Synchronet Git Commit Log

Modified Files:


src/sbbs3/atcodes.cpp
diff

Fix potential buffer overflow and NULL pointer deref in expand_atcodes()

Modified Files:


src/sbbs3/readmsgs.cpp
diff

Don't prompt about *deleted* moderated messages

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: New user option to toggle the message 'replied' character in the
email list. Fix for setting help line colors so that the background won't get
un-done.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch
'dd_msg_reader_msg_replied_char_toggle_and_key_help_line_color_fix' into
'master'

DDMsgReader: New user option to toggle the message 'replied' character in the
email list. Fix for setting help line colors so that the background won't get
un-done.

See merge request main/sbbs!370

Modified Files:


exec/load/ircd/config.js
diff

Squelch log output if in ircdcfg.js

Modified Files:


xtrn/mrc/mrc-display-menu-stats.js
diff

xtrn/mrc/mrc-session.js
diff

MRC minor tweaks & fixes:

Modified Files:


xtrn/mrc/mrc-display-menu-stats.js
diff

xtrn/mrc/mrc-session.js
diff

Merge branch 'mrc' into 'master'

MRC minor tweaks & fixes:

See merge request main/sbbs!369

Modified Files:


exec/mqtt_sub.js
diff

Add -C option to help output

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/websrvr.c
diff

Commonize the <user> logged-in/out log messages among the mail/ftp/web servers

The user name is better to log than the user number. Include user name in
brackets.

Modified Files:


src/sbbs3/websrvr.c
diff

Replace IPv6 colons in access-log filenames with exclaimation marks on Windows

Colons are not legal filename characters on Windows and when virtual hosts are
enabled, the IPv6 address of the server may be used in the access-log filename
so we need to clean that up or errors opening/creating the access-log files
occur.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Option to prompt when deleting a personal email replied to & fixes
for message attributes & vote status display.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_personal_email_delete_after_reply_and_fixes_for_vot
e_status_and_msg_attributes' into 'master'

DDMsgReader: Option to prompt when deleting a personal email replied to & fixes
for message attributes & vote status display.

See merge request main/sbbs!368

Added Files:


xtrn/mrc/chat-with-mrc-stats-example.msg
diff

xtrn/mrc/chat_sec-with-mrc-example.js
diff

xtrn/mrc/mrc-display-menu-stats.js
diff

Modified Files:


xtrn/mrc/mrc-client.js
diff

xtrn/mrc/mrc-connector.js
diff

xtrn/mrc/mrc-session.js
diff

xtrn/mrc/readme.txt
diff

MRC Enhancements: Server Stats & additional tweaks

Added Files:


xtrn/mrc/chat-with-mrc-stats-example.msg
diff

xtrn/mrc/chat_sec-with-mrc-example.js
diff

xtrn/mrc/mrc-display-menu-stats.js
diff

Modified Files:


xtrn/mrc/mrc-client.js
diff

xtrn/mrc/mrc-connector.js
diff

xtrn/mrc/mrc-session.js
diff

xtrn/mrc/readme.txt
diff

Merge branch 'master' into 'master'

MRC Enhancements: Server Stats & additional tweaks

See merge request main/sbbs!367

Modified Files:


exec/load/http.js
diff

Normalized header name may already match what we received.

Modified Files:


exec/load/http.js
diff

Keep original header name alongside normalized for now. We should probably
switch to using a method to read these values and do normalization there.

Modified Files:


webv4/root/api/forum.ssjs
diff

Pass 'answer' query value array instead of first element, submitPollAnswers
expects an array. Fixes #283 presumably.

Modified Files:


exec/load/typeahead.js
diff

Don't crash if you don't got no tree yet. Fixes #546.

Modified Files:


exec/load/http.js
diff

Normalize parsed_headers keys to lowercase.

Fixes #675 (probably).

Modified Files:


src/xpdev/filewrap.h
diff

Add FCLOSE_OPEN_FILE to close a FILE*, if it's open (non-NULL), and NULLify it

Change CLOSE_OPEN_FILE to a do/while(0) to eliminate extraneous semicolon

Modified Files:


src/sbbs3/websrvr.c
diff

A little clean-up around FILE* opening/closing, error handling

"HTTP Logging" replaced in log messages with "Web Server access-logging".

Using new FCLOSE_OPEN_FILE macro to close and NULify open FILE*'s.

Modified Files:


src/sbbs3/websrvr.c
diff

Open SBBS_SSJS.*.html response file(s) only when actually writing data

The first write to a the temporary SBBS_SSJS.*.html file will open the file.
This should reduce the number of 0-byte files left laying around in the the
temp directory, which shouldn't be happening in the first place.

Also:
Fixed bug noticed in temp file clean up loop:  POST data files would *also*
be retained when the DEBUG_SSJS option flag is set.

Also:
Replace some unsafe string operations with safe equivalents.

Happy Thanksgiving Nelgin!

Modified Files:


ctrl/sbbs.ini
diff

Add global TLSErrorLevel, [bbs] SSHErrorLevel, and [mail] TLSErrorLevel

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

src/sbbs3/startup.h
diff

Support configurable max-severity for all SSH-related log messages

Default: Warning

I'm tired of SSH-related errors that I can't do anything about, filling
my error.log file and mail inbox.

Modified Files:


src/sbbs3/js_socket.c
diff

__FUNCTION__ is not a string constant in GCC, so can't do this

error: expected ‘)’ before string constant

Harumph.

Modified Files:


src/sbbs3/sbbs.h
diff

Fix gcc/clang build error

std::atomic's need to be brace-initialized, or else we fail with
"use of deleted function" errors

Odd that MSVC built it just fine.

Modified Files:


src/sbbs3/js_socket.c
diff

Improve JS error reporting

Include function names. Include host:port in "Unable to connect" error.

Modified Files:


src/sbbs3/execmisc.cpp
diff

Fix CID 462292 - possible NULL pointer deref (if realloc fails)

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Fix CID 433237 and other unsafe string copy/concatenations

Modified Files:


src/sbbs3/scfg/scfgchat.c
diff

Fix CID 469127 and 469128 (unused values)

Modified Files:


src/sbbs3/sbbs.h
diff

Fix CID 469129 and 469141 using std::atomic<>

Unlikely, but valid thread-safety concerns by Coverity

Modified Files:


src/sbbs3/getkey.cpp
diff

Fix CID 469138

getkeys() is actually never (currently) called with a NULL arg, so this
could not actually occur, but better to prepare for that eventuality.

This looks like a case of not following the YAGNI principle.

Modified Files:


src/sbbs3/js_rtpool.c
diff

Fix CID 469135

Modified Files:


src/sbbs3/js_global.c
diff

Elaborate in JSDOC string for html_decode()

Add comment/question about the use of JS_SetReservedSlot(), for Deuce

Modified Files:


src/sbbs3/useredit.cpp
diff

Fix CID 32913

getkeys() could return -1 if user disconnects (and SS_ABORT not set), so this
appears to be a valid bug.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Fix CID 465170

Modified Files:


src/sbbs3/scfg/scfgnet.c
diff

Fix CID 174508

And other safety improvements in getsub()

Modified Files:


src/sbbs3/bulkmail.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/email.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mail.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/writemsg.cpp
diff

Support @-code expansion in node messages and short user msgs/telegrams

In response to Nelgin's inquiry:
DigitalMan would it be difficult to add login/logoff date/time to these
messages?
Node  2: xxuserxx logged on Telnet
Node  2: xxuserxx  logged off

Now, you can just use @-codes to add that kind of thing to these text.dat
strings.

Modified Files:


src/sbbs3/websrvr.c
diff

Don't try to send 0-byte files

Saves some opening, reading, and logging, but otherwise was harmeless.

Fix issue #422

Modified Files:


src/sbbs3/js_socket.c
diff

Limit JS Socket TLS error levels to "warning" severity

Ideally, this would use startup.tls_error_level, but which one? And how?

Also, make a TODO comment to fix the fact that all JS Socket log messages
are logged to the terminal server log output. :-(

Modified Files:


xtrn/DDMsgReader/ddmr_cfg.js
diff

ddmr_cfg.js: Fixed the version number to match the current version of
DDMsgReader (1.87)

Modified Files:


xtrn/DDMsgReader/ddmr_cfg.js
diff

Merge branch 'ddmr_cfg_version_187' into 'master'

ddmr_cfg.js: Fixed the version number to match the current version of
DDMsgReader (1.87)

See merge request main/sbbs!366

Modified Files:


xtrn/DDMsgReader/ddmr_cfg.js
diff

ddmr_cfg.js: Added a type check that should fix an 'undefined' error when
formatting option values

Modified Files:


xtrn/DDMsgReader/ddmr_cfg.js
diff

Merge branch 'ddmr_cfg_format_value_undefined_fix' into 'master'

ddmr_cfg.js: Added a type check that should fix an 'undefined' error when
formatting option values

See merge request main/sbbs!365

Modified Files:


exec/load/ircd/config.js
diff

Handle undefined IRC class in [Server]

Modified Files:


xtrn/DDMsgReader/ddmr_cfg.js
diff

Fixed typo in ddmr_cfg causing an error on startup

Modified Files:


xtrn/DDMsgReader/ddmr_cfg.js
diff

Merge branch 'ddmr_cfg_typo_fix' into 'master'

Fixed typo in ddmr_cfg causing an error on startup

See merge request main/sbbs!364

Modified Files:


exec/load/ircd/config.js
diff

Prefer .ini over .conf when loading configs

Added Files:


ctrl/ircd.ini
diff

Removed Files:


ctrl/ircd.conf
diff

Remove legacy ircd.conf, add default ircd.ini

Modified Files:


exec/ircd.js
diff

exec/load/ircd/config.js
diff

More prep for the UIFC cfg editor

Modified Files:


exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

Move things around for the UIFC config editor

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Speed improvements and updates for newscans, and updates for the
indexed newscan menu mode.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch
'dd_msg_reader_speed_improvements_and_newscan_and_indexed_mode_updates' into
'master'

DDMsgReader: Speed improvements and updates for newscans, and updates for the
indexed newscan menu mode.

See merge request main/sbbs!363

Added Files:


exec/load/gettext.js
diff

Modified Files:


exec/default.js
diff

exec/load/shell_lib.js
diff

Start of localization support for JS modules/shells/etc.

Similar to GNU gettext(), by loading gettext.js and enclosing all user-visible
strings in gettext(), a script can get easy/easier support for non-default
(i.e. US-English) locales by loading translated strings from the [JS] section
of ctrl/text.<locale>.ini (if it exists), or customized strings from the [JS]
section of ctrl/text.ini (if it exists).

Results are cached for fast subsequent uses of the same string.

What's *not* supported is different translations (e.g. colorization or
whatever) for the same string used in a different scripts. That could be
added (e.g. use a different section name for script-specific translations),
pretty easily, if desired.

Modified Files:


exec/load/shell_lib.js
diff

Don't load('text.js') - not needed with v3.20

Performance improvement

Modified Files:


exec/default.js
diff

Don't load text.js - no longer needed in v3.20

Modified Files:


src/build/Common.gmake
diff

Disable unknown warning warning on !gcc

Modified Files:


exec/load/ircd/config.js
diff

Fix above commit

Modified Files:


exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

Add GoodResponses= and BadResponses= in [RBL] .ini section

Modified Files:


exec/load/ircd/config.js
diff

Don't allow duplicate H:Lines

Modified Files:


exec/load/ircd/config.js
diff

Fix up auto-connect behaviour a bit

Modified Files:


src/sbbs3/js_console.cpp
diff

Fix g++ warnings in newly added functions

Modified Files:


exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

Make Disabled= and Enabled= work properly in .ini

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/unregistered.js
diff

Check direct match in server names first before wildcards

Modified Files:


exec/load/ircd/unregistered.js
diff

Throw an error if we're about to overwrite a server object

Modified Files:


exec/load/ircd/core.js
diff

Drop mention of ident we don't use

Modified Files:


exec/load/ircd/core.js
diff

Be more verbose about where we've connected to

Modified Files:


exec/load/ircd/core.js
diff

..and don't try to stuff a string into %u

Modified Files:


exec/load/ircd/core.js
diff

Don't show float in port number on STATS C

Modified Files:


exec/user_settings.js
diff

Fix a few text.dat string length checks (oops)

Finish removing the AutoLogonViaIP support from this script

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Log errno description upon QWK pack mutex file creation failure

Modified Files:


src/sbbs3/js_console.cpp
diff

Rename console.crlf() to console.newline(), leaving crlf() as an alias

Also use sbbs_t::newline() as the underlying implementation of
console.newline() rather than a hard-coded CR/LF output loop.

Added new console methods:
	cond_newline() - equivalent of Ctrl-A/
	cond_blankline() - equivlaent of Ctrl-A?
	cond_contline() - equivalent of Ctrl-A\

... so a JS script author doesn't have to output Ctrl-A codes to invoke those
functions.

Modified Files:


src/sbbs3/js_console.cpp
diff

Add console.linefeed() method - for completionism

Seriously though, this doesn't always do the same thing as outputting a '\n'
(e.g. in PETSCII mode, it sends a "cursor down" (17) control character).

Added Files:


install/systemd/httpd.service
diff

Example systemd unit file used to start the Synchronet Web Server separate

... from the other Synchronet servers and services.

For advanced uses/debugging.

Modified Files:


src/sbbs3/sbbscon.c
diff

Easier to over-ride sbbs.ini AutoStart settings via command-line options

To enable a server that's disabled in the sbbs.ini file, just use the <server>+
option (e.g. 't+' to enable the terminal server). To run *only* that server
(and no other servers), use the '<server>!' option (e.g. 'w!' to run *only* the
web server).

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: On start, if console.aborted is true (due to the user pressing
Ctrl-C, etc.), then return -1 to stop a file scan in progress.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_console_aborted_return_negative1' into 'master'

DDFileLister: On start, if console.aborted is true (due to the user pressing
Ctrl-C, etc.), then return -1 to stop a file scan in progress.

See merge request main/sbbs!362

Modified Files:


src/sbbs3/exec.cpp
diff

Only log a single error message when js_execfile() detects a NULL JS Context

js_execxtrn() now returns -1 if a JS context can't be created. This eliminates
redundant error messages from calling js_execfile with a NULL context.

Modified Files:


src/sbbs3/main.cpp
diff

js_init() now logs notice-level messages upon runtime or context creation fail

js_init() failures are now logged with a critical error level (instead of just
"error").

Modified Files:


src/sbbs3/xtrn.cpp
diff

Eliminate unsafe sprintf calls (replaced with snprintf) in *nix build

Modified Files:


exec/noyesbar.js
diff

exec/yesnobar.js
diff

Add support for ^A? sequence in question prompts

Ctrl-A? is a conditional new-line sequence (often used in prompts).

This was a feature in yesnobar/noyesbar.bin and missing in this new JS
port. Oops.

Modified Files:


exec/addfiles.js
diff

Don't use 'undefined' for missing file descriptions

Just a blank string instead.

Modified Files:


exec/login.js
diff

Only call the re-login support functions if re-logging-in

These functions were causing enumeration issues with JSDOC builds (before the
recent refactor that fixes that enumertion order problem), but
really these calls should've been conditional anyway.

Modified Files:


exec/load/ircd/config.js
diff

Allow different passwords for inbound/outbound connects in .ini

Modified Files:


exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

Allow commas in Mask= for .ini configs

Modified Files:


exec/load/ircd/config.js
diff

More sane defaults, and load them first

Modified Files:


exec/load/ircd/core.js
diff

Log outbound initial handshake

Modified Files:


exec/load/ircd/core.js
diff

Add support for /STATS Q

Modified Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/user.js
diff

A bunch of small changes, might fix services

Modified Files:


docs/slyedit_readme.txt
diff

exec/load/dd_lightbar_menu.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


docs/slyedit_readme.txt
diff

exec/load/dd_lightbar_menu.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Indexed mode: Added 'mark all read' for a sub-board with the R
key. Fixed message list colors for messages to the user in the message lists.
Fix for continuous newscan. Fix for DDLIghtbarMenu numbered mode item text in
traditional UI.

Modified Files:


docs/slyedit_readme.txt
diff

exec/load/dd_lightbar_menu.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_indexed_mark_all_read_and_fixes' into 'master'

DDMsgReader: Indexed mode: Added 'mark all read' for a sub-board with the R
key. Fixed message list colors for messages to the user in the message lists.
Fix for continuous newscan. Fix for DDLIghtbarMenu numbered mode item text in
traditional UI.

See merge request main/sbbs!361

Modified Files:


exec/load/ircd/config.js
diff

Allow 0 ConnectFrequency in the .ini

Modified Files:


exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

More .ini stuff

Modified Files:


exec/ircd.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

Comprehensive .ini and multi-RBL support

Modified Files:


exec/load/ircd/core.js
diff

Add some verbosity to outbound connects to aid troubleshooting

Modified Files:


exec/load/ircd/server.js
diff

exec/load/ircd/user.js
diff

Use a better method for server mode synchronization

Modified Files:


exec/jsdocs.js
diff

Updated for v3.20a

Modified Files:


src/sbbs3/textgen.c
diff

Create files in binary mode (on Windows)

We don't need the carriage returns and they cause Git warnings:
warning: in the working copy of 'src/sbbs3/text.h', CRLF will be replaced by LF
the next time Git touches it

Modified Files:


src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_cryptcon.c
diff

Remove CVS comment

Modified Files:


src/sbbs3/js_archive.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_conio.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptkeyset.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_mqtt.c
diff

src/sbbs3/js_msg_area.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_queue.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_uifc.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/js_xtrn_area.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

JSDOC build cleanup (used to generate jsobjs.html)

Replaced _property_ver_list (array of numbers) with _property_ver_list (array
of objects) with a "ver" and (optional) "desc" property. This solves the
enumeration order problem with objects that have both manual and table-based
properties. Object's property tables (arrays of jsSyncPropertySpec) can now
(optionally) contain the property descriptions. For properties defined in this
manner, there will never be another mismatch between ther name/type and
description/version in the jsobjs.html (a problem has re-occurred several
times through the years with nebulous work-arounds).

We still use _property_desc_list arrays for additional (e.g. manually defined)
properties in such objects or just objects that only use one method of
property definition and are not subject to the enumeration order problem.

Fixed numerous typos.

Using more consistent terminology and HTML mark-up.

Some beautification and enhancement of readability, but nothing too major.

Modified Files:


src/sbbs3/sbbs.jsdocs.vcxproj
diff

Updated to build jsdocs with latest dependencies.

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

DD Message Area Chooser: Fix for a copy & paste error - Added the
canViewDeletedMsgs() function

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

Merge branch 'dd_msg_area_chooser_canViewDeletedMsgs' into 'master'

DD Message Area Chooser: Fix for a copy & paste error - Added the
canViewDeletedMsgs() function

See merge request main/sbbs!360

Added Files:


xtrn/DDMsgReader/ddmr_cfg.js
diff

Modified Files:


exec/slyedcfg.js
diff

New: ddmr_cfg.js is a menu-based configurator for Digital Distortion Message
Reader. Also, refactored slyedcfg.js a bit to make it a little simpler.

Added Files:


xtrn/DDMsgReader/ddmr_cfg.js
diff

Modified Files:


exec/slyedcfg.js
diff

Merge branch 'dd_msg_reader_configurator_and_slyedcfg_refactor' into 'master'

New: ddmr_cfg.js is a menu-based configurator for Digital Distortion Message
Reader. Also, refactored slyedcfg.js a bit to make it a little simpler.

See merge request main/sbbs!359

Added Files:


exec/slyedcfg.js
diff

This is a menu-driven configuration program/script for SlyEdit.

Added Files:


exec/slyedcfg.js
diff

Merge branch 'slyedit_configurator_script' into 'master'

This is a menu-driven configuration program/script for SlyEdit.

See merge request main/sbbs!358

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DD Msg Reader: Mark personal email as read if the user is just reading personal
email

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_personal_email_mark_read' into 'master'

DD Msg Reader: Mark personal email as read if the user is just reading personal
email

See merge request main/sbbs!357

Modified Files:


src/sbbs3/mailsrvr.c
diff

Close socket after logging the "REFUSED SESSION from blacklisted server" msg

Fixes issue #670

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Remove unused variable from new function js_load_user_text()

Modified Files:


exec/user_settings.js
diff

Multi-language support and other niceties

The get_lang_count(), get_lang_list(), and get_lang_desc_list() functions are
more or less ported from load_cfg.c. If we ever need these in any other JS
files, they should be moved to a load-lib.

Re-synchronized this code with sbbs_t::maindflts():
- Don't accept keys for settings we didn't display
- Remove support for Auto-Login by IP address (chopping block feature)
- This is even a tad better as a translated (to another language)
  UserDefaultsHdr string (if/when there is one) would be displayed
  immediately upon a new language file being selected

Fixed a bug where the user online's command shell was used as the default
rather than the selected user's command shell (thisuser).

Fixed a bug where 'None' was hard-coded rather than use the text.dat string.

No longer needs/loads text.js (use the hard-coded string IDs in sbbs v3.20)
for a little speed boost.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Multi-language support

New method: bbs.load_user_text() to load/reload user's language file. The
user's select language file (if there is one) is automatically loaded upon
logon to the terminal server, but if the user changes their language
(e.g. via user_settings.js), we needed a way to force re-load of the language
text. This is the way.

bbs.text() now accepts an optional second (bool) argument that if true, will
return a string from the default language strings (in text.dat), and not a
string from any alternate language files (ctrl/text.*.ini) that might've been
loaded. This allows user_settings.js to always get the name of the default
language string (LANG), e.g. "English".

Modified Files:


exec/load/ircd/user.js
diff

Don't ignore MODE when TS is 0

Modified Files:


exec/examples/README.TXT
diff

Remove mention of CVS

Modified Files:


exec/examples/uifc.js
diff

Add an edit list example, with insert/delete/copy/cut/paste support

Enter key does nothing on this example menu (but usually is treated the same
as INSert).

Change help text to multi-line example.

Happy Halloween!

Modified Files:


exec/load/ircd/server.js
diff

Shore up mode synchronization a bit

Added Files:


exec/examples/uifc.js
diff

An example UIFC app that exercises the main methods

Modified Files:


src/sbbs3/js_uifc.c
diff

Update JS docs for uifc methods

The CTX constructor arguments weren't documented

Some blind beautification via HTML tags

Modified Files:


src/sbbs3/js_uifc.c
diff

Document all the parameters to and return value of uifc.input()

Modified Files:


src/sbbs3/js_uifc.c
diff

'prompt' argument missing from uifc.input() JSDOC

Also clarify (or try to clarify) that the maxlen argument is required if you
want to specify any kmode flags.

Modified Files:


exec/msglist.js
diff

Fix for preview mode with narrow terminals

Longer messages would cause the "Preview lines" separator line to wrap.
Chasing 40 column issues is a bit of a rabbit hole, so I think I'll pause
for now.

Modified Files:


exec/msglist.js
diff

Fixes for narrow terminals

In terminals < 80 cols in width, only the message # and "from" field are shown
in listings, so don't show column headings for fields that aren't shown.
Display a '-' in the flag column for deleted messages (that aren't flagged).
Shorten the prompt when listing msgs for terminals narrower than 64 cols
(for phigz). I don't know of any systems/terminals that use 64 cols however.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

dd_lightbar_menu.js: Length off-by-1 fix in substrWithAttrCodes()

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_substrWithAttrCodes_len_fix' into 'master'

dd_lightbar_menu.js: Length off-by-1 fix in substrWithAttrCodes()

See merge request main/sbbs!354

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix in reader mode for refreshing the message area after closing
another window

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_msg_area_refresh_rectangle_fix' into 'master'

DDMsgReader: Fix in reader mode for refreshing the message area after closing
another window

See merge request main/sbbs!355

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

DD Message area chooser: Lightbar mode name collapsing: Ensure the intermediate
subgroup is selected

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

Merge branch 'dd_msg_area_chooser_select_current_subgroup' into 'master'

DD Message area chooser: Lightbar mode name collapsing: Ensure the intermediate
subgroup is selected

See merge request main/sbbs!356

Modified Files:


exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/user.js
diff

Move some stuff around for ini editing

Modified Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

Start of TS and network synchronization refactor

Modified Files:


exec/msglist.js
diff

Make Ctrl-D an alias for DEL (to delete messages)

For terminals that can't easily send a DEL (0x7F) character.
As requested by phigz in IRC.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Extend max language code (user 'lang' property) length from 3 to 8 chars

Ragnarok (DOCKSUD) would like to use lang_COUNTRY for their language files
as  "I use es_AR and is exactly not same to es_ES"

It's trivial to extend the length more if there's a desire to do that.
That's a nice thing about the new (in v3.20) user.tab file format.

Modified Files:


src/build/Common.gmake
diff

Remove legacy comments (e.g. references to CVS)

Modified Files:


src/build/Common.gmake
diff

Disable GCC warning about string truncation

Fix issue #667

I'm not sure why these warnings just started popping up (maybe the inclusion
of string in sbbs.h), but it only seems to happen in debug builds and the
possible truncation is intentional.

Added Files:


exec/noyesbar.js
diff

exec/yesnobar.js
diff

Lightbar confirm/deny Baja mods ported to JS, supporting multi-languages

Really, these should just be loadable modules (not loaded via text.dat
@exec and global variable magic), and merged into a single module, but for
now, this will do.

The old yesnobar.src/bin and noyesbar mods aren't used when these .js files
are in place, unless you have a copy yesnobar/noyesbar.bin in your mods dir.

Modified Files:


ctrl/text.dat
diff

Blank out UserDefaultsHotKey (thanks Nelgin)

And added the other new strings.

Modified Files:


src/sbbs3/sbbs.h
diff

Don't try to include modern C++ headers when building C++ Builder

C++ Builder6 doesn't have unordered_map, so only #include those std C++
headers if/where we actually need them.

Modified Files:


exec/load/text.js
diff

Latest auto-generated text.js

Though, with v3.20, this file isn't strictly needed, at least for new scripts,
you can use bbs.text.[string_id] to get the number associated with a text.dat
string, so bbs.text(bbs.text.Yes) == "Yes" (by default, for English).

Modified Files:


src/sbbs3/sbbs.h
diff

Need explicit include of string header here for G++, wasn't needed for MSVC

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

Cache the text.dat string ID look-ups (mapping from IDs to indexes)

Whoohoo, I'm a reel STL programmerz n0w!

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Personal emails addressed to 'sysop' (or starting with 'sysop')
now marked as read properly

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_emails_to_sysop_as_sysop_marked_as_read' into
'master'

DDMsgReader: Personal emails addressed to 'sysop' (or starting with 'sysop')
now marked as read properly

See merge request main/sbbs!353

Modified Files:


src/sbbs3/str.cpp
diff

Fix g++ compile error (did not appear with MSVC)

error: ISO C++ forbids comparison between pointer and integer

Modified Files:


src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

src/sbbs3/textgen.c
diff

Strip comments from text.dat string IDs (macros)

This fixes the issue with the ContinueQ setting in ctrl/text.??.ini when
attempting to use one of them to replace text.dat strings with localized text.

Modified Files:


src/sbbs3/js_user.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/userfields.h
diff

Initial support or multiple (user-selectable) languages in the terminal server

Uses the new ctrl/text.??.ini files (just a few words translated so far).
Adds the new "lang" user property (to user.tab and JS User class).
The language code is the 2-3 char (e.g. ISO 639-1) abbreviation of a language.
A "blank" language property value (the default), just means to use the
ctrl/text.dat contents.
User-selected alternate language file is loaded upon logon and in the
built-in/hard-coded user default settings menu.
More on the user default settings menu:
- AutoLogin via IP option ('I') to make room for new (I) Language option.
- The cold-keys menu option was removed to make room for Language option
  (via text.dat change to UserDefaultsHotKey)
- Any options disabled via blank text.dat strings will no longer result in
  supported command keys (that could accidentally be struck with hidden
  consequences/effect)
- The user_settings.js will need similar treatment

text/menu/<lang>/* is where alternate language menu files should be stored

New UserDefaultsLanguage text.dat string (inserted before new PasswordChar
string).

Modified Files:


xtrn/ddfilelister/readme.txt
diff

DD File Lister readme: Removed inclusion of "Scan Dirs" in line saying it could
be used for such (it should be used only as the List Files loadable module)

Modified Files:


xtrn/ddfilelister/readme.txt
diff

Merge branch 'dd_file_lister_readme_remove_scan_dirs' into 'master'

DD File Lister readme: Removed inclusion of "Scan Dirs" in line saying it could
be used for such (it should be used only as the List Files loadable module)

See merge request main/sbbs!352

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

DD area choosers: Name collapsing: Fix for incorrect subboard/directory
assignment, and smarter name collapsing behavior

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

Merge branch
'dd_area_choosers_name_collapsing_sub_assignment_fix_and_improvement' into
'master'

DD area choosers: Name collapsing: Fix for incorrect subboard/directory
assignment, and smarter name collapsing behavior

See merge request main/sbbs!351

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for # messages & latest message date in list when changing
sub-board. Should fix #663

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_area_chooser_list_fix_663' into 'master'

DDMsgReader: Fix for # messages & latest message date in list when changing
sub-board. Should fix #663

Closes #663

See merge request main/sbbs!350

Modified Files:


exec/load/ircd/server.js
diff

Assert TS even on non-TS mode

Modified Files:


exec/load/ircd/server.js
diff

Force the topic TS into an integer also

Modified Files:


exec/load/ircd/server.js
diff

Use %lu in TOPIC instead of %d to prevent floating-point problem

Modified Files:


exec/load/ircd/server.js
diff

Fix https://gitlab.synchro.net/main/sbbs/-/issues/650

Modified Files:


exec/load/ircd/server.js
diff

Remove some debugging

Modified Files:


ctrl/text.de.ini
diff

Fix typo

Modified Files:


src/sbbs3/getstats.c
diff

Don't log an error if there's no dsts.ini or dsts.dab file

In a fresh install, neither of these files would exist, and that's normal,
so getstats() should just return true in that case (with the stats struct
zeroed-out).

Fixes error during login to a new install reported by Zoltán Gábor on
Facebook.

Modified Files:


src/sbbs3/echocfg.c
diff

Mark passive (inactive) nodes with an exlamation mark to make them obvious

... in the linked node listing

Modified Files:


xtrn/minesweeper/readme.txt
diff

"syncdata" is not actually the default "sub" value (it's auto-detected)

Add note about not copy/pasting defaults into modopts.ini.

Modified Files:


exec/load/ircd/server.js
diff

Improve empty channel detection a bit and add some more debugging

Modified Files:


exec/load/ircd/server.js
diff

Only relay valid nicks in SJOIN

Modified Files:


exec/load/ircd/server.js
diff

Fix prior commit

Modified Files:


exec/load/ircd/server.js
diff

Detect if SJOIN is empty post-processing

Modified Files:


exec/load/ircd/server.js
diff

Warn if an SJOIN has a bad nick in it

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

DD Msg Area Chooser should now be faster when finding the timestamp of the
latest readable message header

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

Merge branch 'dd_msg_area_chooser_latest_msg_timestamp_speed' into 'master'

DD Msg Area Chooser should now be faster when finding the timestamp of the
latest readable message header

See merge request main/sbbs!349

Modified Files:


src/sexpots/sexpots.c
diff

Implement write-retry in modem_send()

In attempt to address the "Error 11" (EAGAIN) error theat Nelgin sees when
configuring some longer modem init strings on Linux.

This is just a single retry (after a yield) after any modem command char
send failure (for any reason), including the terminating carriage-return.

See issue #662 to details.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

dd_lightbar_menu.js: Fix for substrWithAttrCodes(): If the given length is 0,
then just return an empty string

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_substrWithAttrCodes_len_0' into 'master'

dd_lightbar_menu.js: Fix for substrWithAttrCodes(): If the given length is 0,
then just return an empty string

See merge request main/sbbs!348

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Updated permission functions (speed improvement)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_permission_check_update' into 'master'

DDMsgReader: Updated permission functions (speed improvement)

See merge request main/sbbs!347

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DD Msg Reader: Permission check optimizations

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_permission_check_optimizations' into 'master'

DD Msg Reader: Permission check optimizations

See merge request main/sbbs!346

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Improved new-to-you scan speed (and hopefully overall speed),
indexed newscan improvements, etc.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_speed_and_indexed_newscan_improvements_etc' into
'master'

DDMsgReader: Improved new-to-you scan speed (and hopefully overall speed),
indexed newscan improvements, etc.

Closes #659

See merge request main/sbbs!345

Modified Files:


exec/load/dd_lightbar_menu.js
diff

dd_lightbar_menu.js: Refactored substrWithAttrCodes() to fix issues with it.
Added mechanisms to have additional keys for page-up, page-down, first page
(HOME), and last page (END), similar to the additional quit keys.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch
'dd_lightbar_menu_substrWithAttrCodes_refactor_and_additional_nav_keys' into
'master'

dd_lightbar_menu.js: Refactored substrWithAttrCodes() to fix issues with it.
Added mechanisms to have additional keys for page-up, page-down, first page
(HOME), and last page (END), similar to the additional quit keys.

See merge request main/sbbs!343

Modified Files:


webv4/components/mqtt.xjs
diff

Add a link to the MQTT wiki page

Modified Files:


webv4/components/mqtt.xjs
diff

Merge branch 'Ree/mqtt-wiki-link' into 'master'

Add a link to the MQTT wiki page

See merge request main/sbbs!339

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

DDMsgAreaChooser: Fix for name collapsing mode with the lightbar interface: No
longer gets stuck in a loop when choosing a sub-board. Should fix #658

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

Merge branch 'dd_msg_area_chooser_name_collapsing_loop_fix' into 'master'

DDMsgAreaChooser: Fix for name collapsing mode with the lightbar interface: No
longer gets stuck in a loop when choosing a sub-board. Should fix #658

Closes #658

See merge request main/sbbs!344

Modified Files:


src/build/sdl.props
diff

src/build/sdl2.props
diff

Fix include and library path locations for when the project file is not in
src/*

e.g. src/sbbs3/scfg/scfg.vcxproj

Modified Files:


src/conio/conio_sdl.props
diff

Add "with SDL" to this property sheet name

to differentiate it from the non-SDL version of the conio property sheet

Modified Files:


src/conio/conio_sdl.vcxproj
diff

conio_sdl needs a unique Guid

.. so it can be loaded in the same solution as the conio project

Modified Files:


src/conio/conio_sdl.props
diff

Any program that links with conio_sdl needs winmm.lib too

For waveOutOpen and friend functions

Modified Files:


src/xpdev/xpdev.vcxproj
diff

src/xpdev/xpdev_mt.vcxproj
diff

Add xpbeep to library, needed by conio_sdl

Modified Files:


src/sbbs3/scfg/scfgsrvr.c
diff

Don't hide all the server settings when disabled.

Apparently this was non-intuitive to sysops. <shrug>

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Fix minor help text typo.

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/uedit/uedit.c
diff

Usage help text update: "Win32 native mode" -> "Win32 console mode"

Win32 GDI mode is also native, so let's be more specific.

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Don't read/write or import/export Font "Height" property, redundant with "Size"

Also:
For log message styles (e.g. colorization) based on log level, don't apply
a different font (Name) or size. This just looks terrible when this is done
and I don't think any sysops want that. Keep each log window using the same
font face (name) and size, just allow the color and style (e.g. bold, italics)
to change based on log severity.

This does increase the confusion with the Properties->Customize->Log Fonts
as the "Change Font" dialog still allows the sysop to select/change a font
face and size, they're just not saved/used. I coudln't find a way to remove
or disable these from the displayed TFontDialog form.

Modified Files:


src/sbbs3/ctrl/AboutBoxFormUnit.dfm
diff

src/sbbs3/ctrl/ClientFormUnit.dfm
diff

src/sbbs3/ctrl/ConfigWizardUnit.dfm
diff

src/sbbs3/ctrl/CtrlPathDialogUnit.dfm
diff

src/sbbs3/ctrl/EventsFormUnit.dfm
diff

src/sbbs3/ctrl/FtpCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/FtpFormUnit.dfm
diff

src/sbbs3/ctrl/LoginAttemptsFormUnit.dfm
diff

src/sbbs3/ctrl/MailCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/MailFormUnit.dfm
diff

src/sbbs3/ctrl/MainFormUnit.dfm
diff

src/sbbs3/ctrl/NodeFormUnit.dfm
diff

src/sbbs3/ctrl/PreviewFormUnit.dfm
diff

src/sbbs3/ctrl/PropertiesDlgUnit.dfm
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/ServicesFormUnit.dfm
diff

src/sbbs3/ctrl/SoundCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/SpyFormUnit.dfm
diff

src/sbbs3/ctrl/StatsFormUnit.dfm
diff

src/sbbs3/ctrl/StatsLogFormUnit.dfm
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/TelnetFormUnit.dfm
diff

src/sbbs3/ctrl/TextFileEditUnit.dfm
diff

src/sbbs3/ctrl/UserListFormUnit.dfm
diff

src/sbbs3/ctrl/UserMsgFormUnit.dfm
diff

src/sbbs3/ctrl/WebCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/WebFormUnit.dfm
diff

Fun (not) with fonts

Running SBBSCTRL on Windows 11 with a 4K monitor looked horrible.
The default font sizes varied widely - I'm not sure why this wasn't
apparent before now. And the default font ("MS Sans Serif") is no longer
included in modern Windows versions, so when choosing a Log font, the
pre-selected font was just blank. So change use of "MS Sans Serif"
everywhere to "Microsoft Sans Serif" which appears to have been around since
Win95 and be the preferred alternative. I would consider Segoe, but that
wasn't introduced into Windows until Vista and I'm not sure (yet) what
troubles that might introduce. I'll experiment with a WinXP VM maybe
and find out.

Modified Files:


src/sbbs3/sbbsexec.vcxproj
diff

Need the Windows Kit include dir fix for release build too

Modified Files:


src/sbbs3/sbbsexec.vcxproj
diff

Update the Windows Kit path (with needed NTDDK #include files) to 10.0.22621.0

This is version installed with MSVC 2022

Modified Files:


src/sbbs3/build.bat
diff

src/sexpots/build.bat
diff

src/syncterm/build.bat
diff

src/vdmodem/build.bat
diff

Use the new MSVS 2022 "common tools" environment variable: VS170COMNTOOLS

to find VsMSBuildCmd.bat

This means you can't use MSVS 2019 with this build.bat any longer.

Modified Files:


src/sbbs3/main.cpp
diff

Auto-recycle the term server if/when the ctrl/text.ini file is created/touched

Modified Files:


ctrl/text.dat
diff

Use @-codes for commonly-localized words, some deprecated and new strings

Modified Files:


ctrl/text.de.ini
diff

ctrl/text.es.ini
diff

Updated to include more localized words and metadata (LANG)

Modified Files:


src/sbbs3/chksmb.c
diff

Replace many references to "Message" with "File" when scanning a file base

This could use more cleanup (e.g. instances of "MSGERR:") and in the summary
report there are still mentions of "message" after scanning a file base.

Modified Files:


src/sbbs3/load_cfg.c
diff

Fix off-by-one issue in previous commit, text.dat string numbers are 1-based

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_system.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

Fast text.dat string references, more localization support via JS and @-codes

sbbs_t::mnemonics() now supports @-codes immediately following the tilde
(e.g. ~@Yes@) to use the first character of a dynamically-replaced
(e.g. localized/translated) text string as a command key.
Fixed issue in sbbs_t::mnemonics if multiple @-codes were specified in the
string, but no space characters (just noticed this bug while reviewing).

Created: sbbs_t::expand_atcodes() - used by sbbs_t::mnemonics(), exposed in
JS as bbs.expand_atcodes().

bbs.text and system.text now have properties: each text string ID is the
property name and the text index number (1-based) is the property value -
enabling fast text string lookup without load/require text.js

Constified sbbs_t::atcode() and attrstr() - not too painful

Deprecated YNQP text.dat string in favor of (the first character of)
  "Yes" and "No" text strings and new strings: "Quit", and "PasswordChar"

Other text.dat changes: ListKey->List, AllKey->Unused853
More new text.dat strings: Which, Next, Previous, Language, LANG
Deprecate the "AllKey" text string
Create/use sbbs_t::all_key() - first character of "All" text string

New JS console properties that present common (possibly localized) command
keys: yes_key, no_key, quit_key, all_key, list_key, next_key, prev_key

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/telgate.cpp
diff

Use On/Off text.dat strings instead of (soon to be deprecated) ON/OFF strings

There are other ways to generate forced-upper case expanded @-codes, if that's
what you want.

Fewer duplicates in text.dat make localization, translation to other languages
easier.

Modified Files:


src/sbbs3/load_cfg.c
diff

Allow text strings to be identified by number (instead of ID)

for those that want to use cryptic numbers rather than human-readable names.

Modified Files:


xtrn/wttr.in/locator.js
diff

xtrn/wttr.in/wttr-lib.js
diff

Complete the switch to use system.temp_dir instead of temp_path for WSS

See issue #648 for details.

Modified Files:


exec/chat_sec.js
diff

Use the lower case On and Off text.dat strings

The uppercase ON and OFF are being deprecated

Modified Files:


exec/websocketservice.js
diff

Use system.temp_dir (configurable by sysop) instead of system.temp_path

Fixes issue #648

Modified Files:


src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.vcxproj
diff

Remove the now-unneeded property sheet references

Modified Files:


src/sbbs3/objects.mk
diff

addfiles and delfiles are just little stubs now, simplify dependencies

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

Remove more build dependencies. Adjust warning text a bit.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

Officially deprecate the ADDFILES and DELFILES utilities

These were problematic (crash, could corrupt filebases) and unsupported,
so just change the programs to stubs that alert the sysop that they need to
switch to using the JS versions of these utilities immediately.

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Don't pass all command-line arguments to child programs

Only the common/UIFC-type arguments should be passed-on.

This fixes issue #646

It also appeared that the user editor spawning wouldn't work correctly
when arguments were passed to umonitor (missing a space).

Modified Files:


exec/addfiles.js
diff

Add -readd option to mark any updated existing files as newly-uploaded

Modified Files:


src/sbbs3/load_cfg.vcxproj
diff

Add text_id.c (fixes the current Windows build)

Added Files:


ctrl/text.de.ini
diff

ctrl/text.es.ini
diff

The beginnings of localization of text.dat to Spanish and German

Of course, I'm just guessing using DDG Translate, I don't actually speak
these languages with any fluency, so I could use help from those that do.

These files aren't directly used by anything yet. One could copy or symlink
them to ctrl/text.ini or dynamically load them for certain users (right now,
that'd be done via JS).

Added Files:


exec/replace_text.js
diff

Script that can load additional ctrl/text.*.ini (or .json) text override files

e.g. as a logon script "?replace_text es" would replace strings from
ctrl/text.es.ini (for Spanish translations)

This is not really to be used to load ctrl/text.ini since that is support is
built in (in load_cfg.c) and not necessary to be done in JS.

Modified Files:


src/sbbs3/gtkchat/objects.mk
diff

src/sbbs3/objects.mk
diff

src/sbbs3/scfg/objects.mk
diff

src/sbbs3/uedit/objects.mk
diff

src/sbbs3/umonitor/objects.mk
diff

Include new text_id module in builds

Added Files:


src/sbbs3/text_id.c
diff

I guess we're not auto-generating these textgen'd files on *nix builds

Hm.

Modified Files:


src/sbbs3/answer.cpp
diff

Hyphenate "sign-up" in log message

Modified Files:


src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/str.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/textgen.c
diff

Add support for ctrl/text.ini, used for sysop-override of text.dat strings

The syntax of text.ini is:
<id>: "string"
<id>: "string"

Where <id> is the named identifier of a text.dat string as seen ctrl/text.dat
and string is a literal string value (optionally, in double-quotes). Line
continuations (for long strings) are not supported: you'll just need to put
your string all on one long line (up to 1024 char string).
C-escape characters for control chars and hex-encoded chars are supported.

This should address feature request issue #644

Modified Files:


src/sbbs3/atcodes.cpp
diff

text.dat string IDs can now be used in/as @-codes, directly

The TEXT:<x> @-code can now be used with the text.dat string ID rather than
the text.dat string number, if preferred.

For convenience and brevity, ALL text.dat string IDs are now valid @-codes
(case-sensitive). While this functionality is redundant with the TEXT: @-code
now, if there are any conflicts between new/existing @-codes and text.dat
string IDs, the TEXT: @-code can be used to overcome such conflicts.

This should help with localization (to other languages) by using common
single-word replacements (Which, Quit, Next, etc.) in text.dat strings.

Modified Files:


src/sbbs3/main.cpp
diff

Close node socket after waiting one hour to go inactive to run exclusive event

After 90 minutes of waiting, we'll do the same abort wait (and run the event
anyway), but closing the node's socket should be enough to get the node_thread
to terminate and set the node status back to NODE_WFC.

Apparently some sysops like to leave their terminals idling (e.g. running MRC)
and never disconnect and since they're T-exempt, the BBS won't limit their
time online to allow events to run. Exclusive events will wait for all nodes
to become inactive, but give up after 90 minutes of waiting and run the event
anyway and set node status to WFC at the end. If the node was actually still
connected/in-use, this could lead to the (new) critical error messages logged
"!Node X status is WFC, but the node socket (N) and thread are still in use!"
and other chaos (NODE STATUS FIXUP and the like).

This should prevent all that by just abruptly disconnecting the node after
waiting 60 minutes for the sysop to gracefully disconnect. The log message
when this happens:
"!TIRED of waiting for node N to become inactive (status=X), closing socket Y"

Modified Files:


exec/user_settings.js
diff

Use the word Only from the text.dat (for localization)

Modified Files:


ctrl/text.dat
diff

The ComputerType question/answer strings have been used in decades

Mark them all "UNUSED"

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Add space after numeric value on second line of DOORFILE.SR

This appears to work around a bug in BRE, FE, and TAL where they don't
recognize the "1" (ANSI supported) unless there is at least one other
character on the line following the decimal digit, resulting in the
unnecessary prompting of the user:
  This game is much more enjoyable with ANSI graphics enabled.
  Do you want ANSI Graphics? (Y/n)

As reported by "ben" in IRC.

Modified Files:


src/sbbs3/useredit.cpp
diff

Clear line counter before starting the user settings/config menu.

Fixes unnecessary [Hit a key] prompt.

Modified Files:


exec/user_settings.js
diff

Move the 'Q' hotspot to just *after* the display of the prompt

Fixes issue #645

Modified Files:


exec/user_settings.js
diff

Style update: white-space and parenthesis

Fix-up the require() statements.

Modified Files:


exec/user_settings.js
diff

Fix the 'M' mouse hotspot

Also clear the screen immediately cause it can take a noticable amount
of time to read/parse the file.ini and main.ini files.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/useredit.cpp
diff

Add optional User (Settings) Configuration loadable module

When used, replaces built-in user (e.g. terminal) settings menu with a
loadable (e.g. JS) module.

Modified Files:


exec/load/text.js
diff

New text.dat string (index): None

Modified Files:


exec/user_settings.js
diff

We can't make a copy of 'user', need to create a new User() instance

... or else any changes we make aren't saved (we're just modifying this
object in memory).

Fix the heading (user alias is displayed, not name).

Fix the mouse hot-spots.

Fix the "None" default download protocol (requires latest text.js).

Fix the hot-key option (inverted logic).

Don't display the [K] Command Shell option if there's only one available.

Added Files:


exec/user_settings.js
diff

Clean-up naming, use of global variables, remove text.dat reversion

Modified Files:


exec/user_settings.js
diff

Fix the terminal type display

pass undefined to termdesc.type() when editing current user

Added Files:


exec/default_settings.js
diff

js version of user default

Added Files:


exec/default_settings.js
diff

Merge branch 'nelgin_default_settings' into 'master'

js version of user default

See merge request main/sbbs!331

Modified Files:


exec/init-fidonet.js
diff

exec/load/cfglib.js
diff

Fix "error 13 opening" files when using init-fidonet.js

I finally reproduced this issue myself on a fresh install on Windows.

We needed explicit file closing here as going out of scope doesn't immediately
finalize (and close) a File object. That may not happen until garbage
collection and thus prevent subsequent re-opens of the same files, so always
close() your files.

init-fidonet.js calls install-binkit.js which uses cfglib.js, so that was
a source of these errors too.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

DD MsgReader and SlyVote: Fixed poll voting for single-answer polls

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

Merge branch 'dd_msg_reader_slyvote_single_answer_poll_fix' into 'master'

DD MsgReader and SlyVote: Fixed poll voting for single-answer polls

Closes #642

See merge request main/sbbs!337

Added Files:


webv4/components/sysop-required.xjs
diff

webv4/components/webmonitor/clients-panel.xjs
diff

webv4/components/webmonitor/documentation-panel.xjs
diff

webv4/components/webmonitor/events-panel.xjs
diff

webv4/components/webmonitor/nodes-panel.xjs
diff

webv4/components/webmonitor/quadrant.xjs
diff

webv4/components/webmonitor/recent-visitors-panel.xjs
diff

webv4/components/webmonitor/server-panel.xjs
diff

webv4/components/webmonitor/statistics-panel.xjs
diff

webv4/components/webmonitor/term-configuration-modal.xjs
diff

webv4/pages/More/001-webmonitor.xjs
diff

webv4/root/api/webmonitor/get-term.ssjs
diff

webv4/root/api/webmonitor/update-term.ssjs
diff

webv4/root/js/webmonitor.js
diff

Modified Files:


webv4/components/mqtt.xjs
diff

webv4/lib/auth.js
diff

webv4/pages/More/001-nodespy.xjs
diff

webv4/pages/More/webctrl.ini
diff

webv4/root/js/mqtt.js
diff

webv4/sidebar/002-recent-visitors.xjs
diff

A web-based sbbsctrl implementation

Added Files:


webv4/components/sysop-required.xjs
diff

webv4/components/webmonitor/clients-panel.xjs
diff

webv4/components/webmonitor/documentation-panel.xjs
diff

webv4/components/webmonitor/events-panel.xjs
diff

webv4/components/webmonitor/nodes-panel.xjs
diff

webv4/components/webmonitor/quadrant.xjs
diff

webv4/components/webmonitor/recent-visitors-panel.xjs
diff

webv4/components/webmonitor/server-panel.xjs
diff

webv4/components/webmonitor/statistics-panel.xjs
diff

webv4/components/webmonitor/term-configuration-modal.xjs
diff

webv4/pages/More/001-webmonitor.xjs
diff

webv4/root/api/webmonitor/get-term.ssjs
diff

webv4/root/api/webmonitor/update-term.ssjs
diff

webv4/root/js/webmonitor.js
diff

Modified Files:


webv4/components/mqtt.xjs
diff

webv4/lib/auth.js
diff

webv4/pages/More/001-nodespy.xjs
diff

webv4/pages/More/webctrl.ini
diff

webv4/root/js/mqtt.js
diff

webv4/sidebar/002-recent-visitors.xjs
diff

Merge branch 'Ree/sbbsctrl' into 'master'

A web-based sbbsctrl implementation

See merge request main/sbbs!318

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

DD File Lister: If used as a loadable module and blanked out the NFilesListed
string, then revert NFilesListed on exit of the script

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'dd_file_lister_revert_NFilesListed' into 'master'

DD File Lister: If used as a loadable module and blanked out the NFilesListed
string, then revert NFilesListed on exit of the script

See merge request main/sbbs!336

Modified Files:


src/sbbs3/main.cpp
diff

Log a critical error message if a node is WFC, but its socket is still in use

This should avoid/work-around issue #630

Nelgin's terminal server log indicated that the node's configuration was being
reloaded for a new client connection (which doesn't normally/always happen,
only when there's been a config file change or a node "rerun" requested),
while there was still a user online using that node. This would explain the
segfault (configuration fields being freed and reallocated).

The node_socket[] array indicates when a node thread is actively servicing
a client, so it should contain INVALID_SOCKET for the any node's that WFC.
If it doesn't, that means something/someone changed the node's status value
to 0 (WFC) in the node.dab file while the node was still in-use. Let's not
crash in this case and rather just log the message and give the client the
next available node (if any).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Add more detail (e.g. line number) to various "error opening" log msgs

Some of the errors could be pretty vague since they looked the same and
we were depending on the path/file attempted to be opened in the log msg
to clue us into what exactly was being attempted. But some of these file
paths are sysop-configurable, and they can put unexpected things in there
that make it difficult to determine exactly what file was trying to be
opened and for what purpose. This should help a little bit.

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DD File Lister: Blank out the "# Files Listed" string if used as a loadable
module (optional, defaults to true)

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_blank_NFilesListed_as_loadable_module' into
'master'

DD File Lister: Blank out the "# Files Listed" string if used as a loadable
module (optional, defaults to true)

See merge request main/sbbs!334

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

DD File area chooser: Bug fix for searching with name collapsing

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

Merge branch 'dd_file_area_chooser_name_collapsing_search_fix' into 'master'

DD File area chooser: Bug fix for searching with name collapsing

See merge request main/sbbs!335

Modified Files:


src/sbbs3/con_hi.cpp
diff

src/sbbs3/sbbs.h
diff

The first argument to sbbs_t::uselect() is actually a boolean

Modified Files:


src/sbbs3/js_console.cpp
diff

If console.uselect() is called just with the number argument, use as default

This allows the calling script to control what the default item is (when the
user just hits enter), and not always the first item.

Fixes issue #637

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DD File Lister 'empty directory' fix, help screen pause, filename searching,
etc

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch
'dd_file_lister_exit_code_filename_searching_and_help_screen_pause' into
'master'

DD File Lister 'empty directory' fix, help screen pause, filename searching,
etc

See merge request main/sbbs!333

Added Files:


xtrn/DDAreaChoosers/version_history.txt
diff

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

DD area choosers: Header line display fix

Added Files:


xtrn/DDAreaChoosers/version_history.txt
diff

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

Merge branch 'dd_area_choosers_header_lines_display_fix' into 'master'

DD area choosers: Header line display fix

See merge request main/sbbs!332

Added Files:


exec/load/termdesc.js
diff

Load lib to return descriptive strings for terminal parameters

Much of the logic ported from sbbs_t methods in con_out.cpp

For Nelgin's default_settings.js project

Modified Files:


exec/imapservice.js
diff

Fix error when client supplies invalid Base64 string during auth

IIRC, the error was undefined has no properties or split() is not a function,
something like that.

Modified Files:


exec/imapservice.js
diff

Wrap the body of parse_command() in a try/catch to turn errors into warnings

As requested by Keyop in #synchrob0yyz

Modified Files:


src/sbbs3/scfg/scfgxfr1.c
diff

Remove mention of tbz (tarred-bzip) support

tbz is technically still supported by create_archive(), but without it
being included in the supported_archive_formats definition, isn't easily
chosen as an option and nobody seems to miss it.

Modified Files:


src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upgrade_to_v320.vcxproj
diff

Make output directories unique for these projects

Apparently one was copied from the other and used the same original
output file subdirectory name ("upgrade") oops.

Modified Files:


src/sbbs3/fmsgdump.vcxproj
diff

src/sbbs3/pktdump.vcxproj
diff

Change PlatformToolset from v142 to v141_xp (the latest that supports WinXP)

I didn't notice that these projects were still being built with a toolset
that didn't target WinXP. I might need to update the SDK too.

Modified Files:


src/sbbs3/exec.cpp
diff

Don't decrement user.xedit before calling uselect()

This bug would leave the user's external editor setting decremented by one if
they aborted (with Ctrl-C).

Fixes issue #631

Modified Files:


src/sbbs3/useredit.cpp
diff

Change external editor yes/no prompt default to match current user setting

Also, although not a bug (because we re-read/parse the user's record every
menu cycle), don't decrement user.xedit before calling uselect()
- just not a good practice to not modify variables unnecessarily.
See the corresponding change to exec.cpp, which was a bug.

Added Files:


exec/delmsgs.js
diff

A simple script to delete messages a msgbase

e.g. 'jsexec delmsgs mail from joe-blow'

Modified Files:


exec/load/cfglib.js
diff

Add basic reading main.ini and file.ini (not all sections)

This should be enough for Nelgin to make progress with his user defaults menu
script.

Not all sections are read and parsed and there will be some extra properties
(e.g. "code" in repeated sections that don't normally have that), so the
returned objects aren't (yet) suitable for re-writing back to the *.ini files.

I also cleaned up some of the exceptions (throwing strings rather than Errors)
and removed some empty functions.

Modified Files:


src/sbbs3/main.cpp
diff

Remove redundant timestamp from "End of preexisting log entry" log message

Most logs sysops are looking at already have a date/timestamp for each
message, so this one ended up with 3 date/timestamps in a single line.

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/useredit.cpp
diff

Add new @-code: PROTNAME for full name of default transfer protocol (or None)

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add new @-code: PROT, user's default file transfer protocol (character)

This fixes issue #629

Modified Files:


ctrl/text.dat
diff

Add comma to UserDefaultsRows and new string: None

Modified Files:


src/sbbs3/logon.cpp
diff

A todo comment

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/useredit.cpp
diff

Several new @-codes that can be used to display user's configuration settings

I'll add detailed docs to http://wiki.synchro.net/custom:atcodes soon, but the
list is:

- TERMTYPE
- TERMROWS
- TERMCOLS
- AUTOTERM
- ANSI
- ASCII
- COLOR
- ICE
- RIP
- PETSCII
- SWAPDEL
- UTF8
- MOUSE
- UPAUSE
- SPIN
- PAUSESPIN
- EXPERT
- HOTKEYS
- MSGCLS
- REMSUBS
- FILEDESC
- FILEFLAG
- AUTOHANG
- AUTOLOGON
- QUIET
- ASKNSCAN
- ASKSSCAN
- ANFSCAN
- EDITOR
- SHELL

This should (at least mostly) address the issue #629

Modified Files:


src/sbbs3/mqtt.c
diff

Fix log topic publishing when using MQTT v3

Apparently if you call mosquitto_publish_v5() with a non-NULL properties
pointer, it'll only publish via protocol v5 and doesn't work if you're using
protocol v3 connection.

Thanks Ree.

Modified Files:


src/sbbs3/mqtt.c
diff

Always publish log messages to both .../logs and .../logs/<level> topics

... regardless of the configured MQTT protocol version (v5 or v3.x).

Also include an MQTT v5 user-property ("time") with the message's origination
time/date stamp in ISO-8601 format in all log messages (to both topics).

This will at least double the amount of MQTT log traffic to the broker. When
MQTT v5 is used, the additional user-properties will increase it even a little
more.

Is this what you were suggesting Ree?

Modified Files:


exec/imapservice.js
diff

Wrap the entire search logic in a try/catch statement

This should effectively turn script-terminating errors into just warnings and
thus at least working-around issue #397: the exceptions will be logged as
warnings intead of errors, but still logged.

Modified Files:


src/sbbs3/js_user.c
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/userdat.c
diff

Allow JS 'user.editor' and '.shell' to be set for non-users (e.g. user #0)

The request from Nightfox and Accession via DOVE-Net was to be able to set
a user's external editor even if there's no user logged-in.

These 2 user class properties in the JS object model were a bit special in
that they *only* wrote to the user database and did not immediately modify
the in-memory copy of the user_t structure, depending on the re-reading of
the user.dat/tab file to re-populate the current user_t structure when needed.
This didn't work if the current user is user #0 (no user).

So, set the current user_t.xedit and user_t.shell accordingly whenever those
JS properties are assigned a value (a string, the appropriate internal code).

Modified Files:


src/sbbs3/exec.cpp
diff

Don't call putuserdat if the user number is invalid (not logged in)

This should fix issue #626

Modified Files:


src/sbbs3/mqtt.c
diff

Add ability to send a node message via MQTT (to sbbs/+/node/+/msg topic)

The node message should be terminated with a newline character.

e.g.
$ echo "Hey you" | mosquitto_pub -s -t sbbs/VERT/node/1/msg

I'm considering the ability to send user message (telegrams) via MQTT too.

Modified Files:


exec/websocketservice.js
diff

Add support for binary frames to websocket service

Modified Files:


exec/websocketservice.js
diff

Merge branch 'Ree/websocketservice-support-binary' into 'master'

Add support for binary frames to websocket service

See merge request main/sbbs!330

Modified Files:


exec/load/presence_lib.js
diff

webv4/lib/events/nodelist.js
diff

webv4/root/api/system.ssjs
diff

Update node action display on web

Modified Files:


exec/load/presence_lib.js
diff

webv4/lib/events/nodelist.js
diff

webv4/root/api/system.ssjs
diff

Merge branch 'Ree/nodelist-external-name' into 'master'

Update node action display on web

See merge request main/sbbs!329

Modified Files:


exec/sendmsg.js
diff

Use sysop name instead of user.email if user.number == 0 (run from JSexec)

The reported issue didnt mention JSexec, but I assume that's what was meant
by "from the command line". (?)

I honestly forgot this script even existed. It's using the old deprecated
SMTP SOML command to send a telegram to a user. There are much better ways
to do that for the local system (e.g. calling system.put_telegram), but I
suspect this script existed since before the JS object model had support
for sending user telegrams.

Anyway, this was a simple change to fix issue #623, but really this
script should probably be rewritten or removed from the repo (we use
MSP for sending inter-BBS instant messages these days instead of SMTP/SOML).

Modified Files:


install/systemd/sbbs.service
diff

Change NotifyAccess from "main" to "all"

sd_notify() is called from other threads (PIDs), so we've been getting
syslog warnings abouts this and I hadn't noticed:

systemd[1]: sbbs.service: Got notification message from PID 2555007, but
reception only permitted for main PID which is currently not known

As pointed out by Accession (PHARCYDE) on DOVE-Net.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

Resolve new GCC warnings introduced with addition of new_item()

Just make the list argument a void* and assign to a void** local
var inside the function. No functional changes.

Fixes issue #621

Modified Files:


src/sbbs3/js_socket.c
diff

Fix return value when p->peeked is true

Modified Files:


src/sbbs3/js_socket.c
diff

Merge branch 'Ree/js_socket_recv-fix' into 'master'

Fix return value when p->peeked is true

See merge request main/sbbs!328

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

Update File Options "paste" behavior to use insert-above instead of overwrite

To be more consistent with the paste key behavior elsewhere in SCFG,
make the file options (Viewable Files, Testable Files, Download Events,
Extractable Files, Compressible Files, and Transfer Protocols) menus handle
paste (Ctrl-V, F6) key by inserting the copied or cut item above the current
selection rather than overwriting the current selection.

Fixes issue #616

Modified Files:


exec/websocketservice.js
diff

Speed up file transfers.

Modified Files:


exec/websocketservice.js
diff

Merge branch 'Ree/websocketservice-speedup' into 'master'

Speed up file transfers.

See merge request main/sbbs!327

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Fix for the lightbar interface: When erasing the file info
window, the file date is not shown on a duplicate line if the file date is
already showing in the description area (i.e., for a 1-line file description).
The veresion is now 2.14

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_lightbar_info_description_date_fix' into 'master'

DDFileLister: Fix for the lightbar interface: When erasing the file info
window, the file date is not shown on a duplicate line if the file date is
already showing in the description area (i.e., for a 1-line file description).
The veresion is now 2.14

See merge request main/sbbs!326

Modified Files:


src/odoors/GNUmakefile
diff

Hacks to get ODoors to build on Linux (Debian/Ubuntu recent releases) again

1. Resolve the "hidden symbol 'atexit' ... being referenced by DSO" error
   by using the -shared option (link against shared objects, not static libs)
2. The path to the xpdev output directory (where to find libxpdev.a) is just
   wrong. Hard-coded the machine architecuture portion (.x64) as a hack for
   now. Also, since this is use the LD macro, you need to pass "LD=gcc" on the
   make command-line. Not sure how this worked before.

Fixes (or at least works-around) issues reported by Ryan Fantus (1:218/820)

Modified Files:


src/sbbs3/js_internal.c
diff

Don't use scope argument value to js.exec() if it's null

Fixes issue #611

Modified Files:


xtrn/mrc/mrc-client.js
diff

Fix for js.time_limit stuck at 0

Modified Files:


xtrn/mrc/mrc-client.js
diff

Merge branch 'mrc_fix_time_limit' into 'master'

Fix for js.time_limit stuck at 0

See merge request main/sbbs!325

Modified Files:


xtrn/mrc/mrc-client.js
diff

xtrn/mrc/readme.txt
diff

Fix timeout in mrc client and connector to avoid endless loop issue

Modified Files:


xtrn/mrc/mrc-client.js
diff

xtrn/mrc/readme.txt
diff

Merge branch 'mrc_fix_endless_loop_issue' into 'master'

Fix timeout in mrc client and connector to avoid endless loop issue

See merge request main/sbbs!324

Modified Files:


exec/load/ircd/core.js
diff

Fix https://gitlab.synchro.net/main/sbbs/-/issues/601

Modified Files:


src/sbbs3/node.c
diff

src/sbbs3/nodedefs.h
diff

node utility can now display one/some/all key/values from node*/client.ini

<nelgin> Remind me why you can't show the ip address on node status? :)

Using the new '-v[key]' option, a sysop can view one, some, or all of the
key/value pairs from the nodes with a connected client. For nodes without
a connected client, the client.ini file values aren't particularly useful, but
if someone wants an option to show those values for non-client-connected nodes
I can do that too.

When using '-v', all the client.ini key/value pairs will be displayed for all
the node records requested with currently connected clients. By specifying
'-v[key]' the sysop can specify a key to display (rather than all of them)
e.g. 'node list -vaddr' to list nodes with remote client IP addresses.
This option can be used multiple times on the command-line to view multiple
keys. See node*/client.ini for the list of supported keys.

This feature only works for nodes whose directory paths are ../node#/
relative to the ctrl directory. Since the node utility doesn't read any
configuration files, this is a limitation. If you have different node
directory names/parents and need to use this feature, let me know and I'll
see about adding support for reading/parsing main.ini file to discover those
non-standard/default node directory paths automatically.

The version number displayed is now taken from the sbbs version (sbbsdefs.h).
The maximum ctrl directory path is now extended from 40 chars to MAX_PATH.
More readable help/usage output (using indentation).

Modified Files:


src/sbbs3/mqtt.c
diff

Remove MQTT message publishing from mqtt_connect_callback()

A follow-up to commit 81d4575e

Although I was not able to successfully reproduce the problem that Ree
reported with his commit (even when changing the SCFG->Networks->MQTT->Publish
QOS to 1: At least once) on Windows, I do see how this problem could
theoretically happen. And like Ree said in the follow-up comment on the MR
"maybe these two lines should have stayed in mqtt_startup", they don't really
belong in the connection callback.

The "client" topics only needs to be cleared upon startup or recycle (by
publishing a null message) and it would be bad to clear these topics whenever
the broker was reconnected (the server's clients didn't magically disconnect).
So these "client" topic-clearing publishes are now only done during startup
(again).

The "recycle" topics don't really need to be published to here at all. I
think I only did this for cases where someone published a non-null message to
the topic and its stale message would remain afterward, appearing in MQTT
browsers (like MQTT explorer) long after the server had recycled. The real
solution to this cosmetic issue is to only publish null (0-length) messages to
the "recycle" topics in the first place.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Bug fix for going to a specific message in the message list...

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_list_msg_num_input_fix' into 'master'

DDMsgReader: Bug fix for going to a specific message in the message list...

See merge request main/sbbs!323

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Fix "Error writing /path/to/sbbs.ini" when using '-f' option.

Wasn't opening the sbbs.ini file for modify access.

As reported via DOVE-Net by Accession (PHARCYDE)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: When saving a message on the local BBS PC without all the headers,
the date is now included

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_save_msg_time' into 'master'

DDMsgReader: When saving a message on the local BBS PC without all the headers,
the date is now included

See merge request main/sbbs!322

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DD Message Reader: Including all message headers when saving a message
(sysop...

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_save_all_msg_headers_optional' into 'master'

DD Message Reader: Including all message headers when saving a message
(sysop...

See merge request main/sbbs!319

Modified Files:


src/sbbs3/mqtt.c
diff

Add a connect callback handler.

Modified Files:


src/sbbs3/mqtt.c
diff

Merge branch 'Ree/mqtt-connect-callback' into 'master'

Add a connect callback handler.

See merge request main/sbbs!320

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for "Message header has 'expanded fields'" error when updating
message header attributes in certain conditions

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_update_attributes_expanded_fields_error_fix' into
'master'

DDMsgReader: Fix for "Message header has 'expanded fields'" error when updating
message header attributes in certain conditions

See merge request main/sbbs!317

Modified Files:


exec/mqtt_spy.js
diff

Use console.write() when available for outputting spied content

Defeats local auto-screen-pausing

Fixes issue #603 reported by Nelgin

Modified Files:


src/sbbs3/scfglib2.c
diff

Move reading of each dir's data_dir key into read_dir_defaults_cfg()

This appears to just be a miss from the initial commit (70b835d0) of the
directory default configuration (per lib) feature, so a file
lib's directory default "data dir" wouldn't be read from file.ini.

This fixes issue #602 reported by Nelgin.

Modified Files:


exec/SlyEdit_Misc.js
diff

SlyEdit: More small tweaks for quote line wrapping to determine ideal places to
append a CRLF

Modified Files:


exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_quote_line_wrapping_more_tweaks' into 'master'

SlyEdit: More small tweaks for quote line wrapping to determine ideal places to
append a CRLF

See merge request main/sbbs!316

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Allows kwyeord searching of personal email with command-line
arguments

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_search_personal_email_update' into 'master'

DDMsgReader: Allows kwyeord searching of personal email with command-line
arguments

See merge request main/sbbs!315

Added Files:


webv4/components/mqtt.xjs
diff

webv4/pages/More/001-nodespy.xjs
diff

webv4/root/js/mqtt.js
diff

webv4/root/js/nodespy.js
diff

Removed Files:


webv4/pages/More/002-nodespy.xjs
diff

Refactor the node spy page

Added Files:


webv4/components/mqtt.xjs
diff

webv4/pages/More/001-nodespy.xjs
diff

webv4/root/js/mqtt.js
diff

webv4/root/js/nodespy.js
diff

Removed Files:


webv4/pages/More/002-nodespy.xjs
diff

Merge branch 'Ree/node-spy-2' into 'master'

Refactor the node spy page

See merge request main/sbbs!314

Modified Files:


exec/SlyEdit_Misc.js
diff

SlyEdit: For quote lines, a small tweak for long line (>120 character) adding a
CRLF for paragraph formatting

Modified Files:


exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_long_line_crlf' into 'master'

SlyEdit: For quote lines, a small tweak for long line (>120 character) adding a
CRLF for paragraph formatting

See merge request main/sbbs!313

Modified Files:


docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

SlyEdit: Improvement to paragraph/line breaks in quote line wrapping. The
version is now 1.87

Modified Files:


docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_quote_wrap_paragraph_improvement' into 'master'

SlyEdit: Improvement to paragraph/line breaks in quote line wrapping. The
version is now 1.87

See merge request main/sbbs!312

Added Files:


webv4/pages/More/002-nodespy.xjs
diff

webv4/root/js/utf8_cp437.js
diff

Modified Files:


webv4/lib/pages.js
diff

webv4/pages/More/webctrl.ini
diff

Add a node spy to the web interface

Added Files:


webv4/pages/More/002-nodespy.xjs
diff

webv4/root/js/utf8_cp437.js
diff

Modified Files:


webv4/lib/pages.js
diff

webv4/pages/More/webctrl.ini
diff

Merge branch 'Ree/node-spy' into 'master'

Add a node spy to the web interface

See merge request main/sbbs!308

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Traditional UI - Fixes for qutiting certain actions. Prints
selected actions. Up & down arrow keys.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_traditional_ui_enhancements' into 'master'

DDFileLister: Traditional UI - Fixes for qutiting certain actions. Prints
selected actions. Up & down arrow keys.

See merge request main/sbbs!311

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/defaultTheme.cfg
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

ddfilelister now has its own implementation of a traditional (non-lightbar) UI.
Its version is now 2.12

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/defaultTheme.cfg
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_traditional_ui_implementation' into 'master'

ddfilelister now has its own implementation of a traditional (non-lightbar) UI.
Its version is now 2.12

See merge request main/sbbs!309

Modified Files:


src/sbbs3/mqtt.c
diff

Allow triggering timed event or QWKnet call-out by publishing to MQTT topic

- sbbs/BBSID/exec (publish the timed event's internal code)
- sbbs/BBSID/call (publish the QWKnet hub's ID)

The message contents are not case-sensitive.

Modified Files:


src/sbbs3/mqtt.c
diff

Allow a msg value of "0" to clear/unset the node/+/set/# topics/flags

e.g. publishing "0" to node/#/set/intr will clear the node-interrupt flag.
Any non-zero message value will "set" the flag. Same is true for the
lock, down, and rerun topics/flags.

These node attributes (misc) flags could be cleared previously
by setting the 'misc' topic (e.g. to 0), but since that's not an atomic
read/modify/write operation, other set misc flags could be lost clearing flags
in that manner.

Modified Files:


src/sbbs3/mqtt.c
diff

Prioritize the node/+/input topics over the node/+/set/+ topics

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgchat.c
diff

Fix some signed/unsigned int comparison warnings from MSVC

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Add some helper functions for modifying node records in node.dab, atomically

These should probably be moved (along with other node functions in this file)
to nodedat.* some day.

Modified Files:


src/sbbs3/nodedefs.h
diff

Changes in comments only: copyright header block, typo

Modified Files:


src/sbbs3/mqtt.c
diff

New MQTT topics that the terminal server will subscribe to for node changes

<nelgin> can I push an intr instruction to a node with mqtt?

node/#/set/status - set the node status value (to an integer)
node/#/set/errors - set the node error counter (to an integer, e.g. "0")
node/#/set/misc - set the node's miscellaneous attributes/flags value
 (hexadecimal values can be set by including "0x" prefix)

The message (payload) doesn't matter for the following topics:
node/#/set/lock - lock a node (no one but sysop can login)
node/#/set/intr - interrupt a node (disconnect a user)
node/#/set/down - down a node (not available for connections)
node/#/set/rerun - rerun a node (reload config upon next connection)

Modified Files:


exec/mqtt_pub.js
diff

Fix ReferenceError: options is not defined

Just fall-through to display help output for unrecognized options.

Modified Files:


exec/mqtt_stats.js
diff

Set QOS level to 1 (2 doesn't work?)

Remove unnecessary call to JSON.stringify() in non-JSON mode

Modified Files:


exec/mqtt_pub.js
diff

Add -B and -H options to auto-prefix the topic with BBS or host topic prefix

This allows command-lines to be more cross-platform/host

As requested by Nelgin

Added Files:


exec/mqtt_stats.js
diff

Script to publish statistics (optionally, JSON-encoded) to BBSID/stats topic

Use a timed event and/or execute via jsexec

Nelgin's request/idea

Modified Files:


xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

DD Upload Processor: Scan failure output is now logged to the system log
instead of outputted to the logged-in user

Modified Files:


xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

Merge branch 'ddup_scan_fail_logging' into 'master'

DD Upload Processor: Scan failure output is now logged to the system log
instead of outputted to the logged-in user

See merge request main/sbbs!307

Modified Files:


src/sbbs3/jsexec.c
diff

Insure the exec_dir is *always* prepped (fix for Windows upgrade to v3.20)

A "prepped" means directory means a relative path from the configuration files
(or default settings) has been converted to a full/absolute path with proper
slashes for the platform (i.e. backslashes instead of forward-slashes on
Windows).

JSexec doesn't require that the new v3.20 ctrl/*.ini files exist to run; this
was necessary to be able to run 'jsexec update -> upgrade_to_v320.js' which
does the ctrl/*.cnf to .ini file conversion (egg not required to build
chicken). When JSexec failed to load ctrl/msgs.ini
(e.g. "!ERROR loading configuration files: 2 (No such file or directory)
opening /sbbs/ctrl\msgs.ini"), it would continue to run, but not "prep" any
of the "path" settings (e.g. exec_dir).

The first run of 'jsexec update.js' would fail to run upgrade_to_v320.exe
(which does the v3.20 user base conversion) and a bunch of other (but not as
important) update steps because Windows couldn't execute "../exec/*".

Multiple errors would be displayed in this case, but the most important (as
reported by Ree in #synchronet of irc.synchro.net) was:
  '..' is not recognized as an internal or external command

right after the status output:
  No v3.20 user base found, running ../exec/upgrade_to_v320

Notice the "../exec/" prefix, which is not support by Windows when specifying
a file path to execute.

A second run of 'jsexec update' would work fine because the new v3.20 .ini
files would be successfully created after the first run (though the user base
was not).

This is likely the same issue that MRO reported recently when upgrading a
Windows SBBS v3.19 install to v3.20 and not having the user base upgraded
the first time.

Modified Files:


src/sbbs3/scfg/scfgxfr1.c
diff

Code indentation change only.