Synchronet Git Commit Log

Modified Files:


exec/load/ircd/channel.js
diff

Don't use uninitialized variable

Modified Files:


exec/logon.js
diff

Allow text of all guest information prompts to be overridden in modopts.ini

By setting guest_name, guest_email, guest_location, or guest_referral to any
truthy value, a prompt will be display. By setting it to a string (instead of
true), that string will be displayed. I'm not sure how I feel about this kind
of tri-state setting (true/false/string), but it does reduce the number of
settings/options. The alternative is to have a separate boolean and string
setting for each prompt (which I first considered).

So, as of now:

guest_name = false <- no prompt for Guest's name
guest_name = "" <- no prompt for Guest's name
guest_name = true (the default) <- default prompt text for Guest's name
guest_name = "Enter your name, dude" <- replaces prompt text for Guest's name

For enter trailing white-space and ctrl-a codes, use string literals, e.g.
guest_name: "\x01hEnter your name, dude: "

Modified Files:


exec/logon.js
diff

Guest user prompts can be disabled via modopts.ini [logon] settings

guest_name = false will disable name prompt
guest_email = false will disable the email address prompt
guest_location = false will disable the location prompt
guest_referral = false will disable the "where'd you hear about this BBS"
prompt

Note, at minimum, I do recommend prompting for the guest's email address so
that if they send the sysop feedback (e.g. ask a question), they at least have
some hope of receiving a reply.

Modified Files:


src/sbbs3/mailsrvr.c
diff

When logging sender address forgeries, log the address being forged

Helpful for debugging issues with this forgery detection logic (if there are
any).

Modified Files:


src/sbbs3/useredit.cpp
diff

Stop beeping at the sysop when user-searches are successful.

If anything, I suppose would be beep if a search fails, but really, I think
beeps are kind of annoying these days. Not changing the currently
selected/viewed user is likely all that's really needed to indicate a search
failure.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Don't allow unauthenticated DNS-blacklisted clients to post on subs

Eliminate some of the infrequent SPAM posts to the SYNCPROG conference. Maybe
make this behavior configurable?

Modified Files:


exec/load/ircd/core.js
diff

Don't auto-connect to an invalid port. Reported by nelgin, thanks!

Modified Files:


src/sbbs3/js_msgbase.c
diff

Ignore the PRIVATE message attribute for the "mail" base

When setting the value of a message's 'can_read' property, ignore the PRIVATE
message attribute (which is sometimes set in FTN netmail messages) since it's
assumed all messages in the mail base are private, no special destination (to)
name matching is needed here.

This only popped up recently via msglist.js because of the recent addition of
checking each messages's 'can_read' property.

As reported by <Diehard> via IRC PM.

Modified Files:


exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

Don't auto-connect if no port is defined in C:Line, minor Y:Line changes

Modified Files:


exec/newslink.js
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


exec/newslink.js
diff

Add support for optiona "approved" option to be specify moderator's email addr

Apparently required by some news servers.
As requested via IRC:
<poindexter> Hi all, I've got a weird request. I'd like to post to a newsgroup
that relies on automoderation. You need to add an approved: header to any
posting to have it be accepted - keeps the non-techie riffraff away. is there a
way to do that with newslink.js?

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

Improve server connects (both auto and manual)

Modified Files:


exec/load/ircd/core.js
diff

Use servername when detecting if a server's already there

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

Deal with maxlinks on the Y:Line properly for servers

Modified Files:


exec/load/ircd/server.js
diff

Use integer instead of string in initial TOPIC burst

Modified Files:


exec/msglist.js
diff

Don't list messages that can't be read by user

Should fix unvalidated/moderated message readability bug reported by Phil

Modified Files:


src/sbbs3/websrvr.c
diff

Fix NULL pointer dereference in read_post_data()

What took down cvs/sbbs yesterday:
Program terminated with signal SIGSEGV, Segmentation fault.
6203                    session->req.post_data[session->req.post_len]=0;
[Current thread is 1 (Thread 0x7f2b989ff700 (LWP 17031))]
(gdb) print post_len
No symbol "post_len" in current context.
(gdb) print session->req.post_len
$1 = 0
(gdb) print session->req.post_data
$2 = 0x0

Modified Files:


src/sbbs3/scansubs.cpp
diff

Initialize local variable 'str' in scanallsubs().

Fixes issue #276

Modified Files:


exec/msgutil.js
diff

Don't load() 822header.js unless we're exporting messages

822header.js adds an enumerable method to the header object which ends up in
the output when using the -hdrs option/command.

This addresses issue #277

Note: this is not actually a supported or documented script.

Modified Files:


exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

Fix up STATS m and EVAL

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/user.js
diff

Clean up LIST

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

Make better use of format()

Modified Files:


exec/load/ircd/server.js
diff

Improve TS handling in SJOIN

Modified Files:


exec/load/ircd/server.js
diff

Fix up the server-to-server AKILL message

Modified Files:


exec/load/ircd/server.js
diff

Use correct formatting for printf in NICK

Modified Files:


exec/load/ircd/server.js
diff

Reject malformed NICK messages from servers and notify

Modified Files:


exec/load/ircd/core.js
diff

Fix STATS m to report proper command, found by nelgin, thanks!

Modified Files:


exec/load/ircd/server.js
diff

Use better source of nickname on SJOIN

Modified Files:


exec/load/ircd/user.js
diff

We don't use command anymore, fixes crash on /OPER. Found by nelgin, thanks!

Modified Files:


exec/load/ircd/user.js
diff

Use proper variable on KILL

Modified Files:


ctrl/ircbot.ini
diff

Use a better default hostname for the bot

Modified Files:


exec/ircd.js
diff

exec/load/ircd/core.js
diff

Fix up epoch use in strftime as well

Modified Files:


exec/ircd.js
diff

exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

exec/load/irclib.js
diff

Deprecate time() in favour of new Date()

Modified Files:


exec/load/ircd/server.js
diff

Fix mode desync on server SJOIN. Thanks to Retros for finding where this was
coming from!

Modified Files:


src/sbbs3/file.cpp
diff

Fix memory leak (of extended description) when moving files

Modified Files:


exec/load/ircd/user.js
diff

Fix local KILL (bug reported by phil)

Modified Files:


src/sbbs3/main.cpp
diff

Fix newly-introduced (but likely harmless) bug in mv()

Thanks Coverity! (CID 332340)

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Call smb_freefilemem() instead of smb_msgmem() for files

Not that it really matters, but perhaps it'll matter in the future. And the
code reads better.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

mv() simplified for the non-copy case

Constified function arguments. Source path is still case-insensitive, but
destination is case-sensitive (hopefully that's not an issue).

When a "move" (!copy) is requested, a rename() is always attempted first and if
successful, job done. Otherwise, we continue on with the file-copy (and then
remove).

This should resolve CID 332219 (DEADCODE).

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/upload.cpp
diff

src/smblib/smbdefs.h
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.h
diff

Standardize on "metadata" as the description of a file's "tail" dfield

It's anticipated that this will be used for JS-populated file metadata in JSON
format in the future (and not just "archive contents" in .ini format).

Also, fix the double-free issue that was occurring when moving files with
extended file descriptions (sbbs_t::movefile()). This was actually the primary
problem I was fixing here, but noticed the metadata issue: metadata would not
have been moved along with the other file info between bases.

Modified Files:


src/sbbs3/filedat.c
diff

Include archive_error_string() in archive_write_header failure msg

Hopefully this helps get to the bottom of Ragnarok's reported problem creating
ZIP QWK files with libarchive.

Modified Files:


src/sbbs3/filedat.c
diff

Remove tbz (tarred bzip) files from supported archive list

Not supported by default on Windows and perhaps not on all *nix systems.
You can still support creation of tbz files if you like, but you'll need to
setup an external "Compressible File Type" in SCFG to do it.

Modified Files:


src/sbbs3/pack_qwk.cpp
diff

Better error handling in QWK packet creation

If libarchive creates a 0-byte file or no file at all, then fall-through to the
"temp file command-line" (if there is at least one Compressible File Type
configured).

If libarchive fails, there will still be a (hopefully helpful) error message
logged, but at least the QWK packet may still get created.

Modified Files:


web/lib/msgslib.ssjs
diff

Fix recently-introduced issue reading the 'mail' base.

Reported by AL@TRMB.

Modified Files:


src/sbbs3/main.cpp
diff

Always use rename() on *nix when mv() is called with copy=FALSE

This should fix issue #272 reported by Ragnarok. Not the libarchive error part,
but the second (mv) CopyFile error part.

Modified Files:


web/root/msgs/msg.ssjs
diff

Fail with graceful error message if msgbase is not defined.

Modified Files:


exec/delfiles.js
diff

Don't try to delete offline files when removing from filebase.

Reported by DaiTengu via eye are sea.

Modified Files:


web/lib/msgslib.ssjs
diff

Don't open a message base for an invalid sub-board.

Resolves this errors appearing on Vertrauen where the sub=<code> value appears
to be from some *other* Synchronet BBS:
Unrecognized msgbase code: dove-firearms, Request:
/msgs/msgs.ssjs?msg_sub=dove-firearms

Modified Files:


exec/filelist.js
diff

Remove the unused "-arc" option parsing.

Modified Files:


exec/filelist.js
diff

Add -desc option (include summary/descriptions, same as '-vv')

The -hdr option no longer implies -ext (extended descriptions).

Truncate white-space off end of extended descriptions.

Modified Files:


text/menu/sysxfer.asc
diff

Add DIR command - not sure if/where this was documented before

Update the description of the GET and PUT commands too.

Modified Files:


exec/str_cmds.js
diff

Use K_TRIM mode flag with getstr() through-out.

Modified Files:


exec/tempxfer.js
diff

Allow download of any extracted file

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Detect TLS startup errors correct/fully

We can't (apparently) only rely on the return value of start_tls(), we have to
check the value of the crypt session too.
This fix the possibility of this happening:
Jun  7 18:07:26 sbbs synchronet: ftp  0058 TLS ERROR 'No permiss.to perform
this operation' (-21) opening keyset
Jun  7 18:07:26 sbbs synchronet: ftp  0058 <192.168.1.25> initialized TLS
successfully

Instead, we'll detect the failure and disable FTPS support, logging "failed to
initialize TLS successfully".

Modified Files:


src/sbbs3/scandirs.cpp
diff

Increase the progress() reporting frequency for filename/desc searches

This resolve long delays (while searching for files) without any indication of
progress.

Keep new-scan progress interval at 10 dirs however (they're fast).

Modified Files:


src/sbbs3/con_out.cpp
diff

Condition newline before progress display

Sometimes the progress meter (e.g. during file text searches) appears at a
column offset > 0 and doesn't look good. Fix that.

Modified Files:


src/sbbs3/file.cpp
diff

More use of K_TRIM when prompting for filename/spec

Modified Files:


src/sbbs3/data.cpp
diff

Modernize finduser() a bit

Skip any prepended white-space in the passed name to find.
Use better variable names (and length) for the character strings.
Use matchusername() instead of strcmp(); matchusername() follows the liberal
user-id/alias/name matching algorithm.
Use strcasestr() instead of strstr(), so no copy/modification (upper-casing) of
passed name is now required.
When 'Q'uitting the search, set the SS_ABORT flag.

Modified Files:


src/sbbs3/smbutil.c
diff

Resolved sign/unsigned compare warning

Modified Files:


src/sbbs3/text_defaults.c
diff

EmptyDir and BadFilename string updates

Modified Files:


src/sbbs3/execfunc.cpp
diff

src/sbbs3/upload.cpp
diff

Use K_TRIM getstr() mode when prompting for filenames

Don't need no stinking pre/appended white-space in our filenames!

Modified Files:


text/file.can
diff

Add Windows "reserved names"

For info, see:
https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

Give sysop more control over characters allowed in uploaded filenames

5 options:
- Safest Subset
- Most ASCII, Excluding Spaces (the default)
- Most ASCII, Including Spaces
- Most CP437, Excluding Spaces
- Most CP437, Including Spaces

Modified Files:


text/file.can
diff

Add img001.exe a popular FTP-spread trojan

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/upload.cpp
diff

Include '?' and '*' in ILLEGAL_FILENAME_CHARS definition

Modified Files:


src/xpdev/dirwrap.c
diff

I guess GLOB_PERIOD is Linux or GNU extension. <shrug>

Fix FreeBSD build error:
dirwrap.c:760:13: error: use of undeclared identifier 'GLOB_PERIOD'
Not sure how glob() on FreeBSD treats "dot files" or how to control that.

Modified Files:


ctrl/text.dat
diff

BadFilename is now a format string, EmptyDir uses cond-blankline.

Modified Files:


exec/binkit.js
diff

Don't log an error if after a failure to remove a file, the file doesn't exist

Modified Files:


exec/postfile.js
diff

Set the file cost value to the file size.

Modified Files:


src/xpdev/dirwrap.c
diff

Fix delfiles() to delete files starting with '.' (that match the pattern)

glob() by default, doesn't include 'dot files', so include the GLOB_PERIOD
flag so that when deleting all files in a directory (e.g. node1/temp/*), any
files starting with a dot will be deleted too.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Check batch-uploaded filenames for illegal characters/sequences/names

The BadFilename text.dat is now a format string (prints the bad filename).
Use the nice progress() display status while searching for duplicate filenames.

Modified Files:


src/sbbs3/email.cpp
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/writemsg.cpp
diff

BadFilename text.dat string is now a format string

(prints the bad filename)
- also, checkfname() is going to do the file.can (trashcan) checking, so no
need here

Modified Files:


src/sbbs3/logfile.cpp
diff

src/sbbs3/sbbs.h
diff

A little constification.

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

More uniform safe/illegal/allowed filename (for upload) determination

sbbs_t::checkfname() now checks the file.can too.
new filedat.c functions:
- safest_filename() - not currently used
- illegal_filename() - returns true for a highly-suspicious (e.g. hack attempt)
filename
- allowed_filename() - returns true if the filename is good for upload (assumed
to be already checked to be legal as well).

Importantly, filenames beginning or ending in a '.' are now unallowed:
- 'dot files' are hidden (by default) on *nix
- files ending in a '.' are problematic on Windows

Modified Files:


exec/load/dns.js
diff

Fix parsing of the return code.

This fixes an issue in TypeClass lookups (such as used by reverse())

Modified Files:


src/sbbs3/smbutil.c
diff

Add new commands to flag/unflag all messages for deletion

The command to delete and remove all messages is changed from 'd' to 'D'.
This operation is not reversable.

New commands are 'd' (flag all msgs for deletion) and 'u' (undelete all msgs).

Modified Files:


src/sbbs3/websrvr.c
diff

Remove incorrect and unnecessary comment.

Modified Files:


src/sbbs3/websrvr.c
diff

Don't allow colons in web-requested path names on Windows

This fixes issue #269 (NTFS Alternate Data Stream vulnerability) and other
potential pathname issues on Windows involving colons.

There are other illegal filename characters on Windows (e.g. <>|"?*), but
filenames with these characters aren't expected to pass the later stat() test,
so should fail with a 404 error.

Modified Files:


src/encode/objects.mk
diff

Add new hex object

Modified Files:


src/sbbs3/GNUmakefile
diff

Web server needs encode lib (for hex_decode)

Added Files:


src/encode/hex.c
diff

src/encode/hex.h
diff

Generic hexadecimal encode/decode string functions (e.g. for URL decode)

These functions can be used for "percent encode/decode" or any other
2-hex-digit encoding/decoding with a single escape character.

Modified Files:


src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.vcxproj
diff

Filenames with '+' characters in them could not be served unless encoded

The requested path was being URL-decoded with unescape(), but that function
does a '+' to ' ' (space) conversion.
The '+' to space decoding is supposed to occur for the "query" portion of the
URL only, not the "path" portion.
Use the new hex_decode() function instead of unescape() for "path" decoding.

Modified Files:


src/conio/x_events.c
diff

Avoid directly manipulating XImage data for now.

The previous tests to detect RGB8 appear to have been insufficient.
This may have resulted in various artifacts such as transparency with
some drivers on some hardware in X11 mode.

Modified Files:


src/conio/x_events.c
diff

Remove debug output introduced in last commit

Modified Files:


src/syncterm/syncterm.c
diff

Some Atari (and likely C64) fixes

1) setfont() after loading fonts
2) In X11 mode, don't translate ASCII characters from unicode...
   this was causing non-ASCII characters to be translated twice.

Modified Files:


exec/lbshell.js
diff

Only add accessible programs to the xtrn list

Modified Files:


src/syncterm/syncterm.c
diff

Add CIOLIB_MODE_CURSES_ASCII to output_map

Fixes sourceforce issue number 60.

Reported by WitNik (Thanks!)

Modified Files:


exec/load/irclib.js
diff

Fix integer-to-IP conversion

Modified Files:


exec/load/ircd/core.js
diff

Fix undeclared variable in WHO

Modified Files:


src/sbbs3/tmp_xfer.cpp
diff

Increase file list creation progress report frequency

Cosmetic only.

Modified Files:


src/sbbs3/listfile.cpp
diff

Create (export to text) file lists faster

- Don't read/load extended descriptions
- Don't query each file size (use file cost from database)

Modified Files:


web/root/msgs/msgs.ssjs
diff

Elimniate sysop/logged error when just msgs.ssjs is requested

msgs.ssjs line 6: TypeError: msgbase is undefined

Instead, just display an error to the user/browser (assuming there is one).

Modified Files:


exec/ircd.js
diff

Turns out we need to disable infinite loop detection after all

Modified Files:


web/root/msgs/msg.ssjs
diff

Fix errors when reading msgs posted by users that no longer exist

"msg.ssjs line 42: Error: Error -1 reading user number"

Fixed an errant semicolon in the process. (15 year old minor bug)

Modified Files:


src/sbbs3/listfile.cpp
diff

Beautify the file list files (e.g. NEWFILES.TXT) a bit

Use the file size estimates rather than actual byte values (to keep lines < 80
chars).
Use file name file summary/description is blank or doesn't exist.

Modified Files:


src/sbbs3/tmp_xfer.cpp
diff

File list creation scan progress meter display.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Microsoft doesn't have fchmod(), so use chmod() on the closed file

Modified Files:


src/sbbs3/sbbsecho.c
diff

Keep the same area file (areas.bbs) mode flags (permissions)

When executing area manager requests that alter the area file, the temp area
file created (with mkstemp) had mode 0600 (owner read/write only). The sysop
very possibly had different permission flags they want to keep for their area
file, so copy the mode flags from the original area file to the temp/new area
file.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Don't allow downlinks (AreaFix add) of our "Unknown echoes" sub-board

It was recently pointed out to me that a downlink could link to the '*' echo
via Area Manager (AreaFix) request. This was not intentional.

Modified Files:


exec/archive.js
diff

Since viewable file types support wildcards now, just use '*'

This installs as the last viewable file type, so it just becomes a
fall-through for all file extensions/types and attempts to view them
using the Archive class.

Modified Files:


docs/newfilebase.txt
diff

User to User transfer support was restored and other updates

e.g. DIZ's up to 4000 characters are supported.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/tmp_xfer.cpp
diff

Add optional "temp file transfer" module (defaults to "tempxfer"[.js])

This module (name configurable in SCFG->System->Loadable Modules) replaces the
old hard-coded temp/archive file menu in v3.18 and earlier, going all the way
back to v1a. Good-bye to yet more old and crufty Synchronet C source code. :-/

Change the "Pre Xtrn Prog" and "Post Xtrn Prop" menu option in
SCFG->System->Loadable Modules to just "Pre Xtrn" and "Post Xtrn". The help
text had the wrong names anyway (now fixed).
Save the menu lightbar position in the "Loadable Modules" SCFG menu.

Added Files:


exec/tempxfer.js
diff

A new module to replace the hard-coded temp/archive file menu in v3.18

The last missing file feature in v3.19.

Modified Files:


ctrl/text.dat
diff

More use of conditional blank lines in prompt strings.

Modified Files:


src/sbbs3/text_defaults.c
diff

More use of conditional blank lines in prompt strings.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Add bbs.export_filelist() method

This is the last thing needed to complete the new temp/archive menu module
implemented in JavaScript for v3.19.

File list generation can easily be done in JS (see filelist.js for example),
but since we have this function already in C++ (i.e. for including filelists in
QWK packets) - might as well make it available for use in JS.

Modified Files:


exec/load/ircd/server.js
diff

Fix LINKS

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/user.js
diff

Only purge queue on connection reset. Clean up user QUIT a bit.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

New bbs.view_file(filename) method.

To list/view file/archive contents.

Modified Files:


exec/ircmsg.js
diff

Wait for the correct PING reponse using a random token.

One potential issue here is if you connect/send to irc.synchro.net,
you'l going to get the PONG response back from a different hostname
(e.g. vert.synchro.net), which won't match the expected PONG response.

Modified Files:


exec/ircmsg.js
diff

Send a PING line after message line(s), wait for response.

Is this what you had in mind, Cyan?

Modified Files:


exec/chat_sec.js
diff

Abort menu loop when disconnected.

Modified Files:


exec/load/text.js
diff

Latest new string number definitions.

Modified Files:


src/sbbs3/text_defaults.c
diff

Updated default BatchFlagPrompt

Modified Files:


exec/load/sbbslist_lib.js
diff

Change the max BBS name length from 40 to 30.

40 was causing a lot of cosmetic issues in sbbslist.js (for 80col terminals).
This is a compromise (not reducing to the old limit of 25 chars at least). :-)

Modified Files:


exec/sbbslist.js
diff

Remove storage from the 6th format, was making lines too long for 80cols.

And nobody cares about your terabytes of free space anyway.

Modified Files:


exec/load/ircd/core.js
diff

Don't set properties until we know the object is valid

Modified Files:


ctrl/modopts.ini
diff

Add comment about adding sections/keys if they don't already exist.

Modified Files:


exec/newslink.js
diff

Twitlist optimization (don't re-read over and over)

Also added debug-level log messages for message loop rejection
reasons, for John Dovey (GATOFUEG).

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/viewfile.cpp
diff

Support wildcards in viewable file type extensions (e.g. * and ?)

Now archive.js can be installed as a sort of "fall-through" file viewer (rather
than listing all the supported/possible archive extensions as separately
viewable file-types):
File Extension        *                
Command Line          ?archive list %f 

Modified Files:


exec/load/ircd/core.js
diff

WHOIS now shows if the user is connected via SSL

Modified Files:


ctrl/ipfilter_exempt.cfg
diff

ctrl/text.dat
diff

src/conio/OverhaulNotes.txt
diff

src/conio/bitmap_con.c
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_msgbase.c
diff

src/syncdraw/load.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

src/xpdev/gen_defs.h
diff

Removed Files:



xtrn/sbl/DEPRECATED.TXT
diff

xtrn/sbl/GNUmakefile
diff

xtrn/sbl/Makefile
diff

xtrn/sbl/objects.mk
diff

xtrn/sbl/sbbslist.c
diff

xtrn/sbl/sbl
diff

xtrn/sbl/sbl.bpf
diff

xtrn/sbl/sbl.bpr
diff

xtrn/sbl/sbl.c
diff

xtrn/sbl/sbl.cfg
diff

xtrn/sbl/sbl.doc
diff

xtrn/sbl/sbl.dsp
diff

xtrn/sbl/sbl2smb
diff

xtrn/sbl/sbl2smb.c
diff

xtrn/sbl/sbl2smb.dsp
diff

xtrn/sbl/sbl2txt.c
diff

xtrn/sbl/sbldefs.h
diff

xtrn/sbl/sblpack
diff

xtrn/sbl/sblpack.c
diff

xtrn/sbl/sblpack.dsp
diff

xtrn/sbl/smb2sbl
diff

xtrn/sbl/smb2sbl.c
diff

xtrn/sbl/smb2sbl.dsp
diff

xtrn/sbl/sysop.txt
diff

xtrn/sbl/targets.mk
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


ctrl/ipfilter_exempt.cfg
diff

Add more private IP address ranges to the default filter exemption list

And the IPv4 link local address block (169.254/16) too.

Modified Files:


src/syncdraw/load.c
diff

Treat .msg files the same as .asc when loading.

Removed Files:



xtrn/sbl/DEPRECATED.TXT
diff

xtrn/sbl/GNUmakefile
diff

xtrn/sbl/Makefile
diff

xtrn/sbl/objects.mk
diff

xtrn/sbl/sbbslist.c
diff

xtrn/sbl/sbl
diff

xtrn/sbl/sbl.bpf
diff

xtrn/sbl/sbl.bpr
diff

xtrn/sbl/sbl.c
diff

xtrn/sbl/sbl.cfg
diff

xtrn/sbl/sbl.doc
diff

xtrn/sbl/sbl.dsp
diff

xtrn/sbl/sbl2smb
diff

xtrn/sbl/sbl2smb.c
diff

xtrn/sbl/sbl2smb.dsp
diff

xtrn/sbl/sbl2txt.c
diff

xtrn/sbl/sbldefs.h
diff

xtrn/sbl/sblpack
diff

xtrn/sbl/sblpack.c
diff

xtrn/sbl/sblpack.dsp
diff

xtrn/sbl/smb2sbl
diff

xtrn/sbl/smb2sbl.c
diff

xtrn/sbl/smb2sbl.dsp
diff

xtrn/sbl/sysop.txt
diff

xtrn/sbl/targets.mk
diff

Remove SBL (Synchronet BBS List) - replaced by sbbslist.js years ago

No need to keep this around, someone might try to build or run it!

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Use the screen modes enum, not names array for ini parsing

Any screen mode where the description and the enum value were not
identical (ie: ones with spaces or parenthesis) would not be used
at startup correctly.

Reported by DigitalMan via Discord

Modified Files:


src/sbbs3/js_msgbase.c
diff

Fix mime_version and content_type property names in JSDOCS

Underscores are more JS friendly (and correct).

Modified Files:


src/sbbs3/js_archive.c
diff

Replace la_int64_t with int64_t for rjwboys.

Modified Files:


ctrl/text.dat
diff

Obscure the number of file(s) shown as its non-obvious/helpful

Just include the total files in the listing, not the current display.
Fixes #268.

Modified Files:


src/sbbs3/filedat.c
diff

Use int64_t instead of la_int64_t

Resolve error reported on irc with Ubuntu (don't know what version):
<rjwboys> ok now i get filedat.c:896:3: error: unknown type name
‘la_int64_t’

Modified Files:


src/conio/bitmap_con.c
diff

Default to blocky scaling

For programs that don't specify a scaling type (scfg, syncdraw)
use blocky scaling.

Modified Files:


src/syncterm/syncterm.c
diff

Set the text mode before scaling and size

Setting the scaling and size before changing modes does weird things.
Those things should be fixed, but at least this makes the problem
go away in SyncTERM for now.

Modified Files:


src/conio/OverhaulNotes.txt
diff

13) We need a way to specify the initial mode.

Modified Files:


src/xpdev/gen_defs.h
diff

Character 255 is a non-breaking space in CP437

Now IS_WHITESPACE() will return true for that char and this allows things like
truncsp() to truncate trailing white-space (e.g. from a FILE_ID.DIZ), even if
it contains a terminating 0xFF character for some unknown reason.

Modified Files:


src/sbbs3/file.cpp
diff

Don't abort the file-info edit prompts if no uploader name is entered

Modified Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/server.js
diff

Fix unused/undeclared variables

Modified Files:


src/syncterm/bbslist.c
diff

Set mode by macro, not number

Modified Files:


src/conio/ciolib.h
diff

src/conio/vidmodes.c
diff

src/conio/vidmodes.h
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Add "LCD 80x25" to make DigitalMan less angry

He's old, and should keep his blood pressure down.
Do not walk on his lawn.

Modified Files:


exec/ircd.js
diff

exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

exec/load/irclib.js
diff

text/ircmotd.txt
diff

IRCd 1.9b

Modified Files:


exec/ircd.js
diff

exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

exec/load/irclib.js
diff

text/ircmotd.txt
diff

Merge branch 'master' into 'master'

IRCd 1.9b

See merge request main/sbbs!126

Modified Files:


src/sbbs3/js_internal.c
diff

Fix console and connect events when using select()

Modified Files:


src/xpdev/sockwrap.c
diff

Make inet_ptoaddr() not crash and work with IPv4 address strings

Modified Files:


src/syncterm/bbslist.c
diff

Fix custom mode font size picker

Modified Files:


exec/msglist.js
diff

Perform deleted-msg filtering for all message bases, not just mail

Issue reported by plt2 via IRC.

Added Files:


src/conio/OverhaulNotes.txt
diff

Add notes for CIOLIBng

This is basically just a scratchpad for things I want to have in
the future ciolib.

Added Files:


exec/load/rip.js
diff

Add a new RIP utility library

Currently, this has RIP.supported which returns true if RIP is
supported by the client, and rip.loadicons(archive) which sends
all the icons (and .RIP files) in the specified archive (either
an Arcive object or a filename) to the remote if they don't
already have them.

If you have a RIP enabled door, a small JS script as a pre-run
command like this:

require("rip.js", "RIP");
rip.loadicons('/sbbs/xtrl/lord/lordicns.zip');

Will automatically send all the icon files in the arcive to the
user if the user doesn't already have them.  For SyncTERM as of
this commit, they will be placed in the cache directory for that
BBS (and only be available for that BBS).

On *nix, the cache dir is ~/.syncterm/cache/<bbsname>
On Win32 it's something like: C:\Users\User\AppData\Local\Microsoft\Windows\INe
tCache\SyncTERM\cache\<bbsname>

No ideal what it is on macOS.

Modified Files:


src/syncterm/ripper.c
diff

Fix auto-transfers

Modified Files:


src/syncterm/ripper.c
diff

Send CRLF instead of the specified CR on a file status.

Modified Files:


src/conio/x_events.c
diff

Fix newly-introduced memory leak...

I was going to start keeping the old rect around again, but that
idea didn't pan out.  This massive memory leak is what I get for
not doing more commits while tuning.

Modified Files:


src/syncterm/syncterm.c
diff

Try to remove the extra "SyncTERM" from the BBS cache path on Win32

Reported by Booch (Thanks!)

Modified Files:


src/conio/scale.c
diff

Fix error: ‘stderr’ undeclared (first use in this function)

Modified Files:


src/sbbs3/file.cpp
diff

Have movefile() leave the original file with the delete attribute

This has the effect of the file being listed as absent/deleted in the listing
that's in memory. As requested by Phil, plt via irc.

Moving a file after this change did result in a crash once, but I couldn't
reproduce it with a debugger attached.

Modified Files:


src/conio/bitmap_con.c
diff

Fix bug in last commit

Pixes set via setpixels() were only set in the "blink off" screen
and not in the "blink on" screen... so they all reverse blinked.

Modified Files:


src/build/Common.gmake
diff

src/conio/bitmap_con.c
diff

src/conio/scale.c
diff

src/conio/x_events.c
diff

Optimizations:

1) Keep a rectangle updated per-screen rather than regenerate each time
2) Strip palette info when putting pixels into rectangles rather than
   during scaling
3) Tighten up the screen locks a bit
4) Don't require a full resend of both screens on an update request
5) Only force a redraw for cursor movement when the cursor is visible
   (And force it whenever the cursor changes)
6) Avoid doubles in interpolation
7) Heavily optimize interpolate_height()
   interpolate_width() likely doesn't need it because it's generally not
   used and also it reads from the next pixel in memory making the
   prefetchers job easier.
8) Fix some memory-leak-on-error issues
9) For ARGB8 XImages, manipulate the data directly rather than through
   XPutPixel()

At this point, the scaling and X11 output time is heavily dominated by
cache misses.  The only really effective way to reduce this hit is to
spread the work across all the L3 caches in the system or move it into
the GPU.

With the latest updates, at the SyncTERM menu, over 90% of the time is
spent in the rendering pipeline, and over 90% of that time is spent
thrashing the caches... the only real easy win left is vectorizing, but
that's highly compiler specific.

To that end, I've switched to -O3 for release builds.  There was a comment
that -finline-functions broke Baja "badly", but that's clearly false since
-f-inline-functions has been part of -O2 for quite a while now, and Baja
doesn't seem any more broken that it ever was.

Modified Files:


src/xpdev/filewrap.h
diff

Create a Win32 wrapper for mkstemp() as MSVC doesn't have it

SBBSecho uses mkstemp() now (instead of tempnam()) - so we need this POSIX
function wrapper for Windows builds to succeed.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Replace tempnam() usage with the suggested mkstemp()

Since we're cleaning up warnings... this will break the Windows build for now.

Modified Files:


src/conio/sdl_con.c
diff

src/conio/xbr.c
diff

src/sbbs3/zmodem.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/ooii.c
diff

src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

src/uifc/filepick.c
diff

Fix all GCC warnings in SyncTERM on FreeBSD

Modified Files:


src/conio/GNUmakefile
diff

Don't disable the GCC suggested parenthesis warning here

Modified Files:


src/syncterm/ripper.c
diff

ifdef out an unused static function for now.

It will be used in the future, so the code shouldn't be deleted,
but not using it causes a warning.

Modified Files:


src/conio/xbr.c
diff

Digitalman and Clang agree that order of operations is too hard to
reply on.  Make it harder to merge this code from upstream in the
future instead.

Modified Files:


src/conio/scale.c
diff

Screw it, if the compiler doesn't optimize it, just use more CPU.

At least the warnings are gone.

Modified Files:


src/conio/GNUmakefile
diff

Disable gcc warning about suggested parenthesis

Deuce doesn't want to add "useless parenthesis" to xbr.c.
Hopefully Clang will just ignore this -Wno-* option?
warning: suggest parentheses around ‘&&’ within ‘||’

Modified Files:


src/conio/scale.c
diff

Declare blend() as inline to eliminate gcc warning

warning: always_inline function might not be inlinable [-Wattributes]

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/conio/sdl_con.c
diff

src/sbbs3/umonitor/spyon.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/ripper.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

Add an argument to cterm_end() to not free fonts

While we're doing that, actually use it in SyncTERM so the offline
scrollback retains fonts.

Also, fix an issue where the current mode would be updated with
the custom parameters when you changed them.

Finally, remove some unused variables.

Modified Files:


src/conio/x_events.c
diff

Eliminate unused variable that I guess clang doesn't warn about but gcc does.

Modified Files:


src/syncterm/ripper.c
diff

Use fexistcase() for RIP assets

It seems that at least LORD has upper-case in the ZIPs and lower-case
in the queries.

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/syncterm/ripper.c
diff

src/syncterm/syncterm.c
diff

Add some love for SkyPix

The biggest issue with SkyPix is the fact that it's *not* a character
cell mode.  The cursor is pretty much impossible to position correctly,
and all the text "stuff" basically needs to be bypassed.

Modified Files:


src/syncterm/bbslist.c
diff

Recalculate list height before showing after mode change

Modified Files:


src/uifc/uifc32.c
diff

Draw the shadow if the API bgcolor is blue

WIN_INACT was not getting a border because it changes the value
of bclr which is explicitly compared with BLUE to detect if a
shadow should be drawn.

Instead, draw a shadow any time it would normally be drawn.

Modified Files:


src/conio/x_events.c
diff

No need to resize window just because it moved.

Fixes X11 window dragging blinkiness.

Modified Files:


src/conio/sdlfuncs.c
diff

src/conio/sdlfuncs.h
diff

Fix some return types for SDL functions

Modified Files:


src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

src/syncterm/term.h
diff

Implement upload/download support and use cache dir

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/ripper.h
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.spec
diff

Known bugs are fixed... it's now Beta.

Modified Files:


src/conio/scale.c
diff

On scale fail, but both buffers back in the pool

If do_scale ever failed, it would result in graphics buffers not
returning to the pool, resulting in them never being reused.

Modified Files:


src/conio/sdl_con.c
diff

src/syncterm/menu.c
diff

src/syncterm/term.c
diff

Go back to ALT-Up/Down for speed adjustment

Now that ALT-Up/Down no longer have an effect on window size, they
can go back to their previous bindings of changing the emulated
output speed.

At the same time, remove AltGr support from keysym parsing since it
should be properly handled by the text input stuff now.

Modified Files:


src/syncterm/syncterm.c
diff

Use aspect_fix() not aspect_correct() for initial window size

Caused the initial window to be the wrong size.

Modified Files:


src/conio/vidmodes.c
diff

Switch from "the CTerm palette" to the colodore one

See https://www.pepto.de/projects/colorvic/ for details.

Modified Files:


src/conio/scale.c
diff

src/conio/scale.h
diff

src/conio/sdl_con.c
diff

src/conio/vidmodes.c
diff

src/conio/vidmodes.h
diff

src/conio/x_events.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/ripper.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

Use display aspect ratio, not pixel for tracking.

People are used to thinking about the aspect ratio of displays and
used to not thinking at all about that of pixels.  Most of the modes
are simplt 4:3 modes and the text area is the entire window.  The
only oddball here is the Commodore 64 and 128 40-column modes.
Because they have a border around them that's wider on the sides than
the top/bottom, the display aspect ratio is actually narrower than
a normal NTSC screen (6:5).  It seems the PAL version actually has
square pixels, but nobody has asked for a PAL Commodore mode, and I
think that has a different colour palette too so I'm not doing it.

Just to frustrate DigitalMan a bit, the default custom aspect ratio
is now 4:3 (but can be configured).  At present, modifying the custom
mode while *in* the custom modes "works", which no sane person would
want when adjusting the aspect ratio.

Modified Files:


src/syncterm/term.c
diff

Fix ETA calculation.

Use remaining bytes divided by CPS rather than total estimated time
minus elapsed time.

We squirrley on resumed ZModem downloads.

Modified Files:


src/conio/x_events.c
diff

Add a function to translate event coordinates to screen

Fixes issue 56

Modified Files:


xtrn/sbl/sbl2smb.c
diff

xtrn/sbl/smb2sbl.c
diff

Do the Zombie Shuffle

This is fine.

Modified Files:


src/syncterm/syncterm.c
diff

Sync ciolib_to_screen() with screen_to_ciolib()

Modified Files:


src/conio/vidmodes.c
diff

Fix the 132x43 mode...

Was using the 14 row font with 350 screen rows and expecting 43 lines.

Modified Files:


src/syncterm/bbslist.c
diff

Fix off-by-one error in program settings.

Modified Files:


src/syncterm/bbslist.c
diff

Passing a NULL bar prevents *cur from being off the first screen.

Instead, just set bar to the end and let ulist() sort it out.  It
sucks, but it sucks less.

Modified Files:


src/conio/vidmodes.c
diff

Calculate and plug in pixel aspect ratios.

We're leaving the "Awesome Modes" as 1:1, but the rest all assume
a 4:3 display that is filled by the described text.

Modified Files:


src/conio/sdlfuncs.c
diff

Use xp_dlsym() correctly.

Modified Files:


src/conio/sdl_con.c
diff

src/conio/sdlfuncs.c
diff

Set High DPI Awareness before calling SDL_Init()

Modified Files:


src/conio/sdl_con.c
diff

Use the API to insist SyncTERM is "High DPI aware"

Microsoft wants us to use a manifest for this, but I really don't
feel like digging into however one uses manifest files when not
using the Microsoft build files.

Details here: https://docs.microsoft.com/en-us/windows/win32/hidpi/setting-the-
default-dpi-awareness-for-a-process

Modified Files:


src/conio/sdl_con.c
diff

Specify HighDPI mode when creating a window.

This may solve issue where using Windows "DPI scaling" forces the
window to be scaled.

Modified Files:


ctrl/text.dat
diff

Add EditExtDescriptionQ and removed DeleteExtDescriptionQ

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/writemsg.cpp
diff

Add support for editing extended file descriptions

New text.dat string:
- EditExtDescriptionQ

Removed text.dat string:
DeleteExtDescriptionQ

Modified Files:


src/sbbs3/main.cpp
diff

Fix the printf format for the "ERROR ... connecting to passthru socket"

Was passing the address string twice, so the port appeared as an invalid
number.

Modified Files:


src/sbbs3/logfile.cpp
diff

Log the current Git branch and hash along with every error

This eliminates any ambiguity about what exact version was in use when each
error is logged.

Modified Files:


src/sbbs3/listfile.cpp
diff

Don't attempt to remove files that have already been removed

This is the likely cause of Phil's reported errors when removing files:
access=-110 info=smb_removefile name not found

The only way I was able to reproduce these errors was to attempt to remove the
same file multiple times in the same file listing. In other worse, use 'R',
remove a file, then 'P'revious back to the first file and try to remove it
again. Or to remove it a file from the batch flag prompt and then attempt to
remove it again. <shrug>

Modified Files:


src/sbbs3/main.cpp
diff

Log local address in passthru connection failure

Altere reported via IRC:
!ERROR -1 (113) connecting to passthru socket

It might be helpful to know the address the passthru socket is bound to and the
connection is being attempted on, so log that with the error.

Modified Files:


src/sbbs3/filedat.c
diff

Check return value of fseek() and fstat()

CID 330960, 330967, 330988

Modified Files:


src/sbbs3/filedat.c
diff

Fix typo that caused updatefile() to return false on success

This may have contributed to plt's file editing woes.

Modified Files:


src/sbbs3/file.cpp
diff

Fix potential NULL deref in editfiledesc()

If the file doesn't already have a description, f->desc may be NULL.
Remove the redundant user name in the "removed file" log message.

Modified Files:


src/sbbs3/listfile.cpp
diff

Simplify the file remove/delete logic here.

Modified Files:


src/sbbs3/listfile.cpp
diff

Use correct string for file path when removing file for non dir-ops

Fix issue reported by Jay Crutti.

Modified Files:


src/sbbs3/email.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/writemsg.cpp
diff

Use FOPEN_BUF_SIZE more globally

Modified Files:


src/sbbs3/scfglib1.c
diff

Remove a bunch of old #ifdef/0'd out code

Modified Files:


src/sbbs3/file.cpp
diff

Fix use of uninitialized variable in editfilename()

CID 331582

Modified Files:


3rdp/win32.release/cryptlib/bin/cl32.dll
diff

3rdp/win32.release/cryptlib/bin/cl32.lib
diff

Cryptlib 3.4.5 with the latest patches from Deuce

Modified Files:


src/conio/conio.vcxproj
diff

Fix the new try_x_init() link error

Modified Files:


src/sbbs3/text_defaults.c
diff

Latest text.dat changes.

Modified Files:


src/syncterm/syncterm.c
diff

Blocky scaling is better in my opionion.

Make it the default.

Modified Files:


src/conio/ciolib.c
diff

try_x_init() doesn't need to be guarded by win32 either.

Modified Files:


src/syncterm/ripper.c
diff

Don't guard #pragma

Modified Files:


src/conio/scale.c
diff

src/conio/sdl_con.c
diff

Fix SDL scaling weirdness issues.

Modified Files:


src/conio/scale.c
diff

src/syncterm/ripper.c
diff

Fix for MSVC build using #ifndef _MSC_VER

#pragma clang causes an error
__attribute__ not supported

Modified Files:


src/conio/conio_sdl.vcxproj
diff

Disable X and add new dependent source files

Modified Files:


src/syncterm/SyncTERM.vcxproj
diff

Add new dependent source file: telnets.c

Modified Files:


3rdp/win32.release/cryptlib/include/cryptlib.h
diff

Latest patched cryptlib.h for use with SyncTERM/MSVC build

Modified Files:


src/conio/x_events.c
diff

Fix issue where X11 window would be blank on an Expose event.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/ciolib.h
diff

src/conio/scale.c
diff

src/conio/vidmodes.c
diff

src/conio/vidmodes.h
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Add support for VGA 80x25 mode.

This uses the 720x400 with 9x16 character cell that always made
BBSs look so terrible.

Modified Files:


src/conio/ciolib.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

Prefer X11 mode over SDL mode

I do, so you should too!

Modified Files:


src/conio/x_events.c
diff

Support ALT-Left/ALR-Right for scaling adjustment in X11 mode.

Modified Files:


src/conio/x_events.c
diff

Clear the entire window when the xim size is potentially changed.

This fixes issues where "leftovers" from the previous mode would
remain in a new screen mode.

Modified Files:


src/conio/sdl_con.c
diff

Use lround(), not roundl().

Also, include math.h

Modified Files:


src/conio/curs_cio.c
diff

src/conio/scale.c
diff

src/conio/x_events.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/ripper.c
diff

src/xpdev/strwrap.h
diff

Fix(?) more Windows warnings.

Modified Files:


src/syncterm/bbslist.c
diff

Don't pass -1 as cur or bar.

Sheesh.

Modified Files:


src/conio/GNUmakefile
diff

Bah, gmake.

Modified Files:


src/conio/GNUmakefile
diff

src/conio/objects.mk
diff

scale.o and xbr.o are (basically) required by bitmap now.

Modified Files:


src/conio/sdl_con.c
diff

sdl_con.c can have stdbool.h too.

Modified Files:


src/conio/scale.c
diff

Include the necessary

Modified Files:


src/conio/scale.c
diff

src/conio/sdl_con.c
diff

src/syncterm/syncterm.c
diff

Have SDL use internal scaling when the window size matches.

Simplest way is to use the alt-left/right snapping.

Modified Files:


src/conio/ciolib.h
diff

src/conio/scale.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

Add a new "Blocky Scaling" option to syncterm

Which required a new ciolib option of course.
Only usable in X11 mode at present, though it may land for SDL
this weekend.

Modified Files:


src/conio/scale.c
diff

Make a generic odd pointy scaler.

Since we have all odd numbers thanks to the pointy scaler, and we
have 2x thanks to xBR, we should now be able to build any integer
scaling from a combination of those two scalers.

This, of course, assumes you have enough CPU and RAM to actually
do the scaling you want... powers of two will likely be the worst
case for scaling.

Also, do pointy scaling before xBR.

Modified Files:


src/conio/scale.c
diff

src/conio/scale.h
diff

src/conio/x_events.c
diff

Now that we have scaling sorted out, the X11 driver doesn't need it

Also, we don't need to use pointers for the scaling.

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/inkey.cpp
diff

Fix-ups for the "continuous random tone" sysop chat pager

I haven't played with this chat pager in *years*! The lowest tones were
inaudible (raise the range from 0-800Hz to 400-1200Hz).
Increase the msgabort() tone from 1 to 10ms, sounds like those computerized
voice recognition phone systems now.

Remove the redundant "<user> paged you to chat" notifications (and log message)
when turning *off* the chat pager.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/sbbs.h
diff

Simplify the check-and-clear of console abort status

by adding a 'clear' argument to msgabort() that defaults to false. Pass true to
check-and-clear.
checkline() is a NO-OP, so start eliminating "calls" to it.

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/sbbs.h
diff

Clear the abort flag with the various editfile* functions return false

... upon console abort (Ctrl-C).

Modified Files:


ctrl/text.dat
diff

Make (D)esc command short-cut to just edit file descriptions

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/viewfile.cpp
diff

Make (D)esc command short-cut to just edit file descriptions

Now, just 'E', then 'D' from the batch flag prompt has you editing a file
description - rather than going through all the prompts for uploader name/date,
etc.

Modified Files:


ctrl/text.dat
diff

Add FileInfoEditPrompt string

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/viewfile.cpp
diff

Allow of edit of file info from extended file info prompt

Added text.dat string FileInfoEditPrompt.

Does not allow rename of file from this prompt - perhaps it should?

Resolves issue #263.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/filelist.c
diff

Fix misuse of loadfiles()

Modified Files:


src/conio/scale.c
diff

src/conio/vidmodes.c
diff

Add an untested width interpolater

SyncTERM doesn't support any "fat-pixel" modes.

Modified Files:


src/sbbs3/delfiles.c
diff

Fix ERROR ... removing file from database

Wrong arguments passed to loadfiles() caused only index to be read.

As reported by plt via irc:
ERROR (smb_putmsghdr illegal header length increase: 70 (1 blocks, 0 hfields, 0
dfields) vs 0 (0 blocks)) removing file from database

Also, replace old CVS rev with Git branch and hash.

And for everyone: use delfiles.js instead (e.g. with jsexec).

Modified Files:


src/smblib/smbfile.c
diff

smb_removefile() failed if filename length was > 64 chars

And the "name not found" error text was wrong.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/scale.c
diff

src/conio/scale.h
diff

src/conio/x_events.c
diff

src/conio/xbr.c
diff

Many X11 scaling improvements...

1) Initialize the r2y array for xBR so it actually works.
2) Add a vertical (only) interpolation scaler for aspect ratio enforcement
3) Add a simple muliplier scaler, so that can be removed from x_event.c
4) Use a new graphics buffer free list, which allows tracking last
   drawn screen instead of last bitmap rectangle, removing various hacks
5) Share the Y'CbCr <-> R'dG'dB'd tables between xBR and scale.c

Modified Files:


src/conio/vidmodes.c
diff

src/conio/x_events.c
diff

Align into columns, and add aspect ratios for more modes.

I really need to do a sweep through and update all the aspect
ratios now that the data actually matters.

Modified Files:


src/conio/sdl_con.c
diff

More fallout from non-square pixels...

This fixes all the window adjustment "stuff", but the new aspect
ratio enforcement means that ALT-UP and ALT-DOWN are useless for
resizing the window unless it's not already snapped... use ALT-LEFT
and ALT-RIGHT to decrease/increase the window size.

Modified Files:


src/conio/sdl_con.c
diff

Keep correct aspect ratio when resizing window.

Also, the 8x16 font at 80x25 is *not* a square pixel aspect ratio.
As a result, it now stays "proper", which is likely not what you
want.

This was discovered when I was trying to make DigitalMan happy
because he wanted the apsect ratio retained on scaling.

Sorry for the impending imminent scaling hassle DigitalMan!

Modified Files:


src/sbbs3/js_filebase.c
diff

Don't populate metadata property unless there is metadata 

Or detail level is MAX.

Modified Files:


src/sbbs3/js_filebase.c
diff

The optional JSON-metadata string property is now "metadata"

The old "content" array property goes away.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

Eliminate list_archive_contents()

Do this in JS and use JSON for format instead of .ini.

Modified Files:


src/sbbs3/js_filebase.c
diff

Allow the metadata property to be set with add() and update()

Sorry for the impending imminent merge hassle Deuce!

Added Files:


src/conio/hqx.c
diff

src/conio/hqx.h
diff

src/conio/scale.c
diff

src/conio/scale.h
diff

src/conio/xbr.c
diff

src/conio/xbr.h
diff

Modified Files:


src/conio/GNUmakefile
diff

src/conio/objects.mk
diff

src/conio/x_events.c
diff

Add smooth scaling to X11 output

Uses "pointyscale" for x3 and x5
Uses xBR from FFmpeg for x2 and x4
HQx is also included, but unused as it's too slow at x4.

Modified Files:


src/sbbs3/main.cpp
diff

Attempt to resolve "!ERROR 11 receiving from socket" reported by plt

<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> append key into
keybuf: 4E (N)
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> Executing external:
/sbbs/exec/sexyz 14 -Telnet sz /mnt/disk1/dl/COCO/AGI/agi-xmas.zip
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: Synchronet
External X/Y/ZMODEM  v3.0  master/23b741a1c  Copyright Rob Swindell
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File skipped
by receiver
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File Skipped
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !0 Aborting
Transfer (Sending ZABORT)
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 !ERROR 11 receiving from
socket 14
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 input thread terminated
(received 365 bytes in 35 blocks)

Not sure why this isn't happening for other sysops - perhaps plt was spying on
the node?

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

Remove the archive contents in SMB file "tail" thing

This was really slowing down the upgrade_to_v319 and there's no current
consumer of the data.

Consider adding back in JSON format later or just leave it to JS things to use
for JSON-formatted metadata.

Modified Files:


src/smblib/smbfile.c
diff

Fix crash in smb_addfile_withlist() when passed a non-NULL empty list

Don't allocate and memset a buffer of -1:
#1  0x0000559222bc167f in strListCombine (list=0x559224220720,
buf=0x559224226550 "", maxlen=18446744073709551615,
    delimit=0x559222bcce0a "\r\n") at str_list.c:447
447             memset(buf, 0, maxlen);
(gdb) print maxlen
$1 = 18446744073709551615
(gdb) up
#2  0x0000559222ba3841 in smb_addfile_withlist (smb=0x7ffce63a7e90,
file=0x7ffce63a5bc0, storage=1, extdesc=0x0,
    list=0x559224220720, path=0x7ffce63a6e80 "/xfer/loons/manhater.mp3") at
smbfile.c:365
365                     strListCombine(list, content, size - 1, "\r\n");
(gdb) print list
$2 = (str_list_t) 0x559224220720
(gdb) print list[0]
$3 = 0x0

Found/reported by plt via irc. Thanks!

Modified Files:


src/sbbs3/filedat.c
diff

Speed up list_archive_contents()

Don't use iniSet* since we know we're not updating existing ini entries. Use
strListAppendFormat() instead.

Modified Files:


src/syncterm/ripper.c
diff

Fix angle calculations on Win32

Do multiple before divide, and use an lround() to get the same results
on Win32 with mingw32 as Clang on FreeBSD.

Modified Files:


src/syncterm/conn.c
diff

Put the kbhit() check back into the connect loop

Was removed along with select() in e2094fb95

Modified Files:


src/sbbs3/smbutil.c
diff

Fix issue with the import message commands introduced in previous commit

The fread() usage here did not need "addressing" (Commit 1b56dc96).

This caused messages posted via smbutil to be short (e.g. 0 or 1 bytes
in length). Reported by Accession via Idle Relay Chat.

Also, don't call strlen() on msgtxt which could be NULL, causing segfault
in final printf() callin in postmsg().

Modified Files:


src/syncterm/ripper.c
diff

Add extended comment on do_fill() and why it's terrible.

Modified Files:


src/syncterm/ripper.c
diff

Draw the ellipse pixel when the angle is equal to start/end as well

Being stritly less/greater causes a one pixel gap at the start/end
of the ellipse, meaning flood fills can escape.

Modified Files:


src/conio/bitmap_con.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/ripper.c
diff

Numerous changes:

Clamp coordinate translation max
Fill using native pattern, not scaled pattern
Add a bad, broken, and slow even/odd fill
Fix logging when RIP is enabled
Use the same ellipse algorithm for partial as full ellipses
Detect diagonal movement in ellipse drawing and don't make the edge fat
Only recurse once in the flood fill
Implement the v2 poly bezier command
Enable filled pie slices
Add RIP_POINT command (basically a scaled pixel using line width)

Modified Files:


exec/tickit.js
diff

Don't allow duplicate extended and normal descriptions

If the extended description and the normal (short) description are the same,
delete the extended (long) description.

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

Add option to control whether area-linked nodes must be configured

This should address issue # 261.
Before April 19, 2016, area-linked nodes were required to be listed as nodes in
sbbsecho.ini:
http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/sbbsecho.c?revision=3.6&vi
ew=markup
I'm not sure why the change was made to only require that there be a wildmatch
for each area-linked node. So just make it a configuration option. <shrug>

Also removed the trailing "..." for every top level menu item in echocfg.

Modified Files:


src/sbbs3/listfile.cpp
diff

Make it a conditional *blank* line before the batch flag prompt

It's very tricky to defeat the auto-pause to have your own custom prompt at
rows-1. So going back to having  a blank line before the batch prompt.

Modified Files:


src/sbbs3/listfile.cpp
diff

Change CRLF before batch flag prompt to a conditional new-line.

If a sysop wants a *blank* line before the batch flag prompt, they can put that
(or a conditional blank line, even better) in their text.dat (BatchFlagPrompt).
For now, I'm thinking no blank line before the prompt is better use of the
screen.

Modified Files:


src/syncterm/ripper.c
diff

More improvements...

Consistently use map_rip_color()
Optimize flood fill to not clobber the stack
Fix small full ellipses to match RIPTerm 1.54

Modified Files:


src/syncterm/ripper.c
diff

Fix palette calculations, and add support for RIPv2 'b' command.

Modified Files:


src/sbbs3/filedat.c
diff

Don't sort the keys in the content sections of a file.

Modified Files:


src/sbbs3/text_defaults.c
diff

A couple additional [P]revious commands when list/viewing files

Modified Files:


ctrl/text.dat
diff

A couple additional [P]revious commands when list/viewing files

Modified Files:


src/sbbs3/sbbs_ini.c
diff

sbbs_write_ini() called with a NULL global pointer could have crashed

as get_ini_globals() will de-ref the 'interfaces' element. CID 331352

Modified Files:


src/xpdev/ini_file.c
diff

Fix  a couple of resource leaks in iniSortSections()

One in an error path (CID 331353), the other not.

Modified Files:


src/conio/x_events.c
diff

Optimize pixel calculations.

Modified Files:


src/syncterm/ripper.c
diff

Make some changes

Mostly tightening things up and fixed some text things.

Modified Files:


src/xpdev/ini_file.c
diff

Remove unused variable added in previous commit.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

Sort stored file (archive) contents, for later comparison purposes

Some archives contain exactly the same files as others, but in a different
order. Believe it or not.

Modified Files:


src/xpdev/str_list.c
diff

NULL pointer checks in strListSort*() and strListDup()

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Add iniSortSections() which can sort a read ini list and optionally keys

This also exposed problems with the find_section() utility function: when the
"found" section was actually empty and the next immediate line in the ini file
was the beginning of a new section, the "keys" indexed would actually be the
next section. Now fixed.

Modified Files:


src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/syncterm/ripper.c
diff

Vectorize beziers

Modified Files:


src/sbbs3/listfile.cpp
diff

Previous file support from the [R]emove and [D]ownload commands.

More support for moving backwards through file searches/listing types.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

Fix issues with file header fields getting repeated (cloned)

e.g. when using the JS FileBase.update() method

Modified Files:


src/smblib/smblib.c
diff

When adding a msg/file header, remove the DELETE attribute

When moving or renewing files, they're first removed and then added and they
were being added with the DELETE attribute set. The filenames are displayed in
red when staged for deletion/removal, so that's how I noticed. Oops.

Modified Files:


text/menu/wwiv/main.asc
diff

text/menu/wwiv/transfer.asc
diff

Insert conditional-newlines (Ctrl-A/) to force line-wraps on >80 col terminals

Apparently these menu files were created exactly 80 columns wide. <shrug>

This fixes issue 257 reported by Keyop.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/syncterm/ripper.c
diff

Optimize color_value() and fix RIP reset

color_value() is in the hot drawing path, so should be as fast
as possible... remove all the bit shifting and have the palette
just be colour values.

For RIP, the reset wasn't resetting the global coordinates, so a
scaled image would cause everything to be scaled down later.

Modified Files:


src/syncterm/ripper.c
diff

Add save/resotore mouse fields commands.

Used extensively on Black Flag BBS.

Modified Files:


src/sbbs3/js_filebase.c
diff

Add a 'readd_always' option to the update() method

This will cause archive file contents to be re-captured/added

Modified Files:


src/sbbs3/js_filebase.c
diff

JSDOC updates

Finally document the file-meta-object properties now that things are
solidifying.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

Store contents (list) of archive files in filebase (in the "msg tail")

This will allow fast/easy display of archive contents without actually reading
the archive files.

Introduces some new functions:
- list_archive_contents()
- smb_adddfile_withlist()

A new SMB convenience variable ("tail", aliased as "content" for a file).
A new file detail level ("file_detail_content", exposed in JS as
FileBase.DETAIL.CONTENTS) which adds a "content" array property to file
metadata objects for JS FileBase.get().

Files already added to the new filebases won't have this archive content
automatically - I'm looking into that now (likely a new or updated JS script to
run).

Modified Files:


src/syncterm/ripper.c
diff

Some optimizations and clearing realloc()ed data.

Modified Files:


src/syncterm/ripper.c
diff

Fix merge issue.

Modified Files:


src/conio/bitmap_con.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/ripper.c
diff

src/syncterm/rlogin.c
diff

src/syncterm/term.c
diff

More RIPv3 stuff, make it an option.

The option basically controls forced EGA mode and reported terminal.

Modified Files:


src/syncterm/ripper.c
diff

Implement disabled text for RIP.

We still need to pass ANSI through to the parser though because
Synchronet goes apeshit if it doesn't get a response to a location
request... it tries twice and eats any data it receives that isn't
a valid position report, which obviously breaks menus.

It's also very weird that on Booch's BBS at least it's sent during
the main menu display rather than just on answering.  Not sure why
this is, but it means we can't implement the RIP requirement of
"ignoring all non-RIPscrip bytes" with a zero window without digging
deep into Synchronet guts.

Modified Files:


src/conio/bitmap_con.c
diff

src/syncterm/ripper.c
diff

src/xpdev/xpbeep.c
diff

More improvements for Black Flag...

Pretend we are RipTel v3.
Implement $PCB$
Implement click actions
Fix M areas.

Modified Files:


src/syncterm/ripper.c
diff

Remove debug, optimize

Generate conversion tables rather than do float math twice for each
virtual pixel.

Modified Files:


src/syncterm/ripper.c
diff

Start of minimal RIPv2 support.

Just the easy stuff (scaling, extended colours, border toggle, filled
rectangle)

Modified Files:


exec/load/dns.js
diff

Fix DNS response flag parsing.

Modified Files:


src/sbbs3/listfile.cpp
diff

Search of word in descriptions should match filenames too.

Especially now that now all files even have descriptions (e.g. when super long
filenames suffice).

Modified Files:


src/sbbs3/sbbsecho.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/str_util.c
diff

Add a separate "area tag" string configured per sub-board

According to  Lupine Furmen (FURFOL):
It says in the help that the field is used for both the Newsgroup name AND the
Fido Echo-tag.

These really should be 2 different fields.

Now, the echo/area tag is usually configured in the area file (areas.bbs) and
so does not need to match *any* string configured in SCFG. But since an area
file *can* be generated from SCFG (Export Areas option) and its possible to use
SBBSecho withOUT an area file at all, then it's possible someone would like to
have their FidoNet-style area tags configured different from any other strings
related to a sub-board (e.g. newsgroup name) - why? I'm not clear, but there it
is: another string that  a sysop can set (or not).

Since I'd recently added an area tag field per directory for use by hatchit.js,
this does create some logical symmetry. And there were enough free bytes
per-sub in the msgs.cnf, so why not.

Modified Files:


src/sbbs3/file.cpp
diff

Fix error when moving files

e.g. file.cpp line 239 (removefile) removing "filename.zip" access=-203
info=smb_freemsgdat reading allocation record at offset 1108

Also, if there is an error removing the original file from the filebase, don't
proceed to move the actual file (and log a successful move).

Modified Files:


src/sbbs3/listfile.cpp
diff

When toggling extended file descriptions with the 'T' command, save user

Save the user's "misc" flags to the userbase when they use the 'T' command from
the batch flagging prompt. Without this change, the option would automatically
revert if/when the user record was re-read (which can happen at any time).

Modified Files:


webv4/pages/002-files.xjs
diff

Fix the "undefined" display when a file has no description.

Modified Files:


webv4/root/api/files.ssjs
diff

Fix downloaded filenames in v3.19

Files were being downloaded as undefined.undefined because I didn't emulate
the old 'base' and 'ext' properties - just use a single 'name' property now.

Modified Files:


webv4/pages/002-files.xjs
diff

Use html_encode() for extended descriptions with Ctrl-A codes too.

Synchronet v3.19 now converts ANSI-encoded DIZs to Ctrl-A format upon import.

Modified Files:


src/sbbs3/js_global.c
diff

Add support for conditional new-line Ctrl-A code (/) in html_encode()

Modified Files:


webv4/lib/files.js
diff

Fix count_files() for v3.19 compatibility.

Modified Files:


ctrl/attr.cfg
diff

Change default file description color from darkgreen to lightgray.

Modified Files:


src/sbbs3/addfiles.c
diff

Close stream on error.

Fixes CID 33498

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix double close (fnopen doesn't leave the descriptor open)

Fixes CID 33724.

Modified Files:


src/sbbs3/chksmb.c
diff

Always report the total LZH compressed messages

This looks like a 20-year-old copy/paste bug. CID 33168.

Modified Files:


src/sbbs3/qwknodes.c
diff

Pass msg struct by pointer, not value

CID 33320 and 333321

Modified Files:


src/sbbs3/userdat.c
diff

Get rid of an unnecessary strcat() call

CID 33567

Modified Files:


src/sbbs3/file.cpp
diff

Consolidate the uploader security info (host/ip/prot) on one line

Modified Files:


src/sbbs3/listfile.cpp
diff

Don't display batch flag with same color as description.

Display the batch flag letter with the same color as the filename, but inverted
intensity. The batch flag shouldn't stand-out (be bright) anyway, but the main
reason is because I'm changing the default file description attribute to be
lightgray instead of dark green.

Modified Files:


text/menu/batflag.msg
diff

Add [T]oggle short/extended file description command

And use "Operator" rather than "Sysop" for operator commands.

Modified Files:


src/sbbs3/listfile.cpp
diff

The 'T' command key at the batch flag now toggle extended file descriptions

This is pretty convenient and handy (rather than having to use &E or the
equivalent command from the file xfer menu and then re-list files).

Modified Files:


src/sbbs3/GNUmakefile
diff

use $^ instead of $? for the prereqs for the ans2asc link command

Fixes the link failure when sauce.o didn't need to be rebuilt.

Modified Files:


exec/load/sbbsdefs.js
diff

Resynchronize with sbbsdefs.h, adding and removing consts

Modified Files:


exec/load/userdefs.js
diff

Resynchronize with sbbsdefs.h

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Remove some unused/obsolete macros.

Modified Files:


src/sbbs3/sauce.c
diff

Maybe address Coverity issue.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/sbbs.h
diff

Use reference rather than pointer to make putmsgfrag() more readable.

Modified Files:


src/sbbs3/filedat.c
diff

Address Coverity defects.

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/listfile.cpp
diff

Show removed files in error color (red).

Modified Files:


exec/load/text.js
diff

Add FiAuthor and FiGroup

Modified Files:


exec/dupefind.js
diff

Support find/remove of duplicates based on archive contents

Duplicate archives (e.g. ZIP files) often have the different digest/hash/CRC
values because they have a different ZIP comment or the files were archived
in a different order or used different compression schemes. You can now detect
(and delete) these duplicates.

Modified Files:


exec/archive.js
diff

Add -json (JSON formatted output) and -sort option.

Modified Files:


src/sbbs3/ans2asc.c
diff

Fix new GCC 9.3 warnings.

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix ANS2ASC fmod link error with GCC 9.3 (Latest Ubuntu Linux)

Modified Files:


ctrl/text.dat
diff

Add FiAuthor FiGroup

Modified Files:


src/sbbs3/objects.mk
diff

Fix jsdoor build for *nix.

Modified Files:


src/sbbs3/listfile.cpp
diff

Resolve gcc warning

Modified Files:


src/sbbs3/GNUmakefile
diff

src/sbbs3/filedat.h
diff

src/sbbs3/objects.mk
diff

Fix the build to link with the new sauce.o file

Modified Files:


src/sbbs3/listfile.cpp
diff

Reverse the order of the Delete File and Remove Credits prompts

To match the Remove file command sequence (for consistency).

Modified Files:


src/smblib/smbdump.c
diff

Don't repeat the "cost" field in smb_msghdr_str_list()

Modified Files:


src/smblib/smbdefs.h
diff

src/smblib/smblib.c
diff

src/smblib/smbstr.c
diff

Restore AUTHOR and AUTHOR_ORG SMB header fields removed Apri-19-2019

Going to use these to store SAUCE "AUTHOR" and "GROUP" fields for files.

Modified Files:


src/sbbs3/con_out.cpp
diff

A line feed does not move the cursor to column 0.

This caused an issue for the soon to be committed P_INDENT support in putmsg().

Added Files:


src/sbbs3/sauce.c
diff

src/sbbs3/sauce.h
diff

A SAUCE library that can read a SAUCE record or character file metadata.

Modified Files:


src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Created convert_ansi() which is kind of a minimal version of ANS2ASC

It Ctrl-A encodes a possibly ANSI-encoded string, supporting on color/attribute
sequences and stripping all others.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix observed crashes at end of pop3_thread() and smtp_thread()

"startup" was being deref'd after the caller free'd it because these thread
functions were calling thread_down() before calling mail_close_socket(), which
deref's startup which was subject to a race condition.

Modified Files:


src/sbbs3/ans2asc.c
diff

src/sbbs3/ans2asc.vcxproj
diff

Read/use SAUCE for width and ice-color setting when cols not specified

Also added -normal option to use save/normal/restore attr sequence for
conditional-newlines. This is helpful for narrow ANSIs (e.g. 44-column
FILE_ID.ANS) that depend on the viewer to read/use the SAUCE info.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/filelist.vcxproj
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upload.cpp
diff

DIZ enhancements: Read/use SAUCE data, support ANSI, increase max 1->4K

Inspired by Blocktronics (and other ANSI art group) packs' FILE_ID.DIZ/ANS
files:
* Support (and prioritize) FILE_ID.ANS
* Convert ANSI color/attribute sequences in DIZ files to Ctrl-A equivalent
(uses SAUCE width and ICE color, if specified)
* Don't treat DIZ as a series of lines, they're not always nowadays.
* New putmsg() mode: P_INDENT to print files indented by current column
* Display full (up to 64-char) filenames in lists when using 132+ column
terminal.
* Use the Author, Group, and Title fields from the SAUCE if present/non-blank
* 2 new text.dat strings: 301 (FiAuthor) and 302 (FiGroup)
* Also fix bug with repeated Cost header field on bulk-uploaded files.

I know this'll break the *nix build (sauce.c dependency), but I'll fix that
next.

Modified Files:


src/sbbs3/js_file.c
diff

Use JS_ValueToECMAUint32 for File position, date, and length properties

This resolves errors when setting these properties to values > 2147483647
example:
!JavaScript  /sbbs/exec/load/sauce_lib.js line 69: Error: can't convert
2430770157 to an integer

That means you can now seek around (set position) within files > 2GB, truncate
or extend a file > 2GB, or set a file's date to > Jan-19-2038.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/upload.cpp
diff

Increase file_id.diz max line length from 80 to 255

Increase total extended description length from 1024 to 4000 characters.
Perhaps this should be configurable?

Modified Files:


src/smblib/smbdefs.h
diff

src/smblib/smblib.c
diff

Add convenience pointer (from_port) to SENDERPORT header field

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/upload.cpp
diff

Store file uploader's IP address, hostname, protocol and port

Modified Files:


xtrn/postit/postit.js
diff

removed note about moving to xtrn from exec

Added Files:


xtrn/postit/postit.js
diff

moved postit.js to its rightful home in the xtrn folder. anyone using this
script likely already has it there anyway. if not, data files should be moved
for anyone updating their local script. no file changes have been made.

Modified Files:


src/sbbs3/qwk.cpp
diff

Don't log an error when a QWKnet node uploads votes for old messages

Log an info-level message instead.
Raise the log level severity of duplicate votes from Debug to Info too.

Modified Files:


src/sbbs3/filedat.c
diff

Fail on "disallowed filename" after filtering for filename/pattern

Extracting a file_id.diz would fail if the file contained any disallowed
filenames before the DIZ, e.g.:
 Error: disallowed filename '_blockmen_res[v]olution.ans' (after extracting 0
items successfully)

Modified Files:


src/sbbs3/js_system.c
diff

Populate system.uptime in JSDoor

This variable tracks the time that jsdoor was started.

Modified Files:


exec/testbuild.js
diff

Add the Coverity scan support (for *nix builds only)

Modified Files:


src/sbbs3/userdat.c
diff

Let's make that semfile just sound.mute

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/ntsvcs.c
diff

src/sbbs3/ntsvcs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/websrvr.c
diff

Control sound-mute via semfile (ctrl/sound.muted) rather than sbbs.ini

There was a bug with reloading the configuration files in sbbsctrl where the
sound button no longer reflected the truth and the sysop's previous click-state
of the button was lost. Rather than going through writing the OPT_MUTE flag to
the Options fields of all the sections of the sbbs.ini and then re-loading that
file as a result, just do like we did with the sysop chat availability: use a
semfile. So much simpler.

If anyone ever needs instance-specific muting, we can create/check
instance/host-specific mute semfiles then. Doubt that'll happen though.

Also, removed the old sysavail control methods of ntsvcs too.

Added Files:


exec/delfiles.js
diff

New utility script that replaces DELFILES (the program) for sbbs v3.19

Modified Files:


exec/dupefind.js
diff

Add de-duplication feature (-dedupe option) to remove/delete dupe files found

Modified Files:


exec/str_cmds.js
diff

Remove commands: ALTUL, RESORT, CLOSE no longer applicable in v3.19

Modified Files:


exec/load/text.js
diff

Add FiUploadedTo string

Modified Files:


src/sbbs3/js_filebase.c
diff

get_size() and get_path() methods need to read the header record too

For files with names > 64 chars.

Modified Files:


src/sbbs3/js_filebase.c
diff

remove() method needs to read message header (not just index)

Or else it fails with the following base error:
!smb_putmsghdr illegal header length increase: 70 (1 blocks, 0 hfields, 0
dfields) vs 0 (0 blocks)

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Write the global sound (WAV) file settings in sbbs_write_ini().

Modified Files:


src/sbbs3/ctrl/.gitignore
diff

Ignore sbbsctrl.str output file.

Added Files:


src/sbbs3/ctrl/SoundCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/SoundCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/SoundCfgDlgUnit.h
diff

Modified Files:


src/sbbs3/ctrl/FtpCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/FtpCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/FtpCfgDlgUnit.h
diff

src/sbbs3/ctrl/MailCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/MailCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/MailCfgDlgUnit.h
diff

src/sbbs3/ctrl/PropertiesDlgUnit.cpp
diff

src/sbbs3/ctrl/PropertiesDlgUnit.dfm
diff

src/sbbs3/ctrl/PropertiesDlgUnit.h
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.h
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.h
diff

src/sbbs3/ctrl/WebCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/WebCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/WebCfgDlgUnit.h
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/ctrl/sbbsctrl.cpp
diff

src/sbbs3/ctrl/sbbsctrl.res
diff

Move all common sound (WAV) file configuration to its own dialog

Increment the version in the project file to v3.19a.

Added Files:


src/sbbs3/ctrl/.gitignore
diff

Ignore more C++Builder artifact files.

Modified Files:


src/sbbs3/ctrl/MainFormUnit.dfm
diff

Disable ChangeDir functionality of SaveDialog

This would cause all relative file paths to fail after exporting
settings to .ini file in another directory. Long time bug.

Modified Files:


src/sbbs3/ctrl/FtpCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/WebCfgDlgUnit.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

src/sbbs3/startup.h
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

src/sbbs3/xtrn_sec.cpp
diff

Update sound (WAV) file play-on-event support in Windows build

A "hack attempt" sound file is now supported in the Terminal Server, Mail
Server,  and Services.

"login" and "logoff" sound files are now supported in the Terminal Server, FTP
Server, Web Server, Mail Server, and Services.
This enhancement fixes Issue #157

The following sound files may now be configured in the [Global] section of the
ctrl/sbbs.ini file, if desired to set the default sound files for all
servers/services in on place:
- AnswerSound
- LoginSound
- LogoutSound
- HangupSound
- HackAttemptSound

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Fix typo in previous commit.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

Allow an alternate "services.ini" filename to be specified in sbbs.ini

Set sbbs.ini [services] iniFileName to something other than services.ini to
override the default filename. The automatic/optional hostname decoration of
the filename is still supported.

Addresses request #238.

Modified Files:


exec/hatchit.js
diff

Added "Replaces" keyword support for Al (TRMB)

Made some other cosmetic improvements/fixes.

Modified Files:


ctrl/text.dat
diff

Added FiUploadedTo string.

Modified Files:


src/uifc/uifc32.c
diff

Support WIN_ORG and WIN_BOT modes in uifc.input

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

Display list of file recipients ("Uploaded to") when relevant

for the user-to-user file transfer directory

Modified Files:


exec/load/filebase.js
diff

Replace the guts of OldFileBase to make it v3.19 compatible

This appears to be enough to make hatchit.js work again and file
listings in webv4 (not sure beyond that).

This file is now just an unnecessary shim and should go away when
the consumers (hatchit and webv4) no longer need it.

I did not "port" support for the file properties:
- base
- ext
- datoffset
- opencount
- misc
- altpath

They don't appear to be needed.

Modified Files:


exec/dupefind.js
diff

Update command-line parsing (e.g. double-dash support) and help output

Modified Files:


exec/addfiles.js
diff

Make --help work and copy the option parsing logic from filelist.js

Modified Files:


text/menu/transfer.msg
diff

Restore the /U and /D (user-to-user file transfer) commands

Modified Files:


exec/filelist.js
diff

Optionally include newest-file-in-archive date/time and other features

Modified Files:


ctrl/text.dat
diff

Restore user-to-user file transfer related strings.

More use of the "conditional newline" (^A?) code rather than hard-coded
CRLFCRLFs.

Modified Files:


src/sbbs3/execfile.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

Restore the user-to-user file transfer feature

I forget who it was that said they were still using this feature in v3.18, but
here you go, it's working again (the /D and /U commands). I'm not migrating any
file sender/recipient info from v3.18, so only files added after upgrading to
this will be downloadable from the "user" directory (if you have one).

Something that I never implemented before but noticed is missing is the removal
(or dereferencing) of user-to-user files that were sent from/to a user that is
then deleted. So that's still a TODO item.

Modified Files:


src/sbbs3/addfiles.c
diff

Fix the file update support a bit.

This is still broken (errors when updating existing files) and is still planned
for deprecation.

Modified Files:


src/sbbs3/getmail.c
diff

Don't log a file removal error if the file doesn't exist.

Modified Files:


exec/str_cmds.js
diff

Fix TypeError: file_area.lib_list[i].dir is undefined

dir is not a property of lib_list[], appears to be a typo.

Also, in the "lib" scope commands, j was not defined.

The offline_dir property appears to have been deprecated (no longer
enumerable) years ago, in favor of the dir/dir_list[].is_offline
property, so use that property instead for skipping offline dirs.
Reported by xbit (XBITBBS)

Also, make sure the ;upload and other lib/all search commands are
abortable with Ctrl-C.

Modified Files:


src/sbbs3/addfiles.c
diff

Fix some crashes on multi-line description import stuff

Even though this is going to be removed / deprecated.

Modified Files:


src/xpdev/str_list.c
diff

if strListFind() is passed a NULL 'str' value, return -1 (not found)

Return int value for "string not found" rather than crash/segfault. Seems the
better option.

Modified Files:


src/sbbs3/pack_qwk.cpp
diff

Fix QWK/BLT-* copy issue (regression since v3.18)

Reported by Daryl Stout (TBOLT)

Modified Files:


src/sbbs3/userdat.c
diff

Don't compare array against NULL

Addresses CID 319116 and 319090

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Refactor putuserrec()

This started with a Coverity issue (CID 33230) which got me looking at this
function and wondering: why is str2 being NUL-terminated here? Why is the
length of str2 to be calculated on successive lines? What is with this
(long)((long)((long)((long)) typecast?

This was some of the oldest code in Synchronet (along with a lot of the other
functions in this file). I tried to keep as much intact as possible while still
improving the logic and readability.

Modified Files:


src/sbbs3/postmsg.cpp
diff

Debug the "thread_back field missing" error

Some QWKnet vote messages are failing:
evnt unpackREP <ENSEMBLE> !ERROR 2 (No such file or directory) in qwk.cpp line
1146 (qwk_vote) writing "/sbbs/data/subs/dove-gen" access=-105 info=smb_addvote
thread_back field missing

Catch this problem a little higher up (in votemsg()) and log the message's
reply-IDs to help determine what's the root-cause here. Don't bother calling
smb_addvote() if thread_back is 0.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/un_rep.cpp
diff

Add/use P_REMOTE print-mode flag to bputs()

Do nothing if online != ON_REMOTE. Eliminates some if(online == ON_REMOTE)
clauses.

Modified Files:


src/sbbs3/js_internal.c
diff

Delete one-shot events before running the callback.

If a callback deletes the one-shot event that invoked it, the
event pointer in the caller would be to free()d memory with
hilarious results.

Modified Files:


exec/presence-service.js
diff

Hack the planet.

Added Files:


exec/presence-service.js
diff

Serves "presence" data about local and remote users.

Upon connecting, a client will be sent a list of who's online on
the local BBS as well as other systems (if you and they are set
up for instant messaging). Updates will be sent for subsequent
events (logon, update, logoff).

Mostly intended for use by local consumers; you probably don't
need to open any ports for this.

Nothing uses this at the moment and you do not need to add it
to your config. Eventually it'll bring interBBS presence and
messaging back to webv4 and probably introduce a fancier textmode
imsg module.

Modified Files:


src/sbbs3/js_filebase.c
diff

Check return value of JS_ValueToInt32()

CID 331092

Modified Files:


src/sbbs3/scansubs.cpp
diff

Don't pass uninitialized string to scanposts()

CID 319108

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix some memory leaks

Modified Files:


exec/fseditor.js
diff

Do not use js.report_error()

Properly throw an error instead.

Modified Files:


exec/load/file_size.js
diff

Use Math.round() for sizes > 1024 and < 1024000

Modified Files:


install/GNUmakefile
diff

Copy upgrade_to_v319 to exec dir upon install. <shrug>

Fixes issue #252.

Added Files:


3rdp/build/js-allow-python3.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Disable configure test for python2.[567]

Just don't check the python version at all.  If your python is older
than 2.5, you're already having other issues.

Modified Files:


exec/load/file_size.js
diff

Revert back to whole numbers only for the comma-formatted K output

but round-up non-zero values to 1K.