Synchronet Git Commit Log

Modified Files:


src/sbbs3/sexyz.c
diff

Fix: the -m (max file size) cmd-line option did not work.

Pre-increment would've worked too.

Modified Files:


exec/logon.js
diff

Set the node action to "XTRN" before running an auto-xtrn-upon-rlogin.

prextrn.js keys off of the current node action to detect if the user is
currently in the logon process. Defeat that check in this case (there is no
logon process for auto-xtrn's).

Modified Files:


exec/xtrn_sec.js
diff

add global head and tail for both section menu and external program menu
use options.clear_screen for clear instead of hardcoded value in SelectItemHdr
remove redundant code for input in main section menu

Modified Files:


exec/xtrn_sec.js
diff

Merge branch 'mlong/xtrnheadtail' into 'master'

add global head and tail for both section menu and external program menu

See merge request main/sbbs!49

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Throw an exception in bbs.exec_xtrn() when passed no argument

... or when passed an invalid external program code or number, rather just just
returning false. The underlying exec_xtrn() C++ function may return false
(failure) for other reasons, so let's not obfuscate the other potential failure
causes.

Modified Files:


exec/xtrn_sec.js
diff

Support text/menu/xtrn*_tail even when xtrn<secnum|name> menu exists.

Previously, the xtrn*_tail menu was only displayed in the programmatic menu
mode.

Also, using the P_NOERROR mode flag for bbs.menu() to simplify all the if/else
logic.

And use require() instead of load().

Modified Files:


exec/xtrn_sec.js
diff

Add similar functionality to the xtrn<secnum>_head file but will
display the file after the list of external programs.

Modified Files:


exec/xtrn_sec.js
diff

Merge branch 'nelgin/xtrn_tail' into 'master'

Nelgin/xtrn tail

See merge request main/sbbs!48

Modified Files:


CONTRIBUTING.md
diff

Specify the main/sbbs branch naming scheme.

Modified Files:


src/sbbs3/xtrn.cpp
diff

A second pass at: Better native vs. DOS cmd-line detection in cmdstr()

cmdstr() is often called for non-executable command-lines (e.g. for @include:
file name/path arguments), so don't default to native unless a mode value was
specified. Hopefully addresses issue reported by bobrob without breaking
anything else (again).

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/xtrn.cpp
diff

Revert "Better native vs. DOS cmd-line detection in cmdstr()"

This reverts commit 94517fdf1dbc62c74ae82a57b250830a5b9ced41.

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/xtrn.cpp
diff

Better native vs. DOS cmd-line detection in cmdstr()

Always check the command-line for a '*' or '?' prefix and compare the executed
filename against the native program list. For DOSEMU magic drive/path name
command-line specifier substitution, but only when invoking DOS programs.
Reported by bobrob via IRC.

Modified Files:


src/sbbs3/xmodem.c
diff

Fix failure to recognize remote cancel if send buffer full.

xmodem_cancel() would return an error if putcom() failed, *before*
setting the "cancelled" [sic] flag. xmodem_cancel() in response to the
receipt of a remote cancel request (^X character).

Modified Files:


CONTRIBUTING.md
diff

Commit message etiquette.
Safe-string handling in C/C++.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Bug fix for net type when forwarding messages to internet email or fidonet
netmail

When forwarding a message, it now correctly sets sets the to_net_type property
in the
message header to FidoNet or internet for those types of message destinations

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'DDMsgReader_forward_net_type' into 'master'

Bug fix for net type when forwarding messages to internet email or fidonet
netmail

See merge request main/sbbs!43

Modified Files:


install/GNUmakefile
diff

Add optional NOCAP command-line option (call with NOCAP=1)

This can be used to defeat the automatic inclusion of the sbbs3
"setcap" build target when building on Linux. This should address
issue #175.

Modified Files:


src/sbbs3/main.cpp
diff

Log a warning when falling-back the loaded node configuration.

Modified Files:


xtrn/starstocks/game.js
diff

Update game.js - the game is showing 2 pauses when exiting. This code is not
even needed since you can set "pause after execution" in scfg. Now if that is
enabled, there is only one pause shown. And if not enabled, there is no forced
wait/press a key. Seems it would benefit sysops who want it either way.

Modified Files:


xtrn/starstocks/game.js
diff

Merge branch 'patch-4' into 'master'

Update game.js - the game is showing 2 pauses when exiting. This code is not...

See merge request main/sbbs!46

Modified Files:


src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Command-lines that start with '?' or '*' are implicitly native

Don't do the DOSEMU drive-letter dance for xtrn startup directory if the xtrn's
command line is implicitly native (e.g. Baja or JS).

Also, recognize Baja command-lines as native in cmdstr() - for %n, %!, etc.
DOSemu expansion hack.

Modified Files:


src/sbbs3/main.cpp
diff

Fallback to the "first node" configuration

If a node's configuration can't be loaded (e.g. nodeX/node.cnf is missing),
fall-back and load the "first node" (e.g. Node1) configuration. On recent *nix
installs (since the migration to Git), the node2+/node.cnf files were not
copied/created, so let's solve that soon-to-be-FAQ now.

Modified Files:


install/GNUmakefile
diff

xtrn/fatfish/README.txt
diff

xtrn/starstocks/sysop.doc
diff

Merge remote-tracking branch 'origin/master'

Modified Files:


install/GNUmakefile
diff

Copy the repo/node1 dir to sbbs/node2, node3, node4

This resolves the issue of node2+/node.cnf file missing.

Modified Files:


xtrn/fatfish/README.txt
diff

Update README.txt - website defunct

Modified Files:


xtrn/fatfish/README.txt
diff

Merge branch 'patch-2' into 'master'

Update README.txt - website defunct

See merge request main/sbbs!44

Modified Files:


xtrn/starstocks/sysop.doc
diff

Update sysop.doc - cvs is gone, and these files haven't changed in a long time
so its really not needed in the instructions

Modified Files:


xtrn/starstocks/sysop.doc
diff

Merge branch 'patch-1' into 'master'

Update sysop.doc - cvs is gone, and these files haven't changed in a long
time...

See merge request main/sbbs!42

Modified Files:


src/sbbs3/main.cpp
diff

Copy event last-run info from global config into node config

Fixes issue introduced in last commit to this file (the
each-node-has-its-own-config-in-memory enhancement) that would prevent users
from logging in because their time was reduced for an upcoming event that had
already run. The change assumes the event thread is running (its the thing that
reads the event last-run info from time.dab). Thanks to mlong for the report.

Modified Files:


src/sbbs3/scfg/scfgnode.c
diff

Remove now-obsolete help text about FirstNode config being shared

... between all nodes of  a instance sbbs instance. That's now no longer true.

Modified Files:


src/sbbs3/main.cpp
diff

Load/keep/refresh each node's configuration in memory.

Previously, all nodes shared the same copy of the configuration in memory. This
prevented any node from seeing an updated configuration until all nodes were
offline or waiting for connection and could be recycled. Now, no recycling of
the server is needed for a node to load a new config. A node in-use *still*
cannot reload configuration until the user disconnects, but all you have to do
is logon to another unused node and you (or that user) will get an updated
configuration. Bots or server recycling problems will no longer prevent the
sysop or user from getting a current configuration when connecting to any node.

This is one of those instances of giving the sysop what he wants rather than
what he asked for. I should've done this a long time ago, but the idea just
occurred to me. You're welcome. :-)

Modified Files:


src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

Don't truncate configuration strings when displaying lists/menus

Let UIFC do the truncation as necessary to fit windows/forms, when applicable.
Thanks for jc and nelgin for pointing this out via IRC.

Modified Files:


src/sbbs3/scfg/scfgxfr1.c
diff

Narrow the File Transfer Protocol menu.

The name length is limited to 25 chars, so we don't need a 50-char wide menu
here.

Modified Files:


exec/load/uifcdefs.js
diff

Re-synchronzie with src/uifc/uifc.h

Thanks for pointing that out mlong.

Modified Files:


src/syncterm/syncterm.c
diff

Fix URL typo in ALPHA notice.

And a couple of minor cosmetic adjustments.

Modified Files:


src/syncterm/term.c
diff

Include timestamps in file transfer log lines

(emulating the syslog date/timestamp format). Makes debugging file transfer
issues easier.

Modified Files:


src/sbbs3/js_uifc.c
diff

misspellings in jsdocs

Modified Files:


src/sbbs3/js_uifc.c
diff

Merge branch 'patch-1' into 'master'

misspellings in jsdocs

See merge request main/sbbs!40

Modified Files:


src/syncterm/syncterm.c
diff

Add a screen at start for alpha builds.

Basically, try to scare away people who won't file bug reports.

Modified Files:


src/sbbs3/zmodem.c
diff

Better HEX frame corruption detection.

More logging details (e.g. subpacket byte progress).
Identify XON and XOFF by name (e.g. when purging receive buffer).
Some variable naming and comment improvements.

Modified Files:


src/sbbs3/sexyz.c
diff

Detail the recv_buffer() return value of 0 (TIMEOUT) in comment.

Modified Files:


src/sbbs3/zmodem.c
diff

Insure receive buffer is purged before sending ZRPOS.

Also, zmodem_send_raw() was saving the "last sent" char, even if it wasn't
successfully sent.

Eliminated the "errors" mode of zmodem_recv_header_raw() since was no longer
used.
Eliminated zmodem_recv_header_and_check() since it's no longer used.

Some debug-log fix-ups (e.g. with progress/offset).

Modified Files:


src/sbbs3/zmodem.h
diff

Change zmodem_recv_file_frame() function signature to go with previous commit.

Modified Files:


src/sbbs3/zmodem.c
diff

zmodem_recv_file_data() will purge receive buffer before sending ZRPOS, but...

only when the errored data subpacket was a ZCRCW (waiting for ZACK).
To resolve a non-streaming failure to recover after CRC error issue.

Modified Files:


src/sbbs3/zmodem.c
diff

More log output messages/detail. No functional change.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Trim white-space from the start of stderr-logged string from xtrns

... like the last commit that did this, but do in the other 2 places where
stderr output is logged as log messages.
Also, include the extended program name in the stderr log messages, making it
easier to find the output you're looking for.

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Show the editor information file in the proper case (lower or upper)

... based on the configuration setting.
Also, prompt for upper or lowercase after setting the editor information file
type, so no "door drop file" needs to be selected to change the case of the
editor information file. - reported by mlong

Modified Files:


src/sbbs3/zmodem.c
diff

Include file/progress byte-offset at the beginning of log messages

Makes easier trace/debugging of issues (e.g. matching up with sending side
logs).
No functional change.

Modified Files:


src/sbbs3/zmodem.c
diff

Fix build error introduce in previous commit.

__FUNCTION__ cannot be used a string literal in GCC.

Modified Files:


src/sbbs3/zmodem.c
diff

zmodem_recv_files() now returns upon first failed file.

Previously, a ZRINIT frame would be sent even after a failed file download, and
this could be misinterpreted by the sender as a successful file receipt 
 acknowledgement. 'lrz' just completely aborts the receive "batch" under the
same conditions, so we'll just do the same to prevent the sender (e.g. BBS)
from mistakenly counting this as a successful transfer (download).

A lot of log message updates: additions, removals, and use of the __FUNCTION__
macro.

Modified Files:


exec/load/binkp.js
diff

Apparently we're editing file revisions like cavemen now.

Call this one "2"
Flashbacks to manually editing zone files here.
I may end up going with YYYYMMDD numbers like I sometimes did in
zone files, but maybe I'll just do the single number thing... not
really sure yet.

Modified Files:


exec/load/binkp.js
diff

"Handle" frames with a data length of zero.

These frames were already not allowed in the binkp/1.0 protocol,
and it is mentioned in the spec (issued in 2005) as "Some old
implementations do send empty frames as the last frame.".

It's certainly not allowed now, and any mailer which does it is
broken.

For zero-length data packets, it will be seen as a frame containing
zero data bytes which will also be logged as being after the file
if it comes after the file has already been completely transferred.

A zero-length command packet will abort with M_ERR, logging an error
regarding command number NaN or something like that.

This may fix #185 since attempting a recv() of zero bytes and
succeeding is the only way I can see for a zero second timeout to
have been logged in receving frame data.  The software assumed that
receiving zero bytes was a timeout, but if that's what you asked for,
it's actually success.

Modified Files:


src/sbbs3/sexyz.c
diff

Comment header cleanup.

Modified Files:


exec/binkit.js
diff

exec/load/binkp.js
diff

Increment reported revision.

Modified Files:


src/sbbs3/js_socket.c
diff

Fix bug with Socket.getoption() of byte-sized options

Only observed on Windows, the option value variable (val) was uninitialized so
querying byte-sized options using WinSock getsockopt() would leave the MSB of
the value as undefined (garbage), resulting in sockinfo.js output like this:
KEEPALIVE = -858993663
instead of this:
KEEPALIVE = 1

Modified Files:


src/sbbs3/con_out.cpp
diff

When console output is off, ignore most Ctrl-A codes

Ctrl-A codes that cause cursor movement or attribute changes or anything except
toggling the console output will now be ignored when console output is off.

Modified Files:


src/sbbs3/sexyz.c
diff

Read/set socket options from [sockopts] section of sexpots.ini

Only in Socket I/O mode. This will allow us to tweak the SNDBUF size (to
account for slow ZMODEM downloads - sends from sexyz) and frob other socket
knobs.

Also added a line feed to Windows OutputDebugString() messages since MSVC's
debug log viewer now assumes that you will.

Modified Files:


exec/load/binkp.js
diff

Add comment containing what Internet Rex sends.

Modified Files:


exec/load/binkp.js
diff

Log warning when peer does not indicate binkp/1.1 correctly, but
we assume it's 1.1 anyway.

Modified Files:


exec/binkit.js
diff

Remove hack for Mystic v1.12A39 CRAM-MD5 issue.

This has been fixed upstream for some time.

Modified Files:


exec/load/binkp.js
diff

Just parse VER using /^VER (.*) ([^ ]*?)$/

This restores the meaning of remote_ver and still has a hack for
broken, unfixable mailers that don't advertise protocol v1.1
correctly (ie: Irex)

Modified Files:


exec/load/binkp.js
diff

Don't assume the BinkP VER message contains 3-space-delimited fields.

According to both FTS-1026 and FSP-1024, the "mailer version" portion of this
msg may contain spaces. Some mailers (e.g. Internet Rex), provide their version
information with spaces, e.g. "Internet Rex 2.67 beta 1a OS/2 (binkp/1.1)",
which also include a non-conformant protocol version indicator:
 " (binkp/1.1)" instead of " binkp/1.1".
Additionally, only require that "binkp/" exist in the string, to find and
parse the protocol version number, which is apparently critical to the proper
operation of the protocol. This should resolve issue #185 reported by altere.

I'm also storing the entire VER response in the binkp.remote_ver property and
this will break the older Mystic/BinkP work-arounds in binkit.js. I dont' think
we really need those workarounds any longer however. We'll soon see I guess.

Modified Files:


src/sbbs3/exec.cpp
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


src/sbbs3/exec.cpp
diff

Log a better error when attempting to execute a non-existent module.

Don't complain that exec/<modname>.bin can't be opened. Instead, complain that
<modname> doesn't exist and therefore can't be executed. The old message could
be misleading/confusing if the expected module is a JS mod (not Baja-compiled
.bin mod).

Modified Files:


src/sbbs3/atcodes.cpp
diff

New @code SHOW:<ars> to only show text to users meeting ARS

ARS = Access Requirement String
Spaces aren't allowed in the <ars> so you might have to get creative with ARS
symbols instead of keywords.
SHOW by itself will re-enable display output for all users.
- for Nelgin

Modified Files:


src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

Re-word the text around native programs.

Make it clear that if it's not a 16-bit DOS program, it's "native".

Changed "New Shell / New Context" to "New Shell or New Context"

Modified Files:


src/sbbs3/atcodes.cpp
diff

Merge remote-tracking branch 'origin/master'

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add SYSAVAILYN @-code, same as SYSAVAIL but expands to Yes or No instead.
- for Nelgin

Modified Files:


src/sbbs3/xtrn.cpp
diff

Don't do the special DOSEMU cmdline specifier magic if the cmd starts with '?'

JavaScript modules are intuitively "native" and have not historically required
the "native" option to be set to "yes" in SCFG.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Trim left-most whitespace from stderr lines of externals before logging.

Modified Files:


src/sbbs3/download.cpp
diff

Update comment header.

Testing my commit hook more than anything.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

More Linux-DOSemu ease of use-isms (cmdline specifier magic)

Support temp_dir (%g) and text_dir %(z) expansion to magic DOSemu drives/paths.
Use DOSemu-compatible temp_dir and text_dir paths in drop files.
Automatically recognize native node_dir paths in %f (e.g. editor temp files)
and replace with DOSemu equivalent.

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Insure %j %k %n %! all expand special Linux-DOSEMU "drives"

... when running DOS programs on Linux with a DOSEMU-enabled build.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Fix Linux-DOSEMU buffer overflow warnings with sprintf() usage (!!!)

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Fix Linux-DOSEMU compile error introduced in previous commit.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Simplify Linux-DOSEMU door setup

Allows %f (drop file) and %s (startup-directory) to be specified on the
external program's command-line and expand to the paths that DOSEMU will
understand. No more hard-coding "D:\" or "E:\" and the drop filename on the
command-line required.

Also (for all builds), include the door's startup directory for %s specifier on
the clean-up command-line. This just seems like an oversight.

Modified Files:


ctrl/modopts.ini
diff

Merge branch 'patch-1' into 'master'

Update modopts.ini due to section changes in xtrn_sec.js

See merge request main/sbbs!38

Modified Files:


ctrl/modopts.ini
diff

Update modopts.ini due to section changes in xtrn_sec.js

Modified Files:


exec/xtrn_sec.js
diff

Refactor commit b63b3bb3a85 (customizable xtrn program section menu)

Use the text.dat strings that corresponded with the previous behavior
(used by console.uselect()). The defaults include new-lines, so removed
some hard-coded console.crlf() calls that were added. If you have a
custom section_header_fmt, you'll likely need to add a \r\n to it.

Allow the "External Program Section" title string to be customized
(separately from section_header_fmt, e.g. for localization).

Save/use the current section.

Mouse-enable the program section list.

Modified Files:


ctrl/modopts.ini
diff

Update modopts.ini due to section changes in xtrn_sec.js

Modified Files:


ctrl/modopts.ini
diff

Merge branch 'patch-1' into 'master'

Update modopts.ini due to section changes in xtrn_sec.js

See merge request main/sbbs!38

Modified Files:


exec/xtrn_sec.js
diff

Refactor commit b63b3bb3a85 (customizable xtrn program section menu)

Use the text.dat strings that corresponded with the previous behavior
(used by console.uselect()). The defaults include new-lines, so removed
some hard-coded console.crlf() calls that were added. If you have a
custom section_header_fmt, you'll likely need to add a \r\n to it.

Allow the "External Program Section" title string to be customized
(separately from section_header_fmt, e.g. for localization).

Save/use the current section.

Mouse-enable the program section list.

Modified Files:


ctrl/modopts.ini
diff

Add missing options (clear_screen, multicolumn_separator, and
singlecolumn_margin) for xtrn_sec in modopts.ini

Modified Files:


ctrl/modopts.ini
diff

Merge branch 'patch-1' into 'master'

Add missing options (clear_screen, multicolumn_separator, and
singlecolumn_margin) for xtrn_sec in modopts.ini

See merge request main/sbbs!37

Modified Files:


src/sbbs3/extdeps.mk
diff

readtext.c no longer dependent on sbbs.h

Modified Files:


src/sbbs3/readtext.c
diff

readtext.c no longer dependent on sbbs.h

Modified Files:


src/sbbs3/extdeps.mk
diff

getstats.c no longer dependent on sbbs.h

Modified Files:


src/sbbs3/jsexec.c
diff

Resolve warning: ‘strJavaScriptContextStack’ defined but not used

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/PropertiesDlgUnit.dfm
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/websrvr.c
diff

Stop pretending to configure the JavaScript Context stack

The argument to JS_NewContext that we were allowing to be configured was not
the contest stack size, but rather:
"The size, in bytes, of each "stack chunk". This is a memory management tuning
parameter which most users should not adjust. 8192 is a good default value." -
per Mozilla.

So we're just going to use the suggested default, hard-coded.

Modified Files:


exec/msglist.js
diff

Allow ENTER to abort the Operator menu.

Modified Files:


exec/load/nodedefs.js
diff

exec/load/presence_lib.js
diff

Include the [F] (forced chat) flag for help in debugging forced-chat.

Modified Files:


src/sbbs3/getnode.cpp
diff

src/sbbs3/userdat.c
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


src/sbbs3/getnode.cpp
diff

Fix (restore previous) node action when forced into node-private-chat

The current node action was not saved/restored when being forced into
node-to-node private chat (by a sysop). This could lead to subsequent chat
attempts by the same node to lead to a false indication that the nodes were
chatting with each other.
As reported by Altere (ATHEL).

Modified Files:


src/sbbs3/userdat.c
diff

Include the [F] (forced chat) flag for help in debugging forced-chat.

Modified Files:


exec/load/822header.js
diff

Clean-up header dumps of non-RFC822 messages.

If there's no 'id' property, don't display "Message-ID: undefined".
If the new default_content_type argument is false, don't display
a default content-type and content-transfer-encoding.

Modified Files:


exec/msglist.js
diff

When saving messages, prompt for plain-text (if "No", then save "source").

Often you may only want the plain-text portion of a message (e.g. for
printing).

Modified Files:


src/sbbs3/extdeps.mk
diff

src/sbbs3/getstats.c
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

I need to learn to pull before commit. Ugh.

Modified Files:


src/sbbs3/getstats.c
diff

Fix the sbbs.h dependency unintentionally left after c_dep_refactor

Modified Files:


src/sbbs3/extdeps.mk
diff

Remove obsolete dependencies.

Modified Files:


exec/chat_sec.js
diff

Support individual access requirements for IRC, Finger, and inter-bbs msgs.

New modopts.ini [chat_sec] options:
- imsg_requirements (default: blank)
- irc_requirements (default: blank)
- finger_requirements (default: blank)

For DesotoFireflite (VALHALLA)

Modified Files:


src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/sbbs.h
diff

Add generic on_exit support.

Store all on_exit() strings in the global scope, execute them
one scope at a time with scopes ordered in reverse order of
first call to js.on_exit().  Within a scope, they are ordered
last string first.

Modified Files:


src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/sbbs.h
diff

Merge branch 'on_exit-generic' into 'master'

Add generic on_exit support.

See merge request main/sbbs!34

Modified Files:


install/GNUmakefile
diff

Fix SBJ, TBD, and DPOKER builds when installed withOUT SYMLINK=1

Needed to pass path to the "src" (SRC_ROOT), not SBBS_SRC.

Also updated the gitlab URLs to use main/sbbs instead of sbbs/sbbs.

Modified Files:


ctrl/modopts.ini
diff

exec/prextrn.js
diff

Enable the option to ask for continuation/enter door when displaying info/intro
ans/msg file. This could be useful when displaying info about a door, showing
rules, etc.

Modified Files:


ctrl/modopts.ini
diff

exec/prextrn.js
diff

Merge branch 'prextrncont' into 'master'

Enable the option to ask for continuation/enter door when displaying...

See merge request sbbs/sbbs!35

Modified Files:


src/sbbs3/text_defaults.c
diff

Update to LiMailWaiting default.

Modified Files:


src/uifc/uifc32.c
diff

If both WIN_ORG and WIN_SAV modes are specified, don't clear save buffers.

umonitor uses these mode flags together (or soon will) and bad things happen
if you always clear the buffers that you're trying to save/restore.

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Fix a cosmetic and usability issues reported by plt and Altere (ATHEL)

Combined with a fix in uifc32.c, this fixes some problems with spawning
external programs (e.g. to edit files, run scfg, echocfg, etc.) and
when returning having a different keyboard input functionality and the
screen all fubarred. Tested with Linux/ncurses.

Added Files:


src/sbbs3/date_str.h
diff

src/sbbs3/dllexport.h
diff

src/sbbs3/filedat.h
diff

src/sbbs3/getmail.h
diff

src/sbbs3/getstats.h
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/msg_id.h
diff

src/sbbs3/msgdate.h
diff

src/sbbs3/scfgsave.h
diff

src/sbbs3/str_util.h
diff

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/allusers.c
diff

src/sbbs3/ars.c
diff

src/sbbs3/dat_rec.c
diff

src/sbbs3/date_str.c
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/dstsedit.c
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/echocfg.c
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filelist.c
diff

src/sbbs3/getmail.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/makeuser.c
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/nopen.c
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/smbactiv.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str_util.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Merge branch 'master' of gitlab.synchro.net:sbbs/sbbs

Added Files:


src/sbbs3/date_str.h
diff

src/sbbs3/dllexport.h
diff

src/sbbs3/filedat.h
diff

src/sbbs3/getmail.h
diff

src/sbbs3/getstats.h
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/msg_id.h
diff

src/sbbs3/msgdate.h
diff

src/sbbs3/scfgsave.h
diff

src/sbbs3/str_util.h
diff

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/allusers.c
diff

src/sbbs3/ars.c
diff

src/sbbs3/dat_rec.c
diff

src/sbbs3/date_str.c
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/dstsedit.c
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/echocfg.c
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filelist.c
diff

src/sbbs3/getmail.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/makeuser.c
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/nopen.c
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/smbactiv.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str_util.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

The great C function dependency refactor of 2020

The goal of this commit is that: only modules that either are part-of
sbbs.dll/libsbbs.so or need to link with/use that library, will #include
"sbbs.h" and thus be dependent on its subsequent includes (e.g. cryptlib.h,
jsapi.h). This should mean extdeps.mk can be trimmed way down.

I also removed CVS keyword/comments and trimmed up the boilerplate copyright
notice in modified and added source/header files in this commit.

There is no functional change in behavior in this comment.

Added Files:


src/sbbs3/date_str.h
diff

src/sbbs3/dllexport.h
diff

src/sbbs3/filedat.h
diff

src/sbbs3/getmail.h
diff

src/sbbs3/getstats.h
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/msg_id.h
diff

src/sbbs3/msgdate.h
diff

src/sbbs3/scfgsave.h
diff

src/sbbs3/str_util.h
diff

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/allusers.c
diff

src/sbbs3/ars.c
diff

src/sbbs3/dat_rec.c
diff

src/sbbs3/date_str.c
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/dstsedit.c
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/echocfg.c
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filelist.c
diff

src/sbbs3/getmail.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/makeuser.c
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/nopen.c
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/smbactiv.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str_util.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Merge branch 'c_dependency_refactor' into 'master'

C dependency refactor: limit use/dependency-on sbbs.h

See merge request sbbs/sbbs!36

Modified Files:


src/sbbs3/userdat.c
diff

My first opportunity to use IS_ALPHANUMERIC ()instead of isalnum()

and I blew it. Here's to learning new tricks.

Modified Files:


exec/showmsgavatar.js
diff

Allow configurable placement of avatar in message headers

Set the following in the modopts.ini [avatars] section:
msghdr_draw_top (default is true)
msghdr_draw_above (default is true)
msghdr_draw_right (default is true)

Set any of these to false to override the default behavior -
for DesotoFireflite (VALHALLA).

This commit also includes a couple of changes I've been apparently
sitting on:
- display avatars even for non-ANSI/non-CP437 terminal users
- cache the smbdefs.js in bbs.mods.smbdefs (I don't recall why)

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix netmail forwarding (new feature)

The recipient net-addr/type was always being over-ridden a bit further down in
the code. Don't do that.

Also, log a message (sbbsecho.log) indicating that a message was forwarded
("Forwarding message ...").

For geneb.

Modified Files:


src/build/Common.bmake
diff

So the Borland C++ Compiler we currently use has stdint.h

so define HAS_STDINT_H

Modified Files:


src/sbbs3/main.cpp
diff

Ooops, forgot to make btox static

Modified Files:


src/sbbs3/main.cpp
diff

Improve btox() so that it doesnt lead to any buffer overruns

Added Files:


src/xpdev/haproxy.h
diff

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/websrvr.c
diff

src/xpdev/multisock.c
diff

src/xpdev/multisock.h
diff

Move HAPROXY support into multisock.c and change parsing code.

Modified Files:


src/xpdev/multisock.c
diff

Store a pointer to the in_addr* once the family is discovered.
sa_data won't cut it since it points to the port.

Modified Files:


src/xpdev/multisock.c
diff

Clear addr before filling it, update addrlen correctly.

Modified Files:


src/xpdev/multisock.c
diff

Fix bugs introduced in last couple of commits.

Modified Files:


src/xpdev/multisock.c
diff

Slight tweaks to Deuces awesomeness - tested and v1/v2 working with ipv4/ipv6
addresses

Modified Files:


src/xpdev/haproxy.h
diff

src/xpdev/multisock.c
diff

Fix Command/Version reporting, wrong 4 bits used. Implemented v2 health check.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/websrvr.c
diff

src/xpdev/multisock.c
diff

src/xpdev/multisock.h
diff

Misc changes as requested in sbbs/sbbs!11

Modified Files:


src/xpdev/multisock.c
diff

Change buflen to size_t consitent with other recommendations, and change
'Working out' to LOG_DEBUG

Modified Files:


src/xpdev/multisock.c
diff

Change read_socket_line() to fail if we dont get a NULL or \n terminated string
within buflen.

Added Files:


exec/birthdaylist.js
diff

exec/load/install-3rdp-xtrn.js
diff

exec/postxtrn.js
diff

exec/prextrn.js
diff

exec/sutils.ini
diff

exec/sutils.js
diff

src/build/sdl2.props
diff

src/sbbs3/extdeps.mk
diff

src/sexpots/build.bat
diff

src/sexpots/release.bat
diff

src/syncterm/build.bat
diff

src/syncterm/extdeps.mk
diff

src/syncterm/release.bat
diff

xtrn/3rdp-install/README.md
diff

xtrn/3rdp-install/doormud.ini
diff

Modified Files:


.gitlab-ci.yml
diff

ctrl/modopts.ini
diff

ctrl/sbbs.ini
diff

ctrl/text.dat
diff

docs/install.rtf
diff

exec/automsg.js
diff

exec/fido-nodelist-browser.js
diff

exec/fingerservice.js
diff

exec/install-xtrn.js
diff

exec/jsdocs.js
diff

exec/load/birthdays.js
diff

exec/load/cnfdefs.js
diff

exec/load/cnflib.js
diff

exec/load/fidocfg.js
diff

exec/load/modopts.js
diff

exec/load/sbbsdefs.js
diff

exec/nntpservice.js
diff

exec/xtrn-setup.js
diff

exec/xtrn_sec.js
diff

src/conio/ansi_cio.c
diff

src/conio/conio_sdl.vcxproj
diff

src/conio/cterm.txt
diff

src/sbbs3/GNUmakefile
diff

src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptkeyset.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/objects.mk
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/targets.mk
diff

src/sbbs3/textgen.c
diff

src/sbbs3/textgen.vcxproj
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/xtrn_sec.cpp
diff

src/smblib/smbtxt.c
diff

src/syncdraw/block.c
diff

src/syncdraw/buildfont.c
diff

src/syncdraw/crt.c
diff

src/syncdraw/fonts.c
diff

src/syncdraw/fonts.h
diff

src/syncdraw/fontutil.c
diff

src/syncdraw/load.c
diff

src/syncdraw/menue.c
diff

src/syncdraw/miscfunctions.c
diff

src/syncdraw/sauce.c
diff

src/syncdraw/syncdraw.c
diff

src/syncdraw/tabulator.c
diff

src/syncterm/COMPILING
diff

src/syncterm/GNUmakefile
diff

src/syncterm/SyncTERM.vcxproj
diff

src/syncterm/amigafont.h
diff

src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

src/uifc/GNUmakefile
diff

src/xpdev/genwrap.c
diff

src/xpdev/strwrap.c
diff

src/xpdev/strwrap.h
diff

src/xpdev/xpdev_mt.vcxproj
diff

webv4/root/index.xjs
diff

xtrn/lord/dumpplayers.js
diff

xtrn/lord/lord.js
diff

Removed Files:



exec/badpasswords.js
diff

exec/load/birthdate.js
diff

exec/load/gnatslib.js
diff

exec/query_pr.js
diff

exec/send_pr.js
diff

Merge branch 'upstream'

Modified Files:


src/xpdev/multisock.c
diff

Consistent use of NULL, read_socket_line() no longer considers a NULL
terminated string as good

Modified Files:


src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Merge branch 'upstream' - deuces inet_pton() work for minw32

Modified Files:


src/xpdev/multisock.c
diff

Fix for Microsoft C++ compiler

Modified Files:


src/sbbs3/js_cryptcert.c
diff

src/sbbs3/sbbsecho.c
diff

src/xpdev/gen_defs.h
diff

Merge branch 'upstream'

Modified Files:


src/xpdev/multisock.c
diff

Fix my own nits.

Modified Files:


src/sbbs3/echocfg.vcxproj
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/jsexec.vcxproj
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/ntsvcs.vcxproj
diff

src/sbbs3/sbbscon.vcxproj
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/websrvr.vcxproj
diff

Merge remote-tracking branch 'origin/master' into leenooks/sbbs-master

Modified Files:


src/sbbs3/mailsrvr.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

text/menu/msghdrexample.asc
diff

Merge remote-tracking branch 'origin/master' into leenooks/sbbs-master

Added Files:


src/xpdev/haproxy.h
diff

Modified Files:


ctrl/sbbs.ini
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/startup.h
diff

src/sbbs3/websrvr.c
diff

src/xpdev/multisock.c
diff

src/xpdev/multisock.h
diff

Merge branch 'master' into 'master'

Enable obtaining source IP address if HAproxy is used

See merge request sbbs/sbbs!11

Modified Files:


src/sbbs3/prntfile.cpp
diff

Convert menu paths (e.g. /sbbs/text/menu/../filename) to full paths

If text/menu is a symlink (on *nix), then the path above would actually
point to a filename in the parent of the symlink target, which is not
what we want (we want the filename in the text dir). Fixed by using
FULLPATH.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Resolve newish gcc warning about unused set variable.

Modified Files:


src/sbbs3/js_socket.c
diff

Resolve gcc warnings about unused set variables.

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Use a more-liberal username matching algorithm

- Ignore all non-trailing non-alphanumeric characters when comparing a string
against a user's name. Previously, spaces and dots and underscores were
mostly-treated as equivalent and white-space was sometimes compressed for
comparison purposes (if the user name contained both spaces and dots). This
updated algo helps to insure that deliberate or accidental name collisions
cannot be created but also aids usability (e.g. users can make some minor
cosmetic adjustments to their user name and still be considered the "same user"
for most comparison purposes).
- Terminate the comparison string at an '@' (ignore everything after). This
resolves the FAQ of why users can't login with "username@domain" and aides some
other username/address matching algorithms (e.g. in the mailserver). '@'s are
illegal characters for usernames already.

Expose the new algorithm via new function matchusername().
Use the algorithm in matchuser() and lookup_user().

Unrelated: don't lower-case the 'localuser' part of email addresses in
usermailaddr() - cosmetic only.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Better FTN netmail gating support

Revert the previous change to the mailsrvr (don't try to parse the MS Outlook
singled-quoted names in to/from header fields).

Instead, use the new matchusername() to perform a liberal name match against
the name portion of the destination email address and if it matches, go ahead
and use the quoted-name field. Otherwise, use the name portion of the
destination address as the TO field for the FTN netmail message.

Modified Files:


src/sbbs3/mailsrvr.c
diff

The Received/trace header should contain the forward-path for "for"

instead of the potentially-alias'd delivery address. The angle-brackets
(now included) appear to be standards-compliant.

Modified Files:


text/menu/msghdrexample.asc
diff

Add SHOWMSGAVATAR support to custom message header example

Modified Files:


src/sbbs3/sbbsecho.c
diff

Revert "A better check of a user's netmail-forwarding address."

This reverts commit 796c3db7d2e5fdb81b1c4dff884e15d66718063c.

Modified Files:


src/sbbs3/sbbsecho.c
diff

A better check of a user's netmail-forwarding address.

is_supported_netmail_addr() actually takes the system configuration and QWK
routing table into account. No sense forwarding to a non-deliverable address.

Modified Files:


src/sbbs3/echocfg.vcxproj
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/jsexec.vcxproj
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/ntsvcs.vcxproj
diff

src/sbbs3/sbbscon.vcxproj
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/websrvr.vcxproj
diff

Replace use of WinSock1 import lib with WinSock2 import lib..

Replace use-of/linking-with wsock32.lib with ws2_32.lib to fix issues such as
this one coming-up with the HAProxy feature merge:
unresolved external symbol __imp__inet_pton@12 referenced in function
_xpms_accept 

Modified Files:


src/xpdev/gen_defs.h
diff

Fix UINT32_MAX definition in previous commit

Modified Files:


src/xpdev/gen_defs.h
diff

define U?INT[0-9]+_(MIN|MAX) for builds without stdint.h (ie: Borland)

Modified Files:


src/sbbs3/js_cryptcert.c
diff

Remove useless documentation.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Support forwarding FTN netmail to user's forward-to netmail address

There's no new opt-in option for this new feature - maybe there should be.
For geneb.

Modified Files:


src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

It's _MSC_VER, not _MSVC_VER.

Sorry guys. :(

Modified Files:


src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Looks like MSVC has inet_pton().

Modified Files:


src/xpdev/sockwrap.c
diff

And finally, take a pointer, return success properly.

This one should build even on Win32.

Modified Files:


src/xpdev/sockwrap.c
diff

Fix bugs in last commit... continue abusing the CI infra.

Modified Files:


src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Add inet_pton() for Win32.

Needed by MinGW32... we'll see if MSVC needs it as well soon.

Added Files:


src/sbbs3/extdeps.mk
diff

Modified Files:


src/sbbs3/GNUmakefile
diff

src/sbbs3/targets.mk
diff

src/uifc/GNUmakefile
diff

Make parallel make work for sbbs.

This requires anything that includes sbbs.h to have cryptlib and
mozjs already built/isntalled... to track this, I've added the new
extdeps.mk file.

This is pretty terrible though... not sure how important that
dependency really is.

Added Files:


src/syncterm/extdeps.mk
diff

Modified Files:


src/syncterm/GNUmakefile
diff

Support -j on SyncTERM

This doesn't make anything much faster since the bulk of the time
is building ctyptlib which doesn't support -j, but at least Cyan
won't complain every time he creates an ebuild anymore.

Modified Files:


src/sbbs3/mailsrvr.c
diff

MS Outlook can place names of to/from users in single-quotes

Parse single-quoted "name" portion of email-addr header fields. I don't think
this is going to fully solve the issue with FTN netmail gated to SMTP and
replied via Outlook, but it's a start. Try that Nelgin.

Modified Files:


src/sbbs3/targets.mk
diff

Add dependency on JS for everything that includes sbbs.h

This is because it includes js_version.h if JAVASCRIPT is defined,
and JAVASCRIPT is defined for everything using CFLAGS.

It may be worth re-working the JAVASCRIPT define, but that's a bunch
of extra work.

This is the first (and easiest) step in getting parallel builds
working.

Modified Files:


xtrn/lord/lord.js
diff

Generate scores.lrd when gracefully quitting with 'Q' too.

Modified Files:


ctrl/sbbs.ini
diff

Increase JavaScriptMaxBytes from 8M to 160M

160M is the value used by the Mozilla/SpiderMonkey JSShell project, so I'm
rationalizing that as an acceptable default. Of course, it would be good
to optimize memory usage in JS scripts, so we'll work on that too. So, if
you're a JS developer, best to play with lower values here to see if/where
you're being potentially wasteful in your memory usage, but most sysops
just want everything "to work".

Modified Files:


xtrn/lord/lord.js
diff

Generate scores.lrd whenever a player exits.

Not sure how I missed this bit.

Modified Files:


xtrn/lord/lord.js
diff

Change name *and* real_name to 'X' when deleting a users.

Deleted users would be "properly" loaded as 'X' which would mean
they wouldn't show up in rankings and couldn't be attacked.

Modified Files:


xtrn/lord/lord.js
diff

Go back to the rev 1.37 behavior (don't confirm RESET when run via JSexec)

... but do it do it correctly. This allows for automated game-reset, e.g.
via cron job or timed event.

Modified Files:


xtrn/lord/lord.js
diff

Fix failure to run RESET via jsexec ('bbs' not defined).

Modified Files:


xtrn/lord/dumpplayers.js
diff

Fix hard-coded default path of player file. Allow over-ride via cmdline arg.

Modified Files:


.gitlab-ci.yml
diff

Actually build jsdoor in jsdoor Windows target.

Modified Files:


src/syncterm/COMPILING
diff

DONT_CLOBBER_CC isn't needed anymore since we don't.

Modified Files:


.gitlab-ci.yml
diff

Add Win32 jsdoor build (on FreeBSD)

This can likely be built on Windows, but since I expect I'll be the
only one supporting this for the forseeable future, get the build I
release in here.

Modified Files:


exec/automsg.js
diff

Fix "undefined" message displayed to W-restricted users.

As reported by plt from the I, the R, and the C.

Also, abort menu upon Ctrl-C.

Modified Files:


src/sbbs3/js_cryptcert.c
diff

Looks like MSVC hates forward declarations for no good reason.

Modified Files:


src/sbbs3/js_cryptkeyset.c
diff

Replace < and > with &lt; and &gt; in JSDOC strings.

Modified Files:


exec/jsdocs.js
diff

src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptkeyset.c
diff

src/sbbs3/js_msgbase.c
diff

Add support for documenting class properties to jsdocs.

Then, add JSDOC support to crypto class constant objects.

Also, since crypto stuff is almost half of all the docs, move all
the crypto classes and objects to the end. It would be nice if these
massive lists were hidden by default line the menu tree at the start.

Modified Files:


exec/jsdocs.js
diff

Add massive documentation for CryptCert

Modified Files:


src/sbbs3/js_cryptcert.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

Allow more than 256 pre-defined properties in a built-in JS object.

Previously, properties were only supported via the TinyID mechanism
in the JS API.  This limited the properties to have a unique signed
8-bit integer ID, which prevented more than 256 properties from
existing in a built-in object.

The id value can be a name however, a TinyID is not required.  For
property descriptions with an ID outside the range of 8 bits, define
them using just the name.  When this is done, the getter and setter
functions will need to convert the names to an ID themself.

This isn't ideal... ideally, each would have a unique getter and
setter, but doing it this way puts of requiring an internal JS API
refactor and allows the CryptCert class to have all the defined
properties.

As implied... CryptCert now supports all properties, and JS Docs
will be created for them.  This section is yuge!

Modified Files:


src/sbbs3/js_internal.c
diff

May as well check the signature in the OnExit handler too.

Modified Files:


src/sbbs3/js_internal.c
diff

Fix previous commit.

Copy/paste without the update required a single character to have
seven different values... which is unlikely to actually happen.

Modified Files:


src/syncterm/SyncTERM.vcxproj
diff

MSVC-Build with cryptlib/SSH support.

The calls to cryptlib are still broken, so that's a to-do item.
e.g. calling cryptstatuSOK() in st_crypt.c init_crypt() throws an
exception:
"Run-Time Check Failure #0 - The value of ESP was not properly saved across a
function call.  This is usually a result of calling a function declared with
one calling convention with a function pointer declared with a different
calling convention."

Modified Files:


docs/install.rtf
diff

Mention the MSVC++ 2010 runtime is still required.

Modified Files:


.gitlab-ci.yml
diff

Disable SyncTERM-MSVC build

<@Deuce> SyncTERM on MSVC really shouldn't be part of CI since it's not
expected to work.
<DigitalMan> why not?
<@Deuce> Because it's not supported.
<@Deuce> So it's not part of the integration path.

Modified Files:


webv4/root/index.xjs
diff

Use a better default for web root.

This should be use in all the other places, but this was enough for
me to debug the issue at hand.

Modified Files:


src/sbbs3/js_internal.c
diff

Eliminate crash in js.on_exit()

Have js.on_exit() throw an exciption with a useful(?) error when the
scope already has private data, and that data is not an on_exit list.

This fixes #182.

Modified Files:


src/syncterm/SyncTERM.vcxproj
diff

Fix release build by using runtime DLLs.

Added Files:


src/syncterm/build.bat
diff

src/syncterm/release.bat
diff

A couple batch files for performing MSVC2019 builds (debug by default).

Modified Files:


.gitlab-ci.yml
diff

Added SyncTERM-MSVC (Windows) build

Modified Files:


ctrl/text.dat
diff

Include unread mail (number) in "Mail Waiting" logon info string.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Don't reset line counter after executing externals.

This behavior was cut/pasted from xtrn_sec.js but doesn't play well with logon
events (e.g. SBBSIMSG list) that should pause before a following CLS. As
reported by altere on the I, the R, and the C.

Modified Files:


src/sbbs3/logon.cpp
diff

Fix inverted logic of noyes() prompt in previous commit.

Modified Files:


src/sbbs3/logon.cpp
diff

If all waiting-mail has been read, don't default to "Yes" read mail

Count the read mail-waiting and compare to the total mail-waiting and if
they're the same, then default to "No" for the "Read Your Mail Now" prompt
during logon.

Also, pass the difference (the unread mail) to the LiMailWaiting logon-info
line.

As requested by altere via I.R.C.

Modified Files:


exec/xtrn-setup.js
diff

Skip already-installed externals and fail w/msg if no installables were found.

Modified Files:


.gitlab-ci.yml
diff

Don't perform CI builds unless src/* 3rdp/* or ctrl/text.dat has been touched
by a commit.

Modified Files:


src/conio/cterm.txt
diff

Fix incorrect use of OCS in DCS string description.

Modified Files:


.gitlab-ci.yml
diff

Add builds for jsdoor on Linux and FreeBSD, sexpots on FreeBSD.

Modified Files:


.gitlab-ci.yml
diff

Add SyncDraw builds for FreeBSD and Linux, fix FreeBSD artifacts.

The AMD64 platform on FreeBSD is called amd64, not x64.

Modified Files:


src/syncdraw/block.c
diff

src/syncdraw/buildfont.c
diff

src/syncdraw/crt.c
diff

src/syncdraw/fonts.c
diff

src/syncdraw/fonts.h
diff

src/syncdraw/fontutil.c
diff

src/syncdraw/load.c
diff

src/syncdraw/menue.c
diff

src/syncdraw/miscfunctions.c
diff

src/syncdraw/sauce.c
diff

src/syncdraw/syncdraw.c
diff

src/syncdraw/tabulator.c
diff

Fix font insanity and Clang warnings.

Since this was originally Pascal, there's a tonne of 1-based indexed
arrays, and the font ones were sized by number of elements, meaning
it was chock full of buffer overflows.  Also, the Pascal string
handling was crazy.

There were also some file IO issues floating around.

This fixes all of those issues and also Closes #179

Added Files:


xtrn/3rdp-install/README.md
diff

Create some initial description/instructions for this directory.

Added Files:


exec/load/install-3rdp-xtrn.js
diff

xtrn/3rdp-install/doormud.ini
diff

Modified Files:


exec/install-xtrn.js
diff

exec/xtrn-setup.js
diff

Support 3rd party installer files for external programs (doors)

By simply installing a supported 3rd party door game into your
"xtrn" directory, install-xtrn.js or xtrn-setup.js can automatically
discover and configure your newly installed door for Synchronet. Easy peasy.

Resolves issue #181 (great idea) by Michael Long. Deuce and others have had
similar ideas in the past.

Now, we don't have to rely on the authors of potentially-abandoned door games
to create and include a Synchronet install-xtrn.ini file. We can just do that
for ourselves and make installing all (known) door games super easy.

Many more xtrn/3rdp-install/*.ini files will be forthcoming!

Modified Files:


src/syncterm/ripper.c
diff

Remove duplicate fclose()

Modified Files:


src/syncterm/SyncTERM.vcxproj
diff

SyncTERM v1.2 builds as  Desktop/GUI app, not a console app

Change SubSystem type from Console to Windows to resolve error:
unresolved external symbol _main referenced in function ___tmainCRTStartup

Modified Files:


src/sbbs3/websrvr.c
diff

Merge remote-tracking branch 'origin/master'

Modified Files:


src/sbbs3/websrvr.c
diff

Some CGI programs know they're not running from a console because
QUERY_STRING is defined (even if blank).

Always define it.

Modified Files:


src/xpdev/strwrap.c
diff

A better fix for error: "<malloc.h> has been replaced by <stdlib.h>"

Modified Files:


src/xpdev/strwrap.c
diff

Resolve FreeBSD error: "<malloc.h> has been replaced by <stdlib.h>"

Added Files:


src/build/sdl2.props
diff

SDL2 property sheet for MSVC.

Modified Files:


src/conio/conio_sdl.vcxproj
diff

Update included property sheets (e.g. SDL2, encode, hash libs) for MSVC.

Modified Files:


src/syncterm/SyncTERM.vcxproj
diff

src/syncterm/amigafont.h
diff

src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

Changes necessary to build with MSVC2019.

Modified Files:


src/xpdev/strwrap.c
diff

src/xpdev/xpdev_mt.vcxproj
diff

Changes necessary to build SyncTERM-Win32 with MSVC2019.

Modified Files:


exec/fingerservice.js
diff

Don't include date of birth in finger response for users' info.

Modified Files:


.gitlab-ci.yml
diff

src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

Merge branch 'master' of gitlab.synchro.net:sbbs/sbbs

Modified Files:


src/syncterm/term.c
diff

Fix array size issues introduced on last commit.

Options were added to arrays without increasing the size of arrays.
This caused the menu generated from them to depend on uninitialized
memory and potentially crash or emit garbage.

Modified Files:


src/syncterm/ripper.c
diff

Fix most of the RIP issues found by coverity.

Most are simple memory leaks, but some would cause crashes, and
others would cause unexpected behaviour.

Modified Files:


.gitlab-ci.yml
diff

Experiment with CI caching again another day...

Modified Files:


.gitlab-ci.yml
diff

Linux build failure, undefined reference in libsbbs.so.
Let's try just caching the 3rd party stuff.

Modified Files:


.gitlab-ci.yml
diff

Let's try caching sbbs-linux build artifacts now.

Modified Files:


.gitlab-ci.yml
diff

So my yaml skills are not so great.

Modified Files:


.gitlab-ci.yml
diff

Let's try some caching for the sbbs-windows build (first).

Modified Files:


src/syncterm/ripper.c
diff

Stop using ASCII caret for power of two.

Modified Files:


.gitlab-ci.yml
diff

Capitalize Windows too, because... Deuce.

Modified Files:


.gitlab-ci.yml
diff

Added SyncTERM-FreeBSD build job (for reals).
Try capitalizing Linux tag.

Modified Files:


.gitlab-ci.yml
diff

Add some FreeBSD build jobs.

Modified Files:


ctrl/text.dat
diff

Replace remaining CP437 chars with \xXX escape sequences.

As pointed out by mlong.

Modified Files:


ctrl/modopts.ini
diff

exec/xtrn_sec.js
diff

allows more flexibility in formatting xtrn program menus by allowing one to
remove the titles or underline headings by setting them to 'none' in the ini
file

Modified Files:


ctrl/modopts.ini
diff

exec/xtrn_sec.js
diff

Merge branch 'xtrnnoneformat' into 'master'

allows more flexibility in formatting xtrn program menus by allowing one to...

See merge request sbbs/sbbs!32

Modified Files:


ctrl/text.dat
diff

Replace accidental CP437 char embedded in XtrnProgLstUnderline string

As reported by mlong

Modified Files:


ctrl/modopts.ini
diff

Document the [newuser] survey key

Modified Files:


src/sbbs3/jsexec.c
diff

Restore console to "cooked" mode before daemonizing().

Previously, the console would be left in "raw" mode after invoking
'jsexec -d <module>'.

Modified Files:


src/sbbs3/jsexec.c
diff

More control over output streams

Added options -A[filename] and -S[filename] to allow more control over which
output streams go where (for mlong and his troubles with running ircd via
systemd).

-A controls "all messages" either sending all to stdout or the specified
filename. This override the automatic suppression of the console output stream
when run without a controlling TTY.

-S controls "status message" (includes non-error level log messages), either
sending the status messages to stdout or the specified filename. This also
overrides the automatic suppression of the console output stream when run
without a controlling TTY.

Modified Files:


ctrl/modopts.ini
diff

exec/xtrn_sec.js
diff

Add ability to format the main external section menu like you can with the
programs menus

Modified Files:


ctrl/modopts.ini
diff

exec/xtrn_sec.js
diff

Merge branch 'custxtrnsection' into 'master'

Add ability to format the main external section menu like you can with the
programs menus

See merge request sbbs/sbbs!31

Modified Files:


exec/load/modopts.js
diff

Support blank strings in modopts.ini

Use the new "blanks" option with File.iniGetAllObjects().
This means that keys specified in the modopts.ini with no value
will now be represented as blank strings ("") instead of undefined values,
in JS modules.

Modified Files:


src/sbbs3/js_file.c
diff

JS File.iniGetObject() and .iniGetAllObjects() now support blank strings

If an .ini file is read by either the iniGetObject() or iniGetAllObjects()
methods and contains a key with a blank value, that property would be created
with an "undefined" value.

Both the iniGetObject() and iniGetAllObjects() methods now accept an additional
Boolean argument (which defaults to false), to specify that "blanks" are
acceptable. When the "blanks" argument is true, then keys with empty values in
the .ini file are created as properties with empty string values (length of 0).

This is going to be useful for modopts.js to read potentially-blank strings
from modopts.ini and differentiate between a blank string key and a missing
key.

Modified Files:


src/sbbs3/main.cpp
diff

Add timestamp of node.log file to crash.log

When a preexisting node.log file is found, a terminal server crash is
suspected. Include the timestamp of the node.log in the message appended to the
system log (data/logs/*.log) to help identify the likely time of the crash.

Modified Files:


exec/postxtrn.js
diff

exec/prextrn.js
diff

change the program var in xtrn.js to prog to be compatible with any existing
uses of eval_before_exec

Modified Files:


exec/postxtrn.js
diff

exec/prextrn.js
diff

Merge branch 'prextrnevalfix' into 'master'

fix pre/post_eval_on_exec to work with existing uses

See merge request sbbs/sbbs!33

Modified Files:


exec/load/birthdays.js
diff

Removed Files:



exec/load/birthdate.js
diff

Use the newest methods of getting a user's birth month/day.

Remove birthdate.js - not needed or used anywhere (anymore).

Added Files:


exec/birthdaylist.js
diff

A birthday list module

By default, displays users of the BBS born in the current month.

Modified Files:


.gitlab-ci.yml
diff

Add sbbsctrl.exe, chat.exe, and useredit.exe builds to sbbs-windows build.

Modified Files:


.gitlab-ci.yml
diff

Attempt Borland build of xpdev as part of sbbs-windows build.

Modified Files:


src/smblib/smbtxt.c
diff

Fix crashing bug introduced in previous commit of this file

Don't pass NULL to strcasestr().

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Clarify in the help text that first directory is cloned...

when there is no "template directory" selected/configured.

Modified Files:


exec/postxtrn.js
diff

exec/prextrn.js
diff

Fix: these scripts should not return 1 (error) when disabled via modopts.ini

Modified Files:


exec/sutils.js
diff

sutils.ini is locate in the exec directory, not the cwd (ctrl dir).

Modified Files:


exec/postxtrn.js
diff

exec/prextrn.js
diff

Clean-up and optimize the pre/post exec xtrn modules

Don't load() things unnecessarily (use require() instead).
Fix the X-restriction issue (is not supposed to limit the execution of
programs configured to run as logon events).

Modified Files:


src/smblib/smbtxt.c
diff

Improved parsing of "charset" parameter in MIME Content-Type header.

In Issue #177, the reported problem message header was "Content-Type:
text/plain; charset=utf-8; format=flowed"
The fact that the "charset" value was not quoted and not space delimited means
the charset would have been parsed as "utf-8;", which would not provide an
exact match (against "utf-8") in smb_msg_is_utf8() and thus the message body
would not be considered to be utf-8 encoded.

The solution is to terminate the "charset" parameter value at the semicolon, if
it exists, and the value was not quoted.

Also, for good measure, only search for " charset" or ";charset" to avoid
false-positive parameter matches,  like "notcharset".

Modified Files:


src/sbbs3/postmsg.cpp
diff

Reduce unnecessary posted-to username searches. Auto-UTF8 in savemsg().

When posting to "All" or replying to a message that was posted by networked
(not local) user, don't attempt to search for that username in the local user
base to inform them of the posted message to them.

savemsg() is the underlying C function for saving a new message (mail or post)
to a message base from several places, including JS modules. If there was no
"charset" specified in the passed message header, check to see if the message
body text is non-ASCII but valid UTF-8, and if it is, set the FIDO_CHARSET
header field to the appropriate UTF-8 charset identifier string. This would
*also* address Issue #177 reported by Michael J. Ryan. It's possible, but
unlikely, that a message text would contain valid CP437 that *also* happened to
be valid UTF-8. If that does happen to occur (e.g. in posted ANSI art?), we
might want to revert this enhancement to savemsg() and leave to the caller's to
detect/specify the charset, always.

Modified Files:


exec/load/fidocfg.js
diff

Resilience around tickit.ini and freqit.ini file open operations.

Throw exceptions rather than just loggin an "Unable to open" error
(easier tracking fo the soruce of the error). Log the description and
errno value associated with the file open failure.

Create the .ini files if they don't already exist (rather than crashing
out with an error).

Replace the deprecated 'e' file open mode flag with 'x'.

Modified Files:


.gitlab-ci.yml
diff

Add sexpots-windows build.
Fix sexpots-linux build issue introduced in previous commit.

Added Files:


src/sexpots/build.bat
diff

src/sexpots/release.bat
diff

MSVC build batch files.

Modified Files:


.gitlab-ci.yml
diff

Merge remote-tracking branch 'origin/master'

Modified Files:


.gitlab-ci.yml
diff

Add artifact names back with platform designator/suffix (linux-x64 and win32).

Modified Files:


.gitlab-ci.yml
diff

Filter out non executables/DLLs from Windows build artifacts.
Remove archive names (uses build names by default?).
Remove "build-" from build names.

Modified Files:


src/sbbs3/textgen.c
diff

src/sbbs3/textgen.vcxproj
diff

Pass the path to the ctrl and exec dirs to textgen.

For Windows release (CI) builds.

Modified Files:


.gitlab-ci.yml
diff

Make release builds for Windows-CI

Modified Files:


src/sbbs3/scfglib1.c
diff

Fix bug in mlong's prextrn mod enhancement

Caused error:
exec.cpp line 805 (sbbs_t::exec_bin) opening
"s:\sbbs\exec\ÿÿÿÿÿÿÿÿ.bin" access=0
As reported by Nelgin via IRC at 3AM Texas-time.

Modified Files:


src/sbbs3/textgen.c
diff

Return line number up on failure.

Debugging why textgen is failing during Windows/CI build.

Modified Files:


.gitlab-ci.yml
diff

Force SBBSCTRL and SBBSEXEC to point to the local repo ctrl and exec dirs (For
Windows builds)

Modified Files:


.gitlab-ci.yml
diff

Let's try .\build.bat <shrug>

Modified Files:


.gitlab-ci.yml
diff

We have to "call" batch files (maybe)?

Modified Files:


.gitlab-ci.yml
diff

tags must be an array of strings

Modified Files:


.gitlab-ci.yml
diff

Make each build job a target/project combo

Modified Files:


.gitlab-ci.yml
diff

See if this fixes error about invalid tag.

Modified Files:


.gitlab-ci.yml
diff

Move gcc/Linux into its own job, tagged "linux".
Add Windows build job.

Modified Files:


src/syncterm/term.c
diff

Add original XMODEM send/receive protocol options.

Previously, SyncTERM only supported the more modern XMODEM-1K uploads and
XMODEM-CRC downloads. This commit adds support for XMODEM-128 uploads and
XMODEM-Checksum downloads.

Modified Files:


exec/nntpservice.js
diff

Merge remote-tracking branch 'origin/master'

Modified Files:


exec/nntpservice.js
diff

Log errors when msgbase open failures occur.

This should help to root-cause any future msgbase open failures like those
that I suspect were a result of Issue #4.

Modified Files:


exec/nntpservice.js
diff

Insure that message base is closed before opening another.

This should address the issue raised by Michael J. Ryan in issue #4.
The command in question ("GROUP") would attempt to open the message
base associated with the specified newsgroup name without closing
the currently open/selected message base (if there was one). This would
result in multiple simultaneously open message bases and could result
in an exhaustion of open file descriptors leading to a failure to open
any additional files (includign message bases) and thus a subsequent
"GROUP" command would fail with the wrong "!no such group" error.

Added Files:


exec/postxtrn.js
diff

exec/prextrn.js
diff

Modified Files:


ctrl/modopts.ini
diff

exec/load/cnfdefs.js
diff

exec/xtrn_sec.js
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/xtrn_sec.cpp
diff

This introduces pre/post execution modules for bbs.exec_xtrn. The logic
previously in xtrn_sec.js for those functions is now in prextrn.js and
postxtrn.js. These handle screen clear, evals, fonts, etc. Now everywhere that
launches an external program will support these features

Added Files:


exec/postxtrn.js
diff

exec/prextrn.js
diff

Modified Files:


ctrl/modopts.ini
diff

exec/load/cnfdefs.js
diff

exec/xtrn_sec.js
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Merge branch 'xtrnexecmodules' into 'master'

External Program Pre/Post Loadable Modules

See merge request sbbs/sbbs!24

Modified Files:


exec/load/sbbsdefs.js
diff

Fix problem with U_* defines introduced in CVS rev 1.100 (Apr-1-2020)

as part of the 8->40 password length enhancement.

Everything after U_OLDPASS was NaN because of a typo (U_PASS not yet defined).

Modified Files:


ctrl/modopts.ini
diff

make it easy for people to change the look of the external programs menu by
presenting them the defaults instead of them having to dig into the code,
text.dat, etc. to get the starting values

Modified Files:


ctrl/modopts.ini
diff

Merge branch 'xtrnmodopts' into 'master'

present external menu option display defaults

See merge request sbbs/sbbs!30

Added Files:


exec/sutils.ini
diff

exec/sutils.js
diff

Removed Files:



exec/badpasswords.js
diff

Synchronet Utilities...a master script to make it easier for new sysops to
understand and use the myriad command line scripts that are available

Added Files:


exec/sutils.ini
diff

exec/sutils.js
diff

Removed Files:



exec/badpasswords.js
diff

Merge branch 'sutil' into 'master'

Synchronet Utilities...a master script to make it easier for new sysops to
understand/use command line scripts

See merge request sbbs/sbbs!27

Modified Files:


src/sbbs3/objects.mk
diff

Add more object files required to link jsdoor

Modified Files:


src/xpdev/genwrap.c
diff

Use the crappy strerror() wrapper for all _WIN32 that's not MSC,
not just for Borland.

Modified Files:


src/xpdev/strwrap.c
diff

src/xpdev/strwrap.h
diff

Add strndup() and strnlen() from FreeBSD (used by RIP support)

Modified Files:


src/syncterm/ripper.c
diff

Use sockwrap.h for arpa/inet.h and strwrap.h for stdndup()

Modified Files:


src/conio/ansi_cio.c
diff

Guard _unlock_file() with _MSC_VER, not _WIN32 (mingw doesn't have it)

Modified Files:


exec/fido-nodelist-browser.js
diff

Update fido-nodelist-browser.js - spinning cursor messing up frame

Removed Files:



exec/load/gnatslib.js
diff

Delete gnatslib.js - another unneeded cvs file

Removed Files:



exec/query_pr.js
diff

exec/send_pr.js
diff

CVS scripts, unneeded

Modified Files:


exec/nntpservice.js
diff

Optimize the newsgroup list part of previous commit.

Don't regenerate the newsgroup_list for *every* authenticated NNTP command.

Modified Files:


exec/nntpservice.js
diff

2 new (mutually exclusive) command-line options: -force and -filter

These options are to attempt to address the issue (#178) reported by Michael J.
Ryan
with regards to a Thunderbird error:
"Sending of the messages failed. You can only send to one news server at a
time."
when attempting to reply to a message that was posted to multiple newsgroups,
but the server has not actually advertised that it serves that newsgroups
(because
it doesn't or the names a different than one the server uses for the same
area).

-force will force the export "Newsgroups" header field to contain only the name
of the locally selectec newsgroup.
-filter will remove any Newsgroup names from the exported "Newsgroups" header
if they don't exist on the local server.

Modified Files:


exec/load/cnfdefs.js
diff

exec/load/cnflib.js
diff

Save/restore padding bytes in .cnf files (instead of writing 0's).

Some padding bytes are expected to be 0xff's (not 0x00's) when
unused by configuration properties.

Also, this insures that this library is compatible with future .cnf files
(i.e. it won't over-write new configuration properties with 0's).

Modified Files:


exec/load/cnfdefs.js
diff

Add missing/newer configuration to main cnf definition.

- min_pwlen
- textsec_mod
- automsg_mod
- xtrnsec_mod
- nodelist_mod
- whosonline_mod
- privatemsg_mod
- logonlist_mod

Since cnflib.js doesn't save/restore padding areas (yet), this explains
why using scripts that use cnflib to update/modify configuration files
could result in some settings being reverted to default or blank values
unexpectedly.

Next-up: fix cnflib so it saves and restores padding areas in .cnf files.

Modified Files:


src/sbbs3/putmsg.cpp
diff

Don't allow adjacent marked-up text.

This allows us to ignore markup codes in a string like: "/sbbs/ctrl/*cnf*"

Modified Files:


src/sbbs3/putmsg.cpp
diff

Don't support back-to-back marks in markup parsing

Addresses false-positive matches in URLs (e.g. https://minftn.net/) where the
second slash was being interpreted as a the beginning of an italic markup.

Removed Files:



exec/gnats_cvs.js
diff

remove unneeded cvs script for updating PRs based on CVS commit logs

Modified Files:


src/sbbs3/js_console.cpp
diff

Address warning: unused variable ‘argv’

Modified Files:


src/sbbs3/answer.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/useredit.cpp
diff

Store client terminal information in node#/terminal.ini

In preparation for node-spy applications that can support multiple terminal
sizes/types (none exist yet). The file is updated whenever there is new/updated
information about the client's terminal.

Exposed as JS method: console.term_updated().

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix sendmail bug introduced in 6851910.

The "MAIL FROM" command argument must always be enclosed in angle-brackets.
Some mail servers (e.g. gmail, aol) would reject messages not delivered in this
manner, e.g.:
mx-aol.mail.gm0.yahoodns.net replied with:
"501 Syntax error in parameters or arguments tnmpmscs"
instead of the expected reply:
"250 ..."
gmail-smtp-in.l.google.com replied with:
"555 5.5.2 Syntax error. o6si11103060plk.317 - gsmtp"
instead of the expected reply:
"250 ..."

Modified Files:


CONTRIBUTING.md
diff

src/sbbs3/addfiles.c
diff

src/sbbs3/allusers.c
diff

src/sbbs3/ansiterm.cpp
diff

src/sbbs3/ars.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/baja.c
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getstr.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_server.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/readtext.c
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/services.c
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/textgen.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/wordwrap.c
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/smblib/smbstr.c
diff

src/smblib/smbtxt.c
diff

src/xpdev/dirwrap.c
diff

src/xpdev/gen_defs.h
diff

src/xpdev/genwrap.c
diff

src/xpdev/ini_file.c
diff

src/xpdev/netwrap.c
diff

Replace ctype.h function calls with new MSVC-safe XPDEV macros

I'm fed-up with MSVC assertions in ctype functions (e.g. isdigit, isprint,
isspace, etc.) when called with out-of-range (e.g. negative) values.

This problem only affects MSVC debug builds, but if you run them (like I do),
these things are like little time bombs that can drive you crazy (knocking your
board out of service).

The new macros names are bit more descriptive as well.

Modified Files:


src/conio/ansi_cio.c
diff

The beginnings of ANSI console support on Windows

It kinda sorta works, but needs more love.

Modified Files:


src/sbbs3/download.cpp
diff

Fix display/loop issue with Disconnect-after-file-transfer prompt

As reported by WitNik, on 32-bit rPi builds, the loop would not
terminate and display transfer count down values after hitting 'H'
to hang-up.

Modified Files:


src/sbbs3/getkey.cpp
diff

Fix logged garbage observed in release rPi3 builds

The "insert key into keybuf" log line could contain garbage. Apparently
in a release build, the nested scope stack variable is actually invalid
after the end of the scope. Weird.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Don't log blank lines output from external programs on *nix

Modified Files:


src/smblib/smballoc.c
diff

Fix warning on 32-bit Linux build with large file support enabled (64-bit
off_t)

Modified Files:


src/sbbs3/main.cpp
diff

Address 32-bit GCC warning about printf format

'%lu' expects argument of type 'long unsigned int', but argument 5 has type
'off_t

Modified Files:


src/sbbs3/websrvr.c
diff

Fix 32-bit GCC warning on rPi about printf format

format '%ld' expects argument of type 'long int', but argument 7 has type
'__off64_t'

Modified Files:


src/sbbs3/logout.cpp
diff

Resolve error on 32-bit *nixes with large file support

ERROR 2 (No such file or directory) in logout.cpp line 189 (backout) opening
"/sbbs/node1/backout.dab"

Modified Files:


src/sbbs3/logout.cpp
diff

Revert "Resolve error on 32-bit *nixes with large file support"

This reverts commit 82756324a88ca339598b30202dd4776a6188d93a.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Detect and reject forged "from" fields in submitted msg headers

For non-authenticated SMTP clients, if the "From:" header field contains a
"name" which appears to be an email address (i.e. it has an '@' in it), and
that address does not match the *actual* address in the "From:" field, reject
the mail with an error message about the forged/mismatched address.

Modified Files:


xtrn/sdk/xsdk.c
diff

Fix infinite loop in 32-bit rPi build, in ultoac() - unsigned char?

Modified Files:


xtrn/sdk/xsdkdefs.h
diff

Merge branch 'master' of gitlab.synchro.net:sbbs/sbbs

Modified Files:


xtrn/sdk/xsdkdefs.h
diff

The CTRL character enum definition cannot be checked via #ifdef

So use check for the USE_XPDEV definition instead of CTRL_A.

Modified Files:


xtrn/sdk/xsdkdefs.h
diff

Revert "Revert "Define CTRL character enum when not already defined.""

This reverts commit 218d283e7cedb591cea0f7de917221ea24cd0fd8

Modified Files:


xtrn/sdk/xsdkdefs.h
diff

Revert "Define CTRL character enum when not already defined."

This reverts commit f488c09ae3459ecdae181435e9cc5d25322cbce7

Modified Files:


src/sbbs3/exec.cpp
diff

Always evaluate js.on_exit() installed expressions.

I noticed that when executing an external JS with the new "Use Shell / New
Context" option set to "Yes", that any expressions (strings) installed via
js.on_exit() were not being executed upon exit from the script. These on-exit
strings are important for restoring global state information (e.g. control key
pass-through, console mode) to the original state before the JS mod made any
changes.

I'm not sure why the special treatment of "scope == NULL" is through-out this
function. Going back to v3.16, it appears this was special treatment for JS
mods invoked via global hot key event (when scope != NULL). When invoking an
xtrn JS mod with the new Context option, the scope argument is not NULL, so
this check was defeating the parsing of the "exit_code" and the evaluation of
any js.on_exit() installed expressions for no apparent reason. I can't think
why global hot key events should be excluded from this logic either.

Modified Files:


xtrn/sdk/xsdkdefs.h
diff

Merge remote-tracking branch 'origin/master'

Modified Files:


xtrn/sdk/xsdkdefs.h
diff

Define CTRL character enum when not already defined.

These are defined in xpdev/gen_defs.h, but not all xsdk doors #include that
(e.g. SBJ).

Modified Files:


exec/lbshell.js
diff

exec/xtrn_sec.js
diff

src/sbbs3/xtrn_sec.cpp
diff

Move the external program "pause on exit" implementation back to the C++ code.

Originally, the "pause on exit" was implemented in the C++ version of
sbbs_t::xtrn_sec() and not sbbs_t::exec_xtrn(). This meant that the pause
option was only implemented when the prgoram was invoked from the menu and
not when invoked directly (e.g. via Baja or JS exec_xtrn function).

When sbbs_t::xtrn_sec() was ported to JS, that functionality was also moved
to JS. But it really should have been implemented in exec_xtrn() to begin
with so that regardless of how the program is invoked, that SCFG setting takes
effect.

Thanks to Michael Long for pointing this out.

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Rewrite recycle_servers()

Added an "All Servers" option.
Fixed the "Telnet server" (now "Terminal Server") to set the correct/modern
semaphore file.
Simplified the implementation of this function.

Modified Files:


exec/xtrn_sec.js
diff

Support text/menu/xtrn<sec-code>.* and text/menu/xtrn<sec-code>_head.* files

Using the xtrn program section internal code protects against renumbering upon
configuration changes (inserting/removing program sections).
At Nelgin's suggestion/request.

Removed Files:



xtrn/bbsfinder.net/bbsfinder.js
diff

xtrn/bbsfinder.net/readme.txt
diff

bbsfinder is defunct

Modified Files:


exec/load/acmev2.js
diff

exec/load/binkp.js
diff

exec/load/fido.js
diff

exec/load/fido_syscfg.js
diff

exec/load/fidocfg.js
diff

exec/load/frame.js
diff

exec/load/ftn_nodelist.js
diff

exec/load/ftp.js
diff

exec/load/graphic.js
diff

exec/load/http.js
diff

exec/load/json-chat.js
diff

exec/load/mouse_getkey.js
diff

exec/load/recordfile.js
diff

exec/load/require.js
diff

exec/load/sprite.js
diff

exec/load/tree.js
diff

Throw Error objects, not Strings.

Error objects are much easier to trace back to the offending line of code.
This was a pretty automated search/replace, so in some cases, it's a
commented-out instance that was changed. I did not convert *all* the load/*.js
files.

Modified Files:


exec/load/text.js
diff

Added HowManyColumns text string enum definition.

Modified Files:


src/sbbs3/putmsg.cpp
diff

Allow punctuation characters on either side of the markup tags

So you can do stuff (*like this*).

Also, we don't need to heavily scrutinize the closing tag when we come upon it
because we already determined it was valid before we accepted the opening
tag/character.

Modified Files:


exec/load/sbbsdefs.js
diff

Add K_CTRLKEYS, P_MARKUP, and P_HIDEMARKS defines, copied from sbbsdefs.h

Modified Files:


src/sbbs3/answer.cpp
diff

Manual terminal settings were cleared when logging in via SSH or RLogin

This appears to go back to a change Deuce made in 2004 (rev 1.41) where ANSI,
COLOR, RIP and WIP user terminal settings were always cleared when logging in
via RLogin.

I happened to notice that manually enabling iCE color support wasn't working
when logging in via RLogin (the iCE color flag would be cleared every login,
but worked fine when logging in via Telnet). Upon investigation, I found that
*all* user's manual terminal settings were cleared for either RLogin or SSH
logins (copy/pasted bug). So... stop doing that. The method of dynamic terminal
capability detection/checking has changed since 2004, so we should not need to
mess with the user's misc flags.

Modified Files:


src/sbbs3/inkey.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/useredit.cpp
diff

Support PETSCII terminals connected to non-PETSCII ports

The reported problem (by John "Jay" Crutti) was:
If autodetection of the terminal is used from the defaults menu I get stuck on
the prompt to hit my Delete key because on the BBS, it keeps showing me login
statistics every time I hit my delete key. 

Add/use new K_CTRLKEYS mode to stop inkey() from handling/eating control-keys
(e.g. Ctrl-T) when asking user to hit backspace during defaults->terminal
settings.

Allow PETSCII_DELETE (Ctrl-T) as a valid option when asking for the
backspace/delete key and set the PETSCII flag in the autoterm variable if hit
by the user.

Modified Files:


src/sbbs3/putmsg.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgsub.c
diff

Support markup tags (optionally) when displaying posts

Defaults to "Off" ("No") and can be set per-sub-board to either:
- "Yes" parse/apply markup style to displayed message text while still
displaying the markup tags
- "Hide" parse/apply markup style to displayed message text and hide (don't
display) the markup tags
- "No", treat marked-up messages the same as any other message text, same as
before.

The supported Markup tags at this time are:
#bold text#
/Italicized text/
_underlined text_
#inverse text#

Now, ANSI-BBS terminals (and Synchronet) do not support the concept of italic
or underlined text (at least, not yet) - so those styles become combinations of
the blink and high-intensity attributes which can be used to choose alternate
fonts and this works well.

These 4 styles were chosen to be compatible with GoldEd's "Style Codes", though
GoldEd is actually very configurable in its support of these tags/codes and its
possible we're not 100% compatible. For example, GoldEd (and SemPoint) both
support the combining of tags/codes to created combinations of styled text -
Synchronet does not (this is consistent with Mozilla/Thunderbird's "Structured
Text").

Multiple words can be styled with a single set of tags, but the first and last
word must be delimited by white-space (this is not consistent with Markdown).

Multiple lines can be styled with a single set of tags, but not multiple
paragraphs (this is consistent with Markdown).

The rules I chose were to minimize false positives but maintain some
interoperability with GoldEd and Thunderbird with a familiar/common tag syntax.

Modified Files:


exec/init-fidonet.js
diff

Use constant for temp node number (9999) instead of repeating the magic number

Don't display the new network's domain if it's not defined.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/str_util.c
diff

Strip ANSI escape sequences from file descriptions

Don't let ANSI terminal control sequence, e.g. from 1337 FILE_ID.DIZs, leak
into file descriptions.

Modified Files:


exec/init-fidonet.js
diff

Fix up the unzip command-line introduced in mlong's enhancements

1. You can't include % specifiers in the string passed to system.exec()
   - this is just a wrapper for system(), it doesn't recongize Synchronet
     command-line specifiers.
   - so I just prepend the exec_dir for Win32, leave off for *nix.
   - it appears this wasn't tested since that command-line would not work.

2. Added 'j' option to unzip. We don't want the extraction of infopacks with
   sub-directories to be creating sub-directories under our ctrl dir.
   We should consider extracting to a temp dir instead of the ctrl dir if
   we don't have absolute control over what's being extracted from downloaded
   zip files. This could be dangerous if we're not extremely careful.

Modified Files:


exec/init-fidonet.js
diff

Simplify the changes to get_linked_node()

Modified Files:


install/GNUmakefile
diff

Build the native doors (sbj, dpoker, tbd) in the sbbs/xtrn dir

Just in case the sysop chose not to specify SYMLINK=1.
As reported by Dan_C via IRC, thanks.

Modified Files:


exec/init-fidonet.ini
diff

As stated in the comments, 'port' key need to be specified if 24554

Modified Files:


src/sbbs3/js_global.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str_util.c
diff

Add strip_ansi() function, expose as JS method

A function/method to strip all ANSI terminal control sequences from a string.

Modified Files:


ctrl/sbbsecho.ini
diff

exec/init-fidonet.ini
diff

exec/init-fidonet.js
diff

Improvements to init fidonet. Add and update network list. Add ability to
download infopack (for manual .NA extraction). Ask for and save tic and packet
passwords. Handle domains.

Modified Files:


exec/init-tickit.ini
diff

exec/init-tickit.js
diff

add tqwnet

Modified Files:


exec/init-fidonet.ini
diff

exec/init-fidonet.js
diff

updates from feedback, add unzip ability (linux)

Modified Files:


exec/init-fidonet.js
diff

change from hardcoded 200 to http_request.status.ok

Modified Files:


exec/init-fidonet.js
diff

use unzip on windows

Modified Files:


exec/init-fidonet.ini
diff

remove empty keys

Modified Files:


exec/init-fidonet.ini
diff

Revert "remove empty keys"

This reverts commit c3d933427d4d9bd38fc2e283187c9f6b6b59bc77.

Modified Files:


exec/init-fidonet.js
diff

Revert "use unzip on windows"

This reverts commit 11a8733a1172849fbf7f078eeeeec6b9e4a84fb7.

Modified Files:


exec/init-fidonet.js
diff

Revert "change from hardcoded 200 to http_request.status.ok"

This reverts commit 00e33392d72bb762ede8c8c6eac895078f64be06.

Modified Files:


exec/init-fidonet.ini
diff

exec/init-fidonet.js
diff

Revert "updates from feedback, add unzip ability (linux)"

This reverts commit d167733c1d485de0ff7bb1a3f89b62c51018b5fb.

Modified Files:


exec/init-tickit.ini
diff

exec/init-tickit.js
diff

Merge branch 'tickitinit' into 'master'

add tqwnet to init tickit

See merge request sbbs/sbbs!19

Modified Files:


CONTRIBUTING.md
diff

That's not how we do italics in markdown apparently.

Added Files:


CONTRIBUTING.md
diff

Created a contributing file to address what seems to be the most common reasons
for rejected merge requests.

Modified Files:


xtrn/knk/knk.js
diff

Fix spelling of "October" as reported by WitNik (BGGRSCYN)

Modified Files:


src/sbbs3/mailsrvr.c
diff

Address warning: type defaults to ‘int’ in declaration

Modified Files:


src/sbbs3/mailsrvr.c
diff

Use a mutex to serial message saving among multiple clients/threads

This work-around shouldn't be necessary, but at least on my Linux/Samba setup,
when GitLab sends out notification emails to subscribers and creates 4+
simultaneous SMTP connections and sends email messages, sometimes (often) it
ends up with a lock-timeout on the mail base. The file locking should handle
the contention fine, but somehow I end up in scenarios where savemsg() takes 30
seconds to complete (the configured SMB lock-timeout is 30 seconds, likely not
a coincidence) - and this causes other clients to timeout trying to lock the
base. Just use a sharead-mutex here instead as a work-around. The wait time is
indefinite, might want to consider using a timed-wait instead.

Modified Files:


webv4/components/twit-button.xjs
diff

Confirm with user before adding someone to twitlist

Modified Files:


webv4/components/twit-button.xjs
diff

Merge branch 'patch-1' into 'master'

Confirm with user before adding someone to twitlist

See merge request sbbs/sbbs!16

Modified Files:


ctrl/text.dat
diff

Support manual terminal columns setting per user

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Fix off-by-one magic number bug introduced in previous commit.

Modified Files:


src/sbbs3/dat_rec.c
diff

src/sbbs3/dat_rec.h
diff

getrec() now returns length of record read

This is useful for detecting blank records.

Modified Files:


src/sbbs3/str_util.c
diff

strcpy() -> SAFECOPY()

Modified Files:


src/sbbs3/ansiterm.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_user.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/useredit.cpp
diff

Support manual terminal columns setting per user

The default terminal columns (still 0/auto) can be overridden with the 'L'
command from the user defaults menu. 

Also increased maximum manual terminal rows setting from 99 to 999 - this
involved moving the record in user.dat, though the old record value is
auto-migrated.

Modified Files:


src/sbbs3/str.cpp
diff

CRLF after each protocol option when less than 80 column terminal

Beautification for 40 column terminals.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Create the pack*.now with fmutex() to prevent simultaneous QWK packs

Probably only a problem on Vertrauen, but some QWKnet nodes, for some unknown
reason, like to FTP-connect multiple times concurrently and request to download
a QWK packet. This creates a race condition where the QWK packet gets
created/downloaded/deleted before the second FTP connection can successfully
download the same file, thus logging an error "opening file " on the server
(VERT). So if the pack*.now file already exists, reject the download request.
"What are doing?" is what I really want to ask these nodes, but better just
throw them an error response and quietly move on.

Modified Files:


src/sbbs3/mailsrvr.c
diff

More log message updates.

Putting IP addresses first.

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/str_util.c
diff

Add condense_whitespace() function.

Created a function to condense all white-space in a string to single
space-characters (e.g. Yoda).

Modified Files:


src/sbbs3/mailsrvr.c
diff

More log message overhaul. POP3 CAPA cmd support in transaction state.

Log the IP address first in most log messages.
Condense white-space in log messages to a single space.
Log the server IP address of incoming connections.
(more) Intelligent email address enclosure in angle-brackets.
Better duplicate address comparison (just for log message).
Fix wrong order of lprintf arguments in !UNKNOWN USER log message (new bug).

Modified Files:


exec/init-fidonet.js
diff

webv4/lib/pages.js
diff

Merge remote-tracking branch 'origin/master'

Modified Files:


webv4/lib/pages.js
diff

When using filename as page name, strip ordering prefix and ext.

Modified Files:


exec/init-fidonet.js
diff

Fix another typo that crashes the script

Modified Files:


exec/init-fidonet.js
diff

Merge branch 'patch-1' into 'master'

Fix another typo that crashes the script

See merge request sbbs/sbbs!15

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix printf format typo.

Modified Files:


src/sbbs3/answer.cpp
diff

This "!CLIENT IP NOT LIST in /path/to/rlogin.cfg" message is weird

This message can be logged when a sysop is prompted for the system password and
enters it incorrectly or just disconnects.

So lower the log level to DEBUG. And include the IP address that we searched
for too.

Modified Files:


src/sbbs3/main.cpp
diff

Don't count guest logins as authenticated connections...

When enforcing the MaxConcurrentConnections limit, don't count connections for
user's with blank passwords (i.e. Guest) as authenticated.