Synchronet Git Commit Log

Modified Files:


exec/imapservice.js
diff

Handle invalid credentials in imapservice

Fixes #401

Modified Files:


exec/lbshell.js
diff

Check undefined.

Fixes #368

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Added a mouse click hotspot for ? for message list mode

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_msg_list_help_hotspot' into 'master'

DDMsgReader: Added a mouse click hotspot for ? for message list mode

See merge request main/sbbs!210

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Refactored how email replies are done (passing the header to the
appropriate functions, not using ungetstr() when prompting for the message
subject

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_email_reply_update' into 'master'

DDMsgReader: Refactored how email replies are done (passing the header to the
appropriate functions, not using ungetstr() when prompting for the message
subject

See merge request main/sbbs!209

Modified Files:


exec/chksetup.js
diff

Check user #1 (sysop) exemptions and restrictions against expectations

Modified Files:


exec/testbuild.js
diff

Need to manually run gitinfo.bat

Modified Files:


exec/freqitcfg.js
diff

Insure call to uifc.bail() when exiting

Modified Files:


exec/ircmsg.js
diff

Extra message delivery insurance as recommended by Cyan months ago

Modified Files:


exec/addfiles.js
diff

Document -auto option

Modified Files:


exec/load/cnfdefs.js
diff

qhub_t node->node_num naming to more consistent with other objs

Modified Files:


src/sbbs3/main.cpp
diff

Fix crash when cleanup() was called twice in a row, e.g. load_cfg failure

Need to nullify the xpms after destroying/freeing (as is done in other
servers already).

Modified Files:


exec/load/cnfdefs.js
diff

Add new/missing 'errlevel' field for timed events

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Removed temporary debug code that accidentally made it in last commit

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_remove_temp_debug_code' into 'master'

Removed temporary debug code that accidentally made it in last commit

See merge request main/sbbs!208

Modified Files:


src/sbbs3/viewfile.cpp
diff

viewfile() now uses case-corrected file path

Sometimes files uploaded may have the wrong case in the filebase (a different
unresolved issue), but for instances where that has happened, make those files
viewable in sbbs. This really only impacts target OSes with case-sensitive
file systems (e.g. *nix).

Modified Files:


src/sbbs3/atcodes.cpp
diff

Fix negative MSG_SCORE @-code on 64-bit (*nix) builds

As reported by Android8675 (SHODAN) on DOVE-Net.
This problem did not manifest itself in 32-bit builds.

Modified Files:


src/sbbs3/services.c
diff

Improve JavaScript-related error messages and fix potential JS runtime leak

If a new JS context could not be created for any reason, a JS runtime would
still be allocated (and leaked), potentially leading to out of memory
situations which had been seen (before this change) on vert.synchro.net.

Modified Files:


src/sbbs3/websrvr.c
diff

Improve JavaScript-related error messages

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Set the control key pass-thru so that some hotkeys (such as Ctrl-P for PageUp)
only get caught by the scripts.

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'DD_area_choosers_ctrl_key_passthru' into 'master'

Set the control key pass-thru so that some hotkeys (such as Ctrl-P for PageUp)
only get caught by the scripts.

See merge request main/sbbs!207

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

fwritelog() will now auto-close a log file when it reaches the max size

Modified Files:


src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Create fwritelog() to go along with fopenlog() and fcloselog()

The functions aren't DLL-exported, so the difference in FILE* support
between an app and a library is not an issue... yet, but it could be
someday, so just for good measure.

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/MainFormUnit.dfm
diff

src/sbbs3/ctrl/MainFormUnit.h
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.h
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

Add "Log Events to Disk" option/checkbox for terminal server "Events"

The "Events" log messages will now be logged to a disk file in
data/events*.log by default (unless this option is disabled).

If the "First node" is > 1, then the base filename will be
"events<first-node>", otherwise, it's just "events". This is because you
would not want multiple instances of sbbs writing to the same events.log
file - that would be chaos. These log files are subject the log
rotation/retention policy defined in SCFG.

This should resolve the FAQ for Windows sysops about what log file to
which their event log messages are being written.

Modified Files:


src/sbbs3/userdat.c
diff

matchuser() now always returns 0 when passed an empty 'name'

Also, don't match against deleted (blank) usernames in name.dat
(e.g. when 'name' value consists of a single ETX character).

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

For SIF output file (SOF) code to upper case

Modified Files:


src/sbbs3/websrvr.c
diff

Log message improvements: include protocol (HTTP vs HTTPS) and IP address

Modified Files:


exec/SlyEdit.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

Used js.on_exit() to set console.ctrlkey_passthru back on exit properly
(SlyEdit, DDMsgReader) and bbs.sys_status (SlyEdit)

Modified Files:


exec/SlyEdit.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'slyedit_ddmsgreader_js_on_exit_ctrl_passthru_sys_status' into
'master'

Proper use of js.on_exit() in DDMsgReader and SlyEdit

See merge request main/sbbs!206

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader v1.54: Users now have a personal twit list (configurable via
Ctrl-U, user settings).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_personal_twit_list' into 'master'

DDMsgReader v1.54: Users now have a personal twit list (configurable via
Ctrl-U, user settings).

See merge request main/sbbs!205

Modified Files:


exec/load/cnfdefs.js
diff

Updates to xedit_t and xtrnsec_t definitions (out of date)

Modified Files:


src/sbbs3/scfg/scfgchat.c
diff

Fix crash when a chat channel references an invalid chat action set

When there are no chat action sets or an action set has been deleted, bad
things would happen (e.g. segfault) when listing chat channels.

Modified Files:


src/sbbs3/websrvr.c
diff

Update log messages for execle() or fork() failures

To be more consistent in syntax and include more details (e.g. the command
being invoked).

Modified Files:


src/sbbs3/filedat.c
diff

Check max_files value in extract_files_from_archive() better

Address issue reported by Nightfox via DOVE-Net:
Today I was using the Archive class to extract exactly one file from a zip
file, and I'm a little confused on the exception throwing behavior regarding
the max_files parameter.  When calling extract(), I gave it a filename pattern
and expected exactly 1 file to be extracted, so I also gave a max_files
argument as 1.  It extracted the one file, but it threw an exception with the
error "Error: maximum number of files (1) extracted (after extracting 1 item
successfully)".

Should that be an error condition to throw an exception? I expected 1 file to
be extracted, and that file was extracted successfully.  If I specify max_files
as 2, then it doesn't throw an exception.   

Modified Files:


exec/sbbslist.js
diff

Update logic for deciding if user can delete/edit entries

Local sysop can always deleted/edit entries (now).
Fixed checking of can_edit() return value (string or true), fixed issue #425
as reported by Craig Hendricks (thank you)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Deleted messages can now be un-marked for deletion from the
message list with the U key (if the user has delete permissions). Also, the
reader now honors the system setting for whether users can view deleted
messages.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_undelete_msgs' into 'master'

DDMsgReader: Deleted messages can now be un-marked for deletion from the
message list with the U key (if the user has delete permissions). Also, the
reader now honors the system setting for whether users can view deleted
messages.

See merge request main/sbbs!203

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

DD area choosers: Updated the lightbar help text to be more consistent with
DDMsgReader

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

Merge branch 'dd_area_choosers_lightbar_help_rearrange' into 'master'

DD area choosers: Updated the lightbar help text to be more consistent with
DDMsgReader

See merge request main/sbbs!204

Modified Files:


exec/xtrn_sec.js
diff

Don't treat Enter as choosing default section when no prompt was shown

As pointed out via DOVE-Net by DesotoFireflite (VALHALLA):
When xtrn_sec.* display file/menu is used, there's no auto-generated
prompt (with a default section number indicated). So hitting Enter
in this case and having the previous/default program section selected
would be surprising behavior to a user. So, only support a default
section selection when there was no xtrn_sec.* menu/display file.

Modified Files:


exec/load/cnflib.js
diff

Strip 0xff chars from strings read from .cnf files

Some unused/padding bytes are written as 0xff, so don't build strings from
those chars.

Modified Files:


src/uifc/uifc32.c
diff

Don't print the up arrow if the list is empty

Modified Files:


exec/load/cnfdefs.js
diff

Support the old 32-bit free-credits-per-day field, for upgrading old cnf files

Modified Files:


src/xpdev/ini_file.c
diff

Don't allow strings that contain 0xFF (truncate at this char value)

1. It's a non-printable char
2. It's the Telnet IAC byte value
3. CNF files use this as an "uninitialized value" indicator

Modified Files:


src/sbbs3/main.cpp
diff

Eliminate newly-unused variable: addr_str

Fixes issue #421

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Mouse click support for the bottom help lines in scrollable mode
(thanks to help from Nelgin)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_scrollable_mouse_click_hotspots' into 'master'

DDMsgReader: Mouse click support for the bottom help lines in scrollable mode
(thanks to help from Nelgin)

See merge request main/sbbs!202

Modified Files:


src/sbbs3/main.cpp
diff

src/xpdev/netwrap.c
diff

Don't use inet_ntop() on Windows as XP didn't include it

As reported by cadeon on Vertrauen, Synchronet v3.19 hasn't worked on Windows
XP due to error:
'The procedure entry point inet_ntop could not be located in the dynamic link
library WS2_32.dll'

Modified Files:


3rdp/win32.release/libarchive/bin/archive.dll
diff

libarchive v3.5.1 built for Windows without bcrypt.dll dependency

Accomplished by manually removing #define HAVE_BCRYPT_H 1 from config.h and
rebuilding using MSVC/Visual Studio IDE. Try as I might I couldn't get the
CMakeLists.txt changes (e.g. setting ENABLE_CNG to OFF) to take effect, but
this seems to have worked.

Why? Because Windows XP didn't include bcrypt.dll (a Microsoft DLL) and we
don't really need it as we don't support password-protected ZIP files anyway.
<shrug>

Modified Files:


ctrl/SlyEdit.cfg
diff

Changed the saveColorsAsANSI value to false. Synchronet does not word-wrap
messages with ANSI.

Modified Files:


ctrl/SlyEdit.cfg
diff

Merge branch 'slyedit_cfg_save_attrs_as_ansi_false' into 'master'

SlyEdit.cfg: Changed the saveColorsAsANSI value to false. Synchronet does not
word-wrap messages with ANSI.

See merge request main/sbbs!200

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Fixed a few errors (a couple related to "use strct", and a couple new errors
related to deleting a message, upvoting, and viewing tallies).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_fix_errors_deleting_upvoting_view_tallies' into
'master'

DDMsgReader: Fixed a few errors (a couple related to "use strct", and a couple
new errors related to deleting a message, upvoting, and viewing tallies).

See merge request main/sbbs!201

Modified Files:


ctrl/modopts.ini
diff

Disable web new user registrations by default to match wiki

http://wiki.synchro.net/config:webv4

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Fix for undeclared variable assignment when saving a message to
the BBS machine

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_save_to_bbs_machine_undeclared_assignment_fix' into
'master'

DDMsgReader: Fix for undeclared variable assignment when saving a message to
the BBS machine

See merge request main/sbbs!199

Modified Files:


exec/load/cnfdefs.js
diff

Better alignment of names with JS object model. Other fixes.

Modified Files:


src/xpdev/genwrap.c
diff

Fix for previous commit and escaped char values > 127 (0x7F)

Modified Files:


src/xpdev/genwrap.c
diff

Escape chars >= 0x7f too (DEL and ex-ASCII/UTF-8 and whatnot)

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

DD file area chooser: Lightbar mode fix for not actually moving to the user's
selected directory when directly choosing a directory in their library

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_file_area_chooser_direct_dir_lightbar_fix' into 'master'

DD file area chooser: Lightbar mode fix for not actually moving to the user's
selected directory when directly choosing a directory in their library

See merge request main/sbbs!198

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/umonitor/umonitor.c
diff

src/syncterm/syncterm.c
diff

Support the -insert (instead of overwrite kbrd mode) option in more UIFC apps

I think this is what nelgin/Keyop was asking for via IRC.

Modified Files:


src/sbbs3/readmsgs.cpp
diff

Fix: message numbers listed with 'H' reading msgs command

Broken in commit 082a9fce 3 years ago, the 'H' (highest ranked) message listing
was showing the rank of the message (e.g. 1-20) instead of the message number
itself.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Don't log error opening DOSXTRN.RET when terminating an external

If we detect a client disconnection and terminate DOSXTRN.EXE, don't try to
open DOSXTRN.RET and log an error when the file doesn't exist (as would be
expected).

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

Support left/right arrow key cycling through more multi-item menus

Modified Files:


exec/load/cnfdefs.js
diff

exec/load/cnflib.js
diff

Define structures for node.cnf

Modified Files:


exec/load/cnfdefs.js
diff

exec/load/cnflib.js
diff

Define structures for chat.cnf

Modified Files:


exec/load/cnfdefs.js
diff

A few property name updates to be more aligned with JS obj model

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the
lightbar list, and strict mode fixes

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_strict_fixes' into 'master'

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the
lightbar list, and strict mode fixes

See merge request main/sbbs!197

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/sbbs.h
diff

Support @-codes in text centered with the CENTER @-code

Note: this centering logic does not know the expanded-size of the @-code, so
use a fixed-length @-code (e.g. with padding) or use the 'C' @-code format
modifier instead.

Fix issue #418

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Scrolling ANSI and "use strict" improvements

Graphic is now only used when using the scrollable interface. Also, when
creating the Graphic, now subtracting 1 from the reading area height to avoid
making the Graphic one line too tall to avoid unnecessary scrolling.
When saving messages with ANSI codes, Graphic is only used if the message has
any ASCII drawing characters. (not sure if this really matters much though).
Also, applied "use strict" and made some changes as necessary.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_ansi_and_strict_improvements' into 'master'

DDMsgReader: Scrolling ANSI and "use strict" improvements

See merge request main/sbbs!195

Modified Files:


src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

Always advance to next message after deleting a message

Also, the logic to check if the user could even view deleted messages (on line
912) was wrong, replace with new method: can_view_deleted_msgs().

As requested by deon (ALTERANT).

Modified Files:


ctrl/SlyDCTColors_Default.cfg
diff

ctrl/SlyDCTColors_Midnight.cfg
diff

ctrl/SlyEdit.cfg
diff

ctrl/SlyIceColors_BlueIce.cfg
diff

ctrl/SlyIceColors_EmeraldCity.cfg
diff

ctrl/SlyIceColors_FieryInferno.cfg
diff

ctrl/SlyIceColors_Fire-N-Ice.cfg
diff

ctrl/SlyIceColors_GenericBlue.cfg
diff

ctrl/SlyIceColors_PurpleHaze.cfg
diff

ctrl/SlyIceColors_ShadesOfGrey.cfg
diff

docs/SlyEdit_ReadMe.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

SlyEidt: Added the ability for the user to choose text color/attribute codes.

Modified Files:


ctrl/SlyDCTColors_Default.cfg
diff

ctrl/SlyDCTColors_Midnight.cfg
diff

ctrl/SlyEdit.cfg
diff

ctrl/SlyIceColors_BlueIce.cfg
diff

ctrl/SlyIceColors_EmeraldCity.cfg
diff

ctrl/SlyIceColors_FieryInferno.cfg
diff

ctrl/SlyIceColors_Fire-N-Ice.cfg
diff

ctrl/SlyIceColors_GenericBlue.cfg
diff

ctrl/SlyIceColors_PurpleHaze.cfg
diff

ctrl/SlyIceColors_ShadesOfGrey.cfg
diff

docs/SlyEdit_ReadMe.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_color_selection_update' into 'master'

SlyEidt: Added the ability for the user to choose text color/attribute codes.

See merge request main/sbbs!193

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

DD file area chooser fix: Listing libraries without first listing directories
within the user's current library (with directory collapsing) works again

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_file_area_chooser_list_libraries_fix' into 'master'

DD file area chooser fix: Listing libraries without first listing
directories...

See merge request main/sbbs!194

Modified Files:


exec/avatar_chooser.js
diff

exec/ftn-setup.js
diff

exec/load/mouse_getkey.js
diff

exec/load/tree.js
diff

exec/xtrn-setup.js
diff

xtrn/minesweeper/minesweeper.js
diff

Use Synchronet's built-in mouse tracking support

Synchronet uses "extended normal" mouse reporting for mouse support
(e.g. menu/display file clickable "hot spots"). Many of the JS scripts
that predated Synchronet's own internal mouse support would send their
own mouse-reporting enablement and disablement ANSI sequences and the
terminal could become out of sync with the expectations of the script
(i.e. it would not necessarily disable the mouse modes that had been
set by SBBS before enabling its own preferred mode).

And some scripts (e.g. Synchronet Minesweeper) use a mixture of Synchronet
hotspot support and direct mouse click coordinate reporting, so it was a
mess going between different mouse reporting modes at different times in the
same script.

This all came to light as a result of the fix for issue #412: using mouse
button releases rather than presses to trigger a hotspot.

So mouse_getkey() now has as a separate "release" property it sets in the
return value. Right now its always the opposite of "press", but I can imagine
some mouse tracking modes where movement might be reported with neither a
button press nor release event.

Anyway, Nelgin, give this a try and see if it resolves the issues you were
reporting in IRC with avatar chooser mouse support.

Modified Files:


src/sbbs3/inkey.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/sbbs.h
diff

Setting console.mouse_mode to true  enables default mouse=enabled mode

A single source of truth is now used for SBBS's mouse mode (MOUSE_MODE_ON). A
JS script doesn't need to know what SBBS's preferred/default mouse-enabled mode
flags are, just set to this property to "true". Setting to "false" is the same
as setting to MOUSE_MODE_OFF (0).

Modified Files:


exec/xtrn_sec.js
diff

Add a carriage-return to the mouse hotspot value when needed

For program listings, if the program number is fewer digits than the total
program list count (number of digits), then a carriage return is required
to launch that program. Automate this for the mouse hotspot value, so clicking
Program #1 in a list of 10+ will just run that program and not require the
user to hit the Enter key.

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix smb.subnum corruption in writemsg()

Fix issue introduced 9 years ago that could cause a crash after replying to a
post via email or netmail and then displaying the header of a poll message or a
normal message with votes:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f9f9569a317 in sbbs_t::show_msg (this=0x7f9f70c56880,
    smb=0x7f9f70c5e4e0, msg=0x7f9ebadf08b0, p_mode=4, post=0x7f9f18071a24)
    at getmsg.cpp:255
255
,cfg.sub[smb->subnum]->misc&SUB_
NAME ? useron.name : useron.alias, NET_NONE, NULL);
[Current thread is 1 (Thread 0x7f9ebadf3700 (LWP 23279))]
(gdb) print smb->subnum
$1 = 4294967295
(gdb) bt
#0  0x00007f9f9569a317 in sbbs_t::show_msg (this=0x7f9f70c56880,
    smb=0x7f9f70c5e4e0, msg=0x7f9ebadf08b0, p_mode=4, post=0x7f9f18071a24)
    at getmsg.cpp:255
#1  0x00007f9f957b2aee in sbbs_t::scanposts (this=0x7f9f70c56880, subnum=9,
    mode=2, find=0x7f9ebadf1270 "") at readmsgs.cpp:670
#2  0x00007f9f957bb75a in sbbs_t::scanallsubs (this=0x7f9f70c56880, mode=2)
    at scansubs.cpp:219
#3  0x00007f9f9568c948 in sbbs_t::exec_msg (this=0x7f9f70c56880,
    csi=0x7f9f70c64768) at execmsg.cpp:315
#4  0x00007f9f95683129 in sbbs_t::exec_function (this=0x7f9f70c56880,
    csi=0x7f9f70c64768) at execfunc.cpp:422
#5  0x00007f9f95679450 in sbbs_t::exec (this=0x7f9f70c56880,
    csi=0x7f9f70c64768) at exec.cpp:1199
#6  0x00007f9f9577d742 in node_thread (arg=0x7f9f70c56880) at main.cpp:4364

writemsg() was changing the global smb.subnum and when writing an email or
netmail, that subnum value is -1 (since it's not a sub-board) and then later
show_msg() is using the smb.subnum as a index into scfg.sub[] when determining
if the current user already voted on the message being displayed and then:
bang, crash, fall down, go boom.

Simply saving and restoring the smb.subnum when executing an external editor is
all that was needed here. And this is the first use of the C++ "auto" keyword
in Synchronet!

Modified Files:


src/sbbs3/getmsg.cpp
diff

Paranoia around use of smb.subnum as an index into scfg.sub[]

Use the is_valid_subnum() function before using the smb.subnum as an index into
(s)cfg.sub[]. Related to the previous committed fix of writemsg(): leaving the
global smb.subnum as -1 (INVALID_SUB) after replying to a post via email or
netmail, resulting in a crash here.

Modified Files:


src/sbbs3/inkey.cpp
diff

Use mouse button release rather than press to activate a hotspot

As described in issue #412, when using extended mouse coordinate (SGR) mode,
the mouse button release sequence would be received by the BBS after the
hotspot-activated menu option was executed and then that button release
sequence possibly passed through to the a child script or program that didn't
know how to handle or ignore it.

To resolve this, the BBS now ignores ("eats") the mouse button *press* sequence
and only acts upon the mouse button *release* sequence. This is more aligned
with how button-clicks work in mouse-control/GUI applications anyway.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Add EXECDIR, DATADIR, and XTRNDIR to DOSemu command replacement tokens

As requested. This closes issue #416

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/xtrn.cpp
diff

Fix Win32 build - we don't #include stdbool.h in sbbs.h

Modified Files:


exec/SlyEdit_Misc.js
diff

Fixed a couple of undefined variable errors.
Also, changed "new Object();" and related syntax to literal object definitions,
and similar for arrays.

Modified Files:


exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_undeclared_vars_2022-06-25' into 'master'

Fixed a couple of undefined variable errors.

See merge request main/sbbs!192

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/xtrn.cpp
diff

Auto-detect (log) scripts/module execution as "native", not 16-bit DOS

Address potential FAQ (issue #415)

Modified Files:


src/sbbs3/inkey.cpp
diff

Indicate whether an SGR mouse button report is a press or release

In the mouse debug log output. Potentially helpful in debugging mouse related
issues when using the SGR mouse reporting mode.

Modified Files:


exec/avatar_chooser.js
diff

Address conflict with Synchronet internal mouse support

1. Don't enable mouse support if the user's terminal is configured to not
   support it.

2. After calling bbs.receive_file() which displays a menu and uses sbbs's
   internal mouse support, which enables a different mouse reporting mode,
   disable the console.mouse_mode (sbbs's internal mouse support) before
   re-enabling the mouse support for the avatar_chooser's own custom mouse
   mode. Fix fixes issue #414 reported by Nelgin.

3. Fixed a typo in a message displayed to user if avatar upload failed.

Modified Files:


exec/load/cnfdefs.js
diff

Add several missing fields that were added since v3.18

With one of the new fields being 64-bit, this lib now requires the updated
File object that supports read/writing 64-bit binary integers too.

Modified Files:


exec/logon.js
diff

Small optimization: don't write user.chat_settings if you don't need to

Modified Files:


exec/webfileindex.ssjs
diff

Do the redir thing for all requests not ending in /, not just dirs

Modified Files:


src/sbbs3/js_file.c
diff

src/xpdev/xpendian.h
diff

Add support for non-native endian 64-bit integers

Modified Files:


src/sbbs3/js_file.c
diff

Add support for reading/writing 8-byte (64-bit) integers in binary files

Modified Files:


exec/load/text.js
diff

Add HashingFile and HashedFile text.dat enum values

Modified Files:


exec/load/cnfdefs.js
diff

Fix: Some integer fields were defined as type:"str"

Modified Files:


exec/avatar_chooser.js
diff

Avoid base64-decoding an empty user_avatar.data

Fixes issue #413, at least the non-mouse related part. I was only
able to reproduce it by trying to use the "Edit your avatar" menu item
after choose "I don't want an avatar".

This "I don't want" menu item is weird however and reappears when
the user exits and reruns the chooser, so there's probably still
some improvements needed with this menu item.

The "Upload an avatar" menu item issue is likely totally unrelated.
Please don't combine unrelated issues in the same bug report.

Modified Files:


src/xpdev/ini_file.c
diff

Fix issue with iniSet* functions and root section

Bug introduced in commit 0d9111a5: iniSet* functions would write key/values to
the end of the list when the root section (NULL) was specified, rather than the
beginning of the list.
The root section always starts at the beginning of the list/file, so I'm not
sure why section_start() was doing anything other than returning 0 for the root
section. It's possible this now breaks iniSortSections() in some way, so that
should be retested with a file with a root section and named sections.

Modified Files:


exec/webfileindex.ssjs
diff

Respond with redir when directory requests are received without trailing slash

HTTP Directory requests without a trailing slash would "work" (the directory
listing would be sent), but the links to files, since they're relative to the
current request location, would be incorrect (missing the directory's virtual
subdir). So send a 301 response if a client requets a directory without a
trailing slash.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

DD file lister: Fix for assignment to undeclared variable in file description
search

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'dd_file_lister_desc_search_undeclared_variable_assignment_fix'
into 'master'

DD file lister: Fix for assignment to undeclared variable in file description
search

See merge request main/sbbs!191

Modified Files:


ctrl/sbbs.ini
diff

Remove DIR_FILES [ftp] Option, removed (no longer applicable) inv 3.19b

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_DCTStuff.js
diff

exec/SlyEdit_IceStuff.js
diff

exec/SlyEdit_Misc.js
diff

exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

Updated dd_lightbar_menu.js and some Digital Distortion mods for strict mode &
made some fixes

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_DCTStuff.js
diff

exec/SlyEdit_IceStuff.js
diff

exec/SlyEdit_Misc.js
diff

exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

Merge branch 'dd_use_strict_and_fixes_1' into 'master'

Added "use strict"; to dd_lightbar_menu.js and some Digital Distortion mods&
made some fixes

See merge request main/sbbs!190

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: When doing a text search, it now ignores the user scan
configuration for sub-boards, to ensure it will show any results of the text
search.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmsgreader_text_search_ignore_scan_cfg' into 'master'

DDMsgReader: Text search now ignores user scan configuration

See merge request main/sbbs!189

Modified Files:


exec/load/attr_conv.js
diff

Replaced \1 with \x01 so that "use strict" can be used

Modified Files:


exec/load/attr_conv.js
diff

Merge branch 'attr_conv_hex_sync_attr_codes' into 'master'

attr_conv.js: Replaced Sync attr literals with hexadecimal version so that "use
strict" can be used

See merge request main/sbbs!188

Modified Files:


src/sbbs3/jsexec.c
diff

Flush console output stream after executing a script

Solves problem of status output lines being interleved with console
output (e.g. from print()) after executing a script.

Modified Files:


src/sbbs3/scfglib2.c
diff

Resolve new warning by including the necessary header file

Modified Files:


src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/scfglib2.c
diff

Init virtual sub-directory name for library sub-dirs

When using the "Access to Sub-directories" option for a library, the
auto-created directories did not have their virtual sub-directory name set.
Pretty sure this was introduced along with the http access to filebases after
v3.19b.

Also, only de-dupe the sub-directory names based on the directory name and not
the code/code-suffix for now. Next up: auto-gen unique internal code when
needed.

Modified Files:


src/syncterm/uifcinit.c
diff

Resolve (new) warning

Modified Files:


src/sbbs3/xtrn.cpp
diff

Log command-line that led to logged error opening DOSXTRN.RET

Modified Files:


src/sbbs3/scfgsave.c
diff

Actually save the library's virtual sub-directory naming option value.

Modified Files:


src/sbbs3/js_console.cpp
diff

Remove unused variable introduced recently

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib2.c
diff

Allow sysop-choice of source of virtual sub-directory source name

By default, each file transfer directory's internal code suffix is
used as the source of the sub-directory of the virtual path used
to represent a file area in the FTP and Web servers. Now, a sysop
can change that source to either each directory's short name or
long name, if they prefer.

For MRO, because he asked (on DOVE-Net).

Modified Files:


exec/load/attr_conv.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader refactor for sysop save to BBS machine & attachments.
DDMsgReader Version 1.49 - Refactor: Simplified saving a message to BBS machine
for sysop (as-is, less processing); removed attachment stuff for pre-Synchronet
3.17; moved hasSyncAttrCodes() to attr_conv.js because that's where it needs to
be.

Modified Files:


exec/load/attr_conv.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_attachents_and_save_refactor' into 'master'

DDMsgReader refactor for sysop save to BBS machine & attachments.

See merge request main/sbbs!187

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Improved display of ANSI messages via the use of the Graphic
object

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_ansi_improvement' into 'master'

DDMsgReader: Improved display of ANSI messages via the use of the Graphic
object

See merge request main/sbbs!186

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

DD File Area Chooser: The "false command-line parameter works again,
allowing the user to choose the file directory within their file library.

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_file_lister_only_dir_fix' into 'master'

DD File Area Chooser: The false command-line parameter works again

See merge request main/sbbs!185

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

DD message area chooser: Updated to try to prevent the error
"this.subBoardListPrintfInfo[pGrpIdx] is undefined" when only choosing a
sub-board within the user's current message group.

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

Merge branch 'dd_msg_area_chooser_only_subboard_change_fix' into 'master'

DD message area chooser: Updated to try to prevent an "undefined" error when
only choosing a sub-board within the user's current message group

See merge request main/sbbs!184

Modified Files:


src/sbbs3/con_out.cpp
diff

Always display a progress() output for count value of 0

This is normally the first count value and even if we *just* output a
progress() for a previous operation, we still want the first progress() call
for the operation to display.

Modified Files:


src/sbbs3/execfile.cpp
diff

Print file library scanning progress and aborted status

Modified Files:


src/sbbs3/js_user.c
diff

Add User close() method

This can be used to force a close of the user.dat file, if open. Rather than
waiting for an out of scope User to get garbage-collected, this method could
be used to force a close of the user.dat file, if it's open.

Modified Files:


src/sbbs3/js_console.cpp
diff

Add console.progress() method

This exposes the Synchronet internal sbbs_t::progress() method used to
display a progress indication bar, e.g. "[ Scanning 10.0% ]" with the bar
backfill effect (when supported by the terminal).

Modified Files:


xtrn/dd_upload_processor/ddup.cfg
diff

xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

DD Upload Processor: Removed the chmod updates because they're actually not
needed.
Some antivirus scanners (such as ClamAV) need a command line parameter to pass
the file permissions descriptor to the scanner.

Modified Files:


xtrn/dd_upload_processor/ddup.cfg
diff

xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

Merge branch 'dd_upload_processor_no_more_chmod' into 'master'

DD Upload Processor: Removed the chmod updates because they're actually not
needed.

See merge request main/sbbs!183

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

DD message area chooser: Updated to try to prevent the error
"this.subBoardListPrintfInfo[pGrpIdx] is undefined"

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_area_chooser_list_printf_info_undefined' into 'master'

DD message area chooser: Updated to try to prevent the error
"this.subBoardListPrintfInfo[pGrpIdx] is undefined"

See merge request main/sbbs!182

Modified Files:


src/conio/ansi_cio.c
diff

Increase size of sprintf buffer to resolve GCC warning about buffer overflow

e.g. directive argument in the range [-255, 2147483645]

Modified Files:


src/build/Common.gmake
diff

Disable "unused-result" warning in release builds

Modified Files:


src/sbbs3/netmail.cpp
diff

Safe string formatting of fido netmail time header field

Suppresses GCC warning. I suppose some of these fields could be more digits
than expected.

Modified Files:


webv4/root/api/events.ssjs
diff

Force a garbage collection in the event "wait forever" loop

This appears to fix the "lots of user.dat files open concurrently" behavior
that remains when a browser/client has the webv4 page open for a long
duration.

Eventually, the User objects created in this loop would be cleaned (and the
user.dat file descriptors closed), but the default garbage collection interval
(configurable) is 1000 calls to the CommonOperationCallback function. This
could
be as as long as 1000 times through this loop before GC occurs.

Since this is not a performance sensitive loop (we have a call to sleep for a
full second) just force a garbage collection for each loop iteration.

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

SlyEdit Version 1.78: Removed high-ascii characters from the SlyEdit JS files;
used ascii() with their numeric ASCII values instead. This should avoid issues
with text editors converting characters incorrectly.

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_remove_hardcoded_high_ascii' into 'master'

SlyEdit: Removed high-ascii characters from the JS files to avoid issues with
editors changing encodings

See merge request main/sbbs!180

Modified Files:


.gitlab-ci.yml
diff

Add CI build for SVDM (Synchronet Virtual DOS Modem) for Windows

Modified Files:


xtrn/dd_upload_processor/readme.txt
diff

dd_upload_processor readme update

Modified Files:


xtrn/dd_upload_processor/readme.txt
diff

Merge branch 'ddup_doc_update' into 'master'

dd_upload_processor readme update

See merge request main/sbbs!179

Modified Files:


src/vdmodem/vdmodem.c
diff

Support unlimited number/address aliases in [alias] section of ini file

Add support for an unlimited number of dial string (e.g. phone number) aliases
in the [alias] section of the read .ini file. While the AT&Z, ATDSn support for
stored numbers should work fine for the same use cases, it's limited to 20
numbers (that could be easily increased) and may be less obvious to users who
it works. The [alias] aliases does not use AT commands to query/store the
number aliases, just .ini file edits.

Re-read .ini file when ATZ command is received. This allows applying dynamic
changes to the .ini file without re-running SVDM.

Address some memory-leaks when reading or making changes to .ini file.

Fix ATIn command results. The normal result format (from an actual modem) is:
<text>
<blank-line>
OK (or 0)

Added Files:


xtrn/dd_upload_processor/ddup.cfg
diff

xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/ddup_cleanup.js
diff

xtrn/dd_upload_processor/ddup_file_types.cfg
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

Removed Files:


xtrn/DDUploadProcessor/FILE_ID.DIZ
diff

Updated Digital Distortion Upload Processor so that the scanning works properly
in Linux (directory permissions)

Added Files:


xtrn/dd_upload_processor/ddup.cfg
diff

xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/ddup_cleanup.js
diff

xtrn/dd_upload_processor/ddup_file_types.cfg
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

Removed Files:


xtrn/DDUploadProcessor/FILE_ID.DIZ
diff

Merge branch 'ddup_linux_update' into 'master'

Updated Digital Distortion Upload Processor so that the scanning works properly
in Linux (directory permissions)

See merge request main/sbbs!178

Modified Files:


src/vdmodem/vdmodem.c
diff

src/vdmodem/vdmodem.vcxproj
diff

Support option modem "speaker" (WAV file playback) control via ATM1 (turn on)

Support optional WAV files via .ini keys:
RingSound
ConnectSound
DisconnectSound

ATM0 turns "speaker" (WAV playback) off (the default), ATM1 turns on.

Ignore ATLn (speaker level), ATT (tone) and ATP (pulse) commands. These are
sometimes found in init strings which we don't want to prematurely fail with
a parse failure and "ERROR" result.

Increment version number to 0.2.

Modified Files:


src/sbbs3/websrvr.c
diff

Perform a JS garbage collection for each new request in a reused session

A reused HTTP session would never (apparently) perform garbage collection.
The evidence of this was the collection of concurrent user.dat file opens
that would never close until the HTTP sessions were closed. Hundreds or
even thousands of open user.dat's have been seen. After this change,
active web server (webv4 UI) users have not caused these spikes in open
user.dat files, at least in my testing.

If no garbage collection was being performed, then likely a lot of JS
heap was being needlessly wasted, which could eventually result in a JS
"out of memory" error. But that's just a theory.

Investigation is needed into why the js_CommonOperationCallback()'s calls to
JS_MaybeGC() were not sufficient to actually perform garbage collection
in this case.

Modified Files:


src/sbbs3/telnet.c
diff

src/sbbs3/telnet.h
diff

Fix Borland build issue: no stdbool.h in C++Builder 6 ... still ;-)

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Fix for miscolored digit(s) in # messages column in the sub-board list when
using the lightbar menu

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_area_chooser_num_msgs_color_fix' into 'master'

DD Area chooser: Fix for miscolored digit(s) in # messages column in the
sub-board list when using the lightbar menu

See merge request main/sbbs!176

Modified Files:


src/vdmodem/vdmodem.c
diff

Reset "hangup event" (dropped DTR indication) upon connection

Resolves issue with SBBS v2.30 not be able to answer an incoming "call".

Modified Files:


src/sbbs3/telnet.c
diff

src/sbbs3/telnet.h
diff

Add telnet_opt_enabled() function that returns true for WILL or DO opt status

An option is enabled/supported regardless of which end makes the request, so
the status can be WILL (an ACK to a remote request) or DO (an ACK to a local
request) when an option is enabled.

Modified Files:


src/vdmodem/vdmodem.c
diff

Enable binary-transmit mode in server by default, disabling CR->CRLF expansion

Don't expand CR->CRLF when in binary mode that was requested locally
(option value is DO, instead of WILL), using new telnet_opt_enabled().

Request binary-transmit mode by default in Telnet server/answer mode.
Set ServerBinary=false in svdm.ini to disable.

This fixes the extra line-feeds in Telnet-server mode.

Modified Files:


src/sbbs3/websrvr.c
diff

Use safe string formatting to squelch warnings

Attempt to address 2 GCC version 11.2.0 2 warnings reported by Nelgin
‘%s’ directive writing up to 3 bytes into a region of size between 1 and
4097

Modified Files:


src/sbbs3/chksmb.c
diff

Fix copy/paste bug discovered/reported by gcc version 11.2.0

... in debug print statement (MD5 hast decoded/printed as SHA-1 hash).

Reported by Nelgin running gcc version 11.2.0 (Ubuntu 11.2.0-19ubuntu1)

Modified Files:


src/vdmodem/readme.txt
diff

Remove a couple wiki marks unintentionally left in place

Modified Files:


src/vdmodem/vdmodem.c
diff

Print build details (date, time, compiler version) with -V output.

Added Files:


src/vdmodem/readme.txt
diff

An initial readme.txt, most of this text comes from the wiki.synchro.net page

Modified Files:


src/sbbs3/sbbsexec.c
diff

Better log messages and yielding upon ReadFile(mailslot) error.

Modified Files:


xtrn/doorscan/doorscan.js
diff

Second part of previous fix recommended by Apam (POSITRON)

Modified Files:


xtrn/doorscan/doorscan.js
diff

Apam's suggested correction for "XDOORSCAN" in the log file

Some shells log every character the user types (e.g. 'X' for external programs)
so we need a newline before the logged DOORSCAN line to be parsed correctly.
From Apam (POSITRON)

Modified Files:


src/sbbs3/ctrl/sbbsctrl.cpp
diff

Fix for new sbbs_get_ini_fname() usage

Modified Files:


src/smblib/smballoc.c
diff

src/smblib/smblib.c
diff

Use PRIdOFF instead of %ld or %lu when formatting off_t values for error msgs

On Win32, an off_t is 64-bits while a long is still a measly 32-bits.

Modified Files:


src/sbbs3/ntsvcs.c
diff

src/sbbs3/textgen.c
diff

Address new warnings/errors by get_ctrl_dir() and sbbs_get_ini_fname() changes

Modified Files:


src/vdmodem/vdmodem.c
diff

src/vdmodem/vdmodem.vcxproj
diff

Add support for IP blocking/filtering via file (ala SBBS ip.can)

svdm.ini IpFilterFile can be set to the path/filename of an "ip filter file",
list of IP addresses or patterns (CIDRv4 notation supported) to refuse
connections from.

This is reusing the same IP filter file logic from SBBS, so the same filter
file syntax/rules apply.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/echocfg.c
diff

src/sbbs3/gtkchat/main.c
diff

src/sbbs3/gtkchat/objects.mk
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/makeuser.c
diff

src/sbbs3/objects.mk
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbs_ini.h
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/scfg/objects.mk
diff

src/sbbs3/smbactiv.c
diff

src/sbbs3/uedit/objects.mk
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/umonitor/objects.mk
diff

src/sbbs3/umonitor/umonitor.c
diff

Address warnings and errors introduced in *nix build from previous commit

Also a bit more constification and cleared up the legacy sbbs_get_ini_fname()
usage: the hostname argument hadn't be used in a long, long time.

Modified Files:


src/vdmodem/vdmodem.c
diff

Accept all incoming connections in listen_thread()

This sets the stage for "Caller-ID" support and IP/host filtering (before
sending a "RING" result and requiring an auto-answer or host/BBS software to
send "ATA").

Modified Files:


src/vdmodem/vdmodem.c
diff

Add "Caller ID" support, enabled with AT#CID=1 or AT+VCID=1

Also controlled via [modem] CallerID key in svdm.ini fiile.
Reports the connected IP address between the first and second RING result.
Required a fix to reset the ringcount to 0 upon new connection.

Simplified the AT command parsing logic a bit.

Added Files:


src/sbbs3/findstr.c
diff

src/sbbs3/findstr.h
diff

Modified Files:


src/sbbs3/echocfg.vcxproj
diff

src/sbbs3/getctrl.c
diff

src/sbbs3/getctrl.h
diff

src/sbbs3/jsexec.vcxproj
diff

src/sbbs3/load_cfg.vcxproj
diff

src/sbbs3/ntsvcs.vcxproj
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbscon.vcxproj
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/textgen.vcxproj
diff

src/sbbs3/userdat.c
diff

Decompose some library files to enable reuse by SVDM (virtual DOS modem)

I just wanted to reuse findstr() in vdmodem.c and I fell down this hole :-)

findstr.* is new (findstr() related functions moved from str_util)
getctrl.* is now finally the real home of get_ctrl_dir(), moved from str_util
trashcan* functions moved from str_util to scfglib
other scfg_t dependent functions moved from str_util to scfglib

net_addr() appears to be a function that was never created/used (?)

This will definitely break the *nix build, for now.

Modified Files:


src/vdmodem/vdmodem.c
diff

Store connecting-client information (e.g. IP address) in file

by default, client.ini in the current working directory.
Configurable filename via ClientFile key in the root section of svdm.ini.

Modified Files:


src/sbbs3/js_user.c
diff

Don't clobber an open user.dat file descriptor in js_CreateUserObject()

Likely fix for the user.dat open file descriptor leak:
If js_CreateUserObject(cx,parent,cfg,"name",...) is called multiple times
(e.g. before login and after login), the successive calls will reuse the
previously allocated JS object and allocated private data memory. However, the
private data memory (which includes the descriptor of an open user.dat file,
if it has been opened), was always zeroed, even if it was being reused. This
would leak open file descriptor.

So any (pre)login scripts or web scripts that use the "user" object (which
is all zeroed-out before login) and then allows a user to subsequently login,
would leak a file descriptor.

Modified Files:


src/sbbs3/str.cpp
diff

Close the open user.dat upon (unlikely/impossible) malloc error

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

Fixed weird character issue from last commit
Fixed a weird character issue from the last commit, that may have been due
to using a different text editor that changed some characters, possibly due to
character encoding

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_badchars_fix' into 'master'

Fixed weird character issue from last commit

See merge request main/sbbs!175

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

SlyEdit 1.77: Fix for aborting when trying to access sub-board information when
there are no sub-boards

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_rare_fix_no_subboards' into 'master'

SlyEdit 1.77: Fix for aborting when trying to access sub-board information when
there are no sub-boards

See merge request main/sbbs!174

Modified Files:


src/sbbs3/sbbsexec.c
diff

Fix compile-breaking typos in last commit

Modified Files:


src/sbbs3/sbbsexec.c
diff

Store the UART register/settings in a struct for easy re-init

Re-init the UART struct in the init routine to avoid confusion when making .ini
file changes with older NTVDMs (including NTVDMx64) which don't re-load the
VDDs for every invocation.

Modified Files:


src/vdmodem/vdmodem.c
diff

Enable experimental sbbsexec modes (e.g. redir DOS I/O)

Added undocumented experimental options -I and -O to enable DOS input and
output interception modes in sbbsexec (e.g. to be used possibly with '-h').
Also -M to specify sbbsexec mode value by number (e.g. 3 to enable DOS
Input/Output redir).

Added '-n' option to specify node number (probably no real value/need).

Safe string formatting.

Modified Files:


src/vdmodem/vdmodem.c
diff

Fix port parsing in dial string

More case-insensitivity in parsing special "number" values (e.g. 'L' for last
number).

Default to Telnet mode (not Raw TCP).
Default to unspecific address family (not IPv4).
Case-insensitive "-telnet" and "-raw" option recognition.

Modified Files:


src/vdmodem/vdmodem.c
diff

Send a "banner" when accepting incoming connections.

Fix a corner case where an invalid command-mode escape sequence (e.g. "+.+.+")
could've been interpreted as valid.

Modified Files:


src/vdmodem/vdmodem.c
diff

Resolve the socket protocol/address family issues with IPv4 vs. IPv6

When listening, the address family cannot be PF_UNSPEC, so default to PF_INET
(IPv4), when not specified.
Not sure why we're setting ai_flags to PF_UNSPEC (copied from syncterm) -
that's just 0, but otherwise the PF_ and AI_ flags are not compatible.
Don't set the ai_flags to anything here since they don't seem to change the
behavior.

Modified Files:


src/vdmodem/vdmodem.vcxproj
diff

Run gitinfo.bat in prebuild event

To (re)generate git_branch.h and git_hash.h every build

Modified Files:


src/vdmodem/vdmodem.c
diff

Increment version to 0.1

Added Files:


src/build/gitinfo.bat
diff

Modified Files:


src/sbbs3/release.bat
diff

src/sbbs3/sbbs.jsdocs.vcxproj
diff

src/sbbs3/sbbs.vcxproj
diff

Move gitinfo.bat to build directory

So it can be reused for other projects more easily

Modified Files:


src/vdmodem/vdmodem.sln
diff

Platform rename x86 -> Win32

To be more consistent with other Synchronet project and solution files.

Added Files:


src/vdmodem/build.bat
diff

src/vdmodem/release.bat
diff

Build files

Added Files:


src/vdmodem/.gitignore
diff

Git-Ignore the git*.h files

Modified Files:


src/vdmodem/vdmodem.c
diff

Include Git branch/hash in detailed version output

svdm -V and "ATi1" output.

Modified Files:


src/vdmodem/vdmodem.c
diff

Don't close externally opened/passed socket descriptors

Set sbbs_hungup event state correctly based on initial online state (i.e. FALSE
if already connected/online).

Allow BusyNotice (string) to be configurable via .ini file.

Modified Files:


src/sbbs3/fossinfo.c
diff

Report FOSSIL port status

Modified Files:


src/vdmodem/vdmodem.c
diff

Save modem "NVRAM" settings to ini file

Support [sockopts] (socket options) settings in ini file

CamelCase the ini key names

Modified Files:


src/vdmodem/vdmodem.c
diff

Usage/syntax help output, read svdm.ini from path of svdm.exe

Support specifying an additional or alternate .ini file to read using -c<fname>
option.

Modified Files:


src/sbbs3/sbbsexec.c
diff

No need to call reset_yield() if we're not calilng maybe_yield()

Modified Files:


exec/load/birthdays.js
diff

Fix loop limit (system.stats.total_users != system.lastuser)

When looping to highest user number, use system.lastuser, not
system.stats.total_users.

This explains why not all userbases would be affected by the just-fixed
issue in js_user.c. If the total_users happens to equal lastuser, then
you would have hit the issue in js_user.c. If you had at least one
deleted or inactive user account, then system.stats.total_users would
be less than system.lastuser and your system would *not* have triggered
that bug.

Modified Files:


src/sbbs3/js_user.c
diff

Fix User.number increment beyond lastuser issue

When the 'number' property of an instance of User was incremented beyond the
last user, the call to fgetuserdat() on subsequent property 'get' operation
would fail and zero-out the user structure (including the user number). This
resulted in an infinite loop in load/birthdays.js where the user number would
go from lastuser to 1 in one operation (u.number++).

Reported by DesotoFireflite (VALHALLA)

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Fixes for searching & related error reporting

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'ddac_search_errors_fix' into 'master'

DD area choosers: Fixes for searching & related error reporting

See merge request main/sbbs!171

Modified Files:


src/vdmodem/vdmodem.sln
diff

src/vdmodem/vdmodem.vcxproj
diff

build/link with xpdev_mt

Build using WinXP-compatible toolset.

Modified Files:


src/xpdev/netwrap.h
diff

Fix error: Undefined structure 'in_addr' in Borland builds

sbbsctrl build failed, it needs another winsock header. <sigh>

Oh what a rabbit hole this has been.

Modified Files:


src/xpdev/netwrap.h
diff

Need ws2tcpip.h for struct ip6_addr definition on Windows

Modified Files:


src/xpdev/xpdev.props
diff

src/xpdev/xpdev_mt.props
diff

xpdev/netwrap now requires IPHlpApi.lib on Windows

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/netwrap.c
diff

src/xpdev/netwrap.h
diff

Move IPv4/v6 address parse functions to netwrap.c

And create IPv4AddressToStr(), a wrapper for inet_ntop (or inet_ntoa, when
inet_ntop isn't available).

Modified Files:


src/xpdev/ini_file.c
diff

Apparently MinGW32 doesn't have inet_ntop() or inet_pton() either

Modified Files:


src/xpdev/ini_file.c
diff

Borland didn't include inet_ntop() or inet_pton()

Fixes CI and nightly build.

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Replace deprecated inet_ntoa and inet_addr function calls

Use inet_ntop and inet_pton instead.

Use 32-bit arguments and return values for IPv4 addressess for all target
platforms (ulong is 64-bit on LP64, e.g. Linux-x64, targets).

Modified Files:


src/vdmodem/vdmodem.c
diff

Implement svdm.ini file support to store settings and modem NVRAM

e.g. AT&W writes the current settings to the [modem] section.

Modified Files:


src/syncterm/bbslist.c
diff

Explain that TAB is used to edit the entry comment in online help

Modified Files:


src/sbbs3/services.c
diff

Allow a per-service "LowestLogLevel" setting

Have a service (e.g. imapservice.js) that logs errors that you'd rather not
fill your error.log file with? Set that service's "LowestLogLevel" to "Warning"
in your services.ini file ("lower" means "more severe" when it comes to log
levels, so this would set the maximum severity to Warning).

Modified Files:


src/vdmodem/vdmodem.c
diff

Set Telnet-server options (e.g. will echo) in answer()

Modified Files:


src/smblib/smbhash.c
diff

Remove trailing whitespace before computing Subject CRC

Some responding programs will automatically remove the trailing white-space
from subject when replying and that would mess up the subject-linkage-by-CRC.
So let's just ignore trailing whitespace in the first place.

Modified Files:


src/sbbs3/sbbsexec.c
diff

Better RTS support

Reducing log output (lowering log level of line 437 from LOG_INFO to LOG_DEBUG)
highlighted an issue with Telix stopping RX. That was fixed by checking RTS in
input_thread(). Qmodem needs RTS checked when writing the MCR.

This improved RTS support has been tested with Telix, Qmodem, Telemate, and
Banacom at full data rates.

Modified Files:


src/vdmodem/vdmodem.c
diff

src/vdmodem/vdmodem.vcxproj
diff

Add Telnet support

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Add "Disable Local Display" option for doors, parse DOSXTRN.ERR

New option to disable local screen display for door programs: sets the 'Screen'
value appropriately in door.sys or pcboard.sys drop files and on Windows,
doesn't create a new console window.

Also, now parsing the DOSXTRN.ERR file created by the latest/greatest
dosxtrn.exe when failing to execute the child/DOS program and log the parsed
error details (errno value and description), helpful in debugging the reason
why a DOS program may not have been successfully executed by DOSXTRN.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Remember the last 'first_msg' property value after msgbase is closed

The other msgbase property values are stored in the smb.status or other
private_t members which retain their value when the message base is closed,
unlike the 'first_msg' property which required a read of the message base index
to get the value (and that doesn't work when the message base is closed, so
would return 0).

for deon (ALTERANT)

Modified Files:


src/sbbs3/file.cpp
diff

Print the upload TCP protocol (when available) w/user name, not host/IP

Long hostnames would prevent the protocol from being shown. Also, non-operators
should be able to see the protocol used to upload files.

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

Support an optional ini filename argument, write to DOSXTRN.ERR

If a 4th optional argument is provided, use that as the ini filename for
virtual UART/FOSSIL driver settings instead of "sbbsexec.ini". Using this
feature requires an updated sbbsexec.dll that supports an ini-filename argument
(instead of a directory) to the VDD_LOAD_INI_FILE command.

If DOSXTRN fails to execute the passed command-line, _spawnvp() returns -1, log
the errno value and description to DOSXTRN.ERR (in the same directory as
DOSXTRN.ENV). This will help diagnose issues executing DOS command-lines (e.g.
file not found).

Upon failure to open/create DOSXTRN.RET, don't prematurely terminate as that
would skip a lot of important cleanup.

Modified Files:


src/sbbs3/sbbsexec.c
diff

src/sbbs3/uartdefs.h
diff

Improvements to virtual UART driver for Windows

In the process of creating/testing the new Synchronet Virtual DOS Modem (SVDM)
project, I made the following significant improvements:

- Don't default the log level to DEBUG for debug builds
- Add a "carrier change" event so carrier low to high transitions can be
tracked too
- Replace several lprintf() calls with lputs() for performance reasons
- Specify 'volatile' storage for pending_interrupts
- Interrupts are re-asserted if there are any pending interrupts after reading
IIR register
- Emulate FIFO enablement
- Support RTS flow control signal
- Remove conditional/configurable yields when polling LSR and MSR register,
would just unnecessarily slow down terminal programs
- Report "DCD change" in MSR correctly
- Clean-up (e.g. close handles) in VDD_CLOSE handler
- VDD_LOAD_INI_FILE allows an optional ini filename (instead of directory) as
its argument - for loading an ini filename other than sbbsexec.ini (e.g.
svdm.ini).

Initialize log level in VDDInitialize(). For versions of Windows/NTVDM that
use/call the "init proc" (this function), we just re-initialize global
variables here.

Added Files:


src/vdmodem/vdmodem.c
diff

src/vdmodem/vdmodem.sln
diff

src/vdmodem/vdmodem.vcxproj
diff

Synchronet Virtual DOS Modem for Windows

First commit.

Right now it just connects/accepts-connections using raw TCP. As demonstrated
in YouTube video:
https://www.youtube.com/watch?v=fxp38Nde3fg

Modified Files:


src/xpdev/sockwrap.c
diff

Fix xp_inet_pton: was just writing 0x02 (address family)to 'dst', always

Tried using this function in a new project and didn't work. My guess: it wasn't
tested. <looks at Deuce>

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Fix CID 174496:  Integer handling issues  (BAD_SHIFT)

Don't repeat call atoi() unnecessarily.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/upload.cpp
diff

Fix DIZ extraction/use for FTP uploads

1. Was not setting f->dir to the correct directory number, so only ftp-uploads
to the *first* directory (dirnum = 0) would extract DIZ files of uploaded
files.

Removing the 'dirnum' parameter to addfile() since that implied that you did
not have to initialize the 'dir' element of the passed file_t, but you do: to
get the correct file path for file size/date detection and the DIZ extraction.

2. Was getting heap-corruption when freeing the imported/formatted DIZ text on
Windows once the above problem was fixed: can't free() in one DLL memory that
was allocated in another DLL. Created and now using free_diz() to free the
memory allocated in read_diz().

format_diz() handles a NULL 'lines' argument correctly/gracefully, so no need
for the NULL lines check in sbbs_t::uploadfile().

Added FTP server log messages for successful file upload or update by user.

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Give the timed event config menu the left/right arrow key treatment

Allows quick traversing through timed events (e.g. for comparison of settings).

Modified Files:


src/sbbs3/xtrn.cpp
diff

When running 16-bit DOS commands "offline" on Windows, don't use dosxtrn

We shouldn't need a virtual UART/FOSSIL driver to execute "offline" program
(e.g. timed events) in the first place, and our virtual UART/FOSSIL for Windows
wouldn't work right in the scenario anyway even if it did load successfully.

This resolves the reported issues with timed events configured as not "native"
returning error 255 (and not running successfully) on Windows with SBBS v3.19.
I'm not even sure what changed exactly in xtrn.cpp, dosxtrn.c, and sbbexec.c
between v3.18 and v3.19 that's causing this to now fail, but it (using DOSXTRN
to run offline DOS programs) really shouldn't have been attempted in the first
place. So that was just a design issue that happened to kind of sort of work up
until v3.19.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgnet.c
diff

Add "Native" option for QWKnet call-out cmd-lines

This really shouldn't be necessary to toggle (at least now) on Windows, since
we treat all off-line executions as "native", but for *nix, it could make a big
difference if trying to invoke a native program or shell script for a QWKnet
call-out and it would either fail due to no DOS support or try to executing
using Linux-DOSEMU (unless the command's program name was in the global "native
program list" configured in SCFG->External Programs).

Modified Files:


src/sbbs3/sexyz.vcxproj
diff

Mutex-protect the ring buffers (as we do in the *nix builds)

This fixes an observed crash in sexyz for Windows. The crash was in
RingBufWrite() where 'remain' was set to -1 (4.2B) apparently because pHead
and/or pTail changed (to pTail=pHead) during the invocation of the
RINGBUF_FILL_LEVEL() macro, because it wasn't thread-safe.

Amazing this problem never came up before.

Modified Files:


src/sbbs3/inkey.cpp
diff

Don't add hot-spots for users of terminals without mouse support

This eliminates some link-list management and the debug-level log message
"Scrolled x mouse hot-spots" for non-mouse-enabled user terminals.

Modified Files:


src/sbbs3/con_out.cpp
diff

Always displays the 100% progress report

... regardless of the timing of the last progress report.
For cases where the progress output isn't erased once done doing the thing.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Sort the batch queues in the .ini files as well

This insures that the 'R'emove file option will work correctly if when
displayed sorted.

Modified Files:


src/sbbs3/zmodem.c
diff

Fix erroneous error message

Subpacket OVERFLOW means received subpacket byte offset is >= the max subpacket
length.

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

Report CTS status in FOSSIL driver (high when outbuf has some space)

Some programs (e.g. sbbs.exe v2.30) check for CTS (when configured/enabled for
hardware flow control), so reflect the signal (Clear To Send) accurately.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

Add batch_list_sort() to sort up/download batch xfer list files

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Add a sort (alphabetical) option when listing batch queues

Modified Files:


exec/load/ircd/server.js
diff

We don't use cmd anymore

Modified Files:


docs/source.html
diff

docs/sysop_commands.html
diff

Redirect to the relevant wiki.synchro.net page

Modified Files:


src/sbbs3/userdat.c
diff

Fix possible underflow conditions in gettimeleft()

If a non-'T' exempt user had already used more time today than their security
level allows, their timeleft would be computed as a negative value due to
integer underflow. Since the return value of this function is assigned to a
ulong (timeleft), this becomes a large positive number. Cap the floor of the
computed time left at 0.

Also fix the potential for underflow that could occur if the system clock
changes while a user is online and 'now' becomes greater than 'starttime'.

Modified Files:


src/sbbs3/logout.cpp
diff

Add comment about race condition

Fixed typo in another comment

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/xtrn_sec.cpp
diff

Dates in drop files are always MM/DD/YY, never DD/MM/YY

Previously, if a sysop had set SCFG->System->Toggles->European Date Format
(DD/MM/YY) to "Yes", then many of the dates in drop files would have been
written in this format. Unfortunately, since most BBS doors and door
development kits were written by Americans, MM/DD/YY format is always assumed.
So fixed that (using new TM_MONTH macro too).

Also, line 37 ("Event Time") of DOOR.SYS was always 00:00, now it'll be the
next event time (in HH:MM format). Unfortunately, that time might be tomorrow
or days away and there's no way to represent *that* fact in the DOOR.SYS file
format. <shrug>

Modified Files:


src/xpdev/xpdev_mt.props
diff

Add winsock library (ws2_32.lib) to multi-threaded xpdev props file

This additional library was already included in the single-threaded version, so
this was just a miss.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Add line 8 (user's real name) to DOORFILE.SR (Solar Realms' drop file)

Apparently this line was added at some point, not sure if it's actually used
in any doors, but here it is anyway.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Populate line 36 (user alias) of door.sys with the current user's handle

Previously, we just always made this a blank line.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Restore ability for MsgBase.open() to open an arbitrary SMB msgbase

Before commit 5da26eca, you could pass Msgbase() the path to an SMB
on the disk and open() it, no configuration needed. As of 2 years
ago, I broke that, and passing a path to an SMB would open the "mail" base
instead - most unexpected. This is a feature of smb_open_sub() which we
switched to using (from smb_open()), so go back to using smb_open() when
an unrecognized code is pass to the constructor.

This has the negative consequence that the "mail" base can't be created
via JS. Probably should fix that.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Use smb_open_sub() for the "mail" base too

This restores the ability for JS MsgBase() to be used to create the
initial mail message base properly, if needed.

This means that the 'subnum' should now be equal to scfg.total_subs
when referencing an arbitrary SMB via path (not in the configuration).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix segfault when printing Bad-echo name after failing to load cfg

This is a weird one: sbbsecho ran right as I was saving msgs.cnf via
SCFG and it seems like it loaded 0-byte msgs.cnf into memory and this
segfault was a result of trying to print sub[INVALID_SUB]->code.

The use of [f]nopen() with proper share perms should have prevented this
(truncated msgs.cnf read) from happening, so there's something else afoot here.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Limit door.sys numeric values to 32767

The DoorFrame door library will about with "Overflow Error" if it reads a
door.sys file with lines 16 (calls), 42 (minute credits), or 52 (posted
messages) with a value > 32767, the maximum positive value of a signed 16-bit
integer. So cap these values in the door.sys file at that maximum. This does
potentially break/limit doors that give minutes using the door.sys drop file,
so use that "modify user data" option in SCFG with care.

Electrosys initially reported this problem with the Lemonade! door game which
was barfing on a line 42 value of 449632.

Modified Files:


xtrn/lord/lord.js
diff

Bump the version

The extra strength bug fix needs a new version number.

Modified Files:


xtrn/lord/lord.js
diff

Fix STR gain after defeating a trainer.

You get str_gained, not str. :(

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Don't zero-out static variables for option index/bar

This prevents re-entry to the door configurations from returning to the
previously highlighted menu option. Not sure why this was, but clearly
re-zeroing static variables makes no sense in the first place.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Fix LAZY_BOOLEAN macro definition

This is what was causing the 'is_utf8' message header property to be created as
a Number instead of a Boolean.

Modified Files:


ctrl/text.dat
diff

String 387 is now used for YouCantUseThatNetmail string

Modified Files:


exec/load/sbbsdefs.js
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

Implement duplicate new-user email address checking (optional)

If a sysop wants to prevent new users from using an email address of an
existing user, they can set SCFG->System->New User Values->Question
Toggles->Force Unique E-mail/NetMail to "Yes".

This partially addresses issue #127, at least for the terminal server.

Modified Files:


exec/str_cmds.js
diff

Log string command invoked by users via log()

On *nix, log() output can go to syslog() and on Windows, it can go to the
event log.

This addresses issue #360.

Modified Files:


src/sbbs3/main.cpp
diff

Truncate node.dab to correct size when initializing any sbbs_t instance

Fixes issue #395

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Address Coverity-reported printf format issue

CID 351997 and 351998

Modified Files:


src/sbbs3/nopen.c
diff

Fix new function: fopenlog()

ftello() returns 0 after fnopen(..., O_APPEND). Use filelength() instead.

Modified Files:


src/sbbs3/main.cpp
diff

Address new GCC warning instance

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Add configurable log size limit and retention count

For the following log files:
  hungup.log
  error.log
  crash.log
  hack.log
  spam.log
  guru.log

... they can be limited in size, in bytes, by the sysop, along with a maximum
retention limit (number of *.#.log files). Configured in
SCFG->System->Advanced.

By default, the limit and keep numbers are 0, so "unlimited" (same behavior as
before). Once sufficiently tested, I'll change the default in a stock main.cnf
file to use a sensible limit (e.g. 10 log files of 10MB each, something like
that).

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Dates shown in file desriptions when extended descriptions are enabled.
When extended file descriptions are enabled, the file date is now shown
with the file description on the last line.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_exted_desc_file_dates' into 'master'

DDFileLister: Dates shown in file desriptions when extended descriptions are
enabled.

See merge request main/sbbs!169

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix packet filename in "Gruned message" log entry on Win32

e.g. "Grunged message (type 2) from 4:80/1 at offset 58 in packet: (null)"

off_t is 64-bit, but long in 32-bit (on Win32), so needs a typecast here in
lprintf() call (otherwise, the upper 4 bytes of the offset are interpreted
as the string address for the corresponding '%s' argument, the filename).

Modified Files:


xtrn/lord2/lord2.js
diff

Un-comment-out the line referencing 'bs' since it's now defined.

Modified Files:


xtrn/lord2/lord2.js
diff

Copy in missing ws and bs variables from lord.js

Modified Files:


src/sbbs3/exec.cpp
diff

Install OperationCallback for all executed JS scripts

JS doors with the "Use Shell or New Context" option enabled in SCFG and JS
modules installed a global hot key handlers would not automatically terminate
when the user disconnected (and js.auto_terminate was true, the default).
I'm not sure why the operation callback was only installed when scope==NULL
but always installing it fixes the issue with some global hot key modules
and JS doors becoming "zombies" when a user disconnects while running them.

Modified Files:


xtrn/tw2/input.js
diff

Check for user disconnection in CheckTerminate()

A user disconnecting while running tw2 would just result in an infinite loop
checking node status and waiting for the user's allowed time to run out (which
may never happen) or for the server to be locally terminated.

This has been happening for years on Vertrauen. Finally now I see why.

Modified Files:


src/sbbs3/qwknodes.c
diff

Send error output to stderr, non-error output to stdout

Fixes issue #390

Modified Files:


exec/load/presence_lib.js
diff

Fix long-standing issue with external program name display

Especially for Guest (G-Exempt) accounts which support multiple
concurrent logons - the 'curxtrn' value stored in the user's record
may not match the external program that was actually last executed
on the node in question, so use the .aux property value (from
node.dab) as is done in the C++ code (e.g. printnodedat()). This insures
that the node_status() output here matches the C/C++ code output
(e.g. when logging on the terminal server).

Still support the 'code-based' external program name look-up since
that usage is relied upon by other modules, but when a number is
passed, use the number to find the right external progarm name
(and we need to subtract one, since aux is a 1-based number).

I've looked at this problem a couple of times before and not sure why
I didn't see the solution. <shrug>

Modified Files:


exec/imapservice.js
diff

Throw more interesting errors when a continuation line read fails

Modified Files:


exec/imapservice.js
diff

Fix TypeError: args[1].toUpperCase is not a function

Issue #389 reported by Keyop:
srvc 0324 IMAPS <Keyop> !JavaScript  /sbbs/exec/imapservice.js line 653:
TypeError: args[1].toUpperCase is not a function

I'm not sure how you reproduce this error or what type args[1] is
(apparently, not a string), but this fix it regardless. Please let me
know.

Modified Files:


exec/load/ansiterm_lib.js
diff

Fix the graphic(BIN)->ANSI->HTML translation issue reported by Keyop

Broken in commit ce01d8a79d0263.
F*ck the English language.

Modified Files:


src/sbbs3/sbbscon.c
diff

Only remove the pid file if it has our pid in it.

Modified Files:


src/sbbs3/websrvr.c
diff

Include client IP address in HTTP-level error log messages

Modified Files:


src/sbbs3/sbbsecho.c
diff

Resolve GCC warnings

Fixes isue #388 - no change in behavior

Modified Files:


exec/webfileindex.ssjs
diff

Change sorting_description from const to var

Since this script can be reloaded in the same scope.

Fixes issue #387.

Modified Files:


src/sbbs3/sbbsecho.c
diff

For sub-boards configured to export "ASCII Only", convert UTF-8 correctly

This converts the body text as well as the to, from, and subject header
fields (first to CP437, then to ASCII).

This should address the issue raised in issue #386 with exporting UTF-8
sequences to some message networks.

Modified Files:


exec/load/file_size.js
diff

Remove the 'B' suffix in file_size_float() output

To match behavior of changed xpdev->byte_estimated_to_str().

If the caller wants a 'B' suffix, they can add it.

Modified Files:


exec/slog.js
diff

Updated to read csts.tab instead of csts.dab

Also changed output to reflect slog.c more closely. I suppose only one of
of these 2 "utilities" to read csts.tab should exist at some point. :-)

Also added suport for "-r" and "-t" to be more modern and *nixy.

Added Files:


exec/webfileindex.ssjs
diff

My initial/simple/ugly dynamic web file index generator

Configured in sbbs.ini [web] by setting:

 FileVpathPrefix = /files/
 FileIndexScript = webfileindex.ssjs

And optionally (if you want your vhosts to get filebase access):

 FileVPathForVHosts = true

You can use an .xjs file if you prefer.

Modified Files:


src/sbbs3/main.cpp
diff

When auto-deleting inactive users, log their real name too.

Modified Files:


src/sbbs3/filedat.c
diff

Fix file list sorting by date, need to use the index not the header

When loadfiles() calls sortfiles(), only the file's index records have been
read in, so trying to sort on any header field won't work.

This bug wasn't observable when sorting by date ascending, since that's the
natural index order of the files already (order imported/added), only
observed when sorting by date descending (newest at the top).

Modified Files:


src/sbbs3/ctrl/StatsFormUnit.cpp
diff

Update comment header block. That's all.

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Total timeon stats in days/hours/min format instead just massive minutes.

Modified Files:


src/sbbs3/ctrl/StatsFormUnit.dfm
diff

Double the width of the "Total" status text boxes

to accommodate larger numbers/strings.

Modified Files:


src/sbbs3/main.cpp
diff

Lower level of new "Logoff time <= logon time" log message

... from ERROR to WARNING, but log the human-readable logon time too.

This condition can easily happen if the system clock is corrected (e.g. a few
seconds via NTP adjustment) during a quick connect/disconnect.

Don't call logoffstats() unless a user actually successfully logged-in. I don't
think sysops actually want all the time bots sit at the logon prompt counted as
"time online" in their stats anyway.

Modified Files:


exec/sutils.ini
diff

Remove dstsedit (it's no longer a thing)

Is anyone actually using sutils.js?

Modified Files:


install/GNUmakefile
diff

remove dstsedit (it's gone)

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

CHAIN.TXT files need CRLF terminated lines

This was a regression (to just LF-terminated lines), an accidental change (from
"text" to "binary" file-open) in commit 07580ea7b1b6e.

Modified Files:


src/sbbs3/getstats.c
diff

Use fnopen() in fopen_dstats() to get open auto-retries

iniFileOpen() does not perform retries and there can be contention for the
ctrl/dsts.ini file.

Modified Files:


src/sbbs3/filedat.c
diff

Some archives don't have DIZ in the root directory

(I'm looking at you, mist1221.zip)

... so first try to extract DIZ files from the root of the archive, then try
again searching nested directories too. <sigh>

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Use PRIu64 for (newly) 64-bit user fields (credits, up/download bytes)

Fixes recently-introduced crash when generating text drop files (e.g. XTRN.DAT,
SFDOORS.DAT, DOOR.SYS, CHAIN.TXT) on Win32 (only) where a 'long int' is still
just 32-bit.

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix slog build more (needs xpdev too, apparently)

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix slog build (now needs libsbbs.so)

Modified Files:


src/sbbs3/date_str.c
diff

src/sbbs3/date_str.h
diff

Add minutes_to_str() function

Generates a "Dd Hh Mm" string from a specified number of minutes.

Modified Files:


src/xpdev/dat_file.c
diff

src/xpdev/dat_file.h
diff

Add Open/CloseFile and ListFree methods

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Add enum CSTATS_FIELD definition

Defines the field indexes for records in csts.ini

Modified Files:


src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

Add parse_cstats() function

Modified Files:


src/sbbs3/ctrl/StatsLogFormUnit.cpp
diff

src/sbbs3/slog.c
diff

src/sbbs3/slog.vcxproj
diff

Pretty much a total rewrite of the csts.* file parsing stuff

Hunting down and destroying some super old SBBS code now. :-)

Modified Files:


src/sbbs3/userdat.c
diff

Posts from QWKnet users don't count as "posts" for local stats

Might add some other statistic for these relayed posts at some point.

Modified Files:


src/xpdev/semfile.c
diff

Fix signed/unsigned compare warning reported by Borland C++.

Modified Files:


src/xpdev/dirwrap.c
diff

Use the pointer *after* checking that its not NULL

Fixes CID 351271

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DDLightbarMenu OnItemNav on initial display
DDLightbarMenu can now optionally call its OnItemNav function when
it's first displayed.  By default this behavior is disabled, but it
can be enabled by setting the (new) callOnItemNavOnStartup property
to true.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_onItemNav_startup' into 'master'

DDLightbarMenu OnItemNav on initial display

See merge request main/sbbs!168

Modified Files:


src/xpdev/dirwrap.c
diff

Fix the globi() change for *nix

I was stripping the path here... oops.

Modified Files:


src/sbbs3/atcodes.cpp
diff

Fix another new GCC warning I missed

Modified Files:


src/sbbs3/gtkchat/objects.mk
diff

Fix build (needed getstats.o)

Modified Files:


src/sbbs3/objects.mk
diff

src/sbbs3/sbbs3.sln
diff

src/sbbs3/targets.mk
diff

Removed Files:


src/sbbs3/dstsedit.c
diff

src/sbbs3/dstsedit.vcxproj
diff

Eliminate DSTSEDIT, no longer needed

*/dsts.dab was replaced by dsts.ini.
*/dsts.ini is just a text file, you don't need a special editor.

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/getstats.c
diff

Resolve new GCC warnings

Modified Files:


src/sbbs3/objects.mk
diff

src/sbbs3/scfg/objects.mk
diff

Fix *nix build, more things need to link with getstats.o now

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Remove unused stub function.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/filelist.vcxproj
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

src/sbbs3/js_system.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/str.cpp
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

Overhaul statistics files

*/dsts.dab (daily statistics and running totals) -> */dsts.ini
*/csts.dab (cumulative statistics / log) -> */csts.tab

* dsts.ini now has both daily and total stats for all fields (not just timeon
and logons).
* dsts.ini is now an easily modifiable text file - no longer need dstsedit
(here-by deprecated and soon to be deleted)
* dsts.ini and csts.tab support 64-bit upload/download byte stats and are very
extensible for future fields to be added or extended > 32-bit (this was the
main inspiration for this overhaul, but it was overdue and already designed for
v4, pretty much)
* csts.tab is a tab-delimited fixed length record format suitable for easy
import to a spreadsheet program or parsing with scripts. Each day is a
128-character LF-delimited record with tab-delimited fields of plain ASCII
text.
* All fields except timeon in dsts.ini files are updated immediately and by
more non-terminal servers (e.g. post statistics from web UI scripts).
* New user stats are tracked more than just for "today".

The upgrade of these files is automatic and built-into SBBS.

Still to do: overhaul the slog utility to support the new csts.tab file format.

Modified Files:


src/sbbs3/text_defaults.c
diff

SubInfoViewFileQ and DirInfoViewFileQ are now blank by default

Modified Files:


src/xpdev/dirwrap.c
diff

Only filename portion of pattern for globi() shall be case-insensitive

Windows doesn't allow multiple directories of the same name only differing in
case, so don't on *nix either.

Modified Files:


exec/load/graphic.js
diff

Add auto_extend option

If set to true, when setting the ANSI property, rather than throwing away
vertically "scrolled" lines, just keep extending the height to accommodate the
new required vertical size (height).

Modified Files:


exec/load/cga_defs.js
diff

Add from_attr_code[] table for mapping Ctrl-A attribute codes to CGA values

Modified Files:


exec/load/ansiterm_lib.js
diff

Define and use standard ANSI attribute codes and mappings to CGA values

Create expand_ctrl_a() method that expands Ctrl-A attribute codes in a string
into ANSI escape sequences.

Modified Files:


exec/msglist.js
diff

Support scrolling ANSI messages in preview and view modes

Supports mixed Ctrl-A and ANSI messages.

ANSIs of any length should display correctly.

ANSIs wider than 79 columns will be truncated (not horizontally scrollable).

Animated ANSIs will not render with their animation sequences in tact. :-(

Modified Files:


ctrl/text.dat
diff

Disable prompt for sub/dir info by default, just show the file

yes/no prompts can be disabled by just setting a string to a blank string.
Disable these prompts by default (you can reeanble in your own text.dat if you
want).

Modified Files:


exec/load/graphic.js
diff

Fix bug

Modified Files:


src/sbbs3/prntfile.cpp
diff

De-duplicate at the first '.' following the filename, not the path

Fix the fix to issue #380.

Thanks for letting me know Keyop.

Modified Files:


src/xpdev/dirwrap.c
diff

Uh, increment the pointer in globi()

Fixes crash reported in #381.

Modified Files:


src/sbbs3/str.cpp
diff

Remove the hard-coded ".msg" extension from data/subs/*.msg display file

And data/dirs/*.msg display file. Now you can have any supported menu file in
this location if you wish.

Modified Files:


src/sbbs3/prntfile.cpp
diff

Detect/display menu files, even if only a .ans version exists

I'm so tired of this 30 year old frequently asked question.

If a sysop really wants their Synchronet BBS to only work correctly for ANSI
users, I suppose that should be their prerogative.

I always felt that by not detecting/displaying menu files when the minimum set
of files was not present, I was helping sysops to identify an issue with their
system (which would not work correctly for non-ANSI users). *And* I always felt
that having a single menu/display file that correctly supported both ANSI and
non-ANSI users was a nice convenience (who really wants to maintain multiple
versions of their menu files?). But I'm so tired of answering this question, I
just give up.

Hopefully this doesn't break anything for anyone. <shrug>

Modified Files:


src/sbbs3/prntfile.cpp
diff

Revert to *.XXcol.* being an exact column width, add *.cXX.* support

That previous commit made all *.40col.msg files display for 80 column users.
Not my intention.

So revert to the previous behavior of *.XXcol.* display files. I didn't want to
go renaming a bunch of menu files as a result of the previous commit and I
didn't want a bunch of sysops with *.XXcol.* files to be suddenly surprised at
their new BBS behavior.

And introduce a new file naming convention, *.cXX.* (where XX is a MINIMUM
column width). This is the same naming convention used by Mystic, which also
treats it is as a minimum terminal width, not a required exact width.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Now calls bbs.edit_msg() to edit an existing message.
Now calls bbs.edit_msg() to edit an existing message (if that function exists -
It
was added in Synchronet 3.18).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_bbs_edit_msg' into 'master'

DDMsgReader: Now calls bbs.edit_msg() to edit an existing message.

See merge request main/sbbs!167

Modified Files:


src/xpdev/dirwrap.c
diff

src/xpdev/dirwrap.h
diff

Introduce case-insensitive version of glob(): globi()

glob() is case-insensitive on Windows already, so create a work-alike for *nix.

Modified Files:


src/sbbs3/prntfile.cpp
diff

Use text/menu/*.###col.* display files for even-wider terminals

e.g. display basename.132col.msg even if the terminal is 133+ columns wide.

Fixes issue #380.

Modified Files:


src/sbbs3/prntfile.cpp
diff

De-dupe random menu filenames by truncating at first dot, rather than last.

Fix for one of the problems described in issue #380.

bbs.menu("random*"); would display column-width-specific files (e.g.
random.132col.msg) even when they weren't appropriate for the current
user terminal width.

This is fixed by truncating the filenames matching the requested pattern at
their first-dot rather than the last.

The downside is, you can't have a set of random.#.* files, where # is the
unique part of the filename and * is the file-type extension. Just use
the naming pattern "random-#.*" instead (or something similar) instead.

Modified Files:


src/sbbs3/scfglib.h
diff

DLL-export is_valid_XXXnum() functions, for web server use

Fixes recently broken Win32 build

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Fix newly-introduced GCC warnings

Modified Files:


ctrl/text.dat
diff

Credits don't need 13 characters to display now

Since we're not displaying the exact value to the byte, with commas

Modified Files:


src/xpdev/genwrap.c
diff

src/xpdev/genwrap.h
diff

byte-count to string routines type unsigned 64-bit int now

We don't have a use case negative byte values in strings anywhere that I can
think of.

Created wrapper for MSFT _ui64toa_() - unsigned 64-bit integer to ASCII string.

Add Petabyte (actually, Pebibyte) support to byte_count_to_str()  and
byte_estimate_to_str().

Removed 'B' suffix from byte_estimate_to_str() output for values < 1024.
Callers may display this returned string followed by "bytes" (or similar) and
thus the 'B' suffix is redundant in that case. If the caller needs a 'B'
suffix, they can detect no suffix and add it.

Modified Files:


src/sbbs3/getstats.c
diff

Add TODO comment about dsts.dab not tracking > 4GB up/downloads

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filelist.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/js_user.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Support user credits and transfer stats > 4GB in total

Credits and daily free credits are accurate to the byte up to (a maximum) of
18446744073709551615 (that's 18 Exbibytes - 1).

User's upload and download byte stats are now similarly extended in maximum
range, but the accuracy is only "to the byte" for values less than
10,000,000,000. Beyond that value, the accuracy declines, but is generally
pretty damn accurate (to 4 decimal places beyond the nearest multiple of a
power of 1024), so I don't expect that to be an issue. This method of storing
upload/download byte stats allowed me to use the same 10-character user record
fields in the user.dat file.

As a side-effect of this enhancements:
* User and file credit values are now expressed in multiples of powers of 1024
(e.g. 4.0G rather than 4,294,967,296).
* Free credits per day per security level has now been extended from 32 to
64-bits (to accommodate values >= 4GB).
* adjustuserrec() now longer takes the record length since we can easily
determine that automatically and don't need more "sources of truth" that can be
out-of-sync (e.g. the U_CDT field length going from 10 to 20 chars with this
change).
* setting the stage for locale-dependent thousands-separators (e.g. space
instead of comma) - currently still hard-coded to comma
* more/better support for files > 4GB in size (e.g. in the batch download
queue)
* user_t ulong fields changed to either uint32_t or uint64_t - I didn't realize
how many long/ulong's remained in the code (which are sometmies 32-bit,
sometimes 64-bit) - ugh
* Steve's ultoac() function renamed to u32toac() and created a C++ wrapper that
still uses the old name, for homage

Modified Files:


src/sbbs3/file.cpp
diff

Fix newly introduced GCC warning

warning: invalid suffix on literal; C++11 requires a space between literal and
string macro

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filelist.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/upload.cpp
diff

src/smblib/smbdefs.h
diff

src/smblib/smblib.c
diff

SMB items (messages or files) can now have 32-bit or 64-bit cost value

To fully support files > 4GB in size in file bases, credit values larger than
32-bits must be supported too.

There's a couple of todo comments/items included in this commit, but that's
mainly to do with messages (which don't really have costs anyway).

The main thing to deal with now is the fact that users can't have more than 4GB
in credits in the first place! That's got to be fixed next.

Modified Files:


src/sbbs3/file.cpp
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


src/sbbs3/file.cpp
diff

Fix newly-encountered GCC warning

comparison of integer expressions of different signedness: ‘off_t’ {aka
‘long int’} and ‘uint64_t’ {aka ‘long unsigned int’}

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/smbutil.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

Support files > 4MB in SMB filebase indexes

Used the reserved 16-bits in the file index record to extend the supported
index-file-size from 4294967295 (4GB) to 281474976710655 (281TB). I think
that's big enough for the foreseeable future. :-)

Modified Files:


src/sbbs3/fmsgdump.c
diff

src/sbbs3/pktdump.c
diff

Get rid of CVS keywords and parsing for revision

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr2.c
diff

Add options to sort directories by file size (ascending or descending)

Size is indexed, so might as well sort by it. This does have an issue with
files >= 4GB in length however, so I'm looking at that next.

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Update the help text for the "file existence check" option

This option actually controls whether the disk will be queried for the current
file size and modification date/time (when listing) too.

Modified Files:


src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

Create some convenience functions for validating lib/dir/grp/sub nums

There are lot of places in the code where subnums and dirnums (especially) are
compared against total_subs and/or total_dirs or >= 0 without a ton of
consistency. We should migrate to use these functions for validity-checking
going forward.

Modified Files:


src/sbbs3/js_filebase.c
diff

File's meta-object's "size" and "time" properties reflect current values

Query the disk for file's current "size" and "time" values when get_list() or
get() method is used with a "detail" level of >= DETAIL.NORMAL and the "check
file existence" toggle option is enabled for this directory in SCFG.

I pondered and contemplated whether this configuration setting should be
checked/applied here or in the various JS scripts (e.g. filelist.js) and
decided here was best to provide the most uniform/expected behavior, even
though there is a performance impact. If a script doesn't need/use these
properties, they should probably be specifying the DETAIL.MIN (minimal) detail
level in their queries anyway, which will then bypass these
performance-impacting disk queries.

Modified Files:


src/sbbs3/websrvr.c
diff

Resolve warning about enum value not handled in switch() statement

Modified Files:


src/build/Common.gmake
diff

Linux needs strlcpy() defined in xpdev

Modified Files:


src/sbbs3/js_system.c
diff

typedefs to suppress warnings about using JS_ValueToECMAUint32 w/int32_t

Modified Files:


src/sbbs3/js_system.c
diff

Use JS_ValueToECMAUint32 for full 32-bit time_t values

Resolves issue with filelist.js trying to pass 4294967295 (-1) to
system.datestr() resulting in:
!JavaScript  /sbbs/exec/filelist.js line 13: Error: can't convert t to an
integer

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

Add dynamic file area/base indexing to web server

By setting sbbs.ini [web] FileIndexScript to an SSJS or XJS script filename,
that script (by default, from your exec directory) will be executed when a file
area/base listing has been http[s]-requested. File area/base requests are of
the form <vpath_prefix> (for the list of libraries), <vpath_prefix>/<lib-name>/
(for list of directories of a library) or
<vpath_prefix>/<lib-name>/<dir-code-suffix>/ (for a list of files in a
directory). The new http_request "lib" and "dir" properties indicate that a
library or directory listing was requested (if neither are defined, that's a
request for the root / list of libs). The same configured script is executed to
handle all 3 types of index/list requests.

A sample script (webfileindex.ssj) will be committed soon.

Authentication (via HTTP-AUTH) will be required if user #0 does not have access
to all libraries or all directories within a required library.

file_area.lib[].link has been changed from "/<vdir>/" to just "<vdir>" (no
slashes) and renamed to "vdir".

file_area.dir[].link has been changed from "/<vpath>/" to "<vpath>/" (no
leading slash) and renamed to "vpath".

Added file_area.dir[].vdir property that contains just the directory's virtual
directory name.

I don't think anyone was using these "link" properties since the dynamic FTP
HTML index scripting feature is no longer supported.

Added can_user_access_lib() to insure that the user has access to at least one
directory of a library before allowing access to the library (e.g. via JS).
Something similar should be created for message groups.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DDLightarMenu: For numbered mode, implemented a fix for refreshing the
menu after the user types an item number to select/highlight it. Also,
added 2 new color settings to specify the color to use for writing the
item numbers: itemNumColor (for non-highlighted items) and
highlightedItemNumColor
(for the current highlighted item).

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_numbered_mode_draw_update' into 'master'

DDLightarMenu: Numbered mode item refresh fix & new item number colors

See merge request main/sbbs!164

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

DD area choosers: For message sub-board/file directory collapsing, if there's
only one sub-group/sub-library, then it won't be collapsed
DD area choosers v1.23: For message sub-board/file directory collapsing, if
there's only one
sub-group/sub-library, then it won't be collapsed, as that wouldn't be very
useful.

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_area_choosers_all_separators_no_collapse' into 'master'

DD area choosers: No sub-board/library collapsing if all have the same
separator

See merge request main/sbbs!165

Modified Files:


src/sbbs3/fmsgdump.c
diff

Fix CID 229603: String not null terminated

Modified Files:


exec/sbbslist.js
diff

Don't prompt yes/no upon remove if run with -quiet option

for Andre

Modified Files:


exec/chat_sec.js
diff

Optional channel list per server configured in modopts.ini

So you have multiple IRC servers configured in modopts.ini and
you want different channel list per server? Just add more
keys to the modopts.ini [chat_sec] section of the form:
<server>=<channel_list>

Where <server> is the IRC server's host name (e.g. irc.synchro.net)
and <channel_list> is a comma-separated list of channels to override
the default list of channels (set with the "irc_channel" key).

For DesotoFireflite (VALHALLA)

Modified Files:


xtrn/lord/lord.js
diff

LORD: Fix daily bank transfer count not being reset properly

Modified Files:


xtrn/lord/lord.js
diff

Merge branch 'eugeneso/lord_bankxfer_fix' into 'master'

LORD: Fix daily bank transfer count not being reset properly

See merge request main/sbbs!163

Modified Files:


xtrn/lord/lord.js
diff

LORD: Fix online duel event
Fixed broken code when taunting opponent
Fixed broken code when aborting after waiting a long time for opponent
to respond.