Synchronet Git Commit Log

Added Files:


src/build/gitinfo.bat
diff

Modified Files:


src/sbbs3/release.bat
diff

src/sbbs3/sbbs.jsdocs.vcxproj
diff

src/sbbs3/sbbs.vcxproj
diff

Move gitinfo.bat to build directory

So it can be reused for other projects more easily

Modified Files:


src/vdmodem/vdmodem.sln
diff

Platform rename x86 -> Win32

To be more consistent with other Synchronet project and solution files.

Added Files:


src/vdmodem/build.bat
diff

src/vdmodem/release.bat
diff

Build files

Added Files:


src/vdmodem/.gitignore
diff

Git-Ignore the git*.h files

Modified Files:


src/vdmodem/vdmodem.c
diff

Include Git branch/hash in detailed version output

svdm -V and "ATi1" output.

Modified Files:


src/vdmodem/vdmodem.c
diff

Don't close externally opened/passed socket descriptors

Set sbbs_hungup event state correctly based on initial online state (i.e. FALSE
if already connected/online).

Allow BusyNotice (string) to be configurable via .ini file.

Modified Files:


src/sbbs3/fossinfo.c
diff

Report FOSSIL port status

Modified Files:


src/vdmodem/vdmodem.c
diff

Save modem "NVRAM" settings to ini file

Support [sockopts] (socket options) settings in ini file

CamelCase the ini key names

Modified Files:


src/vdmodem/vdmodem.c
diff

Usage/syntax help output, read svdm.ini from path of svdm.exe

Support specifying an additional or alternate .ini file to read using -c<fname>
option.

Modified Files:


src/sbbs3/sbbsexec.c
diff

No need to call reset_yield() if we're not calilng maybe_yield()

Modified Files:


exec/load/birthdays.js
diff

Fix loop limit (system.stats.total_users != system.lastuser)

When looping to highest user number, use system.lastuser, not
system.stats.total_users.

This explains why not all userbases would be affected by the just-fixed
issue in js_user.c. If the total_users happens to equal lastuser, then
you would have hit the issue in js_user.c. If you had at least one
deleted or inactive user account, then system.stats.total_users would
be less than system.lastuser and your system would *not* have triggered
that bug.

Modified Files:


src/sbbs3/js_user.c
diff

Fix User.number increment beyond lastuser issue

When the 'number' property of an instance of User was incremented beyond the
last user, the call to fgetuserdat() on subsequent property 'get' operation
would fail and zero-out the user structure (including the user number). This
resulted in an infinite loop in load/birthdays.js where the user number would
go from lastuser to 1 in one operation (u.number++).

Reported by DesotoFireflite (VALHALLA)

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Fixes for searching & related error reporting

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'ddac_search_errors_fix' into 'master'

DD area choosers: Fixes for searching & related error reporting

See merge request main/sbbs!171

Modified Files:


src/vdmodem/vdmodem.sln
diff

src/vdmodem/vdmodem.vcxproj
diff

build/link with xpdev_mt

Build using WinXP-compatible toolset.

Modified Files:


src/xpdev/netwrap.h
diff

Fix error: Undefined structure 'in_addr' in Borland builds

sbbsctrl build failed, it needs another winsock header. <sigh>

Oh what a rabbit hole this has been.

Modified Files:


src/xpdev/netwrap.h
diff

Need ws2tcpip.h for struct ip6_addr definition on Windows

Modified Files:


src/xpdev/xpdev.props
diff

src/xpdev/xpdev_mt.props
diff

xpdev/netwrap now requires IPHlpApi.lib on Windows

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/netwrap.c
diff

src/xpdev/netwrap.h
diff

Move IPv4/v6 address parse functions to netwrap.c

And create IPv4AddressToStr(), a wrapper for inet_ntop (or inet_ntoa, when
inet_ntop isn't available).

Modified Files:


src/xpdev/ini_file.c
diff

Apparently MinGW32 doesn't have inet_ntop() or inet_pton() either

Modified Files:


src/xpdev/ini_file.c
diff

Borland didn't include inet_ntop() or inet_pton()

Fixes CI and nightly build.

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Replace deprecated inet_ntoa and inet_addr function calls

Use inet_ntop and inet_pton instead.

Use 32-bit arguments and return values for IPv4 addressess for all target
platforms (ulong is 64-bit on LP64, e.g. Linux-x64, targets).

Modified Files:


src/vdmodem/vdmodem.c
diff

Implement svdm.ini file support to store settings and modem NVRAM

e.g. AT&W writes the current settings to the [modem] section.

Modified Files:


src/syncterm/bbslist.c
diff

Explain that TAB is used to edit the entry comment in online help

Modified Files:


src/sbbs3/services.c
diff

Allow a per-service "LowestLogLevel" setting

Have a service (e.g. imapservice.js) that logs errors that you'd rather not
fill your error.log file with? Set that service's "LowestLogLevel" to "Warning"
in your services.ini file ("lower" means "more severe" when it comes to log
levels, so this would set the maximum severity to Warning).

Modified Files:


src/vdmodem/vdmodem.c
diff

Set Telnet-server options (e.g. will echo) in answer()

Modified Files:


src/smblib/smbhash.c
diff

Remove trailing whitespace before computing Subject CRC

Some responding programs will automatically remove the trailing white-space
from subject when replying and that would mess up the subject-linkage-by-CRC.
So let's just ignore trailing whitespace in the first place.

Modified Files:


src/sbbs3/sbbsexec.c
diff

Better RTS support

Reducing log output (lowering log level of line 437 from LOG_INFO to LOG_DEBUG)
highlighted an issue with Telix stopping RX. That was fixed by checking RTS in
input_thread(). Qmodem needs RTS checked when writing the MCR.

This improved RTS support has been tested with Telix, Qmodem, Telemate, and
Banacom at full data rates.

Modified Files:


src/vdmodem/vdmodem.c
diff

src/vdmodem/vdmodem.vcxproj
diff

Add Telnet support

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Add "Disable Local Display" option for doors, parse DOSXTRN.ERR

New option to disable local screen display for door programs: sets the 'Screen'
value appropriately in door.sys or pcboard.sys drop files and on Windows,
doesn't create a new console window.

Also, now parsing the DOSXTRN.ERR file created by the latest/greatest
dosxtrn.exe when failing to execute the child/DOS program and log the parsed
error details (errno value and description), helpful in debugging the reason
why a DOS program may not have been successfully executed by DOSXTRN.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Remember the last 'first_msg' property value after msgbase is closed

The other msgbase property values are stored in the smb.status or other
private_t members which retain their value when the message base is closed,
unlike the 'first_msg' property which required a read of the message base index
to get the value (and that doesn't work when the message base is closed, so
would return 0).

for deon (ALTERANT)

Modified Files:


src/sbbs3/file.cpp
diff

Print the upload TCP protocol (when available) w/user name, not host/IP

Long hostnames would prevent the protocol from being shown. Also, non-operators
should be able to see the protocol used to upload files.

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

Support an optional ini filename argument, write to DOSXTRN.ERR

If a 4th optional argument is provided, use that as the ini filename for
virtual UART/FOSSIL driver settings instead of "sbbsexec.ini". Using this
feature requires an updated sbbsexec.dll that supports an ini-filename argument
(instead of a directory) to the VDD_LOAD_INI_FILE command.

If DOSXTRN fails to execute the passed command-line, _spawnvp() returns -1, log
the errno value and description to DOSXTRN.ERR (in the same directory as
DOSXTRN.ENV). This will help diagnose issues executing DOS command-lines (e.g.
file not found).

Upon failure to open/create DOSXTRN.RET, don't prematurely terminate as that
would skip a lot of important cleanup.

Modified Files:


src/sbbs3/sbbsexec.c
diff

src/sbbs3/uartdefs.h
diff

Improvements to virtual UART driver for Windows

In the process of creating/testing the new Synchronet Virtual DOS Modem (SVDM)
project, I made the following significant improvements:

- Don't default the log level to DEBUG for debug builds
- Add a "carrier change" event so carrier low to high transitions can be
tracked too
- Replace several lprintf() calls with lputs() for performance reasons
- Specify 'volatile' storage for pending_interrupts
- Interrupts are re-asserted if there are any pending interrupts after reading
IIR register
- Emulate FIFO enablement
- Support RTS flow control signal
- Remove conditional/configurable yields when polling LSR and MSR register,
would just unnecessarily slow down terminal programs
- Report "DCD change" in MSR correctly
- Clean-up (e.g. close handles) in VDD_CLOSE handler
- VDD_LOAD_INI_FILE allows an optional ini filename (instead of directory) as
its argument - for loading an ini filename other than sbbsexec.ini (e.g.
svdm.ini).

Initialize log level in VDDInitialize(). For versions of Windows/NTVDM that
use/call the "init proc" (this function), we just re-initialize global
variables here.

Added Files:


src/vdmodem/vdmodem.c
diff

src/vdmodem/vdmodem.sln
diff

src/vdmodem/vdmodem.vcxproj
diff

Synchronet Virtual DOS Modem for Windows

First commit.

Right now it just connects/accepts-connections using raw TCP. As demonstrated
in YouTube video:
https://www.youtube.com/watch?v=fxp38Nde3fg

Modified Files:


src/xpdev/sockwrap.c
diff

Fix xp_inet_pton: was just writing 0x02 (address family)to 'dst', always

Tried using this function in a new project and didn't work. My guess: it wasn't
tested. <looks at Deuce>

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Fix CID 174496:  Integer handling issues  (BAD_SHIFT)

Don't repeat call atoi() unnecessarily.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/upload.cpp
diff

Fix DIZ extraction/use for FTP uploads

1. Was not setting f->dir to the correct directory number, so only ftp-uploads
to the *first* directory (dirnum = 0) would extract DIZ files of uploaded
files.

Removing the 'dirnum' parameter to addfile() since that implied that you did
not have to initialize the 'dir' element of the passed file_t, but you do: to
get the correct file path for file size/date detection and the DIZ extraction.

2. Was getting heap-corruption when freeing the imported/formatted DIZ text on
Windows once the above problem was fixed: can't free() in one DLL memory that
was allocated in another DLL. Created and now using free_diz() to free the
memory allocated in read_diz().

format_diz() handles a NULL 'lines' argument correctly/gracefully, so no need
for the NULL lines check in sbbs_t::uploadfile().

Added FTP server log messages for successful file upload or update by user.

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Give the timed event config menu the left/right arrow key treatment

Allows quick traversing through timed events (e.g. for comparison of settings).

Modified Files:


src/sbbs3/xtrn.cpp
diff

When running 16-bit DOS commands "offline" on Windows, don't use dosxtrn

We shouldn't need a virtual UART/FOSSIL driver to execute "offline" program
(e.g. timed events) in the first place, and our virtual UART/FOSSIL for Windows
wouldn't work right in the scenario anyway even if it did load successfully.

This resolves the reported issues with timed events configured as not "native"
returning error 255 (and not running successfully) on Windows with SBBS v3.19.
I'm not even sure what changed exactly in xtrn.cpp, dosxtrn.c, and sbbexec.c
between v3.18 and v3.19 that's causing this to now fail, but it (using DOSXTRN
to run offline DOS programs) really shouldn't have been attempted in the first
place. So that was just a design issue that happened to kind of sort of work up
until v3.19.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgnet.c
diff

Add "Native" option for QWKnet call-out cmd-lines

This really shouldn't be necessary to toggle (at least now) on Windows, since
we treat all off-line executions as "native", but for *nix, it could make a big
difference if trying to invoke a native program or shell script for a QWKnet
call-out and it would either fail due to no DOS support or try to executing
using Linux-DOSEMU (unless the command's program name was in the global "native
program list" configured in SCFG->External Programs).

Modified Files:


src/sbbs3/sexyz.vcxproj
diff

Mutex-protect the ring buffers (as we do in the *nix builds)

This fixes an observed crash in sexyz for Windows. The crash was in
RingBufWrite() where 'remain' was set to -1 (4.2B) apparently because pHead
and/or pTail changed (to pTail=pHead) during the invocation of the
RINGBUF_FILL_LEVEL() macro, because it wasn't thread-safe.

Amazing this problem never came up before.

Modified Files:


src/sbbs3/inkey.cpp
diff

Don't add hot-spots for users of terminals without mouse support

This eliminates some link-list management and the debug-level log message
"Scrolled x mouse hot-spots" for non-mouse-enabled user terminals.

Modified Files:


src/sbbs3/con_out.cpp
diff

Always displays the 100% progress report

... regardless of the timing of the last progress report.
For cases where the progress output isn't erased once done doing the thing.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Sort the batch queues in the .ini files as well

This insures that the 'R'emove file option will work correctly if when
displayed sorted.

Modified Files:


src/sbbs3/zmodem.c
diff

Fix erroneous error message

Subpacket OVERFLOW means received subpacket byte offset is >= the max subpacket
length.

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

Report CTS status in FOSSIL driver (high when outbuf has some space)

Some programs (e.g. sbbs.exe v2.30) check for CTS (when configured/enabled for
hardware flow control), so reflect the signal (Clear To Send) accurately.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

Add batch_list_sort() to sort up/download batch xfer list files

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Add a sort (alphabetical) option when listing batch queues

Modified Files:


exec/load/ircd/server.js
diff

We don't use cmd anymore

Modified Files:


docs/source.html
diff

docs/sysop_commands.html
diff

Redirect to the relevant wiki.synchro.net page

Modified Files:


src/sbbs3/userdat.c
diff

Fix possible underflow conditions in gettimeleft()

If a non-'T' exempt user had already used more time today than their security
level allows, their timeleft would be computed as a negative value due to
integer underflow. Since the return value of this function is assigned to a
ulong (timeleft), this becomes a large positive number. Cap the floor of the
computed time left at 0.

Also fix the potential for underflow that could occur if the system clock
changes while a user is online and 'now' becomes greater than 'starttime'.

Modified Files:


src/sbbs3/logout.cpp
diff

Add comment about race condition

Fixed typo in another comment

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/xtrn_sec.cpp
diff

Dates in drop files are always MM/DD/YY, never DD/MM/YY

Previously, if a sysop had set SCFG->System->Toggles->European Date Format
(DD/MM/YY) to "Yes", then many of the dates in drop files would have been
written in this format. Unfortunately, since most BBS doors and door
development kits were written by Americans, MM/DD/YY format is always assumed.
So fixed that (using new TM_MONTH macro too).

Also, line 37 ("Event Time") of DOOR.SYS was always 00:00, now it'll be the
next event time (in HH:MM format). Unfortunately, that time might be tomorrow
or days away and there's no way to represent *that* fact in the DOOR.SYS file
format. <shrug>

Modified Files:


src/xpdev/xpdev_mt.props
diff

Add winsock library (ws2_32.lib) to multi-threaded xpdev props file

This additional library was already included in the single-threaded version, so
this was just a miss.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Add line 8 (user's real name) to DOORFILE.SR (Solar Realms' drop file)

Apparently this line was added at some point, not sure if it's actually used
in any doors, but here it is anyway.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Populate line 36 (user alias) of door.sys with the current user's handle

Previously, we just always made this a blank line.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Restore ability for MsgBase.open() to open an arbitrary SMB msgbase

Before commit 5da26eca, you could pass Msgbase() the path to an SMB
on the disk and open() it, no configuration needed. As of 2 years
ago, I broke that, and passing a path to an SMB would open the "mail" base
instead - most unexpected. This is a feature of smb_open_sub() which we
switched to using (from smb_open()), so go back to using smb_open() when
an unrecognized code is pass to the constructor.

This has the negative consequence that the "mail" base can't be created
via JS. Probably should fix that.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Use smb_open_sub() for the "mail" base too

This restores the ability for JS MsgBase() to be used to create the
initial mail message base properly, if needed.

This means that the 'subnum' should now be equal to scfg.total_subs
when referencing an arbitrary SMB via path (not in the configuration).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix segfault when printing Bad-echo name after failing to load cfg

This is a weird one: sbbsecho ran right as I was saving msgs.cnf via
SCFG and it seems like it loaded 0-byte msgs.cnf into memory and this
segfault was a result of trying to print sub[INVALID_SUB]->code.

The use of [f]nopen() with proper share perms should have prevented this
(truncated msgs.cnf read) from happening, so there's something else afoot here.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Limit door.sys numeric values to 32767

The DoorFrame door library will about with "Overflow Error" if it reads a
door.sys file with lines 16 (calls), 42 (minute credits), or 52 (posted
messages) with a value > 32767, the maximum positive value of a signed 16-bit
integer. So cap these values in the door.sys file at that maximum. This does
potentially break/limit doors that give minutes using the door.sys drop file,
so use that "modify user data" option in SCFG with care.

Electrosys initially reported this problem with the Lemonade! door game which
was barfing on a line 42 value of 449632.

Modified Files:


xtrn/lord/lord.js
diff

Bump the version

The extra strength bug fix needs a new version number.

Modified Files:


xtrn/lord/lord.js
diff

Fix STR gain after defeating a trainer.

You get str_gained, not str. :(

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Don't zero-out static variables for option index/bar

This prevents re-entry to the door configurations from returning to the
previously highlighted menu option. Not sure why this was, but clearly
re-zeroing static variables makes no sense in the first place.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Fix LAZY_BOOLEAN macro definition

This is what was causing the 'is_utf8' message header property to be created as
a Number instead of a Boolean.

Modified Files:


ctrl/text.dat
diff

String 387 is now used for YouCantUseThatNetmail string

Modified Files:


exec/load/sbbsdefs.js
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

Implement duplicate new-user email address checking (optional)

If a sysop wants to prevent new users from using an email address of an
existing user, they can set SCFG->System->New User Values->Question
Toggles->Force Unique E-mail/NetMail to "Yes".

This partially addresses issue #127, at least for the terminal server.

Modified Files:


exec/str_cmds.js
diff

Log string command invoked by users via log()

On *nix, log() output can go to syslog() and on Windows, it can go to the
event log.

This addresses issue #360.

Modified Files:


src/sbbs3/main.cpp
diff

Truncate node.dab to correct size when initializing any sbbs_t instance

Fixes issue #395

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Address Coverity-reported printf format issue

CID 351997 and 351998

Modified Files:


src/sbbs3/nopen.c
diff

Fix new function: fopenlog()

ftello() returns 0 after fnopen(..., O_APPEND). Use filelength() instead.

Modified Files:


src/sbbs3/main.cpp
diff

Address new GCC warning instance

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Add configurable log size limit and retention count

For the following log files:
  hungup.log
  error.log
  crash.log
  hack.log
  spam.log
  guru.log

... they can be limited in size, in bytes, by the sysop, along with a maximum
retention limit (number of *.#.log files). Configured in
SCFG->System->Advanced.

By default, the limit and keep numbers are 0, so "unlimited" (same behavior as
before). Once sufficiently tested, I'll change the default in a stock main.cnf
file to use a sensible limit (e.g. 10 log files of 10MB each, something like
that).

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Dates shown in file desriptions when extended descriptions are enabled.
When extended file descriptions are enabled, the file date is now shown
with the file description on the last line.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_exted_desc_file_dates' into 'master'

DDFileLister: Dates shown in file desriptions when extended descriptions are
enabled.

See merge request main/sbbs!169

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix packet filename in "Gruned message" log entry on Win32

e.g. "Grunged message (type 2) from 4:80/1 at offset 58 in packet: (null)"

off_t is 64-bit, but long in 32-bit (on Win32), so needs a typecast here in
lprintf() call (otherwise, the upper 4 bytes of the offset are interpreted
as the string address for the corresponding '%s' argument, the filename).

Modified Files:


xtrn/lord2/lord2.js
diff

Un-comment-out the line referencing 'bs' since it's now defined.

Modified Files:


xtrn/lord2/lord2.js
diff

Copy in missing ws and bs variables from lord.js

Modified Files:


src/sbbs3/exec.cpp
diff

Install OperationCallback for all executed JS scripts

JS doors with the "Use Shell or New Context" option enabled in SCFG and JS
modules installed a global hot key handlers would not automatically terminate
when the user disconnected (and js.auto_terminate was true, the default).
I'm not sure why the operation callback was only installed when scope==NULL
but always installing it fixes the issue with some global hot key modules
and JS doors becoming "zombies" when a user disconnects while running them.

Modified Files:


xtrn/tw2/input.js
diff

Check for user disconnection in CheckTerminate()

A user disconnecting while running tw2 would just result in an infinite loop
checking node status and waiting for the user's allowed time to run out (which
may never happen) or for the server to be locally terminated.

This has been happening for years on Vertrauen. Finally now I see why.

Modified Files:


src/sbbs3/qwknodes.c
diff

Send error output to stderr, non-error output to stdout

Fixes issue #390

Modified Files:


exec/load/presence_lib.js
diff

Fix long-standing issue with external program name display

Especially for Guest (G-Exempt) accounts which support multiple
concurrent logons - the 'curxtrn' value stored in the user's record
may not match the external program that was actually last executed
on the node in question, so use the .aux property value (from
node.dab) as is done in the C++ code (e.g. printnodedat()). This insures
that the node_status() output here matches the C/C++ code output
(e.g. when logging on the terminal server).

Still support the 'code-based' external program name look-up since
that usage is relied upon by other modules, but when a number is
passed, use the number to find the right external progarm name
(and we need to subtract one, since aux is a 1-based number).

I've looked at this problem a couple of times before and not sure why
I didn't see the solution. <shrug>

Modified Files:


exec/imapservice.js
diff

Throw more interesting errors when a continuation line read fails

Modified Files:


exec/imapservice.js
diff

Fix TypeError: args[1].toUpperCase is not a function

Issue #389 reported by Keyop:
srvc 0324 IMAPS <Keyop> !JavaScript  /sbbs/exec/imapservice.js line 653:
TypeError: args[1].toUpperCase is not a function

I'm not sure how you reproduce this error or what type args[1] is
(apparently, not a string), but this fix it regardless. Please let me
know.

Modified Files:


exec/load/ansiterm_lib.js
diff

Fix the graphic(BIN)->ANSI->HTML translation issue reported by Keyop

Broken in commit ce01d8a79d0263.
F*ck the English language.

Modified Files:


src/sbbs3/sbbscon.c
diff

Only remove the pid file if it has our pid in it.

Modified Files:


src/sbbs3/websrvr.c
diff

Include client IP address in HTTP-level error log messages

Modified Files:


src/sbbs3/sbbsecho.c
diff

Resolve GCC warnings

Fixes isue #388 - no change in behavior

Modified Files:


exec/webfileindex.ssjs
diff

Change sorting_description from const to var

Since this script can be reloaded in the same scope.

Fixes issue #387.

Modified Files:


src/sbbs3/sbbsecho.c
diff

For sub-boards configured to export "ASCII Only", convert UTF-8 correctly

This converts the body text as well as the to, from, and subject header
fields (first to CP437, then to ASCII).

This should address the issue raised in issue #386 with exporting UTF-8
sequences to some message networks.

Modified Files:


exec/load/file_size.js
diff

Remove the 'B' suffix in file_size_float() output

To match behavior of changed xpdev->byte_estimated_to_str().

If the caller wants a 'B' suffix, they can add it.

Modified Files:


exec/slog.js
diff

Updated to read csts.tab instead of csts.dab

Also changed output to reflect slog.c more closely. I suppose only one of
of these 2 "utilities" to read csts.tab should exist at some point. :-)

Also added suport for "-r" and "-t" to be more modern and *nixy.

Added Files:


exec/webfileindex.ssjs
diff

My initial/simple/ugly dynamic web file index generator

Configured in sbbs.ini [web] by setting:

 FileVpathPrefix = /files/
 FileIndexScript = webfileindex.ssjs

And optionally (if you want your vhosts to get filebase access):

 FileVPathForVHosts = true

You can use an .xjs file if you prefer.

Modified Files:


src/sbbs3/main.cpp
diff

When auto-deleting inactive users, log their real name too.

Modified Files:


src/sbbs3/filedat.c
diff

Fix file list sorting by date, need to use the index not the header

When loadfiles() calls sortfiles(), only the file's index records have been
read in, so trying to sort on any header field won't work.

This bug wasn't observable when sorting by date ascending, since that's the
natural index order of the files already (order imported/added), only
observed when sorting by date descending (newest at the top).

Modified Files:


src/sbbs3/ctrl/StatsFormUnit.cpp
diff

Update comment header block. That's all.

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Total timeon stats in days/hours/min format instead just massive minutes.

Modified Files:


src/sbbs3/ctrl/StatsFormUnit.dfm
diff

Double the width of the "Total" status text boxes

to accommodate larger numbers/strings.

Modified Files:


src/sbbs3/main.cpp
diff

Lower level of new "Logoff time <= logon time" log message

... from ERROR to WARNING, but log the human-readable logon time too.

This condition can easily happen if the system clock is corrected (e.g. a few
seconds via NTP adjustment) during a quick connect/disconnect.

Don't call logoffstats() unless a user actually successfully logged-in. I don't
think sysops actually want all the time bots sit at the logon prompt counted as
"time online" in their stats anyway.

Modified Files:


exec/sutils.ini
diff

Remove dstsedit (it's no longer a thing)

Is anyone actually using sutils.js?

Modified Files:


install/GNUmakefile
diff

remove dstsedit (it's gone)

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

CHAIN.TXT files need CRLF terminated lines

This was a regression (to just LF-terminated lines), an accidental change (from
"text" to "binary" file-open) in commit 07580ea7b1b6e.

Modified Files:


src/sbbs3/getstats.c
diff

Use fnopen() in fopen_dstats() to get open auto-retries

iniFileOpen() does not perform retries and there can be contention for the
ctrl/dsts.ini file.

Modified Files:


src/sbbs3/filedat.c
diff

Some archives don't have DIZ in the root directory

(I'm looking at you, mist1221.zip)

... so first try to extract DIZ files from the root of the archive, then try
again searching nested directories too. <sigh>

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Use PRIu64 for (newly) 64-bit user fields (credits, up/download bytes)

Fixes recently-introduced crash when generating text drop files (e.g. XTRN.DAT,
SFDOORS.DAT, DOOR.SYS, CHAIN.TXT) on Win32 (only) where a 'long int' is still
just 32-bit.

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix slog build more (needs xpdev too, apparently)

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix slog build (now needs libsbbs.so)

Modified Files:


src/sbbs3/date_str.c
diff

src/sbbs3/date_str.h
diff

Add minutes_to_str() function

Generates a "Dd Hh Mm" string from a specified number of minutes.

Modified Files:


src/xpdev/dat_file.c
diff

src/xpdev/dat_file.h
diff

Add Open/CloseFile and ListFree methods

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Add enum CSTATS_FIELD definition

Defines the field indexes for records in csts.ini

Modified Files:


src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

Add parse_cstats() function

Modified Files:


src/sbbs3/ctrl/StatsLogFormUnit.cpp
diff

src/sbbs3/slog.c
diff

src/sbbs3/slog.vcxproj
diff

Pretty much a total rewrite of the csts.* file parsing stuff

Hunting down and destroying some super old SBBS code now. :-)

Modified Files:


src/sbbs3/userdat.c
diff

Posts from QWKnet users don't count as "posts" for local stats

Might add some other statistic for these relayed posts at some point.

Modified Files:


src/xpdev/semfile.c
diff

Fix signed/unsigned compare warning reported by Borland C++.

Modified Files:


src/xpdev/dirwrap.c
diff

Use the pointer *after* checking that its not NULL

Fixes CID 351271

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DDLightbarMenu OnItemNav on initial display
DDLightbarMenu can now optionally call its OnItemNav function when
it's first displayed.  By default this behavior is disabled, but it
can be enabled by setting the (new) callOnItemNavOnStartup property
to true.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_onItemNav_startup' into 'master'

DDLightbarMenu OnItemNav on initial display

See merge request main/sbbs!168

Modified Files:


src/xpdev/dirwrap.c
diff

Fix the globi() change for *nix

I was stripping the path here... oops.

Modified Files:


src/sbbs3/atcodes.cpp
diff

Fix another new GCC warning I missed

Modified Files:


src/sbbs3/gtkchat/objects.mk
diff

Fix build (needed getstats.o)

Modified Files:


src/sbbs3/objects.mk
diff

src/sbbs3/sbbs3.sln
diff

src/sbbs3/targets.mk
diff

Removed Files:


src/sbbs3/dstsedit.c
diff

src/sbbs3/dstsedit.vcxproj
diff

Eliminate DSTSEDIT, no longer needed

*/dsts.dab was replaced by dsts.ini.
*/dsts.ini is just a text file, you don't need a special editor.

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/getstats.c
diff

Resolve new GCC warnings

Modified Files:


src/sbbs3/objects.mk
diff

src/sbbs3/scfg/objects.mk
diff

Fix *nix build, more things need to link with getstats.o now

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Remove unused stub function.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/filelist.vcxproj
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

src/sbbs3/js_system.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/str.cpp
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

Overhaul statistics files

*/dsts.dab (daily statistics and running totals) -> */dsts.ini
*/csts.dab (cumulative statistics / log) -> */csts.tab

* dsts.ini now has both daily and total stats for all fields (not just timeon
and logons).
* dsts.ini is now an easily modifiable text file - no longer need dstsedit
(here-by deprecated and soon to be deleted)
* dsts.ini and csts.tab support 64-bit upload/download byte stats and are very
extensible for future fields to be added or extended > 32-bit (this was the
main inspiration for this overhaul, but it was overdue and already designed for
v4, pretty much)
* csts.tab is a tab-delimited fixed length record format suitable for easy
import to a spreadsheet program or parsing with scripts. Each day is a
128-character LF-delimited record with tab-delimited fields of plain ASCII
text.
* All fields except timeon in dsts.ini files are updated immediately and by
more non-terminal servers (e.g. post statistics from web UI scripts).
* New user stats are tracked more than just for "today".

The upgrade of these files is automatic and built-into SBBS.

Still to do: overhaul the slog utility to support the new csts.tab file format.

Modified Files:


src/sbbs3/text_defaults.c
diff

SubInfoViewFileQ and DirInfoViewFileQ are now blank by default

Modified Files:


src/xpdev/dirwrap.c
diff

Only filename portion of pattern for globi() shall be case-insensitive

Windows doesn't allow multiple directories of the same name only differing in
case, so don't on *nix either.

Modified Files:


exec/load/graphic.js
diff

Add auto_extend option

If set to true, when setting the ANSI property, rather than throwing away
vertically "scrolled" lines, just keep extending the height to accommodate the
new required vertical size (height).

Modified Files:


exec/load/cga_defs.js
diff

Add from_attr_code[] table for mapping Ctrl-A attribute codes to CGA values

Modified Files:


exec/load/ansiterm_lib.js
diff

Define and use standard ANSI attribute codes and mappings to CGA values

Create expand_ctrl_a() method that expands Ctrl-A attribute codes in a string
into ANSI escape sequences.

Modified Files:


exec/msglist.js
diff

Support scrolling ANSI messages in preview and view modes

Supports mixed Ctrl-A and ANSI messages.

ANSIs of any length should display correctly.

ANSIs wider than 79 columns will be truncated (not horizontally scrollable).

Animated ANSIs will not render with their animation sequences in tact. :-(

Modified Files:


ctrl/text.dat
diff

Disable prompt for sub/dir info by default, just show the file

yes/no prompts can be disabled by just setting a string to a blank string.
Disable these prompts by default (you can reeanble in your own text.dat if you
want).

Modified Files:


exec/load/graphic.js
diff

Fix bug

Modified Files:


src/sbbs3/prntfile.cpp
diff

De-duplicate at the first '.' following the filename, not the path

Fix the fix to issue #380.

Thanks for letting me know Keyop.

Modified Files:


src/xpdev/dirwrap.c
diff

Uh, increment the pointer in globi()

Fixes crash reported in #381.

Modified Files:


src/sbbs3/str.cpp
diff

Remove the hard-coded ".msg" extension from data/subs/*.msg display file

And data/dirs/*.msg display file. Now you can have any supported menu file in
this location if you wish.

Modified Files:


src/sbbs3/prntfile.cpp
diff

Detect/display menu files, even if only a .ans version exists

I'm so tired of this 30 year old frequently asked question.

If a sysop really wants their Synchronet BBS to only work correctly for ANSI
users, I suppose that should be their prerogative.

I always felt that by not detecting/displaying menu files when the minimum set
of files was not present, I was helping sysops to identify an issue with their
system (which would not work correctly for non-ANSI users). *And* I always felt
that having a single menu/display file that correctly supported both ANSI and
non-ANSI users was a nice convenience (who really wants to maintain multiple
versions of their menu files?). But I'm so tired of answering this question, I
just give up.

Hopefully this doesn't break anything for anyone. <shrug>

Modified Files:


src/sbbs3/prntfile.cpp
diff

Revert to *.XXcol.* being an exact column width, add *.cXX.* support

That previous commit made all *.40col.msg files display for 80 column users.
Not my intention.

So revert to the previous behavior of *.XXcol.* display files. I didn't want to
go renaming a bunch of menu files as a result of the previous commit and I
didn't want a bunch of sysops with *.XXcol.* files to be suddenly surprised at
their new BBS behavior.

And introduce a new file naming convention, *.cXX.* (where XX is a MINIMUM
column width). This is the same naming convention used by Mystic, which also
treats it is as a minimum terminal width, not a required exact width.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Now calls bbs.edit_msg() to edit an existing message.
Now calls bbs.edit_msg() to edit an existing message (if that function exists -
It
was added in Synchronet 3.18).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_bbs_edit_msg' into 'master'

DDMsgReader: Now calls bbs.edit_msg() to edit an existing message.

See merge request main/sbbs!167

Modified Files:


src/xpdev/dirwrap.c
diff

src/xpdev/dirwrap.h
diff

Introduce case-insensitive version of glob(): globi()

glob() is case-insensitive on Windows already, so create a work-alike for *nix.

Modified Files:


src/sbbs3/prntfile.cpp
diff

Use text/menu/*.###col.* display files for even-wider terminals

e.g. display basename.132col.msg even if the terminal is 133+ columns wide.

Fixes issue #380.

Modified Files:


src/sbbs3/prntfile.cpp
diff

De-dupe random menu filenames by truncating at first dot, rather than last.

Fix for one of the problems described in issue #380.

bbs.menu("random*"); would display column-width-specific files (e.g.
random.132col.msg) even when they weren't appropriate for the current
user terminal width.

This is fixed by truncating the filenames matching the requested pattern at
their first-dot rather than the last.

The downside is, you can't have a set of random.#.* files, where # is the
unique part of the filename and * is the file-type extension. Just use
the naming pattern "random-#.*" instead (or something similar) instead.

Modified Files:


src/sbbs3/scfglib.h
diff

DLL-export is_valid_XXXnum() functions, for web server use

Fixes recently broken Win32 build

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Fix newly-introduced GCC warnings

Modified Files:


ctrl/text.dat
diff

Credits don't need 13 characters to display now

Since we're not displaying the exact value to the byte, with commas

Modified Files:


src/xpdev/genwrap.c
diff

src/xpdev/genwrap.h
diff

byte-count to string routines type unsigned 64-bit int now

We don't have a use case negative byte values in strings anywhere that I can
think of.

Created wrapper for MSFT _ui64toa_() - unsigned 64-bit integer to ASCII string.

Add Petabyte (actually, Pebibyte) support to byte_count_to_str()  and
byte_estimate_to_str().

Removed 'B' suffix from byte_estimate_to_str() output for values < 1024.
Callers may display this returned string followed by "bytes" (or similar) and
thus the 'B' suffix is redundant in that case. If the caller needs a 'B'
suffix, they can detect no suffix and add it.

Modified Files:


src/sbbs3/getstats.c
diff

Add TODO comment about dsts.dab not tracking > 4GB up/downloads

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filelist.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/js_user.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Support user credits and transfer stats > 4GB in total

Credits and daily free credits are accurate to the byte up to (a maximum) of
18446744073709551615 (that's 18 Exbibytes - 1).

User's upload and download byte stats are now similarly extended in maximum
range, but the accuracy is only "to the byte" for values less than
10,000,000,000. Beyond that value, the accuracy declines, but is generally
pretty damn accurate (to 4 decimal places beyond the nearest multiple of a
power of 1024), so I don't expect that to be an issue. This method of storing
upload/download byte stats allowed me to use the same 10-character user record
fields in the user.dat file.

As a side-effect of this enhancements:
* User and file credit values are now expressed in multiples of powers of 1024
(e.g. 4.0G rather than 4,294,967,296).
* Free credits per day per security level has now been extended from 32 to
64-bits (to accommodate values >= 4GB).
* adjustuserrec() now longer takes the record length since we can easily
determine that automatically and don't need more "sources of truth" that can be
out-of-sync (e.g. the U_CDT field length going from 10 to 20 chars with this
change).
* setting the stage for locale-dependent thousands-separators (e.g. space
instead of comma) - currently still hard-coded to comma
* more/better support for files > 4GB in size (e.g. in the batch download
queue)
* user_t ulong fields changed to either uint32_t or uint64_t - I didn't realize
how many long/ulong's remained in the code (which are sometmies 32-bit,
sometimes 64-bit) - ugh
* Steve's ultoac() function renamed to u32toac() and created a C++ wrapper that
still uses the old name, for homage

Modified Files:


src/sbbs3/file.cpp
diff

Fix newly introduced GCC warning

warning: invalid suffix on literal; C++11 requires a space between literal and
string macro

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filelist.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/upload.cpp
diff

src/smblib/smbdefs.h
diff

src/smblib/smblib.c
diff

SMB items (messages or files) can now have 32-bit or 64-bit cost value

To fully support files > 4GB in size in file bases, credit values larger than
32-bits must be supported too.

There's a couple of todo comments/items included in this commit, but that's
mainly to do with messages (which don't really have costs anyway).

The main thing to deal with now is the fact that users can't have more than 4GB
in credits in the first place! That's got to be fixed next.

Modified Files:


src/sbbs3/file.cpp
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


src/sbbs3/file.cpp
diff

Fix newly-encountered GCC warning

comparison of integer expressions of different signedness: ‘off_t’ {aka
‘long int’} and ‘uint64_t’ {aka ‘long unsigned int’}

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/smbutil.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

Support files > 4MB in SMB filebase indexes

Used the reserved 16-bits in the file index record to extend the supported
index-file-size from 4294967295 (4GB) to 281474976710655 (281TB). I think
that's big enough for the foreseeable future. :-)

Modified Files:


src/sbbs3/fmsgdump.c
diff

src/sbbs3/pktdump.c
diff

Get rid of CVS keywords and parsing for revision

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr2.c
diff

Add options to sort directories by file size (ascending or descending)

Size is indexed, so might as well sort by it. This does have an issue with
files >= 4GB in length however, so I'm looking at that next.

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Update the help text for the "file existence check" option

This option actually controls whether the disk will be queried for the current
file size and modification date/time (when listing) too.

Modified Files:


src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

Create some convenience functions for validating lib/dir/grp/sub nums

There are lot of places in the code where subnums and dirnums (especially) are
compared against total_subs and/or total_dirs or >= 0 without a ton of
consistency. We should migrate to use these functions for validity-checking
going forward.

Modified Files:


src/sbbs3/js_filebase.c
diff

File's meta-object's "size" and "time" properties reflect current values

Query the disk for file's current "size" and "time" values when get_list() or
get() method is used with a "detail" level of >= DETAIL.NORMAL and the "check
file existence" toggle option is enabled for this directory in SCFG.

I pondered and contemplated whether this configuration setting should be
checked/applied here or in the various JS scripts (e.g. filelist.js) and
decided here was best to provide the most uniform/expected behavior, even
though there is a performance impact. If a script doesn't need/use these
properties, they should probably be specifying the DETAIL.MIN (minimal) detail
level in their queries anyway, which will then bypass these
performance-impacting disk queries.

Modified Files:


src/sbbs3/websrvr.c
diff

Resolve warning about enum value not handled in switch() statement

Modified Files:


src/build/Common.gmake
diff

Linux needs strlcpy() defined in xpdev

Modified Files:


src/sbbs3/js_system.c
diff

typedefs to suppress warnings about using JS_ValueToECMAUint32 w/int32_t

Modified Files:


src/sbbs3/js_system.c
diff

Use JS_ValueToECMAUint32 for full 32-bit time_t values

Resolves issue with filelist.js trying to pass 4294967295 (-1) to
system.datestr() resulting in:
!JavaScript  /sbbs/exec/filelist.js line 13: Error: can't convert t to an
integer

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

Add dynamic file area/base indexing to web server

By setting sbbs.ini [web] FileIndexScript to an SSJS or XJS script filename,
that script (by default, from your exec directory) will be executed when a file
area/base listing has been http[s]-requested. File area/base requests are of
the form <vpath_prefix> (for the list of libraries), <vpath_prefix>/<lib-name>/
(for list of directories of a library) or
<vpath_prefix>/<lib-name>/<dir-code-suffix>/ (for a list of files in a
directory). The new http_request "lib" and "dir" properties indicate that a
library or directory listing was requested (if neither are defined, that's a
request for the root / list of libs). The same configured script is executed to
handle all 3 types of index/list requests.

A sample script (webfileindex.ssj) will be committed soon.

Authentication (via HTTP-AUTH) will be required if user #0 does not have access
to all libraries or all directories within a required library.

file_area.lib[].link has been changed from "/<vdir>/" to just "<vdir>" (no
slashes) and renamed to "vdir".

file_area.dir[].link has been changed from "/<vpath>/" to "<vpath>/" (no
leading slash) and renamed to "vpath".

Added file_area.dir[].vdir property that contains just the directory's virtual
directory name.

I don't think anyone was using these "link" properties since the dynamic FTP
HTML index scripting feature is no longer supported.

Added can_user_access_lib() to insure that the user has access to at least one
directory of a library before allowing access to the library (e.g. via JS).
Something similar should be created for message groups.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DDLightarMenu: For numbered mode, implemented a fix for refreshing the
menu after the user types an item number to select/highlight it. Also,
added 2 new color settings to specify the color to use for writing the
item numbers: itemNumColor (for non-highlighted items) and
highlightedItemNumColor
(for the current highlighted item).

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_numbered_mode_draw_update' into 'master'

DDLightarMenu: Numbered mode item refresh fix & new item number colors

See merge request main/sbbs!164

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

DD area choosers: For message sub-board/file directory collapsing, if there's
only one sub-group/sub-library, then it won't be collapsed
DD area choosers v1.23: For message sub-board/file directory collapsing, if
there's only one
sub-group/sub-library, then it won't be collapsed, as that wouldn't be very
useful.

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_area_choosers_all_separators_no_collapse' into 'master'

DD area choosers: No sub-board/library collapsing if all have the same
separator

See merge request main/sbbs!165

Modified Files:


src/sbbs3/fmsgdump.c
diff

Fix CID 229603: String not null terminated

Modified Files:


exec/sbbslist.js
diff

Don't prompt yes/no upon remove if run with -quiet option

for Andre

Modified Files:


exec/chat_sec.js
diff

Optional channel list per server configured in modopts.ini

So you have multiple IRC servers configured in modopts.ini and
you want different channel list per server? Just add more
keys to the modopts.ini [chat_sec] section of the form:
<server>=<channel_list>

Where <server> is the IRC server's host name (e.g. irc.synchro.net)
and <channel_list> is a comma-separated list of channels to override
the default list of channels (set with the "irc_channel" key).

For DesotoFireflite (VALHALLA)

Modified Files:


xtrn/lord/lord.js
diff

LORD: Fix daily bank transfer count not being reset properly

Modified Files:


xtrn/lord/lord.js
diff

Merge branch 'eugeneso/lord_bankxfer_fix' into 'master'

LORD: Fix daily bank transfer count not being reset properly

See merge request main/sbbs!163

Modified Files:


xtrn/lord/lord.js
diff

LORD: Fix online duel event
Fixed broken code when taunting opponent
Fixed broken code when aborting after waiting a long time for opponent
to respond.

Modified Files:


xtrn/lord/lord.js
diff

Merge branch 'eugeneso/lord_online_duel_fix' into 'master'

LORD: Fix online duel event

See merge request main/sbbs!162

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Added back a few functions that were accidentally removed
Added back a few functions that were accidentally removed (which weren't moved
to attr_conv.js)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'ddmr_add_ansi_funcs_back' into 'master'

DDMsgReader: Added back a few functions that were accidentally removed

See merge request main/sbbs!161

Modified Files:


xtrn/DDMsgReader/readme.txt
diff

Removed references to old files

Modified Files:


xtrn/DDMsgReader/readme.txt
diff

Merge branch 'ddmr_doc' into 'master'

Removed references to old files

See merge request main/sbbs!160

Added Files:


xtrn/DDMsgReader/ddmr_lm.js
diff

Modified Files:


exec/load/attr_conv.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Removed Files:


xtrn/DDMsgReader/loadable_module_scripts/DDReadPersonalMail.js
diff

xtrn/DDMsgReader/loadable_module_scripts/DDScanMsgs.js
diff

xtrn/DDMsgReader/loadable_module_scripts/DDScanSubs.js
diff

DDMsgReader can be called directly as a loadable module

Added Files:


xtrn/DDMsgReader/ddmr_lm.js
diff

Modified Files:


exec/load/attr_conv.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Removed Files:


xtrn/DDMsgReader/loadable_module_scripts/DDReadPersonalMail.js
diff

xtrn/DDMsgReader/loadable_module_scripts/DDScanMsgs.js
diff

xtrn/DDMsgReader/loadable_module_scripts/DDScanSubs.js
diff

Merge branch 'ddmr_loadable_module_update' into 'master'

DDMsgReader can be called directly as a loadable module

See merge request main/sbbs!159

Modified Files:


src/sbbs3/upload.cpp
diff

MSVC didn't like that use of std::min(), so just go back to a macro

Modified Files:


src/sbbs3/upload.cpp
diff

Fix issues with std::min() again...

std::min() requires both arguments be of same type too.

Modified Files:


ctrl/text.dat
diff

Add new strings: HashingFile and HashedFile

Modified Files:


src/xpdev/genwrap.c
diff

src/xpdev/genwrap.h
diff

Create *nix wrapper for MSVC's _i64toa()

Modified Files:


src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Create i64toac() to generate comma-separated ASCII string of 64-bit int

Modified Files:


src/sbbs3/file.cpp
diff

Use new i64toac() function to support files > 4GB in size

Modified Files:


src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

New strings: HashingFile and HashedFile

To display (rather than "Searching for Dupes") when calculating file hashes.

Modified Files:


src/sbbs3/upload.cpp
diff

Use new Hashing/HashedFile text.dat strings, better > 4GB file support

Resolve issues displaying file sizes > 4GB and calculating credit values.

Modified Files:


src/sbbs3/listfile.cpp
diff

Save the node status (with "downloading" action value)

More immediately. I wanted to debug the ETA value here and the action wasn't
written to the node file here, but later.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Fix for "fileDesc is not defined" error when displaying the file description on
the main screen.
ddfilelister version 2.05a: Fix for "fileDesc is not defined" error when
displaying the file
description on the main screen.  Also made a small refactor to the main screen
refresh function.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_filedesc_undefined_fix' into 'master'

Fix for "fileDesc is not defined" error when displaying the file description on
the main screen.

See merge request main/sbbs!158

Modified Files:


src/smblib/smbtxt.c
diff

Replace sprintf() calls with safe_snprintf()

Modified Files:


src/smblib/smbtxt.c
diff

Fix heap corruption of qp_decode()

qp_decode (quoted-printable in-place decode of a string) could write 2
characters *beyond* the allocated buffer by appending "\r\n" to a string that
was not quoted-printable in the first place. i.e. the  contents of buf were not
actually changed in the decode loop. This could result in a corrupted heap and
crash of sbbs or smbutil when reading such a message.

This change may result in a lack of CRLF appended to decoded plain text output,
so we'll have to keep an eye out for that and resolve it some other way. One
possibility could be to only append the CRLF if the destination pointer is
sufficiently behind the source pointer.

This solves the crash that Kirkman reported with a specific message in his
"mail" base. The header for the message said it was quoted-printable encoded,
but the body text was not actually encoded at all:
OtherHeader      Content-Type: text/plain; charset="iso-8859-1"
OtherHeader      MIME-Version: 1.0
OtherHeader      Content-Transfer-Encoding: quoted-printable

Modified Files:


src/sbbs3/targets.mk
diff

Apparently we need to use the backtick method of shell expression here

Modified Files:


xtrn/sdk/xsdk.c
diff

Resolve warning: type defaults to ‘int’ in declaration

Modified Files:


src/sbbs3/targets.mk
diff

Use whereis to find setcap install location and cut to trim the output

<Dan_C> DigitalMan: minor install issue noted today - during a fresh (Linux)
install on a test box, the build failed because it was unable to execute the
"sudo setcap ..." command.  This was on Slackware 15.0, where the setcap
executable is located in /sbin , and that directory is not in the $PATH of a
normal user, or even when a normal user uses the 'sudo' command.

Modified Files:


install/GNUmakefile
diff

Revert "Apparently setcap isn't in /sbin for all Linux distros"

This reverts commit 6a2c3722966ff2fd4ca6a114e035d4bd4f340dfc.

SETCAP isn't a command-line afterall, it's a build target.

Modified Files:


install/GNUmakefile
diff

Revert "Make the default SETCAP value to be /sbin/setcap"

This reverts commit 2869cfb81e5436e4eaf58e58c9a7951ae92a757c.

SETCAP isn't a command-line after all, it's a build target.

Modified Files:


install/GNUmakefile
diff

Apparently setcap isn't in /sbin for all Linux distros

So use 'whereis' to find and and 'cut' to trim its output

Modified Files:


install/GNUmakefile
diff

Make the default SETCAP value to be /sbin/setcap

<Dan_C> DigitalMan: minor install issue noted today - during a fresh (Linux)
install on a test box, the build failed because it was unable to execute the
"sudo setcap ..." command.  This was on Slackware 15.0, where the setcap
executable is located in /sbin , and that directory is not in the $PATH of a
normal user, or even when a normal user uses the 'sudo' command.

Also include SETCAP in the set of documented make variables.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix CID 174355: Big parameter passed by value

Modified Files:


src/sbbs3/netmail.cpp
diff

Fix CID 319119: Unchecked return value from library

Actually probably doesn't fix it, but what'evs

Modified Files:


src/sbbs3/smbutil.c
diff

Fix CID 350312: Uninitialized scalar variable

Modified Files:


src/sbbs3/main.cpp
diff

Fix CID 319133: Unchecked return value

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix CID 33235: Argument cannot be negative

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Paste the table of supported drop files (write and/or read) into F1 help

Also, when hitting ESC at the "Use Real Names" prompt, don't prompt for the
Lower-casing of the drop file name.

Modified Files:


src/sbbs3/smbutil.c
diff

Address warnings introduced in previous commit

Modified Files:


src/sbbs3/pcbdefs.hpp
diff

Fix min() not being in scope when using GCC <C++, shrug>

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Address new warning

Added Files:


src/encode/endian.hpp
diff

Template lib for dealing with endian-specific data types

Just integers right now. And only big or little endian.

Modified Files:


src/encode/pascal_types.hpp
diff

Use endian.hpp for the LittleEndInt template

Modified Files:


src/sbbs3/qbbsdefs.hpp
diff

Correct the harmless wrong filename in the include-guard

Added Files:


src/sbbs3/pcbdefs.hpp
diff

PCBoard type definitions for PCBOARD.SYS and USERS.SYS files

PCBOARD.SYS is officially the worst file format ever invented, not just the
worst BBS drop file format ever invented. What were these guys smoking?!?

I don't know what reference I used almost 30 years ago when I first implemented
PCBOARD.SYS file support, but this time I used the PCBoard v15.3 source code
(e.g. sys.c and usersys.c) and even their own code seems to work really hard to
conform to these crazy file formats.

USERS.SYS is a little more sane, but not by a lot.

C++ features make this cleaner/easier, but man... there's just so much polish
you apply to these turds.

I guess (and hope) that nobody's really running programs that depend on/use
these file formats. <shrug>

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Use buffered file I/O when writing drop files and overhaul PCBOARD.SYS

... and USERS.SYS file creation using new C++ type definitions in pcbdefs.hpp.

This mostly fixes issue #366.

Modified Files:


src/sbbs3/smbutil.c
diff

Display textual version of msg attributes when using 'r'ead command

Also displays net and aux attribute values when non-zero (weren't displayed
at all with the 'r'ead command previously).

Added Files:


exec/load/attr_conv.js
diff

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

ddfilelister: Now displays extended description in list view if the user has
that setting enabled
ddfilelister version 2.05 - Now makes use of the user's extended file
description setting: If
the user's extended file description setting is enabled, the lister will now
show extended file
descriptions on the main screen in a split format, with the lightbar file list
on the left and
the extended file description for the highlighted file on the right.
Also, made the file info window taller for terminals within 25 lines high.
This should resolve issue #363 .
This update to ddfilelister also requires the included update to
dd_lightbar_menu.js and the
new attr_conv.js.

Added Files:


exec/load/attr_conv.js
diff

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_extd_desc_setting' into 'master'

ddfilelister: Now displays extended description in list view if the user has
that setting enabled

Closes #363 and #374

See merge request main/sbbs!157

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Remove now-unneeded str2pas() function

Functionality replaced with Pascal::String

Modified Files:


xtrn/lord/aratime/aratime.js
diff

LORD: Fix crash when exiting aratime igm

Modified Files:


xtrn/lord/aratime/aratime.js
diff

Merge branch 'eugeneso/lord_aratime_fix' into 'master'

LORD: Fix crash when exiting aratime igm

See merge request main/sbbs!156

Modified Files:


src/sbbs3/sbbsecho.c
diff

Add subject.can (Subject filter file) support

For Trikester (DOVEMOD/BSMNTQQ) 

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

src/uifc/uifcx.c
diff

UIFC "list" now supports an optional left/right arrow key indicator

Passing either WIN_LEFTKEY or WIN_RIGHTKEY in the window "mode" argument
enables this new indicator in the upper right of "list" windows. These
indicator arrows are mouse-clickable too (translate to the left and right arrow
keys).

We had defined uses for all 32 available WIN_* mode bits, so I extended the win
mode type from 32 to 64 bits (should this now be called uifc64.c?) :-)

Anyway, it'll be easier to add more WIN_* mode flags as needed later, but I do
wonder about JavaScript support (not so great for > 31-bit integers).

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

Use the new UIFC WIN_LEFTKEY/RIGHTKEY mode flags to enable indicators

A visual clue that there was a new navigation method available on some menus
(where left/right arrow keys cycle through configured item) was needed. This
seems to work nicely.

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Change online program and program section via left/right arrow keys

Similar to how we can now cycle through the file areas and message areas using
left and right arrow keys, do the same for external "online" program sections
and program (door) configurations.

Modified Files:


exec/load/text.js
diff

Latest generated text.js

Note: TEXT_TEXT is actually off-by-one here. I suppose there's no need/use for
that value anyway.

Modified Files:


src/encode/pascal_types.hpp
diff

Add Pascal::String::max_size() method

Rename len() method to length() to align with std::string.

Modified Files:


src/sbbs3/inkey.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/postmsg.cpp
diff

Fix various Clang warnings seen on FreeBSD build.

Modified Files:


src/sbbs3/putmsg.cpp
diff

Fix Clang warnings.

Modified Files:


src/xpdev/filewrap.h
diff

Fix FreeBSD/Clang C++ error

/usr/include/c++/v1/iterator:1168:87: error: expected unqualified-id
  ...&& traits_type::eq_int_type(__sbuf_->sputc(__c), traits_type::eof()))
                                                                   ^
/src/sbbs3/../xpdev/filewrap.h:124:21: note:

      expanded from macro 'eof'
        #define eof(fd)                         (tell(fd)==filelength(fd))
  

Modified Files:


src/encode/pascal_types.hpp
diff

I think type_traits header is technically required for static_assert()

Does this fix the FreeBSD/clang build?

Modified Files:


src/encode/pascal_types.hpp
diff

Interesting, these modern sea plus plusisms

This was necessary to get to build for MSVC2019 and GCC 8.3.0

Modified Files:


exec/str_cmds.js
diff

Fix typos and add the -pause option to the node command-lines

Fix issue #372

Modified Files:


text/menu/sysmain.asc
diff

s/preceeded/preceded

Modified Files:


text/menu/attr.asc
diff

text/menu/sysxfer.asc
diff

s/preceeded/preceded

Modified Files:


src/encode/pascal_types.hpp
diff

std::min() wasn't in scope when using gcc <shrug>

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Remove unused variable

Added Files:


src/encode/pascal_types.hpp
diff

A C++ header-only library for dealing with Pascal data types

(e.g. those stored in files, e.g. EXITINFO.BBS).

Added Files:


src/sbbs3/qbbsdefs.hpp
diff

QuickBBS structure definitions (for EXITINFO.BBS)

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Overhaul EXITINFO.BBS creation using C++ templated classes

Ah, that's better. Actually would work correctly on big-endian platforms
(should we ever support one) and with way less code.

Modified Files:


src/xpdev/xpendian.h
diff

Fix LE/BE_INT() and BYTE_SWAP_INT() for 64-bit long targets (Linux-x64)

long is 64-bits (8 bytes), not 32-bit on some target platforms (e.g.
Linux-x64), so don't assume sizeof(long)==4.

It appears we weren't using these "automatic" integer-size macros anywhere that
I can see, so no harm, but might as well fix them.

Also remove BYTE_SWAP_SHORT and BYTE_SWAP_LONG since they're terribly named.
Retain the LE/BE_SHORT/LONG macros since we're using them currently in SBBS
(e.g. js_file.c).

Modified Files:


src/sbbs3/fmsgdump.c
diff

Don't #include xpendian.h since we're not using it

Modified Files:


src/sbbs3/qwk.cpp
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/scfglib1.c
diff

Fix assumptions about sizeof(long/ulong)

So I did a search through the code for sizeof.*long and was surprised to find
some remaining (harmless) assumptions that a long is 32-bit.

Modified Files:


exec/logonlist.js
diff

Fix off-by-one error in previous commit

The default (when no argument to the '-l' option is provided) is to use
the last_few_callers value from the modopts.ini file. This was broken.

Modified Files:


exec/load/logonlist_lib.js
diff

get() method supports reading entries from multiple days

If days_ago argument is undefined (as is the case when performing
a "last few callers" query/list), then pull upto the maximum last
number of callers from previous days as necessary.

Part of fix for issue #371

Modified Files:


exec/logonlist.js
diff

By default, '-l' (last few callers) option will pull from previous days

If modopts.ini [logonlist] last_few_days is set (to a number), that will
dictate the maximum number of previous days to pull last few callers from
(e.g. set to '0' for previous behavior).

Also, '-l' can now be used with a command-line option (e.g. '-l <num>')
to specify the number of callers to display (overriding the modopts.ini
last_fwe_callers value).

This should address issue (feature request) #371.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Bug fix: Now successfully formats filenames without extensions when listing
files.
Version 2.04 - Bug fix: Now successfully formats filenames without extensions
when listing files.
This addresses issue #369.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_filename_no_ext_fix' into 'master'

DD File Lister bug fix: Now successfully formats filenames without extensions
when listing files.

See merge request main/sbbs!155

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Fix EXITINFO.BBS generation for 64-bit time_t and more

So I was working on re-writing some of this door file generation code and
noticed that the EXITINFO.BBS files generated by SBBS:

1. had a lot of garbage data filling unused string characters (no "harm", but
potentially leaking information)
2. had the wrong total file length due to 64-bit logontime (time_t)
3. had the wrong total file length due to writing 19 GosubData elements
(instead of 20)

The first and last issues appear to be some of those "forever" (20+ year old)
bugs.

So I'm guessing no regularly used door games actually use these portions of the
EXITINFO.BBS, so most likely: no harm, no foul. But still, best to fix this
before I commit the rewrite.

Modified Files:


exec/xbimage.js
diff

Throw an error if trying to convert a > 1-bit BMP file to XBin

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix issue with smtpspy-listed names added in previous commit

p (which is used after this) points into 'str', so we can't use 'str' as a
temporary variable here.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for bogus messages when changing to an empty sub-board
Fix: When changing to an empty sub-board from within the reader (either from
read mode or list mode), it now properly says there are no messages and exits,
rather than showing a list of bogus messages.
Unsure when this bug was introduced.
The version is now 1.46.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_chg_empty_subboard_fix' into 'master'

DDMsgReader: Fix for bogus messages when changing to an empty sub-board

Closes #367

See merge request main/sbbs!154

Modified Files:


exec/irc.js
diff

exec/load/irc-default.js
diff

Fix handling of IRC color control sequences
An extra comma was being added after the control sequences
An empty color control sequence was not handled. It is supposed to
remove all color schemes.

Modified Files:


exec/irc.js
diff

exec/load/irc-default.js
diff

Merge branch 'eugeneso/irc_color_fix' into 'master'

Fix handling of IRC color control sequences

See merge request main/sbbs!153

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

Cycle through grps, subs, libs, and dirs using left/right arrow keys

Nelgin's suggestion to support quick searching/scanning through message and
file areas (e.g. comparing settings or whatever) without having to ESC then
arrow key, ENTER, for each.

Uses Deuce's WIN_EXTKEYS UIFC mode flag, which I don't think I've used before
now and uses the special -CIO_KEY value - 2 trick.

Also expanded the width of the sub-board and directory info windows to show
more information (including full long name).

Fixes issue (wishlist item) #349 by Nelgin

Modified Files:


src/sbbs3/useredit.cpp
diff

Remove unnecessary current user (co-sysop) level/flag checks

As Andre pointed out, these checks perform no function because a user with a
level lower than the user being edited cannot enter the related command-key
anyway.

This was just effectively dead code that was held-over from ancient SBBS days,
seemingly before I learned to effectively use the || operator:
if(!(atoi(str)>useron.level && console&CON_R_INPUT))

:-)

Fixes issue #361

Modified Files:


exec/SlyEdit.js
diff

SlyEdit now remembers the quote line window selection between openings.
When selecting quote lines in a reply message, SlyEdit now remembers the
position in the quote selection menu so that the quote menu isn't always
at the top whenever it's opened again.  This issue may have been introduced
when SlyEdit was refactored to use DDLightbarMenu for its lightbar stuff.

Modified Files:


exec/SlyEdit.js
diff

Merge branch 'slyedit_quote_win_remember_position' into 'master'

SlyEdit now remembers the quote line window selection between openings.

See merge request main/sbbs!152

Modified Files:


src/sbbs3/node.c
diff

Move where the "pause" option is applied

At the suggestion/request of Andre Robitaille.

This option was originally added for debugging use, but may as well move it if
it's useful in another way.

Modified Files:


src/sbbs3/str.cpp
diff

Fix CID 174323: Unintended sign extension

At least, I think this fixes it.

Modified Files:


ctrl/text.dat
diff

Remove beep from UserReadYourMailNodeMsg

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Don't use pointers to the low byte of multi-byte integers

This only works on little endian systems (which is all we support currently).

Fixes CID 174261: Wrong size argument

This binary drop file writing code is pretty terrible and inefficient, but I
remember being really proud of it (supporting so many drop files). This really
should be re-written to use structures and/or buffered file I/O.

Modified Files:


src/sbbs3/str.cpp
diff

Fix CID 33227: Argument cannot be negative

Modified Files:


src/sbbs3/main.cpp
diff

Fix CID 174378: Argument cannot be negative

Modified Files:


src/sbbs3/str.cpp
diff

More correct error message

Modified Files:


src/sbbs3/slog.c
diff

Fix CID 33617: Copy into fixed size buffer

Modified Files:


src/sbbs3/baja.c
diff

Fix CID 33628: Unbounded source buffer

Modified Files:


src/sbbs3/node.c
diff

Fix CID 33629: Unbounded source buffer

Modified Files:


src/sbbs3/addfiles.c
diff

Fix a few issues around single-file add argument parsing

Triggered by CID 33630: Unbounded source buffer

Modified Files:


src/sbbs3/filelist.c
diff

Safer string handling

e.g. CID 33631: Unbounded source buffer

Modified Files:


src/sbbs3/allusers.c
diff

Fix CID 33635: Unbounded source buffer

Modified Files:


src/sbbs3/useredit.cpp
diff

Check return value of filelength()

Fix CID 33266: Negative loop bound

Modified Files:


src/sbbs3/smbutil.c
diff

Check for negative filelength() return values

e.g. CID 229593: Negative loop bound

Modified Files:


src/uifc/uifc32.c
diff

Left for showbuf() is zero-based, calculate width appropriately.

Modified Files:


src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

Show auto-generated newsgroup name and Fido area-tags

Also reversed the order of newsgroup name and area-tag options for a sub-board.

Updated help text too to specify that sub's area-tag can be derived from
newsgroup name, if one is specified.

Modified Files:


src/sbbs3/chat.cpp
diff

Fix CID 33252: Argument cannot be negative

Modified Files:


src/sbbs3/smbutil.c
diff

Detect smb_fallocdat() and ftell() failures

CID 33245

Modified Files:


src/sbbs3/smbutil.c
diff

Detect/report smb_fallochdr() and ftell() failures

Fix CID 33244: Argument cannot be negative

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix CID 33239: Argument cannot be negative

Modified Files:


src/sbbs3/getmsg.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/writemsg.cpp
diff

src/smblib/smblib.h
diff

src/smblib/smbstr.c
diff

Don't pass smbmsg_t (680 bytes) by value

So this started with addressing CID 174264: Big parameter passed by value
(PASS_BY_VALUE), but then I fell down the constification rabbit hole. :-)

Modified Files:


src/sbbs3/text_defaults.c
diff

Remove beep from UserReadYourMailNodeMsg

Modified Files:


src/sbbs3/netmail.cpp
diff

Detect smb_[f]allocdat() failures in qnetmail()

CID 319140

Modified Files:


src/sbbs3/slog.c
diff

getchar() returns int, not char

CID 319110

Modified Files:


src/sbbs3/writemsg.cpp
diff

Detect smb_[f]allocdat() failure in editmsg()

CID 319091

Modified Files:


src/smblib/smballoc.c
diff

Detect/reject negative offset argument values to smb_freemsgdat()

Modified Files:


src/sbbs3/netmail.cpp
diff

Fix issue in previous commit: no need to free what wasn't allocated

Modified Files:


src/sbbs3/sbbs.h
diff

Initialize more sbbs_t members in class declaration

CID 319034

Modified Files:


src/sbbs3/pktdump.c
diff

Detect/report ftell() failure

CID 319007

Modified Files:


src/sbbs3/pktdump.c
diff

Check/report remove() failures

CID 319028

Modified Files:


src/sbbs3/unbaja.c
diff

Fix CID 33289: Dereference null return value

Modified Files:


src/sbbs3/str.cpp
diff

Fix CID 33261 Argument cannot be negative

Modified Files:


src/sbbs3/js_com.c
diff

"Invalid type in argument to printf format specifier"

CID 319142

Modified Files:


src/sbbs3/js_com.c
diff

Invalid type in printf format specifier

CID 319135

Modified Files:


src/sbbs3/getnode.cpp
diff

src/sbbs3/str.cpp
diff

Address Coverity issue: filelength() can return negative value

Modified Files:


src/sbbs3/js_file.c
diff

Fix possible negative offset to lseek()

CID 327965

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix possible negative offset to fseeko()

CID 350353

Modified Files:


src/sbbs3/main.cpp
diff

Batch download queue not cleared upon packed QWK packet

Before the "new filebase" merge of 2021, a user's batch download queue would be
cleared when a QWK packet was successfully packed for them via the event thread
(i.e. triggered via semaphore file). That was lost in the new filebase change
(the batch download queue would not be cleared) - caught by Coverity (CID
350336).

It appears pre-packed QWK packets never cleared the batch download queue (does
anyone actually use this feature in this day and age?) - fixed.

Modified Files:


src/sbbs3/scfg/scfgnet.c
diff

Eliminate unnecessary save/restore

resolved CID 350321

Modified Files:


src/sbbs3/sbbsecho.c
diff

Resolve some Coverity-discovered issues

with lseek() argument types, ftell() return type, etc.

Likely none of these would be actual issues with files < 2GiB in size.

Modified Files:


src/sbbs3/services.c
diff

Probably doesn't resolve the Coverity issue

But good practice anyway

Modified Files:


src/sbbs3/filedat.c
diff

Add some NULL argument value checking

Modified Files:


src/sbbs3/userdat.c
diff

Added NULL argument checking

Modified Files:


src/sbbs3/chksmb.c
diff

Zero-initialize smb before using

Addresses CID 350318 

Modified Files:


src/sbbs3/smbutil.c
diff

Zero-init 'ms'g' before use

Addresses CID 350316

Modified Files:


src/sbbs3/smbutil.c
diff

Zero-init 'msg' before use

Addresses CID 350312

Modified Files:


src/sbbs3/readmsgs.cpp
diff

Fix private message header field parsing/filtering

CID 350294

Modified Files:


src/sbbs3/smbutil.c
diff

Zero-init 'msg' before use

CID 350279

Modified Files:


src/sbbs3/js_file.c
diff

Zero-init write buffer in js_writebin()

CID 350276

Modified Files:


src/sbbs3/fmsgdump.c
diff

Better detection of correctly-null-terminated body text

CID 229603 

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix host name or IP address-based smtpspy.txt logging

Caught by Coverity-scan (use of uninitialized variable, 'str') :-)

Modified Files:


src/sbbs3/sbbscon.c
diff

Document case fall-through

Reported by Coverity

Modified Files:


src/sbbs3/userdat.c
diff

Address Coverity-scan reported issues

Could use more long->off_t conversions, but this is a start.

Modified Files:


src/sbbs3/websrvr.c
diff

I don't know what I was smoking when I did this, but it's fixed now.

Weird early failure return on TLS sends.  Most noticible on local
(ie: fast) connections, but clearly stupid all around when you
look at the code.

Fixed, but some day, I should go back and look how we eneded up in
this mess.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DD file lister: For terminals over 25 rows tall, the file info window will now
be up to 45 rows tall.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfl_issue_352' into 'master'

DD file lister: For terminals over 25 rows tall, the file info window will now
be up to 45 rows tall.

See merge request main/sbbs!151

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

iniSortSections() supports an optional section prefix

Needed for echocfg option to sort linked nodes upon reading/writing
sbbsecho.ini, for Ray Quinn (1:214/23).

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbsecho.h
diff

Add option to sort the list of linked nodes (defaults: off)

Feature request by Ray Quinn (1:214/23)

Modified Files:


src/sbbs3/main.cpp
diff

Lower the "SSH session establishment failed" log msg level

from NOTICE to INFO, per Nelgin

Modified Files:


src/sbbs3/gtkchat/objects.mk
diff

Cleanup (replace DIRSEP with slash)

Modified Files:


src/sbbs3/gtkchat/targets.mk
diff

Replace DIRSEP with slash

Modified Files:


src/sbbs3/gtkchat/objects.mk
diff

load_cfg needs readtext and text_defaults

Modified Files:


src/sbbs3/objects.mk
diff

qwknodes needs the load_cfg objects too

Modified Files:


src/sbbs3/Common.gmake
diff

src/sbbs3/Common.make
diff

src/sbbs3/GNUmakefile
diff

src/sbbs3/extdeps.mk
diff

src/sbbs3/objects.mk
diff

src/sbbs3/scfg/objects.mk
diff

src/sbbs3/scfg/targets.mk
diff

src/sbbs3/targets.mk
diff

More elimination of DIRSEP (replace with slash)

We only support platforms where slash is a legal path separator.

Modified Files:


3rdp/build/GNUmakefile
diff

src/sbbs3/jsdoor.c
diff

Enable ctypes in jsdoor

SpiderMokey is now built with ctypes, but the object is only
being created in jsdoor for now.

Modified Files:


src/sbbs3/objects.mk
diff

src/sbbs3/scfg/objects.mk
diff

src/sbbs3/uedit/objects.mk
diff

src/sbbs3/umonitor/objects.mk
diff

load_cfg now depends on readtext and text_defaults... everywhere

Needed for text.dat support in SBBSecho

load_cfg really should be made either a static library or an exported
function from libsbbs.so that everything reuses. Kind of silly to be
recompiling and linking these files with every app now.

Modified Files:


src/sbbs3/text_defaults.c
diff

Remove beeps from "sent you email" notices.

Modified Files:


src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.vcxproj
diff

For SBBSecho to use text.dat strings, it needs load_cfg() to support it

Thanks to Dan_C for the head's up that SBBSecho stopped (very recently)
successfully sending notices to users about received netmail or echomail.

Modified Files:


ctrl/text.dat
diff

Remove beeps from "send you email" notices.

Modified Files:


xtrn/ddfilelister/readme.txt
diff

Fixed copy paste error for the installation section
Changed "Installing into a command shell" to say section 3
("Installation & Setup") instead.  This resolves issue #353

Modified Files:


xtrn/ddfilelister/readme.txt
diff

Merge branch 'dd_file_lister_doc_install_section' into 'master'

Fixed copy paste error for the installation section

Closes #353

See merge request main/sbbs!150

Modified Files:


docs/adding_nodes.html
diff

Redirect to the appropriate wiki page

Modified Files:


ctrl/main.cnf
diff

Change default node1-4 directories from ..\nodeX\ to ../nodeX/

Fixes issue #355 reported by Andre

Added Files:


xtrn/3rdp-install/dragonshoard.ini
diff

Setup file for Dragon's Hoard (WWIV game, circa 1989)

Added Files:


xtrn/3rdp-install/foodfite-rigormortis.ini
diff

Setup file for Rigor Mortis' FoodFight! for WWIV

Modified Files:


src/conio/ciolib.c
diff

Make it const everywhere.

Modified Files:


src/conio/ciolib.h
diff

Make ciolib_appname const

Modified Files:


exec/load/install-3rdp-xtrn.js
diff

Install door game even when executable filename case doesn't match

e.g. foodfite.com will match FOODFITE.COM or FoodFite.COM

(the MD5 sum is insuring it's the right file anyway).

Modified Files:


src/xpdev/CMakeLists.txt
diff

Don't compile xptime

Modified Files:


src/conio/CMakeLists.txt
diff

Set WITH_SDL in parent scope so xpdevplus can pick it up.

Modified Files:


src/conio/CMakeLists.txt
diff

Add WITH_SDL

Modified Files:


src/sbbs3/js_archive.c
diff

Better error handling in Archive.read()

Inspired by jsdoor's equivalent change.

Modified Files:


src/sbbs3/bulkmail.cpp
diff

Safer string copying/formatting.

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add BUILD_DATE and BUILD_TIME @-codes

For DesotoFireflite (VALHALLA)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

List header fix for personal email
Fix for no group information available when displaying the sub-board header
above the message list when listing personal email

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_mail_hdr_fix' into 'master'

List header fix for personal email

See merge request main/sbbs!149

Added Files:


exec/viewimsgs.js
diff

Modified Files:


exec/privatemsg.js
diff

exec/str_cmds.js
diff

Move "MSGS" string command logic to its own file

This makes the view instant message logic more easily accessible from other
places (e.g. menus or whatever).

Add (V)iew command the private message (^P) prompt while we're at it.
Users don't normally discover ;string commands on their own.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DD message reader: Fixed score display and related colors in the message list
for wide terminals

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_wide_term_score_and_color_fix' into 'master'

DD message reader: Fixed score display and related colors in the message list
for wide terminals

See merge request main/sbbs!148

Modified Files:


CONTRIBUTING.md
diff

s/escaping/encoding

Added Files:


xtrn/DDArchiveViewer/readme.txt
diff

xtrn/DDArchiveViewer/revision_history.txt
diff

xtrn/DDArchiveViewer/updating_from_previous_versions.txt
diff

xtrn/DDMsgReader/enhanced_header_examples/enhMsgHeader-withoutTimeZone.ans
diff

xtrn/DDMsgReader/enhanced_header_examples/enhMsgHeader.ans
diff

xtrn/DDMsgReader/loadable_module_scripts/DDReadPersonalMail.js
diff

xtrn/DDMsgReader/loadable_module_scripts/DDScanMsgs.js
diff

xtrn/DDMsgReader/loadable_module_scripts/DDScanSubs.js
diff

Modified Files:


xtrn/DDMsgReader/readme.txt
diff

Removed Files:


xtrn/DDArchiveViewer/FILE_ID.DIZ
diff

Removed spaces from some filenames of Digital Distortion mods that had them

Added Files:


xtrn/DDArchiveViewer/readme.txt
diff

xtrn/DDArchiveViewer/revision_history.txt
diff

xtrn/DDArchiveViewer/updating_from_previous_versions.txt
diff

xtrn/DDMsgReader/enhanced_header_examples/enhMsgHeader-withoutTimeZone.ans
diff

xtrn/DDMsgReader/enhanced_header_examples/enhMsgHeader.ans
diff

xtrn/DDMsgReader/loadable_module_scripts/DDReadPersonalMail.js
diff

xtrn/DDMsgReader/loadable_module_scripts/DDScanMsgs.js
diff

xtrn/DDMsgReader/loadable_module_scripts/DDScanSubs.js
diff

Modified Files:


xtrn/DDMsgReader/readme.txt
diff

Removed Files:


xtrn/DDArchiveViewer/FILE_ID.DIZ
diff

Merge branch 'dd_remove_spaces' into 'master'

Removed spaces from some filenames of Digital Distortion mods that had them

See merge request main/sbbs!147

Modified Files:


CONTRIBUTING.md
diff

Add notes about added filename preferences/expectations.

Modified Files:


docs/system_config.html
diff

Redirect to the appropriate wiki page which now has this content

Thank you Andre!

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Fixed message list time colors for wide terminals (above 80 columns)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_list_time_color_fix' into 'master'

Fixed message list time colors for wide terminals (above 80 columns)

Closes #351

See merge request main/sbbs!146

Modified Files:


src/xpdev/filewrap.h
diff

Fix sbbs-windows build

BCC error filewrap.h 77: Multiple declaration for 'mode_t'

Introduced in commit e4adeee8

Modified Files:


src/xpdev/genwrap.c
diff

Fix MSVC warning in xp_timer64()

genwrap.c(855): warning C4244: '=': conversion from 'LONGLONG' to 'uint32_t',
possible loss of data

Modified Files:


src/sbbs3/text_defaults.c
diff

New e-mail, not Internet e-mail

Modified Files:


src/xpdev/gen_defs.h
diff

Even when MSVC has inttypes.h, it still doesn't have ssize_t

Modified Files:


src/xpdev/filewrap.h
diff

Add a mingw32 compatible mode_t

Added Files:


3rdp/build/cl-remove-march.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Remove cryptlib's -march=native to avoid SIGILL on x86_64 systems, where SBBS
is compiled on a differnt host to where it is run.

This should fix issue main/sbbs#324

Added Files:


3rdp/build/cl-remove-march.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Merge branch 'master' into 'master'

Remove cryptlib's -march=native to avoid SIGILL on x86_64 systems, where
SBBS...

Closes #324

See merge request main/sbbs!144

Modified Files:


src/conio/cterm.c
diff

Add a UINT64_MAX hack for VS 2022

Not sure why this isn't defined from inttypes.h, but blah.

Modified Files:


ctrl/text.dat
diff

Add new text.dat strings for The Millionaire

- InternetMailReceived
- InternetMailForwarded
- FidoNetMailReceived
- WithAttachment
- FidoEchoMailReceived

The first string (suppressed with %.0s) is an optional date/time stamp.

Modified Files:


src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

Add/use new text.dat strings for received Fido and Internet mail

- InternetMailReceived
- InternetMailForwarded
- FidoNetMailReceived
- WithAttachment
- FidoEchoMailReceived

For The Millionaire, closing issue #254

The first string (suppressed with %.0s) is an optional date/time stamp.

This also deprecates (removes support for) the [mail] NewMailNotice and
ForwardNotice keys from sbbs.ini.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader v1.45: Fixed message scanning & searching issues introduced in the
previous version.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_145_scan_fix' into 'master'

DDMsgReader v1.45: Fixed message scanning & searching issues introduced in the
previous version.

Closes #344

See merge request main/sbbs!145

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Save/restore the current selected user

Addresses issue #350.

Also fixed up the alignment of the header/columns.

Modified Files:


src/sbbs3/userdat.c
diff

Handle filelength() possibly returning negative value

CID 349724

Modified Files:


webv4/components/navbar.xjs
diff

Include path component of .link pages in menus/submenus.
Probably resolves the "Invalid page" problem reported by W6RAY.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Just use our local C macro MAX()

Modified Files:


src/sbbs3/sbbs_status.c
diff

Fix extra argument in printf format specifier

CID 319101

Beautified another lprintf() statement while at it.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Fix potential divide by zero

CID 330961

Modified Files:


src/sbbs3/sbbs_status.c
diff

Fix invalid type in argument to printf format specifier

CID 319001

Modified Files:


src/sbbs3/js_com.c
diff

Fix invalid type in argument to printf format specifier

CID 319142

Modified Files:


src/sbbs3/js_socket.c
diff

Fix invalid type in argument to printf format specifier

CID 319135

Fix the return value of js_socket_sendfilesocket() while we're here (off_t
instead of int).

Modified Files:


src/sbbs3/main.cpp
diff

Delete dead code

CID 174474

Modified Files:


src/sbbs3/smbutil.c
diff

Comment intentional case fall-through

CID 33205

Modified Files:


src/sbbs3/ars.c
diff

Comment intentional case statement fall-throughs

CID 33207
CID 33208
CID 33209

Modified Files:


src/sbbs3/ars.c
diff

src/sbbs3/execfunc.cpp
diff

Document intentional case fall-throughs

CID 33210
CID 33211

Modified Files:


src/sbbs3/allusers.c
diff

Comment intentional fall-through

CID 33212

Modified Files:


src/sbbs3/dstsedit.c
diff

Comment intentional case fall-through

CID 33213