Synchronet Git Commit Log

This is a log of the 500 most recent pushes to the master branch of the Synchronet Git repository.
If you want to view more pushes/commits, you can by passing ?<number> in URL.
  1. Nigel Reed
    Tue Jul 23 2024 15:11:31 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/mrc/mrc-client.js diff
    Missing quote mark added.

  2. Rob Swindell
    Tue Jul 23 2024 15:11:31 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/mrc/mrc-client.js diff
    Merge branch 'mrc_fix_missing_quote' into 'master' Missing quote mark added. See merge request main/sbbs!446

  3. Nigel Reed
    Mon Jul 22 2024 15:51:24 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/mrc/mrc-client.js diff
    Add ssl support for server to server connections.

  4. Rob Swindell
    Mon Jul 22 2024 15:51:24 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/mrc/mrc-client.js diff
    Merge branch 'mrc_ssl' into 'master' Add ssl support for server to server connections. See merge request main/sbbs!445

  5. Rob Swindell (on Debian Linux)
    Sun Jul 21 2024 13:58:35 GMT-0700 (PDT)
    Modified Files:
    

    exec/text_sec.js diff
    Check console.aborted flag in display loops So that hitting 'N' at pause prompt will abort the loop. Reported by phigz via irc.synchro.net

  6. Nigel Reed
    Sat Jul 20 2024 12:14:59 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/mrc/mrc-client.example.ini diff
    xtrn/mrc/mrc-client.js diff
    xtrn/mrc/mrc-connector.example.ini diff
    xtrn/mrc/mrc-connector.js diff
    xtrn/mrc/readme.txt diff
    Add ssl support for server to server connections.

  7. Rob Swindell
    Sat Jul 20 2024 12:14:59 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/mrc/mrc-client.example.ini diff
    xtrn/mrc/mrc-client.js diff
    xtrn/mrc/mrc-connector.example.ini diff
    xtrn/mrc/mrc-connector.js diff
    xtrn/mrc/readme.txt diff
    Merge branch 'mrc_ssl' into 'master' Add ssl support for server to server connections. See merge request main/sbbs!443

  8. Rob Swindell (on Debian Linux)
    Wed Jul 17 2024 13:15:18 GMT-0700 (PDT)
    Modified Files:
    

    exec/logonlist.js diff
    Allow time format to be set via modopts.ini [logonlist] time_fmt ... in strftime format (https://cplusplus.com/reference/ctime/strftime/) If you (sysop) have last_few_callers_fmt set to a custom value in your modopts.ini, you'll need to update that format as a result of this change: the number and type of arguments have now changed: instead of the logon time be passed as hours and minutes (integers), it's now passed as a single a string. That string is the result of a call to strftime() with the time_fmt or (by default), "%H:%M". This change was made to accommodate request by NeoArata (THEREALM)

  9. Rob Swindell (on Debian Linux)
    Tue Jul 16 2024 12:22:33 GMT-0700 (PDT)
    Modified Files:
    

    exec/irc.js diff
    Add '-p' option to over-ride password sent to server via PASS message If -p (or -P) is the last option given with no argument following, then no password would be sent to the server (via PASS message). For Odusseus71

  10. Rob Swindell (on Debian Linux)
    Mon Jul 15 2024 19:51:34 GMT-0700 (PDT)
    Modified Files:
    

    exec/default.js diff
    Don't display the sysop file transfer menu (in response to '!' key) ... for non-sysops

  11. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 19:38:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Include current node number intead of socket descriptor in highwater log msg looks better, more consistent with the log messages before/after it.

  12. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 19:28:09 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Fix *nix build We removed the large-scope 'i', but didn't update the Unix-only blocks of code (dealing with UNIX domain spy sockets).

  13. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 18:49:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/mqtt.c diff
    Clear (set to 0) each server's "highwater" topic upon startup The other server stats (e.g. error_count, served) are zeroed upon startup, so the highwater mark should be zeroed too.

  14. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 19:00:50 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Fix incorrect 'socket' value for new (highwater) log message

  15. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 19:15:43 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Eliminate large-scoped 'i' variable in bbs_thread() This is just a code quality (readability) improvement. No functional change.

  16. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 18:30:53 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/services.c diff
    Track/log/publish-to-MQTT services server (total) client highwater mark Like the other servers. A sysop likely would want to know which services/protocols had what utilization (as a portion of the total highwater mark), so that'll have to be added later.

  17. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 13:38:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Fix off-by-one reporting of "active client highwater mark" Only log the hightwater mark when it's > 1. :-)

  18. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 17:29:03 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Publish client highwater mark (max concurrent client stat) to MQTT

  19. Rob Swindell (on Windows 11)
    Thu Jul 11 2024 17:30:04 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/main.cpp diff
    Log and MQTT-public active client highwater values when seen/reached We don't log highwater valeus of 1, though those are published to MQTT. Not dealing with 'services' server yet, cause that's kind of tricky with the sysop likely wanting to know per-service stats (served counter, highwater mark, etc.)

  20. Rob Swindell (on Debian Linux)
    Tue Jul 09 2024 20:40:03 GMT-0700 (PDT)
    Added Files:
    

    exec/load/filelist_lib.js diff
    Modified Files:

    exec/addfiles.js diff
    libify the filelist (e.g. FILES.BBS) parsing logic in addfiles.js ... for (soon) reuse in fileman.js

  21. Rob Swindell (on Debian Linux)
    Tue Jul 02 2024 12:30:52 GMT-0700 (PDT)
    Modified Files:
    

    exec/bullseye.js diff
    Don't exclude the missing bulletin files from the list (change in last commit) ... since that messes up the bulletin->file numbering which is often hard-coded in bullseye.asc

  22. Rob Swindell (on Debian Linux)
    Tue Jul 02 2024 12:39:19 GMT-0700 (PDT)
    Modified Files:
    

    exec/bullseye.js diff
    Log bulletin file view success/failure more accurately Also updated log output format, avoid redundancy

  23. Rob Swindell (on Debian Linux)
    Tue Jul 02 2024 12:26:35 GMT-0700 (PDT)
    Modified Files:
    

    exec/typeasc.js diff
    Fix "undefined" filename in error message if file doesn't exist

  24. Rob Swindell (on Debian Linux)
    Tue Jul 02 2024 12:26:35 GMT-0700 (PDT)
    Modified Files:
    

    exec/bullseye.js diff
    Refactor, make bullseye menu file (e.g. bullseye.asc) optional Use console.uselect() to list the bulletin files, if the menu file (e.g. bullseye.asc) doesn't exist. For Amessyroom. Don't replace the Pause (hit a key) prompt, since that messes up localizaton support (reverts to the text.dat Pause prompt, instead of the text.*.ini translated Pause prompt). The replace/revert text buffers should really be a stack for a full fix for this. Missing bulletin files are automatically excluded from the bulletin list. The rest is just clean-up from the conversion from Baja. This is still a very old/basic script, but at least it's not quite as hideous and outdated as before. Increment the version to 3.00.

  25. Eric Oulashin
    Sun Jun 30 2024 16:20:20 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: When listing messages via lightbar, check if the subject is UTF-8, which now helps the lightbar menu display the line properly, particularly for UTF-8 terminals

  26. Rob Swindell
    Sun Jun 30 2024 16:20:20 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_msg_list_utf8' into 'master' DDMsgReader: When listing messages via lightbar, check if the subject is UTF-8, which now helps the lightbar menu display the line properly, particularly for UTF-8 terminals See merge request main/sbbs!442

  27. Eric Oulashin
    Sat Jun 29 2024 16:45:56 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    dd_lightbar_menu.js: Fixed text truncation issue when displaying item text when we know it's UTF-8

  28. Rob Swindell
    Sat Jun 29 2024 17:10:44 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_write_item_utf8_improvement' into 'master' dd_lightbar_menu.js: Fixed text truncation issue when displaying item text when we know it's UTF-8 See merge request main/sbbs!441

  29. Rob Swindell (on Debian Linux)
    Sat Jun 29 2024 16:23:21 GMT-0700 (PDT)
    Modified Files:
    

    exec/newuser.js diff
    Allow dash character in new QWKnet account names ... as reported by Mike Powell, and amessroom and root-caused by Nightfox A '-' is a valid QWK-ID character since it is a valid DOS filename character.

  30. Eric Oulashin
    Mon Jun 24 2024 17:11:50 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    dd_lightbar_menu: str_is_utf8() seems to return true sometimes when a string doesn't have UTF-8, so that is now commented out for now

  31. Rob Swindell
    Thu Jun 27 2024 14:43:51 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_text_is_utf8_dont_use_str_is_utf8' into 'master' dd_lightbar_menu: str_is_utf8() seems to return true sometimes when a string doesn't have UTF-8, so that is now commented out for now See merge request main/sbbs!440

  32. Eric Oulashin
    Sun Jun 23 2024 13:25:56 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: Fix for msgText being undefined when doing a message search

  33. Rob Swindell
    Sun Jun 23 2024 14:29:31 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_search_msgbase_msgtext_undefined_fix' into 'master' DDMsgReader: Fix for msgText being undefined when doing a message search See merge request main/sbbs!439

  34. Eric Oulashin
    Sat Jun 22 2024 21:21:30 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    dd_ligbtar_menu.js: Fix for behavior with the item color when printing the last portion of an item. Also, UTF8 detection improvement.

  35. Rob Swindell
    Sat Jun 22 2024 21:21:30 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_list_utf8_detection_and_bkg_color' into 'master' dd_ligbtar_menu.js: Fix for behavior with the item color when printing the last portion of an item. Also, UTF8 detection improvement. See merge request main/sbbs!438

  36. Rob Swindell (on Debian Linux)
    Fri Jun 21 2024 12:44:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    Fix new small memory leak (no need to use strdup here) Fix CID 497098

  37. Rob Swindell (on Windows 11)
    Fri Jun 21 2024 12:33:13 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    Fix getnodedat() error handling and usage If a file descriptor is passed to getnodedat() and the lock retry counter was reached, the file would be closed, but the passed file descriptor reference would not be set to -1. This could result in exceptions (from subsequent read attempts on the referenced file descriptor) in cases where the node.dab could not be locked or read by getnodedat() and was thus closed. The set/get_node_* helper functions (used by MQTT) were not initializing the node.dab file descriptor (i.e. to -1), so it's possible getnodedat() could try to read from and close an invalid/wrong open file descriptor. If the local variable happened to be initialized to a value <= 0, then, no problem, but this is undefined behavior (UB).

  38. Rob Swindell (on Debian Linux)
    Thu Jun 20 2024 15:00:00 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc32.c diff
    Expand tabs and ignore form-feeds in showbuf/help text

  39. Rob Swindell (on Debian Linux)
    Thu Jun 20 2024 15:11:56 GMT-0700 (PDT)
    Modified Files:
    

    exec/fileman.js diff
    Pass filename (instead of file-obj) to FileBase.get[_path/size/time] methods to work around recently-fixed bug with > 64 char filenames parsed from file-meta-objects. Although this bug was fixed in [lib]sbbs[.so|.dll] might as well use the backward-compatible method to set a better example that works as expected with SBBS v3.19.

  40. Rob Swindell (on Debian Linux)
    Thu Jun 20 2024 16:33:53 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc32.c diff
    Truncate long titles in showbuf() the corrupt the screen and the heap Don't actually truncate the string, just the display length

  41. Rob Swindell (on Debian Linux)
    Thu Jun 20 2024 16:34:58 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    Fix bug with FileBase.get_time() for filenames > 64 chars in length We need to read the file header (not just index) entry to get the actual full filename. Also, removed some extraneous calls to getfilepath() that served no purposed.

  42. Rob Swindell (on Debian Linux)
    Thu Jun 20 2024 16:36:46 GMT-0700 (PDT)
    Modified Files:
    

    exec/fileman.js diff
    Fix one remaining FileBase.get_path() call that passed file-meta-object (instead of file name), which would have issues in SBBS v3.19 for filenames > 64 chars in length. Also, remove extraneous calls to format().

  43. Rob Swindell (on Debian Linux)
    Thu Jun 20 2024 20:58:26 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/load_cfg.c diff
    Fix small memory leak when loading lib "Auto-Add Subs" feature enabled caught by valgrind

  44. Rob Swindell (on Debian Linux)
    Thu Jun 20 2024 21:24:55 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifcx.c diff
    Pretend we know the screen width and that it's 132 columns wide ... for UIFC apps/scripts that have screen-width dependant behavior.

  45. Rob Swindell (on Debian Linux)
    Fri Jun 21 2024 00:10:23 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc.h diff
    src/uifc/uifc32.c diff
    Introduce a restore() uifc_api method for restoring a saved window buffer This allows for menu options on an "active" list (with both WIN_SAVE and WIN_ACT mode flags) to close the window and restore the most recently saved window. Also, for the range check on the save buffer count in ulist(), if we've hit the bounds, don't *just* beep (though, that was useful), but turn off the WIN_SAV mode flag so we don't overflow the sav[] array and corrupt the heap!

  46. Rob Swindell (on Debian Linux)
    Fri Jun 21 2024 00:15:13 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_uifc.c diff
    Use the new uifc_t.restore() method when decrementing the save_num This is the proper way to manually-restore the most recently saved window (via the WIN_SAV mode flag to the list() method). I wanted something that was backward comaptible with earlier builds of SBBS, so just doing a magic thing when decrementing the save_num rather than adding a new method seemed the seamless way to do it.

  47. Rob Swindell (on Debian Linux)
    Fri Jun 21 2024 00:18:31 GMT-0700 (PDT)
    Modified Files:
    

    exec/fileman.js diff
    Add new "Search Pending Files" operation Sort of the opposite of the "Offline Files" search, find files copied into the directory storage paths but not yet added to the filebase, with a "Add File..." option (and tagging support) along with DELete files option. Auto-ignore listing files (e.g. FILES.BBS, etc.) when searchign for new files to add to a directory's filebase. If an argument is passed to fileman.js, use that as the UIFC mode (for testing purposes only). Fix case-sensitive file compares (on *nix OSes) when adding files (now case-insensitive). Fix issue with get file paths for files not yet in a filebase (using FileBath.get_path unnecessarily). Display virtual paths to files in many place, when available (> SBBS v3.19).

  48. Rob Swindell (on Windows 11)
    Thu Jun 20 2024 14:49:32 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    Fix 64-char filename length limit for FileBase.get[_path/size/time] methods This was only a problem when these methods were passed a file-meta-object instead of the file name. In hindsight, that's kind of a dumb API "feature" since we're just parsing the name property out of the object. The file_t.file_idx.name is limited to 64 chars, so don't use that struct element to store the parsed "name" property of the passed file-meta-object.

  49. Rob Swindell (on Debian Linux)
    Wed Jun 19 2024 19:35:02 GMT-0700 (PDT)
    Modified Files:
    

    exec/fileman.js diff
    Support viewing text files, deal with LF-terminated extended descriptions Text files with recognized plain text file names/extensions can be viewed from within fileman now. Some extended descriptions may only be terminated with LF (instead of CRLF), so deal with those accordingly. Some auto-translation from LF to CRLF terminated extended description lines may occur when editing extended descriptions.

  50. Rob Swindell (on Debian Linux)
    Tue Jun 18 2024 22:26:42 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc.h diff
    src/uifc/uifc32.c diff
    src/uifc/uifcx.c diff
    Add WIN_BLANKOPTS list() option, to support options/lists with blank lines This requires that the option list be NULL-terminated, when used. For use with js_uifc.c (JS uifc.list method). For some reason, this exposed an issue where "(null)" would be printed for the last line when combined with WIN_XTR mode flag, so worked around that bug too.

  51. Rob Swindell (on Debian Linux)
    Tue Jun 18 2024 22:28:53 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_uifc.c diff
    Use new uifc.list mode flag WIN_BLANKOPTS uifc option lists are always NULL-terminated string lists (not static arrays of char arrays, as is often used in other UIFC utils), so grow the ability to have blank options (list items). This was needed for fileman.js to accurately edit extended file descriptions that contain blank lines.

  52. Rob Swindell (on Debian Linux)
    Tue Jun 18 2024 22:34:21 GMT-0700 (PDT)
    Modified Files:
    

    exec/fileman.js diff
    Add ability to add files, display/edit extended descriptions (yes, I know, unzip for DIZ can corrupt the TUI display when adding files) Add ability to display and edit extended file descriptions (including inserting and deleting lines. Fixed bug with moving files between dirs. F2 is now just a shortcut for renaming files, ENTER is the main edit/display option key now. This really requires an updated sbbs/jsexec to work fully correct (e.g. display/edit extended descriptions that contain blank lines).

  53. Rob Swindell (on Debian Linux)
    Mon Jun 17 2024 20:40:18 GMT-0700 (PDT)
    Modified Files:
    

    exec/viewimsgs.js diff
    A bit more dynamically translated/localizable

  54. Rob Swindell (on Debian Linux)
    Mon Jun 17 2024 19:29:32 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Make filebase status output less confusing ("file" not "msg") Cosmetic change only, output of 'smbutil s' command when used on a filebase. Increment the SMBUTIL version from 3.19 to 3.20

  55. Rob Swindell (on Debian Linux)
    Mon Jun 17 2024 19:33:31 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc.h diff
    src/uifc/uifc32.c diff
    Add suport for option/item tagging using the WIN_TAG ulist() mode flag For use with fileman.js: The space bar can be used by the user to "tag" items, or Ctrl-A to toggle tag status for *all* items. Returns MSK_TAG|with the option tagged/untagged or MSG_TAGALL when all tags are being toggled (via ^A). Also, fix bug where ^Find command would not restore the status bar after ulist() would overwrite it with the string-input/edit hot-keys available.

  56. Rob Swindell (on Debian Linux)
    Mon Jun 17 2024 19:36:35 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/uifcdefs.js diff
    Add WIN_TAG, MSK_TAG, MSG_TAGALL and (missing) WIN_HLP definitions

  57. Rob Swindell (on Debian Linux)
    Mon Jun 17 2024 20:06:30 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    FileBase.add() now supports override to *never* extract/use DIZ if desired Working on fileman.js, when moving files to another base, the output of unzip (trying to extra a FILE_ID.DIZ) was corrupting the display. We don't really want a DIZ file to get imported when moving files between bases anyway. So the second parameter to FileBase.add() can be either: - undefined: will try to extract/use DIZ only if there's no ext desc already - true: will try to extract/use a DIZ even if there's an ext desc already - false: will never try to extract/use a DIZ If the directory is not configured for DIZ support, then the DIZ extraction/use will never occur under any condition.

  58. Rob Swindell (on Debian Linux)
    Mon Jun 17 2024 20:16:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    Better JSDOC description of use_diz param to FileBase.add()

  59. Rob Swindell (on Debian Linux)
    Mon Jun 17 2024 20:37:32 GMT-0700 (PDT)
    Modified Files:
    

    exec/fileman.js diff
    Add multi-file tagging, deleting, moving A bunch of other improvements, cosmetic and functional (viewing archives, editing more File fields, etc.).

  60. Rob Swindell (on Debian Linux)
    Sun Jun 16 2024 14:22:33 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/json-sock.js diff
    More detail to JSON.parse() error in Socket.prototype.recvJSON This is likely the cause of the vauge logged error that I and other sysops see from time to time: srvc 0000 JSON SyntaxError: JSON.parse ... so log the function name and the contents of the string that's failing to parse.

  61. Rob Swindell (on Debian Linux)
    Sun Jun 16 2024 14:26:38 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/json-sock.js diff
    Include the service descriptor in the JSONrecv error message

  62. Rob Swindell (on Debian Linux)
    Fri Jun 14 2024 21:38:45 GMT-0700 (PDT)
    Added Files:
    

    exec/fileman.js diff
    New Synchronet File Manager (run using jsexec) This is a new TUI-style filebase browser/editor for sysop use. Sysops can search files, descriptions/metadata, uploader names, offline files and then easily remove/delete or edit those file's names, description, uploader. Ideas for improvements (e.g. file tagging/bulk deleting) may require updates to UIFC. This is a proof of concept at least and provides some functionality already.

  63. Rob Swindell (on Debian Linux)
    Fri Jun 14 2024 21:02:45 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/smbdump.c diff
    If the msg type is 'File', the subject is the Filename, so say so in the dump

  64. Rob Swindell (on Debian Linux)
    Thu Jun 13 2024 18:04:37 GMT-0700 (PDT)
    Modified Files:
    

    exec/fseditor.js diff
    Open the quote file in "binary" mode (only applicable on Windows) If the quote file contained a Ctrl-Z (ASCII 26) char, it would be truncated at that point. Some UTF-8 messages that include a "right arrow" unicode code point are translated to ASCII Ctrl-Z (ASCII 26) char, which is interpretted by Windows as "EOF" (end of file) marker for files open in "text mode" and the file won't be read beyond that char. Open the file in binary mode to more closely match the *nix fopen() before.

  65. Rob Swindell (on Windows 11)
    Sun Jun 09 2024 20:24:01 GMT-0700 (PDT)
    Modified Files:
    

    src/sexpots/release.bat diff
    Build the git_*.h files on Win32 from here too

  66. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 20:21:15 GMT-0700 (PDT)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Log an error if calls to send() don't return the expected value This addresses GCC warnings about not using the return value of send().

  67. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 20:12:28 GMT-0700 (PDT)
    Modified Files:
    

    src/sexpots/GNUmakefile diff
    Build git_branch.h and git_hash.h here This rule should really be in build/Common.gmake or similar

  68. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 20:15:07 GMT-0700 (PDT)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Fix warning about potential uninitialize variable value use

  69. Rob Swindell (on Windows 11)
    Sun Jun 09 2024 19:20:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Output the Git repo/branch/hash details in execution banner Not sent in connection banner.

  70. Rob Swindell (on Windows 11)
    Sun Jun 09 2024 19:20:47 GMT-0700 (PDT)
    Modified Files:
    

    docs/sexpots.txt diff
    Updated to latest details (e.g. GIt, not CVS)

  71. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 18:52:06 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/logonlist_lib.js diff
    exec/logonlist.js diff
    Log the current connection protocol as a separate property in logon.jsonl Accession reported that (sometimes?) his NNTP logins show up in his logon.jsonl files. This is most likely just a race condition when logging in close to the same time with multiple protocols (e.g. Telnet and NNTP in this case). So, let's log the client.protocol as a separate JSON property and not require on the user.connection property (which is overwritten for *every* login, for almost all connection/server types, not just the terminal server). The client.protocol is always correct for the current session running the script. An NNTP login should never appear in the logon.json file.

  72. Rob Swindell (on Windows 11)
    Sun Jun 09 2024 18:42:05 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_user.c diff
    Make legacy/alias properties non-enumerable: computer, modem I noticed these redundant properties were being logged for every logon in logon.jsonl. We don't need these properties separately enumerable, and really they shouldn't be used anyway. computer is an alias of host_name modem is an alias of connection

  73. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 17:50:03 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/logonlist_lib.js diff
    When pulling from previous days to fulfill the "last few callers list", insert Insert (using unshift) to the beginning of the list, rather than append (using push) to the end of the list. This fixes issue #761

  74. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 16:38:03 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Replace line-feeds with space in extended descriptions used for short desc Fixes cosmetic/readability issue when imported DIZ files that have line/word wrapped text and the space between words was being removed.

  75. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 16:07:37 GMT-0700 (PDT)
    Modified Files:
    

    exec/logonlist.js diff
    Add some usage comments

  76. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 15:49:24 GMT-0700 (PDT)
    Modified Files:
    

    exec/logonlist.js diff
    If passing a non-zero integer, display logons from that many days ago Similar to -y option, but supports going further back than just yesterday.

  77. Rob Swindell (on Debian Linux)
    Sun Jun 09 2024 00:05:22 GMT-0700 (PDT)
    Modified Files:
    

    exec/update.js diff
    Fix typo in output: that's attr.cfg -> attr.ini, not file.cfg -> file.ini As reported by Keyop

  78. Rob Swindell (on Windows 11)
    Mon Jun 03 2024 22:21:36 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Add test command 'Z' for locking an SMB header until keypress Just for testing/experimenting with proper recording locking support. e.g. when one process or network node (on a LAN) has the SMB header locked, another process/node should not be able to lock it or reading the status header.

  79. Rob Swindell (on Windows 11)
    Mon Jun 03 2024 21:15:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    Update help text on startup directory options. Now can include command-line specifiers.

  80. Rob Swindell (on Windows 11)
    Sat Jun 01 2024 18:41:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Add support for command-line specifiers in external program 'startup dir' The exception is: DOS programs on Linux (e.g. Linux DOSEMU), due to the funky drive letter mappng, this can't be supported for those external programs. As requested by Fluid via IRC, for Frotz support, to store user-unique data files in data/user/####.something (e.g. "%juser/%4.zork").

  81. Eric Oulashin
    Wed May 29 2024 13:48:59 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    exec/load/dd_lightbar_menu.js diff
    dd_lightbar_menu: Added KEY_F* defines in there that were referenced in getKeyWithESCChars(). Refactored the includes in SlyEdit, since SlyEdit uses getKeyWithESCChars()

  82. Rob Swindell
    Wed May 29 2024 13:48:59 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_slyedit_get_key_with_esc_chars_f_key_refactor' into 'master' dd_lightbar_menu: Added KEY_F* defines in there that were referenced in getKeyWithESCChars(). Refactored the includes in SlyEdit, since SlyEdit uses getKeyWithESCChars() See merge request main/sbbs!437

  83. Rob Swindell (on Debian Linux)
    Mon May 27 2024 23:29:57 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/telgate.cpp diff
    Address unused return value warnings from GCC

  84. Rob Swindell (on Windows 11)
    Mon May 27 2024 23:24:27 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/telgate.cpp diff
    Fix GCC compile error (can't use __FUNCTION__ macro like that) And warning about signed/unsigned compare

  85. Rob Swindell (on Debian Linux)
    Mon May 27 2024 23:18:18 GMT-0700 (PDT)
    Modified Files:
    

    exec/telgate.js diff
    exec/unixgate.js diff
    Use the telnet gateway proxy (not pass-through) by default Pass-through only really does anything useful if the BBS user's client is a Telnet client and it responds as the server expects. Since the user's Telnet client (when using one) has already negotiated Telnet options, they won't ACK options that the server expects them to, so this doesn't really work. The proxy fixes that issue.

  86. Rob Swindell (on Windows 11)
    Mon May 27 2024 23:14:26 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/telgate.cpp diff
    telnet_gateway() is now, by default, a telnet proxy Meaning, it'll negotiate all Telnet options with the remote server (assuming not an RLogin server), so long as the TG_PASSTHRU option is *not* set. This allows more Telnet servers to work as expected, especially when the client (BBS user) is not using a Telnet client! Fix issue #432

  87. Rob Swindell (on Windows 11)
    Mon May 27 2024 23:14:26 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/telnet_io.c diff
    We don't support echo (sending what we receive back to the server).

  88. Rob Swindell (on Debian Linux)
    Mon May 27 2024 17:19:09 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cfglib.js diff
    Add missing xtrn.ini "hotkey" section read/writing Also arrange section writing order to match scfglib2.c

  89. Rob Swindell
    Mon May 27 2024 15:58:25 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    Don't set MinimalRebuild option to true Avoid build warning about use of deprecated /Gm option.

  90. Rob Swindell (on ChromeOS)
    Sat May 25 2024 19:27:42 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/uedit/uedit.c diff
    Default to 80x25 LCD video mode

  91. Rob Swindell (on ChromeOS)
    Sat May 25 2024 19:35:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/umonitor/umonitor.c diff
    Add support for umonitor.ini (with fallback to uifc.ini) ... for uifc/ciolib settings And make default video mode LCD 80x25

  92. Rob Swindell (on ChromeOS)
    Sat May 25 2024 19:00:07 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/asc2ans.c diff
    Display Git branch/hash instead of VERSION for revision info (like ans2asc) This should fix the Win32 build.

  93. Rob Swindell (on ChromeOS)
    Sat May 25 2024 18:36:43 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/umonitor/umonitor.c diff
    Eliminate use of CVS Revision keyword

  94. Rob Swindell (on ChromeOS)
    Sat May 25 2024 18:38:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/makeuser.c diff
    Eliminate use of CVS Revision keyword

  95. Rob Swindell (on ChromeOS)
    Sat May 25 2024 18:48:12 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/asc2ans.c diff
    src/sbbs3/baja.c diff
    src/sbbs3/unbaja.c diff
    Eliminate use of CVS Revision keyword

  96. Rob Swindell (on Debian Linux)
    Sat May 25 2024 17:25:14 GMT-0700 (PDT)
    Modified Files:
    

    exec/noyesbar.js diff
    exec/yesnobar.js diff
    Fix issue where Ctrl-C would leave a 'N' in the keyboard input buffer This problem doesn't happen with the .bin version of these scripts.

  97. Rob Swindell (on Debian Linux)
    Sat May 25 2024 16:56:54 GMT-0700 (PDT)
    Modified Files:
    

    exec/cleanup.js diff
    Clean up the old attr.cfg file Thanks for the reminder, Keyop

  98. Rob Swindell (on Windows 11)
    Sat May 25 2024 15:48:21 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/attr.ini diff
    Add new rainbow attribute key If this key doesn't exist, the default value is used So it's not a big deal if your ctrl/attr.ini file is missing or doesn't have any particular key in it.

  99. Rob Swindell (on Windows 11)
    Sat May 25 2024 15:23:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/uedit/uedit.c diff
    Elminte use of CVS Keyword for revision number

  100. Rob Swindell (on Windows 11)
    Sat May 25 2024 15:28:19 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc_ini.c diff
    Make the video_mode and ciolib_mode out params option (may be NULL)

  101. Rob Swindell (on Windows 11)
    Sat May 25 2024 15:30:54 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/uedit/uedit.c diff
    Add support for ctrl/uedit.ini (with fallback to uifc.ini) For Nelgin

  102. Rob Swindell (on Windows 11)
    Sat May 25 2024 15:15:10 GMT-0700 (PDT)
    Added Files:
    

    src/uifc/uifc_ini.c diff
    Modified Files:

    src/uifc/objects.mk diff
    src/uifc/uifc.h diff
    src/uifc/uifc.vcxproj diff
    Create read_uifc_ini() for a common method of reading UIFC/CIOLIB .ini files Copied from read_scfg_ini() in scfg.c

  103. Rob Swindell (on Windows 11)
    Sat May 25 2024 15:17:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    Use new read_uifc_ini() to scfg.ini or (if it doesn't exist), uifc.ini

  104. Rob Swindell (on Windows 11)
    Sat May 25 2024 15:18:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    Add support for ctrl/echocfg.ini (or fallback to ctrl/uifc.ini) For controlling the UIFC/CIOLIB properties (scaling, modes, etc.)

  105. Rob Swindell (on Debian Linux)
    Sat May 25 2024 14:18:03 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_file.c diff
    Don't convert/store small integers to doubles when reading/writing .ini files Fix issue #760 UINT_TO_JSVAL automatically handles the storage as the necsesary underlying type in the JS engine. Values > 0x7fffffff (2147483647) will still be stored (and re-written) as doubles and could be problematic.

  106. Rob Swindell (on Windows 11)
    Sat May 25 2024 12:02:32 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/con_out.cpp diff
    Move the line_delay logic so it has effect on PETSCII terminals too Fix issue #759

  107. Rob Swindell (on Debian Linux)
    Fri May 24 2024 17:46:35 GMT-0700 (PDT)
    Modified Files:
    

    exec/cleanup.js diff
    Remove unused remove() function definition

  108. Rob Swindell (on Debian Linux)
    Fri May 24 2024 18:34:03 GMT-0700 (PDT)
    Modified Files:
    

    src/encode/hex.c diff
    src/encode/hex.h diff
    hex_decode() now supports no-escape char, if desired

  109. Rob Swindell (on Debian Linux)
    Fri May 24 2024 21:19:03 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/con_out.cpp diff
    src/sbbs3/load_cfg.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/prntfile.cpp diff
    src/sbbs3/putmsg.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfgdefs.h diff
    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib2.c diff
    src/sbbs3/str_util.c diff
    Add rainbow (elite text) attribute feature New key "rainbow" in ctrl/attr.ini New Ctrl-A codes: 'X' to turn on repeating/wrapping rainbow attributes, 'x' to turn on non-repeating/wrapping rainbow attributes. New @-code: RAINBOW:x to set the list of (comma-separated) rainbow attribute values (in same form as attr.ini). When used in a display file, the rainbow attribute change is temporary. Ever wanted to add alternating attributes to @-code expanded text in display files? Now you can. Also can be used to easily/quickly create display files with repeating elements (e.g. commands/options) using alternating attributes.

  110. Rob Swindell (on Debian Linux)
    Wed May 22 2024 17:12:11 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    src/sbbs3/xtrn_sec.cpp diff
    Clear mouse hotspots when executing *any* external program/script Previously, we only cleared hotspots when executing any external from the external program section (doors menu). This means that invoking a script or external program (e.g. via JS bbs.exec()) from anywhere else, any current mouse hotspots would remain active. Disable those. This fixes issue #758

  111. Rob Swindell (on ChromeOS)
    Tue May 21 2024 20:09:17 GMT-0700 (PDT)
    Added Files:
    

    ctrl/attr.ini diff
    Removed Files:

    ctrl/attr.cfg diff
    Replace attr.cfg with attr.ini (similar, but not same format)

  112. Rob Swindell (on ChromeOS)
    Tue May 21 2024 19:37:13 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    src/sbbs3/load_cfg.c diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfgdefs.h diff
    Replace ctrl/attr.cfg (customized text colors/attrs) with ctrl/attr.ini Another legacy config file replaced with .ini file (for easier editing and future extensibility). No longer dynamically allocate scfg_t.colors (no need). There's really no reason why this is still an array, but leave as is for now. Also, I noticed JS console.color_list (also an array) is not enumerable (or documented) - that should be fixed.

  113. Rob Swindell (on ChromeOS)
    Tue May 21 2024 19:40:45 GMT-0700 (PDT)
    Modified Files:
    

    exec/update.js diff
    Upgrade attr.cfg to attr.ini The extra characters (comments) are ignored when parsing this particular file, so though this is not how we normally add comments to .ini files, it still works fine in this case.

  114. Rob Swindell (on ChromeOS)
    Fri May 17 2024 17:32:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/qwk.cpp diff
    P-restricted users (including QWKnet accounts) can no-longer post polls This was a loop-hole that caused Denn (OUTWEST) some confusion, those his QWKnet account could post polls, it could not post messages due to having the P-restriction.

  115. Deucе
    Wed May 15 2024 20:33:30 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord/lord.js diff
    reLoad() does not return the record. Fixes error reported by Rowyn Sand (Ravne) with accepting a marriage proposal (issue #757)

  116. Rob Swindell (on ChromeOS)
    Wed May 15 2024 19:41:07 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/scfg/scfg.c diff
    Set ciolib_initial_mode before calling initciolib() ... rather than calling textmode() after. This solves the problem of black bars above and below the UIFC window in echocfg and SCFG on ChromeOS, at least.

  117. Rob Swindell (on ChromeOS)
    Wed May 15 2024 19:45:26 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    src/sbbs3/js_system.c diff
    src/sbbs3/postmsg.cpp diff
    Resolve new(er) warnings comparing client_t.protocol with NULL client_t.protocol is no longer a pointer. Warnings reported by gcc (Debian 12.2.0-14) 12.2.0

  118. Rob Swindell (on Windows 11)
    Wed May 15 2024 19:11:55 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    Overhaul scfg.ini keys All keys are now in the root/global section and they are now: video_mode (default: 42) uifc_mode (default: 0) ciolib_mode (default: 0) scaling (default: 0) lines (default: 25) insert (default: false) esc_delay (default: 25)

  119. Rob Swindell (on Debian Linux)
    Wed May 15 2024 18:56:51 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/ciolib.c diff
    src/conio/ciolib.h diff
    src/sbbs3/scfg/scfg.c diff
    Eliminate unused ciolib vars: ciolib_initial_window_height and height These global variables weren't actually used for any purpose.

  120. Rob Swindell (on ChromeOS)
    Mon May 13 2024 22:43:51 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    Allow SCFG ciolib and uifc parameters to be read from ctrl/scfg.ini If a sysop wants to override the default user interface/console I/O library behavior of SCFG without using command-line arguments, they can create a ctrl/scfg.ini file with the following optional [section] keys: [uifc] mode (advanced uses, e.g. disabling mouse support) height (in lines) insert (keyboard insert mode, not overwrite) esc_delay (ESC-key delay) [ciolib] mode (advanced uses) scaling (fractional values, e.g. 1.5, supported) height (in pixels) width (in pixels) Command-line arguments take precedence over scfg.ini settings (if set). The scfg.ini file is read *before* parsing command-line args, so if a ctrl directory is specified on the command-line (e.g. rather than via environment variable), the scfg.ini file won't be read from that specified location but rather the default (/sbbs/ctrl) or the SBBSCTRL env var value. Another attempt to make Nelgin happy and close out issue #749, though no, this doesn't auto-save the current parameters (you'll have to create/edit the scfg.ini file by hand).

  121. Rob Swindell (on Debian Linux)
    Mon May 13 2024 18:11:17 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord/lord.js diff
    Fix apparent typo (vds array has length property, not length5) Fix issue #754

  122. Eric Oulashin
    Sat May 11 2024 19:11:25 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    SlyEdit: In SlyEdit_Misc.js, check to see that xtrn_area.editor[user.editor] is an object before using it. Should help with #755.

  123. Rob Swindell
    Mon May 13 2024 12:26:21 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    Merge branch 'slyedit_xtrn_area_editor_user_editor_check_first' into 'master' SlyEdit: In SlyEdit_Misc.js, check to see that xtrn_area.editor[user.editor] is an object before using it. Should help with #755. See merge request main/sbbs!436

  124. Rob Swindell (on Windows 11)
    Mon May 06 2024 16:21:42 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxfr2.c diff
    Skip files listed in imported DIRS.TXT/DIRS.WIN/00_INDEX.TXT files I'm not clear why Walnut Creek would list files (e.g. readme.txt) in these lists of "directories", but don't create file areas for them. Less clean-up required after import.

  125. Rob Swindell (on Debian Linux)
    Mon May 06 2024 11:59:32 GMT-0700 (PDT)
    Modified Files:
    

    exec/privatemsg.js diff
    Use the localizable Quit @-code

  126. Rob Swindell (on Debian Linux)
    Mon May 06 2024 12:44:00 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Use name as default address when creating new TCP dialing entry I usually use the hostname for the name of the dialing entry and got tired of always having to type the hostname twice when creating a new entry. If the name looks like a hostname or IP address (includes a dot but no spaces) and the connection type is appropriate, make the name the default string for the address (easily over-ridden if wrong, by just typing the correct address). This time-saving feature doesn't work for single-word hostnames (e.g. "localhost") or IPv6 addresses.

  127. Eric Oulashin
    Sun May 05 2024 01:35:00 GMT-0700 (PDT)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: Don't line-wrap poll messages for quoting. Also, minor fix for the 'to' name length in DCT mode.

  128. Rob Swindell
    Sun May 05 2024 01:35:00 GMT-0700 (PDT)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_poll_quoting_and_dct_to_name_fix' into 'master' SlyEdit: Don't line-wrap poll messages for quoting. Also, minor fix for the 'to' name length in DCT mode. See merge request main/sbbs!435

  129. Rob Swindell (on Windows 11)
    Sat May 04 2024 16:03:31 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/mqtt.c diff
    Fix CID 493283: Incorrect expression (NO_EFFECT) Comparing an array to null is not useful: "client->protocol == NULL", since the test will always evaluate as true. or will always evaluate as *false* (the array won't ever be NULL). <shrug>

  130. Rob Swindell (on Windows 11)
    Fri May 03 2024 19:37:34 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    Re-assign the dirnum and subnum fields after sorting dirs or subs The dirnum and subnum are used for the next/previous (left and right) arrow nav through sub-boards and directories. For message groups or file libs that are configured to auto-sort the sub-boards or directory list, when importing an unsorted list, the dirnum and subnum values would then be wrong after the qsort() at the end of the import thus making the left/right nav thing broken (jump to other groups/libs and such). This fixes that. Could I have fixed this by passing an index value to the next/prev_dirnum() and _subnum() functions and returning the next/previous index value instead of relying on the subnum/dirnum elemment to be correct? Maybe. <shrug> Do I like second guessing myself? Not really.

  131. Rob Swindell (on Windows 11)
    Fri May 03 2024 19:37:34 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxfr2.c diff
    Support dir/subdir syntax in DIRS.TXT (CD-ROM) import getfname() just returns the last path element, so can't use that here.

  132. Rob Swindell (on Debian Linux)
    Fri May 03 2024 17:25:12 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Fixup extract_diz() - fallback to external archivers The fallback to external extractors/archivers didn't really work unless a libarchive function (called from extract_files_from_archive) actually failed and the return value was < 0. A return value of 0 would mean the external file extractor would never be used. This was discovered when trying to import DIZ from old ZIP files (from 1992) that used "Implode" compression method for the FILE_ID.DIZ, which is a compression method *not* supported by libarchive. This is a reason why sysops might want to leave Info-zip's 'unzip' as a configured Extractable File Type handler (in SCFG) for 'zip' files. Don't call the external archiver 3 times for the 3 DIZ filenames supported. Just call the external archiver once, and pass all 3 filesnames. This also means that the call to system() can return non-zero (e.g. Info-zip 'unzip' will return 2 if any of the files aren't present in the archive, even if one is) - so ignore this return value from system(). This speeds up bulk import (e.g. using addfiles.js). Unfortunately, I couldn't really find a nice cross-platform way to suppress the unzip "caution: filename not matched" message sent to stderr. That's a bummer and a little annoying. Ignore 0-length DIZ files.

  133. Rob Swindell (on Windows 11)
    Fri May 03 2024 17:09:48 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/client.h diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/services.c diff
    src/sbbs3/userdat.c diff
    src/sbbs3/websrvr.c diff
    Change client_t.protocol from pointer to buffer Fix observed crash when shutting down services server where the client_t protocol was pointing to a freed service's protocol description string. This was the last pointer in client_t and should resolve the last race conditions (memory ownership issues) with its data members. This also resolves a small memory leak in getnodeclient() where the last client "gotten" would have its heap-duplicated protocol string leaked.

  134. echicken
    Thu May 02 2024 20:25:36 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ansiview/ansiview.js diff
    Don't get colors that already done got gotten. Fixes #752

  135. Rob Swindell (on Debian Linux)
    Tue Apr 30 2024 18:02:07 GMT-0700 (PDT)
    Modified Files:
    

    exec/addfiles.js diff
    Better support for CD-ROM filenaming (no dashes in ISO 9660 filenames!) Though the FILES.BBS might have filenames with dashes, the filenames actually have underscores. Consider converting any other valid DOS filename characters that are not allowed in ISO 9660 filenames as well (but to what?). More logging of missing and renamed files (e.g. fixed case, dashes replaced with underscores).

  136. Eric Oulashin
    Tue Apr 30 2024 12:53:11 GMT-0700 (PDT)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    SlyEdit quote line wrapping update: When re-wrapping quote lines, use the quote wrap settings from xtrn.ini, or default to 79 columns, as many terminals are 80 columns wide.

  137. Rob Swindell
    Tue Apr 30 2024 12:53:11 GMT-0700 (PDT)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    Merge branch 'slyedit_quote_wrap_update' into 'master' SlyEdit quote line wrapping update: When re-wrapping quote lines, use the quote wrap settings from xtrn.ini, or default to 79 columns, as many terminals are 80 columns wide. See merge request main/sbbs!434

  138. Rob Swindell (on Windows 11)
    Tue Apr 30 2024 10:58:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxfr2.c diff
    Fix issue in previous commit, caught by GCC warning, reported by Keyop lastchar() returns a char pointer, not a char. This fixes issue #751

  139. Rob Swindell (on Windows 11)
    Tue Apr 30 2024 00:23:13 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/str_util.c diff
    src/sbbs3/str_util.h diff
    Create replace_chars(), a wrapper for REPLACE_CHARS() The iteration variable (p) is created on the stack.

  140. Rob Swindell (on Windows 11)
    Tue Apr 30 2024 00:24:17 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxfr2.c diff
    Improvements to DIRS.TXT/DIRS.WIN import support Strip prepended and trailing slashes. Convert backslashes to forward slashes. When setting lib's parent path: - Auto-fix the sub-directory name case - Display error when setting lib parent to path that doesn't exist

  141. Rob Swindell (on Debian Linux)
    Mon Apr 29 2024 22:01:25 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Not every platform has GLOB_ONLYDIR support ... kind of as I suspected

  142. Rob Swindell (on Debian Linux)
    Mon Apr 29 2024 21:06:50 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    src/xpdev/dirwrap.h diff
    Add getdircase() - like fexistcase(), but for sub-directory names

  143. Rob Swindell (on Debian Linux)
    Mon Apr 29 2024 21:32:01 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxfr2.c diff
    Add option to import and export DIRS.TXT as found on CD-ROMs Walnut Creek and Simtel CD-ROMs usually have this file format which lists the sub-directories along with descriptions of each (one per line). Not to be confused with the DIRS.TXT format that has long been exported from and imported into SCFG.

  144. Rob Swindell (on ChromeOS)
    Sun Apr 28 2024 14:55:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/scfg/scfg.c diff
    Add -s option to set window scaling factor (e.g. 1.5 to set 50% bigger) This is an attempt to make Nelgin happy (issue #749) without writing/reading an additional settings file.

  145. Rob Swindell (on ChromeOS)
    Sun Apr 28 2024 13:43:41 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Fix typo in help text reported by Apam

  146. Rob Swindell (on Debian Linux)
    Sat Apr 27 2024 17:20:57 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/gtkuseredit/events.c diff
    src/sbbs3/uedit/uedit.c diff
    Remove WIP terminal support

  147. Rob Swindell (on Windows 11)
    Sat Apr 27 2024 17:19:00 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/useredit/MainFormUnit.cpp diff
    src/sbbs3/useredit/MainFormUnit.dfm diff
    Removed WIP terminal support

  148. Rob Swindell (on Windows 11)
    Sat Apr 27 2024 17:03:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/readmail.cpp diff
    Oops, another WIP reference here

  149. Rob Swindell (on Windows 11)
    Sat Apr 27 2024 16:52:38 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    Use bool type to eliminate MSVC warning

  150. Rob Swindell (on Windows 11)
    Sat Apr 27 2024 17:02:11 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ars.c diff
    src/sbbs3/bat_xfer.cpp diff
    src/sbbs3/chk_ar.cpp diff
    src/sbbs3/getkey.cpp diff
    src/sbbs3/newuser.cpp diff
    src/sbbs3/qwk.cpp diff
    src/sbbs3/readmsgs.cpp diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scansubs.cpp diff
    src/sbbs3/userdat.c diff
    src/sbbs3/useredit.cpp diff
    Remove support for deprecated WIP and HTML user settings WIPterm hasn't been supported in ages and HTMLterm was just an ephemeral experiment. Leave the WIP ARS keyword parsing support, for backwards script compatibilty.

  151. Rob Swindell (on Windows 11)
    Sat Apr 27 2024 17:03:13 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/build.bat diff
    Suppress the XP deprecation warning, as suggested by Yigael

  152. Rob Swindell (on Windows 11)
    Sat Apr 27 2024 16:29:26 GMT-0700 (PDT)
    Removed Files:
    

    exec/OVB-2.SRC diff
    OVB-2.SRC was renamed to obv-2.src, but Git didn't track that

  153. Rob Swindell (on Debian Linux)
    Sat Apr 27 2024 16:06:08 GMT-0700 (PDT)
    Modified Files:
    

    exec/default.js diff
    Enforce the default message read cmds: (A)uto-reply, (R)e-read The "RemoteAccess emulation" flag can be set by other shells, so be sure to clear it when using (e.g. switching back) to this shell.

  154. Rob Swindell (on Debian Linux)
    Sat Apr 27 2024 16:08:44 GMT-0700 (PDT)
    Modified Files:
    

    exec/sbbsimsg.js diff
    Remove the (D)ebug command

  155. Rob Swindell (on Debian Linux)
    Sat Apr 27 2024 16:10:45 GMT-0700 (PDT)
    Modified Files:
    

    exec/text_sec.js diff
    Multi-language support

  156. Rob Swindell (on Debian Linux)
    Fri Apr 26 2024 21:04:12 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.dat diff
    Use localizable @-code (words) and MNE @-code in mnemonic strings More support for multi-languages

  157. Rob Swindell (on Windows 11)
    Fri Apr 26 2024 19:15:15 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Fix MSVC compiler issues introduced in previous commit And use DWORD insteaad of 'unsigned long' where specified by Win32 API.

  158. Rob Swindell (on Debian Linux)
    Fri Apr 26 2024 17:24:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Fix GCC-aarch64 compile (caught be pipeline) error: cannot bind non-const lvalue reference of type ‘long unsigned int&’ to an rvalue of type ‘long unsigned int’ Just getting rid of more use of ulong (replaced with size_t).

  159. Rob Swindell (on Debian Linux)
    Fri Apr 26 2024 17:09:53 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Convert CP437 to UTF-8 (when necessary) for *nix stdio doors (e.g. DOSEMU) ... as requested by "ben" in #synchronet at irc.synchro.net Currently, this assumes all stdio doors aren't "UTF-8 native", which might be an incorrect assumption.

  160. Rob Swindell (on Debian Linux)
    Fri Apr 26 2024 09:27:04 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/telnet_io.c diff
    Fix CID 425333: update_binary_mode() is a function returning void

  161. Rob Swindell (on Debian Linux)
    Thu Apr 25 2024 23:05:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/getkey.cpp diff
    src/sbbs3/js_console.cpp diff
    src/sbbs3/load_cfg.c diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib2.c diff
    Add MNE:<low>[:high][:cmd] @-code for mnemonic string attribute control The "default" mnemonic string attributes are still set in ctrl/attr.cfg, but now, each mnemonic string (e.g. from text.dat or passed to JS console.mnemonics()) can include a "MNE:" @-code to over-ride the default mnemonic string attributes (low, high, and command). If the "high" attribute isn't specified, it defaults to the same color as the "low" attribute with the "high intensity" flag flipped. The "cmd" attribute defaults to whatever was included in the attr.cfg, if not specified. Technically, the separator between the attributes can be any non-valid attribute character (e.g. symbol). Renamed (really old function) attrstr() to strtoattr() since its usage now more closely resembles other std C strto* functions (has an 'endptr' arg).

  162. Eric Oulashin
    Thu Apr 25 2024 12:42:01 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    dd_lightbar_menu.js: Changed the older KEY_PAGE_UP to KEY_PAGEUP and KEY_PAGE_DOWN to KEY_PAGEDN, as defined in key_defs.js

  163. Rob Swindell
    Thu Apr 25 2024 12:55:39 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_pgup_pgdown_defs' into 'master' dd_lightbar_menu.js: Changed the older KEY_PAGE_UP to KEY_PAGEUP and KEY_PAGE_DOWN to KEY_PAGEDN, as defined in key_defs.js See merge request main/sbbs!433

  164. echicken
    Wed Apr 24 2024 15:00:10 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/openweathermap.js diff
    Check for stale cache in a way that works for 2.5 and 3.0.

  165. echicken
    Wed Apr 24 2024 11:49:07 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/openweathermap.js diff
    Whoopsiedoodle

  166. echicken
    Wed Apr 24 2024 10:09:46 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/openweathermap.js diff
    call_api_v3

  167. Rob Swindell (on Windows 11)
    Mon Apr 22 2024 23:57:00 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Fix apparent missing return statement in get_win_filename() Found by MSVC warning

  168. Rob Swindell (on Windows 11)
    Mon Apr 22 2024 23:57:53 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/filepick.c diff
    Fix strlcpy() not defined warning in Windows build

  169. Rob Swindell (on Windows 11)
    Tue Apr 23 2024 00:15:57 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/telnet_io.c diff
    Track Telnet Binary TX mode set by server via Telnet (IAC) commands As reported by Chris/akacastor (21:1/162), SyncTERM would always assume the Telnet session was in ASCII mode until/unless conn_binary_mode_on() was called which is only called at the beginning of a file transfer, which sets the conn_api.binary_mode accordingly. Unfortunately, if the Telnet server requested binary mode itself (e.g. during initial connection), SyncTERM would (try to) set the connection back to ASCII mode after any file transfer. :-( With this change, the conn_api.binary_mode will track the actual binary TX mode whether initiated locally or remotely (by the server), but it'll only be set to true when *both* directions are succesfully set to binary mode. And this way, if the connection was already in binary mode before any file transfer, it'll remain in binary mode as was apparently desired by the server. Also with this change, we could probably remove the setting of conn_api.binary_mode to true/false in conn_binary_mode_on()/off() functions, but it shouldn't hurt anything if it's left there I suppose (in case some *other* terminal transport protocols have the concept of binary mode?).

  170. Rob Swindell (on Windows 11)
    Mon Apr 22 2024 23:24:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Move swap version and platform in banner to accommodate 40 column display This should now display pretty normally on both 40 and 80 column displays. "FreeBSD" is 7 chars, so make that the max expected platform name (for now). Addresses issue #746, request from Nelgin

  171. Rob Swindell (on Windows 11)
    Mon Apr 22 2024 23:10:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    Don't allow sysops to page or send messages to nodes without a useron Fix a long standing bug where by sysops could page for chat or send node messages or telegrams to any node, even if there wasn't a user even connected. Regular users were not affected by this bug.

  172. Rob Swindell (on Debian Linux)
    Mon Apr 22 2024 21:56:54 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.dat diff
    Use mnemonics and @-codes for more auto-translated prompts Of particular interest is DoYouMeanThisUserQ since it wasn't a mnemonic string before. The string numbers for the last couple strings were wrong, corrected.

  173. Rob Swindell (on Debian Linux)
    Mon Apr 22 2024 21:58:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/data.cpp diff
    Using mnemonic with @-codes for DoYouMeanThisUserQ text.dat string

  174. Rob Swindell (on Windows 11)
    Mon Apr 22 2024 21:53:50 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Update the previous commit to revert the error_code length to 4, since we can And use sizeof, not the magic number (again).

  175. Rob Swindell (on Windows 11)
    Sun Apr 21 2024 21:40:42 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Fix bug with error files (e.g. 404.html) introduced in commit 90de10cf Deuce expanded the local 'error_code' buf to not trip the SAFECOPY macro destionation buffer length check. Only this buffer needed to be 4 chars exactly to truncate the 'message' string at 3 chars (e.g. just "404" for an error message string that starts with "404 "). Switch from SAFECOPY to strlcpy to eliminate this bug. As reported by Ragnarok as part of issue #748 The web error files should work again.

  176. Rob Swindell (on Windows 11)
    Tue Apr 16 2024 11:31:06 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/fidodefs.h diff
    src/sbbs3/scfgdefs.h diff
    Increase FidoNet echo/area tag max length from 40/50 to 60 chars Update to commit 85a2de04e9ca82 (2 years ago). FSC-74 specifies: "The conference name shall be no more than 60 characters in length." SCFG was limiting sub and dir area-tags to 40 chars and SBBSecho was limiting area tags to 50 chars in length. FSC-74 isn't a standard, but lacking this detail in FTS-4 and considering it comes from the same authoritative source (the Conference Mail System User Manual), I think it's the best source of truth we have. Also, since we're no longer using .cnf files, we don't need different max area-tag lengths between SBBSecho and SCFG structs - they all now use the same macro: FIDO_AREATAG_LEN

  177. Rob Swindell (on Debian Linux)
    Mon Apr 15 2024 12:00:59 GMT-0700 (PDT)
    Modified Files:
    

    exec/sbbslist.js diff
    Some old stil (SBL) messages might include 'address' before 'network'? Attempt to address error reported by Manitoo in IRC: JavaScript sbbslist.js line 327: TypeError: bbs.network[network] is undefined Normally, the "address:" key would always follow a "network:" key, but maybe there's a corrupted message or the sysop is trying to import from the wrong message base (not syncdata?).

  178. Rob Swindell (on Debian Linux)
    Sun Apr 14 2024 20:56:31 GMT-0700 (PDT)
    Modified Files:
    

    src/syncdraw/load.c diff
    Fix potential buffer overflow some long ANSI sequences Increase ansicode[] buffer size from 20 to 200 bytes due to this observed crash when attempting to load an ANS file saved from PabloDraw:

  179. Rob Swindell (on Debian Linux)
    Sun Apr 14 2024 15:13:08 GMT-0700 (PDT)
    Added Files:
    

    exec/OVB-2.SRC diff
    Xsword's Oblivion/2 Clone Command Shell from 1994 Although the FILE_ID.DIZ suggests this is a clone of Oblvivion/2 v2.55, the latest Oblivion/2 appears to be v2.40. This shell source (in Baja) is a 99% copy of Yojimbo's (The Dojo BBS) Vision-2 shell source code from earlier in 1994. The menu/display files need a little work, so they'll be committed separately. I mainly wanted to commit this and then record the history of modifications necessary to "modernize" the shell and at least get it compiling and useful with recent versions of Synchronet BBS for Win32 and *nix and as demonstrated at https://youtu.be/HlwQ0uX4S04

  180. Rob Swindell (on Debian Linux)
    Sun Apr 14 2024 15:29:07 GMT-0700 (PDT)
    Added Files:
    

    exec/obv-2.src diff
    Renamed OVB-2.SRC to obv-2.src Lowercased and using the proper abbreviaton of "Oblivion/2".

  181. Rob Swindell (on Debian Linux)
    Sun Apr 14 2024 16:27:04 GMT-0700 (PDT)
    Added Files:
    

    text/menu/obv-2/email.msg diff
    text/menu/obv-2/files.msg diff
    text/menu/obv-2/main.msg diff
    text/menu/obv-2/message.msg diff
    text/menu/obv-2/quick.msg diff
    text/menu/obv-2/qwk.msg diff
    OBV/2 menu files (converted from .ANS to .msg using PabloDraw) Added a CLEAR @-code to the top of qwk.msg

  182. Rob Swindell (on Debian Linux)
    Sun Apr 14 2024 16:28:48 GMT-0700 (PDT)
    Modified Files:
    

    exec/obv-2.src diff
    Modernized Oblivion/2 Clone shell Updated for Baja v2+ compatibility. Updated for UNIX file system compatibilty. Fix cosmetic, cross-platform, and other general "wrongness".

  183. Rob Swindell (on Debian Linux)
    Tue Apr 09 2024 18:02:58 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Resolve CID 492287 - we don't care about the fexistcase() return value here We're just using it to "fix" the case, if the file indeed exists.

  184. Rob Swindell (on Debian Linux)
    Tue Apr 09 2024 18:02:58 GMT-0700 (PDT)
    Modified Files:
    

    exec/default.js diff
    The kludge of reverting the Pause prompt string is no longer needed ... when using user_settings.js (i.e. to switch command shells), the user's text.<lang>.ini is re-loaded, thus reverting any changes (e.g. made when loading another shell, like simple.bin). Also, this was causing the translated Pause strings (from text.<lang>.ini) to be lost.

  185. Rob Swindell (on Debian Linux)
    Wed Apr 10 2024 23:05:25 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    When server_binary option is set, request remote BINARY_TX option As reported by Fzf (FQBBS): It addresses the local configuration but unfortunately it still doesn't set remote options. The remote is usually going to be in binary mode but SVDM has the remote option set to ASCII by default. A CR from the remote then gets held up until a second byte is sent. Also suggested by Fzf, when server_binary mode is not configured, then advertise and request binary mode is/be disabled, explicitly.

  186. Rob Swindell (on Windows 11)
    Tue Apr 09 2024 18:02:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    src/sbbs3/sbbs.h diff
    Reduce the Terminal Server thread outcom timeout from 80 seconds to 800 ms Since the Terminal Server is a single thread, let's not block for long periods of time trying to send bytes to a client (e.g. send the badip.msg file contents to a client with a blocked IP address), effectively DoSing the terminal server. This should address the problem reported via IRC: <theviper4> │Apr 9 15:38:11 viper-bbs synchronet: term Terminal Server timeout(outcom) 0000 0000 <theviper4> │Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 110 sending on socket 39 <theviper4> │Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39 <theviper4> │Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39 <theviper4> │Apr 9 15:38:36 viper-bbs synchronet: term 0039 Telnet !CLIENT BLOCKED in ip.can: 117.95.153.33 Also, make the outcom timeout error message more helpful (e.g. include the sock descriptor of the client) and don't use the old rioctl() function here any more.

  187. Rob Swindell (on Windows 11)
    Tue Apr 09 2024 18:02:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/str.cpp diff
    Create/use sbbs_t::flush_output(timeout) If client socket is connected, wait up to the specified timeout period (in ms) for the output buffer to be emptied. This is much preferred over blindly calling mswait() after sending some data (e.g. a file) and possibly waiting much longer than necessary.

  188. Eric Oulashin
    Tue Apr 09 2024 12:50:41 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DDFileLister Fix: Searching by file date as a loadable module now does the new file search

  189. Rob Swindell
    Tue Apr 09 2024 13:37:02 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_new_file_search_as_loadable_module' into 'master' DDFileLister Fix: Searching by file date as a loadable module now does the new file search See merge request main/sbbs!432

  190. Rob Swindell (on ChromeOS)
    Mon Apr 08 2024 20:23:41 GMT-0700 (PDT)
    Modified Files:
    

    exec/addfiles.js diff
    Remove extra closing-parens pointed out by Apam Oops

  191. Rob Swindell (on Windows 11)
    Mon Apr 08 2024 11:46:01 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    exec/*.bin cmd shell filenames were case sensitive (must've been lowercase) ... while the mods/*.bin command shell filenames could be any-case! Only impacted non-Windows systems (UNIX file systems are case-sensitive). Discovered while making this tutorial video: https://youtu.be/HlwQ0uX4S04

  192. Rob Swindell (on Windows 11)
    Mon Apr 08 2024 11:49:03 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_system.c diff
    Address MSVC warning and CID 492209 with typecast of time_t to uint32_t yes, this is a Y2K38 (or Y2106) issue, but we should have that worked out when upgrading to the next libmozjs. Need something like NUMBER_TO_JSVAL() and equivalent LAZY_NUMBER macro that can deal with >32-bit ints correctly (or just always convert to double?).

  193. Rob Swindell (on Debian Linux)
    Sat Apr 06 2024 19:02:05 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/text.js diff
    3 new text string IDs defined

  194. Rob Swindell (on Debian Linux)
    Fri Apr 05 2024 22:40:22 GMT-0700 (PDT)
    Modified Files:
    

    src/build/gitinfo.bat diff
    src/sbbs3/js_system.c diff
    src/sbbs3/targets.mk diff
    src/sbbs3/ver.cpp diff
    src/sbbs3/ver.h diff
    Introduce system.git_time This is the time_t (seconds since Unix epoch, Jan-1-1970 UTC) date/time of the current (most recent) Git commit used to build the running binary. If a JS developer wants to check if a build is recent-enough to include some change, this is the property they should use to check (with >= comparison).

  195. Rob Swindell (on Debian Linux)
    Fri Apr 05 2024 21:19:14 GMT-0700 (PDT)
    Modified Files:
    

    exec/cleanup.js diff
    Add support for -v (verbose) option Displays messages about non-existing files when in verbose mode

  196. Rob Swindell (on Debian Linux)
    Fri Apr 05 2024 20:47:02 GMT-0700 (PDT)
    Modified Files:
    

    exec/cleanup.js diff
    Clean up the old filebase data files from all the configured data_dir's De-duplicate the data_dirs first (most sysops use a single data dir for all file directories). Also, don't print non-existing old files when run with -q (quiet) option.

  197. Rob Swindell (on ChromeOS)
    Fri Apr 05 2024 19:01:50 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/msgtoqwk.cpp diff
    Remove redundant re-determination of UTF-8 encoded and exported messages

  198. Rob Swindell (on Windows 11)
    Fri Apr 05 2024 17:40:44 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/exec.cpp diff
    Save/restore js.scope property value in sbbs_t::js_execfile() This solves the problem of exit() values (e.g. non-zero return codes) not getting propagated to callers when nest-called (e.g. via bbs.exec()). I think it was kk4qbn that pointed this out via IRC: an exit(1) call from prextrn.js did not stop the external program from running (as it should, for any non-zero exit code). This only happened when the prextrn.js called another JS script (e.g. via bbs.exec() or as was the case here, indirectly via "EXEC" @-code in the YesNoBar text.dat string (which executed yesnobar.js). This nested JS script invocation via sbbs_t::js_execfile() would clobber the stored js.scope property value (where the "exit_code" property is written). Script invoked in their own context (e.g. via js.exec()) wouldn't have this issue in the first place.

  199. Rob Swindell
    Fri Apr 05 2024 17:40:10 GMT-0700 (PDT)
    Modified Files:
    

    BUILDING.md diff
    First pass at making a useful top-level build doc. A lot of content from the wiki should likely be moved here.

  200. Rob Swindell
    Fri Apr 05 2024 15:34:59 GMT-0700 (PDT)
    Added Files:
    

    BUILDING.md diff
    Build instructions should stored in the repo along with the source, so that archives of the source include the current (at the time) build instructions

  201. Rob Swindell (on Debian Linux)
    Thu Apr 04 2024 18:00:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/qwktomsg.cpp diff
    Default FTN charset to CP437 (not ASCII) for QWK-imported messages A QWKnet tagline usually contains CP437 character 254 and if/when appended to a message during export, would "convert" the message to CP437 thus making the "ASCII" charset advertisement incorrect. If a FIDO CHARSET value was already specified (e.g. in HEADERS.DAT), that value will (still) not be overridden. So the *original* import via QWK (before it gets exported to a QWKnet) is where this change will take effect. Fix for issue #741

  202. Rob Swindell (on Debian Linux)
    Wed Apr 03 2024 23:07:35 GMT-0700 (PDT)
    Added Files:
    

    exec/cleanup.js diff
    New script to clean-up (delete) obsolete/unnecessary files from < v3.20 SBBS At Keyop's request This script does not (yet anyway): - clean-up any obsoleted/renamed files in the text directories - clean-up old filebase files that are not stored in the default (data/dirs)

  203. Rob Swindell (on Debian Linux)
    Wed Apr 03 2024 22:51:04 GMT-0700 (PDT)
    Modified Files:
    

    exec/webfileindex.ssjs diff
    When file size is less than 1 byte in length, don't list 0-byte or non-existent files can't be http-downloaded anyway

  204. Rob Swindell (on Debian Linux)
    Wed Apr 03 2024 22:52:08 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/file_size.js diff
    Display file sizes as signed values, so -1 (non-existent file) is clear

  205. Rob Swindell (on Windows 11)
    Tue Apr 02 2024 17:19:22 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/main.ini diff
    Fix accidental change of new_install to 'false' new_install needs to be 'true' to auto-run the config wizard

  206. Eric Oulashin
    Sun Mar 31 2024 14:30:57 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Fix for checkmark refresh when selecting all/none in the message list

  207. Rob Swindell
    Sun Mar 31 2024 23:24:01 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_list_select_all_or_none_checkbox_refresh_fix' into 'master' DDMsgReader: Fix for checkmark refresh when selecting all/none in the message list See merge request main/sbbs!431

  208. Deucе
    Sun Mar 31 2024 00:00:03 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/GNUmakefile diff
    src/syncterm/syncterm.c diff
    Removed Files:

    src/syncterm/extdeps.mk diff
    Fix WITHOUT_CRYPTLIB build

  209. Deucе
    Sun Mar 31 2024 12:12:51 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/term.c diff
    Attempt to silence silly Coverity warning.

  210. Rob Swindell (on ChromeOS)
    Sat Mar 30 2024 14:20:18 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/cgi_env.ini diff
    ctrl/fonts.ini diff
    ctrl/letsyncrypt.ini diff
    ctrl/listserver.ini diff
    ctrl/main.ini diff
    ctrl/mime_types.ini diff
    ctrl/msgs.ini diff
    ctrl/rss.ini diff
    ctrl/sbbs.ini diff
    ctrl/services.ini diff
    ctrl/sockopts.ini diff
    ctrl/web_handler.ini diff
    Remove CVS keywords from (not all) .ini files

  211. Rob Swindell (on ChromeOS)
    Sat Mar 30 2024 15:26:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/exec.cpp diff
    Save and restore the js.exec_path, exec_dir, and exec_file properties When invoking a nested JS script, these properties of the "js" object would be overwritten and not restored, as discovered/reported by Nightfox when his trivial game script would indirectly execute yesnobar.js, his subsequent use of js.exec_dir would point to the wrong location (the "exec" directory, parent of yesnobar.js, and not the direcctory where his game script was located). The exec_path and exec_file properties had the same problem as demonstrated by a simple test.js placed in (and executed from) a directory other than the "exec" dir: function f() { print("js.exec_path = " + js.exec_path); print("js.exec_dir = " + js.exec_dir); print("Js.exec_file = " + js.exec_file); } f(); console.yesno("test"); f(); This would only trigger the problem when executed from the BBS and whebn the YesNoQuestion text.dat string invokes the "yesnobar" module via EXEC @-code and yesnobar.js exists (in exec or mods dir), superceding yesnobar.bin which does not trigger this issue (not a JavaScript mod).

  212. Eric Oulashin
    Sat Mar 30 2024 10:15:43 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Good Time Trivia: Make a copy of js.exec_dir on startup and use the copy, since js.exec_dir could change indirectly (i.e., console.yesno() running yesnobar.js in sbbs/exec)

  213. Rob Swindell
    Sat Mar 30 2024 10:15:43 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Merge branch 'gttrivia_js_exec_dir_change_workaround' into 'master' Good Time Trivia: Make a copy of js.exec_dir on startup and use the copy, since js.exec_dir could change indirectly (i.e., console.yesno() running yesnobar.js in sbbs/exec) See merge request main/sbbs!430

  214. Deucе
    Sat Mar 30 2024 09:59:35 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    src/sbbs3/sftp.cpp diff
    Unconditionally call sftp_end() when input thread exits. Hopefully fixes issue where certificate file is left open and so can't be deleted.

  215. Rob Swindell (on Windows 11)
    Thu Mar 28 2024 22:54:13 GMT-0700 (PDT)
    Modified Files:
    

    install/install.iss diff
    Updated for v3.20b Renamed output file setup.exe to install_SBBS_v*.exe because InnoSetup Warning: Setting the [Setup] section "OutputBaseFileName" to "setup" is not recommended, all executables named "setup.exe" are shimmed by Windows application compatibility to load additional DLLs, such as version.dll. These DLLs are loaded unsafely by Windows and can be hijacked. Use a different name, for example "mysetup".

  216. Rob Swindell (on Windows 11)
    Thu Mar 28 2024 22:55:51 GMT-0700 (PDT)
    Modified Files:
    

    docs/v320_new.txt diff
    New time.ini and (a few more) text.dat strings in v3.20 documented

  217. Rob Swindell (on Windows 11)
    Thu Mar 28 2024 22:56:39 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/text_defaults.c diff
    Corrected string numbers

  218. Rob Swindell (on Windows 11)
    Thu Mar 28 2024 22:57:01 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/AboutBoxFormUnit.cpp diff
    Display Git commit date/time, not build date/time

  219. Deucе
    Thu Mar 28 2024 06:45:54 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/cterm.txt diff
    When ANSI Music is enabled, CSI M with parameters is still delete line

  220. Deucе
    Thu Mar 28 2024 06:45:54 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    Whoops, forgot to add the rest of the entry options.

  221. Deucе
    Thu Mar 28 2024 06:08:46 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Update help for connected BBS list editing.

  222. Deucе
    Thu Mar 28 2024 06:09:02 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    Finish documenting the rest of the Directory list features. Only two major chunks left... settings and connected mode!

  223. Deucе
    Thu Mar 28 2024 06:27:03 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Fix help text.

  224. Deucе
    Thu Mar 28 2024 06:27:57 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/cterm.c diff
    When ANSI Music is enabled, CSI M with parameters is still delete line

  225. Eric Oulashin
    Tue Mar 26 2024 19:02:07 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Good Time Trivia: Formatting fix for sysop menu when the server scores file is missing. Allow showing help when playing a game by entering ?

  226. Rob Swindell
    Tue Mar 26 2024 19:46:12 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Merge branch 'good_time_trivia_sysop_screen_fix_and_help_during_play' into 'master' Good Time Trivia: Formatting fix for sysop menu when the server scores file is missing. Allow showing help when playing a game by entering ? See merge request main/sbbs!429

  227. Rob Swindell (on Windows 11)
    Mon Mar 25 2024 16:29:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Initialize telnet options when passed -h option (withouth -l) As requested by Fzf (FQBBS): When SVDM uses an inherited socket (the -h option) no telnet negotiations are done. As a result, the connection is assumed to be in ASCII mode and server side CR characters are translated to CR/LF. Since most programs are already transmitting a CR/LF this gets translated to CR/LF/LF with the expected results. When using an external socket in telnet mode, could SVDM set the telnet.local_option and telnet.remote_option variables as so: A. Assume both remote and local have already suppressed GA and set the two options accordingly B. Set the remote telnet echo option to off and set the local telnet echo to follow the ServerEcho option from the .INI file C. Set both remote and local BINARY_TX options to follow the ServerBinary option from the .INI file

  228. Rob Swindell (on Windows 11)
    Mon Mar 25 2024 16:29:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Add 2 new .ini settings: MainLoopDelay and SocketSelectTimeout (default: 0) - MainLoopDelay - in milliseconds Set this to a non-zero value to add some CPU yielding to the main loop - SocketSelectTimeout - in milliseconds Set this to a non-zero value to add some CPU yielding while waiting for receive data from the TCP socket These are 2 knobs created for Fzf (FQBBS) to "to reduce the CPU usage". Their default values are currently 0, so you'll need to set these to non-zero values to play with each of them and see their inpact on CPU utilization and responsiveness. I'd suggest starting with low values (e.g. 1) and experimeting from there. Incremented version to 0.5

  229. Rob Swindell (on Windows 11)
    Mon Mar 25 2024 16:29:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.vcxproj diff
    Build release Win32 binaries without SSE exentions for more CPU compatibility

  230. Deucе
    Sun Mar 24 2024 23:24:05 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Hopefully the cache got deleted by that last build and we can re-enable.

  231. Deucе
    Sun Mar 24 2024 23:13:06 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Temporarily disable the js configure cache. The last commit changed the environment, so we need to regenerate the config cache.

  232. Deucе
    Sun Mar 24 2024 23:07:19 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Use cc, not gcc for --build detection

  233. Deucе
    Sun Mar 24 2024 23:07:19 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/js-support-mingw-cross.patch diff
    3rdp/win32.release/nspr/include/nspr/md/_aix32.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_aix64.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_bsdi.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_darwin.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_freebsd.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_hpux32.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_hpux64.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_linux.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_netbsd.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_nto.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_openbsd.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_os2.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_qnx.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_riscos.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_scoos.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_solaris.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_unixware.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_unixware7.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_win95.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_winnt.cfg diff
    3rdp/win32.release/nspr/include/nspr/nspr.h diff
    3rdp/win32.release/nspr/include/nspr/obsolete/pralarm.h diff
    3rdp/win32.release/nspr/include/nspr/obsolete/probslet.h diff
    3rdp/win32.release/nspr/include/nspr/obsolete/protypes.h diff
    3rdp/win32.release/nspr/include/nspr/obsolete/prsem.h diff
    3rdp/win32.release/nspr/include/nspr/plarena.h diff
    3rdp/win32.release/nspr/include/nspr/plarenas.h diff
    3rdp/win32.release/nspr/include/nspr/plbase64.h diff
    3rdp/win32.release/nspr/include/nspr/plerror.h diff
    3rdp/win32.release/nspr/include/nspr/plgetopt.h diff
    3rdp/win32.release/nspr/include/nspr/plhash.h diff
    3rdp/win32.release/nspr/include/nspr/plstr.h diff
    3rdp/win32.release/nspr/include/nspr/pratom.h diff
    3rdp/win32.release/nspr/include/nspr/prbit.h diff
    3rdp/win32.release/nspr/include/nspr/prclist.h diff
    3rdp/win32.release/nspr/include/nspr/prcmon.h diff
    3rdp/win32.release/nspr/include/nspr/prcountr.h diff
    3rdp/win32.release/nspr/include/nspr/prcpucfg.h diff
    3rdp/win32.release/nspr/include/nspr/prcvar.h diff
    3rdp/win32.release/nspr/include/nspr/prdtoa.h diff
    3rdp/win32.release/nspr/include/nspr/prenv.h diff
    3rdp/win32.release/nspr/include/nspr/prerr.h diff
    3rdp/win32.release/nspr/include/nspr/prerror.h diff
    3rdp/win32.release/nspr/include/nspr/prinet.h diff
    3rdp/win32.release/nspr/include/nspr/prinit.h diff
    3rdp/win32.release/nspr/include/nspr/prinrval.h diff
    3rdp/win32.release/nspr/include/nspr/prio.h diff
    3rdp/win32.release/nspr/include/nspr/pripcsem.h diff
    3rdp/win32.release/nspr/include/nspr/private/pprio.h diff
    3rdp/win32.release/nspr/include/nspr/private/pprthred.h diff
    3rdp/win32.release/nspr/include/nspr/private/prpriv.h diff
    3rdp/win32.release/nspr/include/nspr/prlink.h diff
    3rdp/win32.release/nspr/include/nspr/prlock.h diff
    3rdp/win32.release/nspr/include/nspr/prlog.h diff
    3rdp/win32.release/nspr/include/nspr/prlong.h diff
    3rdp/win32.release/nspr/include/nspr/prmem.h diff
    3rdp/win32.release/nspr/include/nspr/prmon.h diff
    3rdp/win32.release/nspr/include/nspr/prmwait.h diff
    3rdp/win32.release/nspr/include/nspr/prnetdb.h diff
    3rdp/win32.release/nspr/include/nspr/prolock.h diff
    3rdp/win32.release/nspr/include/nspr/prpdce.h diff
    3rdp/win32.release/nspr/include/nspr/prprf.h diff
    3rdp/win32.release/nspr/include/nspr/prproces.h diff
    3rdp/win32.release/nspr/include/nspr/prrng.h diff
    3rdp/win32.release/nspr/include/nspr/prrwlock.h diff
    3rdp/win32.release/nspr/include/nspr/prshm.h diff
    3rdp/win32.release/nspr/include/nspr/prshma.h diff
    3rdp/win32.release/nspr/include/nspr/prsystem.h diff
    3rdp/win32.release/nspr/include/nspr/prthread.h diff
    3rdp/win32.release/nspr/include/nspr/prtime.h diff
    3rdp/win32.release/nspr/include/nspr/prtpool.h diff
    3rdp/win32.release/nspr/include/nspr/prtrace.h diff
    3rdp/win32.release/nspr/include/nspr/prtypes.h diff
    3rdp/win32.release/nspr/include/nspr/prvrsion.h diff
    3rdp/win32.release/nspr/include/nspr/prwin16.h diff
    3rdp/win32.release/nspr/lib/libnspr4.a diff
    3rdp/win32.release/nspr/lib/libnspr4_s.a diff
    3rdp/win32.release/nspr/lib/libplc4.a diff
    3rdp/win32.release/nspr/lib/libplc4_s.a diff
    3rdp/win32.release/nspr/lib/libplds4.a diff
    3rdp/win32.release/nspr/lib/libplds4_s.a diff
    3rdp/win32.release/nspr/lib/nspr4.dll diff
    3rdp/win32.release/nspr/lib/plc4.dll diff
    3rdp/win32.release/nspr/lib/plds4.dll diff
    3rdp/win64.release/nspr/lib/libnspr4.a diff
    3rdp/win64.release/nspr/lib/libnspr4_s.a diff
    3rdp/win64.release/nspr/lib/libplc4.a diff
    3rdp/win64.release/nspr/lib/libplc4_s.a diff
    3rdp/win64.release/nspr/lib/libplds4.a diff
    3rdp/win64.release/nspr/lib/libplds4_s.a diff
    3rdp/win64.release/nspr/lib/nspr4.dll diff
    3rdp/win64.release/nspr/lib/plc4.dll diff
    3rdp/win64.release/nspr/lib/plds4.dll diff
    Modified Files:

    3rdp/build/Common.gmake diff
    3rdp/build/GNUmakefile diff
    3rdp/build/js-disable-shell.patch diff
    src/build/Common.gmake diff
    src/sbbs3/sbbs.h diff
    Initial work on cross-building sbbs with mingw The big remaining issue is defining *_EXPORTS where needed, which looks rough from a quick glance.

  234. Rob Swindell (on ChromeOS)
    Sun Mar 24 2024 18:51:34 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    src/sbbs3/scfg/scfgnode.c diff
    Remove the "7-bit only" node option The way this option worked was, if enabled (and it was off by default), bit 7 of all character input *before* successful logon would be stripped and bit 7 from all character input of terminals configured as US-ASCII (only) would be stripped after logon. Instead, always strip bit 7 (the 8th bit) of each input character from US-ASCII (only) terminals. Other detected/configured terminals (CP437, UTF-8, PETSCII) won't have bit 7 stripped (ever) since that's likely not a necessary or nice thing to do. There's now no different handling of pre/post logon in this regard. If there's a need to strip parity bits from character input from client terminals that support CP437, UTF-8, or PETSCII, then we'll re-add this feature in but it shouldn't be a per-node setting in that case.

  235. Rob Swindell (on ChromeOS)
    Sun Mar 24 2024 19:26:00 GMT-0700 (PDT)
    Modified Files:
    

    exec/upgrade_to_v320.js diff
    src/sbbs3/getkey.cpp diff
    src/sbbs3/scfg/scfgnode.c diff
    src/sbbs3/scfg/scfgsys.c diff
    src/sbbs3/scfgdefs.h diff
    src/sbbs3/scfglib1.c diff
    src/sbbs3/scfgsave.c diff
    Move "spinning cursor at pause prompt" from node to system config From SCFG->Nodes ... Toggle Options to SCFG->System->Toggle Options And from a bit flag in node_misc to its own bool member of scfg_t.

  236. Rob Swindell (on ChromeOS)
    Sun Mar 24 2024 19:35:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgnode.c diff
    Simplify the node config menu, eliminating Toggles/Advanced Options menus There's only one toggle left (Leave node file open) and not very many advanced options. Unfortuantely, can't easily do the cool left-right cycle through nodes since each node file has to be saved/loaded, but still, easier to visualize any differences between node configs with all the settings on one menu.

  237. Rob Swindell (on Windows 11)
    Sun Mar 24 2024 17:58:20 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Remove obsolete note comment about genwrap.h

  238. Deucе
    Sun Mar 24 2024 16:53:01 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Removed Files:

    3rdp/build/js-always-define-spew.patch diff
    The problem with Bullseye was the 64-bit kernel. The configure script was using uname -m as the build platform, but Bullseye on RPi uses a 64-bit kernel (aarch64 uname -m) with a 32-bit userland (arm gcc build host), which resulted in a lot of bad decsions around JIT stuff. With this change, we explicitly pass the build/host/target values as taken from the compilers in question, which fixes the issue for Bullseye (But may break mingw32? Well we'll see how the pipes go).

  239. Deucе
    Sun Mar 24 2024 15:44:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Grow another 4-byte string.

  240. Deucе
    Sun Mar 24 2024 15:41:11 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_file.c diff
    Increase size of file mode string so it's not 4 bytes. 4-bytes is how bit a 32-bit pointer is.

  241. Deucе
    Sun Mar 24 2024 15:17:47 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/js-always-define-spew.patch diff
    3rdp/build/js-config.guess-libffi.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    Add a couple more patches that appear to enable libmozjs on Raspian This works on Buster at least... update the other config.guess file the same as the top-level one, and always define JaegerSpew() so the JIT stuff isn't broken.

  242. Rob Swindell (on Windows 11)
    Sun Mar 24 2024 01:48:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/AboutBoxFormUnit.dfm diff
    Increment copyright year from 2022 to 2024

  243. Rob Swindell (on Windows 11)
    Sun Mar 24 2024 01:48:48 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/sbbsctrl.bpr diff
    Increment copyright year to 2024

  244. Rob Swindell (on Debian Linux)
    Sun Mar 24 2024 01:45:00 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsdefs.h diff
    Increment copyright year from 2022 to 2024 Yeah, it's getting about that time...

  245. Rob Swindell (on Debian Linux)
    Sat Mar 23 2024 22:03:36 GMT-0700 (PDT)
    Modified Files:
    

    exec/addfiles.js diff
    Auto-detect/correct filename case from file lists Addresses issue reported by Dumas Walker (CAPCITY2) and kk4qbn (KK4QBN) whereby the list contains filenames in the wrong case.

  246. Deucе
    Sat Mar 23 2024 21:24:14 GMT-0700 (PDT)
    Added Files:
    

    exec/load/syncterm_cache.js diff
    Simple untested script to upload a file to the SyncTERM cache. As I said, untested.

  247. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 17:15:43 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    Fix CID 33725: Use after close

  248. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 17:19:00 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/readsauce.c diff
    Fix CID 174408 Unchecked return value from library (fseek)

  249. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 17:12:59 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Fix typo in previous commit to this file

  250. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:18:28 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/uedit/uedit.c diff
    More save string copy operations using strlcpy and SAFECOPY Resoles (at least) CID 488305

  251. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:21:43 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/datewrap.c diff
    Fix CID 487672: Dereference null return value gmtime_r() can return NULL

  252. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:32:50 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Use volatile keyword to (maybe) fix CID 488122: Data race condition Ideally, I'd use atomic_bool instead, but we're using an older WinSDK for Win7 compatibility and so... can't. Perhaps an xpdev 'protected_bool_t' should be created.

  253. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:47:28 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/logout.cpp diff
    src/sbbs3/sbbs.h diff
    Add/use sbbs_t::fremove() to remove files with logged error on failure This should resolve CID 487088: Unchecked return value from library as well as add some more instrumentation upon unexpected failures removing files. Consider: do some callers of this function need to know the success status (return bool)? That then starts to get into the some callers check and some don't situation (Coverity issue). For now, this is a void function. Also, all remove failures are logged as errors. Consider possibly passing a log level and calling lprintf() instead of errormsg(). errormsg() displays a notice to the user, which maybe we don't want.

  254. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:57:04 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_bbs.cpp diff
    Fix CID 486181: Resource leak (RESOURCE_LEAK) A couple of error paths in expand_atcodes() method could leak heap memory.

  255. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 17:05:09 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    Fix CID 479078: Resource leak (RESOURCE_LEAK) Passing an unparseable integer to console.editfile() could leak heap memory

  256. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 15:42:29 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Insure buf is null-terminated in getzpt(), resoving CID 488308

  257. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:07:54 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sauce.c diff
    SAFECOPY (now using strlcpy) requires the source is terminated ... so use strncpy() and TERMINATE() here (instead of SAFECOPY) to resolve newly reported Coverity issues. There may be other places where we're using SAFECOPY() with an unterminated source string that would've been fine before we switched SAFECOPY from using strncpy to strlcpy. So we should reconsider that change.

  258. Deucе
    Sat Mar 23 2024 10:57:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/syncterm-bounce.js diff
    Re-format b64 encoded images strings so you can see the code. The ppm (image) of course is 24bpp, and the pbm (mask) is 1bpp, so the line lengths are different.

  259. Rob Swindell (on Debian Linux)
    Sat Mar 23 2024 01:34:39 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ars_defs.h diff
    Comment header clean-up (to re-trigger pipeline) No functional change

  260. Rob Swindell (on Debian Linux)
    Sat Mar 23 2024 01:26:01 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ident.h diff
    Non-functional change (header cleanup) to trigger pipeline

  261. Rob Swindell (on Debian Linux)
    Sat Mar 23 2024 01:08:59 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Enable ccache in Linux builds

  262. Deucе
    Sat Mar 23 2024 00:19:15 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Put EXTRA_FILENAME in the filename

  263. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 00:09:55 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Change spaces to tabs in new strlcpy()

  264. Deucе
    Sat Mar 23 2024 00:05:25 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Attempt to fix corruption issue on FreeBSD. Both sbbs-noskeeters and sbbs-build create sbbs-build.tgz Hopefully this fixes it and doesn't just break it worser.

  265. Deucе
    Fri Mar 22 2024 23:43:21 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/x_cio.c diff
    include genwrap for strlcpy()

  266. Deucе
    Fri Mar 22 2024 23:34:07 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/x_cio.c diff
    src/xpdev/gen_defs.h diff
    Use use strlcpy() in x_cio.c without the wrapper. Reverts gen_defs/genwrap craziness.

  267. Deucе
    Fri Mar 22 2024 23:10:52 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    include genwrap.h at the end of gen_defs.h for strlcpy()/strlcat(). This whole library is starting to get crufty and could use a room at a hackathon.

  268. Deucе
    Fri Mar 22 2024 23:02:40 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    After creating the file in /tmp/gitlab-runner, make it read-only. This should hopefully surface whatever is corrupting the file.

  269. Deucе
    Fri Mar 22 2024 22:51:10 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Oh yeah, can't use wildcards since it's in quotes.

  270. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 22:49:51 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Resolve recently introduced warnings about const char* to char* conversion C++ <sigh> We don't need a .ini section separator anyway.

  271. Deucе
    Fri Mar 22 2024 22:44:30 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Put the job ID in the tarball filename. This should help debug if multiple jobs are writing the same archives.

  272. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 22:04:50 GMT-0700 (PDT)
    Removed Files:
    

    src/sbbs3/v4upgrade.c diff
    src/sbbs3/v4upgrade.vcxproj diff
    Remove the v4upgrade code/project Just about everything in here has been implemented in v3.20 already

  273. Rob Swindell (on Windows 11)
    Fri Mar 22 2024 21:27:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Replace (and auto-upgrade) ctrl/time.dab with time.ini This will allow us to change scfg_t.event[].last to a time_t value (from time32_t) whenever we abandon Borland C/C++ in the future. Now it's trival for sysops to view/edit when their timed events 'last run' values. And there's no more endianness concerns. Bad .dab files, bad, go away. After I wrote this change, I found the original conversion code in v4upgrade.c which is almost exactly the same (except I was going to write to different filename). Finally actually implemented this. Next up: qnet.dab

  274. Rob Swindell (on Windows 11)
    Fri Mar 22 2024 21:27:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Convert (and auto-upgrade) ctrl/qnet.dab to ctrl/time.ini as well I suppose this should've been part of the previous commit. Again, this is almost verbatim what v4upgrade.c did (though never actually used).

  275. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 21:00:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ver.cpp diff
    Fix typo in http URL (colon, not semicolon)

  276. Eric Oulashin
    Fri Mar 22 2024 19:19:18 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DDFileLister: (Hopefully) Fix for descLines being undefined in getFileInfoLineArrayForTraditionalUI()

  277. Rob Swindell
    Fri Mar 22 2024 19:52:08 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_descLines_undefined_fix' into 'master' DDFileLister: (Hopefully) Fix for descLines being undefined in getFileInfoLineArrayForTraditionalUI() See merge request main/sbbs!428

  278. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 12:24:09 GMT-0700 (PDT)
    Modified Files:
    

    exec/addfiles.js diff
    Add better error reporting when listfile can't be found on disk For Dumas Walker (CAPCITY2)

  279. Deucе
    Fri Mar 22 2024 11:52:39 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Stop interlacing preprocessor stuff.

  280. Deucе
    Fri Mar 22 2024 11:50:35 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Borland expects ()

  281. Deucе
    Fri Mar 22 2024 11:48:16 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    static_assert() only available with C11 and higher.

  282. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 11:47:21 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Fix stale comment about XSAFECOPY (now uses strlcpy, not strncpy)

  283. Deucе
    Fri Mar 22 2024 11:40:31 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Use static_assert() macro instead of _Static_assert keyword More compatible with C++ that way.

  284. Deucе
    Fri Mar 22 2024 11:37:18 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sauce.c diff
    Remove gratuitous use of comma operator.

  285. Deucе
    Fri Mar 22 2024 11:37:35 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Use strlcpy() for X?SAFECOPY() macros. Also, for DEBUG builds, add a static assertion that sizeof(dst) != sizeof(void*) to catch the most common breakage.

  286. Deucе
    Fri Mar 22 2024 11:30:53 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Fix issue in last commit Need to update the parameter names as well.

  287. Deucе
    Fri Mar 22 2024 11:17:41 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    src/xpdev/genwrap.c diff
    Use strlcpy() for SAFECOPY() and XSAFECOPY() macros. While we're here, Update strlcpy() to slightly more optimal FreeBSD-13.3 version.

  288. Deucе
    Fri Mar 22 2024 10:59:15 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Cpoy/paste strlcat() from FreeBSD 13.3-RELEASE

  289. Deucе
    Fri Mar 22 2024 02:15:06 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/ripper.c diff
    Use safer string things... We really need strlcpy()/strlcat() wrappers in xpdev.

  290. Deucе
    Thu Mar 21 2024 23:38:05 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Now unbreak!

  291. Deucе
    Thu Mar 21 2024 23:33:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Break stuff to test things.

  292. Deucе
    Thu Mar 21 2024 23:24:35 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Instead of converting failures to warnings, run cleanup "always"

  293. Rob Swindell (on Windows 11)
    Thu Mar 21 2024 21:56:18 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    ftp_remove() returns a bool (not an int) now, so do the right thing

  294. Deucе
    Thu Mar 21 2024 17:24:32 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    We need an empty dependencies list, or it will download all the artifacts before deleting temp files. :(

  295. Deucе
    Thu Mar 21 2024 17:12:36 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    We can't make cleanup use needs since some platforms don't run tests.

  296. Deucе
    Thu Mar 21 2024 17:09:48 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Fix cleanup needs

  297. Deucе
    Thu Mar 21 2024 17:08:49 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Don't group cleanup either, and don't make it wait.

  298. Deucе
    Thu Mar 21 2024 17:07:04 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Stop grouping the js-testsuite

  299. Deucе
    Thu Mar 21 2024 17:01:44 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Re-enable Darwin Also, allow tests to run as soon as jsdoor is done, and don't use the artifact file, use the local copy instead.

  300. Deucе
    Thu Mar 21 2024 16:56:52 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Disable Darwin build just to see how fast it could be...

  301. Deucе
    Thu Mar 21 2024 16:49:25 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    OpenBSD requires -xzf, fix gtk* extractions

  302. Deucе
    Thu Mar 21 2024 16:36:58 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Everyone has to clean up.

  303. Deucе
    Thu Mar 21 2024 16:34:21 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    A couple more tipoes.

  304. Deucе
    Thu Mar 21 2024 16:31:06 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Fix typo

  305. Deucе
    Thu Mar 21 2024 16:23:56 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Just slap intermediate results in /tmp/gitlab-runner and call it good

  306. Deucе
    Wed Mar 20 2024 21:49:07 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Nope, that won't work either.

  307. Deucе
    Wed Mar 20 2024 21:36:00 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    More cache fun

  308. Deucе
    Wed Mar 20 2024 21:32:39 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    More cache fiddling. Only on freebsd-amd64 now though... no need to leave stuff laying everywhere.

  309. Deucе
    Wed Mar 20 2024 21:23:24 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Turns out, we can't cleanup caches like that. :(

  310. Deucе
    Wed Mar 20 2024 21:12:26 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Use dependencies, not needs so cleanup runs at end.

  311. Deucе
    Wed Mar 20 2024 21:03:13 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    paths, not files

  312. Deucе
    Wed Mar 20 2024 21:02:11 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Stage, not state

  313. Deucе
    Wed Mar 20 2024 20:59:27 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Experiment for the caches... hoping this doesn't leave an empty zip file laying aorund.

  314. Rob Swindell (on Windows 11)
    Wed Mar 20 2024 20:31:35 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Reduce log severity of QWK-packet removal error log message to WARNING This allows each call to ftp_remote() to specify the log level for any remove failure. All others file-removal failures will continue to log at ERROR level. I get this particular (harmless) error a lot, so just reducing to warning: ftp ... !ERROR 13 (Permission denied) (line 860) removing file: path/to/*.qwk

  315. Deucе
    Wed Mar 20 2024 17:27:04 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    We need the .o files to avoid rebuilding in jsdoor target.

  316. Deucе
    Wed Mar 20 2024 16:40:42 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Create a new jsdoor job that depends on sbbs-build. This basically just moves the download of sbbs-build from the test phase to the build phase, so shouldn't result in any speedup.

  317. Deucе
    Wed Mar 20 2024 12:00:03 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Noskeeters need to extend sbbs-build, not sbbs

  318. Deucе
    Wed Mar 20 2024 11:55:53 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Split sbbs into sbbs-build that compiles and sbbs that just combines. This will allow sbbs-build to run in parallel with scfg etc.

  319. Deucе
    Wed Mar 20 2024 11:44:15 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Remove date calls. About ten seconds in extract/patch, two minutes in build.

  320. Deucе
    Wed Mar 20 2024 11:42:00 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Explicitly don't need anything for "root" jobs.

  321. Deucе
    Wed Mar 20 2024 11:27:00 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/cl-fixed-fixed-seed.patch diff
    diff -u, not diff -i :(

  322. Deucе
    Wed Mar 20 2024 11:25:29 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/cl-fixed-fixed-seed.patch diff
    Modified Files:

    .gitlab-ci-unix.yml diff
    3rdp/build/GNUmakefile diff
    Use a fixed fixed seed for CI

  323. Deucе
    Wed Mar 20 2024 11:15:49 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Print the date, not the literal string "date" :(

  324. Deucе
    Wed Mar 20 2024 11:11:27 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Slap some date calls in to profile the pipes.

  325. Deucе
    Wed Mar 20 2024 10:01:29 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Cache the ffi cache.

  326. Deucе
    Wed Mar 20 2024 09:59:21 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/js-keep-ffi-cache.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Make the ffi cache the same as sm cache but with ".ffi" on the end Allows caching in gitlab.

  327. Deucе
    Wed Mar 20 2024 09:38:49 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    We can't pass on command-line since we want to change it.

  328. Deucе
    Wed Mar 20 2024 09:20:02 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Spell cache-file correctly.

  329. Deucе
    Wed Mar 20 2024 09:10:18 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Attempt to cache the autoconf cache.

  330. Deucе
    Wed Mar 20 2024 02:35:53 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    And finally, ccache raspian.

  331. Deucе
    Wed Mar 20 2024 02:19:44 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    And ccache the rest of alumitron.

  332. Deucе
    Wed Mar 20 2024 01:54:09 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Enable ccache for NetBSD and OpenBSD as well.

  333. Deucе
    Wed Mar 20 2024 01:10:48 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    We need to add RELEASE=1 if we specify build flags manually.

  334. Deucе
    Wed Mar 20 2024 00:44:51 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/GNUmakefile diff
    Use XPDEV_CFLAGS when building. Fixes at least an snprintf() issue on macOS, and likely many other things. It's actually surprising this builds without it to be honest.

  335. Deucе
    Wed Mar 20 2024 01:02:43 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/cl-quote-cc.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    Enable ccache for Darwin. This may or may not actually work, and will certainly need a few runs to build up the cache first.

  336. Deucе
    Tue Mar 19 2024 22:55:06 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    3rdp/build/js-darwin-configure.patch diff
    src/sbbs3/GNUmakefile diff
    Support MacPorts locations as well. Search in both /usr/local (Homebrew) and /opt/local (MacPorts) for libraries. Also, have the name of GNU make be an in option in CI so we can use the Apple-provided make.

  337. Deucе
    Tue Mar 19 2024 11:56:40 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Remove space.

  338. Deucе
    Tue Mar 19 2024 11:54:52 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Most seds apparently don't support -I

  339. Deucе
    Tue Mar 19 2024 11:33:57 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    3rdp/build/cl-macosx-minver.patch diff
    src/build/Common.gmake diff
    Default to building for the current macOS version, fix 3rdp Now if you don't specify MIN_MAC_OSX_VERSION, it will use the "current" version of macOS as the target. "Current" is defined as X.0 where the major version (X) is greater than 10 and X.Y when major version is 10. This allows building for a specific target, but uses the newest libraries if you don't specify.

  340. Deucе
    Tue Mar 19 2024 10:59:57 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    3rdp/build/cl-macosx-minver.patch diff
    src/build/Common.gmake diff
    Bump the default min supported mac version to 12.0 For Synchronet "stuff", we can trivially change this, but some work needs to be done to enable Spidermonkey and Cryptlib to pick up the chosen value. JS should be fairly simple since it's a configure argument. Cryptlib is a bit trickier since it's in a patch.

  341. Rob Swindell (on Windows 11)
    Mon Mar 18 2024 21:21:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/WebCfgDlgUnit.cpp diff
    Bugfix: Log->Base Filename edit box wasn't populated or read ... so the [web] HttpLogFile setting in sbbs.ini couldn't be set using this dialog. Been broken all this time.

  342. Rob Swindell (on Windows 11)
    Mon Mar 18 2024 21:21:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    Fix logic to add the "partially" prefix to download notification messages The file_t struct may not have the size of the file pre-poulated, so we needed to call getfilesize() here.

  343. Rob Swindell (on Windows 11)
    Mon Mar 18 2024 21:21:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Fix a bunch of false "File sent" logs (and uploader-notifications) Web browsers tend start a download and then immediately close the socket (so now send_failed will be true), while on a secondary socket, do a range download of the same file. So log the range requests/completions and don't log successful file sends when the send was terminated due to a send failure. We still count very small (e.g. 2 byte) ranges as successful file transfers and notify the uploader (of a partial download), so we should fix those issues still. But at least now, there's a whole lot less "noise" created from HTTP[S} file downloads via browser.

  344. Deucе
    Mon Mar 18 2024 20:29:37 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    jsdoor and jsexec both depend on ciolib (and likely others)

  345. Deucе
    Mon Mar 18 2024 20:53:48 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/ciolib.c diff
    Don't bother starting the SDL thread just to shut it down. Fixes issue closing SyncTERM in curses mode on macOS.

  346. Deucе
    Mon Mar 18 2024 11:52:49 GMT-0700 (PDT)
    Modified Files:
    

    exec/dorkit/screen.js diff
    Support ignoring CSI n commands. Fixes issue reported from CCO BBS.

  347. Deucе
    Sun Mar 17 2024 21:48:26 GMT-0700 (PDT)
    Added Files:
    

    src/syncterm/DarwinWrappers.h diff
    src/syncterm/DarwinWrappers.m diff
    Modified Files:

    src/build/Common.gmake diff
    src/syncterm/GNUmakefile diff
    src/syncterm/syncterm.c diff
    Add Objective-C wrappers file for Darwin. The native OS calls are ObjC, and the C/C++ APIs are being deprecated, so we need something along these lines. For now, I'm just moving the path "stuff" in there since that's the bulk of the deprecation warnings in building SyncTERM.

  348. Deucе
    Sun Mar 17 2024 15:17:31 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    src/conio/sdl_con.c diff
    Some more macOS fixes... 1) Use static SDL since it's required by both conio and XPDev 2) Since the SDL thread will always run, any attempt to shut down the SDL thread calls exit(0). Not exactly what we want to return, but at least this makes it not hang waiting for the impossible.

  349. Deucе
    Sun Mar 17 2024 15:48:26 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/ciolib.c diff
    src/conio/sdl_con.c diff
    Fix up exit codes on macOS The issue was that the various semaphores and mutexes weren't being initialized at all when sdl_initconio() wasn't called... so starting the event thread and telling it to stop would access uncreated semaphores and mutexes. Split out the init, and be sure to call it before exiting.

  350. Deucе
    Sun Mar 17 2024 14:30:43 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/sdl_con.c diff
    Revert last change reaper is explicitly disabled here.

  351. Deucе
    Sun Mar 17 2024 14:29:20 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/sdl_con.c diff
    Call exit() from exit_sdl_con if ciolib_reaper is enabled and SDL is not initialized.

  352. Deucе
    Sun Mar 17 2024 13:21:22 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    YAML Fixups

  353. Deucе
    Sun Mar 17 2024 13:04:01 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    src/conio/Common.gmake diff
    src/xpdev/Common.gmake diff
    Apparently -framework is a link flag, not a compile one

  354. Deucе
    Sun Mar 17 2024 12:50:05 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Disable jsdoor separate target and build in sbbs3 target JSDoor only compiles one file that isn't shared with the sbbs3 target, so there's no need to build them all twice.

  355. Deucе
    Sun Mar 17 2024 12:29:15 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/sdl_con.c diff
    Do not attempt to clean up SDL unless it was initialized. Should fix js test suite on darwin.

  356. Deucе
    Sun Mar 17 2024 04:28:42 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Argh! Put xpdev libs in the wrong lib!

  357. Deucе
    Sun Mar 17 2024 03:57:18 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Whoops, missed this bit of the macOS patch

  358. Deucе
    Sun Mar 17 2024 03:22:16 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    We can't use version scripts on Darwin.

  359. Deucе
    Sun Mar 17 2024 02:46:11 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Darwin is not a cross-platform build (though the M1 build would be)

  360. Deucе
    Sun Mar 17 2024 02:15:20 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/js-darwin-configure.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    src/build/Common.gmake diff
    src/sbbs3/GNUmakefile diff
    src/xpdev/genwrap.h diff
    Fix builds for macOS It builds and appears to run... not actually tested.

  361. Nigel Reed
    Sun Mar 17 2024 02:07:12 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/ircd.ini diff
    ircdcfg would not provide a valid irc.ini file

  362. Rob Swindell
    Sun Mar 17 2024 02:07:13 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/ircd.ini diff
    Merge branch 'fix_template_ircd_ini_for_ircdcfg' into 'master' ircdcfg would not provide a valid irc.ini file See merge request main/sbbs!426

  363. Deucе
    Sun Mar 17 2024 01:34:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/jsexec.c diff
    Don't use the non-standard third parameter to main for enivronment Use the standard `extern char **environ' instead. Fixes an issue with macOS. Also, check that env is not NULL in js_init.

  364. Deucе
    Sun Mar 17 2024 00:57:14 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    src/build/Common.gmake diff
    All mac hardware that supports 10.9 also supports 10.11 No real purpose to keeping the default min version at 10.9.

  365. Rob Swindell (on Debian Linux)
    Sun Mar 17 2024 00:26:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/fixsmb.c diff
    Increment version to fixsmb to v3.20

  366. Rob Swindell (on Debian Linux)
    Sun Mar 17 2024 00:33:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/listfile.cpp diff
    Resolve a couple GCC warnings of impossible conditions

  367. Rob Swindell (on Debian Linux)
    Sun Mar 17 2024 00:34:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/qwk.cpp diff
    src/sbbs3/un_qwk.cpp diff
    src/sbbs3/un_rep.cpp diff
    Replace some sprintf calls with snprintf ... much more still to do, I'm sure.

  368. Deucе
    Sun Mar 17 2024 00:24:59 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Add a few more PLATFORM_DESC values

  369. Deucе
    Sun Mar 17 2024 00:00:02 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    We need macOS 10.9 for std::atomic

  370. Deucе
    Sun Mar 17 2024 00:04:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/jsexec.c diff
    Make Windows hack Windows-only We need _CIOLIB_main on macOS... at least until the curses stuff works.

  371. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 23:03:52 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/slyvote/slyvote.js diff
    Update netattr flag naming to match smbdefs.js Eliminate some never-defined/used flags (copied from smb.html?)

  372. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 22:12:51 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/smbdefs.js diff
    White-space fix-ups

  373. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 22:20:43 GMT-0700 (PDT)
    Modified Files:
    

    exec/emailfiles.js diff
    exec/imapservice.js diff
    exec/load/smbdefs.js diff
    exec/msglist.js diff
    exec/notransit.js diff
    Do the SMB msghdr netattr MSG_* -> NETMSG_* conversion dance Sorry Nightfox, this might break your scripts

  374. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 22:03:32 GMT-0700 (PDT)
    Added Files:
    

    exec/type.js diff
    Modified Files:

    exec/GNUmakefile diff
    Removed Files:

    exec/cntnodes.src diff
    exec/default.src diff
    exec/dir.src diff
    exec/file_io.src diff
    exec/html.src diff
    exec/lbshell.src diff
    exec/menushel.src diff
    exec/noyesbar.src diff
    exec/qnet-ftp.src diff
    exec/socktest.src diff
    exec/type.src diff
    exec/yesnobar.src diff
    Remove old/deprecated Baja mods (replaced with JS or just obsoleted) e.g. stubs for JS command shells, examples of how to do file I/O, socket I/O and such in Baja (which you really shouldn't). Added type.js to replace type.src/bin

  375. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 20:34:30 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/shell_lib.js diff
    Fix user-to-user download function The JS file_area.user_dir is an object (not documented in jsobjs.html!) and bbs.list_file_info() method expects the directory number (not object) as the first argument. Reported by Jas Hud.

  376. Rob Swindell (on Windows 11)
    Sat Mar 16 2024 20:02:04 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/chksmb.c diff
    src/sbbs3/fixsmb.c diff
    src/sbbs3/getmsg.cpp diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/netmail.cpp diff
    src/sbbs3/sbbsecho.c diff
    src/smblib/smbdefs.h diff
    src/smblib/smbstr.c diff
    Rename SMB message header 'netattr' bit flags to NETMSG_* This resolves the conflict with MSG_HOLD definition in socket.h on MacOS: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sys/socket.h And hey... [NET]MSG_HOLD isn't actually used anywhere? What's up with that.

  377. Rob Swindell (on Windows 11)
    Sat Mar 16 2024 20:03:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/pack_qwk.cpp diff
    Add "MSGID" to QWK DOOR.ID file This is a "newer" QWK control message supported by Synchronet (for like 20 years now), so it's been missing from the DOOR.ID file all this time and no one noticed. <shrug>

  378. Rob Swindell (on Windows 11)
    Sat Mar 16 2024 20:09:39 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Bugfix: actually use the SMB netattr 'HOLD' attribute flag ... when exporting from SMB to .msg ("stored message") file

  379. Deucе
    Sat Mar 16 2024 19:23:14 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Add missing endif

  380. Deucе
    Sat Mar 16 2024 19:15:15 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Use Homebrew libarchive

  381. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 18:50:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/ircd/core.js diff
    IPs listed in dnsbl_exmempt.cfg are exempt from RBL lookups

  382. Deucе
    Sat Mar 16 2024 18:43:22 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    src/conio/Common.gmake diff
    src/xpdev/Common.gmake diff
    Fix xpdev and conio builds, disable JS for macOS for now

  383. Deucе
    Sat Mar 16 2024 17:43:13 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add macOS runner

  384. Rob Swindell (on ChromeOS)
    Sat Mar 16 2024 15:43:17 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsub.c diff
    Don't copy/use the Access Requirements of the template sub for newly-added subs We don't clone the Access Requirements from the template sub-board when clonig (intentionally), similarly we shouldn't copy the Access Requirements of the template sub-board when creating/adding/importing new sub-boards either. This should fix issue #736 even though the title and description of the issue is misleading.

  385. Deucе
    Thu Mar 14 2024 16:35:00 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Don't double-space between file locations. Don't want to have to scroll here.

  386. Deucе
    Thu Mar 14 2024 16:19:27 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Fix random upper-case Letter.

  387. Deucе
    Thu Mar 14 2024 16:16:07 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Add upgrade check and "help" text. It basically says "You should move files from where they are to where they should be".

  388. Deucе
    Thu Mar 14 2024 11:32:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/uedit/uedit.c diff
    Make uedit somewhat friendlier to screen readers. Support -iD Use a , instead of CP437 verticla bar as separator. Also fixes bug with active user list.

  389. Deucе
    Thu Mar 14 2024 10:50:39 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Fix windows build

  390. Deucе
    Thu Mar 14 2024 10:46:38 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Move list into .config on *nix Per https://wiki.debian.org/XDGBaseDirectorySpecification, CONFIG should be fairly small files that you would want to maintain in a VCS... the list makes sense here.

  391. Deucе
    Thu Mar 14 2024 10:24:26 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/term.c diff
    Remove unused variable.

  392. Deucе
    Thu Mar 14 2024 10:24:47 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Show SSH keys file path as well.

  393. Deucе
    Thu Mar 14 2024 10:25:03 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Use XDG paths, clean up code Instead of ~/.syncterm, use paths as specified in the XDG Base Directory Specification https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html This should really have something that notifies a user everything moved and instructs them on where each thing should be placed to keep data from older versions.

  394. Rob Swindell (on Debian Linux)
    Wed Mar 13 2024 23:02:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    Display command shell name along with internal code for new user values Also make it more clear in the online help that some of the new user values are also applied to Guest (G-restricted) account logons.

  395. Eric Oulashin
    Wed Mar 13 2024 20:52:29 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/version_history.txt diff
    DDFileAreaChooser: Fix for the directory item counts

  396. Rob Swindell
    Wed Mar 13 2024 22:40:46 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/version_history.txt diff
    Merge branch 'dd_file_area_chooser_item_count_fix' into 'master' DDFileAreaChooser: Fix for the directory item counts See merge request main/sbbs!425

  397. Eric Oulashin
    Tue Mar 12 2024 15:04:11 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    DDFileLister: List header line refresh fix - Right border characters were shifted left 1 char (noticeable when the batch add success dialog closed)

  398. Rob Swindell
    Tue Mar 12 2024 15:04:11 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    Merge branch 'dd_file_lister_hdr_line_refresh_fix' into 'master' DDFileLister: List header line refresh fix - Right border characters were shifted left 1 char (noticeable when the batch add success dialog closed) See merge request main/sbbs!424

  399. Deucе
    Tue Mar 12 2024 14:33:48 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    Disable LTO for now... it appears LTO is more strict with object ordering.

  400. Deucе
    Tue Mar 12 2024 14:12:07 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    Enable LTO unless NO_LTO is defined... We may want to set NO_LTO for the pipeline...

  401. Rob Swindell (on Debian Linux)
    Tue Mar 12 2024 14:00:40 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/fixsmb.c diff
    Don't hash messages with invalid message numbers It's better to have deleted messages without a hash than to hash invalid message numbers. This can be used to address a (renumbered?) message base that Kirkman shared with me with "Invalid Message number" chksmb warnings from hash entries with message numbers > than the base's last_msg.

  402. Deucе
    Tue Mar 12 2024 13:10:00 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc32.c diff
    Remove non-ASCII char comments. These were originally non-ASCII char literals.

  403. Eric Oulashin
    Tue Mar 12 2024 09:55:29 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    substrWithAttrCodes() fix (string was too long by 1 char; in dd_lightbar_menu.js); a couple of small corresponding updates in ddfilelister.js

  404. Rob Swindell
    Tue Mar 12 2024 11:55:29 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_lightbar_menu_substrWithAttr_1_too_long_and_ddfilelister_fix' into 'master' substrWithAttrCodes() fix (string was too long by 1 char; in dd_lightbar_menu.js); a couple of small corresponding updates in ddfilelister.js See merge request main/sbbs!423

  405. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 22:10:30 GMT-0700 (PDT)
    Added Files:
    

    ctrl/text.fr.ini diff
    New French (I'm sure badly translated) language file, a beginning I hope

  406. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 22:10:30 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.de.ini diff
    ctrl/text.es.ini diff
    Add FREE translation (6 chars or fewer is desired) So KOSTEN means "cost" in German, sort of the opposite of FREE. Maybe "!KOST" would get the point across?

  407. Rob Swindell (on Windows 11)
    Mon Mar 11 2024 22:07:19 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Remove obsolete MUTE options

  408. Rob Swindell (on Windows 11)
    Mon Mar 11 2024 22:08:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/listfile.cpp diff
    Actually use the new FREE text.dat string in file listings

  409. Rob Swindell (on Windows 11)
    Mon Mar 11 2024 19:39:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    Statically initialize uart to COM1 details, don't rely on VDDInitialize call Older versions of Windows don't (always?) call VDDInitialize(), so we need to statically initialize the uart struct. This should address the problem reported by Fzf (FQBBS) via DOVE-Net: ... When using the included SBBSEXEC.DLL, the UART emulation defaults to base address 0x000 and interrupt 0x0. The lockups do not occur when this is left as-is but none of the UART emulation does anything. Setting a ComPort in a [UART] section of SVDM.INI or SBBSEXEC.INI does change the I/O address and IRQ to an expected value. But this isn't necessary. The mere existence of one of those two INI files, even if empty, sets the UART to the expected default of 0x3F8/IRQ4. The debug entry is always as follows when left without any INI file: [180] SBBS: Virtualizing UART (0x0, IRQ 0) This bug appears to be caused by commit 3ba5aa8d7a663 (1 year ago), where uart was no longer statically-initialzed and relied on VDDInitialize() to be called to copy default_uart to the uart struct.

  410. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 18:18:31 GMT-0700 (PDT)
    Removed Files:
    

    install/checkout.bat diff
    This file isn't used/useful (no CVS repo anymore, per Nelgin's wishes)

  411. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 18:19:41 GMT-0700 (PDT)
    Removed Files:
    

    exec/classic_shell.js diff
    This file has been replaced by default.js and lib_shell.js And is now a good example of how to write a Synchronet command shell in JS, though classic_shell.js served its purpose.

  412. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 18:23:06 GMT-0700 (PDT)
    Removed Files:
    

    install/sbbs_src.exclude diff
    install/sbbs_src.lst diff
    install/tarlibs.sh diff
    install/tarsrc.sh diff
    Cruft removal Not sure when the last time these files were used, but it couldn't have been recent.

  413. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 14:06:28 GMT-0700 (PDT)
    Modified Files:
    

    exec/user_settings.js diff
    Don't allow terminal columns and rows to be set to -1 Range check return value of console.getnum(), as is done in useredit.cpp. The user hitting ^C at eithe of the terminal columns or rows prompts would set that value -1.

  414. Rob Swindell (on Debian Linux)
    Sun Mar 10 2024 16:48:36 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.dat diff
    New/changed file-related text strings (see previous commit/merge)

  415. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/smbdefs.h diff
    src/xpdev/gen_defs.h diff
    Eliminate old macro-wrappers for malloc/free/realloc Artifacts from the 16-bit DOS days where we needed the large or huge "memory model" to allocate > 64KB of memory.

  416. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/listfile.cpp diff
    Removing files via batch flag prompt, don't try to remove cdt for free files

  417. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/text_id.c diff
    More details from text.dat strings when removing files or credits Don't display "FREE" in file listings for 0 byte files. When removefcdt() is called for an unknown file uploader, use the new UnknownUploader text.dat string to display the username and filename. When prompting to remove credits, include the username from which to remove the credits. These usability improvements came from watching Deuce struggle to remove malicious uploaded-files and credits from (presumably Guest) user. I should watch sysops manage their BBSes more often.

  418. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    Update help text for loadable modules

  419. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Update "SendMail Support" menu option and help title

  420. Deucе
    Fri Mar 08 2024 21:38:17 GMT-0800 (PST)
    Modified Files:
    

    exec/lbshell.js diff
    Fix longstanding TODO to get files in a directory. This is likely also broken classic_shell.js, but nobody should ever open that file anymore.

  421. Eric Oulashin
    Fri Mar 08 2024 20:35:01 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DDFileLister: Description search as loadable module now works. Added mention of Ctrl-C to the help screen.

  422. Rob Swindell
    Fri Mar 08 2024 20:51:20 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_loadable_module_desc_search_and_ctrl_c_help_screen' into 'master' DDFileLister: Description search as loadable module now works. Added mention of Ctrl-C to the help screen. See merge request main/sbbs!422

  423. Deucе
    Fri Mar 08 2024 20:23:40 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    This will be at least 1.2 Also, it's SyncTERM Cyan, not Syncterm.

  424. Deucе
    Fri Mar 08 2024 09:36:51 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move sftp_state setting outside of the ssh mutexes. Doesn't hurt anything where they were, but Coverity kinda reverse suggested it.

  425. Deucе
    Thu Mar 07 2024 21:19:03 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    src/syncterm/bbslist.c diff
    Some menu/help cleanup More documentation of stuff.

  426. Eric Oulashin
    Thu Mar 07 2024 20:51:56 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: Fix in DrawPartial() for an edge case where it was missing the last character of the menu/menu items in some cases

  427. Rob Swindell
    Thu Mar 07 2024 20:51:56 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_DrawPartial_right_edge_fix' into 'master' DDLightbarMenu: Fix in DrawPartial() for an edge case where it was missing the last character of the menu/menu items in some cases See merge request main/sbbs!421

  428. Deucе
    Thu Mar 07 2024 20:19:16 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    More manual noodling.

  429. Deucе
    Thu Mar 07 2024 19:39:55 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Default SFTP Public Key to false. It causes connections to Mystic BBSs to fail, and assumes the server is running OpenSSH (or Synchronet, which is purposefully compatible with OpenSSH). I love the feature, but it's not good enough for on-by-default. After 1.2 is released, and I do a proper sftp client, I'll likely remove the option anyway, and just have a way to upload it on demand.

  430. Deucе
    Thu Mar 07 2024 13:57:28 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_server.c diff
    Fix warning in mingw32 builds about vasprintf()

  431. Deucе
    Thu Mar 07 2024 13:47:05 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    src/sftp/sftp_client.c diff
    src/syncterm/ssh.c diff
    Split SFTP client cleanup into to functions. sftp_finish() which ends the communication, disables further commands, and can explicitly be called more than once, and sftp_end() which frees the state. This prevents a race around sftp_finish() calls and sftpc_*() calls which is likely responsibe for various weirdness in SSH connections, and should fix ticket 135.

  432. Deucе
    Thu Mar 07 2024 12:10:46 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    src/sftp/sftp_client.c diff
    src/syncterm/ssh.c diff
    Add sftpc_get_err() function and make the sftp client struct hidden This eliminates the hack of using ssh_mutex to protect members of sftp_state (which has its own mutex). This doesn't fix the problem of sftp_state itself though.

  433. Deucе
    Thu Mar 07 2024 11:44:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Fix LOR ion error path.

  434. Deucе
    Thu Mar 07 2024 11:44:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Fix double-unlock and add code for impoosible situation

  435. Rob Swindell (on Debian Linux)
    Thu Mar 07 2024 00:03:53 GMT-0800 (PST)
    Modified Files:
    

    src/build/gitinfo.bat diff
    src/sbbs3/targets.mk diff
    Zero-pad (instead of space-pad) the day of month in GIT_DATE This is not consistent with __DATE__ macro expansion, but I like it better Heck, now that we're not really logging the build date much of anywhere, we could go with any other more sensible date format here.

  436. Rob Swindell (on Debian Linux)
    Thu Mar 07 2024 00:05:58 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/msg_id.c diff
    Include just date in the program-ID (as before) the switch for build->Git date

  437. Rob Swindell (on Debian Linux)
    Thu Mar 07 2024 00:06:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ver.cpp diff
    Restore the additional space before the SMBLIB version

  438. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 23:50:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Don't use echo to create git_hash.h, collapses multiple spaces Wasn't sufficiently quoting, but we don't need to use echo in the first place Will reconsider using %e instead of %d later

  439. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 22:12:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    New @-code: GIT_DATE

  440. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 22:54:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/jsexec.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/msg_id.c diff
    src/sbbs3/sbbscon.c diff
    src/sbbs3/sbbsecho.c diff
    src/sbbs3/sbbsexec.c diff
    src/sbbs3/services.c diff
    src/sbbs3/sexyz.c diff
    src/sbbs3/smbutil.c diff
    src/sbbs3/ver.cpp diff
    src/sbbs3/websrvr.c diff
    Report/log the Git commit date/time, not the build date/time The Git commit date/time is more useful information.

  441. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 22:06:27 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_system.c diff
    Add system.git_date proprety (string)

  442. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 18:30:25 GMT-0800 (PST)
    Modified Files:
    

    src/build/gitinfo.bat diff
    Use double-quotes for Windows cmd.exe compatibilty

  443. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 18:25:43 GMT-0800 (PST)
    Modified Files:
    

    src/build/gitinfo.bat diff
    We need to double-up the percents in batch lingo

  444. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 17:35:19 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/GNUmakefile diff
    Kind of sort of fix xptime build (needs math lib now) There's some GNU make sorcery still needed here to address build errors (though it does generate a working executable): /usr/bin/ld: cannot find gcc.linux.x64.obj.debug: file format not recognized /usr/bin/ld: cannot find gcc.linux.x64.lib.debug: file format not recognized /usr/bin/ld: cannot find gcc.linux.x64.exe.debug: file format not recognized

  445. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 18:12:44 GMT-0800 (PST)
    Modified Files:
    

    src/build/gitinfo.bat diff
    src/sbbs3/targets.mk diff
    src/sbbs3/ver.cpp diff
    src/sbbs3/ver.h diff
    Define GIT_DATE in git_hash.h and git_date in ver.cpp Display the date of last git commit used in this bulid as part of git branch and hash information. This helps to inform how up-to/out-of date the current running build is, regardless of the build date/time.

  446. Deucе
    Wed Mar 06 2024 10:07:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Remove (now) unused variable.

  447. Eric Oulashin
    Tue Mar 05 2024 18:33:55 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    DDFileLister: Removed unnecessary comments & stuff

  448. Rob Swindell
    Tue Mar 05 2024 20:17:00 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    Merge branch 'dd_file_lister_remove_unnecessary_comments_and_stuff' into 'master' DDFileLister: Removed unnecessary comments & stuff See merge request main/sbbs!420

  449. Rob Swindell (on Debian Linux)
    Tue Mar 05 2024 15:33:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/bat_xfer.cpp diff
    Fix warning about impossible condition.

  450. Rob Swindell (on Debian Linux)
    Tue Mar 05 2024 15:34:04 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_uifc.c diff
    Make uifc.input.CTX and uifc.showbuf.CTX constructors match assumptions/docs This one has caught me up before, for the CTX constructors didn't actually accept any initial property values (as arguments). mlong even documented it this way at https://wiki.synchro.net/ref:uifc#javascript_interface And construted his input.CTXs this way (using all 0 values, which were ignored) in his xtrnmenucfg.js

  451. Deucе
    Tue Mar 05 2024 11:58:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Don't return an error when reading /.. POSIX requires a .. directory in the root of a filesystem, and some SFTP clients (at least Filezilla and WinSCP) assume it's there even if the remote doesn't list it. Per POSIX, /. and /.. are the same directory.

  452. Deucе
    Tue Mar 05 2024 11:45:44 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdl_con.c diff
    src/conio/win32gdi.c diff
    src/conio/x_events.c diff
    Fix for SourceForge issue 134 Translation from mouse coordinates to screen coordinates had issues with internal vs. external scaling and for when there are gutters (ie: black bars) on the edges. This change snaps all gutter clicks to the nearest position inside the window instead of discarding them, and ensures the calculations are correct regardless of scaling mode. Win32GDI mode was not tested, the only change there was to stop ignoring mouse positions in the gutters.

  453. Deucе
    Mon Mar 04 2024 21:15:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp.h diff
    src/sftp/sftp_server.c diff
    src/sftp/sftp_str.c diff
    Do lprint() pointer instead of lprintf() pointer. This doesn't make anything better or worse for the C API, but doing variadic pointer things in C++ is fraught.

  454. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 20:43:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Put the 2 SFTP related options next to each other (duh)

  455. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 20:36:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Add the SSH "ANYAUTH" toggle option If the sysop wants their login module to always execute for SSH connections, set to this "Any" rather than the default ("Valid Key or Username").

  456. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:11:45 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    For name ints/enums, allow the value to be longer than the name This allows me to shorten "Informational" to "Info" and "Debugging" to "Debug" and be backward compatible with existing .ini files. I think "Info" and "Debug" are universally known and take up less space (e.g. in SCFG).

  457. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:17:58 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    Add helper functions for returning lib, grp, dir, and sub short names

  458. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:18:45 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    src/sbbs3/bat_xfer.cpp diff
    src/sbbs3/file.cpp diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/upload.cpp diff
    Add 2 additional arguments to FileAlreadyOnline text.dat string ... the library and directory (short) names Making it more obvious *where* the referenced file has already been uploaded.

  459. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:19:48 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/email.cpp diff
    src/sbbs3/netmail.cpp diff
    FileAlreadyThere is used as a printf-format elsewehre, do the same here The stock text.dat FileAlreadyOnline string doesn't actually contain a '%s', but if it did, it would've worked as intended in some cases, and broken badly in others. Now fixed for if/when we do actually include the filenaeme (%s) in that string.

  460. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:22:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Combine First / Last Node settings on a single option: Serving Nodes And make the PETSCII ports more aligned with the other protocol ports visually. If set to 0, say "<disabled>".

  461. Rob Swindell (on Debian Linux)
    Mon Mar 04 2024 00:12:44 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Disable the broken textgen running rule by default Should only be run on official sbbs builds anyway

  462. Rob Swindell (on ChromeOS)
    Mon Mar 04 2024 00:02:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/wordwrap.c diff
    src/sbbs3/wordwrap.h diff
    BOOL->bool conversion

  463. Rob Swindell (on ChromeOS)
    Mon Mar 04 2024 00:03:48 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    src/sbbs3/msgtoqwk.cpp diff
    src/sbbs3/objects.mk diff
    src/sbbs3/pack_qwk.cpp diff
    src/sbbs3/qwk.cpp diff
    src/sbbs3/qwk.h diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/targets.mk diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/text_id.c diff
    Add "word-wrap" option for QWK packet creation Some BBS programs (e.g. Synchronet v2) or possibly old offline message readers don't deal well with long-line messages. So add a per-user option to word/line wrap message text. Addresses issue (feature request) #428 Thanks for the reminder fusion @ CFBBS!

  464. Deucе
    Sun Mar 03 2024 19:08:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    "Fix" impossible warning.

  465. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 18:28:04 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Clear any mouse hot-spots before executing external program from exec_xtrn() As Nelgin pointed out, mouse hot-spots were still active when running external programs (door games) - so clear any active hot-spots before running external programs. This could possibly be done in external() instead, but this sufficient for now. I wouldn't want a menu that EXEC's something (via @-code) to lose all its hot-spots as a result.

  466. Rob Swindell (on Debian Linux)
    Sun Mar 03 2024 14:28:48 GMT-0800 (PST)
    Modified Files:
    

    exec/load/sbbsdefs.js diff
    Add SYS_MOUSE_HOT definition

  467. Rob Swindell (on ChromeOS)
    Sun Mar 03 2024 14:15:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Fix some new warnings about unused variable: 'enabled'

  468. Rob Swindell (on ChromeOS)
    Sun Mar 03 2024 14:15:56 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgsys.c diff
    New toggle option (SCFG->System->Toggles->Mouse Hot-spots in Menus/Prompts) This is for sysops that never want mouse hot-spots in their BBS menus and prompts (e.g. Kirkman, possibly Deuce) - set to "No". Setting to "No" also disables the function of the JS console.add_hotspot() method. Perhaps it should not. <shrug> Setting to "No" does not disable the terminal mouse support question when users are setting their terminal defaults. Perhaps it should. This option should default to enabled (sysops that depend on mouse hot-spots should double check) - it's enabled in new/stock installs.

  469. Deucе
    Sun Mar 03 2024 10:33:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Fix issue when third SSH authentication attempt succeeds Because the session is activated on the *next* time through the loop, if the third attempt to authenticate (including public key) fails, it would leave the session inactive and fail to log in with a confusing error about an obsolete cryptlib. On success, decrement ssh_failed to ensure another pass through the loop. Also, add more debug logging around the auth so you can clearly see each failure, and log client_socket each time so it's clearly grouped.

  470. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 02:46:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    src/sbbs3/websrvr.h diff
    Add NO_HTTP option to web server, for a HTTPS-only web server

  471. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 04:04:59 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    Update help text to refer to SCFG->Servers instead of sbbs.ini as reference.

  472. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 04:05:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Move a bunch of protocol support enable/disable and TCP ports to sub-menus ... declutter a bit more of the menus. Also added the new option to disable HTTP support in the web server.

  473. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 01:48:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Change Telnet, SSH, RLogin Support menus to "... Support" instead of "Server" And center the sub-menus.

  474. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 23:53:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp diff
    Clean up comment header block

  475. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 00:52:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.h diff
    src/sbbs3/sbbs_ini.c diff
    src/sbbs3/scfg/scfgsrvr.c diff
    src/sbbs3/startup.h diff
    Add configurable SFTP session inactivity timer (default: 5 minutes) Allow SFTP support to be enabled/configured in SCFG->Servers and SBBSCTRL->Terminal->Configure. SFTP session inactivity applies to 'H' exempt users too (intentionally).

  476. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 00:55:53 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Set default MaxSessionInactivity to 10 minutes and max SFTP inactivity to 5m

  477. Deucе
    Sat Mar 02 2024 23:06:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Add a function to convert file attributes to a string. And use it in the open() args log.

  478. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 22:57:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/download.cpp diff
    src/sbbs3/upload.cpp diff
    When logging file transfers, log the file size too (in bytes)

  479. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 22:58:00 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Re-arrange the [BBS] Options comments, add missing NO_TELNET option

  480. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 22:58:41 GMT-0800 (PST)
    Modified Files:
    

    docs/v320_new.txt diff
    New stuff documented

  481. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 22:24:38 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_server.c diff
    Fix typo in log message. I use a code editor with a spell checker. <shrug>

  482. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 21:19:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Open files in binary mode This explains the extra calls to record_transfer() on Windows SFTP server I do wonder if we should be usign sopen() or nopen() here instead though.

  483. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 21:12:17 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Include "up/downloaded" in log message for non-filebase-file transfers

  484. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 20:43:48 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Put SSH, Telnet, and RLogin settings in their own sub-menus of Terminal Server This makes the Terminal Server settings menu a bit less cluttered. And now we can add more SSH settings (like SFTP, Any Auth).

  485. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 19:37:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/sftp.cpp diff
    Add some log lines for SFTP logins, non-filebase file transfers Q for Deuce: record_transfer() is being called multiple times for non-filebase file transfers, resulting in duplicate log messages. This doesn't happen for filebase file transfer (downloads, anyway).

  486. Rob Swindell (on Debian Linux)
    Sat Mar 02 2024 18:38:52 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.de.ini diff
    ctrl/text.es.ini diff
    Add "Private" translation

  487. Rob Swindell (on Debian Linux)
    Sat Mar 02 2024 18:39:12 GMT-0800 (PST)
    Modified Files:
    

    exec/xtrn_sec.js diff
    Don't try to center on terminals < 80 columns wide

  488. Rob Swindell (on Debian Linux)
    Sat Mar 02 2024 18:37:49 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    Add NodeConnectionSFTP

  489. Rob Swindell (on Debian Linux)
    Sat Mar 02 2024 18:36:38 GMT-0800 (PST)
    Modified Files:
    

    exec/load/nodedefs.js diff
    exec/load/presence_lib.js diff
    exec/load/text.js diff
    Add support for SFTP node status

  490. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 18:23:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/getnode.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/node.c diff
    src/sbbs3/nodedefs.h diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/text_id.c diff
    src/sbbs3/userdat.c diff
    Address the SFTP logon issues (timeout waiting for keypress, node status, etc) For SFTP sessions, there's no shell/terminal, so no need to run command shells (with their input timeouts, etc.). Reflect the node connection as "via sftp" in the node status. Handle node interruption signal. Probably more to do here with node status/actions (e.g. it'd be nice to set the action to "uploading or "downloading" when appropriate).

  491. Deucе
    Sat Mar 02 2024 17:03:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Make the implied cast explicit rather than change the behaviour.

  492. Deucе
    Sat Mar 02 2024 16:59:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Fix static casts. These functions take a uint32_t, not a time32_t (which is an int32_t).

  493. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 16:30:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logout.cpp diff
    Don't update the user's new file scan date/time if it was never set Every SFTP login/off would reset the user's new-file-scan date to Jan-1-1970

  494. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 16:27:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Resolve some MSVC and GCC warnings with static casts

  495. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 16:12:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_msgbase.c diff
    More use of JS_ValueToECMAUint32 in place of JS_ValueToInt32 To support the full 32-bit range for things like dates/times, and message numbers (!). This should fix issue #732 Though dates beyond Feb 7 2106 are definitely going to still be an issue. I'll definitley look into solving that by the the 2100.

  496. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 15:34:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    TRUE -> true

  497. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 15:37:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    client_on() still accepts a BOOL (not bool), so TRUE (not true) is correct

  498. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 15:45:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Initialize sbbs_t::client and call client_on() as expected for logins See sbbs_t::logon() for example Note: the client.protocol is still "SSH" here (not "SFTP"). Perhaps that should be changed? Does any client actually support simultaneous "SSH" and "SFTP" sessions over the same socket?

  499. Deucе
    Sat Mar 02 2024 13:15:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Fix memory leak in sftp_opendir() Found by Coverity.

  500. Deucе
    Fri Mar 01 2024 22:41:16 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Fix array overrun and asprintf() usage, with other warnings. The array overrun crashed Win32, the asprintf() usage imacts glibc and the other warnings are impossible (an exception would have been thrown).

  501. Deucе
    Fri Mar 01 2024 22:10:43 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp.h diff
    src/sftp/sftp_pkt.c diff
    src/sftp/sftp_server.c diff
    Call the lprtinf() callback for all "errors" sent. This includes the "OK" error, and numerous other normal errors, so most of them are logged as LOG_DEBUG.

  502. Deucе
    Fri Mar 01 2024 21:41:34 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    src/sbbs3/sftp.cpp diff
    Fix sftp_resolve_path() to return '/' instead of empty string Also fail early if parsing underruns root.

  503. Deucе
    Fri Mar 01 2024 20:58:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Don't use _fullpath() to resolve paths... This Win32 function behaves differently on Win32 than *nix, and does not do what we want. Instead, copy the important bits from xpdev, and resolve a TODO.

  504. Rob Swindell (on Windows 11)
    Fri Mar 01 2024 19:08:54 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/include/cryptlib.h diff
    Update with new CRYPTLIB_PATCHES value Oops, missed this with the cl32.dll commit.

  505. Rob Swindell (on Windows 11)
    Fri Mar 01 2024 19:06:19 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs3.sln diff
    Add sftp library to sbbs3 MSVC solution I'm not clear on why MSBuild can build the solution without this but the IDE cannot (results in sftp.lib not found, unresolved SFTP symbols, etc.).

  506. Rob Swindell (on Windows 11)
    Fri Mar 01 2024 18:34:43 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    Newest patched Cryptlib 3.4.7 MSVC-build for Win32 <Deuce> Ok, Win32 will need a new cryptlib with these latest patches. Deuceth commandeth, Robeth doeth

  507. Deucе
    Fri Mar 01 2024 16:37:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Fix bug found by Coverity. If a filename failed to be added for a readdir response, it would have just skipped that file and continued with the files around it rather than reporting an error.

  508. Deucе
    Fri Mar 01 2024 13:22:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Remove /vfiles and use a dash instead of a big solidus.

  509. Eric Oulashin
    Fri Mar 01 2024 09:10:55 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: When writing an item with UTF-8 text, check ANSI support before moving the cursor (and this is important if the menu is being used in non-lightbar mode)

  510. Rob Swindell
    Fri Mar 01 2024 13:09:23 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_write_item_check_ANSI_before_gotoxy' into 'master' DDLightbarMenu: When writing an item with UTF-8 text, check ANSI support before moving the cursor (and this is important if the menu is being used in non-lightbar mode) See merge request main/sbbs!419

  511. Deucе
    Fri Mar 01 2024 09:02:59 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Use dir.sname instead of code in the (disabled) /fls tree.

  512. Deucе
    Thu Feb 29 2024 18:53:12 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Whopps, need <stdexcept> to throw that...

  513. Deucе
    Thu Feb 29 2024 17:18:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    src/sbbs3/sftp.cpp diff
    Add support for /vfiles in sftp The /vfiles root uses the configured virtual paths as in the FTP and web servers. These paths should be shorter than the ones used in /files, and also have the benefit of translating slashes so users will not need to type a Big Solidus if they're trying to type long lib or dir names.

  514. Deucе
    Thu Feb 29 2024 15:21:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    When responding to an sftp readdir command, send up to 25 files This should speed up directory listings over higher latency links by approximately 25×. You're welcome nelgin.

  515. Deucе
    Thu Feb 29 2024 12:26:41 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Use Big Solidus instead of Division Slash to replace Solidus

  516. Deucе
    Thu Feb 29 2024 12:05:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/main.cpp diff
    Fix a lock derp in the pervious commit, and another lock break in answer()

  517. Deucе
    Thu Feb 29 2024 11:49:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Unlock ssh_mutex before calling sftps_recv() This should fix the sftp hangs... While FreeBSD will return EDEADLOCK when a mutex would deadlock, Linux will do what I ask and deadlock. Since we're not checking the return value of pthread_mutex_lock(), this would go completely unnoticed on FreeBSD, resulting in the mutex being unlocked early and all sorts of unprotected accesses would happen, potentially doing crazy things. On Linux it just deadlocks, and taking a peek at the thread backtraces makes the problem obvious. So, point to Linux for making life more correct for people who do incorrect things (locking without checking the return value). I'd also like to thank nelgin, for sticking with me on this issue and being my gdb puppet. And really, this commit should be shared by all the contributors who... 𝆺𝅥𝅮𝆺𝅥𝅮𝆹𝅥𝅯𝆹𝅥𝅯

  518. Deucе
    Thu Feb 29 2024 09:52:46 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Allow init_sftp() to safely be called twice. This prevents the case where input_thread() accepts the sftp connection and calls init_sftp(), then answer() does the same thing, clobbering the previous state.

  519. Eric Oulashin
    Thu Feb 29 2024 01:53:20 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: Fix for text & text column alighment issues with UTF-8 text

  520. Rob Swindell
    Thu Feb 29 2024 01:53:20 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_item_write_UTF8_alignment_fix' into 'master' DDLightbarMenu: Fix for text & text column alighment issues with UTF-8 text See merge request main/sbbs!417

  521. Eric Oulashin
    Wed Feb 28 2024 21:34:03 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DD File Lister: Fix for possibly no file description when adding to the batch DL queue. Also, fix for file description screen refresh (off by one column) for extended descriptions.

  522. Rob Swindell
    Thu Feb 29 2024 01:33:03 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_add_batch_DL_desc_fix_and_extd_desc_refresh_fix' into 'master' DD File Lister: Fix for possibly no file description when adding to the batch DL queue. Also, fix for file description screen refresh (off by one column) for extended descriptions. See merge request main/sbbs!418

  523. Deucе
    Wed Feb 28 2024 20:33:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Not all snprintf()s terminate.

  524. Deucе
    Wed Feb 28 2024 20:44:03 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp_server.c diff
    Plug some leaks.

  525. Deucе
    Wed Feb 28 2024 20:49:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp_server.c diff
    Some locking cleanups

  526. Deucе
    Wed Feb 28 2024 20:55:27 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Heh, fix /files/ check.

  527. Deucе
    Wed Feb 28 2024 15:28:40 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Prevent the input thread from closing channel that has a session, but does not yet have a session type. Also, fix what appears to be a fairly blatant memory leak.

  528. Deucе
    Wed Feb 28 2024 11:00:22 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Early-out of the channel type loop for channel errors. If there's an error setting the channel or getting the channel type, give up on the session immediately.

  529. Deucе
    Wed Feb 28 2024 08:51:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Guard against answer() being called before the first channel is created. In this case, just accept whatever we get info on as the "first" one. Likely fixes #728

  530. Rob Swindell (on Debian Linux)
    Tue Feb 27 2024 23:10:14 GMT-0800 (PST)
    Modified Files:
    

    exec/msglist.js diff
    Search forward/backward by subjet without "re:"/"re: " prefix The search seems to be backward by default (at least when listing a sub-board), so should look into that. But at least now you can find replies that include a "re:" prefix easily. Searching by thread should be added too.

  531. Deucе
    Tue Feb 27 2024 20:54:24 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-allow-none-auth-svr.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/main.cpp diff
    Add a patch to allow the server to accept the "none" auth method. If the SSH_ANYAUTH option is set, the server will accept the "none" authentication method, and not even suggest the client send a password or public key. The client must still send a user ID, but we just ignore it completely and don't even log it.

  532. Deucе
    Tue Feb 27 2024 20:26:16 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/startup.h diff
    Add SSH_ANYAUTH option. This blindly accepts whatever authentication the remote offers, but does not log into the BBS, dropping the user at the login prompt instead. Closes #726 You're welcome Keyop.

  533. Deucе
    Tue Feb 27 2024 20:20:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Attempt to fix error nelgin reported with ssh session timeouts

  534. Deucе
    Tue Feb 27 2024 14:56:47 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Document the new ALLOW_SFTP option.

  535. Deucе
    Tue Feb 27 2024 14:55:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Only log that we're waiting for channel type the first time. The other 500 times are implied.

  536. Deucе
    Tue Feb 27 2024 14:52:37 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp_client.c diff
    Fix warnings reported by nelgin. The reason the comparison was changed to <= 0 is to do an explcit check that eliminates negative numbers rather than the implicit ones with the greater-than checks.

  537. Deucе
    Tue Feb 27 2024 14:42:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Name structs to attempt to silence warnings from GCC. It seems that GCC is concerned that we can't create a sftp_dirdescriptor_t or sftp_filedescriptor_t?

  538. Deucе
    Tue Feb 27 2024 12:54:24 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-channel-select-both.patch diff
    3rdp/build/cl-fix-shell-exec-types.patch diff
    3rdp/build/cl-ssh-eof-half-close.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    src/sbbs3/GNUmakefile diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/ctrl/sbbsctrl.bpr diff
    src/sbbs3/js_uifc.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/objects.mk diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/sbbs.vcxproj diff
    src/sbbs3/sbbscon.vcxproj diff
    src/sbbs3/sftp.cpp diff
    src/sbbs3/startup.h diff
    src/sftp/sftp.h diff
    src/sftp/sftp.props diff
    src/sftp/sftp_attr.c diff
    src/sftp/sftp_client.c diff
    src/sftp/sftp_pkt.c diff
    src/sftp/sftp_server.c diff
    src/sftp/sftp_static.h diff
    src/sftp/sftp_str.c diff
    Removed Files:

    src/sbbs3/sftp.h diff
    Add initial support for SFTP

  539. Rob Swindell
    Tue Feb 27 2024 12:54:24 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-channel-select-both.patch diff
    3rdp/build/cl-fix-shell-exec-types.patch diff
    3rdp/build/cl-ssh-eof-half-close.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    src/sbbs3/GNUmakefile diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/ctrl/sbbsctrl.bpr diff
    src/sbbs3/js_uifc.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/objects.mk diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/sbbs.vcxproj diff
    src/sbbs3/sbbscon.vcxproj diff
    src/sbbs3/sftp.cpp diff
    src/sbbs3/startup.h diff
    src/sftp/sftp.h diff
    src/sftp/sftp.props diff
    src/sftp/sftp_attr.c diff
    src/sftp/sftp_client.c diff
    src/sftp/sftp_pkt.c diff
    src/sftp/sftp_server.c diff
    src/sftp/sftp_static.h diff
    src/sftp/sftp_str.c diff
    Removed Files:

    src/sbbs3/sftp.h diff
    Merge branch 'sftp-server' into 'master' Add initial support for SFTP See merge request main/sbbs!415

  540. Eric Oulashin
    Tue Feb 27 2024 09:06:21 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_DCTStuff.js diff
    SlyEdit DCT: Fix so that the quote window bottom border is drawn the full width, not 2 characters short (not sure why this started happening)

  541. Rob Swindell
    Tue Feb 27 2024 12:52:12 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_DCTStuff.js diff
    Merge branch 'SlyEdit_DCT_quote_win_bottom_border_fix' into 'master' SlyEdit DCT: Fix so that the quote window bottom border is drawn the full width, not 2 characters short (not sure why this started happening) See merge request main/sbbs!416

  542. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 23:19:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    Don't send NodeLoggedOn message to any nodes if user isn't being logged-on If user is being kicked off for being on "More than one node at a time", then don't send a message to other any other nodes that the user logged-on successfully (they haven't). Previosuly, it'd send messages to all the lower-numbered nodes that were in-use (but not by the same user). Reported by Nelgin.

  543. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 23:00:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_internal.c diff
    Update docs for js.auto_terminate to clarify: disconnection will trigger too User disconnection will trigger auto-terminate (eventually) as well. But only in the terminal server.

  544. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 23:06:44 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    Change "On two nodes" to "On more than one node", since it's possible it's > 2

  545. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 20:00:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_global.c diff
    Fix commit 78dc9470 - wasn't complete For some reason, I committed test code that commented-out the actual call to js_IsTerminated() which avoided the unnecessary error log message. I guess I was testing to confirm the change actually worked. <shrug>

  546. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 22:39:34 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    sbbs_t::incom() should return NOINP immediately if/when socket disconnected JS console.inkey() and friends use this as the underlying function to get input from the TCP socket. This might address issue #725 Hoping Nelgin will let us know.

  547. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 19:47:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logout.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/sbbs.h diff
    Don't send NodeLoggedOff msgs to other nodes if kicked before logon completed Address this problem report: <nelgin> Right but I'm getting a lot of "logged off" without ever having a "logged on" <nelgin> Node 3: Keyop logged off 02/26/24 18:35:45 <nelgin> Node 5: Keyop logged off 02/26/24 18:36:39 <nelgin> There was never a login, so there can't be a logoff. <nelgin> That would break the time-warp continium. <nelgin> time-space whatever :) This could happen when non-G-exempt user was kicked before logon completed due to already being logged onto another node. This change should fix that.

  548. Rob Swindell (on Debian Linux)
    Mon Feb 26 2024 17:51:45 GMT-0800 (PST)
    Modified Files:
    

    exec/archive.js diff
    Insure that archive content listing starts a new line ... when run from the BBS (terminal server)

  549. Rob Swindell (on Debian Linux)
    Mon Feb 26 2024 17:52:22 GMT-0800 (PST)
    Modified Files:
    

    exec/load/avatar_lib.js diff
    Use the common ini formatting for writing avatar data (just a cosmetic change)

  550. Rob Swindell (on Windows 11)
    Sun Feb 25 2024 18:04:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logfile.cpp diff
    Don't log errno value and description as part of ERROR log msg, when 0 If errno is 0, it's definitely no proividing anything of value here. Of course, sometimes errno might be non-zero and still be unrelated to the error message. <shrug> For Nelgin: !ERROR 0 (Success) in exec.cpp line 644 (js_execfile) compiling "something.js" access=0 <nelgin> I don't quite get why a successful execution is logged as an error

  551. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 20:33:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    Increase ini key values to max length Resolve build warning about unused var

  552. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 20:30:07 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Don't log an error if spy socket write return EPIPE (expected) Also, resove a new gcc warning about signed/unsigned compares.

  553. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 20:17:34 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    Normalize fullwidth chars to 2-chars (ASCII char, followed by space)

  554. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 20:18:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/umonitor/spyon.c diff
    src/sbbs3/umonitor/spyon.h diff
    src/sbbs3/umonitor/umonitor.c diff
    Support UTF-8 and PETSCII terminal spying Converts UTF-8 output to CP437 equivalent (cterm doesn't yet support UTF-8). Fixes issue #717 (more or less). The terminal dimensions are also read from the node*/terminal.ini file, but aren't applied to the cterm runtime (though maybe they can/should be, probably requires a cterm re-init).

  555. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 17:31:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    src/sbbs3/ctrl/SpyFormUnit.h diff
    Telnet commands haven't been sent to node-spy ring buffers for years now ... so no need to parse/strip them here.

  556. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 14:54:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Log a warning if failed to write to spy ring buffer

  557. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 14:54:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    Increase size of spy ring buffer from 10K to 100K bytes This eliviates the issue of partial/corrupted UTF-8 sequences when spying on a node serving a UTF-8 terminal.

  558. Eric Oulashin
    Sat Feb 24 2024 13:11:03 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_DCTStuff.js diff
    SlyEdit DCT: Use Math.floor() to create an actual number instead of toFixed(0) like I was in some very old parts of the code. This fixes some cursor position calculations (for the current time, particularly).

  559. Rob Swindell
    Sat Feb 24 2024 13:11:03 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_DCTStuff.js diff
    Merge branch 'SlyEdit_DCT_Math_floor_instead_of_toFixed' into 'master' SlyEdit DCT: Use Math.floor() to create an actual number instead of toFixed(0) like I was in some very old parts of the code. This fixes some cursor position calculations (for the current time, particularly). See merge request main/sbbs!414

  560. Deucе
    Sat Feb 24 2024 11:41:33 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Latest SDL2 only supports macOS 10.7 and above.

  561. Deucе
    Sat Feb 24 2024 10:15:55 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    Re-generate patch

  562. Deucе
    Sat Feb 24 2024 08:45:30 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    src/xpdev/dirwrap.h diff
    Looks like that worked... intptr_t the rest.

  563. Deucе
    Sat Feb 24 2024 08:39:32 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Fix glob() for Win64 _fintfirst() is declared in the Mingw-w64 headers as an intptr_t, which tracks. Can't find _findfirst on MSDN, so that's good enough for me... let's see what the pipeline says.

  564. Deucе
    Sat Feb 24 2024 08:32:32 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Remove the mingw32 builds mingw32 has been dead for years, and is missing huge swaths of the Windows APIs. strerror_s() was the straw that broke the camels back here, but there's a lot of hackery for it. I'm not going to go through and actually remove the build support yet since I may want to do the 1.2 SyncTERM release with it (though likely not), but it's not long for this world.

  565. Deucе
    Sat Feb 24 2024 07:07:21 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    Don't imply the callbacks need to be protected by the mutex.

  566. Deucе
    Sat Feb 24 2024 07:07:21 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    Expand comment

  567. Nigel Reed
    Sat Feb 24 2024 02:33:07 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Added NEW-ENVIRON. Note the variable is NEW_ENVIRON

  568. Rob Swindell
    Sat Feb 24 2024 02:33:07 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Merge branch 'add_new_environ_to_telnet_lib' into 'master' Added NEW-ENVIRON. Note the variable is NEW_ENVIRON See merge request main/sbbs!413

  569. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 02:30:22 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Borland C needs the strlcpy definition too The definition of vsnprintf as _vsnprintf didn't seem to hurt the build (as well, for Borland)

  570. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 02:05:19 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Insure all builds of safe_strerror() write the string to the passed buf The GNU_SOURCE build of this function was (sometimes?) just returning the string and not actually copying it to the passed buf. This is consistent with the GNU manpage on strerror_r(): "This may be either a pointer to a string that the function stores in buf ..." but was inconsistent with all the other build types of this function. Also updated to use strlcpy and write the problematic error number to the default string (if unknown).

  571. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 01:13:21 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpmap.c diff
    Remove new/unused variable: of

  572. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 01:14:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_socket.c diff
    src/sbbs3/js_socket.h diff
    Report getaddrinfo() failure result in Socket.error and error_str (not errno) As Nelgin pointed out, a Socket.connect() failure for reasons of address/host lookup failure would report a stale/nonsense Socket.error/error_str value. This change required us to query/store the socket API/getaddrinfo error string at the time of failure (for the Socket.error_str property value) rather than converting from number to string at the time the property is read. This does mean that sometimes Socket.error is a errno value and sometimes its a getaddrinfo (EAI_*) error value. Since the EAI_* values are negative, it should be obvious which is which.

  573. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 00:29:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/NodeFormUnit.cpp diff
    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    src/sbbs3/ctrl/SpyFormUnit.h diff
    Support UTF-8 translation to CP437 and non 80x25 terminals Reads the new(ish) node*/terminal.ini file when it's changed to determine the connected-client's terminal type/dimensions. Now reports the terminal details in the spy form title/caption and if it's UTF-8, does a real-time translation to CP437 (since F. Piette's terminal lib only supports CP437). There is a bug here where if the data read from the RingBuffer is a partial UTF-8 sequence, it isn't decoded correctly. Fix that later (?) if it actually bugs anyone. There's no PETSCII conversion/support added here. I expect to someday replace this entirely (likely with something that uses cterm), so didn't want to invest too much time into this. But at least now spying on non-traditional ANSI-BBS clients isn't so terrible to look at.

  574. Deuce
    Fri Feb 23 2024 21:57:58 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/term.c diff
    We need to call uifcbail() after calling show_bbslist()

  575. Deuce
    Fri Feb 23 2024 18:27:29 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    src/syncterm/ssh.c diff
    Fix some especially silly Coverity "issues" These are regarding initializing variables at the same time as the mutex. Harmless.

  576. Nigel Reed
    Fri Feb 23 2024 11:35:54 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Added MSP, MXP, MSDP and a few other protocols

  577. Rob Swindell
    Fri Feb 23 2024 11:35:54 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Merge branch 'add_mud_protocols_to_telnet_lib' into 'master' Added MSP, MXP, MSDP and a few other protocols See merge request main/sbbs!412

  578. Deuce
    Fri Feb 23 2024 06:43:47 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    We don't need headerBufferUsed... it's already tracked readHeaderFixed() already assumes the same header pointer will be passed in next call if the read is incomplete.

  579. Deuce
    Fri Feb 23 2024 06:31:30 GMT-0800 (PST)
    Modified Files:
    

    exec/irc.js diff
    Don't just drop out the bottom of the function on timeout. If we don't get one of the commands we're waiting for, close the socket and exit instead of returning with the appearance of having received one.

  580. Rob Swindell (on Debian Linux)
    Fri Feb 23 2024 00:39:41 GMT-0800 (PST)
    Modified Files:
    

    exec/irc.js diff
    Don't hang if/when nick is rejected Change wait_for() to no longer loop indefinitely. If nick is rejected (e.g. begins with number), prepend '_' to it. Increment version number to 1.62 Fixes issue #723

  581. Rob Swindell (on Debian Linux)
    Fri Feb 23 2024 00:12:51 GMT-0800 (PST)
    Modified Files:
    

    exec/privatemsg.js diff
    exec/sbbsimsg.js diff
    Some localization support (e.g. 'Q'uit translation to another language) What I haven't really worked out is what if the translated word mnemonic is a duplicate of another, valid command key.

  582. Deucе
    Thu Feb 22 2024 20:57:09 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-ssh-sbbs-id-string.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Add "(SBBS)" to the SSH ID string. We've patched this thing enough to have a different identifier.

  583. Deucе
    Thu Feb 22 2024 19:04:40 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-do-debug.patch diff
    Make debug a bit less noisy.

  584. Deucе
    Thu Feb 22 2024 19:04:59 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-make-channels-work.patch diff
    Instead of keying on the packet being received, key on buffer empty. This should work exactly the same, but is more correct. It's possible that in the future, packet data could be added to the buffer after receiveBufPos, and we could know that no more is required.

  585. Deucе
    Thu Feb 22 2024 19:06:32 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Catch when cryptFlushData() says the channel is closed. Also, fix an unlikely race condition. This, combined with the cryptlib patches, fixes various weird SSH hangs resulting from partial reads of the SSH packet headers... a rare event that's very hard to trigger. Special thanks to MeaTLoTioN for reporting this, and running a BBS that manages to trigger it reliably. Check out The Quantum Wormhole and say thanks!

  586. Deucе
    Thu Feb 22 2024 19:09:46 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Read SSH packet headers into a fixed buffer in the session info Previously, it was read into a local variable, and in the case of a partial read, everything would go to hell and SSH would hang. "Luckily" this was very hard to trigger.

  587. Deucе
    Thu Feb 22 2024 19:40:28 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    sftp_channel is always -1 here.

  588. Deucе
    Thu Feb 22 2024 19:41:05 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-ssh-service-type-for-channel.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    When the server allows us to open a new channel, use the right type. By default, Cryptlib uses the type of whatever channel happens to be currently selected, so if the server has sent some data, that will be shell. Instead, look up the new channel and use that type info. Ugh.

  589. Deucе
    Thu Feb 22 2024 07:03:33 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Keep pointers to dll_handle around to solence Coverity issues.

  590. Deucе
    Thu Feb 22 2024 06:55:39 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/datewrap.c diff
    Attempt to silence Coverity warnings about time32_t.

  591. Deucе
    Thu Feb 22 2024 06:31:37 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Use default instead of enum value in warning suppression. This will hopefully keep both Coverity and compilers happy.

  592. Deucе
    Thu Feb 22 2024 06:37:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Remove do-nothings that Coverity complains do nothing.

  593. Deucе
    Thu Feb 22 2024 06:46:07 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Avoid pasing NULL to strto*() functions. Whill this is perfectly legal and is not a problem, Coverity complains.

  594. Deucе
    Thu Feb 22 2024 06:46:44 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Use SAFECOPY() for no reason. Since old is a strdup() of list->comment, it's known that it will fit, but Coverity doesn't know that.

  595. Deucе
    Thu Feb 22 2024 06:49:40 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Remove need_copy variable when it won't be used. Fixes Coverity issue.

  596. Deucе
    Thu Feb 22 2024 06:03:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/menu.c diff
    src/syncterm/term.c diff
    src/syncterm/term.h diff
    Use shared code for sending login information. The option from the menu (ALT-Z/CTRL-S) was copy/pasted years ago and never updated while the keyboard shortcut (ALT-L) was updated quite a bit. This extracts the ALT-L code into a function and calls it from the menu.

  597. Deucе
    Thu Feb 22 2024 05:35:58 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Fix some weirdness around window sizing. This should fix the recent issue when a larger or smaller version is painted inside the window after resize, as well as fix ALT-→ when the current size is not an integer multiple.

  598. Deucе
    Wed Feb 21 2024 12:58:36 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Lower flush count to 3. This is my happy place on the desktop system running xfce4... any higher, and it interferes with how I manage my windows. Hopefully, this value convers the initialization portion perfectly on all systems (hah!).

  599. Deuce
    Wed Feb 21 2024 12:14:50 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Count flushes to disable resize hack. Instead of strictly using "first resize", also count flushes and assume the hack isn't needed after five. Experimentation on my ChromeBook shows 3 to be sufficient, so I'm sing five for now. Odds are that this will still mess with tiling WMs, but I don't use one, so I don't mind yet. I expect this will be better, but likely still not great.

  600. Deucе
    Wed Feb 21 2024 10:53:17 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Always base scaling on size, and alwayse resize xim. Fixes issue with possible corrupt display when "weird" scaling changes occured.

  601. Deucе
    Wed Feb 21 2024 09:57:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Bugfix and more paranoia in ini*SString() functions. Bugfis: Be sure to terminate value if returning deflt. Paranoia: Terminate value if iniGetString() returns NULL I think the only way to trigger the paranoia is to pass NULL as the default when reading a key that's not present.

  602. Deuce
    Wed Feb 21 2024 09:29:46 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Only count it as the "first resize" if it's not from SendEvent()

  603. Deucе
    Wed Feb 21 2024 09:13:19 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    First attempt to fix "black bars" startup issue. The first time we receive a MapNotify or ConfigureNotify that sets the width and height, resize the window instead of accepting the current window size.

  604. Deucе
    Wed Feb 21 2024 07:46:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Pass user_t as pointer. Silly to pass a 728-byte object as a parameter.

  605. Deucе
    Wed Feb 21 2024 07:23:07 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/conn.c diff
    src/syncterm/conn.h diff
    It appears that in Win64, SOCKET is a long long. No more using the standard int type and having it work. Thanks Microsoft.

  606. Deucе
    Wed Feb 21 2024 07:20:09 GMT-0800 (PST)
    Modified Files:
    

    src/syncdraw/load.c diff
    Remove apparently unused errno declaration.

  607. Deucе
    Wed Feb 21 2024 07:17:25 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    On Win64, COM_HANDLE is bigger than a long. Use strtoll() to parse number (except when _BORLANDC_ of course)

  608. Deucе
    Wed Feb 21 2024 07:08:45 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpmap.c diff
    On Win64, HFILE and HANDLE are quite different, use CreateFile() OpenFile() returns HFILE and is sus, CreateFile() is more complex, but returns a HANDLE (and is what MSDN suggests I use).

  609. Deucе
    Wed Feb 21 2024 06:36:18 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/sockwrap.c diff
    Fix warning on Win64 build

  610. Deucе
    Wed Feb 21 2024 06:30:09 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Cast away warning... This is why I returned ret. :D

  611. Deucе
    Wed Feb 21 2024 06:06:12 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    More input thread cleanup. There was an errant lock in there.

  612. Deucе
    Wed Feb 21 2024 05:42:40 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    And now Coverity gets into the false warning game. Fix incorrect Coverity issue that speculates this may return fval.

  613. Rob Swindell (on Debian Linux)
    Tue Feb 20 2024 23:54:56 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Allow UTF-8 sequences in message subjects (passing K_UTF8 to getstr) This was the behavior for all string input in SBBS until recently (Commit 55ccda6294f82506), with this change, an exception is being made for message subjects, but the vast majority of other string input is still limited to single-byte (i.e. US-ASCII or CP437) characters. This should fix issue #720

  614. Deuce
    Tue Feb 20 2024 21:13:40 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Use max when we have it, only restore size/scaling in fullscreen mode

  615. Deucе
    Tue Feb 20 2024 20:14:35 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    src/syncterm/COMPILING diff
    Unlock vstatlock for map_window()

  616. Deucе
    Tue Feb 20 2024 19:21:59 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/Common.gmake diff
    Find libarchive in 3rdp

  617. Deucе
    Tue Feb 20 2024 19:03:48 GMT-0800 (PST)
    Added Files:
    

    3rdp/win64.release/sdl2/bin/SDL2.dll diff
    3rdp/win64.release/sdl2/bin/sdl2-config diff
    3rdp/win64.release/sdl2/include/SDL2/SDL.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_assert.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_atomic.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_audio.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_bits.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_blendmode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_clipboard.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_config.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_cpuinfo.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_egl.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_endian.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_error.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_events.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_filesystem.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_gamecontroller.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_gesture.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_guid.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_haptic.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_hidapi.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_hints.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_joystick.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_keyboard.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_keycode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_loadso.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_locale.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_log.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_main.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_messagebox.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_metal.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_misc.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_mouse.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_mutex.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_name.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengl.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengl_glext.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2ext.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2platform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_khrplatform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_pixels.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_platform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_power.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_quit.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_rect.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_render.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_revision.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_rwops.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_scancode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_sensor.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_shape.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_stdinc.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_surface.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_system.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_syswm.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_assert.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_common.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_compare.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_crc32.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_font.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_fuzzer.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_harness.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_images.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_log.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_md5.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_memory.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_random.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_thread.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_timer.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_touch.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_types.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_version.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_video.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_vulkan.h diff
    3rdp/win64.release/sdl2/include/SDL2/begin_code.h diff
    3rdp/win64.release/sdl2/include/SDL2/close_code.h diff
    3rdp/win64.release/sdl2/lib/cmake/SDL2/sdl2-config-version.cmake diff
    3rdp/win64.release/sdl2/lib/cmake/SDL2/sdl2-config.cmake diff
    3rdp/win64.release/sdl2/lib/libSDL2.a diff
    3rdp/win64.release/sdl2/lib/libSDL2.dll.a diff
    3rdp/win64.release/sdl2/lib/libSDL2.la diff
    3rdp/win64.release/sdl2/lib/libSDL2_test.a diff
    3rdp/win64.release/sdl2/lib/libSDL2_test.la diff
    3rdp/win64.release/sdl2/lib/libSDL2main.a diff
    3rdp/win64.release/sdl2/lib/libSDL2main.la diff
    3rdp/win64.release/sdl2/lib/pkgconfig/sdl2.pc diff
    3rdp/win64.release/sdl2/share/aclocal/sdl2.m4 diff
    Add SDL2 for Win64

  618. Deucе
    Tue Feb 20 2024 19:00:02 GMT-0800 (PST)
    Added Files:
    

    3rdp/win64.release/libarchive/bin/archive.dll diff
    3rdp/win64.release/libarchive/include/archive.h diff
    3rdp/win64.release/libarchive/include/archive_entry.h diff
    3rdp/win64.release/libarchive/lib/archive.lib diff
    3rdp/win64.release/libarchive/lib/archive_static.lib diff
    Add win64 libarchive

  619. Deucе
    Tue Feb 20 2024 18:43:27 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-mb-w-conv-warnings.patch diff
    src/sbbs3/GNUmakefile diff
    src/sexpots/GNUmakefile diff
    src/xpdev/strwrap.h diff
    Various fixes for 64-bit support

  620. Deucе
    Tue Feb 20 2024 18:34:56 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-add-win64.patch diff
    3rdp/build/cl-fix-mb-w-conv-warnings.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    src/build/Common.gmake diff
    src/conio/Common.gmake diff
    src/conio/GNUmakefile diff
    src/syncterm/GNUmakefile diff
    src/xpdev/Common.gmake diff
    src/xpdev/GNUmakefile diff
    Add support for building 64-bit binaries using mingw32-w64

  621. Deucе
    Tue Feb 20 2024 16:37:41 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    mingw32-w64 does not include ultoa()

  622. Deucе
    Tue Feb 20 2024 16:35:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Unhack mingw32 hack for mingw32-w64

  623. Deucе
    Tue Feb 20 2024 16:24:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add mingw32-w64 build

  624. Deucе
    Tue Feb 20 2024 16:19:34 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Fix (incorrect) warning from gcc12

  625. Deucе
    Tue Feb 20 2024 16:05:33 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Finish fixing ini*SString(). The first fix was to copy the right value, the second fix was to ensure zero-length strings are terminated.

  626. Deucе
    Tue Feb 20 2024 15:56:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Partial fix of iniGetSString() and iniReadSString()

  627. Deucе
    Tue Feb 20 2024 15:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio_win32.c diff
    src/conio/win32cio.c diff
    src/syncterm/syncterm.c diff
    src/xpdev/dirwrap.c diff
    src/xpdev/sockwrap.c diff
    Be explicit in more ANSI/Wide functions. Also, fix macro name collision with GetDiskFreeSpaceEx

  628. Deucе
    Tue Feb 20 2024 15:11:02 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Fix mingw32 some more.

  629. Deucе
    Tue Feb 20 2024 15:01:19 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Fix inverted logic for Mingw32.

  630. Deucе
    Tue Feb 20 2024 14:43:10 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Whoops, these are for all !_WIN32 and some _WIN32

  631. Deucе
    Tue Feb 20 2024 14:31:28 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Some fixups to allow mingw-w64 to be used where mingw32 is currently working.

  632. Deucе
    Tue Feb 20 2024 05:56:32 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move an sftp_state check inside mutex to silence Coverity. There's still outstanding issues in Coverity around sftp_state and sftp_channel that need some deep thought, but this one is trivial.

  633. Deucе
    Tue Feb 20 2024 05:07:52 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    Add iniGetSString() that takes the size of the buffer

  634. Deucе
    Tue Feb 20 2024 05:10:37 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Use new iniGetSString() for syncterm.lst Prevents buffer overlow with manually edited or corrupted files.

  635. Deucе
    Tue Feb 20 2024 05:21:35 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    Add iniReadSString() as well.

  636. Deucе
    Tue Feb 20 2024 05:21:52 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/fonts.c diff
    src/syncterm/syncterm.c diff
    And use iniReadSString() where appropriate in SyncTERM.

  637. Deucе
    Mon Feb 19 2024 16:26:35 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Call map_window() to update size hints when resizing the window. This way, WMs that enforce aspect ratio etc, won't get potentially block the update.

  638. Deucе
    Mon Feb 19 2024 10:59:31 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    src/syncterm/ssh.c diff
    Fix SSH fingerprinting. A hex nybble is not 8 bits, and C strings need to be termianted.

  639. Deucе
    Mon Feb 19 2024 10:11:12 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Likely fix a bunch of Coverity warnings. This is a very crazy lock/unlock pattern... an extra assignment makes it easier to follow the logic.

  640. Deucе
    Mon Feb 19 2024 09:59:56 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Expand ssh_mutex over the flushes. This should also resolve a conspiracy Coverity has about two input threads running at the same time.

  641. Deucе
    Mon Feb 19 2024 08:08:49 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Win32 API calls are __stdcall

  642. Deucе
    Mon Feb 19 2024 07:47:45 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    More fencepost errors in the other direction... This is likely what make the old broken values appear to work.

  643. Deucе
    Mon Feb 19 2024 06:50:08 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    There is something horribly wrong with what sscanf(x, "%2hhx", &cptr) does when compiled with mingw32. Use "anything else" to convert hex to char.

  644. Deucе
    Mon Feb 19 2024 06:06:45 GMT-0800 (PST)
    Modified Files:
    

    src/conio/Common.gmake diff
    Use NEED_BITMAP for no fonts, not X11 | SDL Fixes crash when built without X11 or SDL, but with GDI (not default)

  645. Rob Swindell (on Windows 11)
    Sun Feb 18 2024 23:30:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    src/sbbs3/scfg/scfgxtrn.c diff
    Display warning dialog when changing cmdshell or xtrn editor's internal codes Changing a command shell or an external editor's internal code will revert the preference of any user's that have selected that shell or editor as their default/preference. A sysop may not realize this, so warn them with lots of detail in the help text if they need it. See issue #721 for details. Also updated the help text for command shell internal codes since it still only mentioned Baja/.bin modules.

  646. Deucе
    Sun Feb 18 2024 18:11:11 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdlfuncs.c diff
    src/conio/win32gdi.c diff
    Some cleanup, make SDL hyper turbo DPI aware as well.

  647. Deucе
    Sun Feb 18 2024 17:38:24 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Fix doorway mode. CSI=255h was not entering doorway mode anymore.

  648. Deucе
    Sun Feb 18 2024 14:43:09 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Fix pervasive fencepost error calculating width and height. Basically everywhere was off by one. Also, fix the get dpi size thingie to correct for window decorations. We never actually use the result of this, but Windows might for outline dragging or something... you can never know.

  649. Rob Swindell (on Windows 11)
    Sun Feb 18 2024 13:01:35 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbsecho.ini diff
    Update lha command-line to match current *nix and Windows releases of lha The extraction destination directory must be specified with the 'w=' option. As Fernando Toledo (@Ragnarok) pointed out: https://gitlab.synchro.net/main/sbbs/-/issues/524#note_4867

  650. Deucе
    Sun Feb 18 2024 12:14:01 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    AdjustWindowRect() can't be used for "High DPI" So do more terrible hackery.

  651. Deucе
    Sun Feb 18 2024 09:46:41 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/syncterm.rc diff
    Use the last field of the version for release type

  652. Deucе
    Sun Feb 18 2024 09:44:44 GMT-0800 (PST)
    Added Files:
    

    src/syncterm/syncterm.rc diff
    Modified Files:

    src/syncterm/GNUmakefile diff
    Add version info resource.

  653. Deucе
    Sun Feb 18 2024 08:21:51 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.rc diff
    src/conio/conio.props diff
    src/conio/conio_gdi.props diff
    src/conio/conio_sdl.props diff
    None of that worked, use #ifdef __GNUC__ on the manifest. This means ciolib utilities built with MSVC won't have the right manifest information, but the documentation is terrible and I can't figure it out.

  654. Deucе
    Sun Feb 18 2024 08:10:17 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.props diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    That didn't work, shotgun it into the props files.

  655. Deucе
    Sun Feb 18 2024 08:02:42 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    Move no manifest from lib to rc. Looks like this was where it messed up first.

  656. Deucе
    Sun Feb 18 2024 07:52:34 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    Slap some more tags in interesting-looking places.

  657. Deucе
    Sun Feb 18 2024 07:44:33 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.props diff
    src/conio/conio_gdi.props diff
    src/conio/conio_sdl.props diff
    Hack up some props.

  658. Deucе
    Sun Feb 18 2024 07:30:05 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.manifest diff
    Apparently the MSVC builds also specify trustInfo in manifest. It appears they just set the default values, so try that out.

  659. Deucе
    Sun Feb 18 2024 07:12:37 GMT-0800 (PST)
    Added Files:
    

    src/conio/ciolib.manifest diff
    Modified Files:

    src/conio/GNUmakefile diff
    src/conio/ciolib.rc diff
    src/conio/win32gdi.c diff
    src/syncterm/GNUmakefile diff
    As it turns out, setting high DPI awareness in the process fails. Presumably, "something" is setting it earlier so it can't be set again because reasons. To work around this, add a manifest to ciolib library that asserts the binary is DPI aware and requests Windows not do GDI scaling. Not sure if manifest .o files in a lib are linked in by things, but SyncTERM pulls the .o out and explicitly links it, so this should fix SyncTERM at least.

  660. Deucе
    Sun Feb 18 2024 05:37:16 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Support the third (now preferred) method of setting DPI awareness. We will now try SetProcessDpiAwarenessContext() first, then SetProcessDpiAwareness() second, and finally SetProcessDPIAware() [sic]. Also, "handle" the WM_DPICHANGED event. This may solve problems initializing SyncTERM on systems with two displays that have different DPI settings.

  661. Eric Oulashin
    Sat Feb 17 2024 21:50:33 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    SlyEdit: Update for the isPrintableChar() function to allow more for UTF-8 (it's a simplistic function). Also updated the version number in slyedcfg.js.

  662. Rob Swindell
    Sat Feb 17 2024 22:00:32 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    Merge branch 'slyedit_isPrintableChar_UTF8' into 'master' SlyEdit: Update for the isPrintableChar() function to allow more for UTF-8 (it's a simplistic function). Also updated the version number in slyedcfg.js. See merge request main/sbbs!411

  663. Deucе
    Sat Feb 17 2024 18:18:27 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/CHANGES diff
    src/syncterm/menu.c diff
    src/syncterm/term.c diff
    Show mouse state in status bar, add ALT-O to toggle remote mouse. This allows easy copy/paste without scrollback hacks on BBSs that insist on taking over the mouse just so you can move the mouse and click a character rather than press one key because it's 3l337..

  664. Deucе
    Sat Feb 17 2024 12:16:12 GMT-0800 (PST)
    Modified Files:
    

    xtrn/sbj/GNUmakefile diff
    Depend on .o file and link it. When using $^, all the auto-dependencies are included in the link command-line, which includes sbj.c and all the .h files, causing the link to fail if dependencies exist.

  665. Deucе
    Sat Feb 17 2024 12:01:56 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move sftp_state inside ssh_mutex. This won't matter now since only one thread ever touches it, but when cool stuff happens, it could.

  666. Deucе
    Sat Feb 17 2024 11:45:14 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move sftp_channel under the ssh_mutex completely.

  667. Deucе
    Sat Feb 17 2024 11:37:44 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Remove crufty code that effectively never does anything.

  668. Deucе
    Sat Feb 17 2024 11:26:39 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    src/syncterm/syncterm.c diff
    src/syncterm/syncterm.h diff
    src/syncterm/term.c diff
    Store scrollback position before clearing screen at end. This allows ALT-B from dialing directory to show the last seen thing, not the extra blank screen added to the end. Doesn't fix anything, but a huge QoL improvement for people who use ALT-B after disconnecting.

  669. Deucе
    Sat Feb 17 2024 10:35:47 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdl_con.c diff
    For SDL mode, ensure rect matches vstat as well.

  670. Deucе
    Sat Feb 17 2024 10:17:58 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Ensure the rectangle we're scaling to the screen matches the screen size.

  671. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 22:30:01 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    3rdp/win32.release/cryptlib/include/cryptlib.h diff
    Latest patched cryptlib v3.4.7 for Win32 built with MSVC

  672. Deucе
    Fri Feb 16 2024 21:36:11 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Make ALT-F4 map to CIO_KEY_QUIT in GDI mode. Fixes issue 124 on Sourceforge.

  673. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 18:14:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Log the auto-detected character set (e.g. UTF-8, CP437, PETSCII, or US-ASCII)

  674. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 18:15:30 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    New console property: unicode_zerowidth (either 0 or 1) The column-width of UNICODE 'zero-width' character is now autodetected. This property allows one to use/change this autodetected width (normally 0 or 1).

  675. Eric Oulashin
    Fri Feb 16 2024 13:00:56 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: When checking the user's external editor settings, make sure they actually have an external editor configured, or else DDMsgReader will error out.

  676. Rob Swindell
    Fri Feb 16 2024 13:10:59 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_check_settings_fix' into 'master' DDMsgReader: When checking the user's external editor settings, make sure they actually have an external editor configured, or else DDMsgReader will error out. See merge request main/sbbs!410

  677. Eric Oulashin
    Fri Feb 16 2024 12:06:14 GMT-0800 (PST)
    Modified Files:
    

    ctrl/xtrn.ini diff
    xtrn.ini: For SlyEdit, the "Support UTF-8 Encoding" is now Yes. Also, updated the ARS to "ANSI AND COLS 80"

  678. Rob Swindell
    Fri Feb 16 2024 12:06:14 GMT-0800 (PST)
    Modified Files:
    

    ctrl/xtrn.ini diff
    Merge branch 'slyedit_settings_UTF8_supported' into 'master' xtrn.ini: For SlyEdit, the "Support UTF-8 Encoding" is now Yes. Also, updated the ARS to "ANSI AND COLS 80" See merge request main/sbbs!408

  679. Eric Oulashin
    Fri Feb 16 2024 11:00:32 GMT-0800 (PST)
    Added Files:
    

    ctrl/slyedit_readme.txt diff
    Modified Files:

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: Header display update for UTF-8. Added 'add graphic char' to DCT menu.

  680. Rob Swindell
    Fri Feb 16 2024 11:00:32 GMT-0800 (PST)
    Added Files:
    

    ctrl/slyedit_readme.txt diff
    Modified Files:

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_UTF8_header_items' into 'master' SlyEdit: Header display update for UTF-8. Added 'add graphic char' to DCT menu. See merge request main/sbbs!407

  681. Deucе
    Fri Feb 16 2024 10:21:37 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Info.plist diff
    Add magic value that may allow using internal GPU on macOS.

  682. Deucе
    Fri Feb 16 2024 10:00:23 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Lower timeouts when closing SSH session. Reduces the time after a forced hangup that you need to wait before returning to the main menu.

AuthorCommitsLatest
Nigel Reed6Tue Jul 23 2024 15:11:31 GMT-0700 (PDT)
Rob Swindell369Tue Jul 23 2024 15:11:31 GMT-0700 (PDT)
Eric Oulashin30Sun Jun 30 2024 16:20:20 GMT-0700 (PDT)
Deucе266Wed May 15 2024 20:33:30 GMT-0700 (PDT)
echicken4Thu May 02 2024 20:25:36 GMT-0700 (PDT)
Deuce7Fri Feb 23 2024 21:57:58 GMT-0800 (PST)

For older commits (in CVS), click here

Dynamically generated in 376 milliseconds