Synchronet Git Commit Log

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for reading colors from the theme file. Also, removed debug
function from dd_lightbar_menu.js

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_read_theme_colors_fix' into 'master'

DDMsgReader: Fix for reading colors from the theme file. Also, removed debug
function from dd_lightbar_menu.js

See merge request main/sbbs!251

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: (Hopefully) improved display of certain ANSI messages

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_lister_ansi_improvement' into 'master'

DDMsgReader: (Hopefully) improved display of certain ANSI messages

See merge request main/sbbs!250

Modified Files:


src/sbbs3/mqtt.c
diff

Convert spaces to underscores in MQTT topics 

e.g. "action/hack/smtp login" -> "smtp_login", best practices and all.

Modified Files:


src/sbbs3/websrvr.c
diff

Fix MQTT-published action/login message for web server users

e.g. 20230130T171211-480	0	<unknown user>	76.89.231.66	<no
name>

the user number name actually *are* known at this stage

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Remember the Security Level selection upon exit/reenter security levels

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Don't MQTT-publish the download of temp files

Modified Files:


src/sbbs3/mqtt.c
diff

Lowercase the protocol name in action/login and logout topics

Modified Files:


src/sbbs3/logfile.cpp
diff

Lowercase the topics in hack and spam action messages

Modified Files:


install/systemd/sbbs.service
diff

Add sudo to example command-lines (you have systemd, you probably have sudo)

Add some handy tips too (querying status, monitoring log output)

Modified Files:


text/password.can
diff

Add a couple of overly-used passwords

Modified Files:


exec/chksetup.js
diff

Check for and warn about passwords that match user's name, alias, or handle

This shouldn't be possible during new user sign-up, but there have been ways
to curtail checks and generate user accounts with login names and passwords
that are the same sequence of characters, unfortunately.

Modified Files:


exec/newuser.js
diff

Don't allow QWKnet accounts with login IDs that match the account password

Don't give QWKnet accounts the 'M' (email messages per day) exemption by
default as this has been abused by email spammers.

These are security/anti-spam improvements.

Modified Files:


src/sbbs3/mqtt.c
diff

Fix accidental static storage for login/logout functions

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/server.h
diff

src/sbbs3/services.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/xtrn_sec.cpp
diff

The 3rd great MQTT data scheme update (sorry Nelgin)

- Most published messages (besides log entries) have a timestamp (in ISO8601
format) prepended and tab-separated
- The order and number of elements in client messages (list and activities) has
been updated, now includes user number
- Server client lists are now published to .../SERVER/client/list
- Server client activities (connect, disconnect, update) are now published to
.../SERVER/client/action/#
- Server client count is now published to .../SERVER/client (with the maximum
client count, if applicable)
- Server states are now just represented by name (e.g. initializing, ready,
stopping, stopped) and not number
- BBS errors are logged to sbbs/BBS/action/error/LEVEL (where LEVEL is the log
level name, e.g. "critical" or "error')
- All server hack-attempts, SPAM attempts, logins, logouts, uploads, downloads,
are published to sbbs/BBS/action/ACTION/*
- Chat pages are published to sbbs/BBS/action/page/node/#
- New users (on the terminal server) are published to sbbs/BBS/action/newuser
- Posted messages and executed external programs (on the terminal server) are
published to sbbs/BBS/action/ACTION/CODE topic
- The event thread started/stopped status is published to .../SERVER/event

Yeah, the wiki will get updated soon to reflect/document all these changes

Modified Files:


src/sbbs3/inkey.cpp
diff

Don't do the DEL/Backspace swap for PETSCII terminals

This was a bug if the user had set their terminal to swap Delete and Backspace
keys while not using a PETSCII terminal.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Removed some debugging lines

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_removed_debugging_lines' into 'master'

Removed some debugging lines

See merge request main/sbbs!249

Modified Files:


src/sbbs3/node.c
diff

src/sbbs3/userdat.c
diff

Report the telegram waiting and node-msg waiting statuses separately (M and N)

I noticed that the node status displayed by load/presence_lib.js (e.g. used
by exec/nodelist.js) would have (N) for node-message waiting instead of (M)
as is reported in other places (e.g. the node utility, umonitor, sbbsctrl).
So this commit commonizes this behavior.

Now, it's crazy that there are (at least) 3 places that this node status
display is implemented and more things should just use nodestatus() to get
that string, but I'm not solving that copy/pasta issue in this commit.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/newuser.cpp
diff

New user terminal settings weren't display/settable durin sign-up

The interactive prompting for terminal capabilities worked fine,
but the default configuration menu settings did not reflect the
user's previous choices and changes they made (e.g. toggle mouse
support or BS/DEL key swap) were not reflected in the menu. Once
logged in, the normal user defaults menu worked as expected. This
is all because term_supports() keyed off of SS_USERON which isn't
set during new user sign-up, so let's key off SS_USERON|SS_NEWUSER
now.

Modified Files:


src/xpdev/gen_defs.h
diff

Add XSAFECOPY (extra safe copy) that won't pass NULL to strncpy()

The previous (reverted) change to SAFECOPY would double-resolve the (src)
argument and caused weird side effects.

Again, removes SAFECOPY_USES_SNPRINTF since it was unused.

Modified Files:


src/sbbs3/services.c
diff

Use XSAFECOPY in place of SAFECOPY to avoid NULL pointer checks

Modified Files:


src/xpdev/gen_defs.h
diff

Revert "Make SAFECOPY() even safer by not passing NULL destination to
strncpy()"

This reverts commit c0e857c930feb9833d40617f00ff5d11be9f7772.

Modified Files:


xtrn/sdk/xsdkinet.h
diff

xtrn/sdk/xsdkvars.c
diff

xtrn/sdk/xsdkwrap.c
diff

xtrn/sdk/xsdkwrap.h
diff

Comment header block clean-up

Really just testing to see if gitlab CI will be triggered by this commit.

Modified Files:


.gitlab-ci.yml
diff

Trigger CI builds on any C/C++ source or makefile changes in xtrn/*

Modified Files:


xtrn/sdk/xsdk.c
diff

Don't try to #include XPDEV header files unless USE_XPDEV is defined

This fixes the Borland/Windows build of xsdk that broke yesterday.

Modified Files:


install/GNUmakefile
diff

Remove showstats from install list, added pktdump and fmsgdump

Modified Files:


xtrn/sdk/xsdk.c
diff

xtrn/sdk/xsdk.h
diff

Resolve GCC-Linux build warnings

Modified Files:


src/xpdev/conwrap.h
diff

Add missing prototype for _termios_setup() - causing build warnings

Modified Files:


3rdp/build/js-disable-warnings.patch
diff

Revert "Patching the configure.in seems the better approach"

This reverts commit 64931c4722b6b9c82a30ffe5d3a3dee1de19a990.

Modified Files:


3rdp/build/js-disable-warnings.patch
diff

Patching the configure.in seems the better approach

The previous method (patching Makefile.in) didn't disable warnings when
building 'jsshell' (e.g. js.cpp).

Modified Files:


3rdp/build/js-disable-warnings.patch
diff

Fix Makefile.in path

Added Files:


3rdp/build/js-disable-warnings.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Disable warnings when build (very noisy) SpiderMonkey C++ code

Modified Files:


3rdp/build/GNUmakefile
diff

By default, build SpiderMonkey (libmozjs) in silent (no recipe) output mode

If debugging build issues, build with VERBOSE=1 to get the very verbose
SpiderMonkey build output again.

Modified Files:


install/GNUmakefile
diff

Don't set/reset ownership of files if Linux setcap was used

'chown' resets Linux capabilities (e.g. cap_net_bind_service=ep), so these
calls reset the earlier bind-capabilities enablement, meaning the auto-setup
feature on Linux-install really never worked?

Modified Files:


src/sbbs3/xtrn.cpp
diff

0-init the 'gamedir' variable

Resolves CID 434888, not sure why this one didn't show up before.

Modified Files:


src/sbbs3/main.cpp
diff

Don't try to upgrade */csts.dab and */dsts.dab files that don't exist

In a fresh v3.20 install, the legacy stats files don't exist, so don't try
to convert/upgrade them and log errors about it.

Modified Files:


src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

Don't conditionally allocate scfg_t dynamic arrays

malloc(0) returns a usable/freeable pointer on all supported platforms.

This change insures that the scfg_t dynamically allocated arrays are all valid
non-NULL pointers, even if/when the array length is 0. This should resolve
a lot of new(ish) CIDs. Or not. We'll see. :-/

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/gttrivia/qa/general.qa
diff

xtrn/gttrivia/qa/music_movies_and_entertainment.qa
diff

xtrn/gttrivia/readme.txt
diff

xtrn/gttrivia/revision_history.txt
diff

Added a crlf after printing message scan aborted

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/gttrivia/qa/general.qa
diff

xtrn/gttrivia/qa/music_movies_and_entertainment.qa
diff

xtrn/gttrivia/readme.txt
diff

xtrn/gttrivia/revision_history.txt
diff

Merge branch 'dd_msg_reader_scan_abort_crlf' into 'master'

Added a crlf after printing message scan aborted

See merge request main/sbbs!248

Modified Files:


src/sbbs3/userdat.c
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpdatetime.h
diff

New functions: [gm]time_to_isoDateTimeStr()

Not as flexible with regards to formatting as xpDateTime_to_isoDateTimeStr()
but simpler to use (with a time_t source).

Modified Files:


src/xpdev/gen_defs.h
diff

Make SAFECOPY() even safer by not passing NULL destination to strncpy()

This should resolve (new) CID 434884 and 434885.

Also, remove the SAFECOPY_USES_SPRINTF check/block - nobody enables this.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Small change in resetting the terminal attributes before the
script exits

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_attr_reset_change' into 'master'

DDMsgReader: Small change in resetting the terminal attributes before the
script exits

See merge request main/sbbs!247

Modified Files:


src/sbbs3/mqtt.c
diff

Fix crash in mqtt_startup() when configured broker isn't reachable

Modified Files:


src/sbbs3/objects.mk
diff

src/sbbs3/targets.mk
diff

Remove showstat - this functionality is provided via MQTT clients

Modified Files:


src/sbbs3/client.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/services.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/websrvr.c
diff

Store a copy (rather than a pointer to) the user name in client_t

This fixes issue #495.

Modified Files:


exec/text_sec.js
diff

We need store the file full path in the section name

We need to support the same filename in different directories.

The 'path' key is just an artifact and not normally used when read,
so that was a distraction that apparently confused me previously
and I broke this functionality in commit c44ed79a3b2c5e5.

This should fix the issues reported by xbit (XBITBBS) on DOVE-Net.

Also, don't open the file.ini for write-access (unnecessary).

Modified Files:


install/logrotate.d/sbbs
diff

Add notes about required ownership (root) and mode/permissions

Modified Files:


src/sbbs3/scfgsave.c
diff

Fix issue with QWKnet hub sub-board mappings when inserting new sub-boards

The sub_t.subnum's that were being updated as message areas were being saved to
msgs.ini could not be used as an index into the scfg_t.sub array at this point
(the subnum would be the new index position when the msgs.ini was
re-read/loaded)
.

This was not an issue in v3.19 because we just saved the subnum (to msgs.cnf)
and
in v3.20, we save the sub's internal code (to msgs.ini) and were using the
newly
updated sub_t.subnum to find the corresponding sub_t for that internal code.
Since
the subnum is not used now during the save process, no need to update it here
(this reverses part of the commit 11e529d40bca40 from 5 years ago).

This fixes issue #502 - thanks to the irc.synchro.netizens that reported it!

Modified Files:


exec/load/sbbsdefs.js
diff

Update U_* variables (pseudo consts) to use v3.20 user.tab field numbers

The first argument to system.matchuserdata() in v3.20 is the user.tab field
number, not the user.dat byte-offset that was used in versions of SBBS prior
to v3.20.

These values are synchronized with userfields.h, but I keept the U_ prefix
here (instead of USER_) to maintain compatibility with existing JS scripts.

This is a fix for issue #501 - thanks for the report Eric!

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for #499 (replying to emails from unknown user)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_unknown_sender_reply_fix' into 'master'

DDMsgReader: Fix for #499 (replying to emails from unknown user)

See merge request main/sbbs!246

Modified Files:


src/sbbs3/useredit.cpp
diff

Better handling of Quit/Ctrl-C at default protocol selection

IF user hits 'Q' (or whatever the "Quit" key is), set the default protocol
field in the user record to " " (instead of an empty string).
If user hits abort (Ctrl-C), don't make any change to the default protocol.

Modified Files:


src/sbbs3/userdat.c
diff

Don't truncate a user's record if the default download protocol or gender are
'\0'

A blank download protocol field in a user.dat, when parsed, sets the 'prot'
field
of user_t to 0. When writing the record back to the user.dat, this would
prematurely
truncate all other fields off the user record (since strings in C are NUL
terminated
and we're using sprintf() to format the record and %c specifier for that
field).

The fix is to write a ' ' character instead of '\0' if the user_t.prot is '\0'.
As part of this fix, I'm writing a '?' if a user_t.sex is '\0' (not sure if
this
is actually possible, but just as insurance). Those are the only 2
single-character
user properties/fields today.

Bug reported/debugged by Al of The Rusty Mailbox (1:153/757.2) - thank you!

Modified Files:


exec/update.js
diff

Don't run upgrade_to_v320 if user.dat doesn't exist

There's nothing to upgrade if there's no legacy userbase.

Modified Files:


exec/login.js
diff

Restore stealth legacy login prompt (NN:)

This old prompt used to be sent for any login scripts (e.g. QWKnet
via dial-up) that would key off that WWIV-like "name or number"
(NN:) prompt, but was removed (accidentally?) in commit fedabb0b8f6dfcdc4.

Send "NN: " and "PW: " (include the trailing space, just in case), and use
carriage return to move back (and overwrite) rather than 4 backspaces.

Modified Files:


exec/load/attr_conv.js
diff

xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader can now optionally convert Y-style MCI attributes to Synchronet
attributes.

Modified Files:


exec/load/attr_conv.js
diff

xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_convert_y_style_mci_attrs' into 'master'

DDMsgReader can now optionally convert Y-style MCI attributes to Synchronet
attributes.

See merge request main/sbbs!244

Modified Files:


exec/qnet-ftp.js
diff

Treat 0-byte QW* files the same as non-existent

The SBBS event_thread ignores 0-byte QW* files, so we should here as well
(just overwrite them if they exist), otherwise, if 10 0-byte QW* files got
created, we would just stop downloading QWK packets indefinitely.

Fixes issue reported by deon (ALTERANT) on DOVE-Net.

Modified Files:


src/sbbs3/mqtt.c
diff

Refactor mqtt_client_on()

This function has been causing somewhat rare crashes (e.g. one per week on a
very active system with MQTT enabled) on both Windows and Linux (see issue
#495). The root-cause is still unclear (possible heap corruption?). This
function needed more robustification anyway (see previous TODO comment), so I'm
refactoring here to no longer use strListAppendFormat, which uses vasprintf
(the function where the rare crash was occurring) and instead just use snprintf
and strListPush. The total client_list that's published (as a single
string/message) is now dynamically allocated (this was the point of the
previous TODO comment). This may not actually fix the issue if there's a heap
corruption occurring somewhere else in this function or the call-chain that's
reaching here (usually from the web server).

Another change to mqtt_client_on(): don't incremented the server's 'served'
counter until client disconnects (this is a past-tense statistic).

Also:
- mqtt_pub_strval() can now accept a null 'str' argument which is effectively
the same as mqtt_pub_noval(), so the pub_noval() function is now just a thin
wrapper around pub_strval().

- mqtt_startup() now clears the client_list topic and sets the client_count
topic to 0.

Modified Files:


src/sbbs3/main.cpp
diff

Don't attempt to remove a non-existing qwk-pack semfile

Reduce occurrences of subsequent errors (unsure of root-cause):
!ERROR 2 (No such file or directory) in main.cpp line 2778 (event_thread)
removing "/sbbs/data/pack0341.now"

This does seem to be the only location that deleted pack*.now files, so weird
that they'd disappear sometime after calling glob(), but I do understand that
its theoretically possible.

Modified Files:


src/xpdev/str_list.c
diff

strListJoin() will now fail gracefully (return NULL) if passed NULL buf

No immediate need/use.

Modified Files:


src/xpdev/str_list.c
diff

strListJoin() will now fail gracefully (return NULL) if passed NULL buf

No immediate need/use.

Modified Files:


src/sbbs3/main.cpp
diff

Don't attempt to remove a non-existing qwk-pack semfile

Reduce occurrences of subsequent errors (unsure of root-cause):
!ERROR 2 (No such file or directory) in main.cpp line 2778 (event_thread)
removing "/sbbs/data/pack0341.now"

This does seem to be the only location that deleted pack*.now files, so weird
that they'd disappear sometime after calling glob(), but I do understand that
its theoretically possible.

Modified Files:


src/sbbs3/mqtt.c
diff

Refactor mqtt_client_on()

This function has been causing somewhat rare crashes (e.g. one per week on a
very active system with MQTT enabled) on both Windows and Linux (see issue
#495). The root-cause is still unclear (possible heap corruption?). This
function needed more robustification anyway (see previous TODO comment), so I'm
refactoring here to no longer use strListAppendFormat, which uses vasprintf
(the function where the rare crash was occurring) and instead just use snprintf
and strListPush. The total client_list that's published (as a single
string/message) is now dynamically allocated (this was the point of the
previous TODO comment). This may not actually fix the issue if there's a heap
corruption occurring somewhere else in this function or the call-chain that's
reaching here (usually from the web server).

Another change to mqtt_client_on(): don't incremented the server's 'served'
counter until client disconnects (this is a past-tense statistic).

Also:
- mqtt_pub_strval() can now accept a null 'str' argument which is effectively
the same as mqtt_pub_noval(), so the pub_noval() function is now just a thin
wrapper around pub_strval().

- mqtt_startup() now clears the client_list topic and sets the client_count
topic to 0.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Screen header update optimization for file searching & scanning

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'ddfilelister_search_scan_header_update_optimization' into
'master'

Screen header update optimization for file searching & scanning

See merge request main/sbbs!243

Modified Files:


exec/upgrade_to_v320.js
diff

Another paranoia check, in case the new user command shell is invalid

Modified Files:


exec/upgrade_to_v320.js
diff

Protect against line 335: TypeError: cnf.guru[obj.guru] is undefined

As reported in #synchronet by Android8675

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Fix for issue #494 (DD File Lister searching and scanning)

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'issue_494_ddfilelister_scan_more_detail' into 'master'

Fix for issue #494 (DD File Lister searching and scanning)

Closes #494

See merge request main/sbbs!242

Modified Files:


exec/init-fidonet.js
diff

Fix a couple of compile errors introduced since v3.19

It'd be nice if someone (me?) tested this. :-)

Modified Files:


exec/load/install-binkit.js
diff

Updated to read/write xtrn.ini instead of xtrn.cnf, for SBBS v3.20+

Fixes issue #477

Modified Files:


exec/letsyncrypt.js
diff

Use main.ini instead of main.cnf for system password

Fixes issue #471

Modified Files:


exec/certtool.js
diff

Use main.ini instead of main.cnf for system password

Fixes issue #472

Modified Files:


exec/tickfix.js
diff

Use new cfglib.js instead of cnflib.js for SBBS v3.20+ compatibility

Fixes issue #475

Modified Files:


exec/text_sec.js
diff

text_sec updated for v3.20+

There are some changes in here that I forgot the history behind, but the
most important is that it uses file.ini rather than file.cnf, thus
fixing issue #478. I actually had this changed file sitting outside of my
git repo for a while now and didn't realize it.

The other changes appear to be:
- RIP support (clearing the window before/after each file is displayed)
- read the display files a chunk at a time (rather than read the entire file
  into RAM, which could take a really long time on very large files),
- allow files that don't exist on disk to be added to the list

Modified Files:


exec/chksetup.js
diff

Log a debug-level message when sending finger query to vert

The "opening list file" log message referenced in issue #480 is a debug
level log message, so seemed appropriate to make the newly-added message
also debug-level.

Fixes issue #480

Modified Files:


exec/install-xtrn.js
diff

Updated to use cfglib.js for SBBS v3.20+ compatibility

Fixes issue #473

Added Files:


exec/load/cfglib.js
diff

New config library for dealing with new ctrl/????.ini files

Replaces functionality of cnflib.js for sbbs v3.20+

Only the xtrn.ini read/write support has been added so far
(for use in install-xtrn.js).

I didn't think a lib like this would be needed, being that the
files are now in .ini format, but there was some re-arranging
of property values/section names that still needed to be done by
something (unfortunately), so this does that. But it does make
updating existing scripts that use cnflib.js a breeze.

Modified Files:


src/sbbs3/js_file.c
diff

Add File method: iniRemoveSections()

to remove all sections in an .ini file or all sections with a specified
prefix.

Modified Files:


exec/filearea-lb.js
diff

Merge branch 'eugeneso/filearealb' into 'master'

Migrate filearea-lb.js to use FileBase

See merge request main/sbbs!240

Modified Files:


exec/filearea-lb.js
diff

Migrate filearea-lb.js to use FileBase

Added Files:


xtrn/gttrivia/qa/names_of_people.qa
diff

xtrn/gttrivia/qa/star_trek_general.qa
diff

xtrn/gttrivia/qa/the_office_us.qa
diff

xtrn/gttrivia/qa/word_unscramble_english.qa
diff

Modified Files:


xtrn/gttrivia/gttrivia.ini
diff

xtrn/gttrivia/gttrivia.js
diff

xtrn/gttrivia/qa/dirty_minds.qa
diff

xtrn/gttrivia/qa/general.qa
diff

xtrn/gttrivia/qa/music_movies_and_entertainment.qa
diff

xtrn/gttrivia/readme.txt
diff

xtrn/gttrivia/revision_history.txt
diff

Merge branch 'gttrivia_qa_set_and_answer_metadata' into 'master'

Good Time Trivia 1.03: Fixes to score reading & parsing. Q&A files can have
more flexible metadata. Added more questions.

See merge request main/sbbs!241

Modified Files:


exec/filearea-lb.js
diff

Merge branch 'eugeneso/filearealb' into 'master'

Migrate filearea-lb.js to use FileBase

See merge request main/sbbs!240

Modified Files:


exec/filearea-lb.js
diff

Migrate filearea-lb.js to use FileBase

Added Files:


xtrn/gttrivia/qa/names_of_people.qa
diff

xtrn/gttrivia/qa/star_trek_general.qa
diff

xtrn/gttrivia/qa/the_office_us.qa
diff

xtrn/gttrivia/qa/word_unscramble_english.qa
diff

Modified Files:


xtrn/gttrivia/gttrivia.ini
diff

xtrn/gttrivia/gttrivia.js
diff

xtrn/gttrivia/qa/dirty_minds.qa
diff

xtrn/gttrivia/qa/general.qa
diff

xtrn/gttrivia/qa/music_movies_and_entertainment.qa
diff

xtrn/gttrivia/readme.txt
diff

xtrn/gttrivia/revision_history.txt
diff

Merge branch 'gttrivia_qa_set_and_answer_metadata' into 'master'

Good Time Trivia 1.03: Fixes to score reading & parsing. Q&A files can have
more flexible metadata. Added more questions.

See merge request main/sbbs!241

Modified Files:


exec/filearea-lb.js
diff

Merge branch 'eugeneso/filearealb' into 'master'

Migrate filearea-lb.js to use FileBase

See merge request main/sbbs!240

Modified Files:


exec/filearea-lb.js
diff

Migrate filearea-lb.js to use FileBase

Added Files:


xtrn/gttrivia/qa/names_of_people.qa
diff

xtrn/gttrivia/qa/star_trek_general.qa
diff

xtrn/gttrivia/qa/the_office_us.qa
diff

xtrn/gttrivia/qa/word_unscramble_english.qa
diff

Modified Files:


xtrn/gttrivia/gttrivia.ini
diff

xtrn/gttrivia/gttrivia.js
diff

xtrn/gttrivia/qa/dirty_minds.qa
diff

xtrn/gttrivia/qa/general.qa
diff

xtrn/gttrivia/qa/music_movies_and_entertainment.qa
diff

xtrn/gttrivia/readme.txt
diff

xtrn/gttrivia/revision_history.txt
diff

Merge branch 'gttrivia_qa_set_and_answer_metadata' into 'master'

Good Time Trivia 1.03: Fixes to score reading & parsing. Q&A files can have
more flexible metadata. Added more questions.

See merge request main/sbbs!241

Modified Files:


exec/filearea-lb.js
diff

Merge branch 'eugeneso/filearealb' into 'master'

Migrate filearea-lb.js to use FileBase

See merge request main/sbbs!240

Modified Files:


exec/filearea-lb.js
diff

Migrate filearea-lb.js to use FileBase

Added Files:


xtrn/gttrivia/qa/names_of_people.qa
diff

xtrn/gttrivia/qa/star_trek_general.qa
diff

xtrn/gttrivia/qa/the_office_us.qa
diff

xtrn/gttrivia/qa/word_unscramble_english.qa
diff

Modified Files:


xtrn/gttrivia/gttrivia.ini
diff

xtrn/gttrivia/gttrivia.js
diff

xtrn/gttrivia/qa/dirty_minds.qa
diff

xtrn/gttrivia/qa/general.qa
diff

xtrn/gttrivia/qa/music_movies_and_entertainment.qa
diff

xtrn/gttrivia/readme.txt
diff

xtrn/gttrivia/revision_history.txt
diff

Merge branch 'gttrivia_qa_set_and_answer_metadata' into 'master'

Good Time Trivia 1.03: Fixes to score reading & parsing. Q&A files can have
more flexible metadata. Added more questions.

See merge request main/sbbs!241

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfgdefs.h
diff

Increase maximum file extension length from 3 to 15 characters

For Viewable, Testable, Compressible file types and download events,
the file extension is no longer limited to 3 characters. 15 characters
seemed like "enough".

Similarly, a user's temp/QWK file type preference is also extended from
3 to 15 characters.

This fixes issue #486, but file types such as *.tar.gz (2 dots in the
extension)
are still an issue and will be addressed next.

Modified Files:


src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Fix possible crash when no extractable file types are configured in SCFG

If libarchive couldn't extract a QWK or REP packet, we'd fallback to searching
for a match among the configured extractable file types and if no
extension/type
match was found, default to the first configured extractable file type
(even if there wasn't one) which would result in a NULL pointer dereference
and most likely a crash. Instead, if no matching configured extractable
file type is found, just log a warning message and don't continue with the
extraction attempt. With SBBS v3.19+, it's totally valid/legit to have no
extractable file types configured in SCFG and things "just work" (using
libarchive).

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/viewfile.cpp
diff

Create/use file_type_match() for viewing, testing, and download-events

Allows for more/better wildcard matching in viewable and testable
file types and download-events (e.g. "tar.gz" or "tar.*").

This solves the "double-dot" problem in some file types/extensions.
An implicit "*." is prepended before the configured file type/extension.

Modified Files:


src/sbbs3/upgrade_to_v320.c
diff

Fix sizeof(cursub / curdir) issue as these user_t fields were increased in
v3.20

... but the old user.dat fields would still just be 16 chars in size.

Also a strcpy -> SAFECOPY conversion for user tmpext.

Modified Files:


src/sbbs3/makeuser.c
diff

strcpy -> SAFECOPY

Modified Files:


src/sbbs3/readmail.cpp
diff

Elminate old copy/paste cruft (likely from readmsgs.c/cpp)

Modified Files:


src/sbbs3/upgrade_to_v320.c
diff

Fix sizeof(cursub / curdir) issue as these user_t fields were increased in
v3.20

... but the old user.dat fields would still just be 16 chars in size.

Also a strcpy -> SAFECOPY conversion for user tmpext.

Modified Files:


src/sbbs3/makeuser.c
diff

strcpy -> SAFECOPY

Modified Files:


src/sbbs3/readmail.cpp
diff

Elminate old copy/paste cruft (likely from readmsgs.c/cpp)

Modified Files:


src/sbbs3/upgrade_to_v320.c
diff

Fix sizeof(cursub / curdir) issue as these user_t fields were increased in
v3.20

... but the old user.dat fields would still just be 16 chars in size.

Also a strcpy -> SAFECOPY conversion for user tmpext.

Modified Files:


src/sbbs3/makeuser.c
diff

strcpy -> SAFECOPY

Modified Files:


src/sbbs3/readmail.cpp
diff

Elminate old copy/paste cruft (likely from readmsgs.c/cpp)

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

Log client IP address along with MAXIMUM CLIENTS reached log message

Modified Files:


src/sbbs3/scfg/scfgnet.c
diff

Use more verbose MQTT version numers (e.g. 3.1.0 rather than 3.1)

Modified Files:


src/sbbs3/mqtt.c
diff

Log to log/# topic only when MQTT protocol version is < 5

When MQTT protocol version is >= 5, just log to the */log topic
(the level is a property).

This means you can't subscribe only to specific log levels when using MQTT v5
so I may re-think this, but I don't want to keep publishing every single log
message twice.

Modified Files:


src/sbbs3/scfglib1.c
diff

Change the default MQTT protocol version from 5.0 to 3.1.1

I read that 3.1.1 is much more widely supported, but perhaps that was old
info.

Modified Files:


src/sbbs3/readmail.cpp
diff

Elminate old copy/paste cruft (likely from readmsgs.c/cpp)

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DD lightbar menu fix for navigating with the HOME key with the top item index >
0 & selected item is in the middle of the screen

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_scroll_home_fix' into 'master'

DD lightbar menu fix for navigating with the HOME key with the top item index >
0 & selected item is in the middle of the screen

See merge request main/sbbs!239

Modified Files:


src/sbbs3/websrvr.c
diff

Add a "scheme" property to http_request object

Value is "http" or "https" depending on if TLS is in use.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

Public log messages over MQTT with the 'retain' flag set to true

This can be useful when debugging issues (e.g. crashes) and an MQTT
consuming/logging client wasn't connected at the time.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/putnode.cpp
diff

Go back to singular "node" topic

Modified Files:


src/sbbs3/mqtt.c
diff

Prepend "server/" before server topics

This solves the problem of subscribing to "sbbs/+/+/+" and getting node status
in addition to server status (very different formatted messages).

Also include a change for the singular-again "node" topic

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Range-check the cfg.new_shell value before using as index into array

If a configuration had *no* command shells, this would have caused a crash here
in SCFG.

Also, when selecting the new user command shell, default to the current
selection.

Modified Files:


src/sbbs3/mqtt.c
diff

Fix crash in mqtt_errormsg() when MQTT is disabled

Should fix the segfault reported by NeoArata_ in #synchronet

Also include singular/plural error/s in server status messages.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Publish some topics directly to topic levels

<server>/state is now published directly to the <sever> topic level (the
"state" topic goes away).

Moved <bbs-id>/node# topics to <bbs-id>/nodes/# (allows better wild-card
subscription per MQTT standards).
Publishing total node count to <bbs-id>/nodes rather than <bbs-id>/node_count

Introduced "publish verbosity" control (defaults to "High") - if you want nice
human readable (and sometimes redundant) topic messages, leave this set to
"High". To reduce traffic, set to "Low". It's expected that purpose-built
Synchronet/MQTT clients should work equally-well with either setting, but when
using generic MQTT clients/browser, "high" verbosity is nice. The
human-readable node status is only published when "high" verbosity is enabled.

Publishing the BBS name to the <bbs-id> topic, the instance hostname (as
configured in sbbs.ini) to the <host> topic. Makes the hierarchy much more
clear when using an MQTT browser like MQTT Explorer.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

Public hack, spam, and error logs at the MQTT BBS-ID topic depth

This is more consistent with how these events are logged in a BBS-common log
file in data/*.log.

This change also restores the server abbreviation to the error log entries that
used to be there until recently.

Modified Files:


src/sbbs3/answer.cpp
diff

Write/publish node client terminal params after telnet cmd parsing

Modified Files:


src/sbbs3/con_out.cpp
diff

Include terminal description in terminal.ini and node#/terminal mqtt msg

Modified Files:


src/sbbs3/main.cpp
diff

Include time used (HH:MM:SS) in node#/laston mqtt msg

Modified Files:


src/sbbs3/putnode.cpp
diff

Publish human readable nodestatus to node# mqtt topic

Makes for a nice node listing with pure-text MQTT clients/tools

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/login.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/server.h
diff

src/sbbs3/services.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/websrvr.c
diff

Over-overhaul of MQTT support

Each Synchronet server is now its own MQTT client. This means there's no
longer any MQTT logic in the Synchronet "hosts" (e.g. sbbscon.c, ctrl/*.cpp)
and none needed for SBBS NT services (they'll "just work" with MQTT).

This also means that just about everything (except for nodes, spam and hack)
is now published per-server (in the sbbs/BBS-ID/hostname/server/ topic branch)
and if you want aggregated totals or client lists, you'll have to do that in
your own MQTT client or dashboard.

I also removed the publishing of thread_count and socket_count topics as
they weren't universally supported across all servers and are of questionable
value. They can be added back later if determined to be useful.

Modified Files:


src/sbbs3/sbbscon.c
diff

Set server_stopped back to FALSE if a server is restarted (via recycle)

A set_state() may be called with SERVER_STOPPED while recycling.

Modified Files:


src/sbbs3/sbbscon.c
diff

Only report systemd service "READY=1" state if any server is actually ready

any server "running" is not enough because the server could still be
initializing, re-initializing, or even shutting down.

Modified Files:


webv4/lib/auth.js
diff

Aripoll auth wtf

Modified Files:


webv4/lib/auth.js
diff

Merge branch 'aripoll-auth-wtf' into 'master'

Aripoll auth wtf

See merge request main/sbbs!238

Modified Files:


exec/testbuild.js
diff

Windows builds reqquire Mosquitto (for MQTT) and OpsenSSL DLLs now

Technically, the OpenSSL DLLs aren't used right now because I have TLS support
disabled in the 'develop' branch version of mosquitto.dll v2.1.0 that I have
in the repo, but that should soon change.

Modified Files:


exec/init-fidonet.js
diff

Report correct filename in open failure error message

Fixes issue #476

Modified Files:


src/sbbs3/sbbscon.c
diff

Setup signal blocking before MQTT (which spawns a thread)

This solves the problem of any signal (even HUP) ungracefully terminating
sbbs (on *nix) when MQTT was enabled. As reported by Nightfox on IRC.

Modified Files:


src/sbbs3/mqtt.c
diff

Fix total-disablement of MQTT support in previous crash-fix-commit

Modified Files:


src/sbbs3/sbbscon.c
diff

Log an error upon failure to create/open the pid file

Modified Files:


src/sbbs3/mqtt.c
diff

More support for running (without crashing) with MQTT disabled

Modified Files:


src/sbbs3/mqtt.c
diff

Don't call mosquttio (MQTT lib) functions when disabled

Should fix the new crash issues reported by Retros via #synchronet on
irc.synchro.net

Modified Files:


src/sbbs3/node.c
diff

Actually allow node utility to run without SBBSCTRL being set

Modified Files:


src/sbbs3/ntsvcs.c
diff

Updated NT service descriptions and initialize startup.type members

Modified Files:


src/sbbs3/node.c
diff

src/sbbs3/node.vcxproj
diff

src/sbbs3/objects.mk
diff

Add default SBBSCTRL path to node utility

Update brace style and header comment while at it.

Modified Files:


src/sbbs3/mqtt.c
diff

Resolve GCC warning about function prototype mismatch

warning: passing argument 2 of ‘mosquitto_message_callback_set’ from
incompatible pointer type

Modified Files:


src/sbbs3/mqtt.h
diff

Fix GCC build with foward struct startup declaration.

Interestingly, not required for successful MSVC build. <shurg>

I suspecte the circular dependency and include-guards around mqtt.h
and startup.h were going to be a problem.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/login.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/services.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/websrvr.c
diff

Second part of MQTT overhaul

Now support subscriptions (e.g. recycle topics, node input topics) in SBBSCTRL.
This required a lot of search/replace and fun with circular struct pointers.

Modified Files:


src/sbbs3/ctrl/sbbsctrl.res
diff

Gotta include the updated resource file for new version details.

Modified Files:


src/sbbs3/ctrl/sbbsctrl.bpr
diff

Update version and copyright information using C++Builder IDE

Doing this via manual edits to this bpr file don't seem to work.

Modified Files:


src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

Timed event month-days (mdays) is 32-bit, not 16

Fix issue #470 reported via IRC: timed event "mdays" values were read and
written as 16-bit values, meaning any setting for days > 15 would do weird
things.

Modified Files:


src/sbbs3/mqtt.c
diff

src/sbbs3/sbbscon.c
diff

When the client_list is shared between servers, the served count is too

Modified Files:


src/sbbs3/main.cpp
diff

Remove accidentally added debug line with no effect.

Modified Files:


src/sbbs3/mqtt.c
diff

Resolve GCC warning: enumeration value ‘SERVER_COUNT’ not handled in switch

Modified Files:


src/sbbs3/ctrl/sbbsctrl.bpr
diff

Use int-sized enums for API compatible with MSVC built DLLs

e.g. sbbs.dll

Modified Files:


src/sbbs3/ctrl/AboutBoxFormUnit.cpp
diff

src/sbbs3/ctrl/AboutBoxFormUnit.h
diff

Include git branch/hash in sbbsctrl version info

And export a simple ver() function to be used in MainFormUnit.cpp (for mqtt
stuff)

Added Files:


src/sbbs3/server.h
diff

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

src/sbbs3/startup.h
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

MQTT support overhaul, mainly for SBBSCTRL compatibility

The only difference in the data/scheme is that the "error" topic (error log) is
now under each server rather than each host. I don't *think* there are any
other changes from the MQTT consumer side.

Still not done: subscribing (e.g. support for recycle or node-spy-input via
MQTT) and NT services support.

This change also includes a cool feature that will prompt the sysop if there's
a timeout (30 seconds) while waiting for servers to shutdown gracefully and
giving the sysop the option to abort (Cancel) the wait (and shutdown
ungracefully) or continue the wait (OK).

Modified Files:


src/sbbs3/useredit/UserEdit.bpr
diff

Should fix unresolved dependencies (e.g. vc160.bpl)

Turned of "Use dynamic RTL" and "Build with runtime packages" under
Project options.

This should resolve the UserEdit.exe runtime issue reported by Diamond Dave
via DOVE-Net.

Modified Files:


src/sbbs3/sbbscon.c
diff

Fix sbbs startup issue when user is specific in sbbs.ini [unix]

Bug introduced in the systemd integration (commit d02978ade98a8)
and reported by Dan_C via #synchronet at irc.synchro.net

Modified Files:


exec/update.js
diff

Fix off-by-one errors in looping through user records

(last user record wouldn't have been updated)

These are rather old update steps (e.g. v3.18), so don't fret it.

Modified Files:


src/sbbs3/ctrl/makelibs.bat
diff

Revert "Is coff2omf the issue?"

This reverts commit 15494c2d8813658420379067b070b7f7bf73c9d4.

Modified Files:


.gitlab-ci.yml
diff

Revert "Prefix .bat file script invocation lines with "call""

This reverts commit 1e737459978d50fa99f3a6f73112915208fdbd2a.

Modified Files:


src/sbbs3/ctrl/build.bat
diff

Revert "Don't call makelibs.bat from build.bat"

This reverts commit 6c064579c3b4b2e1449ce65bfab47c463b19700c.

Modified Files:


src/sbbs3/ctrl/makelibs.bat
diff

Is coff2omf the issue?

Modified Files:


src/sbbs3/ctrl/build.bat
diff

Don't call makelibs.bat from build.bat

This seems to stop the CI build and I haven't found any other solution.
So just copy/paste the contents of makelibs.bat into this batch file. <sigh>

Modified Files:


src/sbbs3/ctrl/makelibs.bat
diff

Try the 'exit /b' trick to stop makelibs.bat from terminating build.bat

when run from Gitlab-Runner (CI) using shell="cmd"

Modified Files:


src/sbbs3/ctrl/build.bat
diff

Try setlocal to allow nested build.bat -> makelibs.bat to pass CI build

Modified Files:


.gitlab-ci.yml
diff

Prefix .bat file script invocation lines with "call"

Apparently when the Gitlab Runner is using "cmd", you must do this or only
the first invoked bat file is executed. This explains why sbbsctrl.exe
(and other) files have been missing from the CI-generated artifact archives.
Back when I was using "powershell" to invoke the CI build for sbbs-windows
(my Gitlab-runner/config.toml file had shell = "powershell"), this wasn't an
issue, but this configuration stopped working on Vert at some point (https://fo
rum.gitlab.com/t/windows-10-gitlab-runner-fails-with-error-no-process-is-on-the
-other-end-of-the-pipe/66691)
so I switched to "cmd", even though it's deprecated.

Remove the dependencies: [] line since that wasn't a solution to anything.

Modified Files:


install/systemd/sbbs.service
diff

Add instructions to use symlink and 'systemctl edit sbbs' for over-rides

I think this addresses issue #403, at least in part.

Modified Files:


src/sbbs3/useredit.cpp
diff

Don't assign to unused variable

CID 433272

Modified Files:


src/xpdev/ini_file.c
diff

Borland C/C++ doesn't have strto[u]ll()

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: For Synchronet >= 3.20, read external editor quote wrap setting
from xtrn.ini (rather than xtrn.cnf)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmr_sync320_xtrn_ini' into 'master'

DDMsgReader: For Synchronet >= 3.20, read external editor quote wrap setting
from xtrn.ini (rather than xtrn.cnf)

See merge request main/sbbs!236

Modified Files:


src/sbbs3/main.cpp
diff

Clean-up the logging around the auto-tuned outbuf highwater mark

Modified Files:


src/sbbs3/js_system.c
diff

Resolve unused variable warning introduced in previous commit

Some trailing whitespace clean-up too.

Modified Files:


exec/load/sbbsdefs.js
diff

exec/upgrade_to_v320.js
diff

src/sbbs3/answer.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/login.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/services.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/websrvr.c
diff

Common login control (e.g. via real name) using new find_login_id() function

Previously, many servers and services didn't support login by real name
(e.g. issue #469) even if the sysop had that option enabled in SCFG.

Move login control settings from node.ini to system (main.ini -> login)

The 3 node toggle options:
- Allow Login by User Number
- Allow Login by Real Name
- Always Prompt for Password

... have been now moved from SCFG->Nodes->Node x->Toggle Options to
SCFG-System->Toggle Options.

If you upgraded to v3.20a before now, you'll want to double-check these
settings to make sure they're how you want them set. New upgraders that run
upgrade_to_v320.js (e.g. via 'jsexec update') will get these settings migrated
automatically.

Added some error detection/logging to upgrade_to_v320.js when failing to open
.cnf files.

Constified some more user/login related function args and return types.

Modified Files:


src/sbbs3/login.cpp
diff

src/sbbs3/sbbs.h
diff

More constification of login().

Modified Files:


src/sbbs3/js_system.c
diff

Add JS system.find_login_id() method

Modified Files:


src/sbbs3/answer.cpp
diff

Don't try to send telnet commands if not connected.

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Add functions for reading/getting/settings 64-bit ints/uints

No immediate use, but I thought I had one. I didn't. Still, will probably need
these one day.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Use the user's default download protocol for batch downloads

Oversight probably during the new filebase overhaul in v3.19. Reported by
Nelgin.

Modified Files:


src/sbbs3/main.cpp
diff

Lower log level of send_telnet_cmd() send failure (to debug level)

As apparently these happen a lot when a client disconnects right
away after connecting.

Modified Files:


src/sbbs3/sbbscon.c
diff

Fix MQTT for daemonized sbbs

Need to start the MQTT init/thread-start stuff after daemonizing.

Thanks to Nelgin for letting me know this was recently broken.

Modified Files:


src/sbbs3/main.cpp
diff

Fix gcc warnings in previous commit: don't bother with [s]size_t here

Modified Files:


src/sbbs3/main.cpp
diff

Eliminate the global 'sbbs' here, was masking bugs

I'm not sure what purpose this global variable once had, but it wasn't needed
now and it was masking copy/paste issues in some of the sbbs_t methods in this
file. Just make an 'sbbs' local to bbs_thread(), since there's where it's
legit-used.

FYI: All the Cryptlib-SSH macros assume there's an 'sbbs' in scope.

Modified Files:


src/sbbs3/main.cpp
diff

Add sendsocket() result checking/error-logging to send_telnet_cmd()

Modified Files:


src/sbbs3/main.cpp
diff

Move some lines around to clamp sbbs->outbuf.highwater_mark at
IO_THREAD_BUF_SIZE

Modified Files:


ctrl/sbbs.ini
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/websrvr.c
diff

Use OutbufHighwaterMark as a default, not an override.

The MSS detection will set this to the best value on a per-connection
basis.  This will allow larger packets to be sent from the BBS.

Modified Files:


src/sbbs3/main.cpp
diff

Call RingBufRead() when avail == 0 to reset events

If something else sets these events, and they never get cleared,
this will fall into a tight loop.

Added Files:


docs/slyedit_readme.txt
diff

Modified Files:


exec/SlyEdit.js
diff

exec/newuser.js
diff

src/doors/clans-src/data/list.asc
diff

src/doors/clans-src/data/pg.asc
diff

src/doors/clans-src/data/pxnews.asc
diff

src/doors/clans-src/data/pxtit.asc
diff

src/doors/clans-src/test/scores.ans
diff

src/doors/clans-src/test/scores.asc
diff

src/doors/dgnlance/text/docs.asc
diff

src/doors/dgnlance/text/guards.ans
diff

src/doors/dgnlance/text/guards.asc
diff

src/doors/dgnlance/text/menu.ans
diff

src/doors/dgnlance/text/menu.asc
diff

src/doors/dgnlance/text/plug.asc
diff

src/doors/gac/gac_bj/art/8_backup.ans
diff

src/doors/gac/gac_bj/art/bank.ans
diff

src/doors/gac/gac_bj/art/bbscur.ans
diff

src/doors/gac/gac_bj/art/bbslst.ans
diff

src/doors/gac/gac_bj/art/ga_bj_5.ans
diff

src/doors/gac/gac_bj/art/gac_1.ans
diff

src/doors/gac/gac_bj/art/gac_10.ans
diff

src/doors/gac/gac_bj/art/gac_11.ans
diff

src/doors/gac/gac_bj/art/gac_12.ans
diff

src/doors/gac/gac_bj/art/gac_13.ans
diff

src/doors/gac/gac_bj/art/gac_14.ans
diff

src/doors/gac/gac_bj/art/gac_15.ans
diff

src/doors/gac/gac_bj/art/gac_2.ans
diff

src/doors/gac/gac_bj/art/gac_3.ans
diff

src/doors/gac/gac_bj/art/gac_4.ans
diff

src/doors/gac/gac_bj/art/gac_5.ans
diff

src/doors/gac/gac_bj/art/gac_6.ans
diff

src/doors/gac/gac_bj/art/gac_7.ans
diff

src/doors/gac/gac_bj/art/gac_8.ans
diff

src/doors/gac/gac_bj/art/gac_9.ans
diff

src/doors/gac/gac_bj/art/gac_bj.asc
diff

src/doors/gac/gac_bj/art/gac_bj10.ans
diff

src/doors/gac/gac_bj/art/gac_bj11.ans
diff

src/doors/gac/gac_bj/art/gac_bj12.ans
diff

src/doors/gac/gac_bj/art/gac_bj13.ans
diff

src/doors/gac/gac_bj/art/gac_bj14.ans
diff

src/doors/gac/gac_bj/art/gac_bj15.ans
diff

src/doors/gac/gac_bj/art/gac_bj_1.ans
diff

src/doors/gac/gac_bj/art/gac_bj_2.ans
diff

src/doors/gac/gac_bj/art/gac_bj_3.ans
diff

src/doors/gac/gac_bj/art/gac_bj_4.ans
diff

src/doors/gac/gac_bj/art/gac_bj_5.ans
diff

src/doors/gac/gac_bj/art/gac_bj_6.ans
diff

src/doors/gac/gac_bj/art/gac_bj_7.ans
diff

src/doors/gac/gac_bj/art/gac_bj_8.ans
diff

src/doors/gac/gac_bj/art/gac_bj_9.ans
diff

src/doors/gac/gac_bj/art/gac_fc_1.ans
diff

src/doors/gac/gac_bj/art/plycur.ans
diff

src/doors/gac/gac_bj/art/plylst.ans
diff

src/doors/gac/gac_bj/art/temp.ans
diff

src/doors/gac/gac_bj/bbstimes.ans
diff

src/doors/gac/gac_bj/bbstimes.asc
diff

src/doors/gac/gac_bj/gac_bj.asc
diff

src/doors/gac/gac_bj/release/gac_bj.asc
diff

src/doors/gac/gac_fc/art/8_backup.ans
diff

src/doors/gac/gac_fc/art/bank.ans
diff

src/doors/gac/gac_fc/art/freeinst.asc
diff

src/doors/gac/gac_fc/art/ga_bj_5.ans
diff

src/doors/gac/gac_fc/art/gac_10.ans
diff

src/doors/gac/gac_fc/art/gac_12.ans
diff

src/doors/gac/gac_fc/art/gac_13.ans
diff

src/doors/gac/gac_fc/art/gac_14.ans
diff

src/doors/gac/gac_fc/art/gac_15.ans
diff

src/doors/gac/gac_fc/art/gac_3.ans
diff

src/doors/gac/gac_fc/art/gac_4.ans
diff

src/doors/gac/gac_fc/art/gac_6.ans
diff

src/doors/gac/gac_fc/art/gac_7.ans
diff

src/doors/gac/gac_fc/art/gac_8.ans
diff

src/doors/gac/gac_fc/art/gac_9.ans
diff

src/doors/gac/gac_fc/art/gac_bj10.ans
diff

src/doors/gac/gac_fc/art/gac_bj11.ans
diff

src/doors/gac/gac_fc/art/gac_bj12.ans
diff

src/doors/gac/gac_fc/art/gac_bj13.ans
diff

src/doors/gac/gac_fc/art/gac_bj14.ans
diff

src/doors/gac/gac_fc/art/gac_bj15.ans
diff

src/doors/gac/gac_fc/art/gac_fc.asc
diff

src/doors/gac/gac_fc/art/gac_fc_1.ans
diff

src/doors/gac/gac_fc/art/rules.asc
diff

src/doors/gac/gac_fc/gac_fc.asc
diff

src/doors/gac/gac_wh/art/8_backup.ans
diff

src/doors/gac/gac_wh/art/bank.ans
diff

src/doors/gac/gac_wh/art/gac_10.ans
diff

src/doors/gac/gac_wh/art/gac_12.ans
diff

src/doors/gac/gac_wh/art/gac_13.ans
diff

src/doors/gac/gac_wh/art/gac_14.ans
diff

src/doors/gac/gac_wh/art/gac_15.ans
diff

src/doors/gac/gac_wh/art/gac_3.ans
diff

src/doors/gac/gac_wh/art/gac_4.ans
diff

src/doors/gac/gac_wh/art/gac_6.ans
diff

src/doors/gac/gac_wh/art/gac_7.ans
diff

src/doors/gac/gac_wh/art/gac_8.ans
diff

src/doors/gac/gac_wh/art/gac_9.ans
diff

src/doors/gac/gac_wh/art/gac_fc_1.ans
diff

src/doors/gac/gac_wh/art/gac_wh.asc
diff

src/doors/gac/gac_wh/art/gac_wh_1.ans
diff

src/doors/gac/gac_wh/art/rules.asc
diff

src/doors/gac/gac_wh/art/wahoinst.asc
diff

src/doors/gac/gac_wh/art/wahoobd.ans
diff

src/doors/gac/gac_wh/gac_wh.asc
diff

src/doors/gac/gac_wh/release/gac_wh.asc
diff

src/doors/gac/gac_wh/wahoobd.asc
diff

src/doors/gac/gamesdk/art/bbscur.ans
diff

src/doors/gac/gamesdk/art/bbslst.ans
diff

src/doors/gac/gamesdk/art/plycur.ans
diff

src/doors/gac/gamesdk/art/plylst.ans
diff

src/doors/gac/gamesdk/reqdart/gac_10.ans
diff

src/doors/gac/gamesdk/reqdart/gac_12.ans
diff

src/doors/gac/gamesdk/reqdart/gac_13.ans
diff

src/doors/gac/gamesdk/reqdart/gac_14.ans
diff

src/doors/gac/gamesdk/reqdart/gac_15.ans
diff

src/doors/gac/gamesdk/reqdart/gac_3.ans
diff

src/doors/gac/gamesdk/reqdart/gac_4.ans
diff

src/doors/gac/gamesdk/reqdart/gac_6.ans
diff

src/doors/gac/gamesdk/reqdart/gac_7.ans
diff

src/doors/gac/gamesdk/reqdart/gac_8.ans
diff

src/doors/gac/gamesdk/reqdart/gac_9.ans
diff

src/doors/gac/gamesdk/template/art/gac_10.ans
diff

src/doors/gac/gamesdk/template/art/gac_12.ans
diff

src/doors/gac/gamesdk/template/art/gac_13.ans
diff

src/doors/gac/gamesdk/template/art/gac_14.ans
diff

src/doors/gac/gamesdk/template/art/gac_15.ans
diff

src/doors/gac/gamesdk/template/art/gac_3.ans
diff

src/doors/gac/gamesdk/template/art/gac_4.ans
diff

src/doors/gac/gamesdk/template/art/gac_6.ans
diff

src/doors/ny2008/intro.ans
diff

src/doors/ny2008/intro.asc
diff

src/doors/ny2008/ny2008.ans
diff

src/doors/ny2008/ny2008.asc
diff

src/doors/ny2008/nyinstr.asc
diff

src/doors/ny2008/nyinstrc.asc
diff

src/doors/ny2008/win.ans
diff

src/doors/timeport/buttons.ans
diff

src/doors/timeport/ending1.ans
diff

src/doors/timeport/ending2.ans
diff

src/doors/timeport/flying.ans
diff

src/doors/timeport/room1.ans
diff

src/doors/timeport/room1.asc
diff

src/doors/timeport/room10.ans
diff

src/doors/timeport/room10.asc
diff

src/doors/timeport/room11.ans
diff

src/doors/timeport/room11.asc
diff

src/doors/timeport/room12.ans
diff

src/doors/timeport/room12.asc
diff

src/doors/timeport/room13.ans
diff

src/doors/timeport/room13.asc
diff

src/doors/timeport/room14.ans
diff

src/doors/timeport/room14.asc
diff

src/doors/timeport/room15.ans
diff

src/doors/timeport/room15.asc
diff

src/doors/timeport/room16.ans
diff

src/doors/timeport/room16.asc
diff

src/doors/timeport/room17.ans
diff

src/doors/timeport/room17.asc
diff

src/doors/timeport/room18.ans
diff

src/doors/timeport/room18.asc
diff

src/doors/timeport/room19.ans
diff

src/doors/timeport/room19.asc
diff

src/doors/timeport/room2.ans
diff

src/doors/timeport/room2.asc
diff

src/doors/timeport/room20.ans
diff

src/doors/timeport/room20.asc
diff

src/doors/timeport/room3.ans
diff

src/doors/timeport/room3.asc
diff

src/doors/timeport/room4.ans
diff

src/doors/timeport/room4.asc
diff

src/doors/timeport/room5.ans
diff

src/doors/timeport/room5.asc
diff

src/doors/timeport/room6.ans
diff

src/doors/timeport/room6.asc
diff

src/doors/timeport/room7.ans
diff

src/doors/timeport/room7.asc
diff

src/doors/timeport/room8.ans
diff

src/doors/timeport/room8.asc
diff

src/doors/timeport/room9.ans
diff

src/doors/timeport/room9.asc
diff

src/doors/timeport/shuttle.ans
diff

src/doors/timeport/title1.ans
diff

src/doors/timeport/title2.ans
diff

src/doors/timeport/title3.ans
diff

src/doors/timeport/title4.ans
diff

src/doors/timeport/title5.ans
diff

src/doors/timeport/title6.ans
diff

src/doors/timeport/title7.ans
diff

text/banner1.msg
diff

text/banner2.msg
diff

text/banner3.msg
diff

text/menu/chat.msg
diff

text/menu/e-mail.msg
diff

text/menu/mailread.msg
diff

text/menu/maincfg.msg
diff

text/menu/multchat.msg
diff

text/menu/qwk.msg
diff

text/menu/renegade/email.asc
diff

text/menu/renegade/main.asc
diff

text/menu/renegade/message.asc
diff

text/menu/renegade/transfer.asc
diff

text/menu/sysmailr.msg
diff

text/menu/tempxfer.asc
diff

text/menu/wwiv/main.asc
diff

text/menu/wwiv/transfer.asc
diff

text/menu/xfercfg.msg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/chickendelivery/instruct.ans
diff

xtrn/dgnlance/guards.asc
diff

xtrn/dgnlance/menu.asc
diff

xtrn/dgnlance/plug.asc
diff

xtrn/lord/menus/addmun10/cfthing.ans
diff

xtrn/lord/menus/addmun10/thingad.ans
diff

xtrn/lord/menus/clu_enem/opivy.ans
diff

xtrn/lord/menus/dimensia/dimensio.ans
diff

xtrn/lord/menus/dllord20/backup.ans
diff

xtrn/lord/menus/dllord20/hey.ans
diff

xtrn/lord/menus/exptlord/eye.ans
diff

xtrn/lord/menus/ldxxx/prelord.ans
diff

xtrn/lord/menus/mdrnwrld/hell.ans
diff

xtrn/lord/menus/tnglord/bworld.ans
diff

xtrn/lord/menus/tnglord/tnglord.ans
diff

xtrn/lord2/cnw/battle1.ans
diff

xtrn/lord2/cnw/battle2.ans
diff

xtrn/lord2/cnw/battle3.ans
diff

xtrn/lord2/cnw/battle4.ans
diff

xtrn/lord2/cnw/battle5.ans
diff

xtrn/lord2/cnw/battle6.ans
diff

xtrn/lord2/cnw/castaway.ans
diff

xtrn/lord2/cnw/finger.ans
diff

xtrn/lord2/cnw/fishy.ans
diff

xtrn/lord2/cnw/fishyl.ans
diff

xtrn/lord2/cnw/fishys.ans
diff

xtrn/lord2/cnw/gumgod.ans
diff

xtrn/lord2/cnw/kraken.ans
diff

xtrn/lord2/cnw/lord.ans
diff

xtrn/lord2/cnw/lordad.ans
diff

xtrn/lord2/cnw/rose1.ans
diff

xtrn/lord2/cnw/rose10.ans
diff

xtrn/lord2/cnw/rose2.ans
diff

xtrn/lord2/cnw/rose3.ans
diff

xtrn/lord2/cnw/rose4.ans
diff

xtrn/lord2/cnw/rose5.ans
diff

xtrn/lord2/cnw/rose6.ans
diff

xtrn/lord2/cnw/rose7.ans
diff

xtrn/lord2/cnw/rose8.ans
diff

xtrn/lord2/cnw/rose9.ans
diff

xtrn/lord2/cnw/scvngr1.ans
diff

xtrn/lord2/cnw/scvngr2.ans
diff

xtrn/lord2/cnw/scvngr3.ans
diff

xtrn/lord2/cnw/sea01.ans
diff

xtrn/lord2/cnw/shell.ans
diff

xtrn/lord2/cnw/tower.ans
diff

xtrn/lord2/cnw/weelie.ans
diff

xtrn/tbd/tbdwin.ans
diff

xtrn/tw2/fighters.ans
diff

xtrn/tw2/planet.ans
diff

xtrn/tw2/port.ans
diff

xtrn/tw2/ship.ans
diff

xtrn/tw2/twopeng.asc
diff

Merge branch 'v320a_dev' of gitlab.synchro.net:main/sbbs into v320a_dev

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Add iniGetIntInRange() for range-enforced integer values

If you're going to use a read key value as say, an index into fixed-length
array, then you better be sure it's within an expected range.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/putnode.cpp
diff

Don't attempt MQTT functions when MQTT is disabled

This is to avoid the error reporting/logging that results.

Modified Files:


src/sbbs3/sbbscon.c
diff

Publish a <host>/status to represent on/offline/disconnected

Set "last will" to publish the "disconnected" status.

Modified Files:


src/sbbs3/mqtt.c
diff

Add TLS support

Modified Files:


src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add MQTT TLS support

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

Add Networks->MQTT configuration sub menu

Modified Files:


src/xpdev/conwrap.c
diff

Fix misleading-indentation warning from GCC

Modified Files:


src/vdmodem/vdmodem.c
diff

Add clock related variable values to debug output

Just in case there's some clock wrap around issue  causing issue #468. Seems
unlikely with a 64-bit clock, but there are a lot of conditions in the
xp_timer64() implementation that could evaluate differently on different
versions of Windows or on different computers.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/login.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

Publish hack-attempts, SPAM-attempts, and errors to MQTT

<host>/error
.../spam
.../hack

Modified Files:


src/sbbs3/objects.mk
diff

Not using sbbs_status for anything, so don't build/link it

Modified Files:


src/sbbs3/logfile.cpp
diff

Resolve warning: ISO C++ forbids converting a string constant to ‘char*’

Modified Files:


src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

Add a public "no value" function

This can be used to clear a 'retained' topic (of any type).

Modified Files:


src/sbbs3/sbbscon.c
diff

Fix the MQTT "last will" (must be set before connect)

Add some more "status" topic values while initializing and terminating.

Modified Files:


src/sbbs3/mqtt.c
diff

src/sbbs3/sbbscon.c
diff

Fix non-mosquitto build

By moving mosquitto_will_set() call into mqtt_connect().

I'm still having the issue that the LWT is being published after
mosquitto_disconnect(), even though I set the "force" parameter to false in the
call to mqtt_loop_stop()

Modified Files:


src/conio/cterm.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/xmodem.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/conn.c
diff

src/syncterm/conn.h
diff

src/syncterm/conn_pty.c
diff

src/syncterm/ripper.c
diff

src/syncterm/ssh.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

src/syncterm/window.c
diff

src/syncterm/window.h
diff

src/uifc/filepick.c
diff

src/uifc/uifc32.c
diff

Merge remote-tracking branch 'origin/master' into v320a_dev

Modified Files:


src/sbbs3/sbbscon.c
diff

MQTT thread wasn't even attempted to be started on Windows

mqtt_thread_start() actually will fail on Windows currently because we're
using a non-thread-safe version of mosquitto.dll

This moves the mqtt thread start further up before some *nix-specific stuff,
so hopefully that's not an issue.

Modified Files:


3rdp/win32.release/mosquitto/bin/mosquitto.dll
diff

3rdp/win32.release/mosquitto/bin/mosquitto.lib
diff

Current develop branch of mosquitto 2.1.0, multi-threaded!

Finally, a thread-safe version of mosquitto.dll <sigh>

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/websrvr.c
diff

Move the 'max_clients' value publishing to the individual servers

Added Files:


3rdp/win32.release/mosquitto/bin/libcrypto-1_1.dll
diff

3rdp/win32.release/mosquitto/bin/libssl-1_1.dll
diff

3rdp/win32.release/mosquitto/bin/mosquitto.dll
diff

3rdp/win32.release/mosquitto/bin/mosquitto.lib
diff

3rdp/win32.release/mosquitto/include/mosquitto.h
diff

3rdp/win32.release/mosquitto/include/mqtt_protocol.h
diff

3rdp/win32.release/mosquitto/mosquitto.props
diff

ctrl/chat.ini
diff

ctrl/file.ini
diff

ctrl/main.ini
diff

ctrl/msgs.ini
diff

ctrl/xtrn.ini
diff

docs/newcfgfiles.txt
diff

docs/newuserbase.txt
diff

exec/upgrade_to_v320.js
diff

install/logrotate.d/sbbs
diff

install/rsyslog.d/sbbslog.conf
diff

node1/node.ini
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/upgrade_to_v320.c
diff

src/sbbs3/upgrade_to_v320.vcxproj
diff

src/sbbs3/useredit/.gitignore
diff

src/sbbs3/useredit/MainFormUnit.cpp
diff

src/sbbs3/useredit/MainFormUnit.h
diff

src/sbbs3/useredit/UserEdit.bpr
diff

src/sbbs3/useredit/UserEdit.cpp
diff

src/sbbs3/userfields.h
diff

Modified Files:


.gitlab-ci.yml
diff

CONTRIBUTING.md
diff

exec/archive.js
diff

exec/avatars.js
diff

exec/emailfiles.js
diff

exec/init-fidonet.js
diff

exec/load/cnfdefs.js
diff

exec/localcopy.js
diff

exec/logonlist.js
diff

exec/msglist.js
diff

exec/sbbslist.js
diff

exec/update.js
diff

install/GNUmakefile
diff

install/systemd/sbbs.service
diff

src/sbbs3/GNUmakefile
diff

src/sbbs3/answer.cpp
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/bulkmail.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/ctrl/CtrlPathDialogUnit.dfm
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/ctrl/sbbsctrl.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/data_ovl.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/gtkmonitor/gtkmonitor.c
diff

src/sbbs3/gtkuserlist/gtkuserlist.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.c
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/ntsvcs.c
diff

src/sbbs3/objects.mk
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbs3.sln
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/sbbscon.vcxproj
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/targets.mk
diff

src/sbbs3/textgen.c
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/useredit/MainFormUnit.dfm
diff

src/sbbs3/useredit/UserEdit.res
diff

src/sbbs3/useredit/build.bat
diff

src/sbbs3/ver.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/vdmodem/vdmodem.c
diff

src/xpdev/conwrap.c
diff

src/xpdev/gen_defs.h
diff

src/xpdev/genwrap.c
diff

src/xpdev/genwrap.h
diff

src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

src/xpdev/sockwrap.h
diff

src/xpdev/str_list.c
diff

src/xpdev/str_list.h
diff

text/answer.msg
diff

Removed Files:


ctrl/chat.cnf
diff

ctrl/file.cnf
diff

ctrl/main.cnf
diff

ctrl/msgs.cnf
diff

ctrl/xtrn.cnf
diff

node1/node.cnf
diff

src/sbbs3/allusers.c
diff

src/sbbs3/allusers.vcxproj
diff

src/sbbs3/useredit/MainFormUnit.pas
diff

src/sbbs3/useredit/UserEdit.dof
diff

src/sbbs3/useredit/UserEdit.dpr
diff

Merge remote-tracking branch 'origin/v320a_dev'

v3.20a has been in development for several months now and appears stable enough
to merge to master.

Sysops running v3.19 or earlier *must* run 'jsexec update' to get their config
files (ctrl/*.cnf) converted to *.ini and their user base (data/user/user.dat)
converted to user.tab.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/startup.h
diff

Remove startup->node_spysem, nobody's using it and it had a bad bug

This came about through the realization that the global 'sbbs' in main.cpp
can (and was/is) hiding some copy/pasta bugs.

Modified Files:


exec/syncterm-bounce.js
diff

With the new auto-flush thing, we can rejigger this to not need
console.flush() anymore.

Modified Files:


src/sbbs3/main.cpp
diff

Output snappiness improvements.

When the system checks for an incoming byte, if there's any pending
output, send it immediately, bypassing the outbuf highwater mark.

This allows the final non-full packet to be sent without waiting
for the OutbufDrainTimeout (default 10ms), and makes a big difference
when doing a large number of ANSI queries (send an ANSI code, wait
for a response).  There's a small but noticable placebo effect as
well that makes everything feel smoother.

This commit also cleans up the output thread where it pulls from
the ring buffer into the linear buffer to take advantage of the new
event-based ring buffers.  Much easier to read now.

Speaking of easier to read, this also includes some whitespace
fixups.

Modified Files:


src/sbbs3/js_console.cpp
diff

Fix console.flush() jsdocs details (version, arguments)

Modified Files:


exec/syncterm-bounce.js
diff

Add a console.flush() after we sent each ANSI query that will
wait for a response.  Also, use a single cache list command to check
the MD5 of both files.

This speeds up startup immensely.  It would be a good idea to do
something similar in Synchronet any time we send a query and wait
for a response... as it sits now, we're basically adding extra
delays that aren't strictly necessary.

Another option would be to *always* flush before a blocking read,
which would "fix" anything that's not using inkey() with a timeout
of zero.  This would just generally fix everything I think, unless
there's something calling inkey() with a very small timeout just
to avoid 100% CPU or something.

Modified Files:


exec/syncterm-bounce.js
diff

Use the new console.flush() method.

This speeds up the display immensely without distracting artifacts
(yay!)

Modified Files:


src/sbbs3/js_console.cpp
diff

Add console.flush() method.

Seems to work a treat.

Modified Files:


src/sbbs3/sbbsexec.c
diff

Fix typo

Modified Files:


src/sbbs3/sbbsexec.vcxproj
diff

Add RINGBUF_EVENT to some things that I hope will fix CI.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Fix name of data event

Modified Files:


src/sbbs3/sbbsexec.c
diff

src/sbbs3/xtrn.cpp
diff

(try to) Fix some Windows specific bits from the ringbuf change

Modified Files:


src/sbbs3/CMakeLists.txt
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makevdd.bat
diff

src/sbbs3/ringbuf.c
diff

src/sbbs3/ringbuf.h
diff

src/sbbs3/sbbs.jsdocs.vcxproj
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbsdefs.mk
diff

src/sbbs3/sbbsexec.vcxproj
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.vcxproj
diff

Remove RINGBUF_SEM for RINGBUG_EVENT

We've never really cared how many times the ring buffer has become
empty, how many times data was added to it, or how many times we've
been over the highwater mark.  These have effectively always been
event signalling, with extra hackiness to clear "extra" semaphore
posts.

This commit removes RINGBUF_SEM entirely, and uses events for
everything.  There's an empty event (set when the ring buffer is empty),
a data event (set when the ring buffer is not empty), and a highwater
event (set when the ring buffer has at least highwater mark bytes).

A RingBufWrite() will set data and highwater events if applicable,
and clear the empty event.

A RingBufRead() will set empty event and clear data and highwater
events if applicable.

RingBufReInit() will now set the empty event, and clear the data
and highwater events.

These are the only actions the RingBuf API will perform on the
events, it does *not* clear the highwater event on a RingBufWrite()
if the buffer does not have enough bytes in it for example, this
will *only* be done by RingBufRead() or RingBufReInit().  This
allows consumers to force specific behaviours (such as forcing
the highwater event on shutdown to prevent waiting for it).  Since
the current code was able to deal with the semaphores having
arbitrarily high counts, the existing code shouldn't have any
issue with this.

For things that want to shut something down, we're now setting both
the data and highwater events to ensure it doesn't wait for a
timeout (even for things that don't use highwater like the inbuf).
The RingBuffer API should grow a thing to do this (RingBufferFlush
perhaps?) rather than the consumers poking into the innards
arbitrarily.

Tested on the webserver and RLogin server and seems to be working
great.  sexyz builds.  It seems there's some Windows thing that
uses the ringbuffer sem for something, but I couldn't figure out
what... updated the build file, but no clue if that's broken or not
now... I'm sure DigitalMan will be happy to fix it if CI doesn't
catch it. ;)

This should allow the console object to grow a "flush" method that
will set the highwater and data events.

Modified Files:


src/syncterm/term.c
diff

Initialize mbuf too.

Modified Files:


src/syncterm/term.c
diff

Initialize pointer to NULL to avoid free()ing unallocated memory.

Modified Files:


src/syncterm/term.c
diff

Since we have the code to generate the correct gamma transfer, let's
not scale it in one colour space before translating it to a different
one.

Also, since almost all PPMs will use a maxval of 255, compile that
in as the default so we don't need to generate it.

Modified Files:


exec/syncterm-bounce.js
diff

src/conio/cterm.txt
diff

Use the new loaded PPM functionality.

Update the script to verify pixel operations are supported.

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.txt
diff

src/syncterm/term.c
diff

Update to support two copy buffers and one mask buffer.

Added Files:


exec/syncterm-bounce.js
diff

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/bitmap_con.h
diff

src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/conio/cterm.txt
diff

src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

Add support for PPM graphics to SyncTERM

You can copy whole, or portions of a PPM file from the cache directory
to the screen, optionally applying a mask.  The mask can be specified
as a base64-encoded bitmap or as a PBM file in the cache directory.

You can also copy portions of the screen into an internal buffer, and
draw from that internal buffer.  There's plans to support loading an
image file from the cache directory into the buffer as well.

Portions of the buffer can be copied to the screen, optionally
applying a mask as with drawing PPMs.

There's also plans to support copying a PBM file into a mask buffer.

I've added the syncterm-bounce.js script which simply bounces the
SyncTERM icon around the screen like the classic screensaver we all
hate.  I initially wanted to replace the spinning cursor with it,
but there doesn't seem to be a way to replace that with a script. :(

To use the script, just add the text:
@EXEC:syncterm-bounce.js@ to the end of your logon.js script.

Log in to nix.synchro.net with the latest nightly build or build from
git to see the script in action.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/conn.c
diff

src/syncterm/conn.h
diff

src/syncterm/conn_pty.c
diff

src/syncterm/conn_telnet.c
diff

src/syncterm/fonts.c
diff

src/syncterm/menu.c
diff

src/syncterm/ooii.c
diff

src/syncterm/ooii_bmenus.c
diff

src/syncterm/ooii_cmenus.c
diff

src/syncterm/ooii_logons.c
diff

src/syncterm/ooii_sounds.c
diff

src/syncterm/ripper.c
diff

src/syncterm/rlogin.c
diff

src/syncterm/st_crypt.h
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

src/syncterm/telnet_io.c
diff

src/syncterm/term.c
diff

src/syncterm/uifcinit.c
diff

src/syncterm/uncrustify.cfg
diff

There doesn't seem to be a way to get Uncrustify to put commas at
the start of wrapped function call continuation lines, but at the
end of struct initializers/enums/etc lines.  I think the least bad
is commas at the end, especially now that it's got the happy
four-space indent for continuations.

I may play with this more later, but this seems to be good for now,
we'll see how it works out in actual use.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/conn.c
diff

src/syncterm/conn.h
diff

src/syncterm/conn_pty.c
diff

src/syncterm/conn_pty.h
diff

src/syncterm/conn_telnet.c
diff

src/syncterm/conn_telnet.h
diff

src/syncterm/fonts.c
diff

src/syncterm/fonts.h
diff

src/syncterm/menu.c
diff

src/syncterm/menu.h
diff

src/syncterm/modem.c
diff

src/syncterm/modem.h
diff

src/syncterm/ooii.c
diff

src/syncterm/ooii.h
diff

src/syncterm/ooii_bmenus.h
diff

src/syncterm/ooii_cmenus.h
diff

src/syncterm/ooii_logons.h
diff

src/syncterm/ripper.c
diff

src/syncterm/ripper.h
diff

src/syncterm/rlogin.c
diff

src/syncterm/rlogin.h
diff

src/syncterm/ssh.c
diff

src/syncterm/ssh.h
diff

src/syncterm/st_crypt.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

src/syncterm/telnet_io.c
diff

src/syncterm/telnet_io.h
diff

src/syncterm/telnets.c
diff

src/syncterm/telnets.h
diff

src/syncterm/term.c
diff

src/syncterm/term.h
diff

src/syncterm/uifcinit.c
diff

src/syncterm/uifcinit.h
diff

src/syncterm/uncrustify.cfg
diff

src/syncterm/window.c
diff

src/syncterm/window.h
diff

Force space before pointer stars... too weird without it.

I tried a space after too, but that's weird as well and easily
confused with multiplication at first look.

Modified Files:


src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

src/syncterm/uncrustify.cfg
diff

And run it again.

Modified Files:


src/syncterm/amigafont.h
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/conn.c
diff

src/syncterm/conn_pty.c
diff

src/syncterm/fonts.c
diff

src/syncterm/menu.c
diff

src/syncterm/modem.c
diff

src/syncterm/ooii.c
diff

src/syncterm/ooii_bmenus.c
diff

src/syncterm/ooii_cmenus.c
diff

src/syncterm/ooii_logons.c
diff

src/syncterm/ripper.c
diff

src/syncterm/rlogin.c
diff

src/syncterm/ssh.c
diff

src/syncterm/st_crypt.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

src/syncterm/telnet_io.c
diff

src/syncterm/telnets.c
diff

src/syncterm/term.c
diff

src/syncterm/uifcinit.c
diff

src/syncterm/window.c
diff

And put two newlines (ie: one blank line) before a function

Modified Files:


src/syncterm/bbslist.h
diff

src/syncterm/conn.h
diff

src/syncterm/ripper.c
diff

src/syncterm/syncterm.h
diff

Some quick comma fixes

Modified Files:


src/syncterm/uncrustify.cfg
diff

Fix newlines before function

Modified Files:


src/syncterm/amigafont.h
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/conn.c
diff

src/syncterm/conn.h
diff

src/syncterm/conn_pty.c
diff

src/syncterm/conn_pty.h
diff

src/syncterm/conn_telnet.c
diff

src/syncterm/conn_telnet.h
diff

src/syncterm/fonts.c
diff

src/syncterm/fonts.h
diff

src/syncterm/menu.c
diff

src/syncterm/menu.h
diff

src/syncterm/modem.c
diff

src/syncterm/modem.h
diff

src/syncterm/ooii.c
diff

src/syncterm/ooii.h
diff

src/syncterm/ooii_bmenus.c
diff

src/syncterm/ooii_bmenus.h
diff

src/syncterm/ooii_cmenus.c
diff

src/syncterm/ooii_cmenus.h
diff

src/syncterm/ooii_logons.c
diff

src/syncterm/ooii_logons.h
diff

src/syncterm/ooii_sounds.c
diff

src/syncterm/ooii_sounds.h
diff

src/syncterm/ripper.c
diff

src/syncterm/ripper.h
diff

src/syncterm/rlogin.c
diff

src/syncterm/rlogin.h
diff

src/syncterm/ssh.c
diff

src/syncterm/ssh.h
diff

src/syncterm/st_crypt.c
diff

src/syncterm/st_crypt.h
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

src/syncterm/telnet_io.c
diff

src/syncterm/telnet_io.h
diff

src/syncterm/telnets.c
diff

src/syncterm/telnets.h
diff

src/syncterm/term.c
diff

src/syncterm/term.h
diff

src/syncterm/uifcinit.c
diff

src/syncterm/uifcinit.h
diff

src/syncterm/uncrustify.cfg
diff

src/syncterm/window.c
diff

src/syncterm/window.h
diff

I can't stand it anymore.

Run uncrustify on this mess.
There's a few small oddities (especially in enums), but this is
much better.