Synchronet Git Commit Log

Modified Files:


xtrn/bublbogl/game.js
diff

remove debug logging bits :|

Modified Files:


xtrn/bublbogl/game.js
diff

show month name in high score list

Modified Files:


xtrn/bublbogl/game.js
diff

xtrn/bublbogl/lobby.bin
diff

added "talk shit" feature

Modified Files:


src/sbbs3/js_global.c
diff

Fix multi-array version of socket_select() when using poll()

Previously, when multiple lists were passed, the "write" parameter
(which can't be changed) was applied to all sockets.  This means
they would always all be poll()ed for read, then checked for the
appropriate flag (read/write/priority)... which effectively meant
that only the first (read) array would work.

Modified Files:


src/sbbs3/js_socket.c
diff

Document the connect() callback thing.

Modified Files:


xtrn/minesweeper/graphics.ppm
diff

xtrn/minesweeper/minesweeper.js
diff

xtrn/minesweeper/selmask.pbm
diff

Play with selection-follows-mouse a bit.

Can't seem to get it reliable using the SBBS mouse parsing... doing
it all myself for now until I decide if it's neat enough.  I'll
need to try it from a remote location to see how the latenct impacts
playability.

Modified Files:


src/syncterm/ooii.c
diff

Replace non-ASCII characters with \xXX escaped ones.

Too many tools are gungo-ho over UTF-8 these days.

Modified Files:


src/conio/CMakeLists.txt
diff

src/xpdev/CMakeLists.txt
diff

Some CMakeLists.txt cleanup

Remove more of the obsolete stuff.

Modified Files:


src/syncterm/CHANGES
diff

Mention CMake changes

Modified Files:


src/conio/CMakeLists.txt
diff

src/conio/ciolib.c
diff

src/encode/CMakeLists.txt
diff

src/sftp/CMakeLists.txt
diff

src/syncterm/CMakeLists.txt
diff

src/xpdev/CMakeLists.txt
diff

Initial stab at making the macOS cmake build work

Modified Files:


src/syncterm/CHANGES
diff

Add NetBSD fix note

Modified Files:


src/conio/CMakeLists.txt
diff

src/conio/curs_cio.c
diff

src/xpdev/CMakeLists.txt
diff

Fixup NetBSD and OpenBSD builds

CMake is now fixed, and a NetBSD extra wait for key on exit with
the system curses is also fixed.

Modified Files:


src/conio/CMakeLists.txt
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/bbslist.c
diff

src/xpdev/CMakeLists.txt
diff

Make all listed build options optional in CMake builds

PC Speaker can't actually be disabled, so remove it from build options
listing.

Modified Files:


src/build/SynchronetMacros.cmake
diff

Compare project names instead of dirs.

Allows top-level wrapper CMakeLists.txt files to work (as long as
their project name is right).

Added Files:


src/syncterm/CMakeLists.txt.top
diff

Add top-level CMakeLists.txt for SyncTERM

Added Files:


src/sftp/CMakeLists.txt
diff

Add CMakeLists.txt for sftp

Modified Files:


src/conio/CMakeLists.txt
diff

src/syncterm/CMakeLists.txt
diff

src/xpdev/CMakeLists.txt
diff

Fix CMake system for SyncTERM

Modified Files:


src/conio/cterm.adoc
diff

Clarify that you can still set a macro with p2=0 (and p2=1).

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/vidmodes.c
diff

src/syncterm/CHANGES
diff

Fix memory leak in initializing vmem.

Much easier to fix it this way than to figure out why X11 needs to
init it before bitmap_con does.

Modified Files:


src/conio/x_events.c
diff

src/syncterm/CHANGES
diff

Undo part of the previous commit.

All of this code runs in the same thread, races aren't possible.

Modified Files:


src/conio/x_events.c
diff

src/syncterm/CHANGES
diff

Fix a potential race between drawing and discarding last buffer.

If the last is freed while the screen is being updated, and the use
after free bug is not detected, corruption could occur resulting in
bad areas of the screen that persists until the window gets an
expose event again, or the impacted pixels are updated again.

Possibly fixes an issue reported by nelgin via IRC.

Modified Files:


src/conio/win32gdi.c
diff

src/syncterm/CHANGES
diff

Remove cast-to-int in gdi_getscaling

This fixes bug 141, which is currently the last blocker for rc2.

Modified Files:


src/syncterm/CHANGES
diff

Document more changes.

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

More graphical fixes...

Force mouse support in graphics mode even if user disabled
it for the BBS.  It would be nice if mouse support in the menus
was a separate option than "terminal doesn't support mouse",
and we know the terminal supports the mouse when we detect
graphics mode.

Move top/margin/width calculations into separate functions.
For level 1, center the playboard.

Fix an apparent off-by-one drawing the title bar.

Modified Files:


src/sbbs3/js_file.c
diff

File.read() encodes base64, it doesn't decode.

Added Files:


xtrn/minesweeper/graphics.ppm
diff

xtrn/minesweeper/selmask.pbm
diff

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

Initial support for SyncTERM PPM/PBM graphics.

Hidden behind the graphics option for now since there's still
issues... the board is offset in the window, the level 1 board is
framed wrong (since the graphics are always 2 cols), and it doesn't
check the graphical resolution, so if you're in a weird mode, it
can break.

Also, the graphics are uninspired at best... just hacked them up
in Gimp.

Modified Files:


src/xpdev/xpbeep.c
diff

Since we can check at the menu now, we don't need this warning.

Modified Files:


src/syncterm/term.c
diff

Fix SAUCE date properly... avoid writing past the end of the buffer

Modified Files:


src/xpdev/Common.gmake
diff

src/xpdev/GNUmakefile
diff

Fixups for build changes.

Sneaky hiding extra interesting bits at the end like that. :(

Modified Files:


src/syncterm/bbslist.c
diff

Fix the macro used to detect X11.

NO_X is defined in the ciolib GNUmakefile.  DISABLE_X11 is defined
on Common.gmake.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/Manual.txt
diff

src/syncterm/bbslist.c
diff

src/xpdev/Common.gmake
diff

src/xpdev/GNUmakefile
diff

src/xpdev/xpbeep.c
diff

Add a "Build Options" menu item.

Useful to check if SyncTERM was built with or without specific
features.

Modified Files:


xtrn/bublbogl/boggle.bin
diff

xtrn/bublbogl/lobby.bin
diff

xtrn/dicewarz/dicewarz.bin
diff

xtrn/dicewarz2/lobby.bin
diff

xtrn/maze/fog.bin
diff

xtrn/maze/lobby.bin
diff

xtrn/synchronetris/lobby.bin
diff

xtrn/uberblox/game.js
diff

xtrn/uberblox/gameend.bin
diff

xtrn/uberblox/lobby.bin
diff

update more ansi (links, names, some column widths, etc)
increase player name width in uberblox lobby

Modified Files:


src/conio/x_events.c
diff

Fix some more warnings when not using optional features.

Modified Files:


src/syncterm/CHANGES
diff

Add note about WM_SETCUSOR fix

Modified Files:


src/conio/OverhaulNotes.txt
diff

src/conio/win32gdi.c
diff

Fix issue 146

Fix return value when handling WM_SETCURSOR.  Returning FALSE
indicating we didn't handle it stopped the cursor from being set
to the size arrow cursors.  Instead, pass it to DefWindowProc().

While we're here, handle WM_SIZING to make it more clear that you
can't change the aspect ratio by dragging.

Added Files:


xtrn/dicewarz/exit.bin
diff

Modified Files:


xtrn/bublbogl/exit.bin
diff

xtrn/dicewarz2/exit.bin
diff

xtrn/maze/exit.bin
diff

xtrn/starstocks/exit.bin
diff

xtrn/synchronetris/exit.bin
diff

xtrn/uberblox/exit.bin
diff

updated exit splash screens with new repository url

Modified Files:


src/conio/x_events.c
diff

Fix warnings in last commit.

Modified Files:


src/conio/x_events.c
diff

Refine last commit...

Add a comment explaining why we do what we do, and verify the aspect
is unchanged as well since we could change only the aspect and need
to set new hints in some cases.

Modified Files:


src/conio/x_events.c
diff

If we're not mapping, only XSetWMNormalHints() if it's different.

Modified Files:


src/conio/x_events.c
diff

Never call XMapWindow() in response to a _NET_FRAME_EXTENTS change

This breaks at least herbstluftwm's focus-follows-mouse, and rustles
Cyan's jimmies.

It's also a terrible idea.

Modified Files:


src/syncterm/term.c
diff

Fix last commit.

Modified Files:


src/syncterm/syncterm.c
diff

Fix bool inversion introduced by 8f7cfadf44

quitting needs to be set to true, not false when quitting. :(

Modified Files:


src/syncterm/term.c
diff

Fix bug generating SAUCE date introduced by commit dcf8c35f9b

Using snprintf() prevents the last character of the date from
being put into the string.

Modified Files:


src/conio/x_events.c
diff

Actually don't call XSetICFocus() at start. :(

Modified Files:


src/syncterm/CHANGES
diff

Update CHANGES for rc2

Modified Files:


src/conio/x_cio.c
diff

src/conio/x_events.c
diff

src/conio/x_events.h
diff

Have the IC focus follow the X11 focus

Basically, If we get a FocusOut, call XUnsetICFocus(), and if we
get a FocusIn, call XSetICFocus().  Since we're doing this, don't
call XSetICFocus() unconditionally at start, wait for the server
to send us the initial FocusIn instead.

The only bit I'm not sure of is if I got the times to ignor
messages right... see here:
https://tronche.com/gui/x/xlib/events/input-focus/normal-and-grabbed.html
If you want to check my work.

May fix the focus follows mouse issue reported by Cyan.

Modified Files:


src/syncterm/syncterm.c
diff

Add missing period in "Upgrade detected" help text.

Modified Files:


src/conio/win32gdi.c
diff

Fix reversed mouse wheel on Win32GDI...

From MSDN:
A positive value indicates that the wheel was rotated forward
away from the user; a negative value indicates that the wheel
was rotated backward, toward the user.

Fixes bug 143.

However, this re-opens the confusion around request 75...
nigel and DigitalMan should take a look at this more closely
in rc2 (or an updated nightly).

Modified Files:


src/conio/OverhaulNotes.txt
diff

src/syncterm/Manual.txt
diff

Add "Persistant State" section to manual.

This describes in more detail how the window size is saved and
restored when starting/exiting SyncTERM.

Modified Files:


src/sbbs3/mailsrvr.c
diff

MIME-encode words that contain non-ASCII values in text header fields

(e.g. to, from, subject) ... when transmitting to other hosts (e.g. POP3
clients or other SMTP hosts).

For messages that contain CP437 or UTF-8 chars in these fields and were *not*
imported into the BBS via SMTP or POP3, these header fields would be
transmitted to other hosts with the raw CP437 or UTF-8 chars, thus violating
POP3 and SMTP protocols and likely resulting in garbage displayed in message
readers.

The fix is to encode (using MIME "encoded words", per RFC 2407) where
necessary.

Since moderm mail clients (e.g. Thunderbird) don't see to support CP437
charset in MIME encoded header fields, always translate to UTF-8 first.

We probably should be translating message body text to UTF-8 as well, for
maximum compatibilty with modern mail readers, but this commit doesn't address
body text issues with CP437-encoded content. That'll come later.

Modified Files:


src/syncterm/ripper.c
diff

Fix builds that don't support any graphics.

Modified Files:


src/encode/GNUmakefile
diff

src/hash/GNUmakefile
diff

src/sftp/GNUmakefile
diff

src/smblib/GNUmakefile
diff

src/uifc/GNUmakefile
diff

src/xpdev/GNUmakefile
diff

As it turns out, ciolib isn't special.

We can't update a fat static library using ar on macOS. :(

Modified Files:


src/syncterm/ripper.c
diff

Fix a couple use-after-free bugs in RIP

This likely is the cause of bug 140.

The first one, the LCF flag is copied out of the cterm struct
after cterm_end() is called (which frees the struct).  Copy moved
to before cterm_end().

The second one is trickier... it's executing the commands in a mouse
button, and one of the commands is to delete all the mouse button
commands.  This ends up free()ing the string that's currently being
parsed while it's being parsed.  We now use a strdup() of the string
which we free at the end of the function.

Modified Files:


src/syncterm/ripper.c
diff

src/syncterm/ripper.h
diff

src/syncterm/term.c
diff

src/syncterm/window.c
diff

Fix status bar issue when RIP changes the number of lines.

RIP is currently the only thing that can change the number of lines
in the terminal while connected.  This can actually result in there
being more lines on the screen than the last set video mode supports.

There's a "feature" in SyncTERM text modes (curses, ANSI, and Win32
Console) where if the screen mode is "current", it uses the number
of lines in the terminal, but if it's anything else, it forces the
number of lines to the lines in the mode.

This works great until RIP increases the number of lines beyond the
number in the mode... when this happened, RIP would draw the status
bar at the incorrect location on the screen.

This change no longer sets the max rows in the terminal if the
backend can set individual pixels (required for RIP).  Further, to
avoid a delay before redrawing the status bar after RIP changes the
number of rows, the reinit_screen() function now sets a global to
indicate it was called, and the status bar will always redraw when
it's enabled and the flag is true.

This *may* be related to bug 140, but may not be.

Modified Files:


src/conio/OverhaulNotes.txt
diff

src/conio/win32gdi.c
diff

Fix issue 138

Weird stuff happened when dragging a GDI window between monitors
with different zoom (DPI) settings.  The following changes were
all done to clean up this stuff:

Window position is signed
Do some type casting for warnings
Fix return times of GetDpiFor*() pointers
Fix fallback to GetDpiForSystem() (could never be used)
Handle WM_DPICHANGED correctly
Move some copy/pasted code into a function
Fix return value for WM_GETDPISCALEDSIZE
Fix return value for WM_USER_SETCURSOR

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/syncterm.c
diff

Enable new reverse_cursor UIFC option for SyncTERM

Thanks DigitalMan!

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

Add uifcapi_t.reverse_cursor (BOOL), default is FALSE

Setting this to TRUE reverses the type of cursor used to indicate insert
versus overwrite mode (solid/block cursor veruss underline/normal cursor).
Deuce probably wants to set this to TRUE for SyncTERM.

Modified Files:


src/syncterm/CHANGES
diff

Mention insert mode change

Modified Files:


src/conio/cterm.txt
diff

cterm.txt is no longer the normative reference for cterm.

Add a link to the new generated HTML document, and mention the .adoc
file so people can find it in the future.

Modified Files:


src/syncterm/syncterm.c
diff

Start UIFC in insert mode.

Per comment on reddit by dialsoft, the lack of an insert key on
laptops can make manipulating the phonebook more difficult.  Since
all the other UIFC functions have an insert alternate, they don't
need any changes now that there's a manual, but for editing a
string, the insert key is the only way to toggle overstrike.

Since the insert mode toggle persists, simply starting in overstrike
mode should be fine.

Maybe some weird control key of function key can be used (though
I guess laptops don't have function keys either anymore).

Modified Files:


src/syncterm/Manual.txt
diff

Manual updates.

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

And this isn't.

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

And this is RC1

Modified Files:


src/syncterm/Manual.txt
diff

src/syncterm/updvers.sh
diff

Put the full version number into Manual.txt

I'll want to generate a version-specific one on release, and want
to ensure it's consistent.

Modified Files:


src/conio/cterm.c
diff

Bump revision.

I need to document when I should do this better.

Modified Files:


src/syncterm/updvers.sh
diff

Add reminder to bump cterm revision on version update.

I guess that could be mostly good enoughish.

Modified Files:


src/conio/cterm.adoc
diff

Add reference to STD-070.

Modified Files:


src/sbbs3/atcodes.cpp
diff

include petdefs.h (needed for PETSCII_UPPERGRFX definiton)

Added Files:


src/conio/ciolib.adoc
diff

Modified Files:


src/syncterm/Manual.txt
diff

Add a user document for ciolib, and add it to SyncTERM manual.

Added Files:


src/conio/cterm.adoc
diff

Modified Files:


src/syncterm/Manual.txt
diff

Include CTerm doc in SyncTERM doc

Modified Files:


src/conio/cterm.c
diff

src/syncterm/CHANGES
diff

src/syncterm/Manual.txt
diff

More doc updates.

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add PETGRFX @-code to send char 142 (enter PETSCII upper/graphics char set)

... when PETSCII terminal in use.

For those sysops using editors that don't automatically or easily add this
character to their SEQ art files when needed.

Modified Files:


src/conio/Common.gmake
diff

src/xpdev/Common.gmake
diff

Add SDL_FRAMEWORK_PATH to rpath.

Apparently, /Library/Frameworks isn't searched by default anymore?

Added Files:


3rdp/build/js-include-headers.patch
diff

Modified Files:


.gitlab-ci.yml
diff

3rdp/build/GNUmakefile
diff

Fix config test for va_copy() on darwin.

Because the appropriate header wasn't included, there was no
prototype.  Not having a prototype is an error in C99, which caused
the test to indicate that there was no va_copy() on darwin.

This in turn caused jsprf.cpp to try to copy a va_list using
assignment.

This is invalid, so the compiler would normally return an error.

Somwhere in here, that error became a clang crash (not trivially
reproducable).

At the end of the day, ancient broken tests in config caused the
darwin Spidermonkey builds to fail.  The new patch fixes up the
configure tests, and darwin Synchronet builds are re-enabled.

Modified Files:


src/conio/cterm.txt
diff

Oh, cterm.txt was wrong w.r.t. APC vs. APS too

Modified Files:


xtrn/termtest/termtest.js
diff

Fix APC/SOS naming.

Thanks Ree!

Modified Files:


src/syncterm/Manual.txt
diff

More manual fiddling.

Modified Files:


src/syncterm/Manual.txt
diff

Remove incorrect escaping.

Modified Files:


.gitlab-ci.yml
diff

clang 16.0.0 crashes when building JS... unhook from builds.

Modified Files:


src/syncterm/Manual.txt
diff

Convert to asciidoc

Modified Files:


src/syncterm/syncterm.man.in
diff

Update manpage

Added Files:


3rdp/build/js-int-main-conf.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Fix up configure for platforms that don't use configure.in

Give simple test code a return type (default int isn't valid in C99)
and make some fallback tools executable.

Modified Files:


src/conio/x_events.c
diff

Fix build when XRandR is available, but Xinerama isn't.

Modified Files:


src/sbbs3/GNUmakefile
diff

Remove elfctl calls... they don't help.

Modified Files:


src/conio/sdl_con.c
diff

Fix build.

Whoops.

Modified Files:


src/conio/sdl_con.c
diff

Update fullscreen and mode on Darwin to match window

This should normalize everything, with the possible exception of
"zoom" (the thing other OSs call maximized).  Ideally, we wouldn't
allow window size changes when "zoomed" if we could detect the state,
but it doesn't look like we can.

Modified Files:


src/conio/GNUmakefile
diff

Apparently ar can't update this when it's fat.

Hopefully this is the only lib like this (maybe the resources?)

Modified Files:


src/conio/sdl_con.c
diff

src/conio/sdlfuncs.c
diff

src/conio/sdlfuncs.h
diff

Use SDL_GetWindowSizeInPixels, and don't resize when maximized

Fixes sourceforge issue 126 (finally!)

Apparently, macOS "maximized" is the same as "fullscreen" in SDL.

Modified Files:


src/syncterm/ssh.c
diff

Destroy ssh_tx_mutex

Modified Files:


src/syncterm/ssh.c
diff

No no, *DESTROY* sftp_tx_mutex

Modified Files:


src/sbbs3/logon.cpp
diff

Always close csts.ini file, even in error path (failure to open dsts.ini)

Fix for CID 509720

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

Free ini string list in error path (no sectinos exist)

Fix CID 509721

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix potential null pointer dereference

strListReadFile() can return NULL upon error

Modified Files:


src/syncterm/ssh.c
diff

Be sure to close ssh_sock regardless of ssh_active

Modified Files:


src/syncterm/ssh.c
diff

Some more ssh_close() cleanup

Make ssh_active only true when ssh_session was set.
Only do ssh cleanup if ssh_active is true.
Initialize channel values to -1 (already done in ssh_connect(), but
doesn't hurt anything).

Modified Files:


src/syncterm/ssh.c
diff

Fix sourceforge issue 136

With ssh_sock initialized to zero, if the connect fails, stdin was
closed, preventing ANSI and curses modes from functioning.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

Fix up handling of -b option

First, we need to parse it before load_settings() so we can deal
with it there.

Next, we need to keep the one from the config file available so it
is edited from the program settings, and not the command line version

Modified Files:


src/syncterm/syncterm.c
diff

src/xpdev/netwrap.c
diff

Fix some warnings, return false for zero-length strings.

Modified Files:


xtrn/termtest/termtest.js
diff

Send a backspace space backspace after shift in

Keeps the display cleaner when things work and the shift in byte
is displayed.  Should be harmless in cases where shift in is
interpreted per the standards.

Added Files:


src/syncterm/updvers.sh
diff

Add script to update version numbers in various files

Hopefully I'll be able to keep them all wrangled now.

Modified Files:


src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

Make syncterm_version const

Modified Files:


src/syncterm/Manual.txt
diff

src/syncterm/term.c
diff

More docs.

It's likely time to find a nice format that can be used to generate
HTML and PDFs and such now.

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix copy/paste error.

Modified Files:


src/sbbs3/GNUmakefile
diff

elfctl doesn't work on shared objects.

Modified Files:


src/sbbs3/GNUmakefile
diff

Looks like we do need both.

Modified Files:


src/sbbs3/GNUmakefile
diff

Call elfctl -e +noprotmax in binaries that do JS

Prevents crashes on modern FreeBSD systems that default to implicit
PROT_MAX in the JS code.
(It's possible that +wxneeded will be needed too.. still experimenting)

Modified Files:


src/xpdev/netwrap.c
diff

Fix Borland build.

Modified Files:


src/syncterm/Manual.txt
diff

src/syncterm/bbslist.c
diff

src/syncterm/conn.h
diff

src/xpdev/netwrap.c
diff

src/xpdev/netwrap.h
diff

Clean up and improve 6e516ae

The first entry I tried adding was "Example..." which was not a
valid hostname, but was copied into the address and looked silly.

Now only copies into address if it's a valid, usable hostname.

Also, add a convenience macro to check if a connection type uses
the network or not.

New functions in netwrap:
bool isValidHostname(const char *str);
bool isValidAddressString(const char *str);
bool isResolvableHostname(const char *str);

We ust the last one (which calls the other two) for this feature now.

Modified Files:


src/xpdev/str_list.c
diff

strListReadFile() now returns NULL on any file read failure

Previously, the partially-read lines would be returned in an allocated
string list. This is a suspected cause of issue #791: even though the file was
successfully opened exclusively (using sopen... SH_DENYRW), it's possible that
Samba had already allowed another client or local process to open the same
file, but is now a denying read (most likely, the first read). As Deuce
pointed out, the xpdev *nix implementation of sopen() locks the region/record
of the entire file. So before this change, strListReadFile() might fail on
the first read, and a function that uses iniFileRead() to modify the contents
of an ini file, might end up writing back the empty list (with added keys),
thus deleting all the existing content of the file.

Also in this change:
- Eliminated the unnecessary local/wrapped str_list_read_file() function.
- Elminate unecessary null-before-free check
- Fixed potential memory leak upon malloc failure (the potentially-allocated
  list wasn't freed).

Modified Files:


src/sbbs3/getstats.c
diff

fread_dstats() will now return false upon file read failure

The file position should always be at the EOF after reading the contents.

This should help detect (log errors) upon potential cause of issue #791.

- use a little easier to read .ini style
- add a NULL argument check to local function write_dstats()
  return false rather than deref the NULL pointer

Modified Files:


src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

Log an error upon read failure of dsts.ini and don't write changes back

Part of potential fix (or work-around) for issue #791

Modified Files:


src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

Log errors upon any dsts.ini write failures.

Modified Files:


src/sbbs3/userdat.c
diff

user_downloaded_file() now return false upon statistics update failure

Modified Files:


src/sbbs3/getstats.c
diff

Don't update/rewrite dsts.ini when iniReadFile returns NULL

Even if the empty, iniReadFile() should return an empty list (not NULL),
NULL indicates a file read (or unlikely malloc failure) - so don't write back
what we read and return false (result) instead.

Part of likely work-around of issue #791: it's better to not increment stats
upon a file read error than to reset them all to zero.

Modified Files:


src/sbbs3/js_file.c
diff

Add missing NULL pointer check to js_iniReadAll()

iniReadFile() can return NULL upon file read error or malloc error. Let's not
crash if that happens.

Modified Files:


src/sbbs3/writemsg.cpp
diff

Log a file "create" error if process_edited_file() returns a negative value

I discovered that sbbs_t::editfile() (exposed as JS console.editfile) just
silently failed if it couldn't write to the destination file
(e.g. permission denied by OS).

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Don't update displayed stats values if getstats() returns false (failure)

Use byte_estimate_to_str() to display upload/download byte totals (better
support for totals in gibibytes, tebibytes, etc.).

Modified Files:


3rdp/build/GNUmakefile
diff

src/build/Common.gmake
diff

Add support for fat Darwin builds...

Using FAT=1 one the make command-line

Modified Files:


exec/text_sec.js
diff

Add edit option when adding text files that don't already exist

Revisiting this script due to usability issues reported by W5jsn (TUCUMCAR).

Dynamically figure out the file path rather than storing another property
('path') in the list objects (which ends up in the .ini file). The absence of
the path property (when the file didn't exist) could result in script-ending
exceptions.

.ini files are supposed to be open for read/write access (even when just
writing), so open the file in "w+t" mode in write_list().

Clear console.aborted flag before menu listings: hitting Ctrl-C in some
point could display just header and prompt of lists with no contents.

Modified Files:


src/sbbs3/logon.cpp
diff

Clear the Guest user's language (lang) field during logon - revert to default

Modified Files:


src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/userdat.c
diff

Store debug information in dsts.ini to help solve cause of issue #791

This should help identify the function(s) used when the corruption occurs.

Modified Files:


src/sbbs3/getstats.c
diff

In debug builds only, backup dsts.ini file when opening for write

Hopefully help to determine cause of issue #791 (when is the apparent
corruption of this file occurring?)

Modified Files:


src/sbbs3/getstats.c
diff

Non-functional changes

iniWriteFile() returns bool, not int.

Removed inapplicable function comment.

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Cosmetic improvements to indication of user status (deleted/inactive)

This should address issue #787

Modified Files:


src/sbbs3/getstats.c
diff

Fix return value of fclose_dstats - not currently checked anywhere

fclose() returns 0 on success.

Modified Files:


src/sbbs3/getstats.c
diff

Fix comment header for putstats() - copy/pasted from getstats()

Modified Files:


src/sbbs3/js_msg_area.c
diff

Use JS_ValueToECMAUint32() instead of JS_ValueToInt32() for scan_ptr prop set

scan_cfg and last_read props too. This gives us use of the entire 32-bit range
of an unsigned int. But does someone actually have a message base with message
numbers in the billions?

This is an attempt to fix isssue #792, but I suspect scan_ptr might instead be
trying to be set to NaN or ... ?

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

DDFileLister: Fix for replacing cursor-right codes to allow finding & replacing
all of them in a string

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'dd_file_lister_replace_cursor_right_improvement' into 'master'

DDFileLister: Fix for replacing cursor-right codes to allow finding & replacing
all of them in a string

See merge request main/sbbs!461

Modified Files:


src/sbbs3/smbutil.c
diff

NUL-terminate the SMB fileidxrec_t.name field, just in case

The terminating NUL is actually part of the index record, but with file
corruption, it's technically possible the NUL could be missing.

Fixes CID 509554

Modified Files:


src/smblib/smbfile.c
diff

NUL-terminate the SMB fileidxrec_t.name field, just in case

The terminating NUL is actually part of the index record, but with file
corruption, it's technically possible the NUL could be missing.
Fixes CID 509552

Use strnicmp() insted of stricmp() in smb_removefile()
Fixes CID 509551

Modified Files:


src/sbbs3/text_defaults.c
diff

Update default CantPostMsg to match text.dat

Modified Files:


exec/load/shell_lib.js
diff

Check for console abort (Ctrl-C) in directory searching for loops

Multiple directory searching functions wouldn't terminate on Ctrl-C

Modified Files:


src/sbbs3/js_filebase.c
diff

Update JSDOC description of update() method

Clarify that this is the method to use to rename a file.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/listfile.cpp
diff

Only use liberal file pattern matching in the terminal server listfile funcs

Commit 3a3c889b (2 years ago now) changed loadfiles() to use liberal file
matching (e.g. "syncterm.exe" matched both "syncterm.exe" and
"syncterm_v1.2b.exe").

This could produce surprising results when doing file list querieis/operations
with the FileBase methods via JS (e.g. jsexec utils) and (now that I look at
it), the FTP server too.

So we should not have been doing liberal file matching *everywhere* loadfiles
is used, just where it was a usability issue (due to displayed filenames being
truncated to 12 chars for <=80 column terminals).

Now solved by add/use of new liberal_filepattern() function only in the
built-in file listing methods: sbbs_t::listfiles() and sbbs_t::listfileinfo().

Note: Custom JS file searching/listing scripts may now need their own
work-arounds for this usability issue, if they have it.

Modified Files:


src/sbbs3/listfile.cpp
diff

Use the liberal file matching to continue file listing/searches

If the user didn't supply a wildcard, only a single file (the first file
matching the liberal file pattern) would ever be listed in the file
listing/searches, even when multiple files in the directory matched the
liberal file matching pattern. This is not a new bug.

Modified Files:


exec/updatefiles.js
diff

Remove the always-on force option, replaced with new readdfiles.js

Added Files:


exec/readdfiles.js
diff

New script that just re-adds (updates index position/date-time) files

If you want to "touch" a file in the filebase (so it appears a new again)
this is the script to use to do that.

Modified Files:


exec/nntpservice.js
diff

Re-open closed message base for commands to use selected/open base

Should fix issue #790

Modified Files:


exec/webfileindex.ssjs
diff

Display the file index date-time instead of the file's date-time

Since sorting works on the file index record date-time (date/time added)
it was confusing to display dates that didn't always match the sort order.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: When displaying a file description, remove/replace cursor
movement characters, which can corrupt the display

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch
'dd_file_lister_description_remove_or_replace_cursor_movement_attrs' into
'master'

DDFileLister: When displaying a file description, remove/replace cursor
movement characters, which can corrupt the display

See merge request main/sbbs!460

Modified Files:


src/sbbs3/userdat.c
diff

Delete data/file/*.out directory for new user (if exists)

emailfiles.js puts files here that the user requested to download "via email"
and might not have been successfully delivered and deleted. So clean-up.

Modified Files:


exec/postmsg.js
diff

Add -F option to set file request attribute flag

to force SBBSecho to create a .req file (in FLO-mode), rather than send as
netmail.

For Keyop

Modified Files:


src/sbbs3/js_filebase.c
diff

src/sbbs3/js_msgbase.c
diff

Don't heap allocate argument to MsgBase and FileBase constructors

Nelgin reported a weird error with a failed very large allocation for the
base/code argument to the FileBase constructor. There's no good reason
these strings were heap-allocated in the first place, so just change to
use a stack allocated variable instead. I don't know why this would fix
anything, but at least there's one less heap allocation and potential
for memory leak here.

Fix 2 bugs in js_update_file():
1. missing parenthesis (really?!? Caught by Coverity - sigh) in last
commmit caused attempt/failure/error to remove file after making any
updates. The removing is only supposed to happen when its necessary to
remove and re-add the file to the filebase (e.g. updating extended
description or auxdata).
2. Wrong filename used in 'removing' exception string.

Modified Files:


exec/fileman.js
diff

When renaming a file (using F2 key), need to get all metadata before update

... otherwise, we'll erase the file's extended description or auxdata, if it
has any.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.h
diff

Add/use smb_removefile_by_name()

This fixes a filebase corruption issue that could be triggered by using
FileBase.update() to rename a file while also changing the file's auxdata or
extended description: you can't remove a file header that has the new filename
(in the file_t.name field), cause it doesn't exist yet. So we needed an SMBLIB
API function to pass the (original) filename instead. Much like the filedat.c
removefile() function, but without the SMB opening/closing feature.

Modified Files:


src/sbbs3/js_filebase.c
diff

Don't allow FileBase.update() to create a duplicate file

FileBase.update() will now throw an exception if attempting to rename a file
to a filename that already exists in the filebase index.

Prior to this change, one could (via JS methods) rename a file in the base to
create a duplicate filename which would corrupt the base (one index entry and
two header records for the same filename).

Modified Files:


src/smblib/smblib.c
diff

MSVC requires a 0 in the struct initializer

Modified Files:


src/sbbs3/js_file.c
diff

Eliminte weird gcc (12.2) warning in release build (only)

Increasing size of mode[] element by 2 bytes eliminated these GCC warnings
that seem like false-positives to me:

sbbs.h:194:48: warning: writing 1 byte into a region of size 0
[-Wstringop-overflow=]
  194 |
(ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
      |
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
js_file.c:225:25: note: in expansion of macro ‘JSSTRING_TO_STRBUF’
  225 |                         JSSTRING_TO_STRBUF(cx, str, p->mode,
sizeof(p->mode), NULL);
      |                         ^~~~~~~~~~~~~~~~~~
js_file.c:42:17: note: at offset 5 into destination object ‘mode’ of size 5
   42 |         char    mode[5];
      |                 ^~~~

Similar use of JSSTRING_TO_STRBUF in other files (js_console.cpp, js_archive.c)
(with larger target buffers) does not trigger the same warnings.

Modified Files:


src/smblib/smbdefs.h
diff

fileidexrec_t doesn't need to contain union

This served exactly no purpose (since the idxrec_t existed at the same
offset in both parts of the union). So this was just some weird artifact
from the new filebase development.

Modified Files:


src/smblib/smblib.c
diff

smb_getmsgidx() now reads entire index records from file bases too

chksmb needed this to perform filename checks (index against headers).

Modified Files:


src/sbbs3/chksmb.c
diff

Perform filename checks (index versus header fields) on filebases

I was able to corrupt a filebase using fileman.js, renaming a file
(the filename in the index as viewed with 'smbutil x' did not match
the filename listed with 'smbutil l') - yet, chksmb reported no errors
with the filebase.

Now chksmb will detect that type of corruption.

Modified Files:


src/sbbs3/js_filebase.c
diff

FileBase.update() method throws more exceptions upon error

This will help to determine cause of any file update (e.g. rename)
failures, as reported by Nelgin.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DD file lister: Check for null when getting extended metadata from the DB
(possibly caused by corruption). Also, allow changing the filename when editing
file info/metadata.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_get_extd_info_null_check_and_allow_edit_filename'
into 'master'

DD file lister: Check for null when getting extended metadata from the DB
(possibly caused by corruption). Also, allow changing the filename when editing
file info/metadata.

See merge request main/sbbs!459

Modified Files:


src/sbbs3/ctrl/ClientFormUnit.cpp
diff

src/sbbs3/ctrl/ClientFormUnit.dfm
diff

src/sbbs3/ctrl/ClientFormUnit.h
diff

Add keyboard shortcuts to Clients list view: Ctrl-A, Ctrl-F and Del

Ctrl-A - Select All
Ctrl-F - Filter IP address
DEL - Close Socket

Also, use Begin/EndUpdate() calls to batch updates to the ListView in Timer
tick (no visible difference, but it's the right thing to do).

I don't know why C++Builder increased the TextHeight value of this form from
13 to 15, but doesn't seem to really matter (or at least, I couldn't tell).

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Display horizontal splitter in the correct spot.

For who knows how long now, the horizontal splitter that allows the sysop
to control the size of the top 2 panels (server forms), was displayed above
the top panel, not between the top and bottom panel, thus making the panel
heights not controllable. Weird. Change the order of making the controls
visible to insure that the splitter is displayed below the top panel and
on top of the bottom panel.

Also (non-functional changes):
Remove redunant mutex from client_on() - makes no difference.
Use try/catch in client_on() to try to catch VCL exceptions - doesn't catch
the "invalid index" error popups that we see on occasion. <shrug>

Modified Files:


src/sbbs3/ctrl/MainFormUnit.dfm
diff

Change the height of the horizontal splitter to the minimum (1 pixel)

I don't know why this was set so wide (10 pixels), but that did help to easily
see that it was being placed in the wrong spot in the form (between the tool
button bar and the top panel). But we don't need it to be that thick. 1 pixel
is still enough to be able to grab it with the mouse and resize the top/bottom
panels.

Modified Files:


src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Fix crash due to use after free or double-free

... bug introduced in commit 29a35642160a7f4.

strListMerge() doesn't realloc the strings in the list, so we don't want to
free the strings in this list here.

This is likely the cause of the crash Keyop eluded to in #synchronet.

Modified Files:


exec/nntpservice.js
diff

Close any open message base after input timeout (5 minutes)

As Nelgin pointed out, the nntpservice can leave a message bases open while
a client is idle. Normally, an inactive client would be disconnected after 5
minutes of inactivity, so that wouldn't be much of an issue. However, if
authenticated as a user with the H-exemption, no auto-disconnection after
input timeout would happen. So let's close any open message base for good
measure.

The input/receive timeout probably should be configurable and lowered to
a smaller duration (one minute?). I'll leave that for another commit.

Modified Files:


exec/nntpservice.js
diff

Close an open message base after just 10 seconds of client inactivity

... and log a debug-level log message when doing so.

The current input/receive timeout duration (5 minutes) might be a bit long to
leave a message base open (though, there's no known issue with doing so). For
example, when users read message bases using the terminal server, they can sit
for much longer than 5 minutes reading an open message base.

Modified Files:


src/sbbs3/data_ovl.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Split-up the opening and writing of msg pointer files, to help debug issue

Reported by Keyop (upon being auto-disconnected overnight):
!ERROR 9 (Bad file descriptor) in data_ovl.cpp line 47 (putmsgptrs) writing
"message pointers" access=0

Unfortunately, the way putmsgptrs() was written, we couldn't tell if this was
an open (data/user/*.subs file) issue or a writing issue.

So create putmsgptrs_fp() and use that from sbbs_t::putmsgptrs(), so we can
log a different error (with more accurate details) if it's a file-open failure
versues a file-write failure.

Modified Files:


exec/websocketservice.js
diff

Fix #782 - websocketservice.js garbles input on Banana Pi running Armbian

Modified Files:


exec/websocketservice.js
diff

Merge branch 'ree/websocketservice-debug' into 'master'

Fix #782 - websocketservice.js garbles input on Banana Pi running Armbian

Closes #782

See merge request main/sbbs!458

Modified Files:


src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Blocked IP addresses in ip-silent.can weren't filtered from QWK and REP pkts

The "from_ip" header field of QWK messages is checked against blocked IP
addresses, but was only checking against IP addresses from ip.can, not any
addresses listed in ip-silent.can. These 2 list files are now merged together
for the purposes of filtering during QWK/REP packet import.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Refactor the function: unpack_bundle()

1. When a 0-length bundle file was encountered or an unpacking error occurred,
   any remaining bundles for the current search day-of-week (e.g. *.SU*) would
   be skipped/ignored. This bug (issue #764, regarding the 0-length file part),
   is fixed by not incrementing the day-of-week index in the main loop, but
   rather only incremeting the index when all bundles for the current
   day-of-week have been processed.
2. The age calculation for 0-byte/length bundle files was incorrect, so all
   0-length  bundle files would always be considered "less than 24-hours old"
   (and thus, never auto-deleted).
   This exacerbated the problem of issue #764 since it would persist until the
   0-length files were manually deleted. Fixed the file age calculation and
   now logging the date/timestamp of the 0-length file as well.
3. Don't do the switch/case/sprintf dance when we're not re-running a glob()
   search.
4. Replace the switch/case statement with an array of week day names/patterns.
5. Ignore (with a warning log message) any sub-directories of the inbound
   directory that happen to match the bundle file search pattern.
6. Use better variable naming.
7. Refer to files with a length of 0 as "0-length" instead of "0-byte" in log
   messages.

Modified Files:


src/sbbs3/chksmb.c
diff

Don't check header fields of deleted messages for control characters

... related to issue #786.

Also, don't check for a message-ID if the message-type does not match the
expected message type ("type mismatch").

Modified Files:


src/sbbs3/smbutil.c
diff

Indicate vote/poll messages and files (with details) when listing msgs/files

Add '-v' (increase verbosity) option, used to display msg dates and timezones
... when using the the 'l' (list messages) command (to view post date/time).
Use '-vv' or '-v -v' to see timezones of messages.

The -v option is now also applicable to the 'v' (view) messages command (now
redundant with the 'V' command).

Features as requested by Nelgin as part of issue #786.

Removed day-of-week from date/times displayed. We don't need that level of
user-friendliness with this tool.
However, we are also displaying 12h/am/pm times. Some sysops probably would
prefer 24hour time, so that should be considered at some point.

Modified Files:


docs/v320_new.txt
diff

More v3.20 changes documented

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/putnode.cpp
diff

Don't attempt to publish MQTT messages unless/until connected to broker

For cases where an mqtt struct is shared between threads without concurrency
control. I'm making this improvement in light of research into issue #781,
though I don't expect this change to fix the reported issue.

The reported error seems to come from the event thread (publishing node
status upon starting to run the "DAILY" event) when a broker connection was
not successful, however the reporter (Nelgin) may not have had debug-level
logging turned on, so didn't capture the successful broker-connect log
message. I think the broker connection *was* successful and perhaps then
terminated by the broker ("due to protocol error"?).

Modified Files:


src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

Track broker-connected status via Mosquitto connect/disconnect callbacks

I think this might fix issue #781. I suspect that SBBS (the MQTT client) is
being disconnected by the server ("due to protocol error") *after* the
call to mosquitto_connect_bind() is successful. We don't have any correponding
log output for this case, but at least we can track the connection status
accurately using the Mosquitto client callbacks and not try to publish when
we're not connected.

Modified Files:


exec/tickit.js
diff

Strip trailing whitespace off end of values read from .tic files

Fix issue #785

Modified Files:


src/sbbs3/logfile.cpp
diff

src/sbbs3/sbbs.h
diff

Add llprintf() to log a formatted line to the node.log and term server log

There's a whole lotta calls to sprintf() then logline() that could be reduced
with this function.

Modified Files:


ctrl/text.dat
diff

src/sbbs3/email.cpp
diff

src/sbbs3/postmsg.cpp
diff

Log more/better messages when message fails to post (e.g. duplicate detected)

It appears I had the idea to make the CantPost text.dat string a format string
before, but never quite finished that change (e.g. made the change to
email.cpp and text.dat too).

Modified Files:


src/sbbs3/qwktomsg.cpp
diff

Don't use QWK reply message date unless time zone is also specified

For regular user QWK Relpy packet uploads only, if no timezone is specified
(e.g. via @TZ kludge or HEADERS.DAT), then over-ride the message's "posted"
date/time with the current date/time since we're going to set the message's
timezone to the BBS's local timezone as well.

This is a fix for issue #783 reported by Chris Jacobs.

If/when we support user-specified timezones, then this likely would be a
place where we'd want to use the user's timezone.

Modified Files:


src/sbbs3/js_system.c
diff

Create system.tz_offset property; minutes east (+) or west (-) of UTC

From todo list on Vertrauen, not in GitLab (shrug)

Modified Files:


exec/load/dd_lightbar_menu.js
diff

dd_lightbar_menu.js: Fix for out-of-bounds row updates when updating the
scrollbar in DDLightbarMenu_UpdateScrollbar()

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_UpdateScrollbar_RowOutOfRange_Fix' into 'master'

dd_lightbar_menu.js: Fix for out-of-bounds row updates when updating the
scrollbar in DDLightbarMenu_UpdateScrollbar()

See merge request main/sbbs!457

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for saving an ANSI message to the local BBS PC (undeclared
variable error). Found by Amessyroom

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_save_ansi_message_fix' into 'master'

DDMsgReader: Fix for saving an ANSI message to the local BBS PC (undeclared
variable error). Found by Amessyroom

See merge request main/sbbs!456

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

ddfilelister: "Edit" item text on the bottom horizontal menu for
traditional/non-lightbar interface

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'ddfilelister_bottom_menu_edit_item_text_len' into 'master'

ddfilelister: "Edit" item text on the bottom horizontal menu for
traditional/non-lightbar interface

See merge request main/sbbs!454

Modified Files:


src/sbbs3/prntfile.cpp
diff

Fix NULL pointer deref in random_menu()

When no files with extensions are found, though they matched the glob()
pattern, a NULL pointer deref would result (segfault).

This could happen if the only files matching the pattern had no extenions or
were directories (not files).

Fix for issue #779

Modified Files:


src/sbbs3/getnode.cpp
diff

Don't call utime() on the node.dab file for every read

... this was the cause of some observed unnecessarily high disk/file server
(Samba) utilization, as we call getnodedat() a lot. utime() opens and closes
the file, which was already open - and we're not modifying the file, so
updating the 'modification time' here is wrong anyway.

Disabling this 21-year old bit of logic resulted in a pretty dramatic
reduction in Samba (smbd) CPU utilization on Vertrauen.

If a BBS actually needes this hack (e.g. for NFS compatibility, as Deuce
eluded in the comment), they'd be better off just setting the "Keep Node File
Open" node setting (in SCFG->Nodes) to "No".

Modified Files:


src/sbbs3/userdat.c
diff

Extend (and back-off) the user.tab record lock attempts

I'v been getting errors locking user.tab (for read) for a while (over samba),
so hopefully this helps. The lockuserdat() total timeout duration extends from
about 5 seconds to about 45 seconds (with an incremental back-off).

Implement the same lock-retry logic/limit in putuserdat().

Modified Files:


exec/telgate.js
diff

Add -N option to send blank line after connect

... requested by someone in #synchronet

Modified Files:


exec/init-fidonet.ini
diff

Fix the HobbyNet entry: Zone 954 is not a FidoNet (proper) address

Apparently, Mike Dippel's actual FidoNet address is 3:712/1321.5

Modified Files:


exec/load/diskusage.js
diff

exec/load/filelist_lib.js
diff

exec/load/gettext.js
diff

exec/load/install-3rdp-xtrn.js
diff

exec/load/nodedefs.js
diff

exec/load/presence_lib.js
diff

exec/load/shell_lib.js
diff

exec/load/termdesc.js
diff

exec/load/uifcdefs.js
diff

Remove executable attribute

Modified Files:


exec/addfiles.js
diff

exec/archive.js
diff

exec/badpasswords.js
diff

exec/default.js
diff

exec/delfiles.js
diff

exec/dupefind.js
diff

exec/emailfiles.js
diff

exec/examples/uifc.js
diff

exec/fido-nodelist-syncterm.js
diff

exec/filelist.js
diff

exec/fileman.js
diff

exec/filescancfg.js
diff

exec/hashfile.js
diff

exec/importcfg.js
diff

exec/inventory_archives.js
diff

exec/logon.js
diff

exec/mqtt_spy.js
diff

exec/noyesbar.js
diff

exec/postfile.js
diff

exec/rehashfiles.js
diff

exec/replace_text.js
diff

exec/simple.src
diff

exec/sysavail.js
diff

exec/tempxfer.js
diff

exec/testbuild.js
diff

exec/updatefiles.js
diff

exec/upgrade_to_v320.js
diff

exec/viewimsgs.js
diff

exec/webfileindex.ssjs
diff

exec/yesnobar.js
diff

Remove executable attribute

Modified Files:


src/sbbs3/sexyz.c
diff

src/sbbs3/xmodem.c
diff

src/sbbs3/zmodem.c
diff

src/sbbs3/zmodem.h
diff

Remove executable attribute

Modified Files:


exec/user_settings.js
diff

Defense against TypeError: xtrn_area.editor[thisuser.editor] is undefined

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Now supports editing file info (with the E key).

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_edit_file_info' into 'master'

DDFileLister: Now supports editing file info (with the E key).

See merge request main/sbbs!453

Modified Files:


src/sbbs3/upgrade_to_v319.c
diff

Removed Files:


src/sbbs3/sbbs4defs.h
diff

Eliminate unused file sbbs4defs.h

Modified Files:


src/sbbs3/telgate.cpp
diff

Log warning if sendsocket() fails to send string passed to telgate()

Eliminates GCC warning about not checking return value of write/sendsocket()

Modified Files:


src/sbbs3/telgate.cpp
diff

Fix small memory leak when telgate() was used to proxy for a telnet server

At least 512 bytes per call.

Modified Files:


exec/fido-nodelist-browser.js
diff

Includes swindows with unborked home/end key handling in lightbar. Fixes
problem reported by Nightfox.

Modified Files:


exec/fido-nodelist-browser.js
diff

Temporary fix to restore things on exit pending figuring out why the other way
doesn't work.

Modified Files:


exec/fido-nodelist-browser.js
diff

Restore cursor on exit; which should be happening via js.on_exit anyway but ...
isn't?

Modified Files:


exec/fido-nodelist-browser.js
diff

A faster, better looking, less janky version of the FTN nodelist
browser. Should be feature-equivalent with the old one, though
the navigation is a bit different.

If you don't like it, dig the old one out of git and run it from
some other location.

This is a build of:
https://gitlab.synchro.net/echicken/nodelist-browser
and it will be maintained there for now. I'll try to remember to
update this copy as needed. Do not edit / commit changes to this
file; it's transpiled from TypeScript and not meant to be edited
by hand. Do not read this file if you value your sanity.

Modified Files:


exec/load/sbbsdefs.js
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/telgate.cpp
diff

Add Telnet Gateway "Raw TCP" (TG_RAW) and "Expand Bare-LF to CRLF" TG_EXPANDLF

The expansion of LF to CRLF (with TG_EXPANDLF) is on receive.

For Nelgin

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Updates to fix new user newscan, depending on the scan_ptr value

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_new_user_scan_ptr_fix' into 'master'

DDMsgReader: Updates to fix new user newscan, depending on the scan_ptr value

See merge request main/sbbs!452

Modified Files:


exec/rlogin.js
diff

exec/telgate.js
diff

Add support for -v (verbose) option and modopts.ini

Don't display remote host name/addr unless -v option is specified or
verbosity=1 is set in modopts.ini.

Allow the displayed messages to be customized or disabled as the sysop wishes
via modopts.ini keys:
- help_msg
- connecting_msg
- failed_connect_msg
(e.g. set to a blank string to disable)

The following settings are also now configurable via modopts.ini:
- quiet (correlates with -q option)
- pause (correlates with -P option)
- clear (correlates with -C option)
- timeout (correlates with -T option)
- verbosity (correlates with -v option)

... a sysop can control the default behavior of all invocations of telgate.js
or rlogin.js via a single file now (modopts.ini).

The rlogin.js module will first look ing for the [rlogin] section in
modopts.ini and if it doesn't exist, then [telgate] section. telgate.js just
looks for the [telgate] section.

For the #synchronet irc crew: Nelgin and Keyop

Modified Files:


src/sbbs3/node.c
diff

Fix usage of "node list <node_num> <node_num> [...]"

Only the last node number specified would be listed before this fix.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix CIDs 508283 508284 508285 508286 508287

HANDLE_PENDING() macro returns from the calling function (without freeing
allocated resources), so don't use that here.

Modified Files:


src/sbbs3/telgate.cpp
diff

Fix CID 508288 (STRING_NULL)

I'm not clear why Coverity suddenly thinks that getstr() doesn't
nul-terminate strings, but whatever: NUL-terminate the buf before passing it
to getstr(). <shrug>

Modified Files:


exec/telgate.js
diff

Send CRLF terminated strings with -S option instead of CR-terminated

Telnet requires CRLF or CR/NUL instead of bare CR.

Removed Files:


xtrn/bullshit/bullshit-lib.js
diff

xtrn/bullshit/bullshit.ini
diff

xtrn/bullshit/bullshit.ssjs
diff

xtrn/bullshit/readme.txt
diff

These files no longer needed with new version.

Modified Files:


xtrn/bullshit/999-bullshit.xjs
diff

Basically the same as before, but without the help of bullshit-lib.js.
Untested.

Modified Files:


xtrn/bullshit/bullshit.js
diff

bullshit v4 build as in-place replacement for v3. On first run under the
terminal server, your old bullshit.ini settings will be migrated to
ctrl/modopts.d/bullshit.ini in a slightly different format.

Added Files:


xtrn/bullshit/.babelrc.json
diff

xtrn/bullshit/.devcontainer/devcontainer.json
diff

xtrn/bullshit/.gitignore
diff

xtrn/bullshit/Readme.md
diff

xtrn/bullshit/package-lock.json
diff

xtrn/bullshit/package.json
diff

xtrn/bullshit/src/bullshit.ts
diff

xtrn/bullshit/src/lib/UI.ts
diff

xtrn/bullshit/src/lib/list.ts
diff

xtrn/bullshit/src/lib/options.ts
diff

xtrn/bullshit/tsconfig.json
diff

Bullshit v4 (source & tooling).

This is a rewrite of the Bullshit bulletin lister. Should have all
the same features as v3, but much faster at lightbar navigation
and especially better at scrolling large files. (frame.js has been
replaced here by my new screen management library, 'swindows'.)

Sysops don't need to concern themselves with the files in this
commit; the build generated from these has been placed in the same
location as the old 'bullshit.js' script. Just copy that one to
wherever you normally run this from and it'll take over. Or you
could run Bullshit from the repo if you like to live dangerously.

Modified Files:


exec/tickit.js
diff

Change log level of "already exists" log messages from ERROR to WARNING

Fix issue #773

Modified Files:


src/sbbs3/node.c
diff

Fix the 'node list' command

No longer claim that 'list' is the default action (it's not).

If you want to list nodes, you need to specify the 'list' action.

Fix for issue #772

Modified Files:


exec/telgate.js
diff

Fix the mode passing to bbs.telnet_gate() - never undefined value

bbs.telnet_gate() is not tolerant of receiving an undefined parameter value
(while bbs.rlogin_gate() is), so this messed up the subsequent argument
parsing which caused the strings pushed with the '-s' or '-S' options to
not work.

Fixes issue #774

Modified Files:


exec/rlogin.js
diff

Fixed typo

Modified Files:


exec/telgate.js
diff

Support more command-line options, like -p, -C, -T, -m ala rlogin.js

Includes new feature to optionally send string(s) to remote server after
connecting (for Nelgin).

The -q option addition fixes issue #771.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/telgate.cpp
diff

Add optional array argument to bbs.telnet_gate() and bbs.rlogin_gate()

If an array argument is passed to these methods, the stringified contents of
each array element value will be sent to the remote server after connecting.

This is to support Nelgin's request of sending some strings to a server after
connecting. There's no way to insert pauses between the sent strings or wait
for certain output from the remote - that's beyond this scope/capability.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: New msgSaveDir option to specify a default dir to save messages to
(for the sysop)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_default_save_path_option' into 'master'

DDMsgReader: New msgSaveDir option to specify a default dir to save messages to
(for the sysop)

See merge request main/sbbs!450

Modified Files:


src/sbbs3/ansiterm.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/sbbs.h
diff

Rename sbbs_t::ungetstr() and JS console.ungetstr() to ungetkeys()

... since these methods only feed the keyboard buffer.

Add an optional 'insert' argument to console.ungetkeys() - default is false
(append).

Add a new version of console.ungetstr() which feeds the passed characters
directly to the receive input buffer. Now returns bool indicating success.
Existing scripts (if any) that use console.ungetstr() should continue to work
just fine.

This is anticipation of telgate.js being able to stuff strings (e.g. username,
password) into the input buffer and those chars/keys being passed to the
remote (gatewayed) telnet server. Since the telnet gateway reads directly from
the receive input buffer (ignoring the keyboard buffer), we needed a way to
stuff strings of characters into the receive input buffer directly and that
sort of exposed the weirdness of the existing console.ungetstr() method:
- it didn't return a return value (not indication of failure)
- it didn't support an 'insert' operation (even though the underlying C++
  method does)
- it didn't use the sbbs_t method that already existed for feedding a string
  of characters into the input/keyboard buffer

Modified Files:


src/sbbs3/js_global.c
diff

Global JS exit() function now sets 'exit_code' to 0 by default

Calling exit() causes JS_ExecuteScript() to return false (same return value
as if there's a syntax error) - so if we always set exit_code in exit()
(even when not passed a parameter) and then use that exit code if the property
is defined, then we get the -1 return value from js_execfile() if the script
is terminated prematurely without using exit().

This fixes the issue introduced in the previous commit where scripts that
call exit() - without any parameters, were causing errors to be logged about
scripts (e.g. timed events) returning -1.

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/main.cpp
diff

Fix infinite loop of error msgs/notifications when JS shell has syntax error

js_execfile() now returns -1 when JS_ExecuteScript() return false (failure).

The main command-shell loop will now terminate when js_execfile() returns
anything but 0 (success), similar to how PCMS (Baja-compiled) command-shell
.bin file parse errors are handled.

Modified Files:


src/sbbs3/readmail.cpp
diff

Save/reuse the mail save path/filename as a user property (in data/user/*.ini)

This is a fix for issue #340

Another idea would be to store a history of mail save paths and allow the user
to scroll through them/choose with the up and down arrow keys, but that goes
beyond the original feature request. So this just stores/reuses the last
successfully used path/filename.

Modified Files:


exec/load/shell_lib.js
diff

Prompt to clear the batch download queue if user chooses not to download files

Some users may have unintentionally added files to their batch download queue
and not know how to clear the queue manually, so prompt here for user
friendliness/convenience.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Make argument to bbs.batch_clear() optional (clear downlaod queue by default)

... as appears to have been the intent

Modified Files:


src/sbbs3/js_internal.c
diff

Fix CID 508259:  Control flow issue  (DEADCODE)

... introduced in commit 54523145

Modified Files:


src/sbbs3/js_msgbase.c
diff

Fix CID 508260:  Null pointer dereference

And really, more importantly, the msg header field_list array length would
always be interpretted as 0-length!

... introduced in commit 54523145

Modified Files:


src/sbbs3/node.c
diff

Display usage help when unrecognized param is detected

Include -pause and -loop options in usage help output.

Don't delay (sleep) one second when looping and -pause option is used.

Flush the output before waiting for key-press (-pause option is used).

This should all address issue #365. Sorry for the long wait.

Modified Files:


ctrl/text.dat
diff

StartXferNow string now contains argument (%s) for the protocol name

This is helpful when auto-starting a download using the user's pre-selected
default download protocol, reminds the user to start the appropriate transfer
protocol on their end (when necessary).

Goes along with the previous commited fix to issue #767

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/text_defaults.c
diff

Don't display menu of file xfer prots when auto-selecting user's default prot

When a user has a "default download protocol" selected (configured for their
user account), don't display a menu of file transfer protocols when we're
just going to auto-select their default anyway (e.g. when downloading a QWK
packet).

This change also introduces an argument (%s, the protocol name) in the
StartXferNow text.dat string, so that if/when the user forgets which default
download transfer protocol they had selected, they'll be reminded ("oh yeah,
I need start an XMODEM download!").

This fixes issue #767

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_conio.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/websrvr.c
diff

Prevent NULL pointer dereference when 'null' object passed to JS functions

As was discovered as part of investigation into issue #769, a JavaScript
could crash SBBS (cause a segfault) due to a NULL pointer dereference when
the script passes 'null' to native JS functions where an object is expected.

The issue raised was with console.gotoxy(), but it turns out that *many*
Synchronet native JS functions would call JSVAL_TO_OBJECT() and then, without
checking for NULL/nullptr, pass its return value to JS api functions such as
JS_GetPrivate, JS_GetProperty, JS_GetClass, JS_ObjectIsFunction,
JS_IsArrayObject, JS_GetArrayLength, JS_DefineProperty, JS_Enumerate, etc.
All of these JS API functions dereference the passed object pointer without
NULL/nullptr checking.

The fix here is to either call JSVAL_IS_NULL() or JSVAL_NULL_OR_VOID() and
if true, not call JSVAL_TO_OBJECT() and/or check the return value for the NULL
value before using as an argument to any other JS API functions.

Modified Files:


src/sbbs3/js_console.cpp
diff

Better invalid argument reporting (null object) from js_gotoxy()

The calling script will still terminate if it does this, but at least the
caller will get a useful JS exception.

Related to fix for issue #769

Modified Files:


src/sbbs3/js_console.cpp
diff

Fix potential null object pointer passed to JS_GetProperty in js_gotoxy()

I'm not sure under what script conditions this could happen, but apparently
Nelgin was able to produce this null pointer deref (and segfault) using
DDMsgReader. This should fix issue #769

Modified Files:


exec/imapservice.js
diff

Fix messages with blank bodies not showing up on iphone

Modified Files:


exec/imapservice.js
diff

Merge branch 'fix_blank_imap_body' into 'master'

Fix messages with blank bodies not showing up on iphone

See merge request main/sbbs!449

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader Fix: Indexed newscan mode for new users now shows the number of new
messages in sub-boards like it's supposed to. Reported by Nelgin.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_indexed_newscan_num_new_msgs_fix' into 'master'

DDMsgReader Fix: Indexed newscan mode for new users now shows the number of new
messages in sub-boards like it's supposed to. Reported by Nelgin.

See merge request main/sbbs!448

Modified Files:


xtrn/lemons/level.js
diff

Select the thing and do the thing.

Modified Files:


exec/dyndns.js
diff

Allow password to be read from modopts.ini [dyndns] 'password' key

Overrides whatever is passed on the command-line. Works around issue of '%'
character included in password bein interpretted as a command-line specifier
(e.g. %s).

Increment revision to 2.0.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Make the [BBS] MaxSessionInactivity 10m (not 0), when not set in sbbs.ini

We've had this value as the default in sbbs.ini for a while now, so should be
safe to use as the upgrading-sysop (who wouldn't have this value in their
sbbs.ini file, most likely) setting.

Not all default sbbs.ini values are true "defaults" (meaning, if they don't
exist in the file, then same value would be used) - but we should do an audit
and correct those mismatches at some point.

Modified Files:


src/sbbs3/getkey.cpp
diff

Better support for a blank ("") text.dat AreYouThere string

If a sysop doesn't want this warning to do anything, then no need to save
and restore the current (last displayed) line of text.

Modified Files:


src/sbbs3/main.cpp
diff

Log a warning if any socket inactivity max durations are shorter/equal to ...

to the getkey inactivity timeout.

By setting a socket timeout shorter or equal to the getkey timeout, the getkey
timeout effectively does nothing.

Modified Files:


src/sbbs3/scfg/scfgsrvr.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgsys.c
diff

Help text updates, particularly around socket inactivity timeouts

See issue #765 for background.

Modified Files:


xtrn/mrc/mrc-client.js
diff

Missing quote mark added.

Modified Files:


xtrn/mrc/mrc-client.js
diff

Merge branch 'mrc_fix_missing_quote' into 'master'

Missing quote mark added.

See merge request main/sbbs!446

Modified Files:


xtrn/mrc/mrc-client.js
diff

Add ssl support for server to server connections.

Modified Files:


xtrn/mrc/mrc-client.js
diff

Merge branch 'mrc_ssl' into 'master'

Add ssl support for server to server connections.

See merge request main/sbbs!445

Modified Files:


exec/text_sec.js
diff

Check console.aborted flag in display loops

So that hitting 'N' at pause prompt will abort the loop.
Reported by phigz via irc.synchro.net

Modified Files:


xtrn/mrc/mrc-client.example.ini
diff

xtrn/mrc/mrc-client.js
diff

xtrn/mrc/mrc-connector.example.ini
diff

xtrn/mrc/mrc-connector.js
diff

xtrn/mrc/readme.txt
diff

Add ssl support for server to server connections.

Modified Files:


xtrn/mrc/mrc-client.example.ini
diff

xtrn/mrc/mrc-client.js
diff

xtrn/mrc/mrc-connector.example.ini
diff

xtrn/mrc/mrc-connector.js
diff

xtrn/mrc/readme.txt
diff

Merge branch 'mrc_ssl' into 'master'

Add ssl support for server to server connections.

See merge request main/sbbs!443

Modified Files:


exec/logonlist.js
diff

Allow time format to be set via modopts.ini [logonlist] time_fmt

... in strftime format (https://cplusplus.com/reference/ctime/strftime/)

If you (sysop) have last_few_callers_fmt set to a custom value in your
modopts.ini, you'll need to update that format as a result of this change:
the number and type of arguments have now changed: instead of the logon
time be passed as hours and minutes (integers), it's now passed as a single
a string. That string is the result of a call to strftime() with the time_fmt
or (by default), "%H:%M".

This change was made to accommodate request by NeoArata (THEREALM)

Modified Files:


exec/irc.js
diff

Add '-p' option to over-ride password sent to server via PASS message

If -p (or -P) is the last option given with no argument following, then no
password would be sent to the server (via PASS message).

For Odusseus71

Modified Files:


exec/default.js
diff

Don't display the sysop file transfer menu (in response to '!' key)

... for non-sysops

Modified Files:


src/sbbs3/main.cpp
diff

Include current node number intead of socket descriptor in highwater log msg

looks better, more consistent with the log messages before/after it.

Modified Files:


src/sbbs3/main.cpp
diff

Fix *nix build

We removed the large-scope 'i', but didn't update the Unix-only blocks of code
(dealing with UNIX domain spy sockets).

Modified Files:


src/sbbs3/mqtt.c
diff

Clear (set to 0) each server's "highwater" topic upon startup

The other server stats (e.g. error_count, served) are zeroed upon startup, so
the highwater mark should be zeroed too.

Modified Files:


src/sbbs3/main.cpp
diff

Fix incorrect 'socket' value for new (highwater) log message

Modified Files:


src/sbbs3/main.cpp
diff

Eliminate large-scoped 'i' variable in bbs_thread()

This is just a code quality (readability) improvement. No functional change.

Modified Files:


src/sbbs3/services.c
diff

Track/log/publish-to-MQTT services server (total) client highwater mark

Like the other servers.

A sysop likely would want to know which services/protocols had what
utilization (as a portion of the total highwater mark), so that'll have to
be added later.

Modified Files:


src/sbbs3/websrvr.c
diff

Fix off-by-one reporting of "active client highwater mark"

Only log the hightwater mark when it's > 1. :-)

Modified Files:


src/sbbs3/websrvr.c
diff

Publish client highwater mark (max concurrent client stat) to MQTT

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

Log and MQTT-public active client highwater values when seen/reached

We don't log highwater valeus of 1, though those are published to MQTT.

Not dealing with 'services' server yet, cause that's kind of tricky with the
sysop likely wanting to know per-service stats (served counter, highwater
mark, etc.)

Added Files:


exec/load/filelist_lib.js
diff

Modified Files:


exec/addfiles.js
diff

libify the filelist (e.g. FILES.BBS) parsing logic in addfiles.js

... for (soon) reuse in fileman.js

Modified Files:


exec/bullseye.js
diff

Don't exclude the missing bulletin files from the list (change in last commit)

... since that messes up the bulletin->file numbering which is often
hard-coded in bullseye.asc

Modified Files:


exec/bullseye.js
diff

Log bulletin file view success/failure more accurately

Also updated log output format, avoid redundancy

Modified Files:


exec/typeasc.js
diff

Fix "undefined" filename in error message if file doesn't exist

Modified Files:


exec/bullseye.js
diff

Refactor, make bullseye menu file (e.g. bullseye.asc) optional

Use console.uselect() to list the bulletin files, if the menu file
(e.g. bullseye.asc) doesn't exist. For Amessyroom.

Don't replace the Pause (hit a key) prompt, since that messes up
localizaton support (reverts to the text.dat Pause prompt, instead of the
text.*.ini translated Pause prompt). The replace/revert text buffers should
really be a stack for a full fix for this.

Missing bulletin files are automatically excluded from the bulletin list.

The rest is just clean-up from the conversion from Baja.

This is still a very old/basic script, but at least it's not quite as hideous
and outdated as before.

Increment the version to 3.00.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: When listing messages via lightbar, check if the subject is UTF-8,
which now helps the lightbar menu display the line properly, particularly for
UTF-8 terminals

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_msg_list_utf8' into 'master'

DDMsgReader: When listing messages via lightbar, check if the subject is UTF-8,
which now helps the lightbar menu display the line properly, particularly for
UTF-8 terminals

See merge request main/sbbs!442

Modified Files:


exec/load/dd_lightbar_menu.js
diff

dd_lightbar_menu.js: Fixed text truncation issue when displaying item text when
we know it's UTF-8

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_write_item_utf8_improvement' into 'master'

dd_lightbar_menu.js: Fixed text truncation issue when displaying item text when
we know it's UTF-8

See merge request main/sbbs!441

Modified Files:


exec/newuser.js
diff

Allow dash character in new QWKnet account names

... as reported by Mike Powell, and amessroom and root-caused by Nightfox

A '-' is a valid QWK-ID character since it is a valid DOS filename character.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

dd_lightbar_menu: str_is_utf8() seems to return true sometimes when a string
doesn't have UTF-8, so that is now commented out for now

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_text_is_utf8_dont_use_str_is_utf8' into 'master'

dd_lightbar_menu: str_is_utf8() seems to return true sometimes when a string
doesn't have UTF-8, so that is now commented out for now

See merge request main/sbbs!440

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Fix for msgText being undefined when doing a message search

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_search_msgbase_msgtext_undefined_fix' into 'master'

DDMsgReader: Fix for msgText being undefined when doing a message search

See merge request main/sbbs!439

Modified Files:


exec/load/dd_lightbar_menu.js
diff

dd_ligbtar_menu.js: Fix for behavior with the item color when printing the last
portion of an item. Also, UTF8 detection improvement.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_list_utf8_detection_and_bkg_color' into 'master'

dd_ligbtar_menu.js: Fix for behavior with the item color when printing the last
portion of an item. Also, UTF8 detection improvement.

See merge request main/sbbs!438

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix new small memory leak (no need to use strdup here)

Fix CID 497098

Modified Files:


src/sbbs3/userdat.c
diff

Fix getnodedat() error handling and usage

If a file descriptor is passed to getnodedat() and the lock retry counter was
reached, the file would be closed, but the passed file descriptor reference
would not be set to -1. This could result in exceptions (from subsequent read
attempts on the referenced file descriptor) in cases where the node.dab could
not be locked or read by getnodedat() and was thus closed.

The set/get_node_* helper functions (used by MQTT) were not initializing the
node.dab file descriptor (i.e. to -1), so it's possible getnodedat() could
try to read from and close an invalid/wrong open file descriptor. If the local
variable happened to be initialized to a value <= 0, then, no problem, but
this is undefined behavior (UB).

Modified Files:


src/uifc/uifc32.c
diff

Expand tabs and ignore form-feeds in showbuf/help text

Modified Files:


exec/fileman.js
diff

Pass filename (instead of file-obj) to FileBase.get[_path/size/time] methods

to work around recently-fixed bug with > 64 char filenames parsed from
file-meta-objects. Although this bug was fixed in [lib]sbbs[.so|.dll] might
as well use the backward-compatible method to set a better example that works
as expected with SBBS v3.19.

Modified Files:


src/uifc/uifc32.c
diff

Truncate long titles in showbuf() the corrupt the screen and the heap

Don't actually truncate the string, just the display length

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix bug with FileBase.get_time() for filenames > 64 chars in length

We need to read the file header (not just index) entry to get the actual
full filename.

Also, removed some extraneous calls to getfilepath() that served no
purposed.

Modified Files:


exec/fileman.js
diff

Fix one remaining FileBase.get_path() call that passed file-meta-object

(instead of file name), which would have issues in SBBS v3.19 for filenames
> 64 chars in length.

Also, remove extraneous calls to format().

Modified Files:


src/sbbs3/load_cfg.c
diff

Fix small memory leak when loading lib "Auto-Add Subs" feature enabled

caught by valgrind

Modified Files:


src/uifc/uifcx.c
diff

Pretend we know the screen width and that it's 132 columns wide

... for UIFC apps/scripts that have screen-width dependant behavior.

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

Introduce a restore() uifc_api method for restoring a saved window buffer

This allows for menu options on an "active" list (with both WIN_SAVE and
WIN_ACT mode flags) to close the window and restore the most recently saved
window.

Also, for the range check on the save buffer count in ulist(), if we've
hit the bounds, don't *just* beep (though, that was useful), but turn off the
WIN_SAV mode flag so we don't overflow the sav[] array and corrupt the heap!

Modified Files:


src/sbbs3/js_uifc.c
diff

Use the new uifc_t.restore() method when decrementing the save_num

This is the proper way to manually-restore the most recently saved
window (via the WIN_SAV mode flag to the list() method).

I wanted something that was backward comaptible with earlier builds
of SBBS, so just doing a magic thing when decrementing the save_num
rather than adding a new method seemed the seamless way to do it.

Modified Files:


exec/fileman.js
diff

Add new "Search Pending Files" operation

Sort of the opposite of the "Offline Files" search, find files copied into
the directory storage paths but not yet added to the filebase, with a
"Add File..." option (and tagging support) along with DELete files option.

Auto-ignore listing files (e.g. FILES.BBS, etc.) when searchign for new
files to add to a directory's filebase.

If an argument is passed to fileman.js, use that as the UIFC mode (for testing
purposes only).

Fix case-sensitive file compares (on *nix OSes) when adding files (now
case-insensitive).

Fix issue with get file paths for files not yet in a filebase (using
FileBath.get_path unnecessarily).

Display virtual paths to files in many place, when available (> SBBS v3.19).

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix 64-char filename length limit for FileBase.get[_path/size/time] methods

This was only a problem when these methods were passed a file-meta-object
instead of the file name. In hindsight, that's kind of a dumb API "feature"
since we're just parsing the name property out of the object.

The file_t.file_idx.name is limited to 64 chars, so don't use that struct
element to store the parsed "name" property of the passed file-meta-object.

Modified Files:


exec/fileman.js
diff

Support viewing text files, deal with LF-terminated extended descriptions

Text files with recognized plain text file names/extensions can be viewed from
within fileman now.

Some extended descriptions may only be terminated with LF (instead of CRLF),
so deal with those accordingly. Some auto-translation from LF to CRLF
terminated
extended description lines may occur when editing extended descriptions.

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

src/uifc/uifcx.c
diff

Add WIN_BLANKOPTS list() option, to support options/lists with blank lines

This requires that the option list be NULL-terminated, when used.

For use with js_uifc.c (JS uifc.list method).

For some reason, this exposed an issue where "(null)" would be printed for
the last line when combined with WIN_XTR mode flag, so worked around that
bug too.

Modified Files:


src/sbbs3/js_uifc.c
diff

Use new uifc.list mode flag WIN_BLANKOPTS

uifc option lists are always NULL-terminated string lists (not static
arrays of char arrays, as is often used in other UIFC utils), so grow
the ability to have blank options (list items).

This was needed for fileman.js to accurately edit extended file
descriptions that contain blank lines.

Modified Files:


exec/fileman.js
diff

Add ability to add files, display/edit extended descriptions

(yes, I know, unzip for DIZ can corrupt the TUI display when adding files)

Add ability to display and edit extended file descriptions (including
inserting and deleting lines.

Fixed bug with moving files between dirs.

F2 is now just a shortcut for renaming files, ENTER is the main edit/display
option key now.

This really requires an updated sbbs/jsexec to work fully correct (e.g.
display/edit extended descriptions that contain blank lines).

Modified Files:


exec/viewimsgs.js
diff

A bit more dynamically translated/localizable

Modified Files:


src/sbbs3/smbutil.c
diff

Make filebase status output less confusing ("file" not "msg")

Cosmetic change only, output of 'smbutil s' command when used on a filebase.

Increment the SMBUTIL version from 3.19 to 3.20

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

Add suport for option/item tagging using the WIN_TAG ulist() mode flag

For use with fileman.js:

The space bar can be used by the user to "tag" items, or Ctrl-A to toggle
tag status for *all* items. Returns MSK_TAG|with the option tagged/untagged
or MSG_TAGALL when all tags are being toggled (via ^A).

Also, fix bug where ^Find command would not restore the status bar after
ulist() would overwrite it with the string-input/edit hot-keys available.

Modified Files:


exec/load/uifcdefs.js
diff

Add WIN_TAG, MSK_TAG, MSG_TAGALL and (missing) WIN_HLP definitions

Modified Files:


src/sbbs3/js_filebase.c
diff

FileBase.add() now supports override to *never* extract/use DIZ if desired

Working on fileman.js, when moving files to another base, the output of unzip
(trying to extra a FILE_ID.DIZ) was corrupting the display. We don't really
want a DIZ file to get imported when moving files between bases anyway.

So the second parameter to FileBase.add() can be either:
- undefined: will try to extract/use DIZ only if there's no ext desc already
- true: will try to extract/use a DIZ even if there's an ext desc already
- false: will never try to extract/use a DIZ

If the directory is not configured for DIZ support, then the DIZ extraction/use
will never occur under any condition.

Modified Files:


src/sbbs3/js_filebase.c
diff

Better JSDOC description of use_diz param to FileBase.add()

Modified Files:


exec/fileman.js
diff

Add multi-file tagging, deleting, moving

A bunch of other improvements, cosmetic and functional (viewing archives,
editing more File fields, etc.).

Modified Files:


exec/load/json-sock.js
diff

More detail to JSON.parse() error in Socket.prototype.recvJSON

This is likely the cause of the vauge logged error that I and other
sysops see from time to time:
srvc 0000 JSON SyntaxError: JSON.parse

... so log the function name and the contents of the string that's
failing to parse.

Modified Files:


exec/load/json-sock.js
diff

Include the service descriptor in the JSONrecv error message

Added Files:


exec/fileman.js
diff

New Synchronet File Manager (run using jsexec)

This is a new TUI-style filebase browser/editor for sysop use. Sysops can
search files, descriptions/metadata, uploader names, offline files and then
easily remove/delete or edit those file's names, description, uploader.

Ideas for improvements (e.g. file tagging/bulk deleting) may require updates
to UIFC. This is a proof of concept at least and provides some functionality
already.

Modified Files:


src/smblib/smbdump.c
diff

If the msg type is 'File', the subject is the Filename, so say so in the dump

Modified Files:


exec/fseditor.js
diff

Open the quote file in "binary" mode (only applicable on Windows)

If the quote file contained a Ctrl-Z (ASCII 26) char, it would be truncated
at that point. Some UTF-8 messages that include a "right arrow" unicode code
point are translated to ASCII Ctrl-Z (ASCII 26) char, which is interpretted
by Windows as "EOF" (end of file) marker for files open in "text mode" and
the file won't be read beyond that char. Open the file in binary mode to
more closely match the *nix fopen() before.

Modified Files:


src/sexpots/release.bat
diff

Build the git_*.h files on Win32 from here too

Modified Files:


src/sexpots/sexpots.c
diff

Log an error if calls to send() don't return the expected value

This addresses GCC warnings about not using the return value of send().

Modified Files:


src/sexpots/GNUmakefile
diff

Build git_branch.h and git_hash.h here

This rule should really be in build/Common.gmake or similar

Modified Files:


src/sexpots/sexpots.c
diff

Fix warning about potential uninitialize variable value use

Modified Files:


src/sexpots/sexpots.c
diff

Output the Git repo/branch/hash details in execution banner

Not sent in connection banner.

Modified Files:


docs/sexpots.txt
diff

Updated to latest details (e.g. GIt, not CVS)

Modified Files:


exec/load/logonlist_lib.js
diff

exec/logonlist.js
diff

Log the current connection protocol as a separate property in logon.jsonl

Accession reported that (sometimes?) his NNTP logins show up in his
logon.jsonl files. This is most likely just a race condition when logging
in close to the same time with multiple protocols (e.g. Telnet and NNTP
in this case). So, let's log the client.protocol as a separate JSON property
and not require on the user.connection property (which is overwritten for
*every* login, for almost all connection/server types, not just the terminal
server). The client.protocol is always correct for the current session running
the script.

An NNTP login should never appear in the logon.json file.

Modified Files:


src/sbbs3/js_user.c
diff

Make legacy/alias properties non-enumerable: computer, modem

I noticed these redundant properties were being logged for every logon in
logon.jsonl. We don't need these properties separately enumerable, and really
they shouldn't be used anyway.

computer is an alias of host_name
modem is an alias of connection

Modified Files:


exec/load/logonlist_lib.js
diff

When pulling from previous days to fulfill the "last few callers list", insert

Insert (using unshift) to the beginning of the list, rather than append (using
push) to the end of the list.

This fixes issue #761

Modified Files:


src/sbbs3/filedat.c
diff

Replace line-feeds with space in extended descriptions used for short desc

Fixes cosmetic/readability issue when imported DIZ files that have line/word
wrapped text and the space between words was being removed.

Modified Files:


exec/logonlist.js
diff

Add some usage comments

Modified Files:


exec/logonlist.js
diff

If passing a non-zero integer, display logons from that many days ago

Similar to -y option, but supports going further back than just yesterday.

Modified Files:


exec/update.js
diff

Fix typo in output: that's attr.cfg -> attr.ini, not file.cfg -> file.ini

As reported by Keyop

Modified Files:


src/sbbs3/smbutil.c
diff

Add test command 'Z' for locking an SMB header until keypress

Just for testing/experimenting with proper recording locking support. e.g.
when one process or network node (on a LAN) has the SMB header locked, another
process/node should not be able to lock it or reading the status header.

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Update help text on startup directory options.

Now can include command-line specifiers.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Add support for command-line specifiers in external program 'startup dir'

The exception is: DOS programs on Linux (e.g. Linux DOSEMU), due to the
funky drive letter mappng, this can't be supported for those external
programs.

As requested by Fluid via IRC, for Frotz support, to store user-unique
data files in data/user/####.something (e.g. "%juser/%4.zork").

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

exec/load/dd_lightbar_menu.js
diff

dd_lightbar_menu: Added KEY_F* defines in there that were referenced in
getKeyWithESCChars().  Refactored the includes in SlyEdit, since SlyEdit uses
getKeyWithESCChars()

Modified Files:


exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_slyedit_get_key_with_esc_chars_f_key_refactor'
into 'master'

dd_lightbar_menu: Added KEY_F* defines in there that were referenced in
getKeyWithESCChars().  Refactored the includes in SlyEdit, since SlyEdit uses
getKeyWithESCChars()

See merge request main/sbbs!437

Modified Files:


src/sbbs3/telgate.cpp
diff

Address unused return value warnings from GCC

Modified Files:


src/sbbs3/telgate.cpp
diff

Fix GCC compile error (can't use __FUNCTION__ macro like that)

And warning about signed/unsigned compare

Modified Files:


exec/telgate.js
diff

exec/unixgate.js
diff

Use the telnet gateway proxy (not pass-through) by default

Pass-through only really does anything useful if the BBS user's client is a
Telnet client and it responds as the server expects. Since the user's
Telnet client (when using one) has already negotiated Telnet options, they
won't ACK options that the server expects them to, so this doesn't really
work. The proxy fixes that issue.

Modified Files:


src/sbbs3/telgate.cpp
diff

telnet_gateway() is now, by default, a telnet proxy

Meaning, it'll negotiate all Telnet options with the remote server (assuming
not an RLogin server), so long as the TG_PASSTHRU option is *not* set.

This allows more Telnet servers to work as expected, especially when the
client (BBS user) is not using a Telnet client!

Fix issue #432

Modified Files:


src/syncterm/telnet_io.c
diff

We don't support echo (sending what we receive back to the server).

Modified Files:


exec/load/cfglib.js
diff

Add missing xtrn.ini "hotkey" section read/writing

Also arrange section writing order to match scfglib2.c

Modified Files:


src/conio/conio_gdi.vcxproj
diff

src/conio/conio_sdl.vcxproj
diff

Don't set MinimalRebuild option to true

Avoid build warning about use of deprecated /Gm option.

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Default to 80x25 LCD video mode

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Add support for umonitor.ini (with fallback to uifc.ini)

... for uifc/ciolib settings

And make default video mode LCD 80x25

Modified Files:


src/sbbs3/asc2ans.c
diff

Display Git branch/hash instead of VERSION for revision info (like ans2asc)

This should fix the Win32 build.

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Eliminate use of CVS Revision keyword

Modified Files:


src/sbbs3/makeuser.c
diff

Eliminate use of CVS Revision keyword

Modified Files:


src/sbbs3/asc2ans.c
diff

src/sbbs3/baja.c
diff

src/sbbs3/unbaja.c
diff

Eliminate use of CVS Revision keyword

Modified Files:


exec/noyesbar.js
diff

exec/yesnobar.js
diff

Fix issue where Ctrl-C would leave a 'N' in the keyboard input buffer

This problem doesn't happen with the .bin version of these scripts.

Modified Files:


exec/cleanup.js
diff

Clean up the old attr.cfg file

Thanks for the reminder, Keyop

Modified Files:


ctrl/attr.ini
diff

Add new rainbow attribute key

If this key doesn't exist, the default value is used

So it's not a big deal if your ctrl/attr.ini file is missing or doesn't have
any particular key in it.

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Elminte use of CVS Keyword for revision number

Modified Files:


src/uifc/uifc_ini.c
diff

Make the video_mode and ciolib_mode out params option (may be NULL)

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Add support for ctrl/uedit.ini (with fallback to uifc.ini)

For Nelgin

Added Files:


src/uifc/uifc_ini.c
diff

Modified Files:


src/uifc/objects.mk
diff

src/uifc/uifc.h
diff

src/uifc/uifc.vcxproj
diff

Create read_uifc_ini() for a common method of reading UIFC/CIOLIB .ini files

Copied from read_scfg_ini() in scfg.c

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Use new read_uifc_ini() to scfg.ini or (if it doesn't exist), uifc.ini

Modified Files:


src/sbbs3/echocfg.c
diff

Add support for ctrl/echocfg.ini (or fallback to ctrl/uifc.ini)

For controlling the UIFC/CIOLIB properties (scaling, modes, etc.)

Modified Files:


src/sbbs3/js_file.c
diff

Don't convert/store small integers to doubles when reading/writing .ini files

Fix issue #760

UINT_TO_JSVAL automatically handles the storage as the necsesary underlying
type in the JS engine.

Values > 0x7fffffff (2147483647) will still be stored (and re-written) as
doubles and could be problematic.

Modified Files:


src/sbbs3/con_out.cpp
diff

Move the line_delay logic so it has effect on PETSCII terminals too

Fix issue #759

Modified Files:


exec/cleanup.js
diff

Remove unused remove() function definition

Modified Files:


src/encode/hex.c
diff

src/encode/hex.h
diff

hex_decode() now supports no-escape char, if desired

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/str_util.c
diff

Add rainbow (elite text) attribute feature

New key "rainbow" in ctrl/attr.ini
New Ctrl-A codes: 'X' to turn on repeating/wrapping rainbow attributes,
 'x' to turn on non-repeating/wrapping rainbow attributes.
New @-code: RAINBOW:x to set the list of (comma-separated) rainbow attribute
 values (in same form as attr.ini).
 When used in a display file, the rainbow attribute change is temporary.

Ever wanted to add alternating attributes to @-code expanded text in display
files? Now you can.

Also can be used to easily/quickly create display files with repeating
elements (e.g. commands/options) using alternating attributes.

Modified Files:


src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Clear mouse hotspots when executing *any* external program/script

Previously, we only cleared hotspots when executing any external from the
external program section (doors menu). This means that invoking a script or
external program (e.g. via JS bbs.exec()) from anywhere else, any current
mouse hotspots would remain active. Disable those.

This fixes issue #758

Added Files:


ctrl/attr.ini
diff

Removed Files:


ctrl/attr.cfg
diff

Replace attr.cfg with attr.ini (similar, but not same format)

Modified Files:


src/sbbs3/js_console.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfgdefs.h
diff

Replace ctrl/attr.cfg (customized text colors/attrs) with ctrl/attr.ini

Another legacy config file replaced with .ini file (for easier editing and
future extensibility).

No longer dynamically allocate scfg_t.colors (no need). There's really no
reason why this is still an array, but leave as is for now.

Also, I noticed JS console.color_list (also an array) is not enumerable
(or documented) - that should be fixed.

Modified Files:


exec/update.js
diff

Upgrade attr.cfg to attr.ini

The extra characters (comments) are ignored when parsing this particular file,
so though this is not how we normally add comments to .ini files, it still
works fine in this case.

Modified Files:


src/sbbs3/qwk.cpp
diff

P-restricted users (including QWKnet accounts) can no-longer post polls

This was a loop-hole that caused Denn (OUTWEST) some confusion, those his
QWKnet account could post polls, it could not post messages due to having the
P-restriction.

Modified Files:


xtrn/lord/lord.js
diff

reLoad() does not return the record.

Fixes error reported by Rowyn Sand (Ravne) with accepting a marriage
proposal (issue #757)

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/scfg/scfg.c
diff

Set ciolib_initial_mode before calling initciolib()

... rather than calling textmode() after.

This solves the problem of black bars above and below the UIFC window in
echocfg and SCFG on ChromeOS, at least.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/postmsg.cpp
diff

Resolve new(er) warnings comparing client_t.protocol with NULL

client_t.protocol is no longer a pointer.

Warnings reported by gcc (Debian 12.2.0-14) 12.2.0

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Overhaul scfg.ini keys

All keys are now in the root/global section and they are now:

video_mode (default: 42)
uifc_mode (default: 0)
ciolib_mode (default: 0)
scaling (default: 0)
lines (default: 25)
insert (default: false)
esc_delay (default: 25)

Modified Files:


src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/sbbs3/scfg/scfg.c
diff

Eliminate unused ciolib vars: ciolib_initial_window_height and height

These global variables weren't actually used for any purpose.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Allow SCFG ciolib and uifc parameters to be read from ctrl/scfg.ini

If a sysop wants to override the default user interface/console I/O library
behavior of SCFG without using command-line arguments, they can create a
ctrl/scfg.ini file with the following optional [section] keys:

[uifc]
mode (advanced uses, e.g. disabling mouse support)
height (in lines)
insert (keyboard insert mode, not overwrite)
esc_delay (ESC-key delay)

[ciolib]
mode (advanced uses)
scaling (fractional values, e.g. 1.5, supported)
height (in pixels)
width (in pixels)

Command-line arguments take precedence over scfg.ini settings (if set).

The scfg.ini file is read *before* parsing command-line args, so if a ctrl
directory is specified on the command-line (e.g. rather than via environment
variable), the scfg.ini file won't be read from that specified location but
rather the default (/sbbs/ctrl) or the SBBSCTRL env var value.

Another attempt to make Nelgin happy and close out issue #749, though no, this
doesn't auto-save the current parameters (you'll have to create/edit the
scfg.ini file by hand).

Modified Files:


xtrn/lord/lord.js
diff

Fix apparent typo (vds array has length property, not length5)

Fix issue #754

Modified Files:


ctrl/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

exec/slyedcfg.js
diff

SlyEdit: In SlyEdit_Misc.js, check to see that xtrn_area.editor[user.editor] is
an object before using it.  Should help with #755.

Modified Files:


ctrl/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

exec/slyedcfg.js
diff

Merge branch 'slyedit_xtrn_area_editor_user_editor_check_first' into 'master'

SlyEdit: In SlyEdit_Misc.js, check to see that xtrn_area.editor[user.editor] is
an object before using it.  Should help with #755.

See merge request main/sbbs!436

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Skip files listed in imported DIRS.TXT/DIRS.WIN/00_INDEX.TXT files

I'm not clear why Walnut Creek would list files (e.g. readme.txt) in these
lists of "directories", but don't create file areas for them. Less clean-up
required after import.

Modified Files:


exec/privatemsg.js
diff

Use the localizable Quit @-code

Modified Files:


src/syncterm/bbslist.c
diff

Use name as default address when creating new TCP dialing entry

I usually use the hostname for the name of the dialing entry and got tired
of always having to type the hostname twice when creating a new entry.

If the name looks like a hostname or IP address (includes a dot but
no spaces) and the connection type is appropriate, make the name the
default string for the address (easily over-ridden if wrong, by just
typing the correct address). This time-saving feature doesn't work for
single-word hostnames (e.g. "localhost") or IPv6 addresses.

Modified Files:


docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_DCTStuff.js
diff

exec/SlyEdit_Misc.js
diff

SlyEdit: Don't line-wrap poll messages for quoting. Also, minor fix for the
'to' name length in DCT mode.

Modified Files:


docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_DCTStuff.js
diff

exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_poll_quoting_and_dct_to_name_fix' into 'master'

SlyEdit: Don't line-wrap poll messages for quoting. Also, minor fix for the
'to' name length in DCT mode.

See merge request main/sbbs!435

Modified Files:


src/sbbs3/mqtt.c
diff

Fix CID 493283:  Incorrect expression  (NO_EFFECT)
    Comparing an array to null is not useful: "client->protocol == NULL",
    since the test will always evaluate as true.

or will always evaluate as *false* (the array won't ever be NULL). <shrug>

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Re-assign the dirnum and subnum fields after sorting dirs or subs

The dirnum and subnum are used for the next/previous (left and right) arrow
nav through sub-boards and directories. For message groups or file libs that
are configured to auto-sort the sub-boards or directory list, when importing
an unsorted list, the dirnum and subnum values would then be wrong after the
qsort() at the end of the import thus making the left/right nav thing broken
(jump to other groups/libs and such).

This fixes that.

Could I have fixed this by passing an index value to the next/prev_dirnum()
and _subnum() functions and returning the next/previous index value instead of
relying on the subnum/dirnum elemment to be correct? Maybe. <shrug>
Do I like second guessing myself? Not really.

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Support dir/subdir syntax in DIRS.TXT (CD-ROM) import

getfname() just returns the last path element, so can't use that here.

Modified Files:


src/sbbs3/filedat.c
diff

Fixup extract_diz() - fallback to external archivers

The fallback to external extractors/archivers didn't really work unless a
libarchive function (called from extract_files_from_archive) actually failed
and the return value was < 0. A return value of 0 would mean the external
file extractor would never be used.

This was discovered when trying to import DIZ from old ZIP files (from 1992)
that used "Implode" compression method for the FILE_ID.DIZ, which is a
compression method *not* supported by libarchive. This is a reason why sysops
might want to leave Info-zip's 'unzip' as a configured Extractable File Type
handler (in SCFG) for 'zip' files.

Don't call the external archiver 3 times for the 3 DIZ filenames supported.
Just call the external archiver once, and pass all 3 filesnames. This also
means that the call to system() can return non-zero (e.g. Info-zip 'unzip'
will return 2 if any of the files aren't present in the archive, even if
one is) - so ignore this return value from system(). This speeds up bulk
import (e.g. using addfiles.js).

Unfortunately, I couldn't really find a nice cross-platform way to suppress
the unzip "caution: filename not matched" message sent to stderr. That's
a bummer and a little annoying.

Ignore 0-length DIZ files.

Modified Files:


src/sbbs3/answer.cpp
diff

src/sbbs3/client.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/services.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/websrvr.c
diff

Change client_t.protocol from pointer to buffer

Fix observed crash when shutting down services server where the client_t
protocol was pointing to a freed service's protocol description string.

This was the last pointer in client_t and should resolve the last race
conditions (memory ownership issues) with its data members.

This also resolves a small memory leak in getnodeclient() where the last
client "gotten" would have its heap-duplicated protocol string leaked.