Synchronet Git Commit Log

Modified Files:


src/sbbs3/nopen.c
diff

Fix non-Windows build, broken in previous commit

Modified Files:


src/sbbs3/nopen.c
diff

We need to initialize the fd to -1 here (since we zero-it out the fmutex_t)

and might return before setting it to anything else.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Simplify fmutex_open() signature even more, add fmutex_init()

Can't used designated initializers in fmutex_init() because this file is still
built with C++Builder6.

Modified Files:


src/sbbs3/ctrl/AboutBoxFormUnit.cpp
diff

Update cryptlib copyright dates to match latest cryptlib.h

Modified Files:


src/conio/OverhaulNotes.txt
diff

Add nodes about different screen update methods that will be needed

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Correct initialization of fmutex_t so the file descriptor is -1

For some reason, MSVC was initializing the time_t (second element of the
struct) to -1, not the int fd (the first element), which was initialized to
0. Weird.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Simplify the fmutex_open() usage: always auto-remove when using open/close()

The auto-remove param was only needed for fmutex(), which immediately closes
(and thus don't want auto-removal), so create an internal function that's
used by both fmutex() and fmutex_open().

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Have fmutex_open()/close() accept a fmutex_t* argument

This is needed for *nix where normal (i.e. not Samba-mount) file behavior
requires that we manually unlink() the file, but not until just before closing
it. So we have to keep track of the file name and the 'auto_remove' desire of
the caller. This is not necessary when the file is on a Linux-smbfs, but we
need to work as expected on normal/local *nix file systems too.

This solves atomic lock file removal for *nix, but does not gaurantee lock file
cleanup upon ungraceful process termination (e.g. crash). At least in this
particular case, Windows beats UNIX.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Revert "Use fmutex_open for 100% locking and auto-removal upon
close/termination"

This reverts commit e55183c0953d0b033d9f11796f4290e488596e92.

fmutex_open()'s auto-remove feature doesn't work on normal/local Linux file
systems: unlink() of a file immediately removes its directory entry allowing
subsequent opens of the same file name, defeating the lock.

I had tested fmutex_open() on a Samba mount (from Linux) and it worked as I
wanted (like the Windows version does). Still searching for a good solution:
if a process terminates, gracefully or not, I'd like the file to be removed
at that time and until then, other processes or threads can't create or open
the same lock file (using O_EXCL and file locking to insure this).

Modified Files:


exec/load/openweathermap.js
diff

Update the openweathermap (OWM) API version number

Change requested in issue #747 and from Dan_C in #synchronet

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

Create/use function to toggle bit flags (options/settings)

Oh, so much copy/paste eliminated!

Modified Files:


src/conio/win32gdi.c
diff

When SyncTERM is deactivated and it is in fullscreen mode, minimize.

This appears to be the best we can do when Windows+M (minimize all)
is pressed.  We don't seem to be notified that we should minimize,
only that a different application is being activated.

This also makes Alt-TAB behave a bit more like expected.

Modified Files:


src/syncterm/CHANGES
diff

Log change.

Modified Files:


exec/mqtt_spy.js
diff

Add backup Ctrl-C input checking, just incase console.aborted isn't working

Telnet BINARY_TX mode from the client disables CTRL-C input checking in all
versions of SBBS (before now). This change shouldn't be necessary now, but
it worked-around the BINARY_TX issue when I was having it (couldn't abort
mqtt spy).

Modified Files:


src/sbbs3/ftpsrvr.c
diff

A little beautification of errno logging

Modified Files:


src/sbbs3/main.cpp
diff

Perform "first level Ctrl-C input checking" even when in Telnet BINARY_TX

This condition caused aborting BBS operations via Ctrl-C to fail when
connecting from a traditional Telnet client using binary transmission
mode (e.g. telnet -8) or SyncTERM v1.2rc6.

The check of rio_abortable was probably enough to disable this function
during file transfers (e.g. we've had no issues with SSH file transfers
that might include byte 0x03 received from the client), but I added the
check for SS_FILEXFER system status check too, perhaps unnecessary.

Modified Files:


3rdp/win32.release/cryptlib/bin/cl32.dll
diff

3rdp/win32.release/cryptlib/include/cryptlib.h
diff

Cryptlib v3.4.8 for Win32, patched

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

3rdp/build/cl-Dynamic-linked-static-lib.patch
diff

3rdp/build/cl-PAM-noprompts.patch
diff

3rdp/build/cl-SSL-fix.patch
diff

3rdp/build/cl-add-patches-info.patch
diff

3rdp/build/cl-add-pubkey-attribute.patch
diff

3rdp/build/cl-add-win64.patch
diff

3rdp/build/cl-algorithms.patch
diff

3rdp/build/cl-allow-duplicate-ext.patch
diff

3rdp/build/cl-allow-none-auth-svr.patch
diff

3rdp/build/cl-allow-none-auth.patch
diff

3rdp/build/cl-allow-pkcs12.patch
diff

3rdp/build/cl-allow-servercheck-pubkeys.patch
diff

3rdp/build/cl-allow-ssh-2.0-go.patch
diff

3rdp/build/cl-allow-ssh-auth-retries.patch
diff

3rdp/build/cl-bigger-maxattribute.patch
diff

3rdp/build/cl-bn-noasm64-fix.patch
diff

3rdp/build/cl-channel-select-both.patch
diff

3rdp/build/cl-clear-GCM-flag.patch
diff

3rdp/build/cl-double-delete-fine-on-close.patch
diff

3rdp/build/cl-endian.patch
diff

3rdp/build/cl-fix-cbli-incompatible.patch
diff

3rdp/build/cl-fix-cpuid-order.patch
diff

3rdp/build/cl-fix-mb-w-conv-warnings.patch
diff

3rdp/build/cl-fix-shell-exec-types.patch
diff

3rdp/build/cl-fix-ssh-channel-close.patch
diff

3rdp/build/cl-good-sockets.patch
diff

3rdp/build/cl-haiku-build.patch
diff

3rdp/build/cl-handle-unsupported-pubkey.patch
diff

3rdp/build/cl-just-use-cc.patch
diff

3rdp/build/cl-lowercase-versionhelpers.patch
diff

3rdp/build/cl-macosx-minver.patch
diff

3rdp/build/cl-make-channels-work.patch
diff

3rdp/build/cl-mingw-add-m32.patch
diff

3rdp/build/cl-mingw-vcver.patch
diff

3rdp/build/cl-mingw32-static.patch
diff

3rdp/build/cl-mingw64-is-really-new.patch
diff

3rdp/build/cl-mingw64-thread-handles.patch
diff

3rdp/build/cl-mingw64-unicode-gibble.patch
diff

3rdp/build/cl-moar-objects.patch
diff

3rdp/build/cl-netbsd-hmac-symbol.patch
diff

3rdp/build/cl-netbsd-no-getfsstat.patch
diff

3rdp/build/cl-no-odbc.patch
diff

3rdp/build/cl-no-pie.patch
diff

3rdp/build/cl-no-safe-stack.patch
diff

3rdp/build/cl-no-testobjs.patch
diff

3rdp/build/cl-no-tpm.patch
diff

3rdp/build/cl-no-via-aes.patch
diff

3rdp/build/cl-noasm-defines.patch
diff

3rdp/build/cl-pass-after-pubkey.patch
diff

3rdp/build/cl-poll-not-select.patch
diff

3rdp/build/cl-posix-me-gently.patch
diff

3rdp/build/cl-prefer-ECC-harder.patch
diff

3rdp/build/cl-prefer-ECC.patch
diff

3rdp/build/cl-quote-cc.patch
diff

3rdp/build/cl-ranlib.patch
diff

3rdp/build/cl-read-timeout-every-time.patch
diff

3rdp/build/cl-remove-march.patch
diff

3rdp/build/cl-server-term-support.patch
diff

3rdp/build/cl-ssh-eof-half-close.patch
diff

3rdp/build/cl-ssh-list-ctr-modes.patch
diff

3rdp/build/cl-ssh-sbbs-id-string.patch
diff

3rdp/build/cl-ssh-service-type-for-channel.patch
diff

3rdp/build/cl-terminal-params.patch
diff

3rdp/build/cl-thats-not-asm.patch
diff

3rdp/build/cl-use-ssh-ctr.patch
diff

3rdp/build/cl-vcxproj.patch
diff

3rdp/build/cl-vt-lt-2005-always-defined.patch
diff

3rdp/build/cl-win32-lean-and-mean.patch
diff

3rdp/build/cl-win32-noasm.patch
diff

3rdp/build/cl-zlib.patch
diff

3rdp/build/cl-zz-country.patch
diff

3rdp/dist/cryptlib.zip
diff

Removed Files:


3rdp/build/cl-fix-ssh-ecc-ephemeral.patch
diff

3rdp/build/cl-fix-ssh-header-read.patch
diff

3rdp/build/cl-fix-test-select.patch
diff

3rdp/build/cl-openbsd-threads.patch
diff

3rdp/build/cl-ssl-suite-blocksizes.patch
diff

3rdp/build/cl-win32-build-fix.patch
diff

Update Cryptlib to 3.4.8

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

3rdp/build/cl-Dynamic-linked-static-lib.patch
diff

3rdp/build/cl-PAM-noprompts.patch
diff

3rdp/build/cl-SSL-fix.patch
diff

3rdp/build/cl-add-patches-info.patch
diff

3rdp/build/cl-add-pubkey-attribute.patch
diff

3rdp/build/cl-add-win64.patch
diff

3rdp/build/cl-algorithms.patch
diff

3rdp/build/cl-allow-duplicate-ext.patch
diff

3rdp/build/cl-allow-none-auth-svr.patch
diff

3rdp/build/cl-allow-none-auth.patch
diff

3rdp/build/cl-allow-pkcs12.patch
diff

3rdp/build/cl-allow-servercheck-pubkeys.patch
diff

3rdp/build/cl-allow-ssh-2.0-go.patch
diff

3rdp/build/cl-allow-ssh-auth-retries.patch
diff

3rdp/build/cl-bigger-maxattribute.patch
diff

3rdp/build/cl-bn-noasm64-fix.patch
diff

3rdp/build/cl-channel-select-both.patch
diff

3rdp/build/cl-clear-GCM-flag.patch
diff

3rdp/build/cl-double-delete-fine-on-close.patch
diff

3rdp/build/cl-endian.patch
diff

3rdp/build/cl-fix-cbli-incompatible.patch
diff

3rdp/build/cl-fix-cpuid-order.patch
diff

3rdp/build/cl-fix-mb-w-conv-warnings.patch
diff

3rdp/build/cl-fix-shell-exec-types.patch
diff

3rdp/build/cl-fix-ssh-channel-close.patch
diff

3rdp/build/cl-good-sockets.patch
diff

3rdp/build/cl-haiku-build.patch
diff

3rdp/build/cl-handle-unsupported-pubkey.patch
diff

3rdp/build/cl-just-use-cc.patch
diff

3rdp/build/cl-lowercase-versionhelpers.patch
diff

3rdp/build/cl-macosx-minver.patch
diff

3rdp/build/cl-make-channels-work.patch
diff

3rdp/build/cl-mingw-add-m32.patch
diff

3rdp/build/cl-mingw-vcver.patch
diff

3rdp/build/cl-mingw32-static.patch
diff

3rdp/build/cl-mingw64-is-really-new.patch
diff

3rdp/build/cl-mingw64-thread-handles.patch
diff

3rdp/build/cl-mingw64-unicode-gibble.patch
diff

3rdp/build/cl-moar-objects.patch
diff

3rdp/build/cl-netbsd-hmac-symbol.patch
diff

3rdp/build/cl-netbsd-no-getfsstat.patch
diff

3rdp/build/cl-no-odbc.patch
diff

3rdp/build/cl-no-pie.patch
diff

3rdp/build/cl-no-safe-stack.patch
diff

3rdp/build/cl-no-testobjs.patch
diff

3rdp/build/cl-no-tpm.patch
diff

3rdp/build/cl-no-via-aes.patch
diff

3rdp/build/cl-noasm-defines.patch
diff

3rdp/build/cl-pass-after-pubkey.patch
diff

3rdp/build/cl-poll-not-select.patch
diff

3rdp/build/cl-posix-me-gently.patch
diff

3rdp/build/cl-prefer-ECC-harder.patch
diff

3rdp/build/cl-prefer-ECC.patch
diff

3rdp/build/cl-quote-cc.patch
diff

3rdp/build/cl-ranlib.patch
diff

3rdp/build/cl-read-timeout-every-time.patch
diff

3rdp/build/cl-remove-march.patch
diff

3rdp/build/cl-server-term-support.patch
diff

3rdp/build/cl-ssh-eof-half-close.patch
diff

3rdp/build/cl-ssh-list-ctr-modes.patch
diff

3rdp/build/cl-ssh-sbbs-id-string.patch
diff

3rdp/build/cl-ssh-service-type-for-channel.patch
diff

3rdp/build/cl-terminal-params.patch
diff

3rdp/build/cl-thats-not-asm.patch
diff

3rdp/build/cl-use-ssh-ctr.patch
diff

3rdp/build/cl-vcxproj.patch
diff

3rdp/build/cl-vt-lt-2005-always-defined.patch
diff

3rdp/build/cl-win32-lean-and-mean.patch
diff

3rdp/build/cl-win32-noasm.patch
diff

3rdp/build/cl-zlib.patch
diff

3rdp/build/cl-zz-country.patch
diff

3rdp/dist/cryptlib.zip
diff

Removed Files:


3rdp/build/cl-fix-ssh-ecc-ephemeral.patch
diff

3rdp/build/cl-fix-ssh-header-read.patch
diff

3rdp/build/cl-fix-test-select.patch
diff

3rdp/build/cl-openbsd-threads.patch
diff

3rdp/build/cl-ssl-suite-blocksizes.patch
diff

3rdp/build/cl-win32-build-fix.patch
diff

Merge branch 'cryptlib-3.4.8' into 'master'

Update Cryptlib to 3.4.8

See merge request main/sbbs!473

Modified Files:


exec/imapservice.js
diff

"support" CHARSET search parameter.

Allow only US-ASCII, and send the BADCHARSET response code indicating
that.  Fixes issue with aerc.

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Add a "Use Shell" toggle option for fixed events

On *nix, you need the command shell to do wildcard expansion of filenames

Modified Files:


src/sbbs3/date_str.c
diff

Treat -1 as invalid time in time_as_hhmm()

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Resolve MSVC warning

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Use safe_strerror() in place of strerror() - everything multithreaded should

Modified Files:


src/sbbs3/userdat.c
diff

Add description comment for find_login_id()

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Fix the "ERROR x getting data user y" log message (usernum was 0).

Add the errno value to help root-cause.

We really should be using safe_strerror() everywhere.

Modified Files:


exec/load/newsutil.js
diff

Store original "references" header field as an RFC822HEADER in SMB

If an original references header field was supplied with the message, include
*that* in the header (since it should contain all the IDs of the replied-to
message thread) rather than just the message's reply_id (a single message
ID) when sending via NNTP. This maintains more NNTP post integrity when
sending back out via NNTP.

Not sure why we were storing received "references" in the hdr.references
returned by parse_news_header(), we don't seem to be using it anywere. Maybe
copied from 822header.js or mailproc_util.js? Seems like cruft, so remove it.

Also, don't ever send an "In-Reply-To" heder field via NNTP (it's not valid
/used for NNTP articles, per RFC 5536).

Modified Files:


exec/load/newsutil.js
diff

In-Reply-To is not a valid NNTP article header field

... so this was just redundant noise. Altough "References" is a valid header
field *both* for email and nntp articles, "In-Reply-To" is for email only.
per RFC 5536

Modified Files:


exec/load/newsutil.js
diff

Fix the regex in the parsing of the "References" header field

We only want one Message-ID (we'll use the last, since that appears to be the
message being replied to based on SLRN behavior). This fixes reply linkage
when posing from newsreaders that put multiple message-IDs in the
references header field. This is required for SBBSecho to do its magic
creation of the FTN REPLY kludge during export.

This is the fix that Accession was looking for, I think.

Modified Files:


exec/nntpservice.js
diff

Revert "Don't overwrite the posted-reply FTN REPLY ID if it was provided by the
client"

This reverts commit a7f1a24a2ce7e67a87d067a89450a18108b8965d.

Not the fix we're looking for.

Modified Files:


exec/nntpservice.js
diff

Revert "Look up referenced FTN MSGID of messages being POSTed and use in
FTN-REPLY"

This reverts commit d4692e0a5cf643b67928ec8e2cdf9b333c1ab2d0.

Not the fix we're looking for.

Modified Files:


exec/imapservice.js
diff

Don't overwrite the offset with the IMAP offset, add a new one.

Modified Files:


exec/imapservice.js
diff

"Final" optimizations

Use the fastest message base access methods documented.
Cache read/write configs and avoid parsing on read if unchanged.
Make common saves dependent on there being changes.

This is likely as good as it gets (assuming it works)

Modified Files:


src/sbbs3/sbbsecho.c
diff

Use fmutex_open for 100% locking and auto-removal upon close/termination

Modified Files:


exec/nntpservice.js
diff

Don't overwrite the posted-reply FTN REPLY ID if it was provided by the client

Modified Files:


exec/nntpservice.js
diff

Look up referenced FTN MSGID of messages being POSTed and use in FTN-REPLY

... for Acccession

Modified Files:


exec/imapservice.js
diff

Wrap each cleanup step in a separate try/catch in exit func.

Clean up as much as possible.

Modified Files:


exec/imapservice.js
diff

Replace / with - in group/sub names

Almost no clients support a / in names.  Maybe I'll define an x-
extension or something when I write my own mail client.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Leave the user/*.ftp lock file open for better protection

This appears to be the only way to 100% provide mutual exclusivity between
Windows and Linux client sharing a Samba file system.

Also, make fmutex_close() take a pointer to the file descriptor so that we can
better manage the resource (i.e. don't close a descriptor that's already been
closed and possibly valid in another thread).

Modified Files:


exec/newslink.js
diff

Print the correct .ini filename where ptrs are saved

was printing the filename in uppercase if configured as such

Modified Files:


exec/imapservice.js
diff

Some saved_config cleanup before splitting configs.

Modified Files:


exec/imapservice.js
diff

Overhaul the saved config.

Rather than a single file with config for all subs, use a separate
file for each sub.  This makes clients that do parallel connections
to different mailboxes work much better, and make loading and saving
the config for a mailbox much faster.

The caching stuff is removed to simplify things, and hopefully won't
need to come back... we should just not save config if it doesn't
change.

Only issue I'm still aware of is that 99% of IMAP clients just can't
deal with slashes in mailbox paths.  Like... at all.  The protocol
supports them, but every client seems to have a different way of
breaking with them.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

We can call remove() right after opening to enable auto-remove on *nix

... which simplifies the fmutex_close() function and signature.

Modified Files:


exec/newslink.js
diff

Don't download more msgs than the max for the sub-board (if non-zero)

No sense downloading articles we're just going to toss out the next time
we performance msgbase maintenance.

Modified Files:


src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

Make the spamblock.cfg auto-added entries expirable (configurable duration)

By default, the duration is infinite, but some sysops may not want this
file to be ever-grower but rather periodically pruned by the new trashman
utility.

Sysop that don't use spambait.cfg won't benefit from this change.

Modified Files:


src/sbbs3/nopen.c
diff

Fix for Borland C++ build

Also, don't get hostname unless we're surely going to write to the file.

Modified Files:


src/sbbs3/main.cpp
diff

Just a little wording update on the fmutex file open log message

Modified Files:


src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Add fmutex_close() method to atomically remove the mutex file on Win32

The 'atomic_remove' argument isn't used in non-Windows builds since we can
remove() before close() on non-Windows OSes already.

Modified Files:


src/sbbs3/main.cpp
diff

Use fmutex_close() and don't log ENOENT errors when removing pack*.now files

Modified Files:


exec/imapservice.js
diff

Add a sanity check on saved config.

I managed to hit a bug where bseen and seen were both completely
filled.  No idea how I hit it, so not positive it's fixed.

This is cheap insurance against the 43k file groung to 1.6MB for
someone else.

Modified Files:


exec/imapservice.js
diff

More speed optimizations

1) Cache the binified seen data rather than regenerate every time
2) Only call js.gc() after a complete fetch or store loop

Modified Files:


src/sbbs3/con_out.cpp
diff

The progress reports (e.g. "[ Done      100.0% ]") should never go to logs

Modified Files:


src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Add fmutex_open() for cases where you want to keep the mutex file open

Modified Files:


src/sbbs3/main.cpp
diff

Use fmutex_open() instead of fmutex() to better protect the pack*.lock files

Modified Files:


src/sbbs3/nopen.c
diff

Use sopen(... SH_DENYRW) for fmutex() instead of open()

O_EXCL doesn't appear to be working very reliably over Samba, so let's add
file locking to the equation.

Modified Files:


exec/imapservice.js
diff

Don't rollback scan pointer on sub close.

Modified Files:


exec/imapservice.js
diff

Remove set-but-never-used msg_ptrs

Modified Files:


exec/imapservice.js
diff

What I hope are the last \Seen and \Recent fixes.

Modified Files:


src/sbbs3/main.cpp
diff

Reolve !ERROR 2 (No such file or directory) removing "data/pack####.now"

glob() results might be out of date by the time we look at each file, just
skip missing QWK pack semaphore files silently. This should resolve the
".now already gone" messages too. Hopefully.

Removed some extraneous quotes around logged event command-lines.

Modified Files:


src/sbbs3/main.cpp
diff

Use timestr() instead of ctime_r() for logging full date/times

Also when detecting a blocked event_thread, log the event_code that is/was
running last.

Modified Files:


exec/imapservice.js
diff

Simplify close_sub()

Should be no functional change.

Modified Files:


exec/imapservice.js
diff

If open_sub() fails, set readonly to true.

Modified Files:


exec/imapservice.js
diff

Save scan_ptr for all subs in config.

Also, make save_cfg() require that the lock be held.

Modified Files:


exec/imapservice.js
diff

More Seen flag overhaul.

This should now actually work properly.
Also, add a debug_exceptions flag to rethrow exceptions so I can
get line numbers.

Modified Files:


exec/imapservice.js
diff

Roll the epoch back to zero if it hits 9007199254740991

It shouldn't though.

Modified Files:


exec/imapservice.js
diff

Fix BODYSTRUCTURE bug that prevented macOS Sequoia from loading messages

Also, always use full_send(), not the socket send.

Modified Files:


src/sbbs3/sbbs.h
diff

sbbs_t::fremove() will now, by default, ignore (not log) ENOENT errors

ENOENT = "No such file or directory"

Passing 'true' for the optional 'log_all_errors' parameter overrides this
(logs all errors, including ENOENT).

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Remove "QWK Prepack" feature (has been on chopping block for a long time)

This removes unnecessary some cruft and complexity, most especially from the
event_thread().

Using sbbs_t::fremove() instead of remove(). This probably resolves some
Coverity issues where we weren't checking the return value.

Modified Files:


exec/newslink.js
diff

Return 1 on failure (e.g. authentication failure), not 0

Only log message header read error if the msgbase.status is non-zero

Don't try to import anything if the stop semfile is signaled while
exporting.

Increment revision to 1.2

Modified Files:


exec/testbuild.js
diff

Updates nightly builds in filebase

Modified Files:


src/sbbs3/main.cpp
diff

Detect hung event_thread and log details

Add log message when spawning background timed event

Modified Files:


src/sbbs3/main.cpp
diff

Log event command-lines (repeating event code was redundant)

Only log messages about QWK mutex files existing when > 60 seconds old

Modified Files:


src/sbbs3/main.cpp
diff

Better support for multiple hosts handling QWK events

First, fix the logged username bug in the "Lock exists" log message.
Next, double check that the trigger file (sem file or REP file) still exists
after acquiring the file mutex.

Use a temp varible (fname) to make the code easier to read.

Modified Files:


exec/imapservice.js
diff

Fix UID FETCH deadlock.

Also, after grabbing a lock, enter a try/catch that will unlock
and re-throw the error.

Modified Files:


exec/imapservice.js
diff

Increase lock timeout to 5 min, reset imap config on exception

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Include number of timed events and external programs in title of list windows

Modified Files:


src/sbbs3/answer.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/date_str.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

src/sbbs3/sbbsecho.c
diff

Only allow one FTP session per QWKnet user account

Vertrauen's FTP server gets abused by QWKnet logins sometimes and handling
the race conditions around QWK packet creation attempts is silly - there's
no legit reason why a QWKnet account needs to be logged-in multiple times
concurrently to the hub's FTP server, so reject the subsequent logins even
when they're on different hosts (as is the case with Vertrauen).

As part of this change:
- fmutex() now takes an new time_t* argument to (optionally) store the
  time of the mutex file for helping logging (locked since when?).
- time_as_hhmm() created to format a string as either HH:MM or HH:MM[a|p]
  (depending on system configuration for 12 or 24 hour time formatting).
- renamed the old hhmmtostr ()to tm_as_hhmm() (since it takes a struct tm arg)
  and have it return a non-padded string (useful in more situations without
  requiring truncation) when the sysop prefers 24-hour time.

Modified Files:


src/xpdev/sopenfile.c
diff

Add a -l (loop) option to retry until failure

Pretty remedial option parsing here, the order is significant

Modified Files:


exec/jsdocs.js
diff

Add git details to version information displayed

Modified Files:


src/uifc/uifc32.c
diff

Just overhaul this who chunk of code.

Modified Files:


src/uifc/uifc32.c
diff

Fix bug reported by DigitalMan

It looks like this has been a long-standing UIFC bug (pre-3.0)

If a uifc list that can scroll is showing the bottom-most line,
and an option that is not the last is deleted, and both *cur and
*bar are left untouched, *bar would be adjusted to be too high,
resulting in various highlight bar corruption issues.

This commit just rewrites that logic to be comprehensible, and
ensures that if bar is set such that the list would end before the
bottom of the window, it gets moved up.  This makes delete do the
right thing (didn't test with insert, that may do weird things).

Also, since I figured out a good definition of what bar actually
represtens, add a comment to that effect.

Modified Files:


src/syncterm/CHANGES
diff

Mention the change

Modified Files:


src/sbbs3/js_msgbase.c
diff

Document the editor property (field) of the message header object

there are still other undocumented fields/properties, but this one for sure
was missing.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

src/sbbs3/startup.h
diff

Allow a separate log level for the event thread of the terminal server

So you want to debug (timed) events, but don't want to get debug-spew in your
terminal server log output? Now you can: By default, the event thread log
level will be the same as the terminal server, but now you can override this
by setting [BBS] EventLogLevel in the sbbs.ini file or set it in
SCFG->Servers->Terminal Server->Event Log Level.

Modified Files:


exec/imapservice.js
diff

New IMAP search parser/generator

Previously, the IMAP search tried to do sneaky things to optimize
execution time, but that ended up with problems when nested ()s
were used, among other, more subtle issues.  Also, the old search
wasn't even tested enough so that each term would work.

The new system transpiles the IMAP query to Javascript then runs
the compiled JS function for each message.  Should be much more
accurate (though may also be much slower).

Actually fixes the issue reported as #397, and closes #730.

Modified Files:


exec/newslink.js
diff

Don't report how many bases are being scanned, cause we don't know

... was always reporting 0 because 'area' is not an array object

Modified Files:


exec/load/newsutil.js
diff

Import and export the message "editor" as the NNTP "user-agent" header field

The message editor is exported/imported to/from FTN as the "NOTE" kludge.

For Accession, per irc.synchro.net

Modified Files:


src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

When processing AreaRequest with -R (rescan), rescan existing echoes too

If the body of the request mesages message contains a list of area-tags,
even if we already have the node linked to those echoes, do the rescan for
each listed echo. Previously, only newly-added echoes would be rescanned
via this method.

Apparently the D'bridge built-in method of generating AreaManager requests
uses this syntax (per Ward Dossche).

Also, when rescanning due to AreaManager rescan request and generating a
response netmail message, include the total number of messages exported as a
result.

Increase SBBSecho version number to v3.22 (Please upgrade, Fernando) :-)

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Check whether cost is in the file metadata before using it. Also,
when getting a file's full path, ensure its name is passed to get_path(), as
described by the JS documentation.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_check_cost_in_metadata' into 'master'

DDFileLister: Check whether cost is in the file metadata before using it. Also,
when getting a file's full path, ensure its name is passed to get_path(), as
described by the JS documentation.

See merge request main/sbbs!472

Modified Files:


src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add a 'misc' field for System/Fixed Events allow disabling and "Native"

Configured in SCFG->External Programs->Fixed Events and the Node Daily Events
configured in SCFG->Nodes, now can be disabled (without just clearing the
command-line) and toggle-on "Native", so the program doesn't have to be added
to the dreaded "Native Program List" in order to *not* be treated as a 16-bit
DOS program (the default).

Eventually I'll allow multiple of each time of system fixed event, but this
is an improvement for now at least.

Modified Files:


src/sbbs3/userdat.c
diff

A file descriptor of 0 is technically valid (though normally, STDIN)

Likely fix for CID 514647

Modified Files:


src/sbbs3/sbbsecho.c
diff

Support multiple files ("FileList" per FTS-1) in subj when creating .REQ files

Previously, this feature assumed just one request per FREQ message, however
FTS-1 make this clear:

      If  one  or more  of FileAttached, FileRequest, or  FileUpdateReq  are
      asserted  in an AttributeWord, the subject{72} field is interpreted as
      a  list of file specifications  which may include wildcards and  other
      system-dependent data.  This list is of the form

      FileList = [ FileSpec { Sep FileSpec } ] Null

      FileSpec = (* implementation dependent file specification.  may
                    not contain Null or any of the characters in Sep. *)

      Sep      = ( " " | "," )  { " " }

Modified Files:


src/sbbs3/fidodefs.h
diff

src/sbbs3/sbbsecho.c
diff

Complete the support for multiple files (FileList) in subject of netmails

... also the support for multiple spaces or commas separating each filename.

Oh, FTS-1, how did I miss thee?

Modified Files:


src/conio/Common.gmake
diff

src/sbbs3/GNUmakefile
diff

src/syncterm/GNUmakefile
diff

src/xpdev/Common.gmake
diff

Normalize SDL on macOS

Prefer sdl2-config from the path, and only use the framework in
/Library/Frameworks if that doesn't exist... to that end, don't
copy the framework into the app anymore unless you're using it.

This should clean out the pipes.

Added Files:


src/sbbs3/scfg/resource.h
diff

src/sbbs3/scfg/scfg.rc
diff

src/sbbs3/sync.ico
diff

Modified Files:


src/sbbs3/scfg/scfg.vcxproj
diff

Add "SYNC" icon (64x64, captured from GJ's "SYNCH" ANSI splash)

To replace lost the default/conio icon (for Windows builds) recently

Modified Files:


src/sbbs3/main.cpp
diff

Use new FILE_RETRY_ERRNO() macro for sopen() retries in sbbs_t::nopen()

Modified Files:


src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Add make_newsgroup_name()

Modified Files:


src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfglib1.c
diff

Use (new) make_newsgroup_name() function

... to be sure configured newsgroup name is RFC compliant.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Support multiple filenames in subjects of file-attach netmails being packed

When writing the attached file path/names to the FLO file, parse each
filename out of the subject, accordingly. This should fix issue #824.

There's an inconsistent support in SBBSecho for FileLists in the subjects of
netmail messages. In a couple of places, single-space-separated filelists are
fine (but not commas or multiple space, even though they are allowed per
FTS-1).

This particular fix is just for the packing of netmail messages and the
appending the attached file(s) to the FLO file. Those other places (e.g.
.REQ file creation) will need their own fixes for proper filelist support.

Modified Files:


src/xpdev/filewrap.h
diff

Add FILE_RETRY_ERRNO() definition, to be used in sopen()/lock() loops

Note: EBUSY was added to the list of errno values that should cause a retry
as observed on Vertrauen, running sbbs-linux on a Samba mount, opening
locked files can return failure (-1) with errno = EBUSY, e.g.
evnt BBS Events !ERROR 16 (Device or resource busy) in logon.cpp line 616
(logonstats) reading "system stats" access=0

This was apparently resolved by adding EBUSY (16) the values that trigger an
sopen()
retry (i.e. from [f]nopen()).

Modified Files:


src/sbbs3/nopen.c
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.c
diff

Use (new) FILE_RETRY_ERRNO() macro to decide to retry sopen()

also retrying fread() and chsize(), but that seems harmless.

Modified Files:


exec/imapservice.js
diff

Current IMAP standards to not allow additional text after FLAGS

Remove the grease.

Modified Files:


exec/imapservice.js
diff

Add more paranoia.

This is a suitable amount of paranoia now.

Modified Files:


exec/imapservice.js
diff

Add a bit of paranoia to the infinite loop in lock_cfg() too.

Modified Files:


src/sbbs3/js_socket.c
diff

Document return values of Socket.poll()

Modified Files:


exec/imapservice.js
diff

poll() for write, and break on sock.send() returning zero

Should fix log-padding infinite loop.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Include the size of the message headers in the POP3 STAT response too

I suppose if we only had messages with no body text, this value could be 0
(not accounting for any headers) and thus throw a client off.

So consider this as part of the fix for issue #822.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Report bigger "size of message" in POP3 LIST response

For messages that have no body, we'd report 0. But RFC 1939 says this value
is supposed to be "the exact size of the message in octets" <sigh>. This
would include header fields, so while we can't know the exact RFC822 size,
adding the msg's hdr.length to these values gives size > 0 for messages
with no body text and this enables the Apple iPhone Mail app to download
the message (fixing issue #822).

Part two of this fix is to provide a blank line of message text when there
is none. This changes the message displayed in the iPhone Mail app from:

"This message cannot be displayed because of the way it is formatted.
 Ask the sender to send it again using a different format or email program.

 text/plain"

to (the much nicer):
 "This message has no content".

Modified Files:


exec/imapservice.js
diff

NAMESPACE didn't help with Claws/Sylpheed.

Change the message.

Modified Files:


exec/imapservice.js
diff

Fix handling of short send()s

For some reason, I thought socket.send() did this, but apparently
not.  Fixes issue transferring large messages.

Also, add support for the useless NAMESPACE command.

Modified Files:


exec/imapservice.js
diff

Don't map new-scan config to IMAP subscriptions

The sets of message bases you want to get over different protocols
may be different.

While we're here, fix an error with single-parameter FETCH parsing
which prevented Sylpheed from being able to read messages.

Modified Files:


exec/imapservice.js
diff

Add comment as to why the body is being replaced.

Modified Files:


exec/imapservice.js
diff

Update fix in e0e1fc389c

Instead of text with completely different meaning, change the "no body"
text to a single space.

Modified Files:


exec/imapservice.js
diff

Fix deadlock introduced in last commit.

Modified Files:


exec/imapservice.js
diff

Hold config lock for whole sequence.

Rather than locking for just one message, lock for the entire command
when potentially updating Seen data.  With this, we can block all
connections the user has except the currently executing one, and
not need to read/write the seen data between every message.

While this can take minutes on very large subs, it's certainly
better than hours as previously.

It's rude to have multiple sockets actively pumelling the server
anyway.

Modified Files:


exec/imapservice.js
diff

exec/load/822header.js
diff

Fix what appears to be a potential security hole (and some other stuff)

If the INI file could not be opened, a failure would be returned,
but authentication would (potentially) succeed.  I can't think of
a way to exploit this, but it's getting late.

Also, make some minor optimizations that won't make a difference yet,
and move opening the file into a single function.

Modified Files:


exec/imapservice.js
diff

Optimize read/save of Seen config

Previously, this uses INI format files, with ini file accessors
to read and save this file.  Now it just dumps a JSON file in and
slurps it out.

This saves about 0.4s/msg on my system when reading headers.

Modified Files:


exec/imapservice.js
diff

Do some more optimizations around setting the Seen flag.

This speeds things up a fair bit, and will make things faster after
an initial scan.  I may expand this method a bit to lock other sockets
for for either some period of time or some number of messages to
allow the initial scan to be even faster.

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

Allow 3 digit message base retry timeout

Modified Files:


src/sbbs3/nopen.h
diff

src/sbbs3/userdat.c
diff

Reduce LOOP_NOPEN and LOOP_USERDAT from 500 to 100

With the incremental backoffs, these were super long waits for locks. Not sure
about my math there, but at 500, the total timeout was not "about 45 seconds"
but rather several minutes.

At 100, the total max retry time should be almost exactly 45 seconds:

Retries      ms-per     total seconds
  0 - 9      0          0
 10 - 19     100        1
 20 - 29     200        3
 30 - 39     300        6
 40 - 49     400        10
 50 - 59     500        15
 60 - 69     600        21
 70 - 79     700        28
 80 - 89     800        36
 90 - 99     900        45*
100 - 109    1000       55
110 - 119    1100       66
120 - 129    1200       78
130 - 139    1300       91
140 - 149    1400       105
150 - 159    1500       120
160 - 169    1600       136
170 - 179    1700       153
180 - 189    1800       171
190 - 200    1900       200!

... so yeah, 500 was way too big a number.

Modified Files:


src/xpdev/filewrap.c
diff

Revert the lock() change in commit 043feff8

So this change is needed or else fcntl() will fail with errno=BADF if trying
to write-lock a file that was opened read-only. Oh well. Added a comment
explaining the rationale.

Modified Files:


src/xpdev/lockfile.c
diff

Add -r option for opening the file to lock read-only

It makes a difference on *nix.

Modified Files:


src/xpdev/showlocks.c
diff

Add support for -r (read-only) open before locking

And only supports a single file per invocation now.

Added Files:


src/xpdev/lockfile.c
diff

src/xpdev/showlocks.c
diff

Some helpful test programs for testing file record locking.

Added Files:


src/xpdev/sopenfile.c
diff

A useful little program for testing sopen() from filewrap.c

This is the program I used (along with flock) to reach the root cause of
the SH_COMPAT == SH_DENYRW (no locking) bug in sopen() as well as other
interactions between Linux and Windows clients opening the same files
across a Samba share.

Modified Files:


src/xpdev/filewrap.c
diff

Log a build warning if building for Linux without OFD lock support

OFD locks are needed on Linux for appropriate multi-threaded shared file
access (using fcntl record locks to prevent corruption), so log a warning if
building for Linux without that support.

lock() now mimics DOS/Windows again: the result lock is an "all access" lock
regardless of what mode the file was open in. I'm not sure why this change was
made (commit 11b73134563ce26), but I don't think it was necessary or
appropriate (though I can't think of any immediate negative effects). At
minimum it makes the code a little more understandable and eliminates an
extra call to fcntl().

Modified Files:


src/xpdev/filewrap.c
diff

Get rid of the fcntl() usage in sopen()

You can't lock a file on a Samba share via both fcntl() and flock() (the
interact/collide).

This code was in a !BSD block which means they guy that wrote/committed
it wasn't using it either.

Modified Files:


src/xpdev/filewrap.c
diff

src/xpdev/filewrap.h
diff

Remove the F_SANE*LCKNO stuff

It appears Deuce's FreeBSD patch isn't going to be accepted/merged
(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=50827), so I'm
making this code a little more readable/manageable by removing this
unused feature... for now, with Deuce's approval.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Log a notice-level message when renaming a bad bundle file to *.?_? or *.?-?

Modified Files:


exec/load/newsutil.js
diff

exec/nntpservice.js
diff

Use original RFC822-formatted subject, if available (e.g. recv'd via SMTP)

This solves issue #817 for TLDR messages imported into DOVE-Net Tech Talk,
because those messages are imported via SMTP originally and thus have the
original (MIME/Q-encoded subject) in the message header (as RFC822SUBJECT).

For other messages with UTF-8 characters in their header fields (e.g. subject),
we'll need a different solution (Q-encode header fields that contain
non-ASCII chars on the fly), and then this solution could maybe be reverted.

Modified Files:


src/smblib/smblib.c
diff

Fix printf formatting issue in error message

GCC and Coverity (x 2) both flagged this one.

Modified Files:


exec/imapservice.js
diff

Fix bug introduced in aecde4068 (2018)

Properly read the index of the base, not of the base_code.
Fixes badly broken STATUS command.

Modified Files:


exec/load/newsutil.js
diff

exec/nntpservice.js
diff

Use original RFC822-formatted subject, if available (e.g. recv'd via SMTP)

This solves issue #817 for TLDR messages imported into DOVE-Net Tech Talk,
because those messages are imported via SMTP originally and thus have the
original (MIME/Q-encoded subject) in the message header (as RFC822SUBJECT).

For other messages with UTF-8 characters in their header fields (e.g. subject),
we'll need a different solution (Q-encode header fields that contain
non-ASCII chars on the fly), and then this solution could maybe be reverted.

Modified Files:


src/smblib/smblib.c
diff

Fix printf formatting issue in error message

GCC and Coverity (x 2) both flagged this one.

Modified Files:


exec/imapservice.js
diff

Fix bug introduced in aecde4068 (2018)

Properly read the index of the base, not of the base_code.
Fixes badly broken STATUS command.

Modified Files:


src/syncterm/GNUmakefile
diff

Don't require copying the SDL.framework into the bundle

When using MacPorts (and likely Homebrew), this isn't how this works.

Modified Files:


src/build/Common.gmake
diff

Old sw_vers on macOS uses a single dash.

New versions still support that.

Modified Files:


.gitlab-ci.yml
diff

Make darwin-x86 builds verbose for now...

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix logic in bbs.xfer_prot_menu()

This was just a typo which didn't allow the single-file upload xfer prot menu
to be shown.

Actual fix for CID 11447 (previous attempt, commit f50c866fd was
insufficient). Thank you Coverity!

Modified Files:


src/sbbs3/js_socket.c
diff

Don't check recvline() timeout *before* checking if there's data to receive

This was a regression: Socket.recvline() used to not care what the timeout
duration was so long as there were bytes to receive.

Also, remove the ".0" from timeout values in documented mehtods that don't
(any longer) accept floating point timeout durations. We used to support
fractional seconds for some of these methods, and that was implied by using
the floating point default values, but that's no longer the case. poll()
still accepts a floating point timeout.

Modified Files:


.gitlab-ci.yml
diff

Reconnect with High Sierra

Modified Files:


.gitlab-ci.yml
diff

Disconnect the x86 mini from the pipes.

It's slow and crufty, and there's a new mini on the block now.

Modified Files:


3rdp/build/GNUmakefile
diff

Set MAKE=$(MAKE) for libffi make is gmake.

Should fix OpenBSD builds.

Modified Files:


3rdp/build/GNUmakefile
diff

Add -z for OpenBSD

It's super-picky.

Added Files:


3rdp/build/js-isfinite.patch
diff

3rdp/build/js-macos-configure.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

A couple patches to build on macOS M2

Use standard isfinite() instead of never-standard finite()
Don't use -rpath-link on darwin (since it won't work anyway)

Modified Files:


src/conio/CMakeLists.txt
diff

USE_CURSES_ANYWAY on Darwin as well.

Added Files:


3rdp/dist/libffi.tgz
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Update libffi in SpiderMonkey

Rather than trying to back-port platform support, just grab the
latest libffi release and jelly it in.

Let's wee what the pipes tell us.

Modified Files:


.gitlab-ci.yml
diff

They need to be different OSs!

That's the key!

Modified Files:


.gitlab-ci.yml
diff

Try tags without hyphens?

Ugh.

Modified Files:


.gitlab-ci.yml
diff

Apparently tags are a substring match?

Modified Files:


.gitlab-ci.yml
diff

Ok, we need RELEASE=1 or things break.

Modified Files:


.gitlab-ci.yml
diff

Don't use buildflags on M2 yet.

Modified Files:


src/comio/comio_nix.c
diff

Fix stupid

Modified Files:


src/comio/comio_nix.c
diff

If CBAUD is defined, retain the CBAUD bits in c_cflags

Otherwise, zero it out.  Most termios implementations don't put the
speed in here, but this *is* where dragons be.

Modified Files:


.gitlab-ci.yml
diff

Add the M2 mini

This will likely fail though.

Modified Files:


src/sexpots/sexpots.c
diff

Enable signal (e.g. Ctrl-C) handling / ignoring

Gracefully terminate with SIGQUIT, SIGINT, and SIGTERM

Ignore SIGHUP and SIGPIPE.

Modified Files:


src/comio/comio_nix.c
diff

Don't reset the port baud rate to 0 in comOpen()

As noticed while trouble-shooting issue #813, calling comOpen() would
(on Linux, at least) set the port baud rate to 0 bps (B0) which in
most or all Linux serial drivers triggers special logic to deassert DTR and
RTS signals (to the modem, to attempt to "hangup" any connection).

If the app (e.g. sexpots) did not explictily set the port baud rate after
calling comOpen(), the port would be unusable. This is not how comOpen() works
on Windows.

So rather than just overwrite all the bits in termios.c_cflag, we clear the
fields we know we want to, set the bits we want, and leave the rest (which
usually includes the current baud rate, if CBAUD is defined) as-is.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

DDFileLister: When showing file info, check more of the properties to see if
they exist first

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'ddfilelister_show_info_check_more_properties_exist' into 'master'

DDFileLister: When showing file info, check more of the properties to see if
they exist first

See merge request main/sbbs!471

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

Allow clicking in the comment line to edit.

Modified Files:


src/conio/sdl_con.c
diff

src/syncterm/CHANGES
diff

Fix window scaling on macOS with retina displays

SDL_SetWindowSize() takes dimensions in imaginary units it makes up
so it can call something "Retina™".  SyncTERM however lovingly
crafts everything pixel by pixel for an atisanal ode to BBSing.

This change converts pixel sizes to Retina™ sizes before resizing
the window.  Should fix ticket 164.

Modified Files:


src/sexpots/file_id.diz
diff

src/sexpots/sexpots.c
diff

When not in Telnet Binary TX mode, expand bare CR received from COM to CRLF

I can't believe I missed this - this would've caused definite issues with file
transfers.

I saw a discussion in FSX MYS (between apam and GEARBOX)  which clued me into
their being an issue here. I do wish users of SexPOTS would report issues to
me. :-(

Incremented version to v2.1

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

If fail to create dirs.raw in lib parent dir, create in ctrl_dir instead

Fix for issue #809

Modified Files:


src/sftp/sftp_client.c
diff

Don't retypedef sftpc_state_t for ancient compilers

(ie: gcc 4.4)

Modified Files:


src/syncterm/CHANGES
diff

Update changes

Modified Files:


src/conio/scale.c
diff

Use uint64_t instead of double for interpolation.

More effort to fix the macOS issue.  This could potentially result
in slight problens with the rightmost pixel, but will protect
against any weird FP issues and -ffast-math concerns.

Modified Files:


src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add Monthly fixed (system-wide) event

True, a sysop could add/configure a monthly timed event instead, but that
requires more configuration. Fixed events are nice in their simplicity.

This is intended for running the new Synchronet trashman utility, but could be
used for anything that's simple to execute and the sysop:
- doesn't care which node/instance of sbbs it runs from
- doesn't care exactly what time the event runs
- doesn't need the assorted options available for timed events

Modified Files:


src/sbbs3/scfgsave.c
diff

Use an .ini style that indents keys and puts blank line after the root section

A few extra bytes really helps with human readability.

Modified Files:


src/conio/scale.c
diff

src/conio/xbr.c
diff

More scaling cleanup... no undefined behaviour

Remove undefined behaviour (right-shifting a negative integer) from
the scaler... replace with divide-by-2.  Any modern compiler should
be able to optimize that.

On the enabling the compiler front, const-ify more variables and
use types that allow removing some casts.

I have a bit more hope this will fix the macOS issue than the previous
efforts.

Modified Files:


src/conio/scale.c
diff

Add most const decorations.

Not sure what macOS is doing, but it looks like something weird is
happening in interpolate_width... maybe some unexpected integer
promotion?

Modified Files:


src/sbbs3/getstr.cpp
diff

src/sbbs3/sbbsdefs.h
diff

Add/use K_RIGHTEXIT and CON_RIGHTARROW

for getstr() to be able to return when user right-arrows off end of string
(for use in msgeditor).

Modified Files:


src/sbbs3/websrvr.c
diff

Add missing argument to new error log message upone putuserdat() failure

Fixes a couple CIDs and a GCC warning

Modified Files:


src/sbbs3/writemsg.cpp
diff

Internal message/line editor improvements

* Allow left and right arrow keys to move between lines (within reason)
* Use the K_USEOFFSET getstr() mode flag to keep cursor position when moving
  between lines with arrow keys
* Be smart about integer padding when /Listing lines with numbers
* Add range checking (!) and better error reporting for /Lx argument value

Modified Files:


exec/init-fidonet.js
diff

Address sysops sending emails to net-coordinators w/invalid reply-to address

Issue raised by Dumas Walker (CAPCITY2) on DOVE-Net: apparently some new
sysops run this script before their configured hostname (e.g.
mybbs.synchro.net) is valid or their mail server has been tested (can
successfully receive Internet e-mail).

This attempts to address this concern by:
1. displaying a warning that it's important that the address given is valid
2. attempt to validate that the host portion of the provided address is valid
   (has a DNS address record or MX record)

Uses dns.js for MX-record lookup - thanks Deuce!

This script does not validate that the email host can actually receive mail
or that the name portion of the mail address is valid: that would require an
outbound connection to the host's TCP port 25, which may be blocked by ISPs
(if remote) or if its a local server (e.g. the same machine as the BBS), that
wouldn't confirm that its reachable by Internet hosts. And not all mail
servers support the necessary SMTP commands to validate recipient addresses.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: For ANSI terminals, refresh the area change header ANSI and header
lines when exiting from the new scrollable area change help window

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_scrollable_area_chg_help_window_refresh_header_ansi
_and_header_lines' into 'master'

DDMsgReader: For ANSI terminals, refresh the area change header ANSI and header
lines when exiting from the new scrollable area change help window

See merge request main/sbbs!470

Modified Files:


src/syncterm/CHANGES
diff

Add to changes.

Modified Files:


src/conio/cterm.c
diff

Make the default Prestel ID 0 bytes long.

CCl4 sends an ENQ character in the login screen, and sends an ENQ
which will auto-fill your username.  Also, if you enter six zeros
into the username, it will take you to the password field.

With ten zeros, this means it's impossible to log in to CCl4.

Modified Files:


src/conio/cterm.c
diff

src/syncterm/CHANGES
diff

Fix Steady and Concealed Prestel modes

Fixes Night Owl

Added Files:


src/sbbs3/trashman.vcxproj
diff

Modified Files:


src/sbbs3/trashman.c
diff

Ported to Windows

Beautified the output a bit.

Modified Files:


src/sbbs3/findstr.c
diff

src/sbbs3/trashman.c
diff

Remove trailing newlines from strings in list returned from findstr_list()

Modified Files:


src/sbbs3/data_ovl.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/useredit.cpp
diff

Move putuserdat() wrapper to data_ovl.cpp where the other userdat wrappers are

And have it return bool, like the others. The error logging is different
(not using errormsg), but I think that's okay.

Modified Files:


src/sbbs3/userdat.c
diff

putuserdat() no longer calls dirtyuserdat() if the write/update failed

Modified Files:


src/sbbs3/sbbs3.sln
diff

Add trashman project

Modified Files:


exec/addfiles.js
diff

Actually, const is better for libs, prevent overwriting (mostly)

If this were const to begin with, would have caught the previously
fixed bug with the -lib option clobbering it.

Modified Files:


src/sbbs3/trashman.c
diff

Add a -t (test mode) option, to run in read-only mode

Modified Files:


src/sbbs3/answer.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/websrvr.c
diff

Check return value of putuserdat() and log any errors

Trying to get to the bottom of user.tab corruption (issue #797).

Modified Files:


src/sbbs3/userdat.c
diff

Check return value of seekuserdat() in putuserdat() and return failure

... trying to get to bottom of user.tab corruption reported in issue #797.

Also, don't need to seek in lockuserdat() since we always call seekuserdat()
first.

Modified Files:


src/sbbs3/GNUmakefile
diff

Use XPDEV_LIBS to solve the trashman-mingw64 link issue (I think)

Modified Files:


src/sbbs3/getstats.c
diff

Don't indent the Date key in the root section

Added Files:


src/sbbs3/trashman.c
diff

Modified Files:


src/sbbs3/GNUmakefile
diff

src/sbbs3/objects.mk
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/targets.mk
diff

src/sbbs3/trash.c
diff

src/sbbs3/trash.h
diff

New utility: 'trashman' to manage/maintain text/*.can (filter) files

Though we've had the auto-filtering feature for about a year now, with
expiration dates supported/added to every trash record, nothing was
removing the expired trash/filter items. Until now.

Check the size of your text/*.can files: if they're really big, this is
the solution.

Not yet building for Windows

Sysops will want to run this periodically (monthly?), e.g.
	trashman /sbbs/text/*.can

Modified Files:


src/conio/sdl_con.c
diff

Fix LOR

Modified Files:


src/conio/sdl_con.c
diff

Add locking around win access

Modified Files:


src/uifc/uifc32.c
diff

More malloc() return checks

Modified Files:


src/conio/cterm.c
diff

"Handle" malloc() failures

Just scream on stderr, and screw things up in the window.

Modified Files:


src/syncterm/uifcinit.c
diff

We need to set the palette before calling uifcini32()

The palette is used to construct the blank screen buffer using
vmem cells, so the background would be in screwy colours when
connecting for modes that don't use the CGA 16-colour palette.

Modified Files:


exec/addfiles.js
diff

Use var keyword for good form (no functional change)

Modified Files:


exec/addfiles.js
diff

Use a different variable name (libname) to not clobber the lib variable

Fix to Nelgin's reported error:
line 199: TypeError: lib.parse is not a function

Modified Files:


src/sbbs3/getstats.c
diff

Don't backup the dsts.ini file when saving changes, not needed any more

Root-caused this problem to read() failures which are now caught and logged
rather than zeroing out the statistics fields.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Allow email.can to contain email sender/recipient *names* as well as addresses

Allow filtering/blocking email based on the name portion of email header
fields.

Modified Files:


src/syncterm/term.c
diff

Map underscore to pound

I think this map may be the final one.

Modified Files:


src/syncterm/term.c
diff

Make Return send #, use CTRL-Return for return

Not tested on Windows.

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.h
diff

Implement the remote programming protocol.

I don't expect anything actually uses this...

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/ciolib.h
diff

src/conio/cterm.c
diff

src/syncterm/term.c
diff

src/syncterm/uifcinit.c
diff

Add support for conceal (toggle with tab)

Modified Files:


src/conio/utf8_codepages.c
diff

Fix some unicode mappings

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: When changing sub-boards, now supports cycling through sort
options via [ and ] (for nelgin). Also, new scrolling window for help text for
changing sub-boards.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch
'dd_msg_reader_sub_board_sort_cycling_and_sub_board_scrolling_help_windows'
into 'master'

DDMsgReader: When changing sub-boards, now supports cycling through sort
options via [ and ] (for nelgin). Also, new scrolling window for help text for
changing sub-boards.

See merge request main/sbbs!469

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/cterm.c
diff

Implement double-height.

This is so gross... outputting any character depends on every
character above it, so it must be checked every time.  If the state
was ste up differently, this could be avoided, but it's not, so it
can't.

For v2, I'm going to want to store some per-line data in a separate
struct so I can track this.

Modified Files:


exec/areamgr.hlp
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

Add support for AreaFix -R, -L, and -Q options in subject of AreaMgr requests

(these options follow the password by one or more spaces)

I implemented these based on AreaFix v1.10 User's Guide, at Ragnarok's
suggestion/request. I didn't test them, so looking forward to getting some
test results.

The -L and -Q options are functionally identically to the %LIST and %QUERY
AreaManager commands, while -R ads a little efficiency by combining +areatag
(add) and %RESCAN <areatag> requests in a single command.

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/sbbsecho.c
diff

Support additional arguments in AreaFix request message subject, beyond pass

Apparently AreaFix and other area managers assume password never have spaces
in them, so they can support additional arguments following the password in
the AreaFix request.

This change also now disallows setting AreaManager passwords with spaces in
them.

I don't yet support any of the additional AreaFix request options (e.g. -L,
-R, -Q), but am considering it.

A bunch of sprintf() -> snprintf() conversions are included in this commit
(better string buffer security, probably eliminate a Coverity issue or two).

Modified Files:


xtrn/minesweeper/graphics.ppm
diff

The squares with numbers and bombs are now flat and updated colors

Lowered the intensity of the green '3' (happier on my red-green
colorblindness).

Result looks more like the original Windows versions of this game.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

ddfilelister: Clear the console line counter before any searching, etc., to
prevent screen pauses. This should help with issue #806

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'ddfilelister_console_clear_line_counter' into 'master'

ddfilelister: Clear the console line counter before any searching, etc., to
prevent screen pauses. This should help with issue #806

See merge request main/sbbs!468

Modified Files:


src/sbbs3/GNUmakefile
diff

src/sbbs3/targets.mk
diff

Fix textgen build (when SBBS_OFFICIAL is defined)

This build rule needed to be defined *after* objects.mk and rules.mk are
included.

Modified Files:


xtrn/minesweeper/minesweeper.hlp
diff

xtrn/minesweeper/minesweeper.js
diff

Add support for Ctrl-G to toggle/re-direct graphics mode

Also if the help screen is exactly the right number of lines where auto-pause
didn't leave any unviewed lines, don't pause twice.

Modified Files:


src/conio/cterm.c
diff

Implement line editing support.

Changing "stuff" on a line will now propogate to the right
appropriately.

Next up is double-height characters... hopefully.

Modified Files:


src/conio/allfonts.c
diff

src/syncterm/CHANGES
diff

Fix typo for NO_FONTS support

Modified Files:


src/conio/allfonts.c
diff

src/conio/ciolib.adoc
diff

src/conio/ciolib.h
diff

src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/conio/utf8_codepages.c
diff

src/conio/utf8_codepages.h
diff

src/conio/vidmodes.c
diff

src/conio/vidmodes.h
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

Initial Prestel support.

Basic Prestel support based on the "Prestel Terminal Specification"
Issue 2 by the Post Office.

Known issues:
Modifying an existing line does not update the row after it.
Double height is not supported.
Keyboard mapping kinda sucks (looking at you #/Return).
Concealed is always shown.
Remote programming sequences aren't supported.

There appears to be something wrong with the End of the Line title
and menu screens, but maybe nelgin did them wrong.

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/str_list.c
diff

src/xpdev/str_list.h
diff

strListFastRemove() and strListFastDelete() now take a count argument

... if you're deleting more than one string, this is much more efficient.

Note we do some pointer compares (in strListFastRemove) *after* we've freed
them in strListFastDelete(). I don't suspect this to be an issue, but it does
seem suspect.

Modified Files:


src/sbbs3/userdat.c
diff

strListFastDelete() now takes a count argument

Modified Files:


src/sbbs3/writemsg.cpp
diff

text/menu/editor.asc
diff

Refactor the internal message editor /D command to support deletion of ranges

Supporting the deletion of ranges of lines (e.g. 10-20 rather than one line
at a time) was a big ommission for a long time.

Modified Files:


docs/v320_new.txt
diff

More new v3.20 stuffs

Modified Files:


exec/load/text.js
diff

New weekday and month name abbreviations

Modified Files:


src/sbbs3/scfg/scfg.c
diff

The wizard progress bar is wider now (more pages), so need to adjust position

to not overwrite help "screen" borders

Modified Files:


src/sbbs3/js_system.c
diff

Update docs for datestr() method

Modified Files:


src/sbbs3/date_str.c
diff

src/sbbs3/date_str.h
diff

Add verbal_datestr()

For cases where we want to the verbal short date output, regardless of sysop
preference/configuration.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Fix U.S. system timezone reverting to Atlantic when the DAYLIGHT flag was set

... integer sign extension at fault here.

Also, add examples to Numeric vs. Verbal short date selection dialog.
Update some related help text.

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Made 'view file' from the xfer menu actually work when used as a
loadable module (FL_VIEW). Updated extended information view for files.

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_file_view_and_extended_info_update' into 'master'

DDFileLister: Made 'view file' from the xfer menu actually work when used as a
loadable module (FL_VIEW). Updated extended information view for files.

See merge request main/sbbs!467

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Fix dstrtounix() usage

Modified Files:


src/sbbs3/useredit/MainFormUnit.cpp
diff

Fix dstrtounix() usage

Modified Files:


ctrl/text.dat
diff

src/sbbs3/date_str.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

Make the Weekday and Month name abbreviations localizable via text.dat/ini

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/UserListFormUnit.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/date_str.h
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/js_system.c
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/str.cpp
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

dstrtounix() now takes the format (enum date_fmt) directly

This allows us to use dstrtounix() for MM/DD/YY dates regardless of the system
configuration (sysop/locale preference).

This fixes issue with QWK route.dat file and door.sys (expiration date)
parsing where the date is/has-to-be in MM/DD/YY format, always.

Modified Files:


ctrl/text.dat
diff

Include numeric date format hint when editing dates in useredit

... using @-code

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

ddfilelister: Fix for issue #806 - When scanning files, don't pause for user
input between directories.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_issue806' into 'master'

ddfilelister: Fix for issue #806 - When scanning files, don't pause for user
input between directories.

See merge request main/sbbs!466

Modified Files:


src/syncterm/ripper.c
diff

Fix up previous commit

RIPtel reset to the font configured by the user, not the current
font.  Do the same here.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/ripper.c
diff

Don't reset font in RIPv3 mode

It appears v3 kept the font through a RIP_RESET_WINDOWS command

Modified Files:


src/sbbs3/date_str.c
diff

unixtodstr() will output "00/00/00" on invalid dates instead of "01/00/00"

"01/00/00" would get parsed/converted back to Jan-1-2000 (usually), which is
usually not what we want.

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

Create a C++ wrapper for unixtodstr()

No need to use time32_t for this.

Modified Files:


src/sbbs3/getnode.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/useredit.cpp
diff

Use new C++ wrapper for unixtodstr()

Fix new date editing bug in user editor: we must use the numeric format
for dates when creating strings to be edited.

Modified Files:


exec/str_cmds.js
diff

Expand command-line specifiers (e.g. %a) in command-lines passed to ;EXEC

... and friends

For Gamgee

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

Revert back to using system.datestr() for preferred short date display output

Stripped trailing whitespace

Modified Files:


src/syncterm/CHANGES
diff

More changelog goodness... let's rebuild everything!

Modified Files:


exec/rlogin.js
diff

Allow multiple uses of -c and -s options to built-up an auth string

To solve problem of adding some kind of prefix/tag to a user alias when
connecting to a door server. e.g. ?rlogin server -s [TAG] -s %a

Hopefully you don't need/want a space separating the string elements, as
that's not really doable with this solution.

Modified Files:


src/syncterm/ripper.c
diff

Fix handling of broken CRLF pairs in RIP mode

If telnet binary mode is enabled (the new default), and a CR and LF
come in on separate recv() calls, the RIP parser would stop at the
CR, and pass the LF back to the ANSI parser.

Ah, dura-bbs.net, always pushing the limits.

Modified Files:


src/sbbs3/getkey.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Fix mnemonics bug introduced in commit b84c583a26e6f

We want to not expand tilde to attributes when there are any attribute codes
in the mnemonics string. The existene of a non-attribute ctrl-a code should
not have prevented the tilde expansion.

Fix for issue #805 reported by Nelgin (thank you)

Modified Files:


src/sbbs3/date_str.c
diff

This isn't C++ and some C compilers don't support the {} initializer syntax

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Less ambiguous, not unambiguous

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/ripper.c
diff

More RIP fixes for dura-bbs.net

RIP XOR operation had issues with polylines, boxes, etc. where the
same pixel could be written more than once, resulting in it being
toggled back to the original state.

Also, there were some memory leaks of temporary struct ciolib_pixel
variables.  This is now fixed as well.

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/date_str.h
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/useredit.cpp
diff

Add option to display short dates in verbal/unambiguous formats

Although we've added (in SBBS v3.20) configurable numeric date input/display
formats for the system, the output was still ambiguous for users (e.g.
NN/NN/NN which could be interpretted a number of ways), so I've added an option
to choose "verbal" short date formats to be displayed where possible instead.
The same value separate from the numeric format (whatever the sysop chose) is
used in the verbal date output, but since month name abbreviations are 3
characters, only one separator is used (to keep the output length fixed at 8
characters).

The new "Verbal" short date display format is choosable in the SCFG wizard and
via SCFG->System->Short Date Format.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/menu.c
diff

Fix mouse select in scrollback

Both selecting scrollback from the online menu, and viewing the last
scrollback from the main menu were impacted.

Modified Files:


exec/load/shell_lib.js
diff

Fix typo: js.terminated, not js.terminate

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix CID 511447 with extra parens

Modified Files:


src/sbbs3/scfg/scfgnode.c
diff

Logon Requirements renamed to Login Requirements, for consistency

... with Servers->Terminal Server->Login Requirements

Updated help text: F5->Ctrl-C, no need to hand-update sbbs.ini when adding
or removing nodes (any more).

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_system.c
diff

Support string (text.dat string ID) arguments to bbs.text() and system.text()

Currently, this is a slower way to look-up a text.dat string, but requires no
load/require of text.js and allows for a shorter syntax to get a text.dat
string, i.e. bbs.text("Quit") instead of bbs.text(bbs.text.Quit);

Although the bbs.text() ID lookup is cached, it's only marginally faster than
system.text() ID lookup, which is not cached and about 1/3 the speed of the
other methods of index to string lookup (in the MSVC-Windows build).

Modified Files:


src/syncterm/CHANGES
diff

Add change log

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Sorting of sub-boards when changing to another sub-board (for
nelgin). Toggleable behavior to only show sub-boards with new messages in the
indexed-mode newscan (for kdi4hw). Internal: Updated for bbs.msg_number and
bbs.smb_curmsg being write

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_v1_96' into 'master'

DDMsgReader: Sorting of sub-boards when changing to another sub-board (for
nelgin). Toggleable behavior to only show sub-boards with new messages in the
indexed-mode newscan (for kdi4hw). Internal: Updated for bbs.msg_number and
bbs.smb_curmsg being write

See merge request main/sbbs!465

Modified Files:


src/syncterm/conn_telnet.c
diff

Ok, I'm convinced... initiate some telnet negotation

- Attempt to suppress go aheads in both directions.
- Attempt to set binary mode in both directions
- Request the remote echos

These express the assumptions that SyncTERM always makes, so it's
a good idea to tell the remote this.  For systems that don't like
this, there is the Raw "protocol".

Modified Files:


src/syncterm/relcheck.txt
diff

Add item to avoid the macOS fiasco of rc4

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

src/syncterm/term.h
diff

Make ALT-O mouse control toggle work in RIP mode

Modified Files:


src/syncterm/ripper.c
diff

When RIP changes the vstat mode, also change the cursor

When changing between 8 and 16 row fonts in RIP mode, the cursor
start and end was left for the old font size... 16 -> 8 would leave
the cursor one line below the current position, and 8 -> 16 would
leave the cursor in the middle of the cell.

This hacks the vstat deeper to fix up the cursor as well.

Reported by skipperdoodle1947.

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

sbbs_t::protnum() and protname() now accept the transfer type as argument

It's possible to have multiple transfer protocols with the same mmemonic, but
with different transfer types supports (which would be weird, but possible).
This allows us to use protnum() to replace a lot of copy/pasted prot looping
and comparing logic throughout sbbs.

Also added a variant of sbbs_t::quit_key() that takes and returns a string
(for easy concatenation to strings of key chars).

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/email.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/useredit.cpp
diff

Use sbbs_t::xfer_prot_menu() and protnum() to replace copy/pasted logic

This is a code clean-up, no change in functionality

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/ripper.c
diff

Fix issue with RIP and fragmented ANSI

If an ANSI sequence spanned multiple recv() calls, it would get
silently dropped if RIP was enabled.

Reported by skipperdoodle1947 (who does awesome stuff)

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

sbbs_t::xfer_prot_menu() can now return the list of command keys

for use by JS bbs.xtrn_prot_menu() immediately, elsewhere soon.

Modified Files:


exec/user_settings.js
diff

Use the new bbs.xfer_prot_menu() method

In place of the copy/pasted/ported from C++ version of the same logic

Modified Files:


exec/user_settings.js
diff

Use the return value of bbs.xfer_prot_menu()

Also use console.quit_key for localization support

Modified Files:


xtrn/mrc/mrc-theme-aqua.ini
diff

xtrn/mrc/mrc-theme-default.ini
diff

xtrn/mrc/mrc-theme-garden.ini
diff

xtrn/mrc/mrc-theme-hot.ini
diff

xtrn/mrc/mrc-theme-lilac.ini
diff

xtrn/mrc/mrc-theme-midnight.ini
diff

xtrn/mrc/mrc-theme-neon.ini
diff

xtrn/mrc/mrc-theme-rustic.ini
diff

xtrn/mrc/mrc-theme-stone.ini
diff

Replace CRLF with LF

Modified Files:


src/sbbs3/js_bbs.cpp
diff

bbs.xfer_prot_menu() now returns the list of protocol keys (mnemonics)

... that the user has access to

Modified Files:


src/sbbs3/text_defaults.c
diff

Latest default text from ctrl/text.dat

Modified Files:


src/sbbs3/js_bbs.cpp
diff

New method: bbs.xtrn_prot_menu()

So we don't have to reimplement this logic in user_settings.js (or
equivalent) any longer.

Added Files:


src/syncterm/icons/generate-unix.sh
diff

src/syncterm/syncterm16.png
diff

src/syncterm/syncterm22.png
diff

src/syncterm/syncterm24.png
diff

src/syncterm/syncterm256.png
diff

src/syncterm/syncterm32.png
diff

src/syncterm/syncterm36.png
diff

src/syncterm/syncterm48.png
diff

src/syncterm/syncterm64.png
diff

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/GNUmakefile
diff

Removed Files:


src/syncterm/syncterm.png
diff

Update to new icon files for UNIX style installs

Also, fix manpage generation for CMake.

Added Files:


src/syncterm/relcheck.txt
diff

Add a release checklist.

I've forgotten one of these for every RC except the first one for
v1.2. :(

Modified Files:


src/conio/ansi_cio.c
diff

Fix warnings.

Thanks nelgin.

Modified Files:


src/syncterm/CHANGES
diff

Mention new icons in changes.

Added Files:


src/syncterm/syncterm.ico
diff

Add missing icon

Added Files:


src/syncterm/icons/README.md
diff

src/syncterm/icons/generate-win.sh
diff

src/syncterm/icons/generate.sh
diff

src/syncterm/icons/syncterm-Haiku.iom
diff

src/syncterm/icons/syncterm-Haiku.rdef
diff

src/syncterm/icons/syncterm-Haiku.svg
diff

src/syncterm/icons/syncterm-mini.svg
diff

src/syncterm/icons/syncterm.iom
diff

src/syncterm/icons/syncterm.rdef
diff

src/syncterm/icons/syncterm.svg
diff

Modified Files:


src/conio/ciolib.rc
diff

src/syncterm/LICENCE
diff

src/syncterm/SyncTERM.icns
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

Change to new icons contributed by zuMi.

The amazing Haiku community has redesigned the SyncTERM icons for me!

Unfortunately, I had to remove the default "Synch" icon from ciolib
so that SyncTERM could have its own separate icon. :(

I'm not sure if the msvc builds are using the ciolib.rc file or not,
and I'm not sure how they can add an icon... I'll net DigitalMan sort
that out (sorryish).

Modified Files:


src/syncterm/CHANGES
diff

Whoops, need separate commit for master for this now.

Added Files:


xtrn/mrc/mrc-theme-aqua.ini
diff

xtrn/mrc/mrc-theme-default.ini
diff

xtrn/mrc/mrc-theme-garden.ini
diff

xtrn/mrc/mrc-theme-hot.ini
diff

xtrn/mrc/mrc-theme-lilac.ini
diff

xtrn/mrc/mrc-theme-midnight.ini
diff

xtrn/mrc/mrc-theme-neon.ini
diff

xtrn/mrc/mrc-theme-rustic.ini
diff

xtrn/mrc/mrc-theme-stone.ini
diff

Modified Files:


xtrn/mrc/mrc-client.js
diff

xtrn/mrc/mrc-connector.js
diff

xtrn/mrc/mrc-session.js
diff

xtrn/mrc/readme.txt
diff

MRC: Session stats, mentions, themes, indenting, buffer display, and more

Added Files:


xtrn/mrc/mrc-theme-aqua.ini
diff

xtrn/mrc/mrc-theme-default.ini
diff

xtrn/mrc/mrc-theme-garden.ini
diff

xtrn/mrc/mrc-theme-hot.ini
diff

xtrn/mrc/mrc-theme-lilac.ini
diff

xtrn/mrc/mrc-theme-midnight.ini
diff

xtrn/mrc/mrc-theme-neon.ini
diff

xtrn/mrc/mrc-theme-rustic.ini
diff

xtrn/mrc/mrc-theme-stone.ini
diff

Modified Files:


xtrn/mrc/mrc-client.js
diff

xtrn/mrc/mrc-connector.js
diff

xtrn/mrc/mrc-session.js
diff

xtrn/mrc/readme.txt
diff

Merge branch 'mrc-mods-by-codefenix-20241020' into 'master'

MRC: Session stats, mentions, themes, indenting, buffer display, and more

See merge request main/sbbs!464

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/sdl_con.c
diff

src/conio/x_events.c
diff

Fix an off-by-less-than-one issue in bitmap_double_mult_inside()

This was sometimes causing an integer scaled mode (ie: 4×) to be
reduced to very slightly less than that (ie: 3.996255×), making the
window one pixel smaller than it was supposed to be due to integer
truncation.

This could result in being unable to increase the window size using
the Alt+Right-Arrow shortcut and could make new windows one full
size smaller than they needed to be (such as C64 windows).

While we're here, fix the SDL and X11 outputs to trust what
bitmap_drv_init_mode() does.  It was fixed when GDI mode was being
written, but the other drivers weren't updated to take advantage of
that.

Should resolve issue 156 reported by DigitalMan

Removed Files:


exec/batxfer.js
diff

File was renamed to batchxfer.js

Modified Files:


ctrl/main.ini
diff

Renamed batxfer.js to batchxfer.js

The ini key value name remains the same: batxfer

Added Files:


exec/batchxfer.js
diff

Renamed batxfer to batchxfer

<nelgin> batxfer? Why not called it batchxfer ? The extra 2 characters help :)

[shrug]

Modified Files:


src/conio/ansi_cio.c
diff

ANSI mode isn't just for Windows

Modified Files:


ctrl/main.ini
diff

Make batxfer.js to the default Batch Transfer loadable module

(for new installs)

Added Files:


exec/batxfer.js
diff

A new "Batch Transfer" loadable module

Replaces hard-coded batch transfer menu, same functionality

Modified Files:


src/conio/ansi_cio.c
diff

src/conio/win32cio.c
diff

Change cursor to blinking unline using ANSI sequences.

Whee.

Modified Files:


src/conio/ansi_cio.c
diff

src/conio/win32cio.c
diff

More bugs like Microsoft

Modified Files:


src/sbbs3/listfile.cpp
diff

If file already in download queue, don't display protocol selection

Use localizable [Q]uit key

Removed trailing whitespace

Modified Files:


src/conio/ansi_cio.c
diff

src/conio/win32cio.c
diff

Save and restore the console state for ANSI and Win32Console

Now it doesn't leave the console all messed up.

Modified Files:


ctrl/text.dat
diff

Better support for long filenames in batch queue strings

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

batch_file_remove() can now remove multiple files matching pattern

Returns count of files removed now (not bool).

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Add bbs.download_cps, batch_sort(), and batch_remove()

Helpful for a JS batch file transfer menu

Modified Files:


docs/v320_new.txt
diff

More new things in v3.20

Modified Files:


src/conio/ansi_cio.c
diff

src/conio/ciolib.c
diff

src/conio/win32cio.c
diff

Set the size of the CONSOLE_SCREEN_BUFFER_INFOEX first

This allows GetConsoleScreenBufferInfoEx() to work for palette
changes, allowing Console to not suck.  However, we now prefer
ANSI mode over Win32 Console, so make that so it can actually
fail on Windows of stdout is a TTY and we can't set the
ENABLE_VIRTUAL_TERMINAL_PROCESSING flag.

With this, ANSI mode is used in Windows Terminal, and Win32 Console
is used in Legacy Console, and all should be good with the world.

Modified Files:


exec/load/shell_lib.js
diff

Display menu/tmessage.* when entering file transfer section, if it exists

This appears to be have been missed in the conversion from Baja

Reported by vela025

Modified Files:


exec/user_settings.js
diff

Update the node*/terminal.ini for every iteration of this menu

(as is/was done in useredit.cpp)

Fix the default download protocol columning display (missing final
newline in many cases).

Modified Files:


src/conio/ansi_cio.c
diff

Don't use ANSI.SYS extensions

CSI s and CSI u are ANSI.SYS extensions, and aren't needed here.
We're clearing the screen and moveing the cursor anyway.

Modified Files:


src/conio/ansi_cio.c
diff

Disable the clear to end-of-line optimization

Not only was it broken when window() is set, it's also broken when
the width is not the full screen width.

We've now disabled pretty much all the optimizations... but it works.

Modified Files:


src/conio/ansi_cio.c
diff

src/conio/win32cio.c
diff

Clean up ANSI output a bit

Specifically, make Win32 Terminal output not suck.
If stdout is a tty, set the palette appropriately, avoid using \n
since Windows can't seem to be stopped from expanding it to \r\n
nd brob the Console modes a bit harder.

Modified Files:


src/conio/win32cio.c
diff

Deal with more windows console braindeadedness.

The window and the screen buffer are two different things... the
screen buffer must always be the same size as or larger than the
window.  Further, there are times where it's not possible to resize
the windown programatically (new terminal for example).

There still appears to be a stupid bug in what I assume is the
Windows Terminal LCF flag implementation which causes writes to
the beginning of a line that occur after a write to the end of the
previous line to be in the wrong position.  If it's not the LCF flag
(which isn't turned on), it's in their wrapping thing which is extra
irritating since I explocitly turn that off.

Modified Files:


src/conio/ansi_cio.c
diff

Fix ANSI_KEY_PGDN definition.

Likely still not right though.

Modified Files:


src/conio/win32cio.c
diff

Some more Win32 Terminal fixes

Almost there, the main issue remaining is when running from a
command-line, it sometimes "unwraps" lines.

Modified Files:


src/conio/win32cio.c
diff

Keep a local copy of the screen for windows

Because it screws up the display when you resize the window.

Modified Files:


src/sbbs3/js_file_area.c
diff

src/sbbs3/js_msg_area.c
diff

Clarify in docs that grp/sub/lib/dir numbering is zero-based

Modified Files:


exec/load/shell_lib.js
diff

Add misisng parens from previous commit

Modified Files:


exec/load/shell_lib.js
diff

Use 1-based group and lib numbers for optional subs* and dirs* menu files

This was a bug in the conversion from Baja and C++ to JS.

Discovered/reported by vela025

Added Files:


src/sexpots/.gitignore
diff

Git-ignore auto-generated files: git_branch.h and git_hash.h

Modified Files:


exec/init-fidonet.ini
diff

Fix the 404 error retrying Micronet info packet (MININFO.ZIP not mininfo.zip)

I'm not sure if the file was renamed at some point or what, but apparently
it's currently named in ALL CAPS.

Modified Files:


exec/init-fidonet.js
diff

Pass the ctrl directory on the SCFG command-line

Fixes issue were jsexec was used to invoke this script and a ctrl dir
(different than the contents of the SBBSCTRL env var) was passed on the
command-line (i.e. testing purpose). Use the correct ctrl directory.

Create the data/text directory if it doesn't already exist. This dir
is normally created whenever SBBS is run, so it should normally already
exist, but if someone runs this script via jsexec before (ever) running
sbbs, then it's possible the data/text directory does not yet exist.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/telnets.c
diff

src/syncterm/telnets.h
diff

Fix telnets

This was broken when SFTP support was added and wasn't noticed.
Big thanks to Scott Labrecque of ems-bbs.com for noticing!

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/conn.c
diff

Fix telnets port.

Modified Files:


src/conio/win32cio.c
diff

Deal with consile resizing

This doesn't fix the terrible crap Windows does to the contents of
the console yet though (sigh).

Modified Files:


src/conio/win32cio.c
diff

<nelgin> Wont crash if it wont build.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbs.h
diff

Make JS bbs.msg_number and smb_curmsg writable

These 2 properties, specifically, could be made writable since
1. smb_t.curmsg is a special element owned by the application, not smblib
2. a special sbbs_t.current_msg_number property could be created/used to
   underlie the bbs.msg_number when there's no open message base (by sbbs).

This might be all that's needed to resolve issue #793

The other bbs.msg_* and bbs.smb_* properties are not so easily made writable,
so hopefully that's not desired.

Modified Files:


src/conio/win32cio.c
diff

Some fixups to not crash and stuff.

Modified Files:


src/conio/win32cio.c
diff

The MSVC builds apparently target some ancient API

So we need to define the Windows API ourselves. :(

Modified Files:


src/conio/win32cio.c
diff

src/syncterm/CHANGES
diff

Fix -iW colors in conio.

SetConsoleScreenBufferInfoEx() can no longer set colors in the
console palette.  Switch to virtual terminal parsing stuff and send
some ANSI to adjust the palette instead.

Modified Files:


src/sbbs3/chksmb.c
diff

Update chksmb usage (msg/file bases have .shd files, not .SHD)

And try to make it clear that multiple bases can be passed on the command-line.

Modified Files:


src/syncterm/CHANGES
diff

Log the changes.

Modified Files:


src/conio/win32cio.c
diff

Attempt to re-enable palette setting on Win32

This was disabled due to mingw32 limitations, and we use mingw64 now

Modified Files:


src/sbbs3/getmsg.cpp
diff

src/sbbs3/sbbs.h
diff

Don't use user's default download protocol for msg attachments

Fix issue #801

Modified Files:


src/syncterm/term.c
diff

Fix some remains of input weirdness...

Now that the conio layer is handling translation of character sets,
the key handler in term.c should only handle terminal related
translations (such as backspace to delete).

This fixes bug 159, but there's still some inconsistency across
the various backends on how they handle C0 control characters and
input characters outside of US-ASCII.

Modified Files:


src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Add contains_invalid_attr() - checks string for invalid attr Ctrl-A codes

Other Ctrl-A codes (e.g. ^A\) might be valid, but they're not attribute
control codes, so their existence would cause this function to return true.

Modified Files:


src/sbbs3/getkey.cpp
diff

Expand tildes in mnemonics strings that conain non-attr Ctrl-A codes

Fix for issue #800

Modified Files:


src/conio/scale.c
diff

src/conio/xbr.c
diff

src/syncterm/syncterm.c
diff

Rejigger width iterpolation.

The old code expected the L1 cache to be fairly large, and the
prefetcher to be fairly smart, and did updates by columns to save
some math.  This change performs width interpolation row-by-row
so even the dumbest prefetcher can get it right, and there's no
need to keep the whole source and destination images in the cache.

This may help out older processors when scaling with interpolation
(most commonly used in fullscreen).

It's entirely possible though that this won't be enough and they'll
still need to use "External" scaling.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

IP addresses are logged (most) everywhere else in square brackets

There are still places where it could be logged in <> (if username is not yet
known).

Modified Files:


src/sbbs3/ansiterm.cpp
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/useredit.cpp
diff

Rename sbbs_t::ansi_getlines() to ansi_getdims(), add sbbs_t::getdimensions()

Add JS console.ansi_getdims()

Use sbbs_t::getdimensions() or JS console.getdimensions() to move user
cols/rows values to run-time console values (querying ANSI terminal if
appropriate/supported).

JS console.pushxy(), popxy(), and gotoxy() all return Boolean now.

sbbs_t::getdimensions() and its JS wrapper is now the proper way to propagate
user's cols/rows settings to the run-time console values. This was done
(post-login) only via use of the TERMROWS and TERMCOLS @-codes in
user_settings.js. Weird.