Synchronet Git Commit Log

Modified Files:


exec/pcboard.src
diff

exec/wildcat.src
diff

Don't display/log an error message if text/menu/logon.* doesn't exist

For Wildcat (N)ewsletter command and PCBoard "NEWS" command, display
"No news is good news." instead. :-)

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

Merge branch 'dd_area_choosers_name_collapsing_arbitrary_levels' into 'master'

DD file & message area choosers: Name collapsing now supports an arbitrary
number of levels

See merge request main/sbbs!520

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

DD file & message area choosers: Name collapsing now supports an arbitrary
number of levels

Modified Files:


exec/nntpservice.js
diff

Fix issue with being able to read mail base as a newsgroup

... when using the -mail option, which probably no sysop is.

Just needed to set the 'can_read' property.

As reported via IRC by Accession

Modified Files:


src/sexpots/sexpots.c
diff

Increase buffer size from 4096 to 10000 in handle_call()

Log errors if/when comWriteBuf() fails.

This is to hopefully help to root-cause or even possibly resolve the issue
reported in #synchronet by PyRoDrAkE:
"It all works well until the Dialup connection runs slower than 4800 baud
using SexPots. I connect from my XT at either 1200 baud or 2400 baud and it
would just stop drawing midway."

There shouldn't be any write timeout in comWriteBuf(), so I don't know why
this would help, but it's worth a try. Logging any comWriteBuf() errors is
also a good idea in general.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Add typecast to elminate GCC warning

Modified Files:


src/sbbs3/sbbsecho.c
diff

Eliminate some unnecessary typecasts and parens

Modified Files:


src/sbbs3/sbbsecho.h
diff

Increment SBBSecho version to 3.24

Modified Files:


src/sbbs3/sbbsecho.c
diff

Take the configured origin line chars into account when determining charset

and if the message is UTF-8, encode the origin line as UTF-8 too.
If the message is straight ASCII (e.g. the sub-board is configured as ASCII
only), convert the configured origin line to ASCII, before appending.

At this time, only ASCII and CP437 encodings of originlines are supported
in Synchronet (imported and exported origin lines can contain UTF-8).

This should address the issue raise by Sergey Dorofeev (2:5020/12000) in the
FidoNet UTF-8 echo whereby messages exported from Synchronet systems
(presumably using SBBSecho) could contain a mixture of CP437 and UTF-8
encodings (!) when the sysop had CP437 chars in their configured origin line.

Removed Files:


install/lsm.txt
diff

Get rid of this noise (obsolete Linux Software Map data file)

I sent an update ("add" email), but it was rejected with
"No LSM entries were found" - whatever that means.

Modified Files:


exec/chksetup.js
diff

Perform a Synchronet version check and warn if it's not equal to the latest

... so yeah, most *nix sysops will get a warning about running something newer
than the latest release.

Modified Files:


install/sbbs.json
diff

Shorten the by-line to make warnings (by chksetup) more readable

Modified Files:


install/sbbs.json
diff

Missed a comma and a quote

Added Files:


install/sbbs.json
diff

Synchronet BBS release details

... for a version number comparison (e.g. by chksetup.js)

Modified Files:


install/lsm.txt
diff

Updated (why?)

This file hasn't been updated in 20 years and nobody noticed. :-)

I at least made a new submission (sent email) one last time before we
(might) just remove this file since the the LSM database doesn't appear
to be of any real use/value these days.

Modified Files:


xtrn/tw2/input.js
diff

Clear the aborted flag on input

This fixes the bug whereby if the user ever hit Ctrl-C or hit 'N' at
a pause prompt, they could never see another menu / display file.

Modified Files:


exec/load/sbbslist_html.js
diff

Change link to syncterm.lst file from ftp to http URL

Modified Files:


exec/load/presence_lib.js
diff

Fix cosmetic issue with Logging-out node vstatus display (NodeStatusLogout)

When displaying this node vstatus, the user's alias shouldn't be appended to
the node status, else you get something like this:

16  Logging out Digital ManDigital Man

Modified Files:


src/sbbs3/scfglib1.c
diff

Better config (.ini) file read error detection and reporting

It was possibly before for fgets() failures to be pretty hard to diagnose.

Modified Files:


src/sbbs3/load_cfg.c
diff

Don't try to load node.ini if no nodes are configured in main.ini

But set the error string to hopefully be printed as a warning

Modified Files:


src/sbbs3/services.c
diff

Don't clear the 'terminated' flag after binding sockets

A sysop could hit 'q' to quit (sbbs, console mode) while the binding is taking
place.

Modified Files:


src/syncterm/ssh.c
diff

Call ssh_close() on failure after ssh_session is initialized

Fixes assertion on failed connects.

Modified Files:


src/sbbs3/ssl.c
diff

Incremental backoff on loading SSL cert

Try for 16 seconds (14 loops) to load the SSL certificate.

On the first time through the loop, create self-signed certificate
if configured to do so.

This also splits the generation of the self-signed certificate into
a separate function.

While we're here, split the new SSL epoch out into a separate function
as well, and explicitly call it when we create a new self-signed
cert. This at least partially fixes the epoch thing, but there's
still the possibility of creating it multiple times in the same
second... the file date isn't really enough.

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logfile.h
diff

src/sbbs3/main.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Not all uses of fopenlog() should open the file O_DENYNONE

For quick open/write/close log files (e.g. error.log), go back to using
nopen() to insure exclusive access while writing to prevent any accidental
corruption from concurrent writes from multiple threads or processes.

Modified Files:


src/sbbs3/sbbs.jsdocs.vcxproj
diff

Updated to match the latest sbbs.vcxproj

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/ssl.c
diff

Add/use option: SCFG->System->Security->Create Self-signed Certificate

Default to false / No. Maybe this should default to true / Yes until a
certificate (e.g. from Let's Encrypt) is successfully provisioned?

Anyway, this is just a quick-hack to address the issue where a sysop's
CA-sigend certificate may be overwritten with a self-signed certificate if
for some reason Synchronet can't find/read the ssl.cert file.

See issue #881.

Modified Files:


3rdp/win32.release/cryptlib/bin/cl32.dll
diff

3rdp/win32.release/cryptlib/bin/cl32.lib
diff

3rdp/win32.release/cryptlib/include/cryptlib.h
diff

Latest patched cryptlib for Win32 - fixes issue #882

Modified Files:


src/xpdev/str_list.c
diff

Detect failure (e.g. realloc failure) in strListReadFile->strListAppend()

Added Files:


3rdp/build/cl-winapi-needed.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Patch to fix issue #882

Missing WINAPI decoration on function loaded from DLL.
When called, this would corrupt the parameters to callers,
presumably because the register allocater didn't know the call
would tromp on something.

Modified Files:


3rdp/build/GNUmakefile
diff

Removed Files:


3rdp/build/cl-enbiggen-acls.patch
diff

Revert "Add a new experimental patch for keyset crash."

This reverts commit 219e685852471a2c0aba95d5267a038538e10c02.

Modified Files:


3rdp/build/GNUmakefile
diff

Revert "Fix path to new patch"

This reverts commit 4f2886fce0041765538d3c099a706bffb6f4696e.

Modified Files:


ctrl/file.ini
diff

Mark zip and unzip testable file commands as "Native"

This should be redundant since "zip" and "unzip" should already be in the
native program list, but at some point we should be able to get rid of the
native program list or at least have it default to blank.

Modified Files:


3rdp/build/GNUmakefile
diff

Fix path to new patch

Added Files:


3rdp/build/cl-enbiggen-acls.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Add a new experimental patch for keyset crash.

Cryptlib uses the NT 3.1 API for ACLs, which means hard-codeding
certain security structure sizes.  Quadruple the sizes of these
to see if this fixes the crash DigitalMan is seeing.

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add MSGS @-code - total messages in current sub-board

Unlike SMB_MSGS, the sub-board does not have to be already open.

As requested/reported by Finglonger (SILENT)

Modified Files:


src/sbbs3/ssl.c
diff

Fix failure handing in crypt initialization.

Don't add the atexit() do_cryptEnd() handler until we're not going
to call cryptEnd() ourselves.

Modified Files:


.gitlab-ci.yml
diff

We want the install test to start right away, not way for all builds

<@Deuce> If you want the install test to start immediately, you would use
needs: []

Modified Files:


.gitlab-ci.yml
diff

Use 'needs' instead of 'dependencies' for smoketests

so they can run sooner in the pipeline

Modified Files:


.gitlab-ci.yml
diff

linux install test is standalone (doesn't require a successful build first)

Modified Files:


src/sbbs3/js_cryptkeyset.c
diff

Set p->ks to CRYPT_UNUSED after successful cryptKeysetClose()

Possibly should be done after a failure too...

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/ddfl_cfg.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_edit_extd_desc_when_none_fix' into 'master'

DDFileLister: Fix for editing a file's extended description when the file
doesn't have one initially

See merge request main/sbbs!519

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/ddfl_cfg.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Fix for editing a file's extended description when the file
doesn't have one initially

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Use WIN_ATEXIT at exit.

Also, fix some formatting.

Modified Files:


src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

Don't publish to the initial server topics (e.g. version) until after connect

Fix for issue #884

We must wait until the connect_callback() has been called to publish these
messages. Using mqtt.server_version as the indicator of an initial startup
connection versus a re-connection (due to broker-connection loss), i.e.
setting to NULL after initial connection.

Modified Files:


src/sbbs3/ssl.c
diff

Log a (notice-level) message when creating a self-signed cert

Added Files:


xtrn/mrc/mrc-help-main.msg
diff

xtrn/mrc/mrc-help-nick.msg
diff

xtrn/mrc/mrc-help-theme.msg
diff

xtrn/mrc/mrc-help-twit.msg
diff

xtrn/mrc/mrc-splash.msg
diff

Modified Files:


xtrn/mrc/mrc-client.example.ini
diff

xtrn/mrc/mrc-client.js
diff

xtrn/mrc/mrc-connector.js
diff

xtrn/mrc/mrc-session.js
diff

xtrn/mrc/readme.txt
diff

Merge branch 'massive-mrc-update-20250303' into 'master'

MRC Change List on 3/3/2025:

See merge request main/sbbs!517

Added Files:


xtrn/mrc/mrc-help-main.msg
diff

xtrn/mrc/mrc-help-nick.msg
diff

xtrn/mrc/mrc-help-theme.msg
diff

xtrn/mrc/mrc-help-twit.msg
diff

xtrn/mrc/mrc-splash.msg
diff

Modified Files:


xtrn/mrc/mrc-client.example.ini
diff

xtrn/mrc/mrc-client.js
diff

xtrn/mrc/mrc-connector.js
diff

xtrn/mrc/mrc-session.js
diff

xtrn/mrc/readme.txt
diff

MRC Change List on 3/3/2025:

Modified Files:


exec/load/portdefs.js
diff

Fix typo.

Modified Files:


exec/tests/crypt/cryptkeyset.js
diff

Looks like gitlab doesn't have write access to system.temp_dir

Just write to whatever dir, maybe that'll work.

Added Files:


exec/tests/crypt/cryptkeyset.js
diff

Add a cryptkeyset test

I expect this to crash on Windows...

Modified Files:


src/sbbs3/ssl.c
diff

assert() pthread_mutex assumptions in ssl.c

Modified Files:


src/sbbs3/ssl.c
diff

Don't set cryptlib_initialized = true until the init is complete

is_crypt_initialized() does not depend on the once value.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_non_ansi_input_update' into 'master'

DDLightbarMenu: AdditionalQuitKeys now are honored in traditional
(non-lightbar) mode, and there's a new menu property, nonANSIPromptText, which
allows customization of the prompt text when in traditional/non-ANSI mode.

See merge request main/sbbs!518

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DDLightbarMenu: AdditionalQuitKeys now are honored in traditional
(non-lightbar) mode, and there's a new menu property, nonANSIPromptText, which
allows customization of the prompt text when in traditional/non-ANSI mode.

Modified Files:


.gitlab-ci-unix.yml
diff

Don't cache spidermonkey configure results

Appears to break builds sometimes.

Modified Files:


src/conio/cterm.c
diff

src/syncterm/CHANGES
diff

Document changes, bump CTerm revision

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.h
diff

Allow NUL in Stari ST VT-52 sequences.

It seems at least some Atari ST VT-52 implementations do.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Bump rev to E (i.e. v3.20e)

Modified Files:


docs/v320_new.txt
diff

Fix typo

Modified Files:


docs/jsobjs.html
diff

Regenerated doc for v3.20d

Copied from https://nix.synchro.net/jsobjs.html since jsdocs.js is crashing
for me (on Windows) in js_cryptkeyset_constructor() -> cryptlib

Modified Files:


install/FILE_ID.DIZ
diff

Updated for v3.20d

Modified Files:


ctrl/services.ini
diff

Disable ircd by default

The ircd keeps services from auto-recycling upon request while there's an
outbound connection (e.g. to vert).

Modified Files:


src/sbbs3/services.c
diff

Fix restart of services after a stop

Bug introduced in commit 88e8688baac4a83830fdd06509af4b940a65eccf

Modified Files:


exec/load/text.js
diff

Fix TOTAL_TEXT value

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Increment version to v3.20d

Modified Files:


docs/v320_new.txt
diff

More changes in v3.20d documented

Modified Files:


ctrl/services.ini
diff

Add NO_USER_PROT in comments, enable by default for IMAP[S} services

Modified Files:


docs/install.rtf
diff

Update to v3.20d

Windows Vista (and Windows Server 2008) are now the minimum versions supported.

Modified Files:


install/install.iss
diff

Bump version to 3.20.3 (v3.20d)

Make Windows 6.0 (Vista) the minimum version for install.

Modified Files:


src/sbbs3/ctrl/sbbsctrl.res
diff

Built again with C++Builder IDE

Apparently, the IDE loads the .res file and then updates the .bpr file. So we
can't just update values in the .bpr and expect them to propagate to a rebuilt
.res file. I'm sure I've learned this lesson before and forgotten it. Perhaps
multiple times now.

Modified Files:


src/sbbs3/ctrl/sbbsctrl.res
diff

Rebuilt with C++Buidler IDE

Modified Files:


src/sbbs3/readmsgs.cpp
diff

Update data/user/*.ini section name for storing recent save path for msg sub

Modified Files:


src/sbbs3/ctrl/sbbsctrl.bpr
diff

Increment version to 3.20.3.0 (v3.20d)

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add "AT" @-code to enable easier output of literal @-codes without expansion

Deuce's suggestion

Modified Files:


exec/textedit.js
diff

Remove cleartoeos() hack

It's in JS now.

Modified Files:


src/conio/cterm.c
diff

Fix Mode7 APS handling

The code is 0x1C, not 0x1E, and it's row then column.

Modified Files:


exec/textedit.js
diff

Load saved textedit.ini at start.

Modified Files:


exec/textedit.js
diff

Add CTRL-S to "save"

This simply writes changed values to ctrl/textedit.ini, you can
copy these into the appropriate text.ini or text.dat.

I haven't dug in to see if text.dat has different encoding than ini
or anything, and I think that if you want to use this to build a
full text.dat, you would want to do it a bit at a time, so a follow-
on utility to convert text.ini to text.dat is likely the easiest way
to do this stuff.

Modified Files:


exec/load/syncterm_cache.js
diff

Differentiate between nothing and NUL

Not sure why I need to... this may be some terminal-abstraction
thing.

Modified Files:


exec/textedit.js
diff

Ah, here's the point the P_NOATCODES can be removed.

That was quick!

Modified Files:


src/sbbs3/con_out.cpp
diff

Remove broken security check for text.dat strings w/@-codes in bputs()

As Deuce pointed out, the text[] pointers are malloc()'d so they're not
necessarily sequential/in-order addresses. Definitely not after
any text replacements have been made.

Modified Files:


exec/textedit.js
diff

Always pass P_NOATCODES when calling print()

This is to work around an issue when fiddling with text data, and
will likely be able to be removed at some point.

Modified Files:


exec/textedit.js
diff

Don't subtract one from TOTAL_TEXT anymore

Modified Files:


src/sbbs3/textgen.c
diff

Fix off-by-one in load/text.js TOTAL_TEXT value

i is incremented after reading the last entry, making this value
incorrect.

Modified Files:


exec/textedit.js
diff

Actually allow editing (and some other fixes)

Home/End move the the expected place.
CTRL-Q now quits, not Q
CTRL-R "runs" a message (ie: doesn't abort) useful for @EXEC:noyesbar@
CTRL-Z undoes all changes (reloads text.dat value)
CTRL-V allows entering a hex value
^ allows entering a CTRL-code
\ allows an escape character

Modified Files:


exec/textedit.js
diff

Some more mnemonics() and do theoretical 40-col support

Modified Files:


exec/textedit.js
diff

FileInfoEditPrompt uses mnemonics() as well.

Modified Files:


exec/textedit.js
diff

Add example args for MsgAttr as well.

Nicer example than MsgSubj IMO.

Added Files:


exec/textedit.js
diff

Start of a text.dat editor

Right now it's just a text.dat browser, but it's already somewhat
useful, so I'm comitting it.

Up/Down         = Change entry
CTRL-G          = Go to entry by number
PageUp/PageDown = Change output method (putmsg, mnemonics, print)
Q               = Quit
Left/Right      = Move the cursor around in the source text

This must be ran from the terminal server, it's really not reasonable
to do a text.dat editor as stand-alone.

Modified Files:


src/sbbs3/js_console.cpp
diff

Add console.cleartoeos() method

Modified Files:


src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

Fix the palette hack a bit

This actually adjusts the palette values used by the CTerm shadow
palette.  This allows the palette to work properly without the
weird offset thing.

Unfortunately, this means a cterm_reset() will not use the new
values, and since term.c doesn't know when cterm_reset() has been
called, we can't fix it afterward anymore without being very
invasive and double-checking after every cterm_write() call.

This is fine for the indended audience however (ie: Atari ST
emulation) since they don't have a reset sequence.

Modified Files:


src/sbbs3/readmsgs.cpp
diff

Save/reuse path where messages are saved (per sub-board) to data/user/*.ini

This is a sysop time saver when saving multiple posts to a local text file
(using the Operator->Save message text command).

This is pretty much a copy/paste from readmail.cpp, but uses a different .ini
section name.

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Stop counting dupes for no reason.

While dupes were counted, nothing was done with the count, so just
delete it.

Fixes Clang warning.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Allow specifying a palette in a list entry.

A palette must be decimal integers separated by commas.
The integer represents the RRGGBB value (8-bits per channel) of
the desired colour.

Someday I'll do a proper picker here, but not for 1.x

Modified Files:


.gitlab-ci.yml
diff

Rename some of the tests to conform to the pattern

Modified Files:


src/syncterm/term.c
diff

Pass all control keys through to remote in Beeb mode

Implements feature request #104

Modified Files:


.gitlab-ci.yml
diff

Trigger CI on any *.mk file change

Modified Files:


.gitlab-ci.yml
diff

Add an install-linux CI job

Modified Files:


install/install-sbbs.mk
diff

Update comments to be more clear how to set boolean variables (e.g. =1)

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_numbered_mode_substr_1_longer' into 'master'

DDLightbarMenu: For numbered mode (no lightbar), allow 1 mor character when
using substr with the item text

See merge request main/sbbs!516

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DDLightbarMenu: For numbered mode (no lightbar), allow 1 mor character when
using substr with the item text

Modified Files:


install/install-sbbs.mk
diff

Remove references to addfiles, delfiles, and filelist

These were all deprecated with v3.19 (replaced with JS modules) and their
C source files and build instructions recently removed from the repo.

Reported by MarisaG (thank you!)

Modified Files:


src/sbbs3/xtrn.cpp
diff

Remove lprintf() call from child process of fork() call on *nix

the info-level debug message "Detaching external process"... as this appears
to be the cause of background events hanging sometimes, on Linux (at least).

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Lower severity of repeated log messages about low disk space

"!Insufficient free disk space (%s bytes) to allow upload"

Modified Files:


src/sbbs3/un_qwk.cpp
diff

Include QWKnet hub-id in "Imported" message statistics

... for Codefenix's mod that'll parse events*.log for QWKnet statistics.

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/MainFormUnit.h
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logfile.h
diff

src/sbbs3/main.cpp
diff

Create data/events*.log file for all platforms and monitoring modes

Previously, data/events*.log was only created by sbbsctrl-Win32

The file is referred to as "events*.log" because if the first terminal server
node number is > 1, then that first node number will be prepended to the
base filename. Also, rolled-over logs and renamed to *.0.log, *.1.log, etc.
up to the configured maximum before being deleted.

This change eliminates the repeated log line dedupe feature for that file
(e.g. the "[x2]" indicator). Also, the "Log Eventsto Disk" option is now
removed from the sbbsctrl->Terminal Server->Configure dialog.

Also, fopenlog() now opens log files non-locked (deny-none), so that the
files can be viewed (e.g. with 'grep' or 'tail -f') while they're open and
being written to. There isn't a concurrent write problem for events*.log
but there may be for other log file openes by fopenlog() - so that should
be investigated.

... for Codefenix's mod that'll parse events*.log for QWKnet statistics.

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/sbbs.h
diff

sbbs_t::nodefile_fp and node_ext_fp aren't used for anything in sbbs v3

Get rid of this noise.

Modified Files:


exec/syncterm-bounce.js
diff

Ensure that ANSI is available

Modified Files:


src/sbbs3/ctrl/sbbsctrl.bpr
diff

Define LINK_LIST_THREADSAFE so sbbsctrl doesn't crash in ntdll.dll

Regression introduced in commit cf992d8ad1

sbbs.h defines this macro and now that we're not #including it in
ctrl/*.cpp, we need it define in the project file.

Fixes issue reported by BrokenMind

Added Files:


xtrn/ddfilelister/ddfl_cfg.js
diff

Modified Files:


xtrn/ddfilelister/readme.txt
diff

Merge branch 'dd_file_lister_configurator' into 'master'

DDFileLister: Configurator (new): ddfl_cfg.js - To be run using jsexec

See merge request main/sbbs!515

Added Files:


xtrn/ddfilelister/ddfl_cfg.js
diff

Modified Files:


xtrn/ddfilelister/readme.txt
diff

DDFileLister: Configurator (new): ddfl_cfg.js - To be run using jsexec

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_traditional_UI_extd_desc_ansi_improvement' into
'master'

DDFileLister: Improvement for the traditional (non-lightbar) user itnerface
when displaying extended descriptions with ANSI codes

See merge request main/sbbs!514

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Improvement for the traditional (non-lightbar) user itnerface
when displaying extended descriptions with ANSI codes

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_settings_refactor' into 'master'

DDFileLister: Refactored the way the settings & colors are structured in the
code. No functional change.

See merge request main/sbbs!513

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Refactored the way the settings & colors are structured in the
code. No functional change.

Modified Files:


exec/str_cmds.js
diff

src/sbbs3/writemsg.cpp
diff

Support per-sub-board user signature (.sig files)

This feature was long overdue.

And "SIG" command to view, create or edit default signature (same function as
available from user_settings.js, in fact a copy/pasted the code).
Add "SUBSIG" command to view, create, or edit sub-board signture (no other
method is available to this other than direct file system access, e.g. by the
sysop).

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_extd_desc_filename_behavior' into 'master'

DDFileLister filename behavior for extended descriptions

See merge request main/sbbs!512

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister filename behavior for extended descriptions

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_long_filename_in_desc_color_fix' into 'master'

DDFileLister: Fix for color usage when a long filename is used in the
description for some edge cases

See merge request main/sbbs!509

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Fix for color usage when a long filename is used in the
description for some edge cases

Modified Files:


src/conio/cterm.c
diff

SGR has at least one (defaulted) parameter

Modified Files:


src/conio/cterm.c
diff

CSI < c only takes one manditory argument with default

Fixes bug introduced in cc07b354 where the command without any
parameters would not return anything.

Modified Files:


exec/syncterm-bounce.js
diff

Add a timeout to checking if pixels work

For when I break SyncTERM.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Only log one warning per invocation about inability to auto-add sub

Just the first sub that couldn't be auto-added.

Modified Files:


src/syncterm/term.c
diff

Set up CP437 mode before zmodem auto up/download

Fixes use of system font during up/downloads when auto-started.

Ticket 194

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/defaultTheme.cfg
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_filename_color_in_desc_and_refactor' into 'master'

DDFileLister: New color option (filenameInDesc) for the color of the full
filename when used in the description. Also, a refactor of the extended
description toggle mechanism

See merge request main/sbbs!507

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

DDFileLister: Refactored the implementation of toggling extended descriptions

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/defaultTheme.cfg
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: New color option for the filename when used in the description:
filenameInDesc

Modified Files:


src/conio/cterm.c
diff

Fix defaults for variable length sequences

Only SGR was impacted, but this explicitly sets the rest of the
defaults to zero.

Closes ticket 193.

Modified Files:


src/syncterm/bbslist.c
diff

Fix crash when copying entry

Resolves ticket 195

Added Files:


src/sbbs3/logfile.h
diff

Modified Files:


src/sbbs3/ctrl/ConfigWizardUnit.cpp
diff

src/sbbs3/ctrl/ConfigWizardUnit.h
diff

src/sbbs3/ctrl/LoginAttemptsFormUnit.cpp
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/NodeFormUnit.cpp
diff

src/sbbs3/ctrl/UserListFormUnit.cpp
diff

src/sbbs3/sbbs.h
diff

ctrl/*.cpp no longer needs to #include sbbs.h

Just needed to move the C-exported functions from logfile.cpp into their own
header file (logfile.h) and #include-what-we-use in ctrl/*.cpp

This should reduce the Borland C++ impact on sbbs.h and any files it includes.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Address some MSVC static analysis warnings

Modified Files:


src/sbbs3/sbbsecho.c
diff

Log warning-level message when we can't auto-add a sub

... because there's no linked-node configured as the uplink for the parent
message group.

Modified Files:


src/sbbs3/mailsrvr.c
diff

inet_ntoa() -> inet_ntop() conversion

inet_ntoa() is deprecated

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix use of inet_ntop() in rblchk()

Aren't void pointers fun!?!

Modified Files:


src/sbbs3/mailsrvr.c
diff

Don't use deprecated function gethostbyname() in rblchk()

Eliminated one more use of inet_ntoa() here while at it.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix previous commit: startup.outgoing4 is not a union xp_sockaddr *

Modified Files:


src/sbbs3/mailsrvr.c
diff

Use inet_addrtop to convert socket addresses to strings to handle endianness

Socket addresses are stored in network byte order (big endian) and this
sprintf() logic here assumed little endian.

This was a regression introduced in either commit 29b93c32 or
commit db8bb221 (in the past 2 weeks) when we stopped using (some)
of the deprecated IP address/resolution functions and fixed the socket address
storage to always be in network byte order (as is the norm).

This should fix the issue recently reported in IRC by BrokenMind.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_long_filenames_in_desc_and_extended_desc_toggle'
into 'master'

DDFileLister: Filenames too long for the menu now displayed above the
(extended) description. User can now toggle extended descriptions by pressing X
within DDFileLister. Requested by Nelgin.

See merge request main/sbbs!504

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Filenames too long for the menu now displayed above the
(extended) description. User can now toggle extended descriptions by pressing X
within DDFileLister. Requested by Nelgin.

Modified Files:


src/syncterm/CHANGES
diff

Document change

Modified Files:


src/conio/utf8_codepages.c
diff

Broken vertical is 0xA6, not 0x86

Fix that, and also fix the cpstr_to_utf8() implementation that
bypasses the lookup function.

Modified Files:


src/syncterm/bbslist.c
diff

Support YELLOW_IS_YELLOW in C128 80-column mode.

C128 used CGA monitors, and at least the 1902 output yellow.
An argument could be made that it should be the default.

Modified Files:


src/conio/utf8_codepages.c
diff

src/conio/utf8_codepages.h
diff

Split codepages into _B (broken vertical) variants

For the three codepages with fonts that do both broken and unbroken
vertical bars, add a _B variant for the one with the broken vertical.

This allows the broken vertical to be "correctly" in the codepage
mapping.

Modified Files:


src/conio/allfonts.c
diff

src/conio/ciolib.h
diff

Add flag to font data indicating a broken vertical bar

Some different fonts in the same codepage use different glyphs, so
this can't be a per-codepage setting.

Not sure how I'm going to actually implement this properly, but at
least the data is there now.

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

Merge branch 'dd_file_lister_num_files_in_header_setting' into 'master'

DDFileLister: New configuration option, displayNumFilesInHeader. Forgot to
include it in the .cfg file in my last commit.

See merge request main/sbbs!502

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

DDFileLister: New configuration option, displayNumFilesInHeader. Forgot to
include it in the .cfg file in my last commit.

Modified Files:


src/xpdev/unicode.c
diff

src/xpdev/unicode_defs.h
diff

Define/use UNICODE_VERTICAL_LINE

Resolve GCC warning: case value ‘124’ not in enumerated type
  ‘enum unicode_codepoint’

Modified Files:


exec/webfileindex.ssjs
diff

Fix links to filenames with spaces

View images in a smaller viewport (I'm no CSS expert here, obviously)

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/websrvr.c
diff

Add optional error/result outparam to highlevel filedat API functions

- loadfile
- addfile
- removefile
- updatefile

As discovered via ftp server "error updating" file log message, no details
could be logged since these functions just returned a simple bool. So, we
now support passing an optional output parameter to capture the result/error
value to be displayed or logged when these functions return false.

Unrelated fixes to start_batch_download():
When passing a list of files on the command to the file transfer protocol
driver (e.g. sz), if any filename contains spaces, that filename must be
quoted or else sz will fail with error 'sz: can read only one file from stdin'.
Also, the trailing whitespace from the list of filenames must be removed or
else sz will report errors 'sz: cannot open : No such file or directory'
and 'sz: Transfer incomplete'.

Modified Files:


src/sbbs3/sexyz.c
diff

Bug fix for multi-file zmodem-send using wildcards

If the first specified file in the list had a wildcard pattern, multiple
ZRQINIT (request init) frames would be sent (one for each file matching
the first list item file pattern).

This was just found via code review, not in the wild.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_num_files_in_header' into 'master'

DDFileLister: Now optionally displays the number of files in the header at the
top of the list, confirtable with the displayNumFilesInHeader option in the
config file

See merge request main/sbbs!501

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Now optionally displays the number of files in the header at the
top of the list, confirtable with the displayNumFilesInHeader option in the
config file

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

Don't disable status line for Atari ST modes

Atari ST modes are 25 rows, they don't need to have the status
line turned off by default.

Modified Files:


src/xpdev/unicode.c
diff

Add explicit | to | mapping.

It's not clear exactly what will happen if I don't, so add it just
in case.

Modified Files:


src/conio/utf8_codepages.c
diff

CP437 needs to be a full table translation

CP437 0x7C is U+00A6

It's likely this is true for a bunch of other codepages as well,
so I'll need to dig through them soon.

Modified Files:


src/xpdev/unicode.c
diff

CP437 0x7C is UNICODE_BROKEN_BAR (U+00A6)

Contrary to pouplar belief CP437 does not encode US-ASCII.
US-ASCII has UNICODE_VERTICAL_LINE (U+007C) there (which does match
Unicode)

Aren't you glad your C compiler didn't use CP437?
if (x ??!??! y) is so much uglier than if (x || y)

Of course, with C99 (or C90 with the 1995 ammendment), we would have
seen a lot of iso646.h and the use of the or, bitor, and or_eq macros,
and maybe that would have gotten that whole list of 11 macros promoted
to keywords eventually (Likely in C23) since it's hard to eat just one
peanut.

Of course, that's all alternate history... it's unlikely that any
compiler vendor would actually care, and | and ¦ (or | and ³ for those
using CP437) would be "the same".

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_post_msg_pause_quit' into 'master'

DDMsgReader: After replying to a message, when status is shown and pauses for
user input, Q or Ctrl-C will now exit, and not be ignored.  Requested by Keyop.

See merge request main/sbbs!500

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: After replying to a message, when status is shown and pauses for
user input, Q or Ctrl-C will now exit, and not be ignored.  Requested by Keyop.

Modified Files:


exec/load/syncterm_cache.js
diff

console.inkey() returns empty string on timeout by default

Modified Files:


src/sbbs3/logon.cpp
diff

Don't backup dsts.ini daily

Looks like an unintentional debug-inclusion with commit 2064f3a4f71c6656693a1
as pointed about by Deuce in IRC.

Modified Files:


src/sbbs3/ctrl/MailCfgDlgUnit.dfm
diff

Fix extraneous close paren added in previous commit

Modified Files:


src/sbbs3/ctrl/MailCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/MailCfgDlgUnit.dfm
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/scfg/scfgsrvr.c
diff

Add option to no mark POP3-retrieved mail as READ

When the option is not set, messages "READ" flag is set when the message is
retrieved via POP3. Setting this option defeats that behavior - as requested
by Keyop via IRC.

Since I'm out of option flags, remove the "receive by user number" option.
The receive by user number option was never a good idea and hopefully no
one is actually depending on/using that setting. Uesr numbers in the alias.cfg
file still work.

Modified Files:


src/sexpots/sexpots.c
diff

src/xpdev/ini_file.h
diff

iniRead/Get/SetIpAddress() functions now return/accept network byte order

As a result of recent change to netwrap.c

Modified Files:


src/sbbs3/execnet.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/telgate.cpp
diff

src/xpdev/netwrap.c
diff

parseIPv4Address() and IPv4AddresstoStr() now return/accept network byte order

Since that's the most used/assumed byte order for IP addresses, let's make
that the default and eliminate a lot of unnecessary byte-swapping.

This fixes the issue reported by Keyop in IRC, introduced in commit 29b93c32

Modified Files:


src/conio/vidmodes.c
diff

Base the Prestel/Mode 7 aspect ratio on actual math

It's a bit different than straight 4:3 due to Mode 7 not using the
full line period or all the lines.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Ignore MKD/XMKD commands from users (pretend successful)

For non-Guest users (without the 'U' restriction), if the FTP client
sends the MKD or XMKD command, just return the proper succcess result
and do nothing (don't log as a hack attempt or return a syntax error
result).

Some FTP clients (e.g. Reolink Doorbell camera) just always try to
blindly create a directory before uploading files, but if that command
fails (as we would), the upload is aborted. So pretend to create the
diretory whether it already exists or not, just so the client will
proceed with the upload.

For G or U restricted users, treat (log) as hack-attempt, as before.

Modified Files:


exec/str_cmds.js
diff

If sbbs is configured with "NO_DOS" option, "exec" will assume native program

<@Deuce> Filenames are always assumed to be DOS programs, despite not being
able to run them.
<nelgin> If sbbs was smart, it would know that if it's not a dos program then
to use jsexec or whatever.

There: sbbs is now more smarter

Modified Files:


src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

Fix issue resolving "localhost" to IPv4 address on (some) IPv6-enabled systems

We need to provide an address family "hint" to getaddrinfo() to limit the
results to IPv4 addresses.

Regression introduced in commit 29b93c3297c

Reported by Keyop via IRC

Modified Files:


src/syncterm/term.c
diff

Make F3 toggle reveal just like PgDown

That's what Commstar uses in Prestel mode after all.

Modified Files:


src/syncterm/CHANGES
diff

Mention that the keybindings changed.

Modified Files:


src/syncterm/term.c
diff

Fix up the Mode 7/Prestel key bindings to match Commstar

This mostly just changes the arrow key bindings and adds support
for Ctrl+Fx and Shift+Fx, and makes End Copy.

The big change though is that Page Down, not Tab now toggles reveal
mode.  Sorry all you guys with 60% keyboards.

Modified Files:


src/conio/ciolib.h
diff

Add some key macros for Shift+x and Control+x keys

For use by SyncTERM in Mode 7/Prestel modes.

Modified Files:


src/conio/x_events.c
diff

Fix some scancodes...

It seems some of the Shift+x codes were incorrect (had unshifted
as high byte and shifted as low byte).

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/ciolib.h
diff

src/conio/cterm.c
diff

Fix Mode 7 (ie: SAA5050) mode double-height handling

Basically, the only thing the SAA5050 enforces is that characters
on a bottom row need to be double-height, or they're displayed as
spaces.

The Prestel terminal now has an extra bit that indicates it is a
prestel terminal, and the bitmap console hacks up the second row.

While we're poking this, use macros for magic bits in FG/BG colours.

Modified Files:


docs/v320_new.txt
diff

Document changes since v3.20b

Needs clean-up still

Modified Files:


src/syncterm/syncterm.iss
diff

Update version number to 1.6

No other changes

Modified Files:


src/xpdev/unicode.c
diff

Convert UNICODE_VIEWDATA_SQUARE to # for CP437.

Since we do Mode7

Modified Files:


src/sbbs3/getstr.cpp
diff

Remove exascii literals.

Replace with \xXX values

Modified Files:


src/syncterm/CHANGES
diff

Document blast-through change

Modified Files:


.gitlab-ci.yml
diff

Update case of msvc output directories

This hopefully fixes the new CI pipeline issue

Modified Files:


src/conio/cterm.c
diff

Fix blast-through glyphs for high mosaics.

The smooth mosaics aren't available with the SAA5050.
Nothing to see here.

Modified Files:


src/conio/conio.vcxproj
diff

src/conio/conio_gdi.vcxproj
diff

src/conio/conio_sdl.vcxproj
diff

src/sbbs3/ans2asc.vcxproj
diff

src/sbbs3/asc2ans.vcxproj
diff

src/sbbs3/baja.vcxproj
diff

src/sbbs3/chksmb.vcxproj
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/echocfg.vcxproj
diff

src/sbbs3/fixsmb.vcxproj
diff

src/sbbs3/fmsgdump.vcxproj
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/jsexec.vcxproj
diff

src/sbbs3/load_cfg.vcxproj
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/node.vcxproj
diff

src/sbbs3/ntsvcs.vcxproj
diff

src/sbbs3/pktdump.vcxproj
diff

src/sbbs3/qwknodes.vcxproj
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbscon.vcxproj
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/sbbsexec.vcxproj
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/slog.vcxproj
diff

src/sbbs3/smbutil.vcxproj
diff

src/sbbs3/textgen.vcxproj
diff

src/sbbs3/trashman.vcxproj
diff

src/sbbs3/unbaja.vcxproj
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upgrade_to_v320.vcxproj
diff

src/sbbs3/websrvr.vcxproj
diff

src/sftp/sftp.vcxproj
diff

src/smblib/smblib.vcxproj
diff

src/uifc/uifc.vcxproj
diff

src/xpdev/xpdev.vcxproj
diff

src/xpdev/xpdev_mt.vcxproj
diff

Use MSVS macros for output directories and target filenames

This sets us up better for adding more platform support (e.g. x64) later.

Modified Files:


src/sbbs3/ars.c
diff

src/sbbs3/ars_defs.h
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/userdat.c
diff

Add LANG ARS keyword e.g. "LANG=ES" or "LANG ES" to check for Spanish language

This makes ctrl/modopts/*.ini more useful for multiple language support

Added Files:


3rdp/win64.release/libarchive/bin/archive.lib
diff

Modified Files:


src/conio/conio.vcxproj
diff

src/conio/conio_gdi.vcxproj
diff

src/conio/conio_sdl.vcxproj
diff

src/uifc/uifc.vcxproj
diff

Revert MSVC project files to commit da9512200016ce2

I accidentally committed an experimental x64 build configuration. I want to do
that right when I do add the x64 build configuration.

Modified Files:


exec/load/modopts.js
diff

Add support for ctrl/modopts/*.ini

How these files differ from modopts.ini (and by extension,
ctrl/modopts.d/*.ini):

- The root section is always parsed, part of the returned object
- [sections] denote ARS that if matched (current user meets requirements)
  then those key/values are added as properties of the returned object
  possibly overriding previously defined properties (options), this allows
  different users (or clients/hosts, terminals) to get different option
  values much more easily

Modified Files:


src/conio/cterm.c
diff

src/syncterm/CHANGES
diff

Fix APB and APU from top in BBC Micro Mode 7

Up from the top row scrolls down, does not wrap to bottom.

Backspace from the top-left position scrolls down and moves the
cursor to end end of the new top line, does not wrap to bottom.

Modified Files:


exec/load/modopts.js
diff

Convert charset to lower case before using in section name

(so, [modname:charset=mode7], not [modname:charset=MODE7])

Modified Files:


exec/load/gettext.js
diff

Convert charset to lowercase, don't depend on file_getcase() to fix

... cause it won't (fix directory case in path).

Modified Files:


src/sbbs3/str.cpp
diff

Fix case-sensitivity issue in charset element of path in last commit

fexistcase() only corrects the case of the filename, not the directories in
the path. So we'll just use the lowercase version of the charset string,
always.

Also, return false upon failure of any call to replace_text(), not just the
last one.

Modified Files:


src/sbbs3/getstr.cpp
diff

Save/restore the row number in insert_indicator()

This was the cause of some very slight funkiness when displaying files
after a save/restore (e.g. Ctrl-T or other global hot key) operation.

Modified Files:


exec/load/modopts.js
diff

Support [modname:charset=<charset>] sections

This is a getting a little kludgey

I think doing something with ARS would be nicer, but then we get into the
area of constructing a 'options' object out of keys from multiple sections
and which sections should supercede which? This'll do for now for Nelgin's
BBC mode7 terminal project.

Modified Files:


exec/load/gettext.js
diff

src/sbbs3/str.cpp
diff

Support ctrl/<charset>/text.ini file

For Nelgin's mode7 terminal project

Modified Files:


src/syncterm/webget.c
diff

Fail to parse https:// URIs when cryptlib is disabled

No point in going any further and confusing users.

Modified Files:


src/syncterm/GNUmakefile
diff

webget.o depends on cryptlib

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

And thou art v1.7b

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

I dub thee v1.6

Modified Files:


src/sbbs3/js_file.c
diff

Use iniGetSectionList() instead of iniReadSectionList()

... in File.iniGetSections() method

because iniReadSectionList() doesn't recognize !include directives.

This fixes issue #871 whereby modopts.js couldn't find sections in
modopts.d/*.ini files.

Modified Files:


src/syncterm/bbslist.c
diff

Remove summary thing.

Modified Files:


src/syncterm/bbslist.c
diff

Experimental summary thing... disabled, will be deleted

I just want this in the history in case I ever want to play with
the concept again.

Modified Files:


src/uifc/uifc32.c
diff

Only base drag-select highlight on the legacy attribute.

The fg/bg values all have multiple representations, and some bits
have extra meanings, so inequality there doesn't mean they're not
the same colour.

This fixes an issue where the *second* drag select on a screen
would not highlight blue backgrounds correctly.  The background
colour gets the "pixels set" bit flown because of how
restorescreen() works, which caused this to "know" it's not blue
and use a blue background.

A (good) argument could be made that savescreen()/restorescreen()
shouldn't result in any changes, but since uifc32 doesn't directly
use colours that aren't represented by legacy attributes, there's
no need for it to get tricky here.

Added Files:


ctrl/SlyEditStrings_En.cfg
diff

Modified Files:


ctrl/SlyEdit.cfg
diff

docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

exec/slyedcfg.js
diff

Removed Files:


docs/SlyEdit_DD_Message_Lister_notes.txt
diff

Merge branch 'slyedit_input_timeout_warning' into 'master'

SlyEdit: Display a user inactivity warning message (configurable)

See merge request main/sbbs!498

Added Files:


ctrl/SlyEditStrings_En.cfg
diff

Modified Files:


ctrl/SlyEdit.cfg
diff

docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

exec/slyedcfg.js
diff

Removed Files:


docs/SlyEdit_DD_Message_Lister_notes.txt
diff

SlyEdit: Display a user inactivity warning message (configurable)

Modified Files:


src/conio/ciolib.adoc
diff

src/syncterm/Manual.txt
diff

Mention that some screen modes change the emulation mode.

Modified Files:


src/syncterm/webget.c
diff

Fix harmless Coverity issue.

There's no need to set line = NULL since it's always overwritten.

Modified Files:


exec/mqtt_spy.js
diff

Parse/print the node_aux from the node status topic

Fix for issue #870

Modified Files:


src/conio/cterm.c
diff

A couple more Atari ST VT52 fixes...

FF and VT both move down one line, scrolling if necessary.

The rest of the unsupported control characters have no effect
(ie: work like NUL)

Delete shows the delta.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/cterm.c
diff

src/conio/vidmodes.c
diff

More Atari ST fixes...

Add ESC L and ESC M for insert/delete line.  Used by commando text.
Use a block cursor that blinks at 1Hz.
Discard invalid ESC codes.

Modified Files:


src/conio/ciolib.c
diff

src/conio/vidmodes.c
diff

Fix Atari ST palettes and default attributes

Thanks Kirkman!

Modified Files:


src/sbbs3/main.cpp
diff

Don't attempt to remove inbound QWK packet if doesn't exist (renamed?)

Address error report by Greg Meckel (THEICECA)
evnt QNET !ERROR 2 (No such file or directory) (EinError 2) in main.cpp line
3195 (event_thread) removing "C:\sbbs\data\VERT.qwk" access=0

... this could happen after a bad QWK packet was detected and renamed.

Modified Files:


exec/load/modopts.js
diff

Load section or keys form [module:lang=<user-lang>] if it exists

This allow language-specific module options

Modified Files:


src/conio/allfonts.c
diff

src/conio/ciolib.adoc
diff

src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/conio/utf8_codepages.c
diff

src/conio/utf8_codepages.h
diff

src/conio/vidmodes.c
diff

src/conio/vidmodes.h
diff

src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

Add Atari ST VT52 modes

Completes feature request #95
Have fun kids!

Modified Files:


src/sbbs3/ver.cpp
diff

Display the libmosquitto version number too (which applicable)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_input_timeout_warning_text_display' into 'master'

DDMsgReader: Input timeout warning improvement - Now displays warning text.
Also, new areYouThere configurable string in the theme file.

See merge request main/sbbs!496

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Input timeout warning improvement - Now displays warning text.
Also, new areYouThere configurable string in the theme file.

Modified Files:


src/conio/cterm.adoc
diff

Document ECMA-35 nF Escape Sequences

CTerm does not presently take any action for any of these, but it
does parse and ignore them.

Modified Files:


src/conio/conio.vcxproj
diff

src/conio/conio_gdi.vcxproj
diff

src/conio/conio_sdl.vcxproj
diff

src/sbbs3/ans2asc.vcxproj
diff

src/sbbs3/asc2ans.vcxproj
diff

src/sbbs3/baja.vcxproj
diff

src/sbbs3/chksmb.vcxproj
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/echocfg.vcxproj
diff

src/sbbs3/fixsmb.vcxproj
diff

src/sbbs3/fmsgdump.vcxproj
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/jsexec.vcxproj
diff

src/sbbs3/load_cfg.vcxproj
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/node.vcxproj
diff

src/sbbs3/ntsvcs.vcxproj
diff

src/sbbs3/pktdump.vcxproj
diff

src/sbbs3/qwknodes.vcxproj
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbscon.vcxproj
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/sbbsexec.vcxproj
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/slog.vcxproj
diff

src/sbbs3/smbutil.vcxproj
diff

src/sbbs3/textgen.vcxproj
diff

src/sbbs3/trashman.vcxproj
diff

src/sbbs3/unbaja.vcxproj
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upgrade_to_v320.vcxproj
diff

src/sbbs3/websrvr.vcxproj
diff

src/sftp/sftp.vcxproj
diff

src/smblib/smblib.vcxproj
diff

src/uifc/uifc.vcxproj
diff

src/xpdev/xpdev.vcxproj
diff

src/xpdev/xpdev_mt.vcxproj
diff

Change target processor back to IA32 (no FP instruction set extensions used)

<@Deuce> DigitalMan, also, as it turns out, Windows 7 was the last version of
Windows that supported processors without SSE2.

Since we're targeting Windows Vista and Windows 7 still, don't require FP
extensions that SBBS really won't get much benefit from anyway.

Modified Files:


src/xpdev/dirwrap.c
diff

Use strlcpy instead of sprintf("%.*s") string truncation trick

Resolves MSVC x64 build warnings.

Also fixes a bug with wrong sizeof argument used in readdir() (!)

Modified Files:


src/xpdev/filewrap.c
diff

src/xpdev/filewrap.h
diff

Standard (POSIX) getdelim() returns ssize_t, not long int

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_socket.c
diff

Native JS methods must return JS_FALSE for (Error) exceptions to be thrown

I discovered the first case when FileBase.get_path() failed, but didn't
(immediately) throw an exception. Reviewing the other instances of
JS_RepoertError() calls found several that either reported a garbage (e.g.
NULL) string value or returned JS_TRUE.

The design pattern used a little in js_socket.c probably should be used more:

	if (JS_IsExceptionPending(cx))
		return JS_FALSE;
	return JS_TRUE;

... but that's more of a refactor than I had the stomach for right now.

Modified Files:


src/syncterm/webget.c
diff

Fix memory leak in read_chunked()

Modified Files:


src/syncterm/webget.c
diff

Fix chunked transfer encoding of web lists

It's Transfer-Encoding:, not Content-Transfer-Encoding:, and each
chunk has a \r\n appended to it.

Modified Files:


src/syncterm/webget.c
diff

Terminate header parsing loop on \n as well as \r

With the latest change, *val will be \n after the last item, so
this avoids an extra loop through the loops.

Modified Files:


src/syncterm/webget.c
diff

Fix two (more) bugs with Web Lists

1 - If cache-control header had more than one option, an infinite
    loop would occur.
2 - For TLS, if the remote closes the connection after the transfer,
    a "Complete" error would occur.

Together, these should fox ticket 191

Modified Files:


src/conio/utf8_codepages.c
diff

src/conio/utf8_codepages.h
diff

src/syncterm/term.c
diff

Update prestel unicode tables for new font layout

Pasting mosaics won't work properly, but it wouldn't anyway, so I'm
not too worried about it.

Also, I can't seem to find anything I can paste separated mosaics
into, but that may just be due to Unicode 16 being so new.

Modified Files:


src/conio/cterm.c
diff

Fix handling of translated blast-through mosaics

Since we're translating in ch[0], don't use buf[j] for mosaic or
we'll lose the translation we just did.

Modified Files:


src/conio/cterm.c
diff

src/syncterm/CHANGES
diff

src/syncterm/term.c
diff

Fix mappings in Beeb and Prestel modes

In Beeb mode, receiving the byte on the left prints the one
on the right:

# -> #
_ -> —
` -> £

In Prestel:
# -> £
_ -> #
` -> —

Keyboard mappings adjusted so what you press is what you see.

Modified Files:


src/conio/cterm.c
diff

Character 127 in Beeb mode is destructive backspace.

Modified Files:


src/conio/cterm.c
diff

Split Prestel from Beeb emulation parsing, add VDU 7, 23, and 31

Prestel and Beeb emulations are different enough that using a shared
switch statement doesn't really make sense.

This adds Mode 7 support for VDU commands 7 (beep), 23 (cursor only),
and 31 (move to X/Y, 0-based).

The rest of the unsupported commands don't seem overly useful in a
BBS context (disable/enable output) or I don't want to deal with
documenting and implementing ("Page mode").

Modified Files:


src/syncterm/syncterm.iss
diff

Update for SyncTERM 1.5 and Inno Setup 6

Address warnings from Inno Setup 6, indluding support for both
"administrative" and "non administrative" install modes (!).

This means, if you have not installed SyncTERM previously, you should have an
option to install for "All users" (requiring administrative rights) or
"Just You".

When installing in non-administrative mode ("Just You"), the program will be
installed in your user "Programs" folder, e.g.
 C:\Users\<yourname>\AppData\Local\Programs\SyncTERM

If you previously installed SyncTERM in the common "Program Files" or
"Program File (x86)" directories (which assuming administrative mode, the
only install mode previously), then the installer will install again to
that same location (and require administrative access).

I'm still including a syncterm.lst download option (using curl.exe) because
the Web List feature is not working so great in v1.5. That option should
go away in the next release.

Modified Files:


src/sbbs3/text_defaults.c
diff

CriticalErrors update

Modified Files:


exec/irc.js
diff

Add some bbs.online checks to hopefully detect disconnected user better

Seen disconnected users "stuck" in irc.js for long periods of time. Hopefully
this helps.

Modified Files:


exec/webfileindex.ssjs
diff

Handle files where the 'added' property is 0 or undefined

Modified Files:


exec/jsdocs.js
diff

More consistent capitalization

Modified Files:


exec/addfiles.js
diff

Log/output an alert if the max files for a dir has been reached or exceeded

Modified Files:


exec/delfiles.js
diff

Catch and log exceptions if FileBase.get_path() fails

I saw this in my error.log:

evnt DELFILES !JavaScript  /sbbs/exec/delfiles.js line 100:
     Error: -110 loading file 'somefile.name'

Which would terminate the script. We don't need to do that, just log it
and continue on.

Other changes of no consequence.

Modified Files:


src/syncterm/CHANGES
diff

I've enabled the cursor for Mode 7... document that.

Modified Files:


src/conio/cterm.c
diff

Mode 7 terminals (ie: Commstar) do not support cursor control

Specifically, \x11 is not cursor on, and \x14 is not cursor off.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/webget.c
diff

Ignore errors removing old list file

If there's a problem, we'll catch it on the rename(), no need to
add a race condition by checking if it exists first.

Should fix issue 190

Modified Files:


src/conio/cterm.c
diff

src/syncterm/CHANGES
diff

Disable Prestel ENQ/Memory in BBC Micro Mode 7

There's very little evidence that Prestel terminals supported this,
and zero evidence that BBC Micro terminals did.

ESC and ENQ are ignored like all other control characters in Mode 7
now.

Modified Files:


exec/load/sbbsdefs.js
diff

Define K_WRAP as a legacy alias for K_WORDWRAP

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Don't use K_WRAP here, it's not even a UIFC "thing"

Modified Files:


exec/default.js
diff

exec/load/sbbsdefs.js
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/getstr.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/writemsg.cpp
diff

src/uifc/uifc.h
diff

Add K_LINEWRAP getstr() mode flag, rename K_WRAP to K_WORDWRAP

For 10 years (commit e212e2c5fe9), sbbs_t/console.getstr() has limited length
of string input to the available columns of the terminal.

To fix issue #869, rather than change getstr()'s default behavior, add a new
mode flag: K_LINEWRAP which does not limit the string length input based on
the terminal width (and the current column) (e.g. for use with ;string
commands from the default command shell).

Ideally, I'd like to have a marquee-style option (K_mode flag) where longer
strings just side-scroll to accommodate strings longer than the terminal
width, but in the mean-time, this'll do.

So anywhere we think a narrow (e.g. 40 column) terminal is being excessively
restricted in string input width and starting the input in the first column
is not an option/solution, adding the K_LINEWRAP flag to the getstr() call is
the proposed solution.

Modified Files:


exec/str_cmds.js
diff

Reload text.<lang>.ini file upon ;RELOAD command

Modified Files:


exec/load/text.js
diff

5 new (mostly QWK-related) text.dat string ID definitions

Modified Files:


ctrl/text.dat
diff

Add condition newline to CriticalErrors string

Fix issue #868 - pretty this string for 40 col terminals

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

src/syncterm/term.c
diff

Fix regression in Atari auto-login

In v1.5, it was changed to sending an ASCII CR instead of an ATASCII
one, breaking auto-login.

Modified Files:


src/conio/ciolib.adoc
diff

Add missing cell

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

And now master is 1.6a

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

SyncTERM 1.5

Modified Files:


src/conio/Common.gmake
diff

src/conio/win32cio.c
diff

We don't need to dynamically load [GS]etConsoleMode()

Modified Files:


src/sbbs3/mailsrvr.c
diff

Don't MSVC warning suppression

Modified Files:


src/sbbs3/ntsvcs.c
diff

Assume Windows XP / Server 2003 or later

No need to use LoadLibrary() and GetProcAddress() here

Modified Files:


src/xpdev/dirwrap.c
diff

Remove pre-WinXP support from getdiskspace()

No need to use LoadLibrary and GetProcessAddress here any more either

Modified Files:


src/build/Common.gmake
diff

Actually, bump Gmake builds to Windows 7.

Vista ended support before XP did, and it doesn't seem to show up
on any usage lists (while XP still has 0.27% of all Windows systems...
which are 25.46% of systems on the internet)

https://gs.statcounter.com/os-market-share

Modified Files:


src/build/Common.gmake
diff

Default GNUmake to Vista/IE7 as well

Modified Files:


src/sexpots/sexpots.vcxproj
diff

src/vdmodem/vdmodem.vcxproj
diff

Target Windows Vista (not Windows XP)

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix bug that broken mail received header RBL check

9 years ago in commit dbbfabf1b133b4116d69d4a13c38acfe1607a500

Modified Files:


src/sbbs3/qwk.cpp
diff

Address MSVC warnings: check return value of sscanf

Insure that msgcnt is initialized.

Modified Files:


src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

Don't use deprecated functions: inet_addr() and gethostbyname()

Modified Files:


src/sbbs3/js_socket.c
diff

Don't use deprecated function: inet_addr()

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Addrss some new MSVC warnings

Check sscanf() result
Don't use deprecated function: inet_addr()

Modified Files:


src/xpdev/netwrap.c
diff

malloc() result check, suppress MSVC warning

Modified Files:


src/xpdev/genwrap.c
diff

Use strlcpy instead of strncpy to insure termination, suppress MSVC warning

Modified Files:


src/sbbs3/text_defaults.c
diff

Correct text.dat string number (comment) for QWKBadControlCommand

Modified Files:


src/xpdev/genwrap.c
diff

Fix common typo in comments

Modified Files:


src/xpdev/genwrap.c
diff

When building for Windows Vista+, use GetTickCount64() through-out

At one point while migrating off the Windows XP compatible WinSDK and toolset,
I was getting nice deprecation warnings in this file about uses of
GetTickCount() and the 49 day roll-over isuse. I stopped getting those
deprecation warnings (not sure when/why), but I'm still doing the right thing
here/now and using the newer Win32 API function when it's available (always,
for the versions of Windows we're building Synchronet and friends for).

Added Files:


src/build/target_winver.props
diff

Modified Files:


src/conio/conio.vcxproj
diff

src/conio/conio_gdi.vcxproj
diff

src/conio/conio_sdl.vcxproj
diff

src/sbbs3/ans2asc.vcxproj
diff

src/sbbs3/asc2ans.vcxproj
diff

src/sbbs3/baja.vcxproj
diff

src/sbbs3/chksmb.vcxproj
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/echocfg.vcxproj
diff

src/sbbs3/fixsmb.vcxproj
diff

src/sbbs3/fmsgdump.vcxproj
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/jsexec.vcxproj
diff

src/sbbs3/load_cfg.vcxproj
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/node.vcxproj
diff

src/sbbs3/ntsvcs.vcxproj
diff

src/sbbs3/pktdump.vcxproj
diff

src/sbbs3/qwknodes.vcxproj
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbscon.vcxproj
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/slog.vcxproj
diff

src/sbbs3/smbutil.vcxproj
diff

src/sbbs3/textgen.vcxproj
diff

src/sbbs3/trashman.vcxproj
diff

src/sbbs3/unbaja.vcxproj
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upgrade_to_v320.vcxproj
diff

src/sbbs3/websrvr.vcxproj
diff

src/sftp/sftp.vcxproj
diff

src/smblib/smblib.vcxproj
diff

src/uifc/uifc.vcxproj
diff

src/xpdev/xpdev.vcxproj
diff

src/xpdev/xpdev_mt.vcxproj
diff

Target Windows Vista+ (not Windows XP) and enable enhanced instruction sets

Synchronet v3.20 doesn't actually work on Windows XP due to depenendies in
3rd party libraries we link with and more recent ciolib improvements.

So, no need to use an ancient WinSDK (7.0) or toolset anymore. Hooray!
I'm not changing the versions of C or C++ language enabled (yet), but that's
something we should consider doing.

Also, re-enable enhanced x86 processor extensions (e.g. SSE2) as I doubt very
much you can run Windows Vista on a pre-2000 CPU anyway. If this is a problem
for anyone, it's trivial to disable the processor extensions again.

Modified Files:


src/sbbs3/objects.mk
diff

src/sbbs3/sbbs3.sln
diff

src/sbbs3/targets.mk
diff

Removed Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/filelist.c
diff

src/sbbs3/filelist.vcxproj
diff

Remove deprecated projects (with JS equivalents)

No need to continue to carry this baggage

dupefind is another candidate for removal (soon)

Modified Files:


src/sbbs3/sbbsecho.c
diff

Add debug-level log messages when import_netmail() returns a non-zero value

To help debug any situations where import_netmail() might silently fail
(though I don't anticipate there are any, Accession suggested there was).

Modified Files:


src/sbbs3/js_bbs.cpp
diff

bbs.load_text() can now be used to load text*.ini file

For sysops that don't want to use the user's chosen language to auto-load
alternate text strings, they can specify some other filename from the ctrl
directory (so long as it ends in .ini). I wouldn't use text.*.ini however,
since those filenames are assumed to be language translations and will
automatically appear in user_settings.js as a user-selectable language.
text-*.ini would be fine though as an alternate text.ini filename:
not colliding with text.ini or text.*.ini

Modified Files:


src/sbbs3/prntfile.cpp
diff

Fix random menu/display file selection when some files can't be displayed

When one or more files that match the menu file pattern can't be displayed
(e.g. the user's terminal is not wide enough or there's any other menu file
open/read error), pick another random menu file and try displaying that one,
until either a menu file has been displayed successfully or all files
(matching the pattern) have been attempted.

For example, you have text/menu/random1.c80.msg and random2.msg, if the first
file (random1.c80.msg) is selected at random but the user's terminal isn't
at least 80 columns wide, another file will be picked at random. Since only
random2.msg remains in the list (matching the pattern "random*"), that's the
only file that will always be displayed.

Added Files:


text/menu/random_sync_5m.c80.msg
diff

text/menu/random_sync_5m_fire.c80.msg
diff

New random Sync/Synchronet splash screens, by Smooth of Phenom Productions

Thank you 5mooth!

Added Files:


text/menu/random_sync_abs_blue.c80.msg
diff

text/menu/random_sync_abs_dark.c80.msg
diff

text/menu/random_sync_abs_light.c80.msg
diff

text/menu/random_sync_starwars1.c80.msg
diff

text/menu/random_sync_starwars2.c80.msg
diff

text/menu/random_synch_gj_splash.c80.msg
diff

Rename random logon block-art splash screens to *.c80.msg

Fix issue #867

Renamed to .msg to make for easier preview/edit with PabloDraw

Modified Files:


src/sbbs3/userdat.c
diff

Fix ERROR 2 (...) in putnode.cpp ... opening "node.exb"

Need the O_CREAT mode flag.

Broken with commit d116f3622: I started using opennodeext() (created 5 years
ago with commit 710bb23c1bd) rather than nopen(), and I didn't realize that
opennodeext() was not including O_CREAT.

Once the ctrl/node.exb was created (by anything), this error wouldn't happen.
And it'd only be an issues for systems with text.dat's that included custom
node status (NodeAction*) strings. Good catch Nelgin!

Modified Files:


src/sbbs3/putmsg.cpp
diff

Correctly center lines of text that contain @-codes, after @center@

@-codes weren't expanded before the text length calculation, so the centering
logic (offset in the user's terminal screen) would usually be incorrect as
pointed out by Nelgin in #synchronet when we were discussing the |C @-code
modifier (which is to center an @-code value in a field, not the screen).

This issue was a known limitation of the fix to issue #418 (commit 8987150bd)
but now that we have the expand_atcodes() function (hooray!), this is an
easily solvable problem.

Note: we're now calling center() withOUT the 'msg' parameter set to true,
which means the @center@ code goes back to the previous (to issue #418 fix)
behavior of just using bputs() for the centered text (we don't need the
recursive call to pustmsg() to support @-codes any longer). This was the only
reason that center() grew the optional 'msg' parameter so we likely can remove
that option/feature at some date.

Modified Files:


src/sbbs3/mailsrvr.c
diff

text/menu/restrict.asc
diff

Add new I-restriction, to disallow receipt of Internet mail to specific users

(mail received from authenticated SMTP clients is still allowed)

Previously, the M-restriction also prevent receipt of Internet mail from
authenticated SMTP clients, so separate that restriction into the new 'I'
restriction.

This fixes issue #865

Modified Files:


.gitlab-ci.yml
diff

Remove the PATH debug

Also add cryptlib to PATH for jsexec smoke test, just in case

Modified Files:


.gitlab-ci.yml
diff

CI_PROJECT_DIR looks like the more correct variable to use here

Modified Files:


.gitlab-ci.yml
diff

Add an echo PATH debug statement again <sigh>

Modified Files:


.gitlab-ci.yml
diff

We need the original PATH directories too

Modified Files:


.gitlab-ci.yml
diff

Do the more powershell thing

Modified Files:


.gitlab-ci.yml
diff

This PowerShell, not cmd.exe, as Deuce pointed out

Oops.

Modified Files:


.gitlab-ci.yml
diff

Try using quotes

not clear why this would be required, but exampels seem to use 'em

Modified Files:


src/sbbs3/logon.cpp
diff

Actually use the (first) shell we found that the user meets the requirements

As discovered and reported by Deuce and Nelgin

Modified Files:


.gitlab-ci.yml
diff

Echo the path for debugging

Modified Files:


.gitlab-ci.yml
diff

Try setting the PATH to point to the win32.release/cryptlib/bin dir

... so we always use the correct cl32.dll when running the jsexec test suite
on Windows.

Modified Files:


src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptkeyset.c
diff

Throw a JS exception if do_cryptInit() fails

Catch cryptlib version mismatch gracefully

Modified Files:


src/sbbs3/js_socket.c
diff

Remove accidental whitespace

No functional change.

Modified Files:


src/sbbs3/js_socket.c
diff

Correct JSDOCS for TLS PSK properties

The wrong version nubmer was specified for these new properties - these
properties were added in v3.20c which is represented numerically as 32002 in
decimal.

The description of the tls_psk_id property was missing socket_prop_desc.

Modified Files:


3rdp/win32.release/cryptlib/bin/cl32.dll
diff

3rdp/win32.release/cryptlib/bin/cl32.lib
diff

3rdp/win32.release/cryptlib/include/cryptlib.h
diff

The latest cryptlib patched and built for win32-x86 release

Modified Files:


exec/broker.js
diff

Support uid/pw only auth

There are now two ways to authenticate with the broker:
1) TLS PSK with a sysop account, and set the password field at the
   MQTT level to the system password (user field, if present is
   ignored).  This is the prefered method as it provides mutual
   authentication and you simply can't steal credentials with MITM.
2) Synchronet TLS certificate, sysop username and the users password
   followed by a colon, followed by the system password.  The server
   authentication will now depend on the appropriate trust chain in
   the client.  If using a Let's Encrypt certificate for example,
   you can' securely connect to localhost with this method.

tools and libraries tend to allow TLS-PSK with password at the MQTT
level, many GUI tools do not allow TLS-PSK.

Modified Files:


src/sbbs3/js_socket.c
diff

Use the new TLS PSK flag to control if sock.tls_psk_id is set

Now both the "regular" certificate, and PSK will be supported on
a TLS socket, and it's up to the client to check which was used.

Added Files:


3rdp/build/cl-add-psk-flag.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Add patch to flag PSK TLS sessions

Modified Files:


ctrl/text.dat
diff

Fix number of QWKBadControlCommand

trimmed some trailing whitespace

Modified Files:


src/sbbs3/sbbs.version
diff

Make sad linkers happy.

Modified Files:


src/sbbs3/sbbs.version
diff

Hide more Cryptlib symbols

Modified Files:


src/syncterm/webget.c
diff

It appears the Windows won't allow rename()ing a file over top
of an existing one.

Modified Files:


src/sbbs3/js_socket.c
diff

Add Socket.tls_psk_id property

If tls_psk is used, indicates which entry in tls_psk was used by
the remote.

Modified Files:


src/sbbs3/js_mqtt.c
diff

Lower-case password in JS as well

Modified Files:


src/syncterm/webget.c
diff

Fix webget of chunked responses

Broken with the paranoid_strtoul() addition

Modified Files:


exec/user_settings.js
diff

Default "Foward email to netmail" answer to the current setting

As much as possible, ENTER should mean "no change".

Modified Files:


src/sbbs3/useredit.cpp
diff

text/menu/uedit.asc
diff

Add user NetMail address edit option ('N' command) to UEDIT

A sysop can do the same by going through the 'I' (user config/settings
command), but that's a bit more convoluted.

Modified Files:


exec/load/newsutil.js
diff

Use the from_net_addr even if the from_net_type is 0/NONE

Since it's technically a "local post", but the user/sysop wants their client-
provided email address to appear in the header, use it, if provided (don't use
a made-up BBS email address that may not be valid).

For Accession

Modified Files:


src/sbbs3/js_mqtt.c
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

Add new "Synchronet Broker" MQTT TLS type

With this, you don't need a username, password, PSK, or PSK ID,
certs, CAs, etc, and things just work by magic (when using the
Synchronet broker)

Modified Files:


exec/broker.js
diff

Call client_add()/client_remove() as appropriate

For when running as a service.

Modified Files:


exec/broker.js
diff

src/sbbs3/js_socket.c
diff

Don't allow public key auth if tls_psk is set

Modified Files:


exec/broker.js
diff

Add some documentation about how the script works.

As always when writing documentation, fix things that aren't quite
right... we now schedule nextPacket, but run each packet to
completion as long as we have all the bytes.

Modified Files:


src/syncterm/webget.c
diff

Remove extra set of errno.

We don't need this anymore because the paranoid wrapper does it.

Modified Files:


src/syncterm/webget.c
diff

Add an use new strtou?ll?() wrappers in webget.c

This is kind of a prototype for xpdev... but it's a bit klunky.

The issue these fix is that some C libraries (Windows and GLibC)
will return 0 and leave errno unset when no digits are converted,
while other libraries (FreeBSD and musl) will set errno if no
digits are converted.  This means that even setting errno to zero
before calling, then checking it if the return value is zero is
not enough to catch errors.

This actually led to Windows and (most) Linux systems not being able
to download the web lists because of a bug where it was converting
starting in the middle of the string rather than where the numbers
are.  It worked fine on Alpine Linux and FreeBSD though.

Modified Files:


src/syncterm/webget.c
diff

Fix header parsing...

content-length: and content-transfer-encoding: were badly broken.

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Fix bug with fixed event toggles

I'm totally perplexed that none of the compilers we have warned about this
obvious incorrect usage of the toggle_flag() function. Not warning about
passing false (0/NULL) for a char* makes some sense, but not the passing of
a const char* in place of a bool (int)? Maybe we should be building with
-Wall?

Modified Files:


src/syncterm/webget.c
diff

fclose() newfile before renaming.

Thanks Microsoft!

Modified Files:


src/sbbs3/js_socket.c
diff

Fix last commit.

If we called accept(), it's not datagram, and if you're using SCTP
and Synchronet lies to you, you can fix it yourself.

Modified Files:


src/sbbs3/js_socket.c
diff

Set Socket.type correctly on accept() from multisock

Modified Files:


exec/broker.js
diff

Make broker.js capable of running as a static service.

Modified Files:


exec/broker.js
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_socket.h
diff

Add support for TLS PSK auth

For use by broker.js which now requires a Sysop User ID and password
as the TLS PSK, and requires the system password in the MQTT password
field.

Modified Files:


exec/mqtt_spy.js
diff

Catch and print exceptions

Because of the way this script is invoked from str_cmds.js (using js.exec)
any exceptions were just silent failures, making debugging issues
(e.g. the recent regression with the global ascii() function) difficult.

Modified Files:


exec/irc.js
diff

Increase connect timeout from 15 to 30 seconds

vert.synchro.net is taking > 15 seconds after initial IRC version notice

Modified Files:


ctrl/text.dat
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

Replace some hard-coded strings with Ctrl-A codes with text.dat strings

As Nelgin pointed out, there are a few hard-coded strings in the C++ source
with attribute (Ctrl-A) codes still.

This commit takes care of 5 of them:
- TelnetGatewayPrompt
- QWKEndOfMessage
- QWKTagLineFmt
- QWKControlCommand
- QWKBadControlCommand

Modified Files:


src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add an optional weekly fixed system event

Yes, you can do the same thing with timed events, pretty much

Modified Files:


src/sbbs3/getnode.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbsdefs.h
diff

Rename SS_NEWDAY to SS_DATE_CHANGED

Embarassingly, I'd added SS_NEW_DAY recently (for a different purpose) with
such a similiar name. So let's rename this flag since it serves a very
different purpose and avoid the confusion between the two flags.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/useredit.cpp
diff

Eliminate SS_INUEDIT

This hasn't done anything SBBSv3 - no way to enter internal user editor
recursively.

Modified Files:


src/sbbs3/execfunc.cpp
diff

src/sbbs3/sbbsdefs.h
diff

Eliminate SS_ANSCAP - never did anything in SBBS v3, that I recall

Modified Files:


src/sbbs3/websrvr.c
diff

More use of errprintf() to reduce duplicate error log messages

Modified Files:


exec/tests/global/except.js
diff

src/sbbs3/js_global.c
diff

mqtt_spy.js depends on the previous behavior of ascii()

When passed null or undefined, it needs to return null or undefined.

Document that behavior.

Modified Files:


src/sbbs3/js_cryptcert.c
diff

Fix JSDOCS

It's CryptCert.FORMAT.XXX

Modified Files:


exec/broker.js
diff

Fix inverted comparisons in SUB and UNSUB messages

Modified Files:


exec/broker.js
diff

Do some of that refactor

Add a nextPacket() method that will get the next packet
Add a Connection.parseBytes() method to consume the rx_buf
Simplify Packet.newBytes() to only do socket recv()
Clear RX buffer when closing socket

Modified Files:


exec/broker.js
diff

... But only if it's not null already.

Modified Files:


exec/broker.js
diff

Set sock to null *after* closing it.

Modified Files:


exec/broker.js
diff

More fixes... it seems broadly usefulish now

- Increment bytes required for every extra VBI byte we learn about
- If sock is null, don't look at sock.connection
- Set sock to null after close
- Don't read from sock unless we need some bytes
- If we already have some bytes, parse them

There's a couple hacks in here that should be refactored though.

Modified Files:


exec/broker.js
diff

Log who packets are going to/from, fix potential leak in previous commit

Modified Files:


exec/broker.js
diff

After receiving all packet data, receive the next packet.

This appears to be why it was hanging. :D

Added Files:


exec/broker.js
diff

Add a pure-JS MQTT broker

This is not nearly ready for full-time yet, but it seems to mostly
limp along fine... there's some issues with the callbacks and such,
and the TLS support isn't currently usable by Synchronet.

Worth committing though.

Modified Files:


src/sbbs3/js_user.c
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/userdat.c
diff

Better duplicate "key value" detection/rejection for configuration settings

Internal codes are always treated as keys (in a database sense) and should be
unique, but they weren't always enforced to be unique in SCFG. There's still
a few config items with internal codes that aren't forced unique (e.g. chat
channels).

File Library short names and Mesage Group short names are also key values and
must be unique and that's now enforced as well.

Remove the default name for new File Libraries and Message Groups (which are
likely duplicate anyway).

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

Add K_CHANGED mode flag for uifc.input()

Used in combination with K_EDIT, if the string isn't actually changed, return
-1 (same as abort/ESC).

This allows the elimination of some save/compare/copy code in SCFG where we
only care to even look at the string if it was changed from its existing
value.

Modified Files:


src/syncterm/menu.c
diff

Fix attempt to free static const string in online menu

Broken when I removed the ALT-X shortcuts for ANSI/Curses modes.

Should fix issue #188

Modified Files:


src/syncterm/webget.c
diff

More suppressions

Modified Files:


src/syncterm/webget.c
diff

Attempt to silence Coverity a bit harder

Modified Files:


src/syncterm/webget.c
diff

Whoops, add the string

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/webget.c
diff

A bit more Coverity follow-on

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

src/syncterm/webget.c
diff

src/xpdev/named_str_list.c
diff

Fix all the new issues Coverity complains about

A couple were valid issues, but the majority were impossible.

Modified Files:


src/syncterm/CHANGES
diff

Mention the removal of login delays.

20ms, so you wouldn't notice, but it may be the cause of problem
reports in the future, so best to have it logged somewhere.