Synchronet Git Commit Log

Modified Files:


src/sbbs3/listfile.cpp
diff

Change CRLF before batch flag prompt to a conditional new-line.

If a sysop wants a *blank* line before the batch flag prompt, they can put that
(or a conditional blank line, even better) in their text.dat (BatchFlagPrompt).
For now, I'm thinking no blank line before the prompt is better use of the
screen.

Modified Files:


src/syncterm/ripper.c
diff

More improvements...

Consistently use map_rip_color()
Optimize flood fill to not clobber the stack
Fix small full ellipses to match RIPTerm 1.54

Modified Files:


src/syncterm/ripper.c
diff

Fix palette calculations, and add support for RIPv2 'b' command.

Modified Files:


src/sbbs3/filedat.c
diff

Don't sort the keys in the content sections of a file.

Modified Files:


src/sbbs3/text_defaults.c
diff

A couple additional [P]revious commands when list/viewing files

Modified Files:


ctrl/text.dat
diff

A couple additional [P]revious commands when list/viewing files

Modified Files:


src/sbbs3/sbbs_ini.c
diff

sbbs_write_ini() called with a NULL global pointer could have crashed

as get_ini_globals() will de-ref the 'interfaces' element. CID 331352

Modified Files:


src/xpdev/ini_file.c
diff

Fix  a couple of resource leaks in iniSortSections()

One in an error path (CID 331353), the other not.

Modified Files:


src/conio/x_events.c
diff

Optimize pixel calculations.

Modified Files:


src/syncterm/ripper.c
diff

Make some changes

Mostly tightening things up and fixed some text things.

Modified Files:


src/xpdev/ini_file.c
diff

Remove unused variable added in previous commit.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

Sort stored file (archive) contents, for later comparison purposes

Some archives contain exactly the same files as others, but in a different
order. Believe it or not.

Modified Files:


src/xpdev/str_list.c
diff

NULL pointer checks in strListSort*() and strListDup()

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Add iniSortSections() which can sort a read ini list and optionally keys

This also exposed problems with the find_section() utility function: when the
"found" section was actually empty and the next immediate line in the ini file
was the beginning of a new section, the "keys" indexed would actually be the
next section. Now fixed.

Modified Files:


src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/syncterm/ripper.c
diff

Vectorize beziers

Modified Files:


src/sbbs3/listfile.cpp
diff

Previous file support from the [R]emove and [D]ownload commands.

More support for moving backwards through file searches/listing types.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

Fix issues with file header fields getting repeated (cloned)

e.g. when using the JS FileBase.update() method

Modified Files:


src/smblib/smblib.c
diff

When adding a msg/file header, remove the DELETE attribute

When moving or renewing files, they're first removed and then added and they
were being added with the DELETE attribute set. The filenames are displayed in
red when staged for deletion/removal, so that's how I noticed. Oops.

Modified Files:


text/menu/wwiv/main.asc
diff

text/menu/wwiv/transfer.asc
diff

Insert conditional-newlines (Ctrl-A/) to force line-wraps on >80 col terminals

Apparently these menu files were created exactly 80 columns wide. <shrug>

This fixes issue 257 reported by Keyop.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/syncterm/ripper.c
diff

Optimize color_value() and fix RIP reset

color_value() is in the hot drawing path, so should be as fast
as possible... remove all the bit shifting and have the palette
just be colour values.

For RIP, the reset wasn't resetting the global coordinates, so a
scaled image would cause everything to be scaled down later.

Modified Files:


src/syncterm/ripper.c
diff

Add save/resotore mouse fields commands.

Used extensively on Black Flag BBS.

Modified Files:


src/sbbs3/js_filebase.c
diff

Add a 'readd_always' option to the update() method

This will cause archive file contents to be re-captured/added

Modified Files:


src/sbbs3/js_filebase.c
diff

JSDOC updates

Finally document the file-meta-object properties now that things are
solidifying.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

Store contents (list) of archive files in filebase (in the "msg tail")

This will allow fast/easy display of archive contents without actually reading
the archive files.

Introduces some new functions:
- list_archive_contents()
- smb_adddfile_withlist()

A new SMB convenience variable ("tail", aliased as "content" for a file).
A new file detail level ("file_detail_content", exposed in JS as
FileBase.DETAIL.CONTENTS) which adds a "content" array property to file
metadata objects for JS FileBase.get().

Files already added to the new filebases won't have this archive content
automatically - I'm looking into that now (likely a new or updated JS script to
run).

Modified Files:


src/syncterm/ripper.c
diff

Some optimizations and clearing realloc()ed data.

Modified Files:


src/syncterm/ripper.c
diff

Fix merge issue.

Modified Files:


src/conio/bitmap_con.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/ripper.c
diff

src/syncterm/rlogin.c
diff

src/syncterm/term.c
diff

More RIPv3 stuff, make it an option.

The option basically controls forced EGA mode and reported terminal.

Modified Files:


src/syncterm/ripper.c
diff

Implement disabled text for RIP.

We still need to pass ANSI through to the parser though because
Synchronet goes apeshit if it doesn't get a response to a location
request... it tries twice and eats any data it receives that isn't
a valid position report, which obviously breaks menus.

It's also very weird that on Booch's BBS at least it's sent during
the main menu display rather than just on answering.  Not sure why
this is, but it means we can't implement the RIP requirement of
"ignoring all non-RIPscrip bytes" with a zero window without digging
deep into Synchronet guts.

Modified Files:


src/conio/bitmap_con.c
diff

src/syncterm/ripper.c
diff

src/xpdev/xpbeep.c
diff

More improvements for Black Flag...

Pretend we are RipTel v3.
Implement $PCB$
Implement click actions
Fix M areas.

Modified Files:


src/syncterm/ripper.c
diff

Remove debug, optimize

Generate conversion tables rather than do float math twice for each
virtual pixel.

Modified Files:


src/syncterm/ripper.c
diff

Start of minimal RIPv2 support.

Just the easy stuff (scaling, extended colours, border toggle, filled
rectangle)

Modified Files:


exec/load/dns.js
diff

Fix DNS response flag parsing.

Modified Files:


src/sbbs3/listfile.cpp
diff

Search of word in descriptions should match filenames too.

Especially now that now all files even have descriptions (e.g. when super long
filenames suffice).

Modified Files:


src/sbbs3/sbbsecho.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/str_util.c
diff

Add a separate "area tag" string configured per sub-board

According to  Lupine Furmen (FURFOL):
It says in the help that the field is used for both the Newsgroup name AND the
Fido Echo-tag.

These really should be 2 different fields.

Now, the echo/area tag is usually configured in the area file (areas.bbs) and
so does not need to match *any* string configured in SCFG. But since an area
file *can* be generated from SCFG (Export Areas option) and its possible to use
SBBSecho withOUT an area file at all, then it's possible someone would like to
have their FidoNet-style area tags configured different from any other strings
related to a sub-board (e.g. newsgroup name) - why? I'm not clear, but there it
is: another string that  a sysop can set (or not).

Since I'd recently added an area tag field per directory for use by hatchit.js,
this does create some logical symmetry. And there were enough free bytes
per-sub in the msgs.cnf, so why not.

Modified Files:


src/sbbs3/file.cpp
diff

Fix error when moving files

e.g. file.cpp line 239 (removefile) removing "filename.zip" access=-203
info=smb_freemsgdat reading allocation record at offset 1108

Also, if there is an error removing the original file from the filebase, don't
proceed to move the actual file (and log a successful move).

Modified Files:


src/sbbs3/listfile.cpp
diff

When toggling extended file descriptions with the 'T' command, save user

Save the user's "misc" flags to the userbase when they use the 'T' command from
the batch flagging prompt. Without this change, the option would automatically
revert if/when the user record was re-read (which can happen at any time).

Modified Files:


webv4/pages/002-files.xjs
diff

Fix the "undefined" display when a file has no description.

Modified Files:


webv4/root/api/files.ssjs
diff

Fix downloaded filenames in v3.19

Files were being downloaded as undefined.undefined because I didn't emulate
the old 'base' and 'ext' properties - just use a single 'name' property now.

Modified Files:


webv4/pages/002-files.xjs
diff

Use html_encode() for extended descriptions with Ctrl-A codes too.

Synchronet v3.19 now converts ANSI-encoded DIZs to Ctrl-A format upon import.

Modified Files:


src/sbbs3/js_global.c
diff

Add support for conditional new-line Ctrl-A code (/) in html_encode()

Modified Files:


webv4/lib/files.js
diff

Fix count_files() for v3.19 compatibility.

Modified Files:


ctrl/attr.cfg
diff

Change default file description color from darkgreen to lightgray.

Modified Files:


src/sbbs3/addfiles.c
diff

Close stream on error.

Fixes CID 33498

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix double close (fnopen doesn't leave the descriptor open)

Fixes CID 33724.

Modified Files:


src/sbbs3/chksmb.c
diff

Always report the total LZH compressed messages

This looks like a 20-year-old copy/paste bug. CID 33168.

Modified Files:


src/sbbs3/qwknodes.c
diff

Pass msg struct by pointer, not value

CID 33320 and 333321

Modified Files:


src/sbbs3/userdat.c
diff

Get rid of an unnecessary strcat() call

CID 33567

Modified Files:


src/sbbs3/file.cpp
diff

Consolidate the uploader security info (host/ip/prot) on one line

Modified Files:


src/sbbs3/listfile.cpp
diff

Don't display batch flag with same color as description.

Display the batch flag letter with the same color as the filename, but inverted
intensity. The batch flag shouldn't stand-out (be bright) anyway, but the main
reason is because I'm changing the default file description attribute to be
lightgray instead of dark green.

Modified Files:


text/menu/batflag.msg
diff

Add [T]oggle short/extended file description command

And use "Operator" rather than "Sysop" for operator commands.

Modified Files:


src/sbbs3/listfile.cpp
diff

The 'T' command key at the batch flag now toggle extended file descriptions

This is pretty convenient and handy (rather than having to use &E or the
equivalent command from the file xfer menu and then re-list files).

Modified Files:


src/sbbs3/GNUmakefile
diff

use $^ instead of $? for the prereqs for the ans2asc link command

Fixes the link failure when sauce.o didn't need to be rebuilt.

Modified Files:


exec/load/sbbsdefs.js
diff

Resynchronize with sbbsdefs.h, adding and removing consts

Modified Files:


exec/load/userdefs.js
diff

Resynchronize with sbbsdefs.h

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Remove some unused/obsolete macros.

Modified Files:


src/sbbs3/sauce.c
diff

Maybe address Coverity issue.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/sbbs.h
diff

Use reference rather than pointer to make putmsgfrag() more readable.

Modified Files:


src/sbbs3/filedat.c
diff

Address Coverity defects.

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/listfile.cpp
diff

Show removed files in error color (red).

Modified Files:


exec/load/text.js
diff

Add FiAuthor and FiGroup

Modified Files:


exec/dupefind.js
diff

Support find/remove of duplicates based on archive contents

Duplicate archives (e.g. ZIP files) often have the different digest/hash/CRC
values because they have a different ZIP comment or the files were archived
in a different order or used different compression schemes. You can now detect
(and delete) these duplicates.

Modified Files:


exec/archive.js
diff

Add -json (JSON formatted output) and -sort option.

Modified Files:


src/sbbs3/ans2asc.c
diff

Fix new GCC 9.3 warnings.

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix ANS2ASC fmod link error with GCC 9.3 (Latest Ubuntu Linux)

Modified Files:


ctrl/text.dat
diff

Add FiAuthor FiGroup

Modified Files:


src/sbbs3/objects.mk
diff

Fix jsdoor build for *nix.

Modified Files:


src/sbbs3/listfile.cpp
diff

Resolve gcc warning

Modified Files:


src/sbbs3/GNUmakefile
diff

src/sbbs3/filedat.h
diff

src/sbbs3/objects.mk
diff

Fix the build to link with the new sauce.o file

Modified Files:


src/sbbs3/listfile.cpp
diff

Reverse the order of the Delete File and Remove Credits prompts

To match the Remove file command sequence (for consistency).

Modified Files:


src/smblib/smbdump.c
diff

Don't repeat the "cost" field in smb_msghdr_str_list()

Modified Files:


src/smblib/smbdefs.h
diff

src/smblib/smblib.c
diff

src/smblib/smbstr.c
diff

Restore AUTHOR and AUTHOR_ORG SMB header fields removed Apri-19-2019

Going to use these to store SAUCE "AUTHOR" and "GROUP" fields for files.

Modified Files:


src/sbbs3/con_out.cpp
diff

A line feed does not move the cursor to column 0.

This caused an issue for the soon to be committed P_INDENT support in putmsg().

Added Files:


src/sbbs3/sauce.c
diff

src/sbbs3/sauce.h
diff

A SAUCE library that can read a SAUCE record or character file metadata.

Modified Files:


src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Created convert_ansi() which is kind of a minimal version of ANS2ASC

It Ctrl-A encodes a possibly ANSI-encoded string, supporting on color/attribute
sequences and stripping all others.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix observed crashes at end of pop3_thread() and smtp_thread()

"startup" was being deref'd after the caller free'd it because these thread
functions were calling thread_down() before calling mail_close_socket(), which
deref's startup which was subject to a race condition.

Modified Files:


src/sbbs3/ans2asc.c
diff

src/sbbs3/ans2asc.vcxproj
diff

Read/use SAUCE for width and ice-color setting when cols not specified

Also added -normal option to use save/normal/restore attr sequence for
conditional-newlines. This is helpful for narrow ANSIs (e.g. 44-column
FILE_ID.ANS) that depend on the viewer to read/use the SAUCE info.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/filelist.vcxproj
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upload.cpp
diff

DIZ enhancements: Read/use SAUCE data, support ANSI, increase max 1->4K

Inspired by Blocktronics (and other ANSI art group) packs' FILE_ID.DIZ/ANS
files:
* Support (and prioritize) FILE_ID.ANS
* Convert ANSI color/attribute sequences in DIZ files to Ctrl-A equivalent
(uses SAUCE width and ICE color, if specified)
* Don't treat DIZ as a series of lines, they're not always nowadays.
* New putmsg() mode: P_INDENT to print files indented by current column
* Display full (up to 64-char) filenames in lists when using 132+ column
terminal.
* Use the Author, Group, and Title fields from the SAUCE if present/non-blank
* 2 new text.dat strings: 301 (FiAuthor) and 302 (FiGroup)
* Also fix bug with repeated Cost header field on bulk-uploaded files.

I know this'll break the *nix build (sauce.c dependency), but I'll fix that
next.

Modified Files:


src/sbbs3/js_file.c
diff

Use JS_ValueToECMAUint32 for File position, date, and length properties

This resolves errors when setting these properties to values > 2147483647
example:
!JavaScript  /sbbs/exec/load/sauce_lib.js line 69: Error: can't convert
2430770157 to an integer

That means you can now seek around (set position) within files > 2GB, truncate
or extend a file > 2GB, or set a file's date to > Jan-19-2038.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/upload.cpp
diff

Increase file_id.diz max line length from 80 to 255

Increase total extended description length from 1024 to 4000 characters.
Perhaps this should be configurable?

Modified Files:


src/smblib/smbdefs.h
diff

src/smblib/smblib.c
diff

Add convenience pointer (from_port) to SENDERPORT header field

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/upload.cpp
diff

Store file uploader's IP address, hostname, protocol and port

Modified Files:


xtrn/postit/postit.js
diff

removed note about moving to xtrn from exec

Added Files:


xtrn/postit/postit.js
diff

moved postit.js to its rightful home in the xtrn folder. anyone using this
script likely already has it there anyway. if not, data files should be moved
for anyone updating their local script. no file changes have been made.

Modified Files:


src/sbbs3/qwk.cpp
diff

Don't log an error when a QWKnet node uploads votes for old messages

Log an info-level message instead.
Raise the log level severity of duplicate votes from Debug to Info too.

Modified Files:


src/sbbs3/filedat.c
diff

Fail on "disallowed filename" after filtering for filename/pattern

Extracting a file_id.diz would fail if the file contained any disallowed
filenames before the DIZ, e.g.:
 Error: disallowed filename '_blockmen_res[v]olution.ans' (after extracting 0
items successfully)

Modified Files:


src/sbbs3/js_system.c
diff

Populate system.uptime in JSDoor

This variable tracks the time that jsdoor was started.

Modified Files:


exec/testbuild.js
diff

Add the Coverity scan support (for *nix builds only)

Modified Files:


src/sbbs3/userdat.c
diff

Let's make that semfile just sound.mute

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/ntsvcs.c
diff

src/sbbs3/ntsvcs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/websrvr.c
diff

Control sound-mute via semfile (ctrl/sound.muted) rather than sbbs.ini

There was a bug with reloading the configuration files in sbbsctrl where the
sound button no longer reflected the truth and the sysop's previous click-state
of the button was lost. Rather than going through writing the OPT_MUTE flag to
the Options fields of all the sections of the sbbs.ini and then re-loading that
file as a result, just do like we did with the sysop chat availability: use a
semfile. So much simpler.

If anyone ever needs instance-specific muting, we can create/check
instance/host-specific mute semfiles then. Doubt that'll happen though.

Also, removed the old sysavail control methods of ntsvcs too.

Added Files:


exec/delfiles.js
diff

New utility script that replaces DELFILES (the program) for sbbs v3.19

Modified Files:


exec/dupefind.js
diff

Add de-duplication feature (-dedupe option) to remove/delete dupe files found

Modified Files:


exec/str_cmds.js
diff

Remove commands: ALTUL, RESORT, CLOSE no longer applicable in v3.19

Modified Files:


exec/load/text.js
diff

Add FiUploadedTo string

Modified Files:


src/sbbs3/js_filebase.c
diff

get_size() and get_path() methods need to read the header record too

For files with names > 64 chars.

Modified Files:


src/sbbs3/js_filebase.c
diff

remove() method needs to read message header (not just index)

Or else it fails with the following base error:
!smb_putmsghdr illegal header length increase: 70 (1 blocks, 0 hfields, 0
dfields) vs 0 (0 blocks)

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Write the global sound (WAV) file settings in sbbs_write_ini().

Modified Files:


src/sbbs3/ctrl/.gitignore
diff

Ignore sbbsctrl.str output file.

Added Files:


src/sbbs3/ctrl/SoundCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/SoundCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/SoundCfgDlgUnit.h
diff

Modified Files:


src/sbbs3/ctrl/FtpCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/FtpCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/FtpCfgDlgUnit.h
diff

src/sbbs3/ctrl/MailCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/MailCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/MailCfgDlgUnit.h
diff

src/sbbs3/ctrl/PropertiesDlgUnit.cpp
diff

src/sbbs3/ctrl/PropertiesDlgUnit.dfm
diff

src/sbbs3/ctrl/PropertiesDlgUnit.h
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.h
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.h
diff

src/sbbs3/ctrl/WebCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/WebCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/WebCfgDlgUnit.h
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/ctrl/sbbsctrl.cpp
diff

src/sbbs3/ctrl/sbbsctrl.res
diff

Move all common sound (WAV) file configuration to its own dialog

Increment the version in the project file to v3.19a.

Added Files:


src/sbbs3/ctrl/.gitignore
diff

Ignore more C++Builder artifact files.

Modified Files:


src/sbbs3/ctrl/MainFormUnit.dfm
diff

Disable ChangeDir functionality of SaveDialog

This would cause all relative file paths to fail after exporting
settings to .ini file in another directory. Long time bug.

Modified Files:


src/sbbs3/ctrl/FtpCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/WebCfgDlgUnit.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

src/sbbs3/startup.h
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

src/sbbs3/xtrn_sec.cpp
diff

Update sound (WAV) file play-on-event support in Windows build

A "hack attempt" sound file is now supported in the Terminal Server, Mail
Server,  and Services.

"login" and "logoff" sound files are now supported in the Terminal Server, FTP
Server, Web Server, Mail Server, and Services.
This enhancement fixes Issue #157

The following sound files may now be configured in the [Global] section of the
ctrl/sbbs.ini file, if desired to set the default sound files for all
servers/services in on place:
- AnswerSound
- LoginSound
- LogoutSound
- HangupSound
- HackAttemptSound

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Fix typo in previous commit.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

Allow an alternate "services.ini" filename to be specified in sbbs.ini

Set sbbs.ini [services] iniFileName to something other than services.ini to
override the default filename. The automatic/optional hostname decoration of
the filename is still supported.

Addresses request #238.

Modified Files:


exec/hatchit.js
diff

Added "Replaces" keyword support for Al (TRMB)

Made some other cosmetic improvements/fixes.

Modified Files:


ctrl/text.dat
diff

Added FiUploadedTo string.

Modified Files:


src/uifc/uifc32.c
diff

Support WIN_ORG and WIN_BOT modes in uifc.input

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

Display list of file recipients ("Uploaded to") when relevant

for the user-to-user file transfer directory

Modified Files:


exec/load/filebase.js
diff

Replace the guts of OldFileBase to make it v3.19 compatible

This appears to be enough to make hatchit.js work again and file
listings in webv4 (not sure beyond that).

This file is now just an unnecessary shim and should go away when
the consumers (hatchit and webv4) no longer need it.

I did not "port" support for the file properties:
- base
- ext
- datoffset
- opencount
- misc
- altpath

They don't appear to be needed.

Modified Files:


exec/dupefind.js
diff

Update command-line parsing (e.g. double-dash support) and help output

Modified Files:


exec/addfiles.js
diff

Make --help work and copy the option parsing logic from filelist.js

Modified Files:


text/menu/transfer.msg
diff

Restore the /U and /D (user-to-user file transfer) commands

Modified Files:


exec/filelist.js
diff

Optionally include newest-file-in-archive date/time and other features

Modified Files:


ctrl/text.dat
diff

Restore user-to-user file transfer related strings.

More use of the "conditional newline" (^A?) code rather than hard-coded
CRLFCRLFs.

Modified Files:


src/sbbs3/execfile.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

Restore the user-to-user file transfer feature

I forget who it was that said they were still using this feature in v3.18, but
here you go, it's working again (the /D and /U commands). I'm not migrating any
file sender/recipient info from v3.18, so only files added after upgrading to
this will be downloadable from the "user" directory (if you have one).

Something that I never implemented before but noticed is missing is the removal
(or dereferencing) of user-to-user files that were sent from/to a user that is
then deleted. So that's still a TODO item.

Modified Files:


src/sbbs3/addfiles.c
diff

Fix the file update support a bit.

This is still broken (errors when updating existing files) and is still planned
for deprecation.

Modified Files:


src/sbbs3/getmail.c
diff

Don't log a file removal error if the file doesn't exist.

Modified Files:


exec/str_cmds.js
diff

Fix TypeError: file_area.lib_list[i].dir is undefined

dir is not a property of lib_list[], appears to be a typo.

Also, in the "lib" scope commands, j was not defined.

The offline_dir property appears to have been deprecated (no longer
enumerable) years ago, in favor of the dir/dir_list[].is_offline
property, so use that property instead for skipping offline dirs.
Reported by xbit (XBITBBS)

Also, make sure the ;upload and other lib/all search commands are
abortable with Ctrl-C.

Modified Files:


src/sbbs3/addfiles.c
diff

Fix some crashes on multi-line description import stuff

Even though this is going to be removed / deprecated.

Modified Files:


src/xpdev/str_list.c
diff

if strListFind() is passed a NULL 'str' value, return -1 (not found)

Return int value for "string not found" rather than crash/segfault. Seems the
better option.

Modified Files:


src/sbbs3/pack_qwk.cpp
diff

Fix QWK/BLT-* copy issue (regression since v3.18)

Reported by Daryl Stout (TBOLT)

Modified Files:


src/sbbs3/userdat.c
diff

Don't compare array against NULL

Addresses CID 319116 and 319090

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Refactor putuserrec()

This started with a Coverity issue (CID 33230) which got me looking at this
function and wondering: why is str2 being NUL-terminated here? Why is the
length of str2 to be calculated on successive lines? What is with this
(long)((long)((long)((long)) typecast?

This was some of the oldest code in Synchronet (along with a lot of the other
functions in this file). I tried to keep as much intact as possible while still
improving the logic and readability.

Modified Files:


src/sbbs3/postmsg.cpp
diff

Debug the "thread_back field missing" error

Some QWKnet vote messages are failing:
evnt unpackREP <ENSEMBLE> !ERROR 2 (No such file or directory) in qwk.cpp line
1146 (qwk_vote) writing "/sbbs/data/subs/dove-gen" access=-105 info=smb_addvote
thread_back field missing

Catch this problem a little higher up (in votemsg()) and log the message's
reply-IDs to help determine what's the root-cause here. Don't bother calling
smb_addvote() if thread_back is 0.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/un_rep.cpp
diff

Add/use P_REMOTE print-mode flag to bputs()

Do nothing if online != ON_REMOTE. Eliminates some if(online == ON_REMOTE)
clauses.

Modified Files:


src/sbbs3/js_internal.c
diff

Delete one-shot events before running the callback.

If a callback deletes the one-shot event that invoked it, the
event pointer in the caller would be to free()d memory with
hilarious results.

Modified Files:


exec/presence-service.js
diff

Hack the planet.

Added Files:


exec/presence-service.js
diff

Serves "presence" data about local and remote users.

Upon connecting, a client will be sent a list of who's online on
the local BBS as well as other systems (if you and they are set
up for instant messaging). Updates will be sent for subsequent
events (logon, update, logoff).

Mostly intended for use by local consumers; you probably don't
need to open any ports for this.

Nothing uses this at the moment and you do not need to add it
to your config. Eventually it'll bring interBBS presence and
messaging back to webv4 and probably introduce a fancier textmode
imsg module.

Modified Files:


src/sbbs3/js_filebase.c
diff

Check return value of JS_ValueToInt32()

CID 331092

Modified Files:


src/sbbs3/scansubs.cpp
diff

Don't pass uninitialized string to scanposts()

CID 319108

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix some memory leaks

Modified Files:


exec/fseditor.js
diff

Do not use js.report_error()

Properly throw an error instead.

Modified Files:


exec/load/file_size.js
diff

Use Math.round() for sizes > 1024 and < 1024000

Modified Files:


install/GNUmakefile
diff

Copy upgrade_to_v319 to exec dir upon install. <shrug>

Fixes issue #252.

Added Files:


3rdp/build/js-allow-python3.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Disable configure test for python2.[567]

Just don't check the python version at all.  If your python is older
than 2.5, you're already having other issues.

Modified Files:


exec/load/file_size.js
diff

Revert back to whole numbers only for the comma-formatted K output

but round-up non-zero values to 1K.

Modified Files:


exec/filelist.js
diff

Add configurable size formatting, filename formatting, ext-description offset

Modified Files:


exec/loadfonts.js
diff

Accolades

Modified Files:


exec/loadfonts.js
diff

Updated documentation section 1.1a01

Modified Files:


exec/loadfonts.js
diff

Added some documentation.
Appended very important trailing linefeed.

Modified Files:


src/sbbs3/js_filebase.c
diff

Add format_name() method to format a filename for display

It's a wrapper for filedat.c -> format_filename() which can truncate and pad a
filename for display purposes.

Modified Files:


src/xpdev/sockwrap.c
diff

Add more detail to socket_check() comment

Modified Files:


src/xpdev/sockwrap.c
diff

Finally document socket_check() behaviour.

Tweak the poll() implementation to match.

Should fix #248

Modified Files:


exec/load/file_size.js
diff

When bytes is falsey and size is > 0 but < 1000*1024 don't return "0K"

Instead, return the fractional size in KB's with 2 digits of precision.

Fixed up some of the variable names.

Modified Files:


exec/filelist.js
diff

Pretty much a complete re-write and still a work-in-progress, but useful

The biggest difference is that you can combine all files from multiple dirs
into a single sorted list and you can sort on any property (field) value.

The byte/credit format is very customizeable, the output format is completely
customizeable.

By default, just the filenames are output, but either use '-ext' or one or
more '-v' values to add more fields. Use -p=list to specify a comma-separated
list of properties to print.

Modified Files:


src/sbbs3/js_internal.c
diff

Fix sizeof() target.

Modified Files:


src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

When a callback event is handled, get remote_addr

Prevents weird issues with getting remote address.

Modified Files:


src/sbbs3/filedat.c
diff

Sorted loadfiles() results were corrupted when detail was < normal

When only reading the index (detail = file_detail_index), smb_getfile() just
sets the file->name convenience pointer to point to the name in the index. Then
when loadfiles() would sort the list, these pointers would not be adjusted (so
they would point to the wrong names) resulting in a corrupted file list (e.g.
name/size mismatches and no logical sort order).

The solution is to call smb_getfile() on each file *after* the read index
records have been sorted.

This also means that the sort-by-name routines needed to always sort using the
index name and not the convenience pointer (which is NULL in this case).

While fixing this, I noticed there was no bounds checking in the loadfiles()
and loadfilenames() read-loops, so if the indexes happened to be longer than
the total_files value from the status header, a buffer under-alloc/overflow
would occur and a likely crash as a result. So stop reading the index when the
expected maximum number of index records have been read.

Modified Files:


webv4/root/api/events.ssjs
diff

Content-Type not Content-type; delay 1000 ms between event source scans.

Modified Files:


exec/dupefind.js
diff

Use the new file_size_str() usage for prettier sizes-in-bytes

Modified Files:


exec/addfiles.js
diff

Replace print() with writeln()

Modified Files:


exec/load/file_size.js
diff

Add optional/better format to file_size_str() by passing a precision as 3rd arg

Returns a floating-point formatted size estimate more in-line with my
preference (e.g. 17.0G instead of 17,000M).

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix hash() method broken in commit bc4f24f5 - file needs the dir num

Modified Files:


exec/imapservice.js
diff

Some more fixes...

Fix bseen calculation and saving
Only save seen data after all repsonses have been sent
Stop processing when the socket has been closed

Added Files:


exec/dupefind.js
diff

A duplicate file finder for Synchronet v3.19 - replaces native DUPEFIND

Can find duplicate files in your file bases by name and/or hash sum - fast!
Can output simple text or JSON format.
Run 'jsexec dupefind' to search just for duplicate files by hash (SHA-1)
or run 'jsexec dupefind -help' for the various usage options.

Modified Files:


src/sbbs3/js_filebase.c
diff

Don't expand empty from, tags, desc properties unless detail=MAX

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix missing paren warnings.

Modified Files:


src/sbbs3/scfglib2.c
diff

Don't pretend that user-to-user file transfers are working (they don't)

So just always assume that no "user" directory has been configured. At least
for now while I ponder whether this is a feature worth restoring and if so,
how.

Modified Files:


src/sbbs3/services.c
diff

Include user alias in logged JS error/warning messages

Modified Files:


src/sbbs3/js_filebase.c
diff

Include all properties in getter when detail is MAX

Adds from/tags/desc/extdesc properties, even when absent or blank.

When parsing a file object, set the from, desc, tags and cost properties only
if they already have been set or the new values is non-blank/0.

Modified Files:


src/sbbs3/js_system.c
diff

src/xpdev/genwrap.c
diff

Fix msclock() and xp_timer() to be monotonic on *nix

Previously, these both used gettimeofday() which is both expensive
to call, and not monotonic.

This fixes system.clock_ticks in JS and various internal bits. for
when the UTC wall clock jumps.

While we're here, fix the documention of system.clock_ticks

Modified Files:


exec/tickit.js
diff

Use -debug command-line option if you want the <area> using ... address log

For Nelgin, to reduce log spam.

Modified Files:


src/sbbs3/scfg/scfgsub.c
diff

Clarity around QWK Conference Names

Modified Files:


src/sbbs3/jsexec.c
diff

Typos in help

Modified Files:


src/sbbs3/dupefind.c
diff

Fix heap corruption (under malloc) - crashed on Linux-x64

Modified Files:


src/sbbs3/js_socket.c
diff

Fix some bugs around sock.on('write'...) and sock.clearOn()

Modified Files:


src/sbbs3/sockopts.c
diff

Only set IPV6_ONLY if it's #defined.

Modified Files:


exec/load/dns.js
diff

Fixes for async lookups

- Add a unique number to event names for each request
  Prevents responses from being acepted by multiple queries
- Don't set Socket.dnsObject for synchronous lookups
- OPcode of 2 is used for status replies (ie: NXDOMAIN)
- Be more careful construct result array in request()

Modified Files:


src/sbbs3/sockopts.c
diff

JSDOOR isn't defined here.

Modified Files:


src/sbbs3/sexyz.c
diff

Address GCC 9.3.0 warnings:

warning: format not a string literal and no format arguments

Modified Files:


exec/load/dns.js
diff

Only the async query needs the timeout now, so move it back in.

Also, have handle_response() return errors.

Modified Files:


exec/load/dns.js
diff

Use this, not ctx in handlers.

Modified Files:


src/sbbs3/telgate.cpp
diff

src/xpdev/gen_defs.h
diff

Allow SAFECAT to work on uchar arrays

Caught by CID 331001

The use of SAFECAT() with a typecast to a pointer is not going to work as
expected. This change broke line-based telnet-gateway functionality
(unconfirmed, but pretty obvious).

Modified Files:


src/sbbs3/services.c
diff

Set fds to NULL before recycle.

Likely the cause of the crash that killed cvs.synchro.net last night

Modified Files:


exec/imapservice.js
diff

Fix last commit... there are bits that aren't Seen that are saved

Modified Files:


exec/imapservice.js
diff

Guard against Seen being undefined when saving config.

Modified Files:


src/sbbs3/main.cpp
diff

EVN MR!

Modified Files:


src/sbbs3/main.cpp
diff

MOAR!

Modified Files:


src/sbbs3/main.cpp
diff

Spaces -> Tabs

Tabs are the shit.

Modified Files:


src/sbbs3/js_msg_area.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Add area_tag property to msg_area.sub[]

For easier use of the auto-generated echo-tags in JS.
And a helper function sub_area_tag(), now used in SCFG too.

Added Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

Modified Files:


exec/ircd.js
diff

IRCd 1.9

Added Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

Modified Files:


exec/ircd.js
diff

Merge branch 'deuce-says-so' into 'master'

First IRCd 1.9 changes

See merge request main/sbbs!125

Modified Files:


src/sbbs3/js_console.cpp
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

Make the callback stuff 3.19

Modified Files:


src/sbbs3/js_internal.c
diff

Keep running the event loop while the run queue is not empty

Previously, timed or polled callbacks were required to keep the
event loop running.

Modified Files:


exec/load/array.js
diff

Update array.js formatting

Autoformatted via prettier with settings below, this is so additional polyfill
matches can be used to match formatting in future PRs for polyfills, as well as
full formatting tooling for .js files.

```yaml
tabWidth: 4
useTabs: true
singleQuote: true
trailingComma: "es5"
```

Modified Files:


exec/load/array.js
diff

Merge branch 'format-array-polyfills' into 'master'

Update array.js formatting

See merge request main/sbbs!120

Modified Files:


src/sbbs3/exec.cpp
diff

Have js_execfile() save/restore callbacks

This should allow callbacks to not interfere between (say) shells
and doors.

Modified Files:


exec/addfiles.js
diff

Add option (-delete) to delete the list file after import

Like the -d option for ADDFILES.

For Al (TRMB)

Modified Files:


src/sbbs3/js_internal.c
diff

Clarify that dispatchEvent() adds to the end of the run queue

Modified Files:


src/sbbs3/js_internal.c
diff

Add js.setImmediate(callback[, thisObj)

I haven't added a clearImmediate() because there's currently no way
of manipulating the run queue, and I can't come up with a reason
someone would actually need it.

Modified Files:


src/sbbs3/js_internal.c
diff

Fix event listener removal

Was terribly broken.

Modified Files:


exec/load/dns.js
diff

Change default failures to 3 and timeout to 5sec

Also, check that the opcode and response flag are correct when
parsing responses.

When handling a resolve call, ensure no errors occured.

Modified Files:


src/conio/ansi_cio.c
diff

src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/conio/mouse.c
diff

src/encode/base64.h
diff

src/encode/lzh.c
diff

src/encode/lzh.h
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/js_cryptcert.h
diff

src/sbbs3/js_cryptcon.h
diff

src/sbbs3/ringbuf.c
diff

src/sbbs3/websrvr.h
diff

src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

src/uifc/uifcx.c
diff

src/xpdev/datewrap.h
diff

src/xpdev/dirwrap.h
diff

src/xpdev/eventwrap.h
diff

src/xpdev/filewrap.h
diff

src/xpdev/genwrap.h
diff

src/xpdev/link_list.h
diff

src/xpdev/msg_queue.h
diff

src/xpdev/multisock.h
diff

src/xpdev/netwrap.h
diff

src/xpdev/semfile.h
diff

src/xpdev/semwrap.h
diff

src/xpdev/threadwrap.h
diff

src/xpdev/wrapdll.h
diff

src/xpdev/xp_dl.h
diff

src/xpdev/xpbeep.c
diff

src/xpdev/xpbeep.h
diff

src/xpdev/xpdatetime.h
diff

src/xpdev/xpmap.h
diff

src/xpdev/xpprintf.h
diff

The great DLLCALL purge of 2021 - part 2

Modified Files:


src/sbbs3/chksmb.c
diff

src/sbbs3/data.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getmail.c
diff

src/sbbs3/getstats.c
diff

src/sbbs3/js_client.c
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptkeyset.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msg_area.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_queue.c
diff

src/sbbs3/js_rtpool.c
diff

src/sbbs3/js_server.c
diff

src/sbbs3/js_sprintf.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/js_xtrn_area.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/ntsvcs.c
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/services.c
diff

src/sbbs3/sockopts.c
diff

src/sbbs3/ssl.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/websrvr.c
diff

src/xpdev/datewrap.c
diff

src/xpdev/dirwrap.c
diff

src/xpdev/genwrap.c
diff

src/xpdev/ini_file.c
diff

src/xpdev/link_list.c
diff

src/xpdev/msg_queue.c
diff

src/xpdev/multisock.c
diff

src/xpdev/netwrap.c
diff

src/xpdev/semfile.c
diff

src/xpdev/semwrap.c
diff

src/xpdev/threadwrap.c
diff

src/xpdev/xp_dl.c
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpmap.c
diff

src/xpdev/xpprintf.c
diff

The great DLLCALL purge of 2021

This macro has expanded to nothing for a while now and even before, the usage
was misguided and unnecessary as explained in this video:
https://www.youtube.com/watch?v=cjotPqQxxAY

Modified Files:


src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

Fix errors with callback-based connect()

Non-poll used the wrong value for calculating the high socket (which
is ignored on Win32, the only non-poll() user), and the socket was
being set in the wrong union member.

Modified Files:


src/xpdev/sockwrap.h
diff

Add nfds_t required by poll(), and add note describing Win32 bug

Modified Files:


src/sbbs3/str.cpp
diff

This strcpy() needs to remain as was (caught be GCC).

Modified Files:


src/sbbs3/filedat.c
diff

If error is NULL, insure maxerrlen is 0.

Hopefully this will eliminate the "Dereference after null check" warnings by
Coverity (e.g. CID 330993).

Modified Files:


src/sbbs3/js_archive.c
diff

Insure outdir is never NULL

CID 319037

Modified Files:


src/sbbs3/js_com.c
diff

Handle filelength() returning negative value

CID 33260

Modified Files:


src/sbbs3/js_console.cpp
diff

Remove logically dead code

CID 174335

Modified Files:


src/sbbs3/js_cryptcert.c
diff

Remove structurally dead code (copy pasta?)

CID 174455

Modified Files:


src/sbbs3/js_cryptcon.c
diff

Don't use mode without checking if NULL first

CID 319598

Modified Files:


src/sbbs3/js_cryptkeyset.c
diff

Remove structurally dead code

CID 174483

Modified Files:


src/sbbs3/js_file.c
diff

Fix some printf argument types

CID 319023 319065 319134

Modified Files:


src/sbbs3/js_filebase.c
diff

Alt paths aren't supported/used any longer

Fixes CID 330973

Modified Files:


src/sbbs3/js_filebase.c
diff

dirnum is unsigned, so do not check for negative

CID 330990

Modified Files:


src/sbbs3/js_socket.c
diff

printf fmt/argument type mismatches

CID 319085 319089 319135 319142

Modified Files:


src/sbbs3/js_system.c
diff

client.addr is now an array not pointer

CID 319143

Modified Files:


src/sbbs3/js_uifc.c
diff

Remove logically dead code

PROP_CHANGES already handled in if() condition
CID 33176

Modified Files:


src/sbbs3/main.cpp
diff

ftell() can return negative, deal

CID 33232

Modified Files:


src/sbbs3/node.c
diff

Address logically dead code

This is so old/bad. CID 33179.

Modified Files:


src/sbbs3/postmsg.cpp
diff

mod_ar is no longer a pointer, it's an array

CID 319077

Modified Files:


src/sbbs3/qwk.cpp
diff

The QWK reset sub ptr command would never work

Caught by Coverity-scan CID 33178

Modified Files:


src/sbbs3/scfg/scfgnet.c
diff

strcat() -> SAFECAT()

CID 174491

Modified Files:


src/sbbs3/str.cpp
diff

strcpy -> SAFECOPY

CID 33568

Modified Files:


src/sbbs3/str.cpp
diff

read_ar is no longer a ptr, it's an array

CID 319112

Modified Files:


exec/load/dns.js
diff

Use a single class, and pass in a synchronous flag.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix unsigned int compare to negative - caught by Coverity-scan

Modified Files:


src/sbbs3/js_file.c
diff

printf usage issue caught by Coverity.

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix memory leaks caught by Coverity.

Modified Files:


src/sbbs3/js_msg_area.c
diff

mod_ar is not a pointer, it's an array.

Modified Files:


src/sbbs3/js_socket.c
diff

Fix resource leaks caught by Coverity-scan

CID 330950 and 319020

Modified Files:


src/sbbs3/js_system.c
diff

Fix dead code issues reported by Coverity-scan

Modified Files:


src/sbbs3/qwk.cpp
diff

Fix incorrect buf size argument caught by Coverity-scan

Modified Files:


src/sbbs3/sbbsecho.c
diff

Use SAFECAT() instead of strcat() for more safety.

Modified Files:


src/sbbs3/services.c
diff

Fix UDP buffer memory leak when max clients reached

Caught by Coverity-scan CID 330055

Modified Files:


src/sbbs3/upgrade_to_v319.c
diff

Address Coverity-reported issues

The use of uninitialized smb.retry_time was worst offender, but not expected to
cause any actual issues.

Modified Files:


src/sbbs3/websrvr.c
diff

Fix resource leak in ssjs_send_headers()

IdArray returned by JS_Enumerate() was never freed.

Caught by Coverity-scan, CID 319627.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Fix use of uninitialized local variable (err_pipe[]) on *nix

And other weirdness around EX_NOLOG mode checks.
Addresses Coverity-scan CID 330048.

Modified Files:


src/sbbs3/websrvr.c
diff

Fix socket descriptor leak in fastcgi_connect()

Found by Coverity-scan (CID 330051)

@Deuce should review this.

Modified Files:


src/sbbs3/atcodes.cpp
diff

New @-code: CONTINUE

CONTINUE is like GETKEY except it'll set the display-abort flag if 'N' or 'Q'
are typed.

Make the WAIT:<n> argument 10ths of a second (instead of milliseconds) to be
more consistent with DELAY:<n>.

Modified Files:


src/sbbs3/sbbs.h
diff

Specify default kmode values for getkey() and inkey()

Modified Files:


src/sbbs3/atcodes.cpp
diff

New @-codes: GETKEY and WAIT:<milliseconds>

GETKEY waits indefinitely for any key press by the user (resolves issue #245).
WAIT:<n> waits for up to n-milliseconds for a key press and then continues on.

For both cases, the key pressed is not echoed or acted upon in any way.
Ctrl-keys could be handled by global or built-in ctrl-key handlers, so those
would be the exception.

Modified Files:


docs/newfilebase.txt
diff

Finish the incomplete thought in the Sorting section

Modified Files:


src/sbbs3/scfg/scfgsub.c
diff

Allow the disabling of @-code expansion in sysop-posted msgs

And make it the default for newly created sub-boards.

Modified Files:


src/syncterm/uncrustify.cfg
diff

Fix single-line if stuff

Added Files:


3rdp/win32.release/libarchive/bin/archive.dll
diff

3rdp/win32.release/libarchive/bin/archive.lib
diff

3rdp/win32.release/libarchive/include/archive.h
diff

3rdp/win32.release/libarchive/include/archive_entry.h
diff

3rdp/win32.release/libarchive/libarchive.props
diff

3rdp/win32.release/zlib/bin/zlib1.dll
diff

3rdp/win32.release/zlib/include/zconf.h
diff

3rdp/win32.release/zlib/include/zlib.h
diff

docs/newfilebase.txt
diff

exec/addfiles.js
diff

exec/archive.js
diff

exec/filelist.js
diff

exec/hashfile.js
diff

exec/postfile.js
diff

exec/rehashfiles.js
diff

exec/updatefiles.js
diff

src/hash/sha1.c
diff

src/hash/sha1.h
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

Modified Files:


3rdp/build/Common.gmake
diff

ctrl/file.cnf
diff

ctrl/text.dat
diff

exec/default.src
diff

exec/jsdocs.js
diff

exec/load/avatar_lib.js
diff

exec/load/fidocfg.js
diff

exec/load/sbbslist_lib.js
diff

exec/load/text.js
diff

exec/pcboard.src
diff

exec/sbbslist.js
diff

exec/simple.src
diff

exec/tickit.js
diff

exec/update.js
diff

exec/wildcat.src
diff

src/hash/crc16.c
diff

src/hash/crc16.h
diff

src/hash/crc32.c
diff

src/hash/crc32.h
diff

src/hash/md5.c
diff

src/hash/md5.h
diff

src/hash/objects.mk
diff

src/sbbs3/GNUmakefile
diff

src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/allusers.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chksmb.c
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/ctrl/AboutBoxFormUnit.dfm
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/dat_rec.c
diff

src/sbbs3/dat_rec.h
diff

src/sbbs3/data.cpp
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/download.cpp
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/filelist.c
diff

src/sbbs3/filelist.vcxproj
diff

src/sbbs3/fixsmb.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/msgdate.h
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/nodedefs.h
diff

src/sbbs3/objects.mk
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/release.bat
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbs3.sln
diff

src/sbbs3/sbbs4defs.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/scfgsave.h
diff

src/sbbs3/services.c
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/slog.c
diff

src/sbbs3/smbactiv.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/targets.mk
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/v4upgrade.c
diff

src/sbbs3/viewfile.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.vcxproj
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/smblib/smbadd.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbdump.c
diff

src/smblib/smbfile.c
diff

src/smblib/smbhash.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

src/smblib/smblib.vcxproj
diff

src/smblib/smbstr.c
diff

src/xpdev/dirwrap.c
diff

src/xpdev/dirwrap.h
diff

src/xpdev/gen_defs.h
diff

src/xpdev/ini_file.c
diff

src/xpdev/str_list.c
diff

src/xpdev/str_list.h
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpdatetime.h
diff

text/menu/sysxfer.asc
diff

text/menu/transfer.msg
diff

Removed Files:



src/sbbs3/sortdir.cpp
diff

A poll() failure with EINTR does not mean a socket is closed.

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

Added Files:


3rdp/win32.release/libarchive/bin/archive.dll
diff

3rdp/win32.release/libarchive/bin/archive.lib
diff

3rdp/win32.release/libarchive/include/archive.h
diff

3rdp/win32.release/libarchive/include/archive_entry.h
diff

3rdp/win32.release/libarchive/libarchive.props
diff

3rdp/win32.release/zlib/bin/zlib1.dll
diff

3rdp/win32.release/zlib/include/zconf.h
diff

3rdp/win32.release/zlib/include/zlib.h
diff

docs/newfilebase.txt
diff

exec/addfiles.js
diff

exec/archive.js
diff

exec/filelist.js
diff

exec/hashfile.js
diff

exec/postfile.js
diff

exec/rehashfiles.js
diff

exec/updatefiles.js
diff

src/hash/sha1.c
diff

src/hash/sha1.h
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

Modified Files:


3rdp/build/Common.gmake
diff

ctrl/file.cnf
diff

ctrl/text.dat
diff

exec/default.src
diff

exec/jsdocs.js
diff

exec/load/avatar_lib.js
diff

exec/load/fidocfg.js
diff

exec/load/sbbslist_lib.js
diff

exec/load/text.js
diff

exec/pcboard.src
diff

exec/sbbslist.js
diff

exec/simple.src
diff

exec/tickit.js
diff

exec/update.js
diff

exec/wildcat.src
diff

src/hash/crc16.c
diff

src/hash/crc16.h
diff

src/hash/crc32.c
diff

src/hash/crc32.h
diff

src/hash/md5.c
diff

src/hash/md5.h
diff

src/hash/objects.mk
diff

src/sbbs3/GNUmakefile
diff

src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/allusers.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chksmb.c
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/ctrl/AboutBoxFormUnit.dfm
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/dat_rec.c
diff

src/sbbs3/dat_rec.h
diff

src/sbbs3/data.cpp
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/download.cpp
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/filelist.c
diff

src/sbbs3/filelist.vcxproj
diff

src/sbbs3/fixsmb.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/msgdate.h
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/nodedefs.h
diff

src/sbbs3/objects.mk
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/release.bat
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbs3.sln
diff

src/sbbs3/sbbs4defs.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/scfgsave.h
diff

src/sbbs3/services.c
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/slog.c
diff

src/sbbs3/smbactiv.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/targets.mk
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/v4upgrade.c
diff

src/sbbs3/viewfile.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.vcxproj
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/smblib/smbadd.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbdump.c
diff

src/smblib/smbfile.c
diff

src/smblib/smbhash.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

src/smblib/smblib.vcxproj
diff

src/smblib/smbstr.c
diff

src/xpdev/dirwrap.c
diff

src/xpdev/dirwrap.h
diff

src/xpdev/gen_defs.h
diff

src/xpdev/ini_file.c
diff

src/xpdev/str_list.c
diff

src/xpdev/str_list.h
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpdatetime.h
diff

text/menu/sysxfer.asc
diff

text/menu/transfer.msg
diff

Removed Files:



src/sbbs3/sortdir.cpp
diff

Merge branch 'new_file_base' into 'master'

New file base

Closes #241

See merge request main/sbbs!123

Modified Files:


src/syncterm/uncrustify.cfg
diff

Updates

Added Files:


src/syncterm/uncrustify.cfg
diff

Initial pass at uncrustify config for SyncTERM code

Modified Files:


exec/load/dns.js
diff

Add DNS_blocking sub-class for non-event driven lookups

The DNS_blocking class supports the same API as the DNS class, but
does not use events, so any method will complete before returning.
As such, the callback argument is optional.

Modified Files:


src/sbbs3/js_console.cpp
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/sbbs.h
diff

Fix removal of non-timer events

js_callback_t was not being properly retreived.

Modified Files:


src/sbbs3/GNUmakefile
diff

Not sure why jsdoor depended on sbbs

Not having that dependency is the entire point of it.

Modified Files:


exec/load/dns.js
diff

At least test that it compiles.

Sheesh.

Modified Files:


exec/load/dns.js
diff

Add untested parsers for interesting record types

SRV, NAPTR, and URI

Modified Files:


exec/imapservice.js
diff

Ensure line isn't valid is it's not read in parse_string()

Thus appears to have been the root cause of the infinite loop/memory
issue.  Basically, line was never replaced if it didn't match
^{[0-9]+}$ and didn't result in a number when passed to parseInt()
This resulted in an infinite loop that kept pushing zero-length
strings into an array.

Modified Files:


exec/imapservice.js
diff

Improve error message

Modified Files:


exec/imapservice.js
diff

Check for invalid line thing...

Implicated in possible infinite loop/OOM problems.

Modified Files:


xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

Version 1.11:  When configured to use all available sub-boards, still don't
allow choosing
a sub-board that has polls disabled.  This fixes an issue where SlyVote was
showing all
available message groups but some could be empty due to having no sub-boards
that allow polls.

Modified Files:


xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

Merge branch '247_slyvote_msggroup_undefined' into 'master'

Fix for #247: Slyvote javascript error pMsgGrps[pGrpIdx] is undefined

See merge request main/sbbs!122

Modified Files:


exec/sbbslist.js
diff

The command prompt is now always on the bottom of the screen
(console.screen_rows).

Modified Files:


exec/sbbslist.js
diff

Merge branch '244_sbbslist_command_prompt_not_always_on_bottom' into 'master'

The command prompt is now always on the bottom of the screen

See merge request main/sbbs!121

Added Files:


exec/load/dns.js
diff

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_socket.h
diff

src/sbbs3/js_system.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Initial work on setTimeout()

This appears to work and the event handler *should* work on other
event types already.

Note, this is *nix-only due to the use of poll().  select() will
need to be used for Windows to keep XP compatability.

Added Files:


exec/load/dns.js
diff

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_socket.h
diff

src/sbbs3/js_system.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Merge branch 'echicken-less-grumpy' into 'master'

Implement support for callback style programming

See merge request main/sbbs!118

Modified Files:


.gitignore
diff

ignore .vscode

Modified Files:


.gitignore
diff

Merge branch 'ignore-vscode' into 'master'

ignore .vscode

See merge request main/sbbs!119

Modified Files:


src/sbbs3/js_socket.c
diff

Fix Socket.connect()

Broken with the poll() update

Modified Files:


src/sbbs3/sockopts.c
diff

Default to IPV6_V6ONLY=1 for jsdoor

Modified Files:


exec/load/typeahead.js
diff

Added 'autoDelete' setting. Probably needs some more work.
If true, and if this is our first input, and if the users types
something that would otherwise have been appended to the default
text, then the default text is deleted first.

Modified Files:


xtrn/go-for/go-for.js
diff

Use new typeahead autoDelete setting.

Modified Files:


xtrn/go-for/go-for.js
diff

xtrn/go-for/help.txt
diff

q from help screen quits help, not the whole program.
o from help screen no longer causes go-for to shit its pants in
dramatic fashion.
s and w are now aliases for tab and ` respectively (item nav).

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix editmsg() always fails bug introduced in commit 0c441424

Another Coverity-issued-fixed-introduced-bug.

Failure to remove a non-existant file is not reason for failure.

Modified Files:


src/uifc/uifc32.c
diff

Have showbuf() clamp width the same way as height...

Basically, assume left is correct, and calculate the correct width
to fill the screen to the esge.

Modified Files:


src/sbbs3/js_uifc.c
diff

Make context defaults for with and height same as no-context ones.

ARE YOU HAPPY NOW CYAN?!?!

Modified Files:


src/build/Common.gmake
diff

os is lower-case.

Fixes *nix builds of Win32 programs.

Modified Files:


src/sbbs3/main.cpp
diff

Fix error in last commit.

Looks like I was partially restoring old code before I stopped.

Modified Files:


src/build/Common.gmake
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/xtrn.cpp
diff

src/xpdev/multisock.c
diff

src/xpdev/sockwrap.c
diff

Use new PREFER_POLL define to control poll() usage

Rather than depending on _WIN32 which is silly, make it clear what
exactly is being done and why.

Note that the spy socket stuff and some external stuff on *nix have
had the select() implementation removed.  To support using select()
on !Win32 will require de-refactoring that's not really worth doing.
Instead, just use #error and reference the commit where the old
code can be found.

Modified Files:


src/sbbs3/js_uifc.c
diff

Set a better default window for uifc.showbuf()

Rather than defaulting to zero lines high and the width of the title,
default to the entire screen area.

Modified Files:


src/uifc/uifc32.c
diff

Fix glitch in showbuf window with odd-numbered width

Modified Files:


src/sbbs3/js_uifc.c
diff

Fix showbuf context issues.

Modified Files:


src/sbbs3/mxlookup.c
diff

Fix clang warning

Modified Files:


src/sbbs3/websrvr.c
diff

Remove some unused variables.

Modified Files:


src/sbbs3/execnet.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ident.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mxlookup.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs_status.c
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/xtrn.cpp
diff

Initial poll() work

Still needs updates in services_thread(), CGI stuff in websrvr.c,
and sbbs_t::external()

Modified Files:


src/sbbs3/execnet.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ident.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mxlookup.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs_status.c
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/xtrn.cpp
diff

Merge branch 'poll-update' into 'master'

Poll update

See merge request main/sbbs!116

Modified Files:


src/syncterm/syncterm.c
diff

Use kDownloadsFolderType for downloads.

Found by digging through headers... Apple doesn't document this.

Added Files:


3rdp/build/cl-check-before-use.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Fix macOS build.

Just some more macOS silliness.

Modified Files:


src/syncterm/ooii.c
diff

Guard against pathologically bad OO][ sequences.

Modified Files:


src/syncterm/GNUmakefile
diff

src/syncterm/conn.c
diff

src/syncterm/extdeps.mk
diff

src/syncterm/objects.mk
diff

Fix WITHOUT_CRYPTLIB option.

Modified Files:


src/syncterm/bbslist.c
diff

Fix issue with redrawing BBS list from settings menu

Sometimes the comment wasn't redrawn.
Also, remove configurable mouse actions stuff, not implemented in
13 years, I suspect I'll never do it.

Modified Files:


exec/fseditor.js
diff

Don't use handle_backspace() to handle delete.

While they both delete a character, delete at the end of a line will
move the next line up instead of moving this line up.

Fixes #243

Modified Files:


exec/login.js
diff

Run the "inactive_hangup" option through parseInt()

Just in case it was read as a string (e.g. had a ; comment following the value)

Modified Files:


ctrl/modopts.ini
diff

Remove the comment from the [login] inactive_hangup value

caused it to be represented as JS string rather than number causing an issue
with login.js:
Node 1 terminal not detected, reducing inactivity hang-up timeout to 0 seconds

Modified Files:


xtrn/lord2/cnw/inn.ref
diff

Actually, it was everything *except* Leave that was broken.

Redraw map before returning to startma/startma1

Modified Files:


xtrn/lord2/cnw/inn.ref
diff

Redraw map when you 'Leave' talking to Ma in Greetree inn.

There's likely an ass-ton of these though.

Modified Files:


exec/dorkit/sbbs_input.js
diff

js.terminated does not get set when the user disconnects

Also check bbs.online for sbbs input.

Modified Files:


xtrn/lord/lord.js
diff

Don't enable ctrl keys with dorkit here either.

Modified Files:


xtrn/lord2/lord2.js
diff

Don't enable ctrl-keys for background threads.

Synchronet goes boom.

Modified Files:


exec/load/dorkit.js
diff

Don't set js.terminated mmmkay?

Modified Files:


xtrn/lord2/l2lib.js
diff

Fix a (harmless) user creation error

When a players map is set, it automatically triggers a player record
write.  When a new player is being created, the map is set before
the player is added via @addchar.

This attempted to write record number undefined in the player file,
which threw an exception.  Since exceptions are being caught, logged,
and ignored, this did not cause a problem, but did log an error when
it wasn't necessary.

Modified Files:


xtrn/lord2/l2lib.js
diff

Initialize v variables to zero when creating a new world record.

This should never actually be done though since the map would be
completely empty.

Modified Files:


xtrn/lord2/lord2.js
diff

Do not attempt to list online players who are not on a valid map location

Prevents a who's online list from aborting early when it encounters
and invalid player record.

Modified Files:


src/sbbs3/js_global.c
diff

Properly handle CSI m in html_encode()

Used by gcc in warnings.

Modified Files:


src/syncterm/conn_telnet.c
diff

telnet_interpret() can grow th input buffer by a byte.

If a '\r' is the last thing in the previous receive buffer.

Modified Files:


src/sbbs3/websrvr.c
diff

post_to_file() shouldn't close the file since it didn't open it.

Modified Files:


src/xpdev/sockwrap.c
diff

Properly set buffer size when calling getsockopt()

Modified Files:


src/xpdev/multisock.c
diff

Return an error if calloc() fails allocating pollfd array.

Modified Files:


src/xpdev/sockwrap.c
diff

We still need to peek a byte to tell that recv is done with poll()

Not all implementations set POLLHUP when a TCP socket is half-closed.