Synchronet Git Commit Log

This is a log of the 500 most recent pushes to the master branch of the Synchronet Git repository.
If you want to view more pushes/commits, you can by passing ?<number> in URL.
  1. Eric Oulashin
    Mon Dec 05 2022 11:07:33 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    DD file lister: lfexpand() seems to do what I wrote my own function for in the last commit

  2. Rob Swindell
    Mon Dec 05 2022 11:27:03 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    Merge branch 'ddfilelister_lfexpand' into 'master' DD file lister: lfexpand() seems to do what I wrote my own function for in the last commit See merge request main/sbbs!231

  3. Rob Swindell
    Mon Dec 05 2022 11:02:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    src/xpdev/str_list.c diff
    src/xpdev/str_list.h diff
    Include blank lines in messages edited with internal editor Needed a version of strListSplit() that doesn't treat consecutive delimiters (e.g. "\r\n\r\n") as a single delimiter: so introducing strListDivide(). Like strListSplit(), strListDivide() modifies the input string (replacing first occurrences of delimiter with NUL). Since we don't want "\r\n" to be counted as 2 lines, we need to just split/divide on '\n' and then truncate any line endings (i.e. '\r') chars off the ends of the split strings. Reported by phigan in #synchronet

  4. Eric Oulashin
    Sat Dec 03 2022 13:39:02 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DD File lister: Extended file info update (# times DL'd, last DL, description fix for some cases)

  5. Rob Swindell
    Sat Dec 03 2022 13:39:02 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_extended_info_update' into 'master' DD File lister: Extended file info update (# times DL'd, last DL, description fix for some cases) See merge request main/sbbs!229

  6. Rick Parrish
    Sat Dec 03 2022 13:21:13 GMT-0800 (PST)
    Modified Files:
    

    webv4/pages/003-games.xjs diff
    Ree/games fixes

  7. Rob Swindell
    Sat Dec 03 2022 13:21:13 GMT-0800 (PST)
    Modified Files:
    

    webv4/pages/003-games.xjs diff
    Merge branch 'ree/games-fixes' into 'master' Ree/games fixes See merge request main/sbbs!230

  8. Eric Oulashin
    Fri Dec 02 2022 16:04:33 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader v1.57: @-code expansion only when sender is a sysop (and only when reading personal email)

  9. Rob Swindell
    Fri Dec 02 2022 16:04:33 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_additional_atcode_expand_security' into 'master' DDMsgReader v1.57: @-code expansion only when sender is a sysop (and only when reading personal email) See merge request main/sbbs!228

  10. Eric Oulashin
    Fri Dec 02 2022 11:48:11 GMT-0800 (PST)
    Modified Files:
    

    docs/SlyEdit_ReadMe.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit v1.82: Added some safety checks when reading the configuration file (that section of code was refactored recently).

  11. Rob Swindell
    Fri Dec 02 2022 11:48:11 GMT-0800 (PST)
    Modified Files:
    

    docs/SlyEdit_ReadMe.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_read_config_safety_checks' into 'master' SlyEdit v1.82: Added some safety checks when reading the configuration file (that section of code was refactored recently). See merge request main/sbbs!227

  12. rickparrish
    Mon Nov 28 2022 08:40:52 GMT-0800 (PST)
    Modified Files:
    

    webv4/pages/003-games.xjs diff
    Resize fTelnet for msweeper to support level 5

  13. Rob Swindell
    Thu Dec 01 2022 15:52:32 GMT-0800 (PST)
    Modified Files:
    

    webv4/pages/003-games.xjs diff
    Merge branch 'msweeper-level-5' into 'master' Resize fTelnet for msweeper to support level 5 See merge request main/sbbs!225

  14. rickparrish
    Sun Nov 27 2022 11:25:09 GMT-0800 (PST)
    Modified Files:
    

    webv4/pages/001-forum.ssjs diff
    Display error if user can't read requested sub

  15. Rob Swindell
    Thu Dec 01 2022 12:55:46 GMT-0800 (PST)
    Modified Files:
    

    webv4/pages/001-forum.ssjs diff
    Merge branch 'cant-read-sub' into 'master' Display error if user can't read requested sub See merge request main/sbbs!223

  16. Rob Swindell
    Tue Nov 29 2022 10:56:27 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/un_qwk.cpp diff
    src/sbbs3/un_rep.cpp diff
    Bug-fix: erroneously filtering vote messages by age This bug was introduced in commit 9c91d32a8617 2 years ago and would result in votes and poll message being erroneously filtered. e.g. !Filtering QWK message from (null) due to age: 19321 days The filter criteria was either a zero-initialized msg or the previously parsed/imported msg from the QWK or REP packet. A solution for filtering vote/poll messages is needed, but this isn't it.

  17. Rob Swindell
    Mon Nov 28 2022 12:56:07 GMT-0800 (PST)
    Modified Files:
    

    exec/load/binkp.js diff
    Use socket.poll() to check socket for writability before send() This is the real fix for infinite-wait on send() problem that was attempted in commit f0127e9d457, but caused other issues. Thanks Deuce.

  18. Rob Swindell
    Mon Nov 28 2022 12:18:16 GMT-0800 (PST)
    Modified Files:
    

    exec/load/binkp.js diff
    More errno details in file open and socket-send failure warning log msgs

  19. Rob Swindell
    Mon Nov 28 2022 11:01:10 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_socket.c diff
    Revert "Check socket writability in JS Socket.send()" This reverts commit f0127e9d4572f8c1c44536dcda240c310e18f7d8. This change was "wrong-headed" per Deuce and broke JS sends on blocking sockets. Thanks for the help. This fix for inifinite-wait on send() likely led to the infinite BinkIT errors/log messages that led to commit 4dd32231. The real fix for this problem (which can block all other timed events from running), would be a Socket.poll() on the socket before send in binkp.js.

  20. Eric Oulashin
    Sun Nov 27 2022 11:55:29 GMT-0800 (PST)
    Modified Files:
    

    ctrl/SlyEdit.cfg diff
    docs/SlyEdit_ReadMe.txt diff
    Updated the SlyEdit documentation for version 1.81 (forgot yesterday). Also updated the default SlyEdit.cfg to use the English dictionary (for spell check).

  21. Rob Swindell
    Sun Nov 27 2022 12:27:03 GMT-0800 (PST)
    Modified Files:
    

    ctrl/SlyEdit.cfg diff
    docs/SlyEdit_ReadMe.txt diff
    Merge branch 'slyedit_181_doc_update' into 'master' Updated the SlyEdit documentation for version 1.81 (forgot yesterday). Also updated the default SlyEdit.cfg to use the English dictionary (for spell check). See merge request main/sbbs!224

  22. Eric Oulashin
    Sat Nov 26 2022 11:12:05 GMT-0800 (PST)
    Modified Files:
    

    ctrl/SlyDCTColors_Default.cfg diff
    ctrl/SlyDCTColors_Midnight.cfg diff
    ctrl/SlyIceColors_BlueIce.cfg diff
    ctrl/SlyIceColors_EmeraldCity.cfg diff
    ctrl/SlyIceColors_FieryInferno.cfg diff
    ctrl/SlyIceColors_Fire-N-Ice.cfg diff
    ctrl/SlyIceColors_GeneralClean.cfg diff
    ctrl/SlyIceColors_GenericBlue.cfg diff
    ctrl/SlyIceColors_PurpleHaze.cfg diff
    ctrl/SlyIceColors_ShadesOfGrey.cfg diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: No more control characters needed in the color configuration files

  23. Rob Swindell
    Sat Nov 26 2022 15:37:45 GMT-0800 (PST)
    Modified Files:
    

    ctrl/SlyDCTColors_Default.cfg diff
    ctrl/SlyDCTColors_Midnight.cfg diff
    ctrl/SlyIceColors_BlueIce.cfg diff
    ctrl/SlyIceColors_EmeraldCity.cfg diff
    ctrl/SlyIceColors_FieryInferno.cfg diff
    ctrl/SlyIceColors_Fire-N-Ice.cfg diff
    ctrl/SlyIceColors_GeneralClean.cfg diff
    ctrl/SlyIceColors_GenericBlue.cfg diff
    ctrl/SlyIceColors_PurpleHaze.cfg diff
    ctrl/SlyIceColors_ShadesOfGrey.cfg diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_color_cfg_no_more_control_chars' into 'master' SlyEdit: No more control characters needed in the color configuration files See merge request main/sbbs!222

  24. Eric Oulashin
    Sat Nov 26 2022 15:37:16 GMT-0800 (PST)
    Added Files:
    

    xtrn/gttrivia/lib.js diff
    xtrn/gttrivia/server/commands.js diff
    xtrn/gttrivia/server/service.js diff
    Modified Files:

    xtrn/gttrivia/gttrivia.ini diff
    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/qa/dirty_minds.qa diff
    xtrn/gttrivia/qa/general.qa diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Good Time Trivia: Hosted inter-BBS user scores (via JSON DB) is now possible.

  25. Rob Swindell
    Sat Nov 26 2022 15:37:17 GMT-0800 (PST)
    Added Files:
    

    xtrn/gttrivia/lib.js diff
    xtrn/gttrivia/server/commands.js diff
    xtrn/gttrivia/server/service.js diff
    Modified Files:

    xtrn/gttrivia/gttrivia.ini diff
    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/qa/dirty_minds.qa diff
    xtrn/gttrivia/qa/general.qa diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Merge branch 'gttrivia_hosted_scores' into 'master' Good Time Trivia: Hosted inter-BBS user scores (via JSON DB) is now possible. See merge request main/sbbs!221

  26. Rick Parrish
    Fri Nov 25 2022 23:53:52 GMT-0800 (PST)
    Modified Files:
    

    webv4/pages/000-register.xjs diff
    webv4/root/api/register.ssjs diff
    Update registration page for closed and newuser password systems

  27. Rob Swindell
    Fri Nov 25 2022 23:53:52 GMT-0800 (PST)
    Modified Files:
    

    webv4/pages/000-register.xjs diff
    webv4/root/api/register.ssjs diff
    Merge branch 'master' into 'master' Update registration page for closed and newuser password systems See merge request main/sbbs!219

  28. Eric Oulashin
    Fri Nov 25 2022 16:35:18 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DD Message Reader: Fixed bug startup mode for scanning all groups for un-read messages to you where the reader was bringing up personal email instead.

  29. Rob Swindell
    Fri Nov 25 2022 16:41:18 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_unread_to_you_scan_fix' into 'master' DD Message Reader: Fixed bug startup mode for scanning all groups for un-read messages to you where the reader was bringing up personal email instead. See merge request main/sbbs!220

  30. Rob Swindell
    Tue Nov 22 2022 18:31:46 GMT-0800 (PST)
    Modified Files:
    

    xtrn/minesweeper/minesweeper.js diff
    Export high scores to message base with "export" command-line option A periodic (e.g. weekly) digest of high scores posted to SYNCDATA will allow BBSes to have an accurate list of global high scores without requiring the retention of several years of SYNCDATA messages. Also, made the necessary changes to allow: 'jsexec minesweeper.js export' (for testing, primarily) When posting an exception report, post from sysop if user.alias is undefined. Incremented revision to 2.15 (though there were no game-play changes).

  31. Rob Swindell
    Tue Nov 22 2022 18:31:46 GMT-0800 (PST)
    Modified Files:
    

    xtrn/minesweeper/install-xtrn.ini diff
    xtrn/minesweeper/readme.txt diff
    Install high scores timed event (new to rev 2.15).

  32. Rob Swindell
    Tue Nov 22 2022 18:31:46 GMT-0800 (PST)
    Modified Files:
    

    xtrn/minesweeper/readme.txt diff
    Fixed typo

  33. Rob Swindell
    Tue Nov 22 2022 18:31:46 GMT-0800 (PST)
    Modified Files:
    

    xtrn/minesweeper/minesweeper.js diff
    Fix improper use of list_contains() which caused dupe winners to display De-duplication wasn't working

  34. Rob Swindell
    Sun Nov 20 2022 15:27:04 GMT-0800 (PST)
    Modified Files:
    

    .gitattributes diff
    Add display files (*.ans, *.asc, *.msg) as text with CRLF EOLs Fix issue #457 May as specify that .asc and .msg are text too, though no known reason why CRLF EOLs may be more desireable.

  35. Rob Swindell
    Sat Nov 19 2022 17:00:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_msgbase.c diff
    Fix return return value when methods auto-open a message base (e.g. save_msg()) js_open() sets the rval for the context (e.g. to JSVAL_TRUE), so we need to set it back to JSVAL_FALSE for failure conditions. Otherwise, the methods always return true even upon (save-msg) failure.

  36. Rob Swindell
    Sat Nov 19 2022 13:20:37 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Correct node number *always* before clearning NODE_RRUN [R] status flag If nodeX/node.cnf has the wrong node number, the [R] flag would be cleared from the wrong node upon automatic configuration reload. This likely fixes the issue that Keyop is reporting in #synchronet

  37. Eric Oulashin
    Fri Nov 18 2022 18:17:45 GMT-0800 (PST)
    Added Files:
    

    xtrn/gttrivia/gttrivia.asc diff
    xtrn/gttrivia/gttrivia.ini diff
    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/install-xtrn.ini diff
    xtrn/gttrivia/qa/converter.js diff
    xtrn/gttrivia/qa/dirty_minds.qa diff
    xtrn/gttrivia/qa/general.qa diff
    xtrn/gttrivia/qa/music_movies_and_entertainment.qa diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    This is a new trivia door, Good Time Trivia, written in JavaScript

  38. Rob Swindell
    Fri Nov 18 2022 18:17:45 GMT-0800 (PST)
    Added Files:
    

    xtrn/gttrivia/gttrivia.asc diff
    xtrn/gttrivia/gttrivia.ini diff
    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/install-xtrn.ini diff
    xtrn/gttrivia/qa/converter.js diff
    xtrn/gttrivia/qa/dirty_minds.qa diff
    xtrn/gttrivia/qa/general.qa diff
    xtrn/gttrivia/qa/music_movies_and_entertainment.qa diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Merge branch 'gttrivia_new' into 'master' This is a new trivia door, Good Time Trivia, written in JavaScript See merge request main/sbbs!217

  39. Deucе
    Tue Nov 15 2022 14:46:56 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    src/syncterm/conn.c diff
    src/syncterm/conn.h diff
    src/syncterm/menu.c diff
    src/syncterm/modem.c diff
    src/syncterm/term.c diff
    Add new 3-wire (No RTS) connection type This is for weird embedded systems where RTS is not supported by the communications channel, but is actually controlling something else (TX, Bootloader update mode, etc).

  40. Rob Swindell
    Mon Nov 07 2022 21:46:02 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'dd_msg_area_chooser_posts_and_numeric_input_bugfix' into 'master' DD message area chooser only: Bug fixes for numeric input in lightbar mode and number of posts in traditional mode See merge request main/sbbs!216

  41. Eric Oulashin
    Mon Nov 07 2022 21:46:02 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    DD message area chooser only: Bug fixes for numeric input in lightbar mode and number of posts in traditional mode

  42. Deucе
    Mon Nov 07 2022 15:05:12 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    Whops, missed this commit.

  43. Eric Oulashin
    Fri Nov 04 2022 22:34:44 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Message area chooser only: Made use of the 'posts' property for the number of messages (without vote headers)

  44. Rob Swindell
    Fri Nov 04 2022 22:34:44 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'dd_msg_area_chooser_posts_property' into 'master' Message area chooser only: Made use of the 'posts' property for the number of messages (without vote headers) See merge request main/sbbs!215

  45. Rob Swindell
    Fri Nov 04 2022 10:15:59 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/binkp.js diff
    Resolve undetected or infinitely-retried socket-send failures My hub (1:218/700) is currently having what appears to be a TCP/IP connectivity issue that was resulting in infinite "Send failure" log messages and "We got an M_EOB, but there are still N files pending M_GOT" log messages. I first added better socket-send failure detection (checking return value of sendCmd() and sendData() where needed) and then noticed that failure to send a file was not detected (the sending.file.position is advanced even if sendData() fails), so now handling that condition too. Also added more diagnostics around socket-send failures (is socket writable?) in this particular case, the socket is not writable and socket-send is returning 0.

  46. Rob Swindell
    Mon Oct 24 2022 15:46:59 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/postmsg.cpp diff
    Strip control chars/ctrl-A sequences from msg subject in notify() We may want Ctrl-A sequences in the telegram subject, but not in the message subject

  47. Rob Swindell
    Mon Oct 24 2022 15:48:00 GMT-0700 (PDT)
    Modified Files:
    

    exec/newuser.js diff
    More user details in the new user sysop-notification message This adds a Ctrl-A code in the notification subject, so needs latest postmsg.cpp or that Ctrl-A code will end up in your email/inbox too (not really supported or stripped when sent over POP/SMTP).

  48. Randy Sommerfeld
    Sun Oct 23 2022 18:16:59 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/ircd/unregistered.js diff
    Detect local addresses a bit better

  49. Rob Swindell
    Sun Oct 23 2022 11:28:24 GMT-0700 (PDT)
    Modified Files:
    

    exec/newuser.js diff
    Add a 'notify_sysop' option (set to true or a user number in modopts.ini) Will notify the sysop via email and telegram when a new user account has been created. For Morpheus (MORPHEUS)

  50. Rob Swindell
    Sat Oct 22 2022 19:00:40 GMT-0700 (PDT)
    Modified Files:
    

    exec/newuser.js diff
    Make the "ask qnet" language even more clear/alarmist Somehow, new users on Vertrauen *still* manage to answer "Yes" to both the QWK Networking account questions, accidentally creating a QWKnet account that's not useful for normal BBS user activities. So print a very clear "alert" style message making it even-more clear that the account they are creating will ONLY be useful for QWK Networking activities.

  51. Rob Swindell
    Sat Oct 22 2022 19:00:40 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/newuser.cpp diff
    Don't complain about lack of comma in new user's location ... unless a comma is actually required.

  52. Rob Swindell
    Sat Oct 22 2022 11:02:17 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ansiterm.cpp diff
    Fix CID 319174 (Out-of-bounds write) correctly This Coverity reported issue was previously resolved (incorrectly) with commit 0c441424 which also introduced a bug that ate all the unexpected cursor position report characters (causing issue #304). The correct fix was to compare the response length against the buffer size minus one, to leave room for the NUL terminator. While fixing this and issue #304, I noticed that this function was using the response length ('rsp') as both the state machine state and string length, which didn't work right if a nearly-matching report/response was received: the x/y values would have been stripped from the response before stuffing in the keyboard input buffer. So a bit of a refactor here using a proper state machine variable.

  53. Rob Swindell
    Fri Oct 21 2022 12:03:14 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    Fix-up the recently-added debug/error log messages I didn't look closely enough at which write() call I was instrumenting. This is now more useful, though I think we already found the root-cause based on different log output ("Unexpected ansi_getxy response").

  54. Rob Swindell
    Fri Oct 21 2022 12:04:41 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ansiterm.cpp diff
    Fix lost 'unexpected characters' received in ANSI get cursor position response Unexpected characters received (maybe typed by the user) were supposed to be stuffed in the keyboard input buffer using ungetstr(), but the input string was cleared rather than NUL-terminated before logging the expected character and calling ungetstr(), so nothing (a blank string) was logged and nothing was stuffed in the keyboard input-buffer in this case. Just an off-by-one bug. This should fix issue #304. Thanks to Keyop and Nelgin for their persistence in reporting and testing (in #synchronet at irc.synchro.net).

  55. Rob Swindell
    Thu Oct 20 2022 20:56:34 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    Don't log debug msgs when reading 0 (\x00) from chat.dab file, expected This just resulted in a lot of unhelpful noise in the log output

  56. Rob Swindell
    Thu Oct 20 2022 20:37:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    Add error and debug level log messages to private chat When reading and writing characters to chat files, log each with a debug-level log message. If a read or a write fails, log with an error-level log message. This will hopefully help root-cause and resolve issue #304.

  57. Rob Swindell
    Wed Oct 19 2022 20:35:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/asc2ans.c diff
    Update comment header block

  58. Rob Swindell
    Wed Oct 19 2022 20:29:08 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_server.c diff
    Clean up comment header block

  59. Rob Swindell
    Wed Oct 19 2022 14:23:17 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    src/sbbs3/js_msgbase.c diff
    Fix JSDOC typos

  60. Deucе
    Wed Oct 12 2022 11:04:58 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/cterm.c diff
    Continue fixing a coverity issue.

  61. Rob Swindell
    Mon Oct 10 2022 17:08:11 GMT-0700 (PDT)
    Modified Files:
    

    src/comio/comio.h diff
    src/comio/comio_win32.c diff
    Add comDrainOutput() for Win32 Untested, but matches implementation from https://github.com/veeso/termiWin/blob/master/src/termiWin.c and declare function in comio.h

  62. Rob Swindell
    Mon Oct 10 2022 15:13:12 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/netmail.cpp diff
    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    Use nearest-zone matching for source FTN address when replying to netmail Rather than only matching exact zone numbers as a final "nearest" address search, use a "nearest zone" matching algorithm ("nearest" being the most mathematically near). This way, replying to netmail from a zone 2 address would always match a zone 1 source address, regardless of how many othernet addresses are configured and which order they are configured in SCFG. Fixes issue #447 reported by Charles Blackburn (FBOBBS)

  63. Rob Swindell
    Sat Oct 08 2022 20:02:14 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Don't require USE_DOSEMU for DOS-compatible drive mappings in xtrn.dat We no longer use/require the USE_DOSEMU definition anywhere else, so this was just a miss when the DOSEMU patch was perm-enabled.

  64. Deucе
    Sat Oct 08 2022 12:14:57 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/netwrap.h diff
    Fix warning anywhere netwrap.h is included before sockwrap.h sbbs3/../xpdev/netwrap.h:45:27: warning: 'parseIPv6Address' has C-linkage specified, but returns incomplete type 'struct in6_addr' which could be incompatible with C [-Wreturn-type-c-linkage] DLLEXPORT struct in6_addr parseIPv6Address(const char*); ^

  65. Deucе
    Sat Oct 08 2022 12:05:48 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/cterm.c diff
    src/syncterm/bbslist.c diff
    src/syncterm/ripper.c diff
    src/syncterm/rlogin.c diff
    src/syncterm/term.c diff
    Update to new Coverity Scan, fix new High impact issues New Medium impact and a low impact issue still needs to be triaged.

  66. Rob Swindell
    Fri Oct 07 2022 18:31:59 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    When user hangs-up on external programs on *nix, try to terminate w/SIGTERM Previously, when a user disconnected or ran out of time while running a stdio-based external program on *nix, if the program was still running, we'd send it a SIGHUP, wait up to 10 seconds for the process to terminate and if it did not, terminate it (ungracefully) with SIGKILL. Since some programs catch SIGTERM (and not SIGHUP) to indicate a termination request, we now will first attempt a SIGHUP, wait up to 5 seconds for the process to terminate and if it does not, then send a SIGTERM and wait up to another 5 seconds for it to terminate and if it doesn't, then finally send it a SIGKILL (which cannot be caught and always results in an ungraceful termination of the child process). This doesn't resolve any specific problem with any specific stdio-based external program, but I was playing around with ESR's port of Adventure (https://gitlab.com/esr/open-adventure) and a new auto-save/restore of game state and noticed that we weren't using SIGTERM for this situation, though we should have. Most modern programs, if they catch SIGHUP at all, use it to indicate a refresh of configuration or data files, not a termination request (or indication that a user has "hung up"). So SIGTERM is more reasonable to be expected to be caught and initiate the graceful termination of the child program that we're hoping for.

  67. Rob Swindell
    Thu Oct 06 2022 19:10:37 GMT-0700 (PDT)
    Modified Files:
    

    exec/letsyncrypt.js diff
    Recycle all servers/services after updating certificate Per Deon (ALTERANT) via DOVE-Net: Oct 7 09:47:16 d-11-1 synchronet: srvc 0060 BINKPS connection accepted from: 2402:1f00:8101:b3c:1000::2 port 55338 Oct 7 09:47:16 d-11-1 synchronet: srvc 0060 BINKPS TLS ERROR 'Server certificate has expired' (-3) setting private key Oct 7 09:47:16 d-11-1 synchronet: srvc 0060 BINKPS TLS ERROR 'Data has not been initialised' (-11) setting session active Which was odd, because my cert was renewed. I forced renewed it, and confirmed it was valid, but they were still failing. I noticed that letsyncrypt only recycles the web, which is probably the issue. Once I recycled everything, binkps connections started working again.

  68. Rob Swindell
    Tue Oct 04 2022 14:27:44 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_socket.c diff
    Check socket writability in JS Socket.send() BINKP is suddenly frequently hanging on sendsocket() on Vertrauen on Windows (sending files to my Z1 hub) so try this as a solution.

  69. Deucе
    Thu Sep 29 2022 15:38:40 GMT-0700 (PDT)
    Modified Files:
    

    exec/imapservice.js diff
    Handle invalid credentials in imapservice Fixes #401

  70. Deucе
    Thu Sep 29 2022 15:35:11 GMT-0700 (PDT)
    Modified Files:
    

    exec/lbshell.js diff
    Check undefined. Fixes #368

  71. Eric Oulashin
    Fri Sep 23 2022 21:29:58 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: Added a mouse click hotspot for ? for message list mode

  72. Rob Swindell
    Fri Sep 23 2022 21:29:58 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_msg_list_help_hotspot' into 'master' DDMsgReader: Added a mouse click hotspot for ? for message list mode See merge request main/sbbs!210

  73. Eric Oulashin
    Fri Sep 23 2022 15:19:46 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Refactored how email replies are done (passing the header to the appropriate functions, not using ungetstr() when prompting for the message subject

  74. Rob Swindell
    Fri Sep 23 2022 15:19:47 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_email_reply_update' into 'master' DDMsgReader: Refactored how email replies are done (passing the header to the appropriate functions, not using ungetstr() when prompting for the message subject See merge request main/sbbs!209

  75. Rob Swindell
    Fri Sep 16 2022 18:52:52 GMT-0700 (PDT)
    Modified Files:
    

    exec/chksetup.js diff
    Check user #1 (sysop) exemptions and restrictions against expectations

  76. Rob Swindell
    Fri Sep 16 2022 18:53:50 GMT-0700 (PDT)
    Modified Files:
    

    exec/testbuild.js diff
    Need to manually run gitinfo.bat

  77. Rob Swindell
    Fri Sep 16 2022 18:54:58 GMT-0700 (PDT)
    Modified Files:
    

    exec/freqitcfg.js diff
    Insure call to uifc.bail() when exiting

  78. Rob Swindell
    Fri Sep 16 2022 18:55:23 GMT-0700 (PDT)
    Modified Files:
    

    exec/ircmsg.js diff
    Extra message delivery insurance as recommended by Cyan months ago

  79. Rob Swindell
    Fri Sep 16 2022 18:55:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/addfiles.js diff
    Document -auto option

  80. Rob Swindell
    Fri Sep 16 2022 18:30:12 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    qhub_t node->node_num naming to more consistent with other objs

  81. Rob Swindell
    Fri Sep 16 2022 16:45:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Fix crash when cleanup() was called twice in a row, e.g. load_cfg failure Need to nullify the xpms after destroying/freeing (as is done in other servers already).

  82. Rob Swindell
    Thu Sep 15 2022 20:19:00 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    Add new/missing 'errlevel' field for timed events

  83. Eric Oulashin
    Fri Sep 09 2022 20:51:50 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Removed temporary debug code that accidentally made it in last commit

  84. Rob Swindell
    Sun Sep 11 2022 15:53:25 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_remove_temp_debug_code' into 'master' Removed temporary debug code that accidentally made it in last commit See merge request main/sbbs!208

  85. Rob Swindell
    Sat Sep 10 2022 17:14:03 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/viewfile.cpp diff
    viewfile() now uses case-corrected file path Sometimes files uploaded may have the wrong case in the filebase (a different unresolved issue), but for instances where that has happened, make those files viewable in sbbs. This really only impacts target OSes with case-sensitive file systems (e.g. *nix).

  86. Rob Swindell
    Fri Sep 02 2022 18:50:36 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    Fix negative MSG_SCORE @-code on 64-bit (*nix) builds As reported by Android8675 (SHODAN) on DOVE-Net. This problem did not manifest itself in 32-bit builds.

  87. Rob Swindell
    Sun Aug 21 2022 18:35:32 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/services.c diff
    Improve JavaScript-related error messages and fix potential JS runtime leak If a new JS context could not be created for any reason, a JS runtime would still be allocated (and leaked), potentially leading to out of memory situations which had been seen (before this change) on vert.synchro.net.

  88. Rob Swindell
    Sun Aug 21 2022 18:35:32 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Improve JavaScript-related error messages

  89. Eric Oulashin
    Fri Aug 19 2022 18:08:07 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Set the control key pass-thru so that some hotkeys (such as Ctrl-P for PageUp) only get caught by the scripts.

  90. Rob Swindell
    Fri Aug 19 2022 18:48:11 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'DD_area_choosers_ctrl_key_passthru' into 'master' Set the control key pass-thru so that some hotkeys (such as Ctrl-P for PageUp) only get caught by the scripts. See merge request main/sbbs!207

  91. Rob Swindell
    Sat Aug 13 2022 14:03:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/MainFormUnit.cpp diff
    src/sbbs3/nopen.c diff
    src/sbbs3/nopen.h diff
    fwritelog() will now auto-close a log file when it reaches the max size

  92. Rob Swindell
    Sat Aug 13 2022 00:24:17 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/nopen.c diff
    src/sbbs3/nopen.h diff
    Create fwritelog() to go along with fopenlog() and fcloselog() The functions aren't DLL-exported, so the difference in FILE* support between an app and a library is not an issue... yet, but it could be someday, so just for good measure.

  93. Rob Swindell
    Sat Aug 13 2022 00:35:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/MainFormUnit.cpp diff
    src/sbbs3/ctrl/MainFormUnit.dfm diff
    src/sbbs3/ctrl/MainFormUnit.h diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.h diff
    src/sbbs3/ctrl/sbbsctrl.bpr diff
    Add "Log Events to Disk" option/checkbox for terminal server "Events" The "Events" log messages will now be logged to a disk file in data/events*.log by default (unless this option is disabled). If the "First node" is > 1, then the base filename will be "events<first-node>", otherwise, it's just "events". This is because you would not want multiple instances of sbbs writing to the same events.log file - that would be chaos. These log files are subject the log rotation/retention policy defined in SCFG. This should resolve the FAQ for Windows sysops about what log file to which their event log messages are being written.

  94. Rob Swindell
    Thu Aug 11 2022 12:20:08 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    matchuser() now always returns 0 when passed an empty 'name' Also, don't match against deleted (blank) usernames in name.dat (e.g. when 'name' value consists of a single ETX character).

  95. Rob Swindell
    Tue Aug 09 2022 20:57:38 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    For SIF output file (SOF) code to upper case

  96. Rob Swindell
    Tue Aug 09 2022 19:37:37 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Log message improvements: include protocol (HTTP vs HTTPS) and IP address

  97. Eric Oulashin
    Mon Aug 08 2022 20:03:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    Used js.on_exit() to set console.ctrlkey_passthru back on exit properly (SlyEdit, DDMsgReader) and bbs.sys_status (SlyEdit)

  98. Rob Swindell
    Mon Aug 08 2022 21:27:46 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'slyedit_ddmsgreader_js_on_exit_ctrl_passthru_sys_status' into 'master' Proper use of js.on_exit() in DDMsgReader and SlyEdit See merge request main/sbbs!206

  99. Eric Oulashin
    Sun Aug 07 2022 19:01:19 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader v1.54: Users now have a personal twit list (configurable via Ctrl-U, user settings).

  100. Rob Swindell
    Sun Aug 07 2022 19:01:19 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_personal_twit_list' into 'master' DDMsgReader v1.54: Users now have a personal twit list (configurable via Ctrl-U, user settings). See merge request main/sbbs!205

  101. Rob Swindell
    Thu Aug 04 2022 18:24:35 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    Updates to xedit_t and xtrnsec_t definitions (out of date)

  102. Rob Swindell
    Wed Aug 03 2022 20:59:41 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgchat.c diff
    Fix crash when a chat channel references an invalid chat action set When there are no chat action sets or an action set has been deleted, bad things would happen (e.g. segfault) when listing chat channels.

  103. Rob Swindell
    Wed Aug 03 2022 18:09:35 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Update log messages for execle() or fork() failures To be more consistent in syntax and include more details (e.g. the command being invoked).

  104. Rob Swindell
    Tue Aug 02 2022 17:20:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Check max_files value in extract_files_from_archive() better Address issue reported by Nightfox via DOVE-Net: Today I was using the Archive class to extract exactly one file from a zip file, and I'm a little confused on the exception throwing behavior regarding the max_files parameter. When calling extract(), I gave it a filename pattern and expected exactly 1 file to be extracted, so I also gave a max_files argument as 1. It extracted the one file, but it threw an exception with the error "Error: maximum number of files (1) extracted (after extracting 1 item successfully)". Should that be an error condition to throw an exception? I expected 1 file to be extracted, and that file was extracted successfully. If I specify max_files as 2, then it doesn't throw an exception.

  105. Rob Swindell
    Sat Jul 23 2022 15:21:37 GMT-0700 (PDT)
    Modified Files:
    

    exec/sbbslist.js diff
    Update logic for deciding if user can delete/edit entries Local sysop can always deleted/edit entries (now). Fixed checking of can_edit() return value (string or true), fixed issue #425 as reported by Craig Hendricks (thank you)

  106. Eric Oulashin
    Mon Jul 18 2022 20:31:08 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Deleted messages can now be un-marked for deletion from the message list with the U key (if the user has delete permissions). Also, the reader now honors the system setting for whether users can view deleted messages.

  107. Rob Swindell
    Sat Jul 23 2022 14:59:21 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_undelete_msgs' into 'master' DDMsgReader: Deleted messages can now be un-marked for deletion from the message list with the U key (if the user has delete permissions). Also, the reader now honors the system setting for whether users can view deleted messages. See merge request main/sbbs!203

  108. Eric Oulashin
    Sat Jul 23 2022 13:13:11 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    DD area choosers: Updated the lightbar help text to be more consistent with DDMsgReader

  109. Rob Swindell
    Sat Jul 23 2022 14:59:12 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    Merge branch 'dd_area_choosers_lightbar_help_rearrange' into 'master' DD area choosers: Updated the lightbar help text to be more consistent with DDMsgReader See merge request main/sbbs!204

  110. Rob Swindell
    Sat Jul 16 2022 17:41:05 GMT-0700 (PDT)
    Modified Files:
    

    exec/xtrn_sec.js diff
    Don't treat Enter as choosing default section when no prompt was shown As pointed out via DOVE-Net by DesotoFireflite (VALHALLA): When xtrn_sec.* display file/menu is used, there's no auto-generated prompt (with a default section number indicated). So hitting Enter in this case and having the previous/default program section selected would be surprising behavior to a user. So, only support a default section selection when there was no xtrn_sec.* menu/display file.

  111. Rob Swindell
    Thu Jul 14 2022 17:52:24 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnflib.js diff
    Strip 0xff chars from strings read from .cnf files Some unused/padding bytes are written as 0xff, so don't build strings from those chars.

  112. Rob Swindell
    Wed Jul 13 2022 23:24:56 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc32.c diff
    Don't print the up arrow if the list is empty

  113. Rob Swindell
    Wed Jul 13 2022 23:26:07 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    Support the old 32-bit free-credits-per-day field, for upgrading old cnf files

  114. Rob Swindell
    Wed Jul 13 2022 23:32:53 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Don't allow strings that contain 0xFF (truncate at this char value) 1. It's a non-printable char 2. It's the Telnet IAC byte value 3. CNF files use this as an "uninitialized value" indicator

  115. Rob Swindell
    Sun Jul 10 2022 14:25:53 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Eliminate newly-unused variable: addr_str Fixes issue #421

  116. Eric Oulashin
    Sat Jul 09 2022 19:12:06 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Mouse click support for the bottom help lines in scrollable mode (thanks to help from Nelgin)

  117. Rob Swindell
    Sat Jul 09 2022 19:12:06 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_scrollable_mouse_click_hotspots' into 'master' DDMsgReader: Mouse click support for the bottom help lines in scrollable mode (thanks to help from Nelgin) See merge request main/sbbs!202

  118. Rob Swindell
    Fri Jul 08 2022 16:43:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    src/xpdev/netwrap.c diff
    Don't use inet_ntop() on Windows as XP didn't include it As reported by cadeon on Vertrauen, Synchronet v3.19 hasn't worked on Windows XP due to error: 'The procedure entry point inet_ntop could not be located in the dynamic link library WS2_32.dll'

  119. Rob Swindell
    Fri Jul 08 2022 16:43:49 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/win32.release/libarchive/bin/archive.dll diff
    libarchive v3.5.1 built for Windows without bcrypt.dll dependency Accomplished by manually removing #define HAVE_BCRYPT_H 1 from config.h and rebuilding using MSVC/Visual Studio IDE. Try as I might I couldn't get the CMakeLists.txt changes (e.g. setting ENABLE_CNG to OFF) to take effect, but this seems to have worked. Why? Because Windows XP didn't include bcrypt.dll (a Microsoft DLL) and we don't really need it as we don't support password-protected ZIP files anyway. <shrug>

  120. Eric Oulashin
    Thu Jul 07 2022 16:45:05 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/SlyEdit.cfg diff
    Changed the saveColorsAsANSI value to false. Synchronet does not word-wrap messages with ANSI.

  121. Rob Swindell
    Thu Jul 07 2022 18:05:05 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/SlyEdit.cfg diff
    Merge branch 'slyedit_cfg_save_attrs_as_ansi_false' into 'master' SlyEdit.cfg: Changed the saveColorsAsANSI value to false. Synchronet does not word-wrap messages with ANSI. See merge request main/sbbs!200

  122. Eric Oulashin
    Thu Jul 07 2022 17:00:36 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Fixed a few errors (a couple related to "use strct", and a couple new errors related to deleting a message, upvoting, and viewing tallies).

  123. Rob Swindell
    Thu Jul 07 2022 18:04:55 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_fix_errors_deleting_upvoting_view_tallies' into 'master' DDMsgReader: Fixed a few errors (a couple related to "use strct", and a couple new errors related to deleting a message, upvoting, and viewing tallies). See merge request main/sbbs!201

  124. Rob Swindell
    Thu Jul 07 2022 11:57:40 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/modopts.ini diff
    Disable web new user registrations by default to match wiki http://wiki.synchro.net/config:webv4

  125. Eric Oulashin
    Thu Jul 07 2022 09:17:28 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: Fix for undeclared variable assignment when saving a message to the BBS machine

  126. Rob Swindell
    Thu Jul 07 2022 10:54:51 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_save_to_bbs_machine_undeclared_assignment_fix' into 'master' DDMsgReader: Fix for undeclared variable assignment when saving a message to the BBS machine See merge request main/sbbs!199

  127. Rob Swindell
    Wed Jul 06 2022 21:54:02 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    Better alignment of names with JS object model. Other fixes.

  128. Rob Swindell
    Wed Jul 06 2022 21:22:53 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Fix for previous commit and escaped char values > 127 (0x7F)

  129. Rob Swindell
    Wed Jul 06 2022 21:18:25 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Escape chars >= 0x7f too (DEL and ex-ASCII/UTF-8 and whatnot)

  130. Eric Oulashin
    Wed Jul 06 2022 19:55:28 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library

  131. Rob Swindell
    Wed Jul 06 2022 20:09:23 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'dd_file_area_chooser_direct_dir_lightbar_fix' into 'master' DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library See merge request main/sbbs!198

  132. Rob Swindell
    Wed Jul 06 2022 18:36:57 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/uedit/uedit.c diff
    src/sbbs3/umonitor/umonitor.c diff
    src/syncterm/syncterm.c diff
    Support the -insert (instead of overwrite kbrd mode) option in more UIFC apps I think this is what nelgin/Keyop was asking for via IRC.

  133. Rob Swindell
    Wed Jul 06 2022 18:23:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/readmsgs.cpp diff
    Fix: message numbers listed with 'H' reading msgs command Broken in commit 082a9fce 3 years ago, the 'H' (highest ranked) message listing was showing the rank of the message (e.g. 1-20) instead of the message number itself.

  134. Rob Swindell
    Wed Jul 06 2022 18:23:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Don't log error opening DOSXTRN.RET when terminating an external If we detect a client disconnection and terminate DOSXTRN.EXE, don't try to open DOSXTRN.RET and log an error when the file doesn't exist (as would be expected).

  135. Rob Swindell
    Wed Jul 06 2022 18:23:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    src/sbbs3/scfg/scfgchat.c diff
    src/sbbs3/scfg/scfgnet.c diff
    src/sbbs3/scfg/scfgsys.c diff
    src/sbbs3/scfg/scfgxfr1.c diff
    src/sbbs3/scfg/scfgxtrn.c diff
    Support left/right arrow key cycling through more multi-item menus

  136. Rob Swindell
    Tue Jul 05 2022 23:44:32 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    exec/load/cnflib.js diff
    Define structures for node.cnf

  137. Rob Swindell
    Tue Jul 05 2022 22:28:06 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    exec/load/cnflib.js diff
    Define structures for chat.cnf

  138. Rob Swindell
    Tue Jul 05 2022 21:43:06 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    A few property name updates to be more aligned with JS obj model

  139. Eric Oulashin
    Tue Jul 05 2022 19:57:31 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

  140. Rob Swindell
    Tue Jul 05 2022 19:57:32 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_strict_fixes' into 'master' DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes See merge request main/sbbs!197

  141. Rob Swindell
    Tue Jul 05 2022 15:26:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/con_out.cpp diff
    src/sbbs3/putmsg.cpp diff
    src/sbbs3/sbbs.h diff
    Support @-codes in text centered with the CENTER @-code Note: this centering logic does not know the expanded-size of the @-code, so use a fixed-length @-code (e.g. with padding) or use the 'C' @-code format modifier instead. Fix issue #418

  142. Eric Oulashin
    Tue Jul 05 2022 11:38:58 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Scrolling ANSI and "use strict" improvements Graphic is now only used when using the scrollable interface. Also, when creating the Graphic, now subtracting 1 from the reading area height to avoid making the Graphic one line too tall to avoid unnecessary scrolling. When saving messages with ANSI codes, Graphic is only used if the message has any ASCII drawing characters. (not sure if this really matters much though). Also, applied "use strict" and made some changes as necessary.

  143. Rob Swindell
    Tue Jul 05 2022 12:58:35 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_ansi_and_strict_improvements' into 'master' DDMsgReader: Scrolling ANSI and "use strict" improvements See merge request main/sbbs!195

  144. Rob Swindell
    Tue Jul 05 2022 12:23:16 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/readmsgs.cpp diff
    src/sbbs3/sbbs.h diff
    Always advance to next message after deleting a message Also, the logic to check if the user could even view deleted messages (on line 912) was wrong, replace with new method: can_view_deleted_msgs(). As requested by deon (ALTERANT).

  145. Eric Oulashin
    Mon Jul 04 2022 14:33:42 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/SlyDCTColors_Default.cfg diff
    ctrl/SlyDCTColors_Midnight.cfg diff
    ctrl/SlyEdit.cfg diff
    ctrl/SlyIceColors_BlueIce.cfg diff
    ctrl/SlyIceColors_EmeraldCity.cfg diff
    ctrl/SlyIceColors_FieryInferno.cfg diff
    ctrl/SlyIceColors_Fire-N-Ice.cfg diff
    ctrl/SlyIceColors_GenericBlue.cfg diff
    ctrl/SlyIceColors_PurpleHaze.cfg diff
    ctrl/SlyIceColors_ShadesOfGrey.cfg diff
    docs/SlyEdit_ReadMe.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    SlyEidt: Added the ability for the user to choose text color/attribute codes.

  146. Rob Swindell
    Mon Jul 04 2022 14:33:42 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/SlyDCTColors_Default.cfg diff
    ctrl/SlyDCTColors_Midnight.cfg diff
    ctrl/SlyEdit.cfg diff
    ctrl/SlyIceColors_BlueIce.cfg diff
    ctrl/SlyIceColors_EmeraldCity.cfg diff
    ctrl/SlyIceColors_FieryInferno.cfg diff
    ctrl/SlyIceColors_Fire-N-Ice.cfg diff
    ctrl/SlyIceColors_GenericBlue.cfg diff
    ctrl/SlyIceColors_PurpleHaze.cfg diff
    ctrl/SlyIceColors_ShadesOfGrey.cfg diff
    docs/SlyEdit_ReadMe.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_color_selection_update' into 'master' SlyEidt: Added the ability for the user to choose text color/attribute codes. See merge request main/sbbs!193

  147. Eric Oulashin
    Sun Jul 03 2022 16:39:57 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    DD file area chooser fix: Listing libraries without first listing directories within the user's current library (with directory collapsing) works again

  148. Rob Swindell
    Mon Jul 04 2022 14:21:55 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'dd_file_area_chooser_list_libraries_fix' into 'master' DD file area chooser fix: Listing libraries without first listing directories... See merge request main/sbbs!194

  149. Rob Swindell
    Sun Jul 03 2022 21:32:06 GMT-0700 (PDT)
    Modified Files:
    

    exec/avatar_chooser.js diff
    exec/ftn-setup.js diff
    exec/load/mouse_getkey.js diff
    exec/load/tree.js diff
    exec/xtrn-setup.js diff
    xtrn/minesweeper/minesweeper.js diff
    Use Synchronet's built-in mouse tracking support Synchronet uses "extended normal" mouse reporting for mouse support (e.g. menu/display file clickable "hot spots"). Many of the JS scripts that predated Synchronet's own internal mouse support would send their own mouse-reporting enablement and disablement ANSI sequences and the terminal could become out of sync with the expectations of the script (i.e. it would not necessarily disable the mouse modes that had been set by SBBS before enabling its own preferred mode). And some scripts (e.g. Synchronet Minesweeper) use a mixture of Synchronet hotspot support and direct mouse click coordinate reporting, so it was a mess going between different mouse reporting modes at different times in the same script. This all came to light as a result of the fix for issue #412: using mouse button releases rather than presses to trigger a hotspot. So mouse_getkey() now has as a separate "release" property it sets in the return value. Right now its always the opposite of "press", but I can imagine some mouse tracking modes where movement might be reported with neither a button press nor release event. Anyway, Nelgin, give this a try and see if it resolves the issues you were reporting in IRC with avatar chooser mouse support.

  150. Rob Swindell
    Sun Jul 03 2022 20:49:16 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    src/sbbs3/js_console.cpp diff
    src/sbbs3/sbbs.h diff
    Setting console.mouse_mode to true enables default mouse=enabled mode A single source of truth is now used for SBBS's mouse mode (MOUSE_MODE_ON). A JS script doesn't need to know what SBBS's preferred/default mouse-enabled mode flags are, just set to this property to "true". Setting to "false" is the same as setting to MOUSE_MODE_OFF (0).

  151. Rob Swindell
    Sun Jul 03 2022 16:01:58 GMT-0700 (PDT)
    Modified Files:
    

    exec/xtrn_sec.js diff
    Add a carriage-return to the mouse hotspot value when needed For program listings, if the program number is fewer digits than the total program list count (number of digits), then a carriage return is required to launch that program. Automate this for the mouse hotspot value, so clicking Program #1 in a list of 10+ will just run that program and not require the user to hit the Enter key.

  152. Rob Swindell
    Sun Jul 03 2022 15:47:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Fix smb.subnum corruption in writemsg() Fix issue introduced 9 years ago that could cause a crash after replying to a post via email or netmail and then displaying the header of a poll message or a normal message with votes: Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f9f9569a317 in sbbs_t::show_msg (this=0x7f9f70c56880, smb=0x7f9f70c5e4e0, msg=0x7f9ebadf08b0, p_mode=4, post=0x7f9f18071a24) at getmsg.cpp:255 255 ,cfg.sub[smb->subnum]->misc&SUB_ NAME ? useron.name : useron.alias, NET_NONE, NULL); [Current thread is 1 (Thread 0x7f9ebadf3700 (LWP 23279))] (gdb) print smb->subnum $1 = 4294967295 (gdb) bt #0 0x00007f9f9569a317 in sbbs_t::show_msg (this=0x7f9f70c56880, smb=0x7f9f70c5e4e0, msg=0x7f9ebadf08b0, p_mode=4, post=0x7f9f18071a24) at getmsg.cpp:255 #1 0x00007f9f957b2aee in sbbs_t::scanposts (this=0x7f9f70c56880, subnum=9, mode=2, find=0x7f9ebadf1270 "") at readmsgs.cpp:670 #2 0x00007f9f957bb75a in sbbs_t::scanallsubs (this=0x7f9f70c56880, mode=2) at scansubs.cpp:219 #3 0x00007f9f9568c948 in sbbs_t::exec_msg (this=0x7f9f70c56880, csi=0x7f9f70c64768) at execmsg.cpp:315 #4 0x00007f9f95683129 in sbbs_t::exec_function (this=0x7f9f70c56880, csi=0x7f9f70c64768) at execfunc.cpp:422 #5 0x00007f9f95679450 in sbbs_t::exec (this=0x7f9f70c56880, csi=0x7f9f70c64768) at exec.cpp:1199 #6 0x00007f9f9577d742 in node_thread (arg=0x7f9f70c56880) at main.cpp:4364 writemsg() was changing the global smb.subnum and when writing an email or netmail, that subnum value is -1 (since it's not a sub-board) and then later show_msg() is using the smb.subnum as a index into scfg.sub[] when determining if the current user already voted on the message being displayed and then: bang, crash, fall down, go boom. Simply saving and restoring the smb.subnum when executing an external editor is all that was needed here. And this is the first use of the C++ "auto" keyword in Synchronet!

  153. Rob Swindell
    Sun Jul 03 2022 15:55:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/getmsg.cpp diff
    Paranoia around use of smb.subnum as an index into scfg.sub[] Use the is_valid_subnum() function before using the smb.subnum as an index into (s)cfg.sub[]. Related to the previous committed fix of writemsg(): leaving the global smb.subnum as -1 (INVALID_SUB) after replying to a post via email or netmail, resulting in a crash here.

  154. Rob Swindell
    Sat Jul 02 2022 22:21:55 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    Use mouse button release rather than press to activate a hotspot As described in issue #412, when using extended mouse coordinate (SGR) mode, the mouse button release sequence would be received by the BBS after the hotspot-activated menu option was executed and then that button release sequence possibly passed through to the a child script or program that didn't know how to handle or ignore it. To resolve this, the BBS now ignores ("eats") the mouse button *press* sequence and only acts upon the mouse button *release* sequence. This is more aligned with how button-clicks work in mouse-control/GUI applications anyway.

  155. Rob Swindell
    Sat Jul 02 2022 12:22:04 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Add EXECDIR, DATADIR, and XTRNDIR to DOSemu command replacement tokens As requested. This closes issue #416

  156. Rob Swindell
    Mon Jun 27 2022 21:44:07 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    src/sbbs3/xtrn.cpp diff
    Fix Win32 build - we don't #include stdbool.h in sbbs.h

  157. Eric Oulashin
    Sat Jun 25 2022 11:24:34 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit_Misc.js diff
    Fixed a couple of undefined variable errors. Also, changed "new Object();" and related syntax to literal object definitions, and similar for arrays.

  158. Rob Swindell
    Mon Jun 27 2022 20:15:41 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_undeclared_vars_2022-06-25' into 'master' Fixed a couple of undefined variable errors. See merge request main/sbbs!192

  159. Rob Swindell
    Sat Jun 25 2022 21:09:59 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/xtrn.cpp diff
    Auto-detect (log) scripts/module execution as "native", not 16-bit DOS Address potential FAQ (issue #415)

  160. Rob Swindell
    Sat Jun 25 2022 18:47:11 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    Indicate whether an SGR mouse button report is a press or release In the mouse debug log output. Potentially helpful in debugging mouse related issues when using the SGR mouse reporting mode.

  161. Rob Swindell
    Sat Jun 25 2022 18:09:18 GMT-0700 (PDT)
    Modified Files:
    

    exec/avatar_chooser.js diff
    Address conflict with Synchronet internal mouse support 1. Don't enable mouse support if the user's terminal is configured to not support it. 2. After calling bbs.receive_file() which displays a menu and uses sbbs's internal mouse support, which enables a different mouse reporting mode, disable the console.mouse_mode (sbbs's internal mouse support) before re-enabling the mouse support for the avatar_chooser's own custom mouse mode. Fix fixes issue #414 reported by Nelgin. 3. Fixed a typo in a message displayed to user if avatar upload failed.

  162. Rob Swindell
    Sat Jun 25 2022 17:19:51 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    Add several missing fields that were added since v3.18 With one of the new fields being 64-bit, this lib now requires the updated File object that supports read/writing 64-bit binary integers too.

  163. Rob Swindell
    Sat Jun 25 2022 17:19:51 GMT-0700 (PDT)
    Modified Files:
    

    exec/logon.js diff
    Small optimization: don't write user.chat_settings if you don't need to

  164. Rob Swindell
    Sat Jun 25 2022 17:19:51 GMT-0700 (PDT)
    Modified Files:
    

    exec/webfileindex.ssjs diff
    Do the redir thing for all requests not ending in /, not just dirs

  165. Rob Swindell
    Sat Jun 25 2022 15:31:43 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_file.c diff
    src/xpdev/xpendian.h diff
    Add support for non-native endian 64-bit integers

  166. Rob Swindell
    Sat Jun 25 2022 15:19:57 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_file.c diff
    Add support for reading/writing 8-byte (64-bit) integers in binary files

  167. Rob Swindell
    Sat Jun 25 2022 13:34:12 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/text.js diff
    Add HashingFile and HashedFile text.dat enum values

  168. Rob Swindell
    Sat Jun 25 2022 13:35:06 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cnfdefs.js diff
    Fix: Some integer fields were defined as type:"str"

  169. Rob Swindell
    Sat Jun 25 2022 11:43:45 GMT-0700 (PDT)
    Modified Files:
    

    exec/avatar_chooser.js diff
    Avoid base64-decoding an empty user_avatar.data Fixes issue #413, at least the non-mouse related part. I was only able to reproduce it by trying to use the "Edit your avatar" menu item after choose "I don't want an avatar". This "I don't want" menu item is weird however and reappears when the user exits and reruns the chooser, so there's probably still some improvements needed with this menu item. The "Upload an avatar" menu item issue is likely totally unrelated. Please don't combine unrelated issues in the same bug report.

  170. Rob Swindell
    Fri Jun 24 2022 23:17:54 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Fix issue with iniSet* functions and root section Bug introduced in commit 0d9111a5: iniSet* functions would write key/values to the end of the list when the root section (NULL) was specified, rather than the beginning of the list. The root section always starts at the beginning of the list/file, so I'm not sure why section_start() was doing anything other than returning 0 for the root section. It's possible this now breaks iniSortSections() in some way, so that should be retested with a file with a root section and named sections.

  171. Rob Swindell
    Fri Jun 24 2022 12:48:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/webfileindex.ssjs diff
    Respond with redir when directory requests are received without trailing slash HTTP Directory requests without a trailing slash would "work" (the directory listing would be sent), but the links to files, since they're relative to the current request location, would be incorrect (missing the directory's virtual subdir). So send a 301 response if a client requets a directory without a trailing slash.

  172. Eric Oulashin
    Fri Jun 24 2022 10:31:41 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    DD file lister: Fix for assignment to undeclared variable in file description search

  173. Rob Swindell
    Fri Jun 24 2022 12:35:05 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    Merge branch 'dd_file_lister_desc_search_undeclared_variable_assignment_fix' into 'master' DD file lister: Fix for assignment to undeclared variable in file description search See merge request main/sbbs!191

  174. Rob Swindell
    Tue Jun 21 2022 16:23:08 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Remove DIR_FILES [ftp] Option, removed (no longer applicable) inv 3.19b

  175. Eric Oulashin
    Tue Jun 21 2022 10:12:44 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/slyvote/readme.txt diff
    xtrn/slyvote/slyvote.js diff
    Updated dd_lightbar_menu.js and some Digital Distortion mods for strict mode & made some fixes

  176. Rob Swindell
    Tue Jun 21 2022 11:34:18 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/slyvote/readme.txt diff
    xtrn/slyvote/slyvote.js diff
    Merge branch 'dd_use_strict_and_fixes_1' into 'master' Added "use strict"; to dd_lightbar_menu.js and some Digital Distortion mods& made some fixes See merge request main/sbbs!190

  177. Eric Oulashin
    Mon Jun 20 2022 16:28:08 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: When doing a text search, it now ignores the user scan configuration for sub-boards, to ensure it will show any results of the text search.

  178. Rob Swindell
    Mon Jun 20 2022 19:30:21 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'ddmsgreader_text_search_ignore_scan_cfg' into 'master' DDMsgReader: Text search now ignores user scan configuration See merge request main/sbbs!189

  179. Eric Oulashin
    Fri Jun 17 2022 09:40:15 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/attr_conv.js diff
    Replaced \1 with \x01 so that "use strict" can be used

  180. Rob Swindell
    Fri Jun 17 2022 11:56:03 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/attr_conv.js diff
    Merge branch 'attr_conv_hex_sync_attr_codes' into 'master' attr_conv.js: Replaced Sync attr literals with hexadecimal version so that "use strict" can be used See merge request main/sbbs!188

  181. Rob Swindell
    Thu Jun 16 2022 21:46:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/jsexec.c diff
    Flush console output stream after executing a script Solves problem of status output lines being interleved with console output (e.g. from print()) after executing a script.

  182. Rob Swindell
    Thu Jun 16 2022 21:32:51 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfglib2.c diff
    Resolve new warning by including the necessary header file

  183. Rob Swindell
    Thu Jun 16 2022 21:28:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/load_cfg.c diff
    src/sbbs3/load_cfg.h diff
    src/sbbs3/scfglib2.c diff
    Init virtual sub-directory name for library sub-dirs When using the "Access to Sub-directories" option for a library, the auto-created directories did not have their virtual sub-directory name set. Pretty sure this was introduced along with the http access to filebases after v3.19b. Also, only de-dupe the sub-directory names based on the directory name and not the code/code-suffix for now. Next up: auto-gen unique internal code when needed.

  184. Rob Swindell
    Thu Jun 16 2022 20:20:42 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/uifcinit.c diff
    Resolve (new) warning

  185. Rob Swindell
    Tue Jun 14 2022 22:51:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Log command-line that led to logged error opening DOSXTRN.RET

  186. Rob Swindell
    Tue Jun 14 2022 23:08:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfgsave.c diff
    Actually save the library's virtual sub-directory naming option value.

  187. Rob Swindell
    Tue Jun 14 2022 22:30:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    Remove unused variable introduced recently

  188. Rob Swindell
    Tue Jun 14 2022 22:30:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgxfr2.c diff
    src/sbbs3/scfgdefs.h diff
    src/sbbs3/scfglib2.c diff
    Allow sysop-choice of source of virtual sub-directory source name By default, each file transfer directory's internal code suffix is used as the source of the sub-directory of the virtual path used to represent a file area in the FTP and Web servers. Now, a sysop can change that source to either each directory's short name or long name, if they prefer. For MRO, because he asked (on DOVE-Net).

  189. Eric Oulashin
    Mon Jun 13 2022 19:56:28 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/attr_conv.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader refactor for sysop save to BBS machine & attachments. DDMsgReader Version 1.49 - Refactor: Simplified saving a message to BBS machine for sysop (as-is, less processing); removed attachment stuff for pre-Synchronet 3.17; moved hasSyncAttrCodes() to attr_conv.js because that's where it needs to be.

  190. Rob Swindell
    Mon Jun 13 2022 21:35:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/attr_conv.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_attachents_and_save_refactor' into 'master' DDMsgReader refactor for sysop save to BBS machine & attachments. See merge request main/sbbs!187

  191. Eric Oulashin
    Sun Jun 12 2022 15:39:01 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Improved display of ANSI messages via the use of the Graphic object

  192. Rob Swindell
    Mon Jun 13 2022 11:24:10 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_ansi_improvement' into 'master' DDMsgReader: Improved display of ANSI messages via the use of the Graphic object See merge request main/sbbs!186

  193. Eric Oulashin
    Sun Jun 12 2022 13:55:38 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    DD File Area Chooser: The "false command-line parameter works again, allowing the user to choose the file directory within their file library.

  194. Rob Swindell
    Sun Jun 12 2022 14:20:53 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'dd_file_lister_only_dir_fix' into 'master' DD File Area Chooser: The false command-line parameter works again See merge request main/sbbs!185

  195. Eric Oulashin
    Sat Jun 11 2022 13:31:29 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    DD message area chooser: Updated to try to prevent the error "this.subBoardListPrintfInfo[pGrpIdx] is undefined" when only choosing a sub-board within the user's current message group.

  196. Rob Swindell
    Sat Jun 11 2022 14:31:18 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    Merge branch 'dd_msg_area_chooser_only_subboard_change_fix' into 'master' DD message area chooser: Updated to try to prevent an "undefined" error when only choosing a sub-board within the user's current message group See merge request main/sbbs!184

  197. Rob Swindell
    Sat Jun 11 2022 13:57:14 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/con_out.cpp diff
    Always display a progress() output for count value of 0 This is normally the first count value and even if we *just* output a progress() for a previous operation, we still want the first progress() call for the operation to display.

  198. Rob Swindell
    Sat Jun 11 2022 13:58:27 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/execfile.cpp diff
    Print file library scanning progress and aborted status

  199. Rob Swindell
    Sat Jun 11 2022 14:00:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_user.c diff
    Add User close() method This can be used to force a close of the user.dat file, if open. Rather than waiting for an out of scope User to get garbage-collected, this method could be used to force a close of the user.dat file, if it's open.

  200. Rob Swindell
    Sat Jun 11 2022 14:25:54 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    Add console.progress() method This exposes the Synchronet internal sbbs_t::progress() method used to display a progress indication bar, e.g. "[ Scanning 10.0% ]" with the bar backfill effect (when supported by the terminal).

  201. Eric Oulashin
    Sat Jun 11 2022 13:13:07 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/dd_upload_processor/ddup.cfg diff
    xtrn/dd_upload_processor/ddup.js diff
    xtrn/dd_upload_processor/readme.txt diff
    xtrn/dd_upload_processor/version_history.txt diff
    DD Upload Processor: Removed the chmod updates because they're actually not needed. Some antivirus scanners (such as ClamAV) need a command line parameter to pass the file permissions descriptor to the scanner.

  202. Rob Swindell
    Sat Jun 11 2022 13:34:09 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/dd_upload_processor/ddup.cfg diff
    xtrn/dd_upload_processor/ddup.js diff
    xtrn/dd_upload_processor/readme.txt diff
    xtrn/dd_upload_processor/version_history.txt diff
    Merge branch 'dd_upload_processor_no_more_chmod' into 'master' DD Upload Processor: Removed the chmod updates because they're actually not needed. See merge request main/sbbs!183

  203. Eric Oulashin
    Sat Jun 11 2022 12:13:44 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    DD message area chooser: Updated to try to prevent the error "this.subBoardListPrintfInfo[pGrpIdx] is undefined"

  204. Rob Swindell
    Sat Jun 11 2022 12:24:58 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'dd_area_chooser_list_printf_info_undefined' into 'master' DD message area chooser: Updated to try to prevent the error "this.subBoardListPrintfInfo[pGrpIdx] is undefined" See merge request main/sbbs!182

  205. Rob Swindell
    Fri Jun 10 2022 23:16:08 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/ansi_cio.c diff
    Increase size of sprintf buffer to resolve GCC warning about buffer overflow e.g. directive argument in the range [-255, 2147483645]

  206. Rob Swindell
    Fri Jun 10 2022 22:52:20 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    Disable "unused-result" warning in release builds

  207. Rob Swindell
    Fri Jun 10 2022 22:53:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/netmail.cpp diff
    Safe string formatting of fido netmail time header field Suppresses GCC warning. I suppose some of these fields could be more digits than expected.

  208. Rob Swindell
    Thu Jun 09 2022 20:29:40 GMT-0700 (PDT)
    Modified Files:
    

    webv4/root/api/events.ssjs diff
    Force a garbage collection in the event "wait forever" loop This appears to fix the "lots of user.dat files open concurrently" behavior that remains when a browser/client has the webv4 page open for a long duration. Eventually, the User objects created in this loop would be cleaned (and the user.dat file descriptors closed), but the default garbage collection interval (configurable) is 1000 calls to the CommonOperationCallback function. This could be as as long as 1000 times through this loop before GC occurs. Since this is not a performance sensitive loop (we have a call to sleep for a full second) just force a garbage collection for each loop iteration.

  209. Eric Oulashin
    Thu Jun 09 2022 12:49:38 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit Version 1.78: Removed high-ascii characters from the SlyEdit JS files; used ascii() with their numeric ASCII values instead. This should avoid issues with text editors converting characters incorrectly.

  210. Rob Swindell
    Thu Jun 09 2022 13:13:00 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_remove_hardcoded_high_ascii' into 'master' SlyEdit: Removed high-ascii characters from the JS files to avoid issues with editors changing encodings See merge request main/sbbs!180

  211. Rob Swindell
    Wed Jun 08 2022 22:01:17 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add CI build for SVDM (Synchronet Virtual DOS Modem) for Windows

  212. Eric Oulashin
    Wed Jun 08 2022 15:38:00 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/dd_upload_processor/readme.txt diff
    dd_upload_processor readme update

  213. Rob Swindell
    Wed Jun 08 2022 17:02:35 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/dd_upload_processor/readme.txt diff
    Merge branch 'ddup_doc_update' into 'master' dd_upload_processor readme update See merge request main/sbbs!179

  214. Rob Swindell
    Wed Jun 08 2022 15:25:52 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Support unlimited number/address aliases in [alias] section of ini file Add support for an unlimited number of dial string (e.g. phone number) aliases in the [alias] section of the read .ini file. While the AT&Z, ATDSn support for stored numbers should work fine for the same use cases, it's limited to 20 numbers (that could be easily increased) and may be less obvious to users who it works. The [alias] aliases does not use AT commands to query/store the number aliases, just .ini file edits. Re-read .ini file when ATZ command is received. This allows applying dynamic changes to the .ini file without re-running SVDM. Address some memory-leaks when reading or making changes to .ini file. Fix ATIn command results. The normal result format (from an actual modem) is: <text> <blank-line> OK (or 0)

  215. Eric Oulashin
    Wed Jun 08 2022 15:16:46 GMT-0700 (PDT)
    Added Files:
    

    xtrn/dd_upload_processor/ddup.cfg diff
    xtrn/dd_upload_processor/ddup.js diff
    xtrn/dd_upload_processor/ddup_cleanup.js diff
    xtrn/dd_upload_processor/ddup_file_types.cfg diff
    xtrn/dd_upload_processor/readme.txt diff
    xtrn/dd_upload_processor/version_history.txt diff
    Removed Files:

    xtrn/DDUploadProcessor/FILE_ID.DIZ diff
    Updated Digital Distortion Upload Processor so that the scanning works properly in Linux (directory permissions)

  216. Rob Swindell
    Wed Jun 08 2022 15:16:46 GMT-0700 (PDT)
    Added Files:
    

    xtrn/dd_upload_processor/ddup.cfg diff
    xtrn/dd_upload_processor/ddup.js diff
    xtrn/dd_upload_processor/ddup_cleanup.js diff
    xtrn/dd_upload_processor/ddup_file_types.cfg diff
    xtrn/dd_upload_processor/readme.txt diff
    xtrn/dd_upload_processor/version_history.txt diff
    Removed Files:

    xtrn/DDUploadProcessor/FILE_ID.DIZ diff
    Merge branch 'ddup_linux_update' into 'master' Updated Digital Distortion Upload Processor so that the scanning works properly in Linux (directory permissions) See merge request main/sbbs!178

  217. Rob Swindell
    Mon Jun 06 2022 17:39:13 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    src/vdmodem/vdmodem.vcxproj diff
    Support option modem "speaker" (WAV file playback) control via ATM1 (turn on) Support optional WAV files via .ini keys: RingSound ConnectSound DisconnectSound ATM0 turns "speaker" (WAV playback) off (the default), ATM1 turns on. Ignore ATLn (speaker level), ATT (tone) and ATP (pulse) commands. These are sometimes found in init strings which we don't want to prematurely fail with a parse failure and "ERROR" result. Increment version number to 0.2.

  218. Rob Swindell
    Mon Jun 06 2022 15:17:32 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Perform a JS garbage collection for each new request in a reused session A reused HTTP session would never (apparently) perform garbage collection. The evidence of this was the collection of concurrent user.dat file opens that would never close until the HTTP sessions were closed. Hundreds or even thousands of open user.dat's have been seen. After this change, active web server (webv4 UI) users have not caused these spikes in open user.dat files, at least in my testing. If no garbage collection was being performed, then likely a lot of JS heap was being needlessly wasted, which could eventually result in a JS "out of memory" error. But that's just a theory. Investigation is needed into why the js_CommonOperationCallback()'s calls to JS_MaybeGC() were not sufficient to actually perform garbage collection in this case.

  219. Rob Swindell
    Mon Jun 06 2022 12:23:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/telnet.c diff
    src/sbbs3/telnet.h diff
    Fix Borland build issue: no stdbool.h in C++Builder 6 ... still ;-)

  220. Eric Oulashin
    Mon Jun 06 2022 12:01:24 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Fix for miscolored digit(s) in # messages column in the sub-board list when using the lightbar menu

  221. Rob Swindell
    Mon Jun 06 2022 12:12:05 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'dd_area_chooser_num_msgs_color_fix' into 'master' DD Area chooser: Fix for miscolored digit(s) in # messages column in the sub-board list when using the lightbar menu See merge request main/sbbs!176

  222. Rob Swindell
    Sat Jun 04 2022 21:33:05 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Reset "hangup event" (dropped DTR indication) upon connection Resolves issue with SBBS v2.30 not be able to answer an incoming "call".

  223. Rob Swindell
    Sun Jun 05 2022 15:49:07 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/telnet.c diff
    src/sbbs3/telnet.h diff
    Add telnet_opt_enabled() function that returns true for WILL or DO opt status An option is enabled/supported regardless of which end makes the request, so the status can be WILL (an ACK to a remote request) or DO (an ACK to a local request) when an option is enabled.

  224. Rob Swindell
    Sun Jun 05 2022 16:05:27 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Enable binary-transmit mode in server by default, disabling CR->CRLF expansion Don't expand CR->CRLF when in binary mode that was requested locally (option value is DO, instead of WILL), using new telnet_opt_enabled(). Request binary-transmit mode by default in Telnet server/answer mode. Set ServerBinary=false in svdm.ini to disable. This fixes the extra line-feeds in Telnet-server mode.

  225. Rob Swindell
    Sat Jun 04 2022 20:33:30 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Use safe string formatting to squelch warnings Attempt to address 2 GCC version 11.2.0 2 warnings reported by Nelgin ‘%s’ directive writing up to 3 bytes into a region of size between 1 and 4097

  226. Rob Swindell
    Sat Jun 04 2022 20:25:32 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chksmb.c diff
    Fix copy/paste bug discovered/reported by gcc version 11.2.0 ... in debug print statement (MD5 hast decoded/printed as SHA-1 hash). Reported by Nelgin running gcc version 11.2.0 (Ubuntu 11.2.0-19ubuntu1)

  227. Rob Swindell
    Sat Jun 04 2022 20:08:28 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/readme.txt diff
    Remove a couple wiki marks unintentionally left in place

  228. Rob Swindell
    Sat Jun 04 2022 20:02:10 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Print build details (date, time, compiler version) with -V output.

  229. Rob Swindell
    Sat Jun 04 2022 16:03:27 GMT-0700 (PDT)
    Added Files:
    

    src/vdmodem/readme.txt diff
    An initial readme.txt, most of this text comes from the wiki.synchro.net page

  230. Rob Swindell
    Sat Jun 04 2022 16:04:14 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    Better log messages and yielding upon ReadFile(mailslot) error.

  231. Rob Swindell
    Sat Jun 04 2022 14:36:07 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/doorscan/doorscan.js diff
    Second part of previous fix recommended by Apam (POSITRON)

  232. Rob Swindell
    Sat Jun 04 2022 14:33:19 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/doorscan/doorscan.js diff
    Apam's suggested correction for "XDOORSCAN" in the log file Some shells log every character the user types (e.g. 'X' for external programs) so we need a newline before the logged DOORSCAN line to be parsed correctly. From Apam (POSITRON)

  233. Rob Swindell
    Thu Jun 02 2022 22:12:21 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/sbbsctrl.cpp diff
    Fix for new sbbs_get_ini_fname() usage

  234. Rob Swindell
    Thu Jun 02 2022 12:05:12 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/smballoc.c diff
    src/smblib/smblib.c diff
    Use PRIdOFF instead of %ld or %lu when formatting off_t values for error msgs On Win32, an off_t is 64-bits while a long is still a measly 32-bits.

  235. Rob Swindell
    Wed Jun 01 2022 21:03:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ntsvcs.c diff
    src/sbbs3/textgen.c diff
    Address new warnings/errors by get_ctrl_dir() and sbbs_get_ini_fname() changes

  236. Rob Swindell
    Wed Jun 01 2022 21:10:34 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    src/vdmodem/vdmodem.vcxproj diff
    Add support for IP blocking/filtering via file (ala SBBS ip.can) svdm.ini IpFilterFile can be set to the path/filename of an "ip filter file", list of IP addresses or patterns (CIDRv4 notation supported) to refuse connections from. This is reusing the same IP filter file logic from SBBS, so the same filter file syntax/rules apply.

  237. Rob Swindell
    Wed Jun 01 2022 20:39:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/addfiles.c diff
    src/sbbs3/delfiles.c diff
    src/sbbs3/dupefind.c diff
    src/sbbs3/echocfg.c diff
    src/sbbs3/gtkchat/main.c diff
    src/sbbs3/gtkchat/objects.mk diff
    src/sbbs3/load_cfg.h diff
    src/sbbs3/makeuser.c diff
    src/sbbs3/objects.mk diff
    src/sbbs3/sbbs_ini.c diff
    src/sbbs3/sbbs_ini.h diff
    src/sbbs3/sbbscon.c diff
    src/sbbs3/scfg/objects.mk diff
    src/sbbs3/smbactiv.c diff
    src/sbbs3/uedit/objects.mk diff
    src/sbbs3/uedit/uedit.c diff
    src/sbbs3/umonitor/objects.mk diff
    src/sbbs3/umonitor/umonitor.c diff
    Address warnings and errors introduced in *nix build from previous commit Also a bit more constification and cleared up the legacy sbbs_get_ini_fname() usage: the hostname argument hadn't be used in a long, long time.

  238. Rob Swindell
    Tue May 31 2022 19:27:15 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Accept all incoming connections in listen_thread() This sets the stage for "Caller-ID" support and IP/host filtering (before sending a "RING" result and requiring an auto-answer or host/BBS software to send "ATA").

  239. Rob Swindell
    Wed Jun 01 2022 15:28:44 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Add "Caller ID" support, enabled with AT#CID=1 or AT+VCID=1 Also controlled via [modem] CallerID key in svdm.ini fiile. Reports the connected IP address between the first and second RING result. Required a fix to reset the ringcount to 0 upon new connection. Simplified the AT command parsing logic a bit.

  240. Rob Swindell
    Wed Jun 01 2022 20:02:37 GMT-0700 (PDT)
    Added Files:
    

    src/sbbs3/findstr.c diff
    src/sbbs3/findstr.h diff
    Modified Files:

    src/sbbs3/echocfg.vcxproj diff
    src/sbbs3/getctrl.c diff
    src/sbbs3/getctrl.h diff
    src/sbbs3/jsexec.vcxproj diff
    src/sbbs3/load_cfg.vcxproj diff
    src/sbbs3/ntsvcs.vcxproj diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/sbbs.vcxproj diff
    src/sbbs3/sbbscon.vcxproj diff
    src/sbbs3/sbbsecho.c diff
    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    src/sbbs3/str_util.c diff
    src/sbbs3/str_util.h diff
    src/sbbs3/textgen.vcxproj diff
    src/sbbs3/userdat.c diff
    Decompose some library files to enable reuse by SVDM (virtual DOS modem) I just wanted to reuse findstr() in vdmodem.c and I fell down this hole :-) findstr.* is new (findstr() related functions moved from str_util) getctrl.* is now finally the real home of get_ctrl_dir(), moved from str_util trashcan* functions moved from str_util to scfglib other scfg_t dependent functions moved from str_util to scfglib net_addr() appears to be a function that was never created/used (?) This will definitely break the *nix build, for now.

  241. Rob Swindell
    Tue May 31 2022 18:17:34 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Store connecting-client information (e.g. IP address) in file by default, client.ini in the current working directory. Configurable filename via ClientFile key in the root section of svdm.ini.

  242. Rob Swindell
    Tue May 31 2022 18:17:42 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_user.c diff
    Don't clobber an open user.dat file descriptor in js_CreateUserObject() Likely fix for the user.dat open file descriptor leak: If js_CreateUserObject(cx,parent,cfg,"name",...) is called multiple times (e.g. before login and after login), the successive calls will reuse the previously allocated JS object and allocated private data memory. However, the private data memory (which includes the descriptor of an open user.dat file, if it has been opened), was always zeroed, even if it was being reused. This would leak open file descriptor. So any (pre)login scripts or web scripts that use the "user" object (which is all zeroed-out before login) and then allows a user to subsequently login, would leak a file descriptor.

  243. Rob Swindell
    Tue May 31 2022 18:27:55 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/str.cpp diff
    Close the open user.dat upon (unlikely/impossible) malloc error

  244. Eric Oulashin
    Tue May 31 2022 17:24:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    Fixed weird character issue from last commit Fixed a weird character issue from the last commit, that may have been due to using a different text editor that changed some characters, possibly due to character encoding

  245. Rob Swindell
    Tue May 31 2022 17:44:47 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_badchars_fix' into 'master' Fixed weird character issue from last commit See merge request main/sbbs!175

  246. Eric Oulashin
    Tue May 31 2022 14:33:48 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit 1.77: Fix for aborting when trying to access sub-board information when there are no sub-boards

  247. Rob Swindell
    Tue May 31 2022 14:33:49 GMT-0700 (PDT)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_rare_fix_no_subboards' into 'master' SlyEdit 1.77: Fix for aborting when trying to access sub-board information when there are no sub-boards See merge request main/sbbs!174

  248. Rob Swindell
    Mon May 30 2022 17:23:54 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    Fix compile-breaking typos in last commit

  249. Rob Swindell
    Mon May 30 2022 16:35:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    Store the UART register/settings in a struct for easy re-init Re-init the UART struct in the init routine to avoid confusion when making .ini file changes with older NTVDMs (including NTVDMx64) which don't re-load the VDDs for every invocation.

  250. Rob Swindell
    Sun May 29 2022 19:19:49 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Enable experimental sbbsexec modes (e.g. redir DOS I/O) Added undocumented experimental options -I and -O to enable DOS input and output interception modes in sbbsexec (e.g. to be used possibly with '-h'). Also -M to specify sbbsexec mode value by number (e.g. 3 to enable DOS Input/Output redir). Added '-n' option to specify node number (probably no real value/need). Safe string formatting.

  251. Rob Swindell
    Fri May 27 2022 18:15:02 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Fix port parsing in dial string More case-insensitivity in parsing special "number" values (e.g. 'L' for last number). Default to Telnet mode (not Raw TCP). Default to unspecific address family (not IPv4). Case-insensitive "-telnet" and "-raw" option recognition.

  252. Rob Swindell
    Sat May 28 2022 13:22:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Send a "banner" when accepting incoming connections. Fix a corner case where an invalid command-mode escape sequence (e.g. "+.+.+") could've been interpreted as valid.

  253. Rob Swindell
    Sun May 29 2022 18:52:12 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Resolve the socket protocol/address family issues with IPv4 vs. IPv6 When listening, the address family cannot be PF_UNSPEC, so default to PF_INET (IPv4), when not specified. Not sure why we're setting ai_flags to PF_UNSPEC (copied from syncterm) - that's just 0, but otherwise the PF_ and AI_ flags are not compatible. Don't set the ai_flags to anything here since they don't seem to change the behavior.

  254. Rob Swindell
    Fri May 27 2022 13:08:24 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.vcxproj diff
    Run gitinfo.bat in prebuild event To (re)generate git_branch.h and git_hash.h every build

  255. Rob Swindell
    Fri May 27 2022 13:02:51 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Increment version to 0.1

  256. Rob Swindell
    Tue May 24 2022 08:17:24 GMT-0700 (PDT)
    Added Files:
    

    src/build/gitinfo.bat diff
    Modified Files:

    src/sbbs3/release.bat diff
    src/sbbs3/sbbs.jsdocs.vcxproj diff
    src/sbbs3/sbbs.vcxproj diff
    Move gitinfo.bat to build directory So it can be reused for other projects more easily

  257. Rob Swindell
    Tue May 24 2022 10:15:32 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.sln diff
    Platform rename x86 -> Win32 To be more consistent with other Synchronet project and solution files.

  258. Rob Swindell
    Tue May 24 2022 10:15:55 GMT-0700 (PDT)
    Added Files:
    

    src/vdmodem/build.bat diff
    src/vdmodem/release.bat diff
    Build files

  259. Rob Swindell
    Tue May 24 2022 10:53:24 GMT-0700 (PDT)
    Added Files:
    

    src/vdmodem/.gitignore diff
    Git-Ignore the git*.h files

  260. Rob Swindell
    Tue May 24 2022 21:58:34 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Include Git branch/hash in detailed version output svdm -V and "ATi1" output.

  261. Rob Swindell
    Mon May 23 2022 19:29:34 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Don't close externally opened/passed socket descriptors Set sbbs_hungup event state correctly based on initial online state (i.e. FALSE if already connected/online). Allow BusyNotice (string) to be configurable via .ini file.

  262. Rob Swindell
    Mon May 23 2022 19:29:56 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/fossinfo.c diff
    Report FOSSIL port status

  263. Rob Swindell
    Mon May 23 2022 18:04:13 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Save modem "NVRAM" settings to ini file Support [sockopts] (socket options) settings in ini file CamelCase the ini key names

  264. Rob Swindell
    Mon May 23 2022 18:04:13 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Usage/syntax help output, read svdm.ini from path of svdm.exe Support specifying an additional or alternate .ini file to read using -c<fname> option.

  265. Rob Swindell
    Mon May 23 2022 18:04:13 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    No need to call reset_yield() if we're not calilng maybe_yield()

  266. Rob Swindell
    Wed May 18 2022 18:36:08 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/birthdays.js diff
    Fix loop limit (system.stats.total_users != system.lastuser) When looping to highest user number, use system.lastuser, not system.stats.total_users. This explains why not all userbases would be affected by the just-fixed issue in js_user.c. If the total_users happens to equal lastuser, then you would have hit the issue in js_user.c. If you had at least one deleted or inactive user account, then system.stats.total_users would be less than system.lastuser and your system would *not* have triggered that bug.

  267. Rob Swindell
    Wed May 18 2022 15:32:06 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_user.c diff
    Fix User.number increment beyond lastuser issue When the 'number' property of an instance of User was incremented beyond the last user, the call to fgetuserdat() on subsequent property 'get' operation would fail and zero-out the user structure (including the user number). This resulted in an infinite loop in load/birthdays.js where the user number would go from lastuser to 1 in one operation (u.number++). Reported by DesotoFireflite (VALHALLA)

  268. Eric Oulashin
    Tue May 17 2022 12:47:01 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Fixes for searching & related error reporting

  269. Rob Swindell
    Tue May 17 2022 12:59:04 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'ddac_search_errors_fix' into 'master' DD area choosers: Fixes for searching & related error reporting See merge request main/sbbs!171

  270. Rob Swindell
    Tue May 17 2022 09:42:03 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.sln diff
    src/vdmodem/vdmodem.vcxproj diff
    build/link with xpdev_mt Build using WinXP-compatible toolset.

  271. Rob Swindell
    Tue May 17 2022 09:27:40 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/netwrap.h diff
    Fix error: Undefined structure 'in_addr' in Borland builds sbbsctrl build failed, it needs another winsock header. <sigh> Oh what a rabbit hole this has been.

  272. Rob Swindell
    Mon May 16 2022 20:44:19 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/netwrap.h diff
    Need ws2tcpip.h for struct ip6_addr definition on Windows

  273. Rob Swindell
    Mon May 16 2022 20:45:08 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/xpdev.props diff
    src/xpdev/xpdev_mt.props diff
    xpdev/netwrap now requires IPHlpApi.lib on Windows

  274. Rob Swindell
    Mon May 16 2022 20:20:27 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/netwrap.c diff
    src/xpdev/netwrap.h diff
    Move IPv4/v6 address parse functions to netwrap.c And create IPv4AddressToStr(), a wrapper for inet_ntop (or inet_ntoa, when inet_ntop isn't available).

  275. Rob Swindell
    Mon May 16 2022 12:47:57 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Apparently MinGW32 doesn't have inet_ntop() or inet_pton() either

  276. Rob Swindell
    Mon May 16 2022 12:10:02 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Borland didn't include inet_ntop() or inet_pton() Fixes CI and nightly build.

  277. Rob Swindell
    Sun May 15 2022 23:48:19 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    Replace deprecated inet_ntoa and inet_addr function calls Use inet_ntop and inet_pton instead. Use 32-bit arguments and return values for IPv4 addressess for all target platforms (ulong is 64-bit on LP64, e.g. Linux-x64, targets).

  278. Rob Swindell
    Sun May 15 2022 23:49:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Implement svdm.ini file support to store settings and modem NVRAM e.g. AT&W writes the current settings to the [modem] section.

  279. Rob Swindell
    Tue May 10 2022 12:58:32 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Explain that TAB is used to edit the entry comment in online help

  280. Rob Swindell
    Tue May 10 2022 17:03:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/services.c diff
    Allow a per-service "LowestLogLevel" setting Have a service (e.g. imapservice.js) that logs errors that you'd rather not fill your error.log file with? Set that service's "LowestLogLevel" to "Warning" in your services.ini file ("lower" means "more severe" when it comes to log levels, so this would set the maximum severity to Warning).

  281. Rob Swindell
    Tue May 10 2022 17:04:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Set Telnet-server options (e.g. will echo) in answer()

  282. Rob Swindell
    Mon May 09 2022 18:52:27 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/smbhash.c diff
    Remove trailing whitespace before computing Subject CRC Some responding programs will automatically remove the trailing white-space from subject when replying and that would mess up the subject-linkage-by-CRC. So let's just ignore trailing whitespace in the first place.

  283. Rob Swindell
    Mon May 09 2022 18:36:31 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    Better RTS support Reducing log output (lowering log level of line 437 from LOG_INFO to LOG_DEBUG) highlighted an issue with Telix stopping RX. That was fixed by checking RTS in input_thread(). Qmodem needs RTS checked when writing the MCR. This improved RTS support has been tested with Telix, Qmodem, Telemate, and Banacom at full data rates.

  284. Rob Swindell
    Mon May 09 2022 18:49:25 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    src/vdmodem/vdmodem.vcxproj diff
    Add Telnet support

  285. Rob Swindell
    Sun May 08 2022 18:56:31 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgxtrn.c diff
    src/sbbs3/xtrn.cpp diff
    src/sbbs3/xtrn_sec.cpp diff
    Add "Disable Local Display" option for doors, parse DOSXTRN.ERR New option to disable local screen display for door programs: sets the 'Screen' value appropriately in door.sys or pcboard.sys drop files and on Windows, doesn't create a new console window. Also, now parsing the DOSXTRN.ERR file created by the latest/greatest dosxtrn.exe when failing to execute the child/DOS program and log the parsed error details (errno value and description), helpful in debugging the reason why a DOS program may not have been successfully executed by DOSXTRN.

  286. Rob Swindell
    Sun May 08 2022 11:31:17 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_msgbase.c diff
    Remember the last 'first_msg' property value after msgbase is closed The other msgbase property values are stored in the smb.status or other private_t members which retain their value when the message base is closed, unlike the 'first_msg' property which required a read of the message base index to get the value (and that doesn't work when the message base is closed, so would return 0). for deon (ALTERANT)

  287. Rob Swindell
    Sun May 08 2022 00:01:42 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    Print the upload TCP protocol (when available) w/user name, not host/IP Long hostnames would prevent the protocol from being shown. Also, non-operators should be able to see the protocol used to upload files.

  288. Rob Swindell
    Sun May 08 2022 00:09:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/dosxtrn/dosxtrn.c diff
    Support an optional ini filename argument, write to DOSXTRN.ERR If a 4th optional argument is provided, use that as the ini filename for virtual UART/FOSSIL driver settings instead of "sbbsexec.ini". Using this feature requires an updated sbbsexec.dll that supports an ini-filename argument (instead of a directory) to the VDD_LOAD_INI_FILE command. If DOSXTRN fails to execute the passed command-line, _spawnvp() returns -1, log the errno value and description to DOSXTRN.ERR (in the same directory as DOSXTRN.ENV). This will help diagnose issues executing DOS command-lines (e.g. file not found). Upon failure to open/create DOSXTRN.RET, don't prematurely terminate as that would skip a lot of important cleanup.

  289. Rob Swindell
    Sun May 08 2022 00:40:38 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    src/sbbs3/uartdefs.h diff
    Improvements to virtual UART driver for Windows In the process of creating/testing the new Synchronet Virtual DOS Modem (SVDM) project, I made the following significant improvements: - Don't default the log level to DEBUG for debug builds - Add a "carrier change" event so carrier low to high transitions can be tracked too - Replace several lprintf() calls with lputs() for performance reasons - Specify 'volatile' storage for pending_interrupts - Interrupts are re-asserted if there are any pending interrupts after reading IIR register - Emulate FIFO enablement - Support RTS flow control signal - Remove conditional/configurable yields when polling LSR and MSR register, would just unnecessarily slow down terminal programs - Report "DCD change" in MSR correctly - Clean-up (e.g. close handles) in VDD_CLOSE handler - VDD_LOAD_INI_FILE allows an optional ini filename (instead of directory) as its argument - for loading an ini filename other than sbbsexec.ini (e.g. svdm.ini). Initialize log level in VDDInitialize(). For versions of Windows/NTVDM that use/call the "init proc" (this function), we just re-initialize global variables here.

  290. Rob Swindell
    Sun May 08 2022 00:43:48 GMT-0700 (PDT)
    Added Files:
    

    src/vdmodem/vdmodem.c diff
    src/vdmodem/vdmodem.sln diff
    src/vdmodem/vdmodem.vcxproj diff
    Synchronet Virtual DOS Modem for Windows First commit. Right now it just connects/accepts-connections using raw TCP. As demonstrated in YouTube video: https://www.youtube.com/watch?v=fxp38Nde3fg

  291. Rob Swindell
    Sat Apr 30 2022 18:56:29 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/sockwrap.c diff
    Fix xp_inet_pton: was just writing 0x02 (address family)to 'dst', always Tried using this function in a new project and didn't work. My guess: it wasn't tested. <looks at Deuce>

  292. Rob Swindell
    Sat Apr 30 2022 14:13:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    Fix CID 174496: Integer handling issues (BAD_SHIFT) Don't repeat call atoi() unnecessarily.

  293. Rob Swindell
    Sat Apr 30 2022 14:23:25 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/addfiles.c diff
    src/sbbs3/file.cpp diff
    src/sbbs3/filedat.c diff
    src/sbbs3/filedat.h diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/js_filebase.c diff
    src/sbbs3/listfile.cpp diff
    src/sbbs3/upload.cpp diff
    Fix DIZ extraction/use for FTP uploads 1. Was not setting f->dir to the correct directory number, so only ftp-uploads to the *first* directory (dirnum = 0) would extract DIZ files of uploaded files. Removing the 'dirnum' parameter to addfile() since that implied that you did not have to initialize the 'dir' element of the passed file_t, but you do: to get the correct file path for file size/date detection and the DIZ extraction. 2. Was getting heap-corruption when freeing the imported/formatted DIZ text on Windows once the above problem was fixed: can't free() in one DLL memory that was allocated in another DLL. Created and now using free_diz() to free the memory allocated in read_diz(). format_diz() handles a NULL 'lines' argument correctly/gracefully, so no need for the NULL lines check in sbbs_t::uploadfile(). Added FTP server log messages for successful file upload or update by user.

  294. Rob Swindell
    Thu Apr 28 2022 19:31:56 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    Give the timed event config menu the left/right arrow key treatment Allows quick traversing through timed events (e.g. for comparison of settings).

  295. Rob Swindell
    Thu Apr 28 2022 18:42:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    When running 16-bit DOS commands "offline" on Windows, don't use dosxtrn We shouldn't need a virtual UART/FOSSIL driver to execute "offline" program (e.g. timed events) in the first place, and our virtual UART/FOSSIL for Windows wouldn't work right in the scenario anyway even if it did load successfully. This resolves the reported issues with timed events configured as not "native" returning error 255 (and not running successfully) on Windows with SBBS v3.19. I'm not even sure what changed exactly in xtrn.cpp, dosxtrn.c, and sbbexec.c between v3.18 and v3.19 that's causing this to now fail, but it (using DOSXTRN to run offline DOS programs) really shouldn't have been attempted in the first place. So that was just a design issue that happened to kind of sort of work up until v3.19.

  296. Rob Swindell
    Thu Apr 28 2022 18:55:39 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgnet.c diff
    Add "Native" option for QWKnet call-out cmd-lines This really shouldn't be necessary to toggle (at least now) on Windows, since we treat all off-line executions as "native", but for *nix, it could make a big difference if trying to invoke a native program or shell script for a QWKnet call-out and it would either fail due to no DOS support or try to executing using Linux-DOSEMU (unless the command's program name was in the global "native program list" configured in SCFG->External Programs).

  297. Rob Swindell
    Thu Apr 28 2022 12:59:39 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sexyz.vcxproj diff
    Mutex-protect the ring buffers (as we do in the *nix builds) This fixes an observed crash in sexyz for Windows. The crash was in RingBufWrite() where 'remain' was set to -1 (4.2B) apparently because pHead and/or pTail changed (to pTail=pHead) during the invocation of the RINGBUF_FILL_LEVEL() macro, because it wasn't thread-safe. Amazing this problem never came up before.

  298. Rob Swindell
    Thu Apr 28 2022 13:39:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    Don't add hot-spots for users of terminals without mouse support This eliminates some link-list management and the debug-level log message "Scrolled x mouse hot-spots" for non-mouse-enabled user terminals.

  299. Rob Swindell
    Thu Apr 28 2022 13:42:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/con_out.cpp diff
    Always displays the 100% progress report ... regardless of the timing of the last progress report. For cases where the progress output isn't erased once done doing the thing.

  300. Rob Swindell
    Thu Apr 28 2022 13:43:40 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/bat_xfer.cpp diff
    Sort the batch queues in the .ini files as well This insures that the 'R'emove file option will work correctly if when displayed sorted.

  301. Rob Swindell
    Thu Apr 28 2022 13:45:05 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/zmodem.c diff
    Fix erroneous error message Subpacket OVERFLOW means received subpacket byte offset is >= the max subpacket length.

  302. Rob Swindell
    Thu Apr 28 2022 13:48:41 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/dosxtrn/dosxtrn.c diff
    Report CTS status in FOSSIL driver (high when outbuf has some space) Some programs (e.g. sbbs.exe v2.30) check for CTS (when configured/enabled for hardware flow control), so reflect the signal (Clear To Send) accurately.

  303. Rob Swindell
    Wed Apr 27 2022 20:50:06 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    src/sbbs3/filedat.h diff
    Add batch_list_sort() to sort up/download batch xfer list files

  304. Rob Swindell
    Wed Apr 27 2022 20:51:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/bat_xfer.cpp diff
    Add a sort (alphabetical) option when listing batch queues

  305. Randy Sommerfeld
    Mon Apr 25 2022 23:58:23 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/ircd/server.js diff
    We don't use cmd anymore

  306. Rob Swindell
    Mon Apr 25 2022 20:15:01 GMT-0700 (PDT)
    Modified Files:
    

    docs/source.html diff
    docs/sysop_commands.html diff
    Redirect to the relevant wiki.synchro.net page

  307. Rob Swindell
    Mon Apr 25 2022 14:20:54 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    Fix possible underflow conditions in gettimeleft() If a non-'T' exempt user had already used more time today than their security level allows, their timeleft would be computed as a negative value due to integer underflow. Since the return value of this function is assigned to a ulong (timeleft), this becomes a large positive number. Cap the floor of the computed time left at 0. Also fix the potential for underflow that could occur if the system clock changes while a user is online and 'now' becomes greater than 'starttime'.

  308. Rob Swindell
    Mon Apr 25 2022 14:21:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/logout.cpp diff
    Add comment about race condition Fixed typo in another comment

  309. Rob Swindell
    Sun Apr 24 2022 19:20:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/xtrn_sec.cpp diff
    Dates in drop files are always MM/DD/YY, never DD/MM/YY Previously, if a sysop had set SCFG->System->Toggles->European Date Format (DD/MM/YY) to "Yes", then many of the dates in drop files would have been written in this format. Unfortunately, since most BBS doors and door development kits were written by Americans, MM/DD/YY format is always assumed. So fixed that (using new TM_MONTH macro too). Also, line 37 ("Event Time") of DOOR.SYS was always 00:00, now it'll be the next event time (in HH:MM format). Unfortunately, that time might be tomorrow or days away and there's no way to represent *that* fact in the DOOR.SYS file format. <shrug>

  310. Rob Swindell
    Sun Apr 24 2022 19:21:48 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/xpdev_mt.props diff
    Add winsock library (ws2_32.lib) to multi-threaded xpdev props file This additional library was already included in the single-threaded version, so this was just a miss.

  311. Rob Swindell
    Sun Apr 24 2022 17:32:41 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Add line 8 (user's real name) to DOORFILE.SR (Solar Realms' drop file) Apparently this line was added at some point, not sure if it's actually used in any doors, but here it is anyway.

  312. Rob Swindell
    Sun Apr 24 2022 17:34:58 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Populate line 36 (user alias) of door.sys with the current user's handle Previously, we just always made this a blank line.

  313. Rob Swindell
    Thu Apr 21 2022 21:57:05 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_msgbase.c diff
    Restore ability for MsgBase.open() to open an arbitrary SMB msgbase Before commit 5da26eca, you could pass Msgbase() the path to an SMB on the disk and open() it, no configuration needed. As of 2 years ago, I broke that, and passing a path to an SMB would open the "mail" base instead - most unexpected. This is a feature of smb_open_sub() which we switched to using (from smb_open()), so go back to using smb_open() when an unrecognized code is pass to the constructor. This has the negative consequence that the "mail" base can't be created via JS. Probably should fix that.

  314. Rob Swindell
    Thu Apr 21 2022 22:05:37 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_msgbase.c diff
    Use smb_open_sub() for the "mail" base too This restores the ability for JS MsgBase() to be used to create the initial mail message base properly, if needed. This means that the 'subnum' should now be equal to scfg.total_subs when referencing an arbitrary SMB via path (not in the configuration).

  315. Rob Swindell
    Thu Apr 21 2022 22:07:06 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Fix segfault when printing Bad-echo name after failing to load cfg This is a weird one: sbbsecho ran right as I was saving msgs.cnf via SCFG and it seems like it loaded 0-byte msgs.cnf into memory and this segfault was a result of trying to print sub[INVALID_SUB]->code. The use of [f]nopen() with proper share perms should have prevented this (truncated msgs.cnf read) from happening, so there's something else afoot here.

  316. Rob Swindell
    Thu Apr 21 2022 21:45:09 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Limit door.sys numeric values to 32767 The DoorFrame door library will about with "Overflow Error" if it reads a door.sys file with lines 16 (calls), 42 (minute credits), or 52 (posted messages) with a value > 32767, the maximum positive value of a signed 16-bit integer. So cap these values in the door.sys file at that maximum. This does potentially break/limit doors that give minutes using the door.sys drop file, so use that "modify user data" option in SCFG with care. Electrosys initially reported this problem with the Lemonade! door game which was barfing on a line 42 value of 449632.

  317. Deucе
    Tue Apr 19 2022 09:32:10 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord/lord.js diff
    Bump the version The extra strength bug fix needs a new version number.

  318. Deucе
    Tue Apr 19 2022 09:25:47 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord/lord.js diff
    Fix STR gain after defeating a trainer. You get str_gained, not str. :(

  319. Rob Swindell
    Sun Apr 17 2022 21:19:53 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    Don't zero-out static variables for option index/bar This prevents re-entry to the door configurations from returning to the previously highlighted menu option. Not sure why this was, but clearly re-zeroing static variables makes no sense in the first place.

  320. Rob Swindell
    Sun Apr 17 2022 21:20:50 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_msgbase.c diff
    Fix LAZY_BOOLEAN macro definition This is what was causing the 'is_utf8' message header property to be created as a Number instead of a Boolean.

  321. Rob Swindell
    Sat Apr 16 2022 00:52:34 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.dat diff
    String 387 is now used for YouCantUseThatNetmail string

  322. Rob Swindell
    Sat Apr 16 2022 00:51:59 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/sbbsdefs.js diff
    src/sbbs3/newuser.cpp diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgsys.c diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    Implement duplicate new-user email address checking (optional) If a sysop wants to prevent new users from using an email address of an existing user, they can set SCFG->System->New User Values->Question Toggles->Force Unique E-mail/NetMail to "Yes". This partially addresses issue #127, at least for the terminal server.

  323. Rob Swindell
    Fri Apr 15 2022 23:11:38 GMT-0700 (PDT)
    Modified Files:
    

    exec/str_cmds.js diff
    Log string command invoked by users via log() On *nix, log() output can go to syslog() and on Windows, it can go to the event log. This addresses issue #360.

  324. Rob Swindell
    Fri Apr 15 2022 16:09:32 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Truncate node.dab to correct size when initializing any sbbs_t instance Fixes issue #395

  325. Rob Swindell
    Fri Apr 15 2022 10:56:08 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    Address Coverity-reported printf format issue CID 351997 and 351998

  326. Rob Swindell
    Thu Apr 14 2022 17:30:05 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/nopen.c diff
    Fix new function: fopenlog() ftello() returns 0 after fnopen(..., O_APPEND). Use filelength() instead.

  327. Rob Swindell
    Thu Apr 14 2022 14:58:40 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Address new GCC warning instance

  328. Rob Swindell
    Thu Apr 14 2022 14:53:18 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    src/sbbs3/logfile.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/nopen.c diff
    src/sbbs3/nopen.h diff
    src/sbbs3/scfg/scfgsys.c diff
    src/sbbs3/scfgdefs.h diff
    src/sbbs3/scfglib1.c diff
    src/sbbs3/scfgsave.c diff
    src/sbbs3/xtrn_sec.cpp diff
    Add configurable log size limit and retention count For the following log files: hungup.log error.log crash.log hack.log spam.log guru.log ... they can be limited in size, in bytes, by the sysop, along with a maximum retention limit (number of *.#.log files). Configured in SCFG->System->Advanced. By default, the limit and keep numbers are 0, so "unlimited" (same behavior as before). Once sufficiently tested, I'll change the default in a stock main.cnf file to use a sensible limit (e.g. 10 log files of 10MB each, something like that).

  329. Eric Oulashin
    Wed Apr 13 2022 18:38:38 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Dates shown in file desriptions when extended descriptions are enabled. When extended file descriptions are enabled, the file date is now shown with the file description on the last line.

  330. Rob Swindell
    Wed Apr 13 2022 19:22:14 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'ddfilelister_exted_desc_file_dates' into 'master' DDFileLister: Dates shown in file desriptions when extended descriptions are enabled. See merge request main/sbbs!169

  331. Rob Swindell
    Wed Apr 13 2022 13:32:38 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Fix packet filename in "Gruned message" log entry on Win32 e.g. "Grunged message (type 2) from 4:80/1 at offset 58 in packet: (null)" off_t is 64-bit, but long in 32-bit (on Win32), so needs a typecast here in lprintf() call (otherwise, the upper 4 bytes of the offset are interpreted as the string address for the corresponding '%s' argument, the filename).

  332. Rob Swindell
    Tue Apr 12 2022 13:59:58 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord2/lord2.js diff
    Un-comment-out the line referencing 'bs' since it's now defined.

  333. Stephen Hurd
    Tue Apr 12 2022 13:48:10 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord2/lord2.js diff
    Copy in missing ws and bs variables from lord.js

  334. Rob Swindell
    Sun Apr 10 2022 20:24:44 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/exec.cpp diff
    Install OperationCallback for all executed JS scripts JS doors with the "Use Shell or New Context" option enabled in SCFG and JS modules installed a global hot key handlers would not automatically terminate when the user disconnected (and js.auto_terminate was true, the default). I'm not sure why the operation callback was only installed when scope==NULL but always installing it fixes the issue with some global hot key modules and JS doors becoming "zombies" when a user disconnects while running them.

  335. Rob Swindell
    Sat Apr 09 2022 16:30:28 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/tw2/input.js diff
    Check for user disconnection in CheckTerminate() A user disconnecting while running tw2 would just result in an infinite loop checking node status and waiting for the user's allowed time to run out (which may never happen) or for the server to be locally terminated. This has been happening for years on Vertrauen. Finally now I see why.

  336. Rob Swindell
    Sat Apr 09 2022 16:00:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/qwknodes.c diff
    Send error output to stderr, non-error output to stdout Fixes issue #390

  337. Rob Swindell
    Sat Apr 09 2022 14:29:27 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/presence_lib.js diff
    Fix long-standing issue with external program name display Especially for Guest (G-Exempt) accounts which support multiple concurrent logons - the 'curxtrn' value stored in the user's record may not match the external program that was actually last executed on the node in question, so use the .aux property value (from node.dab) as is done in the C++ code (e.g. printnodedat()). This insures that the node_status() output here matches the C/C++ code output (e.g. when logging on the terminal server). Still support the 'code-based' external program name look-up since that usage is relied upon by other modules, but when a number is passed, use the number to find the right external progarm name (and we need to subtract one, since aux is a 1-based number). I've looked at this problem a couple of times before and not sure why I didn't see the solution. <shrug>

  338. Deucе
    Sat Apr 09 2022 12:14:36 GMT-0700 (PDT)
    Modified Files:
    

    exec/imapservice.js diff
    Throw more interesting errors when a continuation line read fails

  339. Rob Swindell
    Sat Apr 09 2022 11:50:14 GMT-0700 (PDT)
    Modified Files:
    

    exec/imapservice.js diff
    Fix TypeError: args[1].toUpperCase is not a function Issue #389 reported by Keyop: srvc 0324 IMAPS <Keyop> !JavaScript /sbbs/exec/imapservice.js line 653: TypeError: args[1].toUpperCase is not a function I'm not sure how you reproduce this error or what type args[1] is (apparently, not a string), but this fix it regardless. Please let me know.

  340. Rob Swindell
    Sat Apr 09 2022 11:38:21 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/ansiterm_lib.js diff
    Fix the graphic(BIN)->ANSI->HTML translation issue reported by Keyop Broken in commit ce01d8a79d0263. F*ck the English language.

  341. Deucе
    Sat Apr 09 2022 11:34:29 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbscon.c diff
    Only remove the pid file if it has our pid in it.

  342. Rob Swindell
    Mon Apr 04 2022 19:53:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Include client IP address in HTTP-level error log messages

  343. Rob Swindell
    Mon Apr 04 2022 05:35:55 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Resolve GCC warnings Fixes isue #388 - no change in behavior

  344. Rob Swindell
    Sun Apr 03 2022 19:19:50 GMT-0700 (PDT)
    Modified Files:
    

    exec/webfileindex.ssjs diff
    Change sorting_description from const to var Since this script can be reloaded in the same scope. Fixes issue #387.

  345. Rob Swindell
    Sun Apr 03 2022 16:49:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    For sub-boards configured to export "ASCII Only", convert UTF-8 correctly This converts the body text as well as the to, from, and subject header fields (first to CP437, then to ASCII). This should address the issue raised in issue #386 with exporting UTF-8 sequences to some message networks.

  346. Rob Swindell
    Sun Apr 03 2022 15:49:03 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/file_size.js diff
    Remove the 'B' suffix in file_size_float() output To match behavior of changed xpdev->byte_estimated_to_str(). If the caller wants a 'B' suffix, they can add it.

  347. Rob Swindell
    Sun Apr 03 2022 15:51:09 GMT-0700 (PDT)
    Modified Files:
    

    exec/slog.js diff
    Updated to read csts.tab instead of csts.dab Also changed output to reflect slog.c more closely. I suppose only one of of these 2 "utilities" to read csts.tab should exist at some point. :-) Also added suport for "-r" and "-t" to be more modern and *nixy.

  348. Rob Swindell
    Thu Mar 31 2022 19:01:52 GMT-0700 (PDT)
    Added Files:
    

    exec/webfileindex.ssjs diff
    My initial/simple/ugly dynamic web file index generator Configured in sbbs.ini [web] by setting: FileVpathPrefix = /files/ FileIndexScript = webfileindex.ssjs And optionally (if you want your vhosts to get filebase access): FileVPathForVHosts = true You can use an .xjs file if you prefer.

  349. Rob Swindell
    Thu Mar 31 2022 18:56:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    When auto-deleting inactive users, log their real name too.

  350. Rob Swindell
    Thu Mar 31 2022 18:57:15 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Fix file list sorting by date, need to use the index not the header When loadfiles() calls sortfiles(), only the file's index records have been read in, so trying to sort on any header field won't work. This bug wasn't observable when sorting by date ascending, since that's the natural index order of the files already (order imported/added), only observed when sorting by date descending (newest at the top).

  351. Rob Swindell
    Thu Mar 31 2022 00:54:27 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/StatsFormUnit.cpp diff
    Update comment header block. That's all.

  352. Rob Swindell
    Thu Mar 31 2022 00:54:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/MainFormUnit.cpp diff
    Total timeon stats in days/hours/min format instead just massive minutes.

  353. Rob Swindell
    Thu Mar 31 2022 00:28:59 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/StatsFormUnit.dfm diff
    Double the width of the "Total" status text boxes to accommodate larger numbers/strings.

  354. Rob Swindell
    Thu Mar 31 2022 00:11:38 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Lower level of new "Logoff time <= logon time" log message ... from ERROR to WARNING, but log the human-readable logon time too. This condition can easily happen if the system clock is corrected (e.g. a few seconds via NTP adjustment) during a quick connect/disconnect. Don't call logoffstats() unless a user actually successfully logged-in. I don't think sysops actually want all the time bots sit at the logon prompt counted as "time online" in their stats anyway.

  355. Rob Swindell
    Wed Mar 30 2022 18:21:23 GMT-0700 (PDT)
    Modified Files:
    

    exec/sutils.ini diff
    Remove dstsedit (it's no longer a thing) Is anyone actually using sutils.js?

  356. Rob Swindell
    Wed Mar 30 2022 18:16:53 GMT-0700 (PDT)
    Modified Files:
    

    install/GNUmakefile diff
    remove dstsedit (it's gone)

  357. Rob Swindell
    Tue Mar 29 2022 20:12:51 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    CHAIN.TXT files need CRLF terminated lines This was a regression (to just LF-terminated lines), an accidental change (from "text" to "binary" file-open) in commit 07580ea7b1b6e.

  358. Rob Swindell
    Tue Mar 29 2022 20:15:17 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/getstats.c diff
    Use fnopen() in fopen_dstats() to get open auto-retries iniFileOpen() does not perform retries and there can be contention for the ctrl/dsts.ini file.

  359. Rob Swindell
    Tue Mar 29 2022 20:18:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Some archives don't have DIZ in the root directory (I'm looking at you, mist1221.zip) ... so first try to extract DIZ files from the root of the archive, then try again searching nested directories too. <sigh>

  360. Rob Swindell
    Tue Mar 29 2022 12:21:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Use PRIu64 for (newly) 64-bit user fields (credits, up/download bytes) Fixes recently-introduced crash when generating text drop files (e.g. XTRN.DAT, SFDOORS.DAT, DOOR.SYS, CHAIN.TXT) on Win32 (only) where a 'long int' is still just 32-bit.

  361. Rob Swindell
    Tue Mar 29 2022 01:57:44 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Fix slog build more (needs xpdev too, apparently)

  362. Rob Swindell
    Tue Mar 29 2022 01:24:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Fix slog build (now needs libsbbs.so)

  363. Rob Swindell
    Mon Mar 28 2022 23:53:58 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/date_str.c diff
    src/sbbs3/date_str.h diff
    Add minutes_to_str() function Generates a "Dd Hh Mm" string from a specified number of minutes.

  364. Rob Swindell
    Mon Mar 28 2022 23:54:55 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/dat_file.c diff
    src/xpdev/dat_file.h diff
    Add Open/CloseFile and ListFree methods

  365. Rob Swindell
    Mon Mar 28 2022 23:57:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsdefs.h diff
    Add enum CSTATS_FIELD definition Defines the field indexes for records in csts.ini

  366. Rob Swindell
    Tue Mar 29 2022 01:05:39 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/getstats.c diff
    src/sbbs3/getstats.h diff
    Add parse_cstats() function

  367. Rob Swindell
    Tue Mar 29 2022 01:14:01 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/StatsLogFormUnit.cpp diff
    src/sbbs3/slog.c diff
    src/sbbs3/slog.vcxproj diff
    Pretty much a total rewrite of the csts.* file parsing stuff Hunting down and destroying some super old SBBS code now. :-)

  368. Rob Swindell
    Tue Mar 29 2022 01:15:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    Posts from QWKnet users don't count as "posts" for local stats Might add some other statistic for these relayed posts at some point.

  369. Rob Swindell
    Tue Mar 29 2022 01:15:36 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/semfile.c diff
    Fix signed/unsigned compare warning reported by Borland C++.

  370. Rob Swindell
    Tue Mar 29 2022 01:16:13 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Use the pointer *after* checking that its not NULL Fixes CID 351271

  371. Eric Oulashin
    Mon Mar 28 2022 20:24:06 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu OnItemNav on initial display DDLightbarMenu can now optionally call its OnItemNav function when it's first displayed. By default this behavior is disabled, but it can be enabled by setting the (new) callOnItemNavOnStartup property to true.

  372. Rob Swindell
    Mon Mar 28 2022 22:28:34 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_onItemNav_startup' into 'master' DDLightbarMenu OnItemNav on initial display See merge request main/sbbs!168

  373. Rob Swindell
    Mon Mar 28 2022 01:41:02 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Fix the globi() change for *nix I was stripping the path here... oops.

  374. Rob Swindell
    Mon Mar 28 2022 01:20:27 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    Fix another new GCC warning I missed

  375. Rob Swindell
    Mon Mar 28 2022 01:20:27 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/gtkchat/objects.mk diff
    Fix build (needed getstats.o)

  376. Rob Swindell
    Mon Mar 28 2022 01:12:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/objects.mk diff
    src/sbbs3/sbbs3.sln diff
    src/sbbs3/targets.mk diff
    Removed Files:

    src/sbbs3/dstsedit.c diff
    src/sbbs3/dstsedit.vcxproj diff
    Eliminate DSTSEDIT, no longer needed */dsts.dab was replaced by dsts.ini. */dsts.ini is just a text file, you don't need a special editor.

  377. Rob Swindell
    Mon Mar 28 2022 01:02:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/getstats.c diff
    Resolve new GCC warnings

  378. Rob Swindell
    Mon Mar 28 2022 00:59:40 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/objects.mk diff
    src/sbbs3/scfg/objects.mk diff
    Fix *nix build, more things need to link with getstats.o now

  379. Rob Swindell
    Sun Mar 27 2022 21:58:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/MainFormUnit.cpp diff
    Remove unused stub function.

  380. Rob Swindell
    Mon Mar 28 2022 00:51:37 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/addfiles.c diff
    src/sbbs3/addfiles.vcxproj diff
    src/sbbs3/delfiles.vcxproj diff
    src/sbbs3/dupefind.vcxproj diff
    src/sbbs3/filelist.vcxproj diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/getstats.c diff
    src/sbbs3/getstats.h diff
    src/sbbs3/js_system.c diff
    src/sbbs3/logon.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/makeuser.vcxproj diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/sbbsecho.vcxproj diff
    src/sbbs3/scfg/scfg.vcxproj diff
    src/sbbs3/str.cpp diff
    src/sbbs3/upgrade_to_v319.vcxproj diff
    src/sbbs3/upload.cpp diff
    src/sbbs3/userdat.c diff
    Overhaul statistics files */dsts.dab (daily statistics and running totals) -> */dsts.ini */csts.dab (cumulative statistics / log) -> */csts.tab * dsts.ini now has both daily and total stats for all fields (not just timeon and logons). * dsts.ini is now an easily modifiable text file - no longer need dstsedit (here-by deprecated and soon to be deleted) * dsts.ini and csts.tab support 64-bit upload/download byte stats and are very extensible for future fields to be added or extended > 32-bit (this was the main inspiration for this overhaul, but it was overdue and already designed for v4, pretty much) * csts.tab is a tab-delimited fixed length record format suitable for easy import to a spreadsheet program or parsing with scripts. Each day is a 128-character LF-delimited record with tab-delimited fields of plain ASCII text. * All fields except timeon in dsts.ini files are updated immediately and by more non-terminal servers (e.g. post statistics from web UI scripts). * New user stats are tracked more than just for "today". The upgrade of these files is automatic and built-into SBBS. Still to do: overhaul the slog utility to support the new csts.tab file format.

  381. Rob Swindell
    Mon Mar 28 2022 00:52:16 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/text_defaults.c diff
    SubInfoViewFileQ and DirInfoViewFileQ are now blank by default

  382. Rob Swindell
    Sun Mar 27 2022 10:24:18 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Only filename portion of pattern for globi() shall be case-insensitive Windows doesn't allow multiple directories of the same name only differing in case, so don't on *nix either.

  383. Rob Swindell
    Sun Mar 27 2022 02:57:58 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/graphic.js diff
    Add auto_extend option If set to true, when setting the ANSI property, rather than throwing away vertically "scrolled" lines, just keep extending the height to accommodate the new required vertical size (height).

  384. Rob Swindell
    Sun Mar 27 2022 03:01:19 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/cga_defs.js diff
    Add from_attr_code[] table for mapping Ctrl-A attribute codes to CGA values

  385. Rob Swindell
    Sun Mar 27 2022 03:02:04 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/ansiterm_lib.js diff
    Define and use standard ANSI attribute codes and mappings to CGA values Create expand_ctrl_a() method that expands Ctrl-A attribute codes in a string into ANSI escape sequences.

  386. Rob Swindell
    Sun Mar 27 2022 03:04:15 GMT-0700 (PDT)
    Modified Files:
    

    exec/msglist.js diff
    Support scrolling ANSI messages in preview and view modes Supports mixed Ctrl-A and ANSI messages. ANSIs of any length should display correctly. ANSIs wider than 79 columns will be truncated (not horizontally scrollable). Animated ANSIs will not render with their animation sequences in tact. :-(

  387. Rob Swindell
    Sat Mar 26 2022 22:30:23 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.dat diff
    Disable prompt for sub/dir info by default, just show the file yes/no prompts can be disabled by just setting a string to a blank string. Disable these prompts by default (you can reeanble in your own text.dat if you want).

  388. Deucе
    Sat Mar 26 2022 21:23:59 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/graphic.js diff
    Fix bug

  389. Rob Swindell
    Sat Mar 26 2022 20:03:50 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/prntfile.cpp diff
    De-duplicate at the first '.' following the filename, not the path Fix the fix to issue #380. Thanks for letting me know Keyop.

  390. Rob Swindell
    Fri Mar 25 2022 10:21:15 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Uh, increment the pointer in globi() Fixes crash reported in #381.

  391. Rob Swindell
    Fri Mar 25 2022 01:16:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/str.cpp diff
    Remove the hard-coded ".msg" extension from data/subs/*.msg display file And data/dirs/*.msg display file. Now you can have any supported menu file in this location if you wish.

  392. Rob Swindell
    Fri Mar 25 2022 00:37:47 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/prntfile.cpp diff
    Detect/display menu files, even if only a .ans version exists I'm so tired of this 30 year old frequently asked question. If a sysop really wants their Synchronet BBS to only work correctly for ANSI users, I suppose that should be their prerogative. I always felt that by not detecting/displaying menu files when the minimum set of files was not present, I was helping sysops to identify an issue with their system (which would not work correctly for non-ANSI users). *And* I always felt that having a single menu/display file that correctly supported both ANSI and non-ANSI users was a nice convenience (who really wants to maintain multiple versions of their menu files?). But I'm so tired of answering this question, I just give up. Hopefully this doesn't break anything for anyone. <shrug>

  393. Rob Swindell
    Thu Mar 24 2022 23:58:00 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/prntfile.cpp diff
    Revert to *.XXcol.* being an exact column width, add *.cXX.* support That previous commit made all *.40col.msg files display for 80 column users. Not my intention. So revert to the previous behavior of *.XXcol.* display files. I didn't want to go renaming a bunch of menu files as a result of the previous commit and I didn't want a bunch of sysops with *.XXcol.* files to be suddenly surprised at their new BBS behavior. And introduce a new file naming convention, *.cXX.* (where XX is a MINIMUM column width). This is the same naming convention used by Mystic, which also treats it is as a minimum terminal width, not a required exact width.

  394. Eric Oulashin
    Wed Mar 23 2022 20:32:38 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Now calls bbs.edit_msg() to edit an existing message. Now calls bbs.edit_msg() to edit an existing message (if that function exists - It was added in Synchronet 3.18).

  395. Rob Swindell
    Thu Mar 24 2022 23:27:34 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_bbs_edit_msg' into 'master' DDMsgReader: Now calls bbs.edit_msg() to edit an existing message. See merge request main/sbbs!167

  396. Rob Swindell
    Thu Mar 24 2022 23:06:28 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    src/xpdev/dirwrap.h diff
    Introduce case-insensitive version of glob(): globi() glob() is case-insensitive on Windows already, so create a work-alike for *nix.

  397. Rob Swindell
    Thu Mar 24 2022 23:14:15 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/prntfile.cpp diff
    Use text/menu/*.###col.* display files for even-wider terminals e.g. display basename.132col.msg even if the terminal is 133+ columns wide. Fixes issue #380.

  398. Rob Swindell
    Thu Mar 24 2022 21:40:42 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/prntfile.cpp diff
    De-dupe random menu filenames by truncating at first dot, rather than last. Fix for one of the problems described in issue #380. bbs.menu("random*"); would display column-width-specific files (e.g. random.132col.msg) even when they weren't appropriate for the current user terminal width. This is fixed by truncating the filenames matching the requested pattern at their first-dot rather than the last. The downside is, you can't have a set of random.#.* files, where # is the unique part of the filename and * is the file-type extension. Just use the naming pattern "random-#.*" instead (or something similar) instead.

  399. Rob Swindell
    Thu Mar 24 2022 12:40:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfglib.h diff
    DLL-export is_valid_XXXnum() functions, for web server use Fixes recently broken Win32 build

  400. Rob Swindell
    Wed Mar 23 2022 21:17:13 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/getmsg.cpp diff
    src/sbbs3/uedit/uedit.c diff
    src/sbbs3/xtrn_sec.cpp diff
    Fix newly-introduced GCC warnings

  401. Rob Swindell
    Wed Mar 23 2022 21:17:42 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.dat diff
    Credits don't need 13 characters to display now Since we're not displaying the exact value to the byte, with commas

  402. Rob Swindell
    Wed Mar 23 2022 19:54:21 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    byte-count to string routines type unsigned 64-bit int now We don't have a use case negative byte values in strings anywhere that I can think of. Created wrapper for MSFT _ui64toa_() - unsigned 64-bit integer to ASCII string. Add Petabyte (actually, Pebibyte) support to byte_count_to_str() and byte_estimate_to_str(). Removed 'B' suffix from byte_estimate_to_str() output for values < 1024. Callers may display this returned string followed by "bytes" (or similar) and thus the 'B' suffix is redundant in that case. If the caller needs a 'B' suffix, they can detect no suffix and add it.

  403. Rob Swindell
    Wed Mar 23 2022 20:14:37 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/getstats.c diff
    Add TODO comment about dsts.dab not tracking > 4GB up/downloads

  404. Rob Swindell
    Wed Mar 23 2022 21:07:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/bat_xfer.cpp diff
    src/sbbs3/chat.cpp diff
    src/sbbs3/chk_ar.cpp diff
    src/sbbs3/data.cpp diff
    src/sbbs3/download.cpp diff
    src/sbbs3/exec.cpp diff
    src/sbbs3/file.cpp diff
    src/sbbs3/filedat.c diff
    src/sbbs3/filelist.c diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/getmsg.cpp diff
    src/sbbs3/js_user.c diff
    src/sbbs3/listfile.cpp diff
    src/sbbs3/logon.cpp diff
    src/sbbs3/netmail.cpp diff
    src/sbbs3/pack_qwk.cpp diff
    src/sbbs3/qwk.cpp diff
    src/sbbs3/readmsgs.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgsys.c diff
    src/sbbs3/scfgdefs.h diff
    src/sbbs3/scfglib1.c diff
    src/sbbs3/scfgsave.c diff
    src/sbbs3/str.cpp diff
    src/sbbs3/str_util.c diff
    src/sbbs3/str_util.h diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/uedit/uedit.c diff
    src/sbbs3/upload.cpp diff
    src/sbbs3/userdat.c diff
    src/sbbs3/userdat.h diff
    src/sbbs3/useredit.cpp diff
    src/sbbs3/xtrn.cpp diff
    src/sbbs3/xtrn_sec.cpp diff
    Support user credits and transfer stats > 4GB in total Credits and daily free credits are accurate to the byte up to (a maximum) of 18446744073709551615 (that's 18 Exbibytes - 1). User's upload and download byte stats are now similarly extended in maximum range, but the accuracy is only "to the byte" for values less than 10,000,000,000. Beyond that value, the accuracy declines, but is generally pretty damn accurate (to 4 decimal places beyond the nearest multiple of a power of 1024), so I don't expect that to be an issue. This method of storing upload/download byte stats allowed me to use the same 10-character user record fields in the user.dat file. As a side-effect of this enhancements: * User and file credit values are now expressed in multiples of powers of 1024 (e.g. 4.0G rather than 4,294,967,296). * Free credits per day per security level has now been extended from 32 to 64-bits (to accommodate values >= 4GB). * adjustuserrec() now longer takes the record length since we can easily determine that automatically and don't need more "sources of truth" that can be out-of-sync (e.g. the U_CDT field length going from 10 to 20 chars with this change). * setting the stage for locale-dependent thousands-separators (e.g. space instead of comma) - currently still hard-coded to comma * more/better support for files > 4GB in size (e.g. in the batch download queue) * user_t ulong fields changed to either uint32_t or uint64_t - I didn't realize how many long/ulong's remained in the code (which are sometmies 32-bit, sometimes 64-bit) - ugh * Steve's ultoac() function renamed to u32toac() and created a C++ wrapper that still uses the old name, for homage

  405. Rob Swindell
    Mon Mar 21 2022 01:38:25 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    Fix newly introduced GCC warning warning: invalid suffix on literal; C++11 requires a space between literal and string macro

  406. Rob Swindell
    Mon Mar 21 2022 01:27:15 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/bat_xfer.cpp diff
    src/sbbs3/file.cpp diff
    src/sbbs3/filelist.c diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/js_bbs.cpp diff
    src/sbbs3/js_filebase.c diff
    src/sbbs3/js_msgbase.c diff
    src/sbbs3/pack_qwk.cpp diff
    src/sbbs3/upload.cpp diff
    src/smblib/smbdefs.h diff
    src/smblib/smblib.c diff
    SMB items (messages or files) can now have 32-bit or 64-bit cost value To fully support files > 4GB in size in file bases, credit values larger than 32-bits must be supported too. There's a couple of todo comments/items included in this commit, but that's mainly to do with messages (which don't really have costs anyway). The main thing to deal with now is the fact that users can't have more than 4GB in credits in the first place! That's got to be fixed next.

  407. Rob Swindell
    Mon Mar 21 2022 01:35:07 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    Merge branch 'master' of gitlab.synchro.net:main/sbbs

  408. Rob Swindell
    Mon Mar 21 2022 00:00:01 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    Fix newly-encountered GCC warning comparison of integer expressions of different signedness: ‘off_t’ {aka ‘long int’} and ‘uint64_t’ {aka ‘long unsigned int’}

  409. Rob Swindell
    Sun Mar 20 2022 23:53:50 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    src/sbbs3/filedat.c diff
    src/sbbs3/js_filebase.c diff
    src/sbbs3/smbutil.c diff
    src/smblib/smbdefs.h diff
    src/smblib/smbfile.c diff
    src/smblib/smblib.c diff
    src/smblib/smblib.h diff
    Support files > 4MB in SMB filebase indexes Used the reserved 16-bits in the file index record to extend the supported index-file-size from 4294967295 (4GB) to 281474976710655 (281TB). I think that's big enough for the foreseeable future. :-)

  410. Rob Swindell
    Sun Mar 20 2022 21:13:56 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/fmsgdump.c diff
    src/sbbs3/pktdump.c diff
    Get rid of CVS keywords and parsing for revision

  411. Rob Swindell
    Sun Mar 20 2022 21:16:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    src/sbbs3/js_filebase.c diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgxfr2.c diff
    Add options to sort directories by file size (ascending or descending) Size is indexed, so might as well sort by it. This does have an issue with files >= 4GB in length however, so I'm looking at that next.

  412. Rob Swindell
    Sun Mar 20 2022 19:55:26 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxfr2.c diff
    Update the help text for the "file existence check" option This option actually controls whether the disk will be queried for the current file size and modification date/time (when listing) too.

  413. Rob Swindell
    Sun Mar 20 2022 19:57:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    Create some convenience functions for validating lib/dir/grp/sub nums There are lot of places in the code where subnums and dirnums (especially) are compared against total_subs and/or total_dirs or >= 0 without a ton of consistency. We should migrate to use these functions for validity-checking going forward.

  414. Rob Swindell
    Sun Mar 20 2022 20:32:03 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    File's meta-object's "size" and "time" properties reflect current values Query the disk for file's current "size" and "time" values when get_list() or get() method is used with a "detail" level of >= DETAIL.NORMAL and the "check file existence" toggle option is enabled for this directory in SCFG. I pondered and contemplated whether this configuration setting should be checked/applied here or in the various JS scripts (e.g. filelist.js) and decided here was best to provide the most uniform/expected behavior, even though there is a performance impact. If a script doesn't need/use these properties, they should probably be specifying the DETAIL.MIN (minimal) detail level in their queries anyway, which will then bypass these performance-impacting disk queries.

  415. Rob Swindell
    Sun Mar 20 2022 16:26:20 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Resolve warning about enum value not handled in switch() statement

  416. Rob Swindell
    Sun Mar 20 2022 16:22:21 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    Linux needs strlcpy() defined in xpdev

  417. Rob Swindell
    Sun Mar 20 2022 16:23:35 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_system.c diff
    typedefs to suppress warnings about using JS_ValueToECMAUint32 w/int32_t

  418. Rob Swindell
    Sat Mar 19 2022 19:50:28 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_system.c diff
    Use JS_ValueToECMAUint32 for full 32-bit time_t values Resolves issue with filelist.js trying to pass 4294967295 (-1) to system.datestr() resulting in: !JavaScript /sbbs/exec/filelist.js line 13: Error: can't convert t to an integer

  419. Rob Swindell
    Sun Mar 20 2022 15:05:38 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/js_file_area.c diff
    src/sbbs3/sbbs_ini.c diff
    src/sbbs3/userdat.c diff
    src/sbbs3/userdat.h diff
    src/sbbs3/websrvr.c diff
    src/sbbs3/websrvr.h diff
    Add dynamic file area/base indexing to web server By setting sbbs.ini [web] FileIndexScript to an SSJS or XJS script filename, that script (by default, from your exec directory) will be executed when a file area/base listing has been http[s]-requested. File area/base requests are of the form <vpath_prefix> (for the list of libraries), <vpath_prefix>/<lib-name>/ (for list of directories of a library) or <vpath_prefix>/<lib-name>/<dir-code-suffix>/ (for a list of files in a directory). The new http_request "lib" and "dir" properties indicate that a library or directory listing was requested (if neither are defined, that's a request for the root / list of libs). The same configured script is executed to handle all 3 types of index/list requests. A sample script (webfileindex.ssj) will be committed soon. Authentication (via HTTP-AUTH) will be required if user #0 does not have access to all libraries or all directories within a required library. file_area.lib[].link has been changed from "/<vdir>/" to just "<vdir>" (no slashes) and renamed to "vdir". file_area.dir[].link has been changed from "/<vpath>/" to "<vpath>/" (no leading slash) and renamed to "vpath". Added file_area.dir[].vdir property that contains just the directory's virtual directory name. I don't think anyone was using these "link" properties since the dynamic FTP HTML index scripting feature is no longer supported. Added can_user_access_lib() to insure that the user has access to at least one directory of a library before allowing access to the library (e.g. via JS). Something similar should be created for message groups.

  420. Eric Oulashin
    Thu Mar 17 2022 14:01:05 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightarMenu: For numbered mode, implemented a fix for refreshing the menu after the user types an item number to select/highlight it. Also, added 2 new color settings to specify the color to use for writing the item numbers: itemNumColor (for non-highlighted items) and highlightedItemNumColor (for the current highlighted item).

  421. Rob Swindell
    Fri Mar 18 2022 18:09:02 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_numbered_mode_draw_update' into 'master' DDLightarMenu: Numbered mode item refresh fix & new item number colors See merge request main/sbbs!164

  422. Eric Oulashin
    Fri Mar 18 2022 15:31:48 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    DD area choosers: For message sub-board/file directory collapsing, if there's only one sub-group/sub-library, then it won't be collapsed DD area choosers v1.23: For message sub-board/file directory collapsing, if there's only one sub-group/sub-library, then it won't be collapsed, as that wouldn't be very useful.

  423. Rob Swindell
    Fri Mar 18 2022 18:01:19 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'dd_area_choosers_all_separators_no_collapse' into 'master' DD area choosers: No sub-board/library collapsing if all have the same separator See merge request main/sbbs!165

  424. Rob Swindell
    Thu Mar 17 2022 00:04:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/fmsgdump.c diff
    Fix CID 229603: String not null terminated

  425. Rob Swindell
    Wed Mar 16 2022 20:07:00 GMT-0700 (PDT)
    Modified Files:
    

    exec/sbbslist.js diff
    Don't prompt yes/no upon remove if run with -quiet option for Andre

  426. Rob Swindell
    Tue Mar 15 2022 18:21:23 GMT-0700 (PDT)
    Modified Files:
    

    exec/chat_sec.js diff
    Optional channel list per server configured in modopts.ini So you have multiple IRC servers configured in modopts.ini and you want different channel list per server? Just add more keys to the modopts.ini [chat_sec] section of the form: <server>=<channel_list> Where <server> is the IRC server's host name (e.g. irc.synchro.net) and <channel_list> is a comma-separated list of channels to override the default list of channels (set with the "irc_channel" key). For DesotoFireflite (VALHALLA)

  427. Eugene So
    Tue Mar 15 2022 10:06:34 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord/lord.js diff
    LORD: Fix daily bank transfer count not being reset properly

  428. Rob Swindell
    Tue Mar 15 2022 11:00:27 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord/lord.js diff
    Merge branch 'eugeneso/lord_bankxfer_fix' into 'master' LORD: Fix daily bank transfer count not being reset properly See merge request main/sbbs!163

  429. Eugene So
    Tue Mar 15 2022 08:48:26 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord/lord.js diff
    LORD: Fix online duel event Fixed broken code when taunting opponent Fixed broken code when aborting after waiting a long time for opponent to respond.

  430. Rob Swindell
    Tue Mar 15 2022 11:00:01 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/lord/lord.js diff
    Merge branch 'eugeneso/lord_online_duel_fix' into 'master' LORD: Fix online duel event See merge request main/sbbs!162

  431. Eric Oulashin
    Tue Mar 15 2022 09:11:35 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Added back a few functions that were accidentally removed Added back a few functions that were accidentally removed (which weren't moved to attr_conv.js)

  432. Rob Swindell
    Tue Mar 15 2022 10:57:04 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'ddmr_add_ansi_funcs_back' into 'master' DDMsgReader: Added back a few functions that were accidentally removed See merge request main/sbbs!161

  433. Eric Oulashin
    Mon Mar 14 2022 23:17:00 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/readme.txt diff
    Removed references to old files

  434. Rob Swindell
    Tue Mar 15 2022 10:56:47 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/readme.txt diff
    Merge branch 'ddmr_doc' into 'master' Removed references to old files See merge request main/sbbs!160

  435. Eric Oulashin
    Mon Mar 14 2022 16:47:53 GMT-0700 (PDT)
    Added Files:
    

    xtrn/DDMsgReader/ddmr_lm.js diff
    Modified Files:

    exec/load/attr_conv.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Removed Files:

    xtrn/DDMsgReader/loadable_module_scripts/DDReadPersonalMail.js diff
    xtrn/DDMsgReader/loadable_module_scripts/DDScanMsgs.js diff
    xtrn/DDMsgReader/loadable_module_scripts/DDScanSubs.js diff
    DDMsgReader can be called directly as a loadable module

  436. Rob Swindell
    Mon Mar 14 2022 16:47:53 GMT-0700 (PDT)
    Added Files:
    

    xtrn/DDMsgReader/ddmr_lm.js diff
    Modified Files:

    exec/load/attr_conv.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Removed Files:

    xtrn/DDMsgReader/loadable_module_scripts/DDReadPersonalMail.js diff
    xtrn/DDMsgReader/loadable_module_scripts/DDScanMsgs.js diff
    xtrn/DDMsgReader/loadable_module_scripts/DDScanSubs.js diff
    Merge branch 'ddmr_loadable_module_update' into 'master' DDMsgReader can be called directly as a loadable module See merge request main/sbbs!159

  437. Rob Swindell
    Sun Mar 13 2022 23:43:15 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/upload.cpp diff
    MSVC didn't like that use of std::min(), so just go back to a macro

  438. Rob Swindell
    Sun Mar 13 2022 23:38:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/upload.cpp diff
    Fix issues with std::min() again... std::min() requires both arguments be of same type too.

  439. Rob Swindell
    Sun Mar 13 2022 23:38:54 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.dat diff
    Add new strings: HashingFile and HashedFile

  440. Rob Swindell
    Sun Mar 13 2022 23:15:56 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Create *nix wrapper for MSVC's _i64toa()

  441. Rob Swindell
    Sun Mar 13 2022 23:16:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/str_util.c diff
    src/sbbs3/str_util.h diff
    Create i64toac() to generate comma-separated ASCII string of 64-bit int

  442. Rob Swindell
    Sun Mar 13 2022 23:17:29 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    Use new i64toac() function to support files > 4GB in size

  443. Rob Swindell
    Sun Mar 13 2022 23:18:21 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    New strings: HashingFile and HashedFile To display (rather than "Searching for Dupes") when calculating file hashes.

  444. Rob Swindell
    Sun Mar 13 2022 23:19:24 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/upload.cpp diff
    Use new Hashing/HashedFile text.dat strings, better > 4GB file support Resolve issues displaying file sizes > 4GB and calculating credit values.

  445. Rob Swindell
    Sun Mar 13 2022 23:33:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/listfile.cpp diff
    Save the node status (with "downloading" action value) More immediately. I wanted to debug the ETA value here and the action wasn't written to the node file here, but later.

  446. Eric Oulashin
    Sun Mar 13 2022 21:51:24 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Fix for "fileDesc is not defined" error when displaying the file description on the main screen. ddfilelister version 2.05a: Fix for "fileDesc is not defined" error when displaying the file description on the main screen. Also made a small refactor to the main screen refresh function.

  447. Rob Swindell
    Sun Mar 13 2022 22:09:40 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'ddfilelister_filedesc_undefined_fix' into 'master' Fix for "fileDesc is not defined" error when displaying the file description on the main screen. See merge request main/sbbs!158

  448. Rob Swindell
    Sun Mar 13 2022 18:34:25 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/smbtxt.c diff
    Replace sprintf() calls with safe_snprintf()

  449. Rob Swindell
    Sun Mar 13 2022 18:54:21 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/smbtxt.c diff
    Fix heap corruption of qp_decode() qp_decode (quoted-printable in-place decode of a string) could write 2 characters *beyond* the allocated buffer by appending "\r\n" to a string that was not quoted-printable in the first place. i.e. the contents of buf were not actually changed in the decode loop. This could result in a corrupted heap and crash of sbbs or smbutil when reading such a message. This change may result in a lack of CRLF appended to decoded plain text output, so we'll have to keep an eye out for that and resolve it some other way. One possibility could be to only append the CRLF if the destination pointer is sufficiently behind the source pointer. This solves the crash that Kirkman reported with a specific message in his "mail" base. The header for the message said it was quoted-printable encoded, but the body text was not actually encoded at all: OtherHeader Content-Type: text/plain; charset="iso-8859-1" OtherHeader MIME-Version: 1.0 OtherHeader Content-Transfer-Encoding: quoted-printable

  450. Rob Swindell
    Sun Mar 13 2022 16:53:59 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Apparently we need to use the backtick method of shell expression here

  451. Rob Swindell
    Sun Mar 13 2022 15:05:22 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/sdk/xsdk.c diff
    Resolve warning: type defaults to ‘int’ in declaration

  452. Rob Swindell
    Sun Mar 13 2022 14:33:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Use whereis to find setcap install location and cut to trim the output <Dan_C> DigitalMan: minor install issue noted today - during a fresh (Linux) install on a test box, the build failed because it was unable to execute the "sudo setcap ..." command. This was on Slackware 15.0, where the setcap executable is located in /sbin , and that directory is not in the $PATH of a normal user, or even when a normal user uses the 'sudo' command.

  453. Rob Swindell
    Sun Mar 13 2022 14:30:17 GMT-0700 (PDT)
    Modified Files:
    

    install/GNUmakefile diff
    Revert "Apparently setcap isn't in /sbin for all Linux distros" This reverts commit 6a2c3722966ff2fd4ca6a114e035d4bd4f340dfc. SETCAP isn't a command-line afterall, it's a build target.

  454. Rob Swindell
    Sun Mar 13 2022 14:30:44 GMT-0700 (PDT)
    Modified Files:
    

    install/GNUmakefile diff
    Revert "Make the default SETCAP value to be /sbin/setcap" This reverts commit 2869cfb81e5436e4eaf58e58c9a7951ae92a757c. SETCAP isn't a command-line after all, it's a build target.

  455. Rob Swindell
    Sun Mar 13 2022 14:09:57 GMT-0700 (PDT)
    Modified Files:
    

    install/GNUmakefile diff
    Apparently setcap isn't in /sbin for all Linux distros So use 'whereis' to find and and 'cut' to trim its output

  456. Rob Swindell
    Sun Mar 13 2022 13:38:07 GMT-0700 (PDT)
    Modified Files:
    

    install/GNUmakefile diff
    Make the default SETCAP value to be /sbin/setcap <Dan_C> DigitalMan: minor install issue noted today - during a fresh (Linux) install on a test box, the build failed because it was unable to execute the "sudo setcap ..." command. This was on Slackware 15.0, where the setcap executable is located in /sbin , and that directory is not in the $PATH of a normal user, or even when a normal user uses the 'sudo' command. Also include SETCAP in the set of documented make variables.

  457. Rob Swindell
    Sun Mar 13 2022 00:38:35 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Fix CID 174355: Big parameter passed by value

  458. Rob Swindell
    Sun Mar 13 2022 00:28:01 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/netmail.cpp diff
    Fix CID 319119: Unchecked return value from library Actually probably doesn't fix it, but what'evs

  459. Rob Swindell
    Sun Mar 13 2022 00:22:39 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Fix CID 350312: Uninitialized scalar variable

  460. Rob Swindell
    Sun Mar 13 2022 00:26:30 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Fix CID 319133: Unchecked return value

  461. Rob Swindell
    Sun Mar 13 2022 00:18:44 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Fix CID 33235: Argument cannot be negative

  462. Rob Swindell
    Sun Mar 13 2022 00:11:56 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    Paste the table of supported drop files (write and/or read) into F1 help Also, when hitting ESC at the "Use Real Names" prompt, don't prompt for the Lower-casing of the drop file name.

  463. Rob Swindell
    Sat Mar 12 2022 23:20:20 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Address warnings introduced in previous commit

  464. Rob Swindell
    Sat Mar 12 2022 23:20:40 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/pcbdefs.hpp diff
    Fix min() not being in scope when using GCC <C++, shrug>

  465. Rob Swindell
    Sat Mar 12 2022 23:21:04 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Address new warning

  466. Rob Swindell
    Sat Mar 12 2022 22:42:06 GMT-0800 (PDT)
    Added Files:
    

    src/encode/endian.hpp diff
    Template lib for dealing with endian-specific data types Just integers right now. And only big or little endian.

  467. Rob Swindell
    Sat Mar 12 2022 22:43:28 GMT-0800 (PDT)
    Modified Files:
    

    src/encode/pascal_types.hpp diff
    Use endian.hpp for the LittleEndInt template

  468. Rob Swindell
    Sat Mar 12 2022 22:43:56 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/qbbsdefs.hpp diff
    Correct the harmless wrong filename in the include-guard

  469. Rob Swindell
    Sat Mar 12 2022 23:11:04 GMT-0800 (PDT)
    Added Files:
    

    src/sbbs3/pcbdefs.hpp diff
    PCBoard type definitions for PCBOARD.SYS and USERS.SYS files PCBOARD.SYS is officially the worst file format ever invented, not just the worst BBS drop file format ever invented. What were these guys smoking?!? I don't know what reference I used almost 30 years ago when I first implemented PCBOARD.SYS file support, but this time I used the PCBoard v15.3 source code (e.g. sys.c and usersys.c) and even their own code seems to work really hard to conform to these crazy file formats. USERS.SYS is a little more sane, but not by a lot. C++ features make this cleaner/easier, but man... there's just so much polish you apply to these turds. I guess (and hope) that nobody's really running programs that depend on/use these file formats. <shrug>

  470. Rob Swindell
    Sat Mar 12 2022 23:13:10 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Use buffered file I/O when writing drop files and overhaul PCBOARD.SYS ... and USERS.SYS file creation using new C++ type definitions in pcbdefs.hpp. This mostly fixes issue #366.

  471. Rob Swindell
    Sat Mar 12 2022 21:07:18 GMT-0800 (PDT)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Display textual version of msg attributes when using 'r'ead command Also displays net and aux attribute values when non-zero (weren't displayed at all with the 'r'ead command previously).

  472. Eric Oulashin
    Sat Mar 12 2022 11:57:26 GMT-0800 (PST)
    Added Files:
    

    exec/load/attr_conv.js diff
    Modified Files:

    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    ddfilelister: Now displays extended description in list view if the user has that setting enabled ddfilelister version 2.05 - Now makes use of the user's extended file description setting: If the user's extended file description setting is enabled, the lister will now show extended file descriptions on the main screen in a split format, with the lightbar file list on the left and the extended file description for the highlighted file on the right. Also, made the file info window taller for terminals within 25 lines high. This should resolve issue #363 . This update to ddfilelister also requires the included update to dd_lightbar_menu.js and the new attr_conv.js.

  473. Rob Swindell
    Sat Mar 12 2022 18:53:07 GMT-0800 (PDT)
    Added Files:
    

    exec/load/attr_conv.js diff
    Modified Files:

    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'ddfilelister_extd_desc_setting' into 'master' ddfilelister: Now displays extended description in list view if the user has that setting enabled Closes #363 and #374 See merge request main/sbbs!157

  474. Rob Swindell
    Fri Mar 11 2022 21:42:43 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Remove now-unneeded str2pas() function Functionality replaced with Pascal::String

  475. Eugene So
    Fri Mar 11 2022 09:41:50 GMT-0800 (PST)
    Modified Files:
    

    xtrn/lord/aratime/aratime.js diff
    LORD: Fix crash when exiting aratime igm

  476. Rob Swindell
    Fri Mar 11 2022 10:06:48 GMT-0800 (PST)
    Modified Files:
    

    xtrn/lord/aratime/aratime.js diff
    Merge branch 'eugeneso/lord_aratime_fix' into 'master' LORD: Fix crash when exiting aratime igm See merge request main/sbbs!156

  477. Rob Swindell
    Fri Mar 11 2022 00:08:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Add subject.can (Subject filter file) support For Trikester (DOVEMOD/BSMNTQQ)

  478. Rob Swindell
    Thu Mar 10 2022 23:54:20 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/uifc.h diff
    src/uifc/uifc32.c diff
    src/uifc/uifcx.c diff
    UIFC "list" now supports an optional left/right arrow key indicator Passing either WIN_LEFTKEY or WIN_RIGHTKEY in the window "mode" argument enables this new indicator in the upper right of "list" windows. These indicator arrows are mouse-clickable too (translate to the left and right arrow keys). We had defined uses for all 32 available WIN_* mode bits, so I extended the win mode type from 32 to 64 bits (should this now be called uifc64.c?) :-) Anyway, it'll be easier to add more WIN_* mode flags as needed later, but I do wonder about JavaScript support (not so great for > 31-bit integers).

  479. Rob Swindell
    Thu Mar 10 2022 23:56:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgmsg.c diff
    src/sbbs3/scfg/scfgsub.c diff
    src/sbbs3/scfg/scfgxfr2.c diff
    src/sbbs3/scfg/scfgxtrn.c diff
    Use the new UIFC WIN_LEFTKEY/RIGHTKEY mode flags to enable indicators A visual clue that there was a new navigation method available on some menus (where left/right arrow keys cycle through configured item) was needed. This seems to work nicely.

  480. Rob Swindell
    Thu Mar 10 2022 19:04:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    Change online program and program section via left/right arrow keys Similar to how we can now cycle through the file areas and message areas using left and right arrow keys, do the same for external "online" program sections and program (door) configurations.

  481. Rob Swindell
    Thu Mar 10 2022 19:06:04 GMT-0800 (PST)
    Modified Files:
    

    exec/load/text.js diff
    Latest generated text.js Note: TEXT_TEXT is actually off-by-one here. I suppose there's no need/use for that value anyway.

  482. Rob Swindell
    Thu Mar 10 2022 19:07:17 GMT-0800 (PST)
    Modified Files:
    

    src/encode/pascal_types.hpp diff
    Add Pascal::String::max_size() method Rename len() method to length() to align with std::string.

  483. Rob Swindell
    Thu Mar 10 2022 00:24:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/postmsg.cpp diff
    Fix various Clang warnings seen on FreeBSD build.

  484. Rob Swindell
    Thu Mar 10 2022 00:24:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/putmsg.cpp diff
    Fix Clang warnings.

  485. Rob Swindell
    Thu Mar 10 2022 00:15:53 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/filewrap.h diff
    Fix FreeBSD/Clang C++ error /usr/include/c++/v1/iterator:1168:87: error: expected unqualified-id ...&& traits_type::eq_int_type(__sbuf_->sputc(__c), traits_type::eof())) ^ /src/sbbs3/../xpdev/filewrap.h:124:21: note: expanded from macro 'eof' #define eof(fd) (tell(fd)==filelength(fd))

  486. Rob Swindell
    Wed Mar 09 2022 23:43:12 GMT-0800 (PST)
    Modified Files:
    

    src/encode/pascal_types.hpp diff
    I think type_traits header is technically required for static_assert() Does this fix the FreeBSD/clang build?

  487. Rob Swindell
    Wed Mar 09 2022 22:47:19 GMT-0800 (PST)
    Modified Files:
    

    src/encode/pascal_types.hpp diff
    Interesting, these modern sea plus plusisms This was necessary to get to build for MSVC2019 and GCC 8.3.0

  488. Rob Swindell
    Wed Mar 09 2022 22:26:04 GMT-0800 (PST)
    Modified Files:
    

    exec/str_cmds.js diff
    Fix typos and add the -pause option to the node command-lines Fix issue #372

  489. Rob Swindell
    Wed Mar 09 2022 22:22:09 GMT-0800 (PST)
    Modified Files:
    

    text/menu/sysmain.asc diff
    s/preceeded/preceded

  490. Rob Swindell
    Wed Mar 09 2022 22:19:32 GMT-0800 (PST)
    Modified Files:
    

    text/menu/attr.asc diff
    text/menu/sysxfer.asc diff
    s/preceeded/preceded

  491. Rob Swindell
    Wed Mar 09 2022 22:11:15 GMT-0800 (PST)
    Modified Files:
    

    src/encode/pascal_types.hpp diff
    std::min() wasn't in scope when using gcc <shrug>

  492. Rob Swindell
    Wed Mar 09 2022 22:11:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Remove unused variable

  493. Rob Swindell
    Wed Mar 09 2022 22:05:32 GMT-0800 (PST)
    Added Files:
    

    src/encode/pascal_types.hpp diff
    A C++ header-only library for dealing with Pascal data types (e.g. those stored in files, e.g. EXITINFO.BBS).

  494. Rob Swindell
    Wed Mar 09 2022 22:06:10 GMT-0800 (PST)
    Added Files:
    

    src/sbbs3/qbbsdefs.hpp diff
    QuickBBS structure definitions (for EXITINFO.BBS)

  495. Rob Swindell
    Wed Mar 09 2022 22:07:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Overhaul EXITINFO.BBS creation using C++ templated classes Ah, that's better. Actually would work correctly on big-endian platforms (should we ever support one) and with way less code.

  496. Rob Swindell
    Wed Mar 09 2022 20:54:54 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpendian.h diff
    Fix LE/BE_INT() and BYTE_SWAP_INT() for 64-bit long targets (Linux-x64) long is 64-bits (8 bytes), not 32-bit on some target platforms (e.g. Linux-x64), so don't assume sizeof(long)==4. It appears we weren't using these "automatic" integer-size macros anywhere that I can see, so no harm, but might as well fix them. Also remove BYTE_SWAP_SHORT and BYTE_SWAP_LONG since they're terribly named. Retain the LE/BE_SHORT/LONG macros since we're using them currently in SBBS (e.g. js_file.c).

  497. Rob Swindell
    Wed Mar 09 2022 20:55:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/fmsgdump.c diff
    Don't #include xpendian.h since we're not using it

  498. Rob Swindell
    Wed Mar 09 2022 20:57:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/qwk.cpp diff
    src/sbbs3/qwknodes.c diff
    src/sbbs3/sbbsecho.c diff
    src/sbbs3/scfglib1.c diff
    Fix assumptions about sizeof(long/ulong) So I did a search through the code for sizeof.*long and was surprised to find some remaining (harmless) assumptions that a long is 32-bit.

  499. Rob Swindell
    Wed Mar 09 2022 18:28:59 GMT-0800 (PST)
    Modified Files:
    

    exec/logonlist.js diff
    Fix off-by-one error in previous commit The default (when no argument to the '-l' option is provided) is to use the last_few_callers value from the modopts.ini file. This was broken.

  500. Rob Swindell
    Wed Mar 09 2022 14:19:44 GMT-0800 (PST)
    Modified Files:
    

    exec/load/logonlist_lib.js diff
    get() method supports reading entries from multiple days If days_ago argument is undefined (as is the case when performing a "last few callers" query/list), then pull upto the maximum last number of callers from previous days as necessary. Part of fix for issue #371

  501. Rob Swindell
    Wed Mar 09 2022 14:22:06 GMT-0800 (PST)
    Modified Files:
    

    exec/logonlist.js diff
    By default, '-l' (last few callers) option will pull from previous days If modopts.ini [logonlist] last_few_days is set (to a number), that will dictate the maximum number of previous days to pull last few callers from (e.g. set to '0' for previous behavior). Also, '-l' can now be used with a command-line option (e.g. '-l <num>') to specify the number of callers to display (overriding the modopts.ini last_fwe_callers value). This should address issue (feature request) #371.

  502. Eric Oulashin
    Wed Mar 09 2022 09:41:03 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Bug fix: Now successfully formats filenames without extensions when listing files. Version 2.04 - Bug fix: Now successfully formats filenames without extensions when listing files. This addresses issue #369.

  503. Rob Swindell
    Wed Mar 09 2022 09:58:20 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'ddfilelister_filename_no_ext_fix' into 'master' DD File Lister bug fix: Now successfully formats filenames without extensions when listing files. See merge request main/sbbs!155

  504. Rob Swindell
    Tue Mar 08 2022 23:33:35 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Fix EXITINFO.BBS generation for 64-bit time_t and more So I was working on re-writing some of this door file generation code and noticed that the EXITINFO.BBS files generated by SBBS: 1. had a lot of garbage data filling unused string characters (no "harm", but potentially leaking information) 2. had the wrong total file length due to 64-bit logontime (time_t) 3. had the wrong total file length due to writing 19 GosubData elements (instead of 20) The first and last issues appear to be some of those "forever" (20+ year old) bugs. So I'm guessing no regularly used door games actually use these portions of the EXITINFO.BBS, so most likely: no harm, no foul. But still, best to fix this before I commit the rewrite.

  505. Rob Swindell
    Mon Mar 07 2022 20:32:00 GMT-0800 (PST)
    Modified Files:
    

    exec/xbimage.js diff
    Throw an error if trying to convert a > 1-bit BMP file to XBin

  506. Rob Swindell
    Mon Mar 07 2022 17:53:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Fix issue with smtpspy-listed names added in previous commit p (which is used after this) points into 'str', so we can't use 'str' as a temporary variable here.

  507. Eric Oulashin
    Mon Mar 07 2022 15:01:23 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Fix for bogus messages when changing to an empty sub-board Fix: When changing to an empty sub-board from within the reader (either from read mode or list mode), it now properly says there are no messages and exits, rather than showing a list of bogus messages. Unsure when this bug was introduced. The version is now 1.46.

  508. Rob Swindell
    Mon Mar 07 2022 17:00:53 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_chg_empty_subboard_fix' into 'master' DDMsgReader: Fix for bogus messages when changing to an empty sub-board Closes #367 See merge request main/sbbs!154

  509. Eugene So
    Sun Mar 06 2022 10:37:57 GMT-0800 (PST)
    Modified Files:
    

    exec/irc.js diff
    exec/load/irc-default.js diff
    Fix handling of IRC color control sequences An extra comma was being added after the control sequences An empty color control sequence was not handled. It is supposed to remove all color schemes.

  510. Rob Swindell
    Mon Mar 07 2022 11:49:40 GMT-0800 (PST)
    Modified Files:
    

    exec/irc.js diff
    exec/load/irc-default.js diff
    Merge branch 'eugeneso/irc_color_fix' into 'master' Fix handling of IRC color control sequences See merge request main/sbbs!153

  511. Rob Swindell
    Sun Mar 06 2022 17:16:19 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgmsg.c diff
    src/sbbs3/scfg/scfgsub.c diff
    src/sbbs3/scfg/scfgxfr2.c diff
    Cycle through grps, subs, libs, and dirs using left/right arrow keys Nelgin's suggestion to support quick searching/scanning through message and file areas (e.g. comparing settings or whatever) without having to ESC then arrow key, ENTER, for each. Uses Deuce's WIN_EXTKEYS UIFC mode flag, which I don't think I've used before now and uses the special -CIO_KEY value - 2 trick. Also expanded the width of the sub-board and directory info windows to show more information (including full long name). Fixes issue (wishlist item) #349 by Nelgin

  512. Rob Swindell
    Sun Mar 06 2022 16:06:48 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/useredit.cpp diff
    Remove unnecessary current user (co-sysop) level/flag checks As Andre pointed out, these checks perform no function because a user with a level lower than the user being edited cannot enter the related command-key anyway. This was just effectively dead code that was held-over from ancient SBBS days, seemingly before I learned to effectively use the || operator: if(!(atoi(str)>useron.level && console&CON_R_INPUT)) :-) Fixes issue #361

  513. Eric Oulashin
    Sat Mar 05 2022 13:44:40 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit.js diff
    SlyEdit now remembers the quote line window selection between openings. When selecting quote lines in a reply message, SlyEdit now remembers the position in the quote selection menu so that the quote menu isn't always at the top whenever it's opened again. This issue may have been introduced when SlyEdit was refactored to use DDLightbarMenu for its lightbar stuff.

  514. Rob Swindell
    Sat Mar 05 2022 15:06:35 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit.js diff
    Merge branch 'slyedit_quote_win_remember_position' into 'master' SlyEdit now remembers the quote line window selection between openings. See merge request main/sbbs!152

  515. Rob Swindell
    Sat Mar 05 2022 11:48:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/node.c diff
    Move where the "pause" option is applied At the suggestion/request of Andre Robitaille. This option was originally added for debugging use, but may as well move it if it's useful in another way.

  516. Rob Swindell
    Sat Mar 05 2022 11:48:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/str.cpp diff
    Fix CID 174323: Unintended sign extension At least, I think this fixes it.

  517. Rob Swindell
    Fri Mar 04 2022 23:21:00 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    Remove beep from UserReadYourMailNodeMsg

  518. Rob Swindell
    Fri Mar 04 2022 23:15:58 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Don't use pointers to the low byte of multi-byte integers This only works on little endian systems (which is all we support currently). Fixes CID 174261: Wrong size argument This binary drop file writing code is pretty terrible and inefficient, but I remember being really proud of it (supporting so many drop files). This really should be re-written to use structures and/or buffered file I/O.

  519. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/str.cpp diff
    Fix CID 33227: Argument cannot be negative

  520. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Fix CID 174378: Argument cannot be negative

  521. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/str.cpp diff
    More correct error message

  522. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/slog.c diff
    Fix CID 33617: Copy into fixed size buffer

  523. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/baja.c diff
    Fix CID 33628: Unbounded source buffer

  524. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/node.c diff
    Fix CID 33629: Unbounded source buffer

  525. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/addfiles.c diff
    Fix a few issues around single-file add argument parsing Triggered by CID 33630: Unbounded source buffer

  526. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filelist.c diff
    Safer string handling e.g. CID 33631: Unbounded source buffer

  527. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/allusers.c diff
    Fix CID 33635: Unbounded source buffer

  528. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/useredit.cpp diff
    Check return value of filelength() Fix CID 33266: Negative loop bound

  529. Rob Swindell
    Thu Mar 03 2022 16:45:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Check for negative filelength() return values e.g. CID 229593: Negative loop bound

  530. Deucе
    Thu Mar 03 2022 11:28:56 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/uifc32.c diff
    Left for showbuf() is zero-based, calculate width appropriately.

  531. Rob Swindell
    Wed Mar 02 2022 18:41:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsub.c diff
    src/sbbs3/scfg/scfgxfr2.c diff
    Show auto-generated newsgroup name and Fido area-tags Also reversed the order of newsgroup name and area-tag options for a sub-board. Updated help text too to specify that sub's area-tag can be derived from newsgroup name, if one is specified.

  532. Rob Swindell
    Wed Mar 02 2022 13:31:32 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    Fix CID 33252: Argument cannot be negative

  533. Rob Swindell
    Wed Mar 02 2022 13:38:46 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Detect smb_fallocdat() and ftell() failures CID 33245

  534. Rob Swindell
    Wed Mar 02 2022 13:47:33 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Detect/report smb_fallochdr() and ftell() failures Fix CID 33244: Argument cannot be negative

  535. Rob Swindell
    Wed Mar 02 2022 13:51:01 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Fix CID 33239: Argument cannot be negative

  536. Rob Swindell
    Wed Mar 02 2022 16:43:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/getmsg.cpp diff
    src/sbbs3/js_bbs.cpp diff
    src/sbbs3/readmail.cpp diff
    src/sbbs3/readmsgs.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/writemsg.cpp diff
    src/smblib/smblib.h diff
    src/smblib/smbstr.c diff
    Don't pass smbmsg_t (680 bytes) by value So this started with addressing CID 174264: Big parameter passed by value (PASS_BY_VALUE), but then I fell down the constification rabbit hole. :-)

  537. Rob Swindell
    Wed Mar 02 2022 16:44:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/text_defaults.c diff
    Remove beep from UserReadYourMailNodeMsg

  538. Rob Swindell
    Wed Mar 02 2022 12:29:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/netmail.cpp diff
    Detect smb_[f]allocdat() failures in qnetmail() CID 319140

  539. Rob Swindell
    Wed Mar 02 2022 12:32:16 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/slog.c diff
    getchar() returns int, not char CID 319110

  540. Rob Swindell
    Wed Mar 02 2022 12:38:12 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Detect smb_[f]allocdat() failure in editmsg() CID 319091

  541. Rob Swindell
    Wed Mar 02 2022 12:38:49 GMT-0800 (PST)
    Modified Files:
    

    src/smblib/smballoc.c diff
    Detect/reject negative offset argument values to smb_freemsgdat()

  542. Rob Swindell
    Wed Mar 02 2022 12:39:14 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/netmail.cpp diff
    Fix issue in previous commit: no need to free what wasn't allocated

  543. Rob Swindell
    Wed Mar 02 2022 12:48:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Initialize more sbbs_t members in class declaration CID 319034

  544. Rob Swindell
    Wed Mar 02 2022 13:09:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/pktdump.c diff
    Detect/report ftell() failure CID 319007

  545. Rob Swindell
    Wed Mar 02 2022 13:13:22 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/pktdump.c diff
    Check/report remove() failures CID 319028

  546. Rob Swindell
    Wed Mar 02 2022 13:22:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/unbaja.c diff
    Fix CID 33289: Dereference null return value

  547. Rob Swindell
    Wed Mar 02 2022 13:25:51 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/str.cpp diff
    Fix CID 33261 Argument cannot be negative

  548. Rob Swindell
    Wed Mar 02 2022 10:11:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_com.c diff
    "Invalid type in argument to printf format specifier" CID 319142

  549. Rob Swindell
    Wed Mar 02 2022 10:14:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_com.c diff
    Invalid type in printf format specifier CID 319135

  550. Rob Swindell
    Wed Mar 02 2022 12:22:55 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/getnode.cpp diff
    src/sbbs3/str.cpp diff
    Address Coverity issue: filelength() can return negative value

  551. Rob Swindell
    Wed Mar 02 2022 10:06:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_file.c diff
    Fix possible negative offset to lseek() CID 327965

  552. Rob Swindell
    Wed Mar 02 2022 10:07:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Fix possible negative offset to fseeko() CID 350353

  553. Rob Swindell
    Tue Mar 01 2022 21:43:46 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Batch download queue not cleared upon packed QWK packet Before the "new filebase" merge of 2021, a user's batch download queue would be cleared when a QWK packet was successfully packed for them via the event thread (i.e. triggered via semaphore file). That was lost in the new filebase change (the batch download queue would not be cleared) - caught by Coverity (CID 350336). It appears pre-packed QWK packets never cleared the batch download queue (does anyone actually use this feature in this day and age?) - fixed.

  554. Rob Swindell
    Tue Mar 01 2022 21:49:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgnet.c diff
    Eliminate unnecessary save/restore resolved CID 350321

  555. Rob Swindell
    Tue Mar 01 2022 21:51:32 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Resolve some Coverity-discovered issues with lseek() argument types, ftell() return type, etc. Likely none of these would be actual issues with files < 2GiB in size.

  556. Rob Swindell
    Tue Mar 01 2022 21:52:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/services.c diff
    Probably doesn't resolve the Coverity issue But good practice anyway

  557. Rob Swindell
    Tue Mar 01 2022 21:54:58 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Add some NULL argument value checking

  558. Rob Swindell
    Tue Mar 01 2022 21:55:14 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    Added NULL argument checking

  559. Rob Swindell
    Tue Mar 01 2022 21:59:36 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/chksmb.c diff
    Zero-initialize smb before using Addresses CID 350318

  560. Rob Swindell
    Tue Mar 01 2022 22:01:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Zero-init 'ms'g' before use Addresses CID 350316

  561. Rob Swindell
    Tue Mar 01 2022 22:03:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Zero-init 'msg' before use Addresses CID 350312

  562. Rob Swindell
    Tue Mar 01 2022 22:12:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/readmsgs.cpp diff
    Fix private message header field parsing/filtering CID 350294

  563. Rob Swindell
    Tue Mar 01 2022 22:15:22 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Zero-init 'msg' before use CID 350279

  564. Rob Swindell
    Tue Mar 01 2022 22:20:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_file.c diff
    Zero-init write buffer in js_writebin() CID 350276

  565. Rob Swindell
    Tue Mar 01 2022 22:42:59 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/fmsgdump.c diff
    Better detection of correctly-null-terminated body text CID 229603

  566. Rob Swindell
    Tue Mar 01 2022 20:30:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Fix host name or IP address-based smtpspy.txt logging Caught by Coverity-scan (use of uninitialized variable, 'str') :-)

  567. Rob Swindell
    Tue Mar 01 2022 20:30:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbscon.c diff
    Document case fall-through Reported by Coverity

  568. Rob Swindell
    Tue Mar 01 2022 20:30:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    Address Coverity-scan reported issues Could use more long->off_t conversions, but this is a start.

  569. Deucе
    Mon Feb 28 2022 22:33:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    I don't know what I was smoking when I did this, but it's fixed now. Weird early failure return on TLS sends. Most noticible on local (ie: fast) connections, but clearly stupid all around when you look at the code. Fixed, but some day, I should go back and look how we eneded up in this mess.

  570. Eric Oulashin
    Mon Feb 28 2022 15:11:14 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DD file lister: For terminals over 25 rows tall, the file info window will now be up to 45 rows tall.

  571. Rob Swindell
    Mon Feb 28 2022 15:11:15 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'ddfl_issue_352' into 'master' DD file lister: For terminals over 25 rows tall, the file info window will now be up to 45 rows tall. See merge request main/sbbs!151

  572. Rob Swindell
    Mon Feb 28 2022 10:18:02 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    iniSortSections() supports an optional section prefix Needed for echocfg option to sort linked nodes upon reading/writing sbbsecho.ini, for Ray Quinn (1:214/23).

  573. Rob Swindell
    Mon Feb 28 2022 10:19:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/rechocfg.c diff
    src/sbbs3/sbbsecho.h diff
    Add option to sort the list of linked nodes (defaults: off) Feature request by Ray Quinn (1:214/23)

  574. Rob Swindell
    Sun Feb 27 2022 21:50:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Lower the "SSH session establishment failed" log msg level from NOTICE to INFO, per Nelgin

  575. Rob Swindell
    Sun Feb 27 2022 20:21:16 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkchat/objects.mk diff
    Cleanup (replace DIRSEP with slash)

  576. Rob Swindell
    Sun Feb 27 2022 20:21:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkchat/targets.mk diff
    Replace DIRSEP with slash

  577. Rob Swindell
    Sun Feb 27 2022 20:20:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkchat/objects.mk diff
    load_cfg needs readtext and text_defaults

  578. Rob Swindell
    Sun Feb 27 2022 20:03:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/objects.mk diff
    qwknodes needs the load_cfg objects too

  579. Rob Swindell
    Sun Feb 27 2022 19:53:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/Common.gmake diff
    src/sbbs3/Common.make diff
    src/sbbs3/GNUmakefile diff
    src/sbbs3/extdeps.mk diff
    src/sbbs3/objects.mk diff
    src/sbbs3/scfg/objects.mk diff
    src/sbbs3/scfg/targets.mk diff
    src/sbbs3/targets.mk diff
    More elimination of DIRSEP (replace with slash) We only support platforms where slash is a legal path separator.

  580. Deucе
    Sun Feb 27 2022 19:46:07 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    src/sbbs3/jsdoor.c diff
    Enable ctypes in jsdoor SpiderMokey is now built with ctypes, but the object is only being created in jsdoor for now.

  581. Rob Swindell
    Sun Feb 27 2022 19:38:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/objects.mk diff
    src/sbbs3/scfg/objects.mk diff
    src/sbbs3/uedit/objects.mk diff
    src/sbbs3/umonitor/objects.mk diff
    load_cfg now depends on readtext and text_defaults... everywhere Needed for text.dat support in SBBSecho load_cfg really should be made either a static library or an exported function from libsbbs.so that everything reuses. Kind of silly to be recompiling and linking these files with every app now.

  582. Rob Swindell
    Sun Feb 27 2022 19:16:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/text_defaults.c diff
    Remove beeps from "sent you email" notices.

  583. Rob Swindell
    Sun Feb 27 2022 19:16:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/load_cfg.c diff
    src/sbbs3/load_cfg.vcxproj diff
    For SBBSecho to use text.dat strings, it needs load_cfg() to support it Thanks to Dan_C for the head's up that SBBSecho stopped (very recently) successfully sending notices to users about received netmail or echomail.

  584. Rob Swindell
    Sun Feb 27 2022 19:13:23 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    Remove beeps from "send you email" notices.

  585. Eric Oulashin
    Sun Feb 27 2022 15:10:57 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/readme.txt diff
    Fixed copy paste error for the installation section Changed "Installing into a command shell" to say section 3 ("Installation & Setup") instead. This resolves issue #353

  586. Rob Swindell
    Sun Feb 27 2022 15:22:02 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/readme.txt diff
    Merge branch 'dd_file_lister_doc_install_section' into 'master' Fixed copy paste error for the installation section Closes #353 See merge request main/sbbs!150

  587. Rob Swindell
    Sun Feb 27 2022 14:41:38 GMT-0800 (PST)
    Modified Files:
    

    docs/adding_nodes.html diff
    Redirect to the appropriate wiki page

  588. Rob Swindell
    Sun Feb 27 2022 12:32:32 GMT-0800 (PST)
    Modified Files:
    

    ctrl/main.cnf diff
    Change default node1-4 directories from ..\nodeX\ to ../nodeX/ Fixes issue #355 reported by Andre

  589. Rob Swindell
    Sun Feb 27 2022 02:37:37 GMT-0800 (PST)
    Added Files:
    

    xtrn/3rdp-install/dragonshoard.ini diff
    Setup file for Dragon's Hoard (WWIV game, circa 1989)

  590. Rob Swindell
    Sun Feb 27 2022 01:01:41 GMT-0800 (PST)
    Added Files:
    

    xtrn/3rdp-install/foodfite-rigormortis.ini diff
    Setup file for Rigor Mortis' FoodFight! for WWIV

  591. Deucе
    Sat Feb 26 2022 21:56:39 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    Make it const everywhere.

  592. Deucе
    Sat Feb 26 2022 21:43:55 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.h diff
    Make ciolib_appname const

  593. Rob Swindell
    Sat Feb 26 2022 19:59:18 GMT-0800 (PST)
    Modified Files:
    

    exec/load/install-3rdp-xtrn.js diff
    Install door game even when executable filename case doesn't match e.g. foodfite.com will match FOODFITE.COM or FoodFite.COM (the MD5 sum is insuring it's the right file anyway).

  594. Deucе
    Sat Feb 26 2022 16:19:05 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/CMakeLists.txt diff
    Don't compile xptime

  595. Deucе
    Sat Feb 26 2022 15:44:15 GMT-0800 (PST)
    Modified Files:
    

    src/conio/CMakeLists.txt diff
    Set WITH_SDL in parent scope so xpdevplus can pick it up.

  596. Deucе
    Sat Feb 26 2022 15:42:23 GMT-0800 (PST)
    Modified Files:
    

    src/conio/CMakeLists.txt diff
    Add WITH_SDL

  597. Rob Swindell
    Sat Feb 26 2022 13:53:01 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_archive.c diff
    Better error handling in Archive.read() Inspired by jsdoor's equivalent change.

  598. Rob Swindell
    Sat Feb 26 2022 12:33:36 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/bulkmail.cpp diff
    Safer string copying/formatting.

  599. Rob Swindell
    Sat Feb 26 2022 12:33:54 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    Add BUILD_DATE and BUILD_TIME @-codes For DesotoFireflite (VALHALLA)

  600. Eric Oulashin
    Sat Feb 26 2022 00:48:41 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    List header fix for personal email Fix for no group information available when displaying the sub-board header above the message list when listing personal email

  601. Rob Swindell
    Sat Feb 26 2022 01:07:09 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_mail_hdr_fix' into 'master' List header fix for personal email See merge request main/sbbs!149

  602. Rob Swindell
    Fri Feb 25 2022 22:33:04 GMT-0800 (PST)
    Added Files:
    

    exec/viewimsgs.js diff
    Modified Files:

    exec/privatemsg.js diff
    exec/str_cmds.js diff
    Move "MSGS" string command logic to its own file This makes the view instant message logic more easily accessible from other places (e.g. menus or whatever). Add (V)iew command the private message (^P) prompt while we're at it. Users don't normally discover ;string commands on their own.

  603. Eric Oulashin
    Fri Feb 25 2022 22:30:06 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DD message reader: Fixed score display and related colors in the message list for wide terminals

  604. Rob Swindell
    Fri Feb 25 2022 22:30:06 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_wide_term_score_and_color_fix' into 'master' DD message reader: Fixed score display and related colors in the message list for wide terminals See merge request main/sbbs!148

  605. Rob Swindell
    Fri Feb 25 2022 19:54:05 GMT-0800 (PST)
    Modified Files:
    

    CONTRIBUTING.md diff
    s/escaping/encoding

  606. Eric Oulashin
    Fri Feb 25 2022 19:35:04 GMT-0800 (PST)
    Added Files:
    

    xtrn/DDArchiveViewer/readme.txt diff
    xtrn/DDArchiveViewer/revision_history.txt diff
    xtrn/DDArchiveViewer/updating_from_previous_versions.txt diff
    xtrn/DDMsgReader/enhanced_header_examples/enhMsgHeader-withoutTimeZone.ans diff
    xtrn/DDMsgReader/enhanced_header_examples/enhMsgHeader.ans diff
    xtrn/DDMsgReader/loadable_module_scripts/DDReadPersonalMail.js diff
    xtrn/DDMsgReader/loadable_module_scripts/DDScanMsgs.js diff
    xtrn/DDMsgReader/loadable_module_scripts/DDScanSubs.js diff
    Modified Files:

    xtrn/DDMsgReader/readme.txt diff
    Removed Files:

    xtrn/DDArchiveViewer/FILE_ID.DIZ diff
    Removed spaces from some filenames of Digital Distortion mods that had them

  607. Rob Swindell
    Fri Feb 25 2022 19:52:22 GMT-0800 (PST)
    Added Files:
    

    xtrn/DDArchiveViewer/readme.txt diff
    xtrn/DDArchiveViewer/revision_history.txt diff
    xtrn/DDArchiveViewer/updating_from_previous_versions.txt diff
    xtrn/DDMsgReader/enhanced_header_examples/enhMsgHeader-withoutTimeZone.ans diff
    xtrn/DDMsgReader/enhanced_header_examples/enhMsgHeader.ans diff
    xtrn/DDMsgReader/loadable_module_scripts/DDReadPersonalMail.js diff
    xtrn/DDMsgReader/loadable_module_scripts/DDScanMsgs.js diff
    xtrn/DDMsgReader/loadable_module_scripts/DDScanSubs.js diff
    Modified Files:

    xtrn/DDMsgReader/readme.txt diff
    Removed Files:

    xtrn/DDArchiveViewer/FILE_ID.DIZ diff
    Merge branch 'dd_remove_spaces' into 'master' Removed spaces from some filenames of Digital Distortion mods that had them See merge request main/sbbs!147

  608. Rob Swindell
    Fri Feb 25 2022 19:34:16 GMT-0800 (PST)
    Modified Files:
    

    CONTRIBUTING.md diff
    Add notes about added filename preferences/expectations.

  609. Rob Swindell
    Fri Feb 25 2022 17:42:15 GMT-0800 (PST)
    Modified Files:
    

    docs/system_config.html diff
    Redirect to the appropriate wiki page which now has this content Thank you Andre!

  610. Eric Oulashin
    Fri Feb 25 2022 15:24:14 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Fixed message list time colors for wide terminals (above 80 columns)

  611. Rob Swindell
    Fri Feb 25 2022 15:24:15 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_list_time_color_fix' into 'master' Fixed message list time colors for wide terminals (above 80 columns) Closes #351 See merge request main/sbbs!146

  612. Rob Swindell
    Fri Feb 25 2022 14:29:27 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/filewrap.h diff
    Fix sbbs-windows build BCC error filewrap.h 77: Multiple declaration for 'mode_t' Introduced in commit e4adeee8

  613. Rob Swindell
    Fri Feb 25 2022 14:30:29 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Fix MSVC warning in xp_timer64() genwrap.c(855): warning C4244: '=': conversion from 'LONGLONG' to 'uint32_t', possible loss of data

  614. Rob Swindell
    Fri Feb 25 2022 14:30:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/text_defaults.c diff
    New e-mail, not Internet e-mail

  615. Deucе
    Fri Feb 25 2022 13:01:47 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Even when MSVC has inttypes.h, it still doesn't have ssize_t

  616. Deucе
    Fri Feb 25 2022 13:01:47 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/filewrap.h diff
    Add a mingw32 compatible mode_t

  617. Deon George
    Thu Feb 24 2022 18:50:33 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-remove-march.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Remove cryptlib's -march=native to avoid SIGILL on x86_64 systems, where SBBS is compiled on a differnt host to where it is run. This should fix issue main/sbbs#324

  618. Rob Swindell
    Fri Feb 25 2022 12:04:18 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-remove-march.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Merge branch 'master' into 'master' Remove cryptlib's -march=native to avoid SIGILL on x86_64 systems, where SBBS... Closes #324 See merge request main/sbbs!144

  619. Deucе
    Fri Feb 25 2022 10:54:12 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Add a UINT64_MAX hack for VS 2022 Not sure why this isn't defined from inttypes.h, but blah.

  620. Rob Swindell
    Thu Feb 24 2022 23:57:33 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    Add new text.dat strings for The Millionaire - InternetMailReceived - InternetMailForwarded - FidoNetMailReceived - WithAttachment - FidoEchoMailReceived The first string (suppressed with %.0s) is an optional date/time stamp.

  621. Rob Swindell
    Thu Feb 24 2022 23:56:43 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    src/sbbs3/mailsrvr.h diff
    src/sbbs3/sbbs_ini.c diff
    src/sbbs3/sbbsecho.c diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    Add/use new text.dat strings for received Fido and Internet mail - InternetMailReceived - InternetMailForwarded - FidoNetMailReceived - WithAttachment - FidoEchoMailReceived For The Millionaire, closing issue #254 The first string (suppressed with %.0s) is an optional date/time stamp. This also deprecates (removes support for) the [mail] NewMailNotice and ForwardNotice keys from sbbs.ini.

  622. Eric Oulashin
    Thu Feb 24 2022 20:25:01 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader v1.45: Fixed message scanning & searching issues introduced in the previous version.

  623. Rob Swindell
    Thu Feb 24 2022 21:18:12 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_145_scan_fix' into 'master' DDMsgReader v1.45: Fixed message scanning & searching issues introduced in the previous version. Closes #344 See merge request main/sbbs!145

  624. Rob Swindell
    Thu Feb 24 2022 17:06:40 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/uedit/uedit.c diff
    Save/restore the current selected user Addresses issue #350. Also fixed up the alignment of the header/columns.

  625. Rob Swindell
    Thu Feb 24 2022 12:42:58 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    Handle filelength() possibly returning negative value CID 349724

  626. echicken
    Thu Feb 24 2022 06:10:37 GMT-0800 (PST)
    Modified Files:
    

    webv4/components/navbar.xjs diff
    Include path component of .link pages in menus/submenus. Probably resolves the "Invalid page" problem reported by W6RAY.

  627. Rob Swindell
    Wed Feb 23 2022 23:28:40 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/bat_xfer.cpp diff
    Just use our local C macro MAX()

  628. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs_status.c diff
    Fix extra argument in printf format specifier CID 319101 Beautified another lprintf() statement while at it.

  629. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/bat_xfer.cpp diff
    Fix potential divide by zero CID 330961

  630. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs_status.c diff
    Fix invalid type in argument to printf format specifier CID 319001

  631. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_com.c diff
    Fix invalid type in argument to printf format specifier CID 319142

  632. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_socket.c diff
    Fix invalid type in argument to printf format specifier CID 319135 Fix the return value of js_socket_sendfilesocket() while we're here (off_t instead of int).

  633. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Delete dead code CID 174474

  634. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/smbutil.c diff
    Comment intentional case fall-through CID 33205

  635. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ars.c diff
    Comment intentional case statement fall-throughs CID 33207 CID 33208 CID 33209

  636. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ars.c diff
    src/sbbs3/execfunc.cpp diff
    Document intentional case fall-throughs CID 33210 CID 33211

  637. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/allusers.c diff
    Comment intentional fall-through CID 33212

  638. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/dstsedit.c diff
    Comment intentional case fall-through CID 33213

  639. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/fmsgdump.c diff
    src/sbbs3/jsexec.c diff
    src/sbbs3/readmail.cpp diff
    src/sbbs3/uedit/uedit.c diff
    src/sbbs3/umonitor/umonitor.c diff
    src/sbbs3/websrvr.c diff
    Comment intentional case fall-throughs CID 174223 CID 174227 CID 174461 CID 174519 CID 229602 CID 319040 CID 319137 CID 319159

  640. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Fix wrong size argument (not actual problem) CID 174261

  641. Rob Swindell
    Wed Feb 23 2022 23:25:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Initialize a bunch of class members to resolve Coverity issues CID 319034

  642. Rob Swindell
    Wed Feb 23 2022 18:21:35 GMT-0800 (PST)
    Modified Files:
    

    exec/str_cmds.js diff
    Optimize the help display for MSGS command (fits on one line)

  643. Rob Swindell
    Wed Feb 23 2022 18:09:25 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    Introduced FreeDownloadUserMsg text.dat string Also updated the default colors of the existing DownloadUserMsg string to have a little more variety.

  644. Rob Swindell
    Wed Feb 23 2022 18:08:16 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/userdat.c diff
    Introduced FreeDownloadUserMsg text.dat string Tired of being reminded that you were "awarded 0 credits" for free downloads? I know I am, so I created another text.dat string (reusing Unused300), for notification of free-download files where no credits are awarded to the uploader. Also updated the default colors of the existing DownloadUserMsg string to have a little more variety. Not sure why ftpsrvr.c isn't using user_downloaded_file(). That copy/pasta should be eliminated later.

  645. Rob Swindell
    Wed Feb 23 2022 18:01:21 GMT-0800 (PST)
    Modified Files:
    

    exec/addfiles.js diff
    Add -file=name|pattern option to specify files to add/update postfile.js still should be used for adding a single file to a filebase, but when updating a single file, this seemed like a simple enhancement. It also allows filtering of files to be added by wildcard (e.g. *.zip), so potentially useful for adding files too. Address enhancement request #348

  646. Rob Swindell
    Wed Feb 23 2022 13:27:04 GMT-0800 (PST)
    Modified Files:
    

    exec/avatars.js diff
    Remove accidental debug print() statement left from previous commit

  647. Deucе
    Wed Feb 23 2022 13:07:22 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.h diff
    Move all exported variables into extern "C" block

  648. Rob Swindell
    Wed Feb 23 2022 13:01:04 GMT-0800 (PST)
    Modified Files:
    

    exec/avatars.js diff
    Increase white-space tolerance when importing avatars from msgbase TARDIS (Quarkware BBS, the Ruby BBS), uses just \n for QWK message line deliniation, but we were expected \r\n terminated lines here. Also, apparently there was trailing white-space on the "json-end" line, so handle that case too.

  649. Rob Swindell
    Wed Feb 23 2022 11:58:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/addfiles.vcxproj diff
    src/sbbs3/upgrade_to_v319.vcxproj diff
    Fix Windows build: filedat.c now requires utf8.h And a couple of projects didn't have the encode directory in their include path.

  650. Rob Swindell
    Wed Feb 23 2022 00:19:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbsdefs.h diff
    Increase maximum extended file description length from 4000 to 5000 Apparently 4000 characters isn't enough for everyone to describe their files in vibrant colors and "graphics". :-)

  651. Rob Swindell
    Wed Feb 23 2022 00:19:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/str_util.c diff
    src/sbbs3/str_util.h diff
    Add strip_cp437_graphics() and have strip_ctrl() remove DEL chars too strip_cp437_graphics() is like strip_exascii(), except it'll leave the foreign language characters and math symbols intact (removing just the common "block" and "line-drawing" characters). DEL (0x7F) is a control character too, so have strip_ctrl() remove it.

  652. Rob Swindell
    Wed Feb 23 2022 00:19:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Strip CP437 "graphics" characters in prep_file_desc() If the extended description is UTF-8, first convert it to CP437.

  653. Rob Swindell
    Wed Feb 23 2022 00:19:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/upload.cpp diff
    Fix issue with blind/batch uploaded file descriptions When no file description was provided (e.g. blind/batch file uploads), I noticed that the short file description (summary) could be set to "(null)". This problem was introduced in commit bc7030d33b264058c4 with the sbbsfile.des creation and post-processing support. I also noticed that the extended description processing in sbbs_t::uploadfile() was not entirely consistent with other methods of adding/uploading files. Let prep_file_desc() do its just of processing the extended description into a suitable short description/summary (including truncation).

  654. Rob Swindell
    Tue Feb 22 2022 21:59:52 GMT-0800 (PST)
    Modified Files:
    

    exec/str_cmds.js diff
    Add "MSGS" command to redisplay instant messages (notices/telegrams)

  655. Rob Swindell
    Tue Feb 22 2022 21:59:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/getnode.cpp diff
    src/sbbs3/userdat.c diff
    src/sbbs3/userdat.h diff
    Save instant message history (notifications and telegrams) This should address issue (feature request) #196. The last 20 sets of displayed messages are stored as data/msgs/<user-num>.last.#.msg. This number is currently hard-coded, but could be configurable in the future. I say "sets" because messages are batched-up and displayed together normally, unless a user is actively polling for new users (e.g. while at the Ctrl-P/PrivateMsg prompt). This involved getting rid of some copy/pasta in sbbs_t:getsmsg() as well by creating/using/reusing readsmsg().

  656. Rob Swindell
    Tue Feb 22 2022 18:32:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_internal.c diff
    Update JSDOCs on timer-related methods - setInterval() returns a Number, not an Object. - typos fixed - markup added

  657. Rob Swindell
    Tue Feb 22 2022 13:10:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/netmail.cpp diff
    Fix network user/address look-up (using qnet/users.dat) The QWKnet user look-up feature was broken as of commit e4fc5d04d9c6570e31e (a year ago). Just noticed this regression as Andre asked in IRC about looking up network users for netmail. This feature worked for QWKnet users/addresses, at least, and now will work again.

  658. Rob Swindell
    Mon Feb 21 2022 19:55:15 GMT-0800 (PST)
    Modified Files:
    

    exec/automsg.js diff
    Display a different prompt for sysops (that includes the [D]elete option) This addresses the gitlab issue #130. Also, prompt for confirmation when [D]eleting the file. Also, allow modopts.ini customization of this script via keys in the new (optional) [automsg] section: prompt (defaults to text.dat AutoMsg) sysop_prompt (defaults to hard-coded string) intro (defaults to hard-coded string) header_fmt (defaults to text.dat AutoMsgBy) user_fmt (defaults to hard-coded string) line_fmt (defaults to hard-coded string) max_line_len (defaults to 76)

  659. Rob Swindell
    Mon Feb 21 2022 18:22:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/data.cpp diff
    Timed event "month days" value of 1 means "any day" (same as 0) This field should not normally have a value of '1' (no way to configure that, normally, since days are numbered starting at 1 and bit 1 is 2), but if it does, it's treated the same as 0 (any day of the month) - so fix that mismatch in getnexteventtime(). Just noticed this while comparing the logic with the new is_time_to_run() functions in main.cpp. That logic wasn't (should not have) changed, so this mismatch in the treatment of mdays == 1 existed before.

  660. Rob Swindell
    Mon Feb 21 2022 15:59:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Refactor timed-event and QWKnet call-out scheduling Reduced probably the biggest if() conditionals in sbbs to a single line by breaking the "time to run" logic into separate functions and sharing those functions between both QWKnet and timed-event scheduling. There was no actual problem with this code/logic, it was just very difficult to read and understand and step-through with a debugger and understand why or why not an event might run under different configurations and circumstances. Also removed the PostLink network call-out logic. pnet.dab is no longer read and written-to and if you happened to have any PostLink hubs configured (how?!?), they'll no longer be "polled". This is the only functional change unless I did something wrong in the process. One thing I noticed and contemplated, the current time is not queried between consecutive timed-event scheduling/execution. It's possible that an executed event can take a long time and impact the criteria for the next timed event. The events are checked for scheduling every few seconds, so I can't really think of a big down-side to the current design (apparently intended to reduce unnecessary querying of the current date/time), so I didn't do anything to change that. Just something I noticed.

  661. Rob Swindell
    Sun Feb 20 2022 17:36:07 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    Rename "Allow Sysop Login" option to "Allow Sysop Access" With this option set to "No", sysops can still login, they just can't perform most sysop functions. Updated System Password help text to clarify that the "Allow Sysop Access" option effectively disables the system password. Also mention the FTP Server use of the system password to enable sysop access.

  662. Rob Swindell
    Sun Feb 20 2022 17:03:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/login.cpp diff
    src/sbbs3/logon.cpp diff
    Change the semantics of the "Allow Sysop Logins" setting in SCFG->System As Andre pointed out while documenting this setting on the wiki, the option seemed confusing: if a sysop could not login with "system operator access", how could they login at all? Answer: they could not. This setting used to be called "Allow Remote Sysop Logins", back when there was the concept of a "local login", so setting this option to "No" would mean that user accounts with sysop access could only be used for *local* login. But in Synchronet v3, there's really no such concept as a "local login", so it was changed to just "Allow Sysop Logins" (period) and not a lot of thought given to how/why a sysop would actually set to this "No" or what the implications would be (presumably, nobody ever sets this to "No"). So rather than just get rid if the option altogether, I changed it to mean: an account with sysop access (i.e. level 90+) can still login, but any action that normally requires the system password will not be allowed. This includes the sysop-actions available in the FTP server when authenticating with <user-pass>:<system-pass> as the password. The sysop-user can still authenticate (and login), but none of those sysop-actions will be available to them.

  663. Rob Swindell
    Sun Feb 20 2022 16:53:49 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/threadwrap.h diff
    pthread_mutex_t is a CRITICAL_SECTION (not a pointer) on Win32 Partially revert Deuce's commit b4bc9c9759e6f34c272501e024 This explains the EAccessViolation (stack corruption during sbbs startup) that sysops have reported when using the latest nightly builds.

  664. Deucе
    Sat Feb 19 2022 23:37:00 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/filewrap.h diff
    Add DISABLE_MKSTEMP_DEFINE support This macro as written won't compile on mingw32 due to the attributes on _mktemp(). This could be worked around, but it's easier to just disable it since I don't need it, and nobody else is building with mingw32.

  665. Deucе
    Sat Feb 19 2022 21:52:53 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/sockwrap.h diff
    Fix socket_ioctl_ptr_t On Win32 it can't be defined until after winsock*.h is #included. On everything else, it needs to be a pointer.

  666. Deucе
    Sat Feb 19 2022 21:45:10 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/sockwrap.h diff
    Add socket_ioctl_ptr_t For Win32, this is actually the pointer type an ioctl() third argument needs to be. For other OSs, this is basically what an FIONBIO third argument needs to be... there's really no restruction at all on what arguments after the second to ioctl() need to be.

  667. Deucе
    Sat Feb 19 2022 14:42:41 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/sockwrap.h diff
    Make socket_send_buffer_t separate from socket_recv_buffer_t It seems we can't add a const to a typedef in a static_cast<>()

  668. Deucе
    Sat Feb 19 2022 14:02:59 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/threadwrap.h diff
    Use MinGW32 types for pthread_t and pthread_mutex_t uintptr_t should be the same as a DWORD on Win32, and CRITICAL_SECTION can be stored in an inptr_t as well. This should work fine, and allow more build environments to be happy. This is generally caused by new C++ standards having thread support in the standard library, so wrappers getting pushed deeper in. At some pointer, this should be redone with standard threads, but now is not the time.

  669. Eric Oulashin
    Sat Feb 19 2022 13:35:35 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/DefaultTheme.cfg diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    @-code expansion in text lines. Text searching for sub-board, group, or all. Version 1.44: Removed the scanScopePromptText text line and used the SubGroupOrAll line (621) from text.dat instead. Also, the reader now supports @-code expansion in configured text strings. This addresses issue #316 from Vincent Macaluso. Text search now can search sub-board, group, or all like the other text searching (requested by Nelgin). When reading the theme file, color settings are now checked to ensure they only have Synchronet attribute codes.

  670. Rob Swindell
    Sat Feb 19 2022 13:54:35 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/DefaultTheme.cfg diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_144_atcodes_and_text_search' into 'master' @-code expansion in text lines. Text searching for sub-board, group, or all. See merge request main/sbbs!143

  671. Deucе
    Sat Feb 19 2022 13:47:17 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/sockwrap.h diff
    typedef a socket_buffer_t This is so we can deal with send(), recv() and friends taking a void* on BSD stacks, and a char* on Win32. Not a big deal for C where a void* is universal, but C++ hates that type of thing.

  672. Rob Swindell
    Sat Feb 19 2022 12:01:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    ML/TL and MF/TF haven't been a thing since Synchronet v1 I think Thanks to Andre for pointing that out in his wiki updates.

  673. echicken
    Fri Feb 18 2022 22:53:01 GMT-0800 (PST)
    Modified Files:
    

    xtrn/bullshit/bullshit.js diff
    Added optional 'title' setting to root section of bullshit.ini. If absent, default string 'Bulletins' will be used.

  674. echicken
    Fri Feb 18 2022 22:33:13 GMT-0800 (PST)
    Modified Files:
    

    xtrn/bullshit/bullshit-lib.js diff
    xtrn/bullshit/bullshit.js diff
    Added titleBackground config setting. (For CG Learn) Removed attribution rather than fix its coloring. Nobody cares, and if you do care, have you tried not caring? It's easy, it's just a matter of doing nothing. Bullshit is a proud sponsor of funclib.js.

  675. Rob Swindell
    Thu Feb 17 2022 11:27:35 GMT-0800 (PST)
    Modified Files:
    

    exec/filelist.js diff
    Strip carriage returns from extended descriptions On Windows, CRs in extended descriptions could result in output of \r\r\n which could be displayed as 2 newlines (e.g. in notepad.exe). Since the \n -> \r\n expansion already happens on Windows stdout, we don't want them in the processed input (file metadata). As reported by DesotoFireflite (VALHALLA), thank you!

  676. Rob Swindell
    Wed Feb 16 2022 17:49:57 GMT-0800 (PST)
    Modified Files:
    

    exec/filelist.js diff
    Don't include both normal and extended file descriptions by default As pointed out by DesotoFireflite (VALHALLA), both the file's short/normal description and the extended description were being included in all file listings. This is probably want most sysops will want since the extended description is often used as the content of the short/normal description, resulting in repeated content. So, by default, if there is an extended file description, don't output the short/normal file description. If you want to include *both* the short and extended descriptions (for files that have both), include both the -ext and -desc command line options.

  677. Rob Swindell
    Tue Feb 15 2022 15:01:55 GMT-0800 (PST)
    Modified Files:
    

    exec/load/age.js diff
    Use system.text() instead of bbs.text() so this script can be used from jsexec

  678. Rob Swindell
    Tue Feb 15 2022 19:20:58 GMT-0800 (PST)
    Modified Files:
    

    exec/msglist.js diff
    Add offline execution (e.g. using jsexec or timed event) support Inspired by filelist.js (which is really *only* for use offline), added support to run via JSexec or timed event with command-line options to control the output format, sorting, and msg-age range. Try this Mewcenary (EXTRICAT)

  679. Rob Swindell
    Mon Feb 14 2022 11:05:53 GMT-0800 (PST)
    Modified Files:
    

    xtrn/lord/lord.js diff
    Address !JavaScript lord.js line 5835: TypeError: op is null I think this means one of your nodeon.* files are corrupt and just deleting that file would likely cure the situation as well.

  680. Deucе
    Sun Feb 13 2022 23:18:24 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/CMakeLists.txt diff
    Fix

  681. Deucе
    Sun Feb 13 2022 23:17:08 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/CMakeLists.txt diff
    Fix Linux builds

  682. Rob Swindell
    Sun Feb 13 2022 22:12:12 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_archive.c diff
    Add "name" property, matching Deuce's jsdoor fork Convenient way to get the path/name of the archive file as it was passed to the constructor.

  683. Eric Oulashin
    Sun Feb 13 2022 19:19:51 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Digital Distortion File Lister version 2.02: Added the ability to do a file search (via filespec, description, or new files since last scan). A command-line parameter, -MODE, specifies which search to perform (search_filename, search_description, or new_file_search for searching; list_curdir lists files in the user's current directory, which is the default).

  684. Rob Swindell
    Sun Feb 13 2022 19:32:31 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'ddfl_202_file_searching' into 'master' Digital Distortion File Lister v2.02: Added the ability to do a file search (via filespec, description, or new files since last scan). See merge request main/sbbs!141

  685. Eric Oulashin
    Sat Feb 12 2022 17:46:16 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Digital Distortion Area Choosers version 1.22: In the file area chooser, fixed a lightbar file directory choosing issue when using name collapsing (was using the wrong data structure)

  686. Rob Swindell
    Sat Feb 12 2022 17:57:53 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/revision_history.txt diff
    Merge branch 'ddac_122_file_lightbar_fix' into 'master' Digital Distortion Area Choosers v1.22: Fixed a lightbar directory choosing issue in the file area chooser See merge request main/sbbs!140

  687. Rob Swindell
    Sat Feb 12 2022 15:52:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_global.c diff
    src/sbbs3/js_system.c diff
    Replace more uses of msclock() with xp_timer[64]()

  688. Rob Swindell
    Sat Feb 12 2022 12:16:59 GMT-0800 (PST)
    Modified Files:
    

    exec/archive.js diff
    Lower the "list" archive error log level from NOTICE to DEBUG Since we install archive.js as the viewer for '*' by default, we expect it to be asked to list non-archive file-types frequently, so don't be too alarmist about it.

  689. Rob Swindell
    Sat Feb 12 2022 11:45:59 GMT-0800 (PST)
    Modified Files:
    

    ctrl/file.cnf diff
    Make XMODEM-Original the default 'X' protocol, for ancient commie-puters And change XMODEM-1K/CRC to be the '1' protocol.

  690. Deucе
    Sat Feb 12 2022 00:45:36 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Not *that* t.

  691. Deucе
    Sat Feb 12 2022 00:40:11 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Borland doesn't have roundl() so do terrible things instead.

  692. Deucе
    Sat Feb 12 2022 00:15:27 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    More Win32 optimizations.

  693. Deucе
    Sat Feb 12 2022 00:06:38 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    More Win32 optimizations.

  694. Rob Swindell
    Sat Feb 12 2022 00:00:12 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Resolve new msvc warning warning C4244: '=': conversion from 'double' to 'uint64_t', possible loss of data

  695. Deucе
    Fri Feb 11 2022 23:49:35 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Moar!

  696. Deucе
    Fri Feb 11 2022 23:46:50 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Fix Win32 harder

  697. Deucе
    Fri Feb 11 2022 23:43:05 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Fix Win32 builds maybe?

  698. Deucе
    Fri Feb 11 2022 23:40:09 GMT-0800 (PST)
    Modified Files:
    

    src/conio/mouse.c diff
    Use xp_timer64() instead of xp_timer()

  699. Deucе
    Fri Feb 11 2022 23:38:48 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Add xp_timer64() This is a millisecond timer that tries to avoid floating-point operations.

  700. Rob Swindell
    Fri Feb 11 2022 23:33:56 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/con_out.cpp diff
    src/sbbs3/sbbs.h diff
    Replace use of msclock() with xp_timer() it just seems it's even worst than Deuce thought. :-)

  701. Rob Swindell
    Fri Feb 11 2022 23:27:18 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Restore the msclock_t typedef. Things were using it.

  702. Deucе
    Fri Feb 11 2022 23:21:48 GMT-0800 (PST)
    Modified Files:
    

    src/conio/mouse.c diff
    Use xp_timer() instead of msclock() I'm not really happy about rounding floats in time-critical bits, but there you go.

  703. Rob Swindell
    Fri Feb 11 2022 23:20:29 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Fix Windows build.

  704. Deucе
    Fri Feb 11 2022 23:11:22 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Use xp_timer()-based msclock() on Win32 too. Now it should keep working after 24 days.

  705. Rob Swindell
    Fri Feb 11 2022 23:09:09 GMT-0800 (PST)
    Modified Files:
    

    exec/pickfont.js diff
    Resolve SyntaxError: missing ) after condition As seen logging on to WLARB ("too")

  706. Deucе
    Fri Feb 11 2022 20:49:09 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    When a double is cast to an int, but the double has a larger value than the int supports, it's set to 0x80000000 to indicate overflow. msclock() is *always* overflowing, and clock_t is only 32-bits on some platforms (specifically FreeBSD). To "avoid" problems, just keep subtracting UIN32_MAX from the value until it's less than INT_MAX then cast. This function is, of course, terrible and shouldn't actually be used, but it should at least sorta kinda workish.

  707. Deucе
    Fri Feb 11 2022 16:10:32 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpmap.c diff
    Fix mmap flags for read. At least one of MAP_ANON, MAP_GUARD, MAP_PRIVATE, MAP_SHARED, or MAP_STACK must be specified.

  708. Deucе
    Fri Feb 11 2022 15:51:36 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpmap.h diff
    Extern "C"

  709. Deucе
    Thu Feb 10 2022 17:01:06 GMT-0800 (PST)
    Modified Files:
    

    src/conio/utf8_codepages.h diff
    The ole extern "C" trick eh?

  710. Deucе
    Thu Feb 10 2022 16:49:58 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/uifc.h diff
    src/uifc/uifc32.c diff
    More constifying of showbuf() Oddly enough the hbuf wasn't actually modified.

  711. Deucе
    Thu Feb 10 2022 16:44:56 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/getmsg.cpp diff
    src/sbbs3/js_global.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/msgtoqwk.cpp diff
    src/sbbs3/str_util.c diff
    src/sbbs3/str_util.h diff
    src/sbbs3/writemsg.cpp diff
    Rename utf8_to_cp437_str() to utf8_to_cp437_inplace() This will allow naming consistency in encode/* This is the fix you're looking for Keyop. :)

  712. Deucе
    Thu Feb 10 2022 16:27:20 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    src/conio/bitmap_con.h diff
    src/conio/ciolib.c diff
    src/conio/ciolib.h diff
    src/conio/sdl_con.h diff
    src/conio/x_cio.h diff
    Constify loadfont()

  713. Deucе
    Thu Feb 10 2022 16:23:29 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/uifc32.c diff
    Actually constify showbuf() Geeze, this is ugly.

  714. Deucе
    Thu Feb 10 2022 16:14:45 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/uifc32.c diff
    Finish consitfying showbuf()

  715. Deucе
    Thu Feb 10 2022 16:12:38 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    Cleanup bad merge (WTF?)

  716. Deucе
    Thu Feb 10 2022 16:06:08 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/unicode.c diff
    src/xpdev/unicode.h diff
    Whoops, add missing files for last commit.

  717. Deucе
    Thu Feb 10 2022 16:01:09 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/sockwrap.c diff
    src/xpdev/sockwrap.h diff
    Constify addr_str argument to inet_ptoaddr()

  718. Deucе
    Thu Feb 10 2022 16:01:09 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    src/encode/utf8.h diff
    New functions utf8_to_cp437_str() latin1_to_utf8_str() utf8_to_latin1_str()

  719. Eric Oulashin
    Thu Feb 10 2022 15:18:46 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Digital Distortion Message Reader Version 1.43: Fixed the 'out of memory' error when viewing message header info (I had used the same loop control variable name for a loop inside a loop..oops). Also, when viewing message header information, it will no longer show JS functions.

  720. Rob Swindell
    Thu Feb 10 2022 15:57:40 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_hdrs_out_of_memory_fix' into 'master' DD Message Reader Version 1.43: Fixed 'out of memory' error when viewing message headers See merge request main/sbbs!139

  721. Deucе
    Thu Feb 10 2022 15:36:22 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/uifc.h diff
    src/uifc/uifc32.c diff
    Consitfy showbuf too

  722. Deucе
    Thu Feb 10 2022 15:31:52 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/uifc.h diff
    src/uifc/uifc32.c diff
    src/uifc/uifcx.c diff
    Some consitifications

  723. Deucе
    Thu Feb 10 2022 14:48:26 GMT-0800 (PST)
    Added Files:
    

    src/encode/CMakeLists.txt diff
    src/hash/CMakeLists.txt diff
    Modified Files:

    src/comio/CMakeLists.txt diff
    src/uifc/CMakeLists.txt diff
    src/xpdev/CMakeLists.txt diff
    More CMakeLists.txt files.

  724. Deucе
    Thu Feb 10 2022 14:42:22 GMT-0800 (PST)
    Modified Files:
    

    src/conio/CMakeLists.txt diff
    Add CMakeLists.txt file for use as ExternalProject

  725. Rob Swindell
    Wed Feb 09 2022 00:01:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    src/sbbs3/listfile.cpp diff
    Auto-detect/display UTF-8 encoded extended file descriptions I noticed that the recent NASA "Earth Science Picture of the Day" files have had a DIZ with UTF-8 encoded apostrophe in it. <sigh>

  726. Eric Oulashin
    Tue Feb 08 2022 23:13:54 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.cfg diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Added an option to pause after viewing a file (defaults to true)

  727. Rob Swindell
    Tue Feb 08 2022 23:13:54 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.cfg diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_view_file_pause' into 'master' Added an option to pause after viewing a file (defaults to true) See merge request main/sbbs!138

  728. Rob Swindell
    Tue Feb 08 2022 20:25:19 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    Clarify in the help text: if you include a file extension (e.g. .exe)... Then you must also include the file extension on all the configured command-lines. The opposite is not true: excluding the file extension in the native program list will still work if the command-line includes the file extension.

  729. Rob Swindell
    Tue Feb 08 2022 19:33:00 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Don't call com_setup() unless an alternate [COM:x] section is loaded Apparently com_setup() (which just calls tcsetattr()) will cause an attached modem (with a caller) to disconnect the caller. So you can't do this with a live modem. Leave the hack in for Nelgin's null modem cable setup, but you can't (apparently) support both 8N1 and 7E1 "callers" with a real modem (not surprisingly, for multiple reasons).

  730. Rob Swindell
    Tue Feb 08 2022 00:07:22 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio_nix.c diff
    Fix weird gcc warning with white-space change (!)

  731. Rob Swindell
    Tue Feb 08 2022 00:05:21 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio.h diff
    src/comio/comio_nix.c diff
    src/comio/comio_win32.c diff
    src/sexpots/sexpots.c diff
    Allow ByteSize and StopBits to be configured in sexpots.ini [COM] section(s). Fixed bug where Parity was only initially set (in sexpots) if BaudRate was non-zero.

  732. Rob Swindell
    Mon Feb 07 2022 23:46:40 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Parse/apply [COM:x] section upon prompted key press of 'x' Another hack for Nelgin: this'll allow (in theory) the serial device to switch parity modes (e.g. 8N1 or 7E1) depending on what the user selects (key pressed). I did not add byte/stop bit size configurations. We may need that.

  733. Rob Swindell
    Mon Feb 07 2022 23:36:46 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio.h diff
    src/comio/comio_nix.c diff
    src/comio/comio_win32.c diff
    src/sexpots/sexpots.c diff
    Add support for even/odd parity com ports Set Parity=true in [com] section of sexpots.ini Set ParityOdd=true if using Odd parity.

  734. Rob Swindell
    Mon Feb 07 2022 22:05:23 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Setting IgnoreDCD=true causes wait_for_call() to immediate return For Nelgin's null modem setup, putty doesn't raise DTR? <nelgin> sexpots 1492 root 3u CHR 4,64 0t0 90 /dev/ttyS0 <nelgin> Well, it's listening, but when I connect with putty I get nothing. <nelgin> DigitalMan, probably always assume a client is connected since I have my pc wired to my linux box.

  735. Rob Swindell
    Mon Feb 07 2022 20:10:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Fix compile issue in previous commit. <blush>

  736. Rob Swindell
    Mon Feb 07 2022 19:45:30 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/msg_id.c diff
    src/sbbs3/msg_id.h diff
    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    Sanity-check each sub's FidoNet-style address when loading msgs.cnf Just in case a sysop deletes/changes their addresses after create subs, find the nearest matching configured system FTN address/AKA and use that.

  737. Rob Swindell
    Mon Feb 07 2022 19:58:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    src/sbbs3/mailsrvr.h diff
    src/sbbs3/sbbs_ini.c diff
    src/sbbs3/startup.h diff
    Support TLSErrorLevel in [mail] and [global] sections of sbbs.ini Allow a configured maximum-severity (minimum value) for TLS-related log messages. Default is 0 (LOG_EMERG, maximum severity). Getting tired of SMTP/TLS (SMTPS) related errors clogging up my inbox. I'm setting this to "Warning", like I did for [web].

  738. Eric Oulashin
    Mon Feb 07 2022 13:21:57 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    Fix for left/right navigation for command bar introduced in last commit

  739. Rob Swindell
    Mon Feb 07 2022 13:39:24 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    Merge branch 'dd_file_lister_left_right_cmdbar_fix' into 'master' DD file lister: Fix for left/right navigation for command bar introduced in last commit See merge request main/sbbs!137

  740. Eric Oulashin
    Mon Feb 07 2022 11:27:14 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DD file lister version 2.01: Fixed file description being undefined when viewing file info. Fixed command bar refreshing when pressing the hotkeys.

  741. Rob Swindell
    Mon Feb 07 2022 12:16:37 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_info_and_cmd_refresh_fixes' into 'master' DD file lister version 2.01: Fixes for file description and command bar refreshing See merge request main/sbbs!136

  742. Eric Oulashin
    Sun Feb 06 2022 14:12:20 GMT-0800 (PST)
    Added Files:
    

    xtrn/ddfilelister/ddfilelister.cfg diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/defaultTheme.cfg diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Modified Files:

    exec/load/dd_lightbar_menu.js diff
    Created a file lister (in JS) that lists files in the user's current file directory with a lightbar interface, as well as message windows etc. If the user does not have an ANSI terminal, this lister will run Synchronet's stock file lister interface.

  743. Rob Swindell
    Sun Feb 06 2022 15:01:00 GMT-0800 (PST)
    Added Files:
    

    xtrn/ddfilelister/ddfilelister.cfg diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/defaultTheme.cfg diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Modified Files:

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_file_lister_new' into 'master' Created a file lister (in JS) that lists files in the user's current file directory See merge request main/sbbs!135

  744. Rob Swindell
    Sun Feb 06 2022 02:34:54 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Clear mouse hot spots (if any) before hanging up. <nelgin> Ah, here's a good one. If I ssh to my bbs server, then ssh to my bbs, do whatever then /O to logout, when I left click in the putty window I get "0;98;20M0;98;20m and stuff like that. I have to run reset to get it working properly.

  745. Rob Swindell
    Sun Feb 06 2022 02:14:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/client.h diff
    Update comments only.

  746. Rob Swindell
    Sun Feb 06 2022 02:13:54 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    Fix access-control by terminal cap issue introduced a week ago In commit 3f17c245, I was addressing the issue reported by Nelgin via IRC: <nelgin> If you login using a term that doesn't support ansi, it changes your settings - can you set 'em back when done? <DigitalMan> if you have auto-term enabled, it doesn't actually change your settings, just what's in use during that session <nelgin> I logged in using my BBC emulator which doesn't do ansi, then when I logged in through syncterm, I got the display like it was on the BBC. All my characters replaced with #'s and stuff. <nelgin> I had to go back into the user menu to fix it. That is going to confuse users. However, the chk_ar() function in userdat.c which is used to populate JS objects (e.g. xtrn_area.sec_list[].prog_list[]) uses the user.misc value (cannot call term_supports()), so the current user terminal flags need to be reflected in user.misc always. So the real fix for the originally reported problem is to clear the charset-related terminal settings when logging in with auto-terminal settings enabled (and before the auto-detected charset flags are OR'd in). I toyed with the idea of storing a copy of the term_supports() result in client_t, which is passed to chk_ar() when appropriate, but decided that was a bit overkill and there were issues with servers that don't have term_supports (e.g. the web server) and properly populating access-controlled areas in the JS object model (e.g. door games that require ANSI). Better to use the last-auto-detected terminal caps than assuming "no" terminal capabilities in that scenario.

  747. Rob Swindell
    Fri Feb 04 2022 22:29:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/js_user.c diff
    src/sbbs3/netmail.cpp diff
    src/sbbs3/newuser.cpp diff
    src/sbbs3/scfg/scfgnet.c diff
    O-restriction forces sent netmail to come from user's alias too Users with the 'O' restriction (automatically set if a new user has the same "real name" as another account, and that's allowed by the sysop) will send netmail from their alias and not their real name to prevent impersonation of another user.

  748. Rob Swindell
    Fri Feb 04 2022 19:35:22 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfg.h diff
    src/sbbs3/scfg/scfgmsg.c diff
    src/sbbs3/scfg/scfgxfr2.c diff
    Detect and reject duplicate internal code prefixes Don't let (or at least try to prevent) a sysop create a duplicate message group or file library internal code prefix (which could lead to duplicate internal codes for subs and dirs, pretty easily and accidentally).

  749. Rob Swindell
    Thu Feb 03 2022 22:52:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    src/sbbs3/scfg/scfg.h diff
    src/sbbs3/scfg/scfgchat.c diff
    src/sbbs3/scfg/scfgsub.c diff
    src/sbbs3/scfg/scfgxfr2.c diff
    src/sbbs3/scfg/scfgxtrn.c diff
    src/sbbs3/scfglib1.c diff
    Better detection/rejection of duplicate sub and dir internal codes When manually adding a message/file area or modifying an internal code value, reject the code if it's a duplicate. This required that getsubnum() and getdirnum() support non-prepped configurations (where the full internal code has already been constructed from the prefix and suffix).

  750. Rob Swindell
    Thu Feb 03 2022 22:49:45 GMT-0800 (PST)
    Modified Files:
    

    exec/nntpservice.js diff
    Remove extra debug for Newsgroups heades, but log the internal code of sub

  751. Rob Swindell
    Thu Feb 03 2022 20:28:56 GMT-0800 (PST)
    Modified Files:
    

    exec/nntpservice.js diff
    Add debug log lines to help root-cause issue #334

  752. Rob Swindell
    Thu Feb 03 2022 19:21:41 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsub.c diff
    Clarify in the help that Message-ID hashing/checking cannot be disabled

  753. Rob Swindell
    Thu Feb 03 2022 19:22:27 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_archive.c diff
    JSDOC note to clarify that Archive() cannot be used to update an archive

  754. Rob Swindell
    Tue Feb 01 2022 19:13:48 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    add() method will now parse added, last_downloaded, and times_downloaded These 3 'stats' properties were read-only (never used when adding a file). To support moving files between FileBases while retaining these stats, support the parse/use of these file-meta-object property values. Should fix issue #333 reported by Nightfox.

  755. Rob Swindell
    Tue Feb 01 2022 01:26:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    Fix (loss of) carrier detect reporting in Virtual UART driver So Hobo and I have noticed that Global War was leaving game lock (*.LOK) files behind when he disconnected while in the game (e.g. due to the game not responding or something). This was happening because GWAR was not recognizing the loss of connection ("carrier detect" or DCD) and SBBS would ungracefully terminate the process after 5 seconds of being disconnected, thus the game lock files would remain and requiring manual clean-up. I discovered that if I changed the WAR.CFG file to use FOSSIL instead of UART, Global War would then correctly recognize the loss of carrier and exit gracefully (and not leave any .LOK files behind). So... I suspected an issue with the Virtual UART driver. It turns out, that a program that relies on the modem status register change interrupt (and doesn't "poll" the UART MSR register) might never know that the "carrier" was lost. This is fixed by waiting on the hungup_event in the interrupt_thread and deasserting DCD in the "virtual" MSR register and asserting the MSR change interrupt to notify the program that it has in fact changed. Good thing for WaitForMultipleObjects(). Uh huh.

  756. Rob Swindell
    Mon Jan 31 2022 20:57:12 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgxfr1.c diff
    src/sbbs3/upload.cpp diff
    Implement the sbbsfile.nam and sbbsfile.des post-processing in v3.19 This one was one of the last TODO items for the new filebase implementation: It's been supported (for a *long* time) that a file tester/upload processor could change the uploaded file's name or description by modifying the contents of the sbbsfile.nam and sbbsfile.des files in the node's directory (I know, great names, eh?). These files were not read-back into sbbs to apply any changes in v3.19b and that's now "fixed" though I'm not sure any file upload tester/processor actually ever made use of this feature. Also as part of this change, the '%s' specifier for the tester command-line will now be replaced with the path to the sbbsfile.des file and not the file's description itself (which could easily have been problematic for a command-line). Updated SCFG help text to suit.

  757. Rob Swindell
    Mon Jan 31 2022 19:33:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/bat_xfer.cpp diff
    src/sbbs3/listfile.cpp diff
    src/sbbs3/upload.cpp diff
    Call clearline() after displaying "working strings" for file processors Testable File Types and Download Events support working strings (display before/while the command-line executes). Clear the current line (displaying this working string) when the execution completes.

  758. Rob Swindell
    Mon Jan 31 2022 16:59:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs_ini.c diff
    src/sbbs3/websrvr.c diff
    src/sbbs3/websrvr.h diff
    By default, don't recognize filebase virtual path prefix for vhosts If the request is to a virtual web host, don't recognize the filebase vpath prefix (FileVPathPrefix setting) unless FileVPathForVHosts is set to "true" (in the [web] section of sbbs.ini). This addresses another of Deuce's concerns about this feature.

  759. Rob Swindell
    Mon Jan 31 2022 17:52:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/upload.cpp diff
    Fix "Testable Files" file extension comparison Issue introduced in v3.19: Testable Files (a.k.a. upload processors) with a specified file extension/type (e.g. "ZIP" and not "*") would never run because the file extension comparison logic was "off by one". Testable Files with an extension of "*" (all files/types) would still run however. This fixes issue #331 reported by Nightfox.

  760. Rob Swindell
    Mon Jan 31 2022 12:20:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Change "attempted to upload to invalid directory" msg Make it more accurate/clear: "attempted to upload invalid path/filename"

  761. Rob Swindell
    Mon Jan 31 2022 11:58:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Log the full path for rejected uploads based on directory The logged error "!attempted to upload to invalid directory" did log the actual path that was attempted to be uploaded. Added some quotes around other logged paths.

  762. Rob Swindell
    Sun Jan 30 2022 20:58:20 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Support an optional log identifier to syslog() Nelgin: "anyway to get sexpots to report itself differently to syslog" [?]

  763. Rob Swindell
    Sun Jan 30 2022 14:35:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Fix HTTP-requests for files >= 2GB in size An int is 32-bits on all supported platforms, so this has always been broken. The actual file size/request-length sent would depend on fun 2's complement math (a 32GB file was being truncated to 433MB). Also fixed some wrong uses of PRIuOFF: off_t is a signed integer, so technically the maximum file size you can request now is 2^63 bytes, which is "big enough".

  764. Rob Swindell
    Sat Jan 29 2022 20:19:14 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Add optional RingCount and RingInterval [modem] settings Only used in manual answer mode, RingCount defaults 1 (answer after the first ring) and RingInterval defaults to 6000 (maximum elapsed milliseconds between rings of the same "call"). This should address issue/feature-request #330 by Nelgin. Give that a try.

  765. Rob Swindell
    Sat Jan 29 2022 12:32:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Suppress "VDD Open failed" warning if child process terminated Another log message reported by DesotoFireflite (VALHALLA) that can happen when a user has typed something while the programming is running and the program terminates before the data can be sent to it.

AuthorCommitsLatest
Eric Oulashin74Mon Dec 05 2022 11:07:33 GMT-0800 (PST)
Rob Swindell616Mon Dec 05 2022 11:27:03 GMT-0800 (PST)
Rick Parrish2Sat Dec 03 2022 13:21:13 GMT-0800 (PST)
rickparrish2Mon Nov 28 2022 08:40:52 GMT-0800 (PST)
Deucе60Tue Nov 15 2022 14:46:56 GMT-0800 (PST)
Randy Sommerfeld2Sun Oct 23 2022 18:16:59 GMT-0700 (PDT)
Stephen Hurd1Tue Apr 12 2022 13:48:10 GMT-0700 (PDT)
Eugene So4Tue Mar 15 2022 10:06:34 GMT-0700 (PDT)
Deon George1Thu Feb 24 2022 18:50:33 GMT-0800 (PST)
echicken3Thu Feb 24 2022 06:10:37 GMT-0800 (PST)

For older commits (in CVS), click here

Dynamically generated in 561 milliseconds