Synchronet Git Commit Log

Modified Files:


src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

Add per-service option: NO_USER_PROT

If enabled, this option prevents logins to this service from changing the
protocol (aka modem) field for a user logging-in.

This is a work around for Deon who has some message areas set to require
"PROT NOT IMAP" for access requirements and when his IMAP client connects
and logs-in, that changes the protocol field in his user account (to "IMAP")
which means that user account cannot see/read those message areas (until the
protocol field is changed by another login to another server/service) and
thus won't receive echomail notifications for message received for them in
those areas.

Modified Files:


exec/tests/global/rtypes.js
diff

Fix wrong quote usage

Modified Files:


exec/tests/global/rtypes.js
diff

src/sbbs3/js_global.c
diff

Return null from resolve_ip('') and resolve_host('') even on Windows

Defeat the Windows getaddrinfo feature:
If the pNodeName parameter contains an empty string, all registered addresses
on the local computer are returned.

Modified Files:


exec/tests/global/rtypes.js
diff

resovle_ip('') returns a local IP address on Windows

at least for me, "fe80::5dfc:b29c:85d6:8de7%21"

Modified Files:


.gitlab-ci.yml
diff

Try running the jsexec-testsuite with the MSVC Win32 build

Modified Files:


exec/tests/global/rtypes.js
diff

resolve_host("") actually returns a string on Windows

at least, "vert.search.charter.net" in my case

Modified Files:


src/sbbs3/js_socket.c
diff

Add constants to the Socket class.

This is just the ones mentioned in the jsdocs.  I'll add more
if/when I want them. :D

Modified Files:


.gitlab-ci.yml
diff

Add a smoke test for msvc/win32 build of jsexec

Modified Files:


src/sbbs3/js_user.c
diff

Add User.security.deletion_date property

corresponding wth new user DELDATE field

Modified Files:


ctrl/text.dat
diff

src/sbbs3/text_defaults.c
diff

Add parameter to DeletedUser string (deletion or last activity date)

Modified Files:


exec/tests/system/except.js
diff

system.secondstr() does require an argumnet

Modified Files:


src/sbbs3/main.cpp
diff

Make JS global alert() and deny() methods inline with jsexec versions

alert() doesn't throw exception on null/undefined, just no arg

deny() throws exception on no args or null/undefined arg

Modified Files:


src/sbbs3/js_system.c
diff

system zonestr(), timestr(), and datestr() methods don't require an argumnet

So don't check for null/undefined argv[0] if not passed one

Modified Files:


src/sbbs3/js_internal.c
diff

Don't call JS_GC() after js.exec() until new background threads exit

Hopefully this will fix the occasional crash in the testsuites
(and presumably, occasional crash in other things that use background
threads with js.exec(), if there are any).

Except this time, in the right place.

Modified Files:


src/sbbs3/exec.cpp
diff

Revert "Don't call JS_GC() after js.exec() until new background threads exit"

This reverts commit ed8c30dabfca6158b3e9207a9f36f4fde0dd5f3a.

Modified Files:


src/sbbs3/exec.cpp
diff

Revert "Fix MSVC link error"

This reverts commit 7eb498aa080dc3bcd8162ff8c2b7e9a9448d4372.

Modified Files:


src/sbbs3/js_system.c
diff

src/sbbs3/userdat.c
diff

Resolve MSVC warnings

Modified Files:


src/sbbs3/exec.cpp
diff

Fix MSVC link error

Modified Files:


src/sbbs3/exec.cpp
diff

Don't call JS_GC() after js.exec() until new background threads exit

Hopefully this will fix the occasional crash in the testsuites
(and presumably, occasional crash in other things that use background
threads with js.exec(), if there are any).

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Update online help to describe deldays options accounting for DELDATE

User records (aka slots) will be preserved this many days since the user was
deleted (if the DELDATE field is non-zero) otherwise, days since last user
activity.

Modified Files:


src/sbbs3/js_system.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/userfields.h
diff

New userdat API functions for deleting and un-deleting user records

The initial purpose is to support new user field: DELDATE (user record
deletion date) - this allow user record retention for a period after
deletion rather than after period after last user activity.

The Win32 usereditor needs updating to use this function too.

Modified Files:


src/conio/cterm.c
diff

retbuf paranoia

Reported in unmonitor, which always passes NULL.

Modified Files:


src/xpdev/rwlockwrap.h
diff

src/xpdev/threadwrap.h
diff

Conditionally #include assert.h if we're going to define macros using it

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/mouse.c
diff

src/conio/sdl_con.c
diff

src/conio/win32gdi.c
diff

src/conio/x_cio.c
diff

src/conio/x_events.c
diff

src/syncterm/conn.c
diff

src/syncterm/conn_conpty.c
diff

src/syncterm/conn_pty.c
diff

src/syncterm/modem.c
diff

src/syncterm/ripper.c
diff

src/syncterm/rlogin.c
diff

src/syncterm/ssh.c
diff

src/syncterm/telnets.c
diff

src/syncterm/term.c
diff

src/xpdev/rwlockwrap.h
diff

src/xpdev/threadwrap.h
diff

src/xpdev/xpbeep.c
diff

src/xpdev/xpevent.c
diff

src/xpdev/xpsem.c
diff

Replace the multiple custom assert wrappers with a single set

Previously, different files had different sets of wrappers around
pthread_mutex_* and rwlock_* functions.  This commit removes those
and puts assert_ prefixed ones in threadwrap.h and rwlockwrap.h.

It also uses them in all the bits that SyncTERM uses.

This means debug builds are much more likely to unexpectedly
terminate with an assertion... when it does, let us know!

Modified Files:


src/xpdev/xpbeep.c
diff

Add missing re-lock in xptone_open_locked()

While we're here, add debug assertions to the pthread stuff.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Better parameter validation in bbs methods

More method will now throw exception if called without args:
bbs.check_filename(), bbs.logkey(), bbs.export_filelist()

bbs.check_syspass() will prompt for system password if passed null or undefined
value.

Fix (and document) the optional channel argument to bbs.multinode_chat()

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix bbs.compare_ars() called with no params

Throws an exception now instead of using uninitialized args:

;eval
Parameter(s): bbs.compare_ars()
InternalError: allocation size overflow

Updated JSDOCS for methods (mostly just adding punctuation). Fixed a typo
or two.

Modified Files:


src/sbbs3/suppressions.vg
diff

Actually, it turns out I just can't copy/paste correctly.

Modified Files:


src/sbbs3/js_user.c
diff

A little JSDOC updated text and beautification

Modified Files:


src/sbbs3/suppressions.vg
diff

Hrm, maybe the vg replace one doesn't count...

Modified Files:


src/sbbs3/suppressions.vg
diff

Expand pulseaudio suppression, add suppression for Linux

Modified Files:


.gitlab-ci-unix.yml
diff

src/sbbs3/suppressions.vg
diff

Add some leak suppressions and enable leak checks in valgrind.

Likely will fail for Linux if we need some OS-specific suppressions
like we do for FreeBSD.

Modified Files:


exec/tests/user/except.js
diff

exec/tests/user/rtypes.js
diff

src/sbbs3/js_user.c
diff

Scripts assume that calling user.compare_ars(undefined) will not throw

... an exception (e.g. chat_sec.js), so return false instead.

This fixes issue #864

Thank you Accession and Nelgin for the report

Modified Files:


.gitlab-ci-unix.yml
diff

Flip the valgrind switch...

Now that valgrind is working, remove the verbose flag, and have it
return 1 if any errors occur.

Modified Files:


src/sbbs3/suppressions.vg
diff

FreeBSD optimizes GCUntilDone() out... suppress on js_GC as well

Added Files:


src/sbbs3/suppressions.vg
diff

Modified Files:


.gitlab-ci-unix.yml
diff

.gitlab-ci.yml
diff

Add a test that runs valgrind on jsexec

We need some JS_GC() suppressions though.

Modified Files:


exec/delfiles.js
diff

Ajust the log levels and details of log messages

make the output less 'chatty'

Modified Files:


src/sbbs3/execfunc.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/useredit.cpp
diff

Rename sbbs_t::maindflts to ::user_config

Modified Files:


src/sbbs3/useredit.cpp
diff

Elminate meaningless typecast

Added Files:


3rdp/build/cl-size-doesnt-mean-copied.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Add a patch to avoid using uninitialized data as random source

sysctl() doesn't guarantee to copy data when the destination buffer
isn't large enough.

Makes Valgrind a lot easier to use on BSD systems by remove at tonne
of violations.

Modified Files:


src/sbbs3/sbbsecho.c
diff

More log messages around notifying users of imported echomail, for Deon

Log levels ERROR, NOTICE, and DEBUG

Modified Files:


src/sbbs3/userdat.c
diff

Zero-length string is not a valid real name.

Modified Files:


exec/tests/system/except.js
diff

system.findstr and matchuserdata no longer throw exceptions for undef 2nd arg

these functions just return the 'not found' equivalent return type when passed
null or undefined for the search string.

Modified Files:


exec/tests/system/rtypes.js
diff

Remove the debug output that helped identify which rtype function failed

Modified Files:


src/sbbs3/js_system.c
diff

More argument validation fixups for system.matchuserdata()

Modified Files:


src/sbbs3/js_system.c
diff

Fix system.matchuserdata() bug caught by tests/system/rtypes.js on rpi4

Argument count wasn't checked before checking/parsing each optional
argument.

Also noticed/ that the 'match_del' parameter added in commit
e61eb77b91fe didn't advance the argument index, fixed that issue.

Modified Files:


exec/tests/system/rtypes.js
diff

That didn't work, so try using stdout unconditionally

Just trying to get the output into the gitlab test failure output

Modified Files:


exec/tests/system/rtypes.js
diff

Enable some debug output to find which funcion is failing on rPi4

raspian-armhf-on-aarch64

Modified Files:


exec/tests/system/rtypes.js
diff

Remove get_node() rtype test, requires an sbbs installation (node.dab)

Modified Files:


src/sbbs3/js_system.c
diff

Fix typo in exception message about getnodedat() failure

Modified Files:


src/conio/bitmap_con.c
diff

Initialize off, then add an assert to suppress warning.

Modified Files:


src/conio/x_events.c
diff

Formatting

Added Files:


exec/tests/system/except.js
diff

exec/tests/system/rtypes.js
diff

exec/tests/system/skipif
diff

Modified Files:


src/sbbs3/js_system.c
diff

More parameter validation for JS 'system' methods

And corresponding tests

Modified Files:


src/conio/x_events.c
diff

Remove debug code

It looks like the ChromeOS WM is resizeing the window. :(

Modified Files:


src/syncterm/CHANGES
diff

Document Prestel fixes

Modified Files:


src/conio/x_events.c
diff

Add some debug logging

Maybe we can figure out what the Chromebook is doing...

Modified Files:


src/conio/x_events.c
diff

Recalculate scaling when resize_window() is called in fullscreen mode.

Modified Files:


ctrl/xtrn.ini
diff

Add delfiles (filebase maintenance) as a default timed event

This is how the max files/age of files in directories is enforced.

Modified Files:


src/sbbs3/GNUmakefile
diff

More rpath hackery...

If SBBSDIR is set, add $(SBBSDIR)/exec to rpath.
Always add the original output directory to rpath.

I'm not sure what the old LD_RUN_PATH stuff was trying to do, but
I think these are the bits that make it work.

Modified Files:


src/conio/bitmap_con.c
diff

Reset screena *and* screenb, not jsut screena and screena

Modified Files:


src/conio/bitmap_con.c
diff

When reallocating screen rects, reset the toprow.

Fixes error where toprow may end up past the bottom of the screen
when the screen size decreases.

Modified Files:


src/conio/bitmap_con.c
diff

Fix Prestel double-height bottom clearing issue

Any change to any double-height bit anywhere on the screen can
potentially change the display of every character after it on the
screen.  If the bit changes, force a full redraw from vmem
(Luckily there's no graphics in Prestel mode).

Fixes ticket 181
Ugh.

Modified Files:


src/conio/bitmap_con.c
diff

Fix Prestel regression on double-height text.

Visible in the double height graphics and engineering test pages.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/ciolib.h
diff

Fix Prestel reveal toggle

With the performance enhancements, ciolib didn't realize reveal
chars needed to be redrawn when reveal was toggled.  Use a FG colour
bit to indicate if it needs to be, and hack it up in same_cell()

Modified Files:


src/conio/bitmap_con.c
diff

Remove obsolete comment

Modified Files:


src/syncterm/ripper.c
diff

Work around what appears to be an integer promotion issue

On an aarch64 Chromebook running gcc 12.2.0, these would wrap in
weird ways causing vector fonts to be positioned incorrectly.

It managed to say that (25 - -7) * 4 / 3 == -168
This casting dance appears to resolve the issue.

Modified Files:


src/conio/cterm.c
diff

Indicate not running before posting sem

Memory is free()ed after sem is posted, so this write goes into
lalaland.

Modified Files:


src/syncterm/ripper.c
diff

Initialize the *new* memory, not the old stuff.

Fixes various memory corruptions with RIP

Modified Files:


src/sbbs3/sbbsecho.c
diff

Log messages when (attempting) to notify mail recipients (via short messages)

ERROR-level messages with error number, upon failure and debug-level message
upon success.

To hopefully help Deon get to the bottom of his SBBSecho echomail notification
issue.

Modified Files:


src/conio/bitmap_con.c
diff

Avoid unlocking screenlock to draw vmem.

Modified Files:


src/syncterm/GNUmakefile
diff

Link the SyncTERM resources to the .com, .exe, and .dll

Everyone gets an icon!

Modified Files:


src/conio/bitmap_con.c
diff

Properly handle 91-column EGA mode.

There's six pixels at the bottom that aren't part of text, and three
pixels on the right.

Don't touch the vmem when those pixels are updated... vmem can't
update them.

Should fix assertion in Abdul's Armor in RIP mode reported by DigitalMan
on IRC.

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

Store all wins received via msgbase (e.g. SYNCDATA) to netwins.jsonl

This should speed up loading the winnners list (e.g. when the syncdata msgbase
has a lot of messages) and scores won't be lost if the msgbase is purged.
Issue reported by Deuce (nix.synchro.net).

Bump version to 3.10.

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

Actually, I have no plans for new features soon... call this 1.5b

Modified Files:


src/sbbs3/sbbscon.c
diff

Fix JSDOCS WITH_SDL build.

Apparently, whatever was making this not link before has been fixed,
and so this workaround was breaking it.

Modified Files:


src/syncterm/CHANGES
diff

Document the fixes since 1.4

Modified Files:


exec/tests/global/rtypes.js
diff

Whoops, null is an object

Modified Files:


exec/tests/global/rtypes.js
diff

Fix type, and take a swing at not jsdoor compatibility.

Modified Files:


exec/tests/global/except.js
diff

exec/tests/global/rtypes.js
diff

src/sbbs3/js_global.c
diff

Throw fewer exceptions when passed null or undefined as parameters

Some scripts (e.g. addfiles.js) depend on the previous (undocumented) behavior
for some methods, e.g. lfexpand(undefined) would return undefined.

So for global functions that are expected to return a modified version of the
value passed (usually a string), return null or undefined when passed null or
undefined. Backward compatibility is more important than consistency in this
case. :-(

Modified Files:


src/syncterm/ripper.c
diff

Now that vstat.vmem has more stuff, ripper needs to hack up more.

Fixes assertion/crash in 91-column mode (used in LORD intro screens)

Modified Files:


src/conio/bitmap_con.c
diff

Fix scolling in modes that have extra rows

EGA 80x43 has an extra six pixels at the bottom that are not part
of the text area.  When scrolling the botmap buffer, be sure to not
update this area.

Also, fix some screen invalidation bits when setting pixels.

This should fix ticket 180.

Modified Files:


src/sbbs3/jsexec.c
diff

Fix misalignment (by uncrustify?)

Modified Files:


src/conio/bitmap_con.c
diff

Fix major performance regression in RIP rendering

A high number of RIP commands use setpixel(), and it was updated
to scan the whole vmem for changes on each call.  Now we just extract
the part that is relevant and only update the one cell if needed.

This also adds parameter validation to bitmap_setpixel() which can
prevent some memory corruption and crashes.

Modified Files:


src/conio/cterm.c
diff

Fix race condition in starting/stopping playnote thread

Modified Files:


src/sbbs3/jsexec.c
diff

Check/read the passed module path/name section in jsexec.ini first

... before the more ambiguous base filename check.

e.g. if you run 'jsexec /path/to/test.js' and get separate set of settings
from running 'jsexec test.js' depending on which sections you have added to
your jsexec.ini file.

Added Files:


exec/tests/user/except.js
diff

exec/tests/user/rtypes.js
diff

Modified Files:


src/sbbs3/js_user.c
diff

More JS 'user' class method parameter validation

And tests to insure the expected behavior

Modified Files:


src/syncterm/ripper.c
diff

Do the lock assertion thing in ripper.c too.

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/GNUmakefile
diff

Don't link with libraries we run-time link :(

Modified Files:


src/syncterm/GNUmakefile
diff

Add WITHOUT_JPEG_XL build option

For those who want to force JPEG XL off, and don't use CMake

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

And this is now 1.5a

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

Update to 1.4

Modified Files:


exec/tests/global/sound.js
diff

Fix test for modified path

Modified Files:


src/sbbs3/jsexec.c
diff

MethodJIT crashes on OpenBSD

Disable it in jsdoor

Modified Files:


exec/tests/global/nettype.js
diff

Fix error in detecting jsdoor.

Added Files:


exec/tests/user/skipif
diff

Modified Files:


.gitlab-ci-unix.yml
diff

Add skipif for user.

Also, give test suites different names.

Modified Files:


.gitlab-ci-unix.yml
diff

Run tests in both jsdoor and jsexec

Modified Files:


exec/tests/global/nettype.js
diff

Don't run test in jsdoor

Modified Files:


exec/tests/global/format.js
diff

exec/tests/user/birthdate.js
diff

Don't use const

The behaviour is unreliable in Spidermonkey 1.8.5, and the behaviour
will change based on JS options.

Modified Files:


exec/tests/test.js
diff

Add support for a skipif file in each directory.

If this file contains valid JS code that returns a true value, the
directory is skipped.

Modified Files:


src/sbbs3/js_system.c
diff

src/sbbs3/jsexec.c
diff

Fix JSDoor warnings

Modified Files:


src/syncterm/libjxl.c
diff

Don't fail JPEG XL due to missing JxlDecoderSetParallelRunner()

That just means we can't do parallel, not that we can't do JPEG XL

Modified Files:


src/syncterm/libjxl.h
diff

If JPEGXL_MAJOR_VERSION isn't define, define to zero.

It wasn't in v0.6.x, which is packaged by Haiku.

Modified Files:


exec/tests/global/rtypes.js
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/main.cpp
diff

Make global read(0) and readln(0) return undefined

This is really an error condition, so like the jsdocs say:
return undefined upon error

This how read(0) worked in sbbs, but not jsexec before that last commit,
so now just make readln and read work like that in both sbbs and jsexec.

Added Files:


exec/tests/global/except.js
diff

exec/tests/global/rtypes.js
diff

Modified Files:


src/sbbs3/js_archive.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptkeyset.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_mqtt.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

Global JS function parameter validation and updated return types

Many global functions now throw an exception when null or undefined is passed
as a required parameter where null or undefined makes no sense.
e.g. "Argument #1 is an unexpected 'null' or 'undefined' value"
Example exception: is-a/has-a type functions will still return false when
passed null or undefined.

Changed global function return types:
- write() now always returns undefined
- printf() always returns a string, never undefined or garbage string
- prompt() returns null (not undefined) upon no input (as documented)

sbbs works more like jsexec:
- read(0) now returns an empty string instead of undefined
- readln(0) no longer waits for enter

jsexec works more like sbbs:
- add missing write_raw() global function, alias for write()

Include expected number of argment in "Insufficient Arguments" exception
message.

Update JSDOCS for some global methods:
- file_chmod returns boolean, not number
- flags_str requires a minimum of one argument

New tests to validate expected exceptions and return types based on usage.

Modified Files:


xtrn/bullshit/bullshit.js
diff

xtrn/bullshit/package-lock.json
diff

xtrn/bullshit/package.json
diff

New build with workaround for terminal cleanup on exit.

Updated TS4S so we can build with -t while issue #777 is ongoing.

Ran `npm audit fix` to address a security issue in some dependency
of the build system. Perhaps this will silence the alert GitHub
sent to DM; I'm not sure what that was.

Modified Files:


exec/tests/crypt/cert.js
diff

exec/tests/test.js
diff

Make these tests runnable from sbbs

Don't use chdir(), just use js.exec_dir instead (e.g. for location of test.crt)

Use console instead of stdout when stdout isn't defined.

Log the file and line number of an an exception in a nested test when it
happens.

Modified Files:


xtrn/ansiview/install-xtrn.ini
diff

xtrn/ansiview/readme.txt
diff

xtrn/ansiview/settings.ini
diff

Remove ecbbs online archive from defaults.

Modified Files:


exec/fido-nodelist-browser.js
diff

New build from https://gitlab.synchro.net/echicken/nodelist-browser

Fixes #794, esc exits. Other hotkeys reassigned per discussion
that happened I think on DOVE-Net.

Fixes #818, show/hide cursor on netmail.

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix previous commit.

Was overriding value, not appending.

Modified Files:


src/sbbs3/GNUmakefile
diff

Include absolute rpath

It appears that setcap may cause $ORIGIN to stop working for some
unknown reason.

Modified Files:


src/syncterm/telnets.c
diff

Set initial telnet modes in telnets

Not sure how I missed this one.

Modified Files:


src/syncterm/Manual.txt
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/conn_telnet.c
diff

Add new "Binmode Broken" option for telnet.

In this mode, SyncTERM won't will/do TELNET_BINARY_TX at the start
of a connection, leaving the mode up to the remote system. The main
purpose for this option is to work around a bug in older Synchronet
releases where early CTRL-C checking wouldn't work in binary mode.

Implements feature request 91.

Modified Files:


src/sbbs3/js_system.c
diff

Add system.birthdate_template string property

Suitable for passing to console.gettemplate() when prompting for a birth date.

I'm using like this in my logon.js to correct corrupted newuser birth dates:
  while(user.age < 10) {
	console.putmsg(bbs.text(bbs.text.EnterYourBirthday));
	user.birthdate = console.gettemplate(system.birthdate_template);
  }

Modified Files:


src/sbbs3/js_system.c
diff

4 new system properties related to date formatting

- date_format
- date_separator
- date_verbal
- birthdate_format

See JSDOCs for details

Modified Files:


src/sbbs3/jsexec.c
diff

Increase formatted log/console output buffers from 1K to 8K

... make them more useful (e.g. when the result of script is a big string).

Modified Files:


src/syncterm/syncterm.man.in
diff

Update BUGS section

Modified Files:


src/conio/ciolib.h
diff

src/syncterm/CHANGES
diff

src/syncterm/term.c
diff

Rewrite status bar code

This will prevent the cursor from showing up when redrawing the
status bar, and implements feature request 79.

Modified Files:


src/conio/sdl_con.c
diff

Fix initial scaling and initial scaling mode in SDL mode

This isn't great, but it works (on FreeBSD)

Modified Files:


src/syncterm/CHANGES
diff

src/xpdev/xpbeep.c
diff

Reduce audio level by -12dB.

It was at absolute max (an extra one and it would clip) which is
really a terrible thing to do to people wearing headphones.

I don't really need to do it this way, but the math for the different
wave forms depends heavily on integer wrapping (and WAVE_SHAPE_SINE_HARM
is just stupid).

Modified Files:


src/syncterm/syncterm.c
diff

Fix OSS appearence in Audio settings.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/Manual.txt
diff

Audio output menu

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

Allow configuring audio output type

Compile-time isn't the best time for configuration.

Modified Files:


src/xpdev/xpbeep.c
diff

src/xpdev/xpbeep.h
diff

Allow controlling sound output types with a global.

Modified Files:


.gitlab-ci-unix.yml
diff

Use non-buffered output for jsexec console (log) messages

Modified Files:


exec/tests/global/format.js
diff

Add an explicit undefined in there too.

Modified Files:


exec/tests/global/format.js
diff

src/sbbs3/js_sprintf.c
diff

Fix fencepost error in format arguments.

The first argument after the list was still being replaced.
Extended test to try the hard stuff.

Added Files:


exec/tests/global/format.js
diff

A very basic initial set of tests for format()

Modified Files:


.gitlab-ci.yml
diff

Re-run CI pipeline when tests are added or modified

Added Files:


exec/tests/global/nettype.js
diff

Ported nettype.js from exec/bench to exec/tests

Modified Files:


exec/avatars.js
diff

Work-around avatars.js line 271: TypeError: hdr is null

with a null hdr check before use (corrupt msg base?)

Modified Files:


exec/default.js
diff

Remove "Or" from ;help hint since the '?' hint isn't displayed in novice mode

Modified Files:


src/sbbs3/jsexec.c
diff

Revert "Temporary debug to find out where/why jsexec is hanging during mac mini
m4 CI test"

This reverts commit ebe52737cd48d45a843d12eaa7909551f491cc36.

Modified Files:


src/sbbs3/jsexec.c
diff

Revert "Add an fflsuh() for temp debug spew"

This reverts commit 4ce915370298c9c4912a4d4095852854a0726225.

Modified Files:


src/xpdev/dirwrap.c
diff

Revert "Add some temporary debug output to find the mac mini m4 hang"

This reverts commit 33be8662a0d67a0ced7f06587fdec01a27b818a8.

Modified Files:


.gitlab-ci-unix.yml
diff

Actually set SBBSCTRL (not SBBSEXEC) env var

Modified Files:


.gitlab-ci-unix.yml
diff

Try setting SBBSCTRL env var instead

gitlab-runner on my Mac mini doesn't have access to /sbbs

Modified Files:


src/xpdev/dirwrap.c
diff

Add some temporary debug output to find the mac mini m4 hang

Modified Files:


src/sbbs3/GNUmakefile
diff

Use ORIGIN everywhere.

We don't build on SunOS anymore, and using LD_RUN_PATH sucks.
Also, it was badly out of date.

Modified Files:


src/sbbs3/jsexec.c
diff

Add an fflsuh() for temp debug spew

Modified Files:


src/sbbs3/jsexec.c
diff

Temporary debug to find out where/why jsexec is hanging during mac mini m4 CI
test

Modified Files:


.gitlab-ci-unix.yml
diff

Wrong path to ctrl dir (not that it really matters I think)

Modified Files:


src/sbbs3/GNUmakefile
diff

For NetBSD, add $ORIGIN and $ORIGIN/../$(LIBODIR) to the RPATH

Modified Files:


.gitlab-ci-unix.yml
diff

Specify path to ctrl directory on jsexec command-line

Modified Files:


.gitlab-ci-unix.yml
diff

Attempt to run exec/tests/ using JSexec instead of JSdoor

attempt #2

Modified Files:


.gitlab-ci-unix.yml
diff

Revert "Use jsexec for these JS tests instad of jsdoor, jsdoor doesn't have a
User class"

This reverts commit 5c6a22ed3dd74637c37ee84696313ff249a24929.

This doesn't work cause:

Unable to create pipeline
openbsd-amd64 js-testsuite job: undefined need: openbsd-amd64 [jsexec]

and I'm not about to copy/paste those 50 lines to create the needed jsexec
artifact. <sigh>

Modified Files:


.gitlab-ci-unix.yml
diff

Use jsexec for these JS tests instad of jsdoor, jsdoor doesn't have a User
class

If we want to (re)run a specific set/subset of tests with jsdoor, perhaps we
can
come up with some naming scheme that allows that, but for now, it's more
important
that jsexec is correctly functioning than jsdoor.

Modified Files:


src/conio/mouse.c
diff

Don't enter the drag start on a move event unless drag is enabled.

Likely fixes difficulties pasting in SyncTERM.
Probably want to define some minimum amount you need to move to
trigger dragging.

Added Files:


exec/tests/user/birthdate.js
diff

Modified Files:


src/sbbs3/userdat.c
diff

Refactor the birthdate parsing logic, add unit test

The birthdate parsing is now a lot more robust and will recognize all kinds
of variants/formats and use range checks to disambiguate provided dates and
even support partial dates (e.g. year only, year/month and month/year).

The tests should all pass regardless of what the sysop has set for their
system date format in SCFG.

I had considered using sscanf() for the parsing logic but ended up going with
strtoul() only and that seems to be working well (as reflected by the passing
test cases).

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Change terminate_server to correct type expected by xpms_add* functions

Modified Files:


src/sbbs3/userdat.c
diff

Fix parsing of field-separated birthdate strings with 4-digit year

... which is the format expected/required when entering or editing birthdates
in the terminal server. So this is a pretty embarassingly bad bug introduced
just before the v3.20b release to fix a less-severe bug with ecWeb new user
registration (still) writing 2-digit years to the user.birthdate field. :-(

Fix for issue #863

I considerd making these get_birthdate field functions more tolerant of less
strictly formatted strings (e.g. single-digit month or day), but decided to
keep this change to just a fix for the issue at hand. These functions could be
more robust to handle more variance in user/script input.

Modified Files:


src/sbbs3/load_cfg.c
diff

Remove dead code, fixing CID 530828

Added Files:


3rdp/build/cl-remove-silly-pragmas.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Remove all the pragmas telling me what I did.

This is mostly as a test for using git to generate these patches.

Modified Files:


src/conio/sdl_con.c
diff

src/xpdev/xpbeep.c
diff

Decorate intentional sleeps while holding lock

So they're auto-triaged in Synchronet.

Modified Files:


src/xpdev/sdlfuncs.c
diff

Don't leak sdl_dll (make it global)

Also, don't do stupid things if called more than once.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/xpdev/multisock.c
diff

src/xpdev/multisock.h
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Pass an optional 'terminated' (bool pointer) to the multi-sock bind functions

This allows a server that's being terminated to stop the port-bind delay/retry
loops and terminate more quickly in cases of port binding failures.

Added Files:


src/syncterm/.indent.pro
diff

Add config file for GNU indent

Also not happy with this one.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

load_cfg() can now report config file warnings

Log the error string if it's non-blank, as a warning (e.g. unrecognized
text.ini text.dat string ID).

Reduce the number of logged messages when config load failure happens.

Commonize the load_cfg() error log messages.

Modified Files:


ctrl/text.dat
diff

exec/load/text.js
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

src/sbbs3/xtrn.cpp
diff

Add/use "NoDOS" text.dat string

Displayed instead of hard-coded string in xtrn.cpp when attempting to run
16-bit DOS program on system with no DOS/DOSemu support.

Modified Files:


src/sbbs3/scfg/scfgsub.c
diff

Don't display FidoNet address and origin line when not-FidoNet-enabled sub

Displaying these settings when they're not used can confuse sysops.

Modified Files:


src/uifc/uifc32.c
diff

Resolve MSVC warning

Added Files:


src/syncterm/.astylerc
diff

Modified Files:


src/syncterm/bbslist.c
diff

Add an AStyle config that doesn't bother me.

Biggest issue with this one is it doesn't allow BSD-style continuation
indentation, and forces aligning with parens.

Added Files:


src/syncterm/.clang-format
diff

Config for ClangFormat

This is almost, but not quite great.

The biggest issue where it falls over is in struct array indentation
and breaking.  It tries to force everything onto one line, making it
illegible. :(

Modified Files:


src/syncterm/uncrustify.cfg
diff

Update for latest uncrustify

Still not completely happy with it.

Modified Files:


src/encode/lzh.c
diff

src/encode/uucode.c
diff

src/sbbs3/ans2asc.c
diff

src/sbbs3/answer.cpp
diff

src/sbbs3/ars.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/baja.c
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/chksmb.c
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/execnet.cpp
diff

src/sbbs3/filelist.c
diff

src/sbbs3/fixsmb.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getmail.c
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/getstr.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_msg_area.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_server.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_uifc.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/services.c
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/sbbs3/zmodem.c
diff

src/smblib/smballoc.c
diff

src/smblib/smblib.c
diff

src/uifc/filepick.c
diff

src/uifc/uifc32.c
diff

src/uifc/uifctest.c
diff

src/uifc/uifcx.c
diff

src/uncrustify.cfg
diff

src/xpdev/dat_file.c
diff

src/xpdev/genwrap.c
diff

src/xpdev/xpdatetime.c
diff

Split one-liner if () statements into 2 lines

uncrustify nl_split_if_one_liner setting

Modified Files:


3rdp/win64.release/libjxl/lib/libbrotlicommon.a
diff

3rdp/win64.release/libjxl/lib/libbrotlidec.a
diff

3rdp/win64.release/libjxl/lib/libhwy.a
diff

3rdp/win64.release/libjxl/lib/libjxl.a
diff

3rdp/win64.release/libjxl/lib/libjxl_threads.a
diff

Rebuild without AVX support.

Win64 builds were crashing decoding JPEG XLs on my AMD lappy.

Modified Files:


src/encode/base64.c
diff

src/encode/lzh.c
diff

src/encode/uucode.c
diff

src/encode/yenc.c
diff

src/hash/md5.c
diff

src/sbbs3/ans2asc.c
diff

src/sbbs3/ansiterm.cpp
diff

src/sbbs3/answer.cpp
diff

src/sbbs3/ars.c
diff

src/sbbs3/asc2ans.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/baja.c
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/bulkmail.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/chksmb.c
diff

src/sbbs3/con_hi.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/data_ovl.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/download.cpp
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/execnet.cpp
diff

src/sbbs3/fido.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filelist.c
diff

src/sbbs3/finddupes.c
diff

src/sbbs3/fixsmb.c
diff

src/sbbs3/fmsgdump.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getmail.c
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/getstr.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_client.c
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_conio.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptkeyset.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msg_area.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_queue.c
diff

src/sbbs3/js_request.c
diff

src/sbbs3/js_server.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_sprintf.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_uifc.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/js_xtrn_area.c
diff

src/sbbs3/jsdebug.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.c
diff

src/sbbs3/mime.c
diff

src/sbbs3/msdirent.c
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/mxlookup.c
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/nopen.c
diff

src/sbbs3/ntsvcs.c
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/pktdump.c
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/readtext.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/ringbuf.c
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsexec.c
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/services.c
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/sftp.cpp
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/sockopts.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/telnet.c
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

src/sbbs3/text_sec.cpp
diff

src/sbbs3/textgen.c
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/trash.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/upgrade_to_v320.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/ver.cpp
diff

src/sbbs3/viewfile.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xmodem.c
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/sbbs3/zmodem.c
diff

src/smblib/smbadd.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbdump.c
diff

src/smblib/smbfile.c
diff

src/smblib/smbhash.c
diff

src/smblib/smblib.c
diff

src/smblib/smbstr.c
diff

src/smblib/smbtxt.c
diff

src/uncrustify.cfg
diff

src/xpdev/dat_file.c
diff

src/xpdev/datewrap.c
diff

src/xpdev/filewrap.c
diff

src/xpdev/genwrap.c
diff

src/xpdev/ini_file.c
diff

src/xpdev/link_list.c
diff

src/xpdev/msg_queue.c
diff

src/xpdev/netwrap.c
diff

src/xpdev/sdlfuncs.c
diff

src/xpdev/semfile.c
diff

src/xpdev/semwrap.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/str_list.c
diff

src/xpdev/strwrap.c
diff

src/xpdev/threadwrap.c
diff

src/xpdev/wraptest.c
diff

src/xpdev/xp_dl.c
diff

src/xpdev/xp_syslog.c
diff

src/xpdev/xpbeep.c
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpevent.c
diff

src/xpdev/xpprintf.c
diff

src/xpdev/xptime.c
diff

Remove unnecessary parenthesis in return statements

... using uncrustify mod_paren_on_return config

Modified Files:


src/encode/base64.c
diff

src/encode/base64.h
diff

src/encode/hex.c
diff

src/encode/hex.h
diff

src/encode/lzh.c
diff

src/encode/lzh.h
diff

src/encode/utf8.c
diff

src/encode/utf8.h
diff

src/encode/uucode.c
diff

src/encode/yenc.c
diff

src/hash/crc16.c
diff

src/hash/crc16.h
diff

src/hash/crc32.c
diff

src/hash/crc32.h
diff

src/hash/md5.c
diff

src/hash/md5.h
diff

src/hash/sha1.c
diff

src/hash/sha1.h
diff

src/sbbs3/ans2asc.c
diff

src/sbbs3/ansiterm.cpp
diff

src/sbbs3/answer.cpp
diff

src/sbbs3/ars.c
diff

src/sbbs3/ars_defs.h
diff

src/sbbs3/asc2ans.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/bulkmail.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/chksmb.c
diff

src/sbbs3/client.h
diff

src/sbbs3/cmdshell.h
diff

src/sbbs3/con_hi.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/dat_rec.c
diff

src/sbbs3/dat_rec.h
diff

src/sbbs3/data.cpp
diff

src/sbbs3/data_ovl.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/dllexport.h
diff

src/sbbs3/download.cpp
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/echocfg.c
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/execnet.cpp
diff

src/sbbs3/fastcgi.h
diff

src/sbbs3/fido.cpp
diff

src/sbbs3/fidodefs.h
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filelist.c
diff

src/sbbs3/finddupes.c
diff

src/sbbs3/findstr.c
diff

src/sbbs3/findstr.h
diff

src/sbbs3/fixsmb.c
diff

src/sbbs3/fmsgdump.c
diff

src/sbbs3/fossdefs.h
diff

src/sbbs3/fossinfo.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/getctrl.c
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getmail.c
diff

src/sbbs3/getmail.h
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

src/sbbs3/getstr.cpp
diff

src/sbbs3/htmlansi.h
diff

src/sbbs3/ident.c
diff

src/sbbs3/ident.h
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_cache.h
diff

src/sbbs3/js_client.c
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_conio.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_cryptcert.h
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptcon.h
diff

src/sbbs3/js_cryptkeyset.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_mqtt.c
diff

src/sbbs3/js_msg_area.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_queue.c
diff

src/sbbs3/js_request.c
diff

src/sbbs3/js_request.h
diff

src/sbbs3/js_rtpool.c
diff

src/sbbs3/js_rtpool.h
diff

src/sbbs3/js_server.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_socket.h
diff

src/sbbs3/js_sprintf.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_uifc.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/js_xtrn_area.c
diff

src/sbbs3/jsdebug.c
diff

src/sbbs3/jsdebug.h
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mail.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.c
diff

src/sbbs3/mime.c
diff

src/sbbs3/mime.h
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/msdirent.c
diff

src/sbbs3/msdirent.h
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msg_id.h
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/msgdate.h
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/mxlookup.c
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/nodedefs.h
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

src/sbbs3/ntsvcs.c
diff

src/sbbs3/ntsvcs.h
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/pktdump.c
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwk.h
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/readsauce.c
diff

src/sbbs3/readtext.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/ringbuf.c
diff

src/sbbs3/ringbuf.h
diff

src/sbbs3/riodefs.h
diff

src/sbbs3/sauce.c
diff

src/sbbs3/saucedefs.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbs_ini.h
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

src/sbbs3/sbbsexec.c
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/scfgsave.h
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/sexyz.h
diff

src/sbbs3/sftp.cpp
diff

src/sbbs3/slog.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/sockopts.c
diff

src/sbbs3/ssl.c
diff

src/sbbs3/ssl.h
diff

src/sbbs3/startup.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/telnet.c
diff

src/sbbs3/telnet.h
diff

src/sbbs3/text_sec.cpp
diff

src/sbbs3/textgen.c
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/trash.c
diff

src/sbbs3/trash.h
diff

src/sbbs3/trashman.c
diff

src/sbbs3/uartdefs.h
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/upgrade_to_v320.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/vdd_func.h
diff

src/sbbs3/ver.cpp
diff

src/sbbs3/ver.h
diff

src/sbbs3/viewfile.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

src/sbbs3/wordwrap.c
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xmodem.c
diff

src/sbbs3/xmodem.h
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/sbbs3/zmodem.c
diff

src/sbbs3/zmodem.h
diff

src/smblib/smbadd.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbdump.c
diff

src/smblib/smbfile.c
diff

src/smblib/smbhash.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

src/smblib/smbstr.c
diff

src/smblib/smbtxt.c
diff

src/uifc/filepick.c
diff

src/uifc/filepick.h
diff

src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

src/uifc/uifc_ini.c
diff

src/uifc/uifctest.c
diff

src/uifc/uifcx.c
diff

src/uncrustify.cfg
diff

src/xpdev/conwrap.c
diff

src/xpdev/dat_file.c
diff

src/xpdev/datewrap.c
diff

src/xpdev/dirwrap.c
diff

src/xpdev/filewrap.c
diff

src/xpdev/genwrap.c
diff

src/xpdev/haproxy.h
diff

src/xpdev/ini_file.c
diff

src/xpdev/link_list.c
diff

src/xpdev/link_list.h
diff

src/xpdev/lockfile.c
diff

src/xpdev/msg_queue.c
diff

src/xpdev/msg_queue.h
diff

src/xpdev/multisock.c
diff

src/xpdev/netwrap.c
diff

src/xpdev/petdefs.h
diff

src/xpdev/rwlockwrap.c
diff

src/xpdev/rwlockwrap.h
diff

src/xpdev/sdlfuncs.c
diff

src/xpdev/sdlfuncs.h
diff

src/xpdev/semfile.c
diff

src/xpdev/semfile.h
diff

src/xpdev/semwrap.c
diff

src/xpdev/semwrap.h
diff

src/xpdev/showlocks.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sopenfile.c
diff

src/xpdev/str_list.c
diff

src/xpdev/strwrap.c
diff

src/xpdev/strwrap.h
diff

src/xpdev/threadwrap.c
diff

src/xpdev/unicode.c
diff

src/xpdev/unicode_defs.h
diff

src/xpdev/wrapdll.h
diff

src/xpdev/wraptest.c
diff

src/xpdev/xp_dl.c
diff

src/xpdev/xp_dl.h
diff

src/xpdev/xp_syslog.c
diff

src/xpdev/xp_syslog.h
diff

src/xpdev/xpbeep.c
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpdatetime.h
diff

src/xpdev/xpendian.h
diff

src/xpdev/xpevent.c
diff

src/xpdev/xpevent.h
diff

src/xpdev/xpmap.c
diff

src/xpdev/xpprintf.c
diff

src/xpdev/xpprintf.h
diff

src/xpdev/xpsem.c
diff

src/xpdev/xptime.c
diff

First pass run of uncrustify (code beautification)

White-space changes only, exception being the rare insertion of NL before
closing brace (couldn't find the option to disable that behavior).

I excluded some header files (e.g. sbbs.h) since uncrustify seemed to be doing
more harm than good there. I might just end up applying different set of rules
to .h files.

Modified Files:


src/hash/sha1.c
diff

Fix typo in example code in comment causing uncrustify 0.80 to assert

do_source_file: Parsing: sha1.c as language C
parse_cleanup(479): pc orig line is 257, orig col is 33, Text() is '}', type is
BRACE_CLOSE
parse_cleanup(485): (frm.top().type + 1) is VBRACE_CLOSE
parse_cleanup(492): File: sha1.c, orig line is 257, orig col is 33, Error:
Unexpected '}' for 'VBRACE_OPEN', which was on line 256

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Closing brace on its own line (style change only)

Modified Files:


src/sbbs3/execmisc.cpp
diff

Add missing closing bracket in #ifdef'd out code block

Causing uncrustify (0.80) to assert:

do_source_file: Parsing: execmisc.cpp as language CPP
parse_cleanup(479): pc orig line is 1257, orig col is 55, Text() is ')', type
is PAREN_CLOSE
parse_cleanup(485): (frm.top().type + 1) is SQUARE_CLOSE
parse_cleanup(492): File: execmisc.cpp, orig line is 1257, orig col is 55,
Error: Unexpected ')' for 'SQUARE_OPEN', which was on line 1257

Added Files:


src/uncrustify.cfg
diff

A stock uncrustify 0.80 config generated with 'uncrustify --show-config'

Uncrustify-0.80.1-47-ba7fc1679

Added Files:


3rdp/build/cl-fix-constptrptr.patch
diff

3rdp/build/cl-fix-void-ptrs.patch
diff

3rdp/build/cl-intptr-t.patch
diff

3rdp/build/cl-wrong-string-length.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

3rdp/build/cl-mingw64-thread-handles.patch
diff

A few more Win64 on MinGW fixes

Some of these likely break WinCE support.

Modified Files:


src/conio/sdl_con.c
diff

Make Coverity happy by moving fullscreen inside of win_lock

Modified Files:


src/conio/bitmap_con.c
diff

Assert/debug wrappers for trylock() are silly.

Modified Files:


src/xpdev/rwlockwrap.c
diff

Don't leve the wlk critical section on wrlock success.

That *is* the write lock!

Modified Files:


src/xpdev/Common.gmake
diff

Use pkg-config for alsa.

Don't go digging around in the filesystem when you don't have to.

Modified Files:


src/xpdev/Common.gmake
diff

Don't use ALSA on Windows.

Modified Files:


src/xpdev/genwrap.c
diff

More fixups for clock selection.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/sdl_con.c
diff

src/xpdev/Common.gmake
diff

src/xpdev/genwrap.c
diff

More fixups...

Some Coverity issues, some deadlocks, some crashes...
Just misc stuff.

Modified Files:


src/conio/vidmodes.c
diff

Resolve MSVC warnings

Modified Files:


src/conio/bitmap_con.c
diff

No need to pass the vstat_vmem around either.

Also, we can now use a read lock.

Modified Files:


src/conio/bitmap_con.c
diff

We only need to use get_vmem() if we're copying vstat.

Modified Files:


src/conio/bitmap_con.c
diff

Remove some debugging code.

Modified Files:


ctrl/text.dat
diff

src/sbbs3/text_defaults.c
diff

Fix alignment of the Author and Group file info strings

Modified Files:


src/sbbs3/scansubs.cpp
diff

Don't scan for new files (after new messages scan) when new file time is 0

(e.g. new user)

Modified Files:


src/sbbs3/execmisc.cpp
diff

Use return value of datestr() for PCMS/Baja DATESTR function

Similar bug fix as that just made to system.datestr()

Modified Files:


exec/load/shell_lib.js
diff

Don't bother prompting for new file scan when scan pointer is 0

Modified Files:


src/sbbs3/js_system.c
diff

Add missing paren

Modified Files:


src/sbbs3/js_system.c
diff

Fix system.datestr(0) returning garbage

Actually use the return value of datestr()

Fixes issue reported by Deuce, regression introduced in commit 490e86fa38c

Modified Files:


exec/lbshell.js
diff

Remove stutter.

Modified Files:


exec/lbshell.js
diff

Since datestr() now can return "Never" avoid calling datestr with 0.

"Scan for New Files since Never" is gibberish.

Modified Files:


src/sbbs3/readtext.c
diff

Range check value when using default text.

Modified Files:


src/sbbs3/js_internal.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

Move js_CreateArrayOfStrings from main.cpp to js_internal.c

To fix jsdoor build

Modified Files:


src/sbbs3/js_archive.c
diff

Add Archive.supported_formats (array of strings)

Helpful for scripts that want to know what file types (extensions) are
supported by the Archive class object.

Still need to work out the JSDOC support for this. Similar to the
Socket class object properties, this will have no documentation/description.

Modified Files:


src/conio/bitmap_con.c
diff

Fix error displaying Minesweeper field

We need to set the "has pixels set" flag in both vmem and in the
bitmap_drawn array to prevent the update from erasing the pixels.

This is likely what the duplicated line was originally, then it got
broken when I switched to the vmem_cell_*() functions.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_printf_percent_fix' into 'master'

DDMsgReader: %% should be used with printf() to show a percent sign.  "% "
seemed to be showing <error> in some cases (but not always)

See merge request main/sbbs!491

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: %% should be used with printf() to show a percent sign.  "% "
seemed to be showing <error> in some cases (but not always)

Modified Files:


src/conio/bitmap_con.c
diff

No need to do the same thing twice.

Modified Files:


src/sbbs3/ars.c
diff

src/sbbs3/ars_defs.h
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/userdat.c
diff

Create/use ar_type() to eliminate some copy/pasta in AR/ARS parsing logic

Modified Files:


src/sbbs3/websrvr.c
diff

Another use of errprintf() to help de-dupe error logs/alerts

Modified Files:


src/syncterm/term.c
diff

Don't egregiously use strlen() for ZRQ and OOII buffers.

We're building these one byte at a time, we know the length.
1.98s

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/syncterm/term.c
diff

Have cterm_write() return the length of the retbuf.

For now we're still using strlen, but we can avoid the call for
the common case of zero-length returns.

Modified Files:


src/syncterm/term.c
diff

Don't sleep() after receiving input.

2.1 seconds.

Modified Files:


src/xpdev/rwlockwrap.h
diff

Put the now-shared rwlock_destroy_ign() back for *nix.

Modified Files:


src/xpdev/rwlockwrap.c
diff

src/xpdev/rwlockwrap.h
diff

Make rwlock wrappers static inline functions instead of macros.

This should avoid angering Coverity.

Modified Files:


src/syncterm/modem.c
diff

Remove unused variable.

Modified Files:


src/xpdev/link_list.c
diff

NULL check needs to be outside the lock. :D

Also, no, Coverity still doesn't know from recursive mutexes.

Modified Files:


src/syncterm/modem.c
diff

Whoops, forgot to remove the loop.

Thanks coverity!

Modified Files:


src/xpdev/link_list.c
diff

Coverity actually found legitimate issues in link_list.c

They're all from accessing list values outside of a lock.
Lock the list earlier to include these.

Also, does this mean it knows they're recursive now?
Let's find out!

Modified Files:


src/xpdev/xpsem.c
diff

Don't bother checking the impossible.

Modified Files:


src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

Ok, it's weird for the _upload() function to close the stream.

Make the one who opens it responsible for closing it.

Modified Files:


src/conio/ciolib.c
diff

Remove weird 1-length array.

Modified Files:


src/conio/bitmap_con.c
diff

Put assert()s around all the locking in bitmap_con.c

Modified Files:


src/conio/bitmap_con.c
diff

Move video flags out from under vstatlock.

This is a heavily accessed value that is rarely changed and was
causing a lot of contention on vstatlock.

Down to 2.9 seconds.

Modified Files:


src/conio/win32gdi.c
diff

Fix typo

Modified Files:


src/conio/bitmap_con.c
diff

Use rwlock_t, not pthread_rwlock_t

Derp.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/bitmap_con.h
diff

src/conio/sdl_con.c
diff

src/conio/win32gdi.c
diff

src/conio/x_cio.c
diff

src/conio/x_events.c
diff

src/syncterm/ripper.c
diff

Use a rwlock for vstatlock.

Down to 3.4s now.

Modified Files:


exec/ircdcfg.js
diff

Only create the main context once.

Fixes issue where returning to the main menu always takes you to
the top option.

Modified Files:


src/syncterm/modem.c
diff

src/syncterm/rlogin.c
diff

src/syncterm/telnets.c
diff

Give the same input improvement to everything but SSH.

The SSH input thread is too complex to easily make this change.

Modified Files:


src/conio/bitmap_con.c
diff

Remove unused set of coff.

Modified Files:


src/syncterm/ripper.c
diff

Add unreachable code

Coverity thinks it can do the default case.

Modified Files:


src/syncterm/ripper.c
diff

Fix a memory leak and an allowed out-of-bounds access.

Thanks Coverity!

Modified Files:


src/syncterm/conn_pty.c
diff

Don't loop waiting to write entire received data to conn buf

Shaves time down to 3.85 seconds.

Modified Files:


src/conio/bitmap_con.c
diff

Fix updating of bitmap_drawn() when drawing

Fixes high CPU when nothing is happening.

Modified Files:


src/conio/bitmap_con.c
diff

We don't need to multiply the row by cols anymore.

Modified Files:


src/conio/bitmap_con.c
diff

Fix incorrect offset advancement function

Modified Files:


src/sbbs3/websrvr.c
diff

Resolve GCC warning enumeration value ‘PARSED_VPATH_x’ not handled in
switch

Modified Files:


src/sbbs3/ars.c
diff

Fix the auto-keyword detection based on parameter type for USER, DIR, and SUB

SUB and DIR have long had this bug, but I just noticed while playing with the
new USER keyword capabilities (specifying user numbers and/or names).

If you switched between numeric and alpha/string parameters, without restating
the ARS keyword, the keyword would could end up wrong in the parsed byte array.

Modified Files:


src/sbbs3/ars.c
diff

src/sbbs3/ars_defs.h
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/userdat.c
diff

User aliases can be used as parameters to the "USER" ARS keyword

Caveat: the name parameter cannot contain a space, so excludes spaces or
replace them with '.' or '_': the user's alias will match.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/websrvr.c
diff

parse_vpath() no longer takes access requirements into account

This fixes issue #748

Modified Files:


exec/testbuild.js
diff

Update the source archive, support more non-Linux-x64 *nix builds (e.g. macOS)

Modified Files:


exec/default.js
diff

Give hint for ;help command upon unrecognized command input

Modified Files:


exec/delfiles.js
diff

Use the "max_age" and "max_files" values from configuration if not set in base

Work-around for issue #861

This is the utility script for maintaining file bases, if you didn't know. :-)

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/vidmodes.c
diff

src/conio/vidmodes.h
diff

Make vstat vmem a ringbuffer as well.

This shaves off another .75 seconds, and gets rid of the last
glaring plateau in the stack flamegraph.

What's interersting is that I'm seeing my CPU utilization drop now
too, which implies I've reached the speed of the pty connection
type, or the speed of the term worker loop.  Maybe I'll look there
next, but since the pty isn't a major use-case for SyncTERM, I may
not... at this point it's just benchmark golf.

Modified Files:


src/conio/bitmap_con.c
diff

Add missing unlock, and silence Coverity warning.

Modified Files:


src/xpdev/link_list.c
diff

Spell Coverity wright.

Modified Files:


src/conio/cterm.c
diff

Get strspn() out of the ANSI hot path.

This was the only standout issue when profiling the ANSI parsing
code, and is a trivial fix since we're pretty much only checking
contiguous ranges of characters.

Unfortunately, I didn't create a test for comparison here.

Modified Files:


src/syncterm/CHANGES
diff

Just call the imporvement "massive" and leave it at that.

Still massaging more speed out of it.

Modified Files:


src/conio/cterm.c
diff

Get strncat() and strnlen() out of the hot path...

Down to 4.7s now... 38× faster.
Starting to get somewhere useful now.

Modified Files:


src/syncterm/CHANGES
diff

Note performance is better.

Modified Files:


src/conio/bitmap_con.c
diff

Discard the drawn cache when we load a new video mode.

Fixes issue where the screen would be weird during the connecting
phase.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/ciolib.h
diff

Mark cells when they have pixels set in them.

This way, when a character overwrites, we can detect it.
Also, document the various magic colour bits.

Modified Files:


src/conio/bitmap_con.c
diff

Another big speedup...

Since we update the bitmap before drawing a frame now, we can just
mark the cells incorrectly moved by advancing the bitmap ringbuffer
as dirty and known they'll be redrawn.

This gets rid of the memmove on full-width scrolling, and gets us
into the 6s range.

Modified Files:


src/conio/bitmap_con.c
diff

Another large speedup... only update bitmap when drawing a frame

Previously, every change would be flushed through to the bitmap, now
it only flushes before a frame is sent to the driver, or when specific
things (like setting pixels) occur.

This about doubles the throughput again, running the test at 11
seconds (started at 179).  At a 16× speedup now from when I started.

This can now display at about 10Mbps, which is still kinda slow,
but at least it's not completely terrible anymore.

This could likely be improved by better timing of the frame
generation... it tries to hot 100Hz right now, which is a bit
excessive.

Modified Files:


exec/user_settings.js
diff

Fix a couple of bugs with the [L] Terminal Dimensions option

1. It never saved the rows value set by the user
2. It would not set the current online user values immediately
3. It would only call console.getdimenions() when *both* values were set

Modified Files:


src/sbbs3/con_out.cpp
diff

Propagate the non-auto user terminal dimensions to the runtime values, always

Previously, if either of the user terminal dimensions was set to a auto (0)
then we wouldn't propagate the other specific (non-zero) value to the runtime
console dimension. Usually a user will set either both values (cols and rows)
to 0/auto or neither. So this isn't a oft-used configuration combo.