Synchronet Git Commit Log

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Support text.dat string IDs (string) args for replace/revert_text() funcs

For alignment with the text() method and for instances where a script author
doesn't want to load('text.js') or use [bbs|system].text.ID to get a text.dat
string index from an ID.

Modified Files:


src/sbbs3/postmsg.cpp
diff

If user doesn't modify the replied-to-msg subject, use the original subject

(which might be UTF-8 encoded). This works-around the problem that Accession
reported in #synchronet with my reply to a UTF-8 encoded message using a CP437
terminal which resulted in a message body that was UTF-8 encoded but a message
subject that was CP437 encoded. This mix of encodings is not supported by FTN
standards.

This is just a work-around since if the user modifies the subject the result
could still have the CP437 unside-down question marks (indicating
non-translatable UNICODE chars) and those should be converted to UTF-8
chars when going out on FTN or being stored in the message base. So there's
still a bug here somewhere that I need to look into more.

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix off-by-one usage of snprintf() when copying message subject

- when converting from CP437 to UTF-8
- when reading from RESULT.ED drop file

This effectively limited message subjects in some instances to 69 chars
instead of 70. This bug was caught while debugging a replied-message subject
conversion from UTF-8 to CP437 issue reported by Accession.

Modified Files:


exec/default.js
diff

exec/str_cmds.js
diff

Add RELOAD sysop command to reload a (JS) command shell without logoff/on

We have to use load() (rather than js.exec) to invoke str_cmds.js so that an
exit() will actually exit. Since load() automatically does the mods vs exec
directory search-dance, that simplifies the code in default.js a little.
I'm not sure exactly why I originally chose to use js.exec() over load() for
invoking str_cmds.js, but for this feature, we need load() so let's go with
that for now.

I did encounter an issue (issue #840) while originally trying to make this
work with the original code that called js.exec(), but just punted and went
with load() instead. Perhaps if we fix issue #840, we can revert default.js
back to using js.exec() (but why we would need/want to, I'm not sure).

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_metadata_desc_undefined_fix' into 'master'

ddfilelister: Check whether 'desc' is a string in file metadata before trying
to use it. Should fix issue #839

Closes #839

See merge request main/sbbs!482

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

ddfilelister: Check whether 'desc' is a string in file metadata before trying
to use it. Should fix issue #839

Modified Files:


src/sbbs3/getnode.cpp
diff

src/sbbs3/putnode.cpp
diff

Fix use of unitialize variable

Since we we're not using opennodeext(), we don't have the path/fname for
any failure error message here.

CID 515714

Modified Files:


src/sbbs3/userdat.c
diff

Fix incorrect use of sizeof in node_vstatus and node_activity

This would cause the "Logout" status and multinode chat activity
strings to be truncated to 3 or 7 chars.

CID 515713 and 515715

Modified Files:


src/ssh/ssh-trans.h
diff

We need separate context for client to server

Modified Files:


.gitlab-ci.yml
diff

Disable darmwin-x86

System is going on a trip.

Modified Files:


src/sbbs3/getnode.cpp
diff

Reset/send status attr after activity, which could include Ctrl-A codes

Modified Files:


src/sbbs3/userdat.c
diff

Insure ctrl chars/codes are stripped from nodestatus() output

Use strlcpy instead of strncpy

Modified Files:


exec/load/presence_lib.js
diff

Insert stats prefix after activity, in case it contains attr codes

Modified Files:


exec/fingerservice.js
diff

Use new node (customizable) activity, if available (and strip ctrl chars)

This allows customized node actions/activity to be sent over finger/activeuser
(so visible in sbbsimsg.js for example).

Modified Files:


src/sbbs3/gtkmonitor/gtkmonitor.c
diff

src/sbbs3/umonitor/umonitor.c
diff

Load text.dat to get customized node status strings from text.dat/text.ini

Modified Files:


ctrl/text.dat
diff

exec/load/presence_lib.js
diff

exec/load/text.js
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/MainFormUnit.h
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/js_system.c
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Overhaul how custom Node actions and status strings are handled

Custom NodeStatus and NodeAction/Activity strings are now displayed pretty
much everywhere possible (except the node utility, since it doesn't read
any configuration files). This fixes issue #618, finally.

If you have custom (non-blank) NodeAction* strings in your text.dat/text.ini
file, or you change these strings during runtime (e.g. using bbs.replace_text)
this will impact you:
- do not include the user name or any other fields normally included in
  printed node status in your string - just the customized node action and
  really, you should only use/override these strings for dynamically changing
  node status (i.e. you're using NodeActionCustom and you're setting different
  custom strings depending on current node activity). Consider using the new
  NodeActivity* text.dat strings instead if your customized string doesn't
  change during run-time.
- don't use the %s/%u/%d specifiers any more - use @-codes instead, if needed

If you want static/permanent node action strings, set new new NodeActivity*
strings in your text.dat or (preferrbaly) text.ini file instead.
This means the node actions can now be localized for other languagues!

I'm still using the node.exb file (I did consider alternatives, e.g.
node.ini or node*/activity.asc), but decided to postpone such a change.
The node.exb file is still used, but the strings represent just the custom
(extended) node *activity* and not the entire node status string.

Use of Ctrl-A codes needs to be considered/accounted-for (currently isn't).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix the areas.bbs AreaMgr addition bug created in commit 813072cd450c2

The newly created/used link_aera() function was copying the address of the
passed fidoaddr_t pointer rather than the value (fidoaddr) pointed to.
This is the actual fix for the problem reported by Tom Moore (1:135/205)
- tested and validated. It only immediately impacted areas.bbs use
(not areas.ini), since we wrote a stringified address directly to the
areas.ini file "links" key. This was not an allocation issue but a memcpy()
issue.

Other unrelated changes:
- Log a debug-level message when ignoring a "NO-ECHO" message (subject "NE:*")
- Log a notice-level message when ignoring a message due to GATEWAY VIOLATION
  (gating a message between net-types when not explicitly configured to do so)

Modified Files:


src/sbbs3/sbbsecho.c
diff

A differnt 'fix' to link_area()

So, (sizeof *addr) now looks right got me (this should've been the same as
sizeof(fidoaddr_t)), so the change in commit e2476ebbaa doesn't actually look
like a fix, but maybee a regression.

I need to test some area manager link additions and get to the bottom of this,
but this particular change was not a fix (and caught/reported by Coverity -
CID 515673).

Added Files:


src/ssh/comp/none.c
diff

src/ssh/comp/none.h
diff

src/ssh/enc/none.c
diff

src/ssh/enc/none.h
diff

src/ssh/mac/none.c
diff

src/ssh/mac/none.h
diff

Modified Files:


src/ssh/CMakeLists.txt
diff

src/ssh/client.c
diff

src/ssh/ssh-trans.h
diff

Add the "none" encryption mac and compression drivers

This is not the "hard part" I meantioned earlier. :D

Modified Files:


src/ssh/client.c
diff

src/ssh/ssh-trans.c
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.h
diff

Eliminate egregious and unneeded allocations.

Modified Files:


exec/automsg.js
diff

Fix typo: bbs.node_action, not bbs.action

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix insufficient allocation bug in link_area() introduced in commit 813072cd4

This is likely the cause of the areamgr issue that resulted in weird/invalid
node address being added to the area file, reported by Tom Moore (1:135/205).

Modified Files:


src/sbbs3/ctrl/EventsFormUnit.cpp
diff

src/sbbs3/ctrl/EventsFormUnit.h
diff

Update comment header blocks to remove CVS references and such

Modified Files:


src/sbbs3/main.cpp
diff

Don't try to renaming a bad (unpackable) REP packet if it doesn't exist

There still appears to be some race condition with network (Samba) FS
directory caching and opening/locking of files, so it does seem illogical that
the packet file wouldn't exist at this point (since we have the lock file
opened) but this does still happen on occasion on Vertrauen.

Modified Files:


src/sbbs3/un_rep.cpp
diff

Eliminate some redundant log output in Unpack REP failure condition.

Modified Files:


src/sbbs3/js_console.cpp
diff

Parse console.inkey() timeout parameter as an *unsigned* integer

A negative timeout value doesn't make sense and this will extend the legal
(positive) range of this parameter value.

Hopefully this will help eliminate these errors I get often:
  dd_lightbar_menu.js line 4041: Error: can't convert inputTimeoutMS to an
  integer

But if there's some way that this parameter value is even out of the range of
an unsigned 32-bit value (4294967295) then this error could still happen.
Unfortunately, the JS exception doesn't report the value that failed to
convert.

Modified Files:


src/sbbs3/logon.cpp
diff

Check return value of getnodedat()

Should fix CID 515599 since this seems to be the only place we call
unlocknodedat() without possibly not owning the nodefile_mutex already.

Modified Files:


src/sbbs3/putnode.cpp
diff

More nodefile_mutex fixes

Need to unlock the mutex before calling errormsg().

Need unlock the mutex in error path of unlocknodedat().

I'm not clear why this would, but it might resolve CID 515601 which looks
like false positive to me: getnmsg()->putnodedat() should never leave
nodefile_mutex locked.

Modified Files:


src/sbbs3/load_cfg.c
diff

Check return value of smb_create() in smb_open_dir()

Resolves CID 515657

Modified Files:


src/sbbs3/readmail.cpp
diff

Always free(mail)

I don't think this was actually a leak (since smb.msgs should be non-zero
any time mail is non-null), but to make Coverity happy (CID 515659) and just
be more fault-tolerant, always free(mail).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_list_select_msg_move_to_next_refresh_fix' into
'master'

DDMsgReader: Screen refresh fix for selecting messages when automatically
moving to the next message at the menu's last row on the screen

See merge request main/sbbs!481

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Screen refresh fix for selecting messages when automatically
moving to the next message at the menu's last row on the screen

Modified Files:


src/ssh/ssh-trans.c
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.h
diff

And add the hooks for the rest of the transport stuff

Should be possible to implement the hard stuff now, though it won't
actually be testable until the KEX bits exist too.

Smooth sailing after that though.

Modified Files:


src/xpdev/dirwrap.c
diff

Optimize mkpath()

If the path already exists (is a directory), don't need to check each path
element for existence.

This should help with the speed of saving of large file.ini (Nelgin's) when a
lot of directories have "Check for File Existence" set to "Yes".

Modified Files:


src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Verify QWK messagse files (e.g. MESSAGES.DAT) is multiple of QWK block size

(128 bytes)

Fix up the filename in error messages reported during unpacking QWK packets
(MESSAGES.DAT not BBSID.QWK).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Truncate the GIT date (remove time) in Program ID.

Modified Files:


src/sbbs3/msg_id.c
diff

Fix GIT date truncation (e.g. "202" instead of "2024") in program-ID

Modified Files:


src/xpdev/filewrap.h
diff

Resolve Borland build warning: missing xp_lockfile() prototype

Modified Files:


src/xpdev/filewrap.c
diff

Appears MinGW requires '_locking' Borland requires 'locking' and MSVC does both

Modified Files:


src/xpdev/filewrap.c
diff

In Boland's io.h, this function is just called locking()

Modified Files:


src/xpdev/filewrap.c
diff

Need locking.h here for Borland C++ build

Modified Files:


src/xpdev/filewrap.c
diff

Move the xp_lockfile() into a compile block that includes Borland

Modified Files:


src/xpdev/filewrap.c
diff

Fix typo in Windows version of xp_lockfile()

Modified Files:


src/sbbs3/logfile.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

Introduce/use errprintf() for de-duplicated/prioritized error logging

Convert more log messages to use de-duplication as solution to issue #619.

A lot more lprintf() -> errprintf() conversions will be needed to fully
realize this solution (e.g. in the mail, ftp, web, services serverss).

Modified Files:


src/sbbs3/prntfile.cpp
diff

Add "Printing file" and "Printing tail" debug-level log messages

In printfile() and printtail() which are used by menu() and many other
functions.

These should be helpful to sysops that just want to know what file is being
displayed under what conditions (e.g. for trouble-shooting or customization
reasons).

Modified Files:


exec/webfileindex.ssjs
diff

Display directory aliases from web_alias.ini as shortcuts on index page

Other kinds of aliases are supported in web_alias.ini (e.g. libraries, files)
but not displaying those here (yet).

Modified Files:


exec/load/tree.js
diff

Address occasional TypeError: this.current is undefined

Modified Files:


src/sbbs3/userdat.c
diff

Make user_downloaded_file() tolerant of being passed a file path

... instead of just the file name, as was expected.

Modified Files:


webv4/root/api/files.ssjs
diff

user.downloaded_file() expects *just* the filename, not a full path

This is why files downloaded via ecWebv4 haven't been properly accounted.

Modified Files:


src/sbbs3/userdat.c
diff

src/xpdev/filewrap.c
diff

src/xpdev/filewrap.h
diff

Add/use xp_lockfile() to support blocking file range/region lock acquisition

Under heavy loads, I've found periodic non-blocking lock attempts just aren't
reliable enough: in particular, on Vertrauen, the guest user account record
in the user.tab file gets read and written-to A LOT (updating stats), and
under heavy loads (especially with hundreds of web client sessions), I'd get
timeouts attempting to lock the guest record in the user.tab (after about a
minute of periodic retries) - so let's just block "forever" to get the user
record lock (or until signaled or notified of a deadlock). With this change,
I've not had any user.tab lock errors or apparent deadlocks.

Let the underlying OS/filesystem handle queuing and deadlock detection,
when supported. lock() still behaves as before: non-blocking lock attempt.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_indexed_newscan_no_snap_selection_bug_fix' into
'master'

DDMsgReader: Bug fix - For indexed newscan without snap-to-new, ensure it
remembers the user's previously selected sub-board (reported by Keyop)

See merge request main/sbbs!480

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Bug fix - For indexed newscan without snap-to-new, ensure it
remembers the user's previously selected sub-board (reported by Keyop)

Added Files:


src/ssh/client.c
diff

Modified Files:


src/ssh/CMakeLists.txt
diff

src/ssh/ssh-trans.c
diff

src/ssh/ssh.h
diff

Add a test client and fix a couple bugs.

Modified Files:


exec/addfiles.js
diff

Overhaul the help output and display valid lib names when helpful

- If sysop specifies an invalid lib name, show them what the valid names are
- Make it clear that the directory specified (dir-spec) is either a combination
  of -lib and -dir *or* -all *or* dir-code *or* nothing (a get prompted)
- When using -all, clear the list of specified directories to prevent dupe
  dir scanning when misused.

Modified Files:


exec/addfiles.js
diff

Allow any-case for library name used with -lib=name option

Modified Files:


exec/addfiles.js
diff

Auto-convert specified directory codes to lowecase

Modified Files:


exec/addfiles.js
diff

Allow a comma-separate list of dir-codes to be passed to -dir option

Modified Files:


exec/addfiles.js
diff

Add -dir=<code> option to manually specify multiple directories

As requested by Nelgin.

And this option is mutually exclusive with the [dir-code] parameter.

Modified Files:


src/sbbs3/logfile.cpp
diff

De-duplicate repeated errors logged via sbbs_t::errormsg() by reducing severity

... from ERROR to WARNING, so the repeats won't be logged to error.log file
and won't (normally) be sent as notifications (e.g. emails) to the sysop. The
duplicates are identified as from the same source file and line number as the
immediately previous logged error within the last 12 hours. String comparison
doesn't really work for deduplication since if you look closely, the errors
usually are *not* exact duplicates (i.e. there's a node number or a socket
descriptor or something that uniquely identifies the user/client/session).
Repeated errors don't increment the node's error counter either.

This does not de-duplicate errors logged via other means (e.g. direct calls to
log()/lputs(),lprintf() with a severity of LOG_ERR or higher), but will
solve the majority of duplicate errors that can be logged from the terminal
server.

So this at least partially addresses issue #619.

Modified Files:


src/xpdev/filewrap.c
diff

Clean up the OFD check/decision, make use of fcntl() locks easier to opt-in

Modified Files:


src/ssh/ssh-trans.c
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.c
diff

src/ssh/ssh.h
diff

More transport work.

Next step is to implement a KEX.

Modified Files:


src/comio/comio_nix.c
diff

Enable ISTRIP mode when fewer than 8 bits are requested.

With this, SyncTERM and SexPOTS on *nix won't actually need to strip
received bytes themselves.  No idea what Windows does though, so
it'll likely still be needed forever.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_option_listing_msgs_select_goes_to_next_msg' into
'master'

DDMsgReader: New user option & behavior: In a message list, when
selecting/toggling a message, it can now optionally move the cursor to the next
message

See merge request main/sbbs!479

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: New user option & behavior: In a message list, when
selecting/toggling a message, it can now optionally move the cursor to the next
message

Modified Files:


exec/avatars.js
diff

.ini files need to be opened for read/write access when writing/updating

This happened to work before commit d49134e6f7 since iniReadFile()
didn't return false upon any read error, so File.iniSetAllObjects() didn't
realize that the read of (any) existing file contents had failed (because the
file was open write-only).

This explains why the *.avatars.ini files were pretty much blank as of late
and no networked message posters were having their avatars displayed.
Reported by Codefenix (thank you).

Add a print/log line to tell us how many avatars were parsed, just for extra
traceability of this script and any potential failure cause.

Added Files:


src/ssh/ssh-trans.c
diff

src/ssh/ssh.c
diff

Modified Files:


src/ssh/CMakeLists.txt
diff

src/ssh/portable.h
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.h
diff

The start of the transport layer and the public API.

Added Files:


src/ssh/portable.h
diff

Modified Files:


src/ssh/ssh-arch.c
diff

src/ssh/ssh-arch.h
diff

Introduce portable.h for ugly hacks

The plan is to hide non-standard stuff in here.  Currently, just
has [[maybe-unused]] from C23.

Modified Files:


src/ssh/CMakeLists.txt
diff

Use FindOpenSSL instead of pkg-config for OpenSSL

Added Files:


src/ssh/CMakeLists.txt
diff

src/ssh/ssh-arch.c
diff

src/ssh/ssh-arch.h
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.h
diff

Start of DeuceSSH

The intent is that this will be a library implementation of SSH
which allows simple extension of the base protocol, and exposes all
defined features of the protocol (including ones nobody uses).

This will support both client and server, with initial focus on the
client implementation for use in SyncTERM.

The goal of the core library is to only support the most secure
standard methods.  When there are multiple methods that are not
clearly of differing levels of security, the most common two will
be implemented (ie: RSA and Ed25519).

Additionally, care will be taken during development to allow for
the OpenSSH Encrypt-then-MAC MAC modes in the expectation that
someone will standardize an ETM mode at some point, and I expect
to write an extension to support it soon after DeuceSSH is
complete.

Finally, if I cannot mitigate Terrapin without non-standard
extensions, the OpenSSH "strict KEX" extension will be supported
until there's a standard defined that solves the issue.

Modified Files:


src/sbbs3/nopen.c
diff

On Windows, lock the opened mutex file to insure *nix sopen() will fail

Even though we use O_EXCL, networked file systems still sometimes allow the
secondary open() to succeed. We use record locking in xpdev's sopen()
implementation for *nix, so this lock will insure such opens (and locks) will
now fail.

This is an attempt to address occassional error on Vertrauen:
ERROR 2 (No such file or directory) renaming *.rep to *.bad

Modified Files:


src/sbbs3/un_rep.cpp
diff

Log an info-level message before unpacking a REP packet

Modified Files:


src/sbbs3/userdat.c
diff

Check return value of writeuserfields() in putuserstr()

Return correct error value upon seek failure.

Modified Files:


src/xpdev/filewrap.c
diff

Don't use flock() in sopen() since it ends up using non-OFD fcntl() locks

When OFD locks are available, that's what we should be using.
Otherwise, we suffer the horrible behavior of POSIX file/region locks and
a subsequent open/close of the file releases any/all locks on it.

This is currently in an !BSD block, which appears to include macOS, but
macOS *does* support OFD locks, so I'll be fixing that here shortly.

Modified Files:


ctrl/text.dat
diff

Add NodeActionCustom (blank, by default)

Modified Files:


src/sbbs3/getnode.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/userdat.c
diff

Handle NODE_CUSTOM action and print default node status

"performing custom action"

Normally, the sysop would set the NodeActionCustom text.dat string
to override this.

Modified Files:


exec/load/nodedefs.js
diff

exec/load/text.js
diff

Add the new NodeCustom action

Modified Files:


src/sbbs3/nodedefs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

Define custom node action value

This is to be used (e.g. instead of NODE_BXFR) for sysop-custom node actions.

Modified Files:


src/sbbs3/getnode.cpp
diff

White-space changes only

Modified Files:


src/sbbs3/putnode.cpp
diff

Support @-codes in NodeAction text.dat strings

Modified Files:


src/sbbs3/userdat.c
diff

Add random jitter to lockuserdat() and putnodedat() retry delays

so that if multiple entities call these functions at the same time, they
don't retry at exactly the same times.

Modified Files:


src/sbbs3/execnet.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mxlookup.c
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/services.c
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/sockopts.c
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/websrvr.c
diff

Use SOCKET_ERRNO instead of (now deprecated) ERROR_VALUE macro

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/multisock.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Add/use SOCKET_ERRNO (in place of ERROR_VALUE)

Modified Files:


src/xpdev/xp_syslog.c
diff

Eliminate unused variable

Modified Files:


src/xpdev/sockwrap.h
diff

Borland C++ apparently doesn't support inline functions (!)

Modified Files:


src/sbbs3/js_global.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/services.c
diff

src/xpdev/ini_file.c
diff

src/xpdev/multisock.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Make socket errno and string descriptions easier to get/use

Add/use SOCKET_STRERROR which gets the description of the *last* socket
error.

We should start using socket_errno(true) in place of ERROR_VALUE (horribly
named macro) for comparing last socket error nubers against values/macros
from errno.h.

Eliminate get_socket_errno(), unused and redundant with socket_errno().

Modified Files:


src/xpdev/sopenfile.c
diff

Add -c and -R options

Really need to make the option order (arity) neutral

Modified Files:


src/sbbs3/ver.cpp
diff

Fix strlcpy() usage

Modified Files:


src/xpdev/sockwrap.c
diff

Fix typo in get_socket_errno() definition

Modified Files:


src/sbbs3/main.cpp
diff

Log the error description upon failure to send on socket

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/con_hi.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/execnet.cpp
diff

src/sbbs3/fido.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_system.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/login.cpp
diff

src/sbbs3/mail.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/sftp.cpp
diff

src/sbbs3/str.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/ver.cpp
diff

Replace sprintf() calls with snprintf()

Addresses Clang warnings about deprecation

Modified Files:


src/build/Common.gmake
diff

Add -L to LDFLAGS, not CFLAGS for macos builds

This fixes all the "argument unused during compliation" warnings

Added Files:


3rdp/build/cl-dont-validate-va-list.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Fix idiodic check that a va_list != NULL

This breaks armv7 FreeBSD builds.  Presumably it breaks anything
else where va_list isn't a pointer too... and there's no real reason
to expect a va_list to be a pointer except "it's a pointer on the
platform I looked at".

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Unify the int return values of userdat.c functions

These functions now return a common set of non-zero error values (where
appropriate), defined in userdat.h

Don't return errno.

Modified Files:


src/sbbs3/answer.cpp
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/bulkmail.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mail.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Simplify the getnode.cpp API - use bool returns, default paramaeter value

getnodedat() now performs a non-locked read by default.

Perform more checks of getnodedat() return value before calling putnodedat()
to avoid unintentionally zeroing out node.dab records.

Add/use unlocknodedat() method for unlocking a node.dab record without
writing.

Note: The userdat.c getnodedat() and putnodedat() still return int (i.e. 0 on
success), so that can be confusing.

Modified Files:


exec/freqitcfg.js
diff

Don't call uifc.bail() repeatedly

Since this script already sets an on_exit() handler to call uifc.bail()
it doesn't have to call it again (technically, before) in the "Done" block.
This results in "UIFC is unitialized" error displayed, as reported by
Fernando Toledo. Fixing issue #830

Set WIN_ESC (remains active, but greyed when ESC key pressed) mode flag
on main menu while we're here. That looks better.

Modified Files:


src/sbbs3/ctrl/WebCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/WebCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/WebCfgDlgUnit.h
diff

Add max concurrent connections edit box to web cfg dialog

Modified Files:


exec/load/newsutil.js
diff

When the originating address is the same as the name, just include one

There's no need to be unnecessarily redundant in the From header, e.g.
From: "scan-admin@coverity.com" <scan-admin@coverity.com>

Modified Files:


exec/load/newsutil.js
diff

MIME-encode To and From header fields that contain non-ASCII chars

This fixes the display of gitlab pushes from Deucе in conforming news readers.

Modified Files:


src/sbbs3/websrvr.c
diff

Track and report the concurrent connections per client highwater mark

It's possible now for clients to easily exceed the configured max concurrent
connections limit, even though they just get an error 429 page. Let's at least
track and log when a new highwater mark is reached.

Modified Files:


exec/nntpservice.js
diff

More RFC (3977) conformance

Some of the NNTP commands (e.g. LIST) aren't supposed to change the "currently
selected newsgroup". Had to use a different variable name (e.g. mb versus
msgbase) since these message base variables share the function scope).

GROUP and LISTGROUP commands are supposed to set the "current article number"
to the first article in the group. We weren't doing this.

The HEAD, BODY, STAT, and ARTICLE commands aren't *required* to have arguments
and yet, we required they had at least one argument (an article number). Now
fixed.

Enabled "strict mode" even though that didn't catch the colliding 'msgbase'
variable definitions.

Incremented the revision to 1.2

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_clear_after_menu_draw_fix' into 'master'

DDLightbarMenu: When clearing the remainder of the screen after drawing the
menu, ensure the console attributes are reset. Also, refactored that section of
code.

See merge request main/sbbs!478

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DDLightbarMenu: When clearing the remainder of the screen after drawing the
menu, ensure the console attributes are reset. Also, refactored that section of
code.

Modified Files:


exec/load/mimehdr.js
diff

exec/load/newsutil.js
diff

Create/use mimehdr encode() method for MIME/Q-encoding UTF-8 header fields

Use it in newsutil get_news_subject() when no original (RFC822)
Subject header field exists.

This should fix issue #817.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Eliminate some harmless gcc warning about using uninitialized vars

Modified Files:


src/sbbs3/logon.cpp
diff

Move the backup of dsts.ini before opening the file

Can't backup (make copies of) an open file.

Added Files:


web/root/error/429.html
diff

Add 429 error page

Modified Files:


src/sbbs3/websrvr.c
diff

Since this is after client_on() is called now, use > not >=

Modified Files:


src/sbbs3/websrvr.c
diff

Move max concurrent connections check into http_session_thread()

We can't send a 4xx error (ie: client did something wrong) in
plaintext on a TLS connection.

Untested beyond a basic compile check.

Modified Files:


src/conio/Common.gmake
diff

Fix the pipeline that DigitalMan broke.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

Implement max concurrent connections (per IP) limit in web server, default: 10

We have this feature for the FTP, Mail, and Terminal servers (with no default
limit) but crazy abuse of my Synchronet web servers has now made this a
necessity for Vertrauen. A limit of 2 used to be considered reasonable long
ago. Today, 10 seems fair enough. Setting to 0 will impose no max-connections
per IP address (other than the total client limit per server).

Modified Files:


src/conio/Common.gmake
diff

src/conio/GNUmakefile
diff

Fix X11 build option checkbox

Similar problem as PulseAudio, but even grosser.

Modified Files:


src/xpdev/Common.gmake
diff

src/xpdev/GNUmakefile
diff

Fix PulseAudio build option display

The macro was only define in the xpdev GNUmakefile, not in Common,
so bbslist.c did not know if it was enabled or not, and always
showed it as disabled.

Modified Files:


exec/load/newsutil.js
diff

exec/nntpservice.js
diff

Create/use news_get_from() function, copied from nntpservice.js

Use the fully-formed "From" header field in responses to NNTP
OVER/XOVER and HDR/XHDR requests.

This should fix issue #829 reported by Accession

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Range check argc before deref of argv[1]

Apparently JSVAL_IS_STRING() can return true even when argv[1] is out of range
(I guess I assumed it'd alwasy be NULL or VOID/undefined) and this can lead to
crash when calling JS_ValueToString() on it.

Modified Files:


src/xpdev/filewrap.h
diff

Retry file lock/read operations on EIO errors

As seen on MacOS, an SMB shared file can cause the Mac SMB client to report EIO
error on locked-file read or lock attempts. So retry.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyv_cfg.js
diff

xtrn/slyvote/slyvote.js
diff

Merge branch 'ddmsgreader_slyvote_poll_message_show_who_voted_what' into
'master'

DDMsgReader & SlyVote: WHen viewing polls, for the person who posted it, show
who voted on what (mimicking the Synchronet behavior which shows new votes when
the user logs in)

See merge request main/sbbs!477

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyv_cfg.js
diff

xtrn/slyvote/slyvote.js
diff

DDMsgReader & SlyVote: WHen viewing polls, for the person who posted it, show
who voted on what (mimicking the Synchronet behavior which shows new votes when
the user logs in)

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/term.c
diff

Re-order entry fields.

This makes more sense.  Also, ones that are meaningless are hidden
now.

Modified Files:


src/conio/cterm.c
diff

The final fixings for issue 172

Use 0 for "no held mosaic" to avoid confusion around printable bytes.
Store the state of the current cell *before* updating in fix_line()

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/cterm.c
diff

Fix double-height drawing

Top/bottom detection was somewhat broken.
Interestingly, now the previous commit isn't working anymore.
So issue 172 is not quite fixed yet.

Modified Files:


src/conio/cterm.c
diff

Fix up the Prestel "Engineering Test Page" rendering

This was due to two main bugs... the simple one was a type where
the cutoff between separated and contiguous mosaics was incorrect,
which caused the first four separated mosaics to not be displayed.

The second was due to a number of bugs in the Hold Mosaic
implementation.

This fixes the first half of issue 172.

Modified Files:


src/conio/utf8_codepages.c
diff

Fix unicode -> Prestel mapping

We want ASCII to map directly, and unicode values need to be sorted
ascending for bsearch() to work properly.

Fixes Prestel keyboard input not working in GDI mode.

Modified Files:


src/conio/OverhaulNotes.txt
diff

src/conio/cterm.c
diff

Handle 8-bit C1 codes in Prestel mode

If the remote sends 8-bit C1 codes, handle them as though they were
properly escaped.  Since Prestel terminals are 7-bit, these will
never be sent by a proper Pretel system, but apparently some systems
do weird non-standard things.

Modified Files:


ctrl/text.dat
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

Create/use SysopPageNotification text.dat string

to notify sysop (user #1) that they were paged. Previously, this was
a hard-coded string. The new string in text.dat is the same, but adds
2 BELs (CTRL-G chars) and is now customizable.

Created an sbbs_t::notify() method to make this easier to use and that
method supports @-code expansion, so this text.dat string supports @-codes
(which I used).

This addresses the feature request in issue #828 (beep the sysop in the
telegram/short message, when they're paged).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_index_newscan_skip_subboard_fix' into 'master'

DDMsgReader bug fix: For the indexed-mode newscan, when showing only sub-boards
that have new messages, ensure the selected item index is correct when
re-populating the menu so that it doesn't skip a sub-board. Reported by
Amessyroom.

See merge request main/sbbs!476

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader bug fix: For the indexed-mode newscan, when showing only sub-boards
that have new messages, ensure the selected item index is correct when
re-populating the menu so that it doesn't skip a sub-board. Reported by
Amessyroom.

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

We're 1.4a now. :(

Modified Files:


src/syncterm/CHANGES
diff

Document the death of SyncTERM 1.2

Modified Files:


src/syncterm/bbslist.c
diff

Fix error in optmap creation

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_edit_file_check_cost_and_times_downloaded_exist'
into 'master'

DDFileLister: When editing file information, check whether cost and
times_downloaded exist in the metadata before accessing them. Reported by
Ragnarok

See merge request main/sbbs!475

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: When editing file information, check whether cost and
times_downloaded exist in the metadata before accessing them. Reported by
Ragnarok

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

SyncTERM is now 1.3a

Modified Files:


src/conio/sdl_con.c
diff

Fix up win_lock mutex usage

Modified Files:


src/sbbs3/echocfg.c
diff

Some minor cleanups of echocfg

1) Initialize saverobot.name since this is checked unconditionally.
   This has a side effect of initializing everything else, but name
   is the only thing that actually matters.
2) Add a bar to the global settings menu.
   Previously, if you scrolled near the bottom and selected an option,
   after changing the option, you would jump up to the last item on
   the initial screen.
3) Fix the AreaMgr Support default value to be the current, not the
   opposite of current.
4) Use the correct variable for EchoMail Relay Filtered Messages
   setting default.

Modified Files:


src/sbbs3/main.cpp
diff

Remove ssh_errors variable.

We're carefully counting the errors, but never looking at the count.

Modified Files:


src/syncterm/GNUmakefile
diff

Don't create the Framework dir if we won't put anything in it.

Modified Files:


src/conio/sdl_con.c
diff

Remove unused variable

Modified Files:


src/conio/sdl_con.c
diff

Try this the other way...

Modified Files:


src/conio/sdl_con.c
diff

Scale SDL_GetDisplayUsableBounds() like SDL_GetWindowSize()

For retina lies.

Modified Files:


src/sbbs3/getnode.cpp
diff

Fix potential deadlock in getnodedat(), observed on macOS

Upon any node.dab lock or read failure, this code would cause errormsg() which
would often/usually end up claling getnodedat() which would block forever
trying
to acquire the ndoefile_mutex (introduced in commit b9633069, I'm not clear
why).

Unlock/release the mutex *before* calling errormsg().

Modified Files:


src/sbbs3/main.cpp
diff

Fix crash when NO_EVENTS option is set for terminal server

Don't deref that null pointer

Modified Files:


src/sbbs3/echocfg.c
diff

Update Area File help screen to explain areas.ini area file format/option

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

Add support for exporting fidonet sub-boards to areas.ini file

Modified Files:


src/conio/sdl_con.c
diff

Deuce said I remove this error message

It was always displayed (sent to stderr) when running scfg, echocfg, uedit,
etc. in auto-curses mode, so suppress that noise.

Modified Files:


src/sexpots/sexpots.c
diff

If configured COM port byte size is less than 8, strip high 8-n bits on RX

Some USB modems (reportedly, USRobotics USB modem) don't strip the parity bit
of data received from modem connections operating in < 8 bit modes
(e.g. 7-E-1), as is normally don't with a modem connected to a UART, so we'll
do that stripping (forcing to 0) here, as recommended by Deuce.

Nelgin, if you're doing some manually stripping of the 7th bit bytes received
from 7-E-1 connected modems and then sent to your server/BBS over TCP, you
shouldn't need to do that now.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Clean up area management code

I dislike this particular code a little less now:
- no more redundant string compares
- less deeply nested if() and for() blocks
- remove added areas from the add list, rather than zeroing out the tag
- a little more common code between areas.bbs and areas.ini handling

No functional change (I hope).

Modified Files:


src/xpdev/str_list.c
diff

src/xpdev/str_list.h
diff

Add strListFastDeleteAll()

To quickly free and remove all list entries (without realloc).

Modified Files:


src/syncterm/bbslist.c
diff

Remove accidental zero-width unicode character.

Modified Files:


src/syncterm/bbslist.c
diff

Use enum values for field names

Easier to match up than numbers.

Modified Files:


src/syncterm/bbslist.c
diff

Fix editing of name broken in earlier commit, refactor

Split generating help into separate function
- Regenerated when the connection type changes
Split generation the opt list into separate function
- Regenerated after handling any selection

Modified Files:


src/syncterm/CHANGES
diff

Clean up changes list to only "interesting" ones.

If someone wants to know the differences between 1.2rc1 and 1.2rc3,
the can check git.

Modified Files:


src/syncterm/CHANGES
diff

Make the same as the syncterm-1.2 branch

Modified Files:


src/syncterm/CHANGES
diff

Change CHANGE for newest changes.

Modified Files:


src/syncterm/modem.c
diff

The USR modem isn't so bad that it needs parity generated

We just need to strip the high bit on RX because the mode leaves
it on received bytes.

Modified Files:


src/syncterm/modem.c
diff

Resolve recently added compile errors and warnings

to unblock the pipes

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

Replace almost all references to AreaFix with AreaMgr or AreaManager

"AreaFix" is a proper product name. Though it's been defunct and unsupported
for decades, we still should not confuse sysops and historians: the general
term for what AreaFix did/does is Area Management, aka Conference Management.

The sbbsecho.ini key names are unchanged and the destination netmail address
for AreaManager requests can still be "AreaFix" (though "SBBSecho" is still
supported as well).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix stupid inverted logic bug: treating areas.ini as areas.bbs for AreaFix

and vice versa - so area manager requests were broken since I introduced the
areas.ini support. Oops.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Support AreaMgr request messages with -L (list) or -Q (query) but no body

I noticed through code review that these kinds of messages would be rejected
as "No commands to process.". We just needed to increment the 'cmd' counter
when parsing these options to be sure we don't think that no commands were
in fact request. -R (rescan) is not by itself a command since it requires
listed area-tags to have any effect.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Detect and log warnings about duplicate area sections in areas.ini

... like how we do for areas.bbs files.

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Add iniGet/ReadSectionListWithDupes()

For use cases were we don't want to silenty ignore duplicate (secondary)
section definitions.

Modified Files:


src/syncterm/CHANGES
diff

Log changes

Modified Files:


src/syncterm/modem.c
diff

Because some USB modems suck (ie: USR5637), do software parity

This is just in case the modem actually stays in 8N1 mode when
7E1 or 7O1 is set.  This is what the USR 5637 appears to do.

There's a small performance penalty for anything in 7-bit mode with
this, but it shouldn't be enough to actually impact anything.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/modem.c
diff

Drain modem buffer before sending commands.

Modified Files:


src/syncterm/modem.c
diff

Set flow control before raising DTR

Possibly setting CTS/RTS after raising DTR drops DTR which causes
DCD to be lost.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmsgreader_pollview_responses_fix' into 'master'

DDMsgReader bug fix: When viewing a poll that the user has posted and showing
who voted on the poll, ensure it only counts poll responses (not reply
messages). Reported by nelgin

See merge request main/sbbs!474

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader bug fix: When viewing a poll that the user has posted and showing
who voted on the poll, ensure it only counts poll responses (not reply
messages). Reported by nelgin

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix unsigned compare against >= 0 and nomatch misplacement

I'm not clear if/why these would cause the issue reporetd by
Fernando but they're definitely bugs in the areas.ini areafix
code. No impact to the areas.bbs areafix handling.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix new potential NULL derefs (the add/del_area args can be NULL)

... in area manager code modified in previous commit.

Modified Files:


src/syncterm/bbslist.c
diff

Remove unused variable.

Modified Files:


src/syncterm/bbslist.c
diff

Terminate parity_enum

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/modem.c
diff

Apparently, Windows headers define (at least) PARITY_NONE

Even when "lean and mean".  Rename enum.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/modem.c
diff

Add support for configuring data/stop bits and parity for modem and serial

Also, straighten out the confusing option adjuster thing when editing
an entry.

The help text still needs an overhaul, but now I have to re-test this
whole mess.

Modified Files:


src/syncterm/CHANGES
diff

Log changes

Modified Files:


src/syncterm/modem.c
diff

Explicitly set serial port to 8N1

Surely nobody uses anything else...

Modified Files:


src/sbbs3/download.cpp
diff

src/sbbs3/sbbs.h
diff

Save and restore the Telnet BINARY_TX option state separate for each direction

It's possible the client requested binary transmit in only one of the two
directions and if so, restore just the direction that was previously *not*
in binary transmit mode to NVT mode.

Modified Files:


src/sbbs3/main.cpp
diff

request_telnet_opt() will ignore all cmds but DO, DONT, WILL and WONT

This allows us to save unitialized telnet_*_option values (i.e. 0x00) and pass
those values back to request_telnet_opt() with no side effect.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Fix crash when editing blank "extra" bbslist entry
Show current list path, not default in File Locations
Support copy/paste in BBS list

Modified Files:


src/conio/allfonts.c
diff

src/syncterm/CHANGES
diff

Add blank pixel to left and top of Prestel DEL glyph

Makes the Night Owl BBS login screen look more accurate.

Modified Files:


src/sbbs3/download.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/xtrn.cpp
diff

Allow Telnet client to be in binary mode persistently

Before this change, we'd always request a return to Telnet NVT (turn off
binary-TX in both directions) after any file transfer. So although a Telnet
session might be negotiated into binary mode shortly after connection
(e.g., using "telnet -8"), it would be reverted back to NVT mode after any
file transfer.

The request to turn off remote binary-TX after executing external programs
didn't actually accomplish anything since we track the Telnet option states
internally and don't send redundant requests (e.g. the change into a mode
we're already in). External programs aren't expected to send Telnet requests
anyway, so I think this was some holdover from early days of stp/sexyz
development.

Modified Files:


src/sbbs3/main.cpp
diff

Don't use uninitialized variable: lockfname

Where's the compiler warnings guys?

Added Files:


exec/make_areas_ini.js
diff

Modified Files:


src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

Add support for new experimental/optional Area File format: areas.ini

As suggested/requested by Fernando Toledo in issue #826, you can:
1. run 'jsexec make_areas_ini.js' to export your areas.bbs file to areas.ini
   (your old areas.bbs is left in place, in tact, unmodified)
2. change your Area File in echocfg->Paths and Filenames->Area File to
   somepath/somefile.ini (e.g. "../data/areas.ini") and SBBSecho will use
   the .ini file format instead of the old AREAS.BBS format (NIH)

You can always go back to your areas.bbs file by just reverting the Area File
setting back to some other non-ini filename (e.g. "../data/areas.bbs").

Incremented version number to v3.23

Of course documentation and echocfg changes will need to follow, but this is
enough to start testing (looking at your Fernando! :-).

I tried to minimize the diff as much as possible and resisted updating
(modernizing, fixing) the very old AREAS.BBS parsing and areafix code.
The new .ini code is largely modeled after the old areas.bbs code, but oh,
xpdev/ini_file makes things so much nicer and easier.

There are no known fixes for any pre-existing area file/fix issues (including
issue #826), but it's always possible I've introduced a new issue.

Modified Files:


exec/init-fidonet.ini
diff

Update AmigaNet and Fido zone 4 details

Use BACKBONE.NA from Vertrauen as echolist for all Fido zones
(anyone have a better authoritative http link to a fixed file
name or archive name?).

Modified Files:


exec/imapservice.js
diff

Add log levels to the rest of the log() calls.

Modified Files:


exec/init-fidonet.ini
diff

Add FidoNet Zone 2 and Zone 4 coordinator names and contact info

Are there official echolists for these zones?

Modified Files:


src/sbbs3/nopen.c
diff

Fix non-Windows build, broken in previous commit

Modified Files:


src/sbbs3/ctrl/AboutBoxFormUnit.cpp
diff

Update cryptlib copyright dates to match latest cryptlib.h

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Simplify fmutex_open() signature even more, add fmutex_init()

Can't used designated initializers in fmutex_init() because this file is still
built with C++Builder6.

Modified Files:


src/sbbs3/nopen.c
diff

We need to initialize the fd to -1 here (since we zero-it out the fmutex_t)

and might return before setting it to anything else.

Modified Files:


src/conio/OverhaulNotes.txt
diff

Add nodes about different screen update methods that will be needed

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Correct initialization of fmutex_t so the file descriptor is -1

For some reason, MSVC was initializing the time_t (second element of the
struct) to -1, not the int fd (the first element), which was initialized to
0. Weird.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Simplify the fmutex_open() usage: always auto-remove when using open/close()

The auto-remove param was only needed for fmutex(), which immediately closes
(and thus don't want auto-removal), so create an internal function that's
used by both fmutex() and fmutex_open().

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Have fmutex_open()/close() accept a fmutex_t* argument

This is needed for *nix where normal (i.e. not Samba-mount) file behavior
requires that we manually unlink() the file, but not until just before closing
it. So we have to keep track of the file name and the 'auto_remove' desire of
the caller. This is not necessary when the file is on a Linux-smbfs, but we
need to work as expected on normal/local *nix file systems too.

This solves atomic lock file removal for *nix, but does not gaurantee lock file
cleanup upon ungraceful process termination (e.g. crash). At least in this
particular case, Windows beats UNIX.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Revert "Use fmutex_open for 100% locking and auto-removal upon
close/termination"

This reverts commit e55183c0953d0b033d9f11796f4290e488596e92.

fmutex_open()'s auto-remove feature doesn't work on normal/local Linux file
systems: unlink() of a file immediately removes its directory entry allowing
subsequent opens of the same file name, defeating the lock.

I had tested fmutex_open() on a Samba mount (from Linux) and it worked as I
wanted (like the Windows version does). Still searching for a good solution:
if a process terminates, gracefully or not, I'd like the file to be removed
at that time and until then, other processes or threads can't create or open
the same lock file (using O_EXCL and file locking to insure this).

Modified Files:


exec/load/openweathermap.js
diff

Update the openweathermap (OWM) API version number

Change requested in issue #747 and from Dan_C in #synchronet

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

Create/use function to toggle bit flags (options/settings)

Oh, so much copy/paste eliminated!

Modified Files:


src/syncterm/CHANGES
diff

Log change.

Modified Files:


src/conio/win32gdi.c
diff

When SyncTERM is deactivated and it is in fullscreen mode, minimize.

This appears to be the best we can do when Windows+M (minimize all)
is pressed.  We don't seem to be notified that we should minimize,
only that a different application is being activated.

This also makes Alt-TAB behave a bit more like expected.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

A little beautification of errno logging

Modified Files:


exec/mqtt_spy.js
diff

Add backup Ctrl-C input checking, just incase console.aborted isn't working

Telnet BINARY_TX mode from the client disables CTRL-C input checking in all
versions of SBBS (before now). This change shouldn't be necessary now, but
it worked-around the BINARY_TX issue when I was having it (couldn't abort
mqtt spy).

Modified Files:


src/sbbs3/main.cpp
diff

Perform "first level Ctrl-C input checking" even when in Telnet BINARY_TX

This condition caused aborting BBS operations via Ctrl-C to fail when
connecting from a traditional Telnet client using binary transmission
mode (e.g. telnet -8) or SyncTERM v1.2rc6.

The check of rio_abortable was probably enough to disable this function
during file transfers (e.g. we've had no issues with SSH file transfers
that might include byte 0x03 received from the client), but I added the
check for SS_FILEXFER system status check too, perhaps unnecessary.

Modified Files:


3rdp/win32.release/cryptlib/bin/cl32.dll
diff

3rdp/win32.release/cryptlib/include/cryptlib.h
diff

Cryptlib v3.4.8 for Win32, patched

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

3rdp/build/cl-Dynamic-linked-static-lib.patch
diff

3rdp/build/cl-PAM-noprompts.patch
diff

3rdp/build/cl-SSL-fix.patch
diff

3rdp/build/cl-add-patches-info.patch
diff

3rdp/build/cl-add-pubkey-attribute.patch
diff

3rdp/build/cl-add-win64.patch
diff

3rdp/build/cl-algorithms.patch
diff

3rdp/build/cl-allow-duplicate-ext.patch
diff

3rdp/build/cl-allow-none-auth-svr.patch
diff

3rdp/build/cl-allow-none-auth.patch
diff

3rdp/build/cl-allow-pkcs12.patch
diff

3rdp/build/cl-allow-servercheck-pubkeys.patch
diff

3rdp/build/cl-allow-ssh-2.0-go.patch
diff

3rdp/build/cl-allow-ssh-auth-retries.patch
diff

3rdp/build/cl-bigger-maxattribute.patch
diff

3rdp/build/cl-bn-noasm64-fix.patch
diff

3rdp/build/cl-channel-select-both.patch
diff

3rdp/build/cl-clear-GCM-flag.patch
diff

3rdp/build/cl-double-delete-fine-on-close.patch
diff

3rdp/build/cl-endian.patch
diff

3rdp/build/cl-fix-cbli-incompatible.patch
diff

3rdp/build/cl-fix-cpuid-order.patch
diff

3rdp/build/cl-fix-mb-w-conv-warnings.patch
diff

3rdp/build/cl-fix-shell-exec-types.patch
diff

3rdp/build/cl-fix-ssh-channel-close.patch
diff

3rdp/build/cl-good-sockets.patch
diff

3rdp/build/cl-haiku-build.patch
diff

3rdp/build/cl-handle-unsupported-pubkey.patch
diff

3rdp/build/cl-just-use-cc.patch
diff

3rdp/build/cl-lowercase-versionhelpers.patch
diff

3rdp/build/cl-macosx-minver.patch
diff

3rdp/build/cl-make-channels-work.patch
diff

3rdp/build/cl-mingw-add-m32.patch
diff

3rdp/build/cl-mingw-vcver.patch
diff

3rdp/build/cl-mingw32-static.patch
diff

3rdp/build/cl-mingw64-is-really-new.patch
diff

3rdp/build/cl-mingw64-thread-handles.patch
diff

3rdp/build/cl-mingw64-unicode-gibble.patch
diff

3rdp/build/cl-moar-objects.patch
diff

3rdp/build/cl-netbsd-hmac-symbol.patch
diff

3rdp/build/cl-netbsd-no-getfsstat.patch
diff

3rdp/build/cl-no-odbc.patch
diff

3rdp/build/cl-no-pie.patch
diff

3rdp/build/cl-no-safe-stack.patch
diff

3rdp/build/cl-no-testobjs.patch
diff

3rdp/build/cl-no-tpm.patch
diff

3rdp/build/cl-no-via-aes.patch
diff

3rdp/build/cl-noasm-defines.patch
diff

3rdp/build/cl-pass-after-pubkey.patch
diff

3rdp/build/cl-poll-not-select.patch
diff

3rdp/build/cl-posix-me-gently.patch
diff

3rdp/build/cl-prefer-ECC-harder.patch
diff

3rdp/build/cl-prefer-ECC.patch
diff

3rdp/build/cl-quote-cc.patch
diff

3rdp/build/cl-ranlib.patch
diff

3rdp/build/cl-read-timeout-every-time.patch
diff

3rdp/build/cl-remove-march.patch
diff

3rdp/build/cl-server-term-support.patch
diff

3rdp/build/cl-ssh-eof-half-close.patch
diff

3rdp/build/cl-ssh-list-ctr-modes.patch
diff

3rdp/build/cl-ssh-sbbs-id-string.patch
diff

3rdp/build/cl-ssh-service-type-for-channel.patch
diff

3rdp/build/cl-terminal-params.patch
diff

3rdp/build/cl-thats-not-asm.patch
diff

3rdp/build/cl-use-ssh-ctr.patch
diff

3rdp/build/cl-vcxproj.patch
diff

3rdp/build/cl-vt-lt-2005-always-defined.patch
diff

3rdp/build/cl-win32-lean-and-mean.patch
diff

3rdp/build/cl-win32-noasm.patch
diff

3rdp/build/cl-zlib.patch
diff

3rdp/build/cl-zz-country.patch
diff

3rdp/dist/cryptlib.zip
diff

Removed Files:


3rdp/build/cl-fix-ssh-ecc-ephemeral.patch
diff

3rdp/build/cl-fix-ssh-header-read.patch
diff

3rdp/build/cl-fix-test-select.patch
diff

3rdp/build/cl-openbsd-threads.patch
diff

3rdp/build/cl-ssl-suite-blocksizes.patch
diff

3rdp/build/cl-win32-build-fix.patch
diff

Merge branch 'cryptlib-3.4.8' into 'master'

Update Cryptlib to 3.4.8

See merge request main/sbbs!473

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

3rdp/build/cl-Dynamic-linked-static-lib.patch
diff

3rdp/build/cl-PAM-noprompts.patch
diff

3rdp/build/cl-SSL-fix.patch
diff

3rdp/build/cl-add-patches-info.patch
diff

3rdp/build/cl-add-pubkey-attribute.patch
diff

3rdp/build/cl-add-win64.patch
diff

3rdp/build/cl-algorithms.patch
diff

3rdp/build/cl-allow-duplicate-ext.patch
diff

3rdp/build/cl-allow-none-auth-svr.patch
diff

3rdp/build/cl-allow-none-auth.patch
diff

3rdp/build/cl-allow-pkcs12.patch
diff

3rdp/build/cl-allow-servercheck-pubkeys.patch
diff

3rdp/build/cl-allow-ssh-2.0-go.patch
diff

3rdp/build/cl-allow-ssh-auth-retries.patch
diff

3rdp/build/cl-bigger-maxattribute.patch
diff

3rdp/build/cl-bn-noasm64-fix.patch
diff

3rdp/build/cl-channel-select-both.patch
diff

3rdp/build/cl-clear-GCM-flag.patch
diff

3rdp/build/cl-double-delete-fine-on-close.patch
diff

3rdp/build/cl-endian.patch
diff

3rdp/build/cl-fix-cbli-incompatible.patch
diff

3rdp/build/cl-fix-cpuid-order.patch
diff

3rdp/build/cl-fix-mb-w-conv-warnings.patch
diff

3rdp/build/cl-fix-shell-exec-types.patch
diff

3rdp/build/cl-fix-ssh-channel-close.patch
diff

3rdp/build/cl-good-sockets.patch
diff

3rdp/build/cl-haiku-build.patch
diff

3rdp/build/cl-handle-unsupported-pubkey.patch
diff

3rdp/build/cl-just-use-cc.patch
diff

3rdp/build/cl-lowercase-versionhelpers.patch
diff

3rdp/build/cl-macosx-minver.patch
diff

3rdp/build/cl-make-channels-work.patch
diff

3rdp/build/cl-mingw-add-m32.patch
diff

3rdp/build/cl-mingw-vcver.patch
diff

3rdp/build/cl-mingw32-static.patch
diff

3rdp/build/cl-mingw64-is-really-new.patch
diff

3rdp/build/cl-mingw64-thread-handles.patch
diff

3rdp/build/cl-mingw64-unicode-gibble.patch
diff

3rdp/build/cl-moar-objects.patch
diff

3rdp/build/cl-netbsd-hmac-symbol.patch
diff

3rdp/build/cl-netbsd-no-getfsstat.patch
diff

3rdp/build/cl-no-odbc.patch
diff

3rdp/build/cl-no-pie.patch
diff

3rdp/build/cl-no-safe-stack.patch
diff

3rdp/build/cl-no-testobjs.patch
diff

3rdp/build/cl-no-tpm.patch
diff

3rdp/build/cl-no-via-aes.patch
diff

3rdp/build/cl-noasm-defines.patch
diff

3rdp/build/cl-pass-after-pubkey.patch
diff

3rdp/build/cl-poll-not-select.patch
diff

3rdp/build/cl-posix-me-gently.patch
diff

3rdp/build/cl-prefer-ECC-harder.patch
diff

3rdp/build/cl-prefer-ECC.patch
diff

3rdp/build/cl-quote-cc.patch
diff

3rdp/build/cl-ranlib.patch
diff

3rdp/build/cl-read-timeout-every-time.patch
diff

3rdp/build/cl-remove-march.patch
diff

3rdp/build/cl-server-term-support.patch
diff

3rdp/build/cl-ssh-eof-half-close.patch
diff

3rdp/build/cl-ssh-list-ctr-modes.patch
diff

3rdp/build/cl-ssh-sbbs-id-string.patch
diff

3rdp/build/cl-ssh-service-type-for-channel.patch
diff

3rdp/build/cl-terminal-params.patch
diff

3rdp/build/cl-thats-not-asm.patch
diff

3rdp/build/cl-use-ssh-ctr.patch
diff

3rdp/build/cl-vcxproj.patch
diff

3rdp/build/cl-vt-lt-2005-always-defined.patch
diff

3rdp/build/cl-win32-lean-and-mean.patch
diff

3rdp/build/cl-win32-noasm.patch
diff

3rdp/build/cl-zlib.patch
diff

3rdp/build/cl-zz-country.patch
diff

3rdp/dist/cryptlib.zip
diff

Removed Files:


3rdp/build/cl-fix-ssh-ecc-ephemeral.patch
diff

3rdp/build/cl-fix-ssh-header-read.patch
diff

3rdp/build/cl-fix-test-select.patch
diff

3rdp/build/cl-openbsd-threads.patch
diff

3rdp/build/cl-ssl-suite-blocksizes.patch
diff

3rdp/build/cl-win32-build-fix.patch
diff

Update Cryptlib to 3.4.8

Modified Files:


exec/imapservice.js
diff

"support" CHARSET search parameter.

Allow only US-ASCII, and send the BADCHARSET response code indicating
that.  Fixes issue with aerc.

Modified Files:


src/sbbs3/date_str.c
diff

Treat -1 as invalid time in time_as_hhmm()

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Add a "Use Shell" toggle option for fixed events

On *nix, you need the command shell to do wildcard expansion of filenames

Modified Files:


src/sbbs3/userdat.c
diff

Add description comment for find_login_id()

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Use safe_strerror() in place of strerror() - everything multithreaded should

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Resolve MSVC warning

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Fix the "ERROR x getting data user y" log message (usernum was 0).

Add the errno value to help root-cause.

We really should be using safe_strerror() everywhere.

Modified Files:


exec/load/newsutil.js
diff

Store original "references" header field as an RFC822HEADER in SMB

If an original references header field was supplied with the message, include
*that* in the header (since it should contain all the IDs of the replied-to
message thread) rather than just the message's reply_id (a single message
ID) when sending via NNTP. This maintains more NNTP post integrity when
sending back out via NNTP.

Not sure why we were storing received "references" in the hdr.references
returned by parse_news_header(), we don't seem to be using it anywere. Maybe
copied from 822header.js or mailproc_util.js? Seems like cruft, so remove it.

Also, don't ever send an "In-Reply-To" heder field via NNTP (it's not valid
/used for NNTP articles, per RFC 5536).

Modified Files:


exec/load/newsutil.js
diff

In-Reply-To is not a valid NNTP article header field

... so this was just redundant noise. Altough "References" is a valid header
field *both* for email and nntp articles, "In-Reply-To" is for email only.
per RFC 5536

Modified Files:


exec/load/newsutil.js
diff

Fix the regex in the parsing of the "References" header field

We only want one Message-ID (we'll use the last, since that appears to be the
message being replied to based on SLRN behavior). This fixes reply linkage
when posing from newsreaders that put multiple message-IDs in the
references header field. This is required for SBBSecho to do its magic
creation of the FTN REPLY kludge during export.

This is the fix that Accession was looking for, I think.

Modified Files:


exec/nntpservice.js
diff

Revert "Look up referenced FTN MSGID of messages being POSTed and use in
FTN-REPLY"

This reverts commit d4692e0a5cf643b67928ec8e2cdf9b333c1ab2d0.

Not the fix we're looking for.

Modified Files:


exec/nntpservice.js
diff

Revert "Don't overwrite the posted-reply FTN REPLY ID if it was provided by the
client"

This reverts commit a7f1a24a2ce7e67a87d067a89450a18108b8965d.

Not the fix we're looking for.

Modified Files:


exec/imapservice.js
diff

"Final" optimizations

Use the fastest message base access methods documented.
Cache read/write configs and avoid parsing on read if unchanged.
Make common saves dependent on there being changes.

This is likely as good as it gets (assuming it works)

Modified Files:


exec/imapservice.js
diff

Don't overwrite the offset with the IMAP offset, add a new one.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Use fmutex_open for 100% locking and auto-removal upon close/termination

Modified Files:


exec/nntpservice.js
diff

Don't overwrite the posted-reply FTN REPLY ID if it was provided by the client

Modified Files:


exec/nntpservice.js
diff

Look up referenced FTN MSGID of messages being POSTed and use in FTN-REPLY

... for Acccession

Modified Files:


exec/imapservice.js
diff

Wrap each cleanup step in a separate try/catch in exit func.

Clean up as much as possible.

Modified Files:


exec/imapservice.js
diff

Replace / with - in group/sub names

Almost no clients support a / in names.  Maybe I'll define an x-
extension or something when I write my own mail client.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Leave the user/*.ftp lock file open for better protection

This appears to be the only way to 100% provide mutual exclusivity between
Windows and Linux client sharing a Samba file system.

Also, make fmutex_close() take a pointer to the file descriptor so that we can
better manage the resource (i.e. don't close a descriptor that's already been
closed and possibly valid in another thread).

Modified Files:


exec/newslink.js
diff

Print the correct .ini filename where ptrs are saved

was printing the filename in uppercase if configured as such

Modified Files:


exec/imapservice.js
diff

Overhaul the saved config.

Rather than a single file with config for all subs, use a separate
file for each sub.  This makes clients that do parallel connections
to different mailboxes work much better, and make loading and saving
the config for a mailbox much faster.

The caching stuff is removed to simplify things, and hopefully won't
need to come back... we should just not save config if it doesn't
change.

Only issue I'm still aware of is that 99% of IMAP clients just can't
deal with slashes in mailbox paths.  Like... at all.  The protocol
supports them, but every client seems to have a different way of
breaking with them.

Modified Files:


exec/imapservice.js
diff

Some saved_config cleanup before splitting configs.

Modified Files:


exec/newslink.js
diff

Don't download more msgs than the max for the sub-board (if non-zero)

No sense downloading articles we're just going to toss out the next time
we performance msgbase maintenance.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

We can call remove() right after opening to enable auto-remove on *nix

... which simplifies the fmutex_close() function and signature.

Modified Files:


src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

Make the spamblock.cfg auto-added entries expirable (configurable duration)

By default, the duration is infinite, but some sysops may not want this
file to be ever-grower but rather periodically pruned by the new trashman
utility.

Sysop that don't use spambait.cfg won't benefit from this change.

Modified Files:


src/sbbs3/main.cpp
diff

Just a little wording update on the fmutex file open log message

Modified Files:


src/sbbs3/nopen.c
diff

Fix for Borland C++ build

Also, don't get hostname unless we're surely going to write to the file.

Modified Files:


src/sbbs3/main.cpp
diff

Use fmutex_close() and don't log ENOENT errors when removing pack*.now files

Modified Files:


src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Add fmutex_close() method to atomically remove the mutex file on Win32

The 'atomic_remove' argument isn't used in non-Windows builds since we can
remove() before close() on non-Windows OSes already.

Modified Files:


exec/imapservice.js
diff

Add a sanity check on saved config.

I managed to hit a bug where bseen and seen were both completely
filled.  No idea how I hit it, so not positive it's fixed.

This is cheap insurance against the 43k file groung to 1.6MB for
someone else.

Modified Files:


exec/imapservice.js
diff

More speed optimizations

1) Cache the binified seen data rather than regenerate every time
2) Only call js.gc() after a complete fetch or store loop

Modified Files:


src/sbbs3/main.cpp
diff

Use fmutex_open() instead of fmutex() to better protect the pack*.lock files

Modified Files:


src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Add fmutex_open() for cases where you want to keep the mutex file open

Modified Files:


src/sbbs3/con_out.cpp
diff

The progress reports (e.g. "[ Done      100.0% ]") should never go to logs

Modified Files:


src/sbbs3/nopen.c
diff

Use sopen(... SH_DENYRW) for fmutex() instead of open()

O_EXCL doesn't appear to be working very reliably over Samba, so let's add
file locking to the equation.

Modified Files:


exec/imapservice.js
diff

Don't rollback scan pointer on sub close.

Modified Files:


exec/imapservice.js
diff

What I hope are the last \Seen and \Recent fixes.

Modified Files:


exec/imapservice.js
diff

Remove set-but-never-used msg_ptrs

Modified Files:


src/sbbs3/main.cpp
diff

Reolve !ERROR 2 (No such file or directory) removing "data/pack####.now"

glob() results might be out of date by the time we look at each file, just
skip missing QWK pack semaphore files silently. This should resolve the
".now already gone" messages too. Hopefully.

Removed some extraneous quotes around logged event command-lines.

Modified Files:


src/sbbs3/main.cpp
diff

Use timestr() instead of ctime_r() for logging full date/times

Also when detecting a blocked event_thread, log the event_code that is/was
running last.

Modified Files:


exec/imapservice.js
diff

Simplify close_sub()

Should be no functional change.

Modified Files:


exec/imapservice.js
diff

If open_sub() fails, set readonly to true.

Modified Files:


exec/imapservice.js
diff

Save scan_ptr for all subs in config.

Also, make save_cfg() require that the lock be held.

Modified Files:


exec/imapservice.js
diff

More Seen flag overhaul.

This should now actually work properly.
Also, add a debug_exceptions flag to rethrow exceptions so I can
get line numbers.

Modified Files:


exec/imapservice.js
diff

Roll the epoch back to zero if it hits 9007199254740991

It shouldn't though.

Modified Files:


exec/imapservice.js
diff

Fix BODYSTRUCTURE bug that prevented macOS Sequoia from loading messages

Also, always use full_send(), not the socket send.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Remove "QWK Prepack" feature (has been on chopping block for a long time)

This removes unnecessary some cruft and complexity, most especially from the
event_thread().

Using sbbs_t::fremove() instead of remove(). This probably resolves some
Coverity issues where we weren't checking the return value.

Modified Files:


src/sbbs3/sbbs.h
diff

sbbs_t::fremove() will now, by default, ignore (not log) ENOENT errors

ENOENT = "No such file or directory"

Passing 'true' for the optional 'log_all_errors' parameter overrides this
(logs all errors, including ENOENT).

Modified Files:


exec/testbuild.js
diff

Updates nightly builds in filebase

Modified Files:


exec/newslink.js
diff

Return 1 on failure (e.g. authentication failure), not 0

Only log message header read error if the msgbase.status is non-zero

Don't try to import anything if the stop semfile is signaled while
exporting.

Increment revision to 1.2

Modified Files:


src/sbbs3/main.cpp
diff

Detect hung event_thread and log details

Add log message when spawning background timed event

Modified Files:


src/sbbs3/main.cpp
diff

Log event command-lines (repeating event code was redundant)

Only log messages about QWK mutex files existing when > 60 seconds old

Modified Files:


src/sbbs3/main.cpp
diff

Better support for multiple hosts handling QWK events

First, fix the logged username bug in the "Lock exists" log message.
Next, double check that the trigger file (sem file or REP file) still exists
after acquiring the file mutex.

Use a temp varible (fname) to make the code easier to read.

Modified Files:


exec/imapservice.js
diff

Fix UID FETCH deadlock.

Also, after grabbing a lock, enter a try/catch that will unlock
and re-throw the error.

Modified Files:


exec/imapservice.js
diff

Increase lock timeout to 5 min, reset imap config on exception

Modified Files:


src/sbbs3/answer.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/date_str.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

src/sbbs3/sbbsecho.c
diff

Only allow one FTP session per QWKnet user account

Vertrauen's FTP server gets abused by QWKnet logins sometimes and handling
the race conditions around QWK packet creation attempts is silly - there's
no legit reason why a QWKnet account needs to be logged-in multiple times
concurrently to the hub's FTP server, so reject the subsequent logins even
when they're on different hosts (as is the case with Vertrauen).

As part of this change:
- fmutex() now takes an new time_t* argument to (optionally) store the
  time of the mutex file for helping logging (locked since when?).
- time_as_hhmm() created to format a string as either HH:MM or HH:MM[a|p]
  (depending on system configuration for 12 or 24 hour time formatting).
- renamed the old hhmmtostr ()to tm_as_hhmm() (since it takes a struct tm arg)
  and have it return a non-padded string (useful in more situations without
  requiring truncation) when the sysop prefers 24-hour time.

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Include number of timed events and external programs in title of list windows

Modified Files:


exec/jsdocs.js
diff

Add git details to version information displayed

Modified Files:


src/xpdev/sopenfile.c
diff

Add a -l (loop) option to retry until failure

Pretty remedial option parsing here, the order is significant

Modified Files:


src/uifc/uifc32.c
diff

Just overhaul this who chunk of code.

Modified Files:


src/syncterm/CHANGES
diff

Mention the change

Modified Files:


src/uifc/uifc32.c
diff

Fix bug reported by DigitalMan

It looks like this has been a long-standing UIFC bug (pre-3.0)

If a uifc list that can scroll is showing the bottom-most line,
and an option that is not the last is deleted, and both *cur and
*bar are left untouched, *bar would be adjusted to be too high,
resulting in various highlight bar corruption issues.

This commit just rewrites that logic to be comprehensible, and
ensures that if bar is set such that the list would end before the
bottom of the window, it gets moved up.  This makes delete do the
right thing (didn't test with insert, that may do weird things).

Also, since I figured out a good definition of what bar actually
represtens, add a comment to that effect.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

src/sbbs3/startup.h
diff

Allow a separate log level for the event thread of the terminal server

So you want to debug (timed) events, but don't want to get debug-spew in your
terminal server log output? Now you can: By default, the event thread log
level will be the same as the terminal server, but now you can override this
by setting [BBS] EventLogLevel in the sbbs.ini file or set it in
SCFG->Servers->Terminal Server->Event Log Level.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Document the editor property (field) of the message header object

there are still other undocumented fields/properties, but this one for sure
was missing.

Modified Files:


exec/imapservice.js
diff

New IMAP search parser/generator

Previously, the IMAP search tried to do sneaky things to optimize
execution time, but that ended up with problems when nested ()s
were used, among other, more subtle issues.  Also, the old search
wasn't even tested enough so that each term would work.

The new system transpiles the IMAP query to Javascript then runs
the compiled JS function for each message.  Should be much more
accurate (though may also be much slower).

Actually fixes the issue reported as #397, and closes #730.

Modified Files:


exec/load/newsutil.js
diff

Import and export the message "editor" as the NNTP "user-agent" header field

The message editor is exported/imported to/from FTN as the "NOTE" kludge.

For Accession, per irc.synchro.net

Modified Files:


exec/newslink.js
diff

Don't report how many bases are being scanned, cause we don't know

... was always reporting 0 because 'area' is not an array object

Modified Files:


src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

When processing AreaRequest with -R (rescan), rescan existing echoes too

If the body of the request mesages message contains a list of area-tags,
even if we already have the node linked to those echoes, do the rescan for
each listed echo. Previously, only newly-added echoes would be rescanned
via this method.

Apparently the D'bridge built-in method of generating AreaManager requests
uses this syntax (per Ward Dossche).

Also, when rescanning due to AreaManager rescan request and generating a
response netmail message, include the total number of messages exported as a
result.

Increase SBBSecho version number to v3.22 (Please upgrade, Fernando) :-)

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_check_cost_in_metadata' into 'master'

DDFileLister: Check whether cost is in the file metadata before using it. Also,
when getting a file's full path, ensure its name is passed to get_path(), as
described by the JS documentation.

See merge request main/sbbs!472

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Check whether cost is in the file metadata before using it. Also,
when getting a file's full path, ensure its name is passed to get_path(), as
described by the JS documentation.

Modified Files:


src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add a 'misc' field for System/Fixed Events allow disabling and "Native"

Configured in SCFG->External Programs->Fixed Events and the Node Daily Events
configured in SCFG->Nodes, now can be disabled (without just clearing the
command-line) and toggle-on "Native", so the program doesn't have to be added
to the dreaded "Native Program List" in order to *not* be treated as a 16-bit
DOS program (the default).

Eventually I'll allow multiple of each time of system fixed event, but this
is an improvement for now at least.

Modified Files:


src/sbbs3/userdat.c
diff

A file descriptor of 0 is technically valid (though normally, STDIN)

Likely fix for CID 514647

Modified Files:


src/sbbs3/fidodefs.h
diff

src/sbbs3/sbbsecho.c
diff

Complete the support for multiple files (FileList) in subject of netmails

... also the support for multiple spaces or commas separating each filename.

Oh, FTS-1, how did I miss thee?

Modified Files:


src/sbbs3/sbbsecho.c
diff

Support multiple files ("FileList" per FTS-1) in subj when creating .REQ files

Previously, this feature assumed just one request per FREQ message, however
FTS-1 make this clear:

      If  one  or more  of FileAttached, FileRequest, or  FileUpdateReq  are
      asserted  in an AttributeWord, the subject{72} field is interpreted as
      a  list of file specifications  which may include wildcards and  other
      system-dependent data.  This list is of the form

      FileList = [ FileSpec { Sep FileSpec } ] Null

      FileSpec = (* implementation dependent file specification.  may
                    not contain Null or any of the characters in Sep. *)

      Sep      = ( " " | "," )  { " " }

Modified Files:


src/conio/Common.gmake
diff

src/sbbs3/GNUmakefile
diff

src/syncterm/GNUmakefile
diff

src/xpdev/Common.gmake
diff

Normalize SDL on macOS

Prefer sdl2-config from the path, and only use the framework in
/Library/Frameworks if that doesn't exist... to that end, don't
copy the framework into the app anymore unless you're using it.

This should clean out the pipes.

Added Files:


src/sbbs3/scfg/resource.h
diff

src/sbbs3/scfg/scfg.rc
diff

src/sbbs3/sync.ico
diff

Modified Files:


src/sbbs3/scfg/scfg.vcxproj
diff

Add "SYNC" icon (64x64, captured from GJ's "SYNCH" ANSI splash)

To replace lost the default/conio icon (for Windows builds) recently

Modified Files:


src/sbbs3/sbbsecho.c
diff

Support multiple filenames in subjects of file-attach netmails being packed

When writing the attached file path/names to the FLO file, parse each
filename out of the subject, accordingly. This should fix issue #824.

There's an inconsistent support in SBBSecho for FileLists in the subjects of
netmail messages. In a couple of places, single-space-separated filelists are
fine (but not commas or multiple space, even though they are allowed per
FTS-1).

This particular fix is just for the packing of netmail messages and the
appending the attached file(s) to the FLO file. Those other places (e.g.
.REQ file creation) will need their own fixes for proper filelist support.

Modified Files:


src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfglib1.c
diff

Use (new) make_newsgroup_name() function

... to be sure configured newsgroup name is RFC compliant.

Modified Files:


src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Add make_newsgroup_name()

Modified Files:


src/sbbs3/main.cpp
diff

Use new FILE_RETRY_ERRNO() macro for sopen() retries in sbbs_t::nopen()

Modified Files:


src/sbbs3/nopen.c
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.c
diff

Use (new) FILE_RETRY_ERRNO() macro to decide to retry sopen()

also retrying fread() and chsize(), but that seems harmless.

Modified Files:


src/xpdev/filewrap.h
diff

Add FILE_RETRY_ERRNO() definition, to be used in sopen()/lock() loops

Note: EBUSY was added to the list of errno values that should cause a retry
as observed on Vertrauen, running sbbs-linux on a Samba mount, opening
locked files can return failure (-1) with errno = EBUSY, e.g.
evnt BBS Events !ERROR 16 (Device or resource busy) in logon.cpp line 616
(logonstats) reading "system stats" access=0

This was apparently resolved by adding EBUSY (16) the values that trigger an
sopen()
retry (i.e. from [f]nopen()).

Modified Files:


exec/imapservice.js
diff

Current IMAP standards to not allow additional text after FLAGS

Remove the grease.

Modified Files:


exec/imapservice.js
diff

Add more paranoia.

This is a suitable amount of paranoia now.

Modified Files:


exec/imapservice.js
diff

Add a bit of paranoia to the infinite loop in lock_cfg() too.

Modified Files:


exec/imapservice.js
diff

poll() for write, and break on sock.send() returning zero

Should fix log-padding infinite loop.

Modified Files:


src/sbbs3/js_socket.c
diff

Document return values of Socket.poll()

Modified Files:


src/sbbs3/mailsrvr.c
diff

Include the size of the message headers in the POP3 STAT response too

I suppose if we only had messages with no body text, this value could be 0
(not accounting for any headers) and thus throw a client off.

So consider this as part of the fix for issue #822.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Report bigger "size of message" in POP3 LIST response

For messages that have no body, we'd report 0. But RFC 1939 says this value
is supposed to be "the exact size of the message in octets" <sigh>. This
would include header fields, so while we can't know the exact RFC822 size,
adding the msg's hdr.length to these values gives size > 0 for messages
with no body text and this enables the Apple iPhone Mail app to download
the message (fixing issue #822).

Part two of this fix is to provide a blank line of message text when there
is none. This changes the message displayed in the iPhone Mail app from:

"This message cannot be displayed because of the way it is formatted.
 Ask the sender to send it again using a different format or email program.

 text/plain"

to (the much nicer):
 "This message has no content".

Modified Files:


exec/imapservice.js
diff

NAMESPACE didn't help with Claws/Sylpheed.

Change the message.

Modified Files:


exec/imapservice.js
diff

Fix handling of short send()s

For some reason, I thought socket.send() did this, but apparently
not.  Fixes issue transferring large messages.

Also, add support for the useless NAMESPACE command.

Modified Files:


exec/imapservice.js
diff

Don't map new-scan config to IMAP subscriptions

The sets of message bases you want to get over different protocols
may be different.

While we're here, fix an error with single-parameter FETCH parsing
which prevented Sylpheed from being able to read messages.

Modified Files:


exec/imapservice.js
diff

Add comment as to why the body is being replaced.

Modified Files:


exec/imapservice.js
diff

Update fix in e0e1fc389c

Instead of text with completely different meaning, change the "no body"
text to a single space.

Modified Files:


exec/imapservice.js
diff

Fix deadlock introduced in last commit.

Modified Files:


exec/imapservice.js
diff

Hold config lock for whole sequence.

Rather than locking for just one message, lock for the entire command
when potentially updating Seen data.  With this, we can block all
connections the user has except the currently executing one, and
not need to read/write the seen data between every message.

While this can take minutes on very large subs, it's certainly
better than hours as previously.

It's rude to have multiple sockets actively pumelling the server
anyway.

Modified Files:


exec/imapservice.js
diff

Do some more optimizations around setting the Seen flag.

This speeds things up a fair bit, and will make things faster after
an initial scan.  I may expand this method a bit to lock other sockets
for for either some period of time or some number of messages to
allow the initial scan to be even faster.

Modified Files:


exec/imapservice.js
diff

Optimize read/save of Seen config

Previously, this uses INI format files, with ini file accessors
to read and save this file.  Now it just dumps a JSON file in and
slurps it out.

This saves about 0.4s/msg on my system when reading headers.

Modified Files:


exec/imapservice.js
diff

exec/load/822header.js
diff

Fix what appears to be a potential security hole (and some other stuff)

If the INI file could not be opened, a failure would be returned,
but authentication would (potentially) succeed.  I can't think of
a way to exploit this, but it's getting late.

Also, make some minor optimizations that won't make a difference yet,
and move opening the file into a single function.

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

Allow 3 digit message base retry timeout

Modified Files:


src/sbbs3/nopen.h
diff

src/sbbs3/userdat.c
diff

Reduce LOOP_NOPEN and LOOP_USERDAT from 500 to 100

With the incremental backoffs, these were super long waits for locks. Not sure
about my math there, but at 500, the total timeout was not "about 45 seconds"
but rather several minutes.

At 100, the total max retry time should be almost exactly 45 seconds:

Retries      ms-per     total seconds
  0 - 9      0          0
 10 - 19     100        1
 20 - 29     200        3
 30 - 39     300        6
 40 - 49     400        10
 50 - 59     500        15
 60 - 69     600        21
 70 - 79     700        28
 80 - 89     800        36
 90 - 99     900        45*
100 - 109    1000       55
110 - 119    1100       66
120 - 129    1200       78
130 - 139    1300       91
140 - 149    1400       105
150 - 159    1500       120
160 - 169    1600       136
170 - 179    1700       153
180 - 189    1800       171
190 - 200    1900       200!

... so yeah, 500 was way too big a number.

Modified Files:


src/xpdev/showlocks.c
diff

Add support for -r (read-only) open before locking

And only supports a single file per invocation now.

Modified Files:


src/xpdev/lockfile.c
diff

Add -r option for opening the file to lock read-only

It makes a difference on *nix.

Modified Files:


src/xpdev/filewrap.c
diff

Revert the lock() change in commit 043feff8

So this change is needed or else fcntl() will fail with errno=BADF if trying
to write-lock a file that was opened read-only. Oh well. Added a comment
explaining the rationale.

Added Files:


src/xpdev/lockfile.c
diff

src/xpdev/showlocks.c
diff

Some helpful test programs for testing file record locking.

Modified Files:


src/xpdev/filewrap.c
diff

Log a build warning if building for Linux without OFD lock support

OFD locks are needed on Linux for appropriate multi-threaded shared file
access (using fcntl record locks to prevent corruption), so log a warning if
building for Linux without that support.

lock() now mimics DOS/Windows again: the result lock is an "all access" lock
regardless of what mode the file was open in. I'm not sure why this change was
made (commit 11b73134563ce26), but I don't think it was necessary or
appropriate (though I can't think of any immediate negative effects). At
minimum it makes the code a little more understandable and eliminates an
extra call to fcntl().

Added Files:


src/xpdev/sopenfile.c
diff

A useful little program for testing sopen() from filewrap.c

This is the program I used (along with flock) to reach the root cause of
the SH_COMPAT == SH_DENYRW (no locking) bug in sopen() as well as other
interactions between Linux and Windows clients opening the same files
across a Samba share.

Modified Files:


src/xpdev/filewrap.c
diff

Get rid of the fcntl() usage in sopen()

You can't lock a file on a Samba share via both fcntl() and flock() (the
interact/collide).

This code was in a !BSD block which means they guy that wrote/committed
it wasn't using it either.

Modified Files:


src/xpdev/filewrap.c
diff

src/xpdev/filewrap.h
diff

Remove the F_SANE*LCKNO stuff

It appears Deuce's FreeBSD patch isn't going to be accepted/merged
(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=50827), so I'm
making this code a little more readable/manageable by removing this
unused feature... for now, with Deuce's approval.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Log a notice-level message when renaming a bad bundle file to *.?_? or *.?-?

Modified Files:


exec/imapservice.js
diff

Fix bug introduced in aecde4068 (2018)

Properly read the index of the base, not of the base_code.
Fixes badly broken STATUS command.

Modified Files:


src/smblib/smblib.c
diff

Fix printf formatting issue in error message

GCC and Coverity (x 2) both flagged this one.

Modified Files:


exec/load/newsutil.js
diff

exec/nntpservice.js
diff

Use original RFC822-formatted subject, if available (e.g. recv'd via SMTP)

This solves issue #817 for TLDR messages imported into DOVE-Net Tech Talk,
because those messages are imported via SMTP originally and thus have the
original (MIME/Q-encoded subject) in the message header (as RFC822SUBJECT).

For other messages with UTF-8 characters in their header fields (e.g. subject),
we'll need a different solution (Q-encode header fields that contain
non-ASCII chars on the fly), and then this solution could maybe be reverted.

Modified Files:


exec/imapservice.js
diff

Fix bug introduced in aecde4068 (2018)

Properly read the index of the base, not of the base_code.
Fixes badly broken STATUS command.

Modified Files:


src/smblib/smblib.c
diff

Fix printf formatting issue in error message

GCC and Coverity (x 2) both flagged this one.

Modified Files:


exec/load/newsutil.js
diff

exec/nntpservice.js
diff

Use original RFC822-formatted subject, if available (e.g. recv'd via SMTP)

This solves issue #817 for TLDR messages imported into DOVE-Net Tech Talk,
because those messages are imported via SMTP originally and thus have the
original (MIME/Q-encoded subject) in the message header (as RFC822SUBJECT).

For other messages with UTF-8 characters in their header fields (e.g. subject),
we'll need a different solution (Q-encode header fields that contain
non-ASCII chars on the fly), and then this solution could maybe be reverted.

Modified Files:


src/syncterm/GNUmakefile
diff

Don't require copying the SDL.framework into the bundle

When using MacPorts (and likely Homebrew), this isn't how this works.

Modified Files:


src/build/Common.gmake
diff

Old sw_vers on macOS uses a single dash.

New versions still support that.

Modified Files:


.gitlab-ci.yml
diff

Make darwin-x86 builds verbose for now...

Modified Files:


src/sbbs3/js_socket.c
diff

Don't check recvline() timeout *before* checking if there's data to receive

This was a regression: Socket.recvline() used to not care what the timeout
duration was so long as there were bytes to receive.

Also, remove the ".0" from timeout values in documented mehtods that don't
(any longer) accept floating point timeout durations. We used to support
fractional seconds for some of these methods, and that was implied by using
the floating point default values, but that's no longer the case. poll()
still accepts a floating point timeout.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix logic in bbs.xfer_prot_menu()

This was just a typo which didn't allow the single-file upload xfer prot menu
to be shown.

Actual fix for CID 11447 (previous attempt, commit f50c866fd was
insufficient). Thank you Coverity!

Modified Files:


.gitlab-ci.yml
diff

Reconnect with High Sierra

Modified Files:


.gitlab-ci.yml
diff

Disconnect the x86 mini from the pipes.

It's slow and crufty, and there's a new mini on the block now.

Modified Files:


3rdp/build/GNUmakefile
diff

Set MAKE=$(MAKE) for libffi make is gmake.

Should fix OpenBSD builds.

Modified Files:


3rdp/build/GNUmakefile
diff

Add -z for OpenBSD

It's super-picky.