Synchronet Git Commit Log

Modified Files:


src/sexpots/sexpots.c
diff

Allow one second longer for timeout

Modified Files:


src/sexpots/sexpots.c
diff

Actually do bounds checking on timeout.

Fix warning while we're here.

Modified Files:


src/comio/comio.c
diff

src/comio/comio.h
diff

src/sexpots/sexpots.c
diff

Add new definition for infinite timeout, and use that explicitly

The value of the macro is INT_MIN, not zero to protect agains weird
edge cases.

I considered INT_MAX, but figured you could get there in sane ways.

Modified Files:


src/xpdev/dirwrap.c
diff

delfiles() now removes files and directories, recursively

Modified Files:


src/xpdev/dirwrap.h
diff

Fix comment for GLOB_MARK

Modified Files:


src/sbbs3/filedat.c
diff

create_archive() will skip directories in supplied file_list

The file_list[] parameter was expected to contain only files, but the
directory() function (used to create that file_list[]) returns a list of all
directory entries, including sub-directories. I could (and maybe will) add an
option to directory() to only include files or dirs, but this seemed the more
direct fix for the problem reported by DesotoFireflite (VALHALLA):

TickIT's nodelist_handler.js appears to be creating and leaving behind a
sub-directory of the temp directory, triggering this error:
 1/23  11:36:56a  QNET libarchive error -1 (13 opening
c:\SBBS\temp\event\nodelist_handler/) creating c:\SBBS\data\VERT.REP 

Why isn't the temp directory fully cleaned up after/between events? That's
another thing to look into.

Modified Files:


src/sbbs3/putmsg.cpp
diff

Address GCC warnings: case label value exceeds maximum value for type

Modified Files:


src/sbbs3/putmsg.cpp
diff

Add case fall-through comment

To address CID 345626

Modified Files:


src/sexpots/sexpots.c
diff

Re-parse the "TCP" section before sending (optional) Prompt

We need to re-parse the default sexpots.ini [TCP] section for every new session
(when using the Prompt feature) or else there's no way to connect to the
default host.

Also, telnet to be enabled or disabled (e.g. by setting Telnet=false) in any
[TCP] or [TCP:x] section to support a mix of Telnet and non-Telnet hosts.

Modified Files:


src/sexpots/sexpots.c
diff

Change default PromptTimeout to 60 (seconds)

Also log a warning if a control character is received in response to the
prompt, or log a notice if there's a timeout waiting for a response to the
prompt. Change the non-control character response value to a debug-level log
message.

Modified Files:


src/sexpots/sexpots.c
diff

Optional clear-screen before sending banner

Set CLS=true in the root section of sexpots.ini to enable. Sends a ^L ASCII 12
0x0c FF CS whatever you want to call it to the remote terminal before sending
the carriage return and copyright banner. For Nelgin.

Modified Files:


src/comio/comio.c
diff

comReadBuf() supports an infinite timeout (0)

Modified Files:


src/sexpots/sexpots.c
diff

Make PromptTimeout configurable (default to 0/infinite)

Set to number of seconds to timeout, if desired.
Log the received character in response to the prompt.

Modified Files:


src/sexpots/sexpots.c
diff

Optionally send a prompt to connected user

Wait up to 10 seconds for a single-char reply to the prompt and if a
non-control character was received, use the [TCP:x] (x is the character sent by
the user) from the sexpots.ini for the Host and Port values to connect to.

An experimental feature for Nelgin.

Modified Files:


src/sbbs3/putmsg.cpp
diff

Basic PETSCII output column/line counting in putmsg()

When printing a PETSCII Sequence (.seq) file, count the lines/rows and columns
similar to how we would if we were using outchar() (but we don't, we use the
lower-level outcom() to bypass any translations).

This is related to issue #325:
PETSCII seq files seem to display just fine, the problem I saw was with the
auto-pausing (e.g. before a screen-clear) after displaying them.

Modified Files:


text/menu/restrict.asc
diff

Add the 'O' (post using real name) restriction flag.

Oh, QWKnet nodes ('Q' restricted accounts) are impacted by this restriction
since the poster's name isn't taken from the user account anyway.

Modified Files:


src/sbbs3/qwk.cpp
diff

Remove some commented-out code

Posting restrictions are handled one QWK-message at a time (and have been for a
long time). No actual change here.

Modified Files:


src/sbbs3/readmsgs.cpp
diff

src/sbbs3/un_rep.cpp
diff

Call can_user_post() rather than manual checks

Eliminate some redundant code. Use the userdat lib function provided for this
purpose.

Modified Files:


src/sbbs3/newuser.cpp
diff

src/sbbs3/userdat.c
diff

Handle duplicate names and aliases better

So some cute user (mine@demon.com) created a new user account on Vertrauen with
the alias and real name of "Rob Swindell". Funny.

Now, duplicate user aliases are already and always forbidden (even those that
just vaguely match an existing alias) - everyone expects those to be unique.
And we already forbid new user real names to match an existing user alias
(check_name() enforces this and we use that when checking new user real names
too), however, nothing prevented a new user account's alias from matching
another existing user's real name. And this is a problem:

1. This new/fake user could post a message or send an email/netmail and it
would appear to possibly come from the other/original user (we do have options
to send mail and post messages using real names)

2. Received email for real names is supported and if enabled, this second
account could be used to intercept mail for the original/first account if it
was receiving mail for the original/real user's real name.

So disallowing a new user's real name to match an existing alias fixes one
problem. 
However, systems *can* be configured to allow duplicate real names (which is
convenient for QWKnet accounts, for example) and so we needed another solution
for that problem: meet the 'O' restriction. This restriction flag will prevent
a user account from posting messages no sub-boards that require real names. New
user accounts that have a duplicate real name (the same as another user
account's real name), will automatically be assigned the 'O' restriction flag.
Systems that don't allow duplicate real names wouldn't have this issue in the
first place.

Scripts that allow the creation of new user accounts might need some updating
to match this security logic.

Modified Files:


webv4/root/api/register.ssjs
diff

Fix "Username already taken." validation error (could not happen)

The system.check_name() check *also* verifies that the username is not
already taken, so we must perform the matchuser() check first in order
to get the appropriate error message here when trying to use an alias
(username) that's already taken.

Modified Files:


src/sexpots/sexpots.c
diff

Fix issue that prevent "-syslog" option from being used (on *nix)

Fixed a couple sprintf() buffer overflow warnings/issues.

Modified Files:


src/sexpots/sexpots.c
diff

Add a -syslog option for *nix builds to force log output to syslog

for Nelgin

Modified Files:


src/sbbs3/js_system.c
diff

Eliminate a couple new 'unused variable' warnings.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/data_ovl.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/upload.cpp
diff

Use the progress() interval argument as the time interval

Default the progress time interval to 500 milliseconds (twice a second).

Don't specify a count/call interval in the call-sites, since we really want to
use time-based progress updates now only and the default probably will work
fine everywhere.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/sbbs.h
diff

Don't display progress() updates more than twice a second

To send less text over slow (e.g. 4800bps) modems. For Nelgin.

This makes the interval argument unnecessary I think.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_system.c
diff

Add JS methods for vetting filenames (e.g. for upload by users)

system.illegal_filename() - check if contains illegal chars/sequences
system.safest_filename() - check if contains only safest chars
system.allowed_filename() - check if meets criteria from SCFG->File Options
system.check_filename() - check if legal and meets configured criteria and is
not in file.can
bbs.check_filename() - ditto, except will display badfile.msg as appropriate

Now scripts can utilize the sysop-controlled filename criteria and security of
the BBS.

Modified Files:


ctrl/jsexec.ini
diff

Increase default JS heap size from 8M to 16M (ala sbbs.ini)

Also remove "JavaScriptContextStack" (no longer used) and other
wrong or obsolete comments.

Modified Files:


exec/hatchit.js
diff

Only produce MS-DOS compatible 'File' key values in TIC files

to be compliant with FTS-5006 which states "The name must be in 8x3 DOS
format".

I'm not converting the filename to ALL CAPS, since that's not explicitly stated
and really should not be a problem.

This also generates an Lfile key if the generated-DOS-compatible filename
does not exactly match the actual filename in any way (not just length).

Modified Files:


src/sbbs3/main.cpp
diff

Add run-time check for non-terminating/unsafe snprintf() function

Only in debug builds.
If this check fails, then we may be producing/using potentially un-terminated
strings and need to do something about that. By default, xpdev/genwrap.h
redefines snprintf() as safe_snprintf(), so this check *should* always succeed.

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix typo (wrong default size value) in JSDOCS for format_name()

The default is 'size' parameter value is 12 characters, not 13.

Modified Files:


src/sbbs3/listfile.cpp
diff

Don't display "blank" extended description in listings

If an extended description contains nothing but Ctrl-A codes and white-space,
don't display it in a file listing (in place of the normal short description).

Modified Files:


exec/irc.js
diff

UTF-8 encode/decode support, from martylake

Based largley on martylake's provided patch set. By default, assumes
all IRC messages are UTF-8 encoded and will translate to CP-437 if
appropriate or send as UTF-8 if the user's terminal supports it.
Set utf8_support=false in the [irc] section of your ctrl/modopts.ini
file if you wish to disable this behavior.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Fix problem saving HangupSound setting in sbbs.ini

Apparent copy/paste error in sbbs_set_sound_settings() - I was wondering why
the HangupSound key wasn't saving to the sbbs.ini file from SBBSCTRL.

Modified Files:


ctrl/sbbs.ini
diff

A bit of re-sync with actual keys

Remove JavaScriptContextStack (no longer used).
Add *Sound keys to the [Global] section.

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Provide more help for the "Access to Sub-directories" feature

This is an experimental feature that's been in the code for quite a while
without any supporting help/docs (there was the original commit message, I'm
sure). I'm not sure how much value this feature is without providing automatic
access to the *files* within the sub-directories, but there you have it.

Modified Files:


src/sbbs3/websrvr.c
diff

Log requests that resolve outside of the web root as hack attempts

"Request for x is outside of the web root" was already logged (with a "NOTICE"
log level), but would not sound the hack attempt alarm (on Windows) or log to
the hack.log. Now it does.

Modified Files:


docs/install.rtf
diff

updated link to MSVC 2010 SP1 redist package

Modified Files:


src/sbbs3/filedat.c
diff

Fix printf format issue in previous commit.

Modified Files:


src/sbbs3/js_filebase.c
diff

Correct JSDOCS for get_path, get_size, and get_time methods

These methods also (optionally) accept a file-meta-object as an argument.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_filebase.c
diff

Add JS properties to assist with web-access to filebase

file_area.web_vpath_prefix
file-metadata-object (return value of FileBase.get()).vpath

Modified Files:


src/sbbs3/websrvr.c
diff

Add support for web request path aliases (defined in web_alias.ini)

Similar to the ctrl/ftpalias.cfg file, the new ctrl/web_alias.ini file
(optional) can be used to map a portion (the first portion, only) of a web
request path to a different physical or virtual path. For example, I'm using it
to map:
/Synchronet/ = /files/main/sbbs/
for filebase access to my main->sbbs directory of Vertrauen's filebase using a
/Synchronet/* web request (i.e. for slightly prettier or shorter custom URLs,
if desired).

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.cfg
diff

xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.cfg
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Now supports message sub-board & file directory name collapsing, allowing
simplified
file directory and message sub-board lists for ones with common groups, adding
a 3rd
tier of options.  For example, if you have the following file directory
structure:
BBS files
  DOS: BBS software
  DOS: BBS doors
  DOS: BBS utilities
  Windows: BBS software
  Windows: BBS doors
  Windows: BBS utilities

With directory name collapsing, the selection will be come 3 tiers, as follows:
BBS files
  DOS
    BBS software
    BBS doors
    BBS utilities
  Windows
    BBS software
    BBS doors
    BBS utilities

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.cfg
diff

xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.cfg
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_area_choosers_name_collapsing' into 'master'

Now supports message sub-board & file directory name collapsing

See merge request main/sbbs!134

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/websrvr.c
diff

Add direct filebase access from the web server (optional)

By setting SCFG->File Options->Web File Virtual Path Prefix to something (e.g.
"/files/"), all HTTP or HTTPS requests to the Synchronet Web Server with
request paths beginning with this prefix will be interpreted as filebase access
requests (with full access control enforcement). This is configured here (in
SCFG) rather than, say, the [web] section of sbbs.ini, because I have plans for
the terminal server to use this prefix to generate Web-URLs for files to
display or email to users.

Currently, only requests to *files* (for download) are supported (no index
generation, file information, etc. and definitely no upload support). Full
access control (using HTTP auth, not cookies) is used for libraries and
directories with controlled access. Credits are deducted and awarded and
uploaders are notified of downloads, as one would expect. Requests to any
dynamic-web-content files (e.g. .SSJS, .XJS, etc.) will be treated as static
file download requests (no script will be executed).

I'm reusing the same virtual path parsing logic from the FTP server (moved to
the userdat lib), so the virtual path to a file for download would be, for
example, http://yourdomain/files/lib/dir-code/filename.ext

The main motivation for this feature is: FTP-links in email and web pages are
just not useful to many users these days and I don't think that sysops should
have to rely on a SSJS web UI (e.g. ecWebv4, cool as it is), to provide
web-access to the filebases. Using this feature, you can share simpler/shorter
web links to your files that will be more enduring.

Modified Files:


xtrn/lord2/lord2.js
diff

Comment-out what appears to be a typo/copy-paste error

lord2.js line 3168: ReferenceError: bs is not defined

Modified Files:


exec/hatchit.js
diff

Patch by @acn to include a non-interactive mode, fix point paths, and tic pw

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Added a load for 822header.js.  Whoops.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'ddmsgreader_822header' into 'master'

Added a load for 822header.js.  Whoops.

See merge request main/sbbs!133

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Version 1.42: Fixed attachment downloading.
Also, the first attempt at converting HTML entities in HTML-formatted messages
(not working 100%).
Also, added the ability to sort the message list by date & time written rather
than the import date/time.
This is specified in the configuration file via the msgListSort option.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmsgreader_attachment_dl_fix' into 'master'

Version 1.42: Fixed attachment downloading (most importantly).

See merge request main/sbbs!132

Modified Files:


exec/tempxfer.js
diff

text/menu/tempxfer.asc
diff

The JS Archive class doesn't actually support "adding" to archives

So change the (A)dd command to (C)reate here. Leave 'A' as an alias.

Modified Files:


src/sbbs3/filedat.c
diff

Address Coverty reported issue about dereferencing a NULL pointer

CID 345291
It's actually a false positive because if an extension (".suffix") exists in
filespec, it must also exist in newfilespec since it's a copy, but whatever.
It's better form to check.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Disable libarchive support for creating/appending bundles

libarchive apparently cannot be used for in-place modification of (e.g. adding
files to) existing archives, so if a bundle already exists, this code would
over-write it with a new archive containing just the latest packet. Issue
reported by acn (IMZADI) via DOVE-Net.

I could and might create an update_archive() function which extracts and
re-creates an archive with additional files, but since I don't have that yet,
just disable this for now and always use an external archive utility to create
or update bundles (so again, an "Archive" configuration is required in your
sbbsecho.ini file, which you most likely already have).

Modified Files:


src/sbbs3/addfiles.c
diff

A couple more sprintf->SAFEPRINTF conversions

Not sure why, as this utility has been deprecated. :-/

Modified Files:


src/sbbs3/addfiles.c
diff

Address GCC warning: ‘%s’ directive writing up to 4096 bytes...

warning: ‘%s’ directive writing up to 4096 bytes into a region of size
between 4034 and 4097

Modified Files:


docs/v319_new.txt
diff

Fix typo

Modified Files:


src/sbbs3/addfiles.c
diff

Remove remnants of alternate file path support

Wouldn't work with the new filebase if you tried to use it anyway. Just noticed
while watching the v3.19b new feature video that the [.alt_path] was still
listed as a command-line option.

Modified Files:


src/sbbs3/listfile.cpp
diff

Search file's tags, author, and author's group (if available)

When searching descriptions for text, include these new metadata fields in the
content to search.

Modified Files:


exec/simple.src
diff

Pass unrecognized commands to str_cmd.js

(e.g. type "HELP") to get help on string commands, including sysop
commands. File Transfer related sysop commands *not* available via
this command shell however (there's just the one/main menu, so no
"File menu" context from which to execute string/sysop commands).

For nick (in #synchronet at irc.synchro.net).

Modified Files:


exec/str_cmds.js
diff

Remove comment about requiring semicolon prefix, not all shells do.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Log unallowed/illegal filenames in quotes

Prefixed or trailing white-space characters would be hard to discern without
this.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

Allow maximum uploaded filename length to be configured

Default to 64 characters. Maximum value is 65535 characters, but filenames
larger than 64 characters may be problematic (e.g. searching for them,
displaying them, security concerns), so only increase with caution. Shorter
values are fine, but 0 will just revert back to the default.

Modified Files:


src/sbbs3/filedat.c
diff

loadfiles() will perform liberal filename matching when len > 12 chars

As discovered while making the Synchronet v3.18b feature video
(https://www.youtube.com/watch?v=_IWzIV0_sZ4), when only a shortened version of
a long filename is displayed (e.g. due to 80 column terminal width
limitations), trying to download that filename by specifying the filename at
the Download File(s) Filespec [All Files]: prompt can be problematic.

For example (as seen in the video), the file "SyncTERM-1.1-setup.exe" is
displayed as "SyncTERM.exe" (on an 80-column terminal), yet trying to download
"SyncTERM.exe" (or "syncterm.exe") using the 'D'ownload command would fail to
find a file with that name (understandably, but frustratingly so).

This change will transform the requested filename-to-load if it is at least 12
characters in length and contains no wildcards (* or ?), to include a filename
extending wildcard: "filename.txt" will become "filename*.txt" and
"longfilename" will become "longfilename*".

For requested filespecs of NULL (all files) or specs containing wildcards or
specs (filenames) less than 12 characters in length, no filespec transform
takes place: so trying to list/download "a" doesn't match "apple.txt".

Modified Files:


docs/v319_new.txt
diff

Include some statistics about the release

These git diff stats are a bit misleading as a lot of files were removed from
the git repo and some 3rd party libraries were added.

Modified Files:


exec/load/sbbslist_lib.js
diff

Add BBS entry descriptions as a Comment key values to exported syncterm.lst

Added Files:


3rdp/build/js-config.guess.patch
diff

3rdp/build/js-makefile.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Fix build on arm64
- Update SpiderMonkey config.guess
- Include patch for SpiderMonkey Mozilla bug 638056

Added Files:


3rdp/build/js-config.guess.patch
diff

3rdp/build/js-makefile.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Merge branch 'master' into 'master'

Fix build on arm64

See merge request main/sbbs!131

Modified Files:


src/sbbs3/js_system.c
diff

Use SAFECOPY() - CID 345193

Modified Files:


src/sbbs3/filedat.c
diff

The simpler fix to issue #317 (nested DIZ files)

By extracting with with_path=true, the file_list matching won't match the
nested DIZ files.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Increase revision to 'c' (v3.19c) as v3.19b was released yesterday

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Add overwrite argument to extract_file_from_archive and Archive.extract

Previously, extracted files were always overwritten (so that is the "default"
for Archive.extract() and mostly what I'm specifying in the C/C++ code by
default now), but this caused a problem with DIZ extraction: archives that
contained multiple DIZ files (e.g in sub-directories), the last to be extracted
would be used. A maximum of 3 DIZs can be extracted, so it would usually be the
3rd DIZ in the archive if there were that many.

Another solution would be to *only* extract DIZ files from the root of the
archive and I should look into that as well, but the always-overwrite behavior
also seemed to be wrong, so that *also* needed fixing (allow caller to control
behavior).

This fixes issue #317, at least for archives where the root DIZ exists *before*
any nested DIZ files. I'll have to try and create a purposeful archive to test
the other conditions (where the root DIZ would appear *after* the nested
DIZ(s)).

Modified Files:


exec/load/ircd/config.js
diff

Ignore malformed I:lines

Modified Files:


exec/load/ircd/unregistered.js
diff

Agh, fixing again

Modified Files:


exec/load/ircd/unregistered.js
diff

Missing parenthesis

Modified Files:


exec/load/ircd/unregistered.js
diff

Handle null or timed out DNS replies properly

Modified Files:


exec/load/dns.js
diff

Actually call back on a timeout

Modified Files:


src/sbbs3/js_file.c
diff

Need to escape backslashes in JSDOC strings

Modified Files:


exec/jsdocs.js
diff

Document properties even when then have a value of 'null'

Modified Files:


docs/jsobjs.html
diff

Add some missing File properties (due to a bug in jsdocs.js)

properties with a value of null were not being documented

Modified Files:


xtrn/war/war.js
diff

Load terrain.fnt from startup directory, not game directory

Resolves !ERROR Cannot load font \sbbs\xtrn\war\worlds\alderon\terrain.fnt!

Modified Files:


src/sbbs3/js_system.c
diff

src/sbbs3/newuser.cpp
diff

Eliminate a couple of hard-coded instances of "ZIP"

Modified Files:


docs/v319_new.txt
diff

Consolidate and beautify

Modified Files:


src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm
diff

Updated to reflect NTDVDM required (not necessarily a 32-bit OS)

Modified Files:


docs/jsobjs.html
diff

A little more clean-up for v3.19b.

Modified Files:


src/sbbs3/js_archive.c
diff

JSDOC output beautification

I wanted to use an unordered bullet list, but the CSS tricks are making those
not-displayed, so going with ordered (numbered) list for now.

Modified Files:


src/sbbs3/js_file.c
diff

Document the new SHA1-related File properties.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Resolve GCC warning

Modified Files:


src/sbbs3/js_archive.c
diff

Remove extraneous <p> tag (copied from js_file.c no doubt)

Modified Files:


docs/jsobjs.html
diff

Generated with v3.19b for Win32

Modified Files:


src/sbbs3/sbbs.jsdocs.vcxproj
diff

Updated to match sbbs.vcxproj

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Increment revision to b (so, v3.19b).

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Don't enable the multi-file prompt (for upload descriptions) by default

Modified Files:


ctrl/file.cnf
diff

Eliminate default archive extract/compress/list cmd-lines

Use built-in archive support (and archive.js, for listing) instead.
We still have info-zip (zip) here for testing archives and adding comments
since we don't have that explicit support form libarchive (yet).

Modified Files:


install/install.iss
diff

Updated for v3.19 

ecWeb is only web UI included/installed
Optional to enable 16-bit DOS support on 64-bit Windows now (since we support
NTVDMx64 now).
Add libarchive.dll and zlib1.dll
Always install old 16-bit DOS utils (e.g. svdmansi.com), just in case

Modified Files:


docs/install.rtf
diff

Updated for v3.19

Modified Files:


ctrl/msgs.cnf
diff

Use the internal archive (ZIP) support for VERT QWKnet hub

Modified Files:


docs/v319_new.txt
diff

De-duped a bit

Added Files:


docs/text319b.dif
diff

Changes to text.dat since v3.18b (in diff format)

Modified Files:


exec/tempxfer.js
diff

Display archive extraction error to user and abort search (upon error)

Modified Files:


exec/archive.js
diff

Log exception details if 'list' command fails

Modified Files:


exec/email_sec.js
diff

Trim white-space from email/netmail addresses

Modified Files:


exec/dupefind.js
diff

Save JS heap memory by using a hash of the achive contents for map key

Rather than the content listing itself (which can be a very long string).

Modified Files:


exec/updatefiles.js
diff

Add a force option that's currently only enabled. <shrug>

Not sure what I was doing here, but might as well have it committed.

Modified Files:


text/sbbs.msg
diff

We no longer generate HTML indexes for the FTP server

And other minor updates

Modified Files:


ctrl/sbbs.ini
diff

Make ecWebv4 the default [web] RootDirectory value

Modified Files:


src/xpdev/strwrap.h
diff

Resolve MSVC warning C4273: 'strnlen': inconsistent dll linkage

Modified Files:


exec/load/text.js
diff

Synchronized with latest text.dat/text.h

Modified Files:


xtrn/3rdp-install/carlton-blackjack.ini
diff

xtrn/3rdp-install/carlton-crazy8.ini
diff

xtrn/3rdp-install/carlton-doormania.ini
diff

xtrn/3rdp-install/carlton-fleethunter.ini
diff

xtrn/3rdp-install/carlton-litecar.ini
diff

xtrn/3rdp-install/carlton-milleborne.ini
diff

xtrn/3rdp-install/carlton-minezone.ini
diff

xtrn/3rdp-install/carlton-navgrid.ini
diff

xtrn/3rdp-install/carlton-plinko.ini
diff

xtrn/3rdp-install/carlton-rockin.ini
diff

xtrn/3rdp-install/carlton-scavenger.ini
diff

xtrn/3rdp-install/carlton-urges.ini
diff

xtrn/3rdp-install/carlton-wordguess.ini
diff

xtrn/3rdp-install/dalton-adgt.ini
diff

xtrn/3rdp-install/dalton-camptown.ini
diff

xtrn/3rdp-install/dalton-deathbytrivia.ini
diff

xtrn/3rdp-install/dalton-escape.ini
diff

xtrn/3rdp-install/dalton-goc.ini
diff

xtrn/3rdp-install/dalton-gruntfest.ini
diff

xtrn/3rdp-install/dalton-risepower.ini
diff

xtrn/3rdp-install/dalton-shipline.ini
diff

xtrn/3rdp-install/dalton-tfbroadside.ini
diff

xtrn/3rdp-install/dalton-warfreight.ini
diff

xtrn/3rdp-install/disoft-futurerunner.ini
diff

xtrn/3rdp-install/disoft-islandempires.ini
diff

xtrn/3rdp-install/disoft-nuclearwar.ini
diff

xtrn/3rdp-install/disoft-rebelkingdom.ini
diff

xtrn/3rdp-install/disoft-wordmix.ini
diff

xtrn/3rdp-install/dreamware-dreamstakes.ini
diff

xtrn/3rdp-install/exdx-empireatwar.ini
diff

xtrn/3rdp-install/exdx-railroadempires.ini
diff

xtrn/3rdp-install/exdx-riverboatblackjack.ini
diff

xtrn/3rdp-install/exdx-romansatwar.ini
diff

xtrn/3rdp-install/exdx-spaceforcecommander.ini
diff

xtrn/3rdp-install/gutterbowl32.ini
diff

xtrn/3rdp-install/ironwar.ini
diff

xtrn/3rdp-install/jns-amazingmemory.ini
diff

xtrn/3rdp-install/jns-bombsquad.ini
diff

xtrn/3rdp-install/jns-boxedpoker.ini
diff

xtrn/3rdp-install/jns-doublesolitree.ini
diff

xtrn/3rdp-install/jns-fivecarddrawpoker.js.ini
diff

xtrn/3rdp-install/jns-fortythievessolitaire.ini
diff

xtrn/3rdp-install/jns-freecellsolitaire.ini
diff

xtrn/3rdp-install/jns-golfsolitaire.ini
diff

xtrn/3rdp-install/jns-greatwhitecard.ini
diff

xtrn/3rdp-install/jns-idiotsdelight.ini
diff

xtrn/3rdp-install/jns-inbetween.ini
diff

xtrn/3rdp-install/jns-kingslast.ini
diff

xtrn/3rdp-install/jns-matchtwo.ini
diff

xtrn/3rdp-install/jns-montanasolitaire.ini
diff

xtrn/3rdp-install/jns-ontheedge.ini
diff

xtrn/3rdp-install/jns-pressyourluck.ini
diff

xtrn/3rdp-install/jns-quotefall.ini
diff

xtrn/3rdp-install/jns-slidersolitaire.ini
diff

xtrn/3rdp-install/jns-solitree.ini
diff

xtrn/3rdp-install/jns-strikesandspares.ini
diff

xtrn/3rdp-install/jns-theelminator.ini
diff

xtrn/3rdp-install/jns-thepuzzlemachine.ini
diff

xtrn/3rdp-install/jns-threeshuffles.ini
diff

xtrn/3rdp-install/jns-trapper.ini
diff

xtrn/3rdp-install/jns-treasuretrove.ini
diff

xtrn/3rdp-install/jns-tripeakssolitaire.ini
diff

xtrn/3rdp-install/jns-twocardpoker.ini
diff

xtrn/3rdp-install/jns-yacht.ini
diff

xtrn/3rdp-install/latenight-civilwar.ini
diff

xtrn/3rdp-install/latenight-darkcastle.ini
diff

xtrn/3rdp-install/latenight-superrig.ini
diff

xtrn/3rdp-install/latenight-triviamaster.ini
diff

xtrn/3rdp-install/lore.ini
diff

xtrn/3rdp-install/mycroft-adventuressherlockholmes.ini
diff

xtrn/3rdp-install/mycroft-fictiousstockexchange.ini
diff

xtrn/3rdp-install/mycroft-stellarquest.ini
diff

xtrn/3rdp-install/mycroft-uboat.ini
diff

xtrn/3rdp-install/thepit.ini
diff

Replace bbsfiles.com HTTP URLs with vert.synchro.net FTP URLs

Unfortunately, Doug Reah passed away, so bbsfiles.com is no more

Thanks to MRO for supplying us with a site-rip of bbsfiles.com which is now
extracted/expanded and available (via FTP) on vert.synchro.net.

Modified Files:


exec/ircd.js
diff

exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

exec/load/irclib.js
diff

Update copyright

Modified Files:


src/sbbs3/ctrl/AboutBoxFormUnit.dfm
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/sbbsdefs.h
diff

Increment copyright year to 2022

Modified Files:


exec/letsyncrypt.js
diff

Insure the web RootDirectory ends in a slash.

Reported by Compctech via DOVE-Net:

"On a side note,  I had to modify the letsyncrypt.js file to get letsencrypt to
work.  I had to add a / before .well-known on lines 86 - 89 & 96."

I'm guessing this is because his sbbs.ini [Web] RootDirectory wasn't terminated
with a slash.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/telgate.cpp
diff

Use non-blocking connect for telnet/rlogin gateway

Default connect timeout is now 10 (seconds), and can be overridden by passing
an additional number argument to bbs.telnet_gate() or bbs.rlogin_gate().

Addresses issue #314 by Nelgin.

Modified Files:


src/sbbs3/js_file.c
diff

A few minor JSDOC fixes.

Modified Files:


src/sbbs3/mailsrvr.c
diff

If SMTP-transmit-relay is enabled by no relay server, disable

log an error message and disable the transmit-relay in this
detected-misconfiguration case.

Fixes issue #315 reported by Nelgin.

Modified Files:


exec/load/ircd/unregistered.js
diff

Only reverse resolve for the proper protocol family

Modified Files:


exec/load/dns.js
diff

Allow IPv{4,6} only queries while retaining backwards compatibility.

Modified Files:


exec/load/ircd/server.js
diff

Silently ignore unsupported SVSMODE, requested by nelgin

Modified Files:


exec/load/ircd/core.js
diff

Use ssl_session for reporting secure connections via WHOIS. Found by nelgin,
thanks!

Modified Files:


src/sbbs3/inkey.cpp
diff

Disable mouse hot spot adding/clearing debug log messages

... even in debug builds (was already disabled for release builds)

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Better handling of ESC key input if mouse support is disabled

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_nomoues_traditional_input' into 'master'

Better handling of ESC key input if mouse support is disabled

See merge request main/sbbs!130

Added Files:


3rdp/build/cl-moar-objects.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Increase the Cyrptlib object limit from 1024 to 16384

This may fix various out of resources issues.  Here's what the source
has to say about this number:

/* The maximum number of objects.  By default we use a fixed limit set to an
   appropriate large-enough value because the only time anyone that would
   really be creating thousands of objects is if they're leaking them and
   setting a fixed limit means this is detected without the code having to
   run for days or weeks leaking handles, however we allow a dynamically-
   configurable limit set via CONFIG_NUM_OBJECTS if someone really needs to
   use vast numbers of objects */

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

Simplify the enabling of all the optional interrupt counters for debug

Modified Files:


src/sbbs3/getnode.cpp
diff

Sync-up the node status flag output with presence_lib.js

Added Files:


docs/v319_new.txt
diff

List changes since v3.18 (rough draft)

Modified Files:


docs/SlyEdit_ReadMe.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_DCTStuff.js
diff

exec/SlyEdit_IceStuff.js
diff

exec/SlyEdit_Misc.js
diff

exec/load/dd_lightbar_menu.js
diff

SlyEdit v1.75: Refactored the quote selection menu and cross-post selection
menus to use DDLightbarMenu instead of SlyEdit's own lightbar code.  This
allowed the elimination of most of the rest of SlyEdit's own lightbar code,
reducing the size of SlyEdit.js by about 40Kb.  It also provides some
consistency
in behavior by using a common menu component.

Also, to support some additional required behaviors by SlyEdit, added the
following
'event' functions to the DDLightbarMenu class:
ValidateSelectItem(pItemRetval): For validating that the user can select an
item.
Takes the item's return value, and returns a bool to indicate whether the item
can
be selected.

OnItemSelect(pItemRetval, pSelected): A function that is called when an item is
being
selected (or de-selected, when multi-select is enabled).  The parameters are
the item's
return value and a boolean to indicate whether the item was selected or
de-selected.

Also, added an explicit DoKeyDown() function to DDLightbarMenu to support
scrolling
the menu down when desired (special case for SlyEdit's quote selection window).

Modified Files:


docs/SlyEdit_ReadMe.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_DCTStuff.js
diff

exec/SlyEdit_IceStuff.js
diff

exec/SlyEdit_Misc.js
diff

exec/load/dd_lightbar_menu.js
diff

Merge branch 'slyedit_175_crosspost_and_quote_menu_refactor_ddlightbarmenu'
into 'master'

SlyEdit v1.75: Refactored the quote selection menu and cross-post selection

See merge request main/sbbs!128

Added Files:


3rdp/build/cl-good-sockets.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Sockets over 1024 or below stderr aren't bad, just misunderstood. :(

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Made a fix (kludge?) to properly write menu items with the check character
(multi-selected) in a borderless menu (vs. a menu with borders).

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'ddLightBarMenuMultiSelectDrawFix' into 'master'

dd_lightbar_menu: Made a fix (kludge?) to properly write menu items with the
check character

See merge request main/sbbs!127

Modified Files:


3rdp/build/cl-poll-not-select.patch
diff

Remove check for fd <= FD_SETSIZE

This was preventing cryptlib from working with socket descriptors
over FD_SETSIZE despite being patched to use poll() to avoid the
issue it's protecting against.

May fix the various SSH/SSL internal error issues.

Modified Files:


src/sbbs3/sbbs3.sln
diff

Don't build sbbsexec.dll by default for debug builds

This build is touchy and requires an explicit path to a Win10 SDK
directory, so just disable by default for (for debug build). We still
want this built by default for CI, which are release builds.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Fix FTPS upload failure: !DATA ERROR 0 receiving on data socket

Don't treat CRYPT_ERROR_COMPLETE (-24) as a socket error during upload since
it's an indication that the remote closed the connection and is the normal "end
of file/transfer" indicator, not an error. 'rd' is already 0 in this case, so
no need to set at all (since recv() returns 0 upon disconnect and that's what
we're emulating here).

Fixes issue #309 reported by Jas Hud.

Modified Files:


src/sbbs3/sexyz.c
diff

src/sbbs3/xmodem.c
diff

Allow local abort/cancel to abort (more) retries/loops

While debugging a SyncTERM upload issue, I came across some scenarios where an
out of control file transfer could not be aborted via local key press (e.g.
Ctrl-C, Ctrl-Break).

We use zm.local_abort for all local abort indications (even for X/YMODEM).
<shrug>

Modified Files:


src/xpdev/genwrap.c
diff

Work around GetVersionEx deprecation warning/error

For some reason this deprecation warning is being treated as an error (and only
with newer Windows platform SDKs). Just disable this warning for the
GetVersionEx line.
See https://stackoverflow.com/questions/22303824/warning-c4996-getversionexw-wa
s-declared-deprecated for details.

Added Files:


src/sbbs3/sbbsexec.vcxproj
diff

Modified Files:


src/sbbs3/sbbs3.sln
diff

Add sbbsexec.dll project (again)

Regenerated for MSVC2019, the Synchronet virtual UART/FOSSIL driver (VDD) can
be built from Visual Studio again (the makevdd.bat can probably go away now). I
haven't had an MSVC project to build this DLL since the old MSVC 6.0
sbbsexec.dsp file.

A few oddities about this project:
1. xpdev files had to directly included/compiled in this project rather than
linking with the xpdev_mt.lib because __stdcall calling convention is required
for compatibility with ntvdm.lib and xpdev_mt.lib is built using __cdecl
calling convention (the default). Rather than re-introducing the calling
convention game-playing that I just recently removed (e.g. #define DLLCALL),
just build the required xpdev files directly as part of this project. Perhaps
there is a more elegant solution that I'll revisit later.

2. The absolute path of my install Windows 10 SDK directories had to be
specified (for include and library paths) to find vdd_svc.h and ntvdm.lib.
Weird thing is that I didn't have to do anything hacky like this with the
command-line/batch file build method. Again, there's probably a better solution
I'm not seeing. But as is, this project might not build on other systems.

So why use this rather than the brute-force batch file (makevdd.bat)? Well,
this should be a little easier to get into CI/nightly builds and the resulting
release build was 30KB (instead of 150KB), so that's good.

Before:
           1AA00 size of code
            AA00 size of initialized data
               0 size of uninitialized data
After:
            4C00 size of code
            2A00 size of initialized data
               0 size of uninitialized data

Those default DLL project build options include some good optimization flags
apparently.

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsexec.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/vdd_func.h
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Removed Files:



src/sbbs3/execvxd.h
diff

src/sbbs3/execvxd/c.bat
diff

src/sbbs3/execvxd/debugout.h
diff

src/sbbs3/execvxd/makefile
diff

src/sbbs3/execvxd/sbbsexec.cpp
diff

src/sbbs3/execvxd/sbbsexec.h
diff

src/sbbs3/execvxd/sbbsexec.vrc
diff

Remove the last remnants of Win9x/Me support

Allow "FOSSIL Only" as a configuration option for external programs in SCFG.
This is a much easier method of disabling the virtual UART support in the
Virtual UART/FOSSIL device driver (if/when necessary) than editing the
sbbsexec.ini file (which is still supported).

Modified Files:


src/sbbs3/sbbsexec.c
diff

The sem_wait() call was just a bad idea after-all

The sem_wait() call from vdd_read() that was fixed in the previous commit to
this file was a bad idea to begin with:
There is (often) not a 1:1 ratio of bytes in the receive ring buffer and the
semaphore count, so we'd often halt here waiting for the semaphore to be
signaled even though there were still characters in the receive buffer. This
caused (new) stalls/hangs in keyboard input in DOS door games. We didn't see
this previously because the sem_wait() call just didn't work (wrong semaphore
pointer value).

Now, call sem_trywait_block() in vdd_read(), but only if the RingBufRead()
returned 0 (no bytes read) and even then, only block/wait for a maximum of 30
seconds (same as X00 FOSSIL driver). This blocking behavior is specified for
FOSSIL function 02h (Get received character with wait) and would not have
worked previous to the previous "fix", so now we have that corrected behavior
too. The FTSC spec says the wait is indefinite, but I think a 30 second timeout
(ala X00) is more reasonable.

Log the git brach/hash instead of the old CVS revision.

GetMailSlotInfo() apparently always fails on Windows 7 with error 87 (even
using Microsoft's own sample code), so lower the log message severity of that
failure from ERR to DEBUG. Apparently this is pretty harmless anyway as nothing
really needs the write-mailslot status. <shrug>

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

src/sbbs3/fossdefs.h
diff

Fix some FOSSIL functions

Function 0Ch (peek) never worked correctly (character was not returned in AX);
I guess nothing uses this function (?).

Function 01h (transmit char w/wait) now will set the timeout flag (0x8000) in
the AX if the VDD_WRITE function fails (returns value other than 1).

Optimize Function 18h (read block) - no need for the extra VDD_STATUS call.

Use newly defined FOSSIL macros instead of magic numbers of port status bits.

Log the git branch/hash values to the Windows debug log (via sbbsexec.dll).

Modified Files:


src/sbbs3/chat.cpp
diff

Add a debug line when wrapping split-screen chat lines.

Is this the point when the lost chars problem happens?

Added Files:


src/sbbs3/dosxtrn/.gitignore
diff

Modified Files:


src/sbbs3/.gitignore
diff

Ignore sbbsexec.dll and dosxtrn.exe build artifacts.

Modified Files:


install/GNUmakefile
diff

Fix typo in condition (if linux) for setting the SETCAP/setcap target

As reported via irc by Nelgin, the setcap target was not being passed
to 'make -C src/sbbs3' by default (on Linux) due to a misplaced paren.

Modified Files:


src/sbbs3/ringbuf.h
diff

Finally get rid of RINGBUFCALL (finish what was started in April of this year)

Missing part of commit 4da964dd8ff83256df5755e525a0f3f42b1f30d3

Added Files:


src/sbbs3/makevdd.bat
diff

A batch file to build SBBSEXEC.DLL (may or may not require NTDDK?)

Using options (e.g. RINGBUF_MUTEX) from old sbbsexec.dsp

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

src/sbbs3/sbbsexec.c
diff

src/sbbs3/xtrn.cpp
diff

Add support for NTVDMx64

Yes, you can run 16-bit DOS doors on 64-bit (x64) Windows now.

Install NTVDMx64 (http://www.columbia.edu/~em36/ntvdmx64.html, it's not as
onerous as it sounds) and re-enable DOS program support in SBBS (i.e. make sure
"NO_DOS" is not in your sbbs.ini [bbs] Options value) and voila: DOS doors
work.

This change adds an empty init routine to sbbsexec.dll since older versions of
NTVDM (which NTVDMx64 is based on) required one. Also, the sbbsexec.dll should
be located in your Synchronet "exec" directory when using NTVDMx64 (in addition
to or instead of your Windows/System32 directory).

Modified Files:


src/sbbs3/sbbsexec.c
diff

Fix sem_wait() call in vdd_read()

Introduced in Revision 1.16 (CVS)
Wed May 10 08:52:11 2006 UTC (15 years, 6 months ago) by rswindell

This was supposed to wait (block) until there was a new received
byte (the ringbuf semaphore was signaled), but we were passing the sem_t
value rather than the pointer to the sem_t. Since sem_t (on Windows)
is a HANDLE (which is a void*), there was no compiler warning or
error. Type-safety in C sucks.
So, this just never worked (I'm assuming the call would just fail).

I discovered this bug while working on NTVDMx64 support and in that
case, this call would block/wait forever. Simple one character fix.

Modified Files:


xtrn/bullshit/bullshit-lib.js
diff

Don't crap out if [files] section empty or missing.

Modified Files:


exec/websocketservice.js
diff

FWebSocketHeader should just be a bare object.

Modified Files:


exec/websocketservice.js
diff

Case-insensitive search for headers in ShakeHands. Some proxies
like to mangle these unless you tell them not to.

Capture the value of the X-Forwarded-For header, if present, and
stash it in FWebSocketHeader['X-Forwarded-For'].

Modified Files:


exec/load/ftelnethelper.js
diff

Added UsingHAProxy() function to this here funclib dot js

Modified Files:


exec/websocketservice.js
diff

If BBS is using HAProxy ([BBS] Options line has HAPROXY_PROTO)
then throw an error if X-Forwarded-For header was not received,
or otherwise do the HAProxy thing upon connecting.

Modified Files:


exec/websocketservice.js
diff

Avoid spurious connections to the terminal server - and some
other unnecessary work - if the BBS is using HAProxy but we can't
do the thing with the stuff because we don't have the things.

Modified Files:


exec/websocketservice.js
diff

Added inet_pton function borrowed from the internet.
Added incomplete send of haproxy protocol header. Need to sort
out lookup of target (BBS) IP address.

Modified Files:


exec/websocketservice.js
diff

Hurr.

But also, this needs some revision since I'm supposed to send
the header all at once and probably shouldn't be doing a bunch
of individual sendBin calls.

Modified Files:


exec/websocketservice.js
diff

Build protocol header as string and send all in one big barforama.

Modified Files:


exec/websocketservice.js
diff

Use client address from header

Modified Files:


exec/websocketservice.js
diff

Address family must occupy bytes 15 & 16

Modified Files:


exec/presence-service.js
diff

Changed the format of some messages.

Modified Files:


src/sbbs3/dosxtrn/dosxtrn.c
diff

Implement FOSSIL function 0Dh (Keyboard read without wait)

As a work around for TradeWars 2 (v11.14 and v11.20) FOSSIL support:
This door game would never call the FOSSIL "get received character"
function (02h) . But I did notice that it was calling the "Keyboard
read" functions. I never implemented the "Keyboard read" functions
(figured the door game could read the keyboard itself if it wanted to),
but appparently TW2 won't ever read the COM port (using function 02h)
unless the Keyboard read function returns AX=0xFFFF (no keyboard data
available). So now, I just do that and TW2 works (with FOSSIL I/O).

Incremented the revision to 26.
Logging the Git branch/hash and other helpful FOSSIL-debug stuff now.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Continuation of previous commit (support for UART-only doors on Windows)

Needed the actually mapping of XTRN_UART -> EX_UART mode flag here.

Modified Files:


src/sbbs3/execvxd.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/xtrn.cpp
diff

Allow FOSSIL mode of the Win32 virtual UART/FOSSIL driver to be disabled

When configuring an external program, a Win32 sysop can now choose to *only*
enable the virtual UART (and not the FOSSIL driver) feature of the Synchronet
virtual UART/FOSSIL driver (dosxtrn.exe/sbbsexec.dll). Some programs (e.g.
TradeWars 2) will always use the FOSSIL driver if one is detected and in order
to force the use of COM/UART driver for I/O (if that is desired), then one must
disable the FOSSIL driver. It's a rare use case, but I can see the potential
need.

Renamed the "Intercept I/O" option in SCFG to "I/O Method" and make it clear
that "Socket" (for native programs) and "FOSSIL or UART" (for 16-bit DOS
programs) is the default method (what was previously identified as "No" I/O
Interception).

If a sysop want to disable the virtual UART support (on Win32, e.g. so *only*
FOSSIL is available to one or all DOS programs), they do that via their
sbbsexec.ini file.

Modified Files:


src/xpdev/gen_defs.h
diff

MSVC 1.5c defines _MSDOS, not __MSDOS__

This change needed to build dosxtrn.exe (again).

Modified Files:


src/sbbs3/dosxtrn/make.bat
diff

Added helpful reminder remark to build this old beast

Modified Files:


src/sbbs3/sbbsecho.c
diff

Resolve gcc warning

warning: format ‘%lx’ expects argument of type ‘long unsigned int’

Modified Files:


ctrl/text.dat
diff

Add All and ListKey strings.

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/email.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getstr.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/writemsg.cpp
diff

Add text.dat lines for "All" and the List key ('L'), used in quoting

The internal line editor's quoting feature add some hard-coded strings ("Done"
and "All") and the (L)ist key was hard-coded. Use the text.dat string (new and
pre-existing) for these now.

Also, use the new sbbs_t *_key() methods for referencing the configured key
bindings (via text.dat) for these common key-stroke commands.
Convert the text.dat strings for keys (e.g. YNQP) to uppercase always as well.

Modified Files:


ctrl/text.dat
diff

Part of previous commit: new text strings for msg/file scan config prompt/keys

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

Make msg/file scan configuration prompts and keys configurable

For localization purposes, no more hard-coded text strings or characters in the
new-file and file scan configuration menus.

This change fixes issue 232.

A Hungarian sysop also requested this change via Facebook not long ago.

Modified Files:


src/sbbs3/scfgdefs.h
diff

src/sbbs3/ssl.c
diff

Don't use time_t in scfg_t definition

sbbsctrl.exe is built with Borland C++ still which only has a 32-bit time_t, so
to keep the scfg_t definition compatible between MSVC and Borland builds, use
time32_t (32-bit time_t) values only.

This fixes the reported sbbsctrl.exe error:
Error loading configuration
cfg->size (23944) != sizeof(scfg_t) (23952)

Introduced in commit e535aaac.
Reported via DOVE-Net by  Daryl Stout (TBOLT), confirmed by Nightfox (DIGDIST).

Modified Files:


src/sbbs3/mailsrvr.c
diff

Include twit-listed sender name in quotes in log message

Since mail server log messages have their white-space condensed, it was not
obvious why some sender's name would match a twitlist.cfg line that filters
names beginning with a space: "\ *" because the initial space of the sender's
name was condensed/combined with space before it in the log message.

Modified Files:


src/sbbs3/qwktomsg.cpp
diff

Initialize time zone variable (zone)

As found and reported by Talisam author, apam (HAPPYLND).

sscanf() won't initialize the buffer of the argument passed if the format
string is not matched, so when there was no hexadecimal/SMB timezone value, the
timezone specified in the ISO date/time string (if any) would be overwritten
with 0, converted from the uninitialized 'zone' variable (unlikely to be valid
hex-ASCII chars). Thanks apam!

Modified Files:


src/sbbs3/qwk.cpp
diff

src/sbbs3/sbbsecho.c
diff

Add support for "name@address" syntax in twitlist.cfg

where "address" is a QWKnet ID or path or a FidoNet originating address.
Wildcards can be used (e.g. "*@VERT").

For Trikester.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/xtrn.cpp
diff

Add command-line specifier for user's real name (auto-quoted)

%+ will now expand to the current user's real name, automatically enclosed in
quotes if it contains any spaces.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Generate a MSGID kludge for netmail messages created by SBBSecho

The "serialno" field is a bad/naive one (a time_t value), but this is really
just an experiment for Ragnarok to see if this fixes issue #306 (with hotdoged
receiving AreaFix responses/notices).

Modified Files:


src/sbbs3/upload.cpp
diff

Fix sbbsfile.nam contents: contained file's description instead of name

Found during review of previous commit.
Introduced as part of the new file base branch merge (commit fcf58640).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Log an error and exit immediately when a local linked-node is configured

When a linked-node (in echocfg->Linked Nodes) contains one of the local
system's FTN addresses, display/log an error and exit immediately, e.g.:
Configuration ERROR: Linked node #20 is your own address: 1:103/705

I'd perform this check in EchoCfg, but:
1. echocfg doesn't read the BBS's configuration files (where the local FTN
addresses are configured), and
2. some sysops just directly edit their sbbsecho.ini file

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/upload.cpp
diff

Don't write uploaded filename and description to env variables

Environment variables are shared among all threads of a process (e.g. all nodes
of a instance of sbbs), so this scheme of passing the uploaded filename and
description to an external file tester (upload processor) via environment
variables has always been fraught with the possibility of failure or flakiness
in Synchronet v3. Since I very much doubt that any upload processor is actually
using this scheme, just remove it. Upload processors can and should)use the
sbbsfile.nam and sbbsfile.des text files created in the node directory instead.

Modified Files:


src/sbbs3/scfgdefs.h
diff

src/sbbs3/ssl.c
diff

Keep track of certificate file timestamp and reload if it has changed

With the old method, it was possible for a certificate to remain used
eternally, and letsyncrypt.js can change it relatively often.

Modified Files:


src/encode/utf8.c
diff

src/xpdev/unicode_defs.h
diff

Re-synchronize utf8_getc/putc with OpenSSL 3.0

Now correctly rejects UTF-8 encoded Unicode surrogates and does not support
5 and 6 byte UTF-8 encodings.

For reference: https://github.com/openssl/openssl/commit/ba64e5a92a6f009e311ad1
c3565817820a1632a4

Modified Files:


exec/rlogin.js
diff

Allow the client-name, server-name, and term-type to be passed as arguments

Optional, for easier use with game servers that take one of the 3 rlogin
negotation parameters as the name/code of the door to execute. A telgate
mode flag value argument must be provided (use 0 for default behavior)
if you want to provide any of the other arguments to override the defaults
(the user's alias, real name, and current detected terminal type).

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Fix segfault after batch-upload when no "uploads" dir specified

When there's no "uploads" directory configured by the sysop, cfg.upload_dir
will be set to INVALID_DIR, which cannot be used as an index into cfg.dir[] to
determine if the time used for uploading the files should be "given back" to
the user.

In v3.18, we used the first file in the upload queue, if there was one, else
fell back to the "uploads" dir (which had to have been defined if there were no
files in the queue). So this illegal array indexing was a regression in v3.19.

Reported by Zoltán Gábor on Facebook

Modified Files:


3rdp/build/GNUmakefile
diff

Replace $(DIRSEP) with '/' to make this file easier to view/edit

We don't support platforms where '/' doesn't work as a path element separator.

Modified Files:


3rdp/build/GNUmakefile
diff

Replace some apparently errant double-slashes with single-slash

Added Files:


3rdp/build/cl-linux-yield.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Use shed_yield() instead of pthread_yield() on Linux

Per https://man7.org/linux/man-pages/man3/pthread_yield.3.html
	This call is nonstandard, but present on several other systems.
        Use the standardized sched_yield(2) instead.

Should fix #299.

Modified Files:


src/xpdev/genwrap.h
diff

Don't use the deprecated pthread_yield() function

Per https://man7.org/linux/man-pages/man3/pthread_yield.3.html
       This call is nonstandard, but present on several other systems.
       Use the standardized sched_yield(2) instead.

Should fix #299.

Modified Files:


exec/load/ircd/unregistered.js
diff

Don't count unregistered clients

Modified Files:


exec/ircd.js
diff

exec/load/ircd/core.js
diff

Move ircd 1.9 out of beta in anticipation of Synchronet 3.19

Modified Files:


exec/load/ircd/core.js
diff

Bump connect delay from 1s to 10s, thanks to keyop for testing!

Modified Files:


exec/ircd.js
diff

exec/load/ircd/core.js
diff

Only allow one outbound CONNECT at a time

Modified Files:


src/sbbs3/sbbsecho.c
diff

When packing netmail (stored messages), don't discard non-zero zones

As reported by Ragnarok (DOCKSUD) via DOVE-Net, when packing (packetizing)
netmail messages, the source and destination zones from the netmail header were
discarded (since they are defined as "optional" in FTS-1) and the zone values
were replaced with the system's primary/default zone number. If the netmail
message included an INTL kludge, the source and destination zone values would
be parsed from that kludge line and this issue would not be noticed. 

So the fix is: Only if the netmail message header contains a source or
destination zone number of 0, replace that zone with the system's
primary/default zone number. As before, the INTL kludge zone information can
override the header fields.

Also, there's no reason to force the point numbers from the header to zero,
since if they were not valid (e.g. "fill" in the original FTS-1 specification),
they would be already zero. So use the source and destination point numbers, as
is, from the netmail header too (with the FMPT and TOPT kludge override support
left in-tact).

Modified Files:


src/sbbs3/pktdump.c
diff

Print "All good" or "All bad" when trying to recover or split a packet

At Nelgin's suggestion, if all the messages in a packet are either good or bad,
say so (since no .good or .bad file will be generated in that case).

Modified Files:


text/menu/chat.msg
diff

text/menu/maincfg.msg
diff

text/menu/qwk.msg
diff

text/menu/xfercfg.msg
diff

Fix PETSCII display of this menu's title/tab

Modified Files:


text/menu/e-mail.msg
diff

Fix PETSCII display of this menu's title/tab

Added Files:


text/menu/mailread.msg
diff

text/menu/sysmailr.msg
diff

Removed Files:



text/menu/mailread.asc
diff

text/menu/sysmailr.asc
diff

Make 40-column happy versions of mail reading menu (and sysop sub-menu)

Renamed from .asc to .msg for PabloDraw convenience.

Modified Files:


src/sbbs3/atcodes.cpp
diff

New @-codes SEX and GENDERS

SEX is the user's sex/gender
GENDERS is the list of system-supported genders for new users to choose from.

Modified Files:


src/sbbs3/atcodes.cpp
diff

New @-code: !x to perform Ctrl-A style terminal/attribute control

Most Ctrl-A code terminal/attribute effects can now be invoked via @!x@ where x
is one or more Ctrl-A sequence operands (e.g. @!B@ to set the current attribute
to blue, @!P@ to pause the terminal). Multiple attribute codes may be specified
in a single @!x@ sequence. Both upper and lowercase attribute codes are
supported. The "^A@" sequence is not supported, but there's already an @-code
to perform the equivalent operation ("SHOW:20").

Rationale: when using PabloDraw to edit display (e.g. .msg) files, there was no
easy way to explicitly clear (set to "normal") the current attributes at the
end of a line of text. If that line of text contained a background color and
the line caused the terminal to scroll, that background color would fill the
next/new line resulting in some potential undesirable effects. There are 2
common solutions to this problem: either clear the screen before displaying the
file (not always desirable) or clear the attributes at the end of the line
(before the CR/LF). This can now be achieved by adding a @!N@ (the equivalent
of Ctrl-AN for "normal" attributes) to the end of a line. There's no way to
insert custom Ctrl-A sequences or other way to force PabloDraw to clear the
attributes at the end of a line, that I found.

I chose the '!' character because it's (on my keyboard anyway) the Shift-1 key
and Ctrl-A is ASCII 1. I considered a sequence such as @A:x@, but that's one
more character and since this sequence usually won't display anything, a
shorter sequence is likely preferred. For the shortest-possible sequence, use
Ctrl-A sequences instead. However, for many consecutive Ctrl-A sequences, the
@-code equivalent might actually end up being shorter(!). @-codes aren't
support in as many places in Synchronet where Ctrl-A codes are supported (for
security reasons), so it's not like this is going to replace the use of Ctrl-A
codes everywhere.

Modified Files:


src/sbbs3/fmsgdump.c
diff

src/sbbs3/pktdump.c
diff

Don't append the stale static string in fmsgattr_str()

When this function was called multiple times (e.g. multiple messages in a pkt),
it would keep appending to the current (static) string, eventually overflowing
the buffer and corrupting the stack. Although reported in pktdump, it could
have also happened with fmsgdump if passed multiple stored message (.msg)
files.

Fixes #295 reported by Nelgin

Modified Files:


text/menu/multchat.msg
diff

Remove the invisible (black on black) dots

I added them to solve the ANSI screen scroll background attribute fill-new
line issue as I didn't want this menu to clear the screen (there could be chat
lines of text after all).

If this file gets edited with PabloDraw again later, this will have to be fixed
again.

Added Files:


text/menu/multchat.msg
diff

40-column friendly version of the (now defunct) multchat.asc menu.

Removed Files:



text/menu/multchat.asc
diff

Removed in favor of the new multchat.msg

Added Files:


text/menu/main.40col.msg
diff

text/menu/transfer.40col.msg
diff

Rename the 40col menus from .asc to .msg so they appear for CBM/PETSCII terms

The menu file selection priority is like this (for 40col CBM/PETSCII
terminals):
main.40col.seq
main.seq
main.40col.msg
main.msg
main.40col.asc
main.asc

so the main.msg was being chosen before main.40col.asc.

Plus, these files contain ex-ASCII chars, so .msg is actually the more correct
file extension anyway.

Modified Files:


ctrl/text.dat
diff

EnterYourSex -> EnterYourGender

Uses new @code: GENDERS
parts of enhancement #291

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/useredit.cpp
diff

Allow sysop to configure new user gender options (not just M/F)

Up to 40 characters can be configured by the sysop for gender options.
The default choice/configuration is now: "M/F/X" (not just "M/F")
New @-code: GENDERS
text.dat EnterYourSex -> EnterYourGender

Closes enhancement request #291 by Ragnarok

Modified Files:


src/sbbs3/email.cpp
diff

Call smb_updatethread() from sbbs_t::email() to perform Keyop "magic"

As discovered by Keyop and reported via IRC, when replying *to* a local mail
box and *not* using the hard-coded email menu (e.g. when when using
msglist.js), the original message's "Replied" attribute flag was not set. When
replying to a netmail address (at least, Internet or FidoNet, unsure about
QWKnetmail), the attribute would be set.

This discrepancy was because this email() function doesn't use the  "modern"
smb_addmsg() function (which also calls smb_updatethread()), but add the
message body text the old/manual way and never called smb_updatethread().
smb_updatethread() does the thread linkage stuff (which is usually unnoticed in
the mail base) *and* sets the "Replied" attribute of the original message, if
it's not already set.

This function should be overhauled to use smb_addmsg(), but this 2-line change
at least addresses this issue for now. There's probably other places (e.g.
importing mail replies via QWK/REP packets) where this thread-linkage and
"Replied" attribute flag setting is still not happening.

Modified Files:


exec/msglist.js
diff

Added "Replied" attribute to mail messages that are replied-to.

Reported by Keyop.

Modified Files:


src/smblib/smballoc.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

src/xpdev/semfile.c
diff

Resolve some GCC warnings about uncheck return values from std C functions

write()
chsize()

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

When importing FidoNet message area tags > 40 chars, use newsgroup name

Follow-up to previous commit for Keyop (extending max area tag length from 35
to 40/50 chars), when importing echolists/areas.bbs files, if the area tag is
longer than 40 chars, then import it into the newsgroup name field instead (63
chars max).

Modified Files:


src/sbbs3/fidodefs.h
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

Increase FidoNet echo/area tag max length from 35 to 40/50 chars

Per FMail.txt:
Area name
          This is the name of the conference. It can be up to 50
          characters long. This name is often referred to as the
          area tag.

I did not locate a FidoNet spec to contradict that and support a 35 character
maximum area tag length. I think Mystic also has a 50 character area tag limit.
So 50 character area tags are fine I guess.

So up to 50 characters are now supported in SBBSecho and SCFG for area tags
(for message and file echoes). The exception is the (new to 3.19) optional area
tag stored in msgs.cnf/file.cnf is limited to 40 characters due to reserved
space limitations. If you need a tag stored per sub (most sysops do not) and it
needs to be longer than 40 chars, use the newsgroup name instead (limited to 63
chars).

Changed at the request of Keyop via IRC.

Modified Files:


exec/load/ircd/server.js
diff

Fix for 0 TS on server-to-server MODE

Modified Files:


src/sbbs3/userdat.c
diff

Ignore trailing non-alpha-numeric characters in matchusername()

A name ending in a symbol (e.g. "Erich B.") would cause problems with this
matching logic.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Handle FTP requests for paths that start with "/./"

Midnight Commander (mc) apparently sends requests like this for files
(e.g. aliases) in the virtual root directory.

Fixes another part of the reported issue #288.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Fix segfault reported with ftpalias.cfg support in some cases

ftpalias() can return true even when the directory is not set to a valid
directory index (i.e. set to -1), so using as an array index would definitely
segfault. Part of commit 8ad30b6c by Deuce 3 years ago.

I didn't test this as I'm not sure exactly the combination of ftpalias.cfg
content and FTP command received that would trigger this, but it's most
definitely a bug.

So should fix the segfault reported in issue #288.

Modified Files:


exec/load/ircd/core.js
diff

Don't use uninitialized variables in LIST

Modified Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/user.js
diff

Clean up set_chanmode() a bit

Modified Files:


exec/load/ircd/server.js
diff

Don't ignore mode arguments in SJOIN

Modified Files:


ctrl/text.dat
diff

Change SearchExtendedQ to DisplayExtendedFileInfoQ

Relates to feature request #285.

Modified Files:


src/sbbs3/execfile.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

When searching for text in file descriptions, always search ext desc

Since users can (and usually do) display extended descriptions in their normal
file listings anyway, it makes sense to go ahead and search them for the text
(e.g. with the 'F' command from the default command shell File menu/prompt). So
the "search/display extended info" prompt has been changed to just "Display
extended file info" since it no longer controls whether or not the extended
description is searched for the text (it always is). The FL_EXFIND was renamed
to FL_EXT and only controls whether the extended info is display (the FL_FIND
mode flag, always renamed, must also be specified for a find with extended
info).

This closes feature request #285 by Phil (@plt).

Modified Files:


exec/load/ircd/core.js
diff

Check for 'port zero' on the remote port as well

Modified Files:


exec/load/ircd/core.js
diff

Use correct object when logging socket errors

Modified Files:


exec/load/ircd/unregistered.js
diff

Drop DNS replies for closed connections

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

If hitting ESC at Editor Info File prompt, don't prompt for lowercase

Slight usability improvement.

Modified Files:


src/sbbs3/writemsg.cpp
diff

When writing/reading quotes.txt, ignore first 2 lines if WWIV-type

WWIV writes 2 lines of metadata to the beginning of its quotes.txt file created
for external message editors. Its not clear yet what these lines should
contain, but the first line apparently should contain a '#' character since
BREdit checks for this character before deciding to throw-away/ignore these
lines (don't use them for quoted text). Thanks mlong for this tip!

So if the external editor is set to "WWIV CHAIN.TXT" in SCFG (even if the door
doesn't need/use it), then the quotes.txt file created by Synchronet will
contain the extra 2 lines. We're just writing a # to the first line and the
second line is blank.

This fixes reported issue #188.

Modified Files:


src/sbbs3/atcodes.cpp
diff

New @-codes UDR (upload/download byte-ratio) and UDFR (file ratio)

Expands to a percentage, similar to PCR (not capped at 100).

Remove the failed-attempt to cap the percentage at 100 for the PCR atcode.

Modified Files:


exec/load/ircd/core.js
diff

Reject connections if they're from "port zero"

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

Make auto-connects more robust

Modified Files:


src/sbbs3/jsexec.c
diff

Don't fclose(errfp) if it's NULL.

Modified Files:


src/sbbs3/js_system.c
diff

Improve the systme.findstr() JSDOCS description text

Modified Files:


src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Allow '*' pattern character to be used mid-string (not just beg or end)

Previously, the '*' matching pattern character could only be used as the
beginning or ending character of a pattern string; for any other use, it was
treated just as any other exact-match character.

Now, you can have exact-match characters on both the left and right sides of
the '*', so pattern matching like the following is possible:

<*@gmail.com>
digital*man

Multiple '*'s are still not treated special (only the first/left-most '*" is),
so, for example, "*blah*" will not likely produce the desired matching effect
(use "blah~" instead for this case).

Modified Files:


exec/load/ircd/channel.js
diff

Don't use uninitialized variable

Modified Files:


exec/logon.js
diff

Allow text of all guest information prompts to be overridden in modopts.ini

By setting guest_name, guest_email, guest_location, or guest_referral to any
truthy value, a prompt will be display. By setting it to a string (instead of
true), that string will be displayed. I'm not sure how I feel about this kind
of tri-state setting (true/false/string), but it does reduce the number of
settings/options. The alternative is to have a separate boolean and string
setting for each prompt (which I first considered).

So, as of now:

guest_name = false <- no prompt for Guest's name
guest_name = "" <- no prompt for Guest's name
guest_name = true (the default) <- default prompt text for Guest's name
guest_name = "Enter your name, dude" <- replaces prompt text for Guest's name

For enter trailing white-space and ctrl-a codes, use string literals, e.g.
guest_name: "\x01hEnter your name, dude: "

Modified Files:


exec/logon.js
diff

Guest user prompts can be disabled via modopts.ini [logon] settings

guest_name = false will disable name prompt
guest_email = false will disable the email address prompt
guest_location = false will disable the location prompt
guest_referral = false will disable the "where'd you hear about this BBS"
prompt

Note, at minimum, I do recommend prompting for the guest's email address so
that if they send the sysop feedback (e.g. ask a question), they at least have
some hope of receiving a reply.

Modified Files:


src/sbbs3/mailsrvr.c
diff

When logging sender address forgeries, log the address being forged

Helpful for debugging issues with this forgery detection logic (if there are
any).

Modified Files:


src/sbbs3/useredit.cpp
diff

Stop beeping at the sysop when user-searches are successful.

If anything, I suppose would be beep if a search fails, but really, I think
beeps are kind of annoying these days. Not changing the currently
selected/viewed user is likely all that's really needed to indicate a search
failure.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Don't allow unauthenticated DNS-blacklisted clients to post on subs

Eliminate some of the infrequent SPAM posts to the SYNCPROG conference. Maybe
make this behavior configurable?

Modified Files:


exec/load/ircd/core.js
diff

Don't auto-connect to an invalid port. Reported by nelgin, thanks!

Modified Files:


src/sbbs3/js_msgbase.c
diff

Ignore the PRIVATE message attribute for the "mail" base

When setting the value of a message's 'can_read' property, ignore the PRIVATE
message attribute (which is sometimes set in FTN netmail messages) since it's
assumed all messages in the mail base are private, no special destination (to)
name matching is needed here.

This only popped up recently via msglist.js because of the recent addition of
checking each messages's 'can_read' property.

As reported by <Diehard> via IRC PM.

Modified Files:


exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

Don't auto-connect if no port is defined in C:Line, minor Y:Line changes

Modified Files:


exec/newslink.js
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


exec/newslink.js
diff

Add support for optiona "approved" option to be specify moderator's email addr

Apparently required by some news servers.
As requested via IRC:
<poindexter> Hi all, I've got a weird request. I'd like to post to a newsgroup
that relies on automoderation. You need to add an approved: header to any
posting to have it be accepted - keeps the non-techie riffraff away. is there a
way to do that with newslink.js?

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

Improve server connects (both auto and manual)

Modified Files:


exec/load/ircd/core.js
diff

Use servername when detecting if a server's already there

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

Deal with maxlinks on the Y:Line properly for servers

Modified Files:


exec/load/ircd/server.js
diff

Use integer instead of string in initial TOPIC burst

Modified Files:


exec/msglist.js
diff

Don't list messages that can't be read by user

Should fix unvalidated/moderated message readability bug reported by Phil

Modified Files:


src/sbbs3/websrvr.c
diff

Fix NULL pointer dereference in read_post_data()

What took down cvs/sbbs yesterday:
Program terminated with signal SIGSEGV, Segmentation fault.
6203                    session->req.post_data[session->req.post_len]=0;
[Current thread is 1 (Thread 0x7f2b989ff700 (LWP 17031))]
(gdb) print post_len
No symbol "post_len" in current context.
(gdb) print session->req.post_len
$1 = 0
(gdb) print session->req.post_data
$2 = 0x0

Modified Files:


src/sbbs3/scansubs.cpp
diff

Initialize local variable 'str' in scanallsubs().

Fixes issue #276

Modified Files:


exec/msgutil.js
diff

Don't load() 822header.js unless we're exporting messages

822header.js adds an enumerable method to the header object which ends up in
the output when using the -hdrs option/command.

This addresses issue #277

Note: this is not actually a supported or documented script.

Modified Files:


exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

Fix up STATS m and EVAL

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/user.js
diff

Clean up LIST

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

Make better use of format()

Modified Files:


exec/load/ircd/server.js
diff

Improve TS handling in SJOIN

Modified Files:


exec/load/ircd/server.js
diff

Fix up the server-to-server AKILL message

Modified Files:


exec/load/ircd/server.js
diff

Use correct formatting for printf in NICK

Modified Files:


exec/load/ircd/server.js
diff

Reject malformed NICK messages from servers and notify

Modified Files:


exec/load/ircd/core.js
diff

Fix STATS m to report proper command, found by nelgin, thanks!

Modified Files:


exec/load/ircd/server.js
diff

Use better source of nickname on SJOIN

Modified Files:


exec/load/ircd/user.js
diff

We don't use command anymore, fixes crash on /OPER. Found by nelgin, thanks!

Modified Files:


exec/load/ircd/user.js
diff

Use proper variable on KILL

Modified Files:


ctrl/ircbot.ini
diff

Use a better default hostname for the bot

Modified Files:


exec/ircd.js
diff

exec/load/ircd/core.js
diff

Fix up epoch use in strftime as well

Modified Files:


exec/ircd.js
diff

exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

exec/load/irclib.js
diff

Deprecate time() in favour of new Date()

Modified Files:


exec/load/ircd/server.js
diff

Fix mode desync on server SJOIN. Thanks to Retros for finding where this was
coming from!

Modified Files:


src/sbbs3/file.cpp
diff

Fix memory leak (of extended description) when moving files

Modified Files:


exec/load/ircd/user.js
diff

Fix local KILL (bug reported by phil)

Modified Files:


src/sbbs3/main.cpp
diff

Fix newly-introduced (but likely harmless) bug in mv()

Thanks Coverity! (CID 332340)

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Call smb_freefilemem() instead of smb_msgmem() for files

Not that it really matters, but perhaps it'll matter in the future. And the
code reads better.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

mv() simplified for the non-copy case

Constified function arguments. Source path is still case-insensitive, but
destination is case-sensitive (hopefully that's not an issue).

When a "move" (!copy) is requested, a rename() is always attempted first and if
successful, job done. Otherwise, we continue on with the file-copy (and then
remove).

This should resolve CID 332219 (DEADCODE).

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/upload.cpp
diff

src/smblib/smbdefs.h
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.h
diff

Standardize on "metadata" as the description of a file's "tail" dfield

It's anticipated that this will be used for JS-populated file metadata in JSON
format in the future (and not just "archive contents" in .ini format).

Also, fix the double-free issue that was occurring when moving files with
extended file descriptions (sbbs_t::movefile()). This was actually the primary
problem I was fixing here, but noticed the metadata issue: metadata would not
have been moved along with the other file info between bases.

Modified Files:


src/sbbs3/filedat.c
diff

Include archive_error_string() in archive_write_header failure msg

Hopefully this helps get to the bottom of Ragnarok's reported problem creating
ZIP QWK files with libarchive.

Modified Files:


src/sbbs3/filedat.c
diff

Remove tbz (tarred bzip) files from supported archive list

Not supported by default on Windows and perhaps not on all *nix systems.
You can still support creation of tbz files if you like, but you'll need to
setup an external "Compressible File Type" in SCFG to do it.

Modified Files:


src/sbbs3/pack_qwk.cpp
diff

Better error handling in QWK packet creation

If libarchive creates a 0-byte file or no file at all, then fall-through to the
"temp file command-line" (if there is at least one Compressible File Type
configured).

If libarchive fails, there will still be a (hopefully helpful) error message
logged, but at least the QWK packet may still get created.

Modified Files:


web/lib/msgslib.ssjs
diff

Fix recently-introduced issue reading the 'mail' base.

Reported by AL@TRMB.

Modified Files:


src/sbbs3/main.cpp
diff

Always use rename() on *nix when mv() is called with copy=FALSE

This should fix issue #272 reported by Ragnarok. Not the libarchive error part,
but the second (mv) CopyFile error part.

Modified Files:


web/root/msgs/msg.ssjs
diff

Fail with graceful error message if msgbase is not defined.

Modified Files:


exec/delfiles.js
diff

Don't try to delete offline files when removing from filebase.

Reported by DaiTengu via eye are sea.

Modified Files:


web/lib/msgslib.ssjs
diff

Don't open a message base for an invalid sub-board.

Resolves this errors appearing on Vertrauen where the sub=<code> value appears
to be from some *other* Synchronet BBS:
Unrecognized msgbase code: dove-firearms, Request:
/msgs/msgs.ssjs?msg_sub=dove-firearms

Modified Files:


exec/filelist.js
diff

Remove the unused "-arc" option parsing.

Modified Files:


exec/filelist.js
diff

Add -desc option (include summary/descriptions, same as '-vv')

The -hdr option no longer implies -ext (extended descriptions).

Truncate white-space off end of extended descriptions.

Modified Files:


text/menu/sysxfer.asc
diff

Add DIR command - not sure if/where this was documented before

Update the description of the GET and PUT commands too.

Modified Files:


exec/str_cmds.js
diff

Use K_TRIM mode flag with getstr() through-out.

Modified Files:


exec/tempxfer.js
diff

Allow download of any extracted file

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Detect TLS startup errors correct/fully

We can't (apparently) only rely on the return value of start_tls(), we have to
check the value of the crypt session too.
This fix the possibility of this happening:
Jun  7 18:07:26 sbbs synchronet: ftp  0058 TLS ERROR 'No permiss.to perform
this operation' (-21) opening keyset
Jun  7 18:07:26 sbbs synchronet: ftp  0058 <192.168.1.25> initialized TLS
successfully

Instead, we'll detect the failure and disable FTPS support, logging "failed to
initialize TLS successfully".

Modified Files:


src/sbbs3/scandirs.cpp
diff

Increase the progress() reporting frequency for filename/desc searches

This resolve long delays (while searching for files) without any indication of
progress.

Keep new-scan progress interval at 10 dirs however (they're fast).

Modified Files:


src/sbbs3/con_out.cpp
diff

Condition newline before progress display

Sometimes the progress meter (e.g. during file text searches) appears at a
column offset > 0 and doesn't look good. Fix that.

Modified Files:


src/sbbs3/file.cpp
diff

More use of K_TRIM when prompting for filename/spec

Modified Files:


src/sbbs3/data.cpp
diff

Modernize finduser() a bit

Skip any prepended white-space in the passed name to find.
Use better variable names (and length) for the character strings.
Use matchusername() instead of strcmp(); matchusername() follows the liberal
user-id/alias/name matching algorithm.
Use strcasestr() instead of strstr(), so no copy/modification (upper-casing) of
passed name is now required.
When 'Q'uitting the search, set the SS_ABORT flag.

Modified Files:


src/sbbs3/smbutil.c
diff

Resolved sign/unsigned compare warning

Modified Files:


src/sbbs3/text_defaults.c
diff

EmptyDir and BadFilename string updates

Modified Files:


src/sbbs3/execfunc.cpp
diff

src/sbbs3/upload.cpp
diff

Use K_TRIM getstr() mode when prompting for filenames

Don't need no stinking pre/appended white-space in our filenames!

Modified Files:


text/file.can
diff

Add Windows "reserved names"

For info, see:
https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

Give sysop more control over characters allowed in uploaded filenames

5 options:
- Safest Subset
- Most ASCII, Excluding Spaces (the default)
- Most ASCII, Including Spaces
- Most CP437, Excluding Spaces
- Most CP437, Including Spaces

Modified Files:


text/file.can
diff

Add img001.exe a popular FTP-spread trojan

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/upload.cpp
diff

Include '?' and '*' in ILLEGAL_FILENAME_CHARS definition

Modified Files:


src/xpdev/dirwrap.c
diff

I guess GLOB_PERIOD is Linux or GNU extension. <shrug>

Fix FreeBSD build error:
dirwrap.c:760:13: error: use of undeclared identifier 'GLOB_PERIOD'
Not sure how glob() on FreeBSD treats "dot files" or how to control that.

Modified Files:


ctrl/text.dat
diff

BadFilename is now a format string, EmptyDir uses cond-blankline.

Modified Files:


exec/binkit.js
diff

Don't log an error if after a failure to remove a file, the file doesn't exist

Modified Files:


exec/postfile.js
diff

Set the file cost value to the file size.

Modified Files:


src/xpdev/dirwrap.c
diff

Fix delfiles() to delete files starting with '.' (that match the pattern)

glob() by default, doesn't include 'dot files', so include the GLOB_PERIOD
flag so that when deleting all files in a directory (e.g. node1/temp/*), any
files starting with a dot will be deleted too.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Check batch-uploaded filenames for illegal characters/sequences/names

The BadFilename text.dat is now a format string (prints the bad filename).
Use the nice progress() display status while searching for duplicate filenames.

Modified Files:


src/sbbs3/email.cpp
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/writemsg.cpp
diff

BadFilename text.dat string is now a format string

(prints the bad filename)
- also, checkfname() is going to do the file.can (trashcan) checking, so no
need here

Modified Files:


src/sbbs3/logfile.cpp
diff

src/sbbs3/sbbs.h
diff

A little constification.

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/ftpsrvr.c
diff

More uniform safe/illegal/allowed filename (for upload) determination

sbbs_t::checkfname() now checks the file.can too.
new filedat.c functions:
- safest_filename() - not currently used
- illegal_filename() - returns true for a highly-suspicious (e.g. hack attempt)
filename
- allowed_filename() - returns true if the filename is good for upload (assumed
to be already checked to be legal as well).

Importantly, filenames beginning or ending in a '.' are now unallowed:
- 'dot files' are hidden (by default) on *nix
- files ending in a '.' are problematic on Windows

Modified Files:


exec/load/dns.js
diff

Fix parsing of the return code.

This fixes an issue in TypeClass lookups (such as used by reverse())

Modified Files:


src/sbbs3/smbutil.c
diff

Add new commands to flag/unflag all messages for deletion

The command to delete and remove all messages is changed from 'd' to 'D'.
This operation is not reversable.

New commands are 'd' (flag all msgs for deletion) and 'u' (undelete all msgs).

Modified Files:


src/sbbs3/websrvr.c
diff

Remove incorrect and unnecessary comment.

Modified Files:


src/sbbs3/websrvr.c
diff

Don't allow colons in web-requested path names on Windows

This fixes issue #269 (NTFS Alternate Data Stream vulnerability) and other
potential pathname issues on Windows involving colons.

There are other illegal filename characters on Windows (e.g. <>|"?*), but
filenames with these characters aren't expected to pass the later stat() test,
so should fail with a 404 error.

Modified Files:


src/encode/objects.mk
diff

Add new hex object

Modified Files:


src/sbbs3/GNUmakefile
diff

Web server needs encode lib (for hex_decode)

Added Files:


src/encode/hex.c
diff

src/encode/hex.h
diff

Generic hexadecimal encode/decode string functions (e.g. for URL decode)

These functions can be used for "percent encode/decode" or any other
2-hex-digit encoding/decoding with a single escape character.

Modified Files:


src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.vcxproj
diff

Filenames with '+' characters in them could not be served unless encoded

The requested path was being URL-decoded with unescape(), but that function
does a '+' to ' ' (space) conversion.
The '+' to space decoding is supposed to occur for the "query" portion of the
URL only, not the "path" portion.
Use the new hex_decode() function instead of unescape() for "path" decoding.

Modified Files:


src/conio/x_events.c
diff

Avoid directly manipulating XImage data for now.

The previous tests to detect RGB8 appear to have been insufficient.
This may have resulted in various artifacts such as transparency with
some drivers on some hardware in X11 mode.

Modified Files:


src/conio/x_events.c
diff

Remove debug output introduced in last commit

Modified Files:


src/syncterm/syncterm.c
diff

Some Atari (and likely C64) fixes

1) setfont() after loading fonts
2) In X11 mode, don't translate ASCII characters from unicode...
   this was causing non-ASCII characters to be translated twice.

Modified Files:


exec/lbshell.js
diff

Only add accessible programs to the xtrn list

Modified Files:


src/syncterm/syncterm.c
diff

Add CIOLIB_MODE_CURSES_ASCII to output_map

Fixes sourceforce issue number 60.

Reported by WitNik (Thanks!)

Modified Files:


exec/load/irclib.js
diff

Fix integer-to-IP conversion

Modified Files:


exec/load/ircd/core.js
diff

Fix undeclared variable in WHO

Modified Files:


src/sbbs3/tmp_xfer.cpp
diff

Increase file list creation progress report frequency

Cosmetic only.

Modified Files:


src/sbbs3/listfile.cpp
diff

Create (export to text) file lists faster

- Don't read/load extended descriptions
- Don't query each file size (use file cost from database)

Modified Files:


web/root/msgs/msgs.ssjs
diff

Elimniate sysop/logged error when just msgs.ssjs is requested

msgs.ssjs line 6: TypeError: msgbase is undefined

Instead, just display an error to the user/browser (assuming there is one).

Modified Files:


exec/ircd.js
diff

Turns out we need to disable infinite loop detection after all

Modified Files:


web/root/msgs/msg.ssjs
diff

Fix errors when reading msgs posted by users that no longer exist

"msg.ssjs line 42: Error: Error -1 reading user number"

Fixed an errant semicolon in the process. (15 year old minor bug)

Modified Files:


src/sbbs3/listfile.cpp
diff

Beautify the file list files (e.g. NEWFILES.TXT) a bit

Use the file size estimates rather than actual byte values (to keep lines < 80
chars).
Use file name file summary/description is blank or doesn't exist.

Modified Files:


src/sbbs3/tmp_xfer.cpp
diff

File list creation scan progress meter display.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Microsoft doesn't have fchmod(), so use chmod() on the closed file

Modified Files:


src/sbbs3/sbbsecho.c
diff

Keep the same area file (areas.bbs) mode flags (permissions)

When executing area manager requests that alter the area file, the temp area
file created (with mkstemp) had mode 0600 (owner read/write only). The sysop
very possibly had different permission flags they want to keep for their area
file, so copy the mode flags from the original area file to the temp/new area
file.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Don't allow downlinks (AreaFix add) of our "Unknown echoes" sub-board

It was recently pointed out to me that a downlink could link to the '*' echo
via Area Manager (AreaFix) request. This was not intentional.

Modified Files:


exec/archive.js
diff

Since viewable file types support wildcards now, just use '*'

This installs as the last viewable file type, so it just becomes a
fall-through for all file extensions/types and attempts to view them
using the Archive class.

Modified Files:


docs/newfilebase.txt
diff

User to User transfer support was restored and other updates

e.g. DIZ's up to 4000 characters are supported.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/tmp_xfer.cpp
diff

Add optional "temp file transfer" module (defaults to "tempxfer"[.js])

This module (name configurable in SCFG->System->Loadable Modules) replaces the
old hard-coded temp/archive file menu in v3.18 and earlier, going all the way
back to v1a. Good-bye to yet more old and crufty Synchronet C source code. :-/

Change the "Pre Xtrn Prog" and "Post Xtrn Prop" menu option in
SCFG->System->Loadable Modules to just "Pre Xtrn" and "Post Xtrn". The help
text had the wrong names anyway (now fixed).
Save the menu lightbar position in the "Loadable Modules" SCFG menu.

Added Files:


exec/tempxfer.js
diff

A new module to replace the hard-coded temp/archive file menu in v3.18

The last missing file feature in v3.19.

Modified Files:


ctrl/text.dat
diff

More use of conditional blank lines in prompt strings.

Modified Files:


src/sbbs3/text_defaults.c
diff

More use of conditional blank lines in prompt strings.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Add bbs.export_filelist() method

This is the last thing needed to complete the new temp/archive menu module
implemented in JavaScript for v3.19.

File list generation can easily be done in JS (see filelist.js for example),
but since we have this function already in C++ (i.e. for including filelists in
QWK packets) - might as well make it available for use in JS.

Modified Files:


exec/load/ircd/server.js
diff

Fix LINKS

Modified Files:


exec/load/ircd/core.js
diff

exec/load/ircd/user.js
diff

Only purge queue on connection reset. Clean up user QUIT a bit.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

New bbs.view_file(filename) method.

To list/view file/archive contents.

Modified Files:


exec/ircmsg.js
diff

Wait for the correct PING reponse using a random token.

One potential issue here is if you connect/send to irc.synchro.net,
you'l going to get the PONG response back from a different hostname
(e.g. vert.synchro.net), which won't match the expected PONG response.

Modified Files:


exec/ircmsg.js
diff

Send a PING line after message line(s), wait for response.

Is this what you had in mind, Cyan?

Modified Files:


exec/chat_sec.js
diff

Abort menu loop when disconnected.

Modified Files:


exec/load/text.js
diff

Latest new string number definitions.

Modified Files:


src/sbbs3/text_defaults.c
diff

Updated default BatchFlagPrompt

Modified Files:


exec/load/sbbslist_lib.js
diff

Change the max BBS name length from 40 to 30.

40 was causing a lot of cosmetic issues in sbbslist.js (for 80col terminals).
This is a compromise (not reducing to the old limit of 25 chars at least). :-)

Modified Files:


exec/sbbslist.js
diff

Remove storage from the 6th format, was making lines too long for 80cols.

And nobody cares about your terabytes of free space anyway.

Modified Files:


exec/load/ircd/core.js
diff

Don't set properties until we know the object is valid

Modified Files:


ctrl/modopts.ini
diff

Add comment about adding sections/keys if they don't already exist.

Modified Files:


exec/newslink.js
diff

Twitlist optimization (don't re-read over and over)

Also added debug-level log messages for message loop rejection
reasons, for John Dovey (GATOFUEG).

Modified Files:


src/sbbs3/sbbs.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/viewfile.cpp
diff

Support wildcards in viewable file type extensions (e.g. * and ?)

Now archive.js can be installed as a sort of "fall-through" file viewer (rather
than listing all the supported/possible archive extensions as separately
viewable file-types):
File Extension        *                
Command Line          ?archive list %f 

Modified Files:


exec/load/ircd/core.js
diff

WHOIS now shows if the user is connected via SSL

Modified Files:


ctrl/ipfilter_exempt.cfg
diff

ctrl/text.dat
diff

src/conio/OverhaulNotes.txt
diff

src/conio/bitmap_con.c
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_msgbase.c
diff

src/syncdraw/load.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

src/xpdev/gen_defs.h
diff

Removed Files:



xtrn/sbl/DEPRECATED.TXT
diff

xtrn/sbl/GNUmakefile
diff

xtrn/sbl/Makefile
diff

xtrn/sbl/objects.mk
diff

xtrn/sbl/sbbslist.c
diff

xtrn/sbl/sbl
diff

xtrn/sbl/sbl.bpf
diff

xtrn/sbl/sbl.bpr
diff

xtrn/sbl/sbl.c
diff

xtrn/sbl/sbl.cfg
diff

xtrn/sbl/sbl.doc
diff

xtrn/sbl/sbl.dsp
diff

xtrn/sbl/sbl2smb
diff

xtrn/sbl/sbl2smb.c
diff

xtrn/sbl/sbl2smb.dsp
diff

xtrn/sbl/sbl2txt.c
diff

xtrn/sbl/sbldefs.h
diff

xtrn/sbl/sblpack
diff

xtrn/sbl/sblpack.c
diff

xtrn/sbl/sblpack.dsp
diff

xtrn/sbl/smb2sbl
diff

xtrn/sbl/smb2sbl.c
diff

xtrn/sbl/smb2sbl.dsp
diff

xtrn/sbl/sysop.txt
diff

xtrn/sbl/targets.mk
diff

Merge branch 'master' of gitlab.synchro.net:main/sbbs

Modified Files:


ctrl/ipfilter_exempt.cfg
diff

Add more private IP address ranges to the default filter exemption list

And the IPv4 link local address block (169.254/16) too.

Modified Files:


src/syncdraw/load.c
diff

Treat .msg files the same as .asc when loading.

Removed Files:



xtrn/sbl/DEPRECATED.TXT
diff

xtrn/sbl/GNUmakefile
diff

xtrn/sbl/Makefile
diff

xtrn/sbl/objects.mk
diff

xtrn/sbl/sbbslist.c
diff

xtrn/sbl/sbl
diff

xtrn/sbl/sbl.bpf
diff

xtrn/sbl/sbl.bpr
diff

xtrn/sbl/sbl.c
diff

xtrn/sbl/sbl.cfg
diff

xtrn/sbl/sbl.doc
diff

xtrn/sbl/sbl.dsp
diff

xtrn/sbl/sbl2smb
diff

xtrn/sbl/sbl2smb.c
diff

xtrn/sbl/sbl2smb.dsp
diff

xtrn/sbl/sbl2txt.c
diff

xtrn/sbl/sbldefs.h
diff

xtrn/sbl/sblpack
diff

xtrn/sbl/sblpack.c
diff

xtrn/sbl/sblpack.dsp
diff

xtrn/sbl/smb2sbl
diff

xtrn/sbl/smb2sbl.c
diff

xtrn/sbl/smb2sbl.dsp
diff

xtrn/sbl/sysop.txt
diff

xtrn/sbl/targets.mk
diff

Remove SBL (Synchronet BBS List) - replaced by sbbslist.js years ago

No need to keep this around, someone might try to build or run it!

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Use the screen modes enum, not names array for ini parsing

Any screen mode where the description and the enum value were not
identical (ie: ones with spaces or parenthesis) would not be used
at startup correctly.

Reported by DigitalMan via Discord

Modified Files:


src/sbbs3/js_msgbase.c
diff

Fix mime_version and content_type property names in JSDOCS

Underscores are more JS friendly (and correct).

Modified Files:


src/sbbs3/js_archive.c
diff

Replace la_int64_t with int64_t for rjwboys.

Modified Files:


ctrl/text.dat
diff

Obscure the number of file(s) shown as its non-obvious/helpful

Just include the total files in the listing, not the current display.
Fixes #268.

Modified Files:


src/sbbs3/filedat.c
diff

Use int64_t instead of la_int64_t

Resolve error reported on irc with Ubuntu (don't know what version):
<rjwboys> ok now i get filedat.c:896:3: error: unknown type name
‘la_int64_t’

Modified Files:


src/conio/bitmap_con.c
diff

Default to blocky scaling

For programs that don't specify a scaling type (scfg, syncdraw)
use blocky scaling.

Modified Files:


src/syncterm/syncterm.c
diff

Set the text mode before scaling and size

Setting the scaling and size before changing modes does weird things.
Those things should be fixed, but at least this makes the problem
go away in SyncTERM for now.

Modified Files:


src/conio/OverhaulNotes.txt
diff

13) We need a way to specify the initial mode.

Modified Files:


src/xpdev/gen_defs.h
diff

Character 255 is a non-breaking space in CP437

Now IS_WHITESPACE() will return true for that char and this allows things like
truncsp() to truncate trailing white-space (e.g. from a FILE_ID.DIZ), even if
it contains a terminating 0xFF character for some unknown reason.

Modified Files:


src/sbbs3/file.cpp
diff

Don't abort the file-info edit prompts if no uploader name is entered

Modified Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/server.js
diff

Fix unused/undeclared variables

Modified Files:


src/syncterm/bbslist.c
diff

Set mode by macro, not number

Modified Files:


src/conio/ciolib.h
diff

src/conio/vidmodes.c
diff

src/conio/vidmodes.h
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Add "LCD 80x25" to make DigitalMan less angry

He's old, and should keep his blood pressure down.
Do not walk on his lawn.

Modified Files:


exec/ircd.js
diff

exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

exec/load/irclib.js
diff

text/ircmotd.txt
diff

IRCd 1.9b

Modified Files:


exec/ircd.js
diff

exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

exec/load/irclib.js
diff

text/ircmotd.txt
diff

Merge branch 'master' into 'master'

IRCd 1.9b

See merge request main/sbbs!126

Modified Files:


src/sbbs3/js_internal.c
diff

Fix console and connect events when using select()

Modified Files:


src/xpdev/sockwrap.c
diff

Make inet_ptoaddr() not crash and work with IPv4 address strings

Modified Files:


src/syncterm/bbslist.c
diff

Fix custom mode font size picker

Modified Files:


exec/msglist.js
diff

Perform deleted-msg filtering for all message bases, not just mail

Issue reported by plt2 via IRC.

Added Files:


src/conio/OverhaulNotes.txt
diff

Add notes for CIOLIBng

This is basically just a scratchpad for things I want to have in
the future ciolib.

Added Files:


exec/load/rip.js
diff

Add a new RIP utility library

Currently, this has RIP.supported which returns true if RIP is
supported by the client, and rip.loadicons(archive) which sends
all the icons (and .RIP files) in the specified archive (either
an Arcive object or a filename) to the remote if they don't
already have them.

If you have a RIP enabled door, a small JS script as a pre-run
command like this:

require("rip.js", "RIP");
rip.loadicons('/sbbs/xtrl/lord/lordicns.zip');

Will automatically send all the icon files in the arcive to the
user if the user doesn't already have them.  For SyncTERM as of
this commit, they will be placed in the cache directory for that
BBS (and only be available for that BBS).

On *nix, the cache dir is ~/.syncterm/cache/<bbsname>
On Win32 it's something like: C:\Users\User\AppData\Local\Microsoft\Windows\INe
tCache\SyncTERM\cache\<bbsname>

No ideal what it is on macOS.

Modified Files:


src/syncterm/ripper.c
diff

Fix auto-transfers

Modified Files:


src/syncterm/ripper.c
diff

Send CRLF instead of the specified CR on a file status.

Modified Files:


src/conio/x_events.c
diff

Fix newly-introduced memory leak...

I was going to start keeping the old rect around again, but that
idea didn't pan out.  This massive memory leak is what I get for
not doing more commits while tuning.

Modified Files:


src/syncterm/syncterm.c
diff

Try to remove the extra "SyncTERM" from the BBS cache path on Win32

Reported by Booch (Thanks!)

Modified Files:


src/conio/scale.c
diff

Fix error: ‘stderr’ undeclared (first use in this function)

Modified Files:


src/sbbs3/file.cpp
diff

Have movefile() leave the original file with the delete attribute

This has the effect of the file being listed as absent/deleted in the listing
that's in memory. As requested by Phil, plt via irc.

Moving a file after this change did result in a crash once, but I couldn't
reproduce it with a debugger attached.

Modified Files:


src/conio/bitmap_con.c
diff

Fix bug in last commit

Pixes set via setpixels() were only set in the "blink off" screen
and not in the "blink on" screen... so they all reverse blinked.

Modified Files:


src/build/Common.gmake
diff

src/conio/bitmap_con.c
diff

src/conio/scale.c
diff

src/conio/x_events.c
diff

Optimizations:

1) Keep a rectangle updated per-screen rather than regenerate each time
2) Strip palette info when putting pixels into rectangles rather than
   during scaling
3) Tighten up the screen locks a bit
4) Don't require a full resend of both screens on an update request
5) Only force a redraw for cursor movement when the cursor is visible
   (And force it whenever the cursor changes)
6) Avoid doubles in interpolation
7) Heavily optimize interpolate_height()
   interpolate_width() likely doesn't need it because it's generally not
   used and also it reads from the next pixel in memory making the
   prefetchers job easier.
8) Fix some memory-leak-on-error issues
9) For ARGB8 XImages, manipulate the data directly rather than through
   XPutPixel()

At this point, the scaling and X11 output time is heavily dominated by
cache misses.  The only really effective way to reduce this hit is to
spread the work across all the L3 caches in the system or move it into
the GPU.

With the latest updates, at the SyncTERM menu, over 90% of the time is
spent in the rendering pipeline, and over 90% of that time is spent
thrashing the caches... the only real easy win left is vectorizing, but
that's highly compiler specific.

To that end, I've switched to -O3 for release builds.  There was a comment
that -finline-functions broke Baja "badly", but that's clearly false since
-f-inline-functions has been part of -O2 for quite a while now, and Baja
doesn't seem any more broken that it ever was.

Modified Files:


src/xpdev/filewrap.h
diff

Create a Win32 wrapper for mkstemp() as MSVC doesn't have it

SBBSecho uses mkstemp() now (instead of tempnam()) - so we need this POSIX
function wrapper for Windows builds to succeed.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Replace tempnam() usage with the suggested mkstemp()

Since we're cleaning up warnings... this will break the Windows build for now.

Modified Files:


src/conio/sdl_con.c
diff

src/conio/xbr.c
diff

src/sbbs3/zmodem.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/ooii.c
diff

src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

src/uifc/filepick.c
diff

Fix all GCC warnings in SyncTERM on FreeBSD

Modified Files:


src/conio/GNUmakefile
diff

Don't disable the GCC suggested parenthesis warning here

Modified Files:


src/syncterm/ripper.c
diff

ifdef out an unused static function for now.

It will be used in the future, so the code shouldn't be deleted,
but not using it causes a warning.

Modified Files:


src/conio/xbr.c
diff

Digitalman and Clang agree that order of operations is too hard to
reply on.  Make it harder to merge this code from upstream in the
future instead.

Modified Files:


src/conio/scale.c
diff

Screw it, if the compiler doesn't optimize it, just use more CPU.

At least the warnings are gone.

Modified Files:


src/conio/GNUmakefile
diff

Disable gcc warning about suggested parenthesis

Deuce doesn't want to add "useless parenthesis" to xbr.c.
Hopefully Clang will just ignore this -Wno-* option?
warning: suggest parentheses around ‘&&’ within ‘||’

Modified Files:


src/conio/scale.c
diff

Declare blend() as inline to eliminate gcc warning

warning: always_inline function might not be inlinable [-Wattributes]

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/conio/sdl_con.c
diff

src/sbbs3/umonitor/spyon.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/ripper.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

Add an argument to cterm_end() to not free fonts

While we're doing that, actually use it in SyncTERM so the offline
scrollback retains fonts.

Also, fix an issue where the current mode would be updated with
the custom parameters when you changed them.

Finally, remove some unused variables.

Modified Files:


src/conio/x_events.c
diff

Eliminate unused variable that I guess clang doesn't warn about but gcc does.

Modified Files:


src/syncterm/ripper.c
diff

Use fexistcase() for RIP assets

It seems that at least LORD has upper-case in the ZIPs and lower-case
in the queries.

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/syncterm/ripper.c
diff

src/syncterm/syncterm.c
diff

Add some love for SkyPix

The biggest issue with SkyPix is the fact that it's *not* a character
cell mode.  The cursor is pretty much impossible to position correctly,
and all the text "stuff" basically needs to be bypassed.

Modified Files:


src/syncterm/bbslist.c
diff

Recalculate list height before showing after mode change

Modified Files:


src/uifc/uifc32.c
diff

Draw the shadow if the API bgcolor is blue

WIN_INACT was not getting a border because it changes the value
of bclr which is explicitly compared with BLUE to detect if a
shadow should be drawn.

Instead, draw a shadow any time it would normally be drawn.

Modified Files:


src/conio/x_events.c
diff

No need to resize window just because it moved.

Fixes X11 window dragging blinkiness.