Synchronet Git Commit Log

Modified Files:


src/sbbs3/sbbsexec.vcxproj
diff

Need the Windows Kit include dir fix for release build too

Modified Files:


src/sbbs3/sbbsexec.vcxproj
diff

Update the Windows Kit path (with needed NTDDK #include files) to 10.0.22621.0

This is version installed with MSVC 2022

Modified Files:


src/sbbs3/build.bat
diff

src/sexpots/build.bat
diff

src/syncterm/build.bat
diff

src/vdmodem/build.bat
diff

Use the new MSVS 2022 "common tools" environment variable: VS170COMNTOOLS

to find VsMSBuildCmd.bat

This means you can't use MSVS 2019 with this build.bat any longer.

Modified Files:


src/sbbs3/main.cpp
diff

Auto-recycle the term server if/when the ctrl/text.ini file is created/touched

Modified Files:


ctrl/text.dat
diff

Use @-codes for commonly-localized words, some deprecated and new strings

Modified Files:


ctrl/text.de.ini
diff

ctrl/text.es.ini
diff

Updated to include more localized words and metadata (LANG)

Modified Files:


src/sbbs3/chksmb.c
diff

Replace many references to "Message" with "File" when scanning a file base

This could use more cleanup (e.g. instances of "MSGERR:") and in the summary
report there are still mentions of "message" after scanning a file base.

Modified Files:


src/sbbs3/load_cfg.c
diff

Fix off-by-one issue in previous commit, text.dat string numbers are 1-based

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_system.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

Fast text.dat string references, more localization support via JS and @-codes

sbbs_t::mnemonics() now supports @-codes immediately following the tilde
(e.g. ~@Yes@) to use the first character of a dynamically-replaced
(e.g. localized/translated) text string as a command key.
Fixed issue in sbbs_t::mnemonics if multiple @-codes were specified in the
string, but no space characters (just noticed this bug while reviewing).

Created: sbbs_t::expand_atcodes() - used by sbbs_t::mnemonics(), exposed in
JS as bbs.expand_atcodes().

bbs.text and system.text now have properties: each text string ID is the
property name and the text index number (1-based) is the property value -
enabling fast text string lookup without load/require text.js

Constified sbbs_t::atcode() and attrstr() - not too painful

Deprecated YNQP text.dat string in favor of (the first character of)
  "Yes" and "No" text strings and new strings: "Quit", and "PasswordChar"

Other text.dat changes: ListKey->List, AllKey->Unused853
More new text.dat strings: Which, Next, Previous, Language, LANG
Deprecate the "AllKey" text string
Create/use sbbs_t::all_key() - first character of "All" text string

New JS console properties that present common (possibly localized) command
keys: yes_key, no_key, quit_key, all_key, list_key, next_key, prev_key

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/telgate.cpp
diff

Use On/Off text.dat strings instead of (soon to be deprecated) ON/OFF strings

There are other ways to generate forced-upper case expanded @-codes, if that's
what you want.

Fewer duplicates in text.dat make localization, translation to other languages
easier.

Modified Files:


src/sbbs3/load_cfg.c
diff

Allow text strings to be identified by number (instead of ID)

for those that want to use cryptic numbers rather than human-readable names.

Modified Files:


xtrn/wttr.in/locator.js
diff

xtrn/wttr.in/wttr-lib.js
diff

Complete the switch to use system.temp_dir instead of temp_path for WSS

See issue #648 for details.

Modified Files:


exec/chat_sec.js
diff

Use the lower case On and Off text.dat strings

The uppercase ON and OFF are being deprecated

Modified Files:


exec/websocketservice.js
diff

Use system.temp_dir (configurable by sysop) instead of system.temp_path

Fixes issue #648

Modified Files:


src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.vcxproj
diff

Remove the now-unneeded property sheet references

Modified Files:


src/sbbs3/objects.mk
diff

addfiles and delfiles are just little stubs now, simplify dependencies

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

Remove more build dependencies. Adjust warning text a bit.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

Officially deprecate the ADDFILES and DELFILES utilities

These were problematic (crash, could corrupt filebases) and unsupported,
so just change the programs to stubs that alert the sysop that they need to
switch to using the JS versions of these utilities immediately.

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Don't pass all command-line arguments to child programs

Only the common/UIFC-type arguments should be passed-on.

This fixes issue #646

It also appeared that the user editor spawning wouldn't work correctly
when arguments were passed to umonitor (missing a space).

Modified Files:


exec/addfiles.js
diff

Add -readd option to mark any updated existing files as newly-uploaded

Modified Files:


src/sbbs3/load_cfg.vcxproj
diff

Add text_id.c (fixes the current Windows build)

Added Files:


ctrl/text.de.ini
diff

ctrl/text.es.ini
diff

The beginnings of localization of text.dat to Spanish and German

Of course, I'm just guessing using DDG Translate, I don't actually speak
these languages with any fluency, so I could use help from those that do.

These files aren't directly used by anything yet. One could copy or symlink
them to ctrl/text.ini or dynamically load them for certain users (right now,
that'd be done via JS).

Added Files:


exec/replace_text.js
diff

Script that can load additional ctrl/text.*.ini (or .json) text override files

e.g. as a logon script "?replace_text es" would replace strings from
ctrl/text.es.ini (for Spanish translations)

This is not really to be used to load ctrl/text.ini since that is support is
built in (in load_cfg.c) and not necessary to be done in JS.

Modified Files:


src/sbbs3/gtkchat/objects.mk
diff

src/sbbs3/objects.mk
diff

src/sbbs3/scfg/objects.mk
diff

src/sbbs3/uedit/objects.mk
diff

src/sbbs3/umonitor/objects.mk
diff

Include new text_id module in builds

Added Files:


src/sbbs3/text_id.c
diff

I guess we're not auto-generating these textgen'd files on *nix builds

Hm.

Modified Files:


src/sbbs3/answer.cpp
diff

Hyphenate "sign-up" in log message

Modified Files:


src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/str.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/textgen.c
diff

Add support for ctrl/text.ini, used for sysop-override of text.dat strings

The syntax of text.ini is:
<id>: "string"
<id>: "string"

Where <id> is the named identifier of a text.dat string as seen ctrl/text.dat
and string is a literal string value (optionally, in double-quotes). Line
continuations (for long strings) are not supported: you'll just need to put
your string all on one long line (up to 1024 char string).
C-escape characters for control chars and hex-encoded chars are supported.

This should address feature request issue #644

Modified Files:


src/sbbs3/atcodes.cpp
diff

text.dat string IDs can now be used in/as @-codes, directly

The TEXT:<x> @-code can now be used with the text.dat string ID rather than
the text.dat string number, if preferred.

For convenience and brevity, ALL text.dat string IDs are now valid @-codes
(case-sensitive). While this functionality is redundant with the TEXT: @-code
now, if there are any conflicts between new/existing @-codes and text.dat
string IDs, the TEXT: @-code can be used to overcome such conflicts.

This should help with localization (to other languages) by using common
single-word replacements (Which, Quit, Next, etc.) in text.dat strings.

Modified Files:


src/sbbs3/main.cpp
diff

Close node socket after waiting one hour to go inactive to run exclusive event

After 90 minutes of waiting, we'll do the same abort wait (and run the event
anyway), but closing the node's socket should be enough to get the node_thread
to terminate and set the node status back to NODE_WFC.

Apparently some sysops like to leave their terminals idling (e.g. running MRC)
and never disconnect and since they're T-exempt, the BBS won't limit their
time online to allow events to run. Exclusive events will wait for all nodes
to become inactive, but give up after 90 minutes of waiting and run the event
anyway and set node status to WFC at the end. If the node was actually still
connected/in-use, this could lead to the (new) critical error messages logged
"!Node X status is WFC, but the node socket (N) and thread are still in use!"
and other chaos (NODE STATUS FIXUP and the like).

This should prevent all that by just abruptly disconnecting the node after
waiting 60 minutes for the sysop to gracefully disconnect. The log message
when this happens:
"!TIRED of waiting for node N to become inactive (status=X), closing socket Y"

Modified Files:


exec/user_settings.js
diff

Use the word Only from the text.dat (for localization)

Modified Files:


ctrl/text.dat
diff

The ComputerType question/answer strings have been used in decades

Mark them all "UNUSED"

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Add space after numeric value on second line of DOORFILE.SR

This appears to work around a bug in BRE, FE, and TAL where they don't
recognize the "1" (ANSI supported) unless there is at least one other
character on the line following the decimal digit, resulting in the
unnecessary prompting of the user:
  This game is much more enjoyable with ANSI graphics enabled.
  Do you want ANSI Graphics? (Y/n)

As reported by "ben" in IRC.

Modified Files:


src/sbbs3/useredit.cpp
diff

Clear line counter before starting the user settings/config menu.

Fixes unnecessary [Hit a key] prompt.

Modified Files:


exec/user_settings.js
diff

Move the 'Q' hotspot to just *after* the display of the prompt

Fixes issue #645

Modified Files:


exec/user_settings.js
diff

Style update: white-space and parenthesis

Fix-up the require() statements.

Modified Files:


exec/user_settings.js
diff

Fix the 'M' mouse hotspot

Also clear the screen immediately cause it can take a noticable amount
of time to read/parse the file.ini and main.ini files.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/useredit.cpp
diff

Add optional User (Settings) Configuration loadable module

When used, replaces built-in user (e.g. terminal) settings menu with a
loadable (e.g. JS) module.

Modified Files:


exec/load/text.js
diff

New text.dat string (index): None

Modified Files:


exec/user_settings.js
diff

We can't make a copy of 'user', need to create a new User() instance

... or else any changes we make aren't saved (we're just modifying this
object in memory).

Fix the heading (user alias is displayed, not name).

Fix the mouse hot-spots.

Fix the "None" default download protocol (requires latest text.js).

Fix the hot-key option (inverted logic).

Don't display the [K] Command Shell option if there's only one available.

Added Files:


exec/user_settings.js
diff

Clean-up naming, use of global variables, remove text.dat reversion

Modified Files:


exec/user_settings.js
diff

Fix the terminal type display

pass undefined to termdesc.type() when editing current user

Added Files:


exec/default_settings.js
diff

js version of user default

Added Files:


exec/default_settings.js
diff

Merge branch 'nelgin_default_settings' into 'master'

js version of user default

See merge request main/sbbs!331

Modified Files:


exec/init-fidonet.js
diff

exec/load/cfglib.js
diff

Fix "error 13 opening" files when using init-fidonet.js

I finally reproduced this issue myself on a fresh install on Windows.

We needed explicit file closing here as going out of scope doesn't immediately
finalize (and close) a File object. That may not happen until garbage
collection and thus prevent subsequent re-opens of the same files, so always
close() your files.

init-fidonet.js calls install-binkit.js which uses cfglib.js, so that was
a source of these errors too.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

DD MsgReader and SlyVote: Fixed poll voting for single-answer polls

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

Merge branch 'dd_msg_reader_slyvote_single_answer_poll_fix' into 'master'

DD MsgReader and SlyVote: Fixed poll voting for single-answer polls

Closes #642

See merge request main/sbbs!337

Added Files:


webv4/components/sysop-required.xjs
diff

webv4/components/webmonitor/clients-panel.xjs
diff

webv4/components/webmonitor/documentation-panel.xjs
diff

webv4/components/webmonitor/events-panel.xjs
diff

webv4/components/webmonitor/nodes-panel.xjs
diff

webv4/components/webmonitor/quadrant.xjs
diff

webv4/components/webmonitor/recent-visitors-panel.xjs
diff

webv4/components/webmonitor/server-panel.xjs
diff

webv4/components/webmonitor/statistics-panel.xjs
diff

webv4/components/webmonitor/term-configuration-modal.xjs
diff

webv4/pages/More/001-webmonitor.xjs
diff

webv4/root/api/webmonitor/get-term.ssjs
diff

webv4/root/api/webmonitor/update-term.ssjs
diff

webv4/root/js/webmonitor.js
diff

Modified Files:


webv4/components/mqtt.xjs
diff

webv4/lib/auth.js
diff

webv4/pages/More/001-nodespy.xjs
diff

webv4/pages/More/webctrl.ini
diff

webv4/root/js/mqtt.js
diff

webv4/sidebar/002-recent-visitors.xjs
diff

A web-based sbbsctrl implementation

Added Files:


webv4/components/sysop-required.xjs
diff

webv4/components/webmonitor/clients-panel.xjs
diff

webv4/components/webmonitor/documentation-panel.xjs
diff

webv4/components/webmonitor/events-panel.xjs
diff

webv4/components/webmonitor/nodes-panel.xjs
diff

webv4/components/webmonitor/quadrant.xjs
diff

webv4/components/webmonitor/recent-visitors-panel.xjs
diff

webv4/components/webmonitor/server-panel.xjs
diff

webv4/components/webmonitor/statistics-panel.xjs
diff

webv4/components/webmonitor/term-configuration-modal.xjs
diff

webv4/pages/More/001-webmonitor.xjs
diff

webv4/root/api/webmonitor/get-term.ssjs
diff

webv4/root/api/webmonitor/update-term.ssjs
diff

webv4/root/js/webmonitor.js
diff

Modified Files:


webv4/components/mqtt.xjs
diff

webv4/lib/auth.js
diff

webv4/pages/More/001-nodespy.xjs
diff

webv4/pages/More/webctrl.ini
diff

webv4/root/js/mqtt.js
diff

webv4/sidebar/002-recent-visitors.xjs
diff

Merge branch 'Ree/sbbsctrl' into 'master'

A web-based sbbsctrl implementation

See merge request main/sbbs!318

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

DD File Lister: If used as a loadable module and blanked out the NFilesListed
string, then revert NFilesListed on exit of the script

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'dd_file_lister_revert_NFilesListed' into 'master'

DD File Lister: If used as a loadable module and blanked out the NFilesListed
string, then revert NFilesListed on exit of the script

See merge request main/sbbs!336

Modified Files:


src/sbbs3/main.cpp
diff

Log a critical error message if a node is WFC, but its socket is still in use

This should avoid/work-around issue #630

Nelgin's terminal server log indicated that the node's configuration was being
reloaded for a new client connection (which doesn't normally/always happen,
only when there's been a config file change or a node "rerun" requested),
while there was still a user online using that node. This would explain the
segfault (configuration fields being freed and reallocated).

The node_socket[] array indicates when a node thread is actively servicing
a client, so it should contain INVALID_SOCKET for the any node's that WFC.
If it doesn't, that means something/someone changed the node's status value
to 0 (WFC) in the node.dab file while the node was still in-use. Let's not
crash in this case and rather just log the message and give the client the
next available node (if any).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Add more detail (e.g. line number) to various "error opening" log msgs

Some of the errors could be pretty vague since they looked the same and
we were depending on the path/file attempted to be opened in the log msg
to clue us into what exactly was being attempted. But some of these file
paths are sysop-configurable, and they can put unexpected things in there
that make it difficult to determine exactly what file was trying to be
opened and for what purpose. This should help a little bit.

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DD File Lister: Blank out the "# Files Listed" string if used as a loadable
module (optional, defaults to true)

Modified Files:


xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_blank_NFilesListed_as_loadable_module' into
'master'

DD File Lister: Blank out the "# Files Listed" string if used as a loadable
module (optional, defaults to true)

See merge request main/sbbs!334

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

DD File area chooser: Bug fix for searching with name collapsing

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/version_history.txt
diff

Merge branch 'dd_file_area_chooser_name_collapsing_search_fix' into 'master'

DD File area chooser: Bug fix for searching with name collapsing

See merge request main/sbbs!335

Modified Files:


src/sbbs3/con_hi.cpp
diff

src/sbbs3/sbbs.h
diff

The first argument to sbbs_t::uselect() is actually a boolean

Modified Files:


src/sbbs3/js_console.cpp
diff

If console.uselect() is called just with the number argument, use as default

This allows the calling script to control what the default item is (when the
user just hits enter), and not always the first item.

Fixes issue #637

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DD File Lister 'empty directory' fix, help screen pause, filename searching,
etc

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch
'dd_file_lister_exit_code_filename_searching_and_help_screen_pause' into
'master'

DD File Lister 'empty directory' fix, help screen pause, filename searching,
etc

See merge request main/sbbs!333

Added Files:


xtrn/DDAreaChoosers/version_history.txt
diff

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

DD area choosers: Header line display fix

Added Files:


xtrn/DDAreaChoosers/version_history.txt
diff

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

Merge branch 'dd_area_choosers_header_lines_display_fix' into 'master'

DD area choosers: Header line display fix

See merge request main/sbbs!332

Added Files:


exec/load/termdesc.js
diff

Load lib to return descriptive strings for terminal parameters

Much of the logic ported from sbbs_t methods in con_out.cpp

For Nelgin's default_settings.js project

Modified Files:


exec/imapservice.js
diff

Fix error when client supplies invalid Base64 string during auth

IIRC, the error was undefined has no properties or split() is not a function,
something like that.

Modified Files:


exec/imapservice.js
diff

Wrap the body of parse_command() in a try/catch to turn errors into warnings

As requested by Keyop in #synchrob0yyz

Modified Files:


src/sbbs3/scfg/scfgxfr1.c
diff

Remove mention of tbz (tarred-bzip) support

tbz is technically still supported by create_archive(), but without it
being included in the supported_archive_formats definition, isn't easily
chosen as an option and nobody seems to miss it.

Modified Files:


src/sbbs3/upgrade_to_v319.vcxproj
diff

src/sbbs3/upgrade_to_v320.vcxproj
diff

Make output directories unique for these projects

Apparently one was copied from the other and used the same original
output file subdirectory name ("upgrade") oops.

Modified Files:


src/sbbs3/fmsgdump.vcxproj
diff

src/sbbs3/pktdump.vcxproj
diff

Change PlatformToolset from v142 to v141_xp (the latest that supports WinXP)

I didn't notice that these projects were still being built with a toolset
that didn't target WinXP. I might need to update the SDK too.

Modified Files:


src/sbbs3/exec.cpp
diff

Don't decrement user.xedit before calling uselect()

This bug would leave the user's external editor setting decremented by one if
they aborted (with Ctrl-C).

Fixes issue #631

Modified Files:


src/sbbs3/useredit.cpp
diff

Change external editor yes/no prompt default to match current user setting

Also, although not a bug (because we re-read/parse the user's record every
menu cycle), don't decrement user.xedit before calling uselect()
- just not a good practice to not modify variables unnecessarily.
See the corresponding change to exec.cpp, which was a bug.

Added Files:


exec/delmsgs.js
diff

A simple script to delete messages a msgbase

e.g. 'jsexec delmsgs mail from joe-blow'

Modified Files:


exec/load/cfglib.js
diff

Add basic reading main.ini and file.ini (not all sections)

This should be enough for Nelgin to make progress with his user defaults menu
script.

Not all sections are read and parsed and there will be some extra properties
(e.g. "code" in repeated sections that don't normally have that), so the
returned objects aren't (yet) suitable for re-writing back to the *.ini files.

I also cleaned up some of the exceptions (throwing strings rather than Errors)
and removed some empty functions.

Modified Files:


src/sbbs3/main.cpp
diff

Remove redundant timestamp from "End of preexisting log entry" log message

Most logs sysops are looking at already have a date/timestamp for each
message, so this one ended up with 3 date/timestamps in a single line.

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/useredit.cpp
diff

Add new @-code: PROTNAME for full name of default transfer protocol (or None)

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add new @-code: PROT, user's default file transfer protocol (character)

This fixes issue #629

Modified Files:


ctrl/text.dat
diff

Add comma to UserDefaultsRows and new string: None

Modified Files:


src/sbbs3/logon.cpp
diff

A todo comment

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/useredit.cpp
diff

Several new @-codes that can be used to display user's configuration settings

I'll add detailed docs to http://wiki.synchro.net/custom:atcodes soon, but the
list is:

- TERMTYPE
- TERMROWS
- TERMCOLS
- AUTOTERM
- ANSI
- ASCII
- COLOR
- ICE
- RIP
- PETSCII
- SWAPDEL
- UTF8
- MOUSE
- UPAUSE
- SPIN
- PAUSESPIN
- EXPERT
- HOTKEYS
- MSGCLS
- REMSUBS
- FILEDESC
- FILEFLAG
- AUTOHANG
- AUTOLOGON
- QUIET
- ASKNSCAN
- ASKSSCAN
- ANFSCAN
- EDITOR
- SHELL

This should (at least mostly) address the issue #629

Modified Files:


src/sbbs3/mqtt.c
diff

Fix log topic publishing when using MQTT v3

Apparently if you call mosquitto_publish_v5() with a non-NULL properties
pointer, it'll only publish via protocol v5 and doesn't work if you're using
protocol v3 connection.

Thanks Ree.

Modified Files:


src/sbbs3/mqtt.c
diff

Always publish log messages to both .../logs and .../logs/<level> topics

... regardless of the configured MQTT protocol version (v5 or v3.x).

Also include an MQTT v5 user-property ("time") with the message's origination
time/date stamp in ISO-8601 format in all log messages (to both topics).

This will at least double the amount of MQTT log traffic to the broker. When
MQTT v5 is used, the additional user-properties will increase it even a little
more.

Is this what you were suggesting Ree?

Modified Files:


exec/imapservice.js
diff

Wrap the entire search logic in a try/catch statement

This should effectively turn script-terminating errors into just warnings and
thus at least working-around issue #397: the exceptions will be logged as
warnings intead of errors, but still logged.

Modified Files:


src/sbbs3/js_user.c
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/userdat.c
diff

Allow JS 'user.editor' and '.shell' to be set for non-users (e.g. user #0)

The request from Nightfox and Accession via DOVE-Net was to be able to set
a user's external editor even if there's no user logged-in.

These 2 user class properties in the JS object model were a bit special in
that they *only* wrote to the user database and did not immediately modify
the in-memory copy of the user_t structure, depending on the re-reading of
the user.dat/tab file to re-populate the current user_t structure when needed.
This didn't work if the current user is user #0 (no user).

So, set the current user_t.xedit and user_t.shell accordingly whenever those
JS properties are assigned a value (a string, the appropriate internal code).

Modified Files:


src/sbbs3/exec.cpp
diff

Don't call putuserdat if the user number is invalid (not logged in)

This should fix issue #626

Modified Files:


src/sbbs3/mqtt.c
diff

Add ability to send a node message via MQTT (to sbbs/+/node/+/msg topic)

The node message should be terminated with a newline character.

e.g.
$ echo "Hey you" | mosquitto_pub -s -t sbbs/VERT/node/1/msg

I'm considering the ability to send user message (telegrams) via MQTT too.

Modified Files:


exec/websocketservice.js
diff

Add support for binary frames to websocket service

Modified Files:


exec/websocketservice.js
diff

Merge branch 'Ree/websocketservice-support-binary' into 'master'

Add support for binary frames to websocket service

See merge request main/sbbs!330

Modified Files:


exec/load/presence_lib.js
diff

webv4/lib/events/nodelist.js
diff

webv4/root/api/system.ssjs
diff

Update node action display on web

Modified Files:


exec/load/presence_lib.js
diff

webv4/lib/events/nodelist.js
diff

webv4/root/api/system.ssjs
diff

Merge branch 'Ree/nodelist-external-name' into 'master'

Update node action display on web

See merge request main/sbbs!329

Modified Files:


exec/sendmsg.js
diff

Use sysop name instead of user.email if user.number == 0 (run from JSexec)

The reported issue didnt mention JSexec, but I assume that's what was meant
by "from the command line". (?)

I honestly forgot this script even existed. It's using the old deprecated
SMTP SOML command to send a telegram to a user. There are much better ways
to do that for the local system (e.g. calling system.put_telegram), but I
suspect this script existed since before the JS object model had support
for sending user telegrams.

Anyway, this was a simple change to fix issue #623, but really this
script should probably be rewritten or removed from the repo (we use
MSP for sending inter-BBS instant messages these days instead of SMTP/SOML).

Modified Files:


install/systemd/sbbs.service
diff

Change NotifyAccess from "main" to "all"

sd_notify() is called from other threads (PIDs), so we've been getting
syslog warnings abouts this and I hadn't noticed:

systemd[1]: sbbs.service: Got notification message from PID 2555007, but
reception only permitted for main PID which is currently not known

As pointed out by Accession (PHARCYDE) on DOVE-Net.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

Resolve new GCC warnings introduced with addition of new_item()

Just make the list argument a void* and assign to a void** local
var inside the function. No functional changes.

Fixes issue #621

Modified Files:


src/sbbs3/js_socket.c
diff

Fix return value when p->peeked is true

Modified Files:


src/sbbs3/js_socket.c
diff

Merge branch 'Ree/js_socket_recv-fix' into 'master'

Fix return value when p->peeked is true

See merge request main/sbbs!328

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

Update File Options "paste" behavior to use insert-above instead of overwrite

To be more consistent with the paste key behavior elsewhere in SCFG,
make the file options (Viewable Files, Testable Files, Download Events,
Extractable Files, Compressible Files, and Transfer Protocols) menus handle
paste (Ctrl-V, F6) key by inserting the copied or cut item above the current
selection rather than overwriting the current selection.

Fixes issue #616

Modified Files:


exec/websocketservice.js
diff

Speed up file transfers.

Modified Files:


exec/websocketservice.js
diff

Merge branch 'Ree/websocketservice-speedup' into 'master'

Speed up file transfers.

See merge request main/sbbs!327

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Fix for the lightbar interface: When erasing the file info
window, the file date is not shown on a duplicate line if the file date is
already showing in the description area (i.e., for a 1-line file description).
The veresion is now 2.14

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_lightbar_info_description_date_fix' into 'master'

DDFileLister: Fix for the lightbar interface: When erasing the file info
window, the file date is not shown on a duplicate line if the file date is
already showing in the description area (i.e., for a 1-line file description).
The veresion is now 2.14

See merge request main/sbbs!326

Modified Files:


src/odoors/GNUmakefile
diff

Hacks to get ODoors to build on Linux (Debian/Ubuntu recent releases) again

1. Resolve the "hidden symbol 'atexit' ... being referenced by DSO" error
   by using the -shared option (link against shared objects, not static libs)
2. The path to the xpdev output directory (where to find libxpdev.a) is just
   wrong. Hard-coded the machine architecuture portion (.x64) as a hack for
   now. Also, since this is use the LD macro, you need to pass "LD=gcc" on the
   make command-line. Not sure how this worked before.

Fixes (or at least works-around) issues reported by Ryan Fantus (1:218/820)

Modified Files:


src/sbbs3/js_internal.c
diff

Don't use scope argument value to js.exec() if it's null

Fixes issue #611

Modified Files:


xtrn/mrc/mrc-client.js
diff

Fix for js.time_limit stuck at 0

Modified Files:


xtrn/mrc/mrc-client.js
diff

Merge branch 'mrc_fix_time_limit' into 'master'

Fix for js.time_limit stuck at 0

See merge request main/sbbs!325

Modified Files:


xtrn/mrc/mrc-client.js
diff

xtrn/mrc/readme.txt
diff

Fix timeout in mrc client and connector to avoid endless loop issue

Modified Files:


xtrn/mrc/mrc-client.js
diff

xtrn/mrc/readme.txt
diff

Merge branch 'mrc_fix_endless_loop_issue' into 'master'

Fix timeout in mrc client and connector to avoid endless loop issue

See merge request main/sbbs!324

Modified Files:


exec/load/ircd/core.js
diff

Fix https://gitlab.synchro.net/main/sbbs/-/issues/601

Modified Files:


src/sbbs3/node.c
diff

src/sbbs3/nodedefs.h
diff

node utility can now display one/some/all key/values from node*/client.ini

<nelgin> Remind me why you can't show the ip address on node status? :)

Using the new '-v[key]' option, a sysop can view one, some, or all of the
key/value pairs from the nodes with a connected client. For nodes without
a connected client, the client.ini file values aren't particularly useful, but
if someone wants an option to show those values for non-client-connected nodes
I can do that too.

When using '-v', all the client.ini key/value pairs will be displayed for all
the node records requested with currently connected clients. By specifying
'-v[key]' the sysop can specify a key to display (rather than all of them)
e.g. 'node list -vaddr' to list nodes with remote client IP addresses.
This option can be used multiple times on the command-line to view multiple
keys. See node*/client.ini for the list of supported keys.

This feature only works for nodes whose directory paths are ../node#/
relative to the ctrl directory. Since the node utility doesn't read any
configuration files, this is a limitation. If you have different node
directory names/parents and need to use this feature, let me know and I'll
see about adding support for reading/parsing main.ini file to discover those
non-standard/default node directory paths automatically.

The version number displayed is now taken from the sbbs version (sbbsdefs.h).
The maximum ctrl directory path is now extended from 40 chars to MAX_PATH.
More readable help/usage output (using indentation).

Modified Files:


src/sbbs3/mqtt.c
diff

Remove MQTT message publishing from mqtt_connect_callback()

A follow-up to commit 81d4575e

Although I was not able to successfully reproduce the problem that Ree
reported with his commit (even when changing the SCFG->Networks->MQTT->Publish
QOS to 1: At least once) on Windows, I do see how this problem could
theoretically happen. And like Ree said in the follow-up comment on the MR
"maybe these two lines should have stayed in mqtt_startup", they don't really
belong in the connection callback.

The "client" topics only needs to be cleared upon startup or recycle (by
publishing a null message) and it would be bad to clear these topics whenever
the broker was reconnected (the server's clients didn't magically disconnect).
So these "client" topic-clearing publishes are now only done during startup
(again).

The "recycle" topics don't really need to be published to here at all. I
think I only did this for cases where someone published a non-null message to
the topic and its stale message would remain afterward, appearing in MQTT
browsers (like MQTT explorer) long after the server had recycled. The real
solution to this cosmetic issue is to only publish null (0-length) messages to
the "recycle" topics in the first place.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Bug fix for going to a specific message in the message list...

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_list_msg_num_input_fix' into 'master'

DDMsgReader: Bug fix for going to a specific message in the message list...

See merge request main/sbbs!323

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Fix "Error writing /path/to/sbbs.ini" when using '-f' option.

Wasn't opening the sbbs.ini file for modify access.

As reported via DOVE-Net by Accession (PHARCYDE)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: When saving a message on the local BBS PC without all the headers,
the date is now included

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_save_msg_time' into 'master'

DDMsgReader: When saving a message on the local BBS PC without all the headers,
the date is now included

See merge request main/sbbs!322

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DD Message Reader: Including all message headers when saving a message
(sysop...

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_save_all_msg_headers_optional' into 'master'

DD Message Reader: Including all message headers when saving a message
(sysop...

See merge request main/sbbs!319

Modified Files:


src/sbbs3/mqtt.c
diff

Add a connect callback handler.

Modified Files:


src/sbbs3/mqtt.c
diff

Merge branch 'Ree/mqtt-connect-callback' into 'master'

Add a connect callback handler.

See merge request main/sbbs!320

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for "Message header has 'expanded fields'" error when updating
message header attributes in certain conditions

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_update_attributes_expanded_fields_error_fix' into
'master'

DDMsgReader: Fix for "Message header has 'expanded fields'" error when updating
message header attributes in certain conditions

See merge request main/sbbs!317

Modified Files:


exec/mqtt_spy.js
diff

Use console.write() when available for outputting spied content

Defeats local auto-screen-pausing

Fixes issue #603 reported by Nelgin

Modified Files:


src/sbbs3/scfglib2.c
diff

Move reading of each dir's data_dir key into read_dir_defaults_cfg()

This appears to just be a miss from the initial commit (70b835d0) of the
directory default configuration (per lib) feature, so a file
lib's directory default "data dir" wouldn't be read from file.ini.

This fixes issue #602 reported by Nelgin.

Modified Files:


exec/SlyEdit_Misc.js
diff

SlyEdit: More small tweaks for quote line wrapping to determine ideal places to
append a CRLF

Modified Files:


exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_quote_line_wrapping_more_tweaks' into 'master'

SlyEdit: More small tweaks for quote line wrapping to determine ideal places to
append a CRLF

See merge request main/sbbs!316

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Allows kwyeord searching of personal email with command-line
arguments

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_search_personal_email_update' into 'master'

DDMsgReader: Allows kwyeord searching of personal email with command-line
arguments

See merge request main/sbbs!315

Added Files:


webv4/components/mqtt.xjs
diff

webv4/pages/More/001-nodespy.xjs
diff

webv4/root/js/mqtt.js
diff

webv4/root/js/nodespy.js
diff

Removed Files:


webv4/pages/More/002-nodespy.xjs
diff

Refactor the node spy page

Added Files:


webv4/components/mqtt.xjs
diff

webv4/pages/More/001-nodespy.xjs
diff

webv4/root/js/mqtt.js
diff

webv4/root/js/nodespy.js
diff

Removed Files:


webv4/pages/More/002-nodespy.xjs
diff

Merge branch 'Ree/node-spy-2' into 'master'

Refactor the node spy page

See merge request main/sbbs!314

Modified Files:


exec/SlyEdit_Misc.js
diff

SlyEdit: For quote lines, a small tweak for long line (>120 character) adding a
CRLF for paragraph formatting

Modified Files:


exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_long_line_crlf' into 'master'

SlyEdit: For quote lines, a small tweak for long line (>120 character) adding a
CRLF for paragraph formatting

See merge request main/sbbs!313

Modified Files:


docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

SlyEdit: Improvement to paragraph/line breaks in quote line wrapping. The
version is now 1.87

Modified Files:


docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_quote_wrap_paragraph_improvement' into 'master'

SlyEdit: Improvement to paragraph/line breaks in quote line wrapping. The
version is now 1.87

See merge request main/sbbs!312

Added Files:


webv4/pages/More/002-nodespy.xjs
diff

webv4/root/js/utf8_cp437.js
diff

Modified Files:


webv4/lib/pages.js
diff

webv4/pages/More/webctrl.ini
diff

Add a node spy to the web interface

Added Files:


webv4/pages/More/002-nodespy.xjs
diff

webv4/root/js/utf8_cp437.js
diff

Modified Files:


webv4/lib/pages.js
diff

webv4/pages/More/webctrl.ini
diff

Merge branch 'Ree/node-spy' into 'master'

Add a node spy to the web interface

See merge request main/sbbs!308

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Traditional UI - Fixes for qutiting certain actions. Prints
selected actions. Up & down arrow keys.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_traditional_ui_enhancements' into 'master'

DDFileLister: Traditional UI - Fixes for qutiting certain actions. Prints
selected actions. Up & down arrow keys.

See merge request main/sbbs!311

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/defaultTheme.cfg
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

ddfilelister now has its own implementation of a traditional (non-lightbar) UI.
Its version is now 2.12

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/ddfilelister/ddfilelister.cfg
diff

xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/defaultTheme.cfg
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_traditional_ui_implementation' into 'master'

ddfilelister now has its own implementation of a traditional (non-lightbar) UI.
Its version is now 2.12

See merge request main/sbbs!309

Modified Files:


src/sbbs3/mqtt.c
diff

Allow triggering timed event or QWKnet call-out by publishing to MQTT topic

- sbbs/BBSID/exec (publish the timed event's internal code)
- sbbs/BBSID/call (publish the QWKnet hub's ID)

The message contents are not case-sensitive.

Modified Files:


src/sbbs3/mqtt.c
diff

Allow a msg value of "0" to clear/unset the node/+/set/# topics/flags

e.g. publishing "0" to node/#/set/intr will clear the node-interrupt flag.
Any non-zero message value will "set" the flag. Same is true for the
lock, down, and rerun topics/flags.

These node attributes (misc) flags could be cleared previously
by setting the 'misc' topic (e.g. to 0), but since that's not an atomic
read/modify/write operation, other set misc flags could be lost clearing flags
in that manner.

Modified Files:


src/sbbs3/mqtt.c
diff

Prioritize the node/+/input topics over the node/+/set/+ topics

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgchat.c
diff

Fix some signed/unsigned int comparison warnings from MSVC

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Add some helper functions for modifying node records in node.dab, atomically

These should probably be moved (along with other node functions in this file)
to nodedat.* some day.

Modified Files:


src/sbbs3/nodedefs.h
diff

Changes in comments only: copyright header block, typo

Modified Files:


src/sbbs3/mqtt.c
diff

New MQTT topics that the terminal server will subscribe to for node changes

<nelgin> can I push an intr instruction to a node with mqtt?

node/#/set/status - set the node status value (to an integer)
node/#/set/errors - set the node error counter (to an integer, e.g. "0")
node/#/set/misc - set the node's miscellaneous attributes/flags value
 (hexadecimal values can be set by including "0x" prefix)

The message (payload) doesn't matter for the following topics:
node/#/set/lock - lock a node (no one but sysop can login)
node/#/set/intr - interrupt a node (disconnect a user)
node/#/set/down - down a node (not available for connections)
node/#/set/rerun - rerun a node (reload config upon next connection)

Modified Files:


exec/mqtt_pub.js
diff

Fix ReferenceError: options is not defined

Just fall-through to display help output for unrecognized options.

Modified Files:


exec/mqtt_stats.js
diff

Set QOS level to 1 (2 doesn't work?)

Remove unnecessary call to JSON.stringify() in non-JSON mode

Modified Files:


exec/mqtt_pub.js
diff

Add -B and -H options to auto-prefix the topic with BBS or host topic prefix

This allows command-lines to be more cross-platform/host

As requested by Nelgin

Added Files:


exec/mqtt_stats.js
diff

Script to publish statistics (optionally, JSON-encoded) to BBSID/stats topic

Use a timed event and/or execute via jsexec

Nelgin's request/idea

Modified Files:


xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

DD Upload Processor: Scan failure output is now logged to the system log
instead of outputted to the logged-in user

Modified Files:


xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

Merge branch 'ddup_scan_fail_logging' into 'master'

DD Upload Processor: Scan failure output is now logged to the system log
instead of outputted to the logged-in user

See merge request main/sbbs!307

Modified Files:


src/sbbs3/jsexec.c
diff

Insure the exec_dir is *always* prepped (fix for Windows upgrade to v3.20)

A "prepped" means directory means a relative path from the configuration files
(or default settings) has been converted to a full/absolute path with proper
slashes for the platform (i.e. backslashes instead of forward-slashes on
Windows).

JSexec doesn't require that the new v3.20 ctrl/*.ini files exist to run; this
was necessary to be able to run 'jsexec update -> upgrade_to_v320.js' which
does the ctrl/*.cnf to .ini file conversion (egg not required to build
chicken). When JSexec failed to load ctrl/msgs.ini
(e.g. "!ERROR loading configuration files: 2 (No such file or directory)
opening /sbbs/ctrl\msgs.ini"), it would continue to run, but not "prep" any
of the "path" settings (e.g. exec_dir).

The first run of 'jsexec update.js' would fail to run upgrade_to_v320.exe
(which does the v3.20 user base conversion) and a bunch of other (but not as
important) update steps because Windows couldn't execute "../exec/*".

Multiple errors would be displayed in this case, but the most important (as
reported by Ree in #synchronet of irc.synchro.net) was:
  '..' is not recognized as an internal or external command

right after the status output:
  No v3.20 user base found, running ../exec/upgrade_to_v320

Notice the "../exec/" prefix, which is not support by Windows when specifying
a file path to execute.

A second run of 'jsexec update' would work fine because the new v3.20 .ini
files would be successfully created after the first run (though the user base
was not).

This is likely the same issue that MRO reported recently when upgrading a
Windows SBBS v3.19 install to v3.20 and not having the user base upgraded
the first time.

Modified Files:


src/sbbs3/scfg/scfgxfr1.c
diff

Code indentation change only.

Modified Files:


xtrn/dd_upload_processor/readme.txt
diff

Fixed a typo in the DD Upload Processor readme.txt

Modified Files:


xtrn/dd_upload_processor/readme.txt
diff

Merge branch 'dd_upload_processor_readme_typo_fix' into 'master'

Fixed a typo in the DD Upload Processor readme.txt

See merge request main/sbbs!306

Modified Files:


xtrn/dd_arc_viewer/dd_arc_viewer.cfg
diff

xtrn/dd_arc_viewer/dd_arc_viewer.js
diff

xtrn/dd_arc_viewer/readme.txt
diff

xtrn/dd_arc_viewer/revision_history.txt
diff

xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

DD arc viewer & upload processor: Refactor of how the configuration files are
read. Arc viewer: Control characters are no longer needed for color settings.

Modified Files:


xtrn/dd_arc_viewer/dd_arc_viewer.cfg
diff

xtrn/dd_arc_viewer/dd_arc_viewer.js
diff

xtrn/dd_arc_viewer/readme.txt
diff

xtrn/dd_arc_viewer/revision_history.txt
diff

xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

Merge branch 'dd_upload_processor_arc_viewer_config_load_refactor' into
'master'

DD arc viewer & upload processor: Refactor of how the configuration files are
read. Arc viewer: Control characters are no longer needed for color settings.

See merge request main/sbbs!305

Modified Files:


xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

DD Upload Processor: Now supports Synchronet's built-in archive support to
extract archive files

Modified Files:


xtrn/dd_upload_processor/ddup.js
diff

xtrn/dd_upload_processor/readme.txt
diff

xtrn/dd_upload_processor/version_history.txt
diff

Merge branch 'ddup_synchronet_archive_support' into 'master'

DD Upload Processor: Now supports Synchronet's built-in archive support to
extract archive files

See merge request main/sbbs!304

Modified Files:


exec/mqtt_spy.js
diff

Don't publish "null" node input topic

get_ansi_seq() here can return null, don't pass that value to mqtt.publish()
which gets converted to a string.

Modified Files:


exec/mqtt_spy.js
diff

Add character set translation (CP437 <> UTF-8)

... for when your terminal and the node client terminal don't use the same
character set. Only CP437 and UTF-8 addressed in this commit, not PETSCII
or plain ASCII.

This was never possible before MQTT.

Added Files:


exec/mqtt_spy.js
diff

Modified Files:


exec/str_cmds.js
diff

Support for spying via MQTT between nodes

For read-only spying, the mqtt_spy.js module can be used via jsexec (from an
OS shell command prompt), similar to mosquitto_sub.

For read-write spying, just use the ;SPY sysop command as before and if MQTT
is configured/enabled, it'll use MQTT rather than sockets or shared memory
queues to spy on the target node.

For the first time, you can spy between nodes that are on different servers of
the same BBS using the ;SPY sysop command.

Passes through ctrl characters (except Ctrl-C), unlike the built-in spy
function. This could be revisited later or made optional, but it sems to make
sense to allow Ctrl-Z (e.g. to save a message in fseditor.js) to be passed
through to the target node.

Modified Files:


src/vdmodem/vdmodem.c
diff

Don't leave socket open when dial() reports "NO CARRIER"

As reported by Deon on DOVE-net, when the call to socket_recvdone() returns
true (socket is disconnected and all data has been recv()ed), dial() would
report "NO CARRIER" but leave the open socket opened, thus preventing any
subsequent dial attempt ("Can't dial: Already connected" and "ERROR").

Also removed the source file path/name from the debug print statements - don't
need that noise.

Incremented the version to 0.4

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.txt
diff

Add support for 90-97 and 100-107 SGR parameters

This allows directly setting bright foreground and background colours
rather than using bold and blink to indirectly modify them.

These do not have an effect if the desired mode is not possible
(ie: no bright background, no bright foreground).

Modified Files:


src/syncterm/ripper.c
diff

Properly read extended keys in non-graphics builds.

Fixes SF issue 118

Modified Files:


xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

DDMsgReader: In the theme configuration file, use a : as the separator for...

Modified Files:


xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

Merge branch 'DDMsgReader_theme_strings_trailing_spaces' into 'master'

DDMsgReader: In the theme configuration file, use a : as the separator for...

See merge request main/sbbs!303

Modified Files:


src/conio/x_cio.c
diff

Free rects passed before X11 is initialized

Modified Files:


src/conio/win32gdi.c
diff

Fix the typo, fix the pipes.

Modified Files:


src/conio/x_events.c
diff

Move call to bitmap_drv_free_rect() out of vstatlock

Modified Files:


src/conio/sdl_con.c
diff

src/conio/win32gdi.c
diff

src/conio/x_events.c
diff

If ciolib_initial_scaling is less than 1.0, interpret as multiplier

For example, if it was set to 0.4, the initial scaling would be set
to take at most 40% of the screen height or width (whichever is
smaller) with a minimum of 1.0

Modified Files:


docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

SlyEdit: Improved quoting (formatting) for the various quote prefixes (using a
> character)

Modified Files:


docs/slyedit_readme.txt
diff

exec/SlyEdit.js
diff

exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_quote_improvement' into 'master'

SlyEdit: Improved quoting (formatting) for the various quote prefixes (using a
> character)

See merge request main/sbbs!302

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Removed Files:


xtrn/ddfilelister.js
diff

DD File Area Chooser fix for directory collapsing mode when using the lightbar
interface.

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Removed Files:


xtrn/ddfilelister.js
diff

Merge branch 'dd_file_area_chooser_dir_collapsing_lightbar_loop_fix' into
'master'

DD File Area Chooser fix for directory collapsing mode when using the lightbar
interface.

See merge request main/sbbs!301

Modified Files:


src/conio/utf8_codepages.c
diff

Fix ATASCII harder.

There's a few ASCII control codes that need to be translated, so
add a new mapping function that tries the map first, then returns
ASCII on failure to map.

Modified Files:


src/conio/utf8_codepages.c
diff

The unicode->ATASCII table is not a fulltable.

Fixes inability to use ATASCII in curses mode.

Modified Files:


src/conio/x_events.c
diff

Fix CTRL + CAPS issue in X11

Previously, both the shift key, and the "implied shift" from CAPS
were treated as a higher priority than the CTRL modifier.  With
this change, only the explicit shift key has priority, and the
implicit one is only checked after CTRL is checked.

Fixes SourceForge bug 117

Modified Files:


src/conio/bitmap_con.c
diff

Fix non-integer scaling corruption when r2y is NULL

Modified Files:


exec/login.js
diff

Enable "use strict" mode in this script - best practice

Requires hex literals for control chars instead of octal
(e.g. \x01 instead of \1)

All stock scripts should be using strict mode, so this was a miss.

Modified Files:


src/sbbs3/js_socket.c
diff

Manual revert of the ListeningSocket contructor "fix" which wasn't necessary

I keep reverting/un-reverting the merge that includes an unrelated logon.cpp
change. So just manually remove this new code that was added to attempt to
fix issue #402 since I incorrectly concluded that sockopts.ini wasn't being
applied to new sockets created with ListeningSocket().

Modified Files:


src/sbbs3/js_socket.c
diff

Revert "Revert "Apply socket options from sockopts.ini to sockets created by
ListeningSocket()""

This reverts commit 7ff687ff15f690410daa0bdbe2ecc468ea1b4a41.

We're already passing a sock_init callback (ls_cb) which is supposed to set
the socket options (call set_socket_options), so this change shouldn't be
necessary and reportedly caused more issues binding ircd sockets when running
ircd.js via jsexec (though I didn't see this myself).

Modified Files:


src/sbbs3/js_socket.c
diff

Revert "Apply socket options from sockopts.ini to sockets created by
ListeningSocket()"

This reverts commit 52d9a03d372792616091e4c66b28d98d711d3b29.

Modified Files:


src/sbbs3/logon.cpp
diff

Revert "Revert "Log an error if getstats() returns a failure""

This reverts commit e12c35049251dc97e8eafd7c7fc12dfd9ba13ad9.

Wrong commit reverted. Oops.

Modified Files:


src/sbbs3/logon.cpp
diff

Revert "Log an error if getstats() returns a failure"

This reverts commit 8266da9c329d2ba49ff2001cf542a0d05dc9987e.

We're already passing a sock_init callback (ls_cb) which is supposed to set
the socket options (call set_socket_options), so this change shouldn't be
necessary and reportedly caused more issues binding ircd sockets when running
ircd.js via jsexec (though I didn't see this myself).

Modified Files:


src/sbbs3/js_socket.c
diff

Apply socket options from sockopts.ini to sockets created by ListeningSocket()

This socket constructor did not get the global socket options treatment when
created (years ago).

This should fix issue #402 as reported by Nelgin and more recently by Keyop.

Modified Files:


src/sbbs3/logon.cpp
diff

Log an error if getstats() returns a failure

I saw my logon.jsonl file getting cycled multiple times a day recently on Vert
and suspect this function call may have been failing.

Added Files:


xtrn/dd_arc_viewer/dd_arc_viewer.cfg
diff

xtrn/dd_arc_viewer/dd_arc_viewer.js
diff

xtrn/dd_arc_viewer/dd_arc_viewer_cleanup.js
diff

xtrn/dd_arc_viewer/dd_arc_viewer_file_types.cfg
diff

xtrn/dd_arc_viewer/readme.txt
diff

xtrn/dd_arc_viewer/revision_history.txt
diff

xtrn/dd_arc_viewer/updating_from_previous_versions.txt
diff

Removed Files:


xtrn/DDArchiveViewer/DDArcViewer.js
diff

xtrn/DDArchiveViewer/DDArcViewerCleanup.js
diff

xtrn/DDArchiveViewer/DDArcViewerFileTypes.cfg
diff

DD Archive Viewer now supports the built-in Archive class in Synchronet 3.19

Added Files:


xtrn/dd_arc_viewer/dd_arc_viewer.cfg
diff

xtrn/dd_arc_viewer/dd_arc_viewer.js
diff

xtrn/dd_arc_viewer/dd_arc_viewer_cleanup.js
diff

xtrn/dd_arc_viewer/dd_arc_viewer_file_types.cfg
diff

xtrn/dd_arc_viewer/readme.txt
diff

xtrn/dd_arc_viewer/revision_history.txt
diff

xtrn/dd_arc_viewer/updating_from_previous_versions.txt
diff

Removed Files:


xtrn/DDArchiveViewer/DDArcViewer.js
diff

xtrn/DDArchiveViewer/DDArcViewerCleanup.js
diff

xtrn/DDArchiveViewer/DDArcViewerFileTypes.cfg
diff

Merge branch 'dd_archive_viewer_archive_class_update' into 'master'

DD Archive Viewer now supports the built-in Archive class in Synchronet 3.19

See merge request main/sbbs!299

Modified Files:


src/sbbs3/js_internal.c
diff

Fix js.exec() error message when specified script can't be found

If the search up the scope tree for js.exec_dir fails, the script 'path' would
be left blank leading to a weird error message.
e.g. !JavaScript default.js line 249: Error: Script file () does not exist

Modified Files:


exec/default.js
diff

js.exec() expects a full path to the script, normally

There's a weird issue where the scope-walk to find a "js.exec_dir" isn't
working (for Nick Young or Nightfox) after invoking DDMsgReader. This should
fix (or work around) that issue.

And js.exec() doesn't search the mods_dir first when a full script path isn't
passed, so with this change, child scripts that are in the mods_dir should now
work as a sysop would expect.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Always delete the AREASxxxxxx temp file

When there are no changes (areas added or removed) via an areafix message, the
data/AREASxxxxxx temp file would be left behind. The file was only removed if
areas were added or removed from the area file via areafix message.

The orphaned data/AREASxxxxxxx files were reported via DOVE-Net by Gamgee
(PALANTIR)
If you have these stale files, you can safely delete them.

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

DDMsgAreaChooser fix for exiting immediately if the first message group has no
sub-boards. Fixes #589

Modified Files:


xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

Merge branch 'dd_msg_area_chooser_no_sub_boards_update' into 'master'

DDMsgAreaChooser fix for exiting immediately if the first message group has no
sub-boards. Fixes #589

Closes #589

See merge request main/sbbs!298

Modified Files:


src/sbbs3/targets.mk
diff

Don't use ln -r (relative) option for 'symlinks' build target

As reported by Pasta68K:
FreeBSD's ln doesn't support -r

ln -sfr clang.freebsd..exe.release/* /sbbs/exec
ln: illegal option -- r

So use realpath instead. Hopefully all the targeted *nix platforms include
'realpath'.

Modified Files:


src/sbbs3/chksmb.c
diff

Only truncate ".anything" from supplied msgbase path if it's ".shd"

Make behavior consistent with smbutil and fixmsb.

Modified Files:


src/sbbs3/jsexec.c
diff

Resource cleanup on exit (when no module specified)

Eliminates a SANITIZE build error

Modified Files:


exec/ircd.js
diff

exec/load/ircd/core.js
diff

Increment IRCd version to 1.10

Hopefully Cyan agrees that 1.10 was the logical next version number.
Hopefully these are the only 2 places where the version is duplicated.

Modified Files:


exec/load/ircd/core.js
diff

DNSBL-exempt localhost (127.*) and private network (10.*, 192.168.*) addresses

Someone should add IPv6 exempted addresses too

Maybe perform a check against ctrl/dnsbl_exempt.cfg too?

Modified Files:


exec/load/ircd/unregistered.js
diff

Log the socket descriptor that's being closed *before* calling Socket.close()

Socket.close() always sets the descriptor to -1 which is/would be logged here
as an unsigned int (%u) or 4294967295.

If this continues to log 4294967295, then a check of descriptor >= 0 would be
prudent.

And as Cyan said:
<Cyan> the IP would be more useful though

Modified Files:


exec/load/ircd/core.js
diff

Clean-up the DNSBL checking function a little bit and its call site.

Always log (a notice-level log message) when there's a DNSBL match, along with
the address it actually resolved to (indicates which list the IP address was
found in).
No log message otherwise.

Note: resolve_ip() doesn't actually support IPv6 yet, so I don't think this
IPv6 address parsing/reformatting logic has actually been tested.

Modified Files:


exec/load/ircd/core.js
diff

Added RBL lookups on connection via DroneDL.

Modified Files:


exec/load/ircd/core.js
diff

Merge branch 'add_rbl_to_ircd' into 'master'

Added RBL lookups on connection via DroneDL.

See merge request main/sbbs!297

Modified Files:


src/sbbs3/js_global.c
diff

Update JSDOCS for resolve_ip and resolve_host: returns null on failure

Modified Files:


exec/load/ircd/server.js
diff

Fix server.js line 306: TypeError: p[2] is undefined

JavaScript is lovely at data validation ... not!

Modified Files:


exec/load/ircd/server.js
diff

Synchronet IRC services uses RAKILL to remove any previouslly

Modified Files:


exec/load/ircd/server.js
diff

Merge branch 'add_rakill_to_ircd' into 'master'

Synchronet IRC services uses RAKILL to remove any previouslly

See merge request main/sbbs!296

Modified Files:


src/conio/x_events.c
diff

Ensure we get at least one item before passing to the callback

Should fix ASan "crash".

Modified Files:


src/conio/scale.c
diff

UBSan claims this is undefined behaviour...

I don't believe them, but I'll fix it anyway.

Modified Files:


src/conio/x_events.c
diff

Revert "Fix crash in net_wm_state_is_cb when running GCC ASan-enabled build"

This reverts commit 0a6fdb956890d029bfdb230f3fec17110690a471.

This simply caused the callback to never be called.

Modified Files:


src/syncterm/ooii.c
diff

Fix GCC warning: ‘fptr’ may be used uninitialized in this function

This does look like a false positive to me: the if clauses that use fptr appear
to only cover the same values as the switch-case statements. But harmless
defensive change here.

Modified Files:


src/syncterm/bbslist.c
diff

Fix missing NULL terminator for rip_versions string list

Caught be GCC ASan.

Modified Files:


src/conio/x_events.c
diff

Fix crash in net_wm_state_is_cb when running GCC ASan-enabled build

Check size of X11 property before dereferencing as an Atom.
This fixes:
==10203==ERROR: AddressSanitizer: heap-buffer-overflow on address
0x602000065970 at pc 0x5c5834fb8812 bp 0x7819c717c220 sp 0x7819c717c218
READ of size 8 at 0x602000065970 thread T2 (X11 Events)
    #0 0x5c5834fb8811 in net_wm_state_is_cb ../conio/x_events.c:1541

But I'm not clear when nitems_return (nir) might represent > 8-bit items or how
to detect that, so perhaps there's a *better* fix?

Modified Files:


xtrn/hamtest/Technician.js
diff

Updated Tech question pool. Now valid until 6/30/2026

Modified Files:


xtrn/hamtest/Technician.js
diff

Merge branch 'master' into 'master'

Updated Tech question pool. Now valid until 6/30/2026

See merge request main/sbbs!295

Modified Files:


src/sbbs3/ans2asc.c
diff

Fix GCC warning

warning: format not a string literal and no format arguments
[-Wformat-security]
<nelgin> gcc version 9.4.0

Modified Files:


src/conio/cterm.c
diff

Fix for 80379e916

The commit just the zero-length behaviour from uninitialized use
with possible undefined behaviour to guaranteed undefined behaviour.

Modified Files:


src/conio/x_events.c
diff

Remove stale code from net_wm_state_is_cb()

It's unlikely this is what Digitalman reported from ASan and UBSan

Modified Files:


src/conio/ansi_cio.c
diff

src/conio/ciolib.c
diff

src/conio/cterm.c
diff

src/conio/curs_cio.c
diff

src/conio/mouse.c
diff

src/conio/x_cio.c
diff

Clean-up comment header blocks, no code changes

This was really just a test to make sure I had Geany successfully reconfigured
to no longer auto-strip trailing whitespace. Spoiler: It wasn't.

Modified Files:


src/conio/cterm.c
diff

Fix warning: ‘end’ may be used uninitialized in this function

Fix multiple warning: ignoring return value of ‘asprintf’
    declared with attribute ‘warn_unused_result’

Modified Files:


src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Create get_socket_errno() to replace ERROR_VALUE macro eventually

Modified Files:


src/sbbs3/pktdump.c
diff

Fix: wasn't parsing origin point from type 2.2 packet headers

As Deon pointed out on DOVE-Net::Synchronet Discussion. Thanks!

Modified Files:


src/sbbs3/sbbs.h
diff

Thread-safe wrappers for std/socket errno description getters for sbbs_t

These should only be used in the sbbs_t methods called by node_thread or
event_thread. Any other thread-shared sbbs_t instances should not use these
methods since they share a single error description string buffer.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/jsexec.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.c
diff

src/xpdev/genwrap.h
diff

Eliminate STRERROR macro

This macro hasn't done anything meaningful since we stopped using really old
versions of Borland compilers (and std libraries) where strerror() returned a
string terminated with a line-feed (\n) character.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix type 2.2 packet header generation

As reported by Deon on DOVE-Net: type 2.2 packet generation was not (since
SBBSecho v3.0) setting the origin and destination point values correctly:
was leaving the packet type 2.0 date values in these fields.

Also, zero-out the reserved bytes in the type 2.2 packet header (don't leave
the type 2.0 date values in there).

Thanks for the report Deon!

Modified Files:


src/sbbs3/wordwrap.c
diff

Sanity-check the oldlen argument value to wordwrap()

If the oldlen param value is less than one, set to a sane non-zero value (79).
Fix issue #576

Modified Files:


src/build/Common.gmake
diff

Include -fno-omit-frame-pointer when usinag ASan and UBSan

this is recommended to reliably display the call stack when using the
print_stacktrace option.

Modified Files:


src/conio/bitmap_con.c
diff

Fix GCC UBSan (SANITIZE=1 build) runtime error

left shift of 255 by 24 places cannot be represented in type 'int'

Modified Files:


src/sbbs3/ans2asc.c
diff

Add -esc option for C-literal escaping/encoding of output (e.g. for JS/.ini)

<phigz> what would you convert ansi to so it displays right when written out
from a .js file?

Now, you can use 'ans2asc -esc' for this purpose.

Modified Files:


src/cleanall.sh
diff

Support running this script from other directories

e.g. running '../cleanall.sh' from the src/sbbs3 dir

Modified Files:


src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

Resolve warnings about ignored return values

As reported by GCC 10.2 with FORTIFY=1 and SANITIZE=1

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix typo (missing paren) in node util build rule

Not sure how I missed this before <shrug>

Modified Files:


src/sbbs3/node.vcxproj
diff

Add dependencies for building with str_util.c, for strip_ctrl() support

This should fix the SBBS-MSVC build in CI.

Modified Files:


ctrl/text.dat
diff

Add InactivityAlert, clear out NodeActionMultiChat

The InactivityAlert string is sent as a warning before disconnect when a
visible alert (AreYouThere) shouldn't be sent. Defaults to 3 beeps.

Remove the content of the NodeActionMultiChat (over-rides the hard-coded
default node status) - weird that this was the only node status that reported
the user's security level in the default configuration. This has been this
way since sbbs v2.30, at least. I think it was to be sure that others could
see the age/gender of those they were chatting with. But we have other methods
of reporting that in node status now, so we don't need to use this override
string to accomplish that.

Modified Files:


src/sbbs3/GNUmakefile
diff

src/sbbs3/node.c
diff

src/sbbs3/objects.mk
diff

Strip control characters/sequences from custom node status strings

This utility doesn't expand Ctrl-A codes, so just strip them.

Modified Files:


src/conio/x_events.c
diff

Revert "Use XDG_ENVIRONMENT_TYPE to switch to CLIPBOARD"

This reverts commit e61a1aa6c7b27242fc1d03401b4240c6f58ac311.

It turns out neither platform this targeted actually set that
variable correctly.

Modified Files:


src/conio/x_events.c
diff

Use XDG_ENVIRONMENT_TYPE to switch to CLIPBOARD

It appears that XDG_ENVIRONMENT_TYPE will always equal "wayland"
when XWayland is in use, so when we see that, switch to CLIPBOARD
instead of PRIMARY.  This should fix WSL and ChromeOS, and be
irritating on GNOME, so it's a win all around.

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Fix: File Areas... Clone Settings was always cloning settings to first library

The directories of the *first* library was always the target of the (new)
"Clone Settings" option. We're using a dir_t for each lib's dir_defaults, but
that doesn't mean the dir_defaults.lib is initialized to a correct libnum
(it's not), so don't use it.

Modified Files:


src/conio/x_events.c
diff

Actually, don't bother returning a value that's never used.

Still be sure to check the return value of write() though.

Modified Files:


src/conio/x_events.c
diff

Actually, this is a blocking write, just compare with -1

Modified Files:


src/conio/x_events.c
diff

Make x11_event() a bool

Modified Files:


src/conio/x_events.c
diff

Fix GCC v10.2 warnings about ignored return values of 'write'

The return value of x11_event() isn't actually checked anywhere currently, but
still Deuce might want to adjust the new return value here (__LINE__ or -1?).

Some indicental trailing whitespace was auto-cleaned up part of this commit.
Unexpected as I thought this code had been uncrustified already.

Modified Files:


src/sbbs3/sbbscon.c
diff

This is exactly the sort of race condition pthread_once() is for.

Modified Files:


src/sbbs3/sbbscon.c
diff

More consistent logging of errno value (and descriptions)

Should use safe_strerror() here instead... later.

Modified Files:


src/conio/x_events.c
diff

Don't require caller to call textmode() before showing window

Fixes recent regression with scfg

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Fix GCC build errors with SANITIZE=1

scfgsys.c: In function ‘edit_sys_delmsg_policy’:
scfgsys.c:498:3: error: case label does not reduce to an integer constant
  498 |   case SM_USRVDELM | SM_SYSVDELM:
scfgsys.c:504:3: error: case label does not reduce to an integer constant
  504 |   case SM_SYSVDELM:

Modified Files:


src/sbbs3/scfg/targets.mk
diff

Fix *nix clean buld from this directory

the hash lib dependency was missing

Modified Files:


src/uifc/uifcx.c
diff

Fix GCC warning: ignoring return value of ‘vasprintf’

... declared with attribute ‘warn_unused_result’

Modified Files:


src/sbbs3/ars.c
diff

Fix unaligned memory accesses as reported by ASan

e.g. runtime error: store to misaligned address 0x7ffec33195e3 for type
'short int', which requires 2 byte alignment

These aren't a problem for x86, but could be a problem for some other CPU
architectures that don't support unaligned access. I didn't use memcpy() to
resolve this (though that would've worked) to make this change endian agnostic.

Modified Files:


src/sbbs3/jsexec.c
diff

Fix (harmless) memory leak reported by ASan when running 'jsexec -?'

Modified Files:


src/xpdev/filewrap.h
diff

Fix runtime errors when built with UBSan

nopen.c:37:15: runtime error: left shift of 1 by 31 places cannot be
 represented in type 'int'
nopen.c:39:18: runtime error: left shift of 1 by 31 places cannot be
 represented in type 'int'
userdat.c:251:111: runtime error: left shift of 1 by 31 places cannot be
 represented in type 'int'

There are lot of 1<<31 macro definitions in this repo, so I'm expecting a
lot more of this type of fix to be required to make UBSan happy.

Modified Files:


src/conio/x_events.c
diff

src/syncterm/term.c
diff

Fix some more Coverity "issues".

Modified Files:


src/sbbs3/download.cpp
diff

A little more paranoia around passed dirnum (could be negative)

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/js_user.c
diff

More use of is_valid_sub|dirnum()

No obvious bug fixes here, just future proofing.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/win32gdi.c
diff

src/conio/x_events.c
diff

Fix issue with bitmap_drv_init_mode()

Because bitmap_get_scaled_win_size() was being clamped to maxsize,
no matter how much mult was incremented, w and h would never be
larger than maxwidth/maxheight and only under exceptional
circumstances would the be equal, which would result in an infinite
loop.

While we're here, set the integer scaling value so we're not chasing
ulps all over the place with floating point math/scaling when we
don't need to.

Modified Files:


src/conio/bitmap_con.c
diff

src/syncterm/fonts.c
diff

src/syncterm/ripper.c
diff

"Fix" some completely inane Coverity issues.

None of these were even theoretically possible on any platform, but
I took the opportunity to add bounds checking to bitmap_puttext(),
so that's good I guess.

Modified Files:


src/conio/cterm.c
diff

Add comments to hopefully shut up Coverity

Modified Files:


src/syncterm/conn.c
diff

src/syncterm/ssh.c
diff

src/syncterm/telnets.c
diff

src/syncterm/term.c
diff

Some more Coverity shutupness

Modified Files:


src/conio/cterm.c
diff

src/conio/sdl_con.c
diff

src/conio/x_events.c
diff

Fix more Coverity "Issues"

Add some malloc() return checks, comment fall-throughs, and resolve
a sleep while holding lock.

None of these should actually matter, so hopefully I didn't add a
new bug.

Modified Files:


src/conio/x_cio.c
diff

Fix incorrect variable usage found by Coverity

Modified Files:


src/conio/cterm.h
diff

Add stdbool.h to cterm.h

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Add "Yellow Is Yellow" option.

This allows the ANSI yellow colour to be yellow instead of the
brown used in IBM CGA monitors.

Modified Files:


src/syncterm/bbslist.c
diff

Add missing break.

Modified Files:


src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/conio/cterm.txt
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/ripper.c
diff

src/syncterm/term.c
diff

Add changes to support Saskatoon Amiga Users Group BBS.

- Support LCF (Last Column Flag) mode per DEC STD-070
  (Despite years of protest that it's stupid)
- "Properly" support CSI 7 m and CSI 27 m
  Now, when in "Negative Image" mode, changes to the foreground
  change how the background is drawn and vice-versa.  Perviously
  this command just swapped the two values and called it good.

Modified Files:


src/sbbs3/execmisc.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/writemsg.cpp
diff

Address new GCC (10.2) warnings from previous commit

Adding and removing typecasts and changing some types (of ints).

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/cmdshell.h
diff

src/sbbs3/data_ovl.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/execnet.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_msg_area.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/js_xtrn_area.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msg_id.h
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/smblib/smbdefs.h
diff

<Deuce> ... billion-and-one result of comparison of constant 100000 warnings.

So Clang-FreeBSD was warning (in compiles of scfg/scfg*.c by Deuce):
result of comparison of constant 100000 with expression of type 'uint16_t'
(aka 'unsigned short') is always true

Why? Cause a uint16_t's max value is 65535 (less than 100000). Sure we could
have just lowered the UIFC max number of config items to 65535, but that would
have been too easy. And why are these compared-with values of type uint16_t to
begin with? Because most ctrl/*.cnf lists (of configuration items) were
limited to 65535 entries cause ... 16-bit DOS, historically. Now that *.cnf
files aren't used, we could just increase these scfg_t.*_total type sizes from
16 to 32-bits, yeah? The result is this commit.

I went to (signed) int so we could still keep -1 as the special illegal
sub/dir num value (e.g. INVALID_SUB, which is sometimes used to indicate the
email message base). Theoretically, 2 billion configuration items could be
supported in these lists, but SCFG will limit you to 100000 anyway. So there's
a whole lot of s/uint/int in this commit.

I'd be very surprised if this doesn't result in some new GCC/Clang warnings,
but at least the old "comparison of constant 100000" warnings are now gone!

Modified Files:


src/conio/utf8_codepages.c
diff

src/syncterm/term.c
diff

More ATASCII improvements

Fix bad and poor unicode mappings, add support for sending Insert
and Pipe.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/term.c
diff

src/syncterm/window.c
diff

Support inverse mode in atascii

Toggled using backtick.
Current state is shown in the status bar.

Since we previously couldn't actually *show* the status bar in
ATASCII (or C64) mode, enable that as well.  This means supporting
40-column status bars too.

We still default status bar to off for those modes, because that's
likely what people actually want.

Also, it seems ENTER was broken in ATASCII mode, so fix that as well.
Implements SF feature 61

Modified Files:


src/conio/x_events.c
diff

Missed a 'C' in ICCCM

Modified Files:


src/conio/x_events.c
diff

Attempt to set resource name/class correctly for XIM

Modified Files:


src/conio/ciolib.c
diff

src/conio/x_cio.c
diff

src/conio/x_cio.h
diff

src/conio/x_events.c
diff

src/conio/x_events.h
diff

More work on X11 fullscreen mode.

Save the window position and size when we enter fullscreen, and
restore when we leave... this was a bigger box of worms than
expected since we can get ConfigureNotify events that tell is
"Something" changed, but not be able to know the current window
position.

Just remove the x_get_window_info() and anything else that cares
about the window position and derive it from the ALT-Enter keypress
instead.

At the same time, try to remove as much special-casing for
fullscreen as possible.

Tested under marco and xfwm4... will test under Sommelier "soon"

Modified Files:


xtrn/tw2/players.js
diff

=== is best ==

Modified Files:


xtrn/tw2/players.js
diff

Don't try to delete undefined Player objects

May fix #564, may not, nobody knows.

Modified Files:


src/conio/x_cio.c
diff

src/conio/x_events.c
diff

src/conio/x_events.h
diff

Fixes after testing on marco

Don't always start with _NET_WM_STATE containing
_NET_WM_STATE_FULLSCREEN

Enable PropertyChange events

Adjust x_cvstat.win* when _NET_WM_STATE gets
_NET_WM_STATE_FULLSCREEN added

Don't disable fullscreen in ConfigureNotify handler when
fullscreen is still pending

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/sdl_con.c
diff

Work around marco or SDL bug in SDL_SetWindowMinimumSize()

When using the marco WM, and resizing using ALT-Right-drag, calls to
SDL_SetWindowMinimumSize() result in the top-left corner of the
window moving up and to the left (appears to be by the border size).

To prevent this from being a maddening issue under marco, ensure
we only call SDL_SetWindowMinimumSize() once when the minimum size
changes on the window.

Fixes SF ticket 115, thanks Ragnarok!

While we're hear, ensure the minimium maximum window size holds
the original sized window... we're not interested in downscaling.

Modified Files:


.gitlab-ci.yml
diff

No aarch64 sbbs build

Now that I've upgraded my RPi 400 to aarch64, it turns out aarch64
isn't supported by Spidermoney or the libffi it ships with, so
there's no easy way to make it build.

Untill Spidermonkey is updated, there's just no reasonable way to
build on aarch64.

Modified Files:


src/conio/x_events.c
diff

Some minor fixups...

On expose, always redraw the entire screen.  The calculations were
wrong and with fractional scaling, some of them will always be wrong.

Don't clear the screen when xim is resized.

Modified Files:


src/sbbs3/GNUmakefile
diff

mqtt_protocol.h was added to Debian package in 1.6.8-2, require 1.6.9+

Modified Files:


src/sbbs3/GNUmakefile
diff

It appears Synchronet requires libmosquitto v2 or higher

Modified Files:


3rdp/build/GNUmakefile
diff

3rdp/build/js-makefile.patch
diff

Ah, found the problem...

It looks like "armv7l" didn't exist when this version of Spidermoney
was released.  Just expand a previous patch to include all arm*
architectures.

Modified Files:


3rdp/build/GNUmakefile
diff

Ah right, $(machine) has the OS name in it.

Modified Files:


3rdp/build/GNUmakefile
diff

l

Modified Files:


3rdp/build/GNUmakefile
diff

Disable traceJIT on Raspberry PI

Modified Files:


src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/conio/win32gdi.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

Add fullscreen GDI startup mode.

Modified Files:


src/conio/win32gdi.c
diff

Remove some obsolete comments

Modified Files:


.gitlab-ci.yml
diff

Add the rest of the targets for RaspberryPi

Modified Files:


src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/conio/win32gdi.c
diff

src/conio/x_cio.c
diff

src/conio/x_cio.h
diff

src/conio/x_events.c
diff

src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

Add support for starting X11 mode fullscreen.

Modified Files:


.gitlab-ci.yml
diff

Add raspbian built for SyncTERM

Modified Files:


src/conio/genmap.c
diff

ARMv7 doesn't support @progbits, try %progbits

Modified Files:


src/sbbs3/ssl.c
diff

Fix error in previous commit to this file

C allows char* p = '\0' (which is clearly wrong)
C++ does not.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Fix reported Clang warnings about printf format strings

format specifies type 'unsigned short' but the argument has type 'unsigned int'

Modified Files:


src/build/Common.gmake
diff

Document the new FORTIFY and SANITIZE options

Modified Files:


src/sbbs3/pktdump.c
diff

Typecast to resolve MSVC error C4146:

"unary minus operator applied to unsigned type, result still unsigned"

Even though this same code compiled and worked as expected with GCC.

Modified Files:


src/build/Common.gmake
diff

Add FORTIFY and SANITIZE options for DEBUG builds

SANITIZE is not fully supported (or recommended) yet.

FORTIFY will include some performance hits, but those might be offset by -O1
(which is apparently required for _FORTIFY_SOURCE to have any effect).
Prevviosly, DEBUG builds used (implicit -O0).
I'm building and running sbbs on Vertrauen (git.synchro.net) now with FORTIFY.

Set FORTIFY=1 in your localdefs.mk if you wish to have this build option
enabled persistently.

Modified Files:


.gitlab-ci.yml
diff

Add a noskeeters build for FreeBSD.

Modified Files:


src/sbbs3/GNUmakefile
diff

Add support for WITHOUT_MOSQUITTO

I'm doing builds for my jail (which doesn't have libmosquitto) on
my system that does have it now, so I need to disable it manually.

Modified Files:


src/xpdev/xp_syslog.c
diff

Give this copy/pasted resolve_ip() the same fixes as main.cpp and mailsrvr.c

Don't deref a null pointer and return an in_addr_t instead of ulong.

Modified Files:


src/syncterm/rlogin.c
diff

Fix warning: ‘ret’ may be used uninitialized

Modified Files:


src/syncterm/term.c
diff

Fix GCC v12.2.0 -O1 warnings

warning: ‘maxval’ may be used uninitialized
warning: ‘inch’ may be used uninitialized

Modified Files:


src/sexpots/sexpots.c
diff

Fixup the copy-pasted resolve_ip() with same fixes from main.cpp/mailsrvr.c

Don't null-deref h_addr_list.
Return in_addr_t instead of u_long.

Modified Files:


src/sbbs3/addfiles.c
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/fixsmb.c
diff

src/sbbs3/fmsgdump.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

src/sbbs3/pktdump.c
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/services.c
diff

src/sbbs3/ssl.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/umonitor/chat.c
diff

src/sbbs3/umonitor/spyon.c
diff

src/sbbs3/umonitor/umonitor.c
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/sbbs3/zmodem.c
diff

src/uifc/uifc32.c
diff

src/xpdev/genwrap.c
diff

src/xpdev/xpmap.c
diff

src/xpdev/xpprintf.c
diff

Fix warnings exposed by GCC -D_FORTIFY_SOURCE=3 -O1

Mostly (all?) about unchecked return values. Unexpected failures to read or
write some files could've definitely led to some weird bugs.

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/cterm.c
diff

src/conio/genmap.c
diff

src/conio/x_cio.c
diff

src/conio/x_events.c
diff

Snoop through Coverity issues and fix the easy/important ones

Modified Files:


src/conio/x_events.c
diff

Fix black bar generation

Was wrong and therefore causing flickering.

Modified Files:


src/conio/x_events.c
diff

Fix fullscreen external scaled X11 mode

Was not using struts, and was scaling to window size, not aspect
ratio size.

Modified Files:


src/conio/win32gdi.c
diff

Store window position when going fullscreen.

Also, reset struts when not in fullscreen mode.

Modified Files:


src/conio/win32gdi.c
diff

Add support for fullscreen in GDI mode.

GDI and X11 still can't be *started* in fullscreen mode though.

Modified Files:


src/conio/bitmap_con.c
diff

Fix GDI brakage in frameskipping.

Win32GDI currently requires two rects to be available.

Modified Files:


src/conio/bitmap_con.h
diff

More stdbool.h

Modified Files:


src/conio/x_events.c
diff

Fix wildly incorrect usage of set_win_property().

Modified Files:


src/conio/x_events.c
diff

Fix some highly unlikely memory leaks

- Ensure last is cleared even if we manage external scaling without Xrender
- Free the bitmap rectangle in the same situation
- Make a copy of x_internal_scaling so it's used consistently
  (not mutex protected, and accessed from multiple threads)

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/bitmap_con.h
diff

Implement basic frameskipping in bitmap driver

If there's already an outstanding rectangle when the blinker thread
wants to send another one, skip it.

This keeps the interface responsive at the cost of some skipped
frames.

Modified Files:


src/conio/x_events.c
diff

For Sommelier (ie: ChromeOS), use CLIPBOARD not PRIMARY

ChromeOS (as of Jun 2023) effectivly makes PRIMARY useless.  Just
do the wrong thing and use CLIPBOARD instead.  This makes it much
more likely that SyncTERM selections will clobber CLIPBOARD
unintentionally, but we have no choice... DigitalMan doesn't use
X11 mode solely because ChromeOS sucks at X11.

Modified Files:


src/conio/x_events.c
diff

src/conio/x_events.h
diff

src/syncterm/syncterm.c
diff

More rabidly comply with ICCM and EWMH

While we're hacking on that, make a first attempt at a generic
Atom access framework.

The only actual visible change that should occur here is that the
window will not resize larger than will fit on the current desktop
between various WM widgets (panels and menus).  I've been considering
this change for a while, but now that fullscreen support is present,
it doesn't really take anything away.

Modified Files:


src/conio/x_cio.c
diff

src/conio/x_events.c
diff

src/conio/x_events.h
diff

Add X11 fullscreen and do a bunch of other fixes

Just use _NET_WM_STATE protocol for fullscreen... messing around
with the methods is pretty painful.

Because we're not messing with other stuff, we can likely remove
all the code I added to prepare for this. :D

Testing this really highlighted other broken bits, so a bunch of
that has been fixed as well... including the bug that Ragnorok
hadn't reported yet as of last time I looked (corrupted screen when
maximixed).

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

Why are resolve_ip() and rblchk() returning the (sometimes 64-bit) ulong?

Or even weirder, u_long?

And dereffing a ulong/u_long pointer where you expect to find an IPv4 address?
Yet even weirder still.

Fix that spit: It appears in_addr_t is defined on all platforms (?), so use
that type instead.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

Fix more potential null-ptr-derefs in use of gethostbyname()

No known sightings of these sites actually being the location of a segfault,
but as we learned from the segfaults in rblchk(), the first entry in the
h_addr_list can be NULL in some cases.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Check return value of fread()

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix potential NULL pointer deref in rblchk(), observed via segfault lately

I'm not sure why this one only started popping up now, but h_addr_list is a
NULL-terminated list and it makes perfect sense that the first entry could
be the NULL-terminator.

gethostbyname is obsolete/deprecated and we should address that in a separate
commit.

Modified Files:


src/conio/x_events.c
diff

More fullscreen work, get resize working

Modified Files:


src/conio/win32cio.c
diff

Fix warning C4101: 'i': unreferenced local variable

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/readsauce.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/wordwrap.c
diff

src/sbbs3/xmodem.c
diff

Fix warnings raised by gcc -D_FORTIFY_SOURCE=3 -O1

A bunch of possible (but often, not really) use of undefined values.
Some ignored return values (e.g. of chsize/ftruncate, read, write, fgets).

Other than some added diagnostics upon some of these unexpected syscall
failures, there should be no change in behavior from this commit.

Modified Files:


src/conio/Common.gmake
diff

src/conio/x_cio.c
diff

src/conio/x_events.c
diff

src/conio/x_events.h
diff

Start laying the groundwork for X11 fullscreen mode.

This is the last feature that SDL mode provides that X11 mode is
lacking.  I rarely use it myself, but it should be there.

Modified Files:


src/sbbs3/GNUmakefile
diff

<Deuce> Oh yeah, you need that in an ifneq ($(os),win32)

Modified Files:


src/sbbs3/useredit.cpp
diff

Hitting Ctrl-C at the "Use external editor" prompt shouldn't change anything

Modified Files:


src/sbbs3/GNUmakefile
diff

Use pkg-config for detectiong libmosquitto presence and lib name

Apparently the mosquitto.h won't always be installed in /usr/include on
all systems (e.g. Deuce's FreeBSD gitlab-runner system)

Modified Files:


src/conio/x_events.c
diff

Increment offset in the loop when reading _NET_WORKAREA

Previously, if there was more than one work area, this would be
an infinite loop, re-reading the first workarea repeatedly.

Reported by Ragnarok (thanks!)

Modified Files:


src/conio/sdl_con.c
diff

When switching from fullscreen mode, recalculate win size.

Modified Files:


.gitlab-ci.yml
diff

Fix some pipes.

Modified Files:


src/conio/x_events.c
diff

Fix typo in line 666

Modified Files:


src/syncterm/syncterm.man.in
diff

Quick pass through the manpage

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/x_events.c
diff

Fix SF tickets 113 and maybe 111

Fix infinite loop in bitmap_drv_init_mode() if scaling results in
larger than max size.

This uncovered an issue in resize_window() which would cause the
screen to be corrupted due to vstat not agreeing to the actual window.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/syncterm.man.in
diff

Mention -b and -n.