Synchronet CVS Commit Log

This is a log of the 500 most recent changes in the Synchronet CVS repository.
  1. nightfox
    Thu Apr 19 2018 10:36 am PDT

    Modified Files:
    text/avatars/DIGDIST.startrek.bin 1.1 1.2 diff

    Log Message:
    Used some brigher colors in some of the avatars.  This collection is still a work in progress..
  2. rswindell
    Wed Apr 18 2018 10:47 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.39 1.40 diff

    Log Message:
    Lower the log level of "BADDATA" cryptlib errors (-32) from ERROR to
    WARNING.
    Also fixed a couple of typos in strings.
  3. deuce
    Tue Apr 17 2018 11:51 pm PDT

    Modified Files:
    src/syncterm/menu.c 1.60 1.61 diff
    src/syncterm/term.c 1.337 1.338 diff
    src/syncterm/uifcinit.c 1.38 1.39 diff

    Log Message:
    Now that save/restorescreen() do font stuff too, we can just go ahead and
    switch to CP437 before any uifc stuff and everythings going to be happy.
  4. rswindell
    Tue Apr 17 2018 11:46 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.712 1.713 diff

    Log Message:
    Some log output updates, mainly adding errno string-representation where
    missing, but also now logging when renaming (or failing to rename) bad
    received .REP packet files.
  5. deuce
    Tue Apr 17 2018 11:44 pm PDT

    Modified Files:
    src/conio/ciolib.c 1.171 1.172 diff
    src/conio/ciolib.h 1.99 1.100 diff

    Log Message:
    Have save/restorescreen() save and restore the flags and fonts as well.
  6. rswindell
    Tue Apr 17 2018 11:43 pm PDT

    Modified Files:
    src/sbbs3/un_rep.cpp 1.64 1.65 diff

    Log Message:
    Don't treat qwk_import_msg() failures (e.g. duplicate messages) as
    packet errors, no need to save such REP packets as .bad files.
  7. deuce
    Tue Apr 17 2018 11:33 pm PDT

    Modified Files:
    src/conio/bitmap_con.c 1.136 1.137 diff

    Log Message:
    Handle default fonts when setting vmem.
  8. deuce
    Tue Apr 17 2018 11:33 pm PDT

    Modified Files:
    src/conio/cterm.c 1.241 1.242 diff

    Log Message:
    Copy the current font one into the CTerm altfont array during cterm_init()
    
    This should fix the issue with non-CP437 fonts reported by Kirkman.
  9. rswindell
    Tue Apr 17 2018 11:06 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.671 1.672 diff

    Log Message:
    Use the msg.idx.number as the message number in smb_getmsghdr() failure
    error messages (in the POP3 server) as the msg.hdr.number is zeroed by 
    smb_getmsghdr() and potentially invalid when returning an error.
  10. rswindell
    Tue Apr 17 2018 11:00 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.670 1.671 diff

    Log Message:
    Use a different source for the message number in smb_getmsghdr() failure
    error log message as the header is zeroed in this function and thus the
    message number previously read from the index, lost (zeroed) and useless.
  11. deuce
    Tue Apr 17 2018 08:54 pm PDT

    Modified Files:
    src/syncterm/bbslist.c 1.212 1.213 diff

    Log Message:
    Pass a bar pointer to screen mode list to allow showing below end of first
    screen of rows.
  12. deuce
    Tue Apr 17 2018 07:35 pm PDT

    Modified Files:
    exec/imapservice.js 1.66 1.67 diff

    Log Message:
    is_connected is not a method.
  13. rswindell
    Tue Apr 17 2018 06:41 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.232 1.233 diff

    Log Message:
    Experimental enhancement: enable WWIV color (Ctrl-C) code expansion in
    *nix-builds (for stdio WWIV doors).
  14. rswindell
    Tue Apr 17 2018 03:57 pm PDT

    Modified Files:
    src/sbbs3/xtrn_sec.cpp 1.84 1.85 diff

    Log Message:
    Extend USE_DOSEMU patch to drop file creation for non-native doors:
    Use drive mappings (e.g. D:, F:, G:, H:) rathe than absolute paths to node_dir,
    ctrl_dir, data_dir, and exec_dir in drop files.
    Also: fixed what appears to have been a copy/paste error in the node_dir
    and ctrl_dir mapping to Win32-shortnames for non-native doors on Windows.
  15. rswindell
    Tue Apr 17 2018 02:45 pm PDT

    Modified Files:
    exec/tickit.js 1.43 1.44 diff

    Log Message:
    Simplified the rename_or_move() function:
    - Don't use the deprecated 'e' file open mode
    - Use the global file_copy() method rather than roll-your-own
  16. rswindell
    Mon Apr 16 2018 09:32 pm PDT

    Modified Files:
    src/sbbs3/email.cpp 1.66 1.67 diff

    Log Message:
    Display the (previously unused) EmailFilesNotAllowed text.dat entry if a file
    attachment is attempted but unsupported.
  17. rswindell
    Mon Apr 16 2018 09:30 pm PDT

    Modified Files:
    src/sbbs3/fido.cpp 1.58 1.59 diff

    Log Message:
    Overhaul sbbs_t::netmail() for FidoNet netmail:
    - writes outbound netmail to SMB rather than FTS-1 Stored Messages (*.msg)
      this means you must have SBBSecho v2.30 or later in order to export FTN
      netmail (for file attachments, you'll need SBBSecho v3.04 rev 3.78 or later)
    - removed support for the now deprecated "default address" feature
      (nowadays, people are much more likely to gate FidoNet over Internet rather
      than the reverse!)
    
    The QWK-to-NetMail function still needs a similar overhaul.
  18. rswindell
    Mon Apr 16 2018 09:14 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.79 3.80 diff

    Log Message:
    write_flofile(): if the 'infile' path contains a drive letter prefix
    (e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
    to forward-slashes (for all OSes). This resolves an issue of sending a
    netmail file-attachment that was created on a Windows/MS-DOS type system
    and then scanned/exported on a *nix system. The FTN "stored message"
    convention is to have the full path of the attached file in the message
    subject.
    
    Hopefully nobody wants to use outbound directory names beginning with "x:"
    on *nix. :-)
  19. rswindell
    Mon Apr 16 2018 07:56 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.78 3.79 diff

    Log Message:
    Bug-fix: when exporting FTN netmail from SMB "mail" base, if the netmail
    included an "old-style" (not MIME-encoded) file attachment (where the file path
    is in the subject and the FILEATTACH aux-attribute flag is set), the
    corresponding netmail attribute flag would not be set in the stored msg (*.msg)
    file. Also simplified the create_netmail() function prototype/usage, removing
    the "file_attached" argument (use the hdr.auxattr instead).
  20. rswindell
    Mon Apr 16 2018 03:48 pm PDT

    Modified Files:
    3rdp/win32.release/cryptlib/bin/cl32.dll 1.6 1.7 diff

    Log Message:
    This is a clean rebuild of 3.4.4 with all our patches and there are several
    bytes different, so committing out of an abundance of caution. No "known"
    changes however.
  21. rswindell
    Mon Apr 16 2018 03:39 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.711 1.712 diff

    Log Message:
    Fix typo in previous commit.
  22. rswindell
    Mon Apr 16 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.710 1.711 diff
    src/sbbs3/un_rep.cpp 1.63 1.64 diff

    Log Message:
    2 unrelated changes:
    1: Wrap SSH cryptDestroySession() calls in a wrapper that tracks the number of
        open sessions and logs errors upon failure (and remaining session count).
        This is how I found the SSH session leak in sbbs_t::hangup().
        Also found multiple cals to SSH_END() which were invalid (no session to
        destroy) and removed them.
    2: If errors are detected when unpacking a REP packet, save the .rep file
        (in data/file/<filename.rep>.<timestamp>.bad) for later inspection.
        Also added some VOTING.DAT debug output (to be removed later).
        Trying to the get to the bottom of the
        "smb_addvote thread_back field missing" errors.
  23. rswindell
    Sun Apr 15 2018 06:32 pm PDT

    Modified Files:
    src/sbbs3/logon.cpp 1.65 1.66 diff

    Log Message:
    If the HappyBirthday text.dat line is blank, don't try to display it nor 
    pause and CLS after.
  24. echicken
    Sat Apr 14 2018 10:27 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.28 1.29 diff

    Log Message:
    @DigitalMan | It'd be nice if home/end keys moved to first/last avatars in a collection when viewing a collection
  25. echicken
    Sat Apr 14 2018 10:21 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.27 1.28 diff

    Log Message:
    @DigitalMan | JavaScript  s:\sbbs\exec\avatar_chooser.js line 775: TypeError: state.opt_out_item is null
    
    uh, this oughta do away with that, I guess
  26. echicken
    Sat Apr 14 2018 10:10 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.26 1.27 diff

    Log Message:
    Fix display bug (collection/highlight desync), but I should probably 
    revisit some of this.
  27. echicken
    Sat Apr 14 2018 10:00 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.25 1.26 diff

    Log Message:
    Scroll up one more line when on row zero to reveal the collection title.
    (Not the best fix, but it'll do for now.)
  28. rswindell
    Fri Apr 13 2018 04:59 pm PDT

    Modified Files:
    src/sbbs3/logfile.cpp 1.60 1.61 diff

    Log Message:
    errormsg() logs the "useron", when applicable, even for timed events (e.g.
    REP unpacking).
  29. rswindell
    Thu Apr 12 2018 10:25 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.709 1.710 diff

    Log Message:
    Apparent fix for SSH cryptlib session leak (leading to eventual
    'Resource/space exhausted' errors in TLS and SSH:
    The wrong ssh_session is being passed to cryptDestroySession() in
    sbbs_t::hangup() (introduced in rev 1.615), this call to cryptDestorySession()
    fails (returns -1, bad param) thus leaving the actual
    ssh_session never destroyed (leaked).
  30. rswindell
    Thu Apr 12 2018 03:11 pm PDT

    Modified Files:
    exec/load/sbbslist_lib.js 1.14 1.15 diff

    Log Message:
    Increase maximum service address (e.g. host name) length from 28 chars to 35
    chars for Bill McGarrity @ tequilamockingbirdonline.net :-)
    Doesn't seem to break anything (except backwards compatibility with SBL
    v3).
  31. rswindell
    Sun Apr 08 2018 07:59 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.470 1.471 diff

    Log Message:
    Bug-fix: The GCES macro already prints and *frees* the error string, so
    you can't print and free it again after calling that macro.
  32. rswindell
    Sun Apr 08 2018 07:49 pm PDT

    Modified Files:
    exec/binkit.js 2.1 2.2 diff

    Log Message:
    Remove 'e' from File.open() modes, but place a reminder comment to revisit.
    Added destination address of outbound file in "Attempting callout" log msg.
  33. rswindell
    Sat Apr 07 2018 12:21 am PDT

    Modified Files:
    src/xpdev/xpprintf.c 1.61 1.62 diff

    Log Message:
    Resolve GCC warnings:
    cast from pointer to integer of different size
  34. rswindell
    Sat Apr 07 2018 12:18 am PDT

    Modified Files:
    src/sbbs3/pack_rep.cpp 1.47 1.48 diff

    Log Message:
    Resolved GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
  35. rswindell
    Sat Apr 07 2018 12:17 am PDT

    Modified Files:
    src/sbbs3/mime.c 1.10 1.11 diff

    Log Message:
    Resolved GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
  36. rswindell
    Sat Apr 07 2018 12:15 am PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.231 1.232 diff

    Log Message:
    Removed an apparent debug-output (to stderr) line (output the path to
    emusetup.bat).
    It was generating an (easy to fix) GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
    But the line was not needed, so just removed it.
  37. rswindell
    Fri Apr 06 2018 11:01 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.669 1.670 diff

    Log Message:
    Resolve gcc version 5.4.0 warning: 
    format not a string literal and no format arguments [-Wformat-security]
  38. rswindell
    Fri Apr 06 2018 10:55 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.77 3.78 diff

    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]
  39. rswindell
    Fri Apr 06 2018 10:51 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.668 1.669 diff

    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]
       sockprintf(sock,sess,(char*)resp);
       sockprintf(socket,session,sys_error);
  40. rswindell
    Fri Apr 06 2018 12:08 am PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.230 1.231 diff

    Log Message:
    Fix build for USE_DOSEMU option (which I don't use).
  41. rswindell
    Thu Apr 05 2018 08:02 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.76 3.77 diff

    Log Message:
    Use GCC-assisted printf-style format/arg checking to find and fix instances
    of lprintf() misuse.
  42. rswindell
    Thu Apr 05 2018 07:49 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.229 1.230 diff

    Log Message:
    Resolve a couple GCC warnings:
    unused variable 'p'
    comparison between signed and unsigned integer expressions
  43. rswindell
    Thu Apr 05 2018 07:47 pm PDT

    Modified Files:
    src/sbbs3/js_global.c 1.373 1.374 diff

    Log Message:
    Resolve GCC warning: cast from pointer to integer of different size
     in expansion of macro 'JS_ARGS_OFFSET':
    unsigned long is the same size as a pointer (rather than unsigned int)
    on the supported target platforms/tool-chains.
  44. rswindell
    Thu Apr 05 2018 07:42 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.479 1.480 diff
    src/sbbs3/js_cryptcon.c 1.19 1.20 diff
    src/sbbs3/main.cpp 1.708 1.709 diff
    src/sbbs3/pack_rep.cpp 1.46 1.47 diff
    src/sbbs3/readtext.c 1.4 1.5 diff
    src/sbbs3/un_qwk.cpp 1.52 1.53 diff
    src/sbbs3/jsexec.c 1.198 1.199 diff

    Log Message:
    Use GCC-printf-style format/arg checking to find and fix problems with
    ::lprintf() usage.
  45. rswindell
    Thu Apr 05 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.665 1.666 diff

    Log Message:
    Enabled GCC-assisted printf-style format/arg checking for lprintf() and
    fix the resulting warnings.
  46. rswindell
    Thu Apr 05 2018 07:18 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.321 1.322 diff

    Log Message:
    Enabled GCC-assisted printf-style format/arg checking for lprintf() and
    fix the resulting warnings.
  47. rswindell
    Thu Apr 05 2018 07:11 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.h 1.84 1.85 diff
    src/sbbs3/mailsrvr.c 1.667 1.668 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for sockprintf()
    and resolve the resulting warnings.
  48. rswindell
    Thu Apr 05 2018 06:58 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.666 1.667 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for lprintf() and
    resolve the resulting warnings.
  49. rswindell
    Thu Apr 05 2018 06:35 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.469 1.470 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for lprintf, sockprintf
    and send_mlsx().
    Fix numerous printf-style argument bugs, many in the TLS and MLSx support.
  50. rswindell
    Thu Apr 05 2018 06:05 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.468 1.469 diff

    Log Message:
    Fix get_ssl_cert() failure log message (wrong number of arguments).
    Put "TLS" in the failure log messages rather than repeating "FTP".
  51. rswindell
    Thu Apr 05 2018 06:02 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.665 1.666 diff

    Log Message:
    Fix get_ssl_cert() failure log message (wrong number of arguments).
    Was this pasted from somewhere else?
  52. rswindell
    Thu Apr 05 2018 05:49 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.75 3.76 diff

    Log Message:
    Log an error if ftouch() fails to create the outbound sem file.
  53. rswindell
    Thu Apr 05 2018 05:21 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.478 1.479 diff
    src/sbbs3/login.cpp 1.26 1.27 diff

    Log Message:
    Address GCC warning: ISO C++ forbids converting a string constant to 'char*'
  54. rswindell
    Thu Apr 05 2018 05:14 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.664 1.665 diff

    Log Message:
    Fix a couple of issues with external mail processors:
    - Since rev 1.556, mailproc_to_match[] would only ever contain one mail
      processor (index) value, even if the RCPT TO address matched multiple
      mail processor "To" keys in mailproc.ini, so only the first-matching
      mail processor (with a "To" key) would be executed for the msg.
    - mailproc_match, meaning the destination was a non-passthrough
      external mail processor, in which case the destination (RCPT TO) address
      may *not* match a valid local user account, would be set for *passthru*
      mail processors potentially resulting in the following error (and an
      undelivered mail message): !SMTP can't deliver mail to user #0
      only set mailproc_match to a valid mail proc index if the recipient matches a
      non-passthru mail processor.
  55. rswindell
    Thu Apr 05 2018 03:26 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.467 1.468 diff

    Log Message:
    The real apparent fix for the free() assertion: use free_crypt_attrstr() instead
  56. rswindell
    Thu Apr 05 2018 02:49 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.466 1.467 diff

    Log Message:
    Initialize estr to NULL in start_tls(), likely cause of free() assert in
    Windows debug build.
  57. rswindell
    Thu Apr 05 2018 03:28 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.74 3.75 diff

    Log Message:
    Some status string (e.g. "Loading user names...") were being sent to stderr
    instead of stdout.
  58. rswindell
    Wed Apr 04 2018 07:22 pm PDT

    Modified Files:
    exec/showmsghdr.js 1.3 1.4 diff
    exec/showmsgavatar.js 1.1 1.2 diff
    exec/showfileavatar.js 1.2 1.3 diff
    exec/logon.js 1.32 1.33 diff

    Log Message:
    Don't "clear the background attribute" by setting the attributes to 0
    (black on black) as this can inadvertently "hide" text for ANSI users
    (e.g. poll comments, when reading a poll message). Set to 7 (lightgray)
    instead.
  59. rswindell
    Wed Apr 04 2018 12:13 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.195 1.196 diff

    Log Message:
    Don't log "(null)" for the user name in filter_ip() when the user name is
    not known/available (e.g. certain types of SSH login failures).
  60. rswindell
    Wed Apr 04 2018 12:11 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.320 1.321 diff
    src/sbbs3/ftpsrvr.c 1.465 1.466 diff
    src/sbbs3/websrvr.c 1.664 1.665 diff
    src/sbbs3/mailsrvr.c 1.663 1.664 diff

    Log Message:
    Log the number of failed login attempts which triggered the IP filter.
  61. rswindell
    Wed Apr 04 2018 12:10 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.477 1.478 diff
    src/sbbs3/login.cpp 1.25 1.26 diff
    src/sbbs3/main.cpp 1.707 1.708 diff

    Log Message:
    sbbs_t::badlogin() now accepts 3 more (optional) arguments which allow us
    to use this function in bbs_thread() for SSH failed login attempts and thus
    enable the perm-IP-filtering (LoginAttemptFilterThreshold) functionality.
    Right now, it's only a "bad login" if the "Getting channel type" doesn't
    return "session", but we could (and likely will) use it for more SSH login
    failure modes which indicate a likely hack-attempt.
  62. rswindell
    Tue Apr 03 2018 06:52 pm PDT

    Modified Files:
    exec/tickit.js 1.42 1.43 diff

    Log Message:
    Change the -replace option to -force-replace since the old "tick" program
    had a "replace" option that did something differnet (enabled parsing of the
    REPLACES verb) - don't want to confuse sysops now. :-)
  63. rswindell
    Mon Apr 02 2018 04:45 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.706 1.707 diff

    Log Message:
    Create yet-another GCES macro (GCESSTR) to log the output_thread instance
    description string ('node') in SSH-related log messages (e.g. errors) from the
    output_thread: No more "Node 0" log entries from here.
  64. rswindell
    Mon Apr 02 2018 04:22 pm PDT

    Modified Files:
    src/sbbs3/js_file.c 1.171 1.172 diff

    Log Message:
    Updated JS warning when using old/deprecated file open mode 'e':
        "Deprecated file open mode: 'e'"
    If this is your script generating this warning, either remove the 'e' from
    the File open() mode string (it had no effect anyway) or change to 'x' to
    get the real/working exclusive-open functionality (added in v3.17).
  65. rswindell
    Mon Apr 02 2018 03:52 pm PDT

    Modified Files:
    src/sbbs3/ctrl/CodeInputFormUnit.dfm 1.5 1.6 diff

    Log Message:
    Sort the items in the combobox when prompting for an internal code
    (e.g. for a QNET hub or timed event).
  66. rswindell
    Mon Apr 02 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/js_file.c 1.170 1.171 diff

    Log Message:
    The 'e' (exclusive-open) mode flag (introduced in v3.12) never worked. It was
    simply ignored when converted to the underlying open mode passed to sopen().
    Deprecate this flag and log a warning when it is detected as used in a script:
    Deprecated open flag used: 'e'
    Added 'x' (exclsuive-open) mode flag which:
    1. was tested to work as intended
    2. is consistent with the C11 standard for fopen() mode flags
    3. won't cause existing scripts to suddenly break
  67. rswindell
    Mon Apr 02 2018 01:32 pm PDT

    Modified Files:
    exec/tickit.js 1.41 1.42 diff

    Log Message:
    Experimental feature for bgdjr: when '-replace' argument is passed on the
    command-line, treat all .TIC files as they have have a "REPLACES" clause.
  68. deuce
    Mon Apr 02 2018 01:29 am PDT

    Modified Files:
    exec/load/http.js 1.41 1.42 diff

    Log Message:
    When sending a request and the socket is still open, close it.
    This prevents leaving all sockets open until the script exits.  It would
    be better to reuse the existing socket when it's already connected to the
    right place, but this is easier for now.
  69. rswindell
    Sun Apr 01 2018 01:48 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.705 1.706 diff

    Log Message:
    Added function names to SSH error messages so we can better tell where
    these errors are coming from.
  70. rswindell
    Sun Apr 01 2018 01:46 pm PDT

    Modified Files:
    exec/load/fidocfg.js 1.32 1.33 diff
    exec/load/fido.js 1.31 1.32 diff
    exec/load/fido_syscfg.js 1.17 1.18 diff

    Log Message:
    Added CVS Id tag.
  71. echicken
    Sun Apr 01 2018 10:25 am PDT

    Modified Files:
    xtrn/ansiview/ansiview.js 1.24 1.25 diff
    xtrn/ansiview/readme.txt 1.6 1.7 diff

    Log Message:
    Two optional settings can be added to the root section of settings.ini:
    header = /path/to/some.ans
    header_rows = number of lines occupied by the header graphic
    The normal ansiview 'window' will be pushed down by header_rows lines,
    and the header graphic will be displayed above it.
  72. rswindell
    Sun Apr 01 2018 12:51 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.94 1.95 diff

    Log Message:
    If the SSH or RLogin-supplied username is in the name.can, don't start the
    new user signup process with that name (just fall-through to a normal login
    prompt).
  73. rswindell
    Sun Apr 01 2018 12:22 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.662 1.663 diff

    Log Message:
    Added a debug-level log msg ever 100 lines of received SMTP message text.
  74. rswindell
    Sat Mar 31 2018 11:55 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.16 1.17 diff

    Log Message:
    Fix bug in previous commit (use of Object.keys) which caused the default
    domain/zone-map configuration to be used - always.
  75. rswindell
    Sat Mar 31 2018 09:24 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.15 1.16 diff

    Log Message:
    Fix the default domain ('fidonet', zones 1-6) feature when there are no
    domains configured in sbbsecho.ini
    ('domains' is always undefined at this point, <shrug>).
  76. rswindell
    Sat Mar 31 2018 08:54 pm PDT

    Modified Files:
    exec/binkit.js 2.0 2.1 diff

    Log Message:
    Fix error line 792: TypeError: file_getext(dir) is undefined
    when outbound directory (dir) was "../some/path".
  77. rswindell
    Sat Mar 31 2018 08:42 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.32 3.33 diff

    Log Message:
    When creating a new linked node, set binkp_allowPlainText to true
    (Argus and Mystic's BinkP mailers don't support encryption).
  78. rswindell
    Sat Mar 31 2018 08:38 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.31 3.32 diff

    Log Message:
    Help text fix-ups.
  79. rswindell
    Sat Mar 31 2018 08:37 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.73 3.74 diff

    Log Message:
    Bug-fix: The Auto-Add-Subs feature would not create the area file (areas.bbs)
    if it didn't already exist.
  80. rswindell
    Sat Mar 31 2018 07:21 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.14 1.15 diff

    Log Message:
    Fixed some typos.
    Added node address to some authentication failure warnings.
  81. rswindell
    Sat Mar 31 2018 02:43 am PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.30 3.31 diff

    Log Message:
    Resolved GCC warning about implicit type (int).
  82. rswindell
    Sat Mar 31 2018 02:41 am PDT

    Modified Files:
    src/sbbs3/pktdump.c 1.10 1.11 diff

    Log Message:
    Use new struct fidoaddr (5D address).
  83. rswindell
    Sat Mar 31 2018 02:40 am PDT

    Modified Files:
    src/sbbs3/fidodefs.h 1.19 1.20 diff

    Log Message:
    Added FIDO_DOMAIN_LEN (8), PRODDATA_LEN (4), updated comments, etc.
    Created struct fidoaddr (5D address), though it's only used (so far)
    in pktdump.c - doesn't really need to be packed.
  84. rswindell
    Sat Mar 31 2018 02:38 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.21 3.22 diff
    src/sbbs3/sbbsecho.c 3.72 3.73 diff
    src/sbbs3/rechocfg.c 3.29 3.30 diff
    src/sbbs3/echocfg.c 3.29 3.30 diff

    Log Message:
    SBBSecho/EchoCfg v3.04 - uses the newly merged sbbsecho/binkit/ftn_domains.ini
    If you're not using BinkIT (you're using some other FidoNet mailer), you can
    safely ignore all the settings/options.
    A lot of the online help for the new settings/menus needs to be written
    still and the wiki now needs a lot of update to reflect the changes.
    The "title" of this program was changed, again, from "SBBSecho Config" to
    "[Synchronet] FidoNet Config" since it configures more than just SBBSecho
    now.
  85. rswindell
    Sat Mar 31 2018 02:34 am PDT

    Modified Files:
    exec/update.js 1.5 1.6 diff

    Log Message:
    Run 'binkit upgrade' if binkit.ini and sbbsecho.ini exists
    (the upgrade renames binkit.ini and ftn_domains.ini to *.old).
  86. rswindell
    Sat Mar 31 2018 02:33 am PDT

    Modified Files:
    exec/binkit.js NONE 2.0 diff

          Tag: 2.0
    	binkit.js 
    Log Message:
    Merged binkit.ini and ftn_domains.ini into sbbsecho.ini (BinkIT 2.0).
    Use "jsexec binkit upgrade" to upgrade your existing .ini files if you're
    already running BinkIT 1.x.
    echocfg v3.04 may now be used to set all the BinkIT settings and domains
    (in sbbsecho.ini).
  87. rswindell
    Sat Mar 31 2018 02:31 am PDT

    Modified Files:
    exec/load/fidocfg.js 1.31 1.32 diff
    exec/load/fido_syscfg.js 1.13 1.14 diff

    Log Message:
    Merged binkit.ini and ftn_domains.ini into sbbsecho.ini (for BinkIT 2.0)
    (note: some of the key names were changed), run "jsexec binkit upgrade"
    to upgrade your existing .ini's (if you have them).
    Removed support for sbbsecho.cfg.
  88. rswindell
    Sat Mar 31 2018 02:16 am PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.37 1.38 diff

    Log Message:
    Finished removing (now unused) PostLink-networking stuff.
  89. rswindell
    Sat Mar 31 2018 01:40 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.704 1.705 diff

    Log Message:
    Check the terminate_output_thread flag after acquiring the ssh_muex.
  90. deuce
    Sat Mar 31 2018 01:14 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.703 1.704 diff

    Log Message:
    Tabs are stupid.
  91. echicken
    Fri Mar 30 2018 10:41 pm PDT
    exec/load websocket-proxy.js 1.1 NONE
    Update of /cvsroot/sbbs/exec/load
    In directory cvs:/tmp/cvs-serv11750/load
    
    Removed Files:
    	websocket-proxy.js 
    Log Message:
    These are no longer needed and will only cause confusion alongside other websocket scripts.
  92. echicken
    Fri Mar 30 2018 10:41 pm PDT

    Removed Files:
    exec/NONE websocket-rlogin-service.js 1.5 diff

    Log Message:
    These are no longer needed and will only cause confusion alongside other websocket scripts.
  93. rswindell
    Fri Mar 30 2018 09:03 am PDT

    Modified Files:
    src/xpdev/ini_file.c 1.161 1.162 diff

    Log Message:
    Fix bcc32 build error: Expression syntax in function iniSetIntList
  94. rswindell
    Fri Mar 30 2018 01:35 am PDT

    Modified Files:
    src/xpdev/ini_file.c 1.160 1.161 diff
    src/xpdev/ini_file.h 1.54 1.55 diff

    Log Message:
    Added functions for reading/parsing/writing lists of integers in .ini files
    (e.g. "Zones=1,2,3,4,5,6").
  95. rswindell
    Fri Mar 30 2018 01:33 am PDT

    Modified Files:
    src/xpdev/link_list.h 1.27 1.28 diff

    Log Message:
    Fixed typo in comment.
  96. deuce
    Thu Mar 29 2018 06:02 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.464 1.465 diff

    Log Message:
    Fix infinite loop with TLS FTP control session.
  97. deuce
    Tue Mar 27 2018 07:47 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.319 1.320 diff

    Log Message:
    Fix potential crypt handle leak for TLS services.  Destroy the session
    if the thread returns before js_initcx() is called.
  98. deuce
    Tue Mar 27 2018 07:36 pm PDT

    Modified Files:
    exec/letsyncrypt.js 1.32 1.33 diff

    Log Message:
    Don't try ten times to delete files that don't exist.
  99. deuce
    Tue Mar 27 2018 06:45 pm PDT

    Modified Files:
    exec/imapservice.js 1.65 1.66 diff

    Log Message:
    Check if the socket is connected or not in the wait loop.
  100. deuce
    Mon Mar 26 2018 10:16 pm PDT

    Modified Files:
    exec/binkit.js 1.77 1.78 diff

    Log Message:
    Some binkp software (Taurus) doesn't send an M_NUL VER at all.
    Reported by bgdjr.
  101. rswindell
    Mon Mar 26 2018 06:08 pm PDT

    Modified Files:
    src/sbbs3/qwk.cpp 1.81 1.82 diff

    Log Message:
    Don't log an error when a QWK-posted vote message is a dupe (just silently
    discard).
    Also, trim trailing white-spaces.
  102. rswindell
    Mon Mar 26 2018 06:06 pm PDT

    Modified Files:
    src/conio/sdl_con.c 1.261 1.262 diff

    Log Message:
    Fix GCC warning:
    sdl_con.c: In function ΓÇÿsdl_mouse_threadΓÇÖ:
    sdl_con.c:1424:1: warning: no return statement in function returning non-void
  103. nightfox
    Mon Mar 26 2018 12:55 pm PDT

    Modified Files:
    exec/load/DDLightbarMenu.js 1.24 1.25 diff

    Log Message:
    Bug fix in the SetBorderChars method: Missing an index ([i]) into an array
  104. deuce
    Sun Mar 25 2018 10:17 pm PDT

    Modified Files:
    exec/binkit.js 1.76 1.77 diff

    Log Message:
    Check the Mystic version reported by the remote to see if we need to work
    around a broken CRAM-MD5 implementation.  For now, retrains the double-test
    for Mystic/1.12A39 until we see what version number the fixed builds have.
    
    If the major version is less than one, returns true.
    
    If the major version is greater than one, returns false.
    
    If the minor version is less than 12, returns true.
    
    If the minor version is greater than 12, returns false.
    
    If there is no character after the minor versions, returns false.
    (ie: 1.12 is newer than 1.12A39 and is assumed to be fixed)
    
    If the character after the minor version is not an 'A', returns false.
    (ie: 1.12B1 and 1.12.1 are newer than 1.12A39 and assumed fixed)
    
    If the number after the 'A' is less than or equal to 39, returns true.
    
    In all other cases, returns false.
    
    This prevents lowering security by having two allowed CRAM-MD5 responses
    for some remote software versions.  Hopefully the fixed build will have
    version 1.12A40 and we'll be able to remove the last version that does that.
  105. deuce
    Sun Mar 25 2018 09:40 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.702 1.703 diff

    Log Message:
    Since much more than the number of bytes we're reading can be sent on a
    channel we ignore/close, we would get a separate warning for each chunk of
    data on that channel until we read past the close.  Instead, if we're closing
    a channel, we note the channel ID, and simply discard the information
    immediately on the most recently closed channel.
    
    A remote could still cause a bunch of log output by multiplexing two or more
    writes to invalid channels, but nobody seems to do that, so this should be
    good for now.
  106. rswindell
    Sun Mar 25 2018 09:30 pm PDT

    Modified Files:
    src/sbbs3/chksmb.c 1.61 1.62 diff

    Log Message:
    Resolve msvc warnings (and confirm that cvs commits are making it into
    syncprog and the commit log again).
  107. deuce
    Sat Mar 24 2018 09:27 pm PDT

    Modified Files:
    src/conio/cterm.c 1.240 1.241 diff

    Log Message:
    Fix a large number of errors involving re-using an in-use index variable as
    a temp variable.  Mostly impacting the setting of video flags.
  108. rswindell
    Sat Mar 24 2018 09:14 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.193 1.194 diff

    Log Message:
    putmsgptrs():
    Fix-up the user/####.subs ini style (only one blank line between sections).
    Also, don't re-write the .subs file if nothing has changed.
  109. rswindell
    Sat Mar 24 2018 08:48 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.192 1.193 diff

    Log Message:
    Address GCC warning: "/*" within comment
  110. rswindell
    Sat Mar 24 2018 08:47 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.191 1.192 diff

    Log Message:
    Changed user' message pointer/last-read/scan-config storage to a new file
    (data/user/*.subs - in familar .ini syntax)
    indexed by the sub-board internal rather than the old flat binary file using
    the troublesome "pointer index" (ptridx) as an offset. The old files
    (data/user/ptrs/*.ixb) will still be read in when the new file doesn't exist,
    for upgrading users automatically to the new method of pointer storage.
    This should resolve long-standing issues around users' new-scan pointers and
    configurations getting corrupted when the sysop inserts/remove sub-boards.
    However, if you change a sub-board's internal code, that invalidates the users'
    pointers and scan configurations - so that may need to be addrsesed via SCFG.
    The subs' ptridx values are still be used for storing QWKnet hub pointers, for
    now, but that too will soon be addressed with a new file format for those ptrs
    too.
  111. deuce
    Sat Mar 24 2018 02:09 pm PDT

    Modified Files:
    exec/load/binkp.js 1.105 1.106 diff

    Log Message:
    Store the remote software version in the BinkP object, don't do special
    stuff in binkp.js, only the protocol.  BinkIT now does the Mystic check.
  112. deuce
    Sat Mar 24 2018 02:09 pm PDT

    Modified Files:
    exec/binkit.js 1.74 1.75 diff

    Log Message:
    Store the remote software version in the BinkP object, don't do special
    stuff in binkp.js, only the protocol.  BinkIT now does the Mystic check.
  113. deuce
    Sat Mar 24 2018 02:01 pm PDT

    Modified Files:
    exec/load/binkp.js 1.104 1.105 diff

    Log Message:
    Add comment in binkp about why we detect Mystic as well.
  114. deuce
    Sat Mar 24 2018 02:00 pm PDT

    Modified Files:
    exec/binkit.js 1.73 1.74 diff

    Log Message:
    Add comment regarding Mystic password workaround.
  115. deuce
    Sat Mar 24 2018 01:57 pm PDT

    Modified Files:
    exec/load/binkp.js 1.103 1.104 diff

    Log Message:
    Attept to work around Mystic CRAM+CRYPT issue.
  116. deuce
    Sat Mar 24 2018 01:57 pm PDT

    Modified Files:
    exec/binkit.js 1.72 1.73 diff

    Log Message:
    Attept to work around Mystic CRAM+CRYPT issue.
  117. rswindell
    Sat Mar 24 2018 01:53 am PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.41 1.42 diff

    Log Message:
    The SubLstHdr and SubLstFmt lines display the number of posts per sub-board,
    increase post-count width supported from 4 to 5 digits (beautifully).
  118. rswindell
    Sat Mar 24 2018 01:52 am PDT

    Modified Files:
    ctrl/text.dat 1.81 1.82 diff

    Log Message:
    The SubLstHdr and SubLstFmt lines display the number of posts per sub-board,
    increase post-count width supported from 4 to 5 digits (beautifully).
  119. rswindell
    Fri Mar 23 2018 11:49 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.36 1.37 diff
    src/sbbs3/scfg/scfgsub.c 1.45 1.46 diff

    Log Message:
    Removed PostLink/PCRelay configuration stuff - nobody has used this
    networking technology for 20 years. :-(
  120. rswindell
    Fri Mar 23 2018 05:02 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.660 1.661 diff

    Log Message:
    More detailed log output when posting a message via SMTP (successfully
    or not).
  121. rswindell
    Fri Mar 23 2018 04:57 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.700 1.701 diff

    Log Message:
    Log a generic "SSH session establishment failed" message (with NOTICE
    severity) whenever there is an SSH session establishment failure, because
    some of the SSH failure errors are DEBUG level severity and won't be visible
    with "Normal" (informational) log output filtering. This resolves the issue
    of seing "SSH connection accepted from <ip-address> port <port>" messages
    with no follow-up messages as to what happened to that connection.
  122. rswindell
    Fri Mar 23 2018 04:27 pm PDT

    Modified Files:
    exec/load/binkp.js 1.102 1.103 diff

    Log Message:
    Raise the log-level severity (from DEBUG to NOTICE) when sending any M_ERR
    messages. There's a lot of places in this script where we just send a
    (somewhat explanatory) M_ERR string, but don't log anything locally unless
    debug-level logging is enabled, now we'll at least log those messages with
    a bit higher severity.
  123. rswindell
    Fri Mar 23 2018 01:12 am PDT

    Modified Files:
    exec/binkit.js 1.71 1.72 diff

    Log Message:
    Don't allow the CRAM-MD5 challenge length to be overridden (always use
    the binkp.js default, 32-hexchars/16-bytes). Even IRex v2.31 requires a
    16-byte challenge, so experiment is over.
    Log more details when a CRAM-MD5 authentication response doesn't match
    (e.g. to make case-mismatch or other cause of authentication failures
    potentially more obvious - still debugging the Mystic inbound CRAM-MD5
    auth failure and this might help).
  124. rswindell
    Thu Mar 22 2018 07:12 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.190 1.191 diff

    Log Message:
    Fix weird compile error triggered by *some* revisions of msvc which dont'
    like a str_list_t declared in line (but the char* is fine?!).
  125. rswindell
    Thu Mar 22 2018 06:30 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.199 1.200 diff

    Log Message:
    Fix the log msg repeat count (off by one).
    Remember the last forced timed event setting.
  126. rswindell
    Thu Mar 22 2018 06:19 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.463 1.464 diff
    src/sbbs3/mailsrvr.c 1.659 1.660 diff
    src/sbbs3/main.cpp 1.699 1.700 diff
    src/sbbs3/services.c 1.318 1.319 diff
    src/sbbs3/websrvr.c 1.663 1.664 diff

    Log Message:
    Clean-up the log output around server shutdown/recycle:
    - lower log level (raise severity) of "Waiting for ..." msgs from Debug to Info
    - log a message when done waiting (for clients, threads, etc.)
    - only one #### log line per termination event
  127. rswindell
    Thu Mar 22 2018 05:09 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.8 1.9 diff

    Log Message:
    Log the UNIX socket name (filename) the status thread is listening on
    (default is ctrl/status.sock).
  128. rswindell
    Thu Mar 22 2018 04:32 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.7 1.8 diff

    Log Message:
    Fix more typos.
  129. rswindell
    Thu Mar 22 2018 04:29 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.6 1.7 diff

    Log Message:
    Fixed typo in status thread error message string ("stat" not "ftp").
  130. rswindell
    Thu Mar 22 2018 04:03 pm PDT

    Modified Files:
    exec/load/hexdump_lib.js 1.2 1.3 diff

    Log Message:
    Make hexdump_lib.js more lib-like and change the functions (methods) to
    return arrays rather than calling printf() directly. Also, make the ASCII
    portion of the output optional (but enabled by default).
  131. rswindell
    Thu Mar 22 2018 04:03 pm PDT

    Modified Files:
    exec/hexdump.js 1.1 1.2 diff

    Log Message:
    Make hexdump_lib.js more lib-like and change the functions (methods) to
    return arrays rather than calling printf() directly. Also, make the ASCII
    portion of the output optional (but enabled by default).
  132. rswindell
    Thu Mar 22 2018 02:20 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.317 1.318 diff

    Log Message:
    Bug-fix: JS service calls to random() would return the same sequence on
    Windows, every time. For example, this resulted in the same BinkP CRAM-MD5
    challenge being sent for every mailer session. Fixed by calling sbbs_srand
    in the service's thread, not (just once) in the accept thread.
  133. deuce
    Thu Mar 22 2018 12:31 am PDT

    Modified Files:
    exec/binkit.js 1.70 1.71 diff

    Log Message:
    We can't take a lockfile that doesn't exist.
  134. deuce
    Thu Mar 22 2018 12:22 am PDT

    Modified Files:
    exec/binkit.js 1.69 1.70 diff

    Log Message:
    Only add the SCFG outbound root if it's not in the FTNDomains config already.
    This shouldn't cause any functional changes since it's the outbound dirs that
    matter, and they already can't have duplicates.
  135. deuce
    Thu Mar 22 2018 12:06 am PDT

    Modified Files:
    exec/binkit.js 1.68 1.69 diff

    Log Message:
    I don't know how objects are "true", or "false", so don't risk it.
  136. rswindell
    Wed Mar 21 2018 08:24 pm PDT

    Modified Files:
    exec/binkit.js 1.67 1.68 diff

    Log Message:
    More elaborate fix for missing outbound directories (don't create them),
    just don't "run outbound" for those nodes.
  137. rswindell
    Wed Mar 21 2018 07:58 pm PDT

    Modified Files:
    exec/binkit.js 1.66 1.67 diff

    Log Message:
    <@Deuce> If there's no outbound dir, it should just skip the node.
  138. rswindell
    Wed Mar 21 2018 07:53 pm PDT

    Modified Files:
    exec/binkit.js 1.65 1.66 diff

    Log Message:
    Fix errors when outbound directory does not exist (create it):
      Locking c:\binkd\outbound\00da02bc.bsy
      Error 2 creating c:\binkd\outbound\00da02bc.bsy
      Failed to set date in the future fdate (-1) != future (1687417603)
    Also, added some debug dump of "outbound_roots" which appears to contain
    duplicates, at least when the ftn_domains.ini file is not in use:
     Outbound roots: ["c:\\binkd\\outbound","c:\\binkd\\outbound"]
  139. rswindell
    Wed Mar 21 2018 06:19 pm PDT

    Modified Files:
    text/sbbslist.hlp 1.1 1.2 diff

    Log Message:
    Finally a first pass at an sbbslist online help file.
    I got distracted by trying to wiki-syntax and then markdown and finally
    uust used asc/ctrl-a format. Sorry took so long.
  140. deuce
    Wed Mar 21 2018 12:18 pm PDT

    Modified Files:
    exec/fseditor.js 1.87 1.88 diff

    Log Message:
    Update the help text to list all keys.
  141. deuce
    Wed Mar 21 2018 12:02 pm PDT

    Modified Files:
    docs/fseditor.txt 1.13 1.14 diff

    Log Message:
    Update for all currently supported CTRL keys.
  142. deuce
    Wed Mar 21 2018 12:02 pm PDT

    Modified Files:
    exec/fseditor.js 1.86 1.87 diff

    Log Message:
    Add CTRL-\ as a synonym for CTRL-S to avoid collision with Xon.
    Missing synonym since 1.74 (over 8 years ago)
  143. deuce
    Wed Mar 21 2018 11:03 am PDT

    Modified Files:
    docs/fseditor.txt 1.12 1.13 diff

    Log Message:
    Update to match currently used control keys.
  144. deuce
    Wed Mar 21 2018 10:55 am PDT

    Modified Files:
    exec/fseditor.js 1.85 1.86 diff

    Log Message:
    Add CTRL-N to ctrlkey passthru and remove CTRL-O.
  145. deuce
    Wed Mar 21 2018 10:54 am PDT

    Modified Files:
    exec/fseditor.js 1.84 1.85 diff

    Log Message:
    Remove CTRL-N to "select none" (deselect all) in quote mode since DigitalMan
    decided that CTRL-N should be page-down.  This should fix page down in quote
    mode which has been broken since 1.83 three months ago (with a mention in the
    log that the commit broke fseditor.js)
  146. deuce
    Wed Mar 21 2018 10:41 am PDT

    Modified Files:
    src/sbbs3/js_console.cpp 1.115 1.116 diff

    Log Message:
    Document the cterm_version property to unbreak jsdocs.
  147. deuce
    Wed Mar 21 2018 10:04 am PDT

    Modified Files:
    exec/newuser_signup.js 1.45 1.46 diff

    Log Message:
    Apply patch from Psi-Jack in 2014:
    
    This patch fixes the user object process by ordering specific parts in a way
    that fixes the following problems:
    
    Post-delayed realname and handle caused realname and handle not to be set to
    the user object. Moved copy_user_template_to_user to after bbs.login just
    before the bbs.user_sync() solved that.
              
    Choosing not to use the randomly generated password would fail on every
    situation. Reordering user.security.password to be underneath user.number
    solved this problem.
  148. rswindell
    Tue Mar 20 2018 07:28 pm PDT

    Modified Files:
    exec/sbbslist.js 1.38 1.39 diff

    Log Message:
    Cosmetic improvements to "browse" mode, mainly around editing a BBS entry.
    Also clear the screen and display "Returning to <bbs name>" when exiting.
  149. rswindell
    Tue Mar 20 2018 06:36 pm PDT

    Modified Files:
    exec/sbbslist.js 1.37 1.38 diff

    Log Message:
    Allow up to 20 networks per entry, but only export 10 (the old SBL limit)
    in the legacy section of msgbase-exported entries.
  150. rswindell
    Tue Mar 20 2018 05:01 pm PDT

    Modified Files:
    exec/nntpservice.js 1.116 1.117 diff

    Log Message:
    Don't log a "!TIMEOUT waiting for request" message if the client in fact
    only disconnected.
  151. rswindell
    Tue Mar 20 2018 04:41 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.198 1.199 diff

    Log Message:
    Fix a long-standing bug with the log windows: when the log length would
    reach the configured "max size", newly added log lines would not use the
    configured color/font for the msg's log-level (they'd all use the default
    color/font).
  152. rswindell
    Mon Mar 19 2018 08:47 pm PDT

    Modified Files:
    exec/load/binkp.js 1.101 1.102 diff

    Log Message:
    Fix line 1196: ReferenceError: reset_eob is not defined
  153. rswindell
    Mon Mar 19 2018 08:41 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.197 1.198 diff

    Log Message:
    Track log messages that are repeated within the same LogTimer tick
    (interval) and display them on a single line with an " [x#]" suffix
    which identifies the number of times the message was repeated during that
    interval.
    Also created a common log_msg() function and eliminated a lot of copy/pasta
    in the various *_log_msg() functions.
  154. rswindell
    Mon Mar 19 2018 08:39 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.dfm 1.84 1.85 diff

    Log Message:
    Increase the LogTimer interval from 250ms to 500ms, this allows us to
    collate more (repeated/duplicate) log messages into a single line of the
    visible log.
  155. rswindell
    Mon Mar 19 2018 08:36 pm PDT

    Modified Files:
    src/sbbs3/ntsvcs.c 1.47 1.48 diff
    src/sbbs3/ntsvcs.h 1.6 1.7 diff

    Log Message:
    Add a "repeated" log_msg_t member which tracks repeated log messages.
  156. nightfox
    Mon Mar 19 2018 06:55 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.115 1.116 diff
    xtrn/DDMsgReader/readme.txt 1.12 1.13 diff

    Log Message:
    Version 1.17 beta 57: Made a fix for voting input - It wasn't accepting Q to quit out of voting (a blank input worked though).
  157. nightfox
    Mon Mar 19 2018 06:54 pm PDT

    Modified Files:
    xtrn/SlyVote/SlyVote.js 1.53 1.54 diff
    xtrn/SlyVote/readme.txt 1.12 1.13 diff

    Log Message:
    Version 0.35 beta: Made a fix for non-lightbar voting input - It wasn't accepting Q to quit out of voting (a blank input worked though).
  158. deuce
    Mon Mar 19 2018 05:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.698 1.699 diff

    Log Message:
    Some four spaces to tab conversion at the beginnings of lines.
  159. deuce
    Mon Mar 19 2018 05:10 pm PDT

    Modified Files:
    exec/load/binkp.js 1.100 1.101 diff

    Log Message:
    Inspired by revision 1.36, only reset senteob when we add a file.  Appears
    to work around Radius hang.  Also, in v2 mode, when we're close()ing, try
    to send two M_EOB to help work around weird/broken remotes.
  160. ree
    Mon Mar 19 2018 04:56 pm PDT

    Modified Files:
    exec/websocketservice.js 1.10 1.11 diff

    Log Message:
    Slightly less sucky frame handling
  161. deuce
    Mon Mar 19 2018 04:39 pm PDT

    Modified Files:
    exec/binkit.js 1.64 1.65 diff

    Log Message:
    flush() the lockfile after writing program name.
  162. deuce
    Mon Mar 19 2018 04:01 pm PDT

    Modified Files:
    exec/load/binkp.js 1.99 1.100 diff

    Log Message:
    On a recv() of zero bytes, check if the socket is still connected.
  163. deuce
    Mon Mar 19 2018 02:53 pm PDT

    Modified Files:
    exec/binkit.js 1.63 1.64 diff

    Log Message:
    Make semaphores[] a global and unconditionally touch them at the end of
    the script.
  164. deuce
    Mon Mar 19 2018 02:45 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.218 1.219 diff

    Log Message:
    If select() returns an error, return it rather than forcing the return value
    to zero.
  165. rswindell
    Mon Mar 19 2018 11:49 am PDT

    Modified Files:
    exec/load/binkp.js 1.98 1.99 diff

    Log Message:
    More log details with regards to timeouts and successful authentication.
  166. deuce
    Mon Mar 19 2018 11:41 am PDT

    Modified Files:
    exec/binkit.js 1.62 1.63 diff

    Log Message:
    Ensure semaphores isn't undefined since we're passing it around everywhere
    now.
  167. deuce
    Mon Mar 19 2018 11:12 am PDT

    Modified Files:
    exec/load/binkp.js 1.97 1.98 diff

    Log Message:
    Only use reset_eob() to reset eob counts.  Don't reset the EOB counts except
    for in file transfer related times.
  168. deuce
    Mon Mar 19 2018 11:05 am PDT

    Modified Files:
    exec/load/binkp.js 1.96 1.97 diff

    Log Message:
    Don't send a second M_EOB until we get an M_EOB from the remote.
  169. deuce
    Mon Mar 19 2018 10:55 am PDT

    Modified Files:
    exec/load/binkp.js 1.95 1.96 diff

    Log Message:
    Add comment (pending testing), and fix bug in last commit.
  170. deuce
    Mon Mar 19 2018 10:49 am PDT

    Modified Files:
    exec/load/binkp.js 1.94 1.95 diff

    Log Message:
    For v1.1 connections, send two EOBs before raising the timeout.  It seems that
    Radius/4.010/21.01.2005,13:56(Final-Release)/Win32 will not send an M_EOB
    until it receives two from the remote.
  171. deuce
    Mon Mar 19 2018 10:47 am PDT

    Modified Files:
    exec/load/binkp.js 1.93 1.94 diff

    Log Message:
    No need to send M_EOB while receiving a file, it'll settle out at the end.
  172. deuce
    Mon Mar 19 2018 09:36 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.658 1.659 diff
    src/sbbs3/mailsrvr.h 1.83 1.84 diff
    src/sbbs3/mxlookup.c 1.28 1.29 diff

    Log Message:
    Attempt to fix an apparently crypt object leak in the mail server by having
    mail_close_socket() also destroy the session, and take pointers to set the
    socket to INVALID_SOCKET, and the session to -1.
  173. deuce
    Sun Mar 18 2018 11:59 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.217 1.218 diff
    src/sbbs3/js_socket.h 1.5 1.6 diff

    Log Message:
    Make peek(), nread, data_waiting, and poll() usable for TLS sockets by recv()ing
    a single byte into a special buffer.  Note that peek() and nread will never
    return/indicate more than a single byte, so scripts which rely on these may
    be inefficient with TLS (websocket stuff appears to use nread heavily).
  174. deuce
    Sun Mar 18 2018 11:56 pm PDT

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.85 1.86 diff

    Log Message:
    More whitespace stuff.
  175. deuce
    Sun Mar 18 2018 11:06 pm PDT

    Modified Files:
    exec/load/binkp.js 1.92 1.93 diff

    Log Message:
    Pass the timeout argument to the data recv() call
  176. deuce
    Sun Mar 18 2018 04:19 pm PDT

    Modified Files:
    exec/imapservice.js 1.64 1.65 diff

    Log Message:
    cfgile -> cfgfile
  177. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/templates/default/ftelnet.inc 1.3 1.4 diff
    web/templates/default/ftelnet_external.inc 1.4 1.5 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  178. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/root/members/externals.ssjs 1.7 1.8 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  179. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/root/ftelnet.ssjs 1.5 1.6 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  180. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/templates/nightshade/ftelnet_external.inc 1.4 1.5 diff
    web/templates/nightshade/ftelnet.inc 1.3 1.4 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  181. ree
    Sun Mar 18 2018 01:28 pm PDT

    Modified Files:
    exec/load/ftelnethelper.js 1.6 1.7 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  182. ree
    Sun Mar 18 2018 01:28 pm PDT

    Modified Files:
    exec/websocketservice.js 1.9 1.10 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  183. rswindell
    Sun Mar 18 2018 12:32 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.189 1.190 diff

    Log Message:
    Fix Win32 link failure (e.g. unresolved getsockopt): when iniFile functions are
    used, that requires a socket lib too. util builds (that don't need the .ini
    file functions), they #define NO_SOCKET_SUPPORT, so exclude the user/####.ini
    support functions in that case too.
  184. deuce
    Sun Mar 18 2018 11:34 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.216 1.217 diff

    Log Message:
    Log which attribute couldn't be set.
  185. deuce
    Sun Mar 18 2018 09:57 am PDT

    Modified Files:
    exec/imapservice.js 1.63 1.64 diff

    Log Message:
    Only unlock/save the config if it's been opened.
    Fixes errors on sessions that do not authenticate before disconnecting.
  186. deuce
    Sat Mar 17 2018 09:42 pm PDT

    Modified Files:
    exec/load/binkp.js 1.91 1.92 diff

    Log Message:
    TLS is apparently causing issues, remove it since nobody else supports it
    anyway.
  187. rswindell
    Sat Mar 17 2018 08:48 pm PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.269 1.270 diff

    Log Message:
    Move all the remaining status_startup bits inside the #ifdef __unix__ block
    since it's not defined otherwise. Not sure if this ways intended to be
    included in Windows builds or not.
  188. rswindell
    Sat Mar 17 2018 05:00 pm PDT

    Modified Files:
    exec/binkit.js 1.61 1.62 diff

    Log Message:
    * When polling a node and receiving files, the semaphore files would not
      be touched - fixed (and debug-log output for each semfile touched).
    * When using the "install" command, the "BINKP" service won't be added to
      the services.ini file if a "BINKIT" or a "BINKP" service already exists.
  189. rswindell
    Sat Mar 17 2018 03:52 pm PDT

    Modified Files:
    exec/binkit.js 1.60 1.61 diff

    Log Message:
    Attempt to fix:
    Mar 17 14:15:56 trmb synchronet: srvc 0052 BINKP !JavaScript  /sbbs/exec/binkit
    .js line 862: TypeError: this.command is undefined
  190. deuce
    Sat Mar 17 2018 12:57 am PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.268 1.269 diff

    Log Message:
    Fix reported service for stat_*() callbacks.
  191. deuce
    Sat Mar 17 2018 12:51 am PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.5 1.6 diff

    Log Message:
    Fix up handling of disconnected sockets.
  192. deuce
    Sat Mar 17 2018 12:38 am PDT

    Modified Files:
    src/sbbs3/showstat.c 1.4 1.5 diff

    Log Message:
    Don't bother showing client_t info when a client disconnects... it's always
    NULL
  193. deuce
    Sat Mar 17 2018 12:35 am PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.4 1.5 diff

    Log Message:
    We must be much more clever with the client_t stuff in the lists...
    Always store the prot and user with the client_t to avoid even worse
    headaches.
    
    This makes the client update a bit trickier, but it seems to be good now.
  194. deuce
    Fri Mar 16 2018 11:45 pm PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.267 1.268 diff

    Log Message:
    Stat the status thread much later.
  195. deuce
    Fri Mar 16 2018 11:13 pm PDT

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.84 1.85 diff

    Log Message:
    Whitespace cleanup.
  196. deuce
    Fri Mar 16 2018 10:44 pm PDT

    Modified Files:
    install/GNUmakefile 1.73 1.74 diff

    Log Message:
    Install the new showstat utility.
  197. deuce
    Fri Mar 16 2018 10:43 pm PDT

    Modified Files:
    src/sbbs3/GNUmakefile 1.229 1.230 diff
    src/sbbs3/objects.mk 1.68 1.69 diff
    src/sbbs3/sbbscon.c 1.266 1.267 diff
    src/sbbs3/targets.mk 1.45 1.46 diff

    Log Message:
    Tie the new out of process thing into the build... not tested on Linux or
    Windows
  198. deuce
    Fri Mar 16 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/showstat.c 1.3 1.4 diff

    Log Message:
    Support authentication and the new SERVICE_STATUS
  199. deuce
    Fri Mar 16 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.3 1.4 diff
    src/sbbs3/sbbs_status.h 1.2 1.3 diff

    Log Message:
    Make the status thread a "proper" thread with a startup_t, callbacks, etc.
  200. deuce
    Fri Mar 16 2018 09:24 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.462 1.463 diff

    Log Message:
    That was likely supposed to be a semi-colon.
  201. deuce
    Fri Mar 16 2018 08:06 pm PDT

    Modified Files:
    src/sbbs3/showstat.c 1.2 1.3 diff

    Log Message:
    Fix buf declaration, add missing newline.
  202. deuce
    Fri Mar 16 2018 08:05 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.2 1.3 diff

    Log Message:
    client_on can be called with a NULL client, so we have to handle that too.
  203. deuce
    Fri Mar 16 2018 07:45 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.h 1.1 1.2 diff
    src/sbbs3/sbbs_status.c 1.1 1.2 diff
    src/sbbs3/showstat.c 1.1 1.2 diff

    Log Message:
    Fix handling of client_t char * fields.
  204. rswindell
    Fri Mar 16 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/atcodes.cpp 1.79 1.80 diff
    src/sbbs3/chat.cpp 1.75 1.76 diff
    src/sbbs3/echocfg.c 3.28 3.29 diff
    src/sbbs3/filedat.c 1.38 1.39 diff
    src/sbbs3/scfglib.h 1.22 1.23 diff
    src/sbbs3/scfglib2.c 1.45 1.46 diff
    src/sbbs3/services.c 1.316 1.317 diff
    src/sbbs3/xtrn_sec.cpp 1.83 1.84 diff

    Log Message:
    Address coverity-scan reported issues.
  205. rswindell
    Fri Mar 16 2018 07:21 pm PDT

    Modified Files:
    src/uifc/uifcx.c 1.33 1.34 diff

    Log Message:
    Address coverity-scan defect (unterminated string).
  206. deuce
    Fri Mar 16 2018 11:32 am PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.265 1.266 diff

    Log Message:
    Fix WTF indentation and braces.
  207. deuce
    Fri Mar 16 2018 10:50 am PDT

    Modified Files:
    exec/imapservice.js 1.62 1.63 diff

    Log Message:
    Support "binary" storage of Seen flags.  This greatly reduces the size of
    the data/users/000x.imap files when many messages have been seen.
  208. deuce
    Fri Mar 16 2018 09:13 am PDT

    Modified Files:
    exec/imapservice.js 1.61 1.62 diff

    Log Message:
    Typo in last commit?  Say it ain't so!
  209. deuce
    Fri Mar 16 2018 09:12 am PDT

    Modified Files:
    exec/imapservice.js 1.60 1.61 diff

    Log Message:
    Add -d and -r options to control debug and debugRX respectively... no need
    to spam the log unless you're working on the script itself.
  210. deuce
    Fri Mar 16 2018 09:08 am PDT

    Modified Files:
    exec/imapservice.js 1.59 1.60 diff

    Log Message:
    Ensure we can open the message base before including it in a LIST/LSUB
    response.
  211. deuce
    Fri Mar 16 2018 08:31 am PDT

    Modified Files:
    exec/imapservice.js 1.58 1.59 diff

    Log Message:
    Open the config file unbuffered to help with concurrency.
  212. deuce
    Fri Mar 16 2018 08:24 am PDT

    Modified Files:
    exec/imapservice.js 1.57 1.58 diff

    Log Message:
    Pass the index to operate on to apply_seen.
    Fixes issues with STATUS command.
  213. deuce
    Fri Mar 16 2018 08:04 am PDT

    Modified Files:
    exec/imapservice.js 1.56 1.57 diff

    Log Message:
    Pass the base to get_base_code() so that commands such as STATUS that don't
    have a selected base can use it.
  214. deuce
    Fri Mar 16 2018 08:01 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.215 1.216 diff

    Log Message:
    Update Socket.recvline() for new js_socket_recv() TLS semantics.
    Fixes recvline() returning an zero-length "line" on timeouts, which causes
    infinite loops and 100% CPU utilization with IMAPv4-TLS service (and likely
    any other service that uses recvline with a short timeout).
  215. rswindell
    Thu Mar 15 2018 11:06 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.697 1.698 diff

    Log Message:
    Adjusted log output:
    Added "Node # SSH" to a lot of SSH-related log messages.
    Lowered the severity of the SSH "attempt to use channel" msg from ERROR
    to WARNING.
    Removed "last:" from temp-ban message when there is no last-used username.
  216. rswindell
    Thu Mar 15 2018 10:30 pm PDT

    Modified Files:
    src/sbbs3/execfunc.cpp 1.41 1.42 diff

    Log Message:
    Save the last sent-to netmail address and re-use the address automatically
    when creating a new netmail message. Not exactly an "address book", but a
    convenience nonetheless.
  217. rswindell
    Thu Mar 15 2018 10:26 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.188 1.189 diff
    src/sbbs3/userdat.h 1.67 1.68 diff

    Log Message:
    Added some functions to read/write to the data/user/*.ini files.
    I'm calling these "user properties", but that might change.
  218. rswindell
    Thu Mar 15 2018 10:24 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.159 1.160 diff
    src/xpdev/ini_file.h 1.53 1.54 diff

    Log Message:
    Added iniSetValue() which, like iniGetValue(), does not support string
    literals (e.g. won't detect and escape them automatically). If you set
    a key value with carriage-returns and line-feeds, those will end up in the
    .ini file as-is, so use with caution.
  219. deuce
    Thu Mar 15 2018 07:39 pm PDT

    Modified Files:
    exec/binkit.js 1.59 1.60 diff

    Log Message:
    Better log messages when locks fail and aren't old enough to take over.
  220. deuce
    Thu Mar 15 2018 07:30 pm PDT

    Modified Files:
    exec/load/binkp.js 1.90 1.91 diff

    Log Message:
    Fixes for v1.0 mode...
    1) Don't reset eob counts for sent or got.
    2) Ensure M_GET is never sent in v1.0 mode.
    3) Only send one M_EOB in v1.0 mode, even if we add to the list with M_GET
    
    This should cover all the bases, but FREQ may be non-conformant.
  221. deuce
    Thu Mar 15 2018 07:08 pm PDT

    Modified Files:
    exec/load/binkp.js 1.89 1.90 diff

    Log Message:
    Overhaul EOB handling... just count them, and reset both to zero on non-EOB
    in either direction.
    
    For v1.0, a single EOB in both directions terminates the session and for
    v1.1, two EOBs in both directions terminates.
    
    This should greatly simplify the overly complicated senteob/sentempty/goteob/
    gotempty logic and completely eliminate loops.  Biggest risk with this change
    is issues with v1.0 servers.
  222. deuce
    Thu Mar 15 2018 06:39 pm PDT

    Modified Files:
    exec/load/binkp.js 1.88 1.89 diff

    Log Message:
    Terminate string.
  223. deuce
    Thu Mar 15 2018 06:35 pm PDT

    Modified Files:
    exec/load/binkp.js 1.87 1.88 diff

    Log Message:
    Add some temporary debug logspam.
  224. rswindell
    Thu Mar 15 2018 04:56 pm PDT

    Modified Files:
    src/sbbs3/un_qwk.cpp 1.51 1.52 diff

    Log Message:
    Ignore (and delete) TOREADER.EXT (a QWKE additional metadata file) if it
    exists in a .QWK packet. Also, delete the other control/metadata files
    case-insensitively (just in case).
  225. deuce
    Thu Mar 15 2018 04:32 pm PDT

    Modified Files:
    exec/load/binkp.js 1.86 1.87 diff

    Log Message:
    Push an M_SKIP into the failed_sent_files() from the pending_ack array, not
    from the currently sending file, since the pending ack should always be there,
    but sending often won't be.  Also, log a warning when pending_ack isn't empty
    and we get an M_EOB.
  226. deuce
    Thu Mar 15 2018 03:39 pm PDT

    Modified Files:
    exec/load/binkp.js 1.85 1.86 diff

    Log Message:
    Add a new send_chunks() method which will deal with short send() calls.
    We can't rely on our send buffers being infinite anymore.
  227. deuce
    Thu Mar 15 2018 03:21 pm PDT

    Modified Files:
    exec/load/binkp.js 1.84 1.85 diff

    Log Message:
    Fix handling of timeouts vs. errors... they're not the same, so don't treat
    them that way.  Also, ensure there's a timeout on the second byte of the
    packet header since we toss out the first byte if the second byte times out
    (they should pretty much always be in the same packet, but why take the risk?)
  228. deuce
    Thu Mar 15 2018 03:07 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.214 1.215 diff

    Log Message:
    Add missing else in last commit.
  229. deuce
    Thu Mar 15 2018 03:06 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.213 1.214 diff

    Log Message:
    Have the return value of js_socket_recv() have something vaugely to do with
    the return value if recv() for non-TLS sockets.
  230. deuce
    Thu Mar 15 2018 02:56 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.212 1.213 diff

    Log Message:
    Fix ret/copied confusion in last commit.
  231. deuce
    Thu Mar 15 2018 02:42 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.696 1.697 diff

    Log Message:
    Fix unterminated string usage.
  232. deuce
    Thu Mar 15 2018 02:40 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.211 1.212 diff

    Log Message:
    Fix up js_recv_socket() some more... add explicit MSG_WAITALL support for
    TLS, use MSG_WAITALL for reading integers, add a time() based timeout,
    return as soon as any bytes are read (including zero), and generally
    behave more closely to how recv() itself behaves.
  233. deuce
    Thu Mar 15 2018 12:46 pm PDT

    Modified Files:
    exec/load/lightbar.js 1.34 1.35 diff

    Log Message:
    Fix typo in comment
  234. echicken
    Thu Mar 15 2018 12:22 pm PDT

    Modified Files:
    exec/load/http.js 1.40 1.41 diff

    Log Message:
    Ditch the 'self' stuff and give forEach a thisArg instead.
  235. echicken
    Thu Mar 15 2018 11:28 am PDT

    Modified Files:
    exec/load/http.js 1.39 1.40 diff

    Log Message:
    That 'this' was not the 'this' that your 'self' was looking for there then.
    May resolve the error reported by Bill McGarrity (this.extra_headers is
    undefined).
  236. deuce
    Thu Mar 15 2018 02:27 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.210 1.211 diff

    Log Message:
    The timeout to Socket.recv() is the *SECOND* argument, not a copy of the
    first one.
  237. deuce
    Thu Mar 15 2018 02:17 am PDT

    Modified Files:
    exec/load/binkp.js 1.83 1.84 diff

    Log Message:
    Don't use a separate OPT line for TLS, it seems to mess up
    Radius/4.010/21.01.2005,13:56(Final-Release)/Win32
  238. deuce
    Thu Mar 15 2018 01:59 am PDT

    Modified Files:
    exec/load/binkp.js 1.82 1.83 diff

    Log Message:
    Since we're supporting TLS now, use the sock.recv() timeout parameter instead
    of poll()ing for each byte.
  239. deuce
    Thu Mar 15 2018 01:52 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.209 1.210 diff

    Log Message:
    Re-enable recv timeouts for TLS sessions.  It was #ifdef'd out for some
    reason.
  240. deuce
    Thu Mar 15 2018 01:34 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.208 1.209 diff

    Log Message:
    Fix misuse of SSL_OPTIONS in last commit.
  241. deuce
    Thu Mar 15 2018 01:27 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.207 1.208 diff

    Log Message:
    For right now, don't verify server names in certificates.  This will need
    to be changed to something the individual clients can frob in the near
    future.
  242. deuce
    Thu Mar 15 2018 01:16 am PDT

    Modified Files:
    exec/load/binkp.js 1.81 1.82 diff

    Log Message:
    We need to send M_NUL "OPT TLS" before M_NUL "OPT CRYPT".
  243. deuce
    Thu Mar 15 2018 01:13 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.695 1.696 diff

    Log Message:
    We certainly can't re-use i for error return values when it's how many
    bytes have been sent!
  244. deuce
    Thu Mar 15 2018 12:58 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.694 1.695 diff

    Log Message:
    More hacks to work around a known bug in Cryptlib SSH...
    "Sometimes" the write timeout value is used for read timeouts.  Since we
    use a read timeout of zero, and a mutex, this can cause some serious delays
    in SSH processing.  As a workaround, we set the write timeout to zero.
    However, a flush failure has historically been fatal.
    
    So, we now change the write timeout to one second just before a flush, and
    have a flush timeout not be fatal anymore... we set it back to zero after
    the flush.
    
    The fiddling with the write timouts will be removed once the bug is fixed,
    but the flush timout not being fatal may stay forever... add some comments
    to remind us to remove the hack in the future.
  245. rswindell
    Thu Mar 15 2018 12:45 am PDT

    Modified Files:
    3rdp/win32.release/cryptlib/bin/cl32.dll 1.5 1.6 diff
    3rdp/win32.release/cryptlib/bin/cl32.lib 1.5 1.6 diff

    Log Message:
    Updated 3.4.4 with Deuce's latest patches.
  246. deuce
    Thu Mar 15 2018 12:28 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.693 1.694 diff

    Log Message:
    Connections without a "session" channel get treated as a dupe-free failed
    attempt.
  247. rswindell
    Thu Mar 15 2018 12:20 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.187 1.188 diff

    Log Message:
    When loginFailure() is called with a NULL username, always treat it as a
    "unique" login attempt (e.g. hack attempt).
  248. deuce
    Thu Mar 15 2018 12:05 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.692 1.693 diff

    Log Message:
    badlogin() can't be used for SSH sessions that are terminated early, this
    code merely introduced a 5 second delay in the Node 0 thread.
  249. deuce
    Wed Mar 14 2018 04:41 pm PDT

    Modified Files:
    exec/load/binkp.js 1.80 1.81 diff

    Log Message:
    Copy the comment about VER Internet Rex 2.29 Win32 (binkp/1.1) to where
    the challenge length is set and add a TODO comment there.
  250. deuce
    Wed Mar 14 2018 04:31 pm PDT

    Modified Files:
    exec/load/binkp.js 1.79 1.80 diff

    Log Message:
    Remove magical return type of auth callback.
  251. deuce
    Wed Mar 14 2018 04:30 pm PDT

    Modified Files:
    exec/binkit.js 1.58 1.59 diff

    Log Message:
    If there is at least one password mismatch, and there are zero password
    matches, send an M_ERR to the remote and leave the address list empty.
  252. deuce
    Wed Mar 14 2018 03:48 pm PDT

    Modified Files:
    exec/imapservice.js 1.55 1.56 diff

    Log Message:
    It seems many IMAP clients open multiple connections to the server, and
    expect the Seen flags to be coherent across them... support this by leaving
    the users IMAP status file open, and holding a lock on the first byte.
    
    We now need to flush changes to the status file more often, and we need
    to call file.flush() before unlocking.
  253. rswindell
    Wed Mar 14 2018 03:01 pm PDT

    Modified Files:
    exec/binkit.js 1.57 1.58 diff

    Log Message:
    Fix reserved logic of 'nomd5' option check:
    nomd5 means "plain-text passwords are okay" (AllowPlainPasswords=true)
  254. deuce
    Wed Mar 14 2018 11:23 am PDT

    Modified Files:
    exec/load/binkp.js 1.78 1.79 diff

    Log Message:
    Add TLS support to binkp.
    
    The *first* packet from the answering side *must* be an M_NUL "OPT TLS".
    If this is the case, the originating size responds with an M_NUL "OPT TLS".
    After this, the answering system performs a server TLS handshake, and the
    originating system performs a client TLS handshake.
    
    OPT CRYPT is not used in this case (ie: not crypt over TLS)
  255. rswindell
    Tue Mar 13 2018 11:04 pm PDT

    Modified Files:
    exec/postmsg.js 1.1 1.2 diff

    Log Message:
     Allow sub-code value of 'mail'
  256. rswindell
    Tue Mar 13 2018 10:55 pm PDT

    Modified Files:
    src/smblib/smbstr.c 1.28 1.29 diff

    Log Message:
    smb_netaddr_type() will now recognize an FTN-style address without a 
    "user@" prefix.
  257. rswindell
    Tue Mar 13 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.125 1.126 diff

    Log Message:
    Use smb_hfield_netaddr() to properly support FidoNet netmail via the 'n'
    (import netmail) command along with the '-n' option to set the recipient
    net address (and network type). Previously, only Internet or QWK netmail
    was supported.
  258. deuce
    Tue Mar 13 2018 10:39 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.691 1.692 diff

    Log Message:
    Actually, anything except failure to send credentials should count as a
    bad login.
  259. deuce
    Tue Mar 13 2018 10:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.690 1.691 diff

    Log Message:
    Toss invalid session connections into badlogin().
  260. deuce
    Tue Mar 13 2018 07:47 pm PDT

    Modified Files:
    exec/load/utf8_ascii.js 1.2 1.3 diff

    Log Message:
    Fix error in last commit.
  261. deuce
    Tue Mar 13 2018 07:25 pm PDT

    Modified Files:
    exec/imapservice.js 1.54 1.55 diff

    Log Message:
    Handle an uncommon error a bit better... maybe.
  262. deuce
    Tue Mar 13 2018 07:19 pm PDT

    Modified Files:
    web/templates/nightshade/footer.inc 1.1 1.2 diff
    web/templates/nightshade/main.inc 1.3 1.4 diff

    Log Message:
    Do the https:// thing to <img src="http://... stuff in nightshade too.
  263. deuce
    Tue Mar 13 2018 07:17 pm PDT

    Modified Files:
    web/templates/default/footer.inc 1.11 1.12 diff

    Log Message:
    Use the https:// link for the W3 image for that sweet green lock.
  264. rswindell
    Tue Mar 13 2018 03:13 pm PDT

    Modified Files:
    exec/binkit.js 1.56 1.57 diff

    Log Message:
    More detailed log output in inbound_auth_cb() to help debug why
    inbound Mystic sessions are failing (e.g. with Al@TRMB's BinkIt mailer).
  265. deuce
    Tue Mar 13 2018 10:29 am PDT

    Modified Files:
    exec/letsyncrypt.js 1.31 1.32 diff

    Log Message:
    ACMEv2 endpoint is now live.  See the wiki for how to automate TLS certificates
    with Synchronet.
  266. rswindell
    Mon Mar 12 2018 11:22 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.124 1.125 diff

    Log Message:
    Fix bug introduced in rev 1.119: When reading in the msgbase index
    (.sid file), don't divide the fread() results (it's already in number of
    records read). This could cause msgbase maintenance to not take place
    or corruption of a msg base.
  267. deuce
    Mon Mar 12 2018 11:16 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.206 1.207 diff

    Log Message:
    Don't log orderly shutdowns, even at debug level.  This is mostly because
    my jsexec includes debug output... and this is super-normal.
  268. deuce
    Mon Mar 12 2018 10:55 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.662 1.663 diff

    Log Message:
    Fix handling of cryptPushData() and cryptFlushData() success correctly.
    Also, change READTIMEOUT back to zero since that issue is fixed now.
  269. rswindell
    Mon Mar 12 2018 10:10 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.689 1.690 diff

    Log Message:
    Upper-case the timed event internal code and display it in more of the
    log messages.
  270. deuce
    Mon Mar 12 2018 07:00 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.38 1.39 diff

    Log Message:
    Make CRYPT_ERROR_NOSECURE a warning, not an error.  There appear to be
    SSLv3 (!) and even SSLv2(!!) clients still in the wild.  Sysops aren't
    expected to be able to fix other peoples ancient broken stuff.
  271. deuce
    Mon Mar 12 2018 06:58 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.688 1.689 diff

    Log Message:
    No matter the reason we don't get the channel type, still disconnect
    the SSH session.  Also, do an INFO level log entry to indicate what
    happened to your socket.
  272. deuce
    Mon Mar 12 2018 06:32 pm PDT

    Modified Files:
    3rdp/build/GNUmakefile 1.41 1.42 diff
    3rdp/build/cl-short-client-name.patch NONE 1.1 diff

    Added Files:
    	cl-short-client-name.patch 
    Log Message:
    Allow even shorter SSH client names... specifically, SSH-2.0-Go
  273. deuce
    Mon Mar 12 2018 06:23 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.687 1.688 diff

    Log Message:
    Set the TX channel before reading the primary channel type.  Also add
    missing "SSH" when logging channel use errors.
  274. deuce
    Mon Mar 12 2018 05:41 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.205 1.206 diff

    Log Message:
    Limit push size to 8k.  Fixes issue in the IMAP server where ver large
    sends would cause MAC errors.
  275. deuce
    Mon Mar 12 2018 12:22 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.657 1.658 diff

    Log Message:
    Pedanticaly, rsp may not be three characters long (yes, it always will),
    so support that.
  276. deuce
    Mon Mar 12 2018 12:20 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.656 1.657 diff

    Log Message:
    Fix issue where the last line of a multi-line response wasn't searched
    for a match... which caused a memory leak.
    
    Thanks scan-build!
  277. deuce
    Mon Mar 12 2018 12:11 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.655 1.656 diff

    Log Message:
    sendmail_open_socket() will close the passed socket if it's not INVALID_SOCKET
    So, we really should initialize sock to INVALID_SOCKET before calling it.
    
    This should fix the "random descriptors are closed" issue.
  278. deuce
    Mon Mar 12 2018 11:26 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.686 1.687 diff

    Log Message:
    Remove unused variables.
  279. deuce
    Mon Mar 12 2018 11:24 am PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.461 1.462 diff
    src/sbbs3/sbbs.h 1.475 1.476 diff
    src/sbbs3/websrvr.c 1.661 1.662 diff

    Log Message:
    More log fixes.
  280. deuce
    Mon Mar 12 2018 11:11 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.654 1.655 diff

    Log Message:
    Fix incorrect log messages.
  281. deuce
    Mon Mar 12 2018 11:07 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.685 1.686 diff

    Log Message:
    Now that we've fixed the zero timeout on rx issue, we can set the rx timeout
    to zero again.  Unfortunately, there appears to be a related bug where the
    TX timeout is sometimes used for RX... that's OK, we'll just set them both
    to zero.
    
    Also, deal with secondary channels (ie: forwarded ports).  For now, we just
    close these channels any time we get data on them.  In the future, we can
    do scp/sftp pretty easily now... though neither is likely to ever work with
    the sysop account due to the system password requirement.
    
    This change ABSOLUTELY REQUIRES an updated cryptlib.  Windows guys don't
    update until DigitalMan commits cl.lib or whatever it's called.
  282. deuce
    Mon Mar 12 2018 10:52 am PDT

    Modified Files:
    3rdp/build/GNUmakefile 1.40 1.41 diff
    3rdp/build/cl-select-fix.patch NONE 1.1 diff

    Added Files:
    	cl-select-fix.patch 
    Log Message:
    Add fix for ioWait() to guarantee at least one iteration through the select()
    loop even when the timeout is zero.
  283. rswindell
    Sun Mar 11 2018 08:21 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.315 1.316 diff

    Log Message:
    NNTPS/TLS looks funny. Let's go with a "<svc/prot> TLS" instead.
  284. rswindell
    Sun Mar 11 2018 05:21 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.460 1.461 diff
    src/sbbs3/js_socket.c 1.204 1.205 diff
    src/sbbs3/mailsrvr.c 1.653 1.654 diff
    src/sbbs3/services.c 1.314 1.315 diff
    src/sbbs3/websrvr.c 1.660 1.661 diff

    Log Message:
    Added "TLS" (or "/TLS") to the cryptlib-related log messages.
  285. rswindell
    Sun Mar 11 2018 02:30 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.684 1.685 diff
    src/sbbs3/sbbs.h 1.474 1.475 diff
    src/sbbs3/js_socket.c 1.203 1.204 diff

    Log Message:
    Created and used call_socket_open_callback() to track the sockets opened
    via JS Socket->xpms_accept().
    Also, use do_js_close() to eliminate some repeated code in js_socket.c.
  286. rswindell
    Sun Mar 11 2018 02:29 pm PDT

    Modified Files:
    src/sbbs3/inkey.cpp 1.54 1.55 diff

    Log Message:
    When using Ctrl-T to display time info (globally), if the time left has
    been reduced due to an upcoming event, say so here.
  287. rswindell
    Sun Mar 11 2018 02:28 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.652 1.653 diff

    Log Message:
    A little more debug-level log output around the saving of receiving
    msgs and SPAM database lookup.
  288. rswindell
    Sun Mar 11 2018 02:27 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.54 1.55 diff

    Log Message:
    Fix another memory leak found by scan-build (in an error condition).
  289. rswindell
    Sun Mar 11 2018 02:24 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.35 1.36 diff

    Log Message:
    Overhaul the "System FidoNet Addresses" configuration menu - mainly just
    to add CUT/COPY/PASTE support, but also some beautification and sensible
    updates.
  290. rswindell
    Sun Mar 11 2018 01:59 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.34 1.35 diff

    Log Message:
    Remove the deprecated "Default Outbound FidoNet NetMail Address"
    option.
  291. nightfox
    Sat Mar 10 2018 05:57 pm PST

    Modified Files:
    exec/filearea-lb.js 1.4 1.5 diff

    Log Message:
    Fixed a typo in one of the comments
  292. rswindell
    Sat Mar 10 2018 05:36 pm PST

    Modified Files:
    exec/load/binkp.js 1.77 1.78 diff

    Log Message:
    Log the peer mailer version report with a LOG_INFO level message.
  293. nightfox
    Sat Mar 10 2018 05:24 pm PST

    Modified Files:
    exec/filearea-lb.js 1.3 1.4 diff

    Log Message:
    Made use of cnflib.js to load file.cnf to get the viewable file types information.  This requires the latest cnflib.js (and cnfdefs.js) in the load directory.  Also, in the file listing, changed the info command from Enter to I.  This saves a little space on the help bar at the bottom, and I think it's more consistent with using letters for the other commands.  (I also wanted to be able to use the enter key for something else, which I might do as my own custom mod on my BBS, as I make it look & work more like my Baja file lister mod.)
  294. rswindell
    Sat Mar 10 2018 04:43 pm PST

    Added Files:
    exec/dumpcnfs.js NONE 1.1 diff

    Log Message:
    Example use of load/cnflib.js (and cnfdefs.js)
  295. rswindell
    Sat Mar 10 2018 04:42 pm PST

    Modified Files:
    exec/load/cnfdefs.js 1.5 1.6 diff

    Log Message:
    Renamed msg.msg_misc (bit-field) to msg.settings, for consistency.
  296. nightfox
    Sat Mar 10 2018 04:30 pm PST

    Modified Files:
    exec/filearea-lb.js 1.2 1.3 diff

    Log Message:
    The main function now updates bbs.node_action to NODE_LFIL to indicate that the user is listing files.  bbs.node_action is restored to the previous value upon exit of the main function.
    Also I forgot to mention in my last commit that I added an optional command-line argument to specify a file directory internal code so that this script can (optionally) start at the file list for a file directory rather than the file group chooser.  This allows a command shell to run this script for the 'List files in directory' command (with bbs.curdir_code as the first argument).
  297. rswindell
    Sat Mar 10 2018 01:40 pm PST

    Modified Files:
    exec/load/cnfdefs.js 1.4 1.5 diff
    exec/load/cnflib.js 1.12 1.13 diff

    Log Message:
    Added file.cnf support (Nightfox, you could use this for your filearea-lb
    module).
    Also fixed a couple of field names (to match the Sync-JS model) in the
    msgs.cnf representation (e.g. op_ars -> operator_ars).
  298. nightfox
    Sat Mar 10 2018 12:23 pm PST

    Modified Files:
    exec/filearea-lb.js 1.1 1.2 diff

    Log Message:
    Added a V command to the file directory list to allow viewing a file.  This is done by reading ctrl/file.cnf (based on the read_file_config function in src/sbbs3/scfglib2.c), matching the filename extension in the list, and if found, it runs the file view command using bbs.exec().
    
    If possible, it would be useful to add the ability for sysops to move and delete files from this file lister (as in the stock file lister), but I'm not sure how feasable that would be right now.
  299. rswindell
    Sat Mar 10 2018 12:14 pm PST

    Modified Files:
    exec/load/binkp.js 1.76 1.77 diff

    Log Message:
    Allow the default CRAM challenge length (16 bytes) to be overridden
    (e.g. for experimental purposes) via binkit.ini:
    cram_challenge_length = <length in bytes>
  300. rswindell
    Sat Mar 10 2018 12:13 pm PST

    Modified Files:
    exec/binkit.js 1.55 1.56 diff

    Log Message:
    Allow the default CRAM challenge length (16 bytes) to be overridden
    (e.g. for experimental purposes) via binkit.ini:
    cram_challenge_length = <length in bytes>
  301. deuce
    Sat Mar 10 2018 02:16 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.202 1.203 diff

    Log Message:
    Have do_CryptFlush() return a bool.
    Also some whitespace cleanup.
  302. deuce
    Sat Mar 10 2018 02:04 am PST

    Modified Files:
    src/sbbs3/ssl.c 1.37 1.38 diff

    Log Message:
    Lower CRYPT_ERROR_INTERNAL to NOTICE.  Not sure the sysop can do anything
    about these.
  303. deuce
    Sat Mar 10 2018 01:50 am PST

    Modified Files:
    src/conio/x_cio.c 1.48 1.49 diff

    Log Message:
    Don't start the mouse thread until after video init is successful.
    Prevents x11 mouse thread from running when ciolib falls back past it
    (ie: to curses mode)
  304. deuce
    Sat Mar 10 2018 01:20 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.651 1.652 diff

    Log Message:
    Mail server is guilty too.
  305. deuce
    Sat Mar 10 2018 01:17 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.201 1.202 diff

    Log Message:
    Not every crypt error is due to flushing data!
  306. deuce
    Sat Mar 10 2018 12:50 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.650 1.651 diff

    Log Message:
    Re-fix warnings, but be sane about it this time.
  307. deuce
    Sat Mar 10 2018 12:09 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.649 1.650 diff
    src/sbbs3/main.cpp 1.683 1.684 diff

    Log Message:
    Fix indentation.
  308. deuce
    Sat Mar 10 2018 12:00 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.648 1.649 diff
    src/sbbs3/main.cpp 1.682 1.683 diff

    Log Message:
    Open cryptlib.key read-only (also, be cooler)
  309. deuce
    Fri Mar 09 2018 11:32 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.36 1.37 diff

    Log Message:
    Make CRYPT_ERROR_NOTAVAIL LOG_INFO level.
  310. deuce
    Fri Mar 09 2018 11:27 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.647 1.648 diff

    Log Message:
    Oh yeah, that's WAY cooler.
  311. deuce
    Fri Mar 09 2018 11:17 pm PST

    Modified Files:
    src/sbbs3/smbutil.c 1.123 1.124 diff

    Log Message:
    Fix last Clang warning.
  312. deuce
    Fri Mar 09 2018 11:15 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.646 1.647 diff

    Log Message:
    Fix unaligned pointer access warnings from Clang.
  313. deuce
    Fri Mar 09 2018 11:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.459 1.460 diff
    src/sbbs3/js_socket.c 1.200 1.201 diff
    src/sbbs3/mailsrvr.c 1.645 1.646 diff
    src/sbbs3/main.cpp 1.681 1.682 diff
    src/sbbs3/services.c 1.313 1.314 diff
    src/sbbs3/smbutil.c 1.122 1.123 diff
    src/sbbs3/websrvr.c 1.659 1.660 diff

    Log Message:
    "If you alloc() in a DLL, thou shalt free() in the same DLL"
    -- Albert Einstein
  314. deuce
    Fri Mar 09 2018 10:42 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.60 1.61 diff

    Log Message:
    Call va_end() on errors as well.
  315. deuce
    Fri Mar 09 2018 10:34 pm PST

    Modified Files:
    src/sbbs3/services.c 1.312 1.313 diff

    Log Message:
    Add missing NULL check.
  316. deuce
    Fri Mar 09 2018 10:30 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.680 1.681 diff

    Log Message:
    Add "SSH" to all the cryptlib SSH logging.
  317. deuce
    Fri Mar 09 2018 10:20 pm PST

    Modified Files:
    src/sbbs3/writemsg.cpp 1.121 1.122 diff

    Log Message:
    And another of the same warnings.
  318. rswindell
    Fri Mar 09 2018 10:20 pm PST

    Modified Files:
    src/sbbs3/useredit.cpp 1.49 1.50 diff

    Log Message:
    Address clang warning: comparison of unsigned expression < 0 is always false
    getstr() does not return < 0, ever (it returns 0 on abort).
    Added more abort-checks after calls to getstr().
  319. deuce
    Fri Mar 09 2018 10:19 pm PST

    Modified Files:
    src/sbbs3/writemsg.cpp 1.120 1.121 diff

    Log Message:
    Fix warning.
  320. deuce
    Fri Mar 09 2018 10:17 pm PST

    Modified Files:
    src/sbbs3/un_rep.cpp 1.62 1.63 diff

    Log Message:
    Fix warning.
  321. deuce
    Fri Mar 09 2018 10:16 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.679 1.680 diff

    Log Message:
    Fix warnings.
  322. deuce
    Fri Mar 09 2018 10:12 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.372 1.373 diff

    Log Message:
    Fix warnings.
  323. deuce
    Fri Mar 09 2018 10:11 pm PST

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.83 1.84 diff

    Log Message:
    Fix warnings.
  324. rswindell
    Fri Mar 09 2018 10:08 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.678 1.679 diff
    src/sbbs3/js_system.c 1.169 1.170 diff

    Log Message:
    Fix more memory leaks (in error conditions) discovered by clang scan-build.
  325. rswindell
    Fri Mar 09 2018 10:05 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.35 1.36 diff

    Log Message:
    Fix get_ssl_cert() initialization of the error string pointer.
  326. rswindell
    Fri Mar 09 2018 09:13 pm PST

    Modified Files:
    src/sbbs3/userdat.c 1.186 1.187 diff

    Log Message:
    Fix some suspicious typos found via clang warnings.
  327. deuce
    Fri Mar 09 2018 08:49 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.644 1.645 diff

    Log Message:
    Remove unused variable.
  328. deuce
    Fri Mar 09 2018 08:49 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.677 1.678 diff

    Log Message:
    Use new cryptlib log stuff for SSH.
  329. deuce
    Fri Mar 09 2018 08:47 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.34 1.35 diff

    Log Message:
    CRYPT_ENVELOPE_RESOURCE is debug-level as well.
  330. rswindell
    Fri Mar 09 2018 08:34 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.458 1.459 diff

    Log Message:
    Elminated the redundnat "XXX Server listening" log messages
    (the multisock stuff already logs this for each interface and port).
  331. rswindell
    Fri Mar 09 2018 08:29 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.676 1.677 diff

    Log Message:
    Elminated the redundnat "XXX Server listening" log messages
    (the multisock stuff already logs this for each interface and port).
  332. rswindell
    Fri Mar 09 2018 08:20 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.33 1.34 diff

    Log Message:
    #include xpprintf.h to resolve msvc warning:
    ssl.c(210): warning C4013: 'asprintf' undefined; assuming extern returning int
  333. rswindell
    Fri Mar 09 2018 08:04 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.59 1.60 diff
    src/xpdev/xpprintf.h 1.15 1.16 diff

    Log Message:
    Constify the 'format' argument of asprintf() and vasprintf() to be
    compatible with the glibc/etc. declarations and use.
  334. deuce
    Fri Mar 09 2018 07:53 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.199 1.200 diff
    src/sbbs3/mailsrvr.c 1.643 1.644 diff
    src/sbbs3/services.c 1.311 1.312 diff
    src/sbbs3/ssl.c 1.32 1.33 diff
    src/sbbs3/websrvr.c 1.658 1.659 diff

    Log Message:
    Massive TLS logging overhaul... next up, SSH...
  335. nightfox
    Fri Mar 09 2018 07:20 pm PST

    Modified Files:
    xtrn/DDAreaChoosers/DDFileAreaChooser.js 1.10 1.11 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.11 1.12 diff
    xtrn/DDAreaChoosers/readme.txt 1.1 1.2 diff
    xtrn/DDAreaChoosers/revision_history.txt 1.1 1.2 diff

    Log Message:
    Version 1.16: Bug fix for off-by-one issue when there is a file group with no directories or a message group with no sub-boards
  336. rswindell
    Fri Mar 09 2018 07:20 pm PST

    Modified Files:
    src/sbbs3/scfg/scfgxfr2.c 1.53 1.54 diff
    src/sbbs3/scfg/scfgxtrn.c 1.57 1.58 diff

    Log Message:
    Resolve memory leaks found by clang scan-build (mostly, or all, in error
    conditions) - e.g. if a malloc or realloc failed, then some other allocated
    memory would be leaked.
  337. rswindell
    Fri Mar 09 2018 07:19 pm PST

    Modified Files:
    src/sbbs3/bat_xfer.cpp 1.37 1.38 diff
    src/sbbs3/getmail.c 1.15 1.16 diff
    src/sbbs3/js_bbs.cpp 1.162 1.163 diff
    src/sbbs3/js_global.c 1.371 1.372 diff
    src/sbbs3/js_msgbase.c 1.218 1.219 diff
    src/sbbs3/js_system.c 1.168 1.169 diff
    src/sbbs3/sbbs.h 1.473 1.474 diff
    src/sbbs3/sbbsecho.c 3.71 3.72 diff

    Log Message:
    Resolve memory leaks found by clang scan-build (mostly, or all, in error
    conditions) - e.g. if a malloc or realloc failed, then some other allocated
    memory would be leaked.
  338. rswindell
    Fri Mar 09 2018 06:19 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.675 1.676 diff

    Log Message:
    Resolve clang scan-build warning about JS write_raw() method potentially
    calling putcom() with a len value of 0 (which triggers an auto-string-length
    grab via strlen() which should be 0 - but.. meh).
  339. deuce
    Fri Mar 09 2018 06:04 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.457 1.458 diff

    Log Message:
    Don't socket recv() errors for TLS sessions.
  340. deuce
    Fri Mar 09 2018 05:57 pm PST

    Modified Files:
    src/sbbs3/websrvr.c 1.657 1.658 diff

    Log Message:
    Resolve (?) clang crash on FreeBSD-CURRENT (!)
  341. deuce
    Fri Mar 09 2018 05:53 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.456 1.457 diff
    src/sbbs3/js_socket.c 1.198 1.199 diff
    src/sbbs3/mailsrvr.c 1.642 1.643 diff
    src/sbbs3/services.c 1.310 1.311 diff
    src/sbbs3/ssl.c 1.31 1.32 diff
    src/sbbs3/ssl.h 1.12 1.13 diff
    src/sbbs3/websrvr.c 1.656 1.657 diff

    Log Message:
    More betterer crypt logging...
    Things return allocated pointers with errors in them now.
    FTP server updated, the rest to follow "soon".
  342. rswindell
    Fri Mar 09 2018 05:10 pm PST

    Modified Files:
    exec/load/binkp.js 1.75 1.76 diff

    Log Message:
    Inlcude more more version details in the log output (so I can stop having
    to ask sysops after they've already pasted log output into a help request).
    Also, include the sbbs version in the BinkP "VER" message excahanged with
    the BinkP peer.
  343. rswindell
    Fri Mar 09 2018 05:10 pm PST

    Modified Files:
    exec/binkit.js 1.54 1.55 diff

    Log Message:
    Inlcude more more version details in the log output (so I can stop having
    to ask sysops after they've already pasted log output into a help request).
    Also, include the sbbs version in the BinkP "VER" message excahanged with
    the BinkP peer.
  344. rswindell
    Fri Mar 09 2018 04:01 pm PST

    Modified Files:
    src/sbbs3/sbbs_ini.c 1.162 1.163 diff

    Log Message:
    Fix some potential NULL dereferences in sbbs_write_ini() (if 'bbs' arg was
    passsed as NULL) found by scan-build.
  345. rswindell
    Fri Mar 09 2018 03:54 pm PST

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.53 1.54 diff

    Log Message:
    Initialize some variables to quiet scan-build.
  346. rswindell
    Fri Mar 09 2018 03:41 pm PST

    Modified Files:
    src/sbbs3/userdat.c 1.185 1.186 diff

    Log Message:
    Don't use the node value if it's garbage (unset by getnodedat).
    Thanks scan-build!
  347. deuce
    Fri Mar 09 2018 02:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.455 1.456 diff

    Log Message:
    Use crypt_ll() in the FTP server.
  348. deuce
    Fri Mar 09 2018 01:50 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.30 1.31 diff
    src/sbbs3/ssl.h 1.11 1.12 diff

    Log Message:
    Add crypt_ll(int) function that returns "the" appropriate log level for
    a cryptlib error code.
  349. deuce
    Fri Mar 09 2018 01:42 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.454 1.455 diff
    src/sbbs3/ssl.c 1.29 1.30 diff
    src/sbbs3/ssl.h 1.10 1.11 diff

    Log Message:
    First pass at updating the cryptlib log messages... step one, the FTP server.
  350. deuce
    Fri Mar 09 2018 12:51 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.28 1.29 diff
    src/sbbs3/ssl.h 1.9 1.10 diff

    Log Message:
    These functions take a CRYPT_HANDLE, not just a CRYPT_SESSION.
  351. deuce
    Fri Mar 09 2018 12:28 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.27 1.28 diff
    src/sbbs3/ssl.h 1.8 1.9 diff

    Log Message:
    Export get_crypt_error_string()
  352. deuce
    Fri Mar 09 2018 12:25 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.26 1.27 diff

    Log Message:
    Copy error descriptions from cryptlib.h into get_error_string() so we should
    always get a string in cryptlib errors.  Places that don't get an error
    string should now since it should always be useful.
  353. deuce
    Fri Mar 09 2018 12:04 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.370 1.371 diff

    Log Message:
    sp = p, not 0.
    (fix last commit)
  354. deuce
    Fri Mar 09 2018 12:03 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.369 1.370 diff

    Log Message:
    Fix spectacularly bad bug in the cksum_calc() global method.
    Thanks scan-build!
  355. deuce
    Fri Mar 09 2018 11:48 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.197 1.198 diff

    Log Message:
    When close() is called on an external socket (for example, from a service),
    call shutdown(sock, SHUT_RDWR) to do the TCP close, but leave the socket
    descriptor valid for the caller to clean up.
  356. deuce
    Fri Mar 09 2018 10:25 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.196 1.197 diff

    Log Message:
    Fix build error.
  357. deuce
    Fri Mar 09 2018 12:56 am PST

    Modified Files:
    src/smblib/base64.c 1.28 1.29 diff

    Log Message:
    Use the same comparison order so as not to confuse port scan-build.
  358. deuce
    Thu Mar 08 2018 11:46 pm PST

    Modified Files:
    src/xpdev/link_list.c 1.60 1.61 diff

    Log Message:
    Allow passing LAST_NODE to listRemoveNodes() for people who don't know that
    listRemoveNode() exists.
  359. deuce
    Thu Mar 08 2018 11:03 pm PST

    Modified Files:
    src/xpdev/xpevent.c 1.15 1.16 diff

    Log Message:
    And the final unused assignment... care of... SCAN-BUILD! \o/
  360. deuce
    Thu Mar 08 2018 11:02 pm PST

    Modified Files:
    src/syncterm/term.c 1.336 1.337 diff

    Log Message:
    Remove more unneeded assigmnents.
    Thanks scan-build!
  361. deuce
    Thu Mar 08 2018 10:59 pm PST

    Modified Files:
    src/syncterm/syncterm.c 1.217 1.218 diff

    Log Message:
    Remove more unused assignments.
    Thanks scan-build!
  362. deuce
    Thu Mar 08 2018 10:57 pm PST

    Modified Files:
    src/conio/bitmap_con.c 1.135 1.136 diff

    Log Message:
    Removed unused variable that got zeroed extra hard.
    Thanks scan-build!
  363. deuce
    Thu Mar 08 2018 10:55 pm PST

    Modified Files:
    src/conio/cterm.c 1.239 1.240 diff

    Log Message:
    Fix various useless assignments.
    Thanks scan-build!
  364. rswindell
    Thu Mar 08 2018 10:55 pm PST

    Modified Files:
    CVSROOT/loginfo 1.31 1.32 diff

    Log Message:
    Send commit message to synchro.net instead of vert.synchro.net, work-around
    for vert's IRCd not accepting new clients lately.
  365. deuce
    Thu Mar 08 2018 10:53 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.158 1.159 diff

    Log Message:
    Remove bad second check.
  366. deuce
    Thu Mar 08 2018 10:52 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.157 1.158 diff

    Log Message:
    The idea was to NULL check *before* passing to iniGetSectionList().
    Derp.
    Thanks DigitalMan!
  367. deuce
    Thu Mar 08 2018 10:48 pm PST

    Modified Files:
    src/conio/curs_cio.c 1.39 1.40 diff

    Log Message:
    Fix setvideoflags() in curses.  Did nothing.
    Thanks scan-build!
  368. rswindell
    Thu Mar 08 2018 10:47 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.641 1.642 diff

    Log Message:
    Remove "(ftn_addr)" portion of "To name", if it exists, in SMTP-submitted
    FidoNet netmail messages.
    Fix problem reported by Rastus and Nelgin.
  369. deuce
    Thu Mar 08 2018 10:45 pm PST

    Modified Files:
    src/syncterm/syncterm.c 1.216 1.217 diff

    Log Message:
    We don't need to call getenv("HOME") twice in a row to be extra super-sure
    the value is there.
    Thanks scan-build!
  370. deuce
    Thu Mar 08 2018 10:44 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.156 1.157 diff

    Log Message:
    More paranoia.  Still hard to hit unless you hate yourself.
    Thanks scan-build!
  371. deuce
    Thu Mar 08 2018 10:35 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.155 1.156 diff

    Log Message:
    Protect against NULL dereference
    Found by scan-build.
  372. deuce
    Thu Mar 08 2018 10:28 pm PST

    Modified Files:
    src/conio/ciolib.c 1.170 1.171 diff

    Log Message:
    Fix impossible to hit bug.
    Found by scan-build.
  373. deuce
    Thu Mar 08 2018 10:20 pm PST

    Modified Files:
    src/conio/cterm.c 1.238 1.239 diff

    Log Message:
    Fix use of uninitialized value when more than 16 bits of colour channel
    information are specified in an xterm rgb: color definition.
    Found by scan-build.
  374. deuce
    Thu Mar 08 2018 10:13 pm PST

    Modified Files:
    src/conio/cterm.c 1.237 1.238 diff

    Log Message:
    Fix potential NULL dereference on illegal strings commands.
    Found by scan-build.
  375. deuce
    Thu Mar 08 2018 10:11 pm PST

    Modified Files:
    src/xpdev/str_list.c 1.48 1.49 diff

    Log Message:
    Fix bug in last commit.
  376. deuce
    Thu Mar 08 2018 10:05 pm PST

    Modified Files:
    src/xpdev/str_list.c 1.47 1.48 diff

    Log Message:
    Fix a pair of unlikely memory leaks on realloc() failure found by scan-build.
  377. deuce
    Thu Mar 08 2018 10:01 pm PST

    Modified Files:
    src/syncterm/fonts.c 1.28 1.29 diff

    Log Message:
    Fix memory leak when quitting (meh)
    Found by scan-build.
  378. deuce
    Thu Mar 08 2018 09:50 pm PST

    Modified Files:
    src/xpdev/xpbeep.c 1.96 1.97 diff

    Log Message:
    Fix memory leak found by scan-build.
  379. deuce
    Thu Mar 08 2018 09:34 pm PST

    Modified Files:
    src/conio/cterm.c 1.236 1.237 diff

    Log Message:
    "fix" "issue" found by scan-build.
    Not impressed yet.  :-)
  380. rswindell
    Thu Mar 08 2018 08:54 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.640 1.641 diff

    Log Message:
    Log the message number when failing to increment delivery attempt counter.
  381. rswindell
    Thu Mar 08 2018 08:53 pm PST

    Modified Files:
    src/smblib/smblib.c 1.175 1.176 diff

    Log Message:
    A couple of the smb last_error strings had "index" and "header"
    conflated. Added " file" as well.
  382. rswindell
    Thu Mar 08 2018 07:55 pm PST

    Modified Files:
    src/sbbs3/jsexec.c 1.197 1.198 diff

    Log Message:
    Output the name of the module that set the exit_code.
  383. rswindell
    Thu Mar 08 2018 07:54 pm PST

    Modified Files:
    src/sbbs3/smbutil.c 1.121 1.122 diff

    Log Message:
    Output a status line when a messages is imported/added to a msgbase.
  384. deuce
    Thu Mar 08 2018 07:18 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.195 1.196 diff

    Log Message:
    Fix that ole last commit.
  385. rswindell
    Thu Mar 08 2018 07:11 pm PST

    Modified Files:
    src/build/Common.gmake 1.106 1.107 diff

    Log Message:
    Define _GNU_SOURCE when targeting linux. This resolves a lot of warnings
    about undeclared functions (vasprintf and pthread_setname_np) when building
    sbbs3.
  386. rswindell
    Thu Mar 08 2018 06:40 pm PST

    Modified Files:
    src/xpdev/link_list.c 1.59 1.60 diff

    Log Message:
    Use the function pthread_mutex_initializer_np() in place of the macro
    (PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP) - when we defined _GNU_SOURCE,
    assigning that macro value to list->mutex triggers a GCC compiler error.
  387. rswindell
    Thu Mar 08 2018 06:23 pm PST

    Modified Files:
    src/xpdev/gen_defs.h 1.75 1.76 diff

    Log Message:
    Use the "long" printf specifier for file offset (off_t) when __LP64__
    is defined - resolves gcc warning in ftpsrvr.c.
  388. deuce
    Thu Mar 08 2018 05:34 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.194 1.195 diff

    Log Message:
    Actually implement the timeout specified in Socket.recv().
    This has apparently never been implemented for non-TLS sockets, but it
    is used by some.
  389. deuce
    Thu Mar 08 2018 05:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.453 1.454 diff

    Log Message:
    Fix up load access with MLSx
    Call FULLPATH() on local directories after changing
    Add cdir to MLSD in the bbs: mount
    Return full path in MLST
  390. deuce
    Thu Mar 08 2018 03:52 pm PST

    Modified Files:
    src/sbbs3/jsexec.c 1.196 1.197 diff

    Log Message:
    Interrupt syscalls on break_handler() signals.
  391. rswindell
    Thu Mar 08 2018 03:33 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.58 1.59 diff

    Log Message:
    Don't redefine _GNU_SOURCE if it's already defined.
  392. deuce
    Thu Mar 08 2018 03:25 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.452 1.453 diff

    Log Message:
    Map date uploaded to the created fact.
  393. deuce
    Thu Mar 08 2018 02:05 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.451 1.452 diff

    Log Message:
    Add the unique fact to things that can have aliases in ftpalias.cfg
    (dirs and files).  Include the unique fact in aliases as well.  Clients can
    now tell that aliases are the same entry.
    
    For MLST <dir>, always return the full path of the dir instead of the
    specified or relative path.
    
    Likely some other minor fixes as well.
  394. deuce
    Thu Mar 08 2018 11:09 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.639 1.640 diff

    Log Message:
    We don't need any of this cleanup on TLS negotiation failure... in fact,
    free() the mailproc causes a double-free crash.
  395. deuce
    Thu Mar 08 2018 02:34 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.450 1.451 diff

    Log Message:
    Fix format of modify fact.
  396. deuce
    Thu Mar 08 2018 12:37 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.449 1.450 diff

    Log Message:
    Add support for ftpalias.cfg to parsepath().  Directory aliases now work
    like symlinks... note that they aren't shown as symlinks in the directory
    output, so it may be a bit of a surprise when relative paths are relative
    to the target rather than the alias.
  397. rswindell
    Thu Mar 08 2018 12:19 am PST

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.22 1.23 diff

    Log Message:
    Don't call the Progress callbacks when online != ON_REMOTE (e.g. running
    tasks in timed events).
  398. rswindell
    Thu Mar 08 2018 12:17 am PST

    Modified Files:
    src/sbbs3/pack_qwk.cpp 1.77 1.78 diff

    Log Message:
    Check the sbbs_t.online element rather than the cfg.node_num to filter
    excessive log output from packing-QWK events.
  399. rswindell
    Thu Mar 08 2018 12:05 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.448 1.449 diff

    Log Message:
    You need xpprintf.h for the vasprintf() prototype on Windows.
  400. deuce
    Wed Mar 07 2018 03:34 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.447 1.448 diff

    Log Message:
    Return an empty LIST or NLST listing if parsepath() fails.
  401. deuce
    Wed Mar 07 2018 02:39 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.674 1.675 diff

    Log Message:
    Don't count non-client sockets since they don't call the close callback.
  402. rswindell
    Wed Mar 07 2018 02:30 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.673 1.674 diff

    Log Message:
    Fix socket-counter bug introduced in rev 1.615: after accept()ing a connection,
    the startup->socket_open() callback wasn't being called.
    I'm not sure if this is correct with the *nix Spy socket stuff however.
  403. deuce
    Wed Mar 07 2018 02:22 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.446 1.447 diff

    Log Message:
    Skip errored path components and return a root error... LIST really needs
    to handle this somehow (but currently doesn't).
    Also, remove some debug output.
  404. deuce
    Wed Mar 07 2018 02:00 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.445 1.446 diff

    Log Message:
    Fix OPTS MLST support for local files
    Add the '..' parent directory to libs and dirs
    Fly the TVFS flag now that relative dirs are working
  405. deuce
    Wed Mar 07 2018 01:44 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.444 1.445 diff

    Log Message:
    Fix relative paths by rewriting parsepath() from scratch.
    LIST should likely check the return value now...
  406. deuce
    Wed Mar 07 2018 01:06 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.443 1.444 diff

    Log Message:
    Add support for UNIX.ownername to MLSx commands.
    Add support for OPTS MLST command.
    Fix MLST FEAT response.
  407. deuce
    Wed Mar 07 2018 03:04 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.442 1.443 diff

    Log Message:
    Initial MLST/MLSD support.  Relative paths are terrible, but they're terrible
    in the other stuff too.  The local mounts may not be at 100% either, but
    the appear to work.
  408. deuce
    Tue Mar 06 2018 11:50 pm PST

    Modified Files:
    src/sbbs3/websrvr.c 1.655 1.656 diff

    Log Message:
    Fix bug introduced in 1.649 for non-TLS sessions.  That fix was only supposed
    to be for TLS sessions.
  409. rswindell
    Tue Mar 06 2018 11:49 pm PST

    Modified Files:
    exec/load/binkp.js 1.74 1.75 diff

    Log Message:
    Added some helpful log messages when starting/finishing the transfer of
    files (sending or receiving).
  410. rswindell
    Tue Mar 06 2018 11:49 pm PST

    Modified Files:
    exec/binkit.js 1.53 1.54 diff

    Log Message:
    Added some helpful log messages when starting/finishing the transfer of
    files (sending or receiving).
  411. deuce
    Tue Mar 06 2018 11:47 pm PST

    Modified Files:
    exec/load/binkp.js 1.73 1.74 diff

    Log Message:
    Work around issue with Internet Rex 2.29 Win32 (binkp/1.1)
    Does not support CRAM-MD5 challenges longer than 16 bytes (32 hex chars)
  412. deuce
    Tue Mar 06 2018 11:20 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.638 1.639 diff

    Log Message:
    Add missing break after session fails to be set active.
  413. rswindell
    Tue Mar 06 2018 09:09 pm PST

    Modified Files:
    exec/binkit.js 1.52 1.53 diff

    Log Message:
    Send M_ERR instead of M_OK when a link's password doesn't match.
    I'm probably doing something wrong here, since I didn't write this code
    (particularly if there are multiple advertised addresses in the session
    which we have configured links for) - but this should at least give Al
    something to test.
  414. rswindell
    Tue Mar 06 2018 09:04 pm PST

    Modified Files:
    exec/load/binkp.js 1.72 1.73 diff

    Log Message:
    Send M_ERR instead of M_OK when a link's password doesn't match.
    I'm probably doing something wrong here, since I didn't write this code
    (particularly if there are multiple advertised addresses in the session
    which we have configured links for) - but this should at least give Al
    something to test.
  415. rswindell
    Tue Mar 06 2018 07:20 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.637 1.638 diff

    Log Message:
    Treat *all* types of SMTP AUTH failures as "bad logins" for the sake of
    throttling, temp-banning, and filtering.
  416. rswindell
    Tue Mar 06 2018 06:48 pm PST

    Modified Files:
    src/sbbs3/scfgsave.c 1.74 1.75 diff

    Log Message:
    The same custom data_dir as parent of auto-generated transfer path logic needed
    here in write_file_cfg() where the directories are created.
  417. deuce
    Tue Mar 06 2018 06:44 pm PST

    Modified Files:
    src/xpdev/dirwrap.c 1.99 1.100 diff

    Log Message:
    Fix last commit.
  418. deuce
    Tue Mar 06 2018 06:40 pm PST

    Modified Files:
    src/xpdev/dirwrap.c 1.98 1.99 diff

    Log Message:
    isfullpath() should not return true for "\0:" or "$:"... the first char
    must be a letter if the second char is a colon.
  419. rswindell
    Tue Mar 06 2018 05:12 pm PST

    Modified Files:
    src/sbbs3/scfg/scfgxfr2.c 1.52 1.53 diff

    Log Message:
    Use the custom data dir (if one was specified) in the displayed
    auto-generated file transfer path (no transfer path specified), in
    square brackets.
  420. rswindell
    Tue Mar 06 2018 04:57 pm PST

    Modified Files:
    src/sbbs3/load_cfg.c 1.72 1.73 diff

    Log Message:
    Change for Nelgin:
    If the sysop does not specify a file transfer path for a directory, but
    did specify a custom data directory, use the custom data directory as the
    parent of the auto-generated sub-directory to use for the file storage
    path. If this breaks existing configs (are you files are offline?), sorry.
  421. rswindell
    Tue Mar 06 2018 03:08 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.636 1.637 diff

    Log Message:
    Beautify the log output and make the agent/server names more consistent
    (e.g. "SUBMISSIONS Server" becomes "SMTPS Submission Agent", etc.).
    Removed the redundent "<protocol> Server listening" log lines.
  422. rswindell
    Tue Mar 06 2018 03:05 pm PST

    Modified Files:
    src/xpdev/multisock.c 1.33 1.34 diff

    Log Message:
    Update the log messages to include the protocol names/descriptions.
  423. deuce
    Tue Mar 06 2018 01:46 pm PST

    Modified Files:
    src/sbbs3/js_msg_area.c 1.68 1.69 diff

    Log Message:
    Enforce ABNF from RFC5536 for newsgroup property since it's stricter than
    the one in RFC3977.  Technically, you could have those groups, you just
    couldn't have any netnews articles in them.  :-)
  424. deuce
    Tue Mar 06 2018 01:31 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.635 1.636 diff

    Log Message:
    Downgrade message that will be passed to bounce() on failure to LOG_INFO.
    If there's a problem, bounce() will re-log them as LOG_WARNING later.
  425. deuce
    Tue Mar 06 2018 01:22 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.634 1.635 diff

    Log Message:
    Split out the mx fallback/TLS negotiation/etc stuff into a separate function
    and fix all the things.
    
    Hopefully this allows fallback to plaintext after a TLS failure now.
  426. rswindell
    Tue Mar 06 2018 01:21 pm PST

    Modified Files:
    exec/load/fido.js 1.30 1.31 diff

    Log Message:
    Fix flo_outbound() for point nodes (to match the behavior in the heading's
    comment block and the BSO/FLO standard).
    
    Hoping AL@TRMB will test this for us. :-)
  427. rswindell
    Tue Mar 06 2018 12:53 pm PST

    Modified Files:
    exec/binkit.js 1.51 1.52 diff

    Log Message:
    Added some temporary debug log output (with WARNING log level) to help
    resolve AL@TRMB's problem with error:
    /sbbs/fido/outbound.015/00000001.pnt/0004006a.bsy failed.
  428. deuce
    Tue Mar 06 2018 11:47 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.633 1.634 diff

    Log Message:
    Actually log the error string in the place it's most likely to be available...
    setting the session active.
  429. deuce
    Tue Mar 06 2018 11:19 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.632 1.633 diff

    Log Message:
    Allocate an extra byte for the '-'/' ' between the response and the option.
  430. deuce
    Tue Mar 06 2018 10:33 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.631 1.632 diff

    Log Message:
    Actually check the return value of sendmail_open_socket()
  431. rswindell
    Tue Mar 06 2018 01:13 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.630 1.631 diff

    Log Message:
    Update all the POP3 loglines to include the IP address or the authenticated
    user name (once authenticated).
    Lower the log level of the POP3S "Unable to set session active" messages,
    apparently these are normal occurence with drive-by bots and not error.log
    worthy.
    Fixed the !Cryptlib error in sock_recvbyte log output (sock, not socket).
  432. deuce
    Tue Mar 06 2018 01:06 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.629 1.630 diff

    Log Message:
    We need to actually recreate the socket before re-using it after a TLS
    failure... do that.
  433. deuce
    Tue Mar 06 2018 12:32 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.628 1.629 diff

    Log Message:
    Fix retry-after-TLS error, and make log messages more useful.
  434. rswindell
    Tue Mar 06 2018 12:28 am PST

    Modified Files:
    exec/gopherservice.js 1.16 1.17 diff

    Log Message:
    Log a message rather than try to open an invalid sub when requested by the
    client.
  435. deuce
    Tue Mar 06 2018 12:09 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.627 1.628 diff

    Log Message:
    Don't force TLS 1.0 for forwarded STARTTLS delivery.  Cox may suck, but
    not everyone is that inept.
  436. rswindell
    Tue Mar 06 2018 12:05 am PST

    Modified Files:
    src/sbbs3/websrvr.c 1.654 1.655 diff

    Log Message:
    Lower the log level in the "JavaScript FAILED to compile rewrite" log
    entry - if there's an actual compile error, it should already be logged
    via the exception/error-reporter callback. This should eliminate a lot of
    the dokuwiki-related error chatter in my error.log.
  437. rswindell
    Mon Mar 05 2018 11:33 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.672 1.673 diff

    Log Message:
    A little more detail in the "Packing completed" log line.
  438. rswindell
    Mon Mar 05 2018 11:33 pm PST

    Modified Files:
    src/sbbs3/pack_qwk.cpp 1.76 1.77 diff

    Log Message:
    Clean-up the log output when packing QWK packets from the event thread.
  439. deuce
    Mon Mar 05 2018 11:10 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.193 1.194 diff

    Log Message:
    Some needless paranoia.
  440. deuce
    Mon Mar 05 2018 11:09 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.192 1.193 diff

    Log Message:
    Don't close external sockets... ever.
  441. rswindell
    Mon Mar 05 2018 08:59 pm PST

    Modified Files:
    exec/load/portdefs.js 1.5 1.6 diff

    Log Message:
    Added the "submissions" (SMTPS submission) port definition.
  442. rswindell
    Mon Mar 05 2018 08:18 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.626 1.627 diff

    Log Message:
    Add the protocol ("POP3" or "SMTP") and socket descriptor to all the
    "Enable to" (TLS-related) error messages. This might help a little to
    understand why these errors are happening and allow us to consider
    lowering the log level(s) of commonly-occuring cases from LOG_ERR.
  443. deuce
    Mon Mar 05 2018 07:18 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.625 1.626 diff

    Log Message:
    Add support for other WITH clauses.  We still need to add RFC8314 Section 4.3
    support though.
  444. deuce
    Mon Mar 05 2018 07:04 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.624 1.625 diff

    Log Message:
    Add support for RFC3848 ESMTPA with clause.
    ESMTPS and ESMTPSA coming soon!
  445. deuce
    Mon Mar 05 2018 05:24 pm PST

    Modified Files:
    src/sbbs3/js_msg_area.c 1.67 1.68 diff

    Log Message:
    Replace all illegal newsgroup name characters (per RFC3977) with '_' in
    newsgroup property.
    
    Note that any exascii is also illegal, but I don't feel like doing the
    UTF-8 conversion thing today.  Also, you can manually stick in illegal
    characters if you like... but then it's a feature, not a bug.
  446. rswindell
    Mon Mar 05 2018 04:34 pm PST

    Modified Files:
    exec/binkit.js 1.50 1.51 diff
    exec/avatars.js 1.33 1.34 diff
    exec/sbbslist.js 1.36 1.37 diff

    Log Message:
    Change the cnfdefs.js to use the configuration (.cnf) record field
    names from the Sync-JS object model (jsobjs.html) rather than from the
    C/C++ source code (sbbsdefs.js). I got buy-in from mcmlxxix to make this
    change, but any existing scripts which use the old names will need to be
    changed or its likely that the .cnf record changes aren't going to be
    made as intended (attn: CoA sysops).
  447. rswindell
    Mon Mar 05 2018 04:34 pm PST

    Modified Files:
    exec/load/cnfdefs.js 1.3 1.4 diff

    Log Message:
    Change the cnfdefs.js to use the configuration (.cnf) record field
    names from the Sync-JS object model (jsobjs.html) rather than from the
    C/C++ source code (sbbsdefs.js). I got buy-in from mcmlxxix to make this
    change, but any existing scripts which use the old names will need to be
    changed or its likely that the .cnf record changes aren't going to be
    made as intended (attn: CoA sysops).
  448. rswindell
    Mon Mar 05 2018 04:26 pm PST

    Modified Files:
    exec/load/cnflib.js 1.11 1.12 diff

    Log Message:
    When writing a configuration string record (to a .cnf file), if the 
    struct field is not defined, write a zero-len string instead of 'undefined'.
  449. deuce
    Mon Mar 05 2018 04:08 pm PST

    Modified Files:
    src/sbbs3/services.c 1.309 1.310 diff

    Log Message:
    Don't call get_ssl_cert() until the services thread is up.
    Should fix possible issue with certificate being owned by root when
    _THREAD_SUID_BROKEN is true (ie: Linux).
  450. deuce
    Mon Mar 05 2018 03:29 pm PST

    Modified Files:
    exec/load/acmev2.js 1.23 1.24 diff

    Log Message:
    Don't mislabel Location headers as Link headers.
  451. rswindell
    Mon Mar 05 2018 01:50 pm PST

    Modified Files:
    src/xpdev/multisock.c 1.32 1.33 diff

    Log Message:
    Log the address of each interface socket being closed in addition to the
    port number. This resolves the confusion that arises from multiple
    identical "closing x Server socket on port n" lines in the log output.
  452. rswindell
    Mon Mar 05 2018 01:32 pm PST

    Modified Files:
    src/sbbs3/text_defaults.c 1.40 1.41 diff

    Log Message:
    When displaying posts and email summary (to/from/subj), handle 5-digit
    (for subs and "all mail") and 4-digit message numbers. Subs with >9999 msgs
    are not unheard of and its easy to accumulate that much mail in the mail base
    these days. Just eliminated the ':' from the format line(s) to make room.
  453. rswindell
    Mon Mar 05 2018 01:29 pm PST

    Modified Files:
    ctrl/text.dat 1.80 1.81 diff

    Log Message:
    When displaying posts and email summary (to/from/subj), handle 5-digit
    (for subs and "all mail") and 4-digit message numbers. Subs with >9999 msgs
    are not unheard of and its easy to accumulate that much mail in the mail base
    these days. Just eliminated the ':' from the format line(s) to make room.
  454. rswindell
    Mon Mar 05 2018 11:59 am PST

    Modified Files:
    src/xpdev/semfile.c 1.5 1.6 diff

    Log Message:
    Removed copyright year.
  455. deuce
    Mon Mar 05 2018 11:46 am PST

    Modified Files:
    src/sbbs3/services.c 1.308 1.309 diff

    Log Message:
    Remove waits in the services_thread() main loop.
    
    These waits could cause "bad" traffic (blocked, max client exceeded, etc)
    to prevent/delay accept()ing "good" traffic on other services.
  456. rswindell
    Mon Mar 05 2018 10:54 am PST

    Removed Files:
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-6x8.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-7x12.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-8x12.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-8x13.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-8x14.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-8x8.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 737-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 737-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 775-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 850-10x19.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 850-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 850-8x13.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 850-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 852-10x19.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 852-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 852-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 855-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 857-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 860-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 861-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 862-10x19.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 863-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 865-10x19.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 865-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 865-8x13.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 865-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 866-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 869-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-Arabic-16x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-Arabic-HalfWidth-8x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-Graphics-16x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-Graphics-HalfWidth-8x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-International-16x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-International-HalfWidth-8x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE BStrict-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE BStruct-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE MicroKnight-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE MoSoul-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE PotNoodle-8x11.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-16x14.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-7x14.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-7x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-8x14.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE StrokeFont.zip 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE Topaz-8x11.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE TopazPlus-8x11.png 1.1 diff

    Log Message:
    Removing the web/root/ftelnet directory
    Ree (the author) said this old version should be removed from CVS.
  457. rswindell
    Mon Mar 05 2018 10:50 am PST

    Removed Files:
    web/root/ftelnet/ftelnet-resources/NONE ConnectOver.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE ConnectUp.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE SaveFilesDown.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE SaveFilesOver.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE SaveFilesUp.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE connectansi.txt 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE connectrip.txt 1.1 diff

    Log Message:
    Removing the web/root/ftelnet directory
    Ree (the author) said this old version should be removed from CVS.
  458. deuce
    Mon Mar 05 2018 10:47 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.441 1.442 diff

    Log Message:
    Don't write errors to the data socket when resp is false either.
  459. rswindell
    Mon Mar 05 2018 10:46 am PST

    Removed Files:
    web/root/ftelnet/NONE ClientVars.js 1.2 diff
    web/root/ftelnet/NONE fTelnet.swf 1.2 diff
    web/root/ftelnet/NONE playerProductInstall.swf 1.1 diff
    web/root/ftelnet/NONE swfobject.js 1.1 diff

    Log Message:
    Removing the web/root/ftelnet directory
    Ree (the author) said this old version should be removed from CVS.
  460. ree
    Mon Mar 05 2018 09:06 am PST

    Modified Files:
    web/templates/nightshade/ftelnet.inc 1.2 1.3 diff
    web/templates/nightshade/ftelnet_external.inc 1.3 1.4 diff

    Log Message:
    Support the latest version of fTelnet
  461. ree
    Mon Mar 05 2018 09:02 am PST

    Modified Files:
    web/templates/default/ftelnet.inc 1.2 1.3 diff
    web/templates/default/ftelnet_external.inc 1.3 1.4 diff

    Log Message:
    Support the latest version of fTelnet
  462. ree
    Mon Mar 05 2018 08:58 am PST

    Modified Files:
    web/root/members/externals.ssjs 1.6 1.7 diff

    Log Message:
    Support the latest version of fTelnet
  463. ree
    Mon Mar 05 2018 08:54 am PST

    Modified Files:
    web/root/ftelnet.ssjs 1.4 1.5 diff
    web/root/index.ssjs 1.34 1.35 diff

    Log Message:
    Support the latest version of fTelnet
  464. ree
    Mon Mar 05 2018 08:46 am PST

    Modified Files:
    exec/websocketservice.js 1.8 1.9 diff

    Log Message:
    Support the latest version of fTelnet
  465. ree
    Mon Mar 05 2018 08:42 am PST

    Modified Files:
    exec/load/ftelnethelper.js 1.5 1.6 diff

    Log Message:
    Support the latest version of fTelnet
  466. deuce
    Sun Mar 04 2018 10:33 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.440 1.441 diff

    Log Message:
    Add a comment regarding the unimplemented STAT command
  467. deuce
    Sun Mar 04 2018 10:03 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.439 1.440 diff

    Log Message:
    CCC doesn't have a registered FEAT code.
  468. deuce
    Sun Mar 04 2018 09:55 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.438 1.439 diff

    Log Message:
    Add AUTH, PBSZ, PROT, and CCC to HELP.  Also, add CCC to FEAT
  469. rswindell
    Sun Mar 04 2018 09:35 pm PST

    Modified Files:
    src/sbbs3/ctrl/MailCfgDlgUnit.cpp 1.33 1.34 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.dfm 1.35 1.36 diff

    Log Message:
    Fix the TLSPOP3checkbox control of the TLSPOP3Edit box.
    Increase the verbosity of the "Log" checkbox label.
  470. deuce
    Sun Mar 04 2018 09:02 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.25 1.26 diff

    Log Message:
    Add comment.
  471. deuce
    Sun Mar 04 2018 09:01 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.24 1.25 diff

    Log Message:
    Work around MSVC error which assumes ssl_context is used without being
    initialized (it's not).
  472. rswindell
    Sun Mar 04 2018 07:26 pm PST

    Modified Files:
    src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm 1.30 1.31 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.dfm 1.34 1.35 diff

    Log Message:
    Fix-up tab orders.
  473. deuce
    Sun Mar 04 2018 07:14 pm PST

    Modified Files:
    src/sbbs3/gtkuseredit/events.c 1.17 1.18 diff

    Log Message:
    Remove more debug info.
  474. deuce
    Sun Mar 04 2018 07:05 pm PST

    Modified Files:
    src/sbbs3/gtkuseredit/gtkuseredit.c 1.15 1.16 diff

    Log Message:
    Remove debug output.
  475. deuce
    Sun Mar 04 2018 06:53 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.437 1.438 diff
    src/sbbs3/main.cpp 1.671 1.672 diff

    Log Message:
    Add FTPS support.
    
    I wasn't expecting to do this, since SFTP is often viewed as "better", but
    SFTP doesn't have a specification, the implementations don't follow the
    specification drafts that are out there, and the whole sharing a port between
    file transfer and terminal server thing is irritating.
    
    This has only been tested with lftp, but it seems to work.
  476. rswindell
    Sun Mar 04 2018 06:12 pm PST

    Modified Files:
    src/sbbs3/ctrl/MailCfgDlgUnit.cpp 1.32 1.33 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.h 1.20 1.21 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.dfm 1.33 1.34 diff

    Log Message:
    Added controls to enable/configure the new SMTP/TLS and POP3/TLS features
    created so graciously by Deuce, or as I like to call him: Mr. Crypto.
  477. rswindell
    Sun Mar 04 2018 04:38 pm PST

    Modified Files:
    src/sbbs3/mail.cpp 1.31 1.32 diff

    Log Message:
    delmail() re-writes the mail.sid file. Since I've seen some recent
    mail.sid corruption approximately around midnight (when delmail()) is
    called as part of the "DAILY:" mail maintenance, I'm suspicious of this
    function and while I haven't found any bugs, I did find (and now fixed)
    lack of error checking in calls to smb_fsetlength() and smb_fwrite().
  478. rswindell
    Sun Mar 04 2018 04:35 pm PST

    Modified Files:
    src/smblib/smblib.c 1.174 1.175 diff

    Log Message:
    smb_addmsghdr() will now confirm the index file length against the
    status.total_msgs value: if they don't match, don't add header & index
    to the message base, it's apparently corrupted and we're only going to
    make things worse as smb_putmsgidx() will fail (after we've stored the hdr)
    with an "invalid index offset" error.
  479. rswindell
    Sun Mar 04 2018 02:59 pm PST

    Modified Files:
    src/smblib/smblib.c 1.173 1.174 diff

    Log Message:
    Fix potential bug:
    If caller doesn't zero-initialize smb_t, then the 'lock' member could've
    been non-zero (garbage) and some functions would then not lock the SMB
    header, used for protecting against corruption from multiple process or thread
    modification of the same base.
  480. rswindell
    Sun Mar 04 2018 02:04 pm PST

    Modified Files:
    ctrl/sbbs.ini 1.74 1.75 diff

    Log Message:
    Use the new TLS-related settings.
  481. rswindell
    Sun Mar 04 2018 01:20 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.h 1.82 1.83 diff
    src/sbbs3/mailsrvr.c 1.623 1.624 diff
    src/sbbs3/sbbs_ini.c 1.161 1.162 diff

    Log Message:
    Use easier-to-understand .ini keys and options in the [mail] section
    for new TLS-related settings:
    SubmissionsPort -> TLSSubmissionPort
    POP3SPort -> TLSPOP3Port
    USE_TLS_SUBMISSIONS_PORT -> TLS_SUBMISSION
    USE_POP3S_PORT -> TLS_POP3
    There was actuall a typo in the "USE_POP3S_PORT" string anyway. <shrug>
  482. rswindell
    Sun Mar 04 2018 01:06 pm PST

    Modified Files:
    src/sbbs3/smbutil.c 1.120 1.121 diff

    Log Message:
    Re-lock the msg base in packmsgs() when re-opening (to set status header),
    so that the smb_unlock() in main() doesn't fail and display the harmless
    error:
    Error -207 (smb_unlock 2 'No such file or directory' removing mail.lock)
    unlocking mail
  483. deuce
    Sun Mar 04 2018 11:38 am PST

    Modified Files:
    3rdp/build/cl-algorithms.patch 1.1 1.2 diff

    Log Message:
    Enable USE_SSH_EXTENDED which will allow support for sftp in the future.
  484. deuce
    Sun Mar 04 2018 12:32 am PST

    Modified Files:
    ctrl/sbbs.ini 1.73 1.74 diff

    Log Message:
    Wiki says SMTP listens on port 587 by default.  Make that happen.
  485. deuce
    Sun Mar 04 2018 12:18 am PST

    Modified Files:
    ctrl/sbbs.ini 1.72 1.73 diff

    Log Message:
    Add new values/options.
  486. deuce
    Sun Mar 04 2018 12:15 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.622 1.623 diff
    src/sbbs3/mailsrvr.h 1.81 1.82 diff
    src/sbbs3/sbbs_ini.c 1.160 1.161 diff

    Log Message:
    Add support for mail TLS ports.  This adds two new keys to sbbs.ini Mail
    section:
    
    POP3SPort=995
    SubmissionsPort=465
    
    And two new mail options:
    USE_SUBMISSIONS_PORT
    USE_POP3SS_PORT
    
    These are the last of the two option bits for the mail server.
  487. deuce
    Sat Mar 03 2018 11:22 pm PST

    Modified Files:
    src/xpdev/sockwrap.h 1.53 1.54 diff

    Log Message:
    Add pop3s and submissions ports
  488. deuce
    Sat Mar 03 2018 11:11 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.621 1.622 diff
    src/sbbs3/mailsrvr.h 1.80 1.81 diff
    src/sbbs3/mime.c 1.9 1.10 diff
    src/sbbs3/mime.h 1.4 1.5 diff

    Log Message:
    Mail server support for Opportunistic TLS.
    
    Support STARTTLS in SMTP and STLS in POP3.  This includes the sendmail
    thread.  Clients can now be configured to use STARTTLS with Synchronet
    mail services, and Synchronet will attempt to deliver securely when
    possible (though it will fall back to plain text delivery when necessary.)
    
    This touches a *lot* of mail server stuff, so some instability is not
    unlikely.
    
    Of course, RFC8314 (Jan, 2018) officially recommends implicit TLS on the TLS
    ports now, so support for that should be next.
  489. rswindell
    Sat Mar 03 2018 09:50 pm PST

    Modified Files:
    exec/load/fidocfg.js 1.30 1.31 diff

    Log Message:
    Simplify the binkit.js boolean option parsing by just using the JS File
    iniGetValue() boolean parsing (by passing a default value of 'false').
  490. rswindell
    Sat Mar 03 2018 09:17 pm PST

    Modified Files:
    exec/load/fidocfg.js 1.29 1.30 diff

    Log Message:
    Fixed typo in previous commit:
    line 359: ReferenceError: typeoof is not defined
  491. rswindell
    Sat Mar 03 2018 08:07 pm PST

    Modified Files:
    src/smblib/smblib.c 1.172 1.173 diff

    Log Message:
    Include hex values of invalid base/header IDs in the error message.
  492. rswindell
    Sat Mar 03 2018 04:40 pm PST

    Modified Files:
    exec/load/fidocfg.js 1.28 1.29 diff

    Log Message:
    Attempt to resolve reported error:
    TypeError: this.node[sec].poll.toUpperCase is not a function
  493. rswindell
    Fri Mar 02 2018 09:10 pm PST

    Modified Files:
    src/sbbs3/chksmb.c 1.60 1.61 diff

    Log Message:
    Print all the details of a corrupted hash record.
  494. deuce
    Fri Mar 02 2018 06:05 pm PST

    Modified Files:
    exec/ircd.js 1.171 1.172 diff

    Log Message:
    Quick initial testing hack... if we accept a connection on ports 994 or 6697,
    it's TLS (SSL).
    
    This will get replaced with actualy config things once we ascertain that
    it works properly and stuff.
  495. deuce
    Fri Mar 02 2018 06:02 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.191 1.192 diff
    src/sbbs3/js_socket.h 1.4 1.5 diff
    src/sbbs3/load_cfg.c 1.71 1.72 diff
    src/sbbs3/scfgdefs.h 1.43 1.44 diff
    src/sbbs3/services.c 1.307 1.308 diff
    src/sbbs3/ssl.c 1.23 1.24 diff
    src/sbbs3/websrvr.c 1.653 1.654 diff

    Log Message:
    Store the certificate context in scfg_t.  This allows static services to be
    TLS servers without all of them needing to separately load the ssl certificate.
    
    It's destroyed in free_scfg(), and the config *must* be prepped both to
    destroy the certificate and to load it.  This is because the "no cert"
    value is -1, not 0, so the prepped flag is all we really have to indicate
    if it's zero because it's a valid certificate or zero because no certificate
    has been loaded.
  496. deuce
    Fri Mar 02 2018 05:26 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.190 1.191 diff

    Log Message:
    Add ssl_server boolean property.
  497. rswindell
    Fri Mar 02 2018 12:03 pm PST

    Modified Files:
    exec/binkit.js 1.49 1.50 diff

    Log Message:
    Allow the Sysop name (ZYZ value) to be over-ridden via binkit.ini.
  498. rswindell
    Fri Mar 02 2018 12:02 pm PST

    Modified Files:
    exec/load/fidocfg.js 1.27 1.28 diff

    Log Message:
    Support a "sysop" value in the global section of binkit.ini, to over-ride
    the ZYZ BinkP value (e.g. with the sysop's real name instead of alias).
  499. rswindell
    Fri Mar 02 2018 11:21 am PST

    Modified Files:
    exec/binkit.js 1.48 1.49 diff

    Log Message:
    Fix bug cause install() to run for every poll. JS, you're far too liberal
    in your accepted syntax.
  500. rswindell
    Thu Mar 01 2018 11:36 pm PST

    Modified Files:
    src/sbbs3/ctrl/ServicesCfgDlgUnit.dfm 1.11 1.12 diff

    Log Message:
    Tool-tip help/hint for Services config: "Insert key to add new values".
AuthorCommitsLatest
nightfox9Thu Apr 19 2018 10:36 am
rswindell225Wed Apr 18 2018 10:47 pm
deuce244Tue Apr 17 2018 11:51 pm
echicken9Sat Apr 14 2018 10:27 pm
ree13Mon Mar 19 2018 04:56 pm

Dynamically generated in 135 milliseconds