Synchronet CVS Commit Log

This is a log of the 500 most recent changes in the Synchronet CVS repository.
  1. rswindell
    Fri Aug 17 2018 08:50 am PDT

    Modified Files:
    exec/load/userprops.js 1.2 1.3 diff

    Log Message:
    get() will now return the 'deflt' arg value (e.g. undefined) rather than
    false if the .ini file can't be opened (e.g. doesn't exist).
    set() will now return the result of File.iniSetValue() rather than the
    result of File.close().
  2. echicken
    Thu Aug 16 2018 02:10 pm PDT

    Modified Files:
    exec/email_sec.js 1.2 1.3 diff

    Log Message:
    Default addr_list to an empty array if userprops fails to read ####.ini
  3. rswindell
    Wed Aug 15 2018 11:40 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgxfr2.c 1.54 1.55 diff

    Log Message:
    When importing file areas from a file (e.g. FILEGATE.ZXX), and the dir's
    "short name" (e.g. derived from the "AREA tag" from FILEGATE.ZXX) is the same
    as a pre-existing dir, just over-write that dir - don't create a new one.
  4. rswindell
    Wed Aug 15 2018 12:48 pm PDT

    Modified Files:
    src/sbbs3/con_out.cpp 1.86 1.87 diff

    Log Message:
    This is just something I noticed while looking into the change for the
    previous commit: don't clear the line counter or call pause() - which will
    do nothing - if the console abort flag is set.
  5. rswindell
    Wed Aug 15 2018 12:38 pm PDT

    Modified Files:
    src/sbbs3/putmsg.cpp 1.34 1.35 diff

    Log Message:
    This is a bit of a hack for Nelgin, who noticed that novice menu mode
    would not always auto-redisplay menu files when the user hits 'Q' (or 'N'
    or Ctrl-C) at auto-pause prompts:
    
    When displaying a "message" (e.g. file), if the console abort flag is set
    before a single line has been displayed, clear the abort flag. This most
    likely means a pause (hit a key) prompt was automatically displayed due to
    a clear screen code in the message/file and the user hit 'Q' or 'N' or
    Ctrl-C at the prompt. In this special case, don't treat that as an
    "abort message" command and keep displaying the message/file. 
    
    Once one or more lines in the message/file have been displayed, then the
    behavior is the same as before: a console abort (even as a result of an
    auto-pause prompt key) will stop the display of the current message/file.
  6. rswindell
    Tue Aug 14 2018 08:03 pm PDT

    Modified Files:
    exec/xtrn_sec.js 1.18 1.19 diff

    Log Message:
    Fix problem reported by Nelgin:
    In External programs after running Sycnrhonet BBS List you get
    "Returning to <BBS> - hit a key". If you presss Q you get a blank external
    menu menu rather than the full menu.
    The main problem was the line counter, so clearing after returning from
    executing an external program (unless the forced pause thing is on).
  7. rswindell
    Tue Aug 14 2018 07:53 pm PDT

    Modified Files:
    exec/nntpservice.js 1.124 1.125 diff

    Log Message:
    Count blank requests as "bogus commands".
    Throttle bogus command sending clients (one second per bogus command, accumulating).
  8. echicken
    Tue Aug 14 2018 08:24 am PDT

    Modified Files:
    exec/tickit.js 1.45 1.46 diff

    Log Message:
    seem like maybe addrs should be a array
  9. rswindell
    Tue Aug 14 2018 02:36 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.222 1.223 diff

    Log Message:
    Fix-up js_recvline() based on infinite error/log message report from Nelgin:
     term 0087 TLS ERROR 'Unexpected <Unknown type> (24) packet, expected application_data (23)' (-1) popping data
     message repeated 492 times: [ term 0087 TLS ERROR 'Unexpected <Unknown type> (24) packet, expected application_data (23)' (-1) popping data]
    
    When using TLS with a JS Socket object, if there was any kind of data error,
    the recvline() method would return a blank string rather than null/undefined.
    nntpservice.js just loops when it receives a blank string, so this caused an
    infinite loop (with disk-filling error log messages).
    
    First change: if no data has been received (i == 0) and there's any kind of 
    receive error or timeout or disconnection, just return null. And not undefined,
    but null (!) like in v3.15 (before the great JS engine update of 2000-mumble).
    Also, there appeared to be a JS_RESUMEREQUEST call missing in the TLS error
    return case - so that's another bug fixed.
    Commented on the magic return values for js_sock_read_check()
    and js_socket_recv().
    Simplified js_sock_read_check() return value a tad: let the caller decide if
    they want to do something special based on the value of 'i'.
    Added some comments to make this code more readable.
    
    We are now no longer treating the different error return values (0 and -1) from
    js_socket_recv() special in this function, but we dont' treat them special in
    any of the other calls in this file/object either, so that seems to be the
    norm.
  10. rswindell
    Tue Aug 14 2018 12:59 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.221 1.222 diff

    Log Message:
    The timeout parameter to js_socket_recv() is in seconds. I don't think
    Deuce really wanted to pass 1000 as a value here (use 1 instead). I don't
    know if this was an observable problem or not, but it certainly *looks*
    like a bug.
  11. deuce
    Thu Aug 09 2018 01:20 pm PDT

    Modified Files:
    exec/load/fido.js 1.33 1.34 diff

    Log Message:
    Have TickIT use the "closest" address in the From line.
    
    This may resolve Dumas Walker's issue with cross-domain TIC forwarding.
    This should really use the value from BinkpSourceAddress, but that would
    mean renaming that key and including it in the TicITCfg object, or
    creating a new SBBSEchoCfg object method or something, and I don't want
    to mess with the sbbsecho.ini format.
  12. deuce
    Thu Aug 09 2018 01:20 pm PDT

    Modified Files:
    exec/binkit.js 2.6 2.7 diff
    exec/tickit.js 1.44 1.45 diff

    Log Message:
    Have TickIT use the "closest" address in the From line.
    
    This may resolve Dumas Walker's issue with cross-domain TIC forwarding.
    This should really use the value from BinkpSourceAddress, but that would
    mean renaming that key and including it in the TicITCfg object, or
    creating a new SBBSEchoCfg object method or something, and I don't want
    to mess with the sbbsecho.ini format.
  13. deuce
    Thu Aug 09 2018 01:08 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.18 1.19 diff

    Log Message:
    Make ecfg a local variable, not a global one.
  14. deuce
    Thu Aug 09 2018 01:06 pm PDT

    Modified Files:
    exec/ircbots/weather/weather_commands.js 1.27 1.28 diff

    Log Message:
    Display the relative humidity as well.
  15. deuce
    Thu Aug 09 2018 01:05 pm PDT

    Modified Files:
    exec/ircbots/dis/dis.js 1.9 1.10 diff

    Log Message:
    Add null check.
  16. rswindell
    Wed Aug 08 2018 03:23 pm PDT

    Modified Files:
    src/smblib/smbtxt.c 1.33 1.34 diff

    Log Message:
    Additional fix to mime_getattachment() - terminate the filename at the
    first white-space character encountered.
  17. rswindell
    Wed Aug 08 2018 03:14 pm PDT

    Modified Files:
    src/smblib/smbtxt.c 1.32 1.33 diff

    Log Message:
    Fix potential buffer overrun in mime_getattachment() when the MIME
    'content-disposition' filename parameter is not terminated with a double-
    quote or semi-colon character.
  18. rswindell
    Tue Aug 07 2018 11:59 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.24 3.25 diff
    src/sbbs3/sbbsecho.c 3.91 3.92 diff
    src/sbbs3/rechocfg.c 3.31 3.32 diff
    src/sbbs3/echocfg.c 3.35 3.36 diff

    Log Message:
    Incremented version to 3.06
    Added version for Bill McGarrity: for each linked-node, a preferred
    local address (AKA) can be specified to be used as the source address
    when creating packets destined for that linked-node. If no local address
    is specified, the previous (best match) logic is used: find an AKA that
    has the same zone and net as the destination address, if none found, use
    the first address with the same zone.
  19. rswindell
    Mon Aug 06 2018 07:16 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.106 1.107 diff

    Log Message:
    If the user number is 0, don't open the user file (user.dat) - the read
    of the user record is going to fail anyway. *this* explains a lot of
    instances of the user.dat file being open concurrently, at least one per
    active thread with a JS context.
  20. rswindell
    Mon Aug 06 2018 05:49 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.105 1.106 diff

    Log Message:
    js_CreateUserObject(): if passed an internal user_t representation, the
    user data is thusly cached - set the 'cached' property member to TRUE. This
    prevents an unnecessary re-read of the user file and the leaving the user file
    (user.dat) open, at least for JS contexts that contain a "user" object. I don't
    think this explains the "too many open files" errors, but it explains at least
    *some* number of the user.dat open file descriptors.
  21. rswindell
    Thu Aug 02 2018 11:37 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.90 3.91 diff

    Log Message:
    Don't delete netmail file attachments: just because the netmail was exported
    to .msg file doesn't mean you should delete the file attachment! The .msg
    file will still be pointing to that file and it needs to be there.
    SBBSecho was silently failing to delete file attachments on my system, so
    I didn't see this problem. Oops. Anyway, this explains Al's problem with
    netmail attachments.
  22. rswindell
    Thu Aug 02 2018 11:27 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.726 1.727 diff

    Log Message:
    Fix conditions where event log messages could still be sent to the terminal
    server log output/window.
    Also added comment about an observed exception upon shutdown with regards to
    the node_threads_running counter (protected int) being accessed after
    destruction.
  23. rswindell
    Thu Aug 02 2018 11:25 pm PDT

    Modified Files:
    src/sbbs3/getmail.c 1.17 1.18 diff

    Log Message:
    delfattch() now returns FALSE if any of the file attachments could not be
    removed.
  24. rswindell
    Thu Aug 02 2018 11:24 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.486 1.487 diff

    Log Message:
    delfattch() returns BOOL now.
  25. rswindell
    Thu Aug 02 2018 11:18 pm PDT

    Modified Files:
    src/sbbs3/bulkmail.cpp 1.38 1.39 diff
    src/sbbs3/chat.cpp 1.77 1.78 diff
    src/sbbs3/con_hi.cpp 1.26 1.27 diff
    src/sbbs3/download.cpp 1.52 1.53 diff
    src/sbbs3/email.cpp 1.68 1.69 diff
    src/sbbs3/fido.cpp 1.61 1.62 diff
    src/sbbs3/listfile.cpp 1.63 1.64 diff
    src/sbbs3/netmail.cpp 1.50 1.51 diff
    src/sbbs3/newuser.cpp 1.72 1.73 diff
    src/sbbs3/postmsg.cpp 1.108 1.109 diff
    src/sbbs3/qwk.cpp 1.84 1.85 diff
    src/sbbs3/qwktomsg.cpp 1.66 1.67 diff
    src/sbbs3/readmail.cpp 1.79 1.80 diff
    src/sbbs3/readmsgs.cpp 1.104 1.105 diff
    src/sbbs3/scansubs.cpp 1.25 1.26 diff
    src/sbbs3/text_sec.cpp 1.15 1.16 diff
    src/sbbs3/tmp_xfer.cpp 1.48 1.49 diff
    src/sbbs3/un_rep.cpp 1.66 1.67 diff
    src/sbbs3/upload.cpp 1.60 1.61 diff
    src/sbbs3/useredit.cpp 1.50 1.51 diff
    src/sbbs3/writemsg.cpp 1.123 1.124 diff
    src/sbbs3/xtrn.cpp 1.237 1.238 diff

    Log Message:
    Removed a bunch of duplicate user aliases from log messages now that
    sbbs::lputs() will log the current user alias already, logline()->lputs() would
    create log messages with the user alias twice.
  26. rswindell
    Thu Aug 02 2018 10:48 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.89 3.90 diff

    Log Message:
    Log an error if one or more file attachments could not be deleted when
    attempted.
  27. rswindell
    Thu Aug 02 2018 10:47 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfg.c 1.96 1.97 diff

    Log Message:
    Fix gcc printf format warning.
  28. rswindell
    Wed Aug 01 2018 03:34 pm PDT

    Modified Files:
    exec/load/userprops.js 1.1 1.2 diff

    Log Message:
    Allow a default value to be passed to the get() method, fixes problem
    with email_sec.js:
    line 65: TypeError: addr_list.indexOf is not a function
  29. echicken
    Wed Aug 01 2018 02:57 pm PDT

    Modified Files:
    exec/nntpservice.js 1.123 1.124 diff

    Log Message:
    RFC3977-compliant handling of 2-digit year in NEWGROUPS.
    If yy <= current 2-digit year, yy is assumed to be from this century,
    else it is assumed to refer to the previous century.
  30. echicken
    Wed Aug 01 2018 02:15 pm PDT

    Modified Files:
    exec/nntpservice.js 1.122 1.123 diff

    Log Message:
    In the case of a two-digit year, run it through parseInt with radix 10.  On the off chance we look at a message area created from 2000-2009 this will help, I guess.
    Go back to putting month and day through parseInt, but specify radix 10.  In some *cough* older JS interpreters, parseInt likes to treat any string beginning with 0 as octal.
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt#Octal_interpretations_with_no_radix
  31. echicken
    Wed Aug 01 2018 01:57 pm PDT

    Modified Files:
    exec/nntpservice.js 1.121 1.122 diff

    Log Message:
    Removed check for js.global.file_cdate (unused, I think).
    Don't run month/day through parseInt.  On my system, parseInt('08') yields 0 while parseInt('8') yields 8.  Days/months < 10 end up being -1, which apparently doesn't bother the Date constructor.
  32. rswindell
    Tue Jul 31 2018 03:30 pm PDT

    Modified Files:
    src/sbbs3/gtkchat/objects.mk 1.1 1.2 diff

    Log Message:
    userdat.* now dependent on msgdate.*
  33. rswindell
    Mon Jul 30 2018 01:43 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.88 3.89 diff

    Log Message:
    Fix crash (segfault) reported in AreaFix handler for "-ALL", reported
    by Ragnarok@DOCKSUD.
  34. rswindell
    Mon Jul 30 2018 01:29 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.676 1.677 diff

    Log Message:
    Fix chk_email_addr() for strings which begin with a name, specifically for
    mail "To" and "From" header fields of the form: user name <user@addr> or
    "user name" <user@addr> - the email.can filtering would not work
  35. echicken
    Sun Jul 29 2018 04:10 pm PDT

    Modified Files:
    xtrn/ansiview/ansiview.js 1.25 1.26 diff

    Log Message:
    Handle extensionless files. Untested, totally fine I'm sure.
  36. rswindell
    Sun Jul 29 2018 01:21 am PDT

    Modified Files:
    src/sbbs3/getnode.cpp 1.48 1.49 diff

    Log Message:
    The trigger to print a CRLF before claling putmsg() from getnmsg() and
    getsmsg() is now based on the current console column (!=0), not the current
    node action.
  37. rswindell
    Sat Jul 28 2018 10:33 pm PDT

    Modified Files:
    src/sbbs3/execfunc.cpp 1.43 1.44 diff

    Log Message:
    Finish reversion of the rev 1.42 feature (save/reuse previous netmail addr)
  38. rswindell
    Sat Jul 28 2018 10:18 pm PDT

    Added Files:
    exec/privatemsg.js NONE 1.1 diff

    Log Message:
    A new module that can be used to replace the hard-coded private message
    hot key (Ctrl-P) handler.
    
    Currently, it behaves nearly identically to the hard-coded C++ function,
    but my plans are to intergrate the inter-BBS instant messaging functionality
    in here to make it easier to send and reply to instant messages.
    
    Install this module in SCFG->External Programs->Global Hot Key Events:
    Global Hot Key             Ctrl-P        
    Command Line               ?privatemsg.js
  39. rswindell
    Sat Jul 28 2018 10:01 pm PDT

    Modified Files:
    exec/email_sec.js 1.1 1.2 diff

    Log Message:
    Store a history (of 10) destination netmail addresses and pass them to
    console.getstr() so they can be recalled with the up/down arrow keys.
  40. rswindell
    Sat Jul 28 2018 09:57 pm PDT

    Modified Files:
    src/sbbs3/js_console.cpp 1.117 1.118 diff

    Log Message:
    Document (in jsdocs) the new history argument to console.getstr()
  41. rswindell
    Sat Jul 28 2018 09:53 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.485 1.486 diff
    src/sbbs3/getstr.cpp 1.31 1.32 diff
    src/sbbs3/js_console.cpp 1.116 1.117 diff

    Log Message:
    getstr() - both the C++ and JS (console method) versions, now accept an
    additional, optional, "history" argument - an array of strings that can
    be recalled/scrolled using the up/down arrow keys. Currently, I just plan
    to use this for netmail destination address recall, but it could be used
    other places easily enough.
  42. rswindell
    Sat Jul 28 2018 09:45 pm PDT

    Modified Files:
    exec/nntpservice.js 1.120 1.121 diff

    Log Message:
    More NEWGROUPS madness:
    If the "GMT" zone is not specified by the client, presume the date/time
    comparison values are in the server's local timezone. If the client and
    server are not in the same timezone, this could lead to confusing behavior.
  43. rswindell
    Sat Jul 28 2018 09:33 pm PDT

    Modified Files:
    src/sbbs3/inkey.cpp 1.55 1.56 diff

    Log Message:
    Change how the global hot key recursion control (hostkey_inside) works:
    from a counter, which allowed 2 depths of nesting (any 2 hot key handlers)
    to a bit-mask which disallows *any* hot key handler to be re-entrant, but
    you can enter any of the *other* hot key handlers from any *other* hot
    key handler.
    
    Previously, for example, you could hit Ctrl-P to enter the private message
    prompt and then Ctrl-P again to re-enter the private message prompt
    (recusively) - confusingly, requiring 2 'Q'uits to get back to whatever
    you were doing before you hit the first Ctrl-P. Been like this forever.
    Now, while in the Ctrl-P (private message) handler, hitting Ctrl-P again
    does nothing. But you can hit Ctrl-T, or Ctrl-K or any other global hot
    key and it'll work but those in turn will also disallow recursion of their
    own handlers.
  44. rswindell
    Sat Jul 28 2018 07:10 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.56 1.57 diff
    src/sbbs3/scfg/scfgsub.c 1.48 1.49 diff

    Log Message:
    Fixed bug introduced in rev 1.52 of scfgmsg.c: We're not displaying
    the data dir here, we're using it to delete the data files! This explains
    why sub data wasn't getting deleted when deleting a message group and
    answering "Yes" to the "Delete All Data in Group" dialog.
    Eliminated the "clearing ptrs" thing - not needed any more since the move
    from ptrs/*.ixb to user/*.subs files.
  45. rswindell
    Sat Jul 28 2018 07:05 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnode.c 1.33 1.34 diff

    Log Message:
    Cosmetic changes only (popups).
  46. rswindell
    Sat Jul 28 2018 07:05 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfg.c 1.95 1.96 diff

    Log Message:
    Cosmetic changes only (popups, mostly).
  47. rswindell
    Sat Jul 28 2018 06:10 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.55 1.56 diff
    src/sbbs3/scfg/scfgsub.c 1.47 1.48 diff

    Log Message:
    Improvements to importing message areas:
    - If an FTN Echo Tag is more than 25 chars, copy it to the newly created
      sub's "newsgroup" name
      (when exporting areas to echolists, use the newsgroup name for the FTN
      Area/Echo Tag field, if it's not blank)
    - Copied the duplicate internal code logic from the importing file areas
      code - it works a lot better
    
    With these changes I was able to successfully import 10247 areas from the
    usenet group listing he sent me (with 10258 areas listed). The areas that
    were over-written during import were due to the first 63 characters of the
    newsgroup names being duplicated - sorry, that's the best I can do.
  48. rswindell
    Sat Jul 28 2018 06:01 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfg.c 1.94 1.95 diff

    Log Message:
    More status pop-ups when exiting SCFG and saving changes.
  49. rswindell
    Sat Jul 28 2018 06:00 pm PDT

    Modified Files:
    src/uifc/uifc.h 1.92 1.93 diff

    Log Message:
    Increase the maximum number of menu options from 10,000 to 100,000 to
    accommodate configurations of more than 10,000 things (e.g. sub-boards)
    in a single menu (e.g. message group).
    This brings this value over the 16-bit thresholds (0x7ffff and 0xffff)
    where problems could happen if short's/int16's are used to capture the
    return value of uifc.list(), but that's unlikely happening anywhere. Still
    a good idea to make sure if you're using this library/headers.
  50. rswindell
    Sat Jul 28 2018 05:27 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.87 3.88 diff

    Log Message:
    When adding a new sub-board to the area file, if the sub has a "newsgroup"
    name specified, use that instead of the short name as the "Echo Tag"
    (Area Tag) value.
  51. rswindell
    Sat Jul 28 2018 05:26 pm PDT

    Modified Files:
    src/sbbs3/load_cfg.c 1.73 1.74 diff

    Log Message:
    Remove dots (.) from internal codes auto-generated from other strings.
  52. rswindell
    Sat Jul 28 2018 05:17 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfg.c 1.93 1.94 diff

    Log Message:
    Fix a couple of cosmetic things with the -import command.
  53. rswindell
    Sat Jul 28 2018 05:15 pm PDT

    Modified Files:
    src/sbbs3/js_msg_area.c 1.70 1.71 diff

    Log Message:
    Fix apparent typo in revision 1.69 by deuce
  54. rswindell
    Sat Jul 28 2018 03:27 pm PDT

    Modified Files:
    src/sbbs3/scfgsave.c 1.75 1.76 diff

    Log Message:
    When attempting to create message base during config-save, make sure the
    full path to the data dir is created first (note: md() calls mkpath()).
    write_msgs_cfg() will now return FALSE if any message bases couldn't be
    created, but nobody is checking the return value currently.
  55. rswindell
    Sat Jul 28 2018 03:04 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgsub.c 1.46 1.47 diff

    Log Message:
    Fix bug introduced in rev 1.41:
    If there were any sub-boards in the group of a newly created sub-board,
    the newly created sub-board would not have the "HDRMOD" misc flag set, so
    its data files would not be created when saving changes/exiting SCFG.
  56. rswindell
    Sat Jul 28 2018 01:13 pm PDT

    Modified Files:
    exec/nntpservice.js 1.119 1.120 diff

    Log Message:
    NEWGROUPS command, again:
    only list a newsgroup (sub-board) if all of these conditions are true:
    1. It has a .ini file that can be opened
    2. It has a "Created" value and it's later than (or equal to) the requested
       date/time
    3. The message base can be opened
  57. rswindell
    Sat Jul 28 2018 01:10 am PDT

    Modified Files:
    exec/nntpservice.js 1.118 1.119 diff

    Log Message:
    Simplify the NEWGROUPS response (msg area list) filtering:
    - Removed the file "ctime" check as it's not accurate - oh well
    - Removed the index record check - not a good idea (msg purging and all)
    - If the "Created" key in the msgbase.ini file doesn't exist, it's
      obviously not a new msg area! :-)
  58. rswindell
    Fri Jul 27 2018 07:32 pm PDT

    Modified Files:
    exec/nntpservice.js 1.117 1.118 diff

    Log Message:
    Experimental fix for NEWGROUPS command:
    - compares date with the "Created" key in the subs .ini file (if it has one)
    - compare date against the oldest message index record, if there is one
  59. rswindell
    Fri Jul 27 2018 04:39 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.169 1.170 diff

    Log Message:
    Fixed a couple of issues with the last commit.
    Make similar enhancements to the bbs.put_node_message() method:
    - if you message text is given, it is prompted for
    - if no node number is given, it is prompted for
    - if a node number value of -1 is specified, send message to all nodes
    - logs the activity
  60. rswindell
    Fri Jul 27 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.168 1.169 diff

    Log Message:
    bbs.put_telegram() enhancements (mostly copy/pasted from chat.cpp):
    - now creates a log entry that the user sent a telegram to somebody
    - if a destination user number is not specified, one is prompted for
    - the destination user number is compared against the current user's
      restrictions (e.g. F-restricted users can't telegram the sysop)
    - if a telegram message text is not specified, one is prompted for
    
    unrelated fix to bbs.list_msgs(): if a 'find' argument was passed, too many
    increments of argn in call to macro: JSVALUE_TO_MSTRING
  61. rswindell
    Fri Jul 27 2018 02:37 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.167 1.168 diff

    Log Message:
    Fix copy/paste errors in previous commit.
  62. rswindell
    Fri Jul 27 2018 02:32 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.166 1.167 diff

    Log Message:
    New JS 'bbs' properties:
    node_status - reflects the current node's 'status' value (see nodedefs.js)
    node_errors - current node's error counter
    node_useron - current node's logged-in user number (if applicable, else 0)
    node_connection - current node's connection rate or protocol
    node_misc - see nodedefs.js
    node_aux - see nodedefs.js
    node_extaux - see nodedefs.js
    
    This are read-only wrappers around the sbbs_t::thisnode property and have
    the same fundamental meaning as the properties of the same names in the
    system.node_list[] array.
    
    bbs.node_action is a little different as it is the authorative action value
    that should be sync'd with the node database (node.dab) and not necessarily
    the current value in the node database - it's also writeable.
  63. rswindell
    Fri Jul 27 2018 02:02 pm PDT

    Modified Files:
    exec/hatchit.js 1.3 1.4 diff

    Log Message:
    Fix bug reported by Al @ TRMB:
    
    From FTS-5006:
    "The CRC an eight digit hex number, preferably written in upper case"
    
    However hatchit was writing the CRC value in decimal notation.
  64. rswindell
    Thu Jul 26 2018 07:27 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.165 1.166 diff

    Log Message:
    Fix long-time JSDOC error: bbs.good_password() returns Boolean, not String.
  65. rswindell
    Thu Jul 26 2018 06:49 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.164 1.165 diff

    Log Message:
    Created 2 new bbs methods: select_node() and select_user().
    These are wrappers for the C++ function: sbbs::getnodetopage() and will
    be used by the privatemsg.js (Ctrl-P handler) and possibly other node/user
    interaction stuff in the future.
  66. rswindell
    Thu Jul 26 2018 06:23 pm PDT

    Modified Files:
    src/sbbs3/newuser.cpp 1.71 1.72 diff

    Log Message:
    Fixed GCC warning: format not a string literal and no format arguments
  67. rswindell
    Wed Jul 25 2018 11:24 pm PDT

    Modified Files:
    src/sbbs3/putnode.cpp 1.21 1.22 diff

    Log Message:
    putnodedat() - don't try to lock the node.dab file again (should be locked
    already with a call to getnodedat()).
    When using the MSVC2017 CRTL, a lock() of a region that was previously
    locked is a blocking call causing major slowness in the MSVC2017 build.
    This just reverses the 1-line commit from 16 years ago in rev 1.10 of this file.
  68. rswindell
    Wed Jul 25 2018 11:22 pm PDT

    Modified Files:
    src/sbbs3/getnode.cpp 1.47 1.48 diff

    Log Message:
    getnodedat() - don't try to unlock the node.dab file unless the read() fails.
    When using the MSVC2017 CRTL, an unlock() of a region that was not previously
    locked is a blocking call causing major slowness in the MSVC2017 build.
  69. rswindell
    Wed Jul 25 2018 11:21 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.203 1.204 diff

    Log Message:
    getuserdat() - if this function fails to open the user.dat file (e.g. it does
    not exist), set the user->number to 0 before returning as many callers of this
    function do not check the return value, just the value of user->number after
    it returns (ugh). This problem was discovered when running a fresh install,
    typing "1" at the Login prompt and immediately getting a "Time's Up" message
    and a disconnect - only happens when there's no data/user.dat file.
    
    getnodedat() - don't try to unlock the node.dab file unless the read() fails.
    When using the MSVC2017 CRTL, an unlock() of a region that was not previously
    locked is a blocking call causing major slowness in the MSVC2017 build.
    
    putmsgptrs() - cleans up obsolete sections in the data/user/*.subs files now.
    So if you go from say 10,000 sub-boards to 2,000, it won't have to load and
    search through the extra 8,000 invalid subs (once the file is re-written upon
    log-off). This requires an updated xpdev build (for iniAppendSectionWithKeys)
    
    fixmsgptrs() - if the msgbase index can't be opened or the last index record
    cannot be read (e.g. there isn't one), insure the msg-scan pointer value is
    set to 0 (not ~0).
  70. rswindell
    Wed Jul 25 2018 10:36 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.163 1.164 diff
    src/xpdev/ini_file.h 1.55 1.56 diff

    Log Message:
    iniGetSection() no longer includes blank lines (if there are any in the
    section) in the returned stringlist.
    Created iniAppendSectionWithKeys(): similar to iniAppendSection, but a list
    of list of "key=[value]" strings (like those returned from iniGetSection())
    can be added at the same time.
  71. rswindell
    Wed Jul 25 2018 01:40 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.725 1.726 diff

    Log Message:
    More eprintf() to sbbs->lprintf() conversion.
  72. rswindell
    Wed Jul 25 2018 12:02 am PDT

    Modified Files:
    src/sbbs3/execfunc.cpp 1.42 1.43 diff

    Log Message:
    Revert the feature added in rev 1.42 of this file (save/re-use netmail
    destination addresses): this feature messed up the smeg@ address book
    Baja module.
    Use the email_sec.js module if you want this feature.
  73. rswindell
    Tue Jul 24 2018 11:28 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.724 1.725 diff

    Log Message:
    Strip control codes from strings logged with sbbs_t::lputs().
  74. rswindell
    Tue Jul 24 2018 11:23 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.723 1.724 diff

    Log Message:
    More useron number clearing after timed event segments.
  75. rswindell
    Tue Jul 24 2018 11:12 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.722 1.723 diff

    Log Message:
    Make sure the current user number is 0 when terminating the event thread
    or else we may end up with user names in log msgs that don't apply.
  76. rswindell
    Tue Jul 24 2018 11:07 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.236 1.237 diff

    Log Message:
    Another eprintf to lprintf change.
  77. rswindell
    Tue Jul 24 2018 09:20 pm PDT

    Modified Files:
    src/sbbs3/qwk.cpp 1.83 1.84 diff

    Log Message:
    Log an error if any files in the data/qnet/*.out directory could not be
    removed.
  78. rswindell
    Tue Jul 24 2018 09:20 pm PDT

    Modified Files:
    src/xpdev/dirwrap.c 1.100 1.101 diff
    src/xpdev/dirwrap.h 1.49 1.50 diff

    Log Message:
    delfiles() needs to return a signed value (long, not ulong) to indicate
    a faliure.
    delfiles() now returns a negative result upon any deletion errors.
  79. rswindell
    Tue Jul 24 2018 09:00 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.721 1.722 diff

    Log Message:
    More eprintf() to sbbs->lputs/lprintf() replacements.
  80. rswindell
    Tue Jul 24 2018 08:43 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.484 1.485 diff

    Log Message:
    Resolve warning: ISO C++ forbids converting a string constant to ΓÇÿchar*ΓÇÖ
  81. rswindell
    Tue Jul 24 2018 08:39 pm PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.97 1.98 diff
    src/sbbs3/con_out.cpp 1.85 1.86 diff
    src/sbbs3/data_ovl.cpp 1.26 1.27 diff
    src/sbbs3/logfile.cpp 1.61 1.62 diff
    src/sbbs3/logout.cpp 1.30 1.31 diff
    src/sbbs3/main.cpp 1.720 1.721 diff
    src/sbbs3/pack_qwk.cpp 1.79 1.80 diff
    src/sbbs3/sbbs.h 1.483 1.484 diff
    src/sbbs3/xtrn.cpp 1.235 1.236 diff
    src/sbbs3/xtrn_sec.cpp 1.85 1.86 diff

    Log Message:
    sbbs_t::lputs() now handles the adding of the log message prefixes
    ("Node X", user alias, etc.) - so removing a lot of the redundancies.
    Also, logging the current timed event code and other prefixes in the
    event thread log messages - something I've wanted for a while now.
    There might be some redundant "Node X" strings, so if you see some funny
    looking log message, please let me know.
  82. rswindell
    Tue Jul 24 2018 05:40 pm PDT

    Modified Files:
    src/sbbs3/atcodes.cpp 1.80 1.81 diff
    src/sbbs3/execmisc.cpp 1.55 1.56 diff
    src/sbbs3/getstr.cpp 1.30 1.31 diff
    src/sbbs3/listfile.cpp 1.62 1.63 diff
    src/sbbs3/pack_qwk.cpp 1.78 1.79 diff
    src/sbbs3/readmsgs.cpp 1.103 1.104 diff
    src/sbbs3/sbbs.h 1.482 1.483 diff
    src/sbbs3/str.cpp 1.79 1.80 diff
    src/sbbs3/writemsg.cpp 1.122 1.123 diff

    Log Message:
    Enable GCC printf-format checking for more printf-style functions and
    fix the resulting warnings.
  83. rswindell
    Tue Jul 24 2018 05:24 pm PDT

    Modified Files:
    src/sbbs3/un_rep.cpp 1.65 1.66 diff

    Log Message:
    A little better error reporting on bad .REP packets.
  84. rswindell
    Tue Jul 24 2018 04:55 pm PDT

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.25 1.26 diff

    Log Message:
    Even more details (number of subs) in the "read message ... pointers"
    debug log msg.
  85. rswindell
    Tue Jul 24 2018 04:37 am PDT

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.24 1.25 diff
    src/sbbs3/msgdate.c 1.6 1.7 diff
    src/sbbs3/userdat.c 1.202 1.203 diff

    Log Message:
    Reduce the amount of time to load msg ptrs/config from *.subs files even
    more (!) by removing the sections from the total file string list, once parsed.
    Fixed a couple of minor and unlikely off-by-one errors with message ptrs
    based on date/time.
  86. rswindell
    Tue Jul 24 2018 01:41 am PDT

    Modified Files:
    src/sbbs3/ntsvcs.c 1.48 1.49 diff
    src/sbbs3/sbbs_ini.c 1.163 1.164 diff
    src/sbbs3/sbbscon.c 1.270 1.271 diff
    src/sbbs3/startup.h 1.80 1.81 diff

    Log Message:
    Remove/deprecate trailing references to the "SYSOP_AVAILABLE" startup
    option - the sysop chat availability is now controlled via semaphore
    file (ctrl/sysavail.chat).
  87. rswindell
    Tue Jul 24 2018 01:39 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.201 1.202 diff

    Log Message:
    Small optimization here: don't read the last msg idx twice.
  88. rswindell
    Tue Jul 24 2018 01:38 am PDT

    Modified Files:
    ctrl/sbbs.ini 1.75 1.76 diff

    Log Message:
    Removed a trailing reference to the SYSOP_AVAILABLE option (controlled
    via BBS/terminal server startup option flags, now controlled via semfile).
  89. rswindell
    Tue Jul 24 2018 12:03 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.200 1.201 diff

    Log Message:
    Fix major faux pas in previous commit - whoops.
  90. rswindell
    Mon Jul 23 2018 11:39 pm PDT

    Modified Files:
    src/sbbs3/objects.mk 1.69 1.70 diff

    Log Message:
    userdat.* now requires msgdate.*
  91. rswindell
    Mon Jul 23 2018 11:39 pm PDT

    Modified Files:
    src/sbbs3/umonitor/objects.mk 1.3 1.4 diff

    Log Message:
    userdat.* now requires msgdate.*
  92. rswindell
    Mon Jul 23 2018 11:38 pm PDT

    Modified Files:
    src/sbbs3/uedit/objects.mk 1.3 1.4 diff

    Log Message:
    userdat.* now requires msgdate.*
  93. rswindell
    Mon Jul 23 2018 11:29 pm PDT

    Modified Files:
    src/sbbs3/scfg/objects.mk 1.16 1.17 diff
    src/sbbs3/scfg/scfg.vcxproj 1.5 1.6 diff

    Log Message:
    msgdate.* is now needed by userdat.*, for newmsgs() function.
  94. rswindell
    Mon Jul 23 2018 10:36 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.199 1.200 diff

    Log Message:
    Speed-up getmsgptrs() (reads users/data/*.subs files) by only parsing
    each section (sub-code) once. Should cut the search/parse algorithm by 66%
    (since there's 3 keys/values we're searching for, per sub).
  95. rswindell
    Mon Jul 23 2018 10:15 pm PDT

    Modified Files:
    src/smblib/smblib.c 1.179 1.180 diff
    src/smblib/smblib.h 1.86 1.87 diff

    Log Message:
    Singificantlly improve message scan pointer initialization (e.g. for new
    users) and adjusting scan ptrs by date or set to "Last msg" while online:
    - speed (on my system, reduced from 12 to < 2 seconds)
      This involved 2 enhancements: check msgbase index file timestamp (fast)
      before opening any files. When opening the msgbase, just open the index
      file (no other msgbase files) - required new smblib function: smb_open_index.
    - fixed off-by-one when setting by date (when setting the new-scan ptr to
      Jan-1-2018, you want that first message posted on/after Jan-1-2018 to be
      found as "new", not the first message posted *after* that date.
    - re-added the fixmsgptrs() call in putmsgptrs(), inadvertently removed
      in the .ixb -> .ini ptr storage update in rev 1.192 of userdat.c.
  96. rswindell
    Mon Jul 23 2018 10:15 pm PDT

    Modified Files:
    src/sbbs3/getmsg.cpp 1.73 1.74 diff
    src/sbbs3/msgdate.c 1.5 1.6 diff
    src/sbbs3/sbbs.h 1.481 1.482 diff
    src/sbbs3/scansubs.cpp 1.24 1.25 diff
    src/sbbs3/text_defaults.c 1.46 1.47 diff
    src/sbbs3/userdat.c 1.198 1.199 diff

    Log Message:
    Singificantlly improve message scan pointer initialization (e.g. for new
    users) and adjusting scan ptrs by date or set to "Last msg" while online:
    - speed (on my system, reduced from 12 to < 2 seconds)
      This involved 2 enhancements: check msgbase index file timestamp (fast)
      before opening any files. When opening the msgbase, just open the index
      file (no other msgbase files) - required new smblib function: smb_open_index.
    - fixed off-by-one when setting by date (when setting the new-scan ptr to
      Jan-1-2018, you want that first message posted on/after Jan-1-2018 to be
      found as "new", not the first message posted *after* that date.
    - re-added the fixmsgptrs() call in putmsgptrs(), inadvertently removed
      in the .ixb -> .ini ptr storage update in rev 1.192 of userdat.c.
  97. rswindell
    Mon Jul 23 2018 06:20 pm PDT
    src/xpdev truncsp.c 1.3 NONE
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv11037
    
    Removed Files:
    	truncsp.c 
    Log Message:
    This file was not used by anything (thankfully, truncsp is defined in genwrap).
  98. rswindell
    Mon Jul 23 2018 06:13 pm PDT

    Modified Files:
    src/xpdev/conwrap.c 1.14 1.15 diff
    src/xpdev/conwrap.h 1.5 1.6 diff
    src/xpdev/dat_file.c 1.7 1.8 diff
    src/xpdev/dat_file.h 1.3 1.4 diff
    src/xpdev/dirwrap.h 1.48 1.49 diff
    src/xpdev/eventwrap.h 1.3 1.4 diff
    src/xpdev/filewrap.c 1.45 1.46 diff
    src/xpdev/filewrap.h 1.36 1.37 diff
    src/xpdev/netwrap.c 1.6 1.7 diff
    src/xpdev/netwrap.h 1.4 1.5 diff
    src/xpdev/semfile.h 1.1 1.2 diff
    src/xpdev/semwrap.c 1.14 1.15 diff
    src/xpdev/semwrap.h 1.15 1.16 diff
    src/xpdev/threadwrap.c 1.35 1.36 diff
    src/xpdev/threadwrap.h 1.50 1.51 diff
    src/xpdev/wrapdll.h 1.6 1.7 diff
    src/xpdev/xpendian.h 1.5 1.6 diff
    src/xpdev/xpevent.c 1.16 1.17 diff
    src/xpdev/xpevent.h 1.5 1.6 diff
    src/xpdev/xpmap.c 1.7 1.8 diff
    src/xpdev/xpmap.h 1.4 1.5 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  99. rswindell
    Mon Jul 23 2018 06:13 pm PDT

    Modified Files:
    src/uifc/uifc.c 1.30 1.31 diff
    src/uifc/uifctest.c 1.7 1.8 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  100. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/smblib/crc16.c 1.7 1.8 diff
    src/smblib/crc16.h 1.6 1.7 diff
    src/smblib/crc32.c 1.11 1.12 diff
    src/smblib/crc32.h 1.16 1.17 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  101. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sexpots/sexpots.c 1.30 1.31 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  102. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/umonitor/chat.c 1.18 1.19 diff
    src/sbbs3/umonitor/chat.h 1.4 1.5 diff
    src/sbbs3/umonitor/spyon.c 1.14 1.15 diff
    src/sbbs3/umonitor/spyon.h 1.2 1.3 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  103. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmdm.c 1.5 1.6 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  104. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/menuedit/menuedit.c 1.5 1.6 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  105. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/install/sbbsinst.c 1.98 1.99 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  106. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/gtkuseredit/gtkuseredit.glade 1.18 1.19 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  107. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/execvxd/sbbsexec.cpp 1.2 1.3 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  108. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/dosxtrn/dosxtrn.c 1.23 1.24 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  109. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/ctrl/AboutBoxFormUnit.cpp 1.12 1.13 diff
    src/sbbs3/ctrl/AboutBoxFormUnit.dfm 1.19 1.20 diff
    src/sbbs3/ctrl/AboutBoxFormUnit.h 1.5 1.6 diff
    src/sbbs3/ctrl/ClientFormUnit.cpp 1.14 1.15 diff
    src/sbbs3/ctrl/ClientFormUnit.h 1.5 1.6 diff
    src/sbbs3/ctrl/CodeInputFormUnit.cpp 1.3 1.4 diff
    src/sbbs3/ctrl/CodeInputFormUnit.h 1.3 1.4 diff
    src/sbbs3/ctrl/CtrlPathDialogUnit.cpp 1.2 1.3 diff
    src/sbbs3/ctrl/CtrlPathDialogUnit.h 1.2 1.3 diff
    src/sbbs3/ctrl/EventsFormUnit.cpp 1.2 1.3 diff
    src/sbbs3/ctrl/EventsFormUnit.h 1.3 1.4 diff
    src/sbbs3/ctrl/FtpCfgDlgUnit.h 1.7 1.8 diff
    src/sbbs3/ctrl/FtpFormUnit.h 1.6 1.7 diff
    src/sbbs3/ctrl/LoginAttemptsFormUnit.cpp 1.6 1.7 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.h 1.21 1.22 diff
    src/sbbs3/ctrl/MailFormUnit.h 1.6 1.7 diff
    src/sbbs3/ctrl/NodeFormUnit.cpp 1.28 1.29 diff
    src/sbbs3/ctrl/NodeFormUnit.h 1.10 1.11 diff
    src/sbbs3/ctrl/PreviewFormUnit.cpp 1.4 1.5 diff
    src/sbbs3/ctrl/PreviewFormUnit.h 1.4 1.5 diff
    src/sbbs3/ctrl/PropertiesDlgUnit.h 1.19 1.20 diff
    src/sbbs3/ctrl/ServicesFormUnit.h 1.7 1.8 diff
    src/sbbs3/ctrl/SpyFormUnit.cpp 1.13 1.14 diff
    src/sbbs3/ctrl/SpyFormUnit.h 1.9 1.10 diff
    src/sbbs3/ctrl/StatsFormUnit.cpp 1.2 1.3 diff
    src/sbbs3/ctrl/StatsFormUnit.h 1.2 1.3 diff
    src/sbbs3/ctrl/StatsLogFormUnit.cpp 1.3 1.4 diff
    src/sbbs3/ctrl/StatsLogFormUnit.h 1.1.1.1 1.2 diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.h 1.17 1.18 diff
    src/sbbs3/ctrl/TelnetFormUnit.h 1.6 1.7 diff
    src/sbbs3/ctrl/TextFileEditUnit.cpp 1.5 1.6 diff
    src/sbbs3/ctrl/TextFileEditUnit.h 1.2 1.3 diff
    src/sbbs3/ctrl/WebFormUnit.h 1.5 1.6 diff
    src/sbbs3/ctrl/sbbsctrl.bpr 1.46 1.47 diff
    src/sbbs3/ctrl/sbbsctrl.cpp 1.20 1.21 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  110. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/chat/MainFormUnit.cpp 1.7 1.8 diff
    src/sbbs3/chat/MainFormUnit.h 1.2 1.3 diff
    src/sbbs3/chat/chat.cpp 1.3 1.4 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  111. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/ars_defs.h 1.12 1.13 diff
    src/sbbs3/cmdshell.h 1.13 1.14 diff
    src/sbbs3/dat_rec.h 1.3 1.4 diff
    src/sbbs3/execmisc.cpp 1.54 1.55 diff
    src/sbbs3/fossdefs.h 1.2 1.3 diff
    src/sbbs3/getstats.c 1.3 1.4 diff
    src/sbbs3/ident.h 1.5 1.6 diff
    src/sbbs3/msdirent.c 1.2 1.3 diff
    src/sbbs3/msdirent.h 1.3 1.4 diff
    src/sbbs3/putnode.cpp 1.20 1.21 diff
    src/sbbs3/ringbuf.h 1.13 1.14 diff
    src/sbbs3/riodefs.h 1.1.1.1 1.2 diff
    src/sbbs3/sbbs4defs.h 1.5 1.6 diff
    src/sbbs3/sbbsdefs.h 1.221 1.222 diff
    src/sbbs3/sbbsexec.c 1.40 1.41 diff
    src/sbbs3/sexyz.h 1.12 1.13 diff
    src/sbbs3/telnet.h 1.16 1.17 diff
    src/sbbs3/text_defaults.c 1.45 1.46 diff
    src/sbbs3/text_sec.cpp 1.14 1.15 diff
    src/sbbs3/uartdefs.h 1.5 1.6 diff
    src/sbbs3/uucode.h 1.1 1.2 diff
    src/sbbs3/v4upgrade.c 1.15 1.16 diff
    src/sbbs3/vdd_func.h 1.9 1.10 diff
    src/sbbs3/viewfile.cpp 1.10 1.11 diff
    src/sbbs3/wordwrap.h 1.6 1.7 diff
    src/sbbs3/xmodem.h 1.23 1.24 diff
    src/sbbs3/yenc.h 1.1 1.2 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  112. rswindell
    Mon Jul 23 2018 06:10 pm PDT

    Modified Files:
    src/conio/ansi_cio.c 1.83 1.84 diff
    src/conio/ansi_cio.h 1.10 1.11 diff
    src/conio/curs_cio.c 1.40 1.41 diff
    src/conio/curs_cio.h 1.16 1.17 diff
    src/conio/curs_fix.h 1.2 1.3 diff
    src/conio/mouse.c 1.44 1.45 diff
    src/conio/vidmodes.h 1.28 1.29 diff
    src/conio/win32cio.c 1.107 1.108 diff
    src/conio/win32cio.h 1.14 1.15 diff
    src/conio/x_cio.c 1.49 1.50 diff
    src/conio/x_cio.h 1.24 1.25 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  113. rswindell
    Mon Jul 23 2018 06:10 pm PDT

    Modified Files:
    src/comio/comio.c 1.2 1.3 diff
    src/comio/comio.h 1.8 1.9 diff
    src/comio/comio_nix.c 1.12 1.13 diff
    src/comio/comio_win32.c 1.7 1.8 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  114. rswindell
    Mon Jul 23 2018 06:02 pm PDT

    Modified Files:
    docs/copyright.html 1.6 1.7 diff

    Log Message:
    The beginning of the big copyright year removal/update.
  115. rswindell
    Mon Jul 23 2018 04:07 pm PDT

    Modified Files:
    ctrl/text.dat 1.84 1.85 diff

    Log Message:
    Added a rounded/estimated file size (in parenthesis) to the FiFileSize
    output. Example:
    File size        : 7,128,414 (6.8M) bytes
  116. rswindell
    Mon Jul 23 2018 04:06 pm PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.44 1.45 diff

    Log Message:
    Added a rounded/estimated file size (in parenthesis) to the FiFileSize
    output. Example:
    File size        : 7,128,414 (6.8M) bytes
  117. rswindell
    Mon Jul 23 2018 04:05 pm PDT

    Modified Files:
    src/sbbs3/qwk.cpp 1.82 1.83 diff
    src/sbbs3/file.cpp 1.34 1.35 diff

    Log Message:
    Added a rounded/estimated file size (in parenthesis) to the FiFileSize
    output. Example:
    File size        : 7,128,414 (6.8M) bytes
  118. rswindell
    Mon Jul 23 2018 03:52 pm PDT

    Modified Files:
    src/xpdev/genwrap.c 1.108 1.109 diff
    src/xpdev/genwrap.h 1.113 1.114 diff

    Log Message:
    Add a precision argument to byte_estimate_to_str() so the caller can control
    the number of decimal places in the resulting string.
  119. rswindell
    Mon Jul 23 2018 03:41 pm PDT

    Modified Files:
    src/sbbs3/listfile.cpp 1.61 1.62 diff

    Log Message:
    Fix bug introduced in rev 1.60: when searching for a file and a single file
    matches the search spec, the 'D' batch-flagging command would invoke the
    downloadfile() method which confusingly, doesn't actually download (send)
    the file, but instead performs all the post-download functions needed. So
    the user would just see "<filename> sent." and possibly lose some credits
    without actually receiving the file.
  120. rswindell
    Thu Jul 19 2018 10:44 pm PDT

    Modified Files:
    src/xpdev/genwrap.c 1.107 1.108 diff
    src/xpdev/genwrap.h 1.112 1.113 diff

    Log Message:
    Fixed strcasestr() for Windows - oops.
    Created byte_estimate_to_str(), much like byte_count_to_str(), except the
    byte count is rounded to the nearest tera/giga/mega/kilo-byte
    (technically tebi/gibi/mebi/kibi-byte, but ugh, I'm old-sk00l!).
  121. rswindell
    Thu Jul 19 2018 07:50 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.675 1.676 diff

    Log Message:
    Remove redundant calls to remove_mgs_instransit() from sendmail_open_socket()
  122. rswindell
    Thu Jul 19 2018 06:38 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.h 1.86 1.87 diff

    Log Message:
    Fix the GCC format attribute thing to match the new sockprintf() prototype.
  123. rswindell
    Thu Jul 19 2018 06:34 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.674 1.675 diff
    src/sbbs3/mailsrvr.h 1.85 1.86 diff
    src/sbbs3/mime.c 1.11 1.12 diff
    src/sbbs3/mime.h 1.5 1.6 diff
    src/sbbs3/services.c 1.322 1.323 diff

    Log Message:
    Cosmetic/helpful improvements to the log output (a lot of search and replace).
    The "official" log line format is (as of right now at least):
    "[socket] [protocol] [user/host-ID] [! if error]message"
    Hopefully I can remember that when I add new log messages.
    
    Also setting the protocol to SMTPS, POP3S, SEND/TLS, when appropriate and
    passing it around to pretty much any function that can log a message.
    Added debug-level log output when the mail sever is sending message body text
    (every 100 lines).
  124. rswindell
    Thu Jul 19 2018 04:18 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.673 1.674 diff

    Log Message:
    Fix SMTP-sending mail bug when SMTP/TLS was successfully negotiated:
    The "max lines" parameter value passed to sockmsgtxt was using the cryptlib
    session number - this would truncate sent email bodies to some seemingly
    random number of lines. Introduced in rev 1.622.
    Also added a couple of helpful log lines to let the log-reader know if/when
    TLS was successfully negotiated for sendmail sessions.
  125. rswindell
    Thu Jul 19 2018 11:23 am PDT

    Modified Files:
    src/xpdev/genwrap.c 1.106 1.107 diff
    src/xpdev/genwrap.h 1.111 1.112 diff

    Log Message:
    Create a strcasestr() implementation for MSVC (Windows) builds.
  126. rswindell
    Wed Jul 18 2018 09:44 pm PDT

    Modified Files:
    src/sbbs3/dupefind.c 1.4 1.5 diff

    Log Message:
    Update the indent/brace style in this ancient source file.
  127. rswindell
    Wed Jul 18 2018 09:13 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.23 3.24 diff
    src/sbbs3/sbbsecho.c 3.86 3.87 diff
    src/sbbs3/rechocfg.c 3.30 3.31 diff
    src/sbbs3/echocfg.c 3.34 3.35 diff

    Log Message:
    Added a "MinFreeDiskSpace" setting to the root section of sbbsecho.ini
    (defaults to 10 megabytes, "10M").
    When SBBSecho starts up, if this minimum amount of free space is not
    available in any of the following directories, SBBSecho will display an
    error and immediately exit:
    - data directory (in SCFG)
    - logs directory (in SCFG)
    - netmail directory (in SCFG)
    - outbound directory (from sbbsecho.ini)
    - temp directory
    - each linked-node's outbox, if configured
    
    If the sysop runs out of disk space for some reason, at least SBBSecho
    won't contribute to the problem.
  128. rswindell
    Wed Jul 18 2018 03:42 pm PDT

    Modified Files:
    ctrl/sbbsecho.ini 1.4 1.5 diff

    Log Message:
    Added vkradio (zone 432) DNS suffix.
  129. rswindell
    Tue Jul 17 2018 09:50 pm PDT

    Modified Files:
    src/sbbs3/delfiles.c 1.9 1.10 diff

    Log Message:
    Update brace style in this ancient source file.
  130. rswindell
    Tue Jul 17 2018 09:12 pm PDT

    Modified Files:
    ctrl/sbbsecho.ini 1.3 1.4 diff

    Log Message:
    fsxNet now has a domain for DNS-based address look-ups.
  131. nightfox
    Tue Jul 17 2018 08:11 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.122 1.123 diff
    xtrn/DDMsgReader/readme.txt 1.18 1.19 diff

    Log Message:
    Version 1.17 beta 63: Just before showing the message list or changing to another message area from the reader interface, it now writes "Loading..." in case there are a very large number of messages or sub-boards.
  132. rswindell
    Mon Jul 16 2018 11:31 pm PDT

    Modified Files:
    src/smblib/smbadd.c 1.39 1.40 diff
    src/smblib/smballoc.c 1.12 1.13 diff
    src/smblib/smblib.c 1.178 1.179 diff

    Log Message:
    fread() and fwrite() do not set 'errno' to a meaningful value upon failure,
    so remove 'errno' value (and corresponding error strings) from generated
    /logged error messages. fseek(), read(), write(), open(), etc. do set errno
    to a meaningful value, so we still log errno/strerror() in those failure
    cases.
  133. rswindell
    Mon Jul 16 2018 10:42 pm PDT

    Modified Files:
    src/sbbs3/chksmb.c 1.62 1.63 diff

    Log Message:
    Replace the hard-coded beep/BEL characters in the "Hit any key to continue..."
    prompts with the conditional beep enabled only with the '-b' option
    (silent by default). Thanks to Nelgin.
  134. rswindell
    Sun Jul 15 2018 10:42 pm PDT

    Modified Files:
    src/sbbs3/js_msgbase.c 1.220 1.221 diff

    Log Message:
    Rename this private_t.status to private_t.smb_result, to avoid confusion
    with smb_t.status.
  135. rswindell
    Sun Jul 15 2018 12:53 am PDT

    Modified Files:
    src/sbbs3/filelist.c 1.19 1.20 diff

    Log Message:
    Brace-style update of this ancient source file.
  136. deuce
    Fri Jul 13 2018 11:07 am PDT

    Modified Files:
    exec/ircbots/ham/ham.js 1.32 1.33 diff

    Log Message:
    Add 10min/hr/day change stats.
  137. deuce
    Fri Jul 13 2018 12:43 am PDT

    Modified Files:
    exec/ircbots/ham/ham.js 1.31 1.32 diff

    Log Message:
    Add bands command for real-time conditions from bandconditions.com
  138. rswindell
    Sun Jul 08 2018 06:36 pm PDT

    Modified Files:
    exec/binkit.js 2.5 2.6 diff

    Log Message:
    Fix the "too much recursion" error when running from JSexec, need a different
    log prefix solution.
  139. rswindell
    Sun Jul 08 2018 04:55 pm PDT

    Modified Files:
    exec/load/binkp.js 1.108 1.109 diff

    Log Message:
    Fix potential infinite loop in send_chunks(), some versions of Socket.send()
    can return false on error, which is >= 0, so this will just add 0 to the
    length and keep on looping forever in that case.
  140. deuce
    Sun Jul 08 2018 04:44 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.220 1.221 diff

    Log Message:
    Update documentation to match the behaviour... send() returns undefined,
    not null on failure.
  141. deuce
    Sun Jul 08 2018 04:33 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.219 1.220 diff

    Log Message:
    Fix js_send() to conform to documentation.
    Also, is that some line ending weirdness?  *shrug*
  142. rswindell
    Sun Jul 08 2018 03:38 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.127 1.128 diff

    Log Message:
    Added support for referencing a message on the command-line with the
    'l' (list messages), 'x' (dump index), 'r' (read msgs), and 'v' (view msgs)
    commands by "days old", by specifying a negative number (in days).
    (e.g. "smbutil r-30" would read messages posted within the past 30 days).
    This was added to test the smb_getmsgidx_by_time() function, but has some
    value otherwise I suppose.
  143. rswindell
    Sun Jul 08 2018 03:10 pm PDT

    Modified Files:
    exec/load/binkp.js 1.107 1.108 diff

    Log Message:
    Fix what appears to be a few potential infinite loops where
    recvFrame() is being called in a loop and only breaking on specific
    conditions or if recvFrame returned undefined. Problem is, on timeout,
    recvFrame returns null (and when using === comparision, undefined !== null).
    Also added more debug output around sends where I suspect there might be
    another potential infinite loop.
  144. rswindell
    Sun Jul 08 2018 02:50 pm PDT

    Modified Files:
    exec/load/binkp.js 1.106 1.107 diff

    Log Message:
    More log output around connecting to a node.
    I suspect that connect() may be blocking and causing Al's reported issue
    (A BinkIT poll never returns from the script and goes into some kind of
    infinite busy loop).
  145. rswindell
    Sun Jul 08 2018 02:48 pm PDT

    Modified Files:
    exec/binkit.js 2.4 2.5 diff

    Log Message:
    More log output when connecting to an outbound node and when an inbound
    file already exists.
    Also, insure all log messages are prefixed with "BinkIT:".
  146. rswindell
    Sat Jul 07 2018 09:02 pm PDT

    Modified Files:
    src/smblib/smblib.c 1.177 1.178 diff

    Log Message:
    smb_lockmsghdr() - if the 'locked' smb instance property is already set,
    don't try to (re)lock it, just return SMB_SUCCESS.
    
    I honestly don't recall why I made this change, but it makes sense, so I'm
    committing it finally.
  147. rswindell
    Sat Jul 07 2018 08:51 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.197 1.198 diff

    Log Message:
    smb_getmsgidx_by_time() can now return positive integers on success.
  148. rswindell
    Sat Jul 07 2018 08:50 pm PDT

    Modified Files:
    src/smblib/smblib.c 1.176 1.177 diff
    src/smblib/smblib.h 1.85 1.86 diff

    Log Message:
    Re-write of smb_getmsgidx_by_time() - using a proper binary search
    algorithm now. Also, now returns the index offset of the matched index
    (if found), negative error value otherwise.
    
    I was testing something and noticed that the old smb_getmsgidx_by_time()
    implementation could sometimes return the index of a message posted before
    the requested time. That was fixed by re-writing the binary search logic.
    
    Also, I found it useful in my testing to have this function return the
    offset of the matching index (in addition to the index record itself), so
    checks of the return value need to compare >= SMB_SUCCESS, not just ==
    or != SMB_SUCCESS.
  149. rswindell
    Sat Jul 07 2018 12:52 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.96 1.97 diff

    Log Message:
    For SSH and RLogin 'logins', use the mastchuser() function rather than
    userdatdupe() to match the passed login-id (username):
    *  This allows more permissive username matching, e.g. if your user name
       is "Analog Kid", you could login with "analogkid", "analog.kid" or
       "analog_kid", which is handy when passing a user name on the command
       line (e.g. to an ssh client) for example.
    *  This is the same function used for Telnet logins via exec/login.js
  150. rswindell
    Sat Jul 07 2018 12:30 am PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.43 1.44 diff

    Log Message:
    Added @-codes to the SubGroupOrAll and DirLisstOrAll prompts (mnemonics)
    so that the current sub/group and dir/lib short name is displayed as
    part of the prompt.
  151. rswindell
    Sat Jul 07 2018 12:29 am PDT

    Modified Files:
    ctrl/text.dat 1.83 1.84 diff

    Log Message:
    Added @-codes to the SubGroupOrAll and DirLisstOrAll prompts (mnemonics)
    so that the current sub/group and dir/lib short name is displayed as
    part of the prompt.
  152. rswindell
    Sat Jul 07 2018 12:22 am PDT

    Modified Files:
    src/sbbs3/getkey.cpp 1.46 1.47 diff

    Log Message:
    mnemonic strings (those with tilde's to indicate the command-keys), now support
    @-codes within them. Previously, only if the entire mnemonic string was
    comprised of an @-code would it be expanded, now any @-codes within will expand
    as well.
  153. rswindell
    Fri Jul 06 2018 11:14 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.78 1.79 diff

    Log Message:
    Restore the 'U' command back to "User Edit" and commented-out the 
    experimental 'U' (View Unread-Only toggle) command. The 'U' command from
    the e-mail menu (e.g. email_sec.js) works better than the toggle approach and
    is probably all that is needed.
    Also, the user number lookup in the User Edit bit is better at finding the
    proper user account (e.g. for received netmail).
  154. rswindell
    Tue Jul 03 2018 10:42 pm PDT

    Modified Files:
    exec/dyndns.js 1.14 1.15 diff

    Log Message:
    Add support for a [dyndns] section in ctrl/modopts.ini for the following
    settings (keys): mx, ip, ip6
    
    This allows you to specify a long string (e.g. address) here without
    exceeding the 63 char external program command-line limit.
  155. rswindell
    Tue Jul 03 2018 04:52 pm PDT

    Modified Files:
    exec/dyndns.js 1.13 1.14 diff

    Log Message:
    Don't log 'null' if Socket.readline() returns null.
  156. rswindell
    Tue Jul 03 2018 03:58 pm PDT

    Modified Files:
    exec/dyndns.js 1.12 1.13 diff

    Log Message:
    Added '-ip6' option to specify your (optional) IPv6 address on the
    command-line.
  157. rswindell
    Sun Jul 01 2018 08:05 pm PDT

    Modified Files:
    ctrl/ircd.conf 1.12 1.13 diff

    Log Message:
    Added exmaple C/N lines for connecting to cvs.synchro.net too.
  158. rswindell
    Sun Jul 01 2018 02:40 am PDT

    Modified Files:
    src/sbbs3/con_hi.cpp 1.25 1.26 diff
    src/sbbs3/con_out.cpp 1.84 1.85 diff

    Log Message:
    So Nelgin noticed that in novice (non-expert) menu mode, the A/S/D cmds
    from the Chat menu would immediately clear the screen and redisplay the
    menu after displaying the change in the node's state. This was due to the
    enhancement in rev 1.77 of con_out.cpp whereby we no longer increment
    lncntr if the first lines displayed after a key-press are blank (who
    cares if blank lines scroll off the screen?). That's fine and all, but the
    auto-pause check in outchar(FF) would only auto-pause if the line-counter
    was greater than *one* (has been this way since forever). So with the
    enhancement in 1.77, a single non-blank line displayed after a key-press
    was now not enough to trigger the auto-pause ([Hit a Key] prompt).
    So I've changed the line-counter trigger value to greater than *zero*,
    which means we could have some new excessive auto-pauses, but other places
    where auto-pause wasn't working, should again.
    
    One new excessive auto-pause was after the system password was entered at
    the SY: prompt, so that fix is included in this commit.
  159. rswindell
    Sat Jun 30 2018 12:41 pm PDT

    Modified Files:
    web/root/msgs/msgs.ssjs 1.43 1.44 diff

    Log Message:
    Why was this truncating displayed message subjects to 50 chars? No one will
    ever know. Make the max subject length 70 (like Synchronet).
  160. rswindell
    Fri Jun 29 2018 07:51 pm PDT

    Modified Files:
    src/sbbs3/baja.c 1.49 1.50 diff

    Log Message:
    If the BAJAINCLUDE environment variable is set (new!), use that path as the
    default location to find !include'd baja (*.inc) files. If you use the '-I'
    option, it will override the environment variable setting. For Nelgin.
  161. rswindell
    Fri Jun 29 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.719 1.720 diff

    Log Message:
    Fix problem with socket-I/O external programs executed while the client
    using SSH: the output from the program (file transfer driver, door game)
    would reach the SSH client, but input from the client (or user) would not
    reach the external program:
    passthru_output_thread() - responsible for SSH input from the client/user
    to be sent to a "raw" pass-through socket used by the external program,
    had a reversed logic bug added around rev 1.686.
    Problem was introduced as part of the cryptlib update/SSH overhaul of 
    early 2018. Thanks to Thumper @ THEWASTE for the bug report!
  162. rswindell
    Thu Jun 28 2018 03:07 pm PDT

    Modified Files:
    ctrl/sbbsecho.ini 1.2 1.3 diff

    Log Message:
    Added list of known domains (including "othernets" provided by Tony Langdon).
    We should try to keep this list current to assist new sysops, so feedback is
    welcome.
    Also read/saved using EchoCfg, so it added all the supported keys with default
    values.
    Updated the default Inbound directory
     (from /binkd/inbound to ../fido/nonsecure)
    Updated the default Outbound directory
     (from /binkd/outbound to ../fido/outbound)
  163. nightfox
    Mon Jun 25 2018 09:50 pm PDT

    Modified Files:
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.13 1.14 diff

    Log Message:
    Update for the feature of not showing the latest message date & time in the sub-board lists.
  164. nightfox
    Mon Jun 25 2018 09:35 pm PDT

    Modified Files:
    xtrn/DDAreaChoosers/DDFileAreaChooser.js 1.11 1.12 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.cfg 1.3 1.4 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.12 1.13 diff
    xtrn/DDAreaChoosers/readme.txt 1.2 1.3 diff
    xtrn/DDAreaChoosers/revision_history.txt 1.2 1.3 diff

    Log Message:
    Version 1.17: For the message area chooser, added a new configuration file option, showDatesInSubBoardList, that specifies whether or not to show the date & time of the latest message in the sub-boards.
  165. rswindell
    Mon Jun 25 2018 02:14 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.38 1.39 diff

    Log Message:
    Disable the FTN NetMail source address selection (chooser) by default -
    the sysop must now enable this feature in SCFG->Networks->FidoNet.
    Also, widen the FidoNet configuration menu in SCFG, display more FTN
    addresses and the default origin line (part of it, at least) in the menu.
  166. rswindell
    Mon Jun 25 2018 02:13 pm PDT

    Modified Files:
    src/sbbs3/sbbsdefs.h 1.220 1.221 diff
    src/sbbs3/fido.cpp 1.60 1.61 diff

    Log Message:
    Disable the FTN NetMail source address selection (chooser) by default -
    the sysop must now enable this feature in SCFG->Networks->FidoNet.
  167. rswindell
    Mon Jun 25 2018 01:28 pm PDT

    Modified Files:
    exec/postmsg.js 1.2 1.3 diff

    Log Message:
    Clarify that 'mail' is a supported msgbase code.
  168. nightfox
    Mon Jun 25 2018 12:41 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.121 1.122 diff
    xtrn/DDMsgReader/readme.txt 1.17 1.18 diff

    Log Message:
    Version 1.17 beta 62: Made another fix to avoid the "Unknown destination" error when forwarding a message to a QWK-style address (such as "sysop@DIGDIST")
  169. nightfox
    Sun Jun 24 2018 10:05 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.120 1.121 diff
    xtrn/DDMsgReader/readme.txt 1.16 1.17 diff

    Log Message:
    Version 1.17 beta 61: Fixed a bug where it would report an "unknown destination" error when trying to forward a message to a FTN-style email address.
  170. rswindell
    Thu Jun 21 2018 01:24 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgxtrn.c 1.58 1.59 diff

    Log Message:
    Fixed typo (causing line-wrap) in online help.
  171. rswindell
    Thu Jun 21 2018 01:23 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.234 1.235 diff

    Log Message:
    Add clarification to the "No startup directory" error, that this is only
    for DOS programs (part of the USE_DOSEMU patch).
  172. rswindell
    Thu Jun 21 2018 01:22 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgchat.c 1.22 1.23 diff

    Log Message:
    Allow external chat pagers to have their "native" and "use shell" execution
    flags set manually in SCFG.
  173. rswindell
    Thu Jun 21 2018 01:22 pm PDT

    Modified Files:
    src/sbbs3/chat.cpp 1.76 1.77 diff

    Log Message:
    Allow external chat pagers to have their "native" and "use shell" execution
    flags set manually in SCFG.
  174. rswindell
    Tue Jun 19 2018 12:01 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.85 3.86 diff

    Log Message:
    When importing packets, don't export previously-rescanned messages
    (messages which contain the RESCANNED control line) to downlinks.
    
    Also renamed pkt_to_pkt() to write_to_pkts().
  175. rswindell
    Sun Jun 17 2018 06:28 pm PDT

    Modified Files:
    src/sbbs3/download.cpp 1.51 1.52 diff
    src/sbbs3/main.cpp 1.718 1.719 diff

    Log Message:
    Resolved some valgrind reported issues (likely, harmless):
    "Conditional jump or move depends on uninitialised value(s)"
    Thanks, Nelgin.
  176. rswindell
    Sun Jun 17 2018 12:26 pm PDT

    Modified Files:
    exec/load/fido.js 1.32 1.33 diff

    Log Message:
    Fix bug in parse_flo_file_path():
    If there's no zone in the specified path, the default_zone is used and that zone
    is a decimal number, not a hexadecimal string, so running parseInt(...,16)
    on it errorneously generates an incorrect outbound/FLO dir.
    This should fix the problem reported by Al @ TRMB.
  177. rswindell
    Mon Jun 11 2018 10:19 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.40 1.41 diff

    Log Message:
    Fix TLS/SSL failure/error: "creating SSL context"
    If the ctrl/ssl.cert file did not exist, the various TLS/SSL services would
    fail to create it and (sometimes) log the "creating SSL context" error.
    This problem was introduced with rev 1.30 (Mar-9) and the fix/patch
    provided by Deuce via irc. Thanks to Psi-Jack for the bug report.
  178. rswindell
    Mon Jun 11 2018 01:00 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.672 1.673 diff

    Log Message:
    Added log output for a couple of instances where get_ssl_cert() could
    (previuosly) silently fail - in the sendmail_negotiate() and pop3_thread().
    If get_ssl_cert() can return -1 withOUT setting the estr argument to a
    non-NULL value, then we could still have silent failures (TBD).
  179. rswindell
    Sun Jun 10 2018 02:47 am PDT

    Modified Files:
    text/menu/e-mail.asc 1.2 1.3 diff

    Log Message:
    New menu to correspond with new email_sec.js module (loaded by updated Baja cmd
    shells: default, wwiv, wildcat, pcboard).
    - Added (U)n-read messages only command.
    - Renamed (U)pload file to (A)ttach file.
  180. rswindell
    Sun Jun 10 2018 02:09 am PDT

    Modified Files:
    exec/default.src 1.20 1.21 diff
    exec/pcboard.src 1.9 1.10 diff
    exec/wildcat.src 1.12 1.13 diff
    exec/wwiv.src 1.5 1.6 diff
    exec/email_sec.js NONE 1.1 diff

    Added Files:
    	email_sec.js 
    Log Message:
    Replaced the Baja "E-mail Section" code block that was copy/pasted into several
    shells with a new single/unified JS module (email_sec.js):
    - New (U)n-read mail read command ('A' is now for sending file attachments)
    - I didn't update to the renegade shell since it has a custom menu file
    - This module will work with older Synchronet builds, without netmail file
      attachments
    - The old Baja code still works, however... less Baja = rounder Earth
  181. rswindell
    Sun Jun 10 2018 02:00 am PDT

    Modified Files:
    src/sbbs3/getmail.c 1.16 1.17 diff

    Log Message:
    Code cleanup in delfattach().
  182. rswindell
    Sun Jun 10 2018 01:57 am PDT

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.23 1.24 diff

    Log Message:
    Log an error if putmsgptrs() fails (e.g. out of disk space?).
  183. rswindell
    Sun Jun 10 2018 01:56 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.196 1.197 diff

    Log Message:
    putmsgptrs() will now return FALSE if iniWriteFile() returns FALSE
    (out of disk space?).
  184. rswindell
    Sun Jun 10 2018 01:54 am PDT

    Modified Files:
    src/sbbs3/js_msg_area.c 1.69 1.70 diff

    Log Message:
    Add (finally) fido_netmail_settings and inet_netmail_settings (bit-field)
    properties to msg_area object. See NMAIL_* in sbbsdefs.js for the bit values.
  185. rswindell
    Sun Jun 10 2018 01:53 am PDT

    Modified Files:
    src/sbbs3/data.cpp 1.30 1.31 diff
    src/sbbs3/js_bbs.cpp 1.163 1.164 diff
    src/sbbs3/readmail.cpp 1.77 1.78 diff
    src/sbbs3/sbbs.h 1.480 1.481 diff

    Log Message:
    JS bbs object changes:
    - finduser() method no longer prints "Unknown user" upon failure (the calling
      script can do this if/when it wants).
    - read_mail() method now accepts an optional 3rd argumnet (loadmail_mode)
      which may be used to load *only* un-read mail (for example), see LM_* in
      sbbsdefs.js
    
    Pass the lm_mode as a 4th argument to any readmail mod (if one is installed) -
    this correlates with the LM_* mode flag values (0 is normal/usual).
    
    File attachments can also be in a file/####.out directory (e.g. outbound
    Internet email attachments), so try deleting from there too when deleting
    mail with attachments.
  186. rswindell
    Sun Jun 10 2018 01:45 am PDT

    Modified Files:
    src/sbbs3/email.cpp 1.67 1.68 diff

    Log Message:
    Insure the WM_EMAIL mode flag is set when calling writemsg() from email()
    - similar to what we do in netmail() with the WM_NETMAIL flag.
    If you call writemsg() without WM_EMAIL set, it tries to use the subnum as an
    index into the sub-board array and will crash.
  187. rswindell
    Sun Jun 10 2018 01:39 am PDT

    Modified Files:
    src/sbbs3/textgen.c 1.10 1.11 diff

    Log Message:
    text.js now ends in "this;" allowing cool load usage like this:
    var text = load({}, 'text.js');
  188. rswindell
    Sun Jun 10 2018 01:37 am PDT

    Added Files:
    exec/load/userprops.js NONE 1.1 diff

    Log Message:
    New load/library module to make read/writing to user "properties"
    (stored in data/user/*.ini) easy.
  189. rswindell
    Sun Jun 10 2018 01:35 am PDT

    Modified Files:
    exec/load/text.js 1.22 1.23 diff

    Log Message:
    Added new OriginFidoAddr item.
    text.js now ends in "this;" allowing cool load usage like this:
    var text = load({}, 'text.js');
  190. rswindell
    Sun Jun 10 2018 01:34 am PDT

    Modified Files:
    exec/load/sbbsdefs.js 1.77 1.78 diff

    Log Message:
    Added the missing MM_* (msg_area.settings) flag definitions.
    Added loadmail mode (LM_*) definitions for new bbs.read_mail() argument
    (optional).
  191. rswindell
    Fri Jun 08 2018 05:38 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.76 1.77 diff

    Log Message:
    A little beautification of the unread msg only toggle output.
  192. rswindell
    Fri Jun 08 2018 05:24 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.75 1.76 diff

    Log Message:
    getmail() can only check the presence of an attribute flag currently
    (not the absense), so we need to call it twice to find out if there are
    any unread messages for the user.
  193. rswindell
    Fri Jun 08 2018 02:59 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.74 1.75 diff

    Log Message:
    Experimental feature: 'U' command toggles un-read mail visibility.
    Change the 'Edit Author's user account' command to '!' (for now).
  194. rswindell
    Wed Jun 06 2018 07:35 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.104 1.105 diff

    Log Message:
    Updated the JSDOC description of a few User properties.
  195. rswindell
    Wed Jun 06 2018 07:21 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.103 1.104 diff

    Log Message:
    Improve JS User class/object reads across a local network by leaving the
    user.dat file open (for read operations only). Writing still opens and
    closes the user.dat for each property/field modification.
  196. rswindell
    Wed Jun 06 2018 04:07 pm PDT

    Added Files:
    exec/load/birthdays.js NONE 1.1 diff

    Log Message:
     Library to return a list of users with a specified birthday or birthmonth
  197. rswindell
    Wed Jun 06 2018 02:44 pm PDT

    Modified Files:
    exec/load/birthdate.js 1.3 1.4 diff

    Log Message:
     Fix typos in comments, add Id rcs keyword
  198. rswindell
    Wed Jun 06 2018 02:40 pm PDT

    Modified Files:
    exec/load/birthdate.js 1.2 1.3 diff

    Log Message:
     Fix previous change (__defineGetter__)
  199. rswindell
    Tue Jun 05 2018 11:25 pm PDT

    Modified Files:
    exec/fseditor.js 1.88 1.89 diff

    Log Message:
    Use the js.on_exit() method of restoring the bbs.sys_status and
    console.ctrlkey_passthru values. This allows these critical session
    settings to be restored even if/when fseditor.js crashes/abends
    (e.g. exits unexpectedly due to unhandled JS exception).
  200. rswindell
    Mon Jun 04 2018 05:01 pm PDT

    Modified Files:
    ctrl/text.dat 1.82 1.83 diff

    Log Message:
    Added OriginFidoAddr text item.
  201. rswindell
    Mon Jun 04 2018 04:55 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.33 3.34 diff

    Log Message:
    Moved all the BSO/BinkP settings to the end of the Global Settings menu and
    made their display conditional on mailer-type being set to FLO/BSO.
    Added a help menu to the BinkP Settings menu (under Linked Nodes).
  202. rswindell
    Mon Jun 04 2018 03:02 pm PDT

    Modified Files:
    src/xpdev/sockwrap.h 1.54 1.55 diff

    Log Message:
    Added IPPORT_BINKP (TCP port number) definition.
  203. rswindell
    Mon Jun 04 2018 02:52 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.22 3.23 diff

    Log Message:
    Increment SBBSecho version to 3.05:
    more control over SBBS-initiated netmail source/origin addresses.
  204. rswindell
    Mon Jun 04 2018 02:50 pm PDT

    Modified Files:
    src/sbbs3/fido.cpp 1.59 1.60 diff
    src/sbbs3/text.h 1.31 1.32 diff
    src/sbbs3/text_defaults.c 1.42 1.43 diff

    Log Message:
    When the system has multiple configured FidoNet addressess (AKAs), let the
    user choose which address to use as the source address when composing a netmail
    message (the default being the most appropriate for the dest zone/net). This
    change only works with SBBSecho v3.05 or later.
    Some other incremental and safety improvements to sbbs_t::netmail() too.
    FTN netmail file attachments needs some more work however (the "FA:" subject
    prefix trick) - just remove it?
  205. rswindell
    Mon Jun 04 2018 01:56 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.84 3.85 diff

    Log Message:
    Another improvement to create_netmail():
    If the SMB header contains a source FTN address, use that as the origin address
    of the netmail and do not look-up a local AKA match for the destination address.
    Also, fix what appears to have been a (currently harmless) bug in
    smsg_to_echostat_msg(): the msg.from_net.addr is not an ASCIIZ string when
    net.type == NET_FIDO. Currently, source FTN addresses aren't set in echomail
    message headers, where the echostats come from. Could just remove
    these 2 lines.
  206. rswindell
    Mon Jun 04 2018 12:07 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.83 3.84 diff

    Log Message:
    Address RMH's issue:
    When the local system has multiple AKAs for the same zone and we are picking a
    origin/source address suitable for the destination address, pick the AKA that
    matches both the zone and net of the destination address first (if there is
    such a local AKA). It's the same logic used in sbbs_t::netmail() to display
    the originating address, so the AKA picking logic now matches what is shown
    to the netmail author and what SBBSecho will actually use.
  207. rswindell
    Tue May 22 2018 09:16 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.82 3.83 diff

    Log Message:
    Add a ^ARESCANNED w:x/y.z control line to exported messages during a rescan
    (apparently this is a pseudo-standard supported by fastecho and other
    "old-school" tossers) - per mark lewis' request.
  208. rswindell
    Tue May 22 2018 03:34 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.81 3.82 diff

    Log Message:
    When exporting msgs that came from an FTN (e.g. during a rescan), don't convert
    existing tear/origin lines and don't add a new origin line.
  209. rswindell
    Tue May 15 2018 03:41 pm PDT

    Modified Files:
    src/sbbs3/js_msgbase.c 1.219 1.220 diff

    Log Message:
    Fix get_msg_header() problem reported by Bill McGarrity:
    "expand fields" could be misinterpretted (e.g. as 'false') if less than 3
    args were passed to the function. Apparently you can NOT assume that argv[argc]
    is undefined and would fail a JSVAL_IS_BOOLEAN test. In the reported problem,
    MsgBase.get_msg_header() was being called with 2 arguments (from newslink.js)
    and the if(JSVAL_IS_BOOLEAN(argv[n])) test, when n was 2, would eval to true
    and then argv[n] evalulated as false, which would cause a message with no
    message ID to not have one dynamically created, which would then cause the
    message to fail to post to an NNTP server due to malformed Message-ID (a
    missing message "id" property would end up being included in the newsgropu
    article header as "Message-ID: undefined").
    
    get_msg_index() had a similar potential issue, also fixed.
  210. rswindell
    Mon May 14 2018 04:37 pm PDT

    Modified Files:
    exec/newslink.js 1.109 1.110 diff

    Log Message:
    If msgbase.get_msg_header() returns a header with no (undefined) message-ID
    header field, print/log an error and continue on (don't attempt to send to
    NNTP server). This won't solve Bill McGarrity's problem, but it might
    provide a clue (?).
  211. rswindell
    Mon May 14 2018 02:32 pm PDT

    Modified Files:
    exec/binkit.js 2.3 2.4 diff

    Log Message:
    Ignore sub-directories (e.g. *.pnt) of the outbound directory/ies in
    add_outbound_files(). The outbound/*.pnt sub-dirs are handled at a higher
    level.
  212. rswindell
    Thu May 10 2018 12:06 pm PDT

    Added Files:
    exec/msgutil.js NONE 1.1 diff

    Log Message:
    A simple message base test script right now, but ultimately could (should)
    grow into something that could be used in lieu of smbutil for at least
    some message base admin functions. Committing in its current form for
    Bill McGarrity to use to help diagnose a Message-ID issue (w/newslink.js)
  213. rswindell
    Wed May 09 2018 11:48 am PDT

    Modified Files:
    exec/newslink.js 1.108 1.109 diff

    Log Message:
    Created a new function (save_ptr) to elminate some redundant code.
    Removed support for the long-deprecated .snl import/export pointer files
    (uses the long-supported .ini file now only, [NewsLink] section).
    Added more debug output (enabled with the -d switch) when skipping
    (not exporting) any locally posted messages to help debug Bill McGarrity's
    reported problem.
  214. nightfox
    Tue May 08 2018 10:09 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.119 1.120 diff

    Log Message:
    Minor fix
  215. nightfox
    Tue May 08 2018 09:12 pm PDT

    Modified Files:
    xtrn/DDMsgReader/readme.txt 1.15 1.16 diff

    Log Message:
    Updated the version number (1.17 beta 60)
  216. nightfox
    Tue May 08 2018 09:12 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.118 1.119 diff

    Log Message:
    Version 1.17 beta 60:  When a non-sysop is reading anonymous posts, the  "from" name is now shown as "Anonymous".
  217. rswindell
    Thu May 03 2018 06:32 pm PDT

    Modified Files:
    exec/binkit.js 2.2 2.3 diff

    Log Message:
    Resolve exception/abend when files with no extension/suffix are placed 
    in the outbound directory:
     TypeError: file_getext(file) is undefined
  218. rswindell
    Wed May 02 2018 02:47 pm PDT

    Modified Files:
    exec/load/lockfile.js 1.9 1.10 diff

    Log Message:
    Removed the now-deprecated (never-functioning) 'e' flag from File.open()
    calls.
  219. deuce
    Mon Apr 30 2018 11:00 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.667 1.668 diff

    Log Message:
    Break the loop when failed is set to true.
    Also, use a stack pointer if the passed failed pointer is NULL.
  220. rswindell
    Mon Apr 30 2018 06:17 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.80 3.81 diff

    Log Message:
    If a bundle file cannot be unpacked after 48-hours, if the file is 0-bytes in
    length, just delete it (don't rename to *.?_?).
  221. rswindell
    Mon Apr 30 2018 04:02 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.126 1.127 diff

    Log Message:
    maint(): don't truncate the .sid and .hash files to 0-bytes before writing their
    new contents,
    Instead truncate to the new length after writing the new contents. This should
    make the files more tolerant of "out of disk space" situations and reduce
    the risk of lost data (0-byte files) due to low/no free disk space.
  222. rswindell
    Mon Apr 30 2018 03:54 pm PDT

    Modified Files:
    src/sbbs3/mail.cpp 1.32 1.33 diff

    Log Message:
    delmail(): don't truncate the .sid file to 0-bytes before writing the contents,
    instead truncate to the new length after writing the contents. This should
    make mail.sid files more tolerant of "out of disk space" situations and reduce
    the risk of lost data (0-byte mail.sid files) due to low/no free disk space.
  223. rswindell
    Mon Apr 30 2018 02:58 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.162 1.163 diff

    Log Message:
    iniWriteFile(): don't truncate the file to 0-bytes before writing the contents,
    instead truncate to the new length after writing the contents. This should
    make .ini files more tolerate of "out of disk space" situations and reduce
    the risk of lost data (0-byte .ini files) due to low/no disk space.
  224. rswindell
    Sun Apr 29 2018 11:05 pm PDT

    Modified Files:
    src/sbbs3/fixsmb.c 1.45 1.46 diff

    Log Message:
    Bug fix: if the msgbase.lock file existed, it would cause the msgbase open (and
    thus fixsmb) to fail, but just before exiting, fixsmb would delete the .lock
    file (whoops). The msgbase.lock file means something else is rebuilding this
    base (e.g. smbutil) and thus we can't just go deleting the .lock file, unless
    we (fixmsb) was the one that created it.
  225. rswindell
    Tue Apr 24 2018 12:56 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.717 1.718 diff
    src/sbbs3/ftpsrvr.c 1.471 1.472 diff
    src/sbbs3/websrvr.c 1.666 1.667 diff

    Log Message:
    Make the strings passed to startup->errormsg() more consistent (a 4-char
    left-justified server prefix), e.g. "term" now added for terminal server
    errors.
  226. rswindell
    Tue Apr 24 2018 12:02 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.95 1.96 diff

    Log Message:
    Make the "UNKNOWN USER" log messages more consistent:
    - Using NOTCICE (not INFO) log level.
    - Move the protocol name after Node X and remove the colon.
  227. deuce
    Mon Apr 23 2018 09:26 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.233 1.234 diff

    Log Message:
    Fix FreeBSD build, broken by revision 1.230
  228. nightfox
    Mon Apr 23 2018 09:26 pm PDT

    Modified Files:
    xtrn/SlyVote/SlyVote.js 1.55 1.56 diff
    xtrn/SlyVote/readme.txt 1.14 1.15 diff

    Log Message:
    Version 0.37 Beta: When submitting a vote, the thread_id field is now set to the message/poll's message ID, not message number.
  229. nightfox
    Mon Apr 23 2018 09:18 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.117 1.118 diff
    xtrn/DDMsgReader/readme.txt 1.14 1.15 diff

    Log Message:
    Version 1.17 beta 59: When submitting a vote, the thread_id field is now set to the message/poll's message ID, not the message number.
  230. rswindell
    Mon Apr 23 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.716 1.717 diff

    Log Message:
    Added protocol (e.g. Telnet, Rlogin, or SSH) to more log messages
    (e.g. warnings and errors).
    Also, stripped trailing white-space from many lines (editor setting).
  231. rswindell
    Mon Apr 23 2018 07:12 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.715 1.716 diff

    Log Message:
    Fix yet another race condition that could cause:
    Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ... 
    from output_thread
    Don't set ssh_mode=true until the ssh_session has been created successfully.
    
    Also added some more debug output with regards to Cryptlib session number.
  232. rswindell
    Mon Apr 23 2018 06:43 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.714 1.715 diff

    Log Message:
    Fix more race conditions which cause Terminal Server SSH ERROR 'Bad argument,
    parameter 1' (-1) ... from output_thread
  233. rswindell
    Fri Apr 20 2018 01:18 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.713 1.714 diff

    Log Message:
    Fix race-condition causing SSH errors:
    Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1)
     ... from output_thread
    
    The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session
    to 0 (the "parameter 1" value used in the cryptlib function calls in
    output_thread) but was doing this without owning the ssh_mutex, so the
    output_thread had a race condition where it would check ssh_mode=true and
    then use grab the ssh_mutex and use ssh_session in a few cryptlib function
    calls. The fix for the bbs_thread() to grab the ssh_mutex before setting
    ssh_mode to false and ssh_session to 0 and have the output_thread() re-check
    the ssh_mode after grabbing the ssh_mutex and not call any cryptlib
    functions if ssh_mode was set to false while waiting for the mutex.
    
    The cause would have been more obvious if the various cryptlib error/log
    messages contained the cryptlib session ID value (which was 0 in this case).
  234. nightfox
    Thu Apr 19 2018 10:36 am PDT

    Modified Files:
    text/avatars/DIGDIST.startrek.bin 1.1 1.2 diff

    Log Message:
    Used some brigher colors in some of the avatars.  This collection is still a work in progress..
  235. rswindell
    Wed Apr 18 2018 10:47 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.39 1.40 diff

    Log Message:
    Lower the log level of "BADDATA" cryptlib errors (-32) from ERROR to
    WARNING.
    Also fixed a couple of typos in strings.
  236. deuce
    Tue Apr 17 2018 11:51 pm PDT

    Modified Files:
    src/syncterm/menu.c 1.60 1.61 diff
    src/syncterm/term.c 1.337 1.338 diff
    src/syncterm/uifcinit.c 1.38 1.39 diff

    Log Message:
    Now that save/restorescreen() do font stuff too, we can just go ahead and
    switch to CP437 before any uifc stuff and everythings going to be happy.
  237. rswindell
    Tue Apr 17 2018 11:46 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.712 1.713 diff

    Log Message:
    Some log output updates, mainly adding errno string-representation where
    missing, but also now logging when renaming (or failing to rename) bad
    received .REP packet files.
  238. deuce
    Tue Apr 17 2018 11:44 pm PDT

    Modified Files:
    src/conio/ciolib.c 1.171 1.172 diff
    src/conio/ciolib.h 1.99 1.100 diff

    Log Message:
    Have save/restorescreen() save and restore the flags and fonts as well.
  239. rswindell
    Tue Apr 17 2018 11:43 pm PDT

    Modified Files:
    src/sbbs3/un_rep.cpp 1.64 1.65 diff

    Log Message:
    Don't treat qwk_import_msg() failures (e.g. duplicate messages) as
    packet errors, no need to save such REP packets as .bad files.
  240. deuce
    Tue Apr 17 2018 11:33 pm PDT

    Modified Files:
    src/conio/bitmap_con.c 1.136 1.137 diff

    Log Message:
    Handle default fonts when setting vmem.
  241. deuce
    Tue Apr 17 2018 11:33 pm PDT

    Modified Files:
    src/conio/cterm.c 1.241 1.242 diff

    Log Message:
    Copy the current font one into the CTerm altfont array during cterm_init()
    
    This should fix the issue with non-CP437 fonts reported by Kirkman.
  242. rswindell
    Tue Apr 17 2018 11:06 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.671 1.672 diff

    Log Message:
    Use the msg.idx.number as the message number in smb_getmsghdr() failure
    error messages (in the POP3 server) as the msg.hdr.number is zeroed by 
    smb_getmsghdr() and potentially invalid when returning an error.
  243. rswindell
    Tue Apr 17 2018 11:00 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.670 1.671 diff

    Log Message:
    Use a different source for the message number in smb_getmsghdr() failure
    error log message as the header is zeroed in this function and thus the
    message number previously read from the index, lost (zeroed) and useless.
  244. deuce
    Tue Apr 17 2018 08:54 pm PDT

    Modified Files:
    src/syncterm/bbslist.c 1.212 1.213 diff

    Log Message:
    Pass a bar pointer to screen mode list to allow showing below end of first
    screen of rows.
  245. deuce
    Tue Apr 17 2018 07:35 pm PDT

    Modified Files:
    exec/imapservice.js 1.66 1.67 diff

    Log Message:
    is_connected is not a method.
  246. rswindell
    Tue Apr 17 2018 06:41 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.232 1.233 diff

    Log Message:
    Experimental enhancement: enable WWIV color (Ctrl-C) code expansion in
    *nix-builds (for stdio WWIV doors).
  247. rswindell
    Tue Apr 17 2018 03:57 pm PDT

    Modified Files:
    src/sbbs3/xtrn_sec.cpp 1.84 1.85 diff

    Log Message:
    Extend USE_DOSEMU patch to drop file creation for non-native doors:
    Use drive mappings (e.g. D:, F:, G:, H:) rathe than absolute paths to node_dir,
    ctrl_dir, data_dir, and exec_dir in drop files.
    Also: fixed what appears to have been a copy/paste error in the node_dir
    and ctrl_dir mapping to Win32-shortnames for non-native doors on Windows.
  248. rswindell
    Tue Apr 17 2018 02:45 pm PDT

    Modified Files:
    exec/tickit.js 1.43 1.44 diff

    Log Message:
    Simplified the rename_or_move() function:
    - Don't use the deprecated 'e' file open mode
    - Use the global file_copy() method rather than roll-your-own
  249. rswindell
    Mon Apr 16 2018 09:32 pm PDT

    Modified Files:
    src/sbbs3/email.cpp 1.66 1.67 diff

    Log Message:
    Display the (previously unused) EmailFilesNotAllowed text.dat entry if a file
    attachment is attempted but unsupported.
  250. rswindell
    Mon Apr 16 2018 09:30 pm PDT

    Modified Files:
    src/sbbs3/fido.cpp 1.58 1.59 diff

    Log Message:
    Overhaul sbbs_t::netmail() for FidoNet netmail:
    - writes outbound netmail to SMB rather than FTS-1 Stored Messages (*.msg)
      this means you must have SBBSecho v2.30 or later in order to export FTN
      netmail (for file attachments, you'll need SBBSecho v3.04 rev 3.78 or later)
    - removed support for the now deprecated "default address" feature
      (nowadays, people are much more likely to gate FidoNet over Internet rather
      than the reverse!)
    
    The QWK-to-NetMail function still needs a similar overhaul.
  251. rswindell
    Mon Apr 16 2018 09:14 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.79 3.80 diff

    Log Message:
    write_flofile(): if the 'infile' path contains a drive letter prefix
    (e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
    to forward-slashes (for all OSes). This resolves an issue of sending a
    netmail file-attachment that was created on a Windows/MS-DOS type system
    and then scanned/exported on a *nix system. The FTN "stored message"
    convention is to have the full path of the attached file in the message
    subject.
    
    Hopefully nobody wants to use outbound directory names beginning with "x:"
    on *nix. :-)
  252. rswindell
    Mon Apr 16 2018 07:56 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.78 3.79 diff

    Log Message:
    Bug-fix: when exporting FTN netmail from SMB "mail" base, if the netmail
    included an "old-style" (not MIME-encoded) file attachment (where the file path
    is in the subject and the FILEATTACH aux-attribute flag is set), the
    corresponding netmail attribute flag would not be set in the stored msg (*.msg)
    file. Also simplified the create_netmail() function prototype/usage, removing
    the "file_attached" argument (use the hdr.auxattr instead).
  253. rswindell
    Mon Apr 16 2018 03:48 pm PDT

    Modified Files:
    3rdp/win32.release/cryptlib/bin/cl32.dll 1.6 1.7 diff

    Log Message:
    This is a clean rebuild of 3.4.4 with all our patches and there are several
    bytes different, so committing out of an abundance of caution. No "known"
    changes however.
  254. rswindell
    Mon Apr 16 2018 03:39 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.711 1.712 diff

    Log Message:
    Fix typo in previous commit.
  255. rswindell
    Mon Apr 16 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.710 1.711 diff
    src/sbbs3/un_rep.cpp 1.63 1.64 diff

    Log Message:
    2 unrelated changes:
    1: Wrap SSH cryptDestroySession() calls in a wrapper that tracks the number of
        open sessions and logs errors upon failure (and remaining session count).
        This is how I found the SSH session leak in sbbs_t::hangup().
        Also found multiple cals to SSH_END() which were invalid (no session to
        destroy) and removed them.
    2: If errors are detected when unpacking a REP packet, save the .rep file
        (in data/file/<filename.rep>.<timestamp>.bad) for later inspection.
        Also added some VOTING.DAT debug output (to be removed later).
        Trying to the get to the bottom of the
        "smb_addvote thread_back field missing" errors.
  256. rswindell
    Sun Apr 15 2018 06:32 pm PDT

    Modified Files:
    src/sbbs3/logon.cpp 1.65 1.66 diff

    Log Message:
    If the HappyBirthday text.dat line is blank, don't try to display it nor 
    pause and CLS after.
  257. echicken
    Sat Apr 14 2018 10:27 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.28 1.29 diff

    Log Message:
    @DigitalMan | It'd be nice if home/end keys moved to first/last avatars in a collection when viewing a collection
  258. echicken
    Sat Apr 14 2018 10:21 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.27 1.28 diff

    Log Message:
    @DigitalMan | JavaScript  s:\sbbs\exec\avatar_chooser.js line 775: TypeError: state.opt_out_item is null
    
    uh, this oughta do away with that, I guess
  259. echicken
    Sat Apr 14 2018 10:10 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.26 1.27 diff

    Log Message:
    Fix display bug (collection/highlight desync), but I should probably 
    revisit some of this.
  260. echicken
    Sat Apr 14 2018 10:00 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.25 1.26 diff

    Log Message:
    Scroll up one more line when on row zero to reveal the collection title.
    (Not the best fix, but it'll do for now.)
  261. rswindell
    Fri Apr 13 2018 04:59 pm PDT

    Modified Files:
    src/sbbs3/logfile.cpp 1.60 1.61 diff

    Log Message:
    errormsg() logs the "useron", when applicable, even for timed events (e.g.
    REP unpacking).
  262. rswindell
    Thu Apr 12 2018 10:25 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.709 1.710 diff

    Log Message:
    Apparent fix for SSH cryptlib session leak (leading to eventual
    'Resource/space exhausted' errors in TLS and SSH:
    The wrong ssh_session is being passed to cryptDestroySession() in
    sbbs_t::hangup() (introduced in rev 1.615), this call to cryptDestorySession()
    fails (returns -1, bad param) thus leaving the actual
    ssh_session never destroyed (leaked).
  263. rswindell
    Thu Apr 12 2018 03:11 pm PDT

    Modified Files:
    exec/load/sbbslist_lib.js 1.14 1.15 diff

    Log Message:
    Increase maximum service address (e.g. host name) length from 28 chars to 35
    chars for Bill McGarrity @ tequilamockingbirdonline.net :-)
    Doesn't seem to break anything (except backwards compatibility with SBL
    v3).
  264. rswindell
    Sun Apr 08 2018 07:59 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.470 1.471 diff

    Log Message:
    Bug-fix: The GCES macro already prints and *frees* the error string, so
    you can't print and free it again after calling that macro.
  265. rswindell
    Sun Apr 08 2018 07:49 pm PDT

    Modified Files:
    exec/binkit.js 2.1 2.2 diff

    Log Message:
    Remove 'e' from File.open() modes, but place a reminder comment to revisit.
    Added destination address of outbound file in "Attempting callout" log msg.
  266. rswindell
    Sat Apr 07 2018 12:21 am PDT

    Modified Files:
    src/xpdev/xpprintf.c 1.61 1.62 diff

    Log Message:
    Resolve GCC warnings:
    cast from pointer to integer of different size
  267. rswindell
    Sat Apr 07 2018 12:18 am PDT

    Modified Files:
    src/sbbs3/pack_rep.cpp 1.47 1.48 diff

    Log Message:
    Resolved GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
  268. rswindell
    Sat Apr 07 2018 12:17 am PDT

    Modified Files:
    src/sbbs3/mime.c 1.10 1.11 diff

    Log Message:
    Resolved GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
  269. rswindell
    Sat Apr 07 2018 12:15 am PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.231 1.232 diff

    Log Message:
    Removed an apparent debug-output (to stderr) line (output the path to
    emusetup.bat).
    It was generating an (easy to fix) GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
    But the line was not needed, so just removed it.
  270. rswindell
    Fri Apr 06 2018 11:01 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.669 1.670 diff

    Log Message:
    Resolve gcc version 5.4.0 warning: 
    format not a string literal and no format arguments [-Wformat-security]
  271. rswindell
    Fri Apr 06 2018 10:55 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.77 3.78 diff

    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]
  272. rswindell
    Fri Apr 06 2018 10:51 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.668 1.669 diff

    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]
       sockprintf(sock,sess,(char*)resp);
       sockprintf(socket,session,sys_error);
  273. rswindell
    Fri Apr 06 2018 12:08 am PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.230 1.231 diff

    Log Message:
    Fix build for USE_DOSEMU option (which I don't use).
  274. rswindell
    Thu Apr 05 2018 08:02 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.76 3.77 diff

    Log Message:
    Use GCC-assisted printf-style format/arg checking to find and fix instances
    of lprintf() misuse.
  275. rswindell
    Thu Apr 05 2018 07:49 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.229 1.230 diff

    Log Message:
    Resolve a couple GCC warnings:
    unused variable 'p'
    comparison between signed and unsigned integer expressions
  276. rswindell
    Thu Apr 05 2018 07:47 pm PDT

    Modified Files:
    src/sbbs3/js_global.c 1.373 1.374 diff

    Log Message:
    Resolve GCC warning: cast from pointer to integer of different size
     in expansion of macro 'JS_ARGS_OFFSET':
    unsigned long is the same size as a pointer (rather than unsigned int)
    on the supported target platforms/tool-chains.
  277. rswindell
    Thu Apr 05 2018 07:42 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.479 1.480 diff
    src/sbbs3/js_cryptcon.c 1.19 1.20 diff
    src/sbbs3/main.cpp 1.708 1.709 diff
    src/sbbs3/pack_rep.cpp 1.46 1.47 diff
    src/sbbs3/readtext.c 1.4 1.5 diff
    src/sbbs3/un_qwk.cpp 1.52 1.53 diff
    src/sbbs3/jsexec.c 1.198 1.199 diff

    Log Message:
    Use GCC-printf-style format/arg checking to find and fix problems with
    ::lprintf() usage.
  278. rswindell
    Thu Apr 05 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.665 1.666 diff

    Log Message:
    Enabled GCC-assisted printf-style format/arg checking for lprintf() and
    fix the resulting warnings.
  279. rswindell
    Thu Apr 05 2018 07:18 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.321 1.322 diff

    Log Message:
    Enabled GCC-assisted printf-style format/arg checking for lprintf() and
    fix the resulting warnings.
  280. rswindell
    Thu Apr 05 2018 07:11 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.h 1.84 1.85 diff
    src/sbbs3/mailsrvr.c 1.667 1.668 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for sockprintf()
    and resolve the resulting warnings.
  281. rswindell
    Thu Apr 05 2018 06:58 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.666 1.667 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for lprintf() and
    resolve the resulting warnings.
  282. rswindell
    Thu Apr 05 2018 06:35 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.469 1.470 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for lprintf, sockprintf
    and send_mlsx().
    Fix numerous printf-style argument bugs, many in the TLS and MLSx support.
  283. rswindell
    Thu Apr 05 2018 06:05 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.468 1.469 diff

    Log Message:
    Fix get_ssl_cert() failure log message (wrong number of arguments).
    Put "TLS" in the failure log messages rather than repeating "FTP".
  284. rswindell
    Thu Apr 05 2018 06:02 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.665 1.666 diff

    Log Message:
    Fix get_ssl_cert() failure log message (wrong number of arguments).
    Was this pasted from somewhere else?
  285. rswindell
    Thu Apr 05 2018 05:49 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.75 3.76 diff

    Log Message:
    Log an error if ftouch() fails to create the outbound sem file.
  286. rswindell
    Thu Apr 05 2018 05:21 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.478 1.479 diff
    src/sbbs3/login.cpp 1.26 1.27 diff

    Log Message:
    Address GCC warning: ISO C++ forbids converting a string constant to 'char*'
  287. rswindell
    Thu Apr 05 2018 05:14 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.664 1.665 diff

    Log Message:
    Fix a couple of issues with external mail processors:
    - Since rev 1.556, mailproc_to_match[] would only ever contain one mail
      processor (index) value, even if the RCPT TO address matched multiple
      mail processor "To" keys in mailproc.ini, so only the first-matching
      mail processor (with a "To" key) would be executed for the msg.
    - mailproc_match, meaning the destination was a non-passthrough
      external mail processor, in which case the destination (RCPT TO) address
      may *not* match a valid local user account, would be set for *passthru*
      mail processors potentially resulting in the following error (and an
      undelivered mail message): !SMTP can't deliver mail to user #0
      only set mailproc_match to a valid mail proc index if the recipient matches a
      non-passthru mail processor.
  288. rswindell
    Thu Apr 05 2018 03:26 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.467 1.468 diff

    Log Message:
    The real apparent fix for the free() assertion: use free_crypt_attrstr() instead
  289. rswindell
    Thu Apr 05 2018 02:49 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.466 1.467 diff

    Log Message:
    Initialize estr to NULL in start_tls(), likely cause of free() assert in
    Windows debug build.
  290. rswindell
    Thu Apr 05 2018 03:28 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.74 3.75 diff

    Log Message:
    Some status string (e.g. "Loading user names...") were being sent to stderr
    instead of stdout.
  291. rswindell
    Wed Apr 04 2018 07:22 pm PDT

    Modified Files:
    exec/showmsghdr.js 1.3 1.4 diff
    exec/showmsgavatar.js 1.1 1.2 diff
    exec/showfileavatar.js 1.2 1.3 diff
    exec/logon.js 1.32 1.33 diff

    Log Message:
    Don't "clear the background attribute" by setting the attributes to 0
    (black on black) as this can inadvertently "hide" text for ANSI users
    (e.g. poll comments, when reading a poll message). Set to 7 (lightgray)
    instead.
  292. rswindell
    Wed Apr 04 2018 12:13 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.195 1.196 diff

    Log Message:
    Don't log "(null)" for the user name in filter_ip() when the user name is
    not known/available (e.g. certain types of SSH login failures).
  293. rswindell
    Wed Apr 04 2018 12:11 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.320 1.321 diff
    src/sbbs3/ftpsrvr.c 1.465 1.466 diff
    src/sbbs3/websrvr.c 1.664 1.665 diff
    src/sbbs3/mailsrvr.c 1.663 1.664 diff

    Log Message:
    Log the number of failed login attempts which triggered the IP filter.
  294. rswindell
    Wed Apr 04 2018 12:10 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.477 1.478 diff
    src/sbbs3/login.cpp 1.25 1.26 diff
    src/sbbs3/main.cpp 1.707 1.708 diff

    Log Message:
    sbbs_t::badlogin() now accepts 3 more (optional) arguments which allow us
    to use this function in bbs_thread() for SSH failed login attempts and thus
    enable the perm-IP-filtering (LoginAttemptFilterThreshold) functionality.
    Right now, it's only a "bad login" if the "Getting channel type" doesn't
    return "session", but we could (and likely will) use it for more SSH login
    failure modes which indicate a likely hack-attempt.
  295. rswindell
    Tue Apr 03 2018 06:52 pm PDT

    Modified Files:
    exec/tickit.js 1.42 1.43 diff

    Log Message:
    Change the -replace option to -force-replace since the old "tick" program
    had a "replace" option that did something differnet (enabled parsing of the
    REPLACES verb) - don't want to confuse sysops now. :-)
  296. rswindell
    Mon Apr 02 2018 04:45 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.706 1.707 diff

    Log Message:
    Create yet-another GCES macro (GCESSTR) to log the output_thread instance
    description string ('node') in SSH-related log messages (e.g. errors) from the
    output_thread: No more "Node 0" log entries from here.
  297. rswindell
    Mon Apr 02 2018 04:22 pm PDT

    Modified Files:
    src/sbbs3/js_file.c 1.171 1.172 diff

    Log Message:
    Updated JS warning when using old/deprecated file open mode 'e':
        "Deprecated file open mode: 'e'"
    If this is your script generating this warning, either remove the 'e' from
    the File open() mode string (it had no effect anyway) or change to 'x' to
    get the real/working exclusive-open functionality (added in v3.17).
  298. rswindell
    Mon Apr 02 2018 03:52 pm PDT

    Modified Files:
    src/sbbs3/ctrl/CodeInputFormUnit.dfm 1.5 1.6 diff

    Log Message:
    Sort the items in the combobox when prompting for an internal code
    (e.g. for a QNET hub or timed event).
  299. rswindell
    Mon Apr 02 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/js_file.c 1.170 1.171 diff

    Log Message:
    The 'e' (exclusive-open) mode flag (introduced in v3.12) never worked. It was
    simply ignored when converted to the underlying open mode passed to sopen().
    Deprecate this flag and log a warning when it is detected as used in a script:
    Deprecated open flag used: 'e'
    Added 'x' (exclsuive-open) mode flag which:
    1. was tested to work as intended
    2. is consistent with the C11 standard for fopen() mode flags
    3. won't cause existing scripts to suddenly break
  300. rswindell
    Mon Apr 02 2018 01:32 pm PDT

    Modified Files:
    exec/tickit.js 1.41 1.42 diff

    Log Message:
    Experimental feature for bgdjr: when '-replace' argument is passed on the
    command-line, treat all .TIC files as they have have a "REPLACES" clause.
  301. deuce
    Mon Apr 02 2018 01:29 am PDT

    Modified Files:
    exec/load/http.js 1.41 1.42 diff

    Log Message:
    When sending a request and the socket is still open, close it.
    This prevents leaving all sockets open until the script exits.  It would
    be better to reuse the existing socket when it's already connected to the
    right place, but this is easier for now.
  302. rswindell
    Sun Apr 01 2018 01:48 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.705 1.706 diff

    Log Message:
    Added function names to SSH error messages so we can better tell where
    these errors are coming from.
  303. rswindell
    Sun Apr 01 2018 01:46 pm PDT

    Modified Files:
    exec/load/fidocfg.js 1.32 1.33 diff
    exec/load/fido.js 1.31 1.32 diff
    exec/load/fido_syscfg.js 1.17 1.18 diff

    Log Message:
    Added CVS Id tag.
  304. echicken
    Sun Apr 01 2018 10:25 am PDT

    Modified Files:
    xtrn/ansiview/ansiview.js 1.24 1.25 diff
    xtrn/ansiview/readme.txt 1.6 1.7 diff

    Log Message:
    Two optional settings can be added to the root section of settings.ini:
    header = /path/to/some.ans
    header_rows = number of lines occupied by the header graphic
    The normal ansiview 'window' will be pushed down by header_rows lines,
    and the header graphic will be displayed above it.
  305. rswindell
    Sun Apr 01 2018 12:51 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.94 1.95 diff

    Log Message:
    If the SSH or RLogin-supplied username is in the name.can, don't start the
    new user signup process with that name (just fall-through to a normal login
    prompt).
  306. rswindell
    Sun Apr 01 2018 12:22 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.662 1.663 diff

    Log Message:
    Added a debug-level log msg ever 100 lines of received SMTP message text.
  307. rswindell
    Sat Mar 31 2018 11:55 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.16 1.17 diff

    Log Message:
    Fix bug in previous commit (use of Object.keys) which caused the default
    domain/zone-map configuration to be used - always.
  308. rswindell
    Sat Mar 31 2018 09:24 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.15 1.16 diff

    Log Message:
    Fix the default domain ('fidonet', zones 1-6) feature when there are no
    domains configured in sbbsecho.ini
    ('domains' is always undefined at this point, <shrug>).
  309. rswindell
    Sat Mar 31 2018 08:54 pm PDT

    Modified Files:
    exec/binkit.js 2.0 2.1 diff

    Log Message:
    Fix error line 792: TypeError: file_getext(dir) is undefined
    when outbound directory (dir) was "../some/path".
  310. rswindell
    Sat Mar 31 2018 08:42 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.32 3.33 diff

    Log Message:
    When creating a new linked node, set binkp_allowPlainText to true
    (Argus and Mystic's BinkP mailers don't support encryption).
  311. rswindell
    Sat Mar 31 2018 08:38 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.31 3.32 diff

    Log Message:
    Help text fix-ups.
  312. rswindell
    Sat Mar 31 2018 08:37 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.73 3.74 diff

    Log Message:
    Bug-fix: The Auto-Add-Subs feature would not create the area file (areas.bbs)
    if it didn't already exist.
  313. rswindell
    Sat Mar 31 2018 07:21 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.14 1.15 diff

    Log Message:
    Fixed some typos.
    Added node address to some authentication failure warnings.
  314. rswindell
    Sat Mar 31 2018 02:43 am PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.30 3.31 diff

    Log Message:
    Resolved GCC warning about implicit type (int).
  315. rswindell
    Sat Mar 31 2018 02:41 am PDT

    Modified Files:
    src/sbbs3/pktdump.c 1.10 1.11 diff

    Log Message:
    Use new struct fidoaddr (5D address).
  316. rswindell
    Sat Mar 31 2018 02:40 am PDT

    Modified Files:
    src/sbbs3/fidodefs.h 1.19 1.20 diff

    Log Message:
    Added FIDO_DOMAIN_LEN (8), PRODDATA_LEN (4), updated comments, etc.
    Created struct fidoaddr (5D address), though it's only used (so far)
    in pktdump.c - doesn't really need to be packed.
  317. rswindell
    Sat Mar 31 2018 02:38 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.21 3.22 diff
    src/sbbs3/sbbsecho.c 3.72 3.73 diff
    src/sbbs3/rechocfg.c 3.29 3.30 diff
    src/sbbs3/echocfg.c 3.29 3.30 diff

    Log Message:
    SBBSecho/EchoCfg v3.04 - uses the newly merged sbbsecho/binkit/ftn_domains.ini
    If you're not using BinkIT (you're using some other FidoNet mailer), you can
    safely ignore all the settings/options.
    A lot of the online help for the new settings/menus needs to be written
    still and the wiki now needs a lot of update to reflect the changes.
    The "title" of this program was changed, again, from "SBBSecho Config" to
    "[Synchronet] FidoNet Config" since it configures more than just SBBSecho
    now.
  318. rswindell
    Sat Mar 31 2018 02:34 am PDT

    Modified Files:
    exec/update.js 1.5 1.6 diff

    Log Message:
    Run 'binkit upgrade' if binkit.ini and sbbsecho.ini exists
    (the upgrade renames binkit.ini and ftn_domains.ini to *.old).
  319. rswindell
    Sat Mar 31 2018 02:33 am PDT

    Modified Files:
    exec/binkit.js NONE 2.0 diff

          Tag: 2.0
    	binkit.js 
    Log Message:
    Merged binkit.ini and ftn_domains.ini into sbbsecho.ini (BinkIT 2.0).
    Use "jsexec binkit upgrade" to upgrade your existing .ini files if you're
    already running BinkIT 1.x.
    echocfg v3.04 may now be used to set all the BinkIT settings and domains
    (in sbbsecho.ini).
  320. rswindell
    Sat Mar 31 2018 02:31 am PDT

    Modified Files:
    exec/load/fidocfg.js 1.31 1.32 diff
    exec/load/fido_syscfg.js 1.13 1.14 diff

    Log Message:
    Merged binkit.ini and ftn_domains.ini into sbbsecho.ini (for BinkIT 2.0)
    (note: some of the key names were changed), run "jsexec binkit upgrade"
    to upgrade your existing .ini's (if you have them).
    Removed support for sbbsecho.cfg.
  321. rswindell
    Sat Mar 31 2018 02:16 am PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.37 1.38 diff

    Log Message:
    Finished removing (now unused) PostLink-networking stuff.
  322. rswindell
    Sat Mar 31 2018 01:40 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.704 1.705 diff

    Log Message:
    Check the terminate_output_thread flag after acquiring the ssh_muex.
  323. deuce
    Sat Mar 31 2018 01:14 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.703 1.704 diff

    Log Message:
    Tabs are stupid.
  324. echicken
    Fri Mar 30 2018 10:41 pm PDT
    exec/load websocket-proxy.js 1.1 NONE
    Update of /cvsroot/sbbs/exec/load
    In directory cvs:/tmp/cvs-serv11750/load
    
    Removed Files:
    	websocket-proxy.js 
    Log Message:
    These are no longer needed and will only cause confusion alongside other websocket scripts.
  325. echicken
    Fri Mar 30 2018 10:41 pm PDT

    Removed Files:
    exec/NONE websocket-rlogin-service.js 1.5 diff

    Log Message:
    These are no longer needed and will only cause confusion alongside other websocket scripts.
  326. rswindell
    Fri Mar 30 2018 09:03 am PDT

    Modified Files:
    src/xpdev/ini_file.c 1.161 1.162 diff

    Log Message:
    Fix bcc32 build error: Expression syntax in function iniSetIntList
  327. rswindell
    Fri Mar 30 2018 01:35 am PDT

    Modified Files:
    src/xpdev/ini_file.c 1.160 1.161 diff
    src/xpdev/ini_file.h 1.54 1.55 diff

    Log Message:
    Added functions for reading/parsing/writing lists of integers in .ini files
    (e.g. "Zones=1,2,3,4,5,6").
  328. rswindell
    Fri Mar 30 2018 01:33 am PDT

    Modified Files:
    src/xpdev/link_list.h 1.27 1.28 diff

    Log Message:
    Fixed typo in comment.
  329. deuce
    Thu Mar 29 2018 06:02 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.464 1.465 diff

    Log Message:
    Fix infinite loop with TLS FTP control session.
  330. deuce
    Tue Mar 27 2018 07:47 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.319 1.320 diff

    Log Message:
    Fix potential crypt handle leak for TLS services.  Destroy the session
    if the thread returns before js_initcx() is called.
  331. deuce
    Tue Mar 27 2018 07:36 pm PDT

    Modified Files:
    exec/letsyncrypt.js 1.32 1.33 diff

    Log Message:
    Don't try ten times to delete files that don't exist.
  332. deuce
    Tue Mar 27 2018 06:45 pm PDT

    Modified Files:
    exec/imapservice.js 1.65 1.66 diff

    Log Message:
    Check if the socket is connected or not in the wait loop.
  333. deuce
    Mon Mar 26 2018 10:16 pm PDT

    Modified Files:
    exec/binkit.js 1.77 1.78 diff

    Log Message:
    Some binkp software (Taurus) doesn't send an M_NUL VER at all.
    Reported by bgdjr.
  334. rswindell
    Mon Mar 26 2018 06:08 pm PDT

    Modified Files:
    src/sbbs3/qwk.cpp 1.81 1.82 diff

    Log Message:
    Don't log an error when a QWK-posted vote message is a dupe (just silently
    discard).
    Also, trim trailing white-spaces.
  335. rswindell
    Mon Mar 26 2018 06:06 pm PDT

    Modified Files:
    src/conio/sdl_con.c 1.261 1.262 diff

    Log Message:
    Fix GCC warning:
    sdl_con.c: In function ΓÇÿsdl_mouse_threadΓÇÖ:
    sdl_con.c:1424:1: warning: no return statement in function returning non-void
  336. nightfox
    Mon Mar 26 2018 12:55 pm PDT

    Modified Files:
    exec/load/DDLightbarMenu.js 1.24 1.25 diff

    Log Message:
    Bug fix in the SetBorderChars method: Missing an index ([i]) into an array
  337. deuce
    Sun Mar 25 2018 10:17 pm PDT

    Modified Files:
    exec/binkit.js 1.76 1.77 diff

    Log Message:
    Check the Mystic version reported by the remote to see if we need to work
    around a broken CRAM-MD5 implementation.  For now, retrains the double-test
    for Mystic/1.12A39 until we see what version number the fixed builds have.
    
    If the major version is less than one, returns true.
    
    If the major version is greater than one, returns false.
    
    If the minor version is less than 12, returns true.
    
    If the minor version is greater than 12, returns false.
    
    If there is no character after the minor versions, returns false.
    (ie: 1.12 is newer than 1.12A39 and is assumed to be fixed)
    
    If the character after the minor version is not an 'A', returns false.
    (ie: 1.12B1 and 1.12.1 are newer than 1.12A39 and assumed fixed)
    
    If the number after the 'A' is less than or equal to 39, returns true.
    
    In all other cases, returns false.
    
    This prevents lowering security by having two allowed CRAM-MD5 responses
    for some remote software versions.  Hopefully the fixed build will have
    version 1.12A40 and we'll be able to remove the last version that does that.
  338. deuce
    Sun Mar 25 2018 09:40 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.702 1.703 diff

    Log Message:
    Since much more than the number of bytes we're reading can be sent on a
    channel we ignore/close, we would get a separate warning for each chunk of
    data on that channel until we read past the close.  Instead, if we're closing
    a channel, we note the channel ID, and simply discard the information
    immediately on the most recently closed channel.
    
    A remote could still cause a bunch of log output by multiplexing two or more
    writes to invalid channels, but nobody seems to do that, so this should be
    good for now.
  339. rswindell
    Sun Mar 25 2018 09:30 pm PDT

    Modified Files:
    src/sbbs3/chksmb.c 1.61 1.62 diff

    Log Message:
    Resolve msvc warnings (and confirm that cvs commits are making it into
    syncprog and the commit log again).
  340. deuce
    Sat Mar 24 2018 09:27 pm PDT

    Modified Files:
    src/conio/cterm.c 1.240 1.241 diff

    Log Message:
    Fix a large number of errors involving re-using an in-use index variable as
    a temp variable.  Mostly impacting the setting of video flags.
  341. rswindell
    Sat Mar 24 2018 09:14 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.193 1.194 diff

    Log Message:
    putmsgptrs():
    Fix-up the user/####.subs ini style (only one blank line between sections).
    Also, don't re-write the .subs file if nothing has changed.
  342. rswindell
    Sat Mar 24 2018 08:48 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.192 1.193 diff

    Log Message:
    Address GCC warning: "/*" within comment
  343. rswindell
    Sat Mar 24 2018 08:47 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.191 1.192 diff

    Log Message:
    Changed user' message pointer/last-read/scan-config storage to a new file
    (data/user/*.subs - in familar .ini syntax)
    indexed by the sub-board internal rather than the old flat binary file using
    the troublesome "pointer index" (ptridx) as an offset. The old files
    (data/user/ptrs/*.ixb) will still be read in when the new file doesn't exist,
    for upgrading users automatically to the new method of pointer storage.
    This should resolve long-standing issues around users' new-scan pointers and
    configurations getting corrupted when the sysop inserts/remove sub-boards.
    However, if you change a sub-board's internal code, that invalidates the users'
    pointers and scan configurations - so that may need to be addrsesed via SCFG.
    The subs' ptridx values are still be used for storing QWKnet hub pointers, for
    now, but that too will soon be addressed with a new file format for those ptrs
    too.
  344. deuce
    Sat Mar 24 2018 02:09 pm PDT

    Modified Files:
    exec/load/binkp.js 1.105 1.106 diff

    Log Message:
    Store the remote software version in the BinkP object, don't do special
    stuff in binkp.js, only the protocol.  BinkIT now does the Mystic check.
  345. deuce
    Sat Mar 24 2018 02:09 pm PDT

    Modified Files:
    exec/binkit.js 1.74 1.75 diff

    Log Message:
    Store the remote software version in the BinkP object, don't do special
    stuff in binkp.js, only the protocol.  BinkIT now does the Mystic check.
  346. deuce
    Sat Mar 24 2018 02:01 pm PDT

    Modified Files:
    exec/load/binkp.js 1.104 1.105 diff

    Log Message:
    Add comment in binkp about why we detect Mystic as well.
  347. deuce
    Sat Mar 24 2018 02:00 pm PDT

    Modified Files:
    exec/binkit.js 1.73 1.74 diff

    Log Message:
    Add comment regarding Mystic password workaround.
  348. deuce
    Sat Mar 24 2018 01:57 pm PDT

    Modified Files:
    exec/load/binkp.js 1.103 1.104 diff

    Log Message:
    Attept to work around Mystic CRAM+CRYPT issue.
  349. deuce
    Sat Mar 24 2018 01:57 pm PDT

    Modified Files:
    exec/binkit.js 1.72 1.73 diff

    Log Message:
    Attept to work around Mystic CRAM+CRYPT issue.
  350. rswindell
    Sat Mar 24 2018 01:53 am PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.41 1.42 diff

    Log Message:
    The SubLstHdr and SubLstFmt lines display the number of posts per sub-board,
    increase post-count width supported from 4 to 5 digits (beautifully).
  351. rswindell
    Sat Mar 24 2018 01:52 am PDT

    Modified Files:
    ctrl/text.dat 1.81 1.82 diff

    Log Message:
    The SubLstHdr and SubLstFmt lines display the number of posts per sub-board,
    increase post-count width supported from 4 to 5 digits (beautifully).
  352. rswindell
    Fri Mar 23 2018 11:49 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.36 1.37 diff
    src/sbbs3/scfg/scfgsub.c 1.45 1.46 diff

    Log Message:
    Removed PostLink/PCRelay configuration stuff - nobody has used this
    networking technology for 20 years. :-(
  353. rswindell
    Fri Mar 23 2018 05:02 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.660 1.661 diff

    Log Message:
    More detailed log output when posting a message via SMTP (successfully
    or not).
  354. rswindell
    Fri Mar 23 2018 04:57 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.700 1.701 diff

    Log Message:
    Log a generic "SSH session establishment failed" message (with NOTICE
    severity) whenever there is an SSH session establishment failure, because
    some of the SSH failure errors are DEBUG level severity and won't be visible
    with "Normal" (informational) log output filtering. This resolves the issue
    of seing "SSH connection accepted from <ip-address> port <port>" messages
    with no follow-up messages as to what happened to that connection.
  355. rswindell
    Fri Mar 23 2018 04:27 pm PDT

    Modified Files:
    exec/load/binkp.js 1.102 1.103 diff

    Log Message:
    Raise the log-level severity (from DEBUG to NOTICE) when sending any M_ERR
    messages. There's a lot of places in this script where we just send a
    (somewhat explanatory) M_ERR string, but don't log anything locally unless
    debug-level logging is enabled, now we'll at least log those messages with
    a bit higher severity.
  356. rswindell
    Fri Mar 23 2018 01:12 am PDT

    Modified Files:
    exec/binkit.js 1.71 1.72 diff

    Log Message:
    Don't allow the CRAM-MD5 challenge length to be overridden (always use
    the binkp.js default, 32-hexchars/16-bytes). Even IRex v2.31 requires a
    16-byte challenge, so experiment is over.
    Log more details when a CRAM-MD5 authentication response doesn't match
    (e.g. to make case-mismatch or other cause of authentication failures
    potentially more obvious - still debugging the Mystic inbound CRAM-MD5
    auth failure and this might help).
  357. rswindell
    Thu Mar 22 2018 07:12 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.190 1.191 diff

    Log Message:
    Fix weird compile error triggered by *some* revisions of msvc which dont'
    like a str_list_t declared in line (but the char* is fine?!).
  358. rswindell
    Thu Mar 22 2018 06:30 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.199 1.200 diff

    Log Message:
    Fix the log msg repeat count (off by one).
    Remember the last forced timed event setting.
  359. rswindell
    Thu Mar 22 2018 06:19 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.463 1.464 diff
    src/sbbs3/mailsrvr.c 1.659 1.660 diff
    src/sbbs3/main.cpp 1.699 1.700 diff
    src/sbbs3/services.c 1.318 1.319 diff
    src/sbbs3/websrvr.c 1.663 1.664 diff

    Log Message:
    Clean-up the log output around server shutdown/recycle:
    - lower log level (raise severity) of "Waiting for ..." msgs from Debug to Info
    - log a message when done waiting (for clients, threads, etc.)
    - only one #### log line per termination event
  360. rswindell
    Thu Mar 22 2018 05:09 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.8 1.9 diff

    Log Message:
    Log the UNIX socket name (filename) the status thread is listening on
    (default is ctrl/status.sock).
  361. rswindell
    Thu Mar 22 2018 04:32 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.7 1.8 diff

    Log Message:
    Fix more typos.
  362. rswindell
    Thu Mar 22 2018 04:29 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.6 1.7 diff

    Log Message:
    Fixed typo in status thread error message string ("stat" not "ftp").
  363. rswindell
    Thu Mar 22 2018 04:03 pm PDT

    Modified Files:
    exec/load/hexdump_lib.js 1.2 1.3 diff

    Log Message:
    Make hexdump_lib.js more lib-like and change the functions (methods) to
    return arrays rather than calling printf() directly. Also, make the ASCII
    portion of the output optional (but enabled by default).
  364. rswindell
    Thu Mar 22 2018 04:03 pm PDT

    Modified Files:
    exec/hexdump.js 1.1 1.2 diff

    Log Message:
    Make hexdump_lib.js more lib-like and change the functions (methods) to
    return arrays rather than calling printf() directly. Also, make the ASCII
    portion of the output optional (but enabled by default).
  365. rswindell
    Thu Mar 22 2018 02:20 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.317 1.318 diff

    Log Message:
    Bug-fix: JS service calls to random() would return the same sequence on
    Windows, every time. For example, this resulted in the same BinkP CRAM-MD5
    challenge being sent for every mailer session. Fixed by calling sbbs_srand
    in the service's thread, not (just once) in the accept thread.
  366. deuce
    Thu Mar 22 2018 12:31 am PDT

    Modified Files:
    exec/binkit.js 1.70 1.71 diff

    Log Message:
    We can't take a lockfile that doesn't exist.
  367. deuce
    Thu Mar 22 2018 12:22 am PDT

    Modified Files:
    exec/binkit.js 1.69 1.70 diff

    Log Message:
    Only add the SCFG outbound root if it's not in the FTNDomains config already.
    This shouldn't cause any functional changes since it's the outbound dirs that
    matter, and they already can't have duplicates.
  368. deuce
    Thu Mar 22 2018 12:06 am PDT

    Modified Files:
    exec/binkit.js 1.68 1.69 diff

    Log Message:
    I don't know how objects are "true", or "false", so don't risk it.
  369. rswindell
    Wed Mar 21 2018 08:24 pm PDT

    Modified Files:
    exec/binkit.js 1.67 1.68 diff

    Log Message:
    More elaborate fix for missing outbound directories (don't create them),
    just don't "run outbound" for those nodes.
  370. rswindell
    Wed Mar 21 2018 07:58 pm PDT

    Modified Files:
    exec/binkit.js 1.66 1.67 diff

    Log Message:
    <@Deuce> If there's no outbound dir, it should just skip the node.
  371. rswindell
    Wed Mar 21 2018 07:53 pm PDT

    Modified Files:
    exec/binkit.js 1.65 1.66 diff

    Log Message:
    Fix errors when outbound directory does not exist (create it):
      Locking c:\binkd\outbound\00da02bc.bsy
      Error 2 creating c:\binkd\outbound\00da02bc.bsy
      Failed to set date in the future fdate (-1) != future (1687417603)
    Also, added some debug dump of "outbound_roots" which appears to contain
    duplicates, at least when the ftn_domains.ini file is not in use:
     Outbound roots: ["c:\\binkd\\outbound","c:\\binkd\\outbound"]
  372. rswindell
    Wed Mar 21 2018 06:19 pm PDT

    Modified Files:
    text/sbbslist.hlp 1.1 1.2 diff

    Log Message:
    Finally a first pass at an sbbslist online help file.
    I got distracted by trying to wiki-syntax and then markdown and finally
    uust used asc/ctrl-a format. Sorry took so long.
  373. deuce
    Wed Mar 21 2018 12:18 pm PDT

    Modified Files:
    exec/fseditor.js 1.87 1.88 diff

    Log Message:
    Update the help text to list all keys.
  374. deuce
    Wed Mar 21 2018 12:02 pm PDT

    Modified Files:
    docs/fseditor.txt 1.13 1.14 diff

    Log Message:
    Update for all currently supported CTRL keys.
  375. deuce
    Wed Mar 21 2018 12:02 pm PDT

    Modified Files:
    exec/fseditor.js 1.86 1.87 diff

    Log Message:
    Add CTRL-\ as a synonym for CTRL-S to avoid collision with Xon.
    Missing synonym since 1.74 (over 8 years ago)
  376. deuce
    Wed Mar 21 2018 11:03 am PDT

    Modified Files:
    docs/fseditor.txt 1.12 1.13 diff

    Log Message:
    Update to match currently used control keys.
  377. deuce
    Wed Mar 21 2018 10:55 am PDT

    Modified Files:
    exec/fseditor.js 1.85 1.86 diff

    Log Message:
    Add CTRL-N to ctrlkey passthru and remove CTRL-O.
  378. deuce
    Wed Mar 21 2018 10:54 am PDT

    Modified Files:
    exec/fseditor.js 1.84 1.85 diff

    Log Message:
    Remove CTRL-N to "select none" (deselect all) in quote mode since DigitalMan
    decided that CTRL-N should be page-down.  This should fix page down in quote
    mode which has been broken since 1.83 three months ago (with a mention in the
    log that the commit broke fseditor.js)
  379. deuce
    Wed Mar 21 2018 10:41 am PDT

    Modified Files:
    src/sbbs3/js_console.cpp 1.115 1.116 diff

    Log Message:
    Document the cterm_version property to unbreak jsdocs.
  380. deuce
    Wed Mar 21 2018 10:04 am PDT

    Modified Files:
    exec/newuser_signup.js 1.45 1.46 diff

    Log Message:
    Apply patch from Psi-Jack in 2014:
    
    This patch fixes the user object process by ordering specific parts in a way
    that fixes the following problems:
    
    Post-delayed realname and handle caused realname and handle not to be set to
    the user object. Moved copy_user_template_to_user to after bbs.login just
    before the bbs.user_sync() solved that.
              
    Choosing not to use the randomly generated password would fail on every
    situation. Reordering user.security.password to be underneath user.number
    solved this problem.
  381. rswindell
    Tue Mar 20 2018 07:28 pm PDT

    Modified Files:
    exec/sbbslist.js 1.38 1.39 diff

    Log Message:
    Cosmetic improvements to "browse" mode, mainly around editing a BBS entry.
    Also clear the screen and display "Returning to <bbs name>" when exiting.
  382. rswindell
    Tue Mar 20 2018 06:36 pm PDT

    Modified Files:
    exec/sbbslist.js 1.37 1.38 diff

    Log Message:
    Allow up to 20 networks per entry, but only export 10 (the old SBL limit)
    in the legacy section of msgbase-exported entries.
  383. rswindell
    Tue Mar 20 2018 05:01 pm PDT

    Modified Files:
    exec/nntpservice.js 1.116 1.117 diff

    Log Message:
    Don't log a "!TIMEOUT waiting for request" message if the client in fact
    only disconnected.
  384. rswindell
    Tue Mar 20 2018 04:41 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.198 1.199 diff

    Log Message:
    Fix a long-standing bug with the log windows: when the log length would
    reach the configured "max size", newly added log lines would not use the
    configured color/font for the msg's log-level (they'd all use the default
    color/font).
  385. rswindell
    Mon Mar 19 2018 08:47 pm PDT

    Modified Files:
    exec/load/binkp.js 1.101 1.102 diff

    Log Message:
    Fix line 1196: ReferenceError: reset_eob is not defined
  386. rswindell
    Mon Mar 19 2018 08:41 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.197 1.198 diff

    Log Message:
    Track log messages that are repeated within the same LogTimer tick
    (interval) and display them on a single line with an " [x#]" suffix
    which identifies the number of times the message was repeated during that
    interval.
    Also created a common log_msg() function and eliminated a lot of copy/pasta
    in the various *_log_msg() functions.
  387. rswindell
    Mon Mar 19 2018 08:39 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.dfm 1.84 1.85 diff

    Log Message:
    Increase the LogTimer interval from 250ms to 500ms, this allows us to
    collate more (repeated/duplicate) log messages into a single line of the
    visible log.
  388. rswindell
    Mon Mar 19 2018 08:36 pm PDT

    Modified Files:
    src/sbbs3/ntsvcs.c 1.47 1.48 diff
    src/sbbs3/ntsvcs.h 1.6 1.7 diff

    Log Message:
    Add a "repeated" log_msg_t member which tracks repeated log messages.
  389. nightfox
    Mon Mar 19 2018 06:55 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.115 1.116 diff
    xtrn/DDMsgReader/readme.txt 1.12 1.13 diff

    Log Message:
    Version 1.17 beta 57: Made a fix for voting input - It wasn't accepting Q to quit out of voting (a blank input worked though).
  390. nightfox
    Mon Mar 19 2018 06:54 pm PDT

    Modified Files:
    xtrn/SlyVote/SlyVote.js 1.53 1.54 diff
    xtrn/SlyVote/readme.txt 1.12 1.13 diff

    Log Message:
    Version 0.35 beta: Made a fix for non-lightbar voting input - It wasn't accepting Q to quit out of voting (a blank input worked though).
  391. deuce
    Mon Mar 19 2018 05:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.698 1.699 diff

    Log Message:
    Some four spaces to tab conversion at the beginnings of lines.
  392. deuce
    Mon Mar 19 2018 05:10 pm PDT

    Modified Files:
    exec/load/binkp.js 1.100 1.101 diff

    Log Message:
    Inspired by revision 1.36, only reset senteob when we add a file.  Appears
    to work around Radius hang.  Also, in v2 mode, when we're close()ing, try
    to send two M_EOB to help work around weird/broken remotes.
  393. ree
    Mon Mar 19 2018 04:56 pm PDT

    Modified Files:
    exec/websocketservice.js 1.10 1.11 diff

    Log Message:
    Slightly less sucky frame handling
  394. deuce
    Mon Mar 19 2018 04:39 pm PDT

    Modified Files:
    exec/binkit.js 1.64 1.65 diff

    Log Message:
    flush() the lockfile after writing program name.
  395. deuce
    Mon Mar 19 2018 04:01 pm PDT

    Modified Files:
    exec/load/binkp.js 1.99 1.100 diff

    Log Message:
    On a recv() of zero bytes, check if the socket is still connected.
  396. deuce
    Mon Mar 19 2018 02:53 pm PDT

    Modified Files:
    exec/binkit.js 1.63 1.64 diff

    Log Message:
    Make semaphores[] a global and unconditionally touch them at the end of
    the script.
  397. deuce
    Mon Mar 19 2018 02:45 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.218 1.219 diff

    Log Message:
    If select() returns an error, return it rather than forcing the return value
    to zero.
  398. rswindell
    Mon Mar 19 2018 11:49 am PDT

    Modified Files:
    exec/load/binkp.js 1.98 1.99 diff

    Log Message:
    More log details with regards to timeouts and successful authentication.
  399. deuce
    Mon Mar 19 2018 11:41 am PDT

    Modified Files:
    exec/binkit.js 1.62 1.63 diff

    Log Message:
    Ensure semaphores isn't undefined since we're passing it around everywhere
    now.
  400. deuce
    Mon Mar 19 2018 11:12 am PDT

    Modified Files:
    exec/load/binkp.js 1.97 1.98 diff

    Log Message:
    Only use reset_eob() to reset eob counts.  Don't reset the EOB counts except
    for in file transfer related times.
  401. deuce
    Mon Mar 19 2018 11:05 am PDT

    Modified Files:
    exec/load/binkp.js 1.96 1.97 diff

    Log Message:
    Don't send a second M_EOB until we get an M_EOB from the remote.
  402. deuce
    Mon Mar 19 2018 10:55 am PDT

    Modified Files:
    exec/load/binkp.js 1.95 1.96 diff

    Log Message:
    Add comment (pending testing), and fix bug in last commit.
  403. deuce
    Mon Mar 19 2018 10:49 am PDT

    Modified Files:
    exec/load/binkp.js 1.94 1.95 diff

    Log Message:
    For v1.1 connections, send two EOBs before raising the timeout.  It seems that
    Radius/4.010/21.01.2005,13:56(Final-Release)/Win32 will not send an M_EOB
    until it receives two from the remote.
  404. deuce
    Mon Mar 19 2018 10:47 am PDT

    Modified Files:
    exec/load/binkp.js 1.93 1.94 diff

    Log Message:
    No need to send M_EOB while receiving a file, it'll settle out at the end.
  405. deuce
    Mon Mar 19 2018 09:36 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.658 1.659 diff
    src/sbbs3/mailsrvr.h 1.83 1.84 diff
    src/sbbs3/mxlookup.c 1.28 1.29 diff

    Log Message:
    Attempt to fix an apparently crypt object leak in the mail server by having
    mail_close_socket() also destroy the session, and take pointers to set the
    socket to INVALID_SOCKET, and the session to -1.
  406. deuce
    Sun Mar 18 2018 11:59 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.217 1.218 diff
    src/sbbs3/js_socket.h 1.5 1.6 diff

    Log Message:
    Make peek(), nread, data_waiting, and poll() usable for TLS sockets by recv()ing
    a single byte into a special buffer.  Note that peek() and nread will never
    return/indicate more than a single byte, so scripts which rely on these may
    be inefficient with TLS (websocket stuff appears to use nread heavily).
  407. deuce
    Sun Mar 18 2018 11:56 pm PDT

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.85 1.86 diff

    Log Message:
    More whitespace stuff.
  408. deuce
    Sun Mar 18 2018 11:06 pm PDT

    Modified Files:
    exec/load/binkp.js 1.92 1.93 diff

    Log Message:
    Pass the timeout argument to the data recv() call
  409. deuce
    Sun Mar 18 2018 04:19 pm PDT

    Modified Files:
    exec/imapservice.js 1.64 1.65 diff

    Log Message:
    cfgile -> cfgfile
  410. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/templates/default/ftelnet.inc 1.3 1.4 diff
    web/templates/default/ftelnet_external.inc 1.4 1.5 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  411. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/root/members/externals.ssjs 1.7 1.8 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  412. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/root/ftelnet.ssjs 1.5 1.6 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  413. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/templates/nightshade/ftelnet_external.inc 1.4 1.5 diff
    web/templates/nightshade/ftelnet.inc 1.3 1.4 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  414. ree
    Sun Mar 18 2018 01:28 pm PDT

    Modified Files:
    exec/load/ftelnethelper.js 1.6 1.7 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  415. ree
    Sun Mar 18 2018 01:28 pm PDT

    Modified Files:
    exec/websocketservice.js 1.9 1.10 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  416. rswindell
    Sun Mar 18 2018 12:32 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.189 1.190 diff

    Log Message:
    Fix Win32 link failure (e.g. unresolved getsockopt): when iniFile functions are
    used, that requires a socket lib too. util builds (that don't need the .ini
    file functions), they #define NO_SOCKET_SUPPORT, so exclude the user/####.ini
    support functions in that case too.
  417. deuce
    Sun Mar 18 2018 11:34 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.216 1.217 diff

    Log Message:
    Log which attribute couldn't be set.
  418. deuce
    Sun Mar 18 2018 09:57 am PDT

    Modified Files:
    exec/imapservice.js 1.63 1.64 diff

    Log Message:
    Only unlock/save the config if it's been opened.
    Fixes errors on sessions that do not authenticate before disconnecting.
  419. deuce
    Sat Mar 17 2018 09:42 pm PDT

    Modified Files:
    exec/load/binkp.js 1.91 1.92 diff

    Log Message:
    TLS is apparently causing issues, remove it since nobody else supports it
    anyway.
  420. rswindell
    Sat Mar 17 2018 08:48 pm PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.269 1.270 diff

    Log Message:
    Move all the remaining status_startup bits inside the #ifdef __unix__ block
    since it's not defined otherwise. Not sure if this ways intended to be
    included in Windows builds or not.
  421. rswindell
    Sat Mar 17 2018 05:00 pm PDT

    Modified Files:
    exec/binkit.js 1.61 1.62 diff

    Log Message:
    * When polling a node and receiving files, the semaphore files would not
      be touched - fixed (and debug-log output for each semfile touched).
    * When using the "install" command, the "BINKP" service won't be added to
      the services.ini file if a "BINKIT" or a "BINKP" service already exists.
  422. rswindell
    Sat Mar 17 2018 03:52 pm PDT

    Modified Files:
    exec/binkit.js 1.60 1.61 diff

    Log Message:
    Attempt to fix:
    Mar 17 14:15:56 trmb synchronet: srvc 0052 BINKP !JavaScript  /sbbs/exec/binkit
    .js line 862: TypeError: this.command is undefined
  423. deuce
    Sat Mar 17 2018 12:57 am PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.268 1.269 diff

    Log Message:
    Fix reported service for stat_*() callbacks.
  424. deuce
    Sat Mar 17 2018 12:51 am PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.5 1.6 diff

    Log Message:
    Fix up handling of disconnected sockets.
  425. deuce
    Sat Mar 17 2018 12:38 am PDT

    Modified Files:
    src/sbbs3/showstat.c 1.4 1.5 diff

    Log Message:
    Don't bother showing client_t info when a client disconnects... it's always
    NULL
  426. deuce
    Sat Mar 17 2018 12:35 am PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.4 1.5 diff

    Log Message:
    We must be much more clever with the client_t stuff in the lists...
    Always store the prot and user with the client_t to avoid even worse
    headaches.
    
    This makes the client update a bit trickier, but it seems to be good now.
  427. deuce
    Fri Mar 16 2018 11:45 pm PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.267 1.268 diff

    Log Message:
    Stat the status thread much later.
  428. deuce
    Fri Mar 16 2018 11:13 pm PDT

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.84 1.85 diff

    Log Message:
    Whitespace cleanup.
  429. deuce
    Fri Mar 16 2018 10:44 pm PDT

    Modified Files:
    install/GNUmakefile 1.73 1.74 diff

    Log Message:
    Install the new showstat utility.
  430. deuce
    Fri Mar 16 2018 10:43 pm PDT

    Modified Files:
    src/sbbs3/GNUmakefile 1.229 1.230 diff
    src/sbbs3/objects.mk 1.68 1.69 diff
    src/sbbs3/sbbscon.c 1.266 1.267 diff
    src/sbbs3/targets.mk 1.45 1.46 diff

    Log Message:
    Tie the new out of process thing into the build... not tested on Linux or
    Windows
  431. deuce
    Fri Mar 16 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/showstat.c 1.3 1.4 diff

    Log Message:
    Support authentication and the new SERVICE_STATUS
  432. deuce
    Fri Mar 16 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.3 1.4 diff
    src/sbbs3/sbbs_status.h 1.2 1.3 diff

    Log Message:
    Make the status thread a "proper" thread with a startup_t, callbacks, etc.
  433. deuce
    Fri Mar 16 2018 09:24 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.462 1.463 diff

    Log Message:
    That was likely supposed to be a semi-colon.
  434. deuce
    Fri Mar 16 2018 08:06 pm PDT

    Modified Files:
    src/sbbs3/showstat.c 1.2 1.3 diff

    Log Message:
    Fix buf declaration, add missing newline.
  435. deuce
    Fri Mar 16 2018 08:05 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.2 1.3 diff

    Log Message:
    client_on can be called with a NULL client, so we have to handle that too.
  436. deuce
    Fri Mar 16 2018 07:45 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.h 1.1 1.2 diff
    src/sbbs3/sbbs_status.c 1.1 1.2 diff
    src/sbbs3/showstat.c 1.1 1.2 diff

    Log Message:
    Fix handling of client_t char * fields.
  437. rswindell
    Fri Mar 16 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/atcodes.cpp 1.79 1.80 diff
    src/sbbs3/chat.cpp 1.75 1.76 diff
    src/sbbs3/echocfg.c 3.28 3.29 diff
    src/sbbs3/filedat.c 1.38 1.39 diff
    src/sbbs3/scfglib.h 1.22 1.23 diff
    src/sbbs3/scfglib2.c 1.45 1.46 diff
    src/sbbs3/services.c 1.316 1.317 diff
    src/sbbs3/xtrn_sec.cpp 1.83 1.84 diff

    Log Message:
    Address coverity-scan reported issues.
  438. rswindell
    Fri Mar 16 2018 07:21 pm PDT

    Modified Files:
    src/uifc/uifcx.c 1.33 1.34 diff

    Log Message:
    Address coverity-scan defect (unterminated string).
  439. deuce
    Fri Mar 16 2018 11:32 am PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.265 1.266 diff

    Log Message:
    Fix WTF indentation and braces.
  440. deuce
    Fri Mar 16 2018 10:50 am PDT

    Modified Files:
    exec/imapservice.js 1.62 1.63 diff

    Log Message:
    Support "binary" storage of Seen flags.  This greatly reduces the size of
    the data/users/000x.imap files when many messages have been seen.
  441. deuce
    Fri Mar 16 2018 09:13 am PDT

    Modified Files:
    exec/imapservice.js 1.61 1.62 diff

    Log Message:
    Typo in last commit?  Say it ain't so!
  442. deuce
    Fri Mar 16 2018 09:12 am PDT

    Modified Files:
    exec/imapservice.js 1.60 1.61 diff

    Log Message:
    Add -d and -r options to control debug and debugRX respectively... no need
    to spam the log unless you're working on the script itself.
  443. deuce
    Fri Mar 16 2018 09:08 am PDT

    Modified Files:
    exec/imapservice.js 1.59 1.60 diff

    Log Message:
    Ensure we can open the message base before including it in a LIST/LSUB
    response.
  444. deuce
    Fri Mar 16 2018 08:31 am PDT

    Modified Files:
    exec/imapservice.js 1.58 1.59 diff

    Log Message:
    Open the config file unbuffered to help with concurrency.
  445. deuce
    Fri Mar 16 2018 08:24 am PDT

    Modified Files:
    exec/imapservice.js 1.57 1.58 diff

    Log Message:
    Pass the index to operate on to apply_seen.
    Fixes issues with STATUS command.
  446. deuce
    Fri Mar 16 2018 08:04 am PDT

    Modified Files:
    exec/imapservice.js 1.56 1.57 diff

    Log Message:
    Pass the base to get_base_code() so that commands such as STATUS that don't
    have a selected base can use it.
  447. deuce
    Fri Mar 16 2018 08:01 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.215 1.216 diff

    Log Message:
    Update Socket.recvline() for new js_socket_recv() TLS semantics.
    Fixes recvline() returning an zero-length "line" on timeouts, which causes
    infinite loops and 100% CPU utilization with IMAPv4-TLS service (and likely
    any other service that uses recvline with a short timeout).
  448. rswindell
    Thu Mar 15 2018 11:06 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.697 1.698 diff

    Log Message:
    Adjusted log output:
    Added "Node # SSH" to a lot of SSH-related log messages.
    Lowered the severity of the SSH "attempt to use channel" msg from ERROR
    to WARNING.
    Removed "last:" from temp-ban message when there is no last-used username.
  449. rswindell
    Thu Mar 15 2018 10:30 pm PDT

    Modified Files:
    src/sbbs3/execfunc.cpp 1.41 1.42 diff

    Log Message:
    Save the last sent-to netmail address and re-use the address automatically
    when creating a new netmail message. Not exactly an "address book", but a
    convenience nonetheless.
  450. rswindell
    Thu Mar 15 2018 10:26 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.188 1.189 diff
    src/sbbs3/userdat.h 1.67 1.68 diff

    Log Message:
    Added some functions to read/write to the data/user/*.ini files.
    I'm calling these "user properties", but that might change.
  451. rswindell
    Thu Mar 15 2018 10:24 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.159 1.160 diff
    src/xpdev/ini_file.h 1.53 1.54 diff

    Log Message:
    Added iniSetValue() which, like iniGetValue(), does not support string
    literals (e.g. won't detect and escape them automatically). If you set
    a key value with carriage-returns and line-feeds, those will end up in the
    .ini file as-is, so use with caution.
  452. deuce
    Thu Mar 15 2018 07:39 pm PDT

    Modified Files:
    exec/binkit.js 1.59 1.60 diff

    Log Message:
    Better log messages when locks fail and aren't old enough to take over.
  453. deuce
    Thu Mar 15 2018 07:30 pm PDT

    Modified Files:
    exec/load/binkp.js 1.90 1.91 diff

    Log Message:
    Fixes for v1.0 mode...
    1) Don't reset eob counts for sent or got.
    2) Ensure M_GET is never sent in v1.0 mode.
    3) Only send one M_EOB in v1.0 mode, even if we add to the list with M_GET
    
    This should cover all the bases, but FREQ may be non-conformant.
  454. deuce
    Thu Mar 15 2018 07:08 pm PDT

    Modified Files:
    exec/load/binkp.js 1.89 1.90 diff

    Log Message:
    Overhaul EOB handling... just count them, and reset both to zero on non-EOB
    in either direction.
    
    For v1.0, a single EOB in both directions terminates the session and for
    v1.1, two EOBs in both directions terminates.
    
    This should greatly simplify the overly complicated senteob/sentempty/goteob/
    gotempty logic and completely eliminate loops.  Biggest risk with this change
    is issues with v1.0 servers.
  455. deuce
    Thu Mar 15 2018 06:39 pm PDT

    Modified Files:
    exec/load/binkp.js 1.88 1.89 diff

    Log Message:
    Terminate string.
  456. deuce
    Thu Mar 15 2018 06:35 pm PDT

    Modified Files:
    exec/load/binkp.js 1.87 1.88 diff

    Log Message:
    Add some temporary debug logspam.
  457. rswindell
    Thu Mar 15 2018 04:56 pm PDT

    Modified Files:
    src/sbbs3/un_qwk.cpp 1.51 1.52 diff

    Log Message:
    Ignore (and delete) TOREADER.EXT (a QWKE additional metadata file) if it
    exists in a .QWK packet. Also, delete the other control/metadata files
    case-insensitively (just in case).
  458. deuce
    Thu Mar 15 2018 04:32 pm PDT

    Modified Files:
    exec/load/binkp.js 1.86 1.87 diff

    Log Message:
    Push an M_SKIP into the failed_sent_files() from the pending_ack array, not
    from the currently sending file, since the pending ack should always be there,
    but sending often won't be.  Also, log a warning when pending_ack isn't empty
    and we get an M_EOB.
  459. deuce
    Thu Mar 15 2018 03:39 pm PDT

    Modified Files:
    exec/load/binkp.js 1.85 1.86 diff

    Log Message:
    Add a new send_chunks() method which will deal with short send() calls.
    We can't rely on our send buffers being infinite anymore.
  460. deuce
    Thu Mar 15 2018 03:21 pm PDT

    Modified Files:
    exec/load/binkp.js 1.84 1.85 diff

    Log Message:
    Fix handling of timeouts vs. errors... they're not the same, so don't treat
    them that way.  Also, ensure there's a timeout on the second byte of the
    packet header since we toss out the first byte if the second byte times out
    (they should pretty much always be in the same packet, but why take the risk?)
  461. deuce
    Thu Mar 15 2018 03:07 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.214 1.215 diff

    Log Message:
    Add missing else in last commit.
  462. deuce
    Thu Mar 15 2018 03:06 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.213 1.214 diff

    Log Message:
    Have the return value of js_socket_recv() have something vaugely to do with
    the return value if recv() for non-TLS sockets.
  463. deuce
    Thu Mar 15 2018 02:56 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.212 1.213 diff

    Log Message:
    Fix ret/copied confusion in last commit.
  464. deuce
    Thu Mar 15 2018 02:42 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.696 1.697 diff

    Log Message:
    Fix unterminated string usage.
  465. deuce
    Thu Mar 15 2018 02:40 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.211 1.212 diff

    Log Message:
    Fix up js_recv_socket() some more... add explicit MSG_WAITALL support for
    TLS, use MSG_WAITALL for reading integers, add a time() based timeout,
    return as soon as any bytes are read (including zero), and generally
    behave more closely to how recv() itself behaves.
  466. deuce
    Thu Mar 15 2018 12:46 pm PDT

    Modified Files:
    exec/load/lightbar.js 1.34 1.35 diff

    Log Message:
    Fix typo in comment
  467. echicken
    Thu Mar 15 2018 12:22 pm PDT

    Modified Files:
    exec/load/http.js 1.40 1.41 diff

    Log Message:
    Ditch the 'self' stuff and give forEach a thisArg instead.
  468. echicken
    Thu Mar 15 2018 11:28 am PDT

    Modified Files:
    exec/load/http.js 1.39 1.40 diff

    Log Message:
    That 'this' was not the 'this' that your 'self' was looking for there then.
    May resolve the error reported by Bill McGarrity (this.extra_headers is
    undefined).
  469. deuce
    Thu Mar 15 2018 02:27 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.210 1.211 diff

    Log Message:
    The timeout to Socket.recv() is the *SECOND* argument, not a copy of the
    first one.
  470. deuce
    Thu Mar 15 2018 02:17 am PDT

    Modified Files:
    exec/load/binkp.js 1.83 1.84 diff

    Log Message:
    Don't use a separate OPT line for TLS, it seems to mess up
    Radius/4.010/21.01.2005,13:56(Final-Release)/Win32
  471. deuce
    Thu Mar 15 2018 01:59 am PDT

    Modified Files:
    exec/load/binkp.js 1.82 1.83 diff

    Log Message:
    Since we're supporting TLS now, use the sock.recv() timeout parameter instead
    of poll()ing for each byte.
  472. deuce
    Thu Mar 15 2018 01:52 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.209 1.210 diff

    Log Message:
    Re-enable recv timeouts for TLS sessions.  It was #ifdef'd out for some
    reason.
  473. deuce
    Thu Mar 15 2018 01:34 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.208 1.209 diff

    Log Message:
    Fix misuse of SSL_OPTIONS in last commit.
  474. deuce
    Thu Mar 15 2018 01:27 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.207 1.208 diff

    Log Message:
    For right now, don't verify server names in certificates.  This will need
    to be changed to something the individual clients can frob in the near
    future.
  475. deuce
    Thu Mar 15 2018 01:16 am PDT

    Modified Files:
    exec/load/binkp.js 1.81 1.82 diff

    Log Message:
    We need to send M_NUL "OPT TLS" before M_NUL "OPT CRYPT".
  476. deuce
    Thu Mar 15 2018 01:13 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.695 1.696 diff

    Log Message:
    We certainly can't re-use i for error return values when it's how many
    bytes have been sent!
  477. deuce
    Thu Mar 15 2018 12:58 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.694 1.695 diff

    Log Message:
    More hacks to work around a known bug in Cryptlib SSH...
    "Sometimes" the write timeout value is used for read timeouts.  Since we
    use a read timeout of zero, and a mutex, this can cause some serious delays
    in SSH processing.  As a workaround, we set the write timeout to zero.
    However, a flush failure has historically been fatal.
    
    So, we now change the write timeout to one second just before a flush, and
    have a flush timeout not be fatal anymore... we set it back to zero after
    the flush.
    
    The fiddling with the write timouts will be removed once the bug is fixed,
    but the flush timout not being fatal may stay forever... add some comments
    to remind us to remove the hack in the future.
  478. rswindell
    Thu Mar 15 2018 12:45 am PDT

    Modified Files:
    3rdp/win32.release/cryptlib/bin/cl32.dll 1.5 1.6 diff
    3rdp/win32.release/cryptlib/bin/cl32.lib 1.5 1.6 diff

    Log Message:
    Updated 3.4.4 with Deuce's latest patches.
  479. deuce
    Thu Mar 15 2018 12:28 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.693 1.694 diff

    Log Message:
    Connections without a "session" channel get treated as a dupe-free failed
    attempt.
  480. rswindell
    Thu Mar 15 2018 12:20 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.187 1.188 diff

    Log Message:
    When loginFailure() is called with a NULL username, always treat it as a
    "unique" login attempt (e.g. hack attempt).
  481. deuce
    Thu Mar 15 2018 12:05 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.692 1.693 diff

    Log Message:
    badlogin() can't be used for SSH sessions that are terminated early, this
    code merely introduced a 5 second delay in the Node 0 thread.
  482. deuce
    Wed Mar 14 2018 04:41 pm PDT

    Modified Files:
    exec/load/binkp.js 1.80 1.81 diff

    Log Message:
    Copy the comment about VER Internet Rex 2.29 Win32 (binkp/1.1) to where
    the challenge length is set and add a TODO comment there.
  483. deuce
    Wed Mar 14 2018 04:31 pm PDT

    Modified Files:
    exec/load/binkp.js 1.79 1.80 diff

    Log Message:
    Remove magical return type of auth callback.
  484. deuce
    Wed Mar 14 2018 04:30 pm PDT

    Modified Files:
    exec/binkit.js 1.58 1.59 diff

    Log Message:
    If there is at least one password mismatch, and there are zero password
    matches, send an M_ERR to the remote and leave the address list empty.
  485. deuce
    Wed Mar 14 2018 03:48 pm PDT

    Modified Files:
    exec/imapservice.js 1.55 1.56 diff

    Log Message:
    It seems many IMAP clients open multiple connections to the server, and
    expect the Seen flags to be coherent across them... support this by leaving
    the users IMAP status file open, and holding a lock on the first byte.
    
    We now need to flush changes to the status file more often, and we need
    to call file.flush() before unlocking.
  486. rswindell
    Wed Mar 14 2018 03:01 pm PDT

    Modified Files:
    exec/binkit.js 1.57 1.58 diff

    Log Message:
    Fix reserved logic of 'nomd5' option check:
    nomd5 means "plain-text passwords are okay" (AllowPlainPasswords=true)
  487. deuce
    Wed Mar 14 2018 11:23 am PDT

    Modified Files:
    exec/load/binkp.js 1.78 1.79 diff

    Log Message:
    Add TLS support to binkp.
    
    The *first* packet from the answering side *must* be an M_NUL "OPT TLS".
    If this is the case, the originating size responds with an M_NUL "OPT TLS".
    After this, the answering system performs a server TLS handshake, and the
    originating system performs a client TLS handshake.
    
    OPT CRYPT is not used in this case (ie: not crypt over TLS)
  488. rswindell
    Tue Mar 13 2018 11:04 pm PDT

    Modified Files:
    exec/postmsg.js 1.1 1.2 diff

    Log Message:
     Allow sub-code value of 'mail'
  489. rswindell
    Tue Mar 13 2018 10:55 pm PDT

    Modified Files:
    src/smblib/smbstr.c 1.28 1.29 diff

    Log Message:
    smb_netaddr_type() will now recognize an FTN-style address without a 
    "user@" prefix.
  490. rswindell
    Tue Mar 13 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.125 1.126 diff

    Log Message:
    Use smb_hfield_netaddr() to properly support FidoNet netmail via the 'n'
    (import netmail) command along with the '-n' option to set the recipient
    net address (and network type). Previously, only Internet or QWK netmail
    was supported.
  491. deuce
    Tue Mar 13 2018 10:39 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.691 1.692 diff

    Log Message:
    Actually, anything except failure to send credentials should count as a
    bad login.
  492. deuce
    Tue Mar 13 2018 10:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.690 1.691 diff

    Log Message:
    Toss invalid session connections into badlogin().
  493. deuce
    Tue Mar 13 2018 07:47 pm PDT

    Modified Files:
    exec/load/utf8_ascii.js 1.2 1.3 diff

    Log Message:
    Fix error in last commit.
  494. deuce
    Tue Mar 13 2018 07:25 pm PDT

    Modified Files:
    exec/imapservice.js 1.54 1.55 diff

    Log Message:
    Handle an uncommon error a bit better... maybe.
  495. deuce
    Tue Mar 13 2018 07:19 pm PDT

    Modified Files:
    web/templates/nightshade/footer.inc 1.1 1.2 diff
    web/templates/nightshade/main.inc 1.3 1.4 diff

    Log Message:
    Do the https:// thing to <img src="http://... stuff in nightshade too.
  496. deuce
    Tue Mar 13 2018 07:17 pm PDT

    Modified Files:
    web/templates/default/footer.inc 1.11 1.12 diff

    Log Message:
    Use the https:// link for the W3 image for that sweet green lock.
  497. rswindell
    Tue Mar 13 2018 03:13 pm PDT

    Modified Files:
    exec/binkit.js 1.56 1.57 diff

    Log Message:
    More detailed log output in inbound_auth_cb() to help debug why
    inbound Mystic sessions are failing (e.g. with Al@TRMB's BinkIt mailer).
  498. deuce
    Tue Mar 13 2018 10:29 am PDT

    Modified Files:
    exec/letsyncrypt.js 1.31 1.32 diff

    Log Message:
    ACMEv2 endpoint is now live.  See the wiki for how to automate TLS certificates
    with Synchronet.
  499. rswindell
    Mon Mar 12 2018 11:22 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.124 1.125 diff

    Log Message:
    Fix bug introduced in rev 1.119: When reading in the msgbase index
    (.sid file), don't divide the fread() results (it's already in number of
    records read). This could cause msgbase maintenance to not take place
    or corruption of a msg base.
  500. deuce
    Mon Mar 12 2018 11:16 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.206 1.207 diff

    Log Message:
    Don't log orderly shutdowns, even at debug level.  This is mostly because
    my jsexec includes debug output... and this is super-normal.
AuthorCommitsLatest
rswindell339Fri Aug 17 2018 08:50 am
echicken15Thu Aug 16 2018 02:10 pm
deuce125Thu Aug 09 2018 01:20 pm
nightfox14Tue Jul 17 2018 08:11 pm
ree7Mon Mar 19 2018 04:56 pm

Dynamically generated in 19505 milliseconds